Ghostkeeper
8ce016064f
Fix typo in documentation
...
The variable name is _dest_point, it seems.
Contributes to issue CURA-2229.
2016-11-28 17:05:51 +01:00
Ghostkeeper
4e16b4313f
Fix typo in assert message
...
Contributes to issue CURA-3008.
2016-11-28 16:55:24 +01:00
Ghostkeeper
5b493c17dc
Union first layer polygons for brim too
...
For skirt it does this union by taking the convex hull. For brim it did no such thing, so when polygons overlapped it would get complex polygons which didn't work out well.
Contributes to issue CURA-3017.
2016-11-28 16:37:28 +01:00
Tim Kuipers
4b45726ada
Revert "feat: PolygonPointer as distinct from PolygonRef (CURA-2602)"
...
This reverts commit a2a8604c72 .
2016-11-28 14:42:18 +01:00
Tim Kuipers
6653f5a557
Merge branch 'master' into feature_recursive_infill_code_review
2016-11-28 14:39:53 +01:00
Tim Kuipers
4da8c6d8e7
fix: no more aabb hit check fails (CURA-2992)
2016-11-28 14:35:13 +01:00
Tim Kuipers
c5ce425924
fix: no more use of deleted memory by optional (CURA-3008)
2016-11-28 14:34:45 +01:00
Tim Kuipers
c74d4f7550
Revert "feat: PolygonPointer as distinct from PolygonRef (CURA-3008)"
...
This reverts commit 20cd4275fc .
2016-11-28 13:43:03 +01:00
Tim Kuipers
19f093e0cc
safety: assert on optional::instance (CURA-3008)
2016-11-28 13:42:36 +01:00
Tim Kuipers
2a4cca0402
fix: use ClosestPolygonPoint::isValid where neccesary (CURA-3008)
2016-11-28 13:40:54 +01:00
Tim Kuipers
32804c102c
fix: use optional<PolygonRef> instead of PolygonPointer (CURA-3008)
2016-11-28 13:40:02 +01:00
Tim Kuipers
776f56fc37
lil fix: no more un/signed int comaprison
2016-11-28 12:18:13 +01:00
Tim Kuipers
866e911739
fix: make z_seam_pos settable per mesh (CURA-1461)
2016-11-25 16:43:31 +01:00
Tim Kuipers
a92cd23e62
safety: extra assert for too many nozzle switches in a layer
2016-11-25 16:10:10 +01:00
Tim Kuipers
4725001564
fix: remove printing_temperature_command if precooling goes further back (CURA-1932)
...
If the precooling command will precede the printing temeprature command to heat to the temp of the next layer, then don't use that temp;
we should already be cooling down, rather than heating toward the temp of the next layer.
2016-11-25 14:00:26 +01:00
Tim Kuipers
a18595877f
safety: extra assert on temp in NozzleTempInsert (CURA-1932)
2016-11-25 14:00:26 +01:00
Tim Kuipers
40e7c450d5
fix: getCoolDownPointAfterWarmUp outer_temp was switched (CURA-1932)
...
This caused the timing of the precool command to be off
2016-11-25 14:00:26 +01:00
Tim Kuipers
13a0b11d68
fix: don't use material_print_temperature_layer_0 if it's zero (CURA-1932)
2016-11-25 14:00:26 +01:00
Ghostkeeper
4fc69f608a
Fix max extruder height if only using bed adhesion
...
If an extruder only prints bed adhesion, the maximum extruder height for that extruder is now correct.
Contributes to issue CURA-2993.
2016-11-25 11:21:59 +01:00
Ghostkeeper
deb577d559
Make extruder numbers const and unsigned
...
This is in line with the first one, and more correct.
Contributes to issue CURA-2993.
2016-11-25 11:17:45 +01:00
Ghostkeeper
c8161da3eb
Remove spaces within brackets
...
As per our code style.
Contributes to issue CURA-2993.
2016-11-25 11:16:30 +01:00
Ghostkeeper
87733834d1
Expand documentation for computePrintHeightStatistics
...
Should make it more overseeable.
Contributes to issue CURA-2993.
2016-11-25 11:08:29 +01:00
Ghostkeeper
b9aeea425f
Correct documentation of computePrintHeightStatistics
...
It's initialised, not uninitialised (or unitialised).
Contributes to issue CURA-2993.
2016-11-25 11:01:51 +01:00
Tim Kuipers
44b3039db6
optimization: use already computed ClosestPolygonPoint for ensureInsideOrOutside during combing crossing calculation (CURA-2229)
2016-11-24 15:09:41 +01:00
Tim Kuipers
6476270cf6
fix: combing start crossing inside location was sometimes on the destination part, rather than the starting part (CURA-2229)
2016-11-24 13:56:57 +01:00
Ghostkeeper
e532f3ddda
Merge branch 'feature_anti_support'
2016-11-22 16:36:52 +01:00
Tim Kuipers
7aaab151e7
fix: better handling of edge cases for Preheat::getCoolDownPointAfterWarmUp and getWarmUpPointAfterCoolDown (CURA-3006)
2016-11-22 14:54:59 +01:00
Tim Kuipers
0353433919
fix: also ensure prime after first layer of raft (CURA-3006)
2016-11-22 14:52:21 +01:00
Tim Kuipers
40a6c495c7
refactor: move code from FffGcodeWriter::processLayer into new FffGcodeWriter::ensureAllExtrudersArePrimed (CURA-3006)
2016-11-22 14:51:48 +01:00
Ghostkeeper
cfa6758911
Merge branch 'fix_support_order'
...
Conflicts:
src/FffGcodeWriter.cpp
src/PrimeTower.cpp
2016-11-22 13:03:38 +01:00
Tim Kuipers
f6b29b1d8a
Merge branch 'feature_anti_support' of github.com:Ultimaker/CuraEngine into feature_anti_support
2016-11-22 10:21:44 +01:00
Ghostkeeper
bd79a8468e
Merge branch 'feature_hollow_prime_tower'
2016-11-22 09:19:16 +01:00
Tim Kuipers
83a1a09772
fix: merge fix for PathOrderOptimizer in FffGcodeWriter::processSkin (CURA-1461)
2016-11-21 18:48:10 +01:00
Tim Kuipers
2c425421ec
Merge branch 'master' into feature_z_seam_location
2016-11-21 18:45:10 +01:00
Ghostkeeper
35dcc6906f
Merge branch 'feature_precool'
2016-11-21 17:35:40 +01:00
Tim Kuipers
db7bc279ee
fix: removeEmptyFirstLayers can still remove even when support was generated (but removed by anti support meshes (CURA-2077)
2016-11-21 16:50:26 +01:00
Tim Kuipers
a7ea623266
fix: removeEmptyFirstLayers can still remove even when support was generated (but removed by anti support meshes (CURA-2077)
2016-11-21 16:34:55 +01:00
Tim Kuipers
724589c13a
fix: support towers went all the way to the bed (CURA-2077)
2016-11-21 16:31:52 +01:00
Tim Kuipers
db1fa098ad
Merge branch 'master' into feature_anti_support
2016-11-21 16:12:57 +01:00
Tim Kuipers
be99db30c0
fix: combing referenced element zero of a polygons (CURA-3008)
2016-11-21 15:54:07 +01:00
Tim Kuipers
9456592dd7
fix: use PolygonPointer in ClosestPolygonPoint (CURA-3008)
...
sometimes functions cannot return a ClosestPolygonPoint, or we start with an empty one untill we find any point
cherry-picked from 4634338c7d
2016-11-21 15:45:27 +01:00
Tim Kuipers
20cd4275fc
feat: PolygonPointer as distinct from PolygonRef (CURA-3008)
...
It was a bad idea to change PolygonRef into PolygonPointer, because then we'd have to check whether it is a nullptr all over the engine...
cherry-picked from a2a8604c72
2016-11-21 15:38:12 +01:00
Tim Kuipers
67697d5258
fix: handle modulo operations for negative layer numbers (CURA-2789)
2016-11-21 14:18:39 +01:00
Tim Kuipers
7d8e4de7ba
fix: prime tower didn't get added in filler layers (CURA-2789)
...
PrimeTower always received layer_nr=0 for those layers, so i had to propagate the negative layer numbers to addSupportToGcode and to PrimeTower
2016-11-21 14:17:32 +01:00
Tim Kuipers
2486120a38
fix: don't send polygons over command socket during planning phase (CURA-2789)
...
The polygons of the prime tower were also sent on the wrong layer / height, causing it to be visualized within raft layers
2016-11-21 14:13:56 +01:00
Tim Kuipers
43c8f2a913
fix: print prime tower directly after platform adhesion on layer 0 (CURA-2789)
2016-11-21 13:19:25 +01:00
Tim Kuipers
baf6410a1e
fix: PolygonUtils::findClosest failed when only the first polygon was empty (CURA-2602)
2016-11-18 16:33:28 +01:00
Tim Kuipers
4634338c7d
fix: use PolygonPointer in ClosestPolygonPoint (CURA-2602)
...
sometimes functions cannot return a ClosestPolygonPoint, or we start with an empty one untill we find any point
2016-11-18 16:32:56 +01:00
Tim Kuipers
a2a8604c72
feat: PolygonPointer as distinct from PolygonRef (CURA-2602)
...
It was a bad idea to change PolygonRef into PolygonPointer, because then we'd have to check whether it is a nullptr all over the engine...
2016-11-18 16:30:34 +01:00
Ghostkeeper
dd8b57b666
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-11-18 15:51:10 +01:00