From 1da431c4887c4b4c5a3adac2d8862228d2645b05 Mon Sep 17 00:00:00 2001 From: AntonMu Date: Sun, 11 Oct 2020 13:58:48 -0700 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 88f3389..a157b7f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,7 +12,9 @@ Contributions are highly appreciated. If you'd like to make a contribution, plea * Rebase off the upstream/master branch to avoid merge conflicts. - * Test your feature on as many different system configurations as possible. The three major operating systems are Windows, Linux and macOS. For each, try to test the feature with and without using a GPU. + * Test your feature on as many different system configurations as possible. The three major operating systems are Windows, Linux and macOS. For each, try to test the feature with and without using a GPU, + + * Test *all* existing feature with your new code (your change should not break existing features). 1. Create a pull request to the upstream/master branch. The pull request must include: @@ -20,6 +22,7 @@ Contributions are highly appreciated. If you'd like to make a contribution, plea * A minimal test example that uses the new feature, + * A list of tested system configurations (OS and GPU model if used). 1. Once the PR is created, wait for feedback and incorporate suggested changes.