From 966360e02266630f69a1818db2ad2ed0db8f9989 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Tue, 9 Dec 2014 13:09:36 -0700 Subject: [PATCH] Set ::visible to false on panels when they are destroyed --- spec/panel-spec.coffee | 4 ++++ src/panel.coffee | 1 + 2 files changed, 5 insertions(+) diff --git a/spec/panel-spec.coffee b/spec/panel-spec.coffee index fb5945a7a..38ecd4809 100644 --- a/spec/panel-spec.coffee +++ b/spec/panel-spec.coffee @@ -21,3 +21,7 @@ describe "Panel", -> panel.show() expect(panel.isVisible()).toBe true expect(spy).toHaveBeenCalledWith(true) + + panel.destroy() + expect(panel.isVisible()).toBe false + expect(spy).toHaveBeenCalledWith(false) diff --git a/src/panel.coffee b/src/panel.coffee index a06199205..fd196cb8b 100644 --- a/src/panel.coffee +++ b/src/panel.coffee @@ -21,6 +21,7 @@ class Panel # Public: Destroy and remove this panel from the UI. destroy: -> + @hide() @emitter.emit 'did-destroy', this @emitter.dispose()