From a4976c32aeb0ffcad2df7b1ef0811b2bf6231243 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Tue, 3 Feb 2015 14:52:59 -0800 Subject: [PATCH] Remove release notes from event payload The release notes are provided by Squirrel on Mac but not by Squirrel for Windows and the release notes package pulls them down manually anyway so this field is no longer needed. Checking for the presence of the release notes previously was preventing the event from firing on Windows which would cause old release notes to show in the package. Closes #3757 --- spec/atom-spec.coffee | 3 +-- src/browser/auto-update-manager.coffee | 6 +++--- src/window-event-handler.coffee | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/spec/atom-spec.coffee b/spec/atom-spec.coffee index 6cad8c52e..2c1a40afc 100644 --- a/spec/atom-spec.coffee +++ b/spec/atom-spec.coffee @@ -47,9 +47,8 @@ describe "the `atom` global", -> updateAvailableHandler.callCount > 0 runs -> - {releaseVersion, releaseNotes} = updateAvailableHandler.mostRecentCall.args[0] + {releaseVersion} = updateAvailableHandler.mostRecentCall.args[0] expect(releaseVersion).toBe 'version' - expect(releaseNotes).toBe 'notes' describe "loading default config", -> it 'loads the default core config', -> diff --git a/src/browser/auto-update-manager.coffee b/src/browser/auto-update-manager.coffee index f1f782d10..dfbdacfc4 100644 --- a/src/browser/auto-update-manager.coffee +++ b/src/browser/auto-update-manager.coffee @@ -47,7 +47,7 @@ class AutoUpdateManager @setState(ErrorState) console.error "Error Downloading Update: #{message}" - autoUpdater.on 'update-downloaded', (event, @releaseNotes, @releaseVersion) => + autoUpdater.on 'update-downloaded', (event, releaseNotes, @releaseVersion) => @setState(UpdateAvailableState) @emitUpdateAvailableEvent(@getWindows()...) @@ -61,9 +61,9 @@ class AutoUpdateManager @setState(UnsupportedState) emitUpdateAvailableEvent: (windows...) -> - return unless @releaseVersion? and @releaseNotes + return unless @releaseVersion? for atomWindow in windows - atomWindow.sendMessage('update-available', {@releaseVersion, @releaseNotes}) + atomWindow.sendMessage('update-available', {@releaseVersion}) setState: (state) -> return if @state is state diff --git a/src/window-event-handler.coffee b/src/window-event-handler.coffee index 708dcc555..37c04670b 100644 --- a/src/window-event-handler.coffee +++ b/src/window-event-handler.coffee @@ -31,8 +31,8 @@ class WindowEventHandler atom.updateAvailable(detail) # FIXME: Remove this when deprecations are removed - {releaseVersion, releaseNotes} = detail - detail = [releaseVersion, releaseNotes] + {releaseVersion} = detail + detail = [releaseVersion] if workspaceElement = atom.views.getView(atom.workspace) atom.commands.dispatch workspaceElement, "window:update-available", detail