From Thiago:
This patch is to solve the problem in import/export bookmarks. They aren't
exported correctly and also not imported
correctly. Now when the bookmarks are exported the character " are escaped to
" and when they are imported,
they are unescaped.
BUG=7505
TEST=Try importing/exporting bookmarks, make sure nothing is broken.
Review URL: http://codereview.chromium.org/126222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19654 0039d316-1c4b-4281-b951-d872f2087c98
Now css files are opened inside browser instead of download.
Also - making lint happy on the mime_util.cc
BUG=7192
R=abarth
TEST=MimeTypeTests.MimeTypeTests
Patch by Yuri Gorobets.
Original review URL: http://codereview.chromium.org/125005
Review URL: http://codereview.chromium.org/125058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18306 0039d316-1c4b-4281-b951-d872f2087c98
The approach is borrowed from render_process_host's kMaxRenderersByRamTier.
The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.
Patch by Joel Stanley.
BUG=12028
Review URL: http://codereview.chromium.org/115452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17318 0039d316-1c4b-4281-b951-d872f2087c98
The approach is borrowed from render_process_host's kMaxRenderersByRamTier.
The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.
Patch by Joel Stanley.
BUG=12028
Review URL: http://codereview.chromium.org/115452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17183 0039d316-1c4b-4281-b951-d872f2087c98
vista without hebrew support
the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093)
the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least
BUG=12093
TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl".
Review URL: http://codereview.chromium.org/115849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98
pages into an HTML label tag, to make it clickable and more friendly to screen
readers.
TEST= Navigate to ianfette.org and click on the text "I understand that visiting
this site may harm my computer". Checkbox should toggle.
BUG= 12714
Original patch by chromium@willhirsch.co.uk
Original review: http://codereview.chromium.org/115815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17050 0039d316-1c4b-4281-b951-d872f2087c98
After this patch DirectoryWatcher when asked for recursive watch will scan the
subtree and add inotify watches for each subfolder, but further changes to the
tree structure won't trigger adding/removing watches.
Support for really recursive watches is planned. This is just to divide the
work, because the task is not easy.
Based on patch by Janwar Dinata <j.dinata@gmail.com> reviewed at http://codereview.chromium.org/92151http://crbug.com/8968
Review URL: http://codereview.chromium.org/115229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16070 0039d316-1c4b-4281-b951-d872f2087c98
Patch contributed by Robert Sesek <rsesek@bluestatic.org>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15640 0039d316-1c4b-4281-b951-d872f2087c98
does resolve the location bar not being focused bug on the mac build.
Patch by Sean Bryant (sean@cyberwang.net).
BUG=9419
Review URL: http://codereview.chromium.org/100140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14939 0039d316-1c4b-4281-b951-d872f2087c98
cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t)
Review URL: http://codereview.chromium.org/93078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14482 0039d316-1c4b-4281-b951-d872f2087c98
This happened because when I re-created the changelist I ran gcl from the src\Chrome directory as opposed to running it from the src directory.
TBR=evanm
Review URL: http://codereview.chromium.org/42191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11678 0039d316-1c4b-4281-b951-d872f2087c98
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.
For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.
Review URL: http://codereview.chromium.org/43109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set.
Patch contributed by Paul Robinson <paulRobinson85@googlemail.com>
BUG=8049
Review URL: http://codereview.chromium.org/43016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11465 0039d316-1c4b-4281-b951-d872f2087c98
Original patch by Kim Christensen (see http://codereview.chromium.org/28150 ), r=me,brettw, tweaked slightly.
BUG=7227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10558 0039d316-1c4b-4281-b951-d872f2087c98
in the password manager. This method is called whenever the
password manager window is opened and disables the button if
there are no passwords stored. It is also called when all of
the stored passwords are removed.
BUG=7228
Original patch by Kyle Nahrgang <kpn24@drexel.edu> in
http://codereview.chromium.org/28063/show
Review URL: http://codereview.chromium.org/27191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10435 0039d316-1c4b-4281-b951-d872f2087c98
Patch contributed by Raman Tenneti
see also patch number 21038
Review URL: http://codereview.chromium.org/27034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10330 0039d316-1c4b-4281-b951-d872f2087c98
(Also, if this file is in historical order, it ought to be this way.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9851 0039d316-1c4b-4281-b951-d872f2087c98
of the disk cache, rather than in the profile directory. The command
line switch overrides the cache location regardless the chosen
profile.
In this implementation, the supplied directory name must should not
contain spaces.
BUG=6688
submitted by bekkra.
original code review http://codereview.chromium.org/21094/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9375 0039d316-1c4b-4281-b951-d872f2087c98
TestAddCookieOnManyHosts would fail due to SetCookie() returning false when
true was expected. Cause of the failed cookie insert was due to httponly
cookie being used in the test. Removed httponly from cookie.
Patch by jroesslein@gmail.com
R=darin
-This line, and those below, will be ignored--
M AUTHORS
M net/base/cookie_monster_perftest.cc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7158 0039d316-1c4b-4281-b951-d872f2087c98
a variable called SYSTEM_LIBS, consisting of a comma-separated
list of system libraries. So far, bzip2, libpng, libjpeg,
libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized.
BUG=4321
Review URL: http://codereview.chromium.org/10626
Patch from Fabien Tassin <fta@sofaraway.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5320 0039d316-1c4b-4281-b951-d872f2087c98
http://codereview.chromium.org/6577/show
ports listen_socket and telnet_server to POSIX
I had to make some changes to get this to work on Mac and to fix a few regressions it caused in Windows, so please take a fresh look at this diff Dan.
Ibrar, please take a look at the changes from your patch to mine (you may need to diff listen_socket_unittest.h with listen_socket_unittest.cc manually since I moved a bunch of code here). Some were bugs that I should have caught in review, some were bugs that only got tickled on the Mac, others were just cleanup. Comments welcome.
Review URL: http://codereview.chromium.org/9260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5153 0039d316-1c4b-4281-b951-d872f2087c98
I have only compiled this on linux and tested it there but that shouldn't be a problem as the file does seem to be linux-specific.
Review URL: http://codereview.chromium.org/9685
Patch from Craig Schlenter.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4992 0039d316-1c4b-4281-b951-d872f2087c98
contributed by Rob Stradling <rob@comodo.com> of
Comodo CA Limited.
R=ian
BUG=2170
Review URL: http://codereview.chromium.org/3173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3242 0039d316-1c4b-4281-b951-d872f2087c98
You can combine this with --app= to launch an app in Chrome that has no effect
on the user's profile.
Note that this is not the same thing as launching chrome.exe
--user-data-dir=/dev/null, which would give you an completely empty profile
instead of loading the user's profile as read-only.
BUG=1790,2012
Patch by Yarin Kaul <yarin.kaul@gmail.com>
Review URL: http://codereview.chromium.org/6584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3013 0039d316-1c4b-4281-b951-d872f2087c98
Patch from Gaetano Mendola <mendola@gmail.com>
Original review: http://codereview.chromium.org/4273
I added some additions on my part and two unit test fix due to the added DCHECK. Reduced atl header inclusion.
Review URL: http://codereview.chromium.org/5009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2730 0039d316-1c4b-4281-b951-d872f2087c98
OIDs and test URLs were provided by Masahiro Yado
<yado.masa@gmail.com>.
R=maruel
BUG=1622
Review URL: http://codereview.chromium.org/3123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2363 0039d316-1c4b-4281-b951-d872f2087c98
The reason that the allocators are not conformant is that any allocator, say, template<typename T> struct Alloc; must have a constructor of the following form:
template<typename U> Alloc(const Alloc<U>& other)
to allow construction of an Alloc<T> from an Alloc<U>. The constructors cannot be explicit, because they're (essentially) copy constructors, and so are not called explicitly.
StackAllocator has no converting copy constructor at all, and PrivateHookAllocator's is declared explicit, preventing it from being usable.
Without the StackAllocator constructor, StackVectors fail (due to the std::vector member, base\stack_container.h(216)).
Patch by Peter Bright <drpizza@quiscalusmexicanus.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2175 0039d316-1c4b-4281-b951-d872f2087c98
1. Check whether uloc_getdata returns the default locale because an invalid or unsupported (not a part of ICU data file we use) locale is passed.
2. Replace 'se' with 'sv' in IDNToUnicode test and change the corresponding
test result to true. U+00C4 IS used in Swedish, but the result was set to
false because the test results were machine generated with the same
typo ('se' in place of 'sv') under en_US.UTF-8 locale on Linux and
we ran this test only on Windows with en_US locale.
1st part of patch is by Matthias Reitinger <reimarvin@gmail.com>
BUG=1153
TEST=NetUtilTest.IDNToUnicode passes in various locales, C, en_US, en_US.utf8,
ja_JP.utf8, sv_SE.utf8, hi_IN.utf8, ru_RU.utf8, fr_CA
Review URL: http://codereview.chromium.org/1655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2052 0039d316-1c4b-4281-b951-d872f2087c98
Moves the New Tab, Window, Incognito Window menu items from the Page menu to the Wrench menu.
Code review: http://codereview.chromium.org/1826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1903 0039d316-1c4b-4281-b951-d872f2087c98
related to non-virtual destructors in classes having virtual methods
BUG=1859
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1860 0039d316-1c4b-4281-b951-d872f2087c98
This patches allows menu items in PopUpMenus to be clicked with the right mouse
button.
menu.cc controls the web content popup menus, and some others
chrome_menu{.cc,.h} controls popup menu on the chrome, for example right
clicking on a tab.
BUG=718
TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1838 0039d316-1c4b-4281-b951-d872f2087c98
find v8.h which is required for many of the files in src/webkit/port/
bindings/v8/.
BUG=711
AUTHOR=Alex Scheele
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1689 0039d316-1c4b-4281-b951-d872f2087c98
sky@chromium.org