TEST=Try committing when the tree is closed to see.
BUG=none
Review URL: http://codereview.chromium.org/119437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18125 0039d316-1c4b-4281-b951-d872f2087c98
Also fix gcl presubmit tree status check when the change hasn't been uploaded nor gcl try'ed.
Remove PRESUBMIT_unittest.py since it's not useful anymore.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18124 0039d316-1c4b-4281-b951-d872f2087c98
It acts as an advisory presubmit check for now since the try server isn't that stable.
BUG=none
TEST=gcl commit warns the user when a pending change hasn't passed the try job.
Review URL: http://codereview.chromium.org/119295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17870 0039d316-1c4b-4281-b951-d872f2087c98
BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/115261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15906 0039d316-1c4b-4281-b951-d872f2087c98
and paths we'll use in gyp-generated files.
Review URL: http://codereview.chromium.org/56158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12975 0039d316-1c4b-4281-b951-d872f2087c98
This is a follow up to Issue 43098.
Review URL: http://codereview.chromium.org/42086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11619 0039d316-1c4b-4281-b951-d872f2087c98
This makes sure that:
- Files end in a newline character, this is otherwise a fatal error with GCC.
- Files end in only one newline character, and not a bunch of whitespace.
Review URL: http://codereview.chromium.org/43017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11330 0039d316-1c4b-4281-b951-d872f2087c98
- Remove the invalid import os statement (PRESUBMIT.py shouldn't import anything).
- Add excluded paths. Mostly third parties.
- Increase what is considered a source file.
- Don't check for DO NOT SUBMIT on upload.
Review URL: http://codereview.chromium.org/28219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10983 0039d316-1c4b-4281-b951-d872f2087c98
At present this checks the following:
- No tabs in source files
- The words "DO-NOT-SUBMIT" (without the dashes) do not appear in the CL
description or in files in the change
- No CRLF in source files (.cc, .h, .mm, .py)
Limitations:
- The general limitations of the current presubmit API implementation
apply. One of these is that gcl only walks up to the checkout root
searching for presubmit files, so if you've mapped stuff into your
client using DEPS, it will only walk up to where the root of that
mapping.
Patch contributed by Jói.
Review: http://codereview.chromium.org/20474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10015 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org