Arquivos
chromium/base/waitable_event_watcher_unittest.cc
agl@chromium.org 5f2e588499 POSIX: allow WaitableEvents to be deleted while watching them.
On Windows, one can close a HANDLE which is currently being waited on. The MSDN
documentation says that the resulting behaviour is 'undefined', but it doesn't
crash. Currently, on POSIX, one couldn't use WaitableEventWatcher to watch an
event which gets deleted. This mismatch has bitten us several times now.

This patch allows WaitableEvents to be deleted while a WaitableEventWatcher is
still watching them. It applies only to watchers, the usual Wait() and
WaitMany() calls still require that all their target be valid until the end of
the call.

http://crbug.com/8809

Review URL: http://codereview.chromium.org/53026


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12576 0039d316-1c4b-4281-b951-d872f2087c98
2009-03-26 18:28:19 +00:00

159 linhas
4.2 KiB
C++

// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/message_loop.h"
#include "base/platform_thread.h"
#include "base/waitable_event.h"
#include "base/waitable_event_watcher.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::WaitableEvent;
using base::WaitableEventWatcher;
namespace {
class QuitDelegate : public WaitableEventWatcher::Delegate {
public:
virtual void OnWaitableEventSignaled(WaitableEvent* event) {
MessageLoop::current()->Quit();
}
};
class DecrementCountDelegate : public WaitableEventWatcher::Delegate {
public:
DecrementCountDelegate(int* counter) : counter_(counter) {
}
virtual void OnWaitableEventSignaled(WaitableEvent* object) {
--(*counter_);
}
private:
int* counter_;
};
void RunTest_BasicSignal(MessageLoop::Type message_loop_type) {
MessageLoop message_loop(message_loop_type);
// A manual-reset event that is not yet signaled.
WaitableEvent event(true, false);
WaitableEventWatcher watcher;
EXPECT_EQ(NULL, watcher.GetWatchedEvent());
QuitDelegate delegate;
watcher.StartWatching(&event, &delegate);
EXPECT_EQ(&event, watcher.GetWatchedEvent());
event.Signal();
MessageLoop::current()->Run();
EXPECT_EQ(NULL, watcher.GetWatchedEvent());
}
void RunTest_BasicCancel(MessageLoop::Type message_loop_type) {
MessageLoop message_loop(message_loop_type);
// A manual-reset event that is not yet signaled.
WaitableEvent event(true, false);
WaitableEventWatcher watcher;
QuitDelegate delegate;
watcher.StartWatching(&event, &delegate);
watcher.StopWatching();
}
void RunTest_CancelAfterSet(MessageLoop::Type message_loop_type) {
MessageLoop message_loop(message_loop_type);
// A manual-reset event that is not yet signaled.
WaitableEvent event(true, false);
WaitableEventWatcher watcher;
int counter = 1;
DecrementCountDelegate delegate(&counter);
watcher.StartWatching(&event, &delegate);
event.Signal();
// Let the background thread do its business
PlatformThread::Sleep(30);
watcher.StopWatching();
MessageLoop::current()->RunAllPending();
// Our delegate should not have fired.
EXPECT_EQ(1, counter);
}
void RunTest_OutlivesMessageLoop(MessageLoop::Type message_loop_type) {
// Simulate a MessageLoop that dies before an WaitableEventWatcher. This
// ordinarily doesn't happen when people use the Thread class, but it can
// happen when people use the Singleton pattern or atexit.
WaitableEvent event(true, false);
{
WaitableEventWatcher watcher;
{
MessageLoop message_loop(message_loop_type);
QuitDelegate delegate;
watcher.StartWatching(&event, &delegate);
}
}
}
void RunTest_DeleteUnder(MessageLoop::Type message_loop_type) {
// Delete the WaitableEvent out from under the Watcher. This is explictly
// allowed by the interface.
MessageLoop message_loop(message_loop_type);
{
WaitableEventWatcher watcher;
WaitableEvent* event = new WaitableEvent(false, false);
QuitDelegate delegate;
watcher.StartWatching(event, &delegate);
delete event;
}
}
} // namespace
//-----------------------------------------------------------------------------
TEST(WaitableEventWatcherTest, BasicSignal) {
RunTest_BasicSignal(MessageLoop::TYPE_DEFAULT);
RunTest_BasicSignal(MessageLoop::TYPE_IO);
RunTest_BasicSignal(MessageLoop::TYPE_UI);
}
TEST(WaitableEventWatcherTest, BasicCancel) {
RunTest_BasicCancel(MessageLoop::TYPE_DEFAULT);
RunTest_BasicCancel(MessageLoop::TYPE_IO);
RunTest_BasicCancel(MessageLoop::TYPE_UI);
}
TEST(WaitableEventWatcherTest, CancelAfterSet) {
RunTest_CancelAfterSet(MessageLoop::TYPE_DEFAULT);
RunTest_CancelAfterSet(MessageLoop::TYPE_IO);
RunTest_CancelAfterSet(MessageLoop::TYPE_UI);
}
TEST(WaitableEventWatcherTest, OutlivesMessageLoop) {
RunTest_OutlivesMessageLoop(MessageLoop::TYPE_DEFAULT);
RunTest_OutlivesMessageLoop(MessageLoop::TYPE_IO);
RunTest_OutlivesMessageLoop(MessageLoop::TYPE_UI);
}
TEST(WaitableEventWatcherTest, DeleteUnder) {
RunTest_DeleteUnder(MessageLoop::TYPE_DEFAULT);
RunTest_DeleteUnder(MessageLoop::TYPE_IO);
RunTest_DeleteUnder(MessageLoop::TYPE_UI);
}