Arquivos
hbono@chromium.org 5c94ba594a A quick fix for Issue 15852.
After a discussion in <http://crbug.com/15852>, I noticed I wrongly understood the Dvorak and European keyboards. We should not use US layout for handling shortcut keys. To fix this problem, this change uses |event->hardware_keycode| only when WebKit::windowsKeyCodeForKeyEvent() returns 0. When we use the Hebrew (or Russian) layout, |event->keyval| becomes GDK_hebrew_* (or GDK_Cyrillic_*) and this function returns 0.)

BUG=15852 "Incorrect keycode with dvorak keyboard layout on Linux"
TEST=Open <http://www.asquare.net/javascript/tests/KeyCode.html>, press 'x' of a dvorak keyboard, and its keyDown.keyCode becomes 88.
Review URL: http://codereview.chromium.org/149248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20369 0039d316-1c4b-4281-b951-d872f2087c98
2009-07-10 08:32:28 +00:00
..
2009-07-10 08:32:28 +00:00
2009-05-10 20:30:41 +00:00

This directory contains the Chromium WebKit API.  It will eventually be
upstreamed to WebKit/WebKit/chromium in svn.webkit.org.


OVERVIEW

  The Chromium WebKit API provides a stable interface to WebCore without
  revealing any of the WebCore or WTF types to the consumer.

  The 'public' directory contains the API headers, and the 'src' directory
  contains the API implementation.  The API is intended to be used either as a
  shared or static library.


COMPATIBILITY

  No attempt is made to support runtime compatibility in a shared library
  build.  Instead, the API is intended to support backwards compatibility at
  build time.  C++ symbols are allowed in other words.


CODING STYLE

  The code in this directory should adhere to the WebKit Coding Style
  Guidelines:  http://webkit.org/coding/coding-style.html


DEFINES

  WEBKIT_IMPLEMENTATION is defined when building the 'src' directory.
  Consumers should not define this macro.

  WEBKIT_DLL is defined when building as a shared library.  This should be
  defined when building the 'src' directory, and it should also be defined by
  the consumer to ensure proper linkage to the shared library.


BASIC TYPES

  Use of STL is prohibited except in cases where it would be allowed in
  WebCore.  This includes non-allocating uses: algorithms, numeric limits, etc.
  WTF container classes should be used in the implementation of this API.

  The API includes some usage of WebCore types when WEBKIT_IMPLEMENTATION is
  defined.  This is only done for the convenience to the implementation, and
  should not be considered part of the Chromium WebKit API.  Similarly, STL
  types are assumed when WEBKIT_IMPLEMENTATION is not defined, which is done
  for the convenience of the consumer.