From 0dd21ce600328626c3e5dce3846827db2f34567b Mon Sep 17 00:00:00 2001 From: bsimmers Date: Thu, 11 Apr 2013 17:28:16 -0700 Subject: [PATCH] Disabled non-refcounted locals optimization It's still flaky, and I'm hitting asserts related to it on trunk right now. --- hphp/compiler/analysis/emitter.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hphp/compiler/analysis/emitter.cpp b/hphp/compiler/analysis/emitter.cpp index 56f30bd49..39cc4ad65 100644 --- a/hphp/compiler/analysis/emitter.cpp +++ b/hphp/compiler/analysis/emitter.cpp @@ -2226,11 +2226,12 @@ bool EmitterVisitor::visitImpl(ConstructPtr node) { false, 0, 0); } - for (auto& l : r->nonRefcountedLocals()) { + // XXX: disabled until static analysis is more reliable: t2225399 + /*for (auto& l : r->nonRefcountedLocals()) { auto v = m_curFunc->lookupVarId(StringData::GetStaticString(l)); m_metaInfo.add(m_ue.bcPos(), Unit::MetaInfo::NonRefCounted, false, 0, v); - } + }*/ if (retV) { e.RetV(); } else {