From 3a4defc30bc5031d8eb3ff56636966d99e07133d Mon Sep 17 00:00:00 2001
From: Sara Golemon <sgolemon@fb.com>
Date: Sat, 15 Jun 2013 19:20:45 -0700
Subject: [PATCH] Throw an exception when an unknown flag is specified

Because if we don't know, we can't fix it!
---
 hphp/tools/gen-ext-hhvm/idl.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hphp/tools/gen-ext-hhvm/idl.cpp b/hphp/tools/gen-ext-hhvm/idl.cpp
index 588908b89..42482202d 100644
--- a/hphp/tools/gen-ext-hhvm/idl.cpp
+++ b/hphp/tools/gen-ext-hhvm/idl.cpp
@@ -193,7 +193,9 @@ static unsigned long parseFlags(const folly::dynamic &flags) {
   for (auto &flag : flags) {
     auto f = g_flagsMap.find(flag.asString());
     if (f == g_flagsMap.end()) {
-      continue;
+      throw std::logic_error(
+        folly::format("Unknown flag '{0}' specified", flag.asString()).str()
+      );
     }
     ret |= f->second;
   }