From a8749c16183b183dad390fb9a0df8dfb4718d1e9 Mon Sep 17 00:00:00 2001 From: Herman Venter Date: Fri, 28 Jun 2013 17:05:32 -0700 Subject: [PATCH] Remove useless change to test/run Experimental attempt to make sure test output does not contain non ASCII characters is actually completely useless because it sanitizes an integer. Remove it. --- hphp/runtime/debugger/break_point.cpp | 1 - hphp/test/run | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hphp/runtime/debugger/break_point.cpp b/hphp/runtime/debugger/break_point.cpp index de4ad87be..6a901b5a4 100644 --- a/hphp/runtime/debugger/break_point.cpp +++ b/hphp/runtime/debugger/break_point.cpp @@ -13,7 +13,6 @@ | license@php.net so we can mail you a copy immediately. | +----------------------------------------------------------------------+ */ -//force unit test run #include "hphp/runtime/debugger/break_point.h" #include "hphp/runtime/debugger/debugger.h" diff --git a/hphp/test/run b/hphp/test/run index 122d8ba9b..b453fa463 100755 --- a/hphp/test/run +++ b/hphp/test/run @@ -572,7 +572,7 @@ function run_test($options, $test) { # a poor man's aide for debugging shell_exec("diff --text -u $test.expectf $test.out > $test.diff 2>&1"); - return quoted_printable_encode(preg_match("/^$wanted_re\$/s", $output)); + return preg_match("/^$wanted_re\$/s", $output); } else if (file_exists("$test.expectregex")) { $wanted_re = file_get_contents("$test.expectregex"); @@ -580,7 +580,7 @@ function run_test($options, $test) { # a poor man's aide for debugging shell_exec("diff --text -u $test.expectregex $test.out > $test.diff 2>&1"); - return quoted_printable_encode(preg_match("/^$wanted_re\$/s", $output)); + return preg_match("/^$wanted_re\$/s", $output); } }