Convert CREATE_{VECTOR,MAP} from macros to variadic templates

Reviewed By: @andralex

Differential Revision: D970885

hphp/runtime/vm/bytecode.cpp

@@ -6358,6 +6358,7 @@ lookupStatic(StringData* name,
   if (val == nullptr) {
     TypedValue tv;
     tvWriteUninit(&tv);
+    // TODO(#2836647): needs to check return value
     map->set(name, tvAsCVarRef(&tv), false);
     val = map->nvGet(name);
     inited = false;