From d0e49bb0f0916ff1a4f33235c087d776f569c516 Mon Sep 17 00:00:00 2001
From: Eric Caruso <zircean@fb.com>
Date: Tue, 2 Jul 2013 09:43:35 -0700
Subject: [PATCH] Add some easy simplifications for OpMod to simplifier

OpMod wasn't doing any constant folding or optimization,
so this might give it a little boost.
---
 hphp/runtime/vm/jit/simplifier.cpp | 25 +++++++++++++++++++++++++
 hphp/runtime/vm/jit/simplifier.h   |  1 +
 2 files changed, 26 insertions(+)

diff --git a/hphp/runtime/vm/jit/simplifier.cpp b/hphp/runtime/vm/jit/simplifier.cpp
index 062bf6488..79e3da749 100644
--- a/hphp/runtime/vm/jit/simplifier.cpp
+++ b/hphp/runtime/vm/jit/simplifier.cpp
@@ -278,6 +278,7 @@ SSATmp* Simplifier::simplify(IRInstruction* inst) {
   case OpAdd:       return simplifyAdd(src1, src2);
   case OpSub:       return simplifySub(src1, src2);
   case OpMul:       return simplifyMul(src1, src2);
+  case OpMod:       return simplifyMod(src1, src2);
   case OpBitAnd:    return simplifyBitAnd(src1, src2);
   case OpBitOr:     return simplifyBitOr(src1, src2);
   case OpBitXor:    return simplifyBitXor(src1, src2);
@@ -884,6 +885,30 @@ SSATmp* Simplifier::simplifyMul(SSATmp* src1, SSATmp* src2) {
   return nullptr;
 }
 
+SSATmp* Simplifier::simplifyMod(SSATmp* src1, SSATmp* src2) {
+  if (src2->isConst()) {
+    int64_t src2Val = src2->getValInt();
+    // refrain from generating undefined IR
+    assert(src2Val != 0);
+    // simplify const
+    if (src1->isConst()) {
+      // still don't want undefined IR
+      assert(src1->getValInt() != std::numeric_limits<int64_t>::min() ||
+             src2Val != -1);
+      return cns(src1->getValInt() % src2Val);
+    }
+    // X % 1, X % -1 --> 0
+    if (src2Val == 1 || src2Val == -1LL) {
+      return cns(0);
+    }
+    // X % LONG_MIN = X (largest magnitude possible as rhs)
+    if (src2Val == std::numeric_limits<int64_t>::min()) {
+      return src1;
+    }
+  }
+  return nullptr;
+}
+
 SSATmp* Simplifier::simplifyBitAnd(SSATmp* src1, SSATmp* src2) {
   SIMPLIFY_DISTRIBUTIVE(&, |, BitAnd, BitOr);
   // X & X --> X
diff --git a/hphp/runtime/vm/jit/simplifier.h b/hphp/runtime/vm/jit/simplifier.h
index 697ce23d5..3e1fcc4c8 100644
--- a/hphp/runtime/vm/jit/simplifier.h
+++ b/hphp/runtime/vm/jit/simplifier.h
@@ -67,6 +67,7 @@ private:
   SSATmp* simplifyAdd(SSATmp* src1, SSATmp* src2);
   SSATmp* simplifySub(SSATmp* src1, SSATmp* src2);
   SSATmp* simplifyMul(SSATmp* src1, SSATmp* src2);
+  SSATmp* simplifyMod(SSATmp* src1, SSATmp* src2);
   SSATmp* simplifyBitAnd(SSATmp* src1, SSATmp* src2);
   SSATmp* simplifyBitOr(SSATmp* src1, SSATmp* src2);
   SSATmp* simplifyBitXor(SSATmp* src1, SSATmp* src2);