This is the first step of a larger campaign of eliminating goofy types from our codebase. Typedef-ing a reference is unrecommended because references are not first class types and therefore things like construction and copying may do unexpected things. In fact search this diff for 'reinterpret_cast' to see some very odd stuff.
Destroy!
Reviewed By: @jdelong
Differential Revision: D983915
"Syntax error: unexpected T_PAAMAYIM_NEKUDOTAYIM" is a WTF
rite-of-passage for every PHP noob. Unlike Zend, we don't have
history to be beholden to, so HH syntax errors ought to be able to
complain about T_DOUBLE_COLON. For compatibility with any parsers
built on Zend, continue returning T_PAAMAYIM_NEKUDOTAYIM in
'token_name' results
Reviewed By: @jdelong
Differential Revision: D980141