Herman Venter
5b8209aa87
These commands invariably return true. This is more than a tad confusing to a new reader of the code. Refactor them to return void. Remove a few pieces of dead code that would log something if they ever returned false.
92 linhas
3.1 KiB
C++
92 linhas
3.1 KiB
C++
/*
|
|
+----------------------------------------------------------------------+
|
|
| HipHop for PHP |
|
|
+----------------------------------------------------------------------+
|
|
| Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com) |
|
|
+----------------------------------------------------------------------+
|
|
| This source file is subject to version 3.01 of the PHP license, |
|
|
| that is bundled with this package in the file LICENSE, and is |
|
|
| available through the world-wide-web at the following url: |
|
|
| http://www.php.net/license/3_01.txt |
|
|
| If you did not receive a copy of the PHP license and are unable to |
|
|
| obtain it through the world-wide-web, please send a note to |
|
|
| license@php.net so we can mail you a copy immediately. |
|
|
+----------------------------------------------------------------------+
|
|
*/
|
|
|
|
#include "hphp/runtime/eval/debugger/cmd/cmd_global.h"
|
|
#include "hphp/runtime/eval/debugger/cmd/cmd_variable.h"
|
|
|
|
namespace HPHP { namespace Eval {
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
TRACE_SET_MOD(debugger);
|
|
|
|
void CmdGlobal::sendImpl(DebuggerThriftBuffer &thrift) {
|
|
DebuggerCommand::sendImpl(thrift);
|
|
thrift.write(m_globals);
|
|
}
|
|
|
|
void CmdGlobal::recvImpl(DebuggerThriftBuffer &thrift) {
|
|
DebuggerCommand::recvImpl(thrift);
|
|
thrift.read(m_globals);
|
|
}
|
|
|
|
void CmdGlobal::help(DebuggerClient *client) {
|
|
client->helpTitle("Global Command");
|
|
client->helpCmds(
|
|
"[g]lobal", "lists all global variables",
|
|
"[g]lobal {text}", "full-text search global variables",
|
|
nullptr
|
|
);
|
|
client->helpBody(
|
|
"This will print names and values of all global variables, if {text} is "
|
|
"not speified. Otherwise, it will print global variables that contain the "
|
|
"text in their names or values. The search is case-insensitive and "
|
|
"string-based."
|
|
);
|
|
}
|
|
|
|
void CmdGlobal::onClientImpl(DebuggerClient *client) {
|
|
if (DebuggerCommand::displayedHelp(client)) return;
|
|
|
|
String text;
|
|
if (client->argCount() == 1) {
|
|
text = client->argValue(1);
|
|
} else if (client->argCount() != 0) {
|
|
help(client);
|
|
return;
|
|
}
|
|
|
|
CmdGlobalPtr cmd = client->xend<CmdGlobal>(this);
|
|
if (cmd->m_globals.empty()) {
|
|
client->info("(no global variable was found)");
|
|
} else {
|
|
m_globals = cmd->m_globals;
|
|
CmdVariable::PrintVariables(client, cmd->m_globals, true, text);
|
|
}
|
|
}
|
|
|
|
void CmdGlobal::setClientOutput(DebuggerClient *client) {
|
|
client->setOutputType(DebuggerClient::OTValues);
|
|
Array values;
|
|
for (ArrayIter iter(m_globals); iter; ++iter) {
|
|
String name = iter.first().toString();
|
|
if (client->getDebuggerClientApiModeSerialize()) {
|
|
values.set(name,
|
|
DebuggerClient::FormatVariable(iter.second(), 200));
|
|
} else {
|
|
values.set(name, iter.second());
|
|
}
|
|
}
|
|
client->setOTValues(values);
|
|
}
|
|
|
|
bool CmdGlobal::onServer(DebuggerProxy *proxy) {
|
|
m_globals = CmdVariable::GetGlobalVariables();
|
|
return proxy->sendToClient(this);
|
|
}
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
}}
|