Arquivos
hhvm/hphp/runtime/eval/debugger/cmd/cmd_where.cpp
T
Herman Venter 5b8209aa87 DebuggerCommand::onClient and DebuggerCommand::help do not return anything meaningful.
These commands invariably return true. This is more than a tad confusing to a new reader of the code. Refactor them to return void. Remove a few pieces of dead code that would log something if they ever returned false.
2013-05-20 13:52:25 -07:00

166 linhas
5.2 KiB
C++

/*
+----------------------------------------------------------------------+
| HipHop for PHP |
+----------------------------------------------------------------------+
| Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com) |
+----------------------------------------------------------------------+
| This source file is subject to version 3.01 of the PHP license, |
| that is bundled with this package in the file LICENSE, and is |
| available through the world-wide-web at the following url: |
| http://www.php.net/license/3_01.txt |
| If you did not receive a copy of the PHP license and are unable to |
| obtain it through the world-wide-web, please send a note to |
| license@php.net so we can mail you a copy immediately. |
+----------------------------------------------------------------------+
*/
#include "hphp/runtime/eval/debugger/cmd/cmd_where.h"
#include "hphp/runtime/base/array/array_iterator.h"
namespace HPHP { namespace Eval {
///////////////////////////////////////////////////////////////////////////////
TRACE_SET_MOD(debugger);
void CmdWhere::sendImpl(DebuggerThriftBuffer &thrift) {
DebuggerCommand::sendImpl(thrift);
{
String sdata;
DebuggerWireHelpers::WireSerialize(m_stacktrace, sdata);
thrift.write(sdata);
}
thrift.write(m_stackArgs);
}
void CmdWhere::recvImpl(DebuggerThriftBuffer &thrift) {
DebuggerCommand::recvImpl(thrift);
{
String sdata;
thrift.read(sdata);
if (DebuggerWireHelpers::WireUnserialize(sdata, m_stacktrace) !=
DebuggerWireHelpers::NoError) {
m_stacktrace = null_array;
m_wireError = sdata;
}
}
thrift.read(m_stackArgs);
}
void CmdWhere::help(DebuggerClient *client) {
client->helpTitle("Where Command");
client->helpCmds(
"[w]here", "displays current stacktrace",
"[w]here {num}", "displays number of innermost frames",
"[w]here -{num}", "displays number of outermost frames",
nullptr
);
client->helpBody(
"Use '[u]p {num}' or '[d]own {num}' to walk up or down the stacktrace. "
"Use '[f]rame {index}' to jump to one particular frame. At any frame, "
"use '[v]ariable' command to display all local variables."
);
}
Array CmdWhere::fetchStackTrace(DebuggerClient *client) {
Array st = client->getStackTrace();
if (st.isNull()) {
m_stackArgs = client->getDebuggerStackArgs();
CmdWherePtr cmd = client->xend<CmdWhere>(this);
st = cmd->m_stacktrace;
client->setStackTrace(st);
}
return st;
}
void CmdWhere::onClientImpl(DebuggerClient *client) {
if (DebuggerCommand::displayedHelp(client)) return;
if (client->argCount() > 1) {
help(client);
return;
}
Array st = fetchStackTrace(client);
if (st.empty()) {
client->info("(no stacktrace to display or in global scope)");
client->info("if you hit serialization limit, consider do "
"\"set sa off\" and then get the stack without args");
return;
}
// so list command can default to current frame
client->moveToFrame(client->getFrame(), false);
if (client->argCount() == 0) {
int i = 0;
for (ArrayIter iter(st); iter; ++iter) {
client->printFrame(i, iter.second());
++i;
if (!client->isApiMode() &&
i % DebuggerClient::ScrollBlockSize == 0 &&
client->ask("There are %d more frames. Continue? [Y/n]",
st.size() - i) == 'n') {
break;
}
}
} else {
string snum = client->argValue(1);
int num = atoi(snum.c_str());
if (snum[0] == '-') {
snum = snum.substr(1);
}
if (!DebuggerClient::IsValidNumber(snum)) {
client->error("The argument, if specified, has to be numeric.");
return;
}
if (num > 0) {
for (int i = 0; i < num && i < st.size(); i++) {
client->printFrame(i, st[i]);
}
} else if (num < 0) {
for (int i = st.size() + num; i < st.size(); i++) {
client->printFrame(i, st[i]);
}
} else {
client->error("0 was specified for the number of frames");
client->tutorial(
"The optional argument is the number of frames to print out. "
"Use a positive number to print out innermost frames. Use a negative "
"number to print out outermost frames."
);
}
}
}
void CmdWhere::setClientOutput(DebuggerClient *client) {
client->setOutputType(DebuggerClient::OTStacktrace);
}
void CmdWhere::processStackTrace() {
// Strip out the args from the stack
static StaticString s_args("args");
Array smallST;
for (ArrayIter iter(m_stacktrace); iter; ++iter) {
CArrRef frame(iter.secondRef());
Array smallFrame;
for (ArrayIter iter2(frame); iter2; ++iter2) {
if (iter2.first().equal(s_args)) {
continue;
}
smallFrame.set(iter2.first(), iter2.secondRef());
}
smallST.append(smallFrame);
}
m_stacktrace = smallST;
}
bool CmdWhere::onServer(DebuggerProxy *proxy) {
m_stacktrace = g_vmContext->debugBacktrace(false, true, false);
if (!m_stackArgs) {
processStackTrace();
}
return proxy->sendToClient(this);
}
///////////////////////////////////////////////////////////////////////////////
}}