Arquivos
hhvm/hphp/runtime/ext/ext_continuation.cpp
T
Mike Magruder 8283969d81 Don't serialize cppext instances unless they opt-in, and pass the class name for the debugger
Most CPP extension classes don’t think about serialization, and some require more initialization than the default contractor provides. The result is that on deserialization we end up with a partially initialized object, and undefined behavior after that.

Modified the serializer to emit __PHP_Unserializable_Class instead, and just the class name for the debugger case. Modified the deserializer to create a __PHP_Unserializable_Class, too, if we are given a string with a CPP extension instance in it, so we're safe on both sides. I do not raise a warning; the results are pretty clear, I think, and it's also unlikely that most such warnings could (or should) be corrected. Finally, I also removed the odd behavior of emitting "dummy" classes for Closure and Continuation. I found no use of these in any source tree. Closure had no implementation at all, and Continuation had an implementation that simply raised a fatal on any method call. Thus we can safely assume that even if someone was serializing one of these types, they were receiving an object that was useless to them, or would fatal. So I believe this transformation is safe.
2013-07-23 11:44:16 -07:00

252 linhas
7.5 KiB
C++
Arquivo Executável

/*
+----------------------------------------------------------------------+
| HipHop for PHP |
+----------------------------------------------------------------------+
| Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com) |
| Copyright (c) 1997-2010 The PHP Group |
+----------------------------------------------------------------------+
| This source file is subject to version 3.01 of the PHP license, |
| that is bundled with this package in the file LICENSE, and is |
| available through the world-wide-web at the following url: |
| http://www.php.net/license/3_01.txt |
| If you did not receive a copy of the PHP license and are unable to |
| obtain it through the world-wide-web, please send a note to |
| license@php.net so we can mail you a copy immediately. |
+----------------------------------------------------------------------+
*/
#include "hphp/runtime/ext/ext_continuation.h"
#include "hphp/runtime/ext/ext_asio.h"
#include "hphp/runtime/base/builtin_functions.h"
#include "hphp/runtime/ext/ext_spl.h"
#include "hphp/runtime/ext/ext_variable.h"
#include "hphp/runtime/ext/ext_function.h"
#include "hphp/runtime/vm/jit/translator.h"
#include "hphp/runtime/vm/jit/translator-inline.h"
#include "hphp/runtime/vm/func.h"
#include "hphp/runtime/vm/runtime.h"
#include "hphp/runtime/base/stats.h"
namespace HPHP {
///////////////////////////////////////////////////////////////////////////////
p_Continuation f_hphp_create_continuation(CStrRef clsname,
CStrRef funcname,
CStrRef origFuncName,
CArrRef args /* = null_array */) {
throw_fatal("Invalid call hphp_create_continuation");
return NULL;
}
///////////////////////////////////////////////////////////////////////////////
c_Continuation::c_Continuation(Class* cb)
: ExtObjectData(cb)
, m_label(0)
, m_index(-1LL)
, m_key(-1LL)
, m_value(Variant::NullInit())
, m_origFunc(nullptr) {
o_subclassData.u16 = 0;
}
c_Continuation::~c_Continuation() {
ActRec* ar = actRec();
if (ar->hasVarEnv()) {
ar->getVarEnv()->detach(ar);
} else {
frame_free_locals_inl(ar, ar->m_func->numLocals());
}
}
void c_Continuation::t___construct() {}
void c_Continuation::t_update(int64_t label, CVarRef value) {
m_label = label;
assert(m_label == label); // check m_label for truncation
m_value.assignVal(value);
m_key = ++m_index;
}
void c_Continuation::t_update_key(int64_t label, CVarRef key, CVarRef value) {
m_label = label;
assert(m_label == label); // check m_label for truncation
m_key.assignVal(key);
m_value.assignVal(value);
if (m_key.isInteger()) {
int64_t new_index = m_key.toInt64Val();
m_index = new_index > m_index ? new_index : m_index;
}
}
Object c_Continuation::t_getwaithandle() {
if (m_waitHandle.isNull()) {
c_ContinuationWaitHandle::Create(this);
assert(!m_waitHandle.isNull());
}
return m_waitHandle;
}
int64_t c_Continuation::t_getlabel() {
return m_label;
}
Variant c_Continuation::t_current() {
const_assert(false);
return m_value;
}
Variant c_Continuation::t_key() {
startedCheck();
return m_key;
}
void c_Continuation::t_next() {
const_assert(false);
}
static StaticString s_next("next");
void c_Continuation::t_rewind() {
this->o_invoke_few_args(s_next, 0);
}
bool c_Continuation::t_valid() {
const_assert(false);
return !done();
}
void c_Continuation::t_send(CVarRef v) {
const_assert(false);
}
void c_Continuation::t_raise(CVarRef v) {
const_assert(false);
}
String c_Continuation::t_getorigfuncname() {
static auto const closureName = StringData::GetStaticString("{closure}");
auto const origName = m_origFunc->isClosureBody() ? closureName
: m_origFunc->name();
assert(origName->isStatic());
return String(const_cast<StringData*>(origName));
}
String c_Continuation::t_getcalledclass() {
String called_class;
if (actRec()->hasThis()) {
called_class = actRec()->getThis()->getVMClass()->name()->data();
} else if (actRec()->hasClass()) {
called_class = actRec()->getClass()->name()->data();
} else {
called_class = empty_string;
}
return called_class;
}
void c_Continuation::dupContVar(const StringData* name, TypedValue* src) {
ActRec *fp = actRec();
Id destId = fp->m_func->lookupVarId(name);
if (destId != kInvalidId) {
// Copy the value of the local to the cont object.
tvDupFlattenVars(src, frame_local(fp, destId), nullptr);
} else {
if (!fp->hasVarEnv()) {
// This VarEnv may potentially outlive the most recently stack-allocated
// VarEnv, so we need to heap allocate it.
fp->setVarEnv(VarEnv::createLocalOnHeap(fp));
}
fp->getVarEnv()->setWithRef(name, src);
}
}
static const StaticString s_this("this");
void c_Continuation::copyContinuationVars(ActRec* fp) {
// For functions that contain only named locals, we can copy TVs
// right to the local space.
static const StringData* thisStr = s_this.get();
bool skipThis;
if (fp->hasVarEnv()) {
Stats::inc(Stats::Cont_CreateVerySlow);
Array definedVariables = fp->getVarEnv()->getDefinedVariables();
skipThis = definedVariables.exists(s_this, true);
for (ArrayIter iter(definedVariables); !iter.end(); iter.next()) {
dupContVar(iter.first().getStringData(),
const_cast<TypedValue *>(iter.secondRef().asTypedValue()));
}
} else {
const Func *genFunc = actRec()->m_func;
skipThis = genFunc->lookupVarId(thisStr) != kInvalidId;
for (Id i = 0; i < genFunc->numNamedLocals(); ++i) {
dupContVar(genFunc->localVarName(i), frame_local(fp, i));
}
}
// If $this is used as a local inside the body and is not provided
// by our containing environment, just prefill it here instead of
// using InitThisLoc inside the body
if (!skipThis && fp->hasThis()) {
Id id = actRec()->m_func->lookupVarId(thisStr);
if (id != kInvalidId) {
tvAsVariant(frame_local(actRec(), id)) = fp->getThis();
}
}
}
c_Continuation *c_Continuation::clone() {
const Func *origFunc = m_origFunc;
const Func *genFunc = actRec()->m_func;
ActRec *fp = g_vmContext->getFP();
c_Continuation* cont = origFunc->isMethod()
? g_vmContext->createContMeth(origFunc, genFunc, fp->getThisOrClass())
: g_vmContext->createContFunc(origFunc, genFunc);
cont->copyContinuationVars(actRec());
cont->o_subclassData.u16 = o_subclassData.u16;
cont->m_label = m_label;
cont->m_index = m_index;
cont->m_key = m_key;
cont->m_value = m_value;
return cont;
}
namespace {
StaticString s_send("send");
StaticString s_raise("raise");
}
void c_Continuation::call_next() {
const HPHP::Func* func = m_cls->lookupMethod(s_next.get());
g_vmContext->invokeContFunc(func, this);
}
void c_Continuation::call_send(Cell& v) {
const HPHP::Func* func = m_cls->lookupMethod(s_send.get());
g_vmContext->invokeContFunc(func, this, &v);
}
void c_Continuation::call_raise(ObjectData* e) {
assert(e);
assert(e->instanceof(SystemLib::s_ExceptionClass));
const HPHP::Func* func = m_cls->lookupMethod(s_raise.get());
Cell arg;
arg.m_type = KindOfObject;
arg.m_data.pobj = e;
g_vmContext->invokeContFunc(func, this, &arg);
}
///////////////////////////////////////////////////////////////////////////////
}