From 4d93cefa8f2fb06fdc47d8f73ed46c3623b8dfd6 Mon Sep 17 00:00:00 2001 From: Pavan Balaji Date: Sat, 25 Apr 2015 15:27:45 -0500 Subject: [PATCH] Remove MPICHLIB_LDFLAGS/LIBS It does not make sense for the user to specify LDFLAGS/LIBS that would only be used to build the MPICH library, but not the user application. Doing do will create a false dependency of the MPICH library on these external libraries resulting in weird interactions with the user application in cases where interlibrary dependencies are not supported. We were anyway silently modifying the WRAPPER LDFLAGS/LIBS to include these anyway, so the flags themselves were weirdly screwed up. This patch simply removes them instead of pretending to allow them, but not really allowing them. Signed-off-by: Ken Raffenetti --- README.vin | 8 ++++---- configure.ac | 6 ------ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/README.vin b/README.vin index b1ad74793..d9dcfb613 100644 --- a/README.vin +++ b/README.vin @@ -286,10 +286,10 @@ MPICH library being compiled/linked with these flags and the flags internally being used in mpicc and friends. (b) MPICHLIB_CFLAGS, MPICHLIB_CPPFLAGS, MPICHLIB_CXXFLAGS, -MPICHLIB_FFLAGS, MPICHLIB_FCFLAGS, MPICHLIB_LDFLAGS and -MPICHLIB_LIBS (abbreviated as MPICHLIB_xFLAGS): Setting these flags -would result in the MPICH library being compiled/linked with these -flags. However, these flags will *not* be used by mpicc and friends. +MPICHLIB_FFLAGS, and MPICHLIB_FCFLAGS (abbreviated as +MPICHLIB_xFLAGS): Setting these flags would result in the MPICH +library being compiled with these flags. However, these flags will +*not* be used by mpicc and friends. (c) MPICH_MAKE_CFLAGS: Setting these flags would result in MPICH's configure tests to not use these flags, but the makefile's to use diff --git a/configure.ac b/configure.ac index 7a5c4612e..a576e09ee 100644 --- a/configure.ac +++ b/configure.ac @@ -296,17 +296,11 @@ AC_ARG_VAR(MPICHLIB_FFLAGS, [extra FFLAGS used in building MPICH libraries]) AC_ARG_VAR(MPICHLIB_FCFLAGS, [extra FCFLAGS used in building MPICH libraries]) -AC_ARG_VAR(MPICHLIB_LDFLAGS, - [extra LDFLAGS used in building MPICH libraries]) -AC_ARG_VAR(MPICHLIB_LIBS, - [extra LIBS used in building MPICH libraries]) CFLAGS="$CFLAGS $MPICHLIB_CFLAGS" CPPFLAGS="$CPPFLAGS $MPICHLIB_CPPFLAGS" CXXFLAGS="$CXXFLAGS $MPICHLIB_CXXFLAGS" FFLAGS="$FFLAGS $MPICHLIB_FFLAGS" FCFLAGS="$FCFLAGS $MPICHLIB_FCFLAGS" -LDFLAGS="$LDFLAGS $MPICHLIB_LDFLAGS" -LIBS="$LIBS $MPICHLIB_LIBS" dnl include all subsystem m4 fragments now that the core autoconf functionality dnl has been setup. No fragment should do anything except define