Ghostkeeper
05be030c45
Document range check for pre-computed cubes
...
Contributes to issue CURA-3137.
2016-12-14 15:15:20 +01:00
Ghostkeeper
3c5e745f83
Reintroduce assert for coordinates exceeding maximum int
...
Because we might still test with models of 2km size.
Contributes to issue CURA-3137.
2016-12-14 14:09:16 +01:00
Ghostkeeper
2e6cd36f20
Make unused parameters unnamed
...
This way they cannot be used any more.
Shuts the compiler up for issue CURA-3137.
2016-12-14 12:02:00 +01:00
Ghostkeeper
9fc4a427cd
Removed checks of unsigned ints being >= 0
...
Because that's always true. Even the compiler says that.
Contributes sorta to issue CURA-3137.
2016-12-14 12:00:39 +01:00
Ghostkeeper
5729908023
Remove unused path parameter
...
According to the compiler, the path parameter of handleChildren was not unused, but that was only because it went recursively to subcalls to handleChildren, so it was actually also unused.
Contributes to issue CURA-3137.
2016-12-14 11:55:40 +01:00
Ghostkeeper
c5b90b0ad9
Put check for empty extruder trains before size check
...
Could save a miniscule amount of time.
Contributes to issue CURA-3137.
2016-12-14 11:50:45 +01:00
Ghostkeeper
382343e558
Make recursion depth unsigned
...
It can't be negative anyway. And it helps with the signed-unsigned comparison checks.
Contributes to issue CURA-3137.
2016-12-14 11:48:46 +01:00
Ghostkeeper
68b293b880
Make subdivided cubic infill robust to 0% infill
...
Otherwise it would crash or loop forever.
Contributes to issue CURA-3137.
2016-12-14 11:44:34 +01:00
Ghostkeeper
f867c0f53a
Prevent crashing when given no extruder trains
...
Instead we return -1. A bit more robust.
Contributes to issue CURA-3137.
2016-12-14 11:05:05 +01:00
Ghostkeeper
ee7e83d138
Merge branch 'mb-layer-height-comment' of https://github.com/smartavionics/CuraEngine into smartavionics-mb-layer-height-comment
2016-12-14 09:29:53 +01:00
Ghostkeeper
50df40c6c6
Revert "Re-use extruder train variable"
...
This reverts commit c9217d4738 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
4d924fd33d
Revert "Add park distance information to retraction config"
...
This reverts commit 23ef513cce .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
c953a726cb
Revert "Add function to move filament to park position"
...
This reverts commit ae00cbe497 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
7c8c0b2417
Revert "Correct speed of retraction"
...
This reverts commit 6925f39426 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
a834754d64
Revert "Remove some annoying compile warnings"
...
This reverts commit d75882a707 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
9957a0c733
Revert "Fix updating current E value"
...
This reverts commit 80f8760f68 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
f6ce0b4141
Revert "Put filament in parking position when we never use it any more"
...
This reverts commit 3cb3e5de45 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
120a9c440c
Revert "Park filament even if printer doesn't support retraction"
...
This reverts commit 837f992f69 .
Contributes to issue CURA-2795.
2016-12-13 15:35:46 +01:00
Ghostkeeper
59f72bdd98
Revert "Expand documentation of writePark"
...
This reverts commit 4f3b4f429d .
Contributes to issue CURA-2795.
2016-12-13 15:35:46 +01:00
Ghostkeeper
abc43302ac
Revert "Correct retraction speed"
...
This reverts commit 36eb3471df .
Contributes to issue CURA-2795.
2016-12-13 15:35:46 +01:00
Mark Burton
c2725bdf83
Move layer_height out of the GCodeExport class - it doesn't need to be a member.
2016-12-13 13:47:39 +00:00
Tim Kuipers
fb761dfd9d
fix: don't generate perimeter_gaps between inner wall and infill/skin when there is no infill (CURA-3108)
2016-12-13 13:53:05 +01:00
Mark Burton
90727a0578
Merge branch 'master' into mb-layer-height-comment
2016-12-13 08:05:31 +00:00
Mark Burton
fd7d1a4bd4
Add comment that reports layer height in RepRap flavour gcode.
2016-12-12 16:54:13 +00:00
Ghostkeeper
2b1266c647
Move implementation to CPP file
...
Contributes to issue CURA-3006.
2016-12-12 14:04:32 +01:00
Ghostkeeper
901bf47610
Move implementation to CPP file
...
Contributes to issue CURA-3006.
2016-12-12 13:55:47 +01:00
Ghostkeeper
80a6115537
Move implementation to CPP file
...
Contributes to issue CURA-3006.
2016-12-12 13:44:23 +01:00
Ghostkeeper
f94ca645bd
Make writeRetraction accept const ref instead of const pointer
...
This change was already made for CURA-2795, and upon this change was built by other commits for other issues. I had to revert CURA-2795, so that would undo the changes that the other commits depend on. Instead though, I un-reverted the change because it's nice and doesn't have anything inherently to do with CURA-2795.
Contributes to issue CURA-2795.
2016-12-12 13:11:03 +01:00
Ghostkeeper
2067644d30
Revert "Update prime speed corresponding to park retraction"
...
This reverts commit 6c986e6cfe .
Contributes to issue CURA-2795.
2016-12-12 12:57:15 +01:00
Ghostkeeper
0285e2f025
Revert "Add additional safety check for extruder switching off in later layers"
...
This reverts commit bc82fd98c9 .
Contributes to issue CURA-2795.
2016-12-12 12:57:15 +01:00
Ghostkeeper
38a1ee4270
Revert "Allow going to stand-by temperature if nozzle is later used"
...
This reverts commit 3c0d3f1b2d .
Contributes to issue CURA-2795.
2016-12-12 12:57:15 +01:00
Ghostkeeper
63459d5cd4
Revert "Correct documentation on why the temperature is switched off later"
...
This reverts commit 6972101d7e .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
138691436e
Revert "Correct technicality in documentation"
...
This reverts commit ab2c2eed4b .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
b9c5b4593b
Revert "Remove unused parameter"
...
This reverts commit b7e9f72023 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
a0a3a24dc1
Revert "Restore park distance exception for BFB g-code"
...
This reverts commit b6355b69e7 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
5959b41132
Revert "Use filament park distance setting instead of direct heat & cool zones"
...
This reverts commit b0487fa4c7 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
3d7229c9f2
Revert "Turn extruder temperature off only if it parked the filament"
...
This reverts commit 84d3381be6 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
e1cfc3d93b
Revert "Break retraction in two"
...
This reverts commit a0625aa735 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
5834540bec
Revert "Rename writeRetractionMove to writeMoveFilament"
...
This reverts commit 7c39b6b26a .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
f191d23e17
Revert "Pass retraction configs by reference instead of pointer"
...
This reverts commit 7a8be50b8f .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
5114ab4218
Revert "Use writeMoveFilament to retract to parking distance"
...
This reverts commit cb7b7bf22a .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
9f5645ecac
Revert "Protect writeMoveFilament"
...
This reverts commit 52220ccab8 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
66befe5827
Revert "Correct documentation of extruder_switch parameter"
...
This reverts commit 4263801d16 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
c9de64f946
Revert "Use optional to denote uninitiated previous extruder temperature"
...
This reverts commit 460c52ea6c .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
dbfa3a0f4b
Revert "Move park distance data to ExtruderTrainAttributes"
...
This reverts commit 7777668b86 .
Contributes to issue CURA-2795.
2016-12-12 12:54:56 +01:00
Ghostkeeper
02268eb7e8
Revert "Park via E-moves instead of via a retraction"
...
This reverts commit 6350f47cd6 .
Contributes to issue CURA-2795.
2016-12-12 12:54:56 +01:00
Tim Kuipers
d2b8c8bf17
Merge pull request #417 from smartavionics/mb-fix-total-filament-report
...
Reinstate filament used comment for RepRap flavour gcode.
2016-12-12 11:32:58 +01:00
Tim Kuipers
d00f5efa77
lil fix: assert used unset extruder_count
2016-12-11 23:12:20 +01:00
Tim Kuipers
b8d7162daf
lil cast warning fix
2016-12-11 11:56:51 +01:00
Tim Kuipers
b0293e2d6a
refactor: processSkin ==> processSkinAndPerimeterGaps (CURA-3108)
2016-12-11 11:50:07 +01:00