minor changes to bulge algorithm

.gitignore

@@ -1,34 +1,25 @@
 *.tar.bz2
 *.tar.gz
 *.7z
-*.zip
-.DS_Store
-*~
-NUL
-*.gcode
-
-## Building result.
-build/*
 *.pyc
+*.zip
 *.exe
-*.o
-CuraEngine
+.idea
+.DS_Store
 _bin
 _obj
-
-## IDE project files.
+*.depend
+*.o
+.*.swp
+*.gcode
+CuraEngine
+build/*
+*~
+NUL
 CuraEngine.layout
 CuraEngine.cbp
-*kdev*
-*.kate-swp
-nbproject/*
-.idea
-*.depend
-.*.swp
-
-## Documentation.
 documentation/html/*
 documentation/latex/*
 
-## Test results.
-tests/output.xml
+*kdev*
+*.kate-swp

CMakeLists.txt

@@ -2,14 +2,7 @@ project(CuraEngine)
 
 cmake_minimum_required(VERSION 2.8.12)
 
-option (ENABLE_ARCUS
-    "Enable support for ARCUS" ON)
-
-if (ENABLE_ARCUS)
-    message(STATUS "Building with Arcus")
-    find_package(Arcus REQUIRED)
-    add_definitions(-DARCUS)
-endif ()
+find_package(Arcus REQUIRED)
 
 if(NOT ${CMAKE_VERSION} VERSION_LESS 3.1)
     set(CMAKE_CXX_STANDARD 11)
@@ -17,22 +10,6 @@ else()
     set(CMAKE_CXX_FLAGS "-std=c++11")
 endif()
 
-if(APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -stdlib=libc++")
-endif()
-
-set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib")
-
-set(CURA_ENGINE_VERSION "master" CACHE STRING "Version name of Cura")
-
-option(BUILD_TESTS OFF)
-
-# Add a compiler flag to check the output for insane values if we are in debug mode.
-if(CMAKE_BUILD_TYPE MATCHES DEBUG)
-    message(STATUS "Building debug release of CuraEngine.")
-    add_definitions(-DASSERT_INSANE_OUTPUT)
-endif()
-
 # Add warnings
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
 
@@ -44,7 +21,7 @@ include_directories(${CMAKE_CURRENT_BINARY_DIR} libs)
 
 add_library(clipper STATIC libs/clipper/clipper.cpp)
 
-set(engine_SRCS # Except main.cpp.
+set(engine_SRCS
     src/bridge.cpp
     src/comb.cpp
     src/commandSocket.cpp
@@ -54,110 +31,45 @@ set(engine_SRCS # Except main.cpp.
     src/gcodeExport.cpp
     src/gcodePlanner.cpp
     src/infill.cpp
-    src/WallsComputation.cpp
+    src/inset.cpp
     src/layerPart.cpp
-    src/LayerPlanBuffer.cpp
+    src/main.cpp
     src/MergeInfillLines.cpp
     src/mesh.cpp
     src/MeshGroup.cpp
     src/multiVolumes.cpp
     src/pathOrderOptimizer.cpp
     src/PrimeTower.cpp
+    src/Progress.cpp
     src/raft.cpp
+    src/settingRegistry.cpp
+    src/settings.cpp
     src/skin.cpp
     src/skirt.cpp
     src/sliceDataStorage.cpp
     src/slicer.cpp
     src/support.cpp
     src/timeEstimate.cpp
-    src/WallsComputation.cpp
     src/wallOverlap.cpp
     src/Weaver.cpp
     src/Wireframe2gcode.cpp
 
-    src/infill/NoZigZagConnectorProcessor.cpp
-    src/infill/ZigzagConnectorProcessorConnectedEndPieces.cpp
-    src/infill/ZigzagConnectorProcessorDisconnectedEndPieces.cpp
-    src/infill/ZigzagConnectorProcessorEndPieces.cpp
-    src/infill/ZigzagConnectorProcessorNoEndPieces.cpp
-
-    src/progress/Progress.cpp
-    src/progress/ProgressStageEstimator.cpp
-
-    src/settings/SettingConfig.cpp
-    src/settings/SettingContainer.cpp
-    src/settings/SettingRegistry.cpp
-    src/settings/settings.cpp
-
-    src/utils/AABB.cpp
-    src/utils/AABB3D.cpp
-    src/utils/Date.cpp
     src/utils/gettime.cpp
-    src/utils/LinearAlg2D.cpp
     src/utils/logoutput.cpp
     src/utils/polygonUtils.cpp
     src/utils/polygon.cpp
 )
 
-# List of tests. For each test there must be a file tests/${NAME}.cpp and a file tests/${NAME}.h.
-set(engine_TEST
-    GCodePlannerTest
-)
-set(engine_TEST_INFILL
-)
-set(engine_TEST_UTILS
-    BucketGrid2DTest
-    LinearAlg2DTest
-    PolygonUtilsTest
-)
-
-# Generating ProtoBuf protocol
-if (ENABLE_ARCUS)
 protobuf_generate_cpp(engine_PB_SRCS engine_PB_HEADERS Cura.proto)
-endif ()
 
-# Compiling CuraEngine itself.
-add_library(_CuraEngine ${engine_SRCS} ${engine_PB_SRCS}) #First compile all of CuraEngine as library, allowing this to be re-used for tests.
-target_link_libraries(_CuraEngine clipper)
-if (ENABLE_ARCUS)
-    target_link_libraries(_CuraEngine Arcus)
-endif ()
-
-set_target_properties(_CuraEngine PROPERTIES COMPILE_DEFINITIONS "VERSION=\"${CURA_ENGINE_VERSION}\"")
+add_executable(CuraEngine ${engine_SRCS} ${engine_PB_SRCS})
+target_link_libraries(CuraEngine clipper Arcus)
 
 if (UNIX)
-    target_link_libraries(_CuraEngine pthread)
-endif()
-add_executable(CuraEngine src/main.cpp) #Then compile main.cpp as separate executable, and link the library to it.
-target_link_libraries(CuraEngine _CuraEngine)
-
-# Compiling the test environment.
-if (BUILD_TESTS)
-    message(STATUS "Building tests...")
-    enable_testing()
-    foreach (test ${engine_TEST})
-        add_executable(${test} tests/main.cpp tests/${test}.cpp)
-        target_link_libraries(${test} _CuraEngine cppunit)
-        add_test(${test} ${test})
-    endforeach()
-    foreach (test ${engine_TEST_INFILL})
-        add_executable(${test} tests/main.cpp tests/infill/${test}.cpp)
-        target_link_libraries(${test} _CuraEngine cppunit)
-        add_test(${test} ${test})
-    endforeach()
-    foreach (test ${engine_TEST_UTILS})
-        add_executable(${test} tests/main.cpp tests/utils/${test}.cpp)
-        target_link_libraries(${test} _CuraEngine cppunit)
-        add_test(${test} ${test})
-    endforeach()
+    target_link_libraries(CuraEngine pthread)
 endif()
 
-
-add_custom_command(TARGET CuraEngine POST_BUILD
-                   COMMAND ${CMAKE_COMMAND} -E copy_directory
-                       ${CMAKE_SOURCE_DIR}/resources $<TARGET_FILE_DIR:CuraEngine>)
-
-# Installing CuraEngine.
 include(GNUInstallDirs)
 install(TARGETS CuraEngine DESTINATION ${CMAKE_INSTALL_BINDIR})
-include(CPackConfig.cmake)
+include(CPackConfig.cmake)
+

CPackConfig.cmake

@@ -1,12 +1,19 @@
 set(CPACK_PACKAGE_VENDOR "Ultimaker")
 set(CPACK_PACKAGE_CONTACT "Arjen Hiemstra <a.hiemstra@ultimaker.com>")
 set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Cura Engine")
-set(CPACK_PACKAGE_VERSION "15.05.90")
-set(CPACK_GENERATOR "DEB")
-if(NOT DEFINED CPACK_DEBIAN_PACKAGE_ARCHITECTURE)
-  execute_process(COMMAND dpkg --print-architecture OUTPUT_VARIABLE CPACK_DEBIAN_PACKAGE_ARCHITECTURE OUTPUT_STRIP_TRAILING_WHITESPACE)
-endif()
-set(CPACK_PACKAGE_FILE_NAME "${CMAKE_PROJECT_NAME}-${CPACK_PACKAGE_VERSION}_${CPACK_DEBIAN_PACKAGE_ARCHITECTURE}")
+set(CPACK_PACKAGE_VERSION_MAJOR 15)
+set(CPACK_PACKAGE_VERSION_MINOR 05)
+set(CPACK_PACKAGE_VERSION_PATCH 90)
+set(CPACK_GENERATOR "DEB;RPM")
+
+set(RPM_REQUIRES
+    "arcus >= 15.05.90"
+    "protobuf >= 3.0.0"
+    "libstdc++6 >= 4.9.0"
+    "libgcc1 >= 4.9.0"
+)
+string(REPLACE ";" "," RPM_REQUIRES "${RPM_REQUIRES}")
+set(CPACK_RPM_PACKAGE_REQUIRES ${RPM_REQUIRES})
 
 set(DEB_DEPENDS
     "arcus (>= 15.05.90)"

Cura.proto

@@ -2,18 +2,20 @@ syntax = "proto3";
 
 package cura.proto;
 
-message ObjectList
+
+message ObjectList 
 {
     repeated Object objects = 1;
     repeated Setting settings = 2;
 }
 
+// typeid 1
 message Slice
 {
     repeated ObjectList object_lists = 1;
 }
 
-message Object
+message Object 
 {
     int64 id = 1;
     bytes vertices = 2; //An array of 3 floats.
@@ -22,13 +24,28 @@ message Object
     repeated Setting settings = 5; // Setting override per object, overruling the global settings.
 }
 
-message Progress
+// typeid 3
+message Progress 
 {
     float amount = 1;
 }
 
+// typeid 2
+message SlicedObjectList 
+{
+    repeated SlicedObject objects = 1;
+}
+
+message SlicedObject 
+{
+    int64 id = 1;
+
+    repeated Layer layers = 2;
+}
+
 message Layer {
     int32 id = 1;
+
     float height = 2;
     float thickness = 3;
 
@@ -45,24 +62,26 @@ message Polygon {
         SkirtType = 5;
         InfillType = 6;
         SupportInfillType = 7;
-        MoveCombingType = 8;
-        MoveRetractionType = 9;
     }
     Type type = 1;
     bytes points = 2;
     float line_width = 3;
 }
 
+// typeid 4
 message GCodeLayer {
+    int64 id = 1;
     bytes data = 2;
 }
 
+// typeid 5
 message ObjectPrintTime {
     int64 id = 1;
     float time = 2;
     float material_amount = 3;
 }
 
+// typeid 6
 message SettingList {
     repeated Setting settings = 1;
 }
@@ -73,9 +92,7 @@ message Setting {
     bytes value = 2;
 }
 
+// typeid 7
 message GCodePrefix {
     bytes data = 2;
 }
-
-message SlicingFinished {
-}

Doxyfile

@@ -178,7 +178,7 @@ JAVADOC_AUTOBRIEF      = NO
 # requiring an explicit \brief command for a brief description.)
 # The default value is: NO.
 
-QT_AUTOBRIEF           = YES
+QT_AUTOBRIEF           = NO
 
 # The MULTILINE_CPP_IS_BRIEF tag can be set to YES to make doxygen treat a
 # multi-line C++ special comment block (i.e. a block of //! or /// comments) as

README.md

@@ -54,16 +54,11 @@ For that one needs a settings JSON file, which can be found in the Ultimaker/Cur
 An example run for an UM2 machine looks as follows:
 * Navigate to the CuraEngine directory and execute the following
 ```
-./build/CuraEngine slice -v -j ../Cura/resources/definitions/dual_extrusion_printer.def.json -o "output/test.gcode" -e1 -s infill_line_distance=0 -e0 -l "/model_1.stl" -e1 -l "fully_filled_model.stl" 
+./build/CuraEngine slice -v -j ../Cura/resources/machines/dual_extrusion_printer.json -o "output/test.gcode" -e1 -s infill_line_distance=0 -e0 -l "/model_1.stl" -e1 -l "fully_filled_model.stl" 
 ```
 
 Run `CuraEngine help` for a general description of how to use the CuraEngine tool.
 
-[Set the environment variable](https://help.ubuntu.com/community/EnvironmentVariables) CURA_ENGINE_SEARCH_PATH to the appropriate paths, delimited by a colon e.g.
-```
-CURA_ENGINE_SEARCH_PATH=/path/to/Cura/resources/definitions:/user/defined/path
-```
-
 Internals
 =========
 

documentation/code_conventions.md

@@ -0,0 +1,126 @@
+Code Conventions
+=======
+Note that the code convention described here have not all yet been fully implemented.
+
+Bracketing and indenting
+-----
+~~~~~~~~~~~~~~~{.cpp}
+if (condition) // brackets always on new lines
+{ // allways a bracket after an if, for, while, etc.
+    // indent always with 4 spaces, never with tabs
+}
+else // else on new line
+{
+    // more code
+}
+~~~~~~~~~~~~~~~
+
+Naming conventions
+------
+ * variables: lower_case_with_underscores
+ * functions: loweCamelCase
+ * classes: UpperCamelCase
+ * macros: UPPER_CASE_WITH_UNDERSCORES
+~~~~~~~~~~~~~~~{.cpp}
+#define UPPER_CASE_MACRO 1
+
+class UpperCamelCase
+{
+private:
+    MemberVariableObject with_underscores;
+public:
+    MemberVariableObject with_underscores;
+
+public:
+    UpperCamelCase();
+    ~UpperCamelCase();
+    
+    // start with input variable(s) and end with output variable(s)
+    void lowerCamelCaseFunctions(ParamObject& also_with_underscores)
+    {
+        LocalObject under_scores;
+    }
+private:
+    void putFunctionsAndVariablesInSeperatePublicPrivateBlocks();
+};
+~~~~~~~~~~~~~~~
+
+Ordering
+----
+~~~~~~~~~~~~~~~{.cpp}
+class Example
+{
+    // start with input variable(s) and end with output parameter(s) 
+    void function1(ParamObject& input_variable, int setting_parameter, ParamObject2& return_parameter)
+    {
+        function2();
+        function3();
+    }
+    
+    // place functions called solely by one other function below it chronologically
+    void function2();
+    
+    void function3();
+};
+~~~~~~~~~~~~~~~
+
+Documentation
+----
+We use [Doxygen](www.doxygen.org/) to generate documentation. Try to keep your documentation in doxygen style.
+
+Here's a small example:
+~~~~~~~~~~~~~~~{.cpp}
+/ *!
+ * Doxygen style comments!
+ *
+ * \param param1 explanation may refer to another \p param2
+ * /
+void function(int param1, int param2)
+{
+    // non-doxygen style comments on implementation details
+}
+
+int member; //!< inline doxygen comment on the entry to the left
+~~~~~~~~~~~~~~~
+
+Files
+--------
+For a file Foo.h (UpperCamelCase):
+~~~~~~~~~~~~~~~{.cpp}
+#ifndef FOO_H
+#define FOO_H
+// [content]
+#endif//FOO_H
+~~~~~~~~~~~~~~~
+
+
+Other
+----
+~~~~~~~~~~~~~~~{.cpp}
+#include <all>
+#include <includes>
+#include <on>
+#include <top>
+
+#include <first_system_includes>
+
+#include <then_library_includes>
+
+#include "finally_local_includes"
+
+enum class EnumExample 
+{
+    ELEM0 = 0,
+    ELEM1 = 1
+};
+~~~~~~~~~~~~~~~
+
+Illegal syntax
+----
+~~~~~~~~~~~~~~~{.cpp}
+void function()
+{
+    if (condition)
+        single_line_outside_code_block(); // always use braces!
+}; // unneccesary semicolon after function definition is not allowed
+~~~~~~~~~~~~~~~

meta/15.04_to_2.0.txt

@@ -1,203 +0,0 @@
-This file is a conversion from the ENGINE settings of 15.04 to the ENGINE setting of 2.0
-
-This is NOT a conversion on the frontend internal setting names (15.04 has the dictionary of doom)
-
-
-autoCenter ?        ==> center_object OR machine_center_is_zero ??
-coolHeadLift        ==> cool_lift_head
-downSkinCount       ==> bottom_layers
-enableCombing       ==> retraction_combing
-enableOozeShield    ==> ooze_shield_enabled
-endCode             ==> machine_end_gcode
-extruderOffset[MAX_EXTRUDERS] = (machine_nozzle_offset_x, machine_nozzle_offset_y)
-extrusionWidth      ==> infill_line_width, skirt_line_width, support_line_width
-fanFullOnLayerNr    ==> cool_fan_full_layer
-fanSpeedMax         ==> cool_fan_speed_max
-fanSpeedMin         ==> cool_fan_speed_min
-filamentDiameter    ==> material_diameter
-filamentFlow        ==> material_flow
-fixHorrible         ==> meshfix_union_all AND/OR meshfix_union_all_remove_holes AND/OR meshfix_extensive_stitching AND/OR magic_mesh_surface_mode
-gcodeFlavor         ==> machine_gcode_flavor
-infillOverlap       ==> infill_overlap
-infillPattern       ==> infill_pattern
-infillSpeed         ==> speed_infill
-initialLayerSpeed   ==> speed_layer_0
-initialLayerThickness   ==> layer_height_0
-initialSpeedupLayers    ==> speed_slowdown_layers
-inset0Speed         ==> speed_wall_0
-insetCount          ==> wall_line_count
-insetXSpeed         ==> speed_wall_x
-layer0extrusionWidth    [ Doesn't exist anymore ]
-layerThickness      ==> layer_height
-matrix                  [ Doesn't exist anymore ]
-minimalExtrusionBeforeRetraction
-minimalFeedrate     ==> cool_min_speed
-minimalLayerTime    ==> cool_min_layer_time
-moveSpeed           ==> speed_travel
-multiVolumeOverlap  ==> multiple_mesh_overlap
-nozzleSize          ==> machine_nozzle_size
-objectPosition      ==> mesh_position_x, mesh_position_y, mesh_position_z
-objectSink              [ Doesn't exist in CuraEngine anymore ]
-perimeterBeforeInfill = not(infill_before_walls)
-postSwitchExtruderCode  ==> machine_extruder_start_code
-preSwitchExtruderCode   ==> machine_extruder_end_code
-printSpeed          ==> speed_prime_tower, speed_support_lines, speed_support_roof, skirt_speed
-raftAirGap          ==> raft_airgap
-raftAirGapLayer0        ?!?!?
-raftBaseLinewidth       ==> raft_base_line_width
-raftBaseSpeed           ==> raft_interface_speed, raft_base_speed
-raftBaseThickness       ==> raft_base_thickness
-raftFanSpeed            ==> raft_base_fan_speed, raft_interface_fan_speed, raft_surface_fan_speed
-raftInterfaceLineSpacing==> raft_interface_line_spacing
-raftInterfaceLinewidth  ==> raft_interface_line_width
-raftInterfaceThickness  ==> raft_interface_thickness
-raftLineSpacing         ==> raft_base_line_spacing
-raftMargin              ==> raft_margin
-raftSurfaceLayers       ==> raft_surface_layers
-raftSurfaceLineSpacing  ==> raft_surface_line_spacing
-raftSurfaceLinewidth    ==> raft_surface_line_width
-raftSurfaceSpeed        ==> raft_surface_speed
-raftSurfaceThickness    ==> raft_surface_thickness
-retractionAmount                ==> retraction_amount (set retraction_enable = true)
-retractionAmountExtruderSwitch  ==> switch_extruder_retraction_amount
-retractionAmountPrime           ==> retraction_extra_prime_amount
-retractionMinimalDistance       ==> retraction_extrusion_window ( set retraction_count_max = 1 )
-retractionSpeed                 ==> retraction_retract_speed (, retraction_prime_speed ?), switch_extruder_retraction_speed
-retractionZHop                  ==> retraction_hop
-simpleMode              ??!
-skinSpeed           ==> speed_topbottom
-skirtDistance       ==> skirt_gap
-skirtLineCount      ==> brim_line_count, skirt_line_count
-skirtMinLength      ==> skirt_minimal_length
-sparseInfillLineDistance    ==> infill_line_distance
-spiralizeMode   ==> magic_spiralize
-startCode       ==> machine_start_gcode
-supportAngle        ==> support_angle, support_enable=true if support_angle>0
-supportEverywhere   ==> support_type
-supportExtruder     ==> support_extruder_nr, support_extruder_nr_layer_0
-supportLineDistance ==> support_line_distance
-supportType         ==> support_pattern
-supportXYDistance   ==> support_xy_distance
-supportZDistance    ==> support_z_distance
-upSkinCount         ==> top_layers
-wipeTowerSize       ==> prime_tower_size
-
-
-
-
-
-NEW:
-adhesion_extruder_nr
-adhesion_type
-alternate_extra_perimeter
-coasting_enable
-coasting_min_volume_move
-coasting_min_volume_retract
-coasting_speed_move
-coasting_speed_retract
-coasting_volume_move
-coasting_volume_retract
-cool_min_layer_time_fan_speed_max
-draft_shield_dist
-draft_shield_height
-extruder_nr
-fill_perimeter_gaps
-infill_sparse_thickness
-infill_wipe_dist
-machine_depth
-machine_extruder_count
-machine_extruder_end_pos_abs
-machine_extruder_end_pos_x
-machine_extruder_end_pos_y
-machine_extruder_start_pos_abs
-machine_extruder_start_pos_x
-machine_extruder_start_pos_y
-machine_heated_bed
-machine_nozzle_cool_down_speed
-machine_nozzle_expansion_angle
-machine_nozzle_head_distance
-machine_nozzle_heat_up_speed
-machine_nozzle_tip_outer_diameter
-machine_print_temp_wait
-machine_use_extruder_offset_to_offset_coords
-machine_width
-magic_fuzzy_skin_enabled
-magic_fuzzy_skin_point_dist
-magic_fuzzy_skin_thickness
-material_bed_temperature
-material_bed_temp_prepend
-material_bed_temp_wait
-material_extrusion_cool_down_speed
-material_flow_dependent_temperature
-material_flow_temp_graph
-material_print_temperature
-material_print_temp_prepend
-material_print_temp_wait
-material_standby_temperature
-meshfix_keep_open_polygons
-ooze_shield_angle
-ooze_shield_dist
-prime_tower_dir_outward
-prime_tower_distance
-prime_tower_flow
-prime_tower_line_width
-prime_tower_position_x
-prime_tower_position_y
-prime_tower_wipe_enabled
-remove_overlapping_walls_0_enabled
-remove_overlapping_walls_x_enabled
-retraction_min_travel
-skin_alternate_rotation
-skin_line_width
-skin_no_small_gaps_heuristic
-skin_outline_count
-support_area_smoothing
-support_bottom_distance
-support_bottom_stair_step_height
-support_conical_angle
-support_conical_enabled
-support_conical_min_width
-support_connect_zigzags
-support_join_distance
-support_minimal_diameter
-support_offset
-support_roof_enable
-support_roof_extruder_nr
-support_roof_height
-support_roof_line_distance
-support_roof_line_width
-support_roof_pattern
-support_top_distance
-support_tower_diameter
-support_tower_roof_angle
-switch_extruder_prime_speed
-top_bottom_pattern
-travel_avoid_distance
-travel_avoid_other_parts
-travel_compensate_overlapping_walls_enabled
-wall_line_width_0
-wall_line_width_x
-wireframe_bottom_delay
-wireframe_drag_along
-wireframe_enabled
-wireframe_fall_down
-wireframe_flat_delay
-wireframe_flow_connection
-wireframe_flow_flat
-wireframe_height
-wireframe_nozzle_clearance
-wireframe_printspeed_bottom
-wireframe_printspeed_down
-wireframe_printspeed_flat
-wireframe_printspeed_up
-wireframe_roof_drag_along
-wireframe_roof_fall_down
-wireframe_roof_inset
-wireframe_roof_outer_delay
-wireframe_straight_before_down
-wireframe_strategy
-wireframe_top_delay
-wireframe_top_jump
-wireframe_up_half_speed
-xy_offset
-z_seam_type

meta/HOWTO.txt

@@ -1,19 +0,0 @@
-find engine setting literals
-
-
-cd ~/Development/CuraEngine/output/reflection/
-
-~/bin/substitute.pl y 'while(/getSetting\w+\("(\w+)"\)/gsm) { print "$1\n"; }' ../../src/ | sort | uniq > engineSettingLiterals.txt
-
-
-run setting inheritance reflection
-
-cd ~/Development/CuraEngine
-./build/CuraEngine analyse ../Cura/resources/machines/fdmprinter.json meta/refl_ff.gv output/reflection/engineSettingLiterals.txt -piew
-
-dot meta/refl_ff.gv -Tpng > meta/rafl_ff_dotted.png
-
-
-green block = used in engine
-red edge = inherit function only
-black edge = parent-child relation

resources/command_line_settings.json

@@ -1,42 +0,0 @@
-{
-    "version": 1, 
-    "name": "Command line setting defaults CuraEngine",
-    "author": "Ultimaker B.V.",
-    "categories": {
-        "command_line_settings": {
-            "label": "Command Line Settings",
-            "settings": {
-                "center_object": {
-                    "description": "Whether to center the object on the middle of the build platform (0,0), instead of using the coordinate system in which the object was saved.",
-                    "type": "boolean",
-                    "default": false
-                },
-                "machine_print_temp_wait": {
-                    "description": "Whether to wait for the nozzle temperature to be reached when preheating the nozzles at the start of the gcode.",
-                    "type": "boolean",
-                    "default": true
-                },
-                "mesh_position_x": {
-                    "description": "Offset applied to the object in the x direction.",
-                    "type": "float",
-                    "default": 0
-                },
-                "mesh_position_y": {
-                    "description": "Offset applied to the object in the y direction.",
-                    "type": "float",
-                    "default": 0
-                },
-                "mesh_position_z": {
-                    "description": "Offset applied to the object in the z direction. With this you can perform what was used to call 'Object Sink'.",
-                    "type": "float",
-                    "default": 0
-                },
-                "prime_tower_dir_outward": {
-                    "description": "Whether to start printing in the middle of the prime tower and end up at the perimeter, or the other way around. This is only used for certain types of prime tower.",
-                    "type": "boolean",
-                    "default": false
-                }
-            }
-        }
-    }
-}

src/ExtruderTrain.h

@@ -1,7 +1,7 @@
 #ifndef EXTRUDER_TRAIN_H
 #define EXTRUDER_TRAIN_H
 
-#include "settings/settings.h"
+#include "settings.h"
 
 namespace cura 
 {
@@ -13,7 +13,7 @@ public:
     int getExtruderNr() { return extruder_nr; }
     
     ExtruderTrain(SettingsBaseVirtual* settings, int extruder_nr)
-    : SettingsBase(settings, std::string("extruder"))
+    : SettingsBase(settings)
     , extruder_nr(extruder_nr)
     { }
     

src/FanSpeedLayerTime.h

@@ -1,22 +0,0 @@
-#ifndef FAN_SPEED_LAYER_TIME_H
-#define FAN_SPEED_LAYER_TIME_H
-
-#include "settings/settings.h"
-
-namespace cura 
-{
-
-struct FanSpeedLayerTimeSettings 
-{
-public:
-    double cool_min_layer_time;
-    double cool_min_layer_time_fan_speed_max;
-    double cool_fan_speed_min;
-    double cool_fan_speed_max;
-    double cool_min_speed;
-    int cool_fan_full_layer;
-};
-
-} // namespace cura
-
-#endif // FAN_SPEED_LAYER_TIME_H

src/FffGcodeWriter.h

@@ -5,8 +5,6 @@
 #include <fstream>
 #include "utils/gettime.h"
 #include "utils/logoutput.h"
-#include "utils/NoCopy.h"
-#include "utils/polygonUtils.h"
 #include "sliceDataStorage.h"
 #include "raft.h"
 #include "infill.h"
@@ -15,13 +13,8 @@
 #include "gcodePlanner.h"
 #include "gcodeExport.h"
 #include "commandSocket.h"
+#include "utils/polygonUtils.h"
 #include "PrimeTower.h"
-#include "FanSpeedLayerTime.h"
-#include "PrintFeature.h"
-
-
-#include "LayerPlanBuffer.h"
-
 
 namespace cura 
 {
@@ -33,68 +26,46 @@ namespace cura
  * 
  * The main function of this class is FffGcodeWriter::writeGCode().
  */
-class FffGcodeWriter : public SettingsMessenger, NoCopy
+class FffGcodeWriter : public SettingsMessenger
 {
     friend class FffProcessor; // cause WireFrame2Gcode uses the member [gcode] (TODO)
 private:
-    int max_object_height; //!< The maximal height of all previously sliced meshgroups, used to avoid collision when moving to the next meshgroup to print.
-
-    /*
-     * Buffer for all layer plans (of type GCodePlanner)
-     * 
-     * The layer plans are buffered so that we can start heating up a nozzle several layers before it needs to be used.
-     * Another reason is to perform Auto Temperature.
-     */
-    LayerPlanBuffer layer_plan_buffer; 
-
-    /*!
-     * The class holding the current state of the gcode being written.
-     * 
-     * It holds information such as the last written position etc.
-     */
+    int max_object_height;
+    int meshgroup_number; //!< used for sequential printing of objects
     GCodeExport gcode;
-
-    /*!
-     * The gcode file to write to when using CuraEngine as command line tool.
-     */
+    CommandSocket* command_socket;
     std::ofstream output_file;
-
+    
     /*!
      * Layer number of the last layer in which a prime tower has been printed per extruder train.  
      * 
      * This is recorded per extruder to account for a prime tower per extruder, instead of the mixed prime tower.
      */
     int last_prime_tower_poly_printed[MAX_EXTRUDERS]; 
-
-    bool skirt_is_processed[MAX_EXTRUDERS]; //!< Whether the skirt polygons have been processed into planned paths for each extruder train
-
-    FanSpeedLayerTimeSettings fan_speed_layer_time_settings; //!< The settings used relating to minimal layer time and fan speeds.
-
-    Point last_position_planned; //!< The position of the head before planning the next layer
-    int current_extruder_planned; //!< The extruder train in use before planning the next layer
-    bool is_inside_mesh_layer_part; //!< Whether the last position was inside a layer part (used in combing)
 public:
     FffGcodeWriter(SettingsBase* settings_)
     : SettingsMessenger(settings_)
-    , layer_plan_buffer(this, gcode)
-    , last_position_planned(no_point)
-    , current_extruder_planned(0) // TODO: make configurable
-    , is_inside_mesh_layer_part(false)
     {
+        meshgroup_number = 1;
         max_object_height = 0;
-        for (unsigned int extruder_nr = 0; extruder_nr < MAX_EXTRUDERS; extruder_nr++)
-        {
-            skirt_is_processed[extruder_nr] = false;
-        }
+        command_socket = NULL;
+    }
+    void resetFileNumber()
+    {
+        meshgroup_number = 1;
     }
 
-    /*!
-     * Set the target to write gcode to: to a file.
-     * 
-     * Used when CuraEngine is used as command line tool.
-     * 
-     * \param filename The filename of the file to which to write the gcode.
-     */
+    void setCommandSocket(CommandSocket* socket)
+    {
+        command_socket = socket;
+    }
+
+    void sendPolygons(PolygonType type, int layer_nr, Polygons& polygons, int line_width)
+    {
+        if (command_socket)
+            command_socket->sendPolygons(type, layer_nr, polygons, line_width);
+    }
+        
     bool setTargetFile(const char* filename)
     {
         output_file.open(filename);
@@ -105,136 +76,94 @@ public:
         }
         return false;
     }
-
-    /*!
-     * Set the target to write gcode to: an output stream.
-     * 
-     * Used when CuraEngine is NOT used as command line tool.
-     * 
-     * \param stream The stream to write gcode to.
-     */
+    
     void setTargetStream(std::ostream* stream)
     {
         gcode.setOutputStream(stream);
     }
-
-    /*!
-     * Get the total extruded volume for a specific extruder in mm^3
-     * 
-     * Retractions and unretractions don't contribute to this.
-     * 
-     * \param extruder_nr The extruder number for which to get the total netto extruded volume
-     * \return total filament printed in mm^3
-     */
-    double getTotalFilamentUsed(int extruder_nr)
+    
+    double getTotalFilamentUsed(int e)
     {
-        return gcode.getTotalFilamentUsed(extruder_nr);
+        return gcode.getTotalFilamentUsed(e);
     }
 
-    /*!
-     * Get the total estimated print time in seconds
-     * 
-     * \return total print time in seconds
-     */
     double getTotalPrintTime()
     {
         return gcode.getTotalPrintTime();
     }
 
-    /*!
-     * Write all the gcode for the current meshgroup.
-     * This is the primary function of this class.
-     * 
-     * \param[in] storage The data storage from which to get the polygons to print and the areas to fill.
-     * \param timeKeeper The stop watch to see how long it takes for each of the stages in the slicing process.
-     */
     void writeGCode(SliceDataStorage& storage, TimeKeeper& timeKeeper);
-
+    
 private:
-    /*!
-     * Set the FffGcodeWriter::fan_speed_layer_time_settings by retrieving all settings from the global/per-meshgroup settings.
-     */
-    void setConfigFanSpeedLayerTime();
-
-    /*!
-     * Create and set the SliceDataStorage::coasting_config for each extruder.
-     * 
-     * \param[out] storage The data storage to which to save the configuration
-     */
     void setConfigCoasting(SliceDataStorage& storage);
 
-    /*!
-     * Set the retraction config globally, per extruder and per mesh.
-     * 
-     * \param[out] storage The data storage to which to save the configurations
-     */
+    //Setup the retraction parameters.
     void setConfigRetraction(SliceDataStorage& storage);
     
-    /*!
-     * Initialize the GcodePathConfig config parameters which don't change over all layers, for each feature.
-     * 
-     * The features are: skirt, support and for each mesh: outer wall, inner walls, skin, infill (and combined infill)
-     * 
-     * \param[out] storage The data storage to which to save the configurations
-     */
-    void initConfigs(SliceDataStorage& storage);
+    void setConfigSkirt(SliceDataStorage& storage, int layer_thickness);
+    
+    void setConfigSupport(SliceDataStorage& storage, int layer_thickness);
+    
+    void setConfigInsets(SliceMeshStorage& mesh, int layer_thickness);
+    
+    void setConfigSkin(SliceMeshStorage& mesh, int layer_thickness);
+    
+    void setConfigInfill(SliceMeshStorage& mesh, int layer_thickness);
     
     /*!
      * Set temperatures and perform initial priming.
-     * 
-     * Write a stub header if CuraEngine is in command line tool mode. (Cause writing the header afterwards would entail moving all gcode down.)
-     * 
-     * \param[in] storage where the slice data is stored.
+     * \param storage Input: where the slice data is stored.
      */
     void processStartingCode(SliceDataStorage& storage);
 
     /*!
-     * Move up and over the already printed meshgroups to print the next meshgroup.
-     * 
-     * \param[in] storage where the slice data is stored.
+     * Move up and over the just printed model to print the next model.
+     * \param storage Input: where the slice data is stored.
      */
     void processNextMeshGroupCode(SliceDataStorage& storage);
     
     /*!
-     * Add raft layer plans onto the FffGcodeWriter::layer_plan_buffer
-     * 
-     * \param[in] storage where the slice data is stored.
-     * \param total_layers The total number of layers.
+     * Add raft gcode.
+     * \param storage Input: where the slice data is stored.
+     * \param totalLayers The total number of layers.
      */
-    void processRaft(SliceDataStorage& storage, unsigned int total_layers);
+    void processRaft(SliceDataStorage& storage, unsigned int totalLayers);
     
     /*!
-     * Convert the polygon data of a layer into a layer plan on the FffGcodeWriter::layer_plan_buffer
-     * 
-     * \param[in] storage where the slice data is stored.
+     * Add a layer to the gcode.
+     * \param storage Input: where the slice data is stored.
      * \param layer_nr The index of the layer to write the gcode of.
-     * \param total_layers The total number of layers.
+     * \param totalLayers The total number of layers.
      * \param has_raft Whether a raft is used for this print.
      */
-    void processLayer(SliceDataStorage& storage, unsigned int layer_nr, unsigned int total_layers, bool has_raft);
+    void processLayer(SliceDataStorage& storage, unsigned int layer_nr, unsigned int totalLayers, bool has_raft);
     
     /*!
-     * Add the skirt to the layer plan \p gcodeLayer.
-     * 
-     * \param[in] storage where the slice data is stored.
+     * Interpolate between the initial layer speeds and the eventual speeds.
+     * \param storage Input: where the slice data is stored.
+     * \param layer_nr The index of the layer to write the gcode of.
+     */
+    void processInitialLayersSpeedup(SliceDataStorage& storage, unsigned int layer_nr);
+    
+    /*!
+     * Add the skirt to the gcode.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param extruder_nr The extrudewr train for which to process the skirt
      */
     void processSkirt(SliceDataStorage& storage, GCodePlanner& gcodeLayer, unsigned int extruder_nr);
     
     /*!
-     * Adds the ooze shield to the layer plan \p gcodeLayer.
-     * 
-     * \param[in] storage where the slice data is stored.
+     * Adds the ooze shield to the print.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      */
     void processOozeShield(SliceDataStorage& storage, GCodePlanner& gcodeLayer, unsigned int layer_nr);
     
     /*!
-     * Adds the draft protection screen to the layer plan \p gcodeLayer.
-     * 
-     * \param[in] storage where the slice data is stored.
+     * Adds the draft protection screen to the print.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      */
@@ -242,18 +171,16 @@ private:
     
     /*!
      * Calculate in which order to print the meshes.
-     * 
-     * \param[in] storage where the slice data is stored.
+     * \param storage Input: where the slice data is stored.
      * \param current_extruder The current extruder with which we last printed
      * \return A vector of mesh indices ordered on print order.
      */
     std::vector<unsigned int> calculateMeshOrder(SliceDataStorage& storage, int current_extruder);
         
     /*!
-     * Add a single layer from a single mesh-volume to the layer plan \p gcodeLayer in mesh surface mode.
-     * 
-     * \param[in] storage where the slice data is stored.
-     * \param mesh The mesh to add to the layer plan \p gcodeLayer.
+     * Add a single layer from a single mesh-volume to the GCode in mesh surface mode.
+     * \param storage Input: where the slice data is stored.
+     * \param mesh The mesh to add to the gcode.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      * 
@@ -261,10 +188,9 @@ private:
     void addMeshLayerToGCode_meshSurfaceMode(SliceDataStorage& storage, SliceMeshStorage* mesh, GCodePlanner& gcodeLayer, int layer_nr);
     
     /*!
-     * Add the open polylines from a single layer from a single mesh-volume to the layer plan \p gcodeLayer for mesh the surface modes.
-     * 
-     * \param[in] storage where the slice data is stored.
-     * \param mesh The mesh for which to add to the layer plan \p gcodeLayer.
+     * Add the open polylines from a single layer from a single mesh-volume to the GCode for mesh surface mode.
+     * \param storage Input: where the slice data is stored.
+     * \param mesh The mesh for which to add to the gcode.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      * 
@@ -272,10 +198,9 @@ private:
     void addMeshOpenPolyLinesToGCode(SliceDataStorage& storage, SliceMeshStorage* mesh, GCodePlanner& gcode_layer, int layer_nr);
     
     /*!
-     * Add a single layer from a single mesh-volume to the layer plan \p gcodeLayer.
-     * 
-     * \param[in] storage where the slice data is stored.
-     * \param mesh The mesh to add to the layer plan \p gcodeLayer.
+     * Add a single layer from a single mesh-volume to the GCode.
+     * \param storage Input: where the slice data is stored.
+     * \param mesh The mesh to add to the gcode.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      * 
@@ -283,36 +208,35 @@ private:
     void addMeshLayerToGCode(SliceDataStorage& storage, SliceMeshStorage* mesh, GCodePlanner& gcodeLayer, int layer_nr);
     
     /*!
-     * Add thicker (multiple layers) sparse infill for a given part in a layer plan.
-     * 
+     * Add thicker (multiple layers) sparse infill for a given part in a layer.
      * \param gcodeLayer The initial planning of the gcode of the layer.
-     * \param mesh The mesh for which to add to the layer plan \p gcodeLayer.
+     * \param mesh The mesh for which to add to the gcode.
      * \param part The part for which to create gcode
      * \param layer_nr The current layer number.
      * \param infill_line_distance The distance between the infill lines
-     * \param infill_overlap The distance by which the infill overlaps with the wall insets.
+     * \param infill_overlap The fraction of the extrusion width by which the infill overlaps with the wall insets.
      * \param fillAngle The angle in the XY plane at which the infill is generated.
      * \param extrusionWidth extrusionWidth
      */
-    void processMultiLayerInfill(GCodePlanner& gcodeLayer, SliceMeshStorage* mesh, SliceLayerPart& part, unsigned int layer_nr, int infill_line_distance, int infill_overlap, int fillAngle, int extrusionWidth); 
+    void processMultiLayerInfill(GCodePlanner& gcodeLayer, SliceMeshStorage* mesh, SliceLayerPart& part, unsigned int layer_nr, int infill_line_distance, double infill_overlap, int fillAngle, int extrusionWidth); 
     
     /*!
      * Add normal sparse infill for a given part in a layer.
      * \param gcodeLayer The initial planning of the gcode of the layer.
-     * \param mesh The mesh for which to add to the layer plan \p gcodeLayer.
+     * \param mesh The mesh for which to add to the gcode.
      * \param part The part for which to create gcode
      * \param layer_nr The current layer number.
      * \param infill_line_distance The distance between the infill lines
-     * \param infill_overlap The distance by which the infill overlaps with the wall insets.
+     * \param infill_overlap The fraction of the extrusion width by which the infill overlaps with the wall insets.
      * \param fillAngle The angle in the XY plane at which the infill is generated.
      * \param extrusionWidth extrusionWidth
      */
-    void processSingleLayerInfill(GCodePlanner& gcodeLayer, SliceMeshStorage* mesh, SliceLayerPart& part, unsigned int layer_nr, int infill_line_distance, int infill_overlap, int fillAngle, int extrusionWidth);
+    void processSingleLayerInfill(GCodePlanner& gcodeLayer, SliceMeshStorage* mesh, SliceLayerPart& part, unsigned int layer_nr, int infill_line_distance, double infill_overlap, int fillAngle, int extrusionWidth);
     
     /*!
      * Generate the insets for the walls of a given layer part.
      * \param gcodeLayer The initial planning of the gcode of the layer.
-     * \param mesh The mesh for which to add to the layer plan \p gcodeLayer.
+     * \param mesh The mesh for which to add to the gcode.
      * \param part The part for which to create gcode
      * \param layer_nr The current layer number.
      * \param z_seam_type dir3ective for where to start the outer paerimeter of a part
@@ -323,34 +247,34 @@ private:
     /*!
      * Add the gcode of the top/bottom skin of the given part.
      * \param gcodeLayer The initial planning of the gcode of the layer.
-     * \param mesh The mesh for which to add to the layer plan \p gcodeLayer.
+     * \param mesh The mesh for which to add to the gcode.
      * \param part The part for which to create gcode
      * \param layer_nr The current layer number.
-     * \param skin_overlap The distance by which the skinfill overlaps with the wall insets.
+     * \param infill_overlap The fraction of the extrusion width by which the infill overlaps with the wall insets.
      * \param fillAngle The angle in the XY plane at which the infill is generated.
      * \param extrusionWidth extrusionWidth
      */
-    void processSkin(cura::GCodePlanner& gcode_layer, cura::SliceMeshStorage* mesh, cura::SliceLayerPart& part, unsigned int layer_nr, int skin_overlap, int infill_angle, int extrusion_width);
+    void processSkin(cura::GCodePlanner& gcode_layer, cura::SliceMeshStorage* mesh, cura::SliceLayerPart& part, unsigned int layer_nr, double infill_overlap, int infill_angle, int extrusion_width);
     
     /*!
-     * Add the support to the layer plan \p gcodeLayer of the current layer.
-     * \param[in] storage where the slice data is stored.
+     * Add the support to the gcode of the current layer.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      * \param extruder_nr_before The extruder number at the start of the layer (before other print parts aka the rest)
-     * \param before_rest Whether the function has been called before adding the rest to the layer plan \p gcodeLayer, or after.
+     * \param before_rest Whether the function has been called before adding the rest to the gcode, or after.
      */
     void addSupportToGCode(SliceDataStorage& storage, GCodePlanner& gcodeLayer, int layer_nr, int extruder_nr_before, bool before_rest);
     /*!
-     * Add the support lines/walls to the layer plan \p gcodeLayer of the current layer.
-     * \param[in] storage where the slice data is stored.
+     * Add the support lines/walls to the gcode of the current layer.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      */
-    void addSupportInfillToGCode(SliceDataStorage& storage, GCodePlanner& gcodeLayer, int layer_nr);
+    void addSupportLinesToGCode(SliceDataStorage& storage, GCodePlanner& gcodeLayer, int layer_nr);
     /*!
-     * Add the support roofs to the layer plan \p gcodeLayer of the current layer.
-     * \param[in] storage where the slice data is stored.
+     * Add the support roofs to the gcode of the current layer.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      */
@@ -361,7 +285,7 @@ private:
      * 
      * On layer 0 this function adds the skirt for the nozzle it switches to, instead of the prime tower.
      * 
-     * \param[in] storage where the slice data is stored.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      * \param extruder_nr The extruder to which to switch
@@ -370,13 +294,21 @@ private:
     
     /*!
      * Add the prime tower gcode for the current layer.
-     * \param[in] storage where the slice data is stored.
+     * \param storage Input: where the slice data is stored.
      * \param gcodeLayer The initial planning of the gcode of the layer.
      * \param layer_nr The index of the layer to write the gcode of.
      * \param prev_extruder The current extruder with which we last printed.
      */
     void addPrimeTower(SliceDataStorage& storage, GCodePlanner& gcodeLayer, int layer_nr, int prev_extruder);
     
+    /*!
+     * Finish the layer by applying speed corrections for minimal layer times and determine the fanSpeed.
+     * \param storage Input: where the slice data is stored.
+     * \param gcodeLayer The initial planning of the gcode of the layer.
+     * \param layer_nr The index of the layer to write the gcode of.
+     */
+    void processFanSpeedAndMinimalLayerTime(SliceDataStorage& storage, GCodePlanner& gcodeLayer, unsigned int layer_nr);
+    
     /*!
      * Add the end gcode and set all temperatures to zero.
      */

src/FffPolygonGenerator.cpp

@@ -1,7 +1,9 @@
 #include "FffPolygonGenerator.h"
 
 #include <algorithm>
-#include <map> // multimap (ordered map allowing duplicate keys)
+#include <random> // for bulging effect?
+#include <functional> // for bugling?
+#include <cmath> // for bulging?
 
 #include "slicer.h"
 #include "utils/gettime.h"
@@ -10,18 +12,13 @@
 #include "support.h"
 #include "multiVolumes.h"
 #include "layerPart.h"
-#include "WallsComputation.h"
+#include "inset.h"
 #include "skirt.h"
 #include "skin.h"
 #include "infill.h"
 #include "raft.h"
 #include "debug.h"
-#include "progress/Progress.h"
-#include "PrintFeature.h"
-#include "progress/ProgressEstimator.h"
-#include "progress/ProgressStageEstimator.h"
-#include "progress/ProgressEstimatorLinear.h"
-
+#include "Progress.h"
 
 namespace cura
 {
@@ -29,6 +26,9 @@ namespace cura
     
 bool FffPolygonGenerator::generateAreas(SliceDataStorage& storage, MeshGroup* meshgroup, TimeKeeper& timeKeeper)
 {
+    if (commandSocket)
+        commandSocket->beginSendSlicedObject();
+    
     if (!sliceModel(meshgroup, timeKeeper, storage)) 
     {
         return false;
@@ -41,31 +41,21 @@ bool FffPolygonGenerator::generateAreas(SliceDataStorage& storage, MeshGroup* me
 
 bool FffPolygonGenerator::sliceModel(MeshGroup* meshgroup, TimeKeeper& timeKeeper, SliceDataStorage& storage) /// slices the model
 {
-    Progress::messageProgressStage(Progress::Stage::SLICING, &timeKeeper);
+    Progress::messageProgressStage(Progress::Stage::SLICING, &timeKeeper, commandSocket);
     
     storage.model_min = meshgroup->min();
     storage.model_max = meshgroup->max();
     storage.model_size = storage.model_max - storage.model_min;
 
     log("Slicing model...\n");
-    int initial_layer_thickness = getSettingInMicrons("layer_height_0");
-    if(initial_layer_thickness <= 0) //Initial layer height of 0 is not allowed. Negative layer height is nonsense.
-    {
-        logError("Initial layer height %i is disallowed.\n", initial_layer_thickness);
-        return false;
-    }
-    int layer_thickness = getSettingInMicrons("layer_height");
-    if(layer_thickness <= 0) //Layer height of 0 is not allowed. Negative layer height is nonsense.
-    {
-        logError("Layer height %i is disallowed.\n", layer_thickness);
-        return false;
+    int initial_layer_thickness = meshgroup->getSettingInMicrons("layer_height_0");
+    int layer_thickness = meshgroup->getSettingInMicrons("layer_height");
+    if (meshgroup->getSettingAsPlatformAdhesion("adhesion_type") == EPlatformAdhesion::RAFT) 
+    { 
+        initial_layer_thickness = layer_thickness; 
     }
     int initial_slice_z = initial_layer_thickness - layer_thickness / 2;
     int layer_count = (storage.model_max.z - initial_slice_z) / layer_thickness + 1;
-    if(layer_count <= 0) //Model is shallower than layer_height_0, so not even the first layer is sliced. Return an empty model then.
-    {
-        return true; //This is NOT an error state!
-    }
 
     std::vector<Slicer*> slicerList;
     for(unsigned int mesh_idx = 0; mesh_idx < meshgroup->meshes.size(); mesh_idx++)
@@ -77,21 +67,23 @@ bool FffPolygonGenerator::sliceModel(MeshGroup* meshgroup, TimeKeeper& timeKeepe
         for(SlicerLayer& layer : slicer->layers)
         {
             //Reporting the outline here slows down the engine quite a bit, so only do so when debugging.
-            sendPolygons("outline", layer_nr, layer.z, layer.polygonList);
-            sendPolygons("openoutline", layer_nr, layer.openPolygonList);
+            //sendPolygons("outline", layer_nr, layer.z, layer.polygonList);
+            //sendPolygons("openoutline", layer_nr, layer.openPolygonList);
         }
         */
-        Progress::messageProgress(Progress::Stage::SLICING, mesh_idx + 1, meshgroup->meshes.size());
+        Progress::messageProgress(Progress::Stage::SLICING, mesh_idx + 1, meshgroup->meshes.size(), commandSocket);
     }
     
     log("Layer count: %i\n", layer_count);
 
     meshgroup->clear();///Clear the mesh face and vertex data, it is no longer needed after this point, and it saves a lot of memory.
 
-    Progress::messageProgressStage(Progress::Stage::PARTS, &timeKeeper);
+    Progress::messageProgressStage(Progress::Stage::PARTS, &timeKeeper, commandSocket);
+    
+    bulgeWalls(slicerList, meshgroup);
+    
     //carveMultipleVolumes(storage.meshes);
-    generateMultipleVolumesOverlap(slicerList);
-    // TODO!!! dont generate multi volume overlap with infill meshes!
+    generateMultipleVolumesOverlap(slicerList, getSettingInMicrons("multiple_mesh_overlap"));
     
     storage.meshes.reserve(slicerList.size()); // causes there to be no resize in meshes so that the pointers in sliceMeshStorage._config to retraction_config don't get invalidated.
     for(unsigned int meshIdx=0; meshIdx < slicerList.size(); meshIdx++)
@@ -99,32 +91,28 @@ bool FffPolygonGenerator::sliceModel(MeshGroup* meshgroup, TimeKeeper& timeKeepe
         storage.meshes.emplace_back(&meshgroup->meshes[meshIdx]); // new mesh in storage had settings from the Mesh
         SliceMeshStorage& meshStorage = storage.meshes.back();
         Mesh& mesh = storage.meshgroup->meshes[meshIdx];
-        
-        
         createLayerParts(meshStorage, slicerList[meshIdx], mesh.getSettingBoolean("meshfix_union_all"), mesh.getSettingBoolean("meshfix_union_all_remove_holes"));
         delete slicerList[meshIdx];
 
-        bool has_raft = getSettingAsPlatformAdhesion("adhesion_type") == EPlatformAdhesion::RAFT;
+        bool has_raft = meshStorage.getSettingAsPlatformAdhesion("adhesion_type") == EPlatformAdhesion::RAFT;
         //Add the raft offset to each layer.
         for(unsigned int layer_nr=0; layer_nr<meshStorage.layers.size(); layer_nr++)
         {
             SliceLayer& layer = meshStorage.layers[layer_nr];
-            meshStorage.layers[layer_nr].printZ += 
-                getSettingInMicrons("layer_height_0")
-                - initial_slice_z;
             if (has_raft)
             {
-                ExtruderTrain* train = storage.meshgroup->getExtruderTrain(getSettingAsIndex("adhesion_extruder_nr"));
                 layer.printZ += 
-                    train->getSettingInMicrons("raft_base_thickness") 
-                    + train->getSettingInMicrons("raft_interface_thickness") 
-                    + train->getSettingAsCount("raft_surface_layers") * train->getSettingInMicrons("raft_surface_thickness")
-                    + train->getSettingInMicrons("raft_airgap")
-                    - train->getSettingInMicrons("layer_0_z_overlap"); // shift all layers (except 0) down
-                if (layer_nr == 0)
-                {
-                    layer.printZ += train->getSettingInMicrons("layer_0_z_overlap"); // undo shifting down of first layer
-                }
+                    meshStorage.getSettingInMicrons("raft_base_thickness") 
+                    + meshStorage.getSettingInMicrons("raft_interface_thickness") 
+                    + meshStorage.getSettingAsCount("raft_surface_layers") * getSettingInMicrons("layer_height") //raft_surface_thickness") 
+                    + meshStorage.getSettingInMicrons("raft_airgap")
+                    - initial_slice_z;
+            }
+            else 
+            {
+                meshStorage.layers[layer_nr].printZ += 
+                    meshStorage.getSettingInMicrons("layer_height_0")
+                    - initial_slice_z;
             }
     
  
@@ -133,263 +121,149 @@ bool FffPolygonGenerator::sliceModel(MeshGroup* meshgroup, TimeKeeper& timeKeepe
                 meshStorage.layer_nr_max_filled_layer = layer_nr; // last set by the highest non-empty layer
             } 
                 
-            if (CommandSocket::isInstantiated())
+            if (commandSocket)
             {
-                CommandSocket::getInstance()->sendLayerInfo(layer_nr, layer.printZ, layer_nr == 0? getSettingInMicrons("layer_height_0") : getSettingInMicrons("layer_height"));
+                commandSocket->sendLayerInfo(layer_nr, layer.printZ, layer_nr == 0 && !has_raft? meshStorage.getSettingInMicrons("layer_height_0") : meshStorage.getSettingInMicrons("layer_height"));
             }
         }
         
-        Progress::messageProgress(Progress::Stage::PARTS, meshIdx + 1, slicerList.size());
+        Progress::messageProgress(Progress::Stage::PARTS, meshIdx + 1, slicerList.size(), commandSocket);
     }
+    
+    Progress::messageProgressStage(Progress::Stage::INSET, &timeKeeper, commandSocket);
     return true;
 }
 
 void FffPolygonGenerator::slices2polygons(SliceDataStorage& storage, TimeKeeper& time_keeper)
 {
-    // compute layer count and remove first empty layers
-    // there is no separate progress stage for removeEmptyFisrtLayer (TODO)
-    unsigned int total_layers = 0;
-    for (SliceMeshStorage& mesh : storage.meshes)
-    {
-        if (!mesh.getSettingBoolean("infill_mesh"))
-        {
-            total_layers = std::max<unsigned int>(total_layers, mesh.layers.size());
-        }
-    }
-
-    // handle meshes
-    std::vector<double> mesh_timings;
-    for (unsigned int mesh_idx = 0; mesh_idx < storage.meshes.size(); mesh_idx++)
-    {
-        mesh_timings.push_back(1.0); // TODO: have a more accurate estimate of the relative time it takes per mesh, based on the height and number of polygons
-    }
-    ProgressStageEstimator inset_skin_progress_estimate(mesh_timings);
-
-    Progress::messageProgressStage(Progress::Stage::INSET_SKIN, &time_keeper);
-    std::vector<unsigned int> mesh_order;
-    { // compute mesh order
-        std::multimap<int, unsigned int> order_to_mesh_indices;
-        for (unsigned int mesh_idx = 0; mesh_idx < storage.meshes.size(); mesh_idx++)
-        {
-            order_to_mesh_indices.emplace(storage.meshes[mesh_idx].getSettingAsIndex("infill_mesh_order"), mesh_idx);
-        }
-        for (std::pair<const int, unsigned int>& order_and_mesh_idx : order_to_mesh_indices)
-        {
-            mesh_order.push_back(order_and_mesh_idx.second);
-        }
-    }
-    for (unsigned int mesh_idx : mesh_order)
-    {
-        processBasicWallsSkinInfill(storage, mesh_idx, mesh_order, total_layers, inset_skin_progress_estimate);
-        Progress::messageProgress(Progress::Stage::INSET_SKIN, mesh_idx + 1, storage.meshes.size());
-    }
+    // const 
+    unsigned int total_layers = storage.meshes.at(0).layers.size();
     //layerparts2HTML(storage, "output/output.html");
-
-    // we need to remove empty layers after we have procesed the insets
-    // processInsets might throw away parts if they have no wall at all (cause it doesn't fit)
-    // brim depends on the first layer not being empty
-    removeEmptyFirstLayers(storage, getSettingInMicrons("layer_height"), total_layers); // changes total_layers!
-    if (total_layers == 0)
+    for(unsigned int layer_number = 0; layer_number < total_layers; layer_number++)
     {
-        log("Stopping process because there are no non-empty layers.\n");
+        processInsets(storage, layer_number);
+        
+        Progress::messageProgress(Progress::Stage::INSET, layer_number+1, total_layers, commandSocket);
+    }
+    
+    removeEmptyFirstLayers(storage, getSettingInMicrons("layer_height"), total_layers);
+    
+    if (total_layers < 1)
+    {
+        log("Stopping process because there are no layers.\n");
         return;
     }
-
-    Progress::messageProgressStage(Progress::Stage::SUPPORT, &time_keeper);  
-
-    AreaSupport::generateSupportAreas(storage, total_layers);
     
-    /*
+    Progress::messageProgressStage(Progress::Stage::SUPPORT, &time_keeper, commandSocket);  
+            
+    AreaSupport::generateSupportAreas(storage, total_layers, commandSocket);
     if (storage.support.generated)
     {
         for (unsigned int layer_idx = 0; layer_idx < total_layers; layer_idx++)
         {
             Polygons& support = storage.support.supportLayers[layer_idx].supportAreas;
-            if (CommandSocket::isInstantiated()) 
-            {
-                CommandSocket::getInstance()->sendPolygons(PrintFeatureType::Infill, layer_idx, support, 100); //getSettingInMicrons("support_line_width"));
-            }
+            sendPolygons(SupportType, layer_idx, support, getSettingInMicrons("support_line_width"));
         }
     }
-    */
+    
+    Progress::messageProgressStage(Progress::Stage::SKIN, &time_keeper, commandSocket);
+    int mesh_max_bottom_layer_count = 0;
+    if (getSettingBoolean("magic_spiralize"))
+    {
+        for(SliceMeshStorage& mesh : storage.meshes)
+        {
+            mesh_max_bottom_layer_count = std::max(mesh_max_bottom_layer_count, mesh.getSettingAsCount("bottom_layers"));
+        }
+    }
+    for(unsigned int layer_number = 0; layer_number < total_layers; layer_number++)
+    {
+        if (!getSettingBoolean("magic_spiralize") || static_cast<int>(layer_number) < mesh_max_bottom_layer_count)    //Only generate up/downskin and infill for the first X layers when spiralize is choosen.
+        {
+            processSkins(storage, layer_number);
+        }
+        Progress::messageProgress(Progress::Stage::SKIN, layer_number+1, total_layers, commandSocket);
+    }
+    
+    for(unsigned int layer_number = total_layers-1; layer_number > 0; layer_number--)
+    {
+        for(SliceMeshStorage& mesh : storage.meshes)
+            combineInfillLayers(layer_number, mesh, mesh.getSettingAsCount("infill_sparse_combine"));
+    }
 
-    // handle helpers
     storage.primeTower.computePrimeTowerMax(storage);
     storage.primeTower.generatePaths(storage, total_layers);
-
+    
     processOozeShield(storage, total_layers);
-
+        
     processDraftShield(storage, total_layers);
-
+    
     processPlatformAdhesion(storage);
-    
-    // meshes post processing
-    for (SliceMeshStorage& mesh : storage.meshes)
-    {
-        processDerivedWallsSkinInfill(mesh, total_layers);
-    }
-}
 
-void FffPolygonGenerator::processBasicWallsSkinInfill(SliceDataStorage& storage, unsigned int mesh_idx, std::vector<unsigned int>& mesh_order, size_t total_layers, ProgressStageEstimator& inset_skin_progress_estimate)
-{
     
-    SliceMeshStorage& mesh = storage.meshes[mesh_idx];
-    if (mesh.getSettingBoolean("infill_mesh"))
+    for(SliceMeshStorage& mesh : storage.meshes)
     {
-        processInfillMesh(storage, mesh_idx, mesh_order, total_layers);
-    }
-    
-    // TODO: make progress more accurate!!
-    // note: estimated time for     insets : skins = 22.953 : 48.858
-    std::vector<double> walls_vs_skin_timing({22.953, 48.858});
-    ProgressStageEstimator* mesh_inset_skin_progress_estimator = new ProgressStageEstimator(walls_vs_skin_timing);
-    
-    inset_skin_progress_estimate.nextStage(mesh_inset_skin_progress_estimator); // the stage of this function call
-    
-    ProgressEstimatorLinear* inset_estimator = new ProgressEstimatorLinear(total_layers);
-    mesh_inset_skin_progress_estimator->nextStage(inset_estimator);
-    
-    
-    // walls
-    for(unsigned int layer_number = 0; layer_number < total_layers; layer_number++)
-    {
-        processInsets(mesh, layer_number);
-        double progress = inset_skin_progress_estimate.progress(layer_number);
-        Progress::messageProgress(Progress::Stage::INSET_SKIN, progress * 100, 100);
-    }
-
-    ProgressEstimatorLinear* skin_estimator = new ProgressEstimatorLinear(total_layers);
-    mesh_inset_skin_progress_estimator->nextStage(skin_estimator);
-    
-    // skin & infill
-//     Progress::messageProgressStage(Progress::Stage::SKIN, &time_keeper);
-    int mesh_max_bottom_layer_count = 0;
-    if (mesh.getSettingBoolean("magic_spiralize"))
-    {
-        mesh_max_bottom_layer_count = std::max(mesh_max_bottom_layer_count, mesh.getSettingAsCount("bottom_layers"));
-    }
-    for(unsigned int layer_number = 0; layer_number < total_layers; layer_number++)
-    {
-        if (!mesh.getSettingBoolean("magic_spiralize") || static_cast<int>(layer_number) < mesh_max_bottom_layer_count)    //Only generate up/downskin and infill for the first X layers when spiralize is choosen.
+        if (mesh.getSettingBoolean("magic_fuzzy_skin_enabled"))
         {
-            processSkinsAndInfill(mesh, layer_number);
+            processFuzzySkin(mesh);
         }
-        double progress = inset_skin_progress_estimate.progress(layer_number);
-        Progress::messageProgress(Progress::Stage::INSET_SKIN, progress * 100, 100);
     }
 }
 
-void FffPolygonGenerator::processInfillMesh(SliceDataStorage& storage, unsigned int mesh_idx, std::vector<unsigned int>& mesh_order, size_t total_layers)
+void FffPolygonGenerator::processInsets(SliceDataStorage& storage, unsigned int layer_nr) 
 {
-    SliceMeshStorage& mesh = storage.meshes[mesh_idx];
-    for (unsigned int layer_idx = 0; layer_idx < mesh.layers.size(); layer_idx++)
+    for(SliceMeshStorage& mesh : storage.meshes)
     {
-        SliceLayer& layer = mesh.layers[layer_idx];
-        std::vector<PolygonsPart> new_parts;
-
-        for (unsigned int other_mesh_idx : mesh_order)
+        SliceLayer* layer = &mesh.layers[layer_nr];
+        if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::SURFACE)
         {
-            if (other_mesh_idx == mesh_idx)
-            {
-                break; // all previous meshes have been processed
-            }
-            SliceMeshStorage& other_mesh = storage.meshes[other_mesh_idx];
-            if (layer_idx >= other_mesh.layers.size())
-            {
-                continue;
-            }
+            int inset_count = mesh.getSettingAsCount("wall_line_count");
+            if (mesh.getSettingBoolean("magic_spiralize") && static_cast<int>(layer_nr) < mesh.getSettingAsCount("bottom_layers") && layer_nr % 2 == 1)//Add extra insets every 2 layers when spiralizing, this makes bottoms of cups watertight.
+                inset_count += 5;
+            int line_width_x = mesh.getSettingInMicrons("wall_line_width_x");
+            int line_width_0 = mesh.getSettingInMicrons("wall_line_width_0");
+            if (mesh.getSettingBoolean("alternate_extra_perimeter"))
+                inset_count += layer_nr % 2; 
+            generateInsets(layer, mesh.getSettingInMicrons("machine_nozzle_size"), line_width_0, line_width_x, inset_count, mesh.getSettingBoolean("remove_overlapping_walls_0_enabled"), mesh.getSettingBoolean("remove_overlapping_walls_x_enabled"));
 
-            SliceLayer& other_layer = other_mesh.layers[layer_idx];
-
-            for (SliceLayerPart& part : layer.parts)
+            for(unsigned int partNr=0; partNr<layer->parts.size(); partNr++)
             {
-                for (SliceLayerPart& other_part : other_layer.parts)
+                if (layer->parts[partNr].insets.size() > 0)
                 {
-                    if (!part.boundaryBox.hit(other_part.boundaryBox))
-                    {
-                        continue;
-                    }
-                    Polygons& infill = other_part.infill_area;
-                    Polygons new_outline = part.outline.intersection(infill);
-                    if (new_outline.size() == 1)
-                    {
-                        PolygonsPart outline_part_here;
-                        outline_part_here.add(new_outline[0]);
-                        new_parts.push_back(outline_part_here);
-                    }
-                    else if (new_outline.size() > 1)
-                    {
-                        std::vector<PolygonsPart> new_parts_here = new_outline.splitIntoParts();
-                        for (PolygonsPart& new_part_here : new_parts_here)
-                        {
-                            new_parts.push_back(new_part_here);
-                        }
-                    }
-                    infill = infill.difference(part.outline);
-                    other_part.infill_area_per_combine.back() = infill;
+                    sendPolygons(Inset0Type, layer_nr, layer->parts[partNr].insets[0], line_width_0);
+                    for(unsigned int inset=1; inset<layer->parts[partNr].insets.size(); inset++)
+                        sendPolygons(InsetXType, layer_nr, layer->parts[partNr].insets[inset], line_width_x);
                 }
             }
         }
-        
-        layer.parts.clear();
-        for (PolygonsPart& part : new_parts)
-        {
-            layer.parts.emplace_back();
-            layer.parts.back().outline = part;
-            layer.parts.back().boundaryBox.calculate(part);
-        }
-    }
-    
-}
-
-void FffPolygonGenerator::processDerivedWallsSkinInfill(SliceMeshStorage& mesh, size_t total_layers)
-{
-    // combine infill
-    unsigned int combined_infill_layers = mesh.getSettingInMicrons("infill_sparse_thickness") / std::max(getSettingInMicrons("layer_height"), 1); //How many infill layers to combine to obtain the requested sparse thickness.
-    combineInfillLayers(mesh,combined_infill_layers);
-
-    // fuzzy skin
-    if (mesh.getSettingBoolean("magic_fuzzy_skin_enabled"))
-    {
-        processFuzzyWalls(mesh);
-    }
-}
-
-void FffPolygonGenerator::processInsets(SliceMeshStorage& mesh, unsigned int layer_nr) 
-{
-    SliceLayer* layer = &mesh.layers[layer_nr];
-    if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::SURFACE)
-    {
-        int inset_count = mesh.getSettingAsCount("wall_line_count");
-        if (mesh.getSettingBoolean("magic_spiralize") && static_cast<int>(layer_nr) < mesh.getSettingAsCount("bottom_layers") && layer_nr % 2 == 1)//Add extra insets every 2 layers when spiralizing, this makes bottoms of cups watertight.
-            inset_count += 5;
-        int line_width_x = mesh.getSettingInMicrons("wall_line_width_x");
-        int line_width_0 = mesh.getSettingInMicrons("wall_line_width_0");
-        if (mesh.getSettingBoolean("alternate_extra_perimeter"))
-            inset_count += layer_nr % 2; 
-        bool recompute_outline_based_on_outer_wall = mesh.getSettingBoolean("support_enable");
-        WallsComputation walls_computation(mesh.getSettingInMicrons("wall_0_inset"), line_width_0, line_width_x, inset_count, recompute_outline_based_on_outer_wall);
-        walls_computation.generateInsets(layer);
-    }
-    if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::NORMAL)
-    {
-        for (PolygonRef polyline : layer->openPolyLines)
-        {
-            Polygons segments;
-            for (unsigned int point_idx = 1; point_idx < polyline.size(); point_idx++)
+        else 
+        { // only send polygon data
+            SliceLayer* layer = &mesh.layers[layer_nr];
+            for(SliceLayerPart& part : layer->parts)
             {
-                PolygonRef segment = segments.newPoly();
-                segment.add(polyline[point_idx-1]);
-                segment.add(polyline[point_idx]);
+                sendPolygons(Inset0Type, layer_nr, part.outline, mesh.getSettingInMicrons("wall_line_width_0"));
+            }
+        }
+        if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::NORMAL)
+        {
+            for (PolygonRef polyline : layer->openPolyLines)
+            {
+                Polygons segments;
+                for (unsigned int point_idx = 1; point_idx < polyline.size(); point_idx++)
+                {
+                    PolygonRef segment = segments.newPoly();
+                    segment.add(polyline[point_idx-1]);
+                    segment.add(polyline[point_idx]);
+                }
+                sendPolygons(Inset0Type, layer_nr, segments, mesh.getSettingInMicrons("wall_line_width_0"));
             }
         }
     }
 }
 
-void FffPolygonGenerator::removeEmptyFirstLayers(SliceDataStorage& storage, const int layer_height, unsigned int& total_layers)
+void FffPolygonGenerator::removeEmptyFirstLayers(SliceDataStorage& storage, int layer_height, unsigned int totalLayers)
 { 
     int n_empty_first_layers = 0;
-    for (unsigned int layer_idx = 0; layer_idx < total_layers; layer_idx++)
+    for (unsigned int layer_idx = 0; layer_idx < totalLayers; layer_idx++)
     { 
         bool layer_is_empty = true;
         for (SliceMeshStorage& mesh : storage.meshes)
@@ -423,34 +297,50 @@ void FffPolygonGenerator::removeEmptyFirstLayers(SliceDataStorage& storage, cons
                 layer.printZ -= n_empty_first_layers * layer_height;
             }
         }
-        total_layers -= n_empty_first_layers;
+        totalLayers -= n_empty_first_layers;
     }
 }
   
-void FffPolygonGenerator::processSkinsAndInfill(SliceMeshStorage& mesh, unsigned int layer_nr) 
+void FffPolygonGenerator::processSkins(SliceDataStorage& storage, unsigned int layer_nr) 
 {
-    if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") == ESurfaceMode::SURFACE) 
-    { 
-        return;
-    }
-    
-    int wall_line_count = mesh.getSettingAsCount("wall_line_count");
-    int skin_extrusion_width = mesh.getSettingInMicrons("skin_line_width");
-    int innermost_wall_extrusion_width = (wall_line_count == 1)? mesh.getSettingInMicrons("wall_line_width_0") : mesh.getSettingInMicrons("wall_line_width_x");
-    generateSkins(layer_nr, mesh, skin_extrusion_width, mesh.getSettingAsCount("bottom_layers"), mesh.getSettingAsCount("top_layers"), wall_line_count, innermost_wall_extrusion_width, mesh.getSettingAsCount("skin_outline_count"), mesh.getSettingBoolean("skin_no_small_gaps_heuristic"));
-    if (mesh.getSettingInMicrons("infill_line_distance") > 0)
+    for(SliceMeshStorage& mesh : storage.meshes)
     {
-        int infill_skin_overlap = 0;
-        bool infill_is_dense = mesh.getSettingInMicrons("infill_line_distance") < mesh.getSettingInMicrons("infill_line_width") + 10;
-        if (!infill_is_dense && mesh.getSettingAsFillMethod("infill_pattern") != EFillMethod::CONCENTRIC)
+        if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") == ESurfaceMode::SURFACE) { continue; }
+        
+        int extrusionWidth = mesh.getSettingInMicrons("wall_line_width_x");
+        int extrusionWidth_infill = mesh.getSettingInMicrons("infill_line_width");
+        generateSkins(layer_nr, mesh, extrusionWidth, mesh.getSettingAsCount("bottom_layers"), mesh.getSettingAsCount("top_layers"), mesh.getSettingAsCount("skin_outline_count"), mesh.getSettingBoolean("remove_overlapping_walls_0_enabled"), mesh.getSettingBoolean("remove_overlapping_walls_x_enabled"));
+        if (mesh.getSettingInMicrons("infill_line_distance") > 0)
         {
-            infill_skin_overlap = skin_extrusion_width / 2;
+            int infill_skin_overlap = 0;
+            if (mesh.getSettingInMicrons("infill_line_distance") > mesh.getSettingInMicrons("infill_line_width") + 10)
+            {
+                infill_skin_overlap = extrusionWidth / 2;
+            }
+            generateInfill(layer_nr, mesh, extrusionWidth_infill, infill_skin_overlap);
+            if (mesh.getSettingString("fill_perimeter_gaps") == "Skin")
+            {
+                generatePerimeterGaps(layer_nr, mesh, extrusionWidth, mesh.getSettingAsCount("bottom_layers"), mesh.getSettingAsCount("top_layers"));
+            }
+            else if (mesh.getSettingString("fill_perimeter_gaps") == "Everywhere")
+            {
+                generatePerimeterGaps(layer_nr, mesh, extrusionWidth, 0, 0);
+            }
+        }
+
+        SliceLayer& layer = mesh.layers[layer_nr];
+        for(SliceLayerPart& part : layer.parts)
+        {
+//             sendPolygons(InfillType, layer_nr, part.infill_area[0], extrusionWidth_infill); // sends the outline, not the actual infill
+            for (SkinPart& skin_part : part.skin_parts)
+            {
+                sendPolygons(SkinType, layer_nr, skin_part.outline, extrusionWidth);
+            }
         }
-        generateInfill(layer_nr, mesh, innermost_wall_extrusion_width, infill_skin_overlap, wall_line_count);
     }
 }
 
-void FffPolygonGenerator::processOozeShield(SliceDataStorage& storage, unsigned int total_layers)
+void FffPolygonGenerator::processOozeShield(SliceDataStorage& storage, unsigned int totalLayers)
 {
     if (!getSettingBoolean("ooze_shield_enabled"))
     {
@@ -459,28 +349,28 @@ void FffPolygonGenerator::processOozeShield(SliceDataStorage& storage, unsigned
     
     int ooze_shield_dist = getSettingInMicrons("ooze_shield_dist");
     
-    for(unsigned int layer_nr=0; layer_nr<total_layers; layer_nr++)
+    for(unsigned int layer_nr=0; layer_nr<totalLayers; layer_nr++)
     {
         storage.oozeShield.push_back(storage.getLayerOutlines(layer_nr, true).offset(ooze_shield_dist));
     }
     
     int largest_printed_radius = MM2INT(1.0); // TODO: make var a parameter, and perhaps even a setting?
-    for(unsigned int layer_nr=0; layer_nr<total_layers; layer_nr++)
+    for(unsigned int layer_nr=0; layer_nr<totalLayers; layer_nr++)
     {
         storage.oozeShield[layer_nr] = storage.oozeShield[layer_nr].offset(-largest_printed_radius).offset(largest_printed_radius); 
     }
     int allowed_angle_offset = tan(getSettingInAngleRadians("ooze_shield_angle")) * getSettingInMicrons("layer_height");//Allow for a 60deg angle in the oozeShield.
-    for(unsigned int layer_nr=1; layer_nr<total_layers; layer_nr++)
+    for(unsigned int layer_nr=1; layer_nr<totalLayers; layer_nr++)
     {
         storage.oozeShield[layer_nr] = storage.oozeShield[layer_nr].unionPolygons(storage.oozeShield[layer_nr-1].offset(-allowed_angle_offset));
     }
-    for(unsigned int layer_nr=total_layers-1; layer_nr>0; layer_nr--)
+    for(unsigned int layer_nr=totalLayers-1; layer_nr>0; layer_nr--)
     {
         storage.oozeShield[layer_nr-1] = storage.oozeShield[layer_nr-1].unionPolygons(storage.oozeShield[layer_nr].offset(-allowed_angle_offset));
     }
 }
 
-void FffPolygonGenerator::processDraftShield(SliceDataStorage& storage, unsigned int total_layers)
+void FffPolygonGenerator::processDraftShield(SliceDataStorage& storage, unsigned int totalLayers)
 {
     int draft_shield_height = getSettingInMicrons("draft_shield_height");
     int draft_shield_dist = getSettingInMicrons("draft_shield_dist");
@@ -497,7 +387,7 @@ void FffPolygonGenerator::processDraftShield(SliceDataStorage& storage, unsigned
     int layer_skip = 500 / layer_height + 1;
     
     Polygons& draft_shield = storage.draft_protection_shield;
-    for (unsigned int layer_nr = 0; layer_nr < total_layers && layer_nr < max_screen_layer; layer_nr += layer_skip)
+    for (unsigned int layer_nr = 0; layer_nr < totalLayers && layer_nr < max_screen_layer; layer_nr += layer_skip)
     {
         draft_shield = draft_shield.unionPolygons(storage.getLayerOutlines(layer_nr, true));
     }
@@ -507,42 +397,37 @@ void FffPolygonGenerator::processDraftShield(SliceDataStorage& storage, unsigned
 
 void FffPolygonGenerator::processPlatformAdhesion(SliceDataStorage& storage)
 {
-    SettingsBaseVirtual* train = storage.meshgroup->getExtruderTrain(getSettingBoolean("adhesion_extruder_nr"));
     switch(getSettingAsPlatformAdhesion("adhesion_type"))
     {
     case EPlatformAdhesion::SKIRT:
-        if (train->getSettingInMicrons("draft_shield_height") == 0)
+        if (getSettingInMicrons("draft_shield_height") == 0)
         { // draft screen replaces skirt
-            generateSkirt(storage, train->getSettingInMicrons("skirt_gap"), train->getSettingAsCount("skirt_line_count"), train->getSettingInMicrons("skirt_minimal_length"));
+            generateSkirt(storage, getSettingInMicrons("skirt_gap"), getSettingAsCount("skirt_line_count"), getSettingInMicrons("skirt_minimal_length"));
         }
         break;
     case EPlatformAdhesion::BRIM:
-        generateSkirt(storage, 0, train->getSettingAsCount("brim_line_count"), train->getSettingInMicrons("skirt_minimal_length"));
+        generateSkirt(storage, 0, getSettingAsCount("brim_line_count"), getSettingInMicrons("skirt_minimal_length"));
         break;
     case EPlatformAdhesion::RAFT:
-        generateRaft(storage, train->getSettingInMicrons("raft_margin"));
+        generateRaft(storage, getSettingInMicrons("raft_margin"));
         break;
     }
     
     Polygons skirt_sent = storage.skirt[0];
     for (int extruder = 1; extruder < storage.meshgroup->getExtruderCount(); extruder++)
         skirt_sent.add(storage.skirt[extruder]);
+    sendPolygons(SkirtType, 0, skirt_sent, getSettingInMicrons("skirt_line_width"));
 }
 
 
-void FffPolygonGenerator::processFuzzyWalls(SliceMeshStorage& mesh)
+void FffPolygonGenerator::processFuzzySkin(SliceMeshStorage& mesh)
 {
-    if (mesh.getSettingAsCount("wall_line_count") == 0)
-    {
-        return;
-    }
     int64_t fuzziness = mesh.getSettingInMicrons("magic_fuzzy_skin_thickness");
     int64_t avg_dist_between_points = mesh.getSettingInMicrons("magic_fuzzy_skin_point_dist");
     int64_t min_dist_between_points = avg_dist_between_points * 3 / 4; // hardcoded: the point distance may vary between 3/4 and 5/4 the supplied value
     int64_t range_random_point_dist = avg_dist_between_points / 2;
-    for (unsigned int layer_nr = 0; layer_nr < mesh.layers.size(); layer_nr++)
+    for (SliceLayer& layer : mesh.layers)
     {
-        SliceLayer& layer = mesh.layers[layer_nr];
         for (SliceLayerPart& part : layer.parts)
         {
             Polygons results;
@@ -562,7 +447,7 @@ void FffPolygonGenerator::processFuzzyWalls(SliceMeshStorage& mesh)
                     for (int64_t p0pa_dist = dist_left_over; p0pa_dist < p0p1_size; p0pa_dist += min_dist_between_points + rand() % range_random_point_dist)
                     {
                         int r = rand() % (fuzziness * 2) - fuzziness;
-                        Point perp_to_p0p1 = turn90CCW(p0p1);
+                        Point perp_to_p0p1 = crossZ(p0p1);
                         Point fuzz = normal(perp_to_p0p1, r);
                         Point pa = *p0 + normal(p0p1, p0pa_dist) + fuzz;
                         result.add(pa);
@@ -591,5 +476,109 @@ void FffPolygonGenerator::processFuzzyWalls(SliceMeshStorage& mesh)
     }
 }
 
+void FffPolygonGenerator::bulgeWalls(std::vector< Slicer* > slicerList, MeshGroup* meshgroup)
+{
+    
+    assert(slicerList.size() == meshgroup->meshes.size());
+    for (unsigned int mesh_idx = 0; mesh_idx < slicerList.size(); mesh_idx++)
+    {
+        Slicer* slicer = slicerList[mesh_idx];
+        Mesh& mesh = meshgroup->meshes[mesh_idx];
+        
+        if (!mesh.getSettingBoolean("magic_bulge_walls"))
+        {
+//             continue; // TODO
+        }
+        
+        auto getBulging = [](Point xy, int z)
+        {
+            std::hash<int> hash_fn;
+            int cell_size = MM2INT(0.2);
+            int cell_dim = 5; // surrounding taken into account
+            double result = 0.0;
+            int bulging = MM2INT(10.0);
+            Point3 middle(xy.X / cell_size, xy.Y / cell_size, z / cell_size);
+            double total_weight = 0.0;
+            for (int x = middle.x - cell_dim; x < middle.x + cell_dim; x++)
+            {
+                for (int y = middle.y - cell_dim; y < middle.y + cell_dim; y++)
+                {
+                    for (int z = middle.z - cell_dim; z < middle.z + cell_dim; z++)
+                    {
+                        srand(x ^ (y << 8) ^ (z << 16)); // set seed
+                        int h = rand();
+//                         int h = hash_fn(x ^ (y << 8) ^ (z << 16));
+                        double r = (double(h % 200000 - 100000))/100000.0; // between -1 and 1
+                        double weight = sqrt(1.0 / (1.0 + static_cast<double>(((Point3(xy.X, xy.Y, z) - Point3(x,y,z)* cell_size)).vSize()) * 4));
+                        total_weight += weight;
+                        result += r * weight ;
+                    }
+                }
+            }
+            
+            return static_cast<int>(result / total_weight * bulging);
+//             return rand() % (bulging*2) - bulging;
+        };
+        
+        int64_t avg_dist_between_points = MM2INT(0.5); // mesh.getSettingInMicrons("magic_fuzzy_skin_point_dist");
+        int64_t min_dist_between_points = avg_dist_between_points * 3 / 4; // hardcoded: the point distance may vary between 3/4 and 5/4 the supplied value
+        int64_t range_random_point_dist = avg_dist_between_points / 2;
+        
+        int layer_height = mesh.getSettingInMicrons("layer_height");
+        
+        for (unsigned int layer_nr = 0; layer_nr < slicer->layers.size(); layer_nr++)
+        {
+            SlicerLayer& layer = slicer->layers[layer_nr];
+            Polygons& outlines = layer.polygonList;
+            Polygons results;
+            
+            int z_approx = layer_nr * layer_height;
+            
+            for (PolygonRef poly : outlines)
+            {
+                // generate points in between p0 and p1
+                PolygonRef result = results.newPoly();
+                
+                int64_t dist_left_over = rand() % (min_dist_between_points / 2); // the distance to be traversed on the line before making the first new point
+                Point* p0 = &poly.back();
+                for (Point& p1 : poly)
+                { // 'a' is the (next) new point between p0 and p1
+                    Point p0p1 = p1 - *p0;
+                    int64_t p0p1_size = vSize(p0p1);    
+                    int64_t dist_last_point = dist_left_over + p0p1_size * 2; // so that p0p1_size - dist_last_point evaulates to dist_left_over - p0p1_size
+                    for (int64_t p0pa_dist = dist_left_over; p0pa_dist < p0p1_size; p0pa_dist += min_dist_between_points + rand() % range_random_point_dist)
+                    {
+                        Point in_between = *p0 + normal(p0p1, p0pa_dist);
+                        int r = getBulging(in_between, z_approx);
+                        Point perp_to_p0p1 = crossZ(p0p1);
+                        Point fuzz = normal(perp_to_p0p1, r);
+                        Point pa = in_between + fuzz;
+                        result.add(pa);
+                        dist_last_point = p0pa_dist;
+                    }
+                    dist_left_over = p0p1_size - dist_last_point;
+                    
+                    p0 = &p1;
+                }
+                while (result.size() < 3 )
+                {
+                    unsigned int point_idx = poly.size() - 2;
+                    result.add(poly[point_idx]);
+                    if (point_idx == 0) { break; }
+                    point_idx--;
+                }
+                if (result.size() < 3)
+                {
+                    result.clear();
+                    for (Point& p : poly)
+                        result.add(p);
+                }
+            }
+            
+            outlines = results;
+        }
+    }
+}
+
 
 }//namespace cura

src/FffPolygonGenerator.h

@@ -4,18 +4,16 @@
 
 #include "MeshGroup.h"
 #include "utils/polygonUtils.h"
-#include "utils/NoCopy.h"
 #include "utils/gettime.h"
-#include "settings/settings.h"
+#include "settings.h"
 #include "sliceDataStorage.h"
 #include "commandSocket.h"
-#include "PrintFeature.h"
-#include "progress/ProgressEstimator.h"
-#include "progress/ProgressStageEstimator.h"
 
 namespace cura
 {
 
+class Slicer; // forward declaration
+    
 /*!
  * Primary stage in Fused Filament Fabrication processing: Polygons are generated.
  * The model is sliced and each slice consists of polygons representing the outlines: the boundaries between inside and outside the object.
@@ -25,16 +23,28 @@ namespace cura
  * 
  * The main function of this class is FffPolygonGenerator::generateAreas().
  */
-class FffPolygonGenerator : public SettingsMessenger, NoCopy
+class FffPolygonGenerator : public SettingsMessenger
 {
+private:
+    CommandSocket* commandSocket;
 public:
     /*!
-     * Basic constructor
+     * Basic constructor; doesn't set the FffAreaGenerator::commandSocket .
      */
     FffPolygonGenerator(SettingsBase* settings_)
     : SettingsMessenger(settings_)
+    , commandSocket(nullptr)
     {
     }
+    
+    /*!
+     * Set the FffAreaGenerator::commandSocket
+     */
+    void setCommandSocket(CommandSocket* socket)
+    {
+        commandSocket = socket;
+    }
+    
 
     /*!
      * Slice the \p object, process the outline information into inset perimeter polygons, support area polygons, etc. 
@@ -46,6 +56,17 @@ public:
     bool generateAreas(SliceDataStorage& storage, MeshGroup* object, TimeKeeper& timeKeeper);
   
 private:
+    /*!
+     * Send polygons over the command socket, if there is one.
+     * \param type The type of polygon to send
+     * \param layer_nr The layer number at which the polygons occur
+     * \param polygons The polygons to be sent
+     */
+    void sendPolygons(PolygonType type, int layer_nr, Polygons& polygons, int line_width)
+    {
+        if (commandSocket)
+            commandSocket->sendPolygons(type, layer_nr, polygons, line_width);
+    }
     
     /*!
      * Slice the \p object and store the outlines in the \p storage.
@@ -66,75 +87,42 @@ private:
      */
     void slices2polygons(SliceDataStorage& storage, TimeKeeper& timeKeeper);
     
-    /*!
-     * Processes the outline information as stored in the \p storage: generates inset perimeter polygons, skin and infill
-     * 
-     * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
-     * \param mesh_idx The index of the mesh to process in the vector of meshes in \p storage
-     * \param mesh_order The order in which the meshes are processed (used for infill meshes)
-     * \param total_layers The total number of layers over all objects
-     * \param inset_skin_progress_estimate The progress stage estimate calculator
-     */
-    void processBasicWallsSkinInfill(SliceDataStorage& storage, unsigned int mesh_idx, std::vector<unsigned int>& mesh_order, size_t total_layers, ProgressStageEstimator& inset_skin_progress_estimate);
-    
-    /*!
-     * Process the mesh to be an infill mesh: limit all outlines to within the infill of normal meshes and subtract their volume from the infill of those meshes
-     * 
-     * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
-     * \param mesh_idx The index of the mesh to process in the vector of meshes in \p storage
-     * \param mesh_order The order in which the meshes are processed
-     * \param total_layers The total number of layers over all objects
-     */
-    void processInfillMesh(SliceDataStorage& storage, unsigned int mesh_idx, std::vector<unsigned int>& mesh_order, size_t total_layers);
-    
-    /*!
-     * Process features which are derived from the basic walls, skin, and infill:
-     * fuzzy skin, infill combine
-     * 
-     * \param mesh Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
-     * \param total_layers The total number of layers over all objects
-     */
-    void processDerivedWallsSkinInfill(SliceMeshStorage& mesh, size_t total_layers);
-    
     /*!
      * Remove all bottom layers which are empty.
-     * 
-     * \warning Changes \p total_layers
-     * 
      * \param storage Input and Ouput parameter: stores all layers
      * \param layer_height The height of each layer
-     * \param total_layers The total number of layers
+     * \param totalLayers The total number of layers
      */
-    void removeEmptyFirstLayers(SliceDataStorage& storage, const int layer_height, unsigned int& total_layers);
+    void removeEmptyFirstLayers(SliceDataStorage& storage, int layer_height, unsigned int totalLayers);
     
     /*!
      * Generate the inset polygons which form the walls.
-     * \param mesh Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
+     * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
      * \param layer_nr The layer for which to generate the insets.
      */
-    void processInsets(SliceMeshStorage& mesh, unsigned int layer_nr);
+    void processInsets(SliceDataStorage& storage, unsigned int layer_nr);
 
     /*!
      * Generate the outline of the ooze shield.
      * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
-     * \param total_layers The total number of layers 
+     * \param totalLayers The total number of layers 
      */
-    void processOozeShield(SliceDataStorage& storage, unsigned int total_layers);
+    void processOozeShield(SliceDataStorage& storage, unsigned int totalLayers);
     
     /*!
      * Generate the skin areas.
-     * \param mesh Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
+     * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
      * \param layer_nr The layer for which to generate the skin areas.
      */
-    void processSkinsAndInfill(SliceMeshStorage& mesh, unsigned int layer_nr); 
+    void processSkins(SliceDataStorage& storage, unsigned int layer_nr); 
 
     /*!
      * Generate the polygons where the draft screen should be.
      * 
      * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
-     * \param total_layers The total number of layers 
+     * \param totalLayers The total number of layers 
      */
-    void processDraftShield(SliceDataStorage& storage, unsigned int total_layers);
+    void processDraftShield(SliceDataStorage& storage, unsigned int totalLayers);
     /*!
      * Generate the skirt/brim/raft areas/insets.
      * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
@@ -144,12 +132,15 @@ private:
     
     
     /*!
-     * Make the outer wall 'fuzzy'
+     * Special mode: Make the outer wall 'fuzzy'
      */
-    void processFuzzyWalls(SliceMeshStorage& mesh);
+    void processFuzzySkin(SliceMeshStorage& mesh);
     
     
-
+    /*!
+     * Special mode: bulge the outer walls
+     */
+    void bulgeWalls(std::vector< Slicer* > slicerList, MeshGroup* meshgroup);
     
 };
 }//namespace cura

src/FffProcessor.cpp

@@ -5,26 +5,12 @@ namespace cura
 
 FffProcessor FffProcessor::instance; // definition must be in cpp
 
-FffProcessor::FffProcessor()
-: SettingsBase("global")
-, polygon_generator(this)
-, gcode_writer(this)
-, meshgroup_number(0)
-{
-}
-
-int FffProcessor::getMeshgroupNr()
-{
-    return meshgroup_number;
-}
-
 
 std::string FffProcessor::getAllSettingsString(MeshGroup& meshgroup, bool first_meshgroup)
 {
     std::stringstream sstream;
     if (first_meshgroup)
     {
-        sstream << getAllLocalSettingsString(); // global settings
         sstream << " -g";
     }
     else 
@@ -40,7 +26,7 @@ std::string FffProcessor::getAllSettingsString(MeshGroup& meshgroup, bool first_
     for (unsigned int mesh_idx = 0; mesh_idx < meshgroup.meshes.size(); mesh_idx++)
     {
         Mesh& mesh = meshgroup.meshes[mesh_idx];
-        sstream << " -e" << mesh.getSettingAsIndex("extruder_nr") << " -l \"" << mesh_idx << "\"" << mesh.getAllLocalSettingsString();
+        sstream << " -e" << mesh.getSettingAsCount("extruder_nr") << " -l \"" << mesh_idx << "\"" << mesh.getAllLocalSettingsString();
     }
     sstream << "\n";
     return sstream.str();
@@ -71,43 +57,23 @@ bool FffProcessor::processFiles(const std::vector< std::string >& files)
 
 bool FffProcessor::processMeshGroup(MeshGroup* meshgroup)
 {
-    if (SHOW_ALL_SETTINGS) { logWarning(getAllSettingsString(*meshgroup, meshgroup_number == 0).c_str()); }
+    if (SHOW_ALL_SETTINGS) { logWarning(getAllSettingsString(*meshgroup, first_meshgroup).c_str()); }
     time_keeper.restart();
     if (!meshgroup)
         return false;
 
     TimeKeeper time_keeper_total;
-
-    polygon_generator.setParent(meshgroup);
-    gcode_writer.setParent(meshgroup);
-
-    bool empty = true;
-    for (Mesh& mesh : meshgroup->meshes)
-    {
-        if (!mesh.getSettingBoolean("infill_mesh"))
-        {
-            empty = false;
-        }
-    }
-    if (empty)
-    {
-        Progress::messageProgress(Progress::Stage::FINISH, 1, 1); // 100% on this meshgroup
-        log("Total time elapsed %5.2fs.\n", time_keeper_total.restart());
-
-        profile_string += getAllSettingsString(*meshgroup, meshgroup_number == 0);
-        return true;
-    }
     
     if (meshgroup->getSettingBoolean("wireframe_enabled"))
     {
         log("starting Neith Weaver...\n");
                     
         Weaver w(this);
-        w.weave(meshgroup);
+        w.weave(meshgroup, command_socket);
         
         log("starting Neith Gcode generation...\n");
         Wireframe2gcode gcoder(w, gcode_writer.gcode, this);
-        gcoder.writeGCode();
+        gcoder.writeGCode(command_socket);
         log("finished Neith Gcode generation...\n");
         
     } else 
@@ -118,25 +84,17 @@ bool FffProcessor::processMeshGroup(MeshGroup* meshgroup)
         {
             return false;
         }
+        gcode_writer.setCommandSocket(command_socket);
         
-        Progress::messageProgressStage(Progress::Stage::EXPORT, &time_keeper);
+        Progress::messageProgressStage(Progress::Stage::EXPORT, &time_keeper, command_socket);
         gcode_writer.writeGCode(storage, time_keeper);
     }
 
-    Progress::messageProgress(Progress::Stage::FINISH, 1, 1); // 100% on this meshgroup
-    if (CommandSocket::isInstantiated())
-    {
-        CommandSocket::getInstance()->flushGcode();
-        CommandSocket::getInstance()->sendLayerData();
-    }
+    Progress::messageProgress(Progress::Stage::FINISH, 1, 1, command_socket); //Report the GUI that a file has been fully processed.
     log("Total time elapsed %5.2fs.\n", time_keeper_total.restart());
 
-    profile_string += getAllSettingsString(*meshgroup, meshgroup_number == 0);
-    meshgroup_number++;
-
-    polygon_generator.setParent(this); // otherwise consequent getSetting calls (e.g. for finalize) will refer to non-existent meshgroup
-    gcode_writer.setParent(this); // otherwise consequent getSetting calls (e.g. for finalize) will refer to non-existent meshgroup
-
+    profile_string += getAllSettingsString(*meshgroup, first_meshgroup);
+    first_meshgroup = false;
     return true;
 }
 

src/FffProcessor.h

@@ -1,13 +1,13 @@
 #ifndef FFF_PROCESSOR_H
 #define FFF_PROCESSOR_H
 
-#include "settings/settings.h"
+#include "settings.h"
 #include "FffGcodeWriter.h"
 #include "FffPolygonGenerator.h"
 #include "commandSocket.h"
 #include "Weaver.h"
 #include "Wireframe2gcode.h"
-#include "progress/Progress.h"
+#include "Progress.h"
 #include "utils/gettime.h"
 #include "utils/NoCopy.h"
 
@@ -19,152 +19,76 @@ namespace cura {
 class FffProcessor : public SettingsBase , NoCopy
 {
 private:
-    /*!
-     * The FffProcessor used for the (current) slicing (The instance of this singleton)
-     */
     static FffProcessor instance; 
     
-    FffProcessor();
+    FffProcessor()
+    : polygon_generator(this)
+    , gcode_writer(this)
+    , first_meshgroup(true)
+    {
+        command_socket = NULL;
+    }
 public:
-    /*!
-     * Get the instance
-     * \return The instance
-     */
     static FffProcessor* getInstance() 
     { 
         return &instance; 
     }
-
-    /*!
-     * Get the index of the meshgroup currently being processed, starting at zero.
-     */
-    int getMeshgroupNr();
-
+    
 private:
-    /*!
-     * The polygon generator, which slices the models and generates all polygons to be printed and areas to be filled.
-     */
     FffPolygonGenerator polygon_generator;
-
-    /*!
-     * The gcode writer, which generates paths in layer plans in a buffer, which converts these paths into gcode commands.
-     */
     FffGcodeWriter gcode_writer;
-
-    /*!
-     * The index of the meshgroup currently being processed, starting at zero.
-     */
-    int meshgroup_number;
-
-    /*!
-     * A string containing all setting values passed to the engine in the format by which CuraEngine is called via the command line.
-     * 
-     * Used in debugging.
-     */
+    CommandSocket* command_socket;
+    
+    bool first_meshgroup;
+    
     std::string profile_string = "";
-
-    /*!
-     * Get all settings for the current meshgroup in the format by which CuraEngine is called via the command line.
-     * 
-     * Also includes all global settings if this is the first meshgroup.
-     * 
-     * Used in debugging.
-     * 
-     * \param meshgroup The meshgroup for which to stringify all settings
-     * \param first_meshgroup Whether this is the first meshgroup and all global settigns should be included as well
-     */
+    
     std::string getAllSettingsString(MeshGroup& meshgroup, bool first_meshgroup);
-
+    
 public:
-    /*!
-     * Get a string containing all setting values passed to the engine in the format by which CuraEngine is called via the command line.
-     * 
-     * \return A string containing all setting values passed to the engine in the format by which CuraEngine is called via the command line.
-     */
     std::string getProfileString() { return profile_string; }
-
-    /*!
-     * The stop watch used to time how long the different stages take to compute.
-     */
+    
     TimeKeeper time_keeper; // TODO: use singleton time keeper
-
-    /*!
-     * Reset the meshgroup number to the first meshgroup to start a new slicing.
-     */
-    void resetMeshGroupNumber()
+    
+    void resetFileNumber()
     {
-        meshgroup_number = 0;
+        gcode_writer.resetFileNumber();
     }
 
-    /*!
-     * Set the target to write gcode to: to a file.
-     * 
-     * Used when CuraEngine is used as command line tool.
-     * 
-     * \param filename The filename of the file to which to write the gcode.
-     */
+    void setCommandSocket(CommandSocket* socket)
+    {
+        command_socket = socket;
+        gcode_writer.setCommandSocket(socket);
+        polygon_generator.setCommandSocket(socket);
+    }
+    
     bool setTargetFile(const char* filename)
     {
         return gcode_writer.setTargetFile(filename);
     }
-
-    /*!
-     * Set the target to write gcode to: an output stream.
-     * 
-     * Used when CuraEngine is NOT used as command line tool.
-     * 
-     * \param stream The stream to write gcode to.
-     */
+    
     void setTargetStream(std::ostream* stream)
     {
         return gcode_writer.setTargetStream(stream);
     }
 
-    /*!
-     * Get the total extruded volume for a specific extruder in mm^3
-     * 
-     * Retractions and unretractions don't contribute to this.
-     * 
-     * \param extruder_nr The extruder number for which to get the total netto extruded volume
-     * \return total filament printed in mm^3
-     */
-    double getTotalFilamentUsed(int extruder_nr)
+    double getTotalFilamentUsed(int e)
     {
-        return gcode_writer.getTotalFilamentUsed(extruder_nr);
+        return gcode_writer.getTotalFilamentUsed(e);
     }
 
-    /*!
-     * Get the total estimated print time in seconds
-     * 
-     * \return total print time in seconds
-     */
     double getTotalPrintTime()
     {
         return gcode_writer.getTotalPrintTime();
     }
-
-    /*!
-     * Add the end gcode and set all temperatures to zero.
-     */
+    
     void finalize()
     {
         gcode_writer.finalize();
     }
 
-    /*!
-     * Process all files into one meshgroup
-     * 
-     * \warning Unused!
-     */
     bool processFiles(const std::vector<std::string> &files);
-
-    /*!
-     * Generate gcode for a given \p meshgroup
-     * The primary function of this class.
-     * 
-     * \param meshgroup The meshgroup for which to generate gcode
-     * \return Whether this function succeeded
-     */
+    
     bool processMeshGroup(MeshGroup* meshgroup);
 };
 

src/FlowTempGraph.h

@@ -1,77 +0,0 @@
-#ifndef FLOW_TEMP_GRAPH
-#define FLOW_TEMP_GRAPH
-
-#include <cassert>
-
-#include "utils/logoutput.h"
-
-namespace cura
-{
-
-/*!
- * Class representing a graph matching a flow to a temperature.
- * The graph generally consists of several linear line segments between points at which the temperature and flow are matched.
- */
-class FlowTempGraph
-{
-public:
-    struct Datum
-    {
-        double flow; //!< The flow in mm^3/s
-        double temp; //!< The temperature in *C
-        Datum(double flow, double temp)
-        : flow(flow)
-        , temp(temp)
-        {}
-    };
-    std::vector<Datum> data; //!< The points of the graph between which the graph is linearly interpolated
-
-    FlowTempGraph()
-    {}
-    
-    /*!
-     * Get the temperature corresponding to a specific flow.
-     * 
-     * For flows outside of the chart, the temperature at the minimal or maximal flow is returned.
-     * When the graph is empty, the @p material_print_temperature is returned.
-     * 
-     * \param flow the flow in mm^3/s
-     * \param material_print_temperature The default printing temp (backward compatibility for when the graph fails)
-     * \return the corresponding temp
-     */
-    double getTemp(double flow, double material_print_temperature, bool flow_dependent_temperature)
-    {
-        if (!flow_dependent_temperature || data.size() == 0)
-        {
-            return material_print_temperature;
-        }
-        if (data.size() == 1)
-        {
-            return data.front().temp;
-        }
-        if (flow < data.front().flow)
-        {
-            logWarning("Warning! Flow too low!\n"); // TODO
-            return data.front().temp;
-        }
-        Datum* last_datum = &data.front();
-        for (unsigned int datum_idx = 1; datum_idx < data.size(); datum_idx++)
-        {
-            Datum& datum = data[datum_idx];
-            if (datum.flow >= flow)
-            {
-                return last_datum->temp + (datum.temp - last_datum->temp) * (flow - last_datum->flow) / (datum.flow - last_datum->flow);
-            }
-            last_datum = &datum;
-        }
-        
-        logWarning("Warning! Flow too high!\n"); // TODO
-        return data.back().temp;
-    };
-};
-
-
-
-} // namespace cura
-
-#endif // FLOW_TEMP_GRAPH

src/LayerPlanBuffer.cpp

@@ -1,242 +0,0 @@
-/** Copyright (C) 2015 Ultimaker - Released under terms of the AGPLv3 License */
-
-#include "LayerPlanBuffer.h"
-#include "gcodeExport.h"
-#include "utils/logoutput.h"
-#include "FffProcessor.h"
-
-namespace cura {
-
-
-
-void LayerPlanBuffer::flush()
-{
-    if (buffer.size() > 0)
-    {
-        insertPreheatCommands(); // insert preheat commands of the very last layer
-    }
-    while (!buffer.empty())
-    {
-        buffer.front().writeGCode(gcode);
-        if (CommandSocket::isInstantiated())
-        {
-            CommandSocket::getInstance()->flushGcode();
-        }
-        buffer.pop_front();
-    }
-    
-}
-
-void LayerPlanBuffer::insertPreheatCommand(ExtruderPlan& extruder_plan_before, double time_after_extruder_plan_start, int extruder, double temp)
-{
-    double acc_time = 0.0;
-    for (unsigned int path_idx = 0; path_idx < extruder_plan_before.paths.size(); path_idx++)
-    {
-        GCodePath& path = extruder_plan_before.paths[path_idx];
-        acc_time += path.estimates.getTotalTime();
-        if (acc_time > time_after_extruder_plan_start)
-        {
-//                 logError("Inserting %f\t seconds too early!\n", acc_time - time_after_extruder_plan_start);
-            extruder_plan_before.insertCommand(path_idx, extruder, temp, false, acc_time - time_after_extruder_plan_start);
-            return;
-        }
-    }
-    extruder_plan_before.insertCommand(extruder_plan_before.paths.size(), extruder, temp, false); // insert at end of extruder plan if time_after_extruder_plan_start > extruder_plan.time 
-    // = special insert after all extruder plans
-}
-
-double LayerPlanBuffer::timeBeforeExtruderPlanToInsert(std::vector<GCodePlanner*>& layers, unsigned int layer_plan_idx, unsigned int extruder_plan_idx)
-{
-    ExtruderPlan& extruder_plan = layers[layer_plan_idx]->extruder_plans[extruder_plan_idx];
-    int extruder = extruder_plan.extruder;
-    double required_temp = extruder_plan.required_temp;
-    
-    unsigned int extruder_plan_before_idx = extruder_plan_idx - 1;
-    bool first_it = true;
-    double in_between_time = 0.0;
-    for (unsigned int layer_idx = layer_plan_idx; int(layer_idx) >= 0; layer_idx--)
-    {
-        GCodePlanner& layer = *layers[layer_idx];
-        if (!first_it)
-        {
-            extruder_plan_before_idx = layer.extruder_plans.size() - 1;
-        }
-        for ( ; int(extruder_plan_before_idx) >= 0; extruder_plan_before_idx--)
-        {
-            ExtruderPlan& extruder_plan = layer.extruder_plans[extruder_plan_before_idx];
-            if (extruder_plan.extruder == extruder)
-            {
-                return preheat_config.timeBeforeEndToInsertPreheatCommand_coolDownWarmUp(in_between_time, extruder, required_temp);
-            }
-            in_between_time += extruder_plan.estimates.getTotalTime();
-        }
-        first_it = false;
-    }
-    // The last extruder plan with the same extruder falls outside of the buffer
-    // assume the nozzle has cooled down to strandby temperature already.
-    return preheat_config.timeBeforeEndToInsertPreheatCommand_warmUp(preheat_config.getStandbyTemp(extruder), extruder, required_temp, false);
-    
-}
-
-void LayerPlanBuffer::insertPreheatCommand_singleExtrusion(ExtruderPlan& prev_extruder_plan, int extruder, double required_temp)
-{
-    // time_before_extruder_plan_end is halved, so that at the layer change the temperature will be half way betewen the two requested temperatures
-    double time_before_extruder_plan_end = 0.5 * preheat_config.timeBeforeEndToInsertPreheatCommand_warmUp(prev_extruder_plan.required_temp, extruder, required_temp, true);
-    double time_after_extruder_plan_start = prev_extruder_plan.estimates.getTotalTime() - time_before_extruder_plan_end;
-    if (time_after_extruder_plan_start < 0)
-    {
-        time_after_extruder_plan_start = 0; // don't override the extruder plan with same extruder of the previous layer
-    }
-        
-    insertPreheatCommand(prev_extruder_plan, time_after_extruder_plan_start, extruder, required_temp);
-}
-
-void LayerPlanBuffer::insertPreheatCommand_multiExtrusion(std::vector<GCodePlanner*>& layers, unsigned int layer_plan_idx, unsigned int extruder_plan_idx)
-{
-    ExtruderPlan& extruder_plan = layers[layer_plan_idx]->extruder_plans[extruder_plan_idx];
-    int extruder = extruder_plan.extruder;
-    double required_temp = extruder_plan.required_temp;
-    
-    extruder_plan.insertCommand(0, extruder, required_temp, true); // just after the extruder switch, wait for the destination temperature to be reached
-    
-    double time_before_extruder_plan_to_insert = timeBeforeExtruderPlanToInsert(layers, layer_plan_idx, extruder_plan_idx);
-    
-    unsigned int extruder_plan_before_idx = extruder_plan_idx - 1;
-    bool first_it = true; // Whether it's the first iteration of the for loop below
-    for (unsigned int layer_idx = layer_plan_idx; int(layer_idx) >= 0; layer_idx--)
-    {
-        GCodePlanner& layer = *layers[layer_idx];
-        if (!first_it)
-        {
-            extruder_plan_before_idx = layer.extruder_plans.size() - 1;
-        }
-        for ( ; int(extruder_plan_before_idx) >= 0; extruder_plan_before_idx--)
-        {
-            ExtruderPlan& extruder_plan_before = layer.extruder_plans[extruder_plan_before_idx];
-            assert (extruder_plan_before.extruder != extruder);
-            
-            double time_here = extruder_plan_before.estimates.getTotalTime();
-            if (time_here >= time_before_extruder_plan_to_insert)
-            {
-                insertPreheatCommand(extruder_plan_before, time_here - time_before_extruder_plan_to_insert, extruder, required_temp);
-                return;
-            }
-            time_before_extruder_plan_to_insert -= time_here;
-            
-        }
-        first_it = false;
-    }
-    
-    // time_before_extruder_plan_to_insert falls before all plans in the buffer
-    ExtruderPlan& first_extruder_plan = layers[0]->extruder_plans[0];
-    first_extruder_plan.insertCommand(0, extruder, required_temp, false); // insert preheat command at verfy beginning of buffer
-}
-
-void LayerPlanBuffer::insertPreheatCommand(std::vector<GCodePlanner*>& layers, unsigned int layer_plan_idx, unsigned int extruder_plan_idx)
-{   
-    ExtruderPlan& extruder_plan = layers[layer_plan_idx]->extruder_plans[extruder_plan_idx];
-    int extruder = extruder_plan.extruder;
-    double required_temp = extruder_plan.required_temp;
-    
-    
-    ExtruderPlan* prev_extruder_plan = nullptr;
-    if (extruder_plan_idx == 0)
-    {
-        if (layer_plan_idx == 0)
-        { // the very first extruder plan of the current meshgroup
-            for (int extruder_idx = 0; extruder_idx < getSettingAsCount("machine_extruder_count"); extruder_idx++)
-            { // set temperature of the first nozzle, turn other nozzles down
-                if (FffProcessor::getInstance()->getMeshgroupNr() == 0)
-                {
-                    // override values from GCodeExport::setInitialTemps
-                    // the first used extruder should be set to the required temp in the start gcode
-                    // see  FffGcodeWriter::processStartingCode
-                    if (extruder_idx == extruder)
-                    {
-                        gcode.setInitialTemp(extruder_idx, required_temp);
-                    }
-                    else 
-                    {
-                        gcode.setInitialTemp(extruder_idx, preheat_config.getStandbyTemp(extruder_idx));
-                    }
-                }
-                else
-                {
-                    if (extruder_idx == extruder)
-                    {
-                        extruder_plan.insertCommand(0, extruder, required_temp, true);
-                    }
-                    else 
-                    {
-                        extruder_plan.insertCommand(0, extruder_idx, preheat_config.getStandbyTemp(extruder_idx), false);
-                    }
-                }
-            }
-            return;
-        }
-        prev_extruder_plan = &layers[layer_plan_idx - 1]->extruder_plans.back();
-    }
-    else 
-    {
-        prev_extruder_plan = &layers[layer_plan_idx]->extruder_plans[extruder_plan_idx - 1];
-    }
-    assert(prev_extruder_plan != nullptr);
-    
-    int prev_extruder = prev_extruder_plan->extruder;
-    
-    if (prev_extruder != extruder)
-    { // set previous extruder to standby temperature
-        prev_extruder_plan->insertCommand(prev_extruder_plan->paths.size(), prev_extruder, preheat_config.getStandbyTemp(prev_extruder), false);
-    }
-    
-    if (prev_extruder == extruder)
-    {
-        if (preheat_config.usesFlowDependentTemp(extruder))
-        {
-            insertPreheatCommand_singleExtrusion(*prev_extruder_plan, extruder, required_temp);
-        }
-    }
-    else 
-    {
-        insertPreheatCommand_multiExtrusion(layers, layer_plan_idx, extruder_plan_idx);
-    }
-    
-}
-
-void LayerPlanBuffer::insertPreheatCommands()
-{
-    if (buffer.back().extruder_plans.size() == 0 || (buffer.back().extruder_plans.size() == 1 && buffer.back().extruder_plans[0].paths.size() == 0))
-    { // disregard empty layer
-        buffer.pop_back();
-        return;
-    }
-    
-    std::vector<GCodePlanner*> layers;
-    layers.reserve(buffer.size());
-    for (GCodePlanner& layer_plan : buffer)
-    {
-        layers.push_back(&layer_plan);
-    }
-    
-    unsigned int layer_idx = layers.size() - 1;
-
-    // insert commands for all extruder plans on this layer
-    GCodePlanner& layer_plan = *layers[layer_idx];
-    for (unsigned int extruder_plan_idx = 0; extruder_plan_idx < layer_plan.extruder_plans.size(); extruder_plan_idx++)
-    {
-        ExtruderPlan& extruder_plan = layer_plan.extruder_plans[extruder_plan_idx];
-        double time = extruder_plan.estimates.getTotalUnretractedTime();
-        if (time <= 0.0 
-            || extruder_plan.estimates.getMaterial() == 0.0 // extruder plan only consists of moves (when an extruder switch occurs at the beginning of a layer)
-        )
-        {
-            continue;
-        }
-        double avg_flow = extruder_plan.estimates.getMaterial() / time; // TODO: subtract retracted travel time
-        extruder_plan.required_temp = preheat_config.getTemp(extruder_plan.extruder, avg_flow);
-        
-        insertPreheatCommand(layers, layer_idx, extruder_plan_idx);
-    }
-}
-
-} // namespace cura

src/LayerPlanBuffer.h

@@ -1,133 +0,0 @@
-#ifndef LAYER_PLAN_BUFFER_H
-#define LAYER_PLAN_BUFFER_H
-
-#include <list>
-
-#include "settings/settings.h"
-#include "commandSocket.h"
-
-#include "gcodeExport.h"
-#include "gcodePlanner.h"
-#include "MeshGroup.h"
-
-#include "Preheat.h"
-
-namespace cura 
-{
-
-class LayerPlanBuffer : SettingsMessenger
-{
-    GCodeExport& gcode;
-    
-    Preheat preheat_config; //!< the nozzle and material temperature settings for each extruder train.
-    
-    static constexpr unsigned int buffer_size = 5; // should be as low as possible while still allowing enough time in the buffer to heat up from standby temp to printing temp // TODO: hardcoded value
-    // this value should be higher than 1, cause otherwise each layer is viewed as the first layer and no temp commands are inserted.
-    
-public:
-    std::list<GCodePlanner> buffer; //!< The buffer containing several layer plans (GCodePlanner) before writing them to gcode.
-    
-    LayerPlanBuffer(SettingsBaseVirtual* settings, GCodeExport& gcode)
-    : SettingsMessenger(settings)
-    , gcode(gcode)
-    { }
-    
-    void setPreheatConfig(MeshGroup& settings)
-    {
-        preheat_config.setConfig(settings);
-    }
-    
-    /*!
-     * Place a new layer plan (GcodePlanner) by constructing it with the given arguments.
-     * Pop back the oldest layer plan is it exceeds the buffer size and write it to gcode.
-     */
-    template<typename... Args>
-    GCodePlanner& emplace_back(Args&&... constructor_args)
-    {
-        if (buffer.size() > 0)
-        {
-            insertPreheatCommands(); // insert preheat commands of the just completed layer plan (not the newly emplaced one)
-        }
-        buffer.emplace_back(constructor_args...);
-        if (buffer.size() > buffer_size)
-        {
-            buffer.front().writeGCode(gcode);
-            if (CommandSocket::isInstantiated())
-            {
-                CommandSocket::getInstance()->flushGcode();
-            }
-            buffer.pop_front();
-        }
-        return buffer.back();
-    }
-    
-    /*!
-     * Write all remaining layer plans (GCodePlanner) to gcode and empty the buffer.
-     */
-    void flush();
-    
-    /*!
-     * Insert the preheat command for @p extruder into @p extruder_plan_before
-     * 
-     * \param extruder_plan_before An extruder plan before the extruder plan for which the temperature is computed, in which to insert the preheat command
-     * \param time_after_extruder_plan_start The time after the start of the extruder plan, before which to insert the preheat command
-     * \param extruder The extruder for which to set the temperature
-     * \param temp The temperature of the preheat command
-     */
-    void insertPreheatCommand(ExtruderPlan& extruder_plan_before, double time_after_extruder_plan_start, int extruder, double temp);
-    
-    /*!
-     * Compute the time needed to preheat, based either on the time the extruder has been on standby 
-     * or based on the temp of the previous extruder plan which has the same extruder nr.
-     * 
-     * \param layers The layers in the buffer, moved to a vector
-     * \param layer_plan_idx The index into @p layers in which to find the extruder plan
-     * \param extruder_plan_idx The index of the extruder plan in the layer corresponding to @p layer_plan_idx for which to find the preheat time needed
-     * \return the time needed to preheat
-     */
-    double timeBeforeExtruderPlanToInsert(std::vector<GCodePlanner*>& layers, unsigned int layer_plan_idx, unsigned int extruder_plan_idx);
-    
-    /*!
-     * For two consecutive extruder plans of the same extruder (so on different layers), 
-     * preheat the extruder to the temperature corresponding to the average flow of the second extruder plan.
-     * 
-     * The preheat commands are inserted such that the middle of the temperature change coincides with the start of the next layer.
-     * 
-     * \param prev_extruder_plan The former extruder plan (of the former layer)
-     * \param extruder The extruder for which too set the temperature
-     * \param required_temp The required temperature for the second extruder plan
-     */
-    void insertPreheatCommand_singleExtrusion(ExtruderPlan& prev_extruder_plan, int extruder, double required_temp);
-    
-    /*!
-     * Insert the preheat command for an extruder plan which is preceded by an extruder plan with a different extruder.
-     * Find the time window in which this extruder hasn't been used
-     * and compute at what time the preheat command needs to be inserted.
-     * Then insert the preheat command in the right extruder plan.
-     * 
-     * \param layers The layers in the buffer, moved to a vector
-     * \param layer_plan_idx The index into @p layers in which to find the extruder plan
-     * \param extruder_plan_idx The index of the extruder plan in the layer corresponding to @p layer_plan_idx for which to find the preheat time needed
-     */
-    void insertPreheatCommand_multiExtrusion(std::vector<GCodePlanner*>& layers, unsigned int layer_plan_idx, unsigned int extruder_plan_idx);
-    
-    /*!
-     * Insert the preheat command for the extruder plan corersponding to @p extruder_plan_idx of the layer corresponding to @p layer_plan_idx.
-     * 
-     * \param layers The layers of the buffer, moved to a temporary vector (from lower to upper layers)
-     * \param layer_plan_idx The index of the layer plan for which to generate a preheat command
-     * \param extruder_plan_idx The index of the extruder plan in the layer corresponding to @p layer_plan_idx for which to generate the preheat command
-     */
-    void insertPreheatCommand(std::vector<GCodePlanner*>& layers, unsigned int layer_plan_idx, unsigned int extruder_plan_idx);
-
-    /*!
-     * Insert the preheat commands for the last added layer (unless that layer was empty)
-     */
-    void insertPreheatCommands();
-};
-
-
-
-} // namespace cura
-
-#endif // LAYER_PLAN_BUFFER_H

src/MergeInfillLines.cpp

@@ -2,8 +2,6 @@
 
 #include <algorithm> // min
 
-#include "utils/linearAlg2D.h"
-
 namespace cura
 {
     
@@ -14,7 +12,6 @@ void MergeInfillLines::writeCompensatedMove(Point& to, double speed, GCodePath&
     double speed_mod = old_line_width / new_line_width_mm;
     double extrusion_mod = new_line_width_mm / old_line_width;
     double new_speed = std::min(speed * speed_mod, 150.0); // TODO: hardcoded value: max extrusion speed is 150 mm/s = 9000 mm/min
-    sendPolygon(last_path.config->type, gcode.getPositionXY(), to, last_path.getLineWidth());
     gcode.writeMove(to, new_speed, last_path.getExtrusionMM3perMM() * extrusion_mod);
 }
     
@@ -23,8 +20,10 @@ bool MergeInfillLines::mergeInfillLines(double speed, unsigned int& path_idx)
     Point prev_middle;
     Point last_middle;
     int64_t line_width;
-
-    if (isConvertible(path_idx, prev_middle, last_middle, line_width, false))
+    
+    MergeInfillLines merger(gcode, paths, travelConfig, nozzle_size);
+    
+    if (merger.isConvertible(path_idx, prev_middle, last_middle, line_width, false))
     {
         //   path_idx + 3 is the index of the second extrusion move to be converted in combination with the first
         {
@@ -40,150 +39,75 @@ bool MergeInfillLines::mergeInfillLines(double speed, unsigned int& path_idx)
         }
         
         path_idx += 2;
-        extruder_plan.handleInserts(path_idx, gcode);
-        for (; isConvertible(path_idx, prev_middle, last_middle, line_width, true); path_idx += 2)
+        for (; merger.isConvertible(path_idx, prev_middle, last_middle, line_width, true); path_idx += 2)
         {
-            extruder_plan.handleInserts(path_idx, gcode);
             GCodePath& last_path = paths[path_idx + 3];
             writeCompensatedMove(last_middle, speed, last_path, line_width);
         }
         path_idx = path_idx + 1; // means that the next path considered is the travel path after the converted extrusion path corresponding to the updated path_idx
-        extruder_plan.handleInserts(path_idx, gcode);
         return true;
     }
     return false;
 };
 
-bool MergeInfillLines::isConvertible(unsigned int path_idx_first_move, Point& first_middle, Point& second_middle, int64_t& resulting_line_width, bool use_second_middle_as_first)
+bool MergeInfillLines::isConvertible(unsigned int path_idx_first_move, Point& first_middle, Point& second_middle, int64_t& line_width, bool use_second_middle_as_first)
 {
+    int64_t max_line_width = nozzle_size * 3 / 2;
+    
+    
     unsigned int idx = path_idx_first_move;
-    if (idx + 3 > paths.size()-1) 
-    {
-        return false;
-    }
-    if (   paths[idx+0].config != &travelConfig // must be travel
-        || paths[idx+1].points.size() > 1       // extrusion path is single line
-        || paths[idx+1].config == &travelConfig // must be extrusion
-//        || paths[idx+2].points.size() > 1       // travel must be direct
-        || paths[idx+2].config != &travelConfig // must be travel
-        || paths[idx+3].points.size() > 1       // extrusion path is single line
-        || paths[idx+3].config == &travelConfig // must be extrusion
-        || paths[idx+1].config != paths[idx+3].config // both extrusion moves should have the same config
-    )
-    {
-        return false;
-    }
-
-    if (!(paths[idx+1].config->type == PrintFeatureType::Infill || paths[idx+1].config->type == PrintFeatureType::Skin))
-    { // only (skin) infill lines can be merged (note that the second extrusion line config is already checked to be the same as the first in code above)
-        return false;
-    }
-
-    if (paths[idx+1].space_fill_type != SpaceFillType::Lines || paths[idx+3].space_fill_type != SpaceFillType::Lines)
-    { // both extrusion moves must be of lines space filling type!
-        return false;
-    }
-
-    int64_t line_width = paths[idx+1].config->getLineWidth();
+    if (idx + 3 > paths.size()-1) return false;
+    if (paths[idx+0].config != &travelConfig) return false;
+    if (paths[idx+1].points.size() > 1) return false;
+    if (paths[idx+1].config == &travelConfig) return false;
+//                 if (paths[idx+2].points.size() > 1) return false;
+    if (paths[idx+2].config != &travelConfig) return false;
+    if (paths[idx+3].points.size() > 1) return false;
+    if (paths[idx+3].config == &travelConfig) return false;
     
     Point& a = paths[idx+0].points.back(); // first extruded line from
     Point& b = paths[idx+1].points.back(); // first extruded line to
     Point& c = paths[idx+2].points.back(); // second extruded line from
     Point& d = paths[idx+3].points.back(); // second extruded line to
-    
-    return isConvertible(a, b, c, d, line_width, first_middle, second_middle, resulting_line_width, use_second_middle_as_first);
-}
-
-bool MergeInfillLines::isConvertible(const Point& a, const Point& b, const Point& c, const Point& d, int64_t line_width, Point& first_middle, Point& second_middle, int64_t& resulting_line_width, bool use_second_middle_as_first)
-{
-    use_second_middle_as_first = false;
-    int64_t max_line_width = nozzle_size * 3 / 2;
-
     Point ab = b - a;
     Point cd = d - c;
-
-    if (b == c)
-    {
-        return false; // the line segments are connected!
-    }
-
-    int64_t ab_size = vSize(ab);
-    int64_t cd_size = vSize(cd);
-
-    if (ab_size > nozzle_size * 5 || cd_size > nozzle_size * 5)
-    {
-        return false; // infill lines are too long; otherwise infill lines might be merged when the next infill line is coincidentally shorter like |, would become \ ...
-    }
-
-    // if the lines are in the same direction then abs( dot(ab,cd) / |ab| / |cd| ) == 1
-    int64_t prod = dot(ab,cd);
-    if (std::abs(prod) + 400 < ab_size * cd_size) // 400 = 20*20, where 20 micron is the allowed inaccuracy in the dot product, introduced by the inaccurate point locations of a,b,c,d
-    {
-        return false; // extrusion moves not in the same or opposite diraction
-    }
     
-    // make lines in the same direction by flipping one
-    if (prod < 0)
-    {
-        ab = ab * -1;
-    }
-    else if (prod == 0)
-    {
-        return false; // lines are orthogonal!
-    }
-    else if (b == d || a == c)
-    {
-        return false; // the line segments are connected!
-    }
-
+    int64_t prod = dot(ab,cd);
+    if (std::abs(prod) + 400 < vSize(ab) * vSize(cd)) // 400 = 20*20, where 20 micron is the allowed inaccuracy in the dot product, introduced by the inaccurate point locations of a,b,c,d
+        return false; // extrusion moves not in the same or opposite diraction
+    if (prod < 0) { ab = ab * -1; }
+    
+    
+    Point infill_vector = (cd + ab) / 2;
+    
+    if (!shorterThen(infill_vector, 5 * nozzle_size)) return false; // infill lines too far apart
+                    
     first_middle = (use_second_middle_as_first)?
                     second_middle :
                     (a + b) / 2;
     second_middle = (c + d) / 2;
     
-    Point dir_vector_perp = turn90CCW(second_middle - first_middle);
+    Point dir_vector_perp = crossZ(second_middle - first_middle);
     int64_t dir_vector_perp_length = vSize(dir_vector_perp); // == dir_vector_length
-    if (dir_vector_perp_length == 0)
-    {
-        return false;
-    }
-    if (dir_vector_perp_length > 5 * nozzle_size)
-    {
-        return false; // infill lines too far apart
-    }
-
-    Point infill_vector = (cd + ab) / 2; // (similar to) average line / direction of the infill
-
-    // compute the resulting line width
-    resulting_line_width = std::abs( dot(dir_vector_perp, infill_vector) / dir_vector_perp_length );
-    if (resulting_line_width > max_line_width)
-    {
-        return false; // combined lines would be too wide
-    }
-    if (resulting_line_width == 0)
-    {
-        return false; // dot is zero, so lines are in each others extension, not next to eachother
-    }
-
-    // check whether two lines are adjacent (note: not 'line segments' but 'lines')
-    Point ac = c - first_middle;
-    Point infill_vector_perp = turn90CCW(infill_vector);
-    int64_t perp_proj = dot(ac, infill_vector_perp);
-    int64_t infill_vector_perp_length = vSize(infill_vector_perp);
-    if (std::abs(std::abs(perp_proj) / infill_vector_perp_length - line_width) > 20) // it should be the case that dot(ac, infill_vector_perp) / |infill_vector_perp| == line_width
-    {
-        return false; // lines are too far apart or too close together
+    if (dir_vector_perp_length == 0) return false;
+    if (dir_vector_perp_length > 5 * nozzle_size) return false; // infill lines too far apart
+    
+    
+    line_width = std::abs( dot(dir_vector_perp, infill_vector) / dir_vector_perp_length );
+    if (line_width > max_line_width) return false; // combined lines would be too wide
+    if (line_width == 0) return false; // dot is zero, so lines are in each others extension, not next to eachother
+    
+    { // check whether the two lines are adjacent
+        Point ca = first_middle - c;
+        double ca_size = vSizeMM(ca);
+        double cd_size = vSizeMM(cd);
+        double prod = INT2MM(dot(ca, cd));
+        double fraction = prod / ( ca_size * cd_size );
+        int64_t line2line_dist = MM2INT(cd_size * std::sqrt(1.0 - fraction * fraction));
+        
+        if (line2line_dist + 20 > paths[idx+1].config->getLineWidth()) return false; // there is a gap between the two lines
     }
     
-    // check whether the two line segments are adjacent.
-    // full infill in a narrow area might result in line segments with arbitrary distance between them
-    // the more the narrow passage in the area gets aligned with the infill direction, the further apart the line segments will be
-    // however, distant line segments might also be due to different narrow passages, so we limit the distance between merged line segments.
-    if (!LinearAlg2D::lineSegmentsAreCloserThan(a, b, c, d, line_width * 2))
-    {
-        return false;
-    }
-
     return true;
 };
 

src/MergeInfillLines.h

@@ -12,42 +12,22 @@ class MergeInfillLines
 {
 //     void merge(Point& from, Point& p0, Point& p1);
     GCodeExport& gcode; //!<  Where to write the combined line to
-    int layer_nr; //!< The current layer number
     std::vector<GCodePath>& paths; //!< The paths currently under consideration
-    ExtruderPlan& extruder_plan; //!< The extruder plan of the paths currently under consideration
-    
     GCodePathConfig& travelConfig; //!< The travel settings used to see whether a path is a travel path or an extrusion path
     int64_t nozzle_size; //!< The diameter of the hole in the nozzle
-
+    
+    
     /*!
      * Whether the next two extrusion paths are convertible to a single line segment, starting from the end point the of the last travel move at \p path_idx_first_move
      * \param path_idx_first_move Index into MergeInfillLines::paths to the travel before the two extrusion moves udner consideration
      * \param first_middle Output parameter: the middle of the first extrusion move
      * \param second_middle Input/Output parameter: outputs the middle of the second extrusion move; inputs \p first_middle so we don't have to compute it
-     * \param resulting_line_width Output parameter: The width of the resulting combined line (the average length of the lines combined)
+     * \param line_width Output parameter: The width of the resulting combined line (the average length of the lines combined)
      * \param use_second_middle_as_first Whether to use \p second_middle as input parameter for \p first_middle
      * \return Whether the next two extrusion paths are convertible to a single line segment, starting from the end point the of the last travel move at \p path_idx_first_move
      */
-    bool isConvertible(unsigned int path_idx_first_move, Point& first_middle, Point& second_middle, int64_t& resulting_line_width, bool use_second_middle_as_first = false);
-
-    /*!
-     * Whether the two consecutive extrusion paths (ab and cd) are convitrible to a single line segment.
-     * 
-     * Note: as an optimization the \p second_middle from the previous call to isConvertible can be used for \p first_middle, instead of recomputing it. 
-     * 
-     * \param a first from
-     * \param b first to
-     * \param c second from
-     * \param d second to
-     * \param line_width The line width of the moves
-     * \param first_middle Output parameter: the middle of the first extrusion move
-     * \param second_middle Input/Output parameter: outputs the middle of the second extrusion move; inputs \p first_middle so we don't have to compute it
-     * \param resulting_line_width Output parameter: The width of the resulting combined line (the average length of the lines combined)
-     * \param use_second_middle_as_first Whether to use \p second_middle as input parameter for \p first_middle
-     * \return Whether the next two extrusion paths are convertible to a single line segment, starting from the end point the of the last travel move at \p path_idx_first_move
-     */
-    bool isConvertible(const Point& a, const Point& b, const Point& c, const Point& d, int64_t line_width, Point& first_middle, Point& second_middle, int64_t& resulting_line_width, bool use_second_middle_as_first = false);
-
+    bool isConvertible(unsigned int path_idx_first_move, Point& first_middle, Point& second_middle, int64_t& line_width, bool use_second_middle_as_first);
+    
     /*!
      * Write an extrusion move with compensated width and compensated speed so that the material flow will be the same.
      * 
@@ -61,8 +41,8 @@ public:
     /*!
      * Simple constructor only used by MergeInfillLines::isConvertible to easily convey the environment
      */
-    MergeInfillLines(GCodeExport& gcode, int layer_nr, std::vector<GCodePath>& paths, ExtruderPlan& extruder_plan, GCodePathConfig& travelConfig, int64_t nozzle_size) 
-    : gcode(gcode), layer_nr(layer_nr), paths(paths), extruder_plan(extruder_plan), travelConfig(travelConfig), nozzle_size(nozzle_size) { }
+    MergeInfillLines(GCodeExport& gcode, std::vector<GCodePath>& paths,  GCodePathConfig& travelConfig, int64_t nozzle_size) 
+    : gcode(gcode), paths(paths), travelConfig(travelConfig), nozzle_size(nozzle_size) { }
     
     /*!
      * Check for lots of small moves and combine them into one large line.
@@ -78,21 +58,6 @@ public:
      */
     bool mergeInfillLines(double speed, unsigned int& path_idx);
     
-    /*!
-     * send a polygon through the command socket from the previous point to the given point
-     */
-    void sendPolygon(PrintFeatureType print_feature_type, Point from, Point to, int line_width)
-    {
-        if (CommandSocket::isInstantiated()) 
-        {
-            // we should send this travel as a non-retraction move
-            cura::Polygons pathPoly;
-            PolygonRef path = pathPoly.newPoly();
-            path.add(from);
-            path.add(to);
-            CommandSocket::getInstance()->sendPolygons(print_feature_type, layer_nr, pathPoly, line_width);
-        }
-    }
 };
 
 }//namespace cura

src/MeshGroup.cpp

@@ -28,120 +28,7 @@ void* fgets_(char* ptr, size_t len, FILE* f)
     return nullptr;
 }
 
-MeshGroup::MeshGroup(SettingsBaseVirtual* settings_base)
-: SettingsBase(settings_base, std::string("meshgroup"))
-, extruder_count(-1)
-{}
-
-MeshGroup::~MeshGroup()
-{
-    for (unsigned int extruder = 0; extruder < MAX_EXTRUDERS; extruder++)
-    {
-        if (extruders[extruder])
-        {
-            delete extruders[extruder];
-        }
-    }
-}
-
-int MeshGroup::getExtruderCount()
-{
-    if (extruder_count == -1)
-    {
-        extruder_count = getSettingAsCount("machine_extruder_count");
-    }
-    return extruder_count;
-}
-
-ExtruderTrain* MeshGroup::createExtruderTrain(unsigned int extruder_nr)
-    {
-        if (!extruders[extruder_nr])
-        {
-            extruders[extruder_nr] = new ExtruderTrain(this, extruder_nr);
-        }
-        return extruders[extruder_nr];
-    }
-
-ExtruderTrain* MeshGroup::getExtruderTrain(unsigned int extruder_nr)
-{
-    assert(extruders[extruder_nr]);
-    return extruders[extruder_nr];
-}
-
-const ExtruderTrain* MeshGroup::getExtruderTrain(unsigned int extruder_nr) const
-{
-    assert(extruders[extruder_nr]);
-    return extruders[extruder_nr];
-}
-
-Point3 MeshGroup::min() const
-{
-    if (meshes.size() < 1)
-    {
-        return Point3(0, 0, 0);
-    }
-    Point3 ret = meshes[0].min();
-    for(unsigned int i=1; i<meshes.size(); i++)
-    {
-        Point3 v = meshes[i].min();
-        ret.x = std::min(ret.x, v.x);
-        ret.y = std::min(ret.y, v.y);
-        ret.z = std::min(ret.z, v.z);
-    }
-    return ret;
-}
-
-Point3 MeshGroup::max() const
-{
-    if (meshes.size() < 1)
-    {
-        return Point3(0, 0, 0);
-    }
-    Point3 ret = meshes[0].max();
-    for(unsigned int i=1; i<meshes.size(); i++)
-    {
-        Point3 v = meshes[i].max();
-        ret.x = std::max(ret.x, v.x);
-        ret.y = std::max(ret.y, v.y);
-        ret.z = std::max(ret.z, v.z);
-    }
-    return ret;
-}
-
-void MeshGroup::clear()
-{
-    for(Mesh& m : meshes)
-    {
-        m.clear();
-    }
-}
-
-void MeshGroup::finalize()
-{
-    //If the machine settings have been supplied, offset the given position vertices to the center of vertices (0,0,0) is at the bed center.
-    Point3 meshgroup_offset(0, 0, 0);
-    if (!getSettingBoolean("machine_center_is_zero"))
-    {
-        meshgroup_offset.x = getSettingInMicrons("machine_width") / 2;
-        meshgroup_offset.y = getSettingInMicrons("machine_depth") / 2;
-    }
-    
-    // If a mesh position was given, put the mesh at this position in 3D space. 
-    for(Mesh& mesh : meshes)
-    {
-        Point3 mesh_offset(mesh.getSettingInMicrons("mesh_position_x"), mesh.getSettingInMicrons("mesh_position_y"), mesh.getSettingInMicrons("mesh_position_z"));
-        if (mesh.getSettingBoolean("center_object"))
-        {
-            Point3 object_min = mesh.min();
-            Point3 object_max = mesh.max();
-            Point3 object_size = object_max - object_min;
-            mesh_offset += Point3(-object_min.x - object_size.x / 2, -object_min.y - object_size.y / 2, -object_min.z);
-        }
-        mesh.offset(mesh_offset + meshgroup_offset);
-    }
-}
-
-bool loadMeshSTL_ascii(Mesh* mesh, const char* filename, const FMatrix3x3& matrix)
+bool loadMeshSTL_ascii(Mesh* mesh, const char* filename, FMatrix3x3& matrix)
 {
     FILE* f = fopen(filename, "rt");
     char buffer[1024];
@@ -174,41 +61,29 @@ bool loadMeshSTL_ascii(Mesh* mesh, const char* filename, const FMatrix3x3& matri
     return true;
 }
 
-bool loadMeshSTL_binary(Mesh* mesh, const char* filename, const FMatrix3x3& matrix)
+bool loadMeshSTL_binary(Mesh* mesh, const char* filename, FMatrix3x3& matrix)
 {
     FILE* f = fopen(filename, "rb");
-
-    fseek(f, 0L, SEEK_END);
-    long long file_size = ftell(f); //The file size is the position of the cursor after seeking to the end.
-    rewind(f); //Seek back to start.
-    size_t face_count = (file_size - 80 - sizeof(uint32_t)) / 50; //Subtract the size of the header. Every face uses exactly 50 bytes.
-
     char buffer[80];
+    uint32_t faceCount;
     //Skip the header
     if (fread(buffer, 80, 1, f) != 1)
     {
         fclose(f);
         return false;
     }
-
-    uint32_t reported_face_count;
-    //Read the face count. We'll use it as a sort of redundancy code to check for file corruption.
-    if (fread(&reported_face_count, sizeof(uint32_t), 1, f) != 1)
+    //Read the face count
+    if (fread(&faceCount, sizeof(uint32_t), 1, f) != 1)
     {
         fclose(f);
         return false;
     }
-    if (reported_face_count != face_count)
-    {
-        logWarning("Face count reported by file (%s) is not equal to actual face count (%s). File could be corrupt!\n", std::to_string(reported_face_count).c_str(), std::to_string(face_count).c_str());
-    }
-
     //For each face read:
     //float(x,y,z) = normal, float(X,Y,Z)*3 = vertexes, uint16_t = flags
     // Every Face is 50 Bytes: Normal(3*float), Vertices(9*float), 2 Bytes Spacer
-    mesh->faces.reserve(face_count);
-    mesh->vertices.reserve(face_count);
-    for (unsigned int i = 0; i < face_count; i++)
+    mesh->faces.reserve(faceCount);
+    mesh->vertices.reserve(faceCount);
+    for(unsigned int i=0;i<faceCount;i++)
     {
         if (fread(buffer, 50, 1, f) != 1)
         {
@@ -227,34 +102,13 @@ bool loadMeshSTL_binary(Mesh* mesh, const char* filename, const FMatrix3x3& matr
     return true;
 }
 
-bool loadMeshSTL(Mesh* mesh, const char* filename, const FMatrix3x3& matrix)
+bool loadMeshSTL(Mesh* mesh, const char* filename, FMatrix3x3& matrix)
 {
     FILE* f = fopen(filename, "r");
-    if (f == nullptr)
-    {
-        return false;
-    }
-
-    //Skip any whitespace at the beginning of the file.
-    unsigned long long num_whitespace = 0; //Number of whitespace characters.
-    unsigned char whitespace;
-    if (fread(&whitespace, 1, 1, f) != 1)
-    {
-        fclose(f);
-        return false;
-    }
-    while(isspace(whitespace))
-    {
-        num_whitespace++;
-        if (fread(&whitespace, 1, 1, f) != 1)
-        {
-            fclose(f);
-            return false;
-        }
-    }
-    fseek(f, num_whitespace, SEEK_SET); //Seek to the place after all whitespace (we may have just read too far).
-
     char buffer[6];
+    if (f == nullptr)
+        return false;
+
     if (fread(buffer, 5, 1, f) != 1)
     {
         fclose(f);
@@ -281,19 +135,22 @@ bool loadMeshSTL(Mesh* mesh, const char* filename, const FMatrix3x3& matrix)
     return loadMeshSTL_binary(mesh, filename, matrix);
 }
 
-bool loadMeshIntoMeshGroup(MeshGroup* meshgroup, const char* filename, const FMatrix3x3& transformation, SettingsBaseVirtual* object_parent_settings)
+bool loadMeshIntoMeshGroup(MeshGroup* meshgroup, const char* filename, FMatrix3x3& transformation, SettingsBaseVirtual* object_parent_settings)
 {
     const char* ext = strrchr(filename, '.');
     if (ext && (strcmp(ext, ".stl") == 0 || strcmp(ext, ".STL") == 0))
     {
-        Mesh mesh = object_parent_settings ? Mesh(object_parent_settings) : Mesh(meshgroup); //If we have object_parent_settings, use them as parent settings. Otherwise, just use meshgroup.
-        if(loadMeshSTL(&mesh,filename,transformation)) //Load it! If successful...
+        if (object_parent_settings)
         {
-            meshgroup->meshes.push_back(mesh);
-            return true;
+            meshgroup->meshes.emplace_back(object_parent_settings); // make new mesh with [object_parent_settings] as parent settings object
         }
+        else 
+        {
+            meshgroup->meshes.emplace_back(meshgroup); // make new mesh with [meshgroup] as parent settings object
+        }
+        return loadMeshSTL(&meshgroup->meshes[meshgroup->meshes.size()-1], filename, transformation);
     }
     return false;
 }
 
-}//namespace cura
+}//namespace cura

src/MeshGroup.h

@@ -2,7 +2,6 @@
 #ifndef MESH_GROUP_H
 #define MESH_GROUP_H
 
-#include "utils/NoCopy.h"
 #include "mesh.h"
 #include "ExtruderTrain.h"
 
@@ -15,34 +14,112 @@ namespace cura
  * One MeshGroup is a whole which is printed at once.
  * Generally there is one single MeshGroup, though when using one-at-a-time printing, multiple MeshGroups are processed consecutively.
  */
-class MeshGroup : public SettingsBase, NoCopy
+class MeshGroup : public SettingsBase
 {
     ExtruderTrain* extruders[MAX_EXTRUDERS] = {nullptr};
     int extruder_count;
 public:
-    int getExtruderCount();
+    int getExtruderCount()
+    {
+        if (extruder_count == -1)
+        {
+            extruder_count = getSettingAsCount("machine_extruder_count");
+        }
+        return extruder_count;
+    }
 
-    MeshGroup(SettingsBaseVirtual* settings_base);
+    MeshGroup(SettingsBaseVirtual* settings_base) 
+    : SettingsBase(settings_base)
+    , extruder_count(-1) 
+    {}
     
-    ~MeshGroup();
+    ~MeshGroup() 
+    {
+        for (unsigned int extruder = 0; extruder < MAX_EXTRUDERS; extruder++)
+        {
+            if (extruders[extruder])
+            {
+                delete extruders[extruder];
+            }
+        }
+    }
+    
+    ExtruderTrain* getExtruderTrain(unsigned int extruder_nr)
+    {
+        if (!extruders[extruder_nr])
+        {
+            extruders[extruder_nr] = new ExtruderTrain(this, extruder_nr);
+        }
+        return extruders[extruder_nr];
+    }
     
-    /*!
-     * Create a new extruder train for the @p extruder_nr, or return the one which already exists.
-     */
-    ExtruderTrain* createExtruderTrain(unsigned int extruder_nr);
-
-    ExtruderTrain* getExtruderTrain(unsigned int extruder_nr);
-
-    const ExtruderTrain* getExtruderTrain(unsigned int extruder_nr) const;
-
     std::vector<Mesh> meshes;
 
-    Point3 min() const; //! minimal corner of bounding box
-    Point3 max() const; //! maximal corner of bounding box
+    Point3 min() //! minimal corner of bounding box
+    {
+        if (meshes.size() < 1)
+        {
+            return Point3(0, 0, 0);
+        }
+        Point3 ret = meshes[0].min();
+        for(unsigned int i=1; i<meshes.size(); i++)
+        {
+            Point3 v = meshes[i].min();
+            ret.x = std::min(ret.x, v.x);
+            ret.y = std::min(ret.y, v.y);
+            ret.z = std::min(ret.z, v.z);
+        }
+        return ret;
+    }
+    Point3 max() //! maximal corner of bounding box
+    {
+        if (meshes.size() < 1)
+        {
+            return Point3(0, 0, 0);
+        }
+        Point3 ret = meshes[0].max();
+        for(unsigned int i=1; i<meshes.size(); i++)
+        {
+            Point3 v = meshes[i].max();
+            ret.x = std::max(ret.x, v.x);
+            ret.y = std::max(ret.y, v.y);
+            ret.z = std::max(ret.z, v.z);
+        }
+        return ret;
+    }
 
-    void clear();
+    void clear()
+    {
+        for(Mesh& m : meshes)
+        {
+            m.clear();
+        }
+    }
 
-    void finalize();
+    void finalize()
+    {
+        //If the machine settings have been supplied, offset the given position vertices to the center of vertices (0,0,0) is at the bed center.
+        Point3 meshgroup_offset(0, 0, 0);
+        if (!getSettingBoolean("machine_center_is_zero"))
+        {
+            meshgroup_offset.x = getSettingInMicrons("machine_width") / 2;
+            meshgroup_offset.y = getSettingInMicrons("machine_depth") / 2;
+        }
+        
+        // If a mesh position was given, put the mesh at this position in 3D space. 
+        for(Mesh& mesh : meshes)
+        {
+            Point3 mesh_offset(mesh.getSettingInMicrons("mesh_position_x"), mesh.getSettingInMicrons("mesh_position_y"), mesh.getSettingInMicrons("mesh_position_z"));
+            if (mesh.getSettingBoolean("center_object"))
+            {
+                Point3 object_min = mesh.min();
+                Point3 object_max = mesh.max();
+                Point3 object_size = object_max - object_min;
+                mesh_offset += Point3(-object_min.x - object_size.x / 2, -object_min.y - object_size.y / 2, -object_min.z);
+            }
+            mesh.offset(mesh_offset + meshgroup_offset);
+        }
+    }
 };
 
 /*!
@@ -54,7 +131,7 @@ public:
  * \param object_parent_settings (optional) The parent settings object of the new mesh. Defaults to \p meshgroup if none is given.
  * \return whether the file could be loaded
  */
-bool loadMeshIntoMeshGroup(MeshGroup* meshgroup, const char* filename, const FMatrix3x3& transformation, SettingsBaseVirtual* object_parent_settings = nullptr);
+bool loadMeshIntoMeshGroup(MeshGroup* meshgroup, const char* filename, FMatrix3x3& transformation, SettingsBaseVirtual* object_parent_settings = nullptr);
 
 }//namespace cura
 #endif//MESH_GROUP_H

src/Preheat.h

@@ -1,178 +0,0 @@
-#ifndef PREHEAT_H
-#define PREHEAT_H
-
-#include <cassert>
-#include <algorithm> // max
-
-#include "utils/logoutput.h"
-#include "MeshGroup.h"
-
-#include "FlowTempGraph.h"
-
-
-namespace cura 
-{
-
-
-
-/*!
- * Class for computing heatup and cooldown times used for computing the time the printer needs to heat up to a printing temperature.
- */
-class Preheat 
-{
-    /*!
-     * The nozzle and material temperature settings for an extruder train.
-     */
-    class Config
-    {
-    public:
-        double time_to_heatup_1_degree; //!< average time it takes to heat up one degree (in the range of normal print temperatures and standby temperature)
-        double time_to_cooldown_1_degree; //!< average time it takes to cool down one degree (in the range of normal print temperatures and standby temperature)
-        
-        double heatup_cooldown_time_mod_while_printing; //!< The time to be added to Preheat::time_to_heatup_1_degree and subtracted from Preheat::time_to_cooldown_1_degree to get the timings while printing
-
-        double standby_temp; //!< The temperature at which the nozzle rests when it is not printing.
-
-        double material_print_temperature; //!< default print temp (backward compatilibily)
-        
-        bool flow_dependent_temperature; //!< Whether to make the temperature dependent on flow
-    
-        FlowTempGraph flow_temp_graph; //!< The graph linking flows to corresponding temperatures
-    };
-
-    std::vector<Config> config_per_extruder;//!< the nozzle and material temperature settings for each extruder train.
-public:
-    /*!
-     * Get the standby temperature of an extruder train
-     * \param extruder the extruder train for which to get the standby tmep
-     * \return the standby temp
-     */
-    double getStandbyTemp(int extruder)
-    {
-        return config_per_extruder[extruder].standby_temp;
-    }
-    
-    /*!
-     * Set the nozzle and material temperature settings for each extruder train.
-     */
-    void setConfig(MeshGroup& settings)
-    {
-        for (int extruder_nr = 0; extruder_nr < settings.getExtruderCount(); extruder_nr++)
-        {
-            assert(settings.getExtruderTrain(extruder_nr) != nullptr);
-            ExtruderTrain& extruder_train = *settings.getExtruderTrain(extruder_nr);
-            config_per_extruder.emplace_back();
-            Config& config = config_per_extruder.back();
-            config.time_to_cooldown_1_degree = 1.0 / extruder_train.getSettingInSeconds("machine_nozzle_cool_down_speed"); // 0.5
-            config.time_to_heatup_1_degree = 1.0 / extruder_train.getSettingInSeconds("machine_nozzle_heat_up_speed"); // 0.5
-            config.heatup_cooldown_time_mod_while_printing = 1.0 / extruder_train.getSettingInSeconds("material_extrusion_cool_down_speed"); // 0.1
-            config.standby_temp = extruder_train.getSettingInSeconds("material_standby_temperature"); // 150
-            
-            config.material_print_temperature = extruder_train.getSettingInDegreeCelsius("material_print_temperature"); // 220
-            
-            config.flow_dependent_temperature = extruder_train.getSettingBoolean("material_flow_dependent_temperature"); 
-            
-            config.flow_temp_graph = extruder_train.getSettingAsFlowTempGraph("material_flow_temp_graph"); // [[0.1,180],[20,230]]
-        }
-    }
-    
-    bool usesFlowDependentTemp(int extruder_nr)
-    {
-        return config_per_extruder[extruder_nr].flow_dependent_temperature;
-    }
-private:
-    /*!
-     * Calculate time to heat up from standby temperature to a given temperature.
-     * Assumes @p temp is higher than the standby temperature.
-     * 
-     * \param extruder The extruder for which to get the time
-     * \param temp The temperature to be reached
-     */
-    double timeToHeatFromStandbyToPrintTemp(unsigned int extruder, double temp)
-    {
-        return (temp - config_per_extruder[extruder].standby_temp) * config_per_extruder[extruder].time_to_heatup_1_degree; 
-    }
-
-public:
-    
-    /*!
-     * Get the optimal temperature corresponding to a given average flow.
-     * \param extruder The extruder train
-     * \param flow The flow for which to get the optimal temperature
-     * \return The corresponding optimal temperature
-     */
-    double getTemp(unsigned int extruder, double flow)
-    {
-        return config_per_extruder[extruder].flow_temp_graph.getTemp(flow, config_per_extruder[extruder].material_print_temperature, config_per_extruder[extruder].flow_dependent_temperature);
-    }
-    
-    /*!
-     * Decide when to start warming up again after starting to cool down towards the standby temperature.
-     * Two cases are considered: 
-     * the case where the standby temperature is reached  \__/    .
-     * and the case where it isn't  \/    .
-     * 
-     * IT is assumed that the printer is not printing during this cool down and warm up time.
-     * 
-     * Assumes from_temp is approximately the same as @p temp
-     * 
-     * \param window_time The time window within which the cooldown and heat up must take place.
-     * \param extruder The extruder used
-     * \param temp The temperature to which to heat
-     * \return The time before the end of the @p time_window to insert the preheat command
-     */
-    double timeBeforeEndToInsertPreheatCommand_coolDownWarmUp(double time_window, unsigned int extruder, double temp)
-    {
-        double time_ratio_cooldown_heatup = config_per_extruder[extruder].time_to_cooldown_1_degree / config_per_extruder[extruder].time_to_heatup_1_degree;
-        double time_to_heat_from_standby_to_print_temp = timeToHeatFromStandbyToPrintTemp(extruder, temp);
-        double time_needed_to_reach_standby_temp = time_to_heat_from_standby_to_print_temp * (1.0 + time_ratio_cooldown_heatup);
-        if (time_needed_to_reach_standby_temp < time_window)
-        {
-            return time_to_heat_from_standby_to_print_temp;
-        }
-        else 
-        {
-            return time_window * config_per_extruder[extruder].time_to_heatup_1_degree / (config_per_extruder[extruder].time_to_cooldown_1_degree + config_per_extruder[extruder].time_to_heatup_1_degree);
-        }
-    }
-    /*!
-     * Calculate time needed to warm up the nozzle from a given temp to a given temp.
-     * If the printer is printing in the mean time the warming up will take longer.
-     * 
-     * 
-     * \param from_temp The temperature at which the nozzle was before
-     * \param extruder The extruder used
-     * \param temp The temperature to which to heat
-     * \param printing Whether the printer is printing in the time to heat up the nozzle
-     * \return The time needed to reach the desired temperature (@p temp)
-     */
-    double timeBeforeEndToInsertPreheatCommand_warmUp(double from_temp, unsigned int extruder, double temp, bool printing)
-    {
-        if (temp > from_temp)
-        {
-            if (printing)
-            {
-                return (temp - from_temp) * (config_per_extruder[extruder].time_to_heatup_1_degree + config_per_extruder[extruder].heatup_cooldown_time_mod_while_printing); 
-            }
-            else 
-            {
-                return (temp - from_temp) * config_per_extruder[extruder].time_to_heatup_1_degree; 
-            }
-        }
-        else 
-        {
-            if (printing)
-            {
-                return (from_temp - temp) * config_per_extruder[extruder].time_to_cooldown_1_degree; 
-            }
-            else 
-            {
-                return (from_temp - temp) * std::max(0.0, config_per_extruder[extruder].time_to_cooldown_1_degree - config_per_extruder[extruder].heatup_cooldown_time_mod_while_printing); 
-            }
-        }
-    }
-};
-
-} // namespace cura 
-
-#endif // PREHEAT_H

src/PrimeTower.cpp

@@ -5,7 +5,6 @@
 #include "gcodeExport.h"
 #include "gcodePlanner.h"
 #include "infill.h"
-#include "PrintFeature.h"
 
 namespace cura 
 {
@@ -17,29 +16,20 @@ PrimeTower::PrimeTower()
 
 
 
-void PrimeTower::initConfigs(MeshGroup* meshgroup, std::vector<RetractionConfig>& retraction_config_per_extruder)
+void PrimeTower::setConfigs(MeshGroup* meshgroup, std::vector<RetractionConfig>& retraction_config_per_extruder, int layer_thickness)
 {
+    
     extruder_count = meshgroup->getSettingAsCount("machine_extruder_count");
     
-    for (int extr = 0; extr < extruder_count; extr++)
-    {
-        config_per_extruder.emplace_back(&retraction_config_per_extruder[extr], PrintFeatureType::Support);// so that visualization in the old Cura still works (TODO)
-    }
     for (int extr = 0; extr < extruder_count; extr++)
     {
         ExtruderTrain* train = meshgroup->getExtruderTrain(extr);
-        config_per_extruder[extr].init(train->getSettingInMillimetersPerSecond("speed_prime_tower"), train->getSettingInMicrons("prime_tower_line_width"), train->getSettingInPercentage("prime_tower_flow"));
-    }
-}
-
-void PrimeTower::setConfigs(MeshGroup* meshgroup, int layer_thickness)
-{
-    
-    extruder_count = meshgroup->getSettingAsCount("machine_extruder_count");
-    
-    for (int extr = 0; extr < extruder_count; extr++)
-    {
-        GCodePathConfig& conf = config_per_extruder[extr];
+        config_per_extruder.emplace_back(&retraction_config_per_extruder[extr], "WALL-INNER");// so that visualization in the old Cura still works (TODO)
+        GCodePathConfig& conf = config_per_extruder.back();
+        
+        conf.setSpeed(train->getSettingInMillimetersPerSecond("speed_prime_tower"));
+        conf.setLineWidth(train->getSettingInMicrons("prime_tower_line_width"));
+        conf.setFlow(train->getSettingInPercentage("prime_tower_flow"));
         conf.setLayerHeight(layer_thickness);
     }
 }
@@ -51,19 +41,18 @@ void PrimeTower::computePrimeTowerMax(SliceDataStorage& storage)
         
     extruder_count = storage.getSettingAsCount("machine_extruder_count");
     
-    int max_object_height_per_extruder[extruder_count]; 
-    std::fill_n(max_object_height_per_extruder, extruder_count, -1); // unitialize all as -1
+    int max_object_height_per_extruder[extruder_count];
     { // compute max_object_height_per_extruder
+        memset(max_object_height_per_extruder, -1, sizeof(max_object_height_per_extruder));
         for (SliceMeshStorage& mesh : storage.meshes)
         {
-            unsigned int extr_nr = mesh.getSettingAsIndex("extruder_nr");
-            max_object_height_per_extruder[extr_nr] = 
-                std::max(   max_object_height_per_extruder[extr_nr]
+            max_object_height_per_extruder[mesh.getSettingAsIndex("extruder_nr")] = 
+                std::max(   max_object_height_per_extruder[mesh.getSettingAsIndex("extruder_nr")]
                         ,   mesh.layer_nr_max_filled_layer  ); 
         }
-        int support_infill_extruder_nr = storage.getSettingAsIndex("support_infill_extruder_nr"); // TODO: support extruder should be configurable per object
-        max_object_height_per_extruder[support_infill_extruder_nr] = 
-        std::max(   max_object_height_per_extruder[support_infill_extruder_nr]
+        int support_extruder_nr = storage.getSettingAsIndex("support_extruder_nr"); // TODO: support extruder should be configurable per object
+        max_object_height_per_extruder[support_extruder_nr] = 
+        std::max(   max_object_height_per_extruder[support_extruder_nr]
                 ,   storage.support.layer_nr_max_filled_layer  ); 
         int support_roof_extruder_nr = storage.getSettingAsIndex("support_roof_extruder_nr"); // TODO: support roof extruder should be configurable per object
         max_object_height_per_extruder[support_roof_extruder_nr] = 
@@ -83,7 +72,7 @@ void PrimeTower::computePrimeTowerMax(SliceDataStorage& storage)
         for (int extruder_nr = 0; extruder_nr < extruder_count; extruder_nr++)
         {
             if (extruder_nr == extruder_max_object_height) { continue; }
-            if (extruder_second_max_object_height == -1 || max_object_height_per_extruder[extruder_nr] > max_object_height_per_extruder[extruder_second_max_object_height])
+            if (max_object_height_per_extruder[extruder_nr] > max_object_height_per_extruder[extruder_second_max_object_height])
             {
                 extruder_second_max_object_height = extruder_nr;
             }
@@ -104,7 +93,7 @@ void PrimeTower::generateGroundpoly(SliceDataStorage& storage)
 {
     PolygonRef p = storage.primeTower.ground_poly.newPoly();
     int tower_size = storage.getSettingInMicrons("prime_tower_size");
-    int tower_distance = 0; 
+    int tower_distance = 0; //storage.getSettingInMicrons("prime_tower_distance");
     int x = storage.getSettingInMicrons("prime_tower_position_x"); // storage.model_max.x
     int y = storage.getSettingInMicrons("prime_tower_position_y"); // storage.model_max.y
     p.add(Point(x + tower_distance, y + tower_distance));
@@ -115,21 +104,23 @@ void PrimeTower::generateGroundpoly(SliceDataStorage& storage)
     storage.wipePoint = Point(x + tower_distance - tower_size / 2, y + tower_distance + tower_size / 2);   
 }
 
-void PrimeTower::generatePaths(SliceDataStorage& storage, unsigned int total_layers)
+void PrimeTower::generatePaths(SliceDataStorage& storage, unsigned int totalLayers)
 {
-    if (storage.max_object_height_second_to_last_extruder >= 0 && storage.getSettingBoolean("prime_tower_enable"))
+    if (storage.max_object_height_second_to_last_extruder >= 0 
+//         && storage.getSettingInMicrons("prime_tower_distance") > 0 
+        && storage.getSettingInMicrons("prime_tower_size") > 0)
     {
         generatePaths3(storage);
     }
 }
-void PrimeTower::generatePaths_OLD(SliceDataStorage& storage, unsigned int total_layers)
+void PrimeTower::generatePaths_OLD(SliceDataStorage& storage, unsigned int totalLayers)
 {
     
-    if (storage.max_object_height_second_to_last_extruder >= 0 && storage.getSettingBoolean("prime_tower_enable"))
+    if (storage.max_object_height_second_to_last_extruder >= 0 && storage.getSettingInMicrons("prime_tower_distance") > 0 && storage.getSettingInMicrons("prime_tower_size") > 0)
     {
         PolygonRef p = storage.primeTower.ground_poly.newPoly();
         int tower_size = storage.getSettingInMicrons("prime_tower_size");
-        int tower_distance = 0; 
+        int tower_distance = 0; //storage.getSettingInMicrons("prime_tower_distance");
         int x = storage.getSettingInMicrons("prime_tower_position_x"); // storage.model_max.x
         int y = storage.getSettingInMicrons("prime_tower_position_y"); // storage.model_max.y
         p.add(Point(x + tower_distance, y + tower_distance));
@@ -168,7 +159,7 @@ void PrimeTower::generatePaths3(SliceDataStorage& storage)
 {
         
     int n_patterns = 2; // alternating patterns between layers
-    int infill_overlap = 60; // so that it can't be zero; EDIT: wtf?
+    double infill_overlap = 15; // so that it can't be zero
     
     generateGroundpoly(storage);
     
@@ -179,13 +170,7 @@ void PrimeTower::generatePaths3(SliceDataStorage& storage)
         std::vector<Polygons>& patterns = patterns_per_extruder.back();
         for (int pattern_idx = 0; pattern_idx < n_patterns; pattern_idx++)
         {
-            Polygons result_polygons; // should remain empty, since we generate lines pattern!
-            int outline_offset = -line_width/2;
-            int line_distance = line_width;
-            double fill_angle = 45 + pattern_idx * 90;
-            Polygons& result_lines = patterns[pattern_idx];
-            Infill infill_comp(EFillMethod::LINES, ground_poly, outline_offset, line_width, line_distance, infill_overlap, fill_angle);
-            infill_comp.generate(result_polygons, result_lines);
+            generateLineInfill(ground_poly, -line_width/2, patterns[pattern_idx], line_width, line_width, infill_overlap, 45 + pattern_idx*90);
         }
     }
 }
@@ -194,7 +179,9 @@ void PrimeTower::generatePaths3(SliceDataStorage& storage)
 
 void PrimeTower::addToGcode(SliceDataStorage& storage, GCodePlanner& gcodeLayer, GCodeExport& gcode, int layer_nr, int prev_extruder, bool prime_tower_dir_outward, bool wipe, int* last_prime_tower_poly_printed)
 {
-    if (!( storage.max_object_height_second_to_last_extruder >= 0 && storage.getSettingInMicrons("prime_tower_size") > 0) )
+    if (!( storage.max_object_height_second_to_last_extruder >= 0 
+//         && storage.getSettingInMicrons("prime_tower_distance") > 0 
+        && storage.getSettingInMicrons("prime_tower_size") > 0) )
     {
         return;
     }
@@ -231,15 +218,10 @@ void PrimeTower::addToGcode3(SliceDataStorage& storage, GCodePlanner& gcodeLayer
     GCodePathConfig& config = config_per_extruder[new_extruder];
     int start_idx = 0; // TODO: figure out which idx is closest to the far right corner
     gcodeLayer.addPolygon(ground_poly.back(), start_idx, &config);
-    gcodeLayer.addLinesByOptimizer(pattern, &config, SpaceFillType::Lines);
+    gcodeLayer.addLinesByOptimizer(pattern, &config);
     
     last_prime_tower_poly_printed[new_extruder] = layer_nr;
-
-    if (CommandSocket::isInstantiated())
-    {
-        CommandSocket::getInstance()->sendPolygons(PrintFeatureType::Support, layer_nr, pattern, config.getLineWidth());
-    }
-
+    
     if (wipe)
     { //Make sure we wipe the old extruder on the prime tower.
         gcodeLayer.addTravel(storage.wipePoint - gcode.getExtruderOffset(prev_extruder) + gcode.getExtruderOffset(new_extruder));

src/PrimeTower.h

@@ -26,8 +26,7 @@ private:
         
     };
 public:
-    void initConfigs(MeshGroup* meshgroup, std::vector<RetractionConfig>& retraction_config_per_extruder);
-    void setConfigs(MeshGroup* configs, int layer_thickness);
+    void setConfigs(MeshGroup* configs, std::vector<RetractionConfig>& retraction_config_per_extruder, int layer_thickness);
     
     Polygons ground_poly;
     
@@ -45,10 +44,10 @@ public:
      * Generate the area where the prime tower should be.
      * 
      * \param storage Input and Output parameter: fetches the outline information (see SliceLayerPart::outline) and generates the other reachable field of the \p storage
-     * \param total_layers The total number of layers 
+     * \param totalLayers The total number of layers 
      */
-    void generatePaths(SliceDataStorage& storage, unsigned int total_layers);
-    void generatePaths_OLD(SliceDataStorage& storage, unsigned int total_layers);
+    void generatePaths(SliceDataStorage& storage, unsigned int totalLayers);
+    void generatePaths_OLD(SliceDataStorage& storage, unsigned int totalLayers);
 
     void computePrimeTowerMax(SliceDataStorage& storage);
     

src/PrintFeature.h

@@ -4,23 +4,24 @@
 namespace cura
 {
 
-enum class PrintFeatureType
+enum class EPrintFeature : unsigned int
 {
-    NoneType, // unused, but libArcus depends on it
-    OuterWall,
-    InnerWall,
-    Skin,
-    Support,
-    Skirt,
-    Infill,
-    SupportInfill,
-    MoveCombing,
-    MoveRetraction
+    OUTER_WALL,
+    INNER_WALLS,
+    INFILL,
+    SKIN,
+    HELPERS,
+    UNCLASSIFIED,
+    ENUM_COUNT
 };
 
 
 
 
+
+
+
+
 } // namespace cura
 
 #endif // PRINT_FEATURE

src/Progress.cpp

@@ -1,28 +1,30 @@
 /** Copyright (C) 2015 Ultimaker - Released under terms of the AGPLv3 License */
 #include "Progress.h"
 
-#include "../commandSocket.h"
-#include "../utils/gettime.h"
+#include "commandSocket.h"
+#include "utils/gettime.h"
 
 namespace cura {
     
 double Progress::times [] = 
 { 
-    0.0,    // START   = 0, 
-    5.269,  // SLICING = 1, 
-    1.533,  // PARTS   = 2, 
-    71.811, // INSET_SKIN = 3
-    51.009, // SUPPORT = 4, 
-    154.62, // EXPORT  = 5, 
-    0.1     // FINISH  = 6
+    0.0, 
+    5.269, 
+    1.533, 
+    22.953,
+    51.009, 
+    48.858, 
+    154.62, 
+    0.1 
 };
 std::string Progress::names [] = 
 {
     "start",
     "slice",
     "layerparts",
-    "inset+skin",
+    "inset",
     "support",
+    "skin",
     "export",
     "process"
 };
@@ -37,8 +39,9 @@ const Progress::Stage Progress::stages[] =
     Progress::Stage::START, 
     Progress::Stage::SLICING, 
     Progress::Stage::PARTS, 
-    Progress::Stage::INSET_SKIN, 
+    Progress::Stage::INSET, 
     Progress::Stage::SUPPORT, 
+    Progress::Stage::SKIN, 
     Progress::Stage::EXPORT, 
     Progress::Stage::FINISH 
 };
@@ -61,22 +64,22 @@ void Progress::init()
     total_timing = accumulated_time;
 }
 
-void Progress::messageProgress(Progress::Stage stage, int progress_in_stage, int progress_in_stage_max)
+void Progress::messageProgress(Progress::Stage stage, int progress_in_stage, int progress_in_stage_max, CommandSocket* command_socket)
 {
     float percentage = calcOverallProgress(stage, float(progress_in_stage) / float(progress_in_stage_max));
-    if (CommandSocket::getInstance())
+    if (command_socket)
     {
-        CommandSocket::getInstance()->sendProgress(percentage);
+        command_socket->sendProgress(percentage);
     }
     
     logProgress(names[(int)stage].c_str(), progress_in_stage, progress_in_stage_max, percentage);
 }
 
-void Progress::messageProgressStage(Progress::Stage stage, TimeKeeper* time_keeper)
+void Progress::messageProgressStage(Progress::Stage stage, TimeKeeper* time_keeper, CommandSocket* command_socket)
 {
-    if (CommandSocket::getInstance())
+    if (command_socket)
     {
-        CommandSocket::getInstance()->sendProgressStage(stage);
+        command_socket->sendProgressStage(stage);
     }
     
     if (time_keeper)

src/Progress.h

@@ -4,14 +4,14 @@
 
 #include <string>
 
-#include "../utils/logoutput.h"
-#include "../utils/gettime.h"
+#include "utils/logoutput.h"
+#include "utils/gettime.h"
 
 namespace cura {
 
 class CommandSocket;
 
-#define N_PROGRESS_STAGES 7
+#define N_PROGRESS_STAGES 8
 
 /*!
  * Class for handling the progress bar and the progress logging.
@@ -30,10 +30,11 @@ public:
         START   = 0, 
         SLICING = 1, 
         PARTS   = 2, 
-        INSET_SKIN = 3, 
+        INSET   = 3, 
         SUPPORT = 4, 
-        EXPORT  = 5, 
-        FINISH  = 6
+        SKIN    = 5, 
+        EXPORT  = 6, 
+        FINISH  = 7
     };
 private:
     static double times [N_PROGRESS_STAGES]; //!< Time estimates per stage
@@ -51,20 +52,22 @@ private:
 public:
     static void init(); //!< Initialize some values needed in a fast computation of the progress
     /*!
-     * Message progress over the CommandSocket and to the terminal (if the command line arg '-p' is provided).
+     * Message progress over the \p commandSocket and to the terminal (if the command line arg '-p' is provided).
      * 
      * \param stage The current stage of processing
      * \param progress_in_stage Any number giving the progress within the stage
      * \param progress_in_stage_max The maximal value of \p progress_in_stage
+     * \param commandSocket The command socket over which to communicate the progress.
      */
-    static void messageProgress(Stage stage, int progress_in_stage, int progress_in_stage_max);
+    static void messageProgress(Stage stage, int progress_in_stage, int progress_in_stage_max, CommandSocket* commandSocket);
     /*!
      * Message the progress stage over the command socket.
      * 
      * \param stage The current stage
      * \param timeKeeper The stapwatch keeping track of the timings for each stage (optional)
+     * \param commandSocket The command socket over which to communicate (optional)
      */
-    static void messageProgressStage(Stage stage, TimeKeeper* timeKeeper);
+    static void messageProgressStage(Stage stage, TimeKeeper* timeKeeper, CommandSocket* commandSocket);
 };
 
 

src/SpaceFillType.h

@@ -1,25 +0,0 @@
-#ifndef SPACE_FILL_TYPE
-#define SPACE_FILL_TYPE
-
-
-namespace cura
-{
-
-/*!
- * Enum class enumerating the strategies with which an area can be occupied with filament
- * 
- * The walls/perimeters are Polygons
- * ZigZag infill is PolyLines, and so is following mesh surface mode for non-polygon surfaces
- * Grid, Triangles and lines infill is Lines
- */
-enum class SpaceFillType
-{
-    None,
-    Polygons,
-    PolyLines,
-    Lines
-};
-
-} // namespace cura
-
-#endif // SPACE_FILL_TYPE

src/WallsComputation.cpp

@@ -1,79 +0,0 @@
-/** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
-#include "WallsComputation.h"
-#include "utils/polygonUtils.h"
-namespace cura {
-
-WallsComputation::WallsComputation(int wall_0_inset, int line_width_0, int line_width_x, int insetCount, bool recompute_outline_based_on_outer_wall)
-: wall_0_inset(wall_0_inset)
-, line_width_0(line_width_0)
-, line_width_x(line_width_x)
-, insetCount(insetCount)
-, recompute_outline_based_on_outer_wall(recompute_outline_based_on_outer_wall)
-{
-}
-
-void WallsComputation::generateInsets(SliceLayerPart* part)
-{
-    if (insetCount == 0)
-    {
-        part->insets.push_back(part->outline);
-        part->print_outline = part->outline;
-        return;
-    }
-    
-    for(int i=0; i<insetCount; i++)
-    {
-        part->insets.push_back(Polygons());
-        if (i == 0)
-        {
-            part->insets[0] = part->outline.offset(-line_width_0 / 2 - wall_0_inset);
-        } else if (i == 1)
-        {
-            part->insets[1] = part->insets[0].offset(-line_width_0 / 2 + wall_0_inset - line_width_x / 2);
-        } else
-        {
-            part->insets[i] = part->insets[i-1].offset(-line_width_x);
-        }
-        
-        
-        //Finally optimize all the polygons. Every point removed saves time in the long run.
-        part->insets[i].simplify();
-        if (i == 0)
-        {
-            if (recompute_outline_based_on_outer_wall)
-            {
-                part->print_outline = part->insets[0].offset(line_width_0 / 2);
-            }
-            else
-            {
-                part->print_outline = part->outline;
-            }
-        }
-        if (part->insets[i].size() < 1)
-        {
-            part->insets.pop_back();
-            break;
-        }
-    }
-}
-
-void WallsComputation::generateInsets(SliceLayer* layer)
-{
-    for(unsigned int partNr = 0; partNr < layer->parts.size(); partNr++)
-    {
-        generateInsets(&layer->parts[partNr]);
-    }
-    
-    //Remove the parts which did not generate an inset. As these parts are too small to print,
-    // and later code can now assume that there is always minimal 1 inset line.
-    for(unsigned int partNr = 0; partNr < layer->parts.size(); partNr++)
-    {
-        if (layer->parts[partNr].insets.size() < 1)
-        {
-            layer->parts.erase(layer->parts.begin() + partNr);
-            partNr -= 1;
-        }
-    }
-}
-
-}//namespace cura

src/WallsComputation.h

@@ -1,69 +0,0 @@
-/** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
-#ifndef INSET_H
-#define INSET_H
-
-#include "sliceDataStorage.h"
-
-namespace cura 
-{
-
-/*!
- * Function container for computing the outer walls / insets / perimeters polygons of a layer
- */
-class WallsComputation
-{
-public:
-    /*!
-     * The offset applied to the outer wall
-     */
-    int wall_0_inset;
-    /*!
-     * line width of the outer wall
-     */
-    int line_width_0;
-    /*!
-     * line width of other walls
-     */
-    int line_width_x;
-    /*!
-     * The number of insets to to generate
-     */
-    int insetCount;
-    /*!
-     * Whether to compute a more accurate poly representation of the printed outlines, based on the outer wall
-     */
-    bool recompute_outline_based_on_outer_wall;
-
-    /*!
-     * Basic constructor initializing the parameters with which to perform the walls computation
-     * 
-     * \param wall_0_inset The offset applied to the outer wall
-     * \param line_width_0 line width of the outer wall
-     * \param line_width_x line width of other walls
-     * \param insetCount The number of insets to to generate
-     * \param recompute_outline_based_on_outer_wall Whether to compute a more accurate poly representation of the printed outlines, based on the outer wall
-     */
-    WallsComputation(int wall_0_inset, int line_width_0, int line_width_x, int insetCount, bool recompute_outline_based_on_outer_wall);
-
-    /*!
-     * Generates the insets / perimeters for all parts in a layer.
-     * 
-     * Note that the second inset gets offsetted by WallsComputation::line_width_0 instead of the first, 
-     * which leads to better results for a smaller WallsComputation::line_width_0 than WallsComputation::line_width_x and when printing the outer wall last.
-     * 
-     * \param layer The layer for which to generate the insets.
-     */ 
-    void generateInsets(SliceLayer* layer);
-
-private:
-    /*!
-     * Generates the insets / perimeters for a single layer part.
-     * 
-     * \param part The part for which to generate the insets.
-     */
-    void generateInsets(SliceLayerPart* part);
-
-};
-}//namespace cura
-
-#endif//INSET_H

src/Weaver.cpp

@@ -4,14 +4,13 @@
 #include <fstream> // debug IO
 #include <unistd.h>
 
-#include "progress/Progress.h"
+#include "Progress.h"
 #include "weaveDataStorage.h"
-#include "PrintFeature.h"
 
 namespace cura 
 {
 
-void Weaver::weave(MeshGroup* meshgroup)
+void Weaver::weave(MeshGroup* meshgroup, CommandSocket* commandSocket)
 {   
     wireFrame.meshgroup = meshgroup;
     
@@ -29,13 +28,14 @@ void Weaver::weave(MeshGroup* meshgroup)
         slicerList.push_back(slicer);
     }
 
+    
     int starting_layer_idx;
     { // find first non-empty layer
         for (starting_layer_idx = 0; starting_layer_idx < layer_count; starting_layer_idx++)
         {
             Polygons parts;
             for (cura::Slicer* slicer : slicerList)
-                parts.add(slicer->layers[starting_layer_idx].polygons);  
+                parts.add(slicer->layers[starting_layer_idx].polygonList);  
             
             if (parts.size() > 0)
                 break;
@@ -51,19 +51,12 @@ void Weaver::weave(MeshGroup* meshgroup)
     {
         int starting_z = -1;
         for (cura::Slicer* slicer : slicerList)
-            wireFrame.bottom_outline.add(slicer->layers[starting_layer_idx].polygons);
+            wireFrame.bottom_outline.add(slicer->layers[starting_layer_idx].polygonList);
         
-        if (CommandSocket::isInstantiated())
-            CommandSocket::getInstance()->sendPolygons(PrintFeatureType::OuterWall, 0, wireFrame.bottom_outline, 1);
+        if (commandSocket)
+            commandSocket->sendPolygons(Inset0Type, 0, wireFrame.bottom_outline, 1);
         
-        if (slicerList.empty()) //Wait, there is nothing to slice.
-        {
-            wireFrame.z_bottom = 0;
-        }
-        else
-        {
-            wireFrame.z_bottom = slicerList[0]->layers[starting_layer_idx].z;
-        }
+        wireFrame.z_bottom = slicerList[0]->layers[starting_layer_idx].z;
         
         Point starting_point_in_layer;
         if (wireFrame.bottom_outline.size() > 0)
@@ -71,24 +64,23 @@ void Weaver::weave(MeshGroup* meshgroup)
         else 
             starting_point_in_layer = (Point(0,0) + meshgroup->max() + meshgroup->min()) / 2;
         
-        Progress::messageProgressStage(Progress::Stage::INSET_SKIN, nullptr);
+        Progress::messageProgressStage(Progress::Stage::INSET, nullptr, commandSocket);
         for (int layer_idx = starting_layer_idx + 1; layer_idx < layer_count; layer_idx++)
         {
-            Progress::messageProgress(Progress::Stage::INSET_SKIN, layer_idx+1, layer_count); // abuse the progress system of the normal mode of CuraEngine
+            Progress::messageProgress(Progress::Stage::INSET, layer_idx+1, layer_count, commandSocket); // abuse the progress system of the normal mode of CuraEngine
             
             Polygons parts1;
             for (cura::Slicer* slicer : slicerList)
-                parts1.add(slicer->layers[layer_idx].polygons);
+                parts1.add(slicer->layers[layer_idx].polygonList);
 
             
             Polygons chainified;
 
             chainify_polygons(parts1, starting_point_in_layer, chainified, false);
             
-            if (CommandSocket::isInstantiated())
-            {
-                CommandSocket::getInstance()->sendPolygons(PrintFeatureType::OuterWall, layer_idx - starting_layer_idx, chainified, 1);
-            }
+            if (commandSocket)
+                commandSocket->sendPolygons(Inset0Type, layer_idx - starting_layer_idx, chainified, 1);
+            
             if (chainified.size() > 0)
             {
                 if (starting_z == -1) starting_z = slicerList[0]->layers[layer_idx-1].z;
@@ -109,10 +101,10 @@ void Weaver::weave(MeshGroup* meshgroup)
     {
         Polygons* lower_top_parts = &wireFrame.bottom_outline;
         
-        Progress::messageProgressStage(Progress::Stage::SUPPORT, nullptr);
+        Progress::messageProgressStage(Progress::Stage::SKIN, nullptr, commandSocket);
         for (unsigned int layer_idx = 0; layer_idx < wireFrame.layers.size(); layer_idx++)
         {
-            Progress::messageProgress(Progress::Stage::SUPPORT, layer_idx+1, wireFrame.layers.size()); // abuse the progress system of the normal mode of CuraEngine
+            Progress::messageProgress(Progress::Stage::SKIN, layer_idx+1, wireFrame.layers.size(), commandSocket); // abuse the progress system of the normal mode of CuraEngine
             
             WeaveLayer& layer = wireFrame.layers[layer_idx];
             
@@ -144,21 +136,16 @@ void Weaver::weave(MeshGroup* meshgroup)
 
 
     { // roofs:
-        if (!wireFrame.layers.empty()) //If there are no layers, create no roof.
-        {
-            WeaveLayer& top_layer = wireFrame.layers.back();
-            Polygons to_be_supported; // empty for the top layer
-            fillRoofs(top_layer.supported, to_be_supported, -1, top_layer.z1, top_layer.roofs);
-        }
+        
+        WeaveLayer& top_layer = wireFrame.layers.back();
+        Polygons to_be_supported; // empty for the top layer
+        fillRoofs(top_layer.supported, to_be_supported, -1, top_layer.z1, top_layer.roofs);
     }
     
     
     { // bottom:
-        if (!wireFrame.layers.empty()) //If there are no layers, create no bottom.
-        {
-            Polygons to_be_supported; // is empty for the bottom layer, cause the order of insets doesn't really matter (in a sense everything is to be supported)
-            fillRoofs(wireFrame.bottom_outline, to_be_supported, -1, wireFrame.layers.front().z0, wireFrame.bottom_infill);
-        }
+        Polygons to_be_supported; // is empty for the bottom layer, cause the order of insets doesn't really matter (in a sense everything is to be supported)
+        fillRoofs(wireFrame.bottom_outline, to_be_supported, -1, wireFrame.layers.front().z0, wireFrame.bottom_infill);
     }
     
 }

src/Weaver.h

@@ -3,12 +3,11 @@
 
 #include "weaveDataStorage.h"
 #include "commandSocket.h"
-#include "settings/settings.h"
+#include "settings.h"
 
 #include "MeshGroup.h"
 #include "slicer.h"
 
-#include "utils/NoCopy.h"
 #include "utils/polygon.h"
 #include "utils/polygonUtils.h"
 
@@ -20,7 +19,7 @@ namespace cura
 /*!
  * The main weaver / WirePrint / wireframe printing class, which computes the basic paths to be followed.
  */
-class Weaver : public SettingsMessenger, NoCopy
+class Weaver : public SettingsMessenger
 {
     friend class Wireframe2gcode;
 private:
@@ -61,8 +60,9 @@ public:
      * Creates a wireframe for the model consisting of horizontal 'flat' parts and connections between consecutive flat parts consisting of UP moves and diagonally DOWN moves.
      * 
      * \param objects The objects for which to create a wireframe print
+     * \param commandSocket the commandSocket
      */
-    void weave(MeshGroup* objects);
+    void weave(MeshGroup* objects, CommandSocket* commandSocket);
     
 
 private:

src/Wireframe2gcode.cpp

@@ -4,7 +4,7 @@
 #include <fstream> // debug IO
 
 #include "weaveDataStorage.h"
-#include "progress/Progress.h"
+#include "Progress.h"
 
 #include "pathOrderOptimizer.h" // for skirt
 
@@ -12,32 +12,22 @@ namespace cura
 {
 
 
-void Wireframe2gcode::writeGCode()
+void Wireframe2gcode::writeGCode(CommandSocket* commandSocket)
 {
 
     gcode.preSetup(wireFrame.meshgroup);
     
-    gcode.setInitialTemps(wireFrame.meshgroup);
+    if (commandSocket)
+        commandSocket->beginGCode();
     
-    if (CommandSocket::getInstance())
-        CommandSocket::getInstance()->beginGCode();
+    processStartingCode(commandSocket);
     
-    processStartingCode();
+    int maxObjectHeight = wireFrame.layers.back().z1;
     
-    int maxObjectHeight;
-    if (wireFrame.layers.empty())
-    {
-        maxObjectHeight = 0;
-    }
-    else
-    {
-        maxObjectHeight = wireFrame.layers.back().z1;
-    }
-    
-    processSkirt();
+    processSkirt(commandSocket);
     
             
-    unsigned int total_layers = wireFrame.layers.size();
+    unsigned int totalLayers = wireFrame.layers.size();
     gcode.writeLayerComment(0);
     gcode.writeTypeComment("SKIRT");
 
@@ -78,10 +68,10 @@ void Wireframe2gcode::writeGCode()
                         gcode.writeMove(segment.to, speedBottom, extrusion_per_mm_flat); 
                 }
             );
-    Progress::messageProgressStage(Progress::Stage::EXPORT, nullptr);
+    Progress::messageProgressStage(Progress::Stage::EXPORT, nullptr, commandSocket);
     for (unsigned int layer_nr = 0; layer_nr < wireFrame.layers.size(); layer_nr++)
     {
-        Progress::messageProgress(Progress::Stage::EXPORT, layer_nr+1, total_layers); // abuse the progress system of the normal mode of CuraEngine
+        Progress::messageProgress(Progress::Stage::EXPORT, layer_nr+1, totalLayers, commandSocket); // abuse the progress system of the normal mode of CuraEngine
         
         WeaveLayer& layer = wireFrame.layers[layer_nr];
         
@@ -167,7 +157,13 @@ void Wireframe2gcode::writeGCode()
     
     gcode.writeFanCommand(0);
 
-    finalize();
+    finalize(maxObjectHeight);
+    
+    if (commandSocket)
+    {
+        commandSocket->sendGCodeLayer();
+        commandSocket->endSendSlicedObject();
+    }
 }
 
     
@@ -235,14 +231,11 @@ void Wireframe2gcode::strategy_retract(WeaveLayer& layer, WeaveConnectionPart& p
     
     RetractionConfig retraction_config;
     // TODO: get these from the settings!
-    retraction_config.distance = 500; //INT2MM(getSettingInt("retraction_amount"))
-    retraction_config.prime_volume = 0;//INT2MM(getSettingInt("retractionPrime
+    retraction_config.amount = 500; //INT2MM(getSettingInt("retraction_amount"))
+    retraction_config.primeAmount = 0;//INT2MM(getSettingInt("retractionPrime
     retraction_config.speed = 20; // 40;
     retraction_config.primeSpeed = 15; // 30;
     retraction_config.zHop = 0; //getSettingInt("retraction_hop");
-    retraction_config.retraction_count_max = getSettingAsCount("retraction_count_max");
-    retraction_config.retraction_extrusion_window = getSettingInMillimeters("retraction_extrusion_window");
-    retraction_config.retraction_min_travel_distance = getSettingInMicrons("retraction_min_travel");
 
     double top_retract_pause = 2.0;
     int retract_hop_dist = 1000;
@@ -480,8 +473,8 @@ void Wireframe2gcode::writeMoveWithRetract(Point to)
 Wireframe2gcode::Wireframe2gcode(Weaver& weaver, GCodeExport& gcode, SettingsBase* settings_base) 
 : SettingsMessenger(settings_base) 
 , gcode(gcode)
-, wireFrame(weaver.wireFrame)
 {
+    wireFrame = weaver.wireFrame;
     initial_layer_thickness = getSettingInMicrons("layer_height_0");
     connectionHeight = getSettingInMicrons("wireframe_height"); 
     roof_inset = getSettingInMicrons("wireframe_roof_inset"); 
@@ -536,42 +529,33 @@ Wireframe2gcode::Wireframe2gcode(Weaver& weaver, GCodeExport& gcode, SettingsBas
     roof_outer_delay = getSettingInSeconds("wireframe_roof_outer_delay");
     
     
-    standard_retraction_config.distance = getSettingInMillimeters("retraction_amount");
-    standard_retraction_config.prime_volume = getSettingInCubicMillimeters("retraction_extra_prime_amount");
+    standard_retraction_config.amount = INT2MM(getSettingInMicrons("retraction_amount"));
+    standard_retraction_config.primeAmount = INT2MM(getSettingInMicrons("retraction_extra_prime_amount"));
     standard_retraction_config.speed = getSettingInMillimetersPerSecond("retraction_retract_speed");
     standard_retraction_config.primeSpeed = getSettingInMillimetersPerSecond("retraction_prime_speed");
     standard_retraction_config.zHop = getSettingInMicrons("retraction_hop");
-    standard_retraction_config.retraction_count_max = getSettingAsCount("retraction_count_max");
-    standard_retraction_config.retraction_extrusion_window = getSettingInMillimeters("retraction_extrusion_window");
-    standard_retraction_config.retraction_min_travel_distance = getSettingInMicrons("retraction_min_travel");
+
+
 }
 
-void Wireframe2gcode::processStartingCode()
+void Wireframe2gcode::processStartingCode(CommandSocket* command_socket)
 {
-    if (!CommandSocket::isInstantiated())
+    if (gcode.getFlavor() == EGCodeFlavor::ULTIGCODE)
     {
-        gcode.writeCode(gcode.getFileHeader().c_str());
+        if (!command_socket)
+        {
+            gcode.writeCode(";FLAVOR:UltiGCode\n;TIME:666\n;MATERIAL:666\n;MATERIAL2:-1\n");
+        }
     }
     else 
     {
-        if (getSettingBoolean("material_bed_temp_prepend"))
-        {
-            if (getSettingBoolean("machine_heated_bed") && getSettingInDegreeCelsius("material_bed_temperature") > 0)
-            {
-                gcode.writeBedTemperatureCommand(getSettingInDegreeCelsius("material_bed_temperature"), getSettingBoolean("material_bed_temp_wait"));
-            }
-        }
+        if (getSettingBoolean("machine_heated_bed") && getSettingInDegreeCelsius("material_bed_temperature") > 0)
+            gcode.writeBedTemperatureCommand(getSettingInDegreeCelsius("material_bed_temperature"), true);
         
-        if (getSettingBoolean("material_print_temp_prepend"))
+        if (getSettingInDegreeCelsius("material_print_temperature") > 0)
         {
-            if (getSettingInDegreeCelsius("material_print_temperature") > 0)
-            {
-                gcode.writeTemperatureCommand(getSettingAsIndex("extruder_nr"), getSettingInDegreeCelsius("material_print_temperature"));
-                if (getSettingBoolean("machine_print_temp_wait"))
-                {
-                    gcode.writeTemperatureCommand(getSettingAsIndex("extruder_nr"), getSettingInDegreeCelsius("material_print_temperature"), true);
-                }
-            }
+            gcode.writeTemperatureCommand(getSettingAsIndex("extruder_nr"), getSettingInDegreeCelsius("material_print_temperature"));
+            gcode.writeTemperatureCommand(getSettingAsIndex("extruder_nr"), getSettingInDegreeCelsius("material_print_temperature"), true);
         }
         
     }
@@ -588,34 +572,30 @@ void Wireframe2gcode::processStartingCode()
 }
 
 
-void Wireframe2gcode::processSkirt()
+void Wireframe2gcode::processSkirt(CommandSocket* commandSocket)
 {
-    if (wireFrame.bottom_outline.size() == 0) //If we have no layers, don't create a skirt either.
-    {
-        return;
-    }
     Polygons skirt = wireFrame.bottom_outline.offset(100000+5000).offset(-100000);
-    PathOrderOptimizer order(Point(INT32_MIN, INT32_MIN));
+    PathOrderOptimizer order(gcode.getStartPositionXY());
     order.addPolygons(skirt);
     order.optimize();
     
-    for (unsigned int poly_order_idx = 0; poly_order_idx < skirt.size(); poly_order_idx++)
+    for (unsigned int poly_idx = 0; poly_idx < skirt.size(); poly_idx++)
     {
-        unsigned int poly_idx = order.polyOrder[poly_order_idx];
-        PolygonRef poly = skirt[poly_idx];
-        gcode.writeMove(poly[order.polyStart[poly_idx]], getSettingInMillimetersPerSecond("speed_travel"), 0);
+        unsigned int actual_poly_idx = order.polyOrder[poly_idx];
+        PolygonRef poly = skirt[actual_poly_idx];
+        gcode.writeMove(poly[order.polyStart[actual_poly_idx]], getSettingInMillimetersPerSecond("speed_travel"), 0);
         for (unsigned int point_idx = 0; point_idx < poly.size(); point_idx++)
         {
-            Point& p = poly[(point_idx + order.polyStart[poly_idx] + 1) % poly.size()];
+            Point& p = poly[(point_idx + order.polyStart[actual_poly_idx] + 1) % poly.size()];
             gcode.writeMove(p, getSettingInMillimetersPerSecond("skirt_speed"), getSettingInMillimetersPerSecond("skirt_line_width"));
         }
     }
 }
 
 
-void Wireframe2gcode::finalize()
+void Wireframe2gcode::finalize(int maxObjectHeight)
 {
-    gcode.finalize(getSettingString("machine_end_gcode").c_str());
+    gcode.finalize(maxObjectHeight, getSettingInMillimetersPerSecond("speed_travel"), getSettingString("machine_end_gcode").c_str());
     for(int e=0; e<getSettingAsCount("machine_extruder_count"); e++)
         gcode.writeTemperatureCommand(e, 0, false);
 }

src/Wireframe2gcode.h

@@ -4,11 +4,9 @@
 
 #include <functional> // passing function pointer or lambda as argument to a function
 
-#include "utils/NoCopy.h"
-
 #include "weaveDataStorage.h"
 #include "commandSocket.h"
-#include "settings/settings.h"
+#include "settings.h"
 
 #include "MeshGroup.h"
 #include "slicer.h"
@@ -24,7 +22,7 @@ namespace cura
 /*!
  * Export class for exporting wireframe print gcode / weaver gcode / wireprint gcode.
  */
-class Wireframe2gcode : public SettingsMessenger, NoCopy
+class Wireframe2gcode : public SettingsMessenger
 {
 private:
     static const int STRATEGY_COMPENSATE = 0;
@@ -71,26 +69,26 @@ public:
     
     Wireframe2gcode(Weaver& weaver, GCodeExport& gcode, SettingsBase* settings_base);
     
-    void writeGCode();
+    void writeGCode(CommandSocket* commandSocket);
 
 
 private:
-    WireFrame& wireFrame;
+    WireFrame wireFrame;
     
     /*!
      * Startup gcode: nozzle temp up, retraction settings, bed temp
      */
-    void processStartingCode();
+    void processStartingCode(CommandSocket* command_socket);
     
     /*!
      * Lay down a skirt
      */
-    void processSkirt();
+    void processSkirt(CommandSocket* commandSocket);
     
     /*!
      * End gcode: nozzle temp down
      */
-    void finalize();
+    void finalize(int maxObjectHeight);
     
     void writeFill(std::vector<WeaveRoofPart>& infill_insets, Polygons& outlines
         , std::function<void (Wireframe2gcode& thiss, WeaveRoofPart& inset, WeaveConnectionPart& part, unsigned int segment_idx)> connectionHandler

src/comb.cpp

@@ -5,45 +5,55 @@
 
 #include "utils/polygonUtils.h"
 #include "sliceDataStorage.h"
-#include "utils/SVG.h"
 
 namespace cura {
 
+bool Comb::moveInsideBoundary(Point* p, int distance)
+{
+    return PolygonUtils::moveInside(boundary_inside, *p, distance) != NO_INDEX;
+}
 
+Polygons Comb::getLayerSecondWalls()
+{
+    Polygons layer_walls;
+    for (SliceMeshStorage& mesh : storage.meshes)
+    {
+        for (SliceLayerPart& part : mesh.layers[layer_nr].parts)
+        {
+            if (part.insets.size() >= 2)
+            {
+                layer_walls.add(part.insets[1]);
+            }
+            else 
+            {
+                layer_walls.add(part.outline.offset(-offset_from_outlines));
+            }
+        }
+    }
+    return layer_walls;
+}
+  
 // boundary_outside is only computed when it's needed!
-Polygons& Comb::getBoundaryOutside()
+Polygons* Comb::getBoundaryOutside()
 {
     if (!boundary_outside)
     {
         boundary_outside = new Polygons();
-        *boundary_outside = storage.getLayerOutlines(layer_nr, false).offset(offset_from_outlines_outside); 
+        *boundary_outside =  storage.getLayerOutlines(layer_nr, false).offset(offset_from_outlines_outside); 
     }
-    return *boundary_outside;
+    return boundary_outside;
 }
-
-BucketGrid2D<PolygonsPointIndex>& Comb::getOutsideLocToLine()
-{
-    Polygons& outside = getBoundaryOutside();
-    if (!outside_loc_to_line)
-    {
-        outside_loc_to_line = PolygonUtils::createLocToLineGrid(outside, offset_from_outlines_outside * 3 / 2);
-    }
-    return *outside_loc_to_line;
-}
-
   
-Comb::Comb(SliceDataStorage& storage, int layer_nr, Polygons& comb_boundary_inside, int64_t comb_boundary_offset, bool travel_avoid_other_parts, int64_t travel_avoid_distance)
+Comb::Comb(SliceDataStorage& storage, unsigned int layer_nr, int64_t comb_boundary_offset, bool travel_avoid_other_parts, int64_t travel_avoid_distance)
 : storage(storage)
 , layer_nr(layer_nr)
 , offset_from_outlines(comb_boundary_offset) // between second wall and infill / other walls
 , max_moveInside_distance2(offset_from_outlines * 2 * offset_from_outlines * 2)
 , offset_from_outlines_outside(travel_avoid_distance)
-, max_crossing_dist2(offset_from_outlines_outside * offset_from_outlines_outside * 3) // so max_crossing_dist = offset_from_outlines_outside * sqrt(3), which is a bit more than sqrt(2) which is necesary for 90* corners
 , avoid_other_parts(travel_avoid_other_parts)
 // , boundary_inside( boundary.offset(-offset_from_outlines) ) // TODO: make inside boundary configurable?
-, boundary_inside( comb_boundary_inside )
+, boundary_inside( getLayerSecondWalls() )
 , boundary_outside(nullptr)
-, outside_loc_to_line(nullptr)
 , partsView_inside( boundary_inside.splitIntoPartsView() ) // !! changes the order of boundary_inside !!
 {
 }
@@ -51,28 +61,24 @@ Comb::Comb(SliceDataStorage& storage, int layer_nr, Polygons& comb_boundary_insi
 Comb::~Comb()
 {
     if (boundary_outside)
-    {
         delete boundary_outside;
-    }
-    if (outside_loc_to_line)
-    {
-        delete outside_loc_to_line;
-    }
 }
 
-bool Comb::calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool startInside, bool endInside, int64_t max_comb_distance_ignored)
+bool Comb::calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool startInside, bool endInside)
 {
     if (shorterThen(endPoint - startPoint, max_comb_distance_ignored))
     {
         return true;
     }
+    
 
+    
     //Move start and end point inside the comb boundary
     unsigned int start_inside_poly = NO_INDEX;
     if (startInside) 
     {
         start_inside_poly = PolygonUtils::moveInside(boundary_inside, startPoint, offset_extra_start_end, max_moveInside_distance2);
-        if (!boundary_inside.inside(start_inside_poly) || start_inside_poly == NO_INDEX)
+        if (!inside(start_inside_poly) || start_inside_poly == NO_INDEX)
         {
             if (start_inside_poly != NO_INDEX)
             { // if not yet inside because of overshoot, try again
@@ -88,7 +94,7 @@ bool Comb::calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool sta
     if (endInside)
     {
         end_inside_poly = PolygonUtils::moveInside(boundary_inside, endPoint, offset_extra_start_end, max_moveInside_distance2);
-        if (!boundary_inside.inside(endPoint) || end_inside_poly == NO_INDEX)
+        if (!inside(endPoint) || end_inside_poly == NO_INDEX)
         {
             if (end_inside_poly != NO_INDEX)
             { // if not yet inside because of overshoot, try again
@@ -111,136 +117,84 @@ bool Comb::calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool sta
     { // normal combing within part
         PolygonsPart part = partsView_inside.assemblePart(start_part_idx);
         combPaths.emplace_back();
-        LinePolygonsCrossings::comb(part, startPoint, endPoint, combPaths.back(), -offset_dist_to_get_from_on_the_polygon_to_outside, max_comb_distance_ignored);
+        LinePolygonsCrossings::comb(part, startPoint, endPoint, combPaths.back(), -offset_dist_to_get_from_on_the_polygon_to_outside);
         return true;
     }
     else 
     { // comb inside part to edge (if needed) >> move through air avoiding other parts >> comb inside end part upto the endpoint (if needed) 
-        //  INSIDE  |          in_between            |            OUTSIDE     |              in_between         |     INSIDE
-        //        ^crossing_1_in     ^crossing_1_mid  ^crossing_1_out        ^crossing_2_out    ^crossing_2_mid   ^crossing_2_in
-        //
-        // when startPoint is inside crossing_1_in is of interest
-        // when it is in between inside and outside it is equal to crossing_1_mid
-        Point crossing_1_in_or_mid; // the point inside the starting polygon if startPoint is inside or the startPoint itself if it is not inside
-        Point crossing_1_out;
-        Point crossing_2_in_or_mid; // the point inside the ending polygon if endPoint is inside or the endPoint itself if it is not inside
-        Point crossing_2_out;
+        Point middle_from;
+        Point middle_to;
         
-        { // find crossing over the in-between area between inside and outside
-            if (startInside)
-            {
-                ClosestPolygonPoint crossing_1_in_cp = PolygonUtils::findClosest(endPoint, boundary_inside[start_part_boundary_poly_idx]);
-                crossing_1_in_or_mid = PolygonUtils::moveInside(crossing_1_in_cp, offset_dist_to_get_from_on_the_polygon_to_outside); // in-case
+        if (startInside && endInside)
+        {
+            ClosestPolygonPoint middle_from_cp = PolygonUtils::findClosest(endPoint, boundary_inside[start_part_boundary_poly_idx]);
+            ClosestPolygonPoint middle_to_cp = PolygonUtils::findClosest(middle_from_cp.location, boundary_inside[end_part_boundary_poly_idx]);
+//             walkToNearestSmallestConnection(middle_from_cp, middle_to_cp); // TODO: perform this optimization?
+            middle_from = middle_from_cp.location;
+            middle_to = middle_to_cp.location;
+        }
+        else 
+        {
+            if (!startInside && !endInside) 
+            { 
+                middle_from = startPoint; 
+                middle_to = endPoint; 
             }
-            else 
+            else if (!startInside && endInside)
             {
-                crossing_1_in_or_mid = startPoint; // mid-case
+                middle_from = startPoint;
+                ClosestPolygonPoint middle_to_cp = PolygonUtils::findClosest(middle_from, boundary_inside[end_part_boundary_poly_idx]);
+                middle_to = middle_to_cp.location;
             }
-
-            if (endInside)
+            else if (startInside && !endInside)
             {
-                ClosestPolygonPoint crossing_2_in_cp = PolygonUtils::findClosest(crossing_1_in_or_mid, boundary_inside[end_part_boundary_poly_idx]);
-                crossing_2_in_or_mid = PolygonUtils::moveInside(crossing_2_in_cp, offset_dist_to_get_from_on_the_polygon_to_outside); // in-case
-            }
-            else 
-            {
-                crossing_2_in_or_mid = endPoint; // mid-case
+                middle_to = endPoint;
+                ClosestPolygonPoint middle_from_cp = PolygonUtils::findClosest(middle_to, boundary_inside[start_part_boundary_poly_idx]);
+                middle_from = middle_from_cp.location;
             }
         }
         
-        bool avoid_other_parts_now = avoid_other_parts;
-        if (avoid_other_parts_now && vSize2(crossing_1_in_or_mid - crossing_2_in_or_mid) < offset_from_outlines_outside * offset_from_outlines_outside * 4)
-        { // parts are next to eachother, i.e. the direct crossing will always be smaller than two crossings via outside
-            avoid_other_parts_now = false;
-        }
-        
-        if (avoid_other_parts_now)
-        { // compute the crossing points when moving through air
-            Polygons& outside = getBoundaryOutside(); // comb through all air, since generally the outside consists of a single part
-            
-            
-            crossing_1_out = crossing_1_in_or_mid;
-            if (startInside || outside.inside(crossing_1_in_or_mid, true)) // start in_between
-            { // move outside
-                ClosestPolygonPoint* crossing_1_out_cpp = PolygonUtils::findClose(crossing_1_in_or_mid, outside, getOutsideLocToLine());
-                if (crossing_1_out_cpp)
-                {
-                    crossing_1_out = PolygonUtils::moveOutside(*crossing_1_out_cpp, offset_dist_to_get_from_on_the_polygon_to_outside);
-                }
-                else 
-                {
-                    PolygonUtils::moveOutside(outside, crossing_1_out, offset_dist_to_get_from_on_the_polygon_to_outside);
-                }
-            }
-            int64_t in_out_dist2_1 = vSize2(crossing_1_out - crossing_1_in_or_mid); 
-            if (startInside && in_out_dist2_1 > max_crossing_dist2) // moveInside moved too far
-            { // if move is to far over in_between
-                // find crossing closer by
-                std::shared_ptr<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>> best = findBestCrossing(boundary_inside[start_part_boundary_poly_idx], startPoint, endPoint);
-                if (best)
-                {
-                    crossing_1_in_or_mid = PolygonUtils::moveInside(best->first, offset_dist_to_get_from_on_the_polygon_to_outside);
-                    crossing_1_out = PolygonUtils::moveOutside(best->second, offset_dist_to_get_from_on_the_polygon_to_outside);
-                }
-            }
-
-
-            crossing_2_out = crossing_2_in_or_mid;
-            if (endInside || outside.inside(crossing_2_in_or_mid, true))
-            { // move outside
-                ClosestPolygonPoint* crossing_2_out_cpp = PolygonUtils::findClose(crossing_2_in_or_mid, outside, getOutsideLocToLine());
-                if (crossing_2_out_cpp)
-                {
-                    crossing_2_out = PolygonUtils::moveOutside(*crossing_2_out_cpp, offset_dist_to_get_from_on_the_polygon_to_outside);
-                }
-                else 
-                {
-                    PolygonUtils::moveOutside(outside, crossing_2_out, offset_dist_to_get_from_on_the_polygon_to_outside);
-                }
-            }
-            int64_t in_out_dist2_2 = vSize2(crossing_2_out - crossing_2_in_or_mid); 
-            if (endInside && in_out_dist2_2 > max_crossing_dist2) // moveInside moved too far
-            { // if move is to far over in_between
-                // find crossing closer by
-                std::shared_ptr<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>> best = findBestCrossing(boundary_inside[end_part_boundary_poly_idx], endPoint, crossing_1_out);
-                if (best)
-                {
-                    crossing_2_in_or_mid = PolygonUtils::moveInside(best->first, offset_dist_to_get_from_on_the_polygon_to_outside);
-                    crossing_2_out = PolygonUtils::moveOutside(best->second, offset_dist_to_get_from_on_the_polygon_to_outside);
-                }
-            }
-        }
-
         if (startInside)
         {
             // start to boundary
             PolygonsPart part_begin = partsView_inside.assemblePart(start_part_idx); // comb through the starting part only
             combPaths.emplace_back();
-            LinePolygonsCrossings::comb(part_begin, startPoint, crossing_1_in_or_mid, combPaths.back(), -offset_dist_to_get_from_on_the_polygon_to_outside, max_comb_distance_ignored);
+            LinePolygonsCrossings::comb(part_begin, startPoint, middle_from, combPaths.back(), -offset_dist_to_get_from_on_the_polygon_to_outside);
         }
         
         // throught air from boundary to boundary
-        if (avoid_other_parts_now)
+        if (avoid_other_parts)
         {
+            Polygons& middle = *getBoundaryOutside(); // comb through all air, since generally the outside consists of a single part
+            Point from_outside = middle_from;
+            if (startInside || middle.inside(from_outside, true))
+            { // move outside
+                PolygonUtils::moveInside(middle, from_outside, -offset_extra_start_end, max_moveInside_distance2);
+            }
+            Point to_outside = middle_to;
+            if (endInside || middle.inside(to_outside, true))
+            { // move outside
+                PolygonUtils::moveInside(middle, to_outside, -offset_extra_start_end, max_moveInside_distance2);
+            }
             combPaths.emplace_back();
-            combPaths.throughAir = true;
-            if ( vSize(crossing_1_in_or_mid - crossing_2_in_or_mid) < vSize(crossing_1_in_or_mid - crossing_1_out) + vSize(crossing_2_in_or_mid - crossing_2_out) )
-            { // via outside is moving more over the in-between zone
-                combPaths.back().push_back(crossing_1_in_or_mid);
-                combPaths.back().push_back(crossing_2_in_or_mid);
+            combPaths.back().throughAir = true;
+            if ( vSize(middle_from - middle_to) < vSize(middle_from - from_outside) + vSize(middle_to - to_outside) )
+            { // via outside is a detour
+                combPaths.back().push_back(middle_from);
+                combPaths.back().push_back(middle_to);
             }
             else
             {
-                LinePolygonsCrossings::comb(getBoundaryOutside(), crossing_1_out, crossing_2_out, combPaths.back(), offset_dist_to_get_from_on_the_polygon_to_outside, max_comb_distance_ignored);
+                LinePolygonsCrossings::comb(middle, from_outside, to_outside, combPaths.back(), offset_dist_to_get_from_on_the_polygon_to_outside);
             }
         }
         else 
         { // directly through air (not avoiding other parts)
             combPaths.emplace_back();
-            combPaths.throughAir = true;
+            combPaths.back().throughAir = true;
             combPaths.back().cross_boundary = true; // TODO: calculate whether we cross a boundary!
-            combPaths.back().push_back(crossing_1_in_or_mid);
-            combPaths.back().push_back(crossing_2_in_or_mid);
+            combPaths.back().push_back(middle_from);
+            combPaths.back().push_back(middle_to);
         }
         
         if (endInside)
@@ -248,45 +202,13 @@ bool Comb::calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool sta
             // boundary to end
             PolygonsPart part_end = partsView_inside.assemblePart(end_part_idx); // comb through end part only
             combPaths.emplace_back();
-            LinePolygonsCrossings::comb(part_end, crossing_2_in_or_mid, endPoint, combPaths.back(), -offset_dist_to_get_from_on_the_polygon_to_outside, max_comb_distance_ignored);
+            LinePolygonsCrossings::comb(part_end, middle_to, endPoint, combPaths.back(), -offset_dist_to_get_from_on_the_polygon_to_outside);
         }
         
         return true;
     }
 }
 
-std::shared_ptr<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>> Comb::findBestCrossing(PolygonRef from, Point estimated_start, Point estimated_end)
-{
-    ClosestPolygonPoint* best_in = nullptr;
-    ClosestPolygonPoint* best_out = nullptr;
-    int64_t best_detour_dist = std::numeric_limits<int64_t>::max();
-    std::vector<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>> crossing_out_candidates = PolygonUtils::findClose(from, getBoundaryOutside(), getOutsideLocToLine());
-    for (std::pair<ClosestPolygonPoint, ClosestPolygonPoint>& crossing_candidate : crossing_out_candidates)
-    {
-        int64_t crossing_dist2 = vSize2(crossing_candidate.first.location - crossing_candidate.second.location);
-        if (crossing_dist2 > max_crossing_dist2)
-        {
-            continue;
-        }
-        
-        int64_t dist_to_start = vSize(crossing_candidate.second.location - estimated_start); // use outside location, so that the crossing direction is taken into account
-        int64_t dist_to_end = vSize(crossing_candidate.second.location - estimated_end);
-        int64_t detour_dist = dist_to_start + dist_to_end;
-        if (detour_dist < best_detour_dist)
-        {
-            best_in = &crossing_candidate.first;
-            best_out = &crossing_candidate.second;
-            best_detour_dist = detour_dist;
-        }
-    }
-    if (best_detour_dist == std::numeric_limits<int64_t>::max())
-    {
-        return std::shared_ptr<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>>();
-    }
-    return std::make_shared<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>>(*best_in, *best_out);
-}
-
-
 void LinePolygonsCrossings::calcScanlineCrossings()
 {
     
@@ -297,32 +219,18 @@ void LinePolygonsCrossings::calcScanlineCrossings()
     {
         PolyCrossings minMax(poly_idx); 
         PolygonRef poly = boundary[poly_idx];
-        Point p0 = transformation_matrix.apply(poly[poly.size() - 1]);
+        Point p0 = transformation_matrix.apply(poly.back());
         for(unsigned int point_idx = 0; point_idx < poly.size(); point_idx++)
         {
             Point p1 = transformation_matrix.apply(poly[point_idx]);
-            if((p0.Y >= transformed_startPoint.Y && p1.Y <= transformed_startPoint.Y) || (p1.Y >= transformed_startPoint.Y && p0.Y <= transformed_startPoint.Y))
+            if ((p0.Y > transformed_startPoint.Y && p1.Y < transformed_startPoint.Y) || (p1.Y > transformed_startPoint.Y && p0.Y < transformed_startPoint.Y))
             {
-                if(p1.Y == p0.Y) //Line segment is parallel with the scanline. That means that both endpoints lie on the scanline, so they will have intersected with the adjacent line.
-                {
-                    p0 = p1;
-                    continue;
-                }
                 int64_t x = p0.X + (p1.X - p0.X) * (transformed_startPoint.Y - p0.Y) / (p1.Y - p0.Y);
                 
                 if (x >= transformed_startPoint.X && x <= transformed_endPoint.X)
                 {
-                    if(x < minMax.min.x) //For the leftmost intersection, move x left to stay outside of the border.
-                                         //Note: The actual distance from the intersection to the border is almost always less than dist_to_move_boundary_point_outside, since it only moves along the direction of the scanline.
-                    {
-                        minMax.min.x = x;
-                        minMax.min.point_idx = point_idx;
-                    }
-                    if(x > minMax.max.x) //For the rightmost intersection, move x right to stay outside of the border.
-                    {
-                        minMax.max.x = x;
-                        minMax.max.point_idx = point_idx;
-                    }
+                    if (x < minMax.min.x) { minMax.min.x = x; minMax.min.point_idx = point_idx; }
+                    if (x > minMax.max.x) { minMax.max.x = x; minMax.max.point_idx = point_idx; }
                 }
             }
             p0 = p1;
@@ -368,14 +276,14 @@ bool LinePolygonsCrossings::lineSegmentCollidesWithBoundary()
 }
 
 
-void LinePolygonsCrossings::getCombingPath(CombPath& combPath, int64_t max_comb_distance_ignored)
+void LinePolygonsCrossings::getCombingPath(CombPath& combPath)
 {
-    if (shorterThen(endPoint - startPoint, max_comb_distance_ignored) || !lineSegmentCollidesWithBoundary())
+    if (shorterThen(endPoint - startPoint, Comb::max_comb_distance_ignored) || !lineSegmentCollidesWithBoundary())
     {
         //We're not crossing any boundaries. So skip the comb generation.
         combPath.push_back(startPoint); 
-        combPath.push_back(endPoint);
-        return;
+        combPath.push_back(endPoint); 
+        return; 
     }
     
     calcScanlineCrossings();
@@ -383,7 +291,6 @@ void LinePolygonsCrossings::getCombingPath(CombPath& combPath, int64_t max_comb_
     CombPath basicPath;
     getBasicCombingPath(basicPath);
     optimizePath(basicPath, combPath);
-//     combPath = basicPath; // uncomment to disable comb path optimization
 }
 
 
@@ -401,7 +308,7 @@ void LinePolygonsCrossings::getBasicCombingPath(CombPath& combPath)
 void LinePolygonsCrossings::getBasicCombingPath(PolyCrossings& polyCrossings, CombPath& combPath) 
 {
     PolygonRef poly = boundary[polyCrossings.poly_idx];
-    combPath.push_back(transformation_matrix.unapply(Point(polyCrossings.min.x - dist_to_move_boundary_point_outside, transformed_startPoint.Y)));
+    combPath.push_back(transformation_matrix.unapply(Point(polyCrossings.min.x, transformed_startPoint.Y)));
     if ( ( polyCrossings.max.point_idx - polyCrossings.min.point_idx + poly.size() ) % poly.size() 
         < poly.size() / 2 )
     { // follow the path in the same direction as the winding order of the boundary polygon
@@ -416,13 +323,13 @@ void LinePolygonsCrossings::getBasicCombingPath(PolyCrossings& polyCrossings, Co
     { // follow the path in the opposite direction of the winding order of the boundary polygon
         unsigned int min_idx = (polyCrossings.min.point_idx == 0)? poly.size() - 1: polyCrossings.min.point_idx - 1;
         unsigned int max_idx = (polyCrossings.max.point_idx == 0)? poly.size() - 1: polyCrossings.max.point_idx - 1;
-
+        
         for(unsigned int point_idx = min_idx; point_idx != max_idx; point_idx = (point_idx > 0) ? (point_idx - 1) : (poly.size() - 1))
         {
             combPath.push_back(PolygonUtils::getBoundaryPointWithOffset(poly, point_idx, dist_to_move_boundary_point_outside));
         }
     }
-    combPath.push_back(transformation_matrix.unapply(Point(polyCrossings.max.x + dist_to_move_boundary_point_outside, transformed_startPoint.Y))); 
+    combPath.push_back(transformation_matrix.unapply(Point(polyCrossings.max.x, transformed_startPoint.Y))); 
 }
 
 
@@ -441,14 +348,10 @@ LinePolygonsCrossings::PolyCrossings* LinePolygonsCrossings::getNextPolygonAlong
 }
 
 bool LinePolygonsCrossings::optimizePath(CombPath& comb_path, CombPath& optimized_comb_path) 
-{
+{   
     optimized_comb_path.push_back(startPoint);
     for(unsigned int point_idx = 1; point_idx<comb_path.size(); point_idx++)
     {
-        if(comb_path[point_idx] == comb_path[point_idx - 1]) //Two points are the same. Skip the second.
-        {
-            continue;
-        }
         Point& current_point = optimized_comb_path.back();
         if (PolygonUtils::polygonCollidesWithlineSegment(boundary, current_point, comb_path[point_idx]))
         {
@@ -476,7 +379,6 @@ bool LinePolygonsCrossings::optimizePath(CombPath& comb_path, CombPath& optimize
             }
         }
     }
-    optimized_comb_path.push_back(comb_path.back());
     return true;
 }
 

src/comb.h

@@ -2,22 +2,18 @@
 #ifndef COMB_H
 #define COMB_H
 
-#include <memory> // shared_ptr
-
 #include "utils/polygon.h"
-#include "utils/BucketGrid2D.h"
-#include "utils/polygonUtils.h"
 
 namespace cura 
 {
     
 struct CombPath : public  std::vector<Point> //!< A single path either inside or outise the parts
 {
+    bool throughAir = false; //!< Whether the path is one which moves through air.
     bool cross_boundary = false; //!< Whether the path crosses a boundary.
 };
 struct CombPaths : public  std::vector<CombPath> //!< A list of paths alternating between inside a part and outside a part
 {
-    bool throughAir = false; //!< Whether the path is one which moves through air.
 }; 
 
 /*!
@@ -117,7 +113,7 @@ private:
      * 
      * \param combPath Output parameter: the points along the combing path.
      */
-    void getCombingPath(CombPath& combPath, int64_t max_comb_distance_ignored = MM2INT(1.5));
+    void getCombingPath(CombPath& combPath);
     
     /*! 
      * Get the basic combing path, without shortcuts. The path goes straight toward the endPoint and follows the boundary when it hits it, until it passes the scanline again.
@@ -182,10 +178,10 @@ public:
      * \param endPoint Where to end the combing move.
      * \param combPath Output parameter: the combing path generated.
      */
-    static void comb(Polygons& boundary, Point startPoint, Point endPoint, CombPath& combPath, int64_t dist_to_move_boundary_point_outside, int64_t max_comb_distance_ignored = MM2INT(1.5))
+    static void comb(Polygons& boundary, Point startPoint, Point endPoint, CombPath& combPath, int64_t dist_to_move_boundary_point_outside)
     {
         LinePolygonsCrossings linePolygonsCrossings(boundary, startPoint, endPoint, dist_to_move_boundary_point_outside);
-        linePolygonsCrossings.getCombingPath(combPath, max_comb_distance_ignored);
+        linePolygonsCrossings.getCombingPath(combPath);
     };
 };
 
@@ -209,58 +205,47 @@ class Comb
     friend class LinePolygonsCrossings;
 private:
     SliceDataStorage& storage; //!< The storage from which to compute the outside boundary, when needed.
-    const int layer_nr; //!< The layer number for the layer for which to compute the outside boundary, when needed.
+    unsigned int layer_nr; //!< The layer number for the layer for which to compute the outside boundary, when needed.
     
-    const int64_t offset_from_outlines; //!< Offset from the boundary of a part to the comb path. (nozzle width / 2)
-    const int64_t max_moveInside_distance2; //!< Maximal distance of a point to the Comb::boundary_inside which is still to be considered inside. (very sharp corners not allowed :S)
-    const int64_t offset_from_outlines_outside; //!< Offset from the boundary of a part to a travel path which avoids it by this distance.
-    const int64_t max_crossing_dist2; //!< The maximal distance by which to cross the in_between area between inside and outside
+    int64_t offset_from_outlines; //!< Offset from the boundary of a part to the comb path. (nozzle width / 2)
+    int64_t max_moveInside_distance2; //!< Maximal distance of a point to the Comb::boundary_inside which is still to be considered inside. (very sharp corners not allowed :S)
+    int64_t offset_from_outlines_outside; //!< Offset from the boundary of a part to a travel path which avoids it by this distance.
     static const int64_t max_moveOutside_distance2 = INT64_MAX; //!< Any point which is not inside should be considered outside.
     static const int64_t offset_dist_to_get_from_on_the_polygon_to_outside = 40; //!< in order to prevent on-boundary vs crossing boundary confusions (precision thing)
+    static const int64_t max_comb_distance_ignored = MM2INT(1.5); //!< If the direct path from start point to end point is shorter than this, go directly without any combing.
     static const int64_t offset_extra_start_end = 100; //!< Distance to move start point and end point toward eachother to extra avoid collision with the boundaries.
-
-    const bool avoid_other_parts; //!< Whether to perform inverse combing a.k.a. avoid parts.
     
-    Polygons& boundary_inside; //!< The boundary within which to comb.
+    bool avoid_other_parts; //!< Whether to perform inverse combing a.k.a. avoid parts.
+    
+    Polygons boundary_inside; //!< The boundary within which to comb.
     Polygons* boundary_outside; //!< The boundary outside of which to stay to avoid collision with other layer parts. This is a pointer cause we only compute it when we move outside the boundary (so not when there is only a single part in the layer)
-    BucketGrid2D<PolygonsPointIndex>* outside_loc_to_line; //!< The BucketGrid mapping locations to line segments of the outside boundary.
     PartsView partsView_inside; //!< Structured indices onto boundary_inside which shows which polygons belong to which part. 
+        
+    /*!
+     * Collects the inner most walls for every mesh in the layer (not support) or computes them from the outlines using Comb::offset_from_outlines.
+     */
+    Polygons getLayerSecondWalls();
 
     /*!
      * Get the boundary_outside, which is an offset from the outlines of all meshes in the layer. Calculate it when it hasn't been calculated yet.
      */
-    Polygons& getBoundaryOutside();
-    
-    /*!
-     * Get the BucketGrid mapping locations to line segments of the outside boundary. Calculate it when it hasn't been calculated yet.
-     */
-    BucketGrid2D<PolygonsPointIndex>& getOutsideLocToLine();
-    
-    /*!
-     * Find the best crossing from some inside polygon to the outside boundary.
-     * 
-     * The detour from \p estimated_start to \p estimated_end is minimized.
-     * 
-     * \param from From which inside boundary the crossing to the outside starts or ends
-     * \param estimated_start The one point to which to stay close when evaluating crossings which cross about the same distance
-     * \param estimated_end The other point to which to stay close when evaluating crossings which cross about the same distance
-     * \return A pair of which the first is the crossing point on the inside boundary and the second the crossing point on the outside boundary
-     */
-    std::shared_ptr<std::pair<ClosestPolygonPoint, ClosestPolygonPoint>> findBestCrossing(PolygonRef from, Point estimated_start, Point estimated_end);
+    Polygons* getBoundaryOutside();
     
 public:
     /*!
      * Initializes the combing areas for every mesh in the layer (not support)
      * \param storage Where the layer polygon data is stored
      * \param layer_nr The number of the layer for which to generate the combing areas.
-     * \param comb_boundary_inside The comb boundary within which to comb within layer parts.
      * \param offset_from_outlines The offset from the outline polygon, to create the combing boundary in case there is no second wall.
      * \param travel_avoid_other_parts Whether to avoid other layer parts when traveling through air.
      * \param travel_avoid_distance The distance by which to avoid other layer parts when traveling through air.
      */
-    Comb(SliceDataStorage& storage, int layer_nr, Polygons& comb_boundary_inside, int64_t offset_from_outlines, bool travel_avoid_other_parts, int64_t travel_avoid_distance);
+    Comb(SliceDataStorage& storage, unsigned int layer_nr, int64_t offset_from_outlines, bool travel_avoid_other_parts, int64_t travel_avoid_distance);
     
     ~Comb();
+    
+    //! Utility function for `boundary_inside.inside(p)`.
+    bool inside(const Point p) { return boundary_inside.inside(p); }
 
     /*!
      * Calculate the comb paths (if any) - one for each polygon combed alternated with travel paths
@@ -272,7 +257,17 @@ public:
      * \param endInside Whether we want to end up inside the comb boundary
      * \return Whether combing has succeeded; otherwise a retraction is needed.
      */    
-    bool calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool startInside = false, bool endInside = false, int64_t max_comb_distance_ignored = MM2INT(1.5));
+    bool calc(Point startPoint, Point endPoint, CombPaths& combPaths, bool startInside = false, bool endInside = false);
+    
+    /*!
+     * Move \p p to inside the inner comb boundary with a \p distance from the boundary.
+     * 
+     * \param p the point to change/move
+     * \param distance the distance from the resulting point to the boundary on the inside
+     * \return whether the point has been moved inside
+     */
+    bool moveInsideBoundary(Point* p, int distance);
+    
 };
 
 }//namespace cura

src/commandSocket.cpp

@@ -1,263 +1,150 @@
 #include "utils/logoutput.h"
 #include "commandSocket.h"
 #include "FffProcessor.h"
-#include "progress/Progress.h"
+#include "Progress.h"
 
 #include <thread>
 #include <cinttypes>
 
-#ifdef ARCUS
 #include <Arcus/Socket.h>
-#include <Arcus/SocketListener.h>
-#include <Arcus/Error.h>
-#endif
-
-#include <string> // stoi
 
 #ifdef _WIN32
 #include <windows.h>
 #endif
 
-#include "settings/SettingRegistry.h" // loadExtruderJSONsettings
-
-#define DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR(x) 
-
-// std::cerr << x;
-
 namespace cura {
 
 #define BYTES_PER_FLOAT 4
 #define FLOATS_PER_VECTOR 3
 #define VECTORS_PER_FACE 3
-
-CommandSocket* CommandSocket::instance = nullptr; // instantiate instance
-
-#ifdef ARCUS
-class Listener : public Arcus::SocketListener
-{
-public:
-    void stateChanged(Arcus::SocketState::SocketState newState) override
-    {
-    }
-
-    void messageReceived() override
-    {
-    }
-
-    void error(const Arcus::Error & error) override
-    {
-        if (error.getErrorCode() == Arcus::ErrorCode::Debug)
-        {
-            log("%s\n", error.toString().c_str());
-        }
-        else
-        {
-            logError("%s\n", error.toString().c_str());
-        }
-    }
-};
-
+    
 class CommandSocket::Private
 {
 public:
     Private()
         : socket(nullptr)
         , object_count(0)
+        , current_sliced_object(nullptr)
         , sliced_objects(0)
-        , current_layer_count(0)
-        , current_layer_offset(0)
     { }
 
-    std::shared_ptr<cura::proto::Layer> getLayerById(int id);
+    cura::proto::Layer* getLayerById(int id);
 
     Arcus::Socket* socket;
     
     // Number of objects that need to be sliced
     int object_count;
-
+    
+    // Message that holds a list of sliced objects
+    std::shared_ptr<cura::proto::SlicedObjectList> sliced_object_list;
+    
+    // Message that holds the currently sliced object (to be added to sliced_object_list)
+    cura::proto::SlicedObject* current_sliced_object;
+    
     // Number of sliced objects for this sliced object list
     int sliced_objects;
-
-    // Number of layers sent to the front end so far
-    // Used for incrementing the current layer in one at a time mode
-    int current_layer_count;
-    int current_layer_offset;
+    
+    // Ids of the sliced objects
+    std::vector<int64_t> object_ids;
 
     std::string temp_gcode_file;
     std::ostringstream gcode_output_stream;
     
     // Print object that olds one or more meshes that need to be sliced. 
     std::vector< std::shared_ptr<MeshGroup> > objects_to_slice;
-
-    std::unordered_map<int, std::shared_ptr<cura::proto::Layer>> sliced_layers;
 };
-#endif
 
 CommandSocket::CommandSocket()
-#ifdef ARCUS
-    : private_data(new Private)
-#endif
+    : d(new Private)
 {
-#ifdef ARCUS
-#endif
+    FffProcessor::getInstance()->setCommandSocket(this);
 }
 
-CommandSocket* CommandSocket::getInstance()
-{
-    return instance;
-}
-
-void CommandSocket::instantiate()
-{
-    instance = new CommandSocket();
-}
-
-bool CommandSocket::isInstantiated()
-{
-    return instance != nullptr;
-}
-
-
 void CommandSocket::connect(const std::string& ip, int port)
 {
-#ifdef ARCUS
-    private_data->socket = new Arcus::Socket();
-    private_data->socket->addListener(new Listener());
+    d->socket = new Arcus::Socket();
+    //d->socket->registerMessageType(1, &Cura::ObjectList::default_instance());
+    d->socket->registerMessageType(1, &cura::proto::Slice::default_instance());
+    d->socket->registerMessageType(2, &cura::proto::SlicedObjectList::default_instance());
+    d->socket->registerMessageType(3, &cura::proto::Progress::default_instance());
+    d->socket->registerMessageType(4, &cura::proto::GCodeLayer::default_instance());
+    d->socket->registerMessageType(5, &cura::proto::ObjectPrintTime::default_instance());
+    d->socket->registerMessageType(6, &cura::proto::SettingList::default_instance());
+    d->socket->registerMessageType(7, &cura::proto::GCodePrefix::default_instance());
 
-    //private_data->socket->registerMessageType(1, &Cura::ObjectList::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::Slice::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::Layer::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::Progress::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::GCodeLayer::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::ObjectPrintTime::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::SettingList::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::GCodePrefix::default_instance());
-    private_data->socket->registerMessageType(&cura::proto::SlicingFinished::default_instance());
-
-    private_data->socket->connect(ip, port);
-
-    log("Connecting to %s:%i\n", ip.c_str(), port);
-
-    while(private_data->socket->getState() != Arcus::SocketState::Connected && private_data->socket->getState() != Arcus::SocketState::Error)
-    {
-        std::this_thread::sleep_for(std::chrono::milliseconds(100));
-    }
-
-    log("Connected to %s:%i\n", ip.c_str(), port);
-    
-    bool slice_another_time = true;
+    d->socket->connect(ip, port);
     
     // Start & continue listening as long as socket is not closed and there is no error.
-    while(private_data->socket->getState() != Arcus::SocketState::Closed && private_data->socket->getState() != Arcus::SocketState::Error && slice_another_time)
+    while(d->socket->state() != Arcus::SocketState::Closed && d->socket->state() != Arcus::SocketState::Error)
     {
+        //If there is an object to slice, do so.
+        if(d->objects_to_slice.size())
+        {
+            for(auto object : d->objects_to_slice)
+            {
+                FffProcessor::getInstance()->processMeshGroup(object.get());
+            }
+            d->objects_to_slice.clear();
+            sendPrintTime();
+            //TODO: Support all-at-once/one-at-a-time printing
+            //d->processor->processModel(d->object_to_slice.get());
+            //d->object_to_slice.reset();
+            //d->processor->resetFileNumber();
+
+            //sendPrintTime();
+        }
+        
         // Actually start handling messages.
-        Arcus::MessagePtr message = private_data->socket->takeNextMessage();
+        Arcus::MessagePtr message = d->socket->takeNextMessage();
         cura::proto::SettingList* setting_list = dynamic_cast<cura::proto::SettingList*>(message.get());
-        if (setting_list)
+        if(setting_list)
         {
             handleSettingList(setting_list);
         }
 
         /*cura::proto::ObjectList* object_list = dynamic_cast<cura::proto::ObjectList*>(message.get());
-        if (object_list)
+        if(object_list)
         {
             handleObjectList(object_list);
         }*/
         
         cura::proto::Slice* slice = dynamic_cast<cura::proto::Slice*>(message.get());
-        if (slice)
+        if(slice)
         {
             // Reset object counts
-            private_data->object_count = 0;
-            for (auto object : slice->object_lists())
+            d->object_count = 0;
+            d->object_ids.clear();
+            for(auto object : slice->object_lists())
             {
                 handleObjectList(&object);
             }
         }
 
-        //If there is an object to slice, do so.
-        if (private_data->objects_to_slice.size())
-        {
-            FffProcessor::getInstance()->resetMeshGroupNumber();
-            for (auto object : private_data->objects_to_slice)
-            {
-                if (!FffProcessor::getInstance()->processMeshGroup(object.get()))
-                {
-                    logError("Slicing mesh group failed!");
-                }
-            }
-            private_data->objects_to_slice.clear();
-            FffProcessor::getInstance()->finalize();
-            flushGcode();
-            sendPrintTime();
-            sendFinishedSlicing();
-            slice_another_time = false; // TODO: remove this when multiple slicing with CuraEngine is safe
-            //TODO: Support all-at-once/one-at-a-time printing
-            //private_data->processor->processModel(private_data->object_to_slice.get());
-            //private_data->object_to_slice.reset();
-            //private_data->processor->resetFileNumber();
-
-            //sendPrintTime();
-        }
-
         std::this_thread::sleep_for(std::chrono::milliseconds(250));
+
+        if(!d->socket->errorString().empty()) 
+        {
+            logError("%s\n", d->socket->errorString().data());
+            d->socket->clearError();
+        }
     }
-    log("Closing connection\n");
-    private_data->socket->close();
-#endif
 }
 
-#ifdef ARCUS
 void CommandSocket::handleObjectList(cura::proto::ObjectList* list)
 {
-    if (list->objects_size() <= 0)
-    {
-        return;
-    }
-
     FMatrix3x3 matrix;
-    //private_data->object_count = 0;
-    //private_data->object_ids.clear();
-    private_data->objects_to_slice.push_back(std::make_shared<MeshGroup>(FffProcessor::getInstance()));
-    MeshGroup* meshgroup = private_data->objects_to_slice.back().get();
-    
-    for (auto setting : list->settings())
-    {
-        meshgroup->setSetting(setting.name(), setting.value());
-    }
-    
-    for (int extruder_nr = 0; extruder_nr < FffProcessor::getInstance()->getSettingAsCount("machine_extruder_count"); extruder_nr++)
-    { // initialize remaining extruder trains and load the defaults
-        ExtruderTrain* train = meshgroup->createExtruderTrain(extruder_nr); // create new extruder train objects or use already existing ones
-        SettingRegistry::getInstance()->loadExtruderJSONsettings(extruder_nr, train);
-    }
-    
-    for (auto object : list->objects())
+    //d->object_count = 0;
+    //d->object_ids.clear();
+    d->objects_to_slice.push_back(std::make_shared<MeshGroup>(FffProcessor::getInstance()));
+    MeshGroup* object_to_slice = d->objects_to_slice.back().get();
+    for(auto object : list->objects())
     {
+        object_to_slice->meshes.push_back(object_to_slice); //Construct a new mesh (with object_to_slice as settings parent object) and put it into MeshGroup's mesh list.
+        Mesh& mesh = object_to_slice->meshes.back();
+
         int bytes_per_face = BYTES_PER_FLOAT * FLOATS_PER_VECTOR * VECTORS_PER_FACE;
         int face_count = object.vertices().size() / bytes_per_face;
-
-        if (face_count <= 0)
-        {
-            logWarning("Got an empty mesh, ignoring it!");
-            continue;
-        }
-        DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("solid Cura_out\n");
-        int extruder_train_nr = 0; // TODO: make primary extruder configurable!
-        for (auto setting : object.settings())
-        {
-            if (setting.name() == "extruder_nr")
-            {
-                extruder_train_nr = std::stoi(setting.value());
-                break;
-            }
-        }
-        SettingsBase* extruder_train = meshgroup->getExtruderTrain(extruder_train_nr);
-
-        meshgroup->meshes.push_back(extruder_train); //Construct a new mesh (with the corresponding extruder train as settings parent object) and put it into MeshGroup's mesh list.
-        Mesh& mesh = meshgroup->meshes.back();
-
-        for (int i = 0; i < face_count; ++i)
+        for(int i = 0; i < face_count; ++i)
         {
             //TODO: Apply matrix
             std::string data = object.vertices().substr(i * bytes_per_face, bytes_per_face);
@@ -268,75 +155,74 @@ void CommandSocket::handleObjectList(cura::proto::ObjectList* list)
             verts[1] = matrix.apply(float_vertices[1]);
             verts[2] = matrix.apply(float_vertices[2]);
             mesh.addFace(verts[0], verts[1], verts[2]);
-
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("  facet normal -1 0 0\n");
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("    outer loop\n");
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("      vertex "<<INT2MM(verts[0].x) <<" " << INT2MM(verts[0].y) <<" " << INT2MM(verts[0].z) << "\n");
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("      vertex "<<INT2MM(verts[1].x) <<" " << INT2MM(verts[1].y) <<" " << INT2MM(verts[1].z) << "\n");
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("      vertex "<<INT2MM(verts[2].x) <<" " << INT2MM(verts[2].y) <<" " << INT2MM(verts[2].z) << "\n");
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("    endloop\n");
-            DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("  endfacet\n");
         }
-        DEBUG_OUTPUT_OBJECT_STL_THROUGH_CERR("endsolid Cura_out\n");
-        for (auto setting : object.settings())
+
+        for(auto setting : object.settings())
         {
             mesh.setSetting(setting.name(), setting.value());
         }
 
+        d->object_ids.push_back(object.id());
         mesh.finish();
     }
 
-    private_data->object_count++;
-    meshgroup->finalize();
+    for(auto setting : list->settings())
+    {
+        object_to_slice->setSetting(setting.name(), setting.value());
+    }
+
+    d->object_count++;
+    object_to_slice->finalize();
 }
 
 void CommandSocket::handleSettingList(cura::proto::SettingList* list)
 {
-    for (auto setting : list->settings())
+    for(auto setting : list->settings())
     {
         FffProcessor::getInstance()->setSetting(setting.name(), setting.value());
     }
 }
-#endif
 
 void CommandSocket::sendLayerInfo(int layer_nr, int32_t z, int32_t height)
 {
-#ifdef ARCUS
-    std::shared_ptr<cura::proto::Layer> layer = private_data->getLayerById(layer_nr);
+    if(!d->current_sliced_object)
+    {
+        return;
+    }
+    
+    cura::proto::Layer* layer = d->getLayerById(layer_nr);
     layer->set_height(z);
     layer->set_thickness(height);
-#endif
 }
 
-void CommandSocket::sendPolygons(PrintFeatureType type, int layer_nr, Polygons& polygons, int line_width)
+void CommandSocket::sendPolygons(PolygonType type, int layer_nr, Polygons& polygons, int line_width)
 {
-#ifdef ARCUS
+    if(!d->current_sliced_object)
+        return;
+    
     if (polygons.size() == 0)
         return;
 
-    std::shared_ptr<cura::proto::Layer> proto_layer = private_data->getLayerById(layer_nr);
+    cura::proto::Layer* layer = d->getLayerById(layer_nr);
 
-    for (unsigned int i = 0; i < polygons.size(); ++i)
+    for(unsigned int i = 0; i < polygons.size(); ++i)
     {
-        cura::proto::Polygon* p = proto_layer->add_polygons();
+        cura::proto::Polygon* p = layer->add_polygons();
         p->set_type(static_cast<cura::proto::Polygon_Type>(type));
         std::string polydata;
         polydata.append(reinterpret_cast<const char*>(polygons[i].data()), polygons[i].size() * sizeof(Point));
         p->set_points(polydata);
         p->set_line_width(line_width);
     }
-#endif
 }
 
 void CommandSocket::sendProgress(float amount)
 {
-#ifdef ARCUS
     auto message = std::make_shared<cura::proto::Progress>();
-    amount /= private_data->object_count;
-    amount += private_data->sliced_objects * (1. / private_data->object_count);
+    amount /= d->object_count;
+    amount += d->sliced_objects * (1. / d->object_count);
     message->set_amount(amount);
-    private_data->socket->sendMessage(message);
-#endif
+    d->socket->sendMessage(message);
 }
 
 void CommandSocket::sendProgressStage(Progress::Stage stage)
@@ -346,12 +232,10 @@ void CommandSocket::sendProgressStage(Progress::Stage stage)
 
 void CommandSocket::sendPrintTime()
 {
-#ifdef ARCUS
     auto message = std::make_shared<cura::proto::ObjectPrintTime>();
     message->set_time(FffProcessor::getInstance()->getTotalPrintTime());
     message->set_material_amount(FffProcessor::getInstance()->getTotalFilamentUsed(0));
-    private_data->socket->sendMessage(message);
-#endif
+    d->socket->sendMessage(message);
 }
 
 void CommandSocket::sendPrintMaterialForObject(int index, int extruder_nr, float print_time)
@@ -363,88 +247,68 @@ void CommandSocket::sendPrintMaterialForObject(int index, int extruder_nr, float
 //     socket.sendFloat32(print_time);
 }
 
-void CommandSocket::sendLayerData()
+void CommandSocket::beginSendSlicedObject()
 {
-#ifdef ARCUS
-#endif
-#ifdef ARCUS
-    private_data->sliced_objects++;
-    private_data->current_layer_offset = private_data->current_layer_count;
-    log("End sliced object called. Sending ", private_data->current_layer_count, " layers.");
-
-    if (private_data->sliced_objects >= private_data->object_count)
+    if(!d->sliced_object_list)
     {
-        for (std::pair<const int, std::shared_ptr<cura::proto::Layer>> entry : private_data->sliced_layers) //Note: This is in no particular order!
-        {
-            private_data->socket->sendMessage(entry.second); //Send the actual layers.
-        }
-        private_data->sliced_objects = 0;
-        private_data->current_layer_count = 0;
-        private_data->current_layer_offset = 0;
-        private_data->sliced_layers.clear();
-        auto done_message = std::make_shared<cura::proto::SlicingFinished>();
-        private_data->socket->sendMessage(done_message);
+        d->sliced_object_list = std::make_shared<cura::proto::SlicedObjectList>();
     }
-#endif
+
+    d->current_sliced_object = d->sliced_object_list->add_objects();
+    d->current_sliced_object->set_id(d->object_ids[d->sliced_objects]);
 }
 
-void CommandSocket::sendFinishedSlicing()
+void CommandSocket::endSendSlicedObject()
 {
-#ifdef ARCUS
-    std::shared_ptr<cura::proto::SlicingFinished> done_message = std::make_shared<cura::proto::SlicingFinished>();
-    private_data->socket->sendMessage(done_message);
-#endif
+    d->sliced_objects++;
+    std::cout << "End sliced object called. sliced objects " << d->sliced_objects << " object count: " << d->object_count << std::endl;
+    if(d->sliced_objects >= d->object_count)
+    {
+        d->socket->sendMessage(d->sliced_object_list);
+        d->sliced_objects = 0;
+        d->sliced_object_list.reset();
+        d->current_sliced_object = nullptr;
+    }
 }
 
 void CommandSocket::beginGCode()
 {
-#ifdef ARCUS
-    FffProcessor::getInstance()->setTargetStream(&private_data->gcode_output_stream);
-#endif
+    FffProcessor::getInstance()->setTargetStream(&d->gcode_output_stream);
 }
 
-void CommandSocket::flushGcode()
+void CommandSocket::sendGCodeLayer()
 {
-#ifdef ARCUS
     auto message = std::make_shared<cura::proto::GCodeLayer>();
-    message->set_data(private_data->gcode_output_stream.str());
-    private_data->socket->sendMessage(message);
+    message->set_id(d->object_ids[0]);
+    message->set_data(d->gcode_output_stream.str());
+    d->socket->sendMessage(message);
     
-    private_data->gcode_output_stream.str("");
-#endif
+    d->gcode_output_stream.str("");
 }
 
 void CommandSocket::sendGCodePrefix(std::string prefix)
 {
-#ifdef ARCUS
     auto message = std::make_shared<cura::proto::GCodePrefix>();
     message->set_data(prefix);
-    private_data->socket->sendMessage(message);
-#endif
+    d->socket->sendMessage(message);
 }
 
-#ifdef ARCUS
-std::shared_ptr<cura::proto::Layer> CommandSocket::Private::getLayerById(int id)
+cura::proto::Layer* CommandSocket::Private::getLayerById(int id)
 {
-    id += current_layer_offset;
+    auto itr = std::find_if(current_sliced_object->mutable_layers()->begin(), current_sliced_object->mutable_layers()->end(), [id](cura::proto::Layer& l) { return l.id() == id; });
 
-    auto itr = sliced_layers.find(id);
-
-    std::shared_ptr<cura::proto::Layer> layer;
-    if (itr != sliced_layers.end())
+    cura::proto::Layer* layer = nullptr;
+    if(itr != current_sliced_object->mutable_layers()->end())
     {
-        layer = itr->second;
+        layer = &(*itr);
     }
     else
     {
-        layer = std::make_shared<cura::proto::Layer>();
+        layer = current_sliced_object->add_layers();
         layer->set_id(id);
-        current_layer_count++;
-        sliced_layers[id] = layer;
     }
 
     return layer;
 }
-#endif
 
 }//namespace cura

src/commandSocket.h

@@ -3,33 +3,20 @@
 
 #include "utils/socket.h"
 #include "utils/polygon.h"
-#include "settings/settings.h"
-#include "progress/Progress.h"
-#include "PrintFeature.h"
+#include "settings.h"
+#include "Progress.h"
 
 #include <memory>
 
-#ifdef ARCUS
 #include "Cura.pb.h"
-#endif
 
-namespace cura
-{
+namespace cura {
+
 
 class CommandSocket
 {
-private:
-    static CommandSocket* instance; //!< May be a nullptr in case it hasn't been instantiated.
-
-    CommandSocket(); //!< The single constructor is known only privately, since this class is similar to a singleton class (except the single object doesn't need to be instantiated)
-
 public:
-    static CommandSocket* getInstance(); //!< Get the CommandSocket instance, or nullptr if it hasn't been instantiated.
-
-    static void instantiate(); //!< Instantiate the CommandSocket.
-
-    static bool isInstantiated(); //!< Check whether the singleton is instantiated
-
+    CommandSocket();
     /*!
      * Connect with the GUI
      * This creates and initialises the arcus socket and then continues listening for messages. 
@@ -37,8 +24,7 @@ public:
      * \param port int of the port to connect with.
      */
     void connect(const std::string& ip, int port);
-
-#ifdef ARCUS
+    
     /*! 
      * Handler for ObjectList message. 
      * Loads all objects from the message and starts the slicing process
@@ -50,23 +36,17 @@ public:
      * This simply sets all the settings by using key value pair
      */
     void handleSettingList(cura::proto::SettingList* list);
-#endif
     
     /*!
-     * Send info on a layer to be displayed by the forntend: set the z and the thickness of the layer.
+     * Does nothing at the moment 
      */
     void sendLayerInfo(int layer_nr, int32_t z, int32_t height);
     
     /*! 
      * Send a polygon to the engine. This is used for the layerview in the GUI
      */
-    void sendPolygons(cura::PrintFeatureType type, int layer_nr, cura::Polygons& polygons, int line_width);
-
-    /*! 
-     * Send a polygon to the engine if the command socket is instantiated. This is used for the layerview in the GUI
-     */
-    static void sendPolygonsToCommandSocket(cura::PrintFeatureType type, int layer_nr, cura::Polygons& polygons, int line_width);
-
+    void sendPolygons(cura::PolygonType type, int layer_nr, cura::Polygons& polygons, int line_width);
+    
     /*! 
      * Send progress to GUI
      */
@@ -86,36 +66,17 @@ public:
      * Does nothing at the moment
      */
     void sendPrintMaterialForObject(int index, int extruder_nr, float material_amount);
-    
-    /*!
-     * Send the sliced layer data to the GUI.
-     *
-     * The GUI may use this to visualise the g-code, so that the user can
-     * inspect the result of slicing.
-     */
-    void sendLayerData();
 
-    /*!
-     * \brief Sends a message to indicate that all the slicing is done.
-     *
-     * This should indicate that no more data (g-code, prefix/postfix, metadata
-     * or otherwise) should be sent any more regarding the latest slice job.
-     */
-    void sendFinishedSlicing();
+    void beginSendSlicedObject();
+    void endSendSlicedObject();
 
     void beginGCode();
-    
-    /*!
-     * Flush the gcode in gcode_output_stream into a message queued in the socket.
-     */
-    void flushGcode();
+    void sendGCodeLayer();
     void sendGCodePrefix(std::string prefix);
 
-#ifdef ARCUS
 private:
     class Private;
-    const std::unique_ptr<Private> private_data;
-#endif
+    const std::unique_ptr<Private> d;
 };
 
 }//namespace cura

src/gcodeExport.cpp

@@ -1,179 +1,39 @@
 /** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
 #include <stdarg.h>
 #include <iomanip>
-#include <cmath>
 
 #include "gcodeExport.h"
 #include "utils/logoutput.h"
-#include "PrintFeature.h"
-#include "utils/Date.h"
 
 namespace cura {
 
 GCodeExport::GCodeExport()
-: output_stream(&std::cout)
-, currentPosition(0,0,MM2INT(20))
-, layer_nr(0)
+: output_stream(&std::cout), currentPosition(0,0,0), startPosition(INT32_MIN,INT32_MIN,0)
 {
-    current_e_value = 0;
+    extrusion_amount = 0;
     current_extruder = 0;
     currentFanSpeed = -1;
-
+    
     totalPrintTime = 0.0;
-
+    
     currentSpeed = 1;
-    isZHopped = 0;
+    retractionPrimeSpeed = 1;
+    isRetracted = false;
+    isZHopped = false;
+    last_coasted_amount_mm3 = 0;
     setFlavor(EGCodeFlavor::REPRAP);
-    initial_bed_temp = 0;
-
-    extruder_count = 0;
 }
 
 GCodeExport::~GCodeExport()
 {
 }
 
-void GCodeExport::preSetup(MeshGroup* settings)
-{
-    setFlavor(settings->getSettingAsGCodeFlavor("machine_gcode_flavor"));
-    use_extruder_offset_to_offset_coords = settings->getSettingBoolean("machine_use_extruder_offset_to_offset_coords");
-
-    extruder_count = settings->getSettingAsCount("machine_extruder_count");
-
-    for (unsigned int n = 0; n < extruder_count; n++)
-    {
-        ExtruderTrain* train = settings->getExtruderTrain(n);
-        setFilamentDiameter(n, train->getSettingInMicrons("material_diameter")); 
-
-        extruder_attr[n].nozzle_size = train->getSettingInMicrons("machine_nozzle_size");
-        extruder_attr[n].nozzle_offset = Point(train->getSettingInMicrons("machine_nozzle_offset_x"), train->getSettingInMicrons("machine_nozzle_offset_y"));
-
-        extruder_attr[n].start_code = train->getSettingString("machine_extruder_start_code");
-        extruder_attr[n].end_code = train->getSettingString("machine_extruder_end_code");
-
-        extruder_attr[n].extruder_switch_retraction_config.distance = train->getSettingInMillimeters("switch_extruder_retraction_amount"); 
-        extruder_attr[n].extruder_switch_retraction_config.prime_volume = 0.0;
-        extruder_attr[n].extruder_switch_retraction_config.speed = train->getSettingInMillimetersPerSecond("switch_extruder_retraction_speed");
-        extruder_attr[n].extruder_switch_retraction_config.primeSpeed = train->getSettingInMillimetersPerSecond("switch_extruder_prime_speed");
-        extruder_attr[n].extruder_switch_retraction_config.zHop = train->getSettingInMicrons("switch_extruder_retraction_hop");
-        extruder_attr[n].extruder_switch_retraction_config.retraction_count_max = 9999999; // extruder switch retraction is never limited
-        extruder_attr[n].extruder_switch_retraction_config.retraction_extrusion_window = 99999.9; // so that extruder switch retractions won't affect the retraction buffer (extruded_volume_at_previous_n_retractions)
-        extruder_attr[n].extruder_switch_retraction_config.retraction_min_travel_distance = 0; // no limitation on travel distance for an extruder switch retract
-
-        extruder_attr[n].last_retraction_prime_speed = train->getSettingInMillimetersPerSecond("retraction_prime_speed"); // the alternative would be switch_extruder_prime_speed, but dual extrusion might not even be configured...
-    }
-    machine_dimensions.x = settings->getSettingInMicrons("machine_width");
-    machine_dimensions.y = settings->getSettingInMicrons("machine_depth");
-    machine_dimensions.z = settings->getSettingInMicrons("machine_height");
-
-    machine_name = settings->getSettingString("machine_name");
-
-    if (flavor == EGCodeFlavor::BFB)
-    {
-        new_line = "\r\n";
-    }
-    else 
-    {
-        new_line = "\n";
-    }
-}
-
-void GCodeExport::setInitialTemps(const MeshGroup& settings)
-{
-    for (unsigned int extr_nr = 0; extr_nr < extruder_count; extr_nr++)
-    {
-        const ExtruderTrain* extr_train = settings.getExtruderTrain(extr_nr);
-        assert(extr_train);
-        double temp = extr_train->getSettingInDegreeCelsius((extr_nr == 0)? "material_print_temperature" : "material_standby_temperature");
-        setInitialTemp(extr_nr, temp);
-    }
-
-    initial_bed_temp = settings.getSettingInDegreeCelsius("material_bed_temperature");
-}
-
-void GCodeExport::setInitialTemp(int extruder_nr, double temp)
-{
-    extruder_attr[extruder_nr].initial_temp = temp;
-    if (flavor == EGCodeFlavor::GRIFFIN || flavor == EGCodeFlavor::ULTIGCODE)
-    {
-        extruder_attr[extruder_nr].currentTemperature = temp;
-    }
-}
-
-
-std::string GCodeExport::getFileHeader(const double* print_time, const std::vector<double>& filament_used, const std::vector<int16_t>& mat_ids)
-{
-    std::ostringstream prefix;
-    switch (flavor)
-    {
-    case EGCodeFlavor::GRIFFIN:
-        prefix << ";START_OF_HEADER" << new_line;
-        prefix << ";HEADER_VERSION:0.1" << new_line;
-        prefix << ";FLAVOR:" << toString(flavor) << new_line;
-        prefix << ";GENERATOR.NAME:Cura_SteamEngine" << new_line;
-        prefix << ";GENERATOR.VERSION:" << VERSION << new_line;
-        prefix << ";GENERATOR.BUILD_DATE:" << Date::getDate().toStringDashed() << new_line;
-        prefix << ";TARGET_MACHINE.NAME:" << machine_name << new_line;
-
-        for (unsigned int extr_nr = 0; extr_nr < extruder_count; extr_nr++)
-        {
-            prefix << ";EXTRUDER_TRAIN." << extr_nr << ".INITIAL_TEMPERATURE:" << extruder_attr[extr_nr].initial_temp << new_line;
-            if (filament_used.size() == extruder_count)
-            {
-                prefix << ";EXTRUDER_TRAIN." << extr_nr << ".MATERIAL.VOLUME_USED:" << static_cast<int>(filament_used[extr_nr]) << new_line;
-            }
-            if (mat_ids.size() == extruder_count)
-            {
-                prefix << ";EXTRUDER_TRAIN." << extr_nr << ".MATERIAL.GUID:" << mat_ids[extr_nr] << new_line; // TODO: convert to hexadecimal format
-            }
-            prefix << ";EXTRUDER_TRAIN." << extr_nr << ".NOZZLE.DIAMETER:" << float(INT2MM(getNozzleSize(extr_nr))) << new_line;
-        }
-        prefix << ";BUILD_PLATE.INITIAL_TEMPERATURE:" << initial_bed_temp << new_line;
-
-        if (print_time)
-        {
-            prefix << ";PRINT.TIME:" << static_cast<int>(*print_time) << new_line;
-        }
-
-        prefix << ";PRINT.SIZE.MIN.X:0" << new_line;
-        prefix << ";PRINT.SIZE.MIN.Y:0" << new_line;
-        prefix << ";PRINT.SIZE.MIN.Z:0" << new_line;
-        prefix << ";PRINT.SIZE.MAX.X:" << INT2MM(machine_dimensions.x) << new_line;
-        prefix << ";PRINT.SIZE.MAX.Y:" << INT2MM(machine_dimensions.y) << new_line;
-        prefix << ";PRINT.SIZE.MAX.Z:" << INT2MM(machine_dimensions.z) << new_line;
-        prefix << ";END_OF_HEADER" << new_line;
-        return prefix.str();
-    default:
-        prefix << ";FLAVOR:" << toString(flavor) << new_line;
-        prefix << ";TIME:" << ((print_time)? static_cast<int>(*print_time) : 6666) << new_line;
-        if (flavor == EGCodeFlavor::ULTIGCODE)
-        {
-            prefix << ";MATERIAL:" << ((filament_used.size() >= 1)? static_cast<int>(filament_used[0]) : 6666) << new_line;
-            prefix << ";MATERIAL2:" << ((filament_used.size() >= 2)? static_cast<int>(filament_used[1]) : 0) << new_line;
-
-            prefix << ";NOZZLE_DIAMETER:" << float(INT2MM(getNozzleSize(0))) << new_line;
-            // TODO: the second nozzle size isn't always initiated! ";NOZZLE_DIAMETER2:"
-        }
-        return prefix.str();
-    }
-}
-
-
-void GCodeExport::setLayerNr(unsigned int layer_nr_) {
-    layer_nr = layer_nr_;
-}
-
 void GCodeExport::setOutputStream(std::ostream* stream)
 {
     output_stream = stream;
     *output_stream << std::fixed;
 }
 
-int GCodeExport::getNozzleSize(int extruder_idx)
-{
-    return extruder_attr[extruder_idx].nozzle_size;
-}
-
 Point GCodeExport::getExtruderOffset(int id)
 {
     return extruder_attr[id].nozzle_offset;
@@ -203,15 +63,6 @@ void GCodeExport::setFlavor(EGCodeFlavor flavor)
     {
         is_volumatric = false;
     }
-
-    if (flavor == EGCodeFlavor::BFB || flavor == EGCodeFlavor::REPRAP_VOLUMATRIC || flavor == EGCodeFlavor::ULTIGCODE)
-    {
-        firmware_retract = true;
-    }
-    else 
-    {
-        firmware_retract = false;
-    }
 }
 
 EGCodeFlavor GCodeExport::getFlavor()
@@ -238,6 +89,17 @@ int GCodeExport::getPositionZ()
     return currentPosition.z;
 }
 
+void GCodeExport::resetStartPosition()
+{
+    startPosition.x = INT32_MIN;
+    startPosition.y = INT32_MIN;
+}
+
+Point GCodeExport::getStartPositionXY()
+{
+    return Point(startPosition.x, startPosition.y);
+}
+
 int GCodeExport::getExtruderNr()
 {
     return current_extruder;
@@ -250,68 +112,35 @@ void GCodeExport::setFilamentDiameter(unsigned int extruder, int diameter)
     extruder_attr[extruder].filament_area = area;
 }
 
-double GCodeExport::getCurrentExtrudedVolume()
+double GCodeExport::getFilamentArea(unsigned int extruder)
+{
+    return extruder_attr[extruder].filament_area;
+}
+
+double GCodeExport::getExtrusionAmountMM3(unsigned int extruder)
 {
-    double extrusion_amount = current_e_value;
-    if (!firmware_retract)
-    { // no E values are changed to perform a retraction
-        extrusion_amount -= extruder_attr[current_extruder].retraction_e_amount_at_e_start; // subtract the increment in E which was used for the first unretraction instead of extrusion
-        extrusion_amount += extruder_attr[current_extruder].retraction_e_amount_current; // add the decrement in E which the filament is behind on extrusion due to the last retraction
-    }
     if (is_volumatric)
     {
         return extrusion_amount;
     }
     else
     {
-        return extrusion_amount * extruder_attr[current_extruder].filament_area;
+        return extrusion_amount * getFilamentArea(extruder);
     }
 }
 
-double GCodeExport::eToMm(double e)
+
+double GCodeExport::getTotalFilamentUsed(int e)
 {
-    if (is_volumatric)
-    {
-        return e / extruder_attr[current_extruder].filament_area;
-    }
-    else
-    {
-        return e;
-    }
+    if (e == current_extruder)
+        return extruder_attr[e].totalFilament + getExtrusionAmountMM3(e);
+    return extruder_attr[e].totalFilament;
 }
 
-double GCodeExport::mm3ToE(double mm3)
+double GCodeExport::getTotalPrintTime(EPrintFeature print_feature)
 {
-    if (is_volumatric)
-    {
-        return mm3;
-    }
-    else
-    {
-        return mm3 / extruder_attr[current_extruder].filament_area;
-    }
+    return total_print_time_per_feature[(unsigned int)print_feature];
 }
-
-double GCodeExport::mmToE(double mm)
-{
-    if (is_volumatric)
-    {
-        return mm * extruder_attr[current_extruder].filament_area;
-    }
-    else
-    {
-        return mm;
-    }
-}
-
-
-double GCodeExport::getTotalFilamentUsed(int extruder_nr)
-{
-    if (extruder_nr == current_extruder)
-        return extruder_attr[extruder_nr].totalFilament + getCurrentExtrudedVolume();
-    return extruder_attr[extruder_nr].totalFilament;
-}
-
 double GCodeExport::getTotalPrintTime()
 {
     return totalPrintTime;
@@ -320,110 +149,62 @@ double GCodeExport::getTotalPrintTime()
 void GCodeExport::resetTotalPrintTimeAndFilament()
 {
     totalPrintTime = 0;
+    for (unsigned int feat_idx = 0; feat_idx < (unsigned int)EPrintFeature::ENUM_COUNT; feat_idx++)
+    {
+        total_print_time_per_feature[feat_idx] = 0.0;
+    }
     for(unsigned int e=0; e<MAX_EXTRUDERS; e++)
     {
         extruder_attr[e].totalFilament = 0.0;
         extruder_attr[e].currentTemperature = 0;
     }
-    current_e_value = 0.0;
+    extrusion_amount = 0.0;
     estimateCalculator.reset();
 }
 
-void GCodeExport::updateTotalPrintTime()
+void GCodeExport::updateTotalPrintTime(EPrintFeature print_feature)
 {
-    totalPrintTime += estimateCalculator.calculate();
+    double time = estimateCalculator.calculate();
+    totalPrintTime += time;
+    total_print_time_per_feature[(unsigned int)print_feature] += time;
     estimateCalculator.reset();
 }
 
 void GCodeExport::writeComment(std::string comment)
 {
-    *output_stream << ";";
-    for (unsigned int i = 0; i < comment.length(); i++)
-    {
-        if (comment[i] == '\n')
-        {
-            *output_stream << "\\n";
-        }else{
-            *output_stream << comment[i];
-        }
-    }
-    *output_stream << new_line;
+    *output_stream << ";" << comment << "\n";
 }
 
 void GCodeExport::writeTypeComment(const char* type)
 {
-    *output_stream << ";TYPE:" << type << new_line;
+    *output_stream << ";TYPE:" << type << "\n";
 }
-
-void GCodeExport::writeTypeComment(PrintFeatureType type)
-{
-    switch (type)
-    {
-        case PrintFeatureType::OuterWall:
-            *output_stream << ";TYPE:WALL-OUTER" << new_line;
-            break;
-        case PrintFeatureType::InnerWall:
-            *output_stream << ";TYPE:WALL-INNER" << new_line;
-            break;
-        case PrintFeatureType::Skin:
-            *output_stream << ";TYPE:SKIN" << new_line;
-            break;
-        case PrintFeatureType::Support:
-            *output_stream << ";TYPE:SUPPORT" << new_line;
-            break;
-        case PrintFeatureType::Skirt:
-            *output_stream << ";TYPE:SKIRT" << new_line;
-            break;
-        case PrintFeatureType::Infill:
-            *output_stream << ";TYPE:FILL" << new_line;
-            break;
-        case PrintFeatureType::SupportInfill:
-            *output_stream << ";TYPE:SUPPORT" << new_line;
-            break;
-        case PrintFeatureType::MoveCombing:
-        case PrintFeatureType::MoveRetraction:
-        default:
-            // do nothing
-            break;
-    }
-}
-
-
 void GCodeExport::writeLayerComment(int layer_nr)
 {
-    *output_stream << ";LAYER:" << layer_nr << new_line;
-}
-
-void GCodeExport::writeLayerCountComment(int layer_count)
-{
-    *output_stream << ";LAYER_COUNT:" << layer_count << new_line;
+    *output_stream << ";LAYER:" << layer_nr << "\n";
 }
 
 void GCodeExport::writeLine(const char* line)
 {
-    *output_stream << line << new_line;
+    *output_stream << line << "\n";
 }
 
 void GCodeExport::resetExtrusionValue()
 {
-    if (flavor != EGCodeFlavor::MAKERBOT && flavor != EGCodeFlavor::BFB)
+    if (extrusion_amount != 0.0 && flavor != EGCodeFlavor::MAKERBOT && flavor != EGCodeFlavor::BFB)
     {
-        *output_stream << "G92 " << extruder_attr[current_extruder].extruderCharacter << "0" << new_line;
-        double current_extruded_volume = getCurrentExtrudedVolume();
-        extruder_attr[current_extruder].totalFilament += current_extruded_volume;
-        for (double& extruded_volume_at_retraction : extruder_attr[current_extruder].extruded_volume_at_previous_n_retractions)
-        { // update the extruded_volume_at_previous_n_retractions only of the current extruder, since other extruders don't extrude the current volume
-            extruded_volume_at_retraction -= current_extruded_volume;
-        }
-        current_e_value = 0.0;
-        extruder_attr[current_extruder].retraction_e_amount_at_e_start = extruder_attr[current_extruder].retraction_e_amount_current;
+        *output_stream << "G92 " << extruder_attr[current_extruder].extruderCharacter << "0\n";
+        extruder_attr[current_extruder].totalFilament += getExtrusionAmountMM3(current_extruder);
+        for (unsigned int i = 0; i < extrusion_amount_at_previous_n_retractions.size(); i++)
+            extrusion_amount_at_previous_n_retractions[i] -= extrusion_amount;
+        extrusion_amount = 0.0;
     }
 }
 
 void GCodeExport::writeDelay(double timeAmount)
 {
-    *output_stream << "G4 P" << int(timeAmount * 1000) << new_line;
-    estimateCalculator.addTime(timeAmount);
+    *output_stream << "G4 P" << int(timeAmount * 1000) << "\n";
+    totalPrintTime += timeAmount;
 }
 
 void GCodeExport::writeMove(Point p, double speed, double extrusion_mm3_per_mm)
@@ -436,297 +217,238 @@ void GCodeExport::writeMove(Point3 p, double speed, double extrusion_mm3_per_mm)
     writeMove(p.x, p.y, p.z, speed, extrusion_mm3_per_mm);
 }
 
-void GCodeExport::writeMoveBFB(int x, int y, int z, double speed, double extrusion_mm3_per_mm)
-{
-    double extrusion_per_mm = mm3ToE(extrusion_mm3_per_mm);
-    
-    Point gcode_pos = getGcodePos(x,y, current_extruder);
-    
-    //For Bits From Bytes machines, we need to handle this completely differently. As they do not use E values but RPM values.
-    float fspeed = speed * 60;
-    float rpm = extrusion_per_mm * speed * 60;
-    const float mm_per_rpm = 4.0; //All BFB machines have 4mm per RPM extrusion.
-    rpm /= mm_per_rpm;
-    if (rpm > 0)
-    {
-        if (extruder_attr[current_extruder].retraction_e_amount_current)
-        {
-            if (currentSpeed != double(rpm))
-            {
-                //fprintf(f, "; %f e-per-mm %d mm-width %d mm/s\n", extrusion_per_mm, lineWidth, speed);
-                //fprintf(f, "M108 S%0.1f\r\n", rpm);
-                *output_stream << "M108 S" << std::setprecision(1) << rpm << new_line;
-                currentSpeed = double(rpm);
-            }
-            //Add M101 or M201 to enable the proper extruder.
-            *output_stream << "M" << int((current_extruder + 1) * 100 + 1) << new_line;
-            extruder_attr[current_extruder].retraction_e_amount_current = 0.0;
-        }
-        //Fix the speed by the actual RPM we are asking, because of rounding errors we cannot get all RPM values, but we have a lot more resolution in the feedrate value.
-        // (Trick copied from KISSlicer, thanks Jonathan)
-        fspeed *= (rpm / (roundf(rpm * 100) / 100));
-
-        //Increase the extrusion amount to calculate the amount of filament used.
-        Point3 diff = Point3(x,y,z) - getPosition();
-        
-        current_e_value += extrusion_per_mm * diff.vSizeMM();
-    }
-    else
-    {
-        //If we are not extruding, check if we still need to disable the extruder. This causes a retraction due to auto-retraction.
-        if (!extruder_attr[current_extruder].retraction_e_amount_current)
-        {
-            *output_stream << "M103" << new_line;
-            extruder_attr[current_extruder].retraction_e_amount_current = 1.0; // 1.0 used as stub; BFB doesn't use the actual retraction amount; it performs retraction on the firmware automatically
-        }
-    }
-    *output_stream << std::setprecision(3) << 
-        "G1 X" << INT2MM(gcode_pos.X) << 
-        " Y" << INT2MM(gcode_pos.Y) << 
-        " Z" << INT2MM(z) << std::setprecision(1) << " F" << fspeed << new_line;
-    
-    currentPosition = Point3(x, y, z);
-    estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value)), speed);
-}
-
 void GCodeExport::writeMove(int x, int y, int z, double speed, double extrusion_mm3_per_mm)
 {
     if (currentPosition.x == x && currentPosition.y == y && currentPosition.z == z)
         return;
-
-#ifdef ASSERT_INSANE_OUTPUT
-    assert(speed < 200 && speed > 1); // normal F values occurring in UM2 gcode (this code should not be compiled for release)
-    assert(currentPosition != no_point3);
+    
+    assert(speed*60 < 10000 && speed*60 > 100); // normal F values occurring in UM2 gcode (this code should not be compiled for release)
     assert((Point3(x,y,z) - currentPosition).vSize() < MM2INT(300)); // no crazy positions (this code should not be compiled for release)
-#endif //ASSERT_INSANE_OUTPUT
-
+    
     if (extrusion_mm3_per_mm < 0)
         logWarning("Warning! Negative extrusion move!");
+    
+    double extrusion_per_mm = extrusion_mm3_per_mm;
+    if (!is_volumatric)
+    {
+        extrusion_per_mm = extrusion_mm3_per_mm / getFilamentArea(current_extruder);
+    }
+    
+    Point gcode_pos = getGcodePos(x,y, current_extruder);
 
     if (flavor == EGCodeFlavor::BFB)
     {
-        writeMoveBFB(x, y, z, speed, extrusion_mm3_per_mm);
-        return;
-    }
-
-    double extrusion_per_mm = mm3ToE(extrusion_mm3_per_mm);
-
-    Point gcode_pos = getGcodePos(x,y, current_extruder);
-
-    if (extrusion_mm3_per_mm > 0.000001)
-    {
-        Point3 diff = Point3(x,y,z) - getPosition();
-        if (isZHopped > 0)
+        //For Bits From Bytes machines, we need to handle this completely differently. As they do not use E values but RPM values.
+        float fspeed = speed * 60;
+        float rpm = extrusion_per_mm * speed * 60;
+        const float mm_per_rpm = 4.0; //All BFB machines have 4mm per RPM extrusion.
+        rpm /= mm_per_rpm;
+        if (rpm > 0)
         {
-            *output_stream << std::setprecision(3) << "G1 Z" << INT2MM(currentPosition.z) << new_line;
-            isZHopped = 0;
-        }
-        double prime_volume = extruder_attr[current_extruder].prime_volume;
-        current_e_value += mm3ToE(prime_volume);
-        if (extruder_attr[current_extruder].retraction_e_amount_current)
-        {
-            if (firmware_retract)
-            { // note that BFB is handled differently
-                *output_stream << "G11" << new_line;
-                //Assume default UM2 retraction settings.
-                if (prime_volume > 0)
+            if (isRetracted)
+            {
+                if (currentSpeed != double(rpm))
                 {
-                    *output_stream << "G1 F" << (extruder_attr[current_extruder].last_retraction_prime_speed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << current_e_value << new_line;
-                    currentSpeed = extruder_attr[current_extruder].last_retraction_prime_speed;
+                    //fprintf(f, "; %f e-per-mm %d mm-width %d mm/s\n", extrusion_per_mm, lineWidth, speed);
+                    //fprintf(f, "M108 S%0.1f\r\n", rpm);
+                    *output_stream << "M108 S" << std::setprecision(1) << rpm << "\r\n";
+                    currentSpeed = double(rpm);
                 }
-                estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value)), 25.0);
+                //Add M101 or M201 to enable the proper extruder.
+                *output_stream << "M" << int((current_extruder + 1) * 100 + 1) << "\r\n";
+                isRetracted = false;
             }
-            else
+            //Fix the speed by the actual RPM we are asking, because of rounding errors we cannot get all RPM values, but we have a lot more resolution in the feedrate value.
+            // (Trick copied from KISSlicer, thanks Jonathan)
+            fspeed *= (rpm / (roundf(rpm * 100) / 100));
+
+            //Increase the extrusion amount to calculate the amount of filament used.
+            Point3 diff = Point3(x,y,z) - getPosition();
+            
+            extrusion_amount += extrusion_per_mm * diff.vSizeMM();
+        }else{
+            //If we are not extruding, check if we still need to disable the extruder. This causes a retraction due to auto-retraction.
+            if (!isRetracted)
             {
-                current_e_value += extruder_attr[current_extruder].retraction_e_amount_current;
-                *output_stream << "G1 F" << (extruder_attr[current_extruder].last_retraction_prime_speed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << current_e_value << new_line;
-                currentSpeed = extruder_attr[current_extruder].last_retraction_prime_speed;
-                estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value)), currentSpeed);
+                *output_stream << "M103\r\n";
+                isRetracted = true;
             }
-            if (getCurrentExtrudedVolume() > 10000.0) //According to https://github.com/Ultimaker/CuraEngine/issues/14 having more then 21m of extrusion causes inaccuracies. So reset it every 10m, just to be sure.
-            {
-                resetExtrusionValue();
-            }
-            extruder_attr[current_extruder].retraction_e_amount_current = 0.0;
         }
-        else if (prime_volume > 0.0)
-        {
-            *output_stream << "G1 F" << (extruder_attr[current_extruder].last_retraction_prime_speed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << current_e_value << new_line;
-            currentSpeed = extruder_attr[current_extruder].last_retraction_prime_speed;
-            estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value)), currentSpeed);
-        }
-        extruder_attr[current_extruder].prime_volume = 0.0;
-        current_e_value += extrusion_per_mm * diff.vSizeMM();
-        *output_stream << "G1";
+        *output_stream << std::setprecision(3) << 
+            "G1 X" << INT2MM(gcode_pos.X) << 
+            " Y" << INT2MM(gcode_pos.Y) << 
+            " Z" << INT2MM(z) << std::setprecision(1) << " F" << fspeed << "\r\n";
     }
     else
     {
-        *output_stream << "G0";
-
-        if (CommandSocket::isInstantiated()) 
+        //Normal E handling.
+        
+        if (extrusion_mm3_per_mm > 0.000001)
         {
-            // we should send this travel as a non-retraction move
-            cura::Polygons travelPoly;
-            PolygonRef travel = travelPoly.newPoly();
-            travel.add(Point(currentPosition.x, currentPosition.y));
-            travel.add(Point(x, y));
-            CommandSocket::getInstance()->sendPolygons(extruder_attr[current_extruder].retraction_e_amount_current ? PrintFeatureType::MoveRetraction : PrintFeatureType::MoveCombing, layer_nr, travelPoly, extruder_attr[current_extruder].retraction_e_amount_current ? MM2INT(0.2) : MM2INT(0.1));
+            Point3 diff = Point3(x,y,z) - getPosition();
+            if (isZHopped > 0)
+            {
+                *output_stream << std::setprecision(3) << "G1 Z" << INT2MM(currentPosition.z) << "\n";
+                isZHopped = false;
+            }
+            extrusion_amount += (is_volumatric) ? last_coasted_amount_mm3 : last_coasted_amount_mm3 / getFilamentArea(current_extruder);   
+            if (isRetracted)
+            {
+                if (flavor == EGCodeFlavor::ULTIGCODE || flavor == EGCodeFlavor::REPRAP_VOLUMATRIC)
+                {
+                    *output_stream << "G11\n";
+                    //Assume default UM2 retraction settings.
+                    if (last_coasted_amount_mm3 > 0)
+                    {
+                        *output_stream << "G1 F" << (retractionPrimeSpeed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << extrusion_amount << "\n";
+                    }
+                    estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), extrusion_amount), 25.0);
+                }else{
+                    *output_stream << "G1 F" << (retractionPrimeSpeed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << extrusion_amount << "\n";
+                    currentSpeed = retractionPrimeSpeed;
+                    estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), extrusion_amount), currentSpeed);
+                }
+                if (getExtrusionAmountMM3(current_extruder) > 10000.0) //According to https://github.com/Ultimaker/CuraEngine/issues/14 having more then 21m of extrusion causes inaccuracies. So reset it every 10m, just to be sure.
+                    resetExtrusionValue();
+                isRetracted = false;
+            }
+            else 
+            {
+                if (last_coasted_amount_mm3 > 0)
+                {
+                    *output_stream << "G1 F" << (retractionPrimeSpeed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << extrusion_amount << "\n";
+                    estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), extrusion_amount), currentSpeed);
+                }
+            }
+            last_coasted_amount_mm3 = 0;
+            extrusion_amount += extrusion_per_mm * diff.vSizeMM();
+            *output_stream << "G1";
+        }else{
+            *output_stream << "G0";
         }
-    }
 
-    if (currentSpeed != speed)
-    {
-        *output_stream << " F" << (speed * 60);
-        currentSpeed = speed;
-    }
+        if (currentSpeed != speed)
+        {
+            *output_stream << " F" << (speed * 60);
+            currentSpeed = speed;
+        }
 
-    *output_stream << std::setprecision(3) << 
-        " X" << INT2MM(gcode_pos.X) << 
-        " Y" << INT2MM(gcode_pos.Y);
-    if (z != currentPosition.z + isZHopped)
-        *output_stream << " Z" << INT2MM(z + isZHopped);
-    if (extrusion_mm3_per_mm > 0.000001)
-        *output_stream << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << current_e_value;
-    *output_stream << new_line;
+        *output_stream << std::setprecision(3) << 
+            " X" << INT2MM(gcode_pos.X) << 
+            " Y" << INT2MM(gcode_pos.Y);
+        if (z != currentPosition.z)
+            *output_stream << " Z" << INT2MM(z);
+        if (extrusion_mm3_per_mm > 0.000001)
+            *output_stream << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << extrusion_amount;
+        *output_stream << "\n";
+    }
     
     currentPosition = Point3(x, y, z);
-    estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value)), speed);
+    startPosition = currentPosition;
+    estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), extrusion_amount), speed);
 }
 
-void GCodeExport::writeRetraction(RetractionConfig* config, bool force, bool extruder_switch)
+void GCodeExport::writeRetraction(RetractionConfig* config, bool force)
 {
-    ExtruderTrainAttributes& extr_attr = extruder_attr[current_extruder];
-
     if (flavor == EGCodeFlavor::BFB)//BitsFromBytes does automatic retraction.
-    {
-        if (extruder_switch)
-        {
-            if (!extr_attr.retraction_e_amount_current)
-                *output_stream << "M103" << new_line;
-
-            extr_attr.retraction_e_amount_current = 1.0; // 1.0 is a stub; BFB doesn't use the actual retracted amount; retraction is performed by firmware
-        }
         return;
-    }
-
-    double old_retraction_e_amount = extr_attr.retraction_e_amount_current;
-    double new_retraction_e_amount = mmToE(config->distance);
-    double retraction_diff_e_amount = old_retraction_e_amount - new_retraction_e_amount;
-    if (std::abs(retraction_diff_e_amount) < 0.000001)
-    {
+    if (isRetracted)
+        return;
+    if (config->amount <= 0)
+        return;
+    
+    if (!force && config->retraction_count_max > 0 && int(extrusion_amount_at_previous_n_retractions.size()) == config->retraction_count_max - 1 
+        && extrusion_amount < extrusion_amount_at_previous_n_retractions.back() + config->retraction_extrusion_window) 
         return;
-    }
 
-    { // handle retraction limitation
-        double current_extruded_volume = getCurrentExtrudedVolume();
-        std::deque<double>& extruded_volume_at_previous_n_retractions = extr_attr.extruded_volume_at_previous_n_retractions;
-        while (int(extruded_volume_at_previous_n_retractions.size()) > config->retraction_count_max && !extruded_volume_at_previous_n_retractions.empty()) 
-        {
-            // extruder switch could have introduced data which falls outside the retraction window
-            // also the retraction_count_max could have changed between the last retraction and this
-            extruded_volume_at_previous_n_retractions.pop_back();
-        }
-        if (!force && config->retraction_count_max <= 0)
-        {
-            return;
-        }
-        if (!force && int(extruded_volume_at_previous_n_retractions.size()) == config->retraction_count_max
-            && current_extruded_volume < extruded_volume_at_previous_n_retractions.back() + config->retraction_extrusion_window * extr_attr.filament_area) 
-        {
-            return;
-        }
-        extruded_volume_at_previous_n_retractions.push_front(current_extruded_volume);
-        if (int(extruded_volume_at_previous_n_retractions.size()) == config->retraction_count_max + 1) 
-        {
-            extruded_volume_at_previous_n_retractions.pop_back();
-        }
-    }
-
-    if (firmware_retract)
+    if (config->primeAmount > 0)
     {
-        if (extruder_switch && extr_attr.retraction_e_amount_current) 
-        {
-            return; 
-        }
-        *output_stream << "G10";
-        if (extruder_switch)
-        {
-            *output_stream << " S1";
-        }
-        *output_stream << new_line;
+        extrusion_amount += config->primeAmount;
+    }
+    retractionPrimeSpeed = config->primeSpeed;
+    
+    if (flavor == EGCodeFlavor::ULTIGCODE || flavor == EGCodeFlavor::REPRAP_VOLUMATRIC)
+    {
+        *output_stream << "G10\n";
         //Assume default UM2 retraction settings.
-        estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value + retraction_diff_e_amount)), 25); // TODO: hardcoded values!
+        double retraction_distance = 4.5;
+        estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), extrusion_amount - retraction_distance), 25); // TODO: hardcoded values!
+    }else{
+        *output_stream << "G1 F" << (config->speed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << extrusion_amount - config->amount << "\n";
+        currentSpeed = config->speed;
+        estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), extrusion_amount - config->amount), currentSpeed);
     }
-    else
-    {
-        double speed = ((retraction_diff_e_amount < 0.0)? config->speed : extr_attr.last_retraction_prime_speed) * 60;
-        current_e_value += retraction_diff_e_amount;
-        *output_stream << "G1 F" << speed << " "
-            << extr_attr.extruderCharacter << std::setprecision(5) << current_e_value << new_line;
-        currentSpeed = speed;
-        estimateCalculator.plan(TimeEstimateCalculator::Position(INT2MM(currentPosition.x), INT2MM(currentPosition.y), INT2MM(currentPosition.z), eToMm(current_e_value)), currentSpeed);
-        extr_attr.last_retraction_prime_speed = config->primeSpeed;
-    }
-
-    extr_attr.retraction_e_amount_current = new_retraction_e_amount; // suppose that for UM2 the retraction amount in the firmware is equal to the provided amount
-    extr_attr.prime_volume += config->prime_volume;
-
     if (config->zHop > 0)
     {
-        isZHopped = config->zHop;
-        *output_stream << std::setprecision(3) << "G1 Z" << INT2MM(currentPosition.z + isZHopped) << new_line;
+        *output_stream << std::setprecision(3) << "G1 Z" << INT2MM(currentPosition.z + config->zHop) << "\n";
+        isZHopped = true;
     }
+    extrusion_amount_at_previous_n_retractions.push_front(extrusion_amount);
+    if (int(extrusion_amount_at_previous_n_retractions.size()) == config->retraction_count_max)
+    {
+        extrusion_amount_at_previous_n_retractions.pop_back();
+    }
+    isRetracted = true;
 }
 
 void GCodeExport::writeRetraction_extruderSwitch()
 {
-    ExtruderTrainAttributes& extr_attr = extruder_attr[current_extruder];
-    RetractionConfig* config = &extr_attr.extruder_switch_retraction_config;
+    if (isRetracted) { return; }
+        
+    if (flavor == EGCodeFlavor::BFB)
+    {
+        if (!isRetracted)
+            *output_stream << "M103\r\n";
 
-    writeRetraction(config, true, true);
+        isRetracted = true;
+        return;
+    }
+    resetExtrusionValue();
+    if (flavor == EGCodeFlavor::ULTIGCODE || flavor == EGCodeFlavor::REPRAP_VOLUMATRIC)
+    {
+        *output_stream << "G10 S1\n";
+    }else{
+        *output_stream << "G1 F" << (extruder_attr[current_extruder].extruderSwitchRetractionSpeed * 60) << " " << extruder_attr[current_extruder].extruderCharacter << std::setprecision(5) << (extrusion_amount - extruder_attr[current_extruder].extruderSwitchRetraction) << "\n";
+        currentSpeed = extruder_attr[current_extruder].extruderSwitchRetractionSpeed;
+    }
+    isRetracted = true;
 }
 
 void GCodeExport::switchExtruder(int new_extruder)
 {
     if (current_extruder == new_extruder)
         return;
-
-    writeRetraction_extruderSwitch();
-
-    resetExtrusionValue(); // zero the E value on the old extruder, so that the current_e_value is registered on the old extruder
-
+    
+    if (!isRetracted) // assumes the last retraction already was an extruder switch retraction
+    {
+        writeRetraction_extruderSwitch();
+    }
+    
     int old_extruder = current_extruder;
     current_extruder = new_extruder;
-
+    if (flavor == EGCodeFlavor::MACH3)
+        resetExtrusionValue();
+    isRetracted = true;
     writeCode(extruder_attr[old_extruder].end_code.c_str());
     if (flavor == EGCodeFlavor::MAKERBOT)
-    {
-        *output_stream << "M135 T" << current_extruder << new_line;
-    }
+        *output_stream << "M135 T" << current_extruder << "\n";
     else
-    {
-        *output_stream << "T" << current_extruder << new_line;
-    }
-
-    resetExtrusionValue(); // zero the E value on the new extruder, because a firmware bug in Griffin adjusted the E-value when performing a toolswitch (should be fixed as of 9 may 2016)
-
+        *output_stream << "T" << current_extruder << "\n";
     writeCode(extruder_attr[new_extruder].start_code.c_str());
-
+    
     //Change the Z position so it gets re-writting again. We do not know if the switch code modified the Z position.
     currentPosition.z += 1;
 }
 
 void GCodeExport::writeCode(const char* str)
 {
-    *output_stream << str << new_line;
+    *output_stream << str;
+    if (flavor == EGCodeFlavor::BFB)
+        *output_stream << "\r\n";
+    else
+        *output_stream << "\n";
 }
 
-void GCodeExport::writePrimeTrain()
-{
-    *output_stream << "G280" << new_line;
-}
-
-
 void GCodeExport::writeFanCommand(double speed)
 {
     if (currentFanSpeed == speed)
@@ -734,16 +456,16 @@ void GCodeExport::writeFanCommand(double speed)
     if (speed > 0)
     {
         if (flavor == EGCodeFlavor::MAKERBOT)
-            *output_stream << "M126 T0" << new_line; //value = speed * 255 / 100 // Makerbot cannot set fan speed...;
+            *output_stream << "M126 T0\n"; //value = speed * 255 / 100 // Makerbot cannot set fan speed...;
         else
-            *output_stream << "M106 S" << (speed * 255 / 100) << new_line;
+            *output_stream << "M106 S" << (speed * 255 / 100) << "\n";
     }
     else
     {
         if (flavor == EGCodeFlavor::MAKERBOT)
-            *output_stream << "M127 T0" << new_line;
+            *output_stream << "M127 T0\n";
         else
-            *output_stream << "M107" << new_line;
+            *output_stream << "M107\n";
     }
     currentFanSpeed = speed;
 }
@@ -759,7 +481,7 @@ void GCodeExport::writeTemperatureCommand(int extruder, double temperature, bool
         *output_stream << "M104";
     if (extruder != current_extruder)
         *output_stream << " T" << extruder;
-    *output_stream << " S" << temperature << new_line;
+    *output_stream << " S" << temperature << "\n";
     extruder_attr[extruder].currentTemperature = temperature;
 }
 
@@ -769,18 +491,17 @@ void GCodeExport::writeBedTemperatureCommand(double temperature, bool wait)
         *output_stream << "M190 S";
     else
         *output_stream << "M140 S";
-    *output_stream << temperature << new_line;
+    *output_stream << temperature << "\n";
 }
 
-void GCodeExport::finalize(const char* endCode)
+void GCodeExport::finalize(int maxObjectHeight, double moveSpeed, const char* endCode)
 {
     writeFanCommand(0);
+    setZ(maxObjectHeight + 5000);
+    writeMove(Point3(0,0,maxObjectHeight + 5000) + getPositionXY(), moveSpeed, 0);
     writeCode(endCode);
-    long print_time = getTotalPrintTime();
-    int mat_0 = getTotalFilamentUsed(0);
-    log("Print time: %d\n", print_time);
-    log("Print time (readable): %dh %dm %ds\n", print_time / 60 / 60, (print_time / 60) % 60, print_time % 60);
-    log("Filament: %d\n", mat_0);
+    log("Print time: %d\n", int(getTotalPrintTime()));
+    log("Filament: %d\n", int(getTotalFilamentUsed(0)));
     for(int n=1; n<MAX_EXTRUDERS; n++)
         if (getTotalFilamentUsed(n) > 0)
             log("Filament%d: %d\n", n + 1, int(getTotalFilamentUsed(n)));
@@ -788,4 +509,3 @@ void GCodeExport::finalize(const char* endCode)
 }
 
 }//namespace cura
-

src/gcodeExport.h

@@ -6,130 +6,89 @@
 #include <deque> // for extrusionAmountAtPreviousRetractions
 #include <sstream> // for stream.str()
 
-#include "settings/settings.h"
+#include "settings.h"
 #include "utils/intpoint.h"
-#include "utils/NoCopy.h"
 #include "timeEstimate.h"
 #include "MeshGroup.h"
-#include "commandSocket.h"
+#include "PrintFeature.h"
 
 namespace cura {
 
-/*!
- * Coasting configuration used during printing.
- * Can differ per extruder.
- * 
- * Might be used in the future to have different coasting per feature, e.g. outer wall only.
- */
 struct CoastingConfig
 {
-    bool coasting_enable; //!< Whether coasting is enabled on the extruder to which this config is attached 
-    double coasting_volume; //!< The volume leeked when printing without feeding
-    double coasting_speed; //!< A modifier (0-1) on the last used travel speed to move slower during coasting
-    double coasting_min_volume;  //!< The minimal volume printed to build up enough pressure to leek the coasting_volume
-};
+    bool coasting_enable; 
+    double coasting_volume_move; 
+    double coasting_speed_move; 
+    double coasting_min_volume_move; 
 
-/*!
- * The retraction configuration used in the GCodePathConfig of each feature (and the travel config)
- */
+    double coasting_volume_retract;
+    double coasting_speed_retract;
+    double coasting_min_volume_retract;
+};
+    
 class RetractionConfig
 {
 public:
-    double distance; //!< The distance retracted (in mm)
-    double speed; //!< The speed with which to retract (in mm/s)
-    double primeSpeed; //!< the speed with which to unretract (in mm/s)
-    double prime_volume; //!< the amount of material primed after unretracting (in mm^3)
+    double amount; //!< The amount retracted
+    double speed; //!< The speed with which to retract
+    double primeSpeed; //!< the speed with which to unretract
+    double primeAmount; //!< the amount of material primed after unretracting
     int zHop; //!< the amount with which to lift the head during a retraction-travel
-    int retraction_min_travel_distance; //!< Minimal distance traversed to even consider retracting (in micron)
-    double retraction_extrusion_window; //!< Window of mm extruded filament in which to limit the amount of retractions
-    int retraction_count_max; //!< The maximum amount of retractions allowed to occur in the RetractionConfig::retraction_extrusion_window
+    int retraction_min_travel_distance; //!< 
+    double retraction_extrusion_window;
+    int retraction_count_max;
 };
 
-/*!
- * The GCodePathConfig is the configuration for moves/extrusion actions. This defines at which width the line is printed and at which speed.
- */
+//The GCodePathConfig is the configuration for moves/extrusion actions. This defines at which width the line is printed and at which speed.
 class GCodePathConfig
 {
 private:
-    double speed_iconic; //!< movement speed (mm/s) specific to this print feature
-    double speed; //!< current movement speed (mm/s) (modified by layer_nr etc.)
+    double speed; //!< movement speed
     int line_width; //!< width of the line extruded
-    double flow; //!< extrusion flow modifier in %
-    int layer_thickness; //!< layer height in micron
-    double extrusion_mm3_per_mm;//!< mm^3 filament moved per mm line traversed
+    double flow; //!< extrusion flow in %
+    int layer_thickness; //!< layer height
+    double extrusion_mm3_per_mm;//!< mm^3 filament moved per mm line extruded
 public:
-    PrintFeatureType type; //!< name of the feature type
-    RetractionConfig *const retraction_config; //!< The retraction configuration to use when retracting after a part of this feature has been printed.
-
-    GCodePathConfig(RetractionConfig* retraction_config, PrintFeatureType type)
-    : speed_iconic(0)
-    , speed(0)
-    , line_width(0)
-    , extrusion_mm3_per_mm(0.0)
-    , type(type)
-    , retraction_config(retraction_config)
+    const char* name;
+    bool spiralize;
+    RetractionConfig *const retraction_config;
+    
+    // GCodePathConfig() : speed(0), line_width(0), extrusion_mm3_per_mm(0.0), name(nullptr), spiralize(false), retraction_config(nullptr) {}
+    GCodePathConfig(RetractionConfig* retraction_config, const char* name) : speed(0), line_width(0), extrusion_mm3_per_mm(0.0), name(name), spiralize(false), retraction_config(retraction_config) {}
+    
+    void setSpeed(double speed)
     {
+        this->speed = speed;
     }
     
-    /*!
-     * Initialize some of the member variables.
-     * 
-     * \warning GCodePathConfig::setLayerHeight still has to be called before this object can be used.
-     * 
-     * \param speed The regular speed with which to print this feature
-     * \param line_width The line width for this feature
-     * \param flow The flow modifier to apply to the extruded filament when printing this feature
-     */
-    void init(double speed, int line_width, double flow)
+    void setLineWidth(int line_width)
     {
-        speed_iconic = speed;
-        this->speed = speed;
         this->line_width = line_width;
-        this->flow = flow;
+        calculateExtrusion();
     }
-
-    /*!
-     * Set the layer height and (re)compute the extrusion_per_mm
-     */
+    
     void setLayerHeight(int layer_height)
     {
         this->layer_thickness = layer_height;
         calculateExtrusion();
     }
+
+    void setFlow(double flow)
+    {
+        this->flow = flow;
+        calculateExtrusion();
+    }
     
-    /*!
-     * Set the speed to somewhere between the @p min_speed and the speed_iconic.
-     * 
-     * This functions should not be called with @p layer_nr > @p max_speed_layer !
-     * 
-     * \param min_speed The speed at layer zero
-     * \param layer_nr The layer number 
-     * \param max_speed_layer The layer number for which the speed_iconic should be used.
-     */
     void smoothSpeed(double min_speed, int layer_nr, double max_speed_layer) 
     {
-        speed = (speed_iconic*layer_nr)/max_speed_layer + (min_speed*(max_speed_layer-layer_nr)/max_speed_layer);
+        speed = (speed*layer_nr)/max_speed_layer + (min_speed*(max_speed_layer-layer_nr)/max_speed_layer);
     }
-
-    /*!
-     * Set the speed to the iconic speed, i.e. the normal speed of the feature type for which this is a config.
-     */
-    void setSpeedIconic()
-    {
-        speed = speed_iconic;
-    }
-
-    /*!
-     * Can only be called after the layer height has been set (which is done while writing the gcode!)
-     */
+    
     double getExtrusionMM3perMM()
     {
         return extrusion_mm3_per_mm;
     }
     
-    /*!
-     * Get the movement speed in mm/s
-     */
     double getSpeed()
     {
         return speed;
@@ -139,17 +98,7 @@ public:
     {
         return line_width;
     }
-    
-    bool isTravelPath()
-    {
-        return line_width == 0;
-    }
-    
-    double getFlowPercentage()
-    {
-        return flow;
-    }
-    
+
 private:
     void calculateExtrusion()
     {
@@ -159,130 +108,68 @@ private:
 
 //The GCodeExport class writes the actual GCode. This is the only class that knows how GCode looks and feels.
 //  Any customizations on GCodes flavors are done in this class.
-class GCodeExport : public NoCopy
+class GCodeExport
 {
 private:
     struct ExtruderTrainAttributes
     {
-        int nozzle_size; //!< The nozzle size label of the nozzle (e.g. 0.4mm; irrespective of tolerances)
         Point nozzle_offset;
         char extruderCharacter;
         std::string start_code;
         std::string end_code;
         double filament_area; //!< in mm^2 for non-volumetric, cylindrical filament
 
-        RetractionConfig extruder_switch_retraction_config; //!< Retraction configuration used when performing extruder switches
-
+        double extruderSwitchRetraction;
+        int extruderSwitchRetractionSpeed;
+        int extruderSwitchPrimeSpeed;
+        
         double totalFilament; //!< total filament used per extruder in mm^3
         int currentTemperature;
-        int initial_temp; //!< Temperature this nozzle needs to be at the start of the print.
-
-        double retraction_e_amount_current; //!< The current retracted amount (in mm or mm^3), or zero(i.e. false) if it is not currently retracted (positive values mean retracted amount, so negative impact on E values)
-        double retraction_e_amount_at_e_start; //!< The ExtruderTrainAttributes::retraction_amount_current value at E0, i.e. the offset (in mm or mm^3) from E0 to the situation where the filament is at the tip of the nozzle.
-
-        double prime_volume; //!< Amount of material (in mm^3) to be primed after an unretration (due to oozing and/or coasting)
-        double last_retraction_prime_speed; //!< The last prime speed (in mm/s) of the to-be-primed amount
-
-        std::deque<double> extruded_volume_at_previous_n_retractions; // in mm^3
-
+        
         ExtruderTrainAttributes()
         : nozzle_offset(0,0)
         , extruderCharacter(0)
         , start_code("")
         , end_code("")
         , filament_area(0)
+        , extruderSwitchRetraction(0.0)
+        , extruderSwitchRetractionSpeed(0)
+        , extruderSwitchPrimeSpeed(0)
         , totalFilament(0)
         , currentTemperature(0)
-        , initial_temp(0)
-        , retraction_e_amount_current(0.0)
-        , retraction_e_amount_at_e_start(0.0)
-        , prime_volume(0.0)
-        , last_retraction_prime_speed(0.0)
         { }
     };
     ExtruderTrainAttributes extruder_attr[MAX_EXTRUDERS];
-    unsigned int extruder_count;
     bool use_extruder_offset_to_offset_coords;
-    Point3 machine_dimensions;
-    std::string machine_name;
-
+    
     std::ostream* output_stream;
-    std::string new_line;
-
-    double current_e_value; //!< The last E value written to gcode (in mm or mm^3)
+    double extrusion_amount; // in mm or mm^3
+    std::deque<double> extrusion_amount_at_previous_n_retractions; // in mm or mm^3
     Point3 currentPosition;
-    double currentSpeed; //!< The current speed (F values / 60) in mm/s
-    int zPos; // TODO: why is this different from currentPosition.z ? zPos is set every layer, while currentPosition.z is set every move. However, the z position is generally not changed within a layer!
-    int isZHopped; //!< The amount by which the print head is currently z hopped, or zero if it is not z hopped. (A z hop is used during travel moves to avoid collision with other layer parts)
+    Point3 startPosition;
+    double currentSpeed;
+    int zPos;
+    bool isRetracted;
+    bool isZHopped;
 
+    double last_coasted_amount_mm3; //!< The coasted amount of filament to be primed on the first next extrusion. (same type as GCodeExport::extrusion_amount)
+    double retractionPrimeSpeed;
     int current_extruder;
     int currentFanSpeed;
     EGCodeFlavor flavor;
 
-    double totalPrintTime; //!< The total estimated print time in seconds
+    double totalPrintTime;
+    double total_print_time_per_feature[(unsigned int)EPrintFeature::ENUM_COUNT];
     TimeEstimateCalculator estimateCalculator;
     
     bool is_volumatric;
-    bool firmware_retract; //!< whether retractions are done in the firmware, or hardcoded in E values.
-
-    unsigned int layer_nr; //!< for sending travel data
-
-    int initial_bed_temp; //!< bed temperature at the beginning of the print.
-protected:
-    /*!
-     * Convert an E value to a value in mm (if it wasn't already in mm) for the current extruder.
-     * 
-     * E values are either in mm or in mm^3
-     * The current extruder is used to determine the filament area to make the conversion.
-     * 
-     * \param e the value to convert
-     * \return the value converted to mm
-     */
-    double eToMm(double e);
-
-    /*!
-     * Convert a volume value to an E value (which might be volumetric as well) for the current extruder.
-     * 
-     * E values are either in mm or in mm^3
-     * The current extruder is used to determine the filament area to make the conversion.
-     * 
-     * \param mm3 the value to convert
-     * \return the value converted to mm or mm3 depending on whether the E axis is volumetric
-     */
-    double mm3ToE(double mm3);
-
-    /*!
-     * Convert a distance value to an E value (which might be linear/distance based as well) for the current extruder.
-     * 
-     * E values are either in mm or in mm^3
-     * The current extruder is used to determine the filament area to make the conversion.
-     * 
-     * \param mm the value to convert
-     * \return the value converted to mm or mm3 depending on whether the E axis is volumetric
-     */
-    double mmToE(double mm);
-
 public:
     
     GCodeExport();
     ~GCodeExport();
-
-    /*!
-     * Get the gcode file header (e.g. ";FLAVOR:UltiGCode\n")
-     * 
-     * \param print_time The total print time in seconds of the whole gcode (if known)
-     * \param filament_used The total mm^3 filament used for each extruder or a vector of the wrong size of unknown
-     * \param mat_ids The material ids for each material.
-     * \return The string representing the file header
-     */
-    std::string getFileHeader(const double* print_time = nullptr, const std::vector<double>& filament_used = std::vector<double>(), const std::vector<int16_t>& mat_ids = std::vector<int16_t>());
-
-    void setLayerNr(unsigned int layer_nr);
     
     void setOutputStream(std::ostream* stream);
-
-    int getNozzleSize(int extruder_idx);
-
+    
     Point getExtruderOffset(int id);
     
     Point getGcodePos(int64_t x, int64_t y, int extruder_train);
@@ -292,55 +179,38 @@ public:
     
     void setZ(int z);
     
-    void addLastCoastedVolume(double last_coasted_volume) 
-    {
-        extruder_attr[current_extruder].prime_volume += last_coasted_volume; 
-    }
+    void setLastCoastedAmountMM3(double last_coasted_amount) { this->last_coasted_amount_mm3 = last_coasted_amount; }
     
     Point3 getPosition();
     
     Point getPositionXY();
+    
+    void resetStartPosition();
+
+    Point getStartPositionXY();
 
     int getPositionZ();
 
     int getExtruderNr();
     
     void setFilamentDiameter(unsigned int n, int diameter);
+    double getFilamentArea(unsigned int extruder);
     
-    double getCurrentExtrudedVolume();
+    double getExtrusionAmountMM3(unsigned int extruder);
+    
+    double getTotalFilamentUsed(int e);
 
-    /*!
-     * Get the total extruded volume for a specific extruder in mm^3
-     * 
-     * Retractions and unretractions don't contribute to this.
-     * 
-     * \param extruder_nr The extruder number for which to get the total netto extruded volume
-     * \return total filament printed in mm^3
-     */
-    double getTotalFilamentUsed(int extruder_nr);
-
-    /*!
-     * Get the total estimated print time in seconds
-     * 
-     * \return total print time in seconds
-     */
     double getTotalPrintTime();
-    void updateTotalPrintTime();
+    double getTotalPrintTime(EPrintFeature print_feature);
+    void updateTotalPrintTime(EPrintFeature print_feature = EPrintFeature::UNCLASSIFIED);
     void resetTotalPrintTimeAndFilament();
     
     void writeComment(std::string comment);
     void writeTypeComment(const char* type);
-    void writeTypeComment(PrintFeatureType type);
     void writeLayerComment(int layer_nr);
-    void writeLayerCountComment(int layer_count);
     
     void writeLine(const char* line);
     
-    /*!
-     * Reset the current_e_value to prevent too high E values.
-     * 
-     * The current extruded volume is added to the current extruder_attr.
-     */
     void resetExtrusionValue();
     
     void writeDelay(double timeAmount);
@@ -350,12 +220,8 @@ public:
     void writeMove(Point3 p, double speed, double extrusion_per_mm);
 private:
     void writeMove(int x, int y, int z, double speed, double extrusion_per_mm);
-    /*!
-     * The writeMove when flavor == BFB
-     */
-    void writeMoveBFB(int x, int y, int z, double speed, double extrusion_per_mm);
 public:
-    void writeRetraction(RetractionConfig* config, bool force = false, bool extruder_switch = false);
+    void writeRetraction(RetractionConfig* config, bool force=false);
     
     void writeRetraction_extruderSwitch();
     
@@ -363,52 +229,35 @@ public:
     
     void writeCode(const char* str);
     
-    /*!
-     * Write the gcode for priming the current extruder train so that it can be used.
-     */
-    void writePrimeTrain();
-    
     void writeFanCommand(double speed);
     
     void writeTemperatureCommand(int extruder, double temperature, bool wait = false);
     void writeBedTemperatureCommand(double temperature, bool wait = false);
+    
+    void preSetup(MeshGroup* settings)
+    {
+        for(int n=0; n<settings->getSettingAsCount("machine_extruder_count"); n++)
+        {
+            ExtruderTrain* train = settings->getExtruderTrain(n);
+            setFilamentDiameter(n, train->getSettingInMicrons("material_diameter")); 
+            
+            extruder_attr[n].nozzle_offset = Point(train->getSettingInMicrons("machine_nozzle_offset_x"), train->getSettingInMicrons("machine_nozzle_offset_y"));
+            
+            extruder_attr[n].start_code = train->getSettingString("machine_extruder_start_code");
+            extruder_attr[n].end_code = train->getSettingString("machine_extruder_end_code");
+            
+            extruder_attr[n].extruderSwitchRetraction = INT2MM(train->getSettingInMicrons("switch_extruder_retraction_amount")); 
+            extruder_attr[n].extruderSwitchRetractionSpeed = train->getSettingInMillimetersPerSecond("switch_extruder_retraction_speed");
+            extruder_attr[n].extruderSwitchPrimeSpeed = train->getSettingInMillimetersPerSecond("switch_extruder_prime_speed");
+        }
 
-    /*!
-     * Set member variables using the settings in \p settings
-     * 
-     * \param settings The meshgroup to get the global bed temp from and to get the extruder trains from which to get the nozzle temperatures
-     */
-    void preSetup(MeshGroup* settings);
-
-    /*!
-     * Handle the initial (bed/nozzle) temperatures before any gcode is processed.
-     * These temperatures are set in the pre-print setup in the firmware.
-     * 
-     * See FffGcodeWriter::processStartingCode
-     * 
-     * \param settings The meshgroup to get the global bed temp from and to get the extruder trains from which to get the nozzle temperatures
-     */
-    void setInitialTemps(const MeshGroup& settings);
-
-    /*!
-     * Override or set an initial nozzle temperature as written by GCodeExport::setInitialTemps
-     * This is used primarily during better specification of temperatures in LayerPlanBuffer::insertPreheatCommand
-     * 
-     * \param extruder_nr The extruder number for which to better specify the temp
-     * \param temp The temp at which the nozzle should be at startup
-     */
-    void setInitialTemp(int extruder_nr, double temp);
-
-    /*!
-     * Finish the gcode: turn fans off, write end gcode and flush all gcode left in the buffer.
-     * 
-     * \param endCode The end gcode to be appended at the very end.
-     */
-    void finalize(const char* endCode);
-
+        setFlavor(settings->getSettingAsGCodeFlavor("machine_gcode_flavor"));
+        use_extruder_offset_to_offset_coords = settings->getSettingBoolean("machine_use_extruder_offset_to_offset_coords");
+    }
+    void finalize(int maxObjectHeight, double moveSpeed, const char* endCode);
+    
 };
 
 }
 
 #endif//GCODEEXPORT_H
-

src/gcodePlanner.h

@@ -8,9 +8,6 @@
 #include "utils/polygon.h"
 #include "utils/logoutput.h"
 #include "wallOverlap.h"
-#include "commandSocket.h"
-#include "FanSpeedLayerTime.h"
-#include "SpaceFillType.h"
 
 
 namespace cura 
@@ -18,367 +15,46 @@ namespace cura
 
 class SliceDataStorage;
 
-/*!
- * A gcode command to insert before a specific path.
- * 
- * Currently only used for preheat commands
- */
-struct NozzleTempInsert
-{
-    const unsigned int path_idx; //!< The path before which to insert this command
-    double time_after_path_start; //!< The time after the start of the path, before which to insert the command // TODO: use this to insert command in between moves in a path!
-    int extruder; //!< The extruder for which to set the temp
-    double temperature; //!< The temperature of the temperature command to insert
-    bool wait; //!< Whether to wait for the temperature to be reached
-    NozzleTempInsert(unsigned int path_idx, int extruder, double temperature, bool wait, double time_after_path_start = 0.0)
-    : path_idx(path_idx)
-    , time_after_path_start(time_after_path_start)
-    , extruder(extruder)
-    , temperature(temperature)
-    , wait(wait)
-    {}
-    
-    /*!
-     * Write the temperature command at the current position in the gcode.
-     * \param gcode The actual gcode writer
-     */
-    void write(GCodeExport& gcode)
-    {
-        gcode.writeTemperatureCommand(extruder, temperature, wait);
-    }
-};
-
-class GCodePlanner; // forward declaration so that TimeMaterialEstimates can be a friend
-
-/*!
- * Time and material estimates for a portion of paths, e.g. layer, extruder plan, path.
- */
-class TimeMaterialEstimates
-{
-    friend class GCodePlanner;
-private:
-    double extrude_time; //!< Time in seconds occupied by extrusion
-    double unretracted_travel_time; //!< Time in seconds occupied by non-retracted travel (non-extrusion)
-    double retracted_travel_time; //!< Time in seconds occupied by retracted travel (non-extrusion)
-    double material; //!< Material used (in mm^3)
-public:
-    /*!
-     * Basic contructor
-     * 
-     * \param extrude_time Time in seconds occupied by extrusion
-     * \param unretracted_travel_time Time in seconds occupied by non-retracted travel (non-extrusion)
-     * \param retracted_travel_time Time in seconds occupied by retracted travel (non-extrusion)
-     * \param material Material used (in mm^3)
-     */
-    TimeMaterialEstimates(double extrude_time, double unretracted_travel_time, double retracted_travel_time, double material)
-    : extrude_time(extrude_time)
-    , unretracted_travel_time(unretracted_travel_time)
-    , retracted_travel_time(retracted_travel_time)
-    , material(material)
-    {
-    }
-
-    /*!
-     * Basic constructor initializing all estimates to zero.
-     */
-    TimeMaterialEstimates()
-    : extrude_time(0.0)
-    , unretracted_travel_time(0.0)
-    , retracted_travel_time(0.0)
-    , material(0.0)
-    {
-    }
-
-    /*!
-     * Set all estimates to zero.
-     */
-    void reset() 
-    {
-        extrude_time = 0.0;
-        unretracted_travel_time = 0.0;
-        retracted_travel_time = 0.0;
-        material = 0.0;
-    }
-
-    /*!
-     * Pointwise addition of estimate stats
-     * 
-     * \param other The estimates to add to these estimates.
-     * \return The resulting estimates
-     */
-    TimeMaterialEstimates operator+(const TimeMaterialEstimates& other)
-    {
-        return TimeMaterialEstimates(extrude_time+other.extrude_time, unretracted_travel_time+other.unretracted_travel_time, retracted_travel_time+other.retracted_travel_time, material+other.material);
-    }
-
-    /*!
-     * In place pointwise addition of estimate stats
-     * 
-     * \param other The estimates to add to these estimates.
-     * \return These estimates
-     */
-    TimeMaterialEstimates& operator+=(const TimeMaterialEstimates& other)
-    {
-        extrude_time += other.extrude_time;
-        unretracted_travel_time += other.unretracted_travel_time;
-        retracted_travel_time += other.retracted_travel_time;
-        material += other.material;
-        return *this;
-    }
-
-    /*!
-     * \brief Subtracts the specified estimates from these estimates and returns
-     * the result.
-     * 
-     * Each of the estimates in this class are individually subtracted.
-     * 
-     * \param other The estimates to subtract from these estimates.
-     * \return These estimates with the specified estimates subtracted.
-     */
-    TimeMaterialEstimates operator-(const TimeMaterialEstimates& other);
-
-    /*!
-     * \brief Subtracts the specified elements from these estimates.
-     * 
-     * This causes the estimates in this instance to change. Each of the
-     * estimates in this class are individually subtracted.
-     * 
-     * \param other The estimates to subtract from these estimates.
-     * \return A reference to this instance.
-     */
-    TimeMaterialEstimates& operator-=(const TimeMaterialEstimates& other);
-
-    /*!
-     * Get total time estimate. The different time estimate member values added together.
-     * 
-     * \return the total of all different time estimate values 
-     */
-    double getTotalTime() const
-    {
-        return extrude_time + unretracted_travel_time + retracted_travel_time;
-    }
-
-    /*!
-     * Get the total time during which the head is not retracted.
-     * 
-     * This includes extrusion time and non-retracted travel time
-     * 
-     * \return the total time during which the head is not retracted.
-     */
-    double getTotalUnretractedTime() const
-    {
-        return extrude_time + unretracted_travel_time;
-    }
-
-    /*!
-     * Get the total travel time.
-     * 
-     * This includes the retracted travel time as well as the unretracted travel time.
-     * 
-     * \return the total travel time.
-     */
-    double getTravelTime() const
-    {
-        return retracted_travel_time + unretracted_travel_time;
-    }
-
-    /*!
-     * Get the extrusion time.
-     * 
-     * \return extrusion time.
-     */
-    double getExtrudeTime() const
-    {
-        return extrude_time;
-    }
-
-    /*!
-     * Get the amount of material used in mm^3.
-     * 
-     * \return amount of material
-     */
-    double getMaterial() const
-    {
-        return material;
-    }
-};
-
-/*!
- * A class for representing a planned path.
- * 
- * A path consists of several segments of the same type of movement: retracted travel, infill extrusion, etc.
- * 
- * This is a compact premature representation in which are line segments have the same config, i.e. the config of this path.
- * 
- * In the final representation (gcode) each line segment may have different properties, 
- * which are added when the generated GCodePaths are processed.
- */
 class GCodePath
 {
 public:
     GCodePathConfig* config; //!< The configuration settings of the path.
-    SpaceFillType space_fill_type; //!< The type of space filling of which this path is a part
     float flow; //!< A type-independent flow configuration (used for wall overlap compensation)
     bool retract; //!< Whether the path is a move path preceded by a retraction move; whether the path is a retracted move path. 
+    int extruder; //!< The extruder used for this path.
     std::vector<Point> points; //!< The points constituting this path.
     bool done;//!< Path is finished, no more moves should be added, and a new path should be started instead of any appending done to this one.
-
-    bool spiralize; //!< Whether to gradually increment the z position during the printing of this path. A sequence of spiralized paths should start at the given layer height and end in one layer higher.
-
-    TimeMaterialEstimates estimates; //!< Naive time and material estimates
-
-    /*!
-     * Whether this config is the config of a travel path.
-     * 
-     * \return Whether this config is the config of a travel path.
-     */
-    bool isTravelPath()
-    {
-        return config->isTravelPath();
-    }
-
-    /*!
-     * Get the material flow in mm^3 per mm traversed.
-     * 
-     * \warning Can only be called after the layer height has been set (which is done while writing the gcode!)
-     * 
-     * \return The flow
-     */
+    
     double getExtrusionMM3perMM()
     {
         return flow * config->getExtrusionMM3perMM();
     }
-    
-    /*!
-     * Get the actual line width (modulated by the flow)
-     * \return the actual line width as shown in layer view
-     */
-    int getLineWidth()
-    {
-        return flow * config->getLineWidth() * config->getFlowPercentage() / 100.0;
-    }
 };
 
-/*!
- * An extruder plan contains all planned paths (GCodePath) pertaining to a single extruder train.
- * 
- * It allows for temperature command inserts which can be inserted in between paths.
- */
-class ExtruderPlan
-{
-public:
-    std::vector<GCodePath> paths; //!< The paths planned for this extruder
-    std::list<NozzleTempInsert> inserts; //!< The nozzle temperature command inserts, to be inserted in between paths
-
-    int extruder; //!< The extruder used for this paths in the current plan.
-    double required_temp; //!< The required temperature at the start of this extruder plan.
-
-    TimeMaterialEstimates estimates; //!< Accumulated time and material estimates for all planned paths within this extruder plan.
-
-    /*!
-     * Simple contructor.
-     * 
-     * \warning Doesn't set the required temperature yet.
-     * 
-     * \param extruder The extruder number for which this object is a plan.
-     */
-    ExtruderPlan(int extruder)
-    : extruder(extruder)
-    , required_temp(-1)
-    {
-    }
-
-    /*!
-     * Add a new Insert, constructed with the given arguments
-     * 
-     * \see NozzleTempInsert
-     * 
-     * \param contructor_args The arguments for the constructor of an insert 
-     */
-    template<typename... Args>
-    void insertCommand(Args&&... contructor_args)
-    {
-        inserts.emplace_back(contructor_args...);
-    }
-
-    /*!
-     * Insert the inserts into gcode which should be inserted before \p path_idx
-     * 
-     * \param path_idx The index into ExtruderPlan::paths which is currently being consider for temperature command insertion
-     * \param gcode The gcode exporter to which to write the temperature command.
-     */
-    void handleInserts(unsigned int& path_idx, GCodeExport& gcode)
-    {
-        while ( ! inserts.empty() && path_idx >= inserts.front().path_idx)
-        { // handle the Insert to be inserted before this path_idx (and all inserts not handled yet)
-            inserts.front().write(gcode);
-            inserts.pop_front();
-        }
-    }
-
-    /*!
-     * Insert all remaining temp inserts into gcode, to be called at the end of an extruder plan
-     * 
-     * Inserts temperature commands which should be inserted _after_ the last path.
-     * Also inserts all temperatures which should have been inserted earlier,
-     * but for which ExtruderPlan::handleInserts hasn't been called correctly.
-     * 
-     * \param gcode The gcode exporter to which to write the temperature command.
-     */
-    void handleAllRemainingInserts(GCodeExport& gcode)
-    { 
-        while ( ! inserts.empty() )
-        { // handle the Insert to be inserted before this path_idx (and all inserts not handled yet)
-            NozzleTempInsert& insert = inserts.front();
-            assert(insert.path_idx == paths.size());
-            insert.write(gcode);
-            inserts.pop_front();
-        }
-    }
-};
-
-class LayerPlanBuffer; // forward declaration to prevent circular dependency
-
 /*! 
  * The GCodePlanner class stores multiple moves that are planned.
- * 
- * 
  * It facilitates the combing to keep the head inside the print.
  * It also keeps track of the print time estimate for this planning so speed adjustments can be made for the minimal-layer-time.
- * 
- * A GCodePlanner is also knows as a 'layer plan'.
- * 
  */
-class GCodePlanner : public NoCopy
+class GCodePlanner
 {
-    friend class LayerPlanBuffer;
 private:
-    SliceDataStorage& storage; //!< The polygon data obtained from FffPolygonProcessor
+    GCodeExport& gcode;
+    SliceDataStorage& storage;
 
-    int layer_nr; //!< The layer number of this layer plan
-    
-    int z; 
-    
-    int layer_thickness;
-    
-    Point start_position;
     Point lastPosition;
+    std::vector<GCodePath> paths;
     
-    std::vector<ExtruderPlan> extruder_plans; //!< should always contain at least one ExtruderPlan
-    
-    bool was_inside; //!< Whether the last planned (extrusion) move was inside a layer part
-    bool is_inside; //!< Whether the destination of the next planned travel move is inside a layer part
-    Polygons comb_boundary_inside; //!< The boundary within which to comb, or to move into when performing a retraction.
+    bool was_combing;
+    bool is_going_to_comb;
     Comb* comb;
 
     RetractionConfig* last_retraction_config;
     
-    FanSpeedLayerTimeSettings& fan_speed_layer_time_settings;
-
+    GCodePathConfig travelConfig; //!< The config used for travel moves (only the speed and retraction config are set!)
     double extrudeSpeedFactor;
-    double travelSpeedFactor;
-    
-    double fan_speed;
+    double travelSpeedFactor; // TODO: remove this unused var?
+    int currentExtruder;
     
     double extraTime;
     double totalPrintTime;
@@ -389,12 +65,10 @@ private:
      * If GCodePlanner::forceNewPathStart has been called a new path will always be returned.
      * 
      * \param config The config used for the path returned
-     * \param space_fill_type The type of space filling which this path employs
      * \param flow (optional) A ratio for the extrusion speed
-     * \param spiralize Whether to gradually increase the z while printing. (Note that this path may be part of a sequence of spiralized paths, forming one polygon)
      * \return A path with the given config which is now the last path in GCodePlanner::paths
      */
-    GCodePath* getLatestPathWithConfig(GCodePathConfig* config, SpaceFillType space_fill_type, float flow = 1.0, bool spiralize = false);
+    GCodePath* getLatestPathWithConfig(GCodePathConfig* config, float flow = 1.0);
     
     /*!
      * Force GCodePlanner::getLatestPathWithConfig to return a new path.
@@ -408,78 +82,26 @@ private:
      */
     void forceNewPathStart();
 public:
-    /*!
+    /*
      * 
      * \param travel_avoid_other_parts Whether to avoid other layer parts when travaeling through air.
      * \param travel_avoid_distance The distance by which to avoid other layer parts when traveling through air.
-     * \param last_position The position of the head at the start of this gcode layer
-     * \param combing_mode Whether combing is enabled and full or within infill only.
      */
-    GCodePlanner(SliceDataStorage& storage, unsigned int layer_nr, int z, int layer_height, Point last_position, int current_extruder, bool is_inside_mesh, FanSpeedLayerTimeSettings& fan_speed_layer_time_settings, CombingMode combing_mode, int64_t comb_boundary_offset, bool travel_avoid_other_parts, int64_t travel_avoid_distance);
+    GCodePlanner(GCodeExport& gcode, SliceDataStorage& storage, RetractionConfig* retraction_config_travel, double travelSpeed, bool retraction_combing, unsigned int layer_nr, int64_t comb_boundary_offset, bool travel_avoid_other_parts, int64_t travel_avoid_distance);
     ~GCodePlanner();
 
-private:
-    /*!
-     * Compute the boundary within which to comb, or to move into when performing a retraction.
-     * \param combing_mode Whether combing is enabled and full or within infill only.
-     * \return the comb_boundary_inside
-     */
-    Polygons computeCombBoundaryInside(CombingMode combing_mode);
-
-public:
-    int getLayerNr()
-    {
-        return layer_nr;
-    }
-    
-    Point getLastPosition()
-    {
-        return lastPosition;
-    }
-
-    /*!
-     * return whether the last position planned was inside the mesh (used in combing)
-     */
-    bool getIsInsideMesh()
-    {
-        return was_inside;
-    }
-    /*!
-     * send a polygon through the command socket from the previous point to the given point
-     */
-    void sendPolygon(PrintFeatureType print_feature_type, Point from, Point to, int line_width)
-    {
-        if (CommandSocket::isInstantiated()) 
-        {
-            // we should send this travel as a non-retraction move
-            cura::Polygons pathPoly;
-            PolygonRef path = pathPoly.newPoly();
-            path.add(from);
-            path.add(to);
-            CommandSocket::getInstance()->sendPolygons(print_feature_type, layer_nr, pathPoly, line_width);
-        }
-    }
-
-    /*!
-    * Set whether the next destination is inside a layer part or not.
-    * 
-    * Features like infill, walls, skin etc. are considered inside.
-    * Features like prime tower and support are considered outside.
-    */
-    void setIsInside(bool going_to_comb);
+    void setCombing(bool going_to_comb);
     
     bool setExtruder(int extruder);
 
-    /*!
-     * Get the last planned extruder.
-     */
     int getExtruder()
     {
-        return extruder_plans.back().extruder;
+        return currentExtruder;
     }
 
     void setExtrudeSpeedFactor(double speedFactor)
     {
+        if (speedFactor < 1) speedFactor = 1.0;
         this->extrudeSpeedFactor = speedFactor;
     }
     double getExtrudeSpeedFactor()
@@ -495,12 +117,16 @@ public:
     {
         return this->travelSpeedFactor;
     }
-    
-    void setFanSpeed(double _fan_speed)
-    {
-        fan_speed = _fan_speed;
-    }
-    
+
+    /*!
+     * Whether the current retracted path is to be an extruder switch retraction.
+     * This function is used to avoid a G10 S1 after a G10.
+     * 
+     * \param path_idx The index of the current retracted path 
+     * \return Whether the path should be an extgruder switch retracted path
+     */
+    bool makeRetractSwitchRetract(unsigned int path_idx);
+
     /*!
      * Add a travel path to a certain point, retract if needed and when avoiding boundary crossings:
      * avoiding obstacles and comb along the boundary of parts.
@@ -518,138 +144,75 @@ public:
      * \param path (optional) The travel path to which to add the point \p p
      */
     void addTravel_simple(Point p, GCodePath* path = nullptr);
+    
+    void addExtrusionMove(Point p, GCodePathConfig* config, float flow = 1.0);
 
-    /*!
-     * Add an extrusion move to a certain point, optionally with a different flow than the one in the \p config.
-     * 
-     * \param p The point to extrude to
-     * \param config The config with which to extrude
-     * \param space_fill_type Of what space filling type this extrusion move is a part
-     * \param flow A modifier of the extrusion width which would follow from the \p config
-     * \param spiralize Whether to gradually increase the z while printing. (Note that this path may be part of a sequence of spiralized paths, forming one polygon)
-     */
-    void addExtrusionMove(Point p, GCodePathConfig* config, SpaceFillType space_fill_type, float flow = 1.0, bool spiralize = false);
+    void addPolygon(PolygonRef polygon, int startIdx, GCodePathConfig* config, WallOverlapComputation* wall_overlap_computation = nullptr);
 
-    /*!
-     * Add polygon to the gcode starting at vertex \p startIdx
-     * \param polygon The polygon
-     * \param startIdx The index of the starting vertex of the \p polygon
-     * \param config The config with which to print the polygon lines
-     * \param wall_overlap_computation The wall overlap compensation calculator for each given segment (optionally nullptr)
-     * \param spiralize Whether to gradually increase the z height from the normal layer height to the height of the next layer over this polygon
-     */
-    void addPolygon(PolygonRef polygon, int startIdx, GCodePathConfig* config, WallOverlapComputation* wall_overlap_computation = nullptr, bool spiralize = false);
-
-    /*!
-     * Add polygons to the gcode with optimized order.
-     * 
-     * When \p spiralize is true, each polygon will gradually increase from a z corresponding to this layer to the z corresponding to the next layer.
-     * Doing this for each polygon means there is a chance for the print head to crash into already printed parts,
-     * but doing it for the last polygon only would mean you are printing half of the layer in non-spiralize mode,
-     * while each layer starts with a different part.
-     * Two towers would result in alternating spiralize and non-spiralize layers.
-     * 
-     * \param polygons The polygons
-     * \param config The config with which to print the polygon lines
-     * \param wall_overlap_computation The wall overlap compensation calculator for each given segment (optionally nullptr)
-     * \param z_seam_type The seam type / poly start optimizer
-     * \param spiralize Whether to gradually increase the z height from the normal layer height to the height of the next layer over each polygon printed
-     */
-    void addPolygonsByOptimizer(Polygons& polygons, GCodePathConfig* config, WallOverlapComputation* wall_overlap_computation = nullptr, EZSeamType z_seam_type = EZSeamType::SHORTEST, bool spiralize = false);
+    void addPolygonsByOptimizer(Polygons& polygons, GCodePathConfig* config, WallOverlapComputation* wall_overlap_computation = nullptr, EZSeamType z_seam_type = EZSeamType::SHORTEST);
 
     /*!
      * Add lines to the gcode with optimized order.
      * \param polygons The lines
      * \param config The config of the lines
-     * \param space_fill_type The type of space filling used to generate the line segments (should be either Lines or PolyLines!)
      * \param wipe_dist (optional) the distance wiped without extruding after laying down a line.
      */
-    void addLinesByOptimizer(Polygons& polygons, GCodePathConfig* config, SpaceFillType space_fill_type, int wipe_dist = 0);
+    void addLinesByOptimizer(Polygons& polygons, GCodePathConfig* config, int wipe_dist = 0);
 
-    /*!
-     * Compute naive time estimates (without accountign for slow down at corners etc.) and naive material estimates (without accounting for MergeInfillLines)
-     * and store them in each ExtruderPlan and each GCodePath.
-     * 
-     * \return the total estimates of this layer
-     */
-    TimeMaterialEstimates computeNaiveTimeEstimates();
-    
     void forceMinimalLayerTime(double minTime, double minimalSpeed, double travelTime, double extrusionTime);
     
-    /*!
-     * Write the planned paths to gcode
-     * 
-     * \param gcode The gcode to write the planned paths to
-     */
-    void writeGCode(GCodeExport& gcode);
-    
-    /*!
-     * Complete all GcodePathConfig s by 
-     * - altering speed to conform to speed_layer_0
-     * - setting the layer_height (and thereby computing the extrusionMM3perMM)
-     */
-    void completeConfigs();
-    
-    /*!
-     * Interpolate between the initial layer speeds and the eventual speeds.
-     */
-    void processInitialLayersSpeedup();
-    
-    /*!
-     * Whether the current retracted path is to be an extruder switch retraction.
-     * This function is used to avoid a G10 S1 after a G10.
-     * 
-     * \param gcode The gcode to write the planned paths to
-     * \param extruder_plan_idx The index of the current extruder plan
-     * \param path_idx The index of the current retracted path 
-     * \return Whether the path should be an extgruder switch retracted path
-     */
-    bool makeRetractSwitchRetract(GCodeExport& gcode, unsigned int extruder_plan_idx, unsigned int path_idx);
-    
+    void getNaiveTimeEstimates(double& travelTime, double& extrudeTime);
+
     /*!
      * Writes a path to GCode and performs coasting, or returns false if it did nothing.
      * 
      * Coasting replaces the last piece of an extruded path by move commands and uses the oozed material to lay down lines.
      * 
-     * \param gcode The gcode to write the planned paths to
-     * \param extruder_plan_idx The index of the current extruder plan
      * \param path_idx The index into GCodePlanner::paths for the next path to be written to GCode.
      * \param layerThickness The height of the current layer.
-     * \param coasting_volume The volume otherwise leaked during a normal move.
-     * \param coasting_speed The speed at which to move during move-coasting.
-     * \param coasting_min_volume The minimal volume a path should have (before starting to coast) which builds up enough pressure to ooze as much as \p coasting_volume.
+     * \param coasting_volume_move The volume otherwise leaked during a normal move.
+     * \param coasting_speed_move The speed at which to move during move-coasting.
+     * \param coasting_min_volume_move The minimal volume a path should have which builds up enough pressure to ooze as much as \p coasting_volume_move.
+     * \param coasting_volume_retract The volume otherwise leaked during a retract move.
+     * \param coasting_speed_retract The speed at which to move during retract-coasting.
+     * \param coasting_min_volume_retract The minimal volume a path should have which builds up enough pressure to ooze as much as \p coasting_volume_retract.
      * \return Whether any GCode has been written for the path.
      */
-    bool writePathWithCoasting(GCodeExport& gcode, unsigned int extruder_plan_idx, unsigned int path_idx, int64_t layerThickness, double coasting_volume, double coasting_speed, double coasting_min_volume);
+    bool writePathWithCoasting(unsigned int path_idx, int64_t layerThickness, double coasting_volume_move, double coasting_speed_move, double coasting_min_volume_move, double coasting_volume_retract, double coasting_speed_retract, double coasting_min_volume_retract);
 
+    /*!
+     * Writes a path to GCode and performs coasting, or returns false if it did nothing.
+     * 
+     * Coasting replaces the last piece of an extruded path by move commands and uses the oozed material to lay down lines.
+     * 
+     * Paths shorter than \p coasting_min_volume will use less \p coasting_volume linearly.
+     * 
+     * \param path The extrusion path to be written to GCode.
+     * \param path_next The next travel path to be written to GCode.
+     * \param layerThickness The height of the current layer.
+     * \param coasting_volume The volume otherwise leaked.
+     * \param coasting_speed The speed at which to move during coasting.
+     * \param coasting_min_volume The minimal volume a path should have which builds up enough pressure to ooze as much as \p coasting_volume.
+     * \param extruder_switch_retract (optional) For a coasted path followed by a retraction: whether to retract normally, or do an extruder switch retraction.
+     * \return Whether any GCode has been written for the path.
+     */
+    bool writePathWithCoasting(GCodePath& path, GCodePath& path_next, int64_t layerThickness, double coasting_volume, double coasting_speed, double coasting_min_volume, bool extruder_switch_retract = false);
+    
     /*!
      * Write a retraction: either an extruder switch retraction or a normal retraction based on the last extrusion paths retraction config.
-     * \param gcode The gcode to write the planned paths to
-     * \param extruder_plan_idx The index of the current extruder plan
      * \param path_idx_travel_after Index in GCodePlanner::paths to the travel move before which to do the retraction
      */
-    void writeRetraction(GCodeExport& gcode, unsigned int extruder_plan_idx, unsigned int path_idx_travel_after);
+    void writeRetraction(unsigned int path_idx_travel_after);
     
     /*!
      * Write a retraction: either an extruder switch retraction or a normal retraction based on the given retraction config.
-     * \param gcode The gcode to write the planned paths to
      * \param extruder_switch_retract Whether to write an extruder switch retract
      * \param retraction_config The config used.
      */
-    void writeRetraction(GCodeExport& gcode, bool extruder_switch_retract, RetractionConfig* retraction_config);
+    void writeRetraction(bool extruder_switch_retract, RetractionConfig* retraction_config);
     
-    /*!
-     * Applying speed corrections for minimal layer times and determine the fanSpeed. 
-     */
-    void processFanSpeedAndMinimalLayerTime();
-    
-    /*!
-     * Add a travel move to the layer plan to move inside the current layer part by a given distance away from the outline.
-     * This is supposed to be called when the nozzle is around the boundary of a layer part, not when the nozzle is in the middle of support, or in the middle of the air.
-     * 
-     * \param distance The distance to the comb boundary after we moved inside it.
-     */
-    void moveInsideCombBoundary(int distance);
+    void writeGCode(bool liftHeadIfNeeded, int layerThickness);
+    void moveInsideCombBoundary(int arg1);
 };
 
 }//namespace cura

src/infill.cpp

@@ -2,11 +2,12 @@
 #include "infill.h"
 #include "functional"
 #include "utils/polygonUtils.h"
+#include "utils/AABB.h"
 #include "utils/logoutput.h"
 
 namespace cura {
 
-void Infill::generate(Polygons& result_polygons, Polygons& result_lines)
+void Infill::generate(Polygons& result_polygons, Polygons& result_lines, Polygons* in_between)
 {
     if (in_outline.size() == 0) return;
     if (line_distance == 0) return;
@@ -15,21 +16,36 @@ void Infill::generate(Polygons& result_polygons, Polygons& result_lines)
     switch(pattern)
     {
     case EFillMethod::GRID:
-        generateGridInfill(result_lines);
+        generateGridInfill(in_outline, outlineOffset, result_lines, extrusion_width, line_distance * 2, infill_overlap, fill_angle);
         break;
     case EFillMethod::LINES:
-        generateLineInfill(result_lines, line_distance, fill_angle);
+        generateLineInfill(in_outline, outlineOffset, result_lines, extrusion_width, line_distance, infill_overlap, fill_angle);
         break;
     case EFillMethod::TRIANGLES:
-        generateTriangleInfill(result_lines);
+        generateTriangleInfill(in_outline, outlineOffset, result_lines, extrusion_width, line_distance * 3, infill_overlap, fill_angle);
         break;
     case EFillMethod::CONCENTRIC:
-        outline_offsetted = in_outline.offset(outline_offset - infill_line_width / 2); // - infill_line_width / 2 cause generateConcentricInfill expects [outline] to be the outer most polygon instead of the outer outline 
-        outline = &outline_offsetted;
-        generateConcentricInfill(*outline, result_polygons, line_distance);
+        if (outlineOffset != 0)
+        {
+            PolygonUtils::offsetSafe(in_outline, outlineOffset, extrusion_width, outline_offsetted, avoidOverlappingPerimeters);
+            outline = &outline_offsetted;
+        }
+        if (abs(extrusion_width - line_distance) < 10)
+        {
+            generateConcentricInfillDense(*outline, result_polygons, in_between, extrusion_width, avoidOverlappingPerimeters);
+        }
+        else 
+        {
+            generateConcentricInfill(*outline, result_polygons, line_distance);
+        }
         break;
     case EFillMethod::ZIG_ZAG:
-        generateZigZagInfill(result_lines, line_distance, fill_angle, connected_zigzags, use_endpieces);
+        if (outlineOffset != 0)
+        {
+            PolygonUtils::offsetSafe(in_outline, outlineOffset, extrusion_width, outline_offsetted, avoidOverlappingPerimeters);
+            outline = &outline_offsetted;
+        }
+        generateZigZagInfill(*outline, result_lines, extrusion_width, line_distance, infill_overlap, fill_angle, connect_zigzags, use_endPieces);
         break;
     default:
         logError("Fill pattern has unknown value.\n");
@@ -37,105 +53,184 @@ void Infill::generate(Polygons& result_polygons, Polygons& result_lines)
     }
 }
 
-void Infill::generateConcentricInfill(Polygons outline, Polygons& result, int inset_value)
+    
+      
+void generateConcentricInfillDense(Polygons outline, Polygons& result, Polygons* in_between, int extrusionWidth, bool avoidOverlappingPerimeters)
 {
     while(outline.size() > 0)
     {
-        result.add(outline);
+        for (unsigned int polyNr = 0; polyNr < outline.size(); polyNr++)
+        {
+            PolygonRef r = outline[polyNr];
+            result.add(r);
+        }
+        Polygons next_outline;
+        PolygonUtils::offsetExtrusionWidth(outline, true, extrusionWidth, next_outline, in_between, avoidOverlappingPerimeters);
+        outline = next_outline;
+    } 
+
+}
+
+void generateConcentricInfill(Polygons outline, Polygons& result, int inset_value)
+{
+    while(outline.size() > 0)
+    {
+        for (unsigned int polyNr = 0; polyNr < outline.size(); polyNr++)
+        {
+            PolygonRef r = outline[polyNr];
+            result.add(r);
+        }
         outline = outline.offset(-inset_value);
     } 
 }
 
 
-void Infill::generateGridInfill(Polygons& result)
+void generateGridInfill(const Polygons& in_outline, int outlineOffset, Polygons& result,
+                        int extrusionWidth, int lineSpacing, double infillOverlap,
+                        double rotation)
 {
-    generateLineInfill(result, line_distance, fill_angle);
-    generateLineInfill(result, line_distance, fill_angle + 90);
+    generateLineInfill(in_outline, outlineOffset, result, extrusionWidth, lineSpacing,
+                       infillOverlap, rotation);
+    generateLineInfill(in_outline, outlineOffset, result, extrusionWidth, lineSpacing,
+                       infillOverlap, rotation + 90);
 }
 
-void Infill::generateTriangleInfill(Polygons& result)
+void generateTriangleInfill(const Polygons& in_outline, int outlineOffset, Polygons& result,
+                        int extrusionWidth, int lineSpacing, double infillOverlap,
+                        double rotation)
 {
-    generateLineInfill(result, line_distance, fill_angle);
-    generateLineInfill(result, line_distance, fill_angle + 60);
-    generateLineInfill(result, line_distance, fill_angle + 120);
+    generateLineInfill(in_outline, outlineOffset, result, extrusionWidth, lineSpacing,
+                       infillOverlap, rotation);
+    generateLineInfill(in_outline, outlineOffset, result, extrusionWidth, lineSpacing,
+                       infillOverlap, rotation + 60);
+    generateLineInfill(in_outline, outlineOffset, result, extrusionWidth, lineSpacing,
+                       infillOverlap, rotation + 120);
 }
 
-void Infill::addLineInfill(Polygons& result, const PointMatrix& rotation_matrix, const int scanline_min_idx, const int line_distance, const AABB boundary, std::vector<std::vector<int64_t>>& cut_list)
+void addLineInfill(Polygons& result, PointMatrix matrix, int scanline_min_idx, int lineSpacing, AABB boundary, std::vector<std::vector<int64_t> > cutList, int extrusionWidth)
 {
     auto addLine = [&](Point from, Point to)
-    {
+    {            
         PolygonRef p = result.newPoly();
-        p.add(rotation_matrix.unapply(from));
-        p.add(rotation_matrix.unapply(to));
+        p.add(matrix.unapply(from));
+        p.add(matrix.unapply(to));
     };
-
+    
     auto compare_int64_t = [](const void* a, const void* b)
     {
         int64_t n = (*(int64_t*)a) - (*(int64_t*)b);
-        if (n < 0)
-        {
-            return -1;
-        }
-        if (n > 0)
-        {
-            return 1;
-        }
+        if (n < 0) return -1;
+        if (n > 0) return 1;
         return 0;
     };
-
+    
     int scanline_idx = 0;
-    for(int64_t x = scanline_min_idx * line_distance; x < boundary.max.X; x += line_distance)
+    for(int64_t x = scanline_min_idx * lineSpacing; x < boundary.max.X; x += lineSpacing)
     {
-        std::vector<int64_t>& crossings = cut_list[scanline_idx];
-        qsort(crossings.data(), crossings.size(), sizeof(int64_t), compare_int64_t);
-        for(unsigned int crossing_idx = 0; crossing_idx + 1 < crossings.size(); crossing_idx += 2)
+        qsort(cutList[scanline_idx].data(), cutList[scanline_idx].size(), sizeof(int64_t), compare_int64_t);
+        for(unsigned int i = 0; i + 1 < cutList[scanline_idx].size(); i+=2)
         {
-            if (crossings[crossing_idx + 1] - crossings[crossing_idx] < infill_line_width / 5)
-            { // segment is too short to create infill
+            if (cutList[scanline_idx][i+1] - cutList[scanline_idx][i] < extrusionWidth / 5)
                 continue;
-            }
-            addLine(Point(x, crossings[crossing_idx]), Point(x, crossings[crossing_idx + 1]));
+            addLine(Point(x, cutList[scanline_idx][i]), Point(x, cutList[scanline_idx][i+1]));
         }
         scanline_idx += 1;
     }
 }
 
-void Infill::generateLineInfill(Polygons& result, int line_distance, const double& fill_angle)
+/*!
+ * generate lines within the area of \p in_outline, at regular intervals of \p lineSpacing
+ * 
+ * idea:
+ * intersect a regular grid of 'scanlines' with the area inside \p in_outline
+ * 
+ * we call the areas between two consecutive scanlines a 'scansegment'.
+ * Scansegment x is the area between scanline x and scanline x+1
+ * 
+ * algorithm:
+ * 1) for each line segment of each polygon:
+ *      store the intersections of that line segment with all scanlines in a mapping (vector of vectors) from scanline to intersections
+ *      (zigzag): add boundary segments to result
+ * 2) for each scanline:
+ *      sort the associated intersections 
+ *      and connect them using the even-odd rule
+ * 
+ */
+void generateLineInfill(const Polygons& in_outline, int outlineOffset, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation)
 {
-    PointMatrix rotation_matrix(fill_angle);
-    NoZigZagConnectorProcessor lines_processor(rotation_matrix, result);
-    bool connected_zigzags = false;
-    bool safe_outline_offset = false;
-    generateLinearBasedInfill(outline_offset, safe_outline_offset, result, line_distance, rotation_matrix, lines_processor, connected_zigzags);
+    if (lineSpacing == 0) return;
+    if (in_outline.size() == 0) return;
+    Polygons outline = ((outlineOffset)? in_outline.offset(outlineOffset) : in_outline).offset(extrusionWidth * infillOverlap / 100);
+    if (outline.size() == 0) return;
+    
+    PointMatrix matrix(rotation);
+    
+    outline.applyMatrix(matrix);
+
+    
+    AABB boundary(outline);
+    
+    int scanline_min_idx = boundary.min.X / lineSpacing;
+    int lineCount = (boundary.max.X + (lineSpacing - 1)) / lineSpacing - scanline_min_idx;
+  
+    std::vector<std::vector<int64_t> > cutList; // mapping from scanline to all intersections with polygon segments
+    
+    for(int n=0; n<lineCount; n++)
+        cutList.push_back(std::vector<int64_t>());
+    
+    for(unsigned int poly_idx=0; poly_idx < outline.size(); poly_idx++)
+    {
+        Point p0 = outline[poly_idx][outline[poly_idx].size()-1];
+        for(unsigned int i=0; i < outline[poly_idx].size(); i++)
+        {
+            Point p1 = outline[poly_idx][i];
+            int64_t xMin = p1.X, xMax = p0.X;
+            if (xMin == xMax) {
+                p0 = p1;
+                continue; 
+            }
+            if (xMin > xMax) { xMin = p0.X; xMax = p1.X; }
+            
+            int scanline_idx0 = (p0.X + ((p0.X > 0)? -1 : -lineSpacing)) / lineSpacing; // -1 cause a linesegment on scanline x counts as belonging to scansegment x-1   ...
+            int scanline_idx1 = (p1.X + ((p1.X > 0)? -1 : -lineSpacing)) / lineSpacing; // -linespacing because a line between scanline -n and -n-1 belongs to scansegment -n-1 (for n=positive natural number)
+            int direction = 1;
+            if (p0.X > p1.X) 
+            { 
+                direction = -1; 
+                scanline_idx1 += 1; // only consider the scanlines in between the scansegments
+            } else scanline_idx0 += 1; // only consider the scanlines in between the scansegments
+            
+            for(int scanline_idx = scanline_idx0; scanline_idx != scanline_idx1+direction; scanline_idx+=direction)
+            {
+                int x = scanline_idx * lineSpacing;
+                int y = p1.Y + (p0.Y - p1.Y) * (x - p1.X) / (p0.X - p1.X);
+                cutList[scanline_idx - scanline_min_idx].push_back(y);
+            }
+            p0 = p1;
+        }
+    }
+    
+    addLineInfill(result, matrix, scanline_min_idx, lineSpacing, boundary, cutList, extrusionWidth);
 }
 
 
-void Infill::generateZigZagInfill(Polygons& result, const int line_distance, const double& fill_angle, const bool connected_zigzags, const bool use_endpieces)
+void generateZigZagInfill(const Polygons& in_outline, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation, bool connect_zigzags, bool use_endPieces)
 {
-    bool safe_outline_offset = true;
-
-    PointMatrix rotation_matrix(fill_angle);
-    if (use_endpieces)
-    {
-        if (connected_zigzags)
-        {
-            ZigzagConnectorProcessorConnectedEndPieces zigzag_processor(rotation_matrix, result);
-            generateLinearBasedInfill(outline_offset - infill_line_width / 2, safe_outline_offset, result, line_distance, rotation_matrix, zigzag_processor, connected_zigzags);
-        }
-        else
-        {
-            ZigzagConnectorProcessorDisconnectedEndPieces zigzag_processor(rotation_matrix, result);
-            generateLinearBasedInfill(outline_offset - infill_line_width / 2, safe_outline_offset, result, line_distance, rotation_matrix, zigzag_processor, connected_zigzags);
-        }
-    }
-    else 
-    {
-        ZigzagConnectorProcessorNoEndPieces zigzag_processor(rotation_matrix, result);
-        generateLinearBasedInfill(outline_offset - infill_line_width / 2, safe_outline_offset, result, line_distance, rotation_matrix, zigzag_processor, connected_zigzags);
-    }
+    if (use_endPieces) return generateZigZagIninfill_endPieces(in_outline, result, extrusionWidth, lineSpacing, infillOverlap, rotation, connect_zigzags);
+    else return generateZigZagIninfill_noEndPieces(in_outline, result, extrusionWidth, lineSpacing, infillOverlap, rotation);
 }
 
-/* 
+/*!
+ * adapted from generateLineInfill(.)
+ * 
+ * generate lines within the area of [in_outline], at regular intervals of [lineSpacing]
+ * idea:
+ * intersect a regular grid of 'scanlines' with the area inside [in_outline]
+ * sigzag:
+ * include pieces of boundary, connecting the lines, forming an accordion like zigzag instead of separate lines    |_|^|_|
+ * 
+ * we call the areas between two consecutive scanlines a 'scansegment'
+ * 
  * algorithm:
  * 1. for each line segment of each polygon:
  *      store the intersections of that line segment with all scanlines in a mapping (vector of vectors) from scanline to intersections
@@ -144,119 +239,288 @@ void Infill::generateZigZagInfill(Polygons& result, const int line_distance, con
  *      sort the associated intersections 
  *      and connect them using the even-odd rule
  * 
- * rough explanation of the zigzag algorithm:
+ * zigzag algorithm:
  * while walking around (each) polygon (1.)
  *  if polygon intersects with even scanline
  *      start boundary segment (add each following segment to the [result])
  *  when polygon intersects with a scanline again
  *      stop boundary segment (stop adding segments to the [result])
- *  (see infill/ZigzagConnectorProcessor.h for actual implementation details)
+ *      if polygon intersects with even scanline again (instead of odd)
+ *          dont add the last line segment to the boundary (unless [connect_zigzags])
  * 
  * 
- * we call the areas between two consecutive scanlines a 'scansegment'.
- * Scansegment x is the area between scanline x and scanline x+1
- * Edit: the term scansegment is wrong, since I call a boundary segment leaving from an even scanline to the left as belonging to an even scansegment, 
- *  while I also call a boundary segment leaving from an even scanline toward the right as belonging to an even scansegment.
+ *     <--
+ *     ___
+ *    |   |   |
+ *    |   |   |
+ *    |   |___|
+ *         -->
+ * 
+ *        ^ = even scanline
+ * 
+ * start boundary from even scanline! :D
+ * 
+ * 
+ *          _____
+ *   |     |     | ,
+ *   |     |     |  |
+ *   |_____|     |__/
+ * 
+ *   ^     ^     ^    scanlines
+ *                 ^  disconnected end piece
  */
-void Infill::generateLinearBasedInfill(const int outline_offset, bool safe_outline_offset, Polygons& result, const int line_distance, const PointMatrix& rotation_matrix, ZigzagConnectorProcessor& zigzag_connector_processor, const bool connected_zigzags)
+void generateZigZagIninfill_endPieces(const Polygons& in_outline, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation, bool connect_zigzags)
 {
-    if (line_distance == 0)
-    {
-        return;
-    }
-    if (in_outline.size() == 0)
-    {
-        return;
-    }
+//     if (in_outline.size() == 0) return;
+//     Polygons outline = in_outline.offset(extrusionWidth * infillOverlap / 100 - extrusionWidth / 2);
+    Polygons empty;
+    Polygons outline = in_outline.difference(empty); // copy
+    if (outline.size() == 0) return;
     
-    Polygons outline;
-    if (outline_offset != 0)
-    {
-        outline = in_outline.offset(outline_offset);
-    }
-    else
-    {
-        outline = in_outline;
-    }
+    PointMatrix matrix(rotation);
     
-        outline = outline.offset(infill_overlap);
+    outline.applyMatrix(matrix);
     
-    if (outline.size() == 0)
-    {
-        return;
-    }
-
-    outline.applyMatrix(rotation_matrix);
-
+    auto addLine = [&](Point from, Point to)
+    {            
+        PolygonRef p = result.newPoly();
+        p.add(matrix.unapply(from));
+        p.add(matrix.unapply(to));
+    };   
+        
     AABB boundary(outline);
-
-    int scanline_min_idx = boundary.min.X / line_distance;
-    int line_count = (boundary.max.X + (line_distance - 1)) / line_distance - scanline_min_idx;
-
-    std::vector<std::vector<int64_t> > cut_list; // mapping from scanline to all intersections with polygon segments
-
-    for(int scanline_idx = 0; scanline_idx < line_count; scanline_idx++)
+    
+    int scanline_min_idx = boundary.min.X / lineSpacing;
+    int lineCount = (boundary.max.X + (lineSpacing - 1)) / lineSpacing - scanline_min_idx;
+    
+    std::vector<std::vector<int64_t> > cutList; // mapping from scanline to all intersections with polygon segments
+    
+    for(int n=0; n<lineCount; n++)
+        cutList.push_back(std::vector<int64_t>());
+    for(unsigned int polyNr=0; polyNr < outline.size(); polyNr++)
     {
-        cut_list.push_back(std::vector<int64_t>());
-    }
-
-    for(unsigned int poly_idx = 0; poly_idx < outline.size(); poly_idx++)
-    {
-        PolygonRef poly = outline[poly_idx];
-        Point p0 = poly.back();
-        zigzag_connector_processor.registerVertex(p0); // always adds the first point to ZigzagConnectorProcessorEndPieces::first_zigzag_connector when using a zigzag infill type
-        for(unsigned int point_idx = 0; point_idx < poly.size(); point_idx++)
+        std::vector<Point> firstBoundarySegment;
+        std::vector<Point> unevenBoundarySegment; // stored cause for connected_zigzags a boundary segment which ends in an uneven scanline needs to be included
+        
+        bool isFirstBoundarySegment = true;
+        bool firstBoundarySegmentEndsInEven;
+        
+        bool isEvenScanSegment = false; 
+        
+        
+        Point p0 = outline[polyNr][outline[polyNr].size()-1];
+        Point lastPoint = p0;
+        for(unsigned int i=0; i < outline[polyNr].size(); i++)
         {
-            Point p1 = poly[point_idx];
-            if (p1.X == p0.X)
-            {
-                zigzag_connector_processor.registerVertex(p1); 
-                // TODO: how to make sure it always adds the shortest line? (in order to prevent overlap with the zigzag connectors)
-                // note: this is already a problem for normal infill, but hasn't really cothered anyone so far.
+            Point p1 = outline[polyNr][i];
+            int64_t xMin = p1.X, xMax = p0.X;
+            if (xMin == xMax) {
+                lastPoint = p1;
                 p0 = p1;
                 continue; 
             }
-
-            int scanline_idx0 = (p0.X + ((p0.X > 0)? -1 : -line_distance)) / line_distance; // -1 cause a linesegment on scanline x counts as belonging to scansegment x-1   ...
-            int scanline_idx1 = (p1.X + ((p1.X > 0)? -1 : -line_distance)) / line_distance; // -linespacing because a line between scanline -n and -n-1 belongs to scansegment -n-1 (for n=positive natural number)
-            // this way of handling the indices takes care of the case where a boundary line segment ends exactly on a scanline:
-            // in case the next segment moves back from that scanline either 2 or 0 scanline-boundary intersections are created
-            // otherwise only 1 will be created, counting as an actual intersection
+            if (xMin > xMax) { xMin = p0.X; xMax = p1.X; }
+            
+            int scanline_idx0 = (p0.X + ((p0.X > 0)? -1 : -lineSpacing)) / lineSpacing; // -1 cause a linesegment on scanline x counts as belonging to scansegment x-1   ...
+            int scanline_idx1 = (p1.X + ((p1.X > 0)? -1 : -lineSpacing)) / lineSpacing; // -linespacing because a line between scanline -n and -n-1 belongs to scansegment -n-1 (for n=positive natural number)
             int direction = 1;
             if (p0.X > p1.X) 
             { 
                 direction = -1; 
                 scanline_idx1 += 1; // only consider the scanlines in between the scansegments
-            }
-            else
+            } else scanline_idx0 += 1; // only consider the scanlines in between the scansegments
+            
+            
+            if (isFirstBoundarySegment) firstBoundarySegment.push_back(p0);
+            for(int scanline_idx = scanline_idx0; scanline_idx != scanline_idx1+direction; scanline_idx+=direction)
             {
-                scanline_idx0 += 1; // only consider the scanlines in between the scansegments
-            }
-
-            for(int scanline_idx = scanline_idx0; scanline_idx != scanline_idx1 + direction; scanline_idx += direction)
-            {
-                int x = scanline_idx * line_distance;
+                int x = scanline_idx * lineSpacing;
                 int y = p1.Y + (p0.Y - p1.Y) * (x - p1.X) / (p0.X - p1.X);
-                cut_list[scanline_idx - scanline_min_idx].push_back(y);
-                Point scanline_linesegment_intersection(x, y);
-                zigzag_connector_processor.registerScanlineSegmentIntersection(scanline_linesegment_intersection, scanline_idx % 2 == 0);
+                cutList[scanline_idx - scanline_min_idx].push_back(y);
+                
+                
+                bool last_isEvenScanSegment = isEvenScanSegment;
+                if (scanline_idx % 2 == 0) isEvenScanSegment = true;
+                else isEvenScanSegment = false;
+                
+                if (!isFirstBoundarySegment)
+                {
+                    if (last_isEvenScanSegment && (connect_zigzags || !isEvenScanSegment))
+                        addLine(lastPoint, Point(x,y));
+                    else if (connect_zigzags && !last_isEvenScanSegment && !isEvenScanSegment) // if we end an uneven boundary in an uneven segment
+                    { // add whole unevenBoundarySegment (including the just obtained point)
+                        for (unsigned int p = 1; p < unevenBoundarySegment.size(); p++)
+                        {
+                            addLine(unevenBoundarySegment[p-1], unevenBoundarySegment[p]);
+                        }
+                        addLine(unevenBoundarySegment[unevenBoundarySegment.size()-1], Point(x,y));
+                        unevenBoundarySegment.clear();
+                    } 
+                    if (connect_zigzags && last_isEvenScanSegment && !isEvenScanSegment)
+                        unevenBoundarySegment.push_back(Point(x,y));
+                    else 
+                        unevenBoundarySegment.clear();
+                        
+                }
+                lastPoint = Point(x,y);
+                
+                if (isFirstBoundarySegment) 
+                {
+                    firstBoundarySegment.emplace_back(x,y);
+                    firstBoundarySegmentEndsInEven = isEvenScanSegment;
+                    isFirstBoundarySegment = false;
+                }
+                
             }
-            zigzag_connector_processor.registerVertex(p1);
+            if (!isFirstBoundarySegment)
+            {
+                if (isEvenScanSegment)
+                    addLine(lastPoint, p1);
+                else if (connect_zigzags)
+                    unevenBoundarySegment.push_back(p1);
+            }
+            
+            lastPoint = p1;
             p0 = p1;
         }
-        zigzag_connector_processor.registerPolyFinished();
-    }
-
-    if (cut_list.size() == 0)
-    {
-        return;
-    }
-    if (connected_zigzags && cut_list.size() == 1 && cut_list[0].size() <= 2)
-    {
-        return;  // don't add connection if boundary already contains whole outline!
-    }
-
-    addLineInfill(result, rotation_matrix, scanline_min_idx, line_distance, boundary, cut_list);
+        
+        if (isEvenScanSegment || isFirstBoundarySegment || connect_zigzags)
+        {
+            for (unsigned int i = 1; i < firstBoundarySegment.size() ; i++)
+            {
+                if (i < firstBoundarySegment.size() - 1 || !firstBoundarySegmentEndsInEven || connect_zigzags) // only add last element if connect_zigzags or boundary segment ends in uneven scanline
+                    addLine(firstBoundarySegment[i-1], firstBoundarySegment[i]);
+            }   
+        }
+        else if (!firstBoundarySegmentEndsInEven)
+            addLine(firstBoundarySegment[firstBoundarySegment.size()-2], firstBoundarySegment[firstBoundarySegment.size()-1]);
+    } 
+    
+    if (cutList.size() == 0) return;
+    if (connect_zigzags && cutList.size() == 1 && cutList[0].size() <= 2) return;  // don't add connection if boundary already contains whole outline!
+    
+    addLineInfill(result, matrix, scanline_min_idx, lineSpacing, boundary, cutList, extrusionWidth);
 }
 
+
+void generateZigZagIninfill_noEndPieces(const Polygons& in_outline, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation)
+{
+    if (in_outline.size() == 0) return;
+    Polygons outline = in_outline.offset(extrusionWidth * infillOverlap / 100 - extrusionWidth / 2);
+    if (outline.size() == 0) return;
+    
+    PointMatrix matrix(rotation);
+    
+    outline.applyMatrix(matrix);
+    
+    auto addLine = [&](Point from, Point to)
+    {            
+        PolygonRef p = result.newPoly();
+        p.add(matrix.unapply(from));
+        p.add(matrix.unapply(to));
+    };   
+        
+    AABB boundary(outline);
+    
+    int scanline_min_idx = boundary.min.X / lineSpacing;
+    int lineCount = (boundary.max.X + (lineSpacing - 1)) / lineSpacing - scanline_min_idx;
+    
+    std::vector<std::vector<int64_t> > cutList; // mapping from scanline to all intersections with polygon segments
+    
+    for(int n=0; n<lineCount; n++)
+        cutList.push_back(std::vector<int64_t>());
+    for(unsigned int polyNr=0; polyNr < outline.size(); polyNr++)
+    {
+        std::vector<Point> firstBoundarySegment;
+        std::vector<Point> boundarySegment;
+        
+        bool isFirstBoundarySegment = true;
+        bool firstBoundarySegmentEndsInEven;
+        
+        bool isEvenScanSegment = false; 
+        
+        
+        Point p0 = outline[polyNr][outline[polyNr].size()-1];
+        for(unsigned int i=0; i < outline[polyNr].size(); i++)
+        {
+            Point p1 = outline[polyNr][i];
+            int64_t xMin = p1.X, xMax = p0.X;
+            if (xMin == xMax) {
+                p0 = p1;
+                continue; 
+            }
+            if (xMin > xMax) { xMin = p0.X; xMax = p1.X; }
+            
+            int scanline_idx0 = (p0.X + ((p0.X > 0)? -1 : -lineSpacing)) / lineSpacing; // -1 cause a linesegment on scanline x counts as belonging to scansegment x-1   ...
+            int scanline_idx1 = (p1.X + ((p1.X > 0)? -1 : -lineSpacing)) / lineSpacing; // -linespacing because a line between scanline -n and -n-1 belongs to scansegment -n-1 (for n=positive natural number)
+            int direction = 1;
+            if (p0.X > p1.X) 
+            { 
+                direction = -1; 
+                scanline_idx1 += 1; // only consider the scanlines in between the scansegments
+            } else scanline_idx0 += 1; // only consider the scanlines in between the scansegments
+            
+            
+            if (isFirstBoundarySegment) firstBoundarySegment.push_back(p0);
+            else boundarySegment.push_back(p0);
+            for(int scanline_idx = scanline_idx0; scanline_idx != scanline_idx1+direction; scanline_idx+=direction)
+            {
+                int x = scanline_idx * lineSpacing;
+                int y = p1.Y + (p0.Y - p1.Y) * (x - p1.X) / (p0.X - p1.X);
+                cutList[scanline_idx - scanline_min_idx].push_back(y);
+                
+                
+                bool last_isEvenScanSegment = isEvenScanSegment;
+                if (scanline_idx % 2 == 0) isEvenScanSegment = true;
+                else isEvenScanSegment = false;
+                
+                if (!isFirstBoundarySegment)
+                {
+                    if (last_isEvenScanSegment && !isEvenScanSegment)
+                    { // add whole boundarySegment (including the just obtained point)
+                        for (unsigned int p = 1; p < boundarySegment.size(); p++)
+                        {
+                            addLine(boundarySegment[p-1], boundarySegment[p]);
+                        }
+                        addLine(boundarySegment[boundarySegment.size()-1], Point(x,y));
+                        boundarySegment.clear();
+                    } 
+                    else if (isEvenScanSegment) // we are either in an end piece or an uneven boundary segment
+                    {
+                        boundarySegment.clear();
+                        boundarySegment.emplace_back(x,y);
+                    } else
+                        boundarySegment.clear();
+                        
+                }
+                
+                if (isFirstBoundarySegment) 
+                {
+                    firstBoundarySegment.emplace_back(x,y);
+                    firstBoundarySegmentEndsInEven = isEvenScanSegment;
+                    isFirstBoundarySegment = false;
+                    boundarySegment.emplace_back(x,y);
+                }
+                
+            }
+            if (!isFirstBoundarySegment && isEvenScanSegment)
+                boundarySegment.push_back(p1);
+            
+            
+            p0 = p1;
+        }
+        
+        if (!isFirstBoundarySegment && isEvenScanSegment && !firstBoundarySegmentEndsInEven)
+        {
+            for (unsigned int i = 1; i < firstBoundarySegment.size() ; i++)
+                addLine(firstBoundarySegment[i-1], firstBoundarySegment[i]);
+        }
+    } 
+    
+
+    addLineInfill(result, matrix, scanline_min_idx, lineSpacing, boundary, cutList, extrusionWidth);
+
+}
+
+
 }//namespace cura

src/infill.h

@@ -3,169 +3,49 @@
 #define INFILL_H
 
 #include "utils/polygon.h"
-#include "settings/settings.h"
-// #include "ZigzagConnectorProcessor.h"
-#include "infill/ZigzagConnectorProcessor.h"
-#include "infill/NoZigZagConnectorProcessor.h"
-#include "infill/ActualZigzagConnectorProcessor.h"
-#include "infill/ZigzagConnectorProcessorNoEndPieces.h"
-#include "infill/ZigzagConnectorProcessorEndPieces.h"
-#include "infill/ZigzagConnectorProcessorConnectedEndPieces.h"
-#include "infill/ZigzagConnectorProcessorDisconnectedEndPieces.h"
-#include "utils/intpoint.h"
-#include "utils/AABB.h"
+#include "settings.h"
 
-namespace cura
-{
+namespace cura {
 
 class Infill 
 {
-    EFillMethod pattern; //!< the space filling pattern of the infill to generate
-    const Polygons& in_outline; //!< a reference polygon for getting the actual area within which to generate infill (see outline_offset)
-    int outline_offset; //!< Offset from Infill::in_outline to get the actual area within which to generate infill
-    int infill_line_width; //!< The line width of the infill lines to generate
-    int line_distance; //!< The distance between two infill lines / polygons
-    int infill_overlap; //!< the distance by which to overlap with the actual area within which to generate infill
-    double fill_angle; //!< for linear infill types: the angle of the infill lines (or the angle of the grid)
-    bool connected_zigzags; //!< (ZigZag) Whether endpieces of zigzag infill should be connected to the nearest infill line on both sides of the zigzag connector
-    bool use_endpieces; //!< (ZigZag) Whether to include endpieces: zigzag connector segments from one infill line to itself
+    EFillMethod pattern;
+    const Polygons& in_outline;
+    int outlineOffset;
+    bool avoidOverlappingPerimeters;
+    int extrusion_width;
+    int line_distance;
+    double infill_overlap;
+    double fill_angle;
+    bool connect_zigzags;
+    bool use_endPieces;
 
 public:
-    Infill(EFillMethod pattern, const Polygons& in_outline, int outline_offset, int infill_line_width, int line_distance, int infill_overlap, double fill_angle, bool connected_zigzags = false, bool use_endpieces = false)
+    Infill(EFillMethod pattern, const Polygons& in_outline, int outlineOffset, bool avoidOverlappingPerimeters, int extrusion_width, int line_distance, double infill_overlap, double fill_angle, bool connect_zigzags, bool use_endPieces)
     : pattern(pattern)
     , in_outline(in_outline)
-    , outline_offset(outline_offset)
-    , infill_line_width(infill_line_width)
+    , outlineOffset(outlineOffset)
+    , avoidOverlappingPerimeters(avoidOverlappingPerimeters)
+    , extrusion_width(extrusion_width)
     , line_distance(line_distance)
     , infill_overlap(infill_overlap)
     , fill_angle(fill_angle)
-    , connected_zigzags(connected_zigzags)
-    , use_endpieces(use_endpieces)
+    , connect_zigzags(connect_zigzags)
+    , use_endPieces(use_endPieces)
     {
     }
-    /*!
-     * Generate the infill.
-     * 
-     * \param result_polygons (output) The resulting polygons (from concentric infill)
-     * \param result_lines (output) The resulting line segments (from linear infill types)
-     */
-    void generate(Polygons& result_polygons, Polygons& result_lines);
-
-private:
-
-    /*!
-     * Generate sparse concentric infill 
-     * \param outline The actual outline of the area within which to generate infill
-     * \param result (output) The resulting polygons
-     * \param inset_value The offset between each consecutive two polygons
-     */
-    void generateConcentricInfill(Polygons outline, Polygons& result, int inset_value);
-
-    /*!
-     * Generate a rectangular grid of infill lines
-     * \param result (output) The resulting lines
-     */
-    void generateGridInfill(Polygons& result);
-
-    /*!
-     * Generate a triangular grid of infill lines
-     * \param result (output) The resulting lines
-     */
-    void generateTriangleInfill(Polygons& result);
-    
-    /*!
-     * Convert a mapping from scanline to line_segment-scanline-intersections (\p cut_list) into line segments, using the even-odd rule
-     * \param result (output) The resulting lines
-     * \param rotation_matrix The rotation matrix (un)applied to enforce the angle of the infill 
-     * \param scanline_min_idx The lowest index of all scanlines crossing the polygon
-     * \param line_distance The distance between two lines which are in the same direction
-     * \param boundary The axis aligned boundary box within which the polygon is
-     * \param cut_list A mapping of each scanline to all y-coordinates (in the space transformed by rotation_matrix) where the polygons are crossing the scanline
-     */
-    void addLineInfill(Polygons& result, const PointMatrix& rotation_matrix, const int scanline_min_idx, const int line_distance, const AABB boundary, std::vector<std::vector<int64_t>>& cut_list);
-
-    /*!
-     * generate lines within the area of \p in_outline, at regular intervals of \p line_distance
-     * 
-     * idea:
-     * intersect a regular grid of 'scanlines' with the area inside \p in_outline
-     * 
-     * \param result (output) The resulting lines
-     * \param line_distance The distance between two lines which are in the same direction
-     * \param fill_angle The angle of the generated lines
-     */
-    void generateLineInfill(Polygons& result, int line_distance, const double& fill_angle);
-    
-    /*!
-     * Function for creating linear based infill types (Lines, ZigZag).
-     * 
-     * This function implements the basic functionality of Infill::generateLineInfill (see doc of that function),
-     * but makes calls to a ZigzagConnectorProcessor which handles what to do with each line segment - scanline intersection.
-     * 
-     * It is called only from Infill::generateLineinfill and Infill::generateZigZagInfill.
-     * 
-     * \param outline_offset An offset from the reference polygon (Infill::in_outline) to get the actual outline within which to generate infill
-     * \param safe_outline_offset Whether to consider removing overlapping wall parts (not so for normal line infill)
-     * \param result (output) The resulting lines
-     * \param line_distance The distance between two lines which are in the same direction
-     * \param rotation_matrix The rotation matrix (un)applied to enforce the angle of the infill 
-     * \param zigzag_connector_processor The processor used to generate zigzag connectors
-     * \param connected_zigzags Whether to connect the endpiece zigzag segments on both sides to the same infill line
-     */
-    void generateLinearBasedInfill(const int outline_offset, bool safe_outline_offset, Polygons& result, const int line_distance, const PointMatrix& rotation_matrix, ZigzagConnectorProcessor& zigzag_connector_processor, const bool connected_zigzags);
-
-    /*!
-     * 
-     * generate lines within the area of [in_outline], at regular intervals of [line_distance]
-     * idea:
-     * intersect a regular grid of 'scanlines' with the area inside [in_outline] (see generateLineInfill)
-     * zigzag:
-     * include pieces of boundary, connecting the lines, forming an accordion like zigzag instead of separate lines    |_|^|_|
-     * 
-     * Note that ZigZag consists of 3 types:
-     * - without endpieces
-     * - with disconnected endpieces
-     * - with connected endpieces
-     * 
-     *     <--
-     *     ___
-     *    |   |   |
-     *    |   |   |
-     *    |   |___|
-     *         -->
-     * 
-     *        ^ = even scanline
-     *  ^            ^ no endpieces
-     * 
-     * start boundary from even scanline! :D
-     * 
-     * 
-     *                 v  disconnected end piece: leave out last line segment
-     *          _____
-     *   |     |     |  \                     .
-     *   |     |     |  |
-     *   |_____|     |__/
-     * 
-     *   ^     ^     ^    scanlines
-     * 
-     * 
-     *                 v  connected end piece
-     *          ________
-     *   |     |     |  \                      .
-     *   |     |     |  |
-     *   |_____|     |__/                       .
-     * 
-     *   ^     ^     ^    scanlines
-     * 
-     * \param result (output) The resulting lines
-     * \param line_distance The distance between two lines which are in the same direction
-     * \param fill_angle The angle of the generated lines
-     * \param connected_zigzags Whether to connect the endpiece zigzag segments on both sides to the same infill line
-     * \param use_endpieces Whether to include zigzag segments connecting a scanline to itself
-     */
-    void generateZigZagInfill(Polygons& result, const int line_distance, const double& fill_angle, const bool connected_zigzags, const bool use_endpieces);
+    void generate(Polygons& result_polygons, Polygons& result_lines, Polygons* in_between);
 };
-
+    
+void generateInfill(EFillMethod pattern, const Polygons& in_outline, int outlineOffset, Polygons& result_polygons, Polygons& result_lines, Polygons* in_between, bool avoidOverlappingPerimeters, int extrusion_width, int line_distance, double infill_overlap, double fill_angle, bool connect_zigzags, bool use_endPieces);
+void generateConcentricInfill(Polygons outline, Polygons& result, int inset_value);
+void generateConcentricInfillDense(Polygons outline, Polygons& result, Polygons* in_between, int extrusionWidth, bool avoidOverlappingPerimeters);
+void generateGridInfill(const Polygons& in_outline, int outlineOffset, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation);
+void generateTriangleInfill(const Polygons& in_outline, int outlineOffset, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation);
+void generateLineInfill(const Polygons& in_outline, int outlineOffset, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation);
+void generateZigZagInfill(const Polygons& in_outline, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation, bool connect_zigzags, bool use_endPieces);
+void generateZigZagIninfill_endPieces(const Polygons& in_outline, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation, bool connect_zigzags);
+void generateZigZagIninfill_noEndPieces(const Polygons& in_outline, Polygons& result, int extrusionWidth, int lineSpacing, double infillOverlap, double rotation);
 }//namespace cura
 
 #endif//INFILL_H

src/infill/ActualZigzagConnectorProcessor.h

@@ -1,47 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_ACTUAL_ZIGZAG_CONNECTOR_PROCESSOR_H
-#define INFILL_ACTUAL_ZIGZAG_CONNECTOR_PROCESSOR_H
-
-
-#include "../utils/polygon.h"
-#include "ZigzagConnectorProcessor.h"
-#include "../utils/intpoint.h"
-
-namespace cura
-{
-
-/*!
- * In contrast to NoZigZagConnectorProcessor
- */
-class ActualZigzagConnectorProcessor : public ZigzagConnectorProcessor
-{
-protected:
-    /*!
-     * The line segments belonging the zigzag connector to which the very first vertex belongs. 
-     * This will be combined with the last handled zigzag_connector, which combine to a whole zigzag connector.
-     * 
-     * Because the boundary polygon may start in in the middle of a zigzag connector, 
-     */
-    std::vector<Point> first_zigzag_connector; 
-    /*!
-     * The currently built up zigzag connector (not the first/last) or end piece or discarded boundary segment
-     */
-    std::vector<Point> zigzag_connector; 
-
-    bool is_first_zigzag_connector; //!< Whether we're still in the first zigzag connector
-    bool first_zigzag_connector_ends_in_even_scanline; //!< Whether the first zigzag connector ends in an even scanline
-    bool last_scanline_is_even;  //!< Whether the last seen scanline-boundary intersection was with an even scanline
-
-    ActualZigzagConnectorProcessor(const PointMatrix& rotation_matrix, Polygons& result)
-    : ZigzagConnectorProcessor(rotation_matrix, result)
-    , is_first_zigzag_connector(true)
-    , first_zigzag_connector_ends_in_even_scanline(true)
-    , last_scanline_is_even(false) 
-    {
-    }
-};
-
-} // namespace cura
-
-
-#endif // INFILL_ACTUAL_ZIGZAG_CONNECTOR_PROCESSOR_H

src/infill/NoZigZagConnectorProcessor.cpp

@@ -1,25 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "NoZigZagConnectorProcessor.h"
-
-
-namespace cura 
-{
-
-void NoZigZagConnectorProcessor::registerVertex(const Point& vertex)
-{
-
-}
-
-void NoZigZagConnectorProcessor::registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even)
-{
-
-}
-
-void NoZigZagConnectorProcessor::registerPolyFinished()
-{
-
-}
-
-
-
-} // namespace cura 

src/infill/NoZigZagConnectorProcessor.h

@@ -1,28 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_NO_ZIGZAG_CONNECTOR_PROCESSOR_H
-#define INFILL_NO_ZIGZAG_CONNECTOR_PROCESSOR_H
-
-#include "../utils/polygon.h"
-#include "ZigzagConnectorProcessor.h"
-
-namespace cura
-{
-
-class NoZigZagConnectorProcessor : public ZigzagConnectorProcessor
-{
-public:
-    NoZigZagConnectorProcessor(const PointMatrix& rotation_matrix, Polygons& result)
-    : ZigzagConnectorProcessor(rotation_matrix, result)
-    {
-    }
-
-    void registerVertex(const Point& vertex);
-    void registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even);
-    void registerPolyFinished();
-};
-
-
-} // namespace cura
-
-
-#endif // INFILL_NO_ZIGZAG_CONNECTOR_PROCESSOR_H

src/infill/ZigzagConnectorProcessor.h

@@ -1,154 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_ZIGZAG_CONNECTOR_PROCESSOR_H
-#define INFILL_ZIGZAG_CONNECTOR_PROCESSOR_H
-
-#include "../utils/polygon.h"
-
-namespace cura
-{
-
-/*!
- * Processor class for processing the connections between lines which makes the infill a zigzag pattern.
- * 
- * During the creation of the infill lines, calls are made to a ZigzagConnectorProcessor so that the zigzag connector segments are created 
- * at the same time as the lines are created.
- *
- * generate lines within the area of [in_outline], at regular intervals of [line_distance]
- *  idea:
- * intersect a regular grid of 'scanlines' with the area inside [in_outline] (see generateLineInfill)
- * zigzag:
- * include pieces of boundary, connecting the lines, forming an accordion like zigzag instead of separate lines    |_|^|_|
- * 
- * we call the areas between two consecutive scanlines a 'scansegment'
- * 
- * algorithm:
- * 1. for each line segment of each polygon:
- *      store the intersections of that line segment with all scanlines in a mapping (vector of vectors) from scanline to intersections
- *      (zigzag): add boundary segments to result
- * 2. for each scanline:
- *      sort the associated intersections 
- *      and connect them using the even-odd rule
- * 
- * zigzag algorithm:
- *  while walking around (each) polygon (1.)
- *  if polygon intersects with even scanline
- *      start boundary segment (add each following segment to the [result])
- *  when polygon intersects with a scanline again
- *      stop boundary segment (stop adding segments to the [result])
- *      if polygon intersects with even scanline again (instead of odd)
- *           dont add the last line segment to the boundary (unless [connected_zigzags])
- * 
- * Note that ZigZag consists of 3 types:
- * - without endpieces
- * - with disconnected endpieces
- * - with connected endpieces
- * 
- * Each of these has a base class for which ZigzagConnectorProcessor is an ancestor.
- * The inheritance structure is as such:
- *                                                                      ZigzagConnectorProcessor
- *                                                                           /             \                                    .
- *                                                                          /               \                                   .
- *                                                  ActualZigzagConnectorProcessor      NoZigZagConnectorProcessor
- *                                                         /                \             for lines infill                                      .
- *                                                        /                  \                                                  .
- *                          ZigzagConnectorProcessorEndPieces   ZigzagConnectorProcessorNoEndPieces
- *                                     /            \                 for zigzag infill (without end pieces)                                                          .
- *                                    /              \                                                                          .
- * ZigzagConnectorProcessorConnectedEndPieces     ZigzagConnectorProcessorDisconnectedEndPieces
- * for zigzag support with normal endpieces          for zigzag support with disconnected endpieces for more easy removability
- * 
- *      v   v   zigzag connectors
- *     <--
- *    :___:   :      < scanlines
- *    |   |   |
- *    |   |   |      < infill lines along scanlines
- *    |   |___|
- *    :   :   :
- *         -->       winding order of polygon
- * 
- *        ^ = even scanline
- *  ^            ^ no endpieces
- * 
- * start boundary from even scanline! :D
- * include only a boundary segment if it starts in an even scanline and ends in an odd scanline
- * 
- *          ________
- *   |     |     |  \                      .
- *   |     |     |  |
- *   |_____|     |__/                       .
- * 
- *   ^     ^     ^    scanlines
- *                 ^  connected end piece
- * include a boundary segment also if it starts in an odd scanline and ends odd, 
- * or starts in an even scanline and ends in an even scanline,
- * but not when it starts in an odd and ends in an even scanline (see top left or bottom middle).
- * 
- *          _____
- *   |     |     |  \                     .
- *   |     |     |  |
- *   |_____|     |__/
- * 
- *   ^     ^     ^    scanlines
- *                 ^  disconnected end piece
- * Leave out the last line segment of the boundary polygon: from a vertex to the linesegment-scanline intersection.
- */
-class ZigzagConnectorProcessor 
-{
-protected:
-    const PointMatrix& rotation_matrix; //!< The rotation matrix used to enforce the infill angle
-    Polygons& result; //!< The result of the computation
-
-    virtual ~ZigzagConnectorProcessor()
-    {}
-
-    /*!
-     * Add a line to the result bu unapplying the rotation rotation_matrix.
-     * 
-     * \param from The one end of the line segment
-     * \param to The other end of the line segment
-     */
-    void addLine(Point from, Point to)
-    {
-        PolygonRef line_poly = result.newPoly();
-        line_poly.add(rotation_matrix.unapply(from));
-        line_poly.add(rotation_matrix.unapply(to));
-    }
-
-    /*!
-     * Basic constructor. Inheriting children should call this constructor.
-     * 
-     * \param rotation_matrix The rotation matrix used to enforce the infill angle
-     * \param result The resulting line segments (Each line segment is a Polygon with 2 points)
-     */
-    ZigzagConnectorProcessor(const PointMatrix& rotation_matrix, Polygons& result)
-    : rotation_matrix(rotation_matrix)
-    , result(result)
-    {}
-public:
-
-    /*!
-     * Handle the next vertex on the outer boundary.
-     * \param vertex The vertex
-     */
-    virtual void registerVertex(const Point& vertex) = 0;
-    
-    /*!
-     * Handle the next intersection between a scanline and the outer boundary.
-     * 
-     * \param intersection The intersection
-     * \param scanline_is_even Whether the scanline was even
-     */
-    virtual void registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even) = 0;
-    
-    /*!
-     * Handle the end of a polygon and prepare for the next.
-     * This function should reset all member variables.
-     */
-    virtual void registerPolyFinished() = 0;
-};
-
-
-} // namespace cura
-
-
-#endif // INFILL_ZIGZAG_CONNECTOR_PROCESSOR_H

src/infill/ZigzagConnectorProcessorConnectedEndPieces.cpp

@@ -1,75 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "ZigzagConnectorProcessorConnectedEndPieces.h"
-
-
-namespace cura 
-{
-
-
-void ZigzagConnectorProcessorConnectedEndPieces::registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even)
-{
-    bool previous_scanline_is_even = last_scanline_is_even;
-    last_scanline_is_even = scanline_is_even;
-    bool this_scanline_is_even = last_scanline_is_even;
-    
-    if (is_first_zigzag_connector)
-    {
-        first_zigzag_connector.push_back(intersection);
-        first_zigzag_connector_ends_in_even_scanline = this_scanline_is_even;
-        is_first_zigzag_connector = false;
-    }
-    else
-    {
-        if (previous_scanline_is_even)
-        { // when a boundary segment starts in an even scanline it is either a normal zigzag connector or an endpiece, so it should be included anyway
-            addLine(last_connector_point, intersection);
-        }
-        else if (!previous_scanline_is_even && !this_scanline_is_even) // if we end an odd boundary in an odd segment
-        { // add whole zigzag_connector (including the just obtained point)
-            for (unsigned int point_idx = 1; point_idx < zigzag_connector.size(); point_idx++)
-            {
-                addLine(zigzag_connector[point_idx - 1], zigzag_connector[point_idx]);
-            }
-            addLine(zigzag_connector.back(), intersection);
-            zigzag_connector.clear();
-        }
-
-    }
-    zigzag_connector.clear(); // we're starting a new (odd) zigzag connector, so clear the old one
-    if (!this_scanline_is_even) // we are either in an end piece or an boundary segment starting in an odd scanline
-    { // only when a boundary segment starts in an odd scanline it depends on whether it ends in an odd scanline for whether this segment should be included or not
-        zigzag_connector.push_back(intersection);
-    }
-
-    last_connector_point = intersection;
-}
-
-
-void ZigzagConnectorProcessorConnectedEndPieces::registerPolyFinished()
-{
-    // write end segment if needed (first half of start/end-crossing segment)
-    if (!last_scanline_is_even && !first_zigzag_connector_ends_in_even_scanline)
-    {
-        for (unsigned int point_idx = 1; point_idx < zigzag_connector.size(); point_idx++)
-        {
-            addLine(zigzag_connector[point_idx - 1], zigzag_connector[point_idx]);
-        }
-    }
-    // write begin segment if needed (second half of start/end-crossing segment)
-    if (last_scanline_is_even || (!last_scanline_is_even && !first_zigzag_connector_ends_in_even_scanline)
-        || is_first_zigzag_connector)
-    {
-        for (unsigned int point_idx = 1; point_idx < first_zigzag_connector.size(); point_idx++)
-        {
-            addLine(first_zigzag_connector[point_idx - 1], first_zigzag_connector[point_idx]);
-        }
-    }
-    // reset member variables
-    is_first_zigzag_connector = true;
-    first_zigzag_connector_ends_in_even_scanline = true;
-    last_scanline_is_even = false; 
-    first_zigzag_connector.clear();
-    zigzag_connector.clear();
-}
-
-} // namespace cura 

src/infill/ZigzagConnectorProcessorConnectedEndPieces.h

@@ -1,27 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_ZIGZAG_CONNECTOR_PROCESSOR_CONNECTED_END_PIECES_H
-#define INFILL_ZIGZAG_CONNECTOR_PROCESSOR_CONNECTED_END_PIECES_H
-
-#include "../utils/polygon.h"
-#include "ZigzagConnectorProcessorEndPieces.h"
-#include "../utils/intpoint.h"
-
-namespace cura
-{
-
-
-class ZigzagConnectorProcessorConnectedEndPieces : public ZigzagConnectorProcessorEndPieces
-{
-public:
-    ZigzagConnectorProcessorConnectedEndPieces(const PointMatrix& rotation_matrix, Polygons& result)
-    : ZigzagConnectorProcessorEndPieces(rotation_matrix, result)
-    {
-    }
-    void registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even);
-    void registerPolyFinished();
-};
-
-} // namespace cura
-
-
-#endif // INFILL_ZIGZAG_CONNECTOR_PROCESSOR_CONNECTED_END_PIECES_H

src/infill/ZigzagConnectorProcessorDisconnectedEndPieces.cpp

@@ -1,79 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "ZigzagConnectorProcessorDisconnectedEndPieces.h"
-
-
-namespace cura 
-{
-
-void ZigzagConnectorProcessorDisconnectedEndPieces::registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even)
-{
-    bool previous_scanline_is_even = last_scanline_is_even;
-    last_scanline_is_even = scanline_is_even;
-    bool this_scanline_is_even = last_scanline_is_even;
-    
-    if (is_first_zigzag_connector) 
-    {
-        first_zigzag_connector.push_back(intersection);
-        first_zigzag_connector_ends_in_even_scanline = this_scanline_is_even;
-        is_first_zigzag_connector = false;
-    }
-    else
-    {
-        if (previous_scanline_is_even && !this_scanline_is_even)
-        { // if we left from an even scanline, but not if this is the line segment connecting that zigzag_connector to an even scanline
-            addLine(last_connector_point, intersection);
-        }
-        else if (!previous_scanline_is_even && !this_scanline_is_even) // if we end an odd boundary in an odd segment
-        { // add whole oddBoundarySegment (including the just obtained point)
-            for (unsigned int point_idx = 1; point_idx < zigzag_connector.size(); point_idx++)
-            {
-                addLine(zigzag_connector[point_idx - 1], zigzag_connector[point_idx]);
-            }
-            // skip the last segment to the [intersection]
-            zigzag_connector.clear();
-        }
-        
-    }
-    zigzag_connector.clear(); // we're starting a new (odd) zigzag connector, so clear the old one
-    if (!this_scanline_is_even) // we are either in an end piece or an boundary segment starting in an odd scanline
-    { // only when a boundary segment starts in an odd scanline it depends on whether it ends in an odd scanline for whether this segment should be included or not
-        zigzag_connector.push_back(intersection);
-    }
-
-    last_connector_point = intersection;
-}
-
-
-void ZigzagConnectorProcessorDisconnectedEndPieces::registerPolyFinished()
-{
-    // write end segment if needed (first half of start/end-crossing segment)
-    if (!last_scanline_is_even && !first_zigzag_connector_ends_in_even_scanline)
-    {
-        for (unsigned int point_idx = 1; point_idx < zigzag_connector.size(); point_idx++)
-        {
-            addLine(zigzag_connector[point_idx - 1], zigzag_connector[point_idx]);
-        }
-    }
-    // write begin segment if needed (second half of start/end-crossing segment)
-    if (last_scanline_is_even || is_first_zigzag_connector)
-    {
-        for (unsigned int point_idx = 1; point_idx < first_zigzag_connector.size() - 1; point_idx++) // -1 cause skipping very last line segment!
-        {
-            addLine(first_zigzag_connector[point_idx - 1], first_zigzag_connector[point_idx]);
-        }
-    }
-    // write very last line segment if needed
-    if (last_scanline_is_even && !first_zigzag_connector_ends_in_even_scanline)
-    { // only add last element if boundary segment ends in odd scanline
-        addLine(first_zigzag_connector[first_zigzag_connector.size() - 2], first_zigzag_connector[first_zigzag_connector.size() - 1]);
-    }
-    // reset member variables
-    is_first_zigzag_connector = true;
-    first_zigzag_connector_ends_in_even_scanline = true;
-    last_scanline_is_even = false; 
-    first_zigzag_connector.clear();
-    zigzag_connector.clear();
-}
-
-
-} // namespace cura 

src/infill/ZigzagConnectorProcessorDisconnectedEndPieces.h

@@ -1,26 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_ZIGZAG_CONNECTOR_PROCESSOR_DISCONNECTED_END_PIECES_H
-#define INFILL_ZIGZAG_CONNECTOR_PROCESSOR_DISCONNECTED_END_PIECES_H
-
-#include "../utils/polygon.h"
-#include "ZigzagConnectorProcessorEndPieces.h"
-
-namespace cura
-{
-
-class ZigzagConnectorProcessorDisconnectedEndPieces : public ZigzagConnectorProcessorEndPieces
-{
-
-public:
-    ZigzagConnectorProcessorDisconnectedEndPieces(const PointMatrix& rotation_matrix, Polygons& result)
-    : ZigzagConnectorProcessorEndPieces(rotation_matrix, result)
-    {
-    }
-    void registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even);
-    void registerPolyFinished();
-};
-
-} // namespace cura
-
-
-#endif // INFILL_ZIGZAG_CONNECTOR_PROCESSOR_DISCONNECTED_END_PIECES_H

src/infill/ZigzagConnectorProcessorEndPieces.cpp

@@ -1,27 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "ZigzagConnectorProcessorEndPieces.h"
-
-
-namespace cura 
-{
-
-void ZigzagConnectorProcessorEndPieces::registerVertex(const Point& vertex)
-{
-    if (is_first_zigzag_connector)
-    {
-        first_zigzag_connector.push_back(vertex);
-    }
-    else if (last_scanline_is_even)
-    { // when a boundary segments starts in an even scanline it's either a normal zigzag connector or an endpiece to be included
-        // note that for ZigzagConnectorProcessorDisconnectedEndPieces only the last line segment from a boundary vertex to a scanline-boundary intersection is omitted
-        addLine(last_connector_point, vertex);
-    }
-    else
-    { // it's yet unclear whether the line segment should be included, so we store it until we know
-        zigzag_connector.push_back(vertex);
-    }
-    last_connector_point = vertex;
-}
-
-
-} // namespace cura 

src/infill/ZigzagConnectorProcessorEndPieces.h

@@ -1,32 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_ZIGZAG_CONNECTOR_PROCESSOR_END_PIECES_H
-#define INFILL_ZIGZAG_CONNECTOR_PROCESSOR_END_PIECES_H
-
-#include "../utils/polygon.h"
-#include "ActualZigzagConnectorProcessor.h"
-
-namespace cura
-{
-
-
-class ZigzagConnectorProcessorEndPieces : public ActualZigzagConnectorProcessor
-{
-protected:
-    Point last_connector_point; //!< last registered boundary vertex or scanline-coundary intersection
-
-    ZigzagConnectorProcessorEndPieces(const PointMatrix& rotation_matrix, Polygons& result)
-    : ActualZigzagConnectorProcessor(rotation_matrix, result)
-    , last_connector_point(0,0)
-    {
-    }
-
-public:
-    void registerVertex(const Point& vertex);
-};
-
-
-
-} // namespace cura
-
-
-#endif // INFILL_ZIGZAG_CONNECTOR_PROCESSOR_END_PIECES_H

src/infill/ZigzagConnectorProcessorNoEndPieces.cpp

@@ -1,72 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "ZigzagConnectorProcessorNoEndPieces.h"
-
-
-namespace cura 
-{
-
-void ZigzagConnectorProcessorNoEndPieces::registerVertex(const Point& vertex)
-{
-    if (is_first_zigzag_connector)
-    {
-        first_zigzag_connector.push_back(vertex);
-    }
-    else if (last_scanline_is_even)
-    {
-        zigzag_connector.push_back(vertex);
-    }
-}
-
-
-void ZigzagConnectorProcessorNoEndPieces::registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even)
-{
-    bool previous_scanline_is_even = last_scanline_is_even;
-    last_scanline_is_even = scanline_is_even;
-    bool this_scanline_is_even = last_scanline_is_even; // for conceptual clarity
-    
-    if (is_first_zigzag_connector) 
-    {
-        first_zigzag_connector.push_back(intersection);
-        first_zigzag_connector_ends_in_even_scanline = this_scanline_is_even;
-        is_first_zigzag_connector = false;
-    }
-    else
-    {
-        if (previous_scanline_is_even && !this_scanline_is_even)
-        { // add whole zigzag_connector (including the just obtained point)
-            for (unsigned int point_idx = 1; point_idx < zigzag_connector.size(); point_idx++)
-            {
-                addLine(zigzag_connector[point_idx - 1], zigzag_connector[point_idx]);
-            }
-            addLine(zigzag_connector.back(), intersection);
-            zigzag_connector.clear();
-        }
-    }
-    zigzag_connector.clear(); // we're starting a new zigzag connector, so clear the old one
-    if (this_scanline_is_even) // only boundary segments starting in an even segment are considered
-    {
-        zigzag_connector.push_back(intersection);
-    }
-    
-}
-
-
-void ZigzagConnectorProcessorNoEndPieces::registerPolyFinished()
-{
-    if (!is_first_zigzag_connector && last_scanline_is_even && !first_zigzag_connector_ends_in_even_scanline)
-    { // only if it's a normal zigzag connector; not when the whole boundary didn't cross any scanlines
-        for (unsigned int point_idx = 1; point_idx < first_zigzag_connector.size() ; point_idx++)
-        {
-            addLine(first_zigzag_connector[point_idx - 1], first_zigzag_connector[point_idx]);
-        }
-    }
-    // reset member variables
-    is_first_zigzag_connector = true;
-    first_zigzag_connector_ends_in_even_scanline = true;
-    last_scanline_is_even = false; 
-    first_zigzag_connector.clear();
-    zigzag_connector.clear();
-}
-
-
-} // namespace cura 

src/infill/ZigzagConnectorProcessorNoEndPieces.h

@@ -1,29 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef INFILL_ZIGZAG_CONNECTOR_PROCESSOR_NO_ENDPIECES_H
-#define INFILL_ZIGZAG_CONNECTOR_PROCESSOR_NO_ENDPIECES_H
-
-#include "../utils/polygon.h"
-#include "ActualZigzagConnectorProcessor.h"
-#include "../utils/intpoint.h"
-
-namespace cura
-{
-
-class ZigzagConnectorProcessorNoEndPieces : public ActualZigzagConnectorProcessor
-{
-public:
-    ZigzagConnectorProcessorNoEndPieces(const PointMatrix& rotation_matrix, Polygons& result)
-    : ActualZigzagConnectorProcessor(rotation_matrix, result)
-    {
-    }
-
-    void registerVertex(const Point& vertex);
-    void registerScanlineSegmentIntersection(const Point& intersection, bool scanline_is_even);
-    void registerPolyFinished();
-};
-
-
-} // namespace cura
-
-
-#endif // INFILL_ZIGZAG_CONNECTOR_PROCESSOR_NO_ENDPIECES_H

src/inset.cpp

@@ -0,0 +1,74 @@
+/** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
+#include "inset.h"
+#include "utils/polygonUtils.h"
+namespace cura {
+
+void generateInsets(SliceLayerPart* part, int nozzle_width, int line_width_0, int line_width_x, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters)
+{
+    if (insetCount == 0)
+    {
+        part->insets.push_back(part->outline);
+        return;
+    }
+    
+    for(int i=0; i<insetCount; i++)
+    {
+        part->insets.push_back(Polygons());
+        if (i == 0)
+        {
+            if (line_width_0 < nozzle_width)
+            {
+                PolygonUtils::offsetSafe(part->outline, - nozzle_width/2, line_width_0, part->insets[0], avoidOverlappingPerimeters_0);
+            }
+            else 
+            {
+                PolygonUtils::offsetSafe(part->outline, - line_width_0/2, line_width_0, part->insets[0], avoidOverlappingPerimeters_0);
+            }
+        } else if (i == 1)
+        {
+            if (line_width_0 < nozzle_width)
+            {
+                int offset_from_first_boundary_for_edge_of_outer_wall = -nozzle_width/2; 
+                // ideally this /\ should be: nozzle_width/2 - line_width_0; however, factually, the nozzle will fill up part of the perimeter gaps
+                PolygonUtils::offsetSafe(part->insets[0], nozzle_width/2 - line_width_0 - line_width_x/2, offset_from_first_boundary_for_edge_of_outer_wall, line_width_x, part->insets[1], &part->perimeterGaps, avoidOverlappingPerimeters);
+            }
+            else 
+            {
+                PolygonUtils::offsetSafe(part->insets[0], -line_width_0/2 - line_width_x/2, -line_width_0/2, line_width_x, part->insets[1], &part->perimeterGaps, avoidOverlappingPerimeters);
+            }
+        } else
+        {
+            PolygonUtils::offsetExtrusionWidth(part->insets[i-1], true, line_width_x, part->insets[i], &part->perimeterGaps, avoidOverlappingPerimeters);
+        }
+        
+        
+        //Finally optimize all the polygons. Every point removed saves time in the long run.
+        part->insets[i].simplify();
+        if (part->insets[i].size() < 1)
+        {
+            part->insets.pop_back();
+            break;
+        }
+    }
+}
+
+void generateInsets(SliceLayer* layer, int nozzle_width, int line_width_0, int line_width_x, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters)
+{
+    for(unsigned int partNr = 0; partNr < layer->parts.size(); partNr++)
+    {
+        generateInsets(&layer->parts[partNr], nozzle_width, line_width_0, line_width_x, insetCount, avoidOverlappingPerimeters_0, avoidOverlappingPerimeters);
+    }
+    
+    //Remove the parts which did not generate an inset. As these parts are too small to print,
+    // and later code can now assume that there is always minimal 1 inset line.
+    for(unsigned int partNr = 0; partNr < layer->parts.size(); partNr++)
+    {
+        if (layer->parts[partNr].insets.size() < 1)
+        {
+            layer->parts.erase(layer->parts.begin() + partNr);
+            partNr -= 1;
+        }
+    }
+}
+
+}//namespace cura

src/inset.h

@@ -0,0 +1,41 @@
+/** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
+#ifndef INSET_H
+#define INSET_H
+
+#include "sliceDataStorage.h"
+
+namespace cura 
+{
+
+/*!
+ * Generates the insets / perimeters for a single layer part.
+ * 
+ * \param part The part for which to generate the insets.
+ * \param nozzle_width The diameter of the hole in the nozzle
+ * \param line_width_0 line width of the outer wall
+ * \param line_width_x line width of other walls
+ * \param insetCount The number of insets to to generate
+ * \param avoidOverlappingPerimeters_0 Whether to remove the parts of the first perimeters where it have overlap with itself (and store the gaps thus created in the \p storage)
+ * \param avoidOverlappingPerimeters Whether to remove the parts of two consecutive perimeters where they have overlap (and store the gaps thus created in the \p part)
+ */
+void generateInsets(SliceLayerPart* part, int nozzle_width, int line_width_0, int line_width_x, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters);
+
+/*!
+ * Generates the insets / perimeters for all parts in a layer.
+ * 
+ * Note that the second inset gets offsetted by \p line_width_0 instead of the first, 
+ * which leads to better results for a smaller \p line_width_0 than \p line_width_x and when printing the outer wall last.
+ * 
+ * \param layer The layer for which to generate the insets.
+ * \param nozzle_width The diameter of the hole in the nozzle
+ * \param line_width_0 line width of the outer wall
+ * \param line_width_x line width of other walls
+ * \param insetCount The number of insets to to generate
+ * \param avoidOverlappingPerimeters_0 Whether to remove the parts of the first perimeters where it have overlap with itself (and store the gaps thus created in the \p storage)
+ * \param avoidOverlappingPerimeters Whether to remove the parts of two consecutive perimeters where they have overlap (and store the gaps thus created in the \p part)
+ */ 
+void generateInsets(SliceLayer* layer, int nozzle_width, int line_width_0, int line_width_x, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters);
+
+}//namespace cura
+
+#endif//INSET_H

src/layerPart.cpp

@@ -1,8 +1,8 @@
 /** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
 
 #include "layerPart.h"
-#include "settings/settings.h"
-#include "progress/Progress.h"
+#include "settings.h"
+#include "Progress.h"
 
 #include "utils/SVG.h" // debug output
 
@@ -26,15 +26,15 @@ void createLayerWithParts(SliceLayer& storageLayer, SlicerLayer* layer, bool uni
 
     if (union_all_remove_holes)
     {
-        for(unsigned int i=0; i<layer->polygons.size(); i++)
+        for(unsigned int i=0; i<layer->polygonList.size(); i++)
         {
-            if (layer->polygons[i].orientation())
-                layer->polygons[i].reverse();
+            if (layer->polygonList[i].orientation())
+                layer->polygonList[i].reverse();
         }
     }
     
     std::vector<PolygonsPart> result;
-    result = layer->polygons.splitIntoParts(union_layers || union_all_remove_holes);
+    result = layer->polygonList.splitIntoParts(union_layers || union_all_remove_holes);
     for(unsigned int i=0; i<result.size(); i++)
     {
         storageLayer.parts.emplace_back();
@@ -42,14 +42,14 @@ void createLayerWithParts(SliceLayer& storageLayer, SlicerLayer* layer, bool uni
         storageLayer.parts[i].boundaryBox.calculate(storageLayer.parts[i].outline);
     }
 }
-void createLayerParts(SliceMeshStorage& mesh, Slicer* slicer, bool union_layers, bool union_all_remove_holes)
+void createLayerParts(SliceMeshStorage& storage, Slicer* slicer, bool union_layers, bool union_all_remove_holes)
 {
     for(unsigned int layer_nr = 0; layer_nr < slicer->layers.size(); layer_nr++)
     {
-        mesh.layers.push_back(SliceLayer());
-        mesh.layers[layer_nr].sliceZ = slicer->layers[layer_nr].z;
-        mesh.layers[layer_nr].printZ = slicer->layers[layer_nr].z;
-        createLayerWithParts(mesh.layers[layer_nr], &slicer->layers[layer_nr], union_layers, union_all_remove_holes);
+        storage.layers.push_back(SliceLayer());
+        storage.layers[layer_nr].sliceZ = slicer->layers[layer_nr].z;
+        storage.layers[layer_nr].printZ = slicer->layers[layer_nr].z;
+        createLayerWithParts(storage.layers[layer_nr], &slicer->layers[layer_nr], union_layers, union_all_remove_holes);
     }
 }
 

src/layerPart.h

@@ -22,9 +22,9 @@ namespace cura {
 
 void createLayerWithParts(SliceLayer& storageLayer, SlicerLayer* layer, bool union_layers, bool union_all_remove_holes);
 
-void createLayerParts(SliceMeshStorage& mesh, Slicer* slicer, bool union_layers, bool union_all_remove_holes);
+void createLayerParts(SliceMeshStorage& storage, Slicer* slicer, bool union_layers, bool union_all_remove_holes);
 
-void layerparts2HTML(SliceDataStorage& mesh, const char* filename, bool all_layers = true, int layer_nr = -1);
+void layerparts2HTML(SliceDataStorage& storage, const char* filename, bool all_layers = true, int layer_nr = -1);
 
 }//namespace cura
 

src/main.cpp

@@ -16,9 +16,7 @@
 #include "utils/string.h"
 
 #include "FffProcessor.h"
-#include "settings/SettingRegistry.h"
-
-#include "settings/SettingsToGV.h"
+#include "settingRegistry.h"
 
 namespace cura
 {
@@ -30,25 +28,23 @@ void print_usage()
     cura::logError("CuraEngine help\n");
     cura::logError("\tShow this help message\n");
     cura::logError("\n");
-    cura::logError("CuraEngine connect <host>[:<port>] [-j <settings.def.json>]\n");
+    cura::logError("CuraEngine connect <host>[:<port>] [-j <settings.json>]\n");
     cura::logError("  --connect <host>[:<port>]\n\tConnect to <host> via a command socket, \n\tinstead of passing information via the command line\n");
-    cura::logError("  -j<settings.def.json>\n\tLoad settings.json file to register all settings and their defaults\n");
+    cura::logError("  -j\n\tLoad settings.json file to register all settings and their defaults\n");
     cura::logError("\n");
-    cura::logError("CuraEngine slice [-v] [-p] [-j <settings.json>] [-s <settingkey>=<value>] [-g] [-e<extruder_nr>] [-o <output.gcode>] [-l <model.stl>] [--next]\n");
+    cura::logError("CuraEngine slice [-v] [-p] [-j <settings.json>] [-s <settingkey>=<value>] [-g] [-e] [-o <output.gcode>] [-l <model.stl>] [--next]\n");
     cura::logError("  -v\n\tIncrease the verbose level (show log messages).\n");
     cura::logError("  -p\n\tLog progress information.\n");
-    cura::logError("  -j\n\tLoad settings.def.json file to register all settings and their defaults.\n");
+    cura::logError("  -j\n\tLoad settings.json file to register all settings and their defaults.\n");
     cura::logError("  -s <setting>=<value>\n\tSet a setting to a value for the last supplied object, \n\textruder train, or general settings.\n");
     cura::logError("  -l <model_file>\n\tLoad an STL model. \n");
     cura::logError("  -g\n\tSwitch setting focus to the current mesh group only.\n\tUsed for one-at-a-time printing.\n");
-    cura::logError("  -e<extruder_nr>\n\tSwitch setting focus to the extruder train with the given number.\n");
+    cura::logError("  -e\n\tAdd a new extruder train.\n");
     cura::logError("  --next\n\tGenerate gcode for the previously supplied mesh group and append that to \n\tthe gcode of further models for one-at-a-time printing.\n");
     cura::logError("  -o <output_file>\n\tSpecify a file to which to write the generated gcode.\n");
     cura::logError("\n");
     cura::logError("The settings are appended to the last supplied object:\n");
-    cura::logError("CuraEngine slice [general settings] \n\t-g [current group settings] \n\t-e0 [extruder train 0 settings] \n\t-l obj_inheriting_from_last_extruder_train.stl [object settings] \n\t--next [next group settings]\n\t... etc.\n");
-    cura::logError("\n");
-    cura::logError("In order to load machine definitions from custom locations, you need to create the environment variable CURA_ENGINE_SEARCH_PATH, which should contain all search paths delimited by a (semi-)colon.\n");
+    cura::logError("CuraEngine slice [general settings] \n\t-g [current group settings] \n\t-e [extruder train settings] \n\t-l obj_inheriting_from_last_extruder_train.stl [object settings] \n\t--next [next group settings]\n\t... etc.\n");
     cura::logError("\n");
 }
 
@@ -70,7 +66,7 @@ void print_call(int argc, char **argv)
 
 void connect(int argc, char **argv)
 {
-    CommandSocket::instantiate();
+    CommandSocket* commandSocket = new CommandSocket();
     std::string ip;
     int port = 49674;
     
@@ -81,6 +77,7 @@ void connect(int argc, char **argv)
         port = std::stoi(ip_port.substr(ip_port.find(':') + 1).data());
     }
 
+    
     for(int argn = 3; argn < argc; argn++)
     {
         char* str = argv[argn];
@@ -95,7 +92,7 @@ void connect(int argc, char **argv)
                     break;
                 case 'j':
                     argn++;
-                    if (SettingRegistry::getInstance()->loadJSONsettings(argv[argn], FffProcessor::getInstance()))
+                    if (SettingRegistry::getInstance()->loadJSONsettings(argv[argn]))
                     {
                         cura::logError("ERROR: Failed to load json file: %s\n", argv[argn]);
                     }
@@ -110,7 +107,7 @@ void connect(int argc, char **argv)
         }
     }
     
-    CommandSocket::getInstance()->connect(ip, port);
+    commandSocket->connect(ip, port);
 }
 
 void slice(int argc, char **argv)
@@ -119,12 +116,11 @@ void slice(int argc, char **argv)
     
     FMatrix3x3 transformation; // the transformation applied to a model when loaded
                         
-    MeshGroup* meshgroup = new MeshGroup(FffProcessor::getInstance());
+    MeshGroup meshgroup(FffProcessor::getInstance());
     
     int extruder_train_nr = 0;
 
-    SettingsBase* last_extruder_train = meshgroup->createExtruderTrain(0);
-    // extruder defaults cannot be loaded yet cause no json has been parsed
+    SettingsBase* last_extruder_train = meshgroup.getExtruderTrain(0);
     SettingsBase* last_settings_object = FffProcessor::getInstance();
     for(int argn = 2; argn < argc; argn++)
     {
@@ -138,29 +134,25 @@ void slice(int argc, char **argv)
                     try {
                         //Catch all exceptions, this prevents the "something went wrong" dialog on windows to pop up on a thrown exception.
                         // Only ClipperLib currently throws exceptions. And only in case that it makes an internal error.
-                        meshgroup->finalize();
+                        meshgroup.finalize();
                         log("Loaded from disk in %5.3fs\n", FffProcessor::getInstance()->time_keeper.restart());
                         
                         for (int extruder_nr = 0; extruder_nr < FffProcessor::getInstance()->getSettingAsCount("machine_extruder_count"); extruder_nr++)
                         { // initialize remaining extruder trains and load the defaults
-                            ExtruderTrain* train = meshgroup->createExtruderTrain(extruder_nr); // create new extruder train objects or use already existing ones
-                            SettingRegistry::getInstance()->loadExtruderJSONsettings(extruder_nr, train);
+                            meshgroup.getExtruderTrain(extruder_nr)->setExtruderTrainDefaults(extruder_nr); // also initializes yet uninitialized extruder trains
                         }
                         //start slicing
-                        FffProcessor::getInstance()->processMeshGroup(meshgroup);
+                        FffProcessor::getInstance()->processMeshGroup(&meshgroup);
                         
                         // initialize loading of new meshes
                         FffProcessor::getInstance()->time_keeper.restart();
-                        delete meshgroup;
-                        meshgroup = new MeshGroup(FffProcessor::getInstance());
-                        last_extruder_train = meshgroup->createExtruderTrain(0); 
-                        last_settings_object = meshgroup;
-                        SettingRegistry::getInstance()->loadExtruderJSONsettings(0, last_extruder_train);
-                        
+                        meshgroup = MeshGroup(FffProcessor::getInstance());
+                        last_settings_object = &meshgroup;
                     }catch(...){
                         cura::logError("Unknown exception\n");
                         exit(1);
                     }
+                    break;
                 }else{
                     cura::logError("Unknown option: %s\n", str);
                 }
@@ -177,7 +169,7 @@ void slice(int argc, char **argv)
                         break;
                     case 'j':
                         argn++;
-                        if (SettingRegistry::getInstance()->loadJSONsettings(argv[argn], last_settings_object))
+                        if (SettingRegistry::getInstance()->loadJSONsettings(argv[argn]))
                         {
                             cura::logError("ERROR: Failed to load json file: %s\n", argv[argn]);
                         }
@@ -185,9 +177,8 @@ void slice(int argc, char **argv)
                     case 'e':
                         str++;
                         extruder_train_nr = int(*str - '0'); // TODO: parse int instead (now "-e10"="-e:" , "-e11"="-e;" , "-e12"="-e<" .. etc) 
-                        last_settings_object = meshgroup->createExtruderTrain(extruder_train_nr);
-                        last_extruder_train = last_settings_object;
-                        SettingRegistry::getInstance()->loadExtruderJSONsettings(extruder_train_nr, last_extruder_train);
+                        last_settings_object = meshgroup.getExtruderTrain(extruder_train_nr);
+                        last_extruder_train = meshgroup.getExtruderTrain(extruder_train_nr);
                         break;
                     case 'l':
                         argn++;
@@ -195,13 +186,13 @@ void slice(int argc, char **argv)
                         log("Loading %s from disk...\n", argv[argn]);
                         // transformation = // TODO: get a transformation from somewhere
                         
-                        if (!loadMeshIntoMeshGroup(meshgroup, argv[argn], transformation, last_extruder_train))
+                        if (!loadMeshIntoMeshGroup(&meshgroup, argv[argn], transformation, last_extruder_train))
                         {
                             logError("Failed to load model: %s\n", argv[argn]);
                         }
                         else 
                         {
-                            last_settings_object = &(meshgroup->meshes.back()); // pointer is valid until a new object is added, so this is OK
+                            last_settings_object = &(meshgroup.meshes.back()); // pointer is valid until a new object is added, so this is OK
                         }
                         break;
                     case 'o':
@@ -213,7 +204,7 @@ void slice(int argc, char **argv)
                         }
                         break;
                     case 'g':
-                        last_settings_object = meshgroup;
+                        last_settings_object = &meshgroup;
                     case 's':
                         {
                             //Parse the given setting and store it.
@@ -247,11 +238,9 @@ void slice(int argc, char **argv)
         }
     }
 
-    int extruder_count = FffProcessor::getInstance()->getSettingAsCount("machine_extruder_count");
-    for (extruder_train_nr = 0; extruder_train_nr < extruder_count; extruder_train_nr++)
+    for (extruder_train_nr = 0; extruder_train_nr < FffProcessor::getInstance()->getSettingAsCount("machine_extruder_count"); extruder_train_nr++)
     { // initialize remaining extruder trains and load the defaults
-        ExtruderTrain* train = meshgroup->createExtruderTrain(extruder_train_nr); // create new extruder train objects or use already existing ones
-        SettingRegistry::getInstance()->loadExtruderJSONsettings(extruder_train_nr, train);
+        meshgroup.getExtruderTrain(extruder_train_nr)->setExtruderTrainDefaults(extruder_train_nr); // also initializes yet uninitialized extruder trains
     }
     
     
@@ -260,12 +249,12 @@ void slice(int argc, char **argv)
 #endif
         //Catch all exceptions, this prevents the "something went wrong" dialog on windows to pop up on a thrown exception.
         // Only ClipperLib currently throws exceptions. And only in case that it makes an internal error.
-        meshgroup->finalize();
+        meshgroup.finalize();
         log("Loaded from disk in %5.3fs\n", FffProcessor::getInstance()->time_keeper.restart());
         
         //start slicing
-        FffProcessor::getInstance()->processMeshGroup(meshgroup);
-
+        FffProcessor::getInstance()->processMeshGroup(&meshgroup);
+        
 #ifndef DEBUG
     }catch(...){
         cura::logError("Unknown exception\n");
@@ -274,8 +263,7 @@ void slice(int argc, char **argv)
 #endif
     //Finalize the processor, this adds the end.gcode. And reports statistics.
     FffProcessor::getInstance()->finalize();
-
-    delete meshgroup;
+    
 }
 
 }//namespace cura
@@ -329,79 +317,6 @@ int main(int argc, char **argv)
     {
         slice(argc, argv);
     }
-    else if (stringcasecompare(argv[1], "help") == 0)
-    {
-        print_usage();
-        exit(0);
-    }
-    else if (stringcasecompare(argv[1], "analyse") == 0)
-    { // CuraEngine analyse [json] [output.gv] [engine_settings] -[p|i|e|w]
-        // p = show parent-child relations
-        // i = show inheritance function
-        // e = show error functions
-        // w = show warning functions
-        // dot refl_ff.gv -Tpng > rafl_ff_dotted.png
-        // see meta/HOWTO.txt
-        
-        bool parent_child_viz = false;
-        bool inherit_viz = false;
-        bool warning_viz = false;
-        bool error_viz = false;
-        if (argc >= 6)
-        {
-            char* str = argv[5];
-            if (str[0] == '-')
-            {
-                for(str++; *str; str++)
-                {
-                    switch(*str)
-                    {
-                    case 'p':
-                        parent_child_viz = true;
-                        break;
-                    case 'i':
-                        inherit_viz = true;
-                        break;
-                    case 'e':
-                        error_viz = true;
-                        break;
-                    case 'w':
-                        warning_viz = true;
-                        break;
-                    default:
-                        cura::logError("Unknown option: %c\n", *str);
-                        print_call(argc, argv);
-                        print_usage();
-                        break;
-                    }
-                }
-            }
-        }
-        else
-        {
-            cura::logError("\n");
-            cura::logError("usage:\n");
-            cura::logError("CuraEngine analyse <fdmPrinter.def.json> <output.gv> <engine_settings_list> -[p|i|e|w]\n");
-            cura::logError("\tGenerate a grpah to visualize the setting inheritance structure.\n");
-            cura::logError("\t<fdmPrinter.def.json>\n\tThe base seting definitions file.\n");
-            cura::logError("\t<output.gv>\n\tThe output file.\n");
-            cura::logError("\t<engine_settings_list>\n\tA text file with all setting keys used in the engine, separated by newlines.\n");
-            cura::logError("\t-[p|i|e|w]\n\tOptions for what to include in the visualization\n");
-            cura::logError("\t\tp\tVisualize the parent-child relationship.\n");
-            cura::logError("\t\ti\tVisualize inheritance function relationships.\n");
-            cura::logError("\t\te\tVisualize (max/min) error function relationships.\n");
-            cura::logError("\t\tw\tVisualize (max/min) warning function relationships.\n");
-            cura::logError("\n");
-    
-        }
-        
-        SettingsToGv gv_out(argv[3], argv[4], parent_child_viz, inherit_viz, error_viz, warning_viz);
-        if (gv_out.generate(std::string(argv[2])))
-        {
-            cura::logError("ERROR: Failed to analyse json file: %s\n", argv[2]);
-        }
-        exit(0);
-    }
     else
     {
         cura::logError("Unknown command: %s\n", argv[1]);

src/mesh.cpp

@@ -5,17 +5,13 @@ namespace cura
 {
 
 const int vertex_meld_distance = MM2INT(0.03);
-/*!
- * returns a hash for the location, but first divides by the vertex_meld_distance,
- * so that any point within a box of vertex_meld_distance by vertex_meld_distance would get mapped to the same hash.
- */
-static inline uint32_t pointHash(const Point3& p)
+static inline uint32_t pointHash(Point3& p)
 {
     return ((p.x + vertex_meld_distance/2) / vertex_meld_distance) ^ (((p.y + vertex_meld_distance/2) / vertex_meld_distance) << 10) ^ (((p.z + vertex_meld_distance/2) / vertex_meld_distance) << 20);
 }
 
 Mesh::Mesh(SettingsBaseVirtual* parent)
-: SettingsBase(parent, std::string("mesh"))
+: SettingsBase(parent)
 {
 }
 
@@ -59,21 +55,16 @@ void Mesh::finish()
     }
 }
 
-Point3 Mesh::min() const
+Point3 Mesh::min()
 {
     return aabb.min;
 }
-Point3 Mesh::max() const
+Point3 Mesh::max()
 {
     return aabb.max;
 }
-AABB3D Mesh::getAABB() const
-{
-    return aabb;
-}
 
-
-int Mesh::findIndexOfVertex(const Point3& v)
+int Mesh::findIndexOfVertex(Point3& v)
 {
     uint32_t hash = pointHash(v);
 
@@ -116,7 +107,7 @@ See <a href="http://stackoverflow.com/questions/14066933/direct-way-of-computing
 
 
 */
-int Mesh::getFaceIdxWithPoints(int idx0, int idx1, int notFaceIdx) const
+int Mesh::getFaceIdxWithPoints(int idx0, int idx1, int notFaceIdx)
 {
     std::vector<int> candidateFaces; // in case more than two faces meet at an edge, multiple candidates are generated
     int notFaceVertexIdx = -1; // index of the third vertex of the face corresponding to notFaceIdx
@@ -188,4 +179,4 @@ int Mesh::getFaceIdxWithPoints(int idx0, int idx1, int notFaceIdx) const
     return bestIdx;
 }
 
-}//namespace cura
+}//namespace cura

src/mesh.h

@@ -1,8 +1,8 @@
 #ifndef MESH_H
 #define MESH_H
 
-#include "settings/settings.h"
-#include "utils/AABB3D.h"
+#include "settings.h"
+#include "utils/AABB.h"
 
 namespace cura
 {
@@ -69,9 +69,8 @@ public:
     void clear(); //!< clears all data
     void finish(); //!< complete the model : set the connected_face_index fields of the faces.
 
-    Point3 min() const; //!< min (in x,y and z) vertex of the bounding box
-    Point3 max() const; //!< max (in x,y and z) vertex of the bounding box
-    AABB3D getAABB() const; //!< Get the axis aligned bounding box
+    Point3 min(); //!< min (in x,y and z) vertex of the bounding box
+    Point3 max(); //!< max (in x,y and z) vertex of the bounding box
     
     /*!
      * Offset the whole mesh (all vertices and the bounding box).
@@ -86,12 +85,12 @@ public:
     }
 
 private:
-    int findIndexOfVertex(const Point3& v); //!< find index of vertex close to the given point, or create a new vertex and return its index.
+    int findIndexOfVertex(Point3& v); //!< find index of vertex close to the given point, or create a new vertex and return its index.
     /*!
     Get the index of the face connected to the face with index \p notFaceIdx, via vertices \p idx0 and \p idx1.
     In case multiple faces connect with the same edge, return the next counter-clockwise face when viewing from \p idx1 to \p idx0.
     */
-    int getFaceIdxWithPoints(int idx0, int idx1, int notFaceIdx) const;
+    int getFaceIdxWithPoints(int idx0, int idx1, int notFaceIdx);
 };
 
 }//namespace cura

src/multiVolumes.cpp

@@ -6,29 +6,15 @@ namespace cura
 void carveMultipleVolumes(std::vector<Slicer*> &volumes)
 {
     //Go trough all the volumes, and remove the previous volume outlines from our own outline, so we never have overlapped areas.
-    for (unsigned int volume_1_idx = 0; volume_1_idx < volumes.size(); volume_1_idx++)
+    for(unsigned int idx=0; idx < volumes.size(); idx++)
     {
-        Slicer& volume_1 = *volumes[volume_1_idx];
-        if (volume_1.mesh->getSettingBoolean("infill_mesh"))
+        for(unsigned int idx2=0; idx2<idx; idx2++)
         {
-            continue;
-        }
-        for (unsigned int volume_2_idx = 0; volume_2_idx < volume_1_idx; volume_2_idx++)
-        {
-            Slicer& volume_2 = *volumes[volume_2_idx];
-            if (volume_2.mesh->getSettingBoolean("infill_mesh"))
+            for(unsigned int layerNr=0; layerNr < volumes[idx]->layers.size(); layerNr++)
             {
-                continue;
-            }
-            if (!volume_1.mesh->getAABB().hit(volume_2.mesh->getAABB()))
-            {
-                continue;
-            }
-            for (unsigned int layerNr = 0; layerNr < volume_1.layers.size(); layerNr++)
-            {
-                SlicerLayer& layer1 = volume_1.layers[layerNr];
-                SlicerLayer& layer2 = volume_2.layers[layerNr];
-                layer1.polygons = layer1.polygons.difference(layer2.polygons);
+                SlicerLayer& layer1 = volumes[idx]->layers[layerNr];
+                SlicerLayer& layer2 = volumes[idx2]->layers[layerNr];
+                layer1.polygonList = layer1.polygonList.difference(layer2.polygonList);
             }
         }
     }
@@ -36,40 +22,24 @@ void carveMultipleVolumes(std::vector<Slicer*> &volumes)
  
 //Expand each layer a bit and then keep the extra overlapping parts that overlap with other volumes.
 //This generates some overlap in dual extrusion, for better bonding in touching parts.
-void generateMultipleVolumesOverlap(std::vector<Slicer*> &volumes)
+void generateMultipleVolumesOverlap(std::vector<Slicer*> &volumes, int overlap)
 {
-    if (volumes.size() < 2)
+    if (volumes.size() < 2 || overlap <= 0) return;
+    
+    for(unsigned int layerNr=0; layerNr < volumes[0]->layers.size(); layerNr++)
     {
-        return;
-    }
-
-    int offset_to_merge_other_merged_volumes = 20;
-    for (Slicer* volume : volumes)
-    {
-        int overlap = volume->mesh->getSettingInMicrons("multiple_mesh_overlap");
-        if (volume->mesh->getSettingBoolean("infill_mesh")
-            || overlap == 0)
+        Polygons fullLayer;
+        for(unsigned int volIdx = 0; volIdx < volumes.size(); volIdx++)
         {
-            continue;
+            SlicerLayer& layer1 = volumes[volIdx]->layers[layerNr];
+            fullLayer = fullLayer.unionPolygons(layer1.polygonList.offset(20)); // TODO: put hard coded value in a variable with an explanatory name (and make var a parameter, and perhaps even a setting?)
         }
-        for (unsigned int layer_nr = 0; layer_nr < volume->layers.size(); layer_nr++)
+        fullLayer = fullLayer.offset(-20); // TODO: put hard coded value in a variable with an explanatory name (and make var a parameter, and perhaps even a setting?)
+        
+        for(unsigned int volIdx = 0; volIdx < volumes.size(); volIdx++)
         {
-            Polygons all_other_volumes;
-            for (Slicer* other_volume : volumes)
-            {
-                if (other_volume->mesh->getSettingBoolean("infill_mesh")
-                    || !other_volume->mesh->getAABB().hit(volume->mesh->getAABB())
-                )
-                {
-                    continue;
-                }
-                SlicerLayer& other_volume_layer = other_volume->layers[layer_nr];
-                all_other_volumes = all_other_volumes.unionPolygons(other_volume_layer.polygons.offset(offset_to_merge_other_merged_volumes));
-            }
-            all_other_volumes = all_other_volumes.offset(-offset_to_merge_other_merged_volumes);
-
-            SlicerLayer& volume_layer = volume->layers[layer_nr];
-            volume_layer.polygons.unionPolygons(all_other_volumes.intersection(volume_layer.polygons.offset(overlap / 2)));
+            SlicerLayer& layer1 = volumes[volIdx]->layers[layerNr];
+            layer1.polygonList = fullLayer.intersection(layer1.polygonList.offset(overlap / 2));
         }
     }
 }

src/multiVolumes.h

@@ -13,7 +13,7 @@ void carveMultipleVolumes(std::vector<Slicer*> &meshes);
  * Expand each layer a bit and then keep the extra overlapping parts that overlap with other volumes.
  * This generates some overlap in dual extrusion, for better bonding in touching parts.
  */
-void generateMultipleVolumesOverlap(std::vector<Slicer*> &meshes);
+void generateMultipleVolumesOverlap(std::vector<Slicer*> &meshes, int overlap);
 
 }//namespace cura
 

src/pathOrderOptimizer.cpp

@@ -2,7 +2,6 @@
 #include "pathOrderOptimizer.h"
 #include "utils/logoutput.h"
 #include "utils/BucketGrid2D.h"
-#include "utils/linearAlg2D.h"
 
 #define INLINE static inline
 
@@ -16,16 +15,17 @@ void PathOrderOptimizer::optimize()
     bool picked[polygons.size()];
     memset(picked, false, sizeof(bool) * polygons.size());/// initialized as falses
     
-    for (PolygonRef poly : polygons) /// find closest point to initial starting point within each polygon +initialize picked
+    for(unsigned int i_polygon=0 ; i_polygon<polygons.size() ; i_polygon++) /// find closest point to initial starting point within each polygon +initialize picked
     {
         int best = -1;
         float bestDist = std::numeric_limits<float>::infinity();
-        for (unsigned int point_idx = 0; point_idx < poly.size(); point_idx++) /// get closest point in polygon
+        PolygonRef poly = polygons[i_polygon];
+        for(unsigned int i_point=0; i_point<poly.size(); i_point++) /// get closest point in polygon
         {
-            float dist = vSize2f(poly[point_idx] - startPoint);
+            float dist = vSize2f(poly[i_point] - startPoint);
             if (dist < bestDist)
             {
-                best = point_idx;
+                best = i_point;
                 bestDist = dist;
             }
         }
@@ -37,50 +37,46 @@ void PathOrderOptimizer::optimize()
 
 
     Point prev_point = startPoint;
-    for (unsigned int poly_order_idx = 0; poly_order_idx < polygons.size(); poly_order_idx++) /// actual path order optimizer
+    for(unsigned int i_polygon=0 ; i_polygon<polygons.size() ; i_polygon++) /// actual path order optimizer
     {
-        int best_poly_idx = -1;
+        int best = -1;
         float bestDist = std::numeric_limits<float>::infinity();
 
 
-        for (unsigned int poly_idx = 0; poly_idx < polygons.size(); poly_idx++)
+        for(unsigned int i_polygon=0 ; i_polygon<polygons.size() ; i_polygon++)
         {
-            if (picked[poly_idx] || polygons[poly_idx].size() < 1) /// skip single-point-polygons
-            {
+            if (picked[i_polygon] || polygons[i_polygon].size() < 1) /// skip single-point-polygons
                 continue;
-            }
 
-            assert (polygons[poly_idx].size() != 2);
+            assert (polygons[i_polygon].size() != 2);
 
-            float dist = vSize2f(polygons[poly_idx][polyStart[poly_idx]] - prev_point);
+            float dist = vSize2f(polygons[i_polygon][polyStart[i_polygon]] - prev_point);
             if (dist < bestDist)
             {
-                best_poly_idx = poly_idx;
+                best = i_polygon;
                 bestDist = dist;
             }
 
         }
 
 
-        if (best_poly_idx > -1) /// should always be true; we should have been able to identify the best next polygon
+        if (best > -1) /// should always be true; we should have been able to identify the best next polygon
         {
-            assert(polygons[best_poly_idx].size() != 2);
+            assert(polygons[best].size() != 2);
 
-            prev_point = polygons[best_poly_idx][polyStart[best_poly_idx]];
+            prev_point = polygons[best][polyStart[best]];
 
-            picked[best_poly_idx] = true;
-            polyOrder.push_back(best_poly_idx);
+            picked[best] = true;
+            polyOrder.push_back(best);
         }
         else
-        {
             logError("Failed to find next closest polygon.\n");
-        }
     }
 
     prev_point = startPoint;
-    for (unsigned int order_idx = 0; order_idx < polyOrder.size(); order_idx++) /// decide final starting points in each polygon
+    for(unsigned int n=0; n<polyOrder.size(); n++) /// decide final starting points in each polygon
     {
-        int poly_idx = polyOrder[order_idx];
+        int poly_idx = polyOrder[n];
         int point_idx = getPolyStart(prev_point, poly_idx);
         polyStart[poly_idx] = point_idx;
         prev_point = polygons[poly_idx][point_idx];
@@ -103,23 +99,22 @@ int PathOrderOptimizer::getPolyStart(Point prev_point, int poly_idx)
 int PathOrderOptimizer::getClosestPointInPolygon(Point prev_point, int poly_idx)
 {
     PolygonRef poly = polygons[poly_idx];
-
     int best_point_idx = -1;
-    float best_point_score = std::numeric_limits<float>::infinity();
-    Point p0 = poly.back();
-    for (unsigned int point_idx = 0; point_idx < poly.size(); point_idx++)
+    float bestDist = std::numeric_limits<float>::infinity();
+    bool orientation = poly.orientation();
+    for(unsigned int i_point=0 ; i_point<poly.size() ; i_point++)
     {
-        Point& p1 = poly[point_idx];
-        Point& p2 = poly[(point_idx + 1) % poly.size()];
-        int64_t dist = vSize2(p1 - prev_point);
-        float is_on_inside_corner_score = -LinearAlg2D::getAngleLeft(p0, p1, p2) / M_PI * 5000 * 5000; // prefer inside corners
-        // this score is in the order of 5 mm
-        if (dist + is_on_inside_corner_score < best_point_score)
+        float dist = vSize2f(poly[i_point] - prev_point);
+        Point n0 = normal(poly[(i_point-1+poly.size())%poly.size()] - poly[i_point], 2000);
+        Point n1 = normal(poly[i_point] - poly[(i_point + 1) % poly.size()], 2000);
+        float dot_score = dot(n0, n1) - dot(crossZ(n0), n1); /// prefer binnenbocht
+        if (orientation)
+            dot_score = -dot_score;
+        if (dist + dot_score < bestDist)
         {
-            best_point_idx = point_idx;
-            best_point_score = dist + is_on_inside_corner_score;
+            best_point_idx = i_point;
+            bestDist = dist;
         }
-        p0 = p1;
     }
     return best_point_idx;
 }
@@ -152,118 +147,132 @@ int PathOrderOptimizer::getFarthestPointInPolygon(int poly_idx)
 */
 void LineOrderOptimizer::optimize()
 {
-    int gridSize = 5000; // the size of the cells in the hash grid. TODO
+    int gridSize = 5000; // the size of the cells in the hash grid.
     BucketGrid2D<unsigned int> line_bucket_grid(gridSize);
     bool picked[polygons.size()];
     memset(picked, false, sizeof(bool) * polygons.size());/// initialized as falses
     
-    for (unsigned int poly_idx = 0; poly_idx < polygons.size(); poly_idx++) /// find closest point to initial starting point within each polygon +initialize picked
+    for(unsigned int i_polygon=0 ; i_polygon<polygons.size() ; i_polygon++) /// find closest point to initial starting point within each polygon +initialize picked
     {
-        int best_point_idx = -1;
-        float best_point_dist = std::numeric_limits<float>::infinity();
-        PolygonRef poly = polygons[poly_idx];
-        for (unsigned int point_idx = 0; point_idx < poly.size(); point_idx++) /// get closest point from polygon
+        int best = -1;
+        float bestDist = std::numeric_limits<float>::infinity();
+        PolygonRef poly = polygons[i_polygon];
+        for(unsigned int i_point=0; i_point<poly.size(); i_point++) /// get closest point from polygon
         {
-            float dist = vSize2f(poly[point_idx] - startPoint);
-            if (dist < best_point_dist)
+            float dist = vSize2f(poly[i_point] - startPoint);
+            if (dist < bestDist)
             {
-                best_point_idx = point_idx;
-                best_point_dist = dist;
+                best = i_point;
+                bestDist = dist;
             }
         }
-        polyStart.push_back(best_point_idx);
+        polyStart.push_back(best);
 
         assert(poly.size() == 2);
 
-        line_bucket_grid.insert(poly[0], poly_idx);
-        line_bucket_grid.insert(poly[1], poly_idx);
+        line_bucket_grid.insert(poly[0], i_polygon);
+        line_bucket_grid.insert(poly[1], i_polygon);
 
     }
 
 
-    Point incoming_perpundicular_normal(0, 0);
+    Point incommingPerpundicularNormal(0, 0);
     Point prev_point = startPoint;
-    for (unsigned int order_idx = 0; order_idx < polygons.size(); order_idx++) /// actual path order optimizer
+    for(unsigned int i_polygon=0 ; i_polygon<polygons.size() ; i_polygon++) /// actual path order optimizer
     {
-        int best_line_idx = -1;
-        float best_score = std::numeric_limits<float>::infinity(); // distance score for the best next line
+        int best = -1;
+        float bestDist = std::numeric_limits<float>::infinity();
 
-        for(unsigned int close_line_poly_idx :  line_bucket_grid.findNearbyObjects(prev_point)) /// check if single-line-polygon is close to last point
+        for(unsigned int i_close_line_polygon :  line_bucket_grid.findNearbyObjects(prev_point)) /// check if single-line-polygon is close to last point
         {
-            if (picked[close_line_poly_idx] || polygons[close_line_poly_idx].size() < 1)
-            {
+            if (picked[i_close_line_polygon] || polygons[i_close_line_polygon].size() < 1)
                 continue;
-            }
 
-            updateBestLine(close_line_poly_idx, best_line_idx, best_score, prev_point, incoming_perpundicular_normal);
+
+            checkIfLineIsBest(i_close_line_polygon, best, bestDist, prev_point, incommingPerpundicularNormal);
+
         }
 
-        if (best_line_idx == -1) /// if single-line-polygon hasn't been found yet
+        if (best == -1) /// if single-line-polygon hasn't been found yet
         {
-            for (unsigned int poly_idx = 0; poly_idx < polygons.size(); poly_idx++)
+           for(unsigned int i_polygon=0 ; i_polygon<polygons.size() ; i_polygon++)
             {
-                if (picked[poly_idx] || polygons[poly_idx].size() < 1) /// skip single-point-polygons
-                {
+                if (picked[i_polygon] || polygons[i_polygon].size() < 1) /// skip single-point-polygons
                     continue;
-                }
-                assert(polygons[poly_idx].size() == 2);
+                assert(polygons[i_polygon].size() == 2);
 
-                updateBestLine(poly_idx, best_line_idx, best_score, prev_point, incoming_perpundicular_normal);
+                checkIfLineIsBest(i_polygon, best, bestDist, prev_point, incommingPerpundicularNormal);
 
             }
         }
 
-        if (best_line_idx > -1) /// should always be true; we should have been able to identify the best next polygon
+        if (best > -1) /// should always be true; we should have been able to identify the best next polygon
         {
-            PolygonRef best_line = polygons[best_line_idx];
-            assert(best_line.size() == 2);
+            assert(polygons[best].size() == 2);
 
-            int line_start_point_idx = polyStart[best_line_idx];
-            int line_end_point_idx = line_start_point_idx * -1 + 1; /// 1 -> 0 , 0 -> 1
-            Point& line_start = best_line[line_start_point_idx];
-            Point& line_end = best_line[line_end_point_idx];
-            prev_point = line_end;
-            incoming_perpundicular_normal = turn90CCW(normal(line_end - line_start, 1000));
+            int endIdx = polyStart[best] * -1 + 1; /// 1 -> 0 , 0 -> 1
+            prev_point = polygons[best][endIdx];
+            incommingPerpundicularNormal = crossZ(normal(polygons[best][endIdx] - polygons[best][polyStart[best]], 1000));
 
-            picked[best_line_idx] = true;
-            polyOrder.push_back(best_line_idx);
+            picked[best] = true;
+            polyOrder.push_back(best);
         }
         else
-        {
             logError("Failed to find next closest line.\n");
+    }
+
+    prev_point = startPoint;
+    for(unsigned int n=0; n<polyOrder.size(); n++) /// decide final starting points in each polygon
+    {
+        int nr = polyOrder[n];
+        PolygonRef poly = polygons[nr];
+        int best = -1;
+        float bestDist = std::numeric_limits<float>::infinity();
+        bool orientation = poly.orientation();
+        for(unsigned int i=0;i<poly.size(); i++)
+        {
+            float dist = vSize2f(polygons[nr][i] - prev_point);
+            Point n0 = normal(poly[(i+poly.size()-1)%poly.size()] - poly[i], 2000);
+            Point n1 = normal(poly[i] - poly[(i + 1) % poly.size()], 2000);
+            float dot_score = dot(n0, n1) - dot(crossZ(n0), n1);
+            if (orientation)
+                dot_score = -dot_score;
+            if (dist + dot_score < bestDist)
+            {
+                best = i;
+                bestDist = dist + dot_score;
+            }
         }
+
+        polyStart[nr] = best;
+        assert(poly.size() == 2);
+        prev_point = poly[best *-1 + 1]; /// 1 -> 0 , 0 -> 1
+
     }
 }
 
-inline void LineOrderOptimizer::updateBestLine(unsigned int poly_idx, int& best, float& best_score, Point prev_point, Point incoming_perpundicular_normal)
+inline void LineOrderOptimizer::checkIfLineIsBest(unsigned int i_line_polygon, int& best, float& bestDist, Point& prev_point, Point& incommingPerpundicularNormal)
 {
-    Point& p0 = polygons[poly_idx][0];
-    Point& p1 = polygons[poly_idx][1];
-    float dot_score = getAngleScore(incoming_perpundicular_normal, p0, p1);
     { /// check distance to first point on line (0)
-        float score = vSize2f(p0 - prev_point) + dot_score; // prefer 90 degree corners
-        if (score < best_score)
+        float dist = vSize2f(polygons[i_line_polygon][0] - prev_point);
+        dist += abs(dot(incommingPerpundicularNormal, normal(polygons[i_line_polygon][1] - polygons[i_line_polygon][0], 1000))) * 0.0001f; /// penalize sharp corners
+        if (dist < bestDist)
         {
-            best = poly_idx;
-            best_score = score;
-            polyStart[poly_idx] = 0;
+            best = i_line_polygon;
+            bestDist = dist;
+            polyStart[i_line_polygon] = 0;
         }
     }
     { /// check distance to second point on line (1)
-        float score = vSize2f(p1 - prev_point) + dot_score; // prefer 90 degree corners
-        if (score < best_score)
+        float dist = vSize2f(polygons[i_line_polygon][1] - prev_point);
+        dist += abs(dot(incommingPerpundicularNormal, normal(polygons[i_line_polygon][0] - polygons[i_line_polygon][1], 1000) )) * 0.0001f; /// penalize sharp corners
+        if (dist < bestDist)
         {
-            best = poly_idx;
-            best_score = score;
-            polyStart[poly_idx] = 1;
+            best = i_line_polygon;
+            bestDist = dist;
+            polyStart[i_line_polygon] = 1;
         }
     }
 }
 
-float LineOrderOptimizer::getAngleScore(Point incoming_perpundicular_normal, Point p0, Point p1)
-{
-    return dot(incoming_perpundicular_normal, normal(p1 - p0, 1000)) * 0.0001f;
-}
-
-
 }//namespace cura

src/pathOrderOptimizer.h

@@ -4,7 +4,7 @@
 
 #include <stdint.h>
 #include "utils/polygon.h"
-#include "settings/settings.h"
+#include "settings.h"
 
 namespace cura {
  
@@ -81,35 +81,8 @@ public:
     void optimize(); //!< sets #polyStart and #polyOrder
 
 private:
-    /*!
-     * Update LineOrderOptimizer::polyStart if the current line is better than the current best.
-     * 
-     * Besides looking at the distance from the previous line segment, we also look at the angle we make.
-     * 
-     * We prefer 90 degree angles; 180 degree turn arounds are slow on machines where the jerk is limited.
-     * 0 degree (straight ahead) 'corners' occur only when a single infill line is interrupted, 
-     * in which case the travel move might involve combing, which makes it rather longer.
-     * 
-     * \param poly_idx[in] The index in LineOrderOptimizer::polygons for the current line to test
-     * \param best[in, out] The index of current best line
-     * \param best_score[in, out] The distance score for the current best line
-     * \param prev_point[in] The previous point from which to find the next best line
-     * \param incoming_perpundicular_normal[in] The direction of movement when the print head arrived at \p prev_point, turned 90 degrees CCW
-     */
-    void updateBestLine(unsigned int poly_idx, int& best, float& best_score, Point prev_point, Point incoming_perpundicular_normal);
+    void checkIfLineIsBest(unsigned int i_line_polygon, int& best, float& bestDist, Point& prev_point, Point& incommingPerpundicularNormal);
 
-    /*!
-     * Get a score to modify the distance score for measuring how good two lines follow each other.
-     * 
-     * The angle score is symmetric in \p from and \p to; they can be exchanged without altering the result. (Code relies on this property)
-     * 
-     * \param incoming_perpundicular_normal The direction in which the head was moving while printing the previous line, turned 90 degrees CCW
-     * \param from The one end of the next line
-     * \param to The other end of the next line
-     * \return A score measuring how good the angle is of the line between \p from and \p to when the previous line had a direction given by \p incoming_perpundicular_normal 
-     * 
-     */
-    static float getAngleScore(Point incoming_perpundicular_normal, Point from, Point to);
 };
 
 }//namespace cura

src/progress/ProgressEstimator.h

@@ -1,29 +0,0 @@
-/** Copyright (C) 2016 Tim Kuipers - Released under terms of the AGPLv3 License */
-#ifndef PROGRESS_PROGRESS_ESTIMATOR_H
-#define PROGRESS_PROGRESS_ESTIMATOR_H
-
-#include <vector>
-
-namespace cura
-{
-/*
- * ProgressEstimator is a finger-tree with ProgressEstimatorLinear as leaves.
- * 
- * Each (non-leaf) node consists of a ProgressStageEstimator which consists of several stages.
- * 
- * The structure of this tree is an oversimplification of the call graph of CuraEngine.
- * 
- */
-    
-class ProgressEstimator
-{
-public:
-    virtual double progress(int current_step) = 0;
-    virtual ~ProgressEstimator()
-    {
-    }
-};
-
-} // namespace cura
-
-#endif // PROGRESS_PROGRESS_ESTIMATOR_H

src/progress/ProgressEstimatorLinear.h

@@ -1,29 +0,0 @@
-/** Copyright (C) 2016 Tim Kuipers - Released under terms of the AGPLv3 License */
-#ifndef PROGRESS_PROGRESS_ESTIMATOR_LINEAR_H
-#define PROGRESS_PROGRESS_ESTIMATOR_LINEAR_H
-
-#include <vector>
-
-#include "ProgressEstimator.h"
-
-namespace cura
-{
-
-
-class ProgressEstimatorLinear : public ProgressEstimator
-{
-    unsigned int total_steps;
-public:
-    ProgressEstimatorLinear(unsigned int total_steps)
-    : total_steps(total_steps)
-    {
-    }
-    double progress(int current_step)
-    {
-        return double(current_step) / double(total_steps);
-    }
-};
-
-} // namespace cura
-
-#endif // PROGRESS_PROGRESS_ESTIMATOR_LINEAR_H

src/progress/ProgressStageEstimator.cpp

@@ -1,52 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "ProgressStageEstimator.h"
-
-
-namespace cura 
-{
-
-
-ProgressStageEstimator::ProgressStageEstimator(std::vector< double >& relative_time_estimates)
-: total_estimated_time(0)
-, accumulated_estimate(0)
-, current_stage_idx(-1)
-{
-    stages.reserve(relative_time_estimates.size());
-    for (double relative_estimated_time : relative_time_estimates)
-    {
-        stages.emplace_back(relative_estimated_time);
-        total_estimated_time += relative_estimated_time;
-    }
-}
-
-ProgressStageEstimator::~ProgressStageEstimator()
-{
-    for (ProgressStage& stage : stages)
-    {
-        delete stage.stage;
-    }
-}
-
-double ProgressStageEstimator::progress(int current_step)
-{
-    ProgressStage& current_stage = stages[current_stage_idx];
-    return (accumulated_estimate + current_stage.stage->progress(current_step) * current_stage.relative_estimated_time) / total_estimated_time;
-}
-
-void ProgressStageEstimator::nextStage(ProgressEstimator* stage)
-{
-    if (current_stage_idx >= int(stages.size()) - 1)
-    {
-        return;
-    }
-    if (current_stage_idx >= 0)
-    {
-        ProgressStage& current_stage = stages[current_stage_idx];
-        accumulated_estimate += current_stage.relative_estimated_time;
-    }
-    current_stage_idx++;
-    stages[current_stage_idx].stage = stage;
-}
-
-
-} // namespace cura 

src/progress/ProgressStageEstimator.h

@@ -1,54 +0,0 @@
-/** Copyright (C) 2016 Tim Kuipers - Released under terms of the AGPLv3 License */
-#ifndef PROGRESS_PROGRESS_STAGE_ESTIMATOR_H
-#define PROGRESS_PROGRESS_STAGE_ESTIMATOR_H
-
-#include <vector>
-
-#include "ProgressEstimator.h"
-
-namespace cura
-{
-
-/*!
- * A staged progress estimator which estimates each stage to have different times.
- */
-class ProgressStageEstimator : public ProgressEstimator
-{
-    struct ProgressStage
-    {
-        double relative_estimated_time;
-        ProgressEstimator* stage;
-        ProgressStage(double relative_estimated_time)
-        : relative_estimated_time(relative_estimated_time)
-        , stage(nullptr)
-        {
-        }
-        
-    };
-    
-protected:
-    std::vector<ProgressStage> stages;
-    double total_estimated_time;
-    
-private:
-    double accumulated_estimate;
-    int current_stage_idx;
-    
-public:
-    ProgressStageEstimator(std::vector<double>& relative_time_estimates);
-    
-    double progress(int current_step);
-    
-    /*!
-     * 
-     * \warning This class is responsible for deleting the \p stage
-     * 
-     */
-    void nextStage(ProgressEstimator* stage);
-    
-    ~ProgressStageEstimator();
-};
-
-} // namespace cura
-
-#endif // PROGRESS_PROGRESS_STAGE_ESTIMATOR_H

src/raft.cpp

@@ -16,7 +16,7 @@ void generateRaft(SliceDataStorage& storage, int distance)
     }
     else 
     {
-        storage.raftOutline = storage.getLayerOutlines(0, true).offset(distance);
+        storage.raftOutline = storage.getLayerOutlines(0, true);
     }
 }
 

src/settingRegistry.cpp

@@ -0,0 +1,312 @@
+#include "settingRegistry.h"
+
+#include <sstream>
+#include <iostream> // debug IO
+#include <libgen.h> // dirname
+#include <string>
+
+#include "utils/logoutput.h"
+
+#include "rapidjson/rapidjson.h"
+#include "rapidjson/document.h"
+#include "rapidjson/error/en.h"
+#include "rapidjson/filereadstream.h"
+#include "utils/logoutput.h"
+
+namespace cura
+{
+    
+SettingRegistry SettingRegistry::instance; // define settingRegistry
+
+std::string SettingRegistry::toString(rapidjson::Type type)
+{
+    switch (type)
+    {
+        case rapidjson::Type::kNullType: return "null";
+        case rapidjson::Type::kFalseType: return "false";
+        case rapidjson::Type::kTrueType: return "true";
+        case rapidjson::Type::kObjectType: return "object";
+        case rapidjson::Type::kArrayType: return "array";
+        case rapidjson::Type::kStringType: return "string";
+        case rapidjson::Type::kNumberType: return "number";
+        default: return "Unknown";
+    }
+}
+
+
+SettingContainer::SettingContainer(std::string key, std::string label)
+: key(key)
+, label(label)
+{
+}
+
+SettingConfig* SettingContainer::addChild(std::string key, std::string label)
+{
+    children.emplace_back(key, label, nullptr);
+    return &children.back();
+}
+
+SettingConfig::SettingConfig(std::string key, std::string label, SettingContainer* parent)
+: SettingContainer(key, label)
+, parent(parent)
+{
+//     std::cerr << key << std::endl; // debug output to show all frontend registered settings...
+}
+
+bool SettingRegistry::settingExists(std::string key) const
+{
+    return settings.find(key) != settings.end();
+}
+
+SettingConfig* SettingRegistry::getSettingConfig(std::string key)
+{
+    auto it = settings.find(key);
+    if (it == settings.end())
+        return nullptr;
+    return it->second;
+}
+
+SettingContainer* SettingRegistry::getCategory(std::string key)
+{
+    for (SettingContainer& cat : categories)
+        if (cat.getKey().compare(key) == 0)
+            return &cat;
+    return nullptr;
+}
+
+
+SettingRegistry::SettingRegistry()
+{
+}
+
+bool SettingRegistry::settingsLoaded()
+{
+    return settings.size() > 0;
+}
+
+int SettingRegistry::loadJSON(std::string filename, rapidjson::Document& json_document)
+{
+    FILE* f = fopen(filename.c_str(), "rb");
+    if (!f)
+    {
+        cura::logError("Couldn't open JSON file.\n");
+        return 1;
+    }
+    char read_buffer[4096];
+    rapidjson::FileReadStream reader_stream(f, read_buffer, sizeof(read_buffer));
+    json_document.ParseStream(reader_stream);
+    fclose(f);
+    if (json_document.HasParseError())
+    {
+        cura::logError("Error parsing JSON(offset %u): %s\n", (unsigned)json_document.GetErrorOffset(), GetParseError_En(json_document.GetParseError()));
+        return 2;
+    }
+    
+    return 0;
+}
+
+int SettingRegistry::loadJSONsettings(std::string filename)
+{
+    rapidjson::Document json_document;
+    
+    int err = loadJSON(filename, json_document);
+    if (err) { return err; }
+    
+    if (json_document.HasMember("inherits"))
+    {
+        std::string filename_copy = std::string(filename.c_str()); // copy the string because dirname(.) changes the input string!!!
+        char* filename_cstr = (char*)filename_copy.c_str();
+        int err = loadJSONsettings(std::string(dirname(filename_cstr)) + std::string("/") + json_document["inherits"].GetString());
+        if (err) { return err; }
+        return loadJSONsettingsFromDoc(json_document, false);
+    }
+    else 
+    {
+        return loadJSONsettingsFromDoc(json_document, true);
+    }
+    
+}
+
+int SettingRegistry::loadJSONsettingsFromDoc(rapidjson::Document& json_document, bool warn_duplicates)
+{
+    
+    if (!json_document.IsObject())
+    {
+        cura::logError("JSON file is not an object.\n");
+        return 3;
+    }
+
+    if (json_document.HasMember("machine_extruder_trains"))
+    {
+        categories.emplace_back("machine_extruder_trains", "Extruder Trains Settings Objects");
+        SettingContainer* category_trains = &categories.back();
+        const rapidjson::Value& trains = json_document["machine_extruder_trains"];
+        if (trains.IsArray()) 
+        {
+            if (trains.Size() > 0 && trains[0].IsObject())
+            {
+                unsigned int idx = 0;
+                for (auto it = trains.Begin(); it != trains.End(); ++it)
+                {
+                    SettingConfig* child = category_trains->addChild(std::to_string(idx), std::to_string(idx));
+                    
+                    for (rapidjson::Value::ConstMemberIterator setting_iterator = it->MemberBegin(); setting_iterator != it->MemberEnd(); ++setting_iterator)
+                    {
+                        _addSettingToContainer(child, setting_iterator, warn_duplicates, false);
+                    }
+                    
+                    idx++;
+                }
+            }
+        }
+        else 
+        {
+            logError("Error: JSON machine_extruder_trains is not an array!\n");
+        }
+    }
+    if (json_document.HasMember("machine_settings"))
+    {
+        categories.emplace_back("machine_settings", "Machine Settings");
+        SettingContainer* category_machine_settings = &categories.back();
+        
+        const rapidjson::Value& json_object_container = json_document["machine_settings"];
+        for (rapidjson::Value::ConstMemberIterator setting_iterator = json_object_container.MemberBegin(); setting_iterator != json_object_container.MemberEnd(); ++setting_iterator)
+        {
+            _addSettingToContainer(category_machine_settings, setting_iterator, warn_duplicates);
+        }
+    }
+    
+    if (json_document.HasMember("categories"))
+    {
+        for (rapidjson::Value::ConstMemberIterator category_iterator = json_document["categories"].MemberBegin(); category_iterator != json_document["categories"].MemberEnd(); ++category_iterator)
+        {
+            if (!category_iterator->value.IsObject())
+            {
+                continue;
+            }
+            if (!category_iterator->value.HasMember("label") || !category_iterator->value["label"].IsString())
+            {
+                continue;
+            }
+            if (!category_iterator->value.HasMember("settings") || !category_iterator->value["settings"].IsObject())
+            {
+                continue;
+            }
+            
+            categories.emplace_back(category_iterator->name.GetString(), category_iterator->value["label"].GetString());
+            SettingContainer* category = &categories.back();
+            
+            const rapidjson::Value& json_object_container = category_iterator->value["settings"];
+            for (rapidjson::Value::ConstMemberIterator setting_iterator = json_object_container.MemberBegin(); setting_iterator != json_object_container.MemberEnd(); ++setting_iterator)
+            {
+                _addSettingToContainer(category, setting_iterator, warn_duplicates);
+            }
+        }
+    }
+    
+    if (false && json_document.HasMember("overrides"))
+    {
+        const rapidjson::Value& json_object_container = json_document["overrides"];
+        for (rapidjson::Value::ConstMemberIterator override_iterator = json_object_container.MemberBegin(); override_iterator != json_object_container.MemberEnd(); ++override_iterator)
+        {
+            SettingConfig* conf = getSettingConfig(override_iterator->name.GetString());
+            _addSettingToContainer(conf, override_iterator, false);
+        }
+    }
+    
+    return 0;
+}
+void SettingRegistry::_addSettingToContainer(SettingContainer* parent, rapidjson::Value::ConstMemberIterator& json_object_it, bool warn_duplicates, bool add_to_settings)
+{
+        const rapidjson::Value& data = json_object_it->value;
+        
+        if (data.HasMember("type") && data["type"].IsString() && 
+            (data["type"].GetString() == std::string("polygon") || data["type"].GetString() == std::string("polygons")))
+        {
+            logWarning("Loading polygon setting %s not implemented...\n", json_object_it->name.GetString());
+            /// When this setting has children, add those children to the parent setting.
+            if (data.HasMember("children") && data["children"].IsObject())
+            {
+                const rapidjson::Value& json_object_container = data["children"];
+                for (rapidjson::Value::ConstMemberIterator setting_iterator = json_object_container.MemberBegin(); setting_iterator != json_object_container.MemberEnd(); ++setting_iterator)
+                {
+                    _addSettingToContainer(parent, setting_iterator, warn_duplicates, add_to_settings);
+                }
+            }
+            return;
+        }
+        
+        std::string label;
+        if (!json_object_it->value.HasMember("label") || !data["label"].IsString())
+        {
+            label = "N/A";
+        }
+        else
+        {
+            label = data["label"].GetString();
+        }
+
+        /// Create the new setting config object.
+        SettingConfig* config = parent->addChild(json_object_it->name.GetString(), label);
+        
+        
+        /// Fill the setting config object with data we have in the json file.
+        if (data.HasMember("type") && data["type"].IsString())
+        {
+            config->setType(data["type"].GetString());
+        }
+        if (data.HasMember("default"))
+        {
+            const rapidjson::Value& dflt = data["default"];
+            if (dflt.IsString())
+            {
+                config->setDefault(dflt.GetString());
+            }
+            else if (dflt.IsTrue())
+            {
+                config->setDefault("true");
+            }
+            else if (dflt.IsFalse())
+            {
+                config->setDefault("false");
+            }
+            else if (dflt.IsNumber())
+            {
+                std::ostringstream ss;
+                ss << dflt.GetDouble();
+                config->setDefault(ss.str());
+            } // arrays are ignored because machine_extruder_trains needs to be handled separately
+            else 
+            {
+                logError("Unrecognized data type in JSON: %s has type %s\n", json_object_it->name.GetString(), toString(dflt.GetType()).c_str());
+            }
+        }
+        if (data.HasMember("unit") && data["unit"].IsString())
+        {
+            config->setUnit(data["unit"].GetString());
+        }
+        
+        /// Register the setting in the settings map lookup.
+        if (warn_duplicates && settingExists(config->getKey()))
+        {
+            cura::logError("Duplicate definition of setting: %s a.k.a. \"%s\" was already claimed by \"%s\"\n", config->getKey().c_str(), config->getLabel().c_str(), getSettingConfig(config->getKey())->getLabel().c_str());
+        }
+        
+        if (add_to_settings)
+        {
+            settings[config->getKey()] = config;
+        }
+
+        /// When this setting has children, add those children to this setting.
+        if (data.HasMember("children") && data["children"].IsObject())
+        {
+            const rapidjson::Value& json_object_container = data["children"];
+            for (rapidjson::Value::ConstMemberIterator setting_iterator = json_object_container.MemberBegin(); setting_iterator != json_object_container.MemberEnd(); ++setting_iterator)
+            {
+                _addSettingToContainer(parent, setting_iterator, warn_duplicates, add_to_settings);
+            }
+        }
+}
+
+
+}//namespace cura

src/settingRegistry.h

@@ -0,0 +1,191 @@
+#ifndef SETTING_REGISTRY_H
+#define SETTING_REGISTRY_H
+
+#include <vector>
+#include <list>
+#include <unordered_map>
+#include <string>
+
+#include "utils/NoCopy.h"
+#include "rapidjson/document.h"
+
+namespace cura
+{
+    
+// Forward declaration
+class SettingConfig;
+
+/*!
+ * Setting category.
+ * Filled from the fdmprinter.json file. Contains one or more children settings.
+ */
+class SettingContainer
+{
+    friend class SettingConfig;
+private:
+    std::string key;
+    std::string label;
+    std::list<SettingConfig> children;
+public:
+    std::string getKey() const { return key; }
+    std::string getLabel() const { return label; }
+    SettingContainer(std::string key, std::string label);
+    
+    SettingConfig* addChild(std::string key, std::string label);
+    
+    /*!
+     * Get the \p idx th child.
+     * 
+     * This is used to get a specific extruder train in Settingsbase::setExtruderTrainDefaults
+     * 
+     * \param idx The index in the list of children
+     * \return The \p idx th child
+     */
+    const SettingConfig* getChild(unsigned int idx) const
+    {
+        if (idx < children.size())
+        {
+            auto it = children.begin();
+            while (idx > 0) { ++it; idx--; }
+            return &*it;
+        }
+        else 
+            return nullptr;
+    }
+};
+
+/*!
+ * Single setting data.
+ * Filled from the fdmprinter.json file. Can contain child settings, and is registered in the
+ * setting registry with it's key.
+ */
+class SettingConfig : public SettingContainer
+{
+private:
+    std::string type;
+    std::string default_value;
+    std::string unit;
+    SettingContainer* parent;
+public:
+    SettingConfig(std::string key, std::string label, SettingContainer* parent);
+    
+    /*!
+     * Get the SettingConfig::children.
+     * 
+     * This is used to get the extruder trains; see Settingsbase::setExtruderTrainDefaults
+     * 
+     * \return SettingConfig::children
+     */
+    const std::list<SettingConfig>& getChildren() const { return children; }
+    
+    std::string getKey() const
+    {
+        return key;
+    }
+    
+    void setType(std::string type)
+    {
+        this->type = type;
+    }
+    
+    std::string getType() const
+    {
+        return type;
+    }
+
+    void setDefault(std::string default_value)
+    {
+        this->default_value = default_value;
+    }
+    
+    std::string getDefaultValue() const
+    {
+        return default_value;
+    }
+
+    void setUnit(std::string unit)
+    {
+        this->unit = unit;
+    }
+    
+    std::string getUnit() const
+    {
+        return unit;
+    }
+};
+
+/*!
+ * Setting registry.
+ * There is a single global setting registry.
+ * This registry contains all known setting keys.
+ * The registry also contains the settings categories to build up the setting hiarcy from the json file.
+ */
+class SettingRegistry : NoCopy
+{
+private:
+    static SettingRegistry instance;
+
+    SettingRegistry();
+    
+    std::unordered_map<std::string, SettingConfig*> settings;
+    std::list<SettingContainer> categories;
+public:
+    /*!
+     * Get the SettingRegistry.
+     * 
+     * This is a singleton class.
+     * 
+     * \return The SettingRegistry
+     */
+    static SettingRegistry* getInstance() { return &instance; }
+    
+    bool settingExists(std::string key) const;
+    SettingConfig* getSettingConfig(std::string key);
+    
+    /*!
+     * Return the first category with the given key as name, or a null pointer.
+     * 
+     * \param key the key as it is in the JSON file
+     * \return The first category in the list having the \p key
+     */
+    SettingContainer* getCategory(std::string key);
+    
+    bool settingsLoaded();
+    /*!
+     * Load settings from a json file and all the parents it inherits from.
+     * 
+     * Uses recursion to load the parent json file.
+     * 
+     * \param filename The filename of the json file to parse
+     * \return an error code or zero of succeeded
+     */
+    int loadJSONsettings(std::string filename);
+    
+private:
+    std::string toString(rapidjson::Type type);
+    /*!
+     * Load a json document.
+     * 
+     * \param filename The filename of the json file to parse
+     * \param json_document (output) the document to be loaded
+     * \return an error code or zero of succeeded
+     */
+    int loadJSON(std::string filename, rapidjson::Document& json_document);
+    
+    /*!
+     * Load settings from a single json file.
+     * 
+     * \param filename The filename of the json file to parse
+     * \param warn_duplicates whether to warn for duplicate definitions
+     * \return an error code or zero of succeeded
+     */
+    int loadJSONsettingsFromDoc(rapidjson::Document& json_document, bool warn_duplicates);
+    
+    /*!
+     * \param warn_duplicates whether to warn for duplicate definitions
+     */
+    void _addSettingToContainer(SettingContainer* parent, rapidjson::Value::ConstMemberIterator& json_object_it, bool warn_duplicates, bool add_to_settings = true);
+};
+
+}//namespace cura
+#endif//SETTING_REGISTRY_H

src/settings.cpp

@@ -0,0 +1,262 @@
+#include <cctype>
+#include <fstream>
+#include <stdio.h>
+#include <sstream> // ostringstream
+#include "utils/logoutput.h"
+
+#include "settings.h"
+#include "settingRegistry.h"
+
+namespace cura
+{
+//c++11 no longer defines M_PI, so add our own constant.
+#ifndef M_PI
+#define M_PI 3.14159265358979323846
+#endif
+
+SettingsBaseVirtual::SettingsBaseVirtual()
+: parent(NULL)
+{
+}
+
+SettingsBaseVirtual::SettingsBaseVirtual(SettingsBaseVirtual* parent)
+: parent(parent)
+{
+}
+
+SettingsBase::SettingsBase()
+: SettingsBaseVirtual(NULL)
+{
+}
+
+SettingsBase::SettingsBase(SettingsBaseVirtual* parent)
+: SettingsBaseVirtual(parent)
+{
+}
+
+SettingsMessenger::SettingsMessenger(SettingsBaseVirtual* parent)
+: SettingsBaseVirtual(parent)
+{
+}
+
+void SettingsBase::setSetting(std::string key, std::string value)
+{
+    if (SettingRegistry::getInstance()->settingExists(key))
+    {
+        setting_values[key] = value;
+    }
+    else
+    {
+        cura::logError("Warning: setting an unregistered setting %s\n", key.c_str() );
+        setting_values[key] = value; // Handy when programmers are in the process of introducing a new setting
+    }
+}
+
+std::string SettingsBase::getSettingString(std::string key)
+{
+    if (setting_values.find(key) != setting_values.end())
+    {
+        return setting_values[key];
+    }
+    if (parent)
+    {
+        return parent->getSettingString(key);
+    }
+    
+    if (SettingRegistry::getInstance()->settingExists(key))
+    {
+        setting_values[key] = SettingRegistry::getInstance()->getSettingConfig(key)->getDefaultValue();
+    }
+    else
+    {
+        setting_values[key] = "";
+        cura::logError("Unregistered setting %s\n", key.c_str());
+    }
+    return setting_values[key];
+}
+
+void SettingsMessenger::setSetting(std::string key, std::string value)
+{
+    parent->setSetting(key, value);
+}
+
+std::string SettingsMessenger::getSettingString(std::string key)
+{
+    return parent->getSettingString(key);
+}
+
+
+void SettingsBase::setExtruderTrainDefaults(unsigned int extruder_nr)
+{
+    const SettingContainer* machine_extruder_trains = SettingRegistry::getInstance()->getCategory(std::string("machine_extruder_trains"));
+    
+    if (!machine_extruder_trains) 
+    {
+        logWarning("Error: no machine_extruder_trains category found in JSON!\n");
+        return;
+    }
+    
+    const SettingConfig* train = machine_extruder_trains->getChild(extruder_nr);
+    
+    if (!train)
+    {
+        logError("Not enough extruder trains specified in JSON: %i\n", extruder_nr);
+        return;
+    }
+    
+    for (const SettingConfig& setting : train->getChildren())
+    {
+        if (setting_values.find(setting.getKey()) == setting_values.end())
+        {
+            setSetting(setting.getKey(), setting.getDefaultValue());
+        }
+    }
+}
+
+int SettingsBaseVirtual::getSettingAsIndex(std::string key)
+{
+    std::string value = getSettingString(key);
+    return atoi(value.c_str());
+}
+
+int SettingsBaseVirtual::getSettingAsCount(std::string key)
+{
+    std::string value = getSettingString(key);
+    return atoi(value.c_str());
+}
+
+int SettingsBaseVirtual::getSettingInMicrons(std::string key)
+{
+    std::string value = getSettingString(key);
+    return atof(value.c_str()) * 1000.0;
+}
+
+double SettingsBaseVirtual::getSettingInAngleRadians(std::string key)
+{
+    std::string value = getSettingString(key);
+    return atof(value.c_str()) / 180.0 * M_PI;
+}
+
+bool SettingsBaseVirtual::getSettingBoolean(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "on")
+        return true;
+    if (value == "yes")
+        return true;
+    if (value == "true" or value == "True") //Python uses "True"
+        return true;
+    int num = atoi(value.c_str());
+    return num != 0;
+}
+
+double SettingsBaseVirtual::getSettingInDegreeCelsius(std::string key)
+{
+    std::string value = getSettingString(key);
+    return atof(value.c_str());
+}
+
+double SettingsBaseVirtual::getSettingInMillimetersPerSecond(std::string key)
+{
+    std::string value = getSettingString(key);
+    return std::max(1.0, atof(value.c_str()));
+}
+
+double SettingsBaseVirtual::getSettingInCubicMillimeters(std::string key)
+{
+    std::string value = getSettingString(key);
+    return std::max(0.0, atof(value.c_str()));
+}
+
+double SettingsBaseVirtual::getSettingInPercentage(std::string key)
+{
+    std::string value = getSettingString(key);
+    return std::max(0.0, atof(value.c_str()));
+}
+
+double SettingsBaseVirtual::getSettingInSeconds(std::string key)
+{
+    std::string value = getSettingString(key);
+    return std::max(0.0, atof(value.c_str()));
+}
+
+EGCodeFlavor SettingsBaseVirtual::getSettingAsGCodeFlavor(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "RepRap")
+        return EGCodeFlavor::REPRAP;
+    else if (value == "UltiGCode")
+        return EGCodeFlavor::ULTIGCODE;
+    else if (value == "Makerbot")
+        return EGCodeFlavor::MAKERBOT;
+    else if (value == "BFB")
+        return EGCodeFlavor::BFB;
+    else if (value == "MACH3")
+        return EGCodeFlavor::MACH3;
+    else if (value == "RepRap (Volumatric)")
+        return EGCodeFlavor::REPRAP_VOLUMATRIC;
+    return EGCodeFlavor::REPRAP;
+}
+
+EFillMethod SettingsBaseVirtual::getSettingAsFillMethod(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "lines")
+        return EFillMethod::LINES;
+    if (value == "grid")
+        return EFillMethod::GRID;
+    if (value == "triangles")
+        return EFillMethod::TRIANGLES;
+    if (value == "concentric")
+        return EFillMethod::CONCENTRIC;
+    if (value == "zigzag")
+        return EFillMethod::ZIG_ZAG;
+    return EFillMethod::NONE;
+}
+
+EPlatformAdhesion SettingsBaseVirtual::getSettingAsPlatformAdhesion(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "brim")
+        return EPlatformAdhesion::BRIM;
+    if (value == "raft")
+        return EPlatformAdhesion::RAFT;
+    return EPlatformAdhesion::SKIRT;
+}
+
+ESupportType SettingsBaseVirtual::getSettingAsSupportType(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "everywhere")
+        return ESupportType::EVERYWHERE;
+    if (value == "touching_buildplate")
+        return ESupportType::PLATFORM_ONLY;
+    return ESupportType::NONE;
+}
+
+EZSeamType SettingsBaseVirtual::getSettingAsZSeamType(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "random")
+        return EZSeamType::RANDOM;
+    if (value == "shortest")
+        return EZSeamType::SHORTEST;
+    if (value == "back")
+        return EZSeamType::BACK;
+    return EZSeamType::SHORTEST;
+}
+
+ESurfaceMode SettingsBaseVirtual::getSettingAsSurfaceMode(std::string key)
+{
+    std::string value = getSettingString(key);
+    if (value == "normal")
+        return ESurfaceMode::NORMAL;
+    if (value == "surface")
+        return ESurfaceMode::SURFACE;
+    if (value == "both")
+        return ESurfaceMode::BOTH;
+    return ESurfaceMode::NORMAL;
+}
+
+
+}//namespace cura

src/settings.h

@@ -1,15 +1,12 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef SETTINGS_SETTINGS_H
-#define SETTINGS_SETTINGS_H
+#ifndef SETTINGS_H
+#define SETTINGS_H
 
 #include <vector>
 #include <map>
 #include <unordered_map>
 #include <sstream>
 
-#include "../utils/floatpoint.h"
-
-#include "../FlowTempGraph.h"
+#include "utils/floatpoint.h"
 
 namespace cura
 {
@@ -76,23 +73,8 @@ enum class EGCodeFlavor
  *  M106 Sxxx and M107 are used to turn the fan on/off.
  **/
     REPRAP_VOLUMATRIC = 5,
-/**
- * Griffin flavored is Marlin based GCode.
- *  This is a type of RepRap used for machines with multiple extruder trains.
- *  G0 for moves, G1 for extrusion.
- *  E values give mm of filament extrusion.
- *  E values are stored separately per extruder train.
- *  Retraction is done on E values with G1. Start/end code is added.
- *  M227 is used to initialize a single extrusion train.
- **/
-    GRIFFIN = 6,
 };
 
-/*!
- * Converts a gcode flavor type to string so that it can be included in the gcode.
- */
-std::string toString(EGCodeFlavor flavor);
-
 /*!
  * In Cura different infill methods are available.
  * This enum defines which fill patterns are available to get a uniform naming troughout the engine.
@@ -142,19 +124,6 @@ enum class ESurfaceMode
     BOTH
 };
 
-enum class CombingMode
-{
-    OFF,
-    ALL,
-    NO_SKIN
-};
-
-enum class SupportDistPriority
-{
-    XY_OVERRIDES_Z,
-    Z_OVERRIDES_XY
-};
-
 #define MAX_EXTRUDERS 16
 
 //Maximum number of infill layers that can be combined into a single infill extrusion area.
@@ -172,8 +141,7 @@ class SettingsBaseVirtual
 protected:
     SettingsBaseVirtual* parent;
 public:
-    virtual std::string getSettingString(std::string key) const = 0;
-    virtual std::string _getSettingString(std::string key) const = 0;
+    virtual std::string getSettingString(std::string key) = 0;
     
     virtual void setSetting(std::string key, std::string value) = 0;
     
@@ -185,32 +153,26 @@ public:
     void setParent(SettingsBaseVirtual* parent) { this->parent = parent; }
     SettingsBaseVirtual* getParent() { return parent; }
     
-    int getSettingAsIndex(std::string key) const;
-    int getSettingAsCount(std::string key) const;
+    int getSettingAsIndex(std::string key);
+    int getSettingAsCount(std::string key);
     
-    double getSettingInAngleRadians(std::string key) const;
-    double getSettingInMillimeters(std::string key) const;
-    int getSettingInMicrons(std::string key) const;
-    bool getSettingBoolean(std::string key) const;
-    double getSettingInDegreeCelsius(std::string key) const;
-    double getSettingInMillimetersPerSecond(std::string key) const;
-    double getSettingInCubicMillimeters(std::string key) const;
-    double getSettingInPercentage(std::string key) const;
-    double getSettingInSeconds(std::string key) const;
+    double getSettingInAngleRadians(std::string key);
+    int getSettingInMicrons(std::string key);
+    bool getSettingBoolean(std::string key);
+    double getSettingInDegreeCelsius(std::string key);
+    double getSettingInMillimetersPerSecond(std::string key);
+    double getSettingInCubicMillimeters(std::string key);
+    double getSettingInPercentage(std::string key);
+    double getSettingInSeconds(std::string key);
     
-    FlowTempGraph getSettingAsFlowTempGraph(std::string key) const;
-    
-    EGCodeFlavor getSettingAsGCodeFlavor(std::string key) const;
-    EFillMethod getSettingAsFillMethod(std::string key) const;
-    EPlatformAdhesion getSettingAsPlatformAdhesion(std::string key) const;
-    ESupportType getSettingAsSupportType(std::string key) const;
-    EZSeamType getSettingAsZSeamType(std::string key) const;
-    ESurfaceMode getSettingAsSurfaceMode(std::string key) const;
-    CombingMode getSettingAsCombingMode(std::string key);
-    SupportDistPriority getSettingAsSupportDistPriority(std::string key);
+    EGCodeFlavor getSettingAsGCodeFlavor(std::string key);
+    EFillMethod getSettingAsFillMethod(std::string key);
+    EPlatformAdhesion getSettingAsPlatformAdhesion(std::string key);
+    ESupportType getSettingAsSupportType(std::string key);
+    EZSeamType getSettingAsZSeamType(std::string key);
+    ESurfaceMode getSettingAsSurfaceMode(std::string key);
 };
 
-class SettingRegistry;
 /*!
  * Base class for every object that can hold settings.
  * The SettingBase object can hold multiple key-value pairs that define settings.
@@ -220,24 +182,26 @@ class SettingRegistry;
  */
 class SettingsBase : public SettingsBaseVirtual
 {
-    friend class SettingRegistry;
 private:
     std::unordered_map<std::string, std::string> setting_values;
-    std::string level_id; //!< The name of the level at which this is retrieved "global", "extruder-1", etc.
 public:
-    SettingsBase(std::string level_id); //!< SettingsBase without a parent settings object
-    SettingsBase(SettingsBaseVirtual* parent, std::string level_id); //!< construct a SettingsBase with a parent settings object
-
-    /*!
-     * Set a setting to a value.
-     * \param key the setting
-     * \param value the value
-     */
-    void setSetting(std::string key, std::string value);
-    std::string getSettingString(std::string key) const; //!< Get a setting from this SettingsBase (or any ancestral SettingsBase)
-    std::string _getSettingString(std::string key) const; //!< Get a setting from this SettingsBase (or any ancestral SettingsBase)
+    SettingsBase(); //!< SettingsBase without a parent settings object
+    SettingsBase(SettingsBaseVirtual* parent); //!< construct a SettingsBase with a parent settings object
     
-    std::string getAllLocalSettingsString() const
+    /*!
+     * Retrieve the defaults for each extruder train from the machine_extruder_trains settings 
+     * and set the general settings to those defaults if they haven't been set yet.
+     * 
+     * Only sets those settings which haven't already been set on that level - not looking at its parent (FffProcessor, meshgroup) or children (meshes).
+     * 
+     * \param extruder_nr The index of which extruder train in machine_extruder_trains to get the settings from
+     */
+    void setExtruderTrainDefaults(unsigned int extruder_nr);
+    
+    void setSetting(std::string key, std::string value);
+    std::string getSettingString(std::string key); //!< Get a setting from this SettingsBase (or any ancestral SettingsBase)
+    
+    std::string getAllLocalSettingsString()
     {
         std::stringstream sstream;
         for (auto pair : setting_values)
@@ -250,18 +214,11 @@ public:
         return sstream.str();
     }
     
-    void debugOutputAllLocalSettings()  const
+    void debugOutputAllLocalSettings() 
     {
         for (auto pair : setting_values)
             std::cerr << pair.first << " : " << pair.second << std::endl;
     }
-protected:
-    /*!
-     * Set a setting without checking if it's registered.
-     * 
-     * Used in SettingsRegistry
-     */
-    void _setSetting(std::string key, std::string value);
 };
 
 /*!
@@ -275,11 +232,9 @@ public:
     SettingsMessenger(SettingsBaseVirtual* parent); //!< construct a SettingsMessenger with a parent settings object
     
     void setSetting(std::string key, std::string value); //!< Set a setting of the parent SettingsBase to a given value
-    std::string getSettingString(std::string key) const; //!< Get a setting from the parent SettingsBase (or any further ancestral SettingsBase)
-    std::string _getSettingString(std::string key) const; //!< Get a setting from the parent SettingsBase (or any further ancestral SettingsBase)
+    std::string getSettingString(std::string key); //!< Get a setting from the parent SettingsBase (or any further ancestral SettingsBase)
 };
 
 
 }//namespace cura
-#endif//SETTINGS_SETTINGS_H
-
+#endif//SETTINGS_H

src/settings/SettingConfig.cpp

@@ -1,14 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "SettingConfig.h"
-
-
-namespace cura
-{
-
-SettingConfig::SettingConfig(std::string key, std::string label)
-: SettingContainer(key, label)
-{
-//     std::cerr << key << std::endl; // debug output to show all frontend registered settings...
-}
-
-}//namespace cura

src/settings/SettingConfig.h

@@ -1,76 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef SETTINGS_SETTING_CONFIG_H
-#define SETTINGS_SETTING_CONFIG_H
-
-#include <string>
-#include <iostream> // debug out
-
-#include "SettingContainer.h"
-
-#include "../utils/NoCopy.h"
-#include "rapidjson/document.h"
-
-namespace cura
-{
-
-/*!
- * Single setting data.
- * Filled from the fdmprinter.json file. Can contain child settings, and is registered in the
- * setting registry with it's key.
- */
-class SettingConfig : public SettingContainer
-{
-private:
-    std::string type; //!< The type of the default_value, e.g. str, int, bool
-    std::string default_value; //!< The default value for this setting
-    std::string unit; //!< The unit of the physical quantity in which this setting is measured, e.g. "mm", "mm/s", ""
-public:
-    SettingConfig(std::string key, std::string label);
-
-    std::string getKey() const
-    {
-        return key;
-    }
-    
-    void setType(std::string type)
-    {
-        this->type = type;
-    }
-    
-    std::string getType() const
-    {
-        return type;
-    }
-
-    void setDefault(std::string default_value)
-    {
-        this->default_value = default_value;
-    }
-    
-    std::string getDefaultValue() const
-    {
-        return default_value;
-    }
-
-    void setUnit(std::string unit)
-    {
-        this->unit = unit;
-    }
-    
-    std::string getUnit() const
-    {
-        return unit;
-    }
-    
-    void debugOutputAllSettings() const
-    {
-        std::cerr << key <<  "(" << default_value << ")" << std::endl;
-        for (const SettingConfig& child : children)
-        {
-            child.debugOutputAllSettings();
-        }
-    }
-};
-
-}//namespace cura
-#endif//SETTINGS_SETTING_CONFIG_H

src/settings/SettingContainer.cpp

@@ -1,47 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "SettingContainer.h"
-#include "SettingConfig.h"
-
-#include <string>
-#include <algorithm> // find_if
-
-namespace cura
-{
-
-SettingContainer::SettingContainer(std::string key, std::string label)
-: key(key)
-, label(label)
-{
-}
-
-SettingConfig* SettingContainer::addChild(std::string key, std::string label)
-{
-    children.emplace_back(key, label);
-    return &children.back();
-}
-
-SettingConfig& SettingContainer::getOrCreateChild(std::string key, std::string label)
-{
-    auto child_it = std::find_if(children.begin(), children.end(), [&key](SettingConfig& child) { return child.key == key; } );
-    if (child_it == children.end())
-    {
-        children.emplace_back(key, label);
-        return children.back();
-    }
-    else
-    {
-        return *child_it;
-    }
-}
-
-
-void SettingContainer::debugOutputAllSettings() const
-{
-    std::cerr << "\nSETTINGS BASE: " << key << std::endl;
-    for (const SettingConfig& child : children)
-    {
-        child.debugOutputAllSettings();
-    }
-}
-
-}//namespace cura

src/settings/SettingContainer.h

@@ -1,83 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef SETTINGS_SETTING_CONTAINER_H
-#define SETTINGS_SETTING_CONTAINER_H
-
-#include <vector>
-#include <list>
-#include <unordered_map>
-#include <string>
-#include <iostream> // debug out
-
-#include "../utils/NoCopy.h"
-#include "rapidjson/document.h"
-
-namespace cura
-{
-    
-// Forward declaration
-class SettingConfig;
-class SettingRegistry;
-
-/*!
- * Setting container for a settings base of definitions and default values.
- * Filled from the .def.json files. Contains one or more children settings.
- */
-class SettingContainer
-{
-    friend class SettingConfig;
-    friend class SettingRegistry;
-private:
-    std::string key;
-    std::string label;
-    std::list<SettingConfig> children; // must be a list cause the pointers to individual children are mapped to in SettingRegistry::settings.
-    std::list<std::string> path; //!< The path of parents (internal names) to this container
-public:
-    std::string getKey() const { return key; }
-    std::string getLabel() const { return label; }
-    SettingContainer(std::string key, std::string label);
-    
-    /*!
-     * Get the SettingConfig::children.
-     * 
-     * This is used to get the extruder trains; see Settingsbase::setExtruderTrainDefaults
-     * 
-     * \return SettingConfig::children
-     */
-    const std::list<SettingConfig>& getChildren() const { return children; }
-    
-    SettingConfig* addChild(std::string key, std::string label);
-    
-    /*!
-     * Get the \p idx th child.
-     * 
-     * This is used to get a specific extruder train in Settingsbase::setExtruderTrainDefaults
-     * 
-     * \param idx The index in the list of children
-     * \return The \p idx th child
-     */
-    const SettingConfig* getChild(unsigned int idx) const
-    {
-        if (idx < children.size())
-        {
-            auto it = children.begin();
-            while (idx > 0) { ++it; idx--; }
-            return &*it;
-        }
-        else 
-            return nullptr;
-    }
-
-private:
-    /*!
-     * Get the (direct) child with key \p key, or create one with key \p key and label \p label as well.
-     * 
-     * \param key the key
-     * \param label the label for creating a new child
-     * \return The existing or newly created child setting.
-     */
-    SettingConfig& getOrCreateChild(std::string key, std::string label);
-public:
-    void debugOutputAllSettings() const;
-};
-}//namespace cura
-#endif//SETTINGS_SETTING_CONTAINER_H

src/settings/SettingRegistry.cpp

@@ -1,392 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include "SettingRegistry.h"
-
-#include <sstream>
-#include <iostream> // debug IO
-#include <libgen.h> // dirname
-#include <string>
-#include <cstring> // strtok (split string using delimiters) strcpy
-#include <fstream> // ifstream (to see if file exists)
-
-#include "rapidjson/rapidjson.h"
-#include "rapidjson/document.h"
-#include "rapidjson/error/en.h"
-#include "rapidjson/filereadstream.h"
-#include "../utils/logoutput.h"
-
-namespace cura
-{
-    
-SettingRegistry SettingRegistry::instance; // define settingRegistry
-
-std::string SettingRegistry::toString(rapidjson::Type type)
-{
-    switch (type)
-    {
-        case rapidjson::Type::kNullType: return "null";
-        case rapidjson::Type::kFalseType: return "false";
-        case rapidjson::Type::kTrueType: return "true";
-        case rapidjson::Type::kObjectType: return "object";
-        case rapidjson::Type::kArrayType: return "array";
-        case rapidjson::Type::kStringType: return "string";
-        case rapidjson::Type::kNumberType: return "number";
-        default: return "Unknown";
-    }
-}
-
-
-SettingConfig::SettingConfig(std::string key, std::string label)
-: SettingContainer(key, label)
-{
-//     std::cerr << key << std::endl; // debug output to show all frontend registered settings...
-}
-
-bool SettingRegistry::settingExists(std::string key) const
-{
-    return setting_key_to_config.find(key) != setting_key_to_config.end();
-}
-
-SettingConfig* SettingRegistry::getSettingConfig(std::string key) const
-{
-    auto it = setting_key_to_config.find(key);
-    if (it == setting_key_to_config.end())
-        return nullptr;
-    return it->second;
-}
-
-SettingRegistry::SettingRegistry()
-: setting_definitions("settings", "Settings")
-{
-    // load search paths from environment variable CURA_ENGINE_SEARCH_PATH
-    char* paths = getenv("CURA_ENGINE_SEARCH_PATH");
-    if (paths)
-    {
-#if defined(__linux__) || (defined(__APPLE__) && defined(__MACH__))
-        char delims[] = ":"; // colon
-#else
-        char delims[] = ";"; // semicolon
-#endif
-        char* path = strtok(paths, delims); // search for next path delimited by any of the characters in delims
-        while (path != NULL)
-        {
-            search_paths.emplace(path);
-            path = strtok(NULL, ";:,"); // continue searching in last call to strtok
-        }
-    }
-}
-
-int SettingRegistry::loadJSON(std::string filename, rapidjson::Document& json_document)
-{
-    FILE* f = fopen(filename.c_str(), "rb");
-    if (!f)
-    {
-        cura::logError("Couldn't open JSON file.\n");
-        return 1;
-    }
-    char read_buffer[4096];
-    rapidjson::FileReadStream reader_stream(f, read_buffer, sizeof(read_buffer));
-    json_document.ParseStream(reader_stream);
-    fclose(f);
-    if (json_document.HasParseError())
-    {
-        cura::logError("Error parsing JSON(offset %u): %s\n", (unsigned)json_document.GetErrorOffset(), GetParseError_En(json_document.GetParseError()));
-        return 2;
-    }
-
-    return 0;
-}
-
-/*!
- * Check whether a file exists.
- * from https://techoverflow.net/blog/2013/01/11/cpp-check-if-file-exists/
- * 
- * \param filename The path to a filename to check if it exists
- * \return Whether the file exists.
- */
-bool fexists(const char *filename)
-{
-    std::ifstream ifile(filename);
-    return (bool)ifile;
-}
-
-bool SettingRegistry::getDefinitionFile(const std::string machine_id, std::string& result)
-{
-    for (const std::string& search_path : search_paths)
-    {
-        result = search_path + std::string("/") + machine_id + std::string(".def.json");
-        if (fexists(result.c_str()))
-        {
-            return true;
-        }
-    }
-    return false;
-}
-
-
-int SettingRegistry::loadExtruderJSONsettings(unsigned int extruder_nr, SettingsBase* settings_base)
-{
-    if (extruder_nr >= extruder_train_ids.size())
-    {
-        return -1;
-    }
-    
-    std::string definition_file;
-    bool found = getDefinitionFile(extruder_train_ids[extruder_nr], definition_file);
-    if (!found)
-    {
-        return -1;
-    }
-    bool warn_base_file_duplicates = false;
-    return loadJSONsettings(definition_file, settings_base, warn_base_file_duplicates);
-}
-
-int SettingRegistry::loadJSONsettings(std::string filename, SettingsBase* settings_base, bool warn_base_file_duplicates)
-{
-    rapidjson::Document json_document;
-    
-    log("Loading %s...\n", filename.c_str());
-
-    int err = loadJSON(filename, json_document);
-    if (err) { return err; }
-
-    { // add parent folder to search paths
-        char filename_cstr[500];
-        std::strcpy(filename_cstr, filename.c_str()); // copy the string because dirname(.) changes the input string!!!
-        std::string folder_name = std::string(dirname(filename_cstr));
-        search_paths.emplace(folder_name);
-    }
-
-    if (json_document.HasMember("inherits") && json_document["inherits"].IsString())
-    {
-        std::string child_filename;
-        bool found = getDefinitionFile(json_document["inherits"].GetString(), child_filename);
-        if (!found)
-        {
-            return -1;
-        }
-        err = loadJSONsettings(child_filename, settings_base, warn_base_file_duplicates); // load child first
-        if (err)
-        {
-            return err;
-        }
-        err = loadJSONsettingsFromDoc(json_document, settings_base, false);
-    }
-    else 
-    {
-        err = loadJSONsettingsFromDoc(json_document, settings_base, warn_base_file_duplicates);
-    }
-
-    if (json_document.HasMember("metadata") && json_document["metadata"].IsObject())
-    {
-        const rapidjson::Value& json_metadata = json_document["metadata"];
-        if (json_metadata.HasMember("machine_extruder_trains") && json_metadata["machine_extruder_trains"].IsObject())
-        {
-            const rapidjson::Value& json_machine_extruder_trains = json_metadata["machine_extruder_trains"];
-            for (rapidjson::Value::ConstMemberIterator extr_train_iterator = json_machine_extruder_trains.MemberBegin(); extr_train_iterator != json_machine_extruder_trains.MemberEnd(); ++extr_train_iterator)
-            {
-                int extruder_train_nr = atoi(extr_train_iterator->name.GetString());
-                if (extruder_train_nr < 0)
-                {
-                    continue;
-                }
-                const rapidjson::Value& json_id = extr_train_iterator->value;
-                if (!json_id.IsString())
-                {
-                    continue;
-                }
-                const char* id = json_id.GetString();
-                if (extruder_train_nr >= (int) extruder_train_ids.size())
-                {
-                    extruder_train_ids.resize(extruder_train_nr + 1);
-                }
-                extruder_train_ids[extruder_train_nr] = std::string(id);
-            }
-        }
-    }
-
-    return err;
-}
-
-int SettingRegistry::loadJSONsettingsFromDoc(rapidjson::Document& json_document, SettingsBase* settings_base, bool warn_duplicates)
-{
-    
-    if (!json_document.IsObject())
-    {
-        cura::logError("JSON file is not an object.\n");
-        return 3;
-    }
-
-    { // handle machine name
-        std::string machine_name = "Unknown";
-        if (json_document.HasMember("name"))
-        {
-            const rapidjson::Value& machine_name_field = json_document["name"];
-            if (machine_name_field.IsString())
-            {
-                machine_name = machine_name_field.GetString();
-            }
-        }
-        SettingConfig& machine_name_setting = addSetting("machine_name", "Machine Name");
-        machine_name_setting.setDefault(machine_name);
-        machine_name_setting.setType("string");
-        settings_base->_setSetting(machine_name_setting.getKey(), machine_name_setting.getDefaultValue());
-    }
-
-    if (json_document.HasMember("settings"))
-    {
-        std::list<std::string> path;
-        handleChildren(json_document["settings"], path, settings_base, warn_duplicates);
-    }
-    
-    if (json_document.HasMember("overrides"))
-    {
-        const rapidjson::Value& json_object_container = json_document["overrides"];
-        for (rapidjson::Value::ConstMemberIterator override_iterator = json_object_container.MemberBegin(); override_iterator != json_object_container.MemberEnd(); ++override_iterator)
-        {
-            std::string setting = override_iterator->name.GetString();
-            SettingConfig* conf = getSettingConfig(setting);
-            if (!conf) //Setting could not be found.
-            {
-                logWarning("Trying to override unknown setting %s.\n", setting.c_str());
-                continue;
-            }
-            _loadSettingValues(conf, override_iterator, settings_base);
-        }
-    }
-    
-    return 0;
-}
-
-void SettingRegistry::handleChildren(const rapidjson::Value& settings_list, std::list<std::string>& path, SettingsBase* settings_base, bool warn_duplicates)
-{
-    if (!settings_list.IsObject())
-    {
-        logError("ERROR: json settings list is not an object!\n");
-        return;
-    }
-    for (rapidjson::Value::ConstMemberIterator setting_iterator = settings_list.MemberBegin(); setting_iterator != settings_list.MemberEnd(); ++setting_iterator)
-    {
-        handleSetting(setting_iterator, path, settings_base, warn_duplicates);
-        if (setting_iterator->value.HasMember("children"))
-        {
-            std::list<std::string> path_here = path;
-            path_here.push_back(setting_iterator->name.GetString());
-            handleChildren(setting_iterator->value["children"], path_here, settings_base, warn_duplicates);
-        }
-    }
-}
-
-bool SettingRegistry::settingIsUsedByEngine(const rapidjson::Value& setting)
-{
-    if (setting.HasMember("children"))
-    {
-        return false;
-    }
-    else
-    {
-        return true;
-    }
-}
-
-
-void SettingRegistry::handleSetting(const rapidjson::Value::ConstMemberIterator& json_setting_it, std::list<std::string>& path, SettingsBase* settings_base, bool warn_duplicates)
-{
-    const rapidjson::Value& json_setting = json_setting_it->value;
-    if (!json_setting.IsObject())
-    {
-        logError("ERROR: json setting is not an object!\n");
-        return;
-    }
-    std::string name = json_setting_it->name.GetString();
-    if (json_setting.HasMember("type") && json_setting["type"].IsString() && json_setting["type"].GetString() == std::string("category"))
-    { // skip category objects
-        return;
-    }
-    if (settingIsUsedByEngine(json_setting))
-    {
-        if (!json_setting.HasMember("label") || !json_setting["label"].IsString())
-        {
-            logError("ERROR: json setting \"%s\" has no label!\n", name.c_str());
-            return;
-        }
-        std::string label = json_setting["label"].GetString();
-        
-        SettingConfig* setting = getSettingConfig(name);
-        if (warn_duplicates && setting)
-        {
-            cura::logError("Duplicate definition of setting: %s a.k.a. \"%s\" was already claimed by \"%s\"\n", name.c_str(), label.c_str(), getSettingConfig(name)->getLabel().c_str());
-        }
-        if (!setting)
-        {
-            setting = &addSetting(name, label);
-        }
-        _loadSettingValues(setting, json_setting_it, settings_base);
-    }
-}
-
-SettingConfig& SettingRegistry::addSetting(std::string name, std::string label)
-{
-    SettingConfig* config = setting_definitions.addChild(name, label);
-
-    setting_key_to_config[name] = config;
-
-    return *config;
-}
-
-void SettingRegistry::loadDefault(const rapidjson::GenericValue< rapidjson::UTF8< char > >::ConstMemberIterator& json_object_it, SettingConfig* config)
-{
-    const rapidjson::Value& setting_content = json_object_it->value;
-    if (setting_content.HasMember("default_value"))
-    {
-        const rapidjson::Value& dflt = setting_content["default_value"];
-        if (dflt.IsString())
-        {
-            config->setDefault(dflt.GetString());
-        }
-        else if (dflt.IsTrue())
-        {
-            config->setDefault("true");
-        }
-        else if (dflt.IsFalse())
-        {
-            config->setDefault("false");
-        }
-        else if (dflt.IsNumber())
-        {
-            std::ostringstream ss;
-            ss << dflt.GetDouble();
-            config->setDefault(ss.str());
-        } // arrays are ignored because machine_extruder_trains needs to be handled separately
-        else 
-        {
-            logWarning("WARNING: Unrecognized data type in JSON: %s has type %s\n", json_object_it->name.GetString(), toString(dflt.GetType()).c_str());
-        }
-    }
-}
-
-
-void SettingRegistry::_loadSettingValues(SettingConfig* config, const rapidjson::GenericValue< rapidjson::UTF8< char > >::ConstMemberIterator& json_object_it, SettingsBase* settings_base)
-{
-    const rapidjson::Value& data = json_object_it->value;
-    /// Fill the setting config object with data we have in the json file.
-    if (data.HasMember("type") && data["type"].IsString())
-    {
-        config->setType(data["type"].GetString());
-    }
-    if (config->getType() == std::string("polygon") || config->getType() == std::string("polygons"))
-    { // skip polygon settings : not implemented yet and not used yet (TODO)
-//         logWarning("WARNING: Loading polygon setting %s not implemented...\n", json_object_it->name.GetString());
-        return;
-    }
-
-    loadDefault(json_object_it, config);
-
-    if (data.HasMember("unit") && data["unit"].IsString())
-    {
-        config->setUnit(data["unit"].GetString());
-    }
-
-    settings_base->_setSetting(config->getKey(), config->getDefaultValue());
-}
-
-}//namespace cura

src/settings/SettingRegistry.h

@@ -1,191 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef SETTINGS_SETTING_REGISTRY_H
-#define SETTINGS_SETTING_REGISTRY_H
-
-#include <vector>
-#include <unordered_set>
-#include <list>
-#include <unordered_map>
-#include <string>
-#include <iostream> // debug out
-
-#include "SettingConfig.h"
-#include "SettingContainer.h"
-
-#include "../utils/NoCopy.h"
-#include "rapidjson/document.h"
-#include "settings.h"
-
-namespace cura
-{
-
-/*!
- * Setting registry.
- * There is a single global setting registry.
- * This registry contains all known setting keys and (some of) their attributes.
- * The default values are stored and retrieved in case a given setting doesn't get a value from the command line or the frontend.
- */
-class SettingRegistry : NoCopy
-{
-private:
-    static SettingRegistry instance;
-
-    SettingRegistry();
-    
-    std::unordered_map<std::string, SettingConfig*> setting_key_to_config; //!< Mapping from setting keys to their configurations
-
-    SettingContainer setting_definitions; //!< All setting configurations (A flat list)
-    
-    std::vector<std::string> extruder_train_ids; //!< The internal id's of each extruder (the filename without the extension)
-
-    std::unordered_set<std::string> search_paths; //!< The paths to search for json files.
-public:
-    /*!
-     * Get the SettingRegistry.
-     * 
-     * This is a singleton class.
-     * 
-     * \return The SettingRegistry
-     */
-    static SettingRegistry* getInstance() { return &instance; }
-    
-    /*!
-     * Check whether a setting exists, according to the settings json files.
-     * 
-     * \param key The internal key for the setting to test
-     * \return Whether a definition of the setting is recorded in this registry.
-     */
-    bool settingExists(std::string key) const;
-
-    /*!
-     * Get the config of a setting with a given key.
-     * 
-     * \param key the (internal) key for a setting
-     * \return the setting definition values
-     */
-    SettingConfig* getSettingConfig(std::string key) const;
-protected:
-    /*!
-     * Whether this json settings object is a definition of a CuraEngine setting,
-     * or only a shorthand setting to control other settings.
-     * Only settings used by the engine will be recordedd in the registry.
-     * 
-     * \param setting The setting to check whether CuraEngine uses it.
-     * \return Whether CuraEngine uses the setting.
-     */
-    bool settingIsUsedByEngine(const rapidjson::Value& setting);
-
-    /*!
-     * Get the filename for the machine definition with the given id.
-     * Check the directories in SettingRegistry::search_paths.
-     * 
-     * \param machine_id The id and base filename (without extensions) of the machine definition to search for.
-     * \param result The filename of the machine definition
-     * \return Whether we found the file.
-     */
-    bool getDefinitionFile(const std::string machine_id, std::string& result);
-    
-    /*!
-     * Get the default value of a json setting object in the format used internally (c style).
-     * 
-     * \param[in] json_object_it An iterator for a given setting json object
-     * \param[out] config Where the default value is stored
-     */
-    static void loadDefault(const rapidjson::GenericValue< rapidjson::UTF8< char > >::ConstMemberIterator& json_object_it, SettingConfig* config);
-public:
-    /*!
-     * Load settings from a json file and all the parents it inherits from.
-     * 
-     * Uses recursion to load the parent json file.
-     * 
-     * \param filename The filename of the json file to parse
-     * \param settings_base The settings base where to store the default values.
-     * \param warn_base_file_duplicates Whether to warn if there are duplicate definitions in the base file (the .def.json which has no inherits).
-     * \return an error code or zero of succeeded
-     */
-    int loadJSONsettings(std::string filename, SettingsBase* settings_base, bool warn_base_file_duplicates = true);
-    
-    void debugOutputAllSettings() const
-    {
-        setting_definitions.debugOutputAllSettings();
-    }
-
-    /*!
-     * Load settings from the extruder definition json file and all the parents it inherits from.
-     * Use the json file refered to in the machine_extruder_trains attribute of the last loaded machine json file.
-     * 
-     * Uses recursion to load the parent json file.
-     * 
-     * \param extruder_nr The number of the extruder to load
-     * \param settings_base The settings base where to store the default values. (The extruder settings base)
-     * \return an error code or zero of succeeded
-     */
-    int loadExtruderJSONsettings(unsigned int extruder_nr, SettingsBase* settings_base);
-private:
-    
-    /*!
-     * \param type type to convert to string
-     * \return human readable version of json type
-     */
-    static std::string toString(rapidjson::Type type);
-public:
-    /*!
-     * Load a json document.
-     * 
-     * \param filename The filename of the json file to parse
-     * \param json_document (output) the document to be loaded
-     * \return an error code or zero of succeeded
-     */
-    static int loadJSON(std::string filename, rapidjson::Document& json_document);
-private:
-    /*!
-     * Load settings from a single json file.
-     * 
-     * \param filename The filename of the json file to parse
-     * \param settings_base The settings base where to store the default values.
-     * \param warn_duplicates whether to warn for duplicate definitions
-     * \return an error code or zero of succeeded
-     */
-    int loadJSONsettingsFromDoc(rapidjson::Document& json_document, SettingsBase* settings_base, bool warn_duplicates);
-
-    /*!
-     * Create a new SettingConfig and add it to the registry.
-     * 
-     * \param name The internal key of the setting
-     * \param label The human readable name for the frontend
-     * \return The config created
-     */
-    SettingConfig& addSetting(std::string name, std::string label);
-
-    /*!
-     * Load inessential data about the setting, like its type and unit.
-     * 
-     * \param[out] config Where to store the data
-     * \param[in] json_object_it Iterator to a setting json object
-     * \param[out] settings_base The settings base where to store the default values.
-     */
-    void _loadSettingValues(SettingConfig* config, const rapidjson::Value::ConstMemberIterator& json_object_it, SettingsBase* settings_base);
-
-    /*!
-     * Handle a json object which contains a list of settings.
-     * 
-     * \param settings_list The object containing one or more setting definitions
-     * \param path The path of (internal) setting names traversed to get to this object
-     * \param settings_base The settings base where to store the default values.
-     * \param warn_duplicates whether to warn for duplicate setting definitions
-     */
-    void handleChildren(const rapidjson::Value& settings_list, std::list<std::string>& path, SettingsBase* settings_base, bool warn_duplicates);
-    
-    /*!
-     * Handle a json object for a setting.
-     * 
-     * \param json_setting_it Iterator for the setting which contains the key (setting name) and attributes info
-     * \param path The path of (internal) setting names traversed to get to this object
-     * \param settings_base The settings base where to store the default values.
-     * \param warn_duplicates whether to warn for duplicate setting definitions
-     */
-    void handleSetting(const rapidjson::Value::ConstMemberIterator& json_setting_it, std::list<std::string>& path, SettingsBase* settings_base, bool warn_duplicates);
-};
-
-}//namespace cura
-#endif//SETTINGS_SETTING_REGISTRY_H

src/settings/SettingsToGV.h

@@ -1,238 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#ifndef SETTINGS_TO_GV_H
-#define SETTINGS_TO_GV_H
-
-
-#include <stdio.h> // for file output
-#include <sstream>
-#include <iostream> // debug IO
-#include <libgen.h> // dirname
-#include <string>
-#include <algorithm> // find_if
-#include <regex> // regex_search
-#include <cassert>
-#include <fstream>
-#include <set>
-
-#include "rapidjson/rapidjson.h"
-#include "rapidjson/document.h"
-#include "rapidjson/error/en.h"
-#include "rapidjson/filereadstream.h"
-#include "../utils/logoutput.h"
-#include "SettingRegistry.h"
-
-namespace cura
-{
-
-class SettingsToGv
-{
-    enum class RelationType
-    {
-        PARENT_CHILD,
-        INHERIT_FUNCTION,
-        ERROR_FUNCTION,
-        WARNING_FUNCTION
-    };
-    
-    FILE* out;
-    std::set<std::string> engine_settings;
-    bool parent_child_viz, inherit_viz, error_viz, warning_viz;
-public: 
-    SettingsToGv(std::string output_filename, std::string engine_settings_filename, bool parent_child_viz, bool inherit_viz, bool error_viz, bool warning_viz)
-    : parent_child_viz(parent_child_viz)
-    , inherit_viz(inherit_viz)
-    , error_viz(error_viz)
-    , warning_viz(warning_viz)
-    {
-        out = fopen(output_filename.c_str(), "w");
-        fprintf(out, "digraph G {\n");
-        
-        
-        std::ifstream engine_settings_file(engine_settings_filename.c_str());
-        std::string line;
-        while (std::getline(engine_settings_file, line))
-        {
-            engine_settings.insert(line);
-            //fprintf(out, "%s [color=green];\n", line.c_str());
-        }
-        engine_settings_file.close();
-    }
-private:
-    void generateEdge(const std::string& parent, const std::string& child, RelationType relation_type)
-    {
-        if (engine_settings.find(parent) != engine_settings.end())
-        {
-            fprintf(out, "%s [color=green];\n", parent.c_str());
-        }
-        if (engine_settings.find(child) != engine_settings.end())
-        {
-            fprintf(out, "%s [color=green];\n", child.c_str());
-        }
-        std::string color;
-        switch (relation_type)
-        {
-            case SettingsToGv::RelationType::INHERIT_FUNCTION:
-                if (!inherit_viz)
-                {
-                    return;
-                }
-                color = "blue";
-                break;
-            case SettingsToGv::RelationType::PARENT_CHILD:
-                if (!parent_child_viz)
-                {
-                    return;
-                }
-                color = "black";
-                break;
-            case SettingsToGv::RelationType::ERROR_FUNCTION:
-                if (!error_viz)
-                {
-                    return;
-                }
-                color = "red";
-                break;
-            case SettingsToGv::RelationType::WARNING_FUNCTION:
-                if (!warning_viz)
-                {
-                    return;
-                }
-                color = "orange";
-                break;
-        }
-        fprintf(out, "edge [color=%s];\n", color.c_str());
-        fprintf(out, "%s -> %s;\n", parent.c_str(), child.c_str());
-    }
-    
-    bool createFunctionEdges(const rapidjson::Value& data, std::string function_key, const std::string& parent, const std::string& name, const RelationType relation_type)
-    {
-        bool generated_edge = false;
-        if (data.HasMember(function_key.c_str()) && data[function_key.c_str()].IsString())
-        {
-            std::string function = data[function_key.c_str()].GetString();
-            
-            std::regex setting_name_regex("[a-zA-Z0-9_]+"); // matches mostly with setting names
-            std::smatch regex_match;
-            while (std::regex_search (function, regex_match, setting_name_regex))
-            {
-                std::string inherited_setting_string = regex_match[0];
-                if (inherited_setting_string == "parent_value")
-                {
-                    generateEdge(parent, name, RelationType::PARENT_CHILD);
-                    generated_edge = true;
-                }
-                else if ( ! std::regex_match(inherited_setting_string, std::regex("[0-9]+")) && // exclude numbers
-                    // result != "parent_value" && 
-                    inherited_setting_string != "if" && inherited_setting_string != "else" && inherited_setting_string != "and" 
-                    && inherited_setting_string != "or" && inherited_setting_string != "math" && inherited_setting_string != "ceil" 
-                    && inherited_setting_string != "int" && inherited_setting_string != "round" && inherited_setting_string != "max" // exclude operators and functions
-                    && inherited_setting_string != "grid" && inherited_setting_string != "triangles" // exclude enum values
-                    && function.c_str()[regex_match.position() + regex_match.length()] != '\'') // exclude enum terms
-                {
-                    if (inherited_setting_string == parent)
-                    {
-                        generated_edge = true;
-                        generateEdge(inherited_setting_string, name, RelationType::PARENT_CHILD);
-                    }
-                    else 
-                    {
-                        generateEdge(inherited_setting_string, name, relation_type);
-                    }
-                }
-                function = regex_match.suffix().str();
-            }
-        }
-        return generated_edge;
-    }
-    
-    void parseSetting(const std::string& parent, rapidjson::Value::ConstMemberIterator json_object_it)
-    {
-        std::string name = json_object_it->name.GetString();
-        
-//         std::cerr << "parsed: " << name <<"\n";
-        
-        bool generated_edge = false;
-        
-        const rapidjson::Value& data = json_object_it->value;
-        
-        if (data.HasMember("type") && data["type"].IsString() && data["type"].GetString() != std::string("category"))
-        {
-            
-            bool generated_edge_inherit = createFunctionEdges(data, "inherit_function", parent, name, RelationType::INHERIT_FUNCTION);
-            bool generated_edge_max = createFunctionEdges(data, "max_value", parent, name, RelationType::ERROR_FUNCTION);
-            bool generated_edge_min = createFunctionEdges(data, "min_value", parent, name, RelationType::ERROR_FUNCTION);
-            bool generated_edge_max_warn = createFunctionEdges(data, "max_value_warning", parent, name, RelationType::WARNING_FUNCTION);
-            bool generated_edge_min_warn = createFunctionEdges(data, "min_value_warning", parent, name, RelationType::WARNING_FUNCTION);
-            if (generated_edge_inherit || generated_edge_max_warn || generated_edge_min_warn || generated_edge_max || generated_edge_min)
-            {
-                generated_edge = true;
-            }
-            
-            if (!generated_edge && parent != "")
-            {
-                generateEdge(parent, name, RelationType::PARENT_CHILD);
-            }
-        }
-        else
-        {
-            name = "";
-        }
-        
-        // recursive part
-        if (data.HasMember("children") && data["children"].IsObject())
-        {
-            const rapidjson::Value& json_object_container = data["children"];
-            for (rapidjson::Value::ConstMemberIterator setting_iterator = json_object_container.MemberBegin(); setting_iterator != json_object_container.MemberEnd(); ++setting_iterator)
-            {
-                parseSetting(name, setting_iterator);
-            }
-        }
-    }
-    
-    void parseJson(const rapidjson::Document& json_document)
-    {
-        if (json_document.HasMember("settings"))
-        {
-            for (rapidjson::Value::ConstMemberIterator setting_iterator = json_document["settings"].MemberBegin(); setting_iterator != json_document["settings"].MemberEnd(); ++setting_iterator)
-            {
-                parseSetting("", setting_iterator);
-            }
-        }
-    }
-
-    int generateRecursive(std::string filename)
-    {
-        rapidjson::Document json_document;
-        
-        int err = SettingRegistry::loadJSON(filename, json_document);
-        if (err) { return err; }
-        
-        if (json_document.HasMember("inherits"))
-        {
-            std::string filename_copy = std::string(filename.c_str()); // copy the string because dirname(.) changes the input string!!!
-            char* filename_cstr = (char*)filename_copy.c_str();
-            int err = generate(std::string(dirname(filename_cstr)) + std::string("/") + json_document["inherits"].GetString());
-            if (err)
-            {
-                return err;
-            }
-        }
-        parseJson(json_document);
-        return 0;
-    }
-public:
-    int generate(std::string json_filename)
-    {
-        int err = generateRecursive(json_filename);
-        fprintf(out, "}\n");
-        fclose(out);
-        return err;
-    }
-
-
-
-};
-
-} // namespace cura
-
-#endif // SETTINGS_TO_GV_H

src/settings/settings.cpp

@@ -1,368 +0,0 @@
-/** Copyright (C) 2016 Ultimaker - Released under terms of the AGPLv3 License */
-#include <cctype>
-#include <fstream>
-#include <stdio.h>
-#include <sstream> // ostringstream
-#include "../utils/logoutput.h"
-
-#include "settings.h"
-#include "SettingRegistry.h"
-
-namespace cura
-{
-//c++11 no longer defines M_PI, so add our own constant.
-#ifndef M_PI
-#define M_PI 3.14159265358979323846
-#endif
-
-std::string toString(EGCodeFlavor flavor)
-{
-    switch (flavor)
-    {
-        case EGCodeFlavor::BFB:
-            return "BFB";
-        case EGCodeFlavor::MACH3:
-            return "Mach3";
-        case EGCodeFlavor::MAKERBOT:
-            return "Makerbot";
-        case EGCodeFlavor::ULTIGCODE:
-            return "UltiGCode";
-        case EGCodeFlavor::REPRAP_VOLUMATRIC:
-            return "RepRap(Volumetric)";
-        case EGCodeFlavor::GRIFFIN:
-            return "Griffin";
-        case EGCodeFlavor::REPRAP:
-        default:
-            return "RepRap";
-    }
-}
-
-SettingsBaseVirtual::SettingsBaseVirtual()
-: parent(NULL)
-{
-}
-
-SettingsBaseVirtual::SettingsBaseVirtual(SettingsBaseVirtual* parent)
-: parent(parent)
-{
-}
-
-SettingsBase::SettingsBase(std::string level_id)
-: SettingsBaseVirtual(NULL)
-, level_id(level_id)
-{
-}
-
-SettingsBase::SettingsBase(SettingsBaseVirtual* parent, std::string level_id)
-: SettingsBaseVirtual(parent)
-, level_id(level_id)
-{
-}
-
-SettingsMessenger::SettingsMessenger(SettingsBaseVirtual* parent)
-: SettingsBaseVirtual(parent)
-{
-}
-
-void SettingsBase::_setSetting(std::string key, std::string value)
-{
-    setting_values[key] = value;
-}
-
-
-void SettingsBase::setSetting(std::string key, std::string value)
-{
-    if (SettingRegistry::getInstance()->settingExists(key))
-    {
-        _setSetting(key, value);
-    }
-    else
-    {
-        cura::logError("Warning: setting an unregistered setting %s\n", key.c_str() );
-        _setSetting(key, value); // Handy when programmers are in the process of introducing a new setting
-    }
-}
-
-std::string SettingsBase::getSettingString(std::string key) const
-{
-//     logError(">>>%s, %s\n", key.c_str(), level_id.c_str());
-    std::cout << key << "\t\t : " << level_id << "\n";
-//     if (level_id == std::string("global"))
-//     {
-//         logError("WARNING: %s retrieved globally!\n", key.c_str());
-//     }
-    return _getSettingString(key);
-}
-std::string SettingsBase::_getSettingString(std::string key) const
-{
-    if (setting_values.find(key) != setting_values.end())
-    {
-        return setting_values.at(key);
-    }
-    if (parent)
-    {
-        return parent->_getSettingString(key);
-    }
-
-    const_cast<SettingsBase&>(*this).setting_values[key] = "";
-    cura::logError("Unregistered setting %s\n", key.c_str());
-    return "";
-}
-
-void SettingsMessenger::setSetting(std::string key, std::string value)
-{
-    parent->setSetting(key, value);
-}
-
-std::string SettingsMessenger::_getSettingString(std::string key) const
-{
-    return parent->_getSettingString(key);
-}
-std::string SettingsMessenger::getSettingString(std::string key) const
-{
-    return parent->getSettingString(key);
-}
-
-int SettingsBaseVirtual::getSettingAsIndex(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return atoi(value.c_str());
-}
-
-int SettingsBaseVirtual::getSettingAsCount(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return atoi(value.c_str());
-}
-
-double SettingsBaseVirtual::getSettingInMillimeters(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return atof(value.c_str());
-}
-
-int SettingsBaseVirtual::getSettingInMicrons(std::string key) const
-{
-    return getSettingInMillimeters(key) * 1000.0;
-}
-
-double SettingsBaseVirtual::getSettingInAngleRadians(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return atof(value.c_str()) / 180.0 * M_PI;
-}
-
-bool SettingsBaseVirtual::getSettingBoolean(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "on")
-        return true;
-    if (value == "yes")
-        return true;
-    if (value == "true" or value == "True") //Python uses "True"
-        return true;
-    int num = atoi(value.c_str());
-    return num != 0;
-}
-
-double SettingsBaseVirtual::getSettingInDegreeCelsius(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return atof(value.c_str());
-}
-
-double SettingsBaseVirtual::getSettingInMillimetersPerSecond(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return std::max(1.0, atof(value.c_str()));
-}
-
-double SettingsBaseVirtual::getSettingInCubicMillimeters(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return std::max(0.0, atof(value.c_str()));
-}
-
-double SettingsBaseVirtual::getSettingInPercentage(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return std::max(0.0, atof(value.c_str()));
-}
-
-double SettingsBaseVirtual::getSettingInSeconds(std::string key) const
-{
-    std::string value = getSettingString(key);
-    return std::max(0.0, atof(value.c_str()));
-}
-
-FlowTempGraph SettingsBaseVirtual::getSettingAsFlowTempGraph(std::string key) const
-{
-    FlowTempGraph ret;
-    const char* c_str = getSettingString(key).c_str();
-    char const* char_p = c_str;
-    while (*char_p != '[')
-    {
-        if (*char_p == '\0') //We've reached the end of string without encountering the first opening bracket.
-        {
-            return ret; //Empty at this point.
-        }
-        char_p++;
-    }
-    char_p++; // skip the '['
-    for (; *char_p != '\0'; char_p++)
-    {
-        while (*char_p != '[')
-        {
-            if (*char_p == '\0') //We've reached the end of string without finding the next opening bracket.
-            {
-                return ret; //Don't continue parsing this item then. Just stop and return.
-            }
-            char_p++;
-        }
-        char_p++; // skip the '['
-        char* end;
-        double first = strtod(char_p, &end); //If not a valid number, this becomes zero.
-        char_p = end;
-        while (*char_p != ',')
-        {
-            if (*char_p == '\0') //We've reached the end of string without finding the comma.
-            {
-                return ret; //This entry is incomplete.
-            }
-            char_p++;
-        }
-        char_p++; // skip the ','
-        double second = strtod(char_p, &end); //If not a valid number, this becomes zero.
-        ret.data.emplace_back(first, second);
-        char_p = end;
-        while (*char_p != ']')
-        {
-            if (*char_p == '\0') //We've reached the end of string without finding the closing bracket.
-            {
-                return ret; //This entry is probably complete and has been added, but stop searching.
-            }
-            char_p++;
-        }
-        char_p++; // skip the ']'
-        if (*char_p == ']' || *char_p == '\0')
-        {
-            break;
-        }
-    }
-    return ret;
-}
-
-
-EGCodeFlavor SettingsBaseVirtual::getSettingAsGCodeFlavor(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "Griffin")
-        return EGCodeFlavor::GRIFFIN;
-    else if (value == "UltiGCode")
-        return EGCodeFlavor::ULTIGCODE;
-    else if (value == "Makerbot")
-        return EGCodeFlavor::MAKERBOT;
-    else if (value == "BFB")
-        return EGCodeFlavor::BFB;
-    else if (value == "MACH3")
-        return EGCodeFlavor::MACH3;
-    else if (value == "RepRap (Volumatric)")
-        return EGCodeFlavor::REPRAP_VOLUMATRIC;
-    return EGCodeFlavor::REPRAP;
-}
-
-EFillMethod SettingsBaseVirtual::getSettingAsFillMethod(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "lines")
-        return EFillMethod::LINES;
-    if (value == "grid")
-        return EFillMethod::GRID;
-    if (value == "triangles")
-        return EFillMethod::TRIANGLES;
-    if (value == "concentric")
-        return EFillMethod::CONCENTRIC;
-    if (value == "zigzag")
-        return EFillMethod::ZIG_ZAG;
-    return EFillMethod::NONE;
-}
-
-EPlatformAdhesion SettingsBaseVirtual::getSettingAsPlatformAdhesion(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "brim")
-        return EPlatformAdhesion::BRIM;
-    if (value == "raft")
-        return EPlatformAdhesion::RAFT;
-    return EPlatformAdhesion::SKIRT;
-}
-
-ESupportType SettingsBaseVirtual::getSettingAsSupportType(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "everywhere")
-        return ESupportType::EVERYWHERE;
-    if (value == "buildplate")
-        return ESupportType::PLATFORM_ONLY;
-    return ESupportType::NONE;
-}
-
-EZSeamType SettingsBaseVirtual::getSettingAsZSeamType(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "random")
-        return EZSeamType::RANDOM;
-    if (value == "shortest")
-        return EZSeamType::SHORTEST;
-    if (value == "back")
-        return EZSeamType::BACK;
-    return EZSeamType::SHORTEST;
-}
-
-ESurfaceMode SettingsBaseVirtual::getSettingAsSurfaceMode(std::string key) const
-{
-    std::string value = getSettingString(key);
-    if (value == "normal")
-        return ESurfaceMode::NORMAL;
-    if (value == "surface")
-        return ESurfaceMode::SURFACE;
-    if (value == "both")
-        return ESurfaceMode::BOTH;
-    return ESurfaceMode::NORMAL;
-}
-
-CombingMode SettingsBaseVirtual::getSettingAsCombingMode(std::string key)
-{
-    std::string value = getSettingString(key);
-    if (value == "off")
-    {
-        return CombingMode::OFF;
-    }
-    if (value == "all")
-    {
-        return CombingMode::ALL;
-    }
-    if (value == "noskin")
-    {
-        return CombingMode::NO_SKIN;
-    }
-    return CombingMode::ALL;
-}
-
-SupportDistPriority SettingsBaseVirtual::getSettingAsSupportDistPriority(std::string key)
-{
-    std::string value = getSettingString(key);
-    if (value == "xy_overrides_z")
-    {
-        return SupportDistPriority::XY_OVERRIDES_Z;
-    }
-    if (value == "z_overrides_xy")
-    {
-        return SupportDistPriority::Z_OVERRIDES_XY;
-    }
-    return SupportDistPriority::XY_OVERRIDES_Z;
-}
-
-
-}//namespace cura
-

src/skin.cpp

@@ -2,97 +2,57 @@
 #include "skin.h"
 #include "utils/polygonUtils.h"
 
-#define MIN_AREA_SIZE (0.4 * 0.4) 
+#define MIN_AREA_SIZE (INT2MM(extrusionWidth) * INT2MM(extrusionWidth)) 
 
 namespace cura 
 {
 
         
-void generateSkins(int layerNr, SliceMeshStorage& mesh, int extrusionWidth, int downSkinCount, int upSkinCount, int wall_line_count, int innermost_wall_extrusion_width, int insetCount, bool no_small_gaps_heuristic)
+void generateSkins(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int downSkinCount, int upSkinCount, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters)
 {
-    generateSkinAreas(layerNr, mesh, innermost_wall_extrusion_width, downSkinCount, upSkinCount, wall_line_count, no_small_gaps_heuristic);
+    generateSkinAreas(layerNr, storage, extrusionWidth, downSkinCount, upSkinCount);
 
-    SliceLayer* layer = &mesh.layers[layerNr];
+    SliceLayer* layer = &storage.layers[layerNr];
     for(unsigned int partNr=0; partNr<layer->parts.size(); partNr++)
     {
         SliceLayerPart* part = &layer->parts[partNr];
-        generateSkinInsets(part, extrusionWidth, insetCount);
+        generateSkinInsets(part, extrusionWidth, insetCount, avoidOverlappingPerimeters_0, avoidOverlappingPerimeters);
     }
 }
 
-void generateSkinAreas(int layer_nr, SliceMeshStorage& mesh, int innermost_wall_extrusion_width, int downSkinCount, int upSkinCount, int wall_line_count, bool no_small_gaps_heuristic)
+void generateSkinAreas(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int downSkinCount, int upSkinCount)
 {
-    SliceLayer& layer = mesh.layers[layer_nr];
-    
-    if (downSkinCount == 0 && upSkinCount == 0)
-    {
-        return;
-    }
-    
+    SliceLayer& layer = storage.layers[layerNr];
+
     for(unsigned int partNr = 0; partNr < layer.parts.size(); partNr++)
     {
         SliceLayerPart& part = layer.parts[partNr];
+        
+        Polygons upskin = part.insets.back().offset(-extrusionWidth/2);
+        Polygons downskin = upskin;
 
-        if (int(part.insets.size()) < wall_line_count)
+        
+        if (static_cast<int>(layerNr - downSkinCount) >= 0)
         {
-            continue; // the last wall is not present, the part should only get inter preimeter gaps, but no skin.
-        }
-
-        Polygons upskin = part.insets.back().offset(-innermost_wall_extrusion_width/2);
-        Polygons downskin = (downSkinCount == 0)? Polygons() : upskin;
-        if (upSkinCount == 0) upskin = Polygons();
-
-        auto getInsidePolygons = [&part, wall_line_count](SliceLayer& layer2)
+            SliceLayer& layer2 = storage.layers[layerNr - downSkinCount];
+            for(SliceLayerPart& part2 : layer2.parts)
             {
-                Polygons result;
-                for(SliceLayerPart& part2 : layer2.parts)
-                {
-                    if (part.boundaryBox.hit(part2.boundaryBox))
-                    {
-                        unsigned int wall_idx = std::min(wall_line_count, (int) part2.insets.size()) - 1;
-                        result.add(part2.insets[wall_idx]);
-                    }
-                }
-                return result;
-            };
-            
-        if (no_small_gaps_heuristic)
-        {
-            if (static_cast<int>(layer_nr - downSkinCount) >= 0)
-            {
-                downskin = downskin.difference(getInsidePolygons(mesh.layers[layer_nr - downSkinCount])); // skin overlaps with the walls
-            }
-            
-            if (static_cast<int>(layer_nr + upSkinCount) < static_cast<int>(mesh.layers.size()))
-            {
-                upskin = upskin.difference(getInsidePolygons(mesh.layers[layer_nr + upSkinCount])); // skin overlaps with the walls
+                if (part.boundaryBox.hit(part2.boundaryBox))
+                    downskin = downskin.difference(part2.insets.back());
             }
         }
-        else 
+        if (static_cast<int>(layerNr + upSkinCount) < static_cast<int>(storage.layers.size()))
         {
-            if (layer_nr >= downSkinCount && downSkinCount > 0)
+            SliceLayer& layer2 = storage.layers[layerNr + upSkinCount];
+            for(SliceLayerPart& part2 : layer2.parts)
             {
-                Polygons not_air = getInsidePolygons(mesh.layers[layer_nr - 1]);
-                for (int downskin_layer_nr = layer_nr - downSkinCount; downskin_layer_nr < layer_nr - 1; downskin_layer_nr++)
-                {
-                    not_air = not_air.intersection(getInsidePolygons(mesh.layers[downskin_layer_nr]));
-                }
-                downskin = downskin.difference(not_air); // skin overlaps with the walls
-            }
-            
-            if (layer_nr < static_cast<int>(mesh.layers.size()) - 1 && upSkinCount > 0)
-            {
-                Polygons not_air = getInsidePolygons(mesh.layers[layer_nr + 1]);
-                for (int upskin_layer_nr = layer_nr + 2; upskin_layer_nr < layer_nr + upSkinCount + 1; upskin_layer_nr++)
-                {
-                    not_air = not_air.intersection(getInsidePolygons(mesh.layers[upskin_layer_nr]));
-                }
-                upskin = upskin.difference(not_air); // skin overlaps with the walls
+                if (part.boundaryBox.hit(part2.boundaryBox))
+                    upskin = upskin.difference(part2.insets.back());
             }
         }
         
         Polygons skin = upskin.unionPolygons(downskin);
-        
+          
         skin.removeSmallAreas(MIN_AREA_SIZE);
         
         for (PolygonsPart& skin_area_part : skin.splitIntoParts())
@@ -104,7 +64,7 @@ void generateSkinAreas(int layer_nr, SliceMeshStorage& mesh, int innermost_wall_
 }
 
 
-void generateSkinInsets(SliceLayerPart* part, int extrusionWidth, int insetCount)
+void generateSkinInsets(SliceLayerPart* part, int extrusionWidth, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters)
 {
     if (insetCount == 0)
     {
@@ -118,10 +78,12 @@ void generateSkinInsets(SliceLayerPart* part, int extrusionWidth, int insetCount
             skin_part.insets.push_back(Polygons());
             if (i == 0)
             {
-                skin_part.insets[0] = skin_part.outline.offset(- extrusionWidth/2);
+                PolygonUtils::offsetSafe(skin_part.outline, - extrusionWidth/2, extrusionWidth, skin_part.insets[0], avoidOverlappingPerimeters_0);
+                Polygons in_between = skin_part.outline.difference(skin_part.insets[0].offset(extrusionWidth/2)); 
+                skin_part.perimeterGaps.add(in_between);
             } else
             {
-                skin_part.insets[i] = skin_part.insets[i - 1].offset(-extrusionWidth);
+                PolygonUtils::offsetExtrusionWidth(skin_part.insets[i-1], true, extrusionWidth, skin_part.insets[i], &skin_part.perimeterGaps, avoidOverlappingPerimeters);
             }
             
             // optimize polygons: remove unnnecesary verts
@@ -135,18 +97,13 @@ void generateSkinInsets(SliceLayerPart* part, int extrusionWidth, int insetCount
     }
 }
 
-void generateInfill(int layerNr, SliceMeshStorage& mesh, int innermost_wall_extrusion_width, int infill_skin_overlap, int wall_line_count)
+void generateInfill(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int infill_skin_overlap)
 {
-    SliceLayer& layer = mesh.layers[layerNr];
+    SliceLayer& layer = storage.layers[layerNr];
 
     for(SliceLayerPart& part : layer.parts)
     {
-        if (int(part.insets.size()) < wall_line_count)
-        {
-            part.infill_area_per_combine.emplace_back(); // put empty polygons as initial infill_per_combine
-            continue; // the last wall is not present, the part should only get inter preimeter gaps, but no infill.
-        }
-        Polygons infill = part.insets.back().offset(-innermost_wall_extrusion_width / 2 - infill_skin_overlap);
+        Polygons infill = part.insets.back().offset(-extrusionWidth / 2 - infill_skin_overlap);
 
         for(SliceLayerPart& part2 : layer.parts)
         {
@@ -160,61 +117,69 @@ void generateInfill(int layerNr, SliceMeshStorage& mesh, int innermost_wall_extr
         }
         infill.removeSmallAreas(MIN_AREA_SIZE);
         
-        part.infill_area = infill.offset(infill_skin_overlap);
-        part.infill_area_per_combine.push_back(part.infill_area);
+        part.infill_area.push_back(infill.offset(infill_skin_overlap));
     }
 }
 
-void combineInfillLayers(SliceMeshStorage& mesh, unsigned int amount)
+void combineInfillLayers(int layerNr, SliceMeshStorage& storage, int amount)
 {
-    // Note that *all* parts should have an [infill_area_per_combine] with one element in it, which up till now only contains the exact same polygons as [infill].
-    if(amount <= 1) //If we must combine 1 layer, nothing needs to be combined. Combining 0 layers is invalid.
-    {
-        return;
-    }
-    if (mesh.layers.empty() || mesh.layers.size() - 1 < static_cast<size_t>(mesh.getSettingAsCount("top_layers")) || mesh.getSettingAsCount("infill_line_distance") <= 0) //No infill is even generated.
-    {
-        return;
-    }
-    /* We need to round down the layer index we start at to the nearest
-    divisible index. Otherwise we get some parts that have infill at divisible
-    layers and some at non-divisible layers. Those layers would then miss each
-    other. */
-    size_t min_layer = mesh.getSettingAsCount("bottom_layers") + amount - 1;
-    min_layer -= min_layer % amount; //Round upwards to the nearest layer divisible by infill_sparse_combine.
-    size_t max_layer = mesh.layers.size() - 1 - mesh.getSettingAsCount("top_layers");
-    max_layer -= max_layer % amount; //Round downwards to the nearest layer divisible by infill_sparse_combine.
-    for(size_t layer_idx = min_layer;layer_idx <= max_layer;layer_idx += amount) //Skip every few layers, but extrude more.
-    {
-        SliceLayer* layer = &mesh.layers[layer_idx];
+    SliceLayer* layer = &storage.layers[layerNr];
 
-        for(unsigned int n = 1;n < amount;n++)
+    for(int n=1; n<amount; n++)
+    {
+        if (layerNr < n)
+            break;
+        
+        SliceLayer* layer2 = &storage.layers[layerNr - n];
+        for(SliceLayerPart& part : layer->parts)
         {
-            if(layer_idx < n)
+            Polygons result;
+            for(SliceLayerPart& part2 : layer2->parts)
             {
-                break;
-            }
-
-            SliceLayer* layer2 = &mesh.layers[layer_idx - n];
-            for(SliceLayerPart& part : layer->parts)
-            {
-                Polygons result;
-                for(SliceLayerPart& part2 : layer2->parts)
+                if (part.boundaryBox.hit(part2.boundaryBox))
                 {
-                    if(part.boundaryBox.hit(part2.boundaryBox))
-                    {
-                        Polygons intersection = part.infill_area_per_combine[n - 1].intersection(part2.infill_area_per_combine[0]).offset(-200).offset(200);
-                        result.add(intersection);
-                        part.infill_area_per_combine[n - 1] = part.infill_area_per_combine[n - 1].difference(intersection);
-                        part2.infill_area_per_combine[0] = part2.infill_area_per_combine[0].difference(intersection);
-                    }
+                    Polygons intersection = part.infill_area[n - 1].intersection(part2.infill_area[0]).offset(-200).offset(200);
+                    result.add(intersection);
+                    part.infill_area[n - 1] = part.infill_area[n - 1].difference(intersection);
+                    part2.infill_area[0] = part2.infill_area[0].difference(intersection);
                 }
-
-                part.infill_area_per_combine.push_back(result);
             }
+            
+            part.infill_area.push_back(result);
         }
     }
 }
 
 
+void generatePerimeterGaps(int layer_nr, SliceMeshStorage& storage, int extrusionWidth, int downSkinCount, int upSkinCount)
+{
+    SliceLayer& layer = storage.layers[layer_nr];
+    
+    for (SliceLayerPart& part : layer.parts) 
+    { // handle gaps between perimeters etc.
+        if (downSkinCount > 0 && upSkinCount > 0 && // note: if both are zero or less, then all gaps will be used
+            layer_nr >= downSkinCount && layer_nr < static_cast<int>(storage.layers.size() - upSkinCount)) // remove gaps which appear within print, i.e. not on the bottom most or top most skin
+        {
+            Polygons outlines_above;
+            for (SliceLayerPart& part_above : storage.layers[layer_nr + upSkinCount].parts)
+            {
+                if (part.boundaryBox.hit(part_above.boundaryBox))
+                {
+                    outlines_above.add(part_above.outline);
+                }
+            }
+            Polygons outlines_below;
+            for (SliceLayerPart& part_below : storage.layers[layer_nr - downSkinCount].parts)
+            {
+                if (part.boundaryBox.hit(part_below.boundaryBox))
+                {
+                    outlines_below.add(part_below.outline);
+                }
+            }
+            part.perimeterGaps = part.perimeterGaps.intersection(outlines_above.xorPolygons(outlines_below));
+        }
+        part.perimeterGaps.removeSmallAreas(MIN_AREA_SIZE);
+    }
+}
+
 }//namespace cura

src/skin.h

@@ -6,33 +6,42 @@
 
 namespace cura 
 {
+
+/*!
+ * Generate the gap areas which occur between consecutive insets.
+ * 
+ * \param layerNr The index of the layer for which to generate the gaps.
+ * \param storage The storage where the layer outline information (input) is stored and where the gap areas (output) are stored.
+ * \param extrusionWidth extrusionWidth
+ * \param downSkinCount The number of layers of bottom gaps
+ * \param upSkinCount The number of layers of top gaps
+ */
+void generatePerimeterGaps(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int downSkinCount, int upSkinCount);
+
 /*!
  * Generate the skin areas and its insets.
  * 
  * \param layerNr The index of the layer for which to generate the skins.
- * \param mesh The storage where the layer outline information (input) is stored and where the skin insets and fill areas (output) are stored.
+ * \param storage The storage where the layer outline information (input) is stored and where the skin insets and fill areas (output) are stored.
  * \param extrusionWidth extrusionWidth
  * \param downSkinCount The number of layers of bottom skin
  * \param upSkinCount The number of layers of top skin
- * \param wall_line_count The number of walls, i.e. the number of the wall from which to offset.
- * \param innermost_wall_extrusion_width The line width of the inner most wall
  * \param insetCount The number of perimeters to surround the skin
- * \param no_small_gaps_heuristic A heuristic which assumes there will be no small gaps between bottom and top skin with a z size smaller than the skin size itself
+ * \param avoidOverlappingPerimeters_0 Whether to remove the parts of the first perimeters where it have overlap with itself (and store the gaps thus created in the \p storage)
+ * \param avoidOverlappingPerimeters Whether to remove the parts of two consecutive perimeters where they have overlap (and store the gaps thus created in the \p storage)
  */
-void generateSkins(int layerNr, SliceMeshStorage& mesh, int extrusionWidth, int downSkinCount, int upSkinCount, int wall_line_count, int innermost_wall_extrusion_width, int insetCount, bool no_small_gaps_heuristic);
+void generateSkins(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int downSkinCount, int upSkinCount, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters);
 
 /*!
  * Generate the skin areas (outlines)
  * 
  * \param layerNr The index of the layer for which to generate the skins.
- * \param mesh The storage where the layer outline information (input) is stored and where the skin outline (output) is stored.
+ * \param storage The storage where the layer outline information (input) is stored and where the skin outline (output) is stored.
  * \param extrusionWidth extrusionWidth
  * \param downSkinCount The number of layers of bottom skin
  * \param upSkinCount The number of layers of top skin
- * \param wall_line_count The number of walls, i.e. the number of the wall from which to offset.
- * \param no_small_gaps_heuristic A heuristic which assumes there will be no small gaps between bottom and top skin with a z size smaller than the skin size itself
  */
-void generateSkinAreas(int layerNr, SliceMeshStorage& mesh, int extrusionWidth, int downSkinCount, int upSkinCount, int wall_line_count, bool no_small_gaps_heuristic);
+void generateSkinAreas(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int downSkinCount, int upSkinCount);
 
 /*!
  * Generate the skin insets.
@@ -41,36 +50,20 @@ void generateSkinAreas(int layerNr, SliceMeshStorage& mesh, int extrusionWidth,
  * \param part The part where the skin outline information (input) is stored and where the skin insets (output) are stored.
  * \param extrusionWidth extrusionWidth
  * \param insetCount The number of perimeters to surround the skin
+ * \param avoidOverlappingPerimeters_0 Whether to remove the parts of the first perimeters where it have overlap with itself (and store the gaps thus created in the \p storage)
+ * \param avoidOverlappingPerimeters Whether to remove the parts of two consecutive perimeters where they have overlap (and store the gaps thus created in the \p storage)
  */
-void generateSkinInsets(SliceLayerPart* part, int extrusionWidth, int insetCount);
+void generateSkinInsets(SliceLayerPart* part, int extrusionWidth, int insetCount, bool avoidOverlappingPerimeters_0, bool avoidOverlappingPerimeters);
 
 /*!
- * Generate Infill by offsetting from the last wall.
- * 
- * The walls should already be generated.
- * 
- * After this function has been called on a layer of a mesh, each SliceLayerPart of that layer should have an infill_area consisting of exactly one Polygons : the normal uncombined infill area.
- * 
+ * Generate Infill
  * \param layerNr The index of the layer for which to generate the infill
- * \param mesh The storage where the layer outline information (input) is stored and where the skin outline (output) is stored.
  * \param part The part where the insets (input) are stored and where the infill (output) is stored.
- * \param innermost_wall_extrusion_width width of the innermost wall lines
+ * \param extrusionWidth width of the wall lines
  * \param infill_skin_overlap overlap distance between infill and skin
- * \param wall_line_count The number of walls, i.e. the number of the wall from which to offset.
  */
-void generateInfill(int layerNr, SliceMeshStorage& mesh, int innermost_wall_extrusion_width, int infill_skin_overlap, int wall_line_count);
-
-/*!
- * \brief Combines the infill of multiple layers for a specified mesh.
- * 
- * The infill layers are combined while the thickness of each layer is
- * multiplied such that the infill should fill up again to the full height of
- * all combined layers.
- * 
- * \param mesh The mesh to combine the infill layers of.
- * \param amount The number of layers to combine.
- */
-void combineInfillLayers(SliceMeshStorage& mesh, unsigned int amount);
+void generateInfill(int layerNr, SliceMeshStorage& storage, int extrusionWidth, int infill_skin_overlap);
+void combineInfillLayers(int layerNr, SliceMeshStorage& storage, int amount);
 
 }//namespace cura
 

src/sliceDataStorage.cpp

@@ -1,278 +1,53 @@
 #include "sliceDataStorage.h"
 
-#include "FffProcessor.h" //To create a mesh group with if none is provided.
-
 namespace cura
 {
 
-Polygons SliceLayer::getOutlines(bool external_polys_only) const
+Polygons SliceLayer::getOutlines(bool external_polys_only)
 {
     Polygons ret;
     getOutlines(ret, external_polys_only);
     return ret;
 }
 
-void SliceLayer::getOutlines(Polygons& result, bool external_polys_only) const
+void SliceLayer::getOutlines(Polygons& result, bool external_polys_only)
 {
-    for (const SliceLayerPart& part : parts)
+    for (SliceLayerPart& part : parts)
     {
         if (external_polys_only)
         {
-            result.add(const_cast<SliceLayerPart&>(part).outline.outerPolygon()); // TODO: make a const version of outerPolygon()
+            result.add(part.outline.outerPolygon());
         }
         else 
         {
-            result.add(part.print_outline);
+            result.add(part.outline);
         }
     }
 }
 
-Polygons SliceLayer::getSecondOrInnermostWalls() const
+
+Polygons SliceDataStorage::getLayerOutlines(unsigned int layer_nr, bool include_helper_parts, bool external_polys_only)
 {
-    Polygons ret;
-    getSecondOrInnermostWalls(ret);
-    return ret;
-}
-
-void SliceLayer::getSecondOrInnermostWalls(Polygons& layer_walls) const
-{
-    for (const SliceLayerPart& part : parts)
-    {
-        // we want the 2nd inner walls
-        if (part.insets.size() >= 2) {
-            layer_walls.add(const_cast<SliceLayerPart&>(part).insets[1]); // TODO const cast!
-            continue;
-        }
-        // but we'll also take the inner wall if the 2nd doesn't exist
-        if (part.insets.size() == 1) {
-            layer_walls.add(const_cast<SliceLayerPart&>(part).insets[0]); // TODO const cast!
-            continue;
-        }
-        // offset_from_outlines was so large that it completely destroyed our isle,
-        // so we'll just use the regular outline
-        layer_walls.add(part.outline);
-        continue;
-    }
-}
-
-
-std::vector<RetractionConfig> SliceDataStorage::initializeRetractionConfigs()
-{
-    std::vector<RetractionConfig> ret;
-    ret.resize(meshgroup->getExtruderCount()); // initializes with constructor RetractionConfig()
-    return ret;
-}
-std::vector<GCodePathConfig> SliceDataStorage::initializeTravelConfigs()
-{
-    std::vector<GCodePathConfig> ret;
-    for (int extruder = 0; extruder < meshgroup->getExtruderCount(); extruder++)
-    {
-        RetractionConfig* retraction_config = nullptr;
-        travel_config_per_extruder.emplace_back(retraction_config, PrintFeatureType::MoveCombing);
-    }
-    return ret;
-}
-std::vector<GCodePathConfig> SliceDataStorage::initializeSkirtConfigs()
-{
-    std::vector<GCodePathConfig> ret;
-    for (int extruder = 0; extruder < meshgroup->getExtruderCount(); extruder++)
-    {
-        RetractionConfig* extruder_retraction_config = &retraction_config_per_extruder[extruder];
-        skirt_config.emplace_back(extruder_retraction_config, PrintFeatureType::Skirt);
-    }
-    return ret;
-}
-SliceDataStorage::SliceDataStorage(MeshGroup* meshgroup) : SettingsMessenger(meshgroup),
-    meshgroup(meshgroup != nullptr ? meshgroup : new MeshGroup(FffProcessor::getInstance())), //If no mesh group is provided, we roll our own.
-    retraction_config_per_extruder(initializeRetractionConfigs()),
-    travel_config_per_extruder(initializeTravelConfigs()),
-    skirt_config(initializeSkirtConfigs()),
-    raft_base_config(&retraction_config_per_extruder[getSettingAsIndex("adhesion_extruder_nr")], PrintFeatureType::Support),
-    raft_interface_config(&retraction_config_per_extruder[getSettingAsIndex("adhesion_extruder_nr")], PrintFeatureType::Support),
-    raft_surface_config(&retraction_config_per_extruder[getSettingAsIndex("adhesion_extruder_nr")], PrintFeatureType::Support),
-    support_config(&retraction_config_per_extruder[getSettingAsIndex("support_infill_extruder_nr")], PrintFeatureType::Support),
-    support_roof_config(&retraction_config_per_extruder[getSettingAsIndex("support_roof_extruder_nr")], PrintFeatureType::Skin),
-    max_object_height_second_to_last_extruder(-1)
-{
-}
-
-Polygons SliceDataStorage::getLayerOutlines(int layer_nr, bool include_helper_parts, bool external_polys_only) const
-{
-    if (layer_nr < 0)
-    { // when processing raft
-        if (include_helper_parts)
-        {
-            if (external_polys_only)
-            {
-                std::vector<PolygonsPart> parts = raftOutline.splitIntoParts();
-                Polygons result;
-                for (PolygonsPart& part : parts) 
-                {
-                    result.add(part.outerPolygon());
-                }
-                return result;
-            }
-            else 
-            {
-                return raftOutline;
-            }
-        }
-        else 
-        {
-            return Polygons();
-        }
-    }
-    else 
-    {
-        Polygons total;
-        for (const SliceMeshStorage& mesh : meshes)
-        {
-            const SliceLayer& layer = mesh.layers[layer_nr];
-            layer.getOutlines(total, external_polys_only);
-            if (const_cast<SliceMeshStorage&>(mesh).getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::NORMAL) // TODO: make all getSetting functions const??
-            {
-                total = total.unionPolygons(layer.openPolyLines.offsetPolyLine(100));
-            }
-        }
-        if (include_helper_parts)
-        {
-            if (support.generated) 
-            {
-                total.add(support.supportLayers[layer_nr].supportAreas);
-                total.add(support.supportLayers[layer_nr].roofs);
-            }
-            total.add(primeTower.ground_poly);
-        }
-        return total;
-    }
-}
-
-Polygons SliceDataStorage::getLayerSecondOrInnermostWalls(int layer_nr, bool include_helper_parts) const
-{
-    if (layer_nr < 0)
-    { // when processing raft
-        if (include_helper_parts)
-        {
-            return raftOutline;
-        }
-        else 
-        {
-            return Polygons();
-        }
-    }
-    else 
-    {
-        Polygons total;
-        for (const SliceMeshStorage& mesh : meshes)
-        {
-            const SliceLayer& layer = mesh.layers[layer_nr];
-            layer.getSecondOrInnermostWalls(total);
-            if (const_cast<SliceMeshStorage&>(mesh).getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::NORMAL) // TODO: make getSetting const? make settings.setting_values mapping mutable??
-            {
-                total = total.unionPolygons(layer.openPolyLines.offsetPolyLine(100));
-            }
-        }
-        if (include_helper_parts)
-        {
-            if (support.generated) 
-            {
-                total.add(support.supportLayers[layer_nr].supportAreas);
-                total.add(support.supportLayers[layer_nr].roofs);
-            }
-            total.add(primeTower.ground_poly);
-        }
-        return total;
-    }
-
-}
-
-
-std::vector<bool> SliceDataStorage::getExtrudersUsed(int layer_nr)
-{
-    std::vector<bool> ret;
-    ret.resize(meshgroup->getExtruderCount(), false);
-    if (layer_nr < 0)
-    {
-        ret[getSettingAsIndex("adhesion_extruder_nr")] = true; // raft
-    }
-    else 
-    {
-        if (layer_nr == 0)
-        { // process brim/skirt
-            for (int extr_nr = 0; extr_nr < meshgroup->getExtruderCount(); extr_nr++)
-            {
-                if (skirt[extr_nr].size() > 0)
-                {
-                    ret[extr_nr] = true;
-                    continue;
-                }
-            }
-        }
-
-        // TODO: ooze shield, draft shield
-
-        // support
-        if (support.supportLayers[layer_nr].supportAreas.size() > 0)
-        {
-            if (layer_nr == 0)
-            {
-                ret[getSettingAsIndex("support_extruder_nr_layer_0")] = true;
-            }
-            else 
-            {
-                ret[getSettingAsIndex("support_infill_extruder_nr")] = true;
-            }
-        }
-        if (support.supportLayers[layer_nr].roofs.size() > 0)
-        {
-            ret[getSettingAsIndex("support_roof_extruder_nr")] = true;
-        }
-
-        for (SliceMeshStorage& mesh : meshes)
-        {
-            SliceLayer& layer = mesh.layers[layer_nr];
-            int extr_nr = mesh.getSettingAsIndex("extruder_nr");
-            if (layer.parts.size() > 0)
-            {
-                ret[extr_nr] = true;
-            }
-        }
-    }
-    return ret;
-}
-
-std::vector< bool > SliceDataStorage::getExtrudersUsed()
-{
-
-    std::vector<bool> ret;
-    ret.resize(meshgroup->getExtruderCount(), false);
-
-    ret[getSettingAsIndex("adhesion_extruder_nr")] = true; 
-    { // process brim/skirt
-        for (int extr_nr = 0; extr_nr < meshgroup->getExtruderCount(); extr_nr++)
-        {
-            if (skirt[extr_nr].size() > 0)
-            {
-                ret[extr_nr] = true;
-                continue;
-            }
-        }
-    }
-
-    // TODO: ooze shield, draft shield ..?
-
-    // support
-    // support is presupposed to be present...
-    ret[getSettingAsIndex("support_extruder_nr_layer_0")] = true;
-    ret[getSettingAsIndex("support_infill_extruder_nr")] = true;
-    ret[getSettingAsIndex("support_roof_extruder_nr")] = true;
-
-    // all meshes are presupposed to actually have content
+    Polygons total;
     for (SliceMeshStorage& mesh : meshes)
     {
-        ret[mesh.getSettingAsIndex("extruder_nr")] = true;
+        SliceLayer& layer = mesh.layers[layer_nr];
+        layer.getOutlines(total, external_polys_only);
+        if (mesh.getSettingAsSurfaceMode("magic_mesh_surface_mode") != ESurfaceMode::NORMAL)
+        {
+            total = total.unionPolygons(layer.openPolyLines.offsetPolyLine(100));
+        }
     }
-    return ret;
+    if (include_helper_parts)
+    {
+        if (support.generated) 
+        {
+            total.add(support.supportLayers[layer_nr].supportAreas);
+            total.add(support.supportLayers[layer_nr].roofs);
+        }
+        total.add(primeTower.ground_poly);
+    }
+    return total;
 }
 
 
@@ -297,6 +72,9 @@ std::vector< bool > SliceDataStorage::getExtrudersUsed()
 
 
 
+
+
+
 
 
 

src/sliceDataStorage.h

@@ -4,8 +4,6 @@
 
 #include "utils/intpoint.h"
 #include "utils/polygon.h"
-#include "utils/NoCopy.h"
-#include "utils/AABB.h"
 #include "mesh.h"
 #include "gcodePlanner.h"
 #include "MeshGroup.h"
@@ -23,6 +21,7 @@ class SkinPart
 public:
     PolygonsPart outline;               //!< The skinOutline is the area which needs to be 100% filled to generate a proper top&bottom filling. It's filled by the "skin" module.
     std::vector<Polygons> insets;   //!< The skin can have perimeters so that the skin lines always start at a perimeter instead of in the middle of an infill cell.
+    Polygons perimeterGaps;         //!< The gaps introduced by avoidOverlappingPerimeters which would otherwise be overlapping perimeters.
 };
 /*!
     The SliceLayerPart is a single enclosed printable area for a single layer. (Also known as islands)
@@ -34,11 +33,10 @@ class SliceLayerPart
 public:
     AABB boundaryBox;       //!< The boundaryBox is an axis-aligned bounardy box which is used to quickly check for possible collision between different parts on different layers. It's an optimalization used during skin calculations.
     PolygonsPart outline;       //!< The outline is the first member that is filled, and it's filled with polygons that match a cross section of the 3D model. The first polygon is the outer boundary polygon and the rest are holes.
-    Polygons print_outline; //!< An approximation to the outline of what's actually printed, based on the outer wall. Too small parts will be omitted compared to the outline.
     std::vector<Polygons> insets;         //!< The insets are generated with: an offset of (index * line_width + line_width/2) compared to the outline. The insets are also known as perimeters, and printed inside out.
     std::vector<SkinPart> skin_parts;     //!< The skin parts which are filled for 100% with lines and/or insets.
-    Polygons infill_area; //!< The areas which need to be filled with sparse (0-99%) infill. Like SliceLayerPart::outline, this class member is not used to actually determine the feature area, but is used to compute the infill_area_per_combine and the inside comb boundary.
-    std::vector<Polygons> infill_area_per_combine; //!< The areas which need to be filled with sparse (0-99%) infill for different thicknesses. The infill_area is an array to support thicker layers of sparse infill. infill_area[n] is infill_area of (n+1) layers thick. 
+    std::vector<Polygons> infill_area; //!< The infill_area are the areas which need to be filled with sparse (0-99%) infill. The infill_area is an array to support thicker layers of sparse infill. infill_area[n] is infill_area of (n+1) layers thick. 
+    Polygons perimeterGaps; //!< The gaps introduced by avoidOverlappingPerimeters which would otherwise be overlapping perimeters.
 };
 
 /*!
@@ -53,35 +51,8 @@ public:
     std::vector<SliceLayerPart> parts;  //!< An array of LayerParts which contain the actual data. The parts are printed one at a time to minimize travel outside of the 3D model.
     Polygons openPolyLines; //!< A list of lines which were never hooked up into a 2D polygon. (Currently unused in normal operation)
     
-    /*!
-     * Get the all outlines of all layer parts in this layer.
-     * 
-     * \param external_polys_only Whether to only include the outermost outline of each layer part
-     * \return A collection of all the outline polygons
-     */
-    Polygons getOutlines(bool external_polys_only = false) const;
-    
-    /*!
-     * Get the all outlines of all layer parts in this layer.
-     * Add those polygons to @p result.
-     * 
-     * \param external_polys_only Whether to only include the outermost outline of each layer part
-     * \param result The result: a collection of all the outline polygons
-     */
-    void getOutlines(Polygons& result, bool external_polys_only = false) const;
-    
-    /*!
-     * Collects the second wall of every part, or the outer wall if it has no second, or the outline, if it has no outer wall.
-     * \return The collection of all polygons thus obtained
-     */
-    Polygons getSecondOrInnermostWalls() const;
-    
-    /*!
-     * Collects the second wall of every part, or the outer wall if it has no second, or the outline, if it has no outer wall.
-     * Add those polygons to @p result.
-     * \param result The result: the collection of all polygons thus obtained
-     */
-    void getSecondOrInnermostWalls(Polygons& result) const;
+    Polygons getOutlines(bool external_polys_only = false);
+    void getOutlines(Polygons& result, bool external_polys_only = false);
 };
 
 /******************/
@@ -120,15 +91,15 @@ public:
     std::vector<GCodePathConfig> infill_config;
     
     SliceMeshStorage(SettingsBaseVirtual* settings)
-    : SettingsMessenger(settings), layer_nr_max_filled_layer(0), inset0_config(&retraction_config, PrintFeatureType::OuterWall), insetX_config(&retraction_config, PrintFeatureType::InnerWall), skin_config(&retraction_config, PrintFeatureType::Skin)
+    : SettingsMessenger(settings), layer_nr_max_filled_layer(0), inset0_config(&retraction_config, "WALL-OUTER"), insetX_config(&retraction_config, "WALL-INNER"), skin_config(&retraction_config, "SKIN")
     {
         infill_config.reserve(MAX_INFILL_COMBINE);
         for(int n=0; n<MAX_INFILL_COMBINE; n++)
-            infill_config.emplace_back(&retraction_config, PrintFeatureType::Infill);
+            infill_config.emplace_back(&retraction_config, "FILL");
     }
 };
 
-class SliceDataStorage : public SettingsMessenger, NoCopy
+class SliceDataStorage : public SettingsMessenger
 {
 public:
     MeshGroup* meshgroup; // needed to pass on the per extruder settings.. (TODO: put this somewhere else? Put the per object settings here directly, or a pointer only to the per object settings.)
@@ -137,16 +108,11 @@ public:
     std::vector<SliceMeshStorage> meshes;
     
     std::vector<RetractionConfig> retraction_config_per_extruder; //!< used for support, skirt, etc.
-
-    std::vector<GCodePathConfig> travel_config_per_extruder; //!< The config used for travel moves (only speed is set!)
-
+    RetractionConfig retraction_config; //!< The retraction config used as fallback when getting the per_extruder_config or the mesh config was impossible (for travelConfig)
+    
     std::vector<GCodePathConfig> skirt_config; //!< config for skirt per extruder
     std::vector<CoastingConfig> coasting_config; //!< coasting config per extruder
     
-    GCodePathConfig raft_base_config;
-    GCodePathConfig raft_interface_config;
-    GCodePathConfig raft_surface_config;
-    
     GCodePathConfig support_config;
     GCodePathConfig support_roof_config;
     
@@ -162,30 +128,33 @@ public:
     Polygons draft_protection_shield; //!< The polygons for a heightened skirt which protects from warping by gusts of wind and acts as a heated chamber.
     Point wipePoint;
     
-    /*!
-     * Construct the initial retraction_config_per_extruder
-     */
-    std::vector<RetractionConfig> initializeRetractionConfigs();
-    /*!
-     * Construct the initial travel_config_per_extruder
-     */
-    std::vector<GCodePathConfig> initializeTravelConfigs();
-    /*!
-     * Construct the initial skirt_config s for each extruder
-     */
-    std::vector<GCodePathConfig> initializeSkirtConfigs();
-
-    /*!
-     * \brief Creates a new slice data storage that stores the slice data of the
-     * specified mesh group.
-     * 
-     * It will obtain the settings from the mesh group too. The mesh group is
-     * not yet sliced in this constructor. If no mesh group is provided, an
-     * empty one will be created.
-     * 
-     * \param meshgroup The mesh group to load into this data storage, if any.
-     */
-    SliceDataStorage(MeshGroup* meshgroup);
+    std::vector<RetractionConfig> initializeRetractionConfigs()
+    {
+        std::vector<RetractionConfig> ret;
+        ret.resize(meshgroup->getExtruderCount()); // initializes with constructor RetractionConfig()
+        return ret;
+    }
+    std::vector<GCodePathConfig> initializeSkirtConfigs()
+    {
+        std::vector<GCodePathConfig> ret;
+        for (int extruder = 0; extruder < meshgroup->getExtruderCount(); extruder++)
+        {
+            RetractionConfig* extruder_retraction_config = &retraction_config_per_extruder[extruder];
+            skirt_config.emplace_back(extruder_retraction_config, "SKIRT");
+        }
+        return ret;
+    }
+    SliceDataStorage(MeshGroup* meshgroup)
+    : SettingsMessenger(meshgroup)
+    , meshgroup(meshgroup)
+    , retraction_config_per_extruder(initializeRetractionConfigs())
+    , skirt_config(initializeSkirtConfigs())
+    , support_config(&retraction_config_per_extruder[meshgroup->getSettingAsIndex("support_extruder_nr")], "SUPPORT")
+    , support_roof_config(&retraction_config_per_extruder[meshgroup->getSettingAsIndex("support_roof_extruder_nr")], "SKIN")
+    , max_object_height_second_to_last_extruder(-1)
+//     , primeTower()
+    {
+    }
     
     ~SliceDataStorage()
     {
@@ -194,36 +163,11 @@ public:
     /*!
      * Get all outlines within a given layer.
      * 
-     * \param layer_nr the index of the layer for which to get the outlines (negative layer numbers indicate the raft)
+     * \param layer_nr the index of the layer for which to get the outlines
      * \param include_helper_parts whether to include support and prime tower
      * \param external_polys_only whether to disregard all hole polygons
      */
-    Polygons getLayerOutlines(int layer_nr, bool include_helper_parts, bool external_polys_only = false) const;
-    
-    /*!
-     * Collects the second wall of every part, or the outer wall if it has no second, or the outline, if it has no outer wall.
-     * 
-     * For helper parts the outlines are used.
-     * 
-     * \param layer_nr the index of the layer for which to get the outlines (negative layer numbers indicate the raft)
-     * \param include_helper_parts whether to include support and prime tower
-     */
-    Polygons getLayerSecondOrInnermostWalls(int layer_nr, bool include_helper_parts) const;
-    
-    /*!
-     * Get the extruder numbers of all extruders used in a given layer.
-     * 
-     * \param layer_nr the index of the layer for which to get the extruders used (negative layer numbers indicate the raft)
-     * \return a vector of bools indicating whether the extruder with corresponding index is used in this layer.
-     */
-    std::vector<bool> getExtrudersUsed(int layer_nr);
-    
-    /*!
-     * Get the extruders used.
-     * 
-     * \return a vector of bools indicating whether the extruder with corresponding index is used in this layer.
-     */
-    std::vector<bool> getExtrudersUsed();
+    Polygons getLayerOutlines(unsigned int layer_nr, bool include_helper_parts, bool external_polys_only = false);
 };
 
 }//namespace cura

src/slicer.cpp

@@ -1,459 +1,323 @@
 /** Copyright (C) 2013 David Braam - Released under terms of the AGPLv3 License */
 #include <stdio.h>
 
-#include <algorithm> // remove_if
-
 #include "utils/gettime.h"
 #include "utils/logoutput.h"
 
 #include "slicer.h"
 #include "debug.h" // TODO remove
 
-
 namespace cura {
-    
-int largest_neglected_gap_first_phase = MM2INT(0.01); //!< distance between two line segments regarded as connected
-int largest_neglected_gap_second_phase = MM2INT(0.02); //!< distance between two line segments regarded as connected
-int max_stitch1 = MM2INT(10.0); //!< maximal distance stitched between open polylines to form polygons
 
-void SlicerLayer::makeBasicPolygonLoops(const Mesh* mesh, Polygons& open_polylines)
+void SlicerLayer::makePolygons(Mesh* mesh, bool keep_none_closed, bool extensive_stitching)
 {
-    for(unsigned int start_segment_idx = 0; start_segment_idx < segments.size(); start_segment_idx++)
+    Polygons openPolygonList;
+    
+    // connect line segments
+    for(unsigned int startSegment=0; startSegment < segmentList.size(); startSegment++)
     {
-        if (!segments[start_segment_idx].addedToPolygon)
+        if (segmentList[startSegment].addedToPolygon)
+            continue;
+        
+        Polygon poly;
+        poly.add(segmentList[startSegment].start);
+        
+        unsigned int segmentIndex = startSegment;
+        bool canClose;
+        while(true)
         {
-            makeBasicPolygonLoop(mesh, open_polylines, start_segment_idx);
+            canClose = false;
+            segmentList[segmentIndex].addedToPolygon = true;
+            Point p0 = segmentList[segmentIndex].end;
+            poly.add(p0);
+            int nextIndex = -1;
+            const MeshFace& face = mesh->faces[segmentList[segmentIndex].faceIndex];
+            for(unsigned int i=0;i<3;i++)
+            {
+                decltype(face_idx_to_segment_index.begin()) it;
+                if (face.connected_face_index[i] > -1 && (it = face_idx_to_segment_index.find(face.connected_face_index[i])) != face_idx_to_segment_index.end())
+                {
+                    int index = (*it).second;
+                    Point p1 = segmentList[index].start;
+                    Point diff = p0 - p1;
+                    if (shorterThen(diff, MM2INT(0.01)))
+                    {
+                        if (index == static_cast<int>(startSegment))
+                            canClose = true;
+                        if (segmentList[index].addedToPolygon)
+                            continue;
+                        nextIndex = index;
+                    }
+                }
+            }
+            if (nextIndex == -1)
+                break;
+            segmentIndex = nextIndex;
         }
+        if (canClose)
+            polygonList.add(poly);
+        else
+            openPolygonList.add(poly);
     }
     //Clear the segmentList to save memory, it is no longer needed after this point.
-    segments.clear();
-}
-
-void SlicerLayer::makeBasicPolygonLoop(const Mesh* mesh, Polygons& open_polylines, unsigned int start_segment_idx)
-{
+    segmentList.clear();
     
-    Polygon poly;
-    poly.add(segments[start_segment_idx].start);
-    
-    for (int segment_idx = start_segment_idx; segment_idx != -1; )
+    // TODO: (?) for mesh surface mode: connect open polygons. Maybe the above algorithm can create two open polygons which are actually connected when the starting segment is in the middle between the two open polygons.
+
+    //Connecting polygons that are not closed yet, as models are not always perfect manifold we need to join some stuff up to get proper polygons
+    //First link up polygon ends that are within 2 microns.
+    for(unsigned int i=0;i<openPolygonList.size();i++)
     {
-        SlicerSegment& segment = segments[segment_idx];
-        poly.add(segment.end);
-        segment.addedToPolygon = true;
-        segment_idx = getNextSegmentIdx(mesh, segment, start_segment_idx);
-        if (segment_idx == static_cast<int>(start_segment_idx)) 
-        { // polyon is closed
-            polygons.add(poly);
-            return;
-        }
-    }
-    // polygon couldn't be closed
-    open_polylines.add(poly);
-}
-
-int SlicerLayer::getNextSegmentIdx(const Mesh* mesh, const SlicerSegment& segment, unsigned int start_segment_idx)
-{
-    int next_segment_idx = -1;
-    const MeshFace& face = mesh->faces[segment.faceIndex];
-    for (unsigned int face_edge_idx = 0; face_edge_idx < 3; face_edge_idx++)
-    { // check segments in connected faces
-        decltype(face_idx_to_segment_idx.begin()) it;
-        if (face.connected_face_index[face_edge_idx] > -1 && (it = face_idx_to_segment_idx.find(face.connected_face_index[face_edge_idx])) != face_idx_to_segment_idx.end())
+        if (openPolygonList[i].size() < 1) continue;
+        for(unsigned int j=0;j<openPolygonList.size();j++)
         {
-            int segment_idx = (*it).second;
-            Point p1 = segments[segment_idx].start;
-            Point diff = segment.end - p1;
-            if (shorterThen(diff, largest_neglected_gap_first_phase))
-            {
-                if (segment_idx == static_cast<int>(start_segment_idx))
-                {
-                    return start_segment_idx;
-                }
-                if (segments[segment_idx].addedToPolygon)
-                {
-                    continue;
-                }
-                next_segment_idx = segment_idx; // not immediately returned since we might still encounter the start_segment_idx
-            }
-        }
-    }
-    return next_segment_idx;
-}
-
-void SlicerLayer::connectOpenPolylines(Polygons& open_polylines)
-{
-    // TODO use some space partitioning data structure to make this run faster than O(n^2)
-    for(unsigned int open_polyline_idx = 0; open_polyline_idx < open_polylines.size(); open_polyline_idx++)
-    {
-        PolygonRef open_polyline = open_polylines[open_polyline_idx];
-        
-        if (open_polyline.size() < 1) continue;
-        for(unsigned int open_polyline_other_idx = 0; open_polyline_other_idx < open_polylines.size(); open_polyline_other_idx++)
-        {
-            PolygonRef open_polyline_other = open_polylines[open_polyline_other_idx];
+            if (openPolygonList[j].size() < 1) continue;
             
-            if (open_polyline_other.size() < 1) continue;
-            
-            Point diff = open_polyline.back() - open_polyline_other[0];
+            Point diff = openPolygonList[i][openPolygonList[i].size()-1] - openPolygonList[j][0];
+            int64_t distSquared = vSize2(diff);
 
-            if (shorterThen(diff, largest_neglected_gap_second_phase))
+            if (distSquared < MM2INT(0.02) * MM2INT(0.02))
             {
-                if (open_polyline_idx == open_polyline_other_idx)
+                if (i == j)
                 {
-                    polygons.add(open_polyline);
-                    open_polyline.clear();
+                    polygonList.add(openPolygonList[i]);
+                    openPolygonList[i].clear();
                     break;
-                }
-                else
-                {
-                    for (unsigned int line_idx = 0; line_idx < open_polyline_other.size(); line_idx++)
-                    {
-                        open_polyline.add(open_polyline_other[line_idx]);
-                    }
-                    open_polyline_other.clear();
+                }else{
+                    for(unsigned int n=0; n<openPolygonList[j].size(); n++)
+                        openPolygonList[i].add(openPolygonList[j][n]);
+
+                    openPolygonList[j].clear();
                 }
             }
         }
     }
-}
 
-void SlicerLayer::stitch(Polygons& open_polylines)
-{ // TODO This is an inefficient implementation which can run in O(n^3) time.
-    // below code closes smallest gaps first
-    while(1)
+    if (mesh->getSettingAsSurfaceMode("magic_mesh_surface_mode") == ESurfaceMode::NORMAL)
     {
-        int64_t best_dist2 = max_stitch1 * max_stitch1;
-        unsigned int best_polyline_1_idx = -1;
-        unsigned int best_polyline_2_idx = -1;
-        bool reversed = false;
-        for(unsigned int polyline_1_idx = 0; polyline_1_idx < open_polylines.size(); polyline_1_idx++)
+        //Next link up all the missing ends, closing up the smallest gaps first. This is an inefficient implementation which can run in O(n*n*n) time.
+        while(1)
         {
-            PolygonRef polyline_1 = open_polylines[polyline_1_idx];
-            
-            if (polyline_1.size() < 1) continue;
-            for(unsigned int polyline_2_idx = 0; polyline_2_idx < open_polylines.size(); polyline_2_idx++)
+        int64_t bestScore = MM2INT(10.0) * MM2INT(10.0);
+        unsigned int bestA = -1;
+        unsigned int bestB = -1;
+        bool reversed = false;
+        for(unsigned int i=0;i<openPolygonList.size();i++)
+        {
+            if (openPolygonList[i].size() < 1) continue;
+            for(unsigned int j=0;j<openPolygonList.size();j++)
             {
-                PolygonRef polyline_2 = open_polylines[polyline_2_idx];
+                if (openPolygonList[j].size() < 1) continue;
                 
-                if (polyline_2.size() < 1) continue;
-                
-                Point diff = polyline_1.back() - polyline_2[0];
-                int64_t dist2 = vSize2(diff);
-                if (dist2 < best_dist2)
+                Point diff = openPolygonList[i][openPolygonList[i].size()-1] - openPolygonList[j][0];
+                int64_t distSquared = vSize2(diff);
+                if (distSquared < bestScore)
                 {
-                    best_dist2 = dist2;
-                    best_polyline_1_idx = polyline_1_idx;
-                    best_polyline_2_idx = polyline_2_idx;
+                    bestScore = distSquared;
+                    bestA = i;
+                    bestB = j;
                     reversed = false;
                 }
 
-                if (polyline_1_idx != polyline_2_idx)
+                if (i != j)
                 {
-                    Point diff = polyline_1.back() - polyline_2.back();
-                    int64_t dist2 = vSize2(diff);
-                    if (dist2 < best_dist2)
+                    Point diff = openPolygonList[i][openPolygonList[i].size()-1] - openPolygonList[j][openPolygonList[j].size()-1];
+                    int64_t distSquared = vSize2(diff);
+                    if (distSquared < bestScore)
                     {
-                        best_dist2 = dist2;
-                        best_polyline_1_idx = polyline_1_idx;
-                        best_polyline_2_idx = polyline_2_idx;
+                        bestScore = distSquared;
+                        bestA = i;
+                        bestB = j;
                         reversed = true;
                     }
                 }
             }
         }
         
-        if (best_dist2 >= max_stitch1 * max_stitch1)
-            break; // this code is reached if there was nothing to stitch within the distance limits
+        if (bestScore >= MM2INT(10.0) * MM2INT(10.0))
+            break;
         
-        PolygonRef polyline_1 = open_polylines[best_polyline_1_idx];
-        PolygonRef polyline_2 = open_polylines[best_polyline_2_idx];
-        
-        if (best_polyline_1_idx == best_polyline_2_idx)
-        { // connect last piece of 'circle'
-            polygons.add(polyline_1);
-            polyline_1.clear();
-        }
-        else
-        { // connect two polylines
+        if (bestA == bestB)
+        {
+            polygonList.add(openPolygonList[bestA]);
+            openPolygonList[bestA].clear();
+        }else{
             if (reversed)
             {
-                if (polyline_1.size() > polyline_2.size()) // decide which polygon to copy into the other
+                if (openPolygonList[bestA].polygonLength() > openPolygonList[bestB].polygonLength())
                 {
-                    for(int poly_idx = polyline_2.size()-1; poly_idx >= 0; poly_idx--)
-                        polyline_1.add(polyline_2[poly_idx]);
-                    polyline_2.clear();
-                } 
-                else
-                {
-                    for(int poly_idx = polyline_1.size()-1; poly_idx >= 0; poly_idx--)
-                        polyline_2.add(polyline_1[poly_idx]);
-                    polyline_1.clear();
+                    for(unsigned int n=openPolygonList[bestB].size()-1; int(n)>=0; n--)
+                        openPolygonList[bestA].add(openPolygonList[bestB][n]);
+                    openPolygonList[bestB].clear();
+                }else{
+                    for(unsigned int n=openPolygonList[bestA].size()-1; int(n)>=0; n--)
+                        openPolygonList[bestB].add(openPolygonList[bestA][n]);
+                    openPolygonList[bestA].clear();
                 }
-                // note that either way we end up with the end of former polyline_1 next to the start of former polyline_2
-            }
-            else
-            {
-                for(Point& p : polyline_2)
-                    polyline_1.add(p);
-                polyline_2.clear();
+            }else{
+                for(unsigned int n=0; n<openPolygonList[bestB].size(); n++)
+                    openPolygonList[bestA].add(openPolygonList[bestB][n]);
+                openPolygonList[bestB].clear();
             }
         }
     }
-}
-
-void SlicerLayer::stitch_extensive(Polygons& open_polylines)
-{
-    //For extensive stitching find 2 open polygons that are touching 2 closed polygons.
-    // Then find the shortest path over this polygon that can be used to connect the open polygons,
-    // And generate a path over this shortest bit to link up the 2 open polygons.
-    // (If these 2 open polygons are the same polygon, then the final result is a closed polyon)
-    
-    while(1)
+    }
+    if (extensive_stitching)
     {
-        unsigned int best_polyline_1_idx = -1;
-        unsigned int best_polyline_2_idx = -1;
-        GapCloserResult best_result;
-        best_result.len = POINT_MAX;
-        best_result.polygonIdx = -1;
-        best_result.pointIdxA = -1;
-        best_result.pointIdxB = -1;
+        //For extensive stitching find 2 open polygons that are touching 2 closed polygons.
+        // Then find the sortest path over this polygon that can be used to connect the open polygons,
+        // And generate a path over this shortest bit to link up the 2 open polygons.
+        // (If these 2 open polygons are the same polygon, then the final result is a closed polyon)
         
-        for(unsigned int polyline_1_idx = 0; polyline_1_idx < open_polylines.size(); polyline_1_idx++)
+        while(1)
         {
-            PolygonRef polyline_1 = open_polylines[polyline_1_idx];
-            if (polyline_1.size() < 1) continue;
+            unsigned int bestA = -1;
+            unsigned int bestB = -1;
+            GapCloserResult bestResult;
+            bestResult.len = POINT_MAX;
+            bestResult.polygonIdx = -1;
+            bestResult.pointIdxA = -1;
+            bestResult.pointIdxB = -1;
             
+            for(unsigned int i=0; i<openPolygonList.size(); i++)
             {
-                GapCloserResult res = findPolygonGapCloser(polyline_1[0], polyline_1.back());
-                if (res.len > 0 && res.len < best_result.len)
-                {
-                    best_polyline_1_idx = polyline_1_idx;
-                    best_polyline_2_idx = polyline_1_idx;
-                    best_result = res;
-                }
-            }
-
-            for(unsigned int polyline_2_idx = 0; polyline_2_idx < open_polylines.size(); polyline_2_idx++)
-            {
-                PolygonRef polyline_2 = open_polylines[polyline_2_idx];
-                if (polyline_2.size() < 1 || polyline_1_idx == polyline_2_idx) continue;
+                if (openPolygonList[i].size() < 1) continue;
                 
-                GapCloserResult res = findPolygonGapCloser(polyline_1[0], polyline_2.back());
-                if (res.len > 0 && res.len < best_result.len)
                 {
-                    best_polyline_1_idx = polyline_1_idx;
-                    best_polyline_2_idx = polyline_2_idx;
-                    best_result = res;
-                }
-            }
-        }
-        
-        if (best_result.len < POINT_MAX)
-        {
-            if (best_polyline_1_idx == best_polyline_2_idx)
-            {
-                if (best_result.pointIdxA == best_result.pointIdxB)
-                {
-                    polygons.add(open_polylines[best_polyline_1_idx]);
-                    open_polylines[best_polyline_1_idx].clear();
-                }
-                else if (best_result.AtoB)
-                {
-                    PolygonRef poly = polygons.newPoly();
-                    for(unsigned int j = best_result.pointIdxA; j != best_result.pointIdxB; j = (j + 1) % polygons[best_result.polygonIdx].size())
-                        poly.add(polygons[best_result.polygonIdx][j]);
-                    for(unsigned int j = open_polylines[best_polyline_1_idx].size() - 1; int(j) >= 0; j--)
-                        poly.add(open_polylines[best_polyline_1_idx][j]);
-                    open_polylines[best_polyline_1_idx].clear();
-                }
-                else
-                {
-                    unsigned int n = polygons.size();
-                    polygons.add(open_polylines[best_polyline_1_idx]);
-                    for(unsigned int j = best_result.pointIdxB; j != best_result.pointIdxA; j = (j + 1) % polygons[best_result.polygonIdx].size())
-                        polygons[n].add(polygons[best_result.polygonIdx][j]);
-                    open_polylines[best_polyline_1_idx].clear();
-                }
-            }
-            else
-            {
-                if (best_result.pointIdxA == best_result.pointIdxB)
-                {
-                    for(unsigned int n=0; n<open_polylines[best_polyline_1_idx].size(); n++)
-                        open_polylines[best_polyline_2_idx].add(open_polylines[best_polyline_1_idx][n]);
-                    open_polylines[best_polyline_1_idx].clear();
-                }
-                else if (best_result.AtoB)
-                {
-                    Polygon poly;
-                    for(unsigned int n = best_result.pointIdxA; n != best_result.pointIdxB; n = (n + 1) % polygons[best_result.polygonIdx].size())
-                        poly.add(polygons[best_result.polygonIdx][n]);
-                    for(unsigned int n=poly.size()-1;int(n) >= 0; n--)
-                        open_polylines[best_polyline_2_idx].add(poly[n]);
-                    for(unsigned int n=0; n<open_polylines[best_polyline_1_idx].size(); n++)
-                        open_polylines[best_polyline_2_idx].add(open_polylines[best_polyline_1_idx][n]);
-                    open_polylines[best_polyline_1_idx].clear();
-                }
-                else
-                {
-                    for(unsigned int n = best_result.pointIdxB; n != best_result.pointIdxA; n = (n + 1) % polygons[best_result.polygonIdx].size())
-                        open_polylines[best_polyline_2_idx].add(polygons[best_result.polygonIdx][n]);
-                    for(unsigned int n = open_polylines[best_polyline_1_idx].size() - 1; int(n) >= 0; n--)
-                        open_polylines[best_polyline_2_idx].add(open_polylines[best_polyline_1_idx][n]);
-                    open_polylines[best_polyline_1_idx].clear();
-                }
-            }
-        }
-        else
-        {
-            break;
-        }
-    }
-}
-
-GapCloserResult SlicerLayer::findPolygonGapCloser(Point ip0, Point ip1)
-{
-    GapCloserResult ret;
-    ClosePolygonResult c1 = findPolygonPointClosestTo(ip0);
-    ClosePolygonResult c2 = findPolygonPointClosestTo(ip1);
-    if (c1.polygonIdx < 0 || c1.polygonIdx != c2.polygonIdx)
-    {
-        ret.len = -1;
-        return ret;
-    }
-    ret.polygonIdx = c1.polygonIdx;
-    ret.pointIdxA = c1.pointIdx;
-    ret.pointIdxB = c2.pointIdx;
-    ret.AtoB = true;
-    
-    if (ret.pointIdxA == ret.pointIdxB)
-    {
-        //Connection points are on the same line segment.
-        ret.len = vSize(ip0 - ip1);
-    }else{
-        //Find out if we have should go from A to B or the other way around.
-        Point p0 = polygons[ret.polygonIdx][ret.pointIdxA];
-        int64_t lenA = vSize(p0 - ip0);
-        for(unsigned int i = ret.pointIdxA; i != ret.pointIdxB; i = (i + 1) % polygons[ret.polygonIdx].size())
-        {
-            Point p1 = polygons[ret.polygonIdx][i];
-            lenA += vSize(p0 - p1);
-            p0 = p1;
-        }
-        lenA += vSize(p0 - ip1);
-
-        p0 = polygons[ret.polygonIdx][ret.pointIdxB];
-        int64_t lenB = vSize(p0 - ip1);
-        for(unsigned int i = ret.pointIdxB; i != ret.pointIdxA; i = (i + 1) % polygons[ret.polygonIdx].size())
-        {
-            Point p1 = polygons[ret.polygonIdx][i];
-            lenB += vSize(p0 - p1);
-            p0 = p1;
-        }
-        lenB += vSize(p0 - ip0);
-        
-        if (lenA < lenB)
-        {
-            ret.AtoB = true;
-            ret.len = lenA;
-        }else{
-            ret.AtoB = false;
-            ret.len = lenB;
-        }
-    }
-    return ret;
-}
-
-ClosePolygonResult SlicerLayer::findPolygonPointClosestTo(Point input)
-{
-    ClosePolygonResult ret;
-    for(unsigned int n=0; n<polygons.size(); n++)
-    {
-        Point p0 = polygons[n][polygons[n].size()-1];
-        for(unsigned int i=0; i<polygons[n].size(); i++)
-        {
-            Point p1 = polygons[n][i];
-            
-            //Q = A + Normal( B - A ) * ((( B - A ) dot ( P - A )) / VSize( A - B ));
-            Point pDiff = p1 - p0;
-            int64_t lineLength = vSize(pDiff);
-            if (lineLength > 1)
-            {
-                int64_t distOnLine = dot(pDiff, input - p0) / lineLength;
-                if (distOnLine >= 0 && distOnLine <= lineLength)
-                {
-                    Point q = p0 + pDiff * distOnLine / lineLength;
-                    if (shorterThen(q - input, 100))
+                    GapCloserResult res = findPolygonGapCloser(openPolygonList[i][0], openPolygonList[i][openPolygonList[i].size()-1]);
+                    if (res.len > 0 && res.len < bestResult.len)
                     {
-                        ret.intersectionPoint = q;
-                        ret.polygonIdx = n;
-                        ret.pointIdx = i;
-                        return ret;
+                        bestA = i;
+                        bestB = i;
+                        bestResult = res;
+                    }
+                }
+
+                for(unsigned int j=0; j<openPolygonList.size(); j++)
+                {
+                    if (openPolygonList[j].size() < 1 || i == j) continue;
+                    
+                    GapCloserResult res = findPolygonGapCloser(openPolygonList[i][0], openPolygonList[j][openPolygonList[j].size()-1]);
+                    if (res.len > 0 && res.len < bestResult.len)
+                    {
+                        bestA = i;
+                        bestB = j;
+                        bestResult = res;
                     }
                 }
             }
-            p0 = p1;
+            
+            if (bestResult.len < POINT_MAX)
+            {
+                if (bestA == bestB)
+                {
+                    if (bestResult.pointIdxA == bestResult.pointIdxB)
+                    {
+                        polygonList.add(openPolygonList[bestA]);
+                        openPolygonList[bestA].clear();
+                    }
+                    else if (bestResult.AtoB)
+                    {
+                        PolygonRef poly = polygonList.newPoly();
+                        for(unsigned int j = bestResult.pointIdxA; j != bestResult.pointIdxB; j = (j + 1) % polygonList[bestResult.polygonIdx].size())
+                            poly.add(polygonList[bestResult.polygonIdx][j]);
+                        for(unsigned int j = openPolygonList[bestA].size() - 1; int(j) >= 0; j--)
+                            poly.add(openPolygonList[bestA][j]);
+                        openPolygonList[bestA].clear();
+                    }
+                    else
+                    {
+                        unsigned int n = polygonList.size();
+                        polygonList.add(openPolygonList[bestA]);
+                        for(unsigned int j = bestResult.pointIdxB; j != bestResult.pointIdxA; j = (j + 1) % polygonList[bestResult.polygonIdx].size())
+                            polygonList[n].add(polygonList[bestResult.polygonIdx][j]);
+                        openPolygonList[bestA].clear();
+                    }
+                }
+                else
+                {
+                    if (bestResult.pointIdxA == bestResult.pointIdxB)
+                    {
+                        for(unsigned int n=0; n<openPolygonList[bestA].size(); n++)
+                            openPolygonList[bestB].add(openPolygonList[bestA][n]);
+                        openPolygonList[bestA].clear();
+                    }
+                    else if (bestResult.AtoB)
+                    {
+                        Polygon poly;
+                        for(unsigned int n = bestResult.pointIdxA; n != bestResult.pointIdxB; n = (n + 1) % polygonList[bestResult.polygonIdx].size())
+                            poly.add(polygonList[bestResult.polygonIdx][n]);
+                        for(unsigned int n=poly.size()-1;int(n) >= 0; n--)
+                            openPolygonList[bestB].add(poly[n]);
+                        for(unsigned int n=0; n<openPolygonList[bestA].size(); n++)
+                            openPolygonList[bestB].add(openPolygonList[bestA][n]);
+                        openPolygonList[bestA].clear();
+                    }
+                    else
+                    {
+                        for(unsigned int n = bestResult.pointIdxB; n != bestResult.pointIdxA; n = (n + 1) % polygonList[bestResult.polygonIdx].size())
+                            openPolygonList[bestB].add(polygonList[bestResult.polygonIdx][n]);
+                        for(unsigned int n = openPolygonList[bestA].size() - 1; int(n) >= 0; n--)
+                            openPolygonList[bestB].add(openPolygonList[bestA][n]);
+                        openPolygonList[bestA].clear();
+                    }
+                }
+            }
+            else
+            {
+                break;
+            }
         }
     }
-    ret.polygonIdx = -1;
-    return ret;
-}
-
-void SlicerLayer::makePolygons(const Mesh* mesh, bool keep_none_closed, bool extensive_stitching)
-{
-    Polygons open_polylines;
-    
-    makeBasicPolygonLoops(mesh, open_polylines);
-    
-    connectOpenPolylines(open_polylines);
-    
-    // TODO: (?) for mesh surface mode: connect open polygons. Maybe the above algorithm can create two open polygons which are actually connected when the starting segment is in the middle between the two open polygons.
-
-    if (mesh->getSettingAsSurfaceMode("magic_mesh_surface_mode") == ESurfaceMode::NORMAL)
-    { // don't stitch when using (any) mesh surface mode, i.e. also don't stitch when using mixed mesh surface and closed polygons, because then polylines which are supposed to be open will be closed
-        stitch(open_polylines);
-    }
-    
-    if (extensive_stitching)
-    {
-        stitch_extensive(open_polylines);
-    }
 
     if (keep_none_closed)
     {
-        for (PolygonRef polyline : open_polylines)
+        for(unsigned int n=0; n<openPolygonList.size(); n++)
         {
-            if (polyline.size() > 0)
-                openPolylines.add(polyline);
+            if (openPolygonList[n].size() > 0)
+                polygonList.add(openPolygonList[n]);
         }
     }
     
-    for (PolygonRef polyline : open_polylines)
+    for(unsigned int i=0;i<openPolygonList.size();i++)
     {
-        if (polyline.size() > 0)
-            openPolylines.add(polyline);
+        if (openPolygonList[i].size() > 0)
+            openPolylines.add(openPolygonList[i]);
     }
 
     //Remove all the tiny polygons, or polygons that are not closed. As they do not contribute to the actual print.
-    int snapDistance = MM2INT(1.0); // TODO: hardcoded value
-    auto it = std::remove_if(polygons.begin(), polygons.end(), [snapDistance](PolygonRef poly) { return poly.shorterThan(snapDistance); });
-    polygons.erase(it, polygons.end());
+    int snapDistance = MM2INT(1.0);
+    for(unsigned int i=0;i<polygonList.size();i++)
+    {
+        int length = 0;
+
+        for(unsigned int n=1; n<polygonList[i].size(); n++)
+        {
+            length += vSize(polygonList[i][n] - polygonList[i][n-1]);
+            if (length > snapDistance)
+                break;
+        }
+        if (length < snapDistance)
+        {
+            polygonList.remove(i);
+            i--;
+        }
+    }
 
     //Finally optimize all the polygons. Every point removed saves time in the long run.
-    polygons.simplify();
+    polygonList.simplify();
     
-    polygons.removeDegenerateVerts(); // remove verts connected to overlapping line segments
+    polygonList.removeDegenerateVerts(); // remove verts connected to overlapping line segments
     
     int xy_offset = mesh->getSettingInMicrons("xy_offset");
     if (xy_offset != 0)
     {
-        polygons = polygons.offset(xy_offset);
+        polygonList = polygonList.offset(xy_offset);
     }
 }
 
 
 Slicer::Slicer(Mesh* mesh, int initial, int thickness, int layer_count, bool keep_none_closed, bool extensive_stitching)
-: mesh(mesh)
 {
     assert(layer_count > 0);
 
@@ -504,10 +368,10 @@ Slicer::Slicer(Mesh* mesh, int initial, int thickness, int layer_count, bool kee
                 //  on the slice would create two segments
                 continue;
             }
-            layers[layer_nr].face_idx_to_segment_idx.insert(std::make_pair(mesh_idx, layers[layer_nr].segments.size()));
+            layers[layer_nr].face_idx_to_segment_index.insert(std::make_pair(mesh_idx, layers[layer_nr].segmentList.size()));
             s.faceIndex = mesh_idx;
             s.addedToPolygon = false;
-            layers[layer_nr].segments.push_back(s);
+            layers[layer_nr].segmentList.push_back(s);
         }
     }
     for(unsigned int layer_nr=0; layer_nr<layers.size(); layer_nr++)

src/slicer.h

@@ -39,90 +39,109 @@ public:
 class SlicerLayer
 {
 public:
-    std::vector<SlicerSegment> segments;
-    std::unordered_map<int, int> face_idx_to_segment_idx; // topology
+    std::vector<SlicerSegment> segmentList;
+    std::unordered_map<int, int> face_idx_to_segment_index; // topology
     
     int z;
-    Polygons polygons;
+    Polygons polygonList;
     Polygons openPolylines;
+    
+    void makePolygons(Mesh* mesh, bool keepNoneClosed, bool extensiveStitching);
 
-    /*!
-     * Connect the segments into polygons for this layer of this \p mesh
-     * 
-     * \param[in] mesh The mesh data for which we are connecting sliced segments (The face data is used)
-     * \param keepNoneClosed Whether to throw away the data for segments which we couldn't stitch into a polygon
-     * \param extensiveStitching Whether to perform extra work to try and close polylines into polygons when there are large gaps
-     */
-    void makePolygons(const Mesh* mesh, bool keepNoneClosed, bool extensiveStitching);
+private:
+    GapCloserResult findPolygonGapCloser(Point ip0, Point ip1)
+    {
+        GapCloserResult ret;
+        ClosePolygonResult c1 = findPolygonPointClosestTo(ip0);
+        ClosePolygonResult c2 = findPolygonPointClosestTo(ip1);
+        if (c1.polygonIdx < 0 || c1.polygonIdx != c2.polygonIdx)
+        {
+            ret.len = -1;
+            return ret;
+        }
+        ret.polygonIdx = c1.polygonIdx;
+        ret.pointIdxA = c1.pointIdx;
+        ret.pointIdxB = c2.pointIdx;
+        ret.AtoB = true;
+        
+        if (ret.pointIdxA == ret.pointIdxB)
+        {
+            //Connection points are on the same line segment.
+            ret.len = vSize(ip0 - ip1);
+        }else{
+            //Find out if we have should go from A to B or the other way around.
+            Point p0 = polygonList[ret.polygonIdx][ret.pointIdxA];
+            int64_t lenA = vSize(p0 - ip0);
+            for(unsigned int i = ret.pointIdxA; i != ret.pointIdxB; i = (i + 1) % polygonList[ret.polygonIdx].size())
+            {
+                Point p1 = polygonList[ret.polygonIdx][i];
+                lenA += vSize(p0 - p1);
+                p0 = p1;
+            }
+            lenA += vSize(p0 - ip1);
 
-protected:
-    /*!
-     * Connect the segments into loops which correctly form polygons (don't perform stitching here)
-     * 
-     * \param[in] mesh The mesh data for which we are connecting sliced segments (The face data is used)
-     * \param[out] open_polylines The polylines which are stiched, but couldn't be closed into a loop
-     */
-    void makeBasicPolygonLoops(const Mesh* mesh, Polygons& open_polylines);
+            p0 = polygonList[ret.polygonIdx][ret.pointIdxB];
+            int64_t lenB = vSize(p0 - ip1);
+            for(unsigned int i = ret.pointIdxB; i != ret.pointIdxA; i = (i + 1) % polygonList[ret.polygonIdx].size())
+            {
+                Point p1 = polygonList[ret.polygonIdx][i];
+                lenB += vSize(p0 - p1);
+                p0 = p1;
+            }
+            lenB += vSize(p0 - ip0);
+            
+            if (lenA < lenB)
+            {
+                ret.AtoB = true;
+                ret.len = lenA;
+            }else{
+                ret.AtoB = false;
+                ret.len = lenB;
+            }
+        }
+        return ret;
+    }
 
-    /*!
-     * Connect the segments into a loop, starting from the segment with index \p start_segment_idx
-     * 
-     * \param[in] mesh The mesh data for which we are connecting sliced segments (The face data is used)
-     * \param[out] open_polylines The polylines which are stiched, but couldn't be closed into a loop
-     * \param[in] start_segment_idx The index into SlicerLayer::segments for the first segment from which to start the polygon loop
-     */
-    void makeBasicPolygonLoop(const Mesh* mesh, Polygons& open_polylines, unsigned int start_segment_idx);
-
-    /*!
-     * Get the next segment connected to the end of \p segment.
-     * Used to make closed polygon loops.
-     * Return ASAP if segment is (also) connected to SlicerLayer::segments[\p start_segment_idx]
-     * 
-     * \param[in] mesh The mesh data for which we are connecting sliced segments (The face data is used)
-     * \param[in] segment The segment from which to start looking for the next
-     * \param[in] start_segment_idx The index to the segment which when conected to \p segment will immediately stop looking for further candidates.
-     */
-    int getNextSegmentIdx(const Mesh* mesh, const SlicerSegment& segment, unsigned int start_segment_idx);
-
-    /*!
-     * Connecting polygons that are not closed yet, as models are not always perfect manifold we need to join some stuff up to get proper polygons.
-     * First link up polygon ends that are within 2 microns.
-     * 
-     * Clears all open polylines which are used up in the process
-     * 
-     * \param[in,out] open_polylines The polylines which are stiched, but couldn't be closed into a loop
-     */
-    void connectOpenPolylines(Polygons& open_polylines);
-
-    /*!
-     * Link up all the missing ends, closing up the smallest gaps first. This is an inefficient implementation which can run in O(n*n*n) time.
-     * 
-     * Clears all open polylines which are used up in the process
-     * 
-     * \param[in,out] open_polylines The polylines which are stiched, but couldn't be closed into a loop yet
-     */
-    void stitch(Polygons& open_polylines);
-
-    GapCloserResult findPolygonGapCloser(Point ip0, Point ip1);
-
-    ClosePolygonResult findPolygonPointClosestTo(Point input);
-
-    /*!
-     * Try to close up polylines into polygons while they have large gaps in them.
-     * 
-     * Clears all open polylines which are used up in the process
-     * 
-     * \param[in,out] open_polylines The polylines which are stiched, but couldn't be closed into a loop yet
-     */
-    void stitch_extensive(Polygons& open_polylines);
+    ClosePolygonResult findPolygonPointClosestTo(Point input)
+    {
+        ClosePolygonResult ret;
+        for(unsigned int n=0; n<polygonList.size(); n++)
+        {
+            Point p0 = polygonList[n][polygonList[n].size()-1];
+            for(unsigned int i=0; i<polygonList[n].size(); i++)
+            {
+                Point p1 = polygonList[n][i];
+                
+                //Q = A + Normal( B - A ) * ((( B - A ) dot ( P - A )) / VSize( A - B ));
+                Point pDiff = p1 - p0;
+                int64_t lineLength = vSize(pDiff);
+                if (lineLength > 1)
+                {
+                    int64_t distOnLine = dot(pDiff, input - p0) / lineLength;
+                    if (distOnLine >= 0 && distOnLine <= lineLength)
+                    {
+                        Point q = p0 + pDiff * distOnLine / lineLength;
+                        if (shorterThen(q - input, 100))
+                        {
+                            ret.intersectionPoint = q;
+                            ret.polygonIdx = n;
+                            ret.pointIdx = i;
+                            return ret;
+                        }
+                    }
+                }
+                p0 = p1;
+            }
+        }
+        ret.polygonIdx = -1;
+        return ret;
+    }
 };
 
 class Slicer
 {
 public:
     std::vector<SlicerLayer> layers;
-
-    const Mesh* mesh; //!< The sliced mesh
     
     Slicer(Mesh* mesh, int initial, int thickness, int layer_count, bool keepNoneClosed, bool extensiveStitching);
     

src/support.cpp

@@ -3,8 +3,7 @@
 
 #include <cmath> // sqrt
 #include <utility> // pair
-#include <deque>
-#include "progress/Progress.h"
+#include "Progress.h"
 
 namespace cura 
 {
@@ -36,22 +35,21 @@ Polygons AreaSupport::join(Polygons& supportLayer_up, Polygons& supportLayer_thi
     return joined;
 }
 
-void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int layer_count)
+void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int layer_count, CommandSocket* commandSocket)
 {
     // initialization of supportAreasPerLayer
     for (unsigned int layer_idx = 0; layer_idx < layer_count ; layer_idx++)
         storage.support.supportLayers.emplace_back();
     
-    for(unsigned int mesh_idx = 0; mesh_idx < storage.meshes.size(); mesh_idx++)
+    for(SliceMeshStorage& mesh : storage.meshes)
     {
-        SliceMeshStorage& mesh = storage.meshes[mesh_idx];
         std::vector<Polygons> supportAreas;
         supportAreas.resize(layer_count, Polygons());
-        generateSupportAreas(storage, mesh_idx, layer_count, supportAreas);
+        generateSupportAreas(storage, &mesh, layer_count, supportAreas, commandSocket);
         
         if (mesh.getSettingBoolean("support_roof_enable"))
         {
-            generateSupportRoofs(storage, supportAreas, layer_count, storage.getSettingInMicrons("layer_height"), mesh.getSettingInMicrons("support_roof_height"));
+            generateSupportRoofs(storage, supportAreas, layer_count, mesh.getSettingInMicrons("layer_height"), mesh.getSettingInMicrons("support_roof_height"), commandSocket);
         }
         else 
         {
@@ -81,72 +79,66 @@ void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int l
  * 
  * for support buildplate only: purge all support not connected to buildplate
  */
-void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int mesh_idx, unsigned int layer_count, std::vector<Polygons>& supportAreas)
+void AreaSupport::generateSupportAreas(SliceDataStorage& storage, SliceMeshStorage* object, unsigned int layer_count, std::vector<Polygons>& supportAreas, CommandSocket* commandSocket)
 {
-    SliceMeshStorage& mesh = storage.meshes[mesh_idx];
-        
     // given settings
-    ESupportType support_type = mesh.getSettingAsSupportType("support_type");
+    ESupportType support_type = object->getSettingAsSupportType("support_type");
     
-    if (!mesh.getSettingBoolean("support_enable"))
+    if (!object->getSettingBoolean("support_enable"))
         return;
     if (support_type == ESupportType::NONE)
         return;
     
-    double supportAngle = mesh.getSettingInAngleRadians("support_angle");
+    double supportAngle = object->getSettingInAngleRadians("support_angle");
     bool supportOnBuildplateOnly = support_type == ESupportType::PLATFORM_ONLY;
-    int supportZDistanceBottom = mesh.getSettingInMicrons("support_bottom_distance");
-    int supportZDistanceTop = mesh.getSettingInMicrons("support_top_distance");
-    int join_distance = mesh.getSettingInMicrons("support_join_distance");
-    int support_bottom_stair_step_height = mesh.getSettingInMicrons("support_bottom_stair_step_height");
-    int smoothing_distance = mesh.getSettingInMicrons("support_area_smoothing"); 
+    int supportZDistance = object->getSettingInMicrons("support_z_distance");
+    int supportZDistanceBottom = object->getSettingInMicrons("support_bottom_distance");
+    int supportZDistanceTop = object->getSettingInMicrons("support_top_distance");
+    int join_distance = object->getSettingInMicrons("support_join_distance");
+    int support_bottom_stair_step_height = object->getSettingInMicrons("support_bottom_stair_step_height");
+    int smoothing_distance = object->getSettingInMicrons("support_area_smoothing"); 
     
-    int extension_offset = mesh.getSettingInMicrons("support_offset");
+    int extension_offset = object->getSettingInMicrons("support_offset");
     
-    int supportTowerDiameter = mesh.getSettingInMicrons("support_tower_diameter");
-    int supportMinAreaSqrt = mesh.getSettingInMicrons("support_minimal_diameter");
-    double supportTowerRoofAngle = mesh.getSettingInAngleRadians("support_tower_roof_angle");
+    int supportTowerDiameter = object->getSettingInMicrons("support_tower_diameter");
+    int supportMinAreaSqrt = object->getSettingInMicrons("support_minimal_diameter");
+    double supportTowerRoofAngle = object->getSettingInAngleRadians("support_tower_roof_angle");
     
     //std::cerr <<" towerDiameter=" << towerDiameter <<", supportMinAreaSqrt=" << supportMinAreaSqrt << std::endl;
     
     int min_smoothing_area = 100*100; // minimal area for which to perform smoothing
     int z_layer_distance_tower = 1; // start tower directly below overhang point
         
-    int layerThickness = storage.getSettingInMicrons("layer_height");
-    int extrusionWidth = storage.getSettingInMicrons("support_line_width"); 
-    int supportXYDistance = mesh.getSettingInMicrons("support_xy_distance");
-    int support_xy_distance_overhang = mesh.getSettingInMicrons("support_xy_distance_overhang");
-
-    bool use_support_xy_distance_overhang = mesh.getSettingAsSupportDistPriority("support_xy_overrides_z") == SupportDistPriority::Z_OVERRIDES_XY; // whether to use a different xy distance at overhangs
-
-    bool conical_support = mesh.getSettingBoolean("support_conical_enabled");
-    double conical_support_angle = mesh.getSettingInAngleRadians("support_conical_angle");
-    int64_t conical_smallest_breadth = mesh.getSettingInMicrons("support_conical_min_width");
+    int layerThickness = object->getSettingInMicrons("layer_height");
+    int extrusionWidth = object->getSettingInMicrons("support_line_width"); 
+    int supportXYDistance = object->getSettingInMicrons("support_xy_distance") + extrusionWidth / 2;
     
-    if (conical_support_angle == 0)
-    {
-        conical_support = false;
-    }
+    bool conical_support = object->getSettingBoolean("support_conical_enabled");
+    double conical_support_angle = object->getSettingInAngleRadians("support_conical_angle");
+    int64_t conical_smallest_breadth = object->getSettingInMicrons("support_conical_min_width");
     
     // derived settings:
     
+    if (supportZDistanceBottom < 0) supportZDistanceBottom = supportZDistance;
+    if (supportZDistanceTop < 0)    supportZDistanceTop = supportZDistance;
+    
     
     int supportLayerThickness = layerThickness;
     
-    int layerZdistanceTop       = std::max(0, supportZDistanceTop / supportLayerThickness) + 1; // support must always be 1 layer below overhang
+    int layerZdistanceTop       = supportZDistanceTop / supportLayerThickness + 1; // support must always be 1 layer below overhang
     unsigned int layerZdistanceBottom    = std::max(0, supportZDistanceBottom / supportLayerThickness); 
 
     double tanAngle = tan(supportAngle) - 0.01;  // the XY-component of the supportAngle
-    int max_dist_from_lower_layer = tanAngle * supportLayerThickness; // max dist which can be bridged
+    int maxDistFromLowerLayer = tanAngle * supportLayerThickness; // max dist which can be bridged
     
     int64_t conical_support_offset;
     if (conical_support_angle > 0) 
-    { // outward ==> wider base than overhang
-        conical_support_offset = -(tan(conical_support_angle) - 0.01) * supportLayerThickness;
+    {
+        conical_support_offset = (tan(conical_support_angle) - 0.01) * supportLayerThickness;
     }
     else 
-    { // inward ==> smaller base than overhang
-        conical_support_offset = (tan(-conical_support_angle) - 0.01) * supportLayerThickness;
+    {
+        conical_support_offset = -(tan(-conical_support_angle) - 0.01) * supportLayerThickness;
     }
     
     unsigned int support_layer_count = layer_count;
@@ -168,28 +160,46 @@ void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int m
         
     
     std::vector<std::pair<int, std::vector<Polygons>>> overhang_points; // stores overhang_points along with the layer index at which the overhang point occurs
-    AreaSupport::detectOverhangPoints(storage, mesh, overhang_points, layer_count, supportMinAreaSqrt, extrusionWidth);
-
-    std::deque<std::pair<Polygons, Polygons>> basic_and_full_overhang_above;
-    for (unsigned int layer_idx = support_layer_count - 1; layer_idx != support_layer_count - 1 - layerZdistanceTop ; layer_idx--)
-    {
-        basic_and_full_overhang_above.push_front(computeBasicAndFullOverhang(storage, mesh, layer_idx, max_dist_from_lower_layer));
-    }
-
+    AreaSupport::detectOverhangPoints(storage, *object, overhang_points, layer_count, supportMinAreaSqrt, extrusionWidth);
+        
+    
     bool still_in_upper_empty_layers = true;
     int overhang_points_pos = overhang_points.size() - 1;
     Polygons supportLayer_last;
     std::vector<Polygons> towerRoofs;
-
     for (unsigned int layer_idx = support_layer_count - 1 - layerZdistanceTop; layer_idx != (unsigned int) -1 ; layer_idx--)
     {
-        basic_and_full_overhang_above.push_front(computeBasicAndFullOverhang(storage, mesh, layer_idx, max_dist_from_lower_layer));
         
         Polygons overhang;
         {
             // compute basic overhang and put in right layer ([layerZdistanceTOp] layers below)
-            overhang = basic_and_full_overhang_above.back().second;
-            basic_and_full_overhang_above.pop_back();
+            Polygons supportLayer_supportee = object->layers[layer_idx+layerZdistanceTop].getOutlines();
+            Polygons supportLayer_supporter = storage.getLayerOutlines(layer_idx-1+layerZdistanceTop, false);
+            
+            Polygons supportLayer_supported =  supportLayer_supporter.offset(maxDistFromLowerLayer);
+            Polygons basic_overhang = supportLayer_supportee.difference(supportLayer_supported);
+        
+//         Polygons support_extension = basic_overhang.offset(maxDistFromLowerLayer);
+//         support_extension = support_extension.intersection(supportLayer_supported);
+//         support_extension = support_extension.intersection(supportLayer_supportee);
+//         
+//         Polygons overhang =  basic_overhang.unionPolygons(support_extension);
+//         presumably the computation above is slower than the one below
+            
+            Polygons overhang_extented = basic_overhang.offset(maxDistFromLowerLayer + 100); // +100 for easier joining with support from layer above
+            overhang = overhang_extented.intersection(supportLayer_supported.unionPolygons(supportLayer_supportee));
+            
+            /*            layer 2
+            * layer 1 ______________|
+            * _______|         ^^^^^ basic overhang
+            * 
+            * ^^^^^^^ supporter
+            * ^^^^^^^^^^^^^^^^^ supported
+            * ^^^^^^^^^^^^^^^^^^^^^^ supportee
+            *         ^^^^^^^^^^^^^^^^^^^^^^^^ overhang extended
+            *         ^^^^^^^^^      overhang extensions
+            *         ^^^^^^^^^^^^^^ overhang
+            */
         }
 
         Polygons& supportLayer_this = overhang; 
@@ -229,33 +239,17 @@ void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int m
         
         // inset using X/Y distance
         if (supportLayer_this.size() > 0)
-        {
-            Polygons& basic_overhang = basic_and_full_overhang_above.front().first; // basic overhang on this layer
-            Polygons outlines = storage.getLayerOutlines(layer_idx, false);
-
-            if (use_support_xy_distance_overhang)
-            {
-                Polygons xy_overhang_disallowed = basic_overhang.offset(supportZDistanceTop * tanAngle);
-                Polygons xy_non_overhang_disallowed = outlines.difference(basic_overhang.offset(supportXYDistance)).offset(supportXYDistance);
-
-                Polygons xy_disallowed = xy_overhang_disallowed.unionPolygons(xy_non_overhang_disallowed.unionPolygons(outlines.offset(support_xy_distance_overhang)));
-                supportLayer_this = supportLayer_this.difference(xy_disallowed);
-            }
-            else
-            {
-                supportLayer_this = supportLayer_this.difference(storage.getLayerOutlines(layer_idx, false).offset(supportXYDistance));
-            }
-        }
-
+            supportLayer_this = supportLayer_this.difference(storage.getLayerOutlines(layer_idx, false).offset(supportXYDistance));
+        
         supportAreas[layer_idx] = supportLayer_this;
-
+        
         if (still_in_upper_empty_layers && supportLayer_this.size() > 0)
         {
-            storage.support.layer_nr_max_filled_layer = std::max(storage.support.layer_nr_max_filled_layer, (int)layer_idx);
+            storage.support.layer_nr_max_filled_layer = layer_idx;
             still_in_upper_empty_layers = false;
         }
         
-        Progress::messageProgress(Progress::Stage::SUPPORT, storage.meshes.size() * mesh_idx + support_layer_count - layer_idx, support_layer_count * storage.meshes.size());
+        Progress::messageProgress(Progress::Stage::SUPPORT, support_layer_count - layer_idx, support_layer_count, commandSocket);
     }
     
     // do stuff for when support on buildplate only
@@ -266,26 +260,6 @@ void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int m
         {
             Polygons& supportLayer = supportAreas[layer_idx];
             
-            if (conical_support)
-            { // with conical support the next layer is allowed to be larger than the previous
-                touching_buildplate = touching_buildplate.offset(std::abs(conical_support_offset) + 10, ClipperLib::jtMiter, 10); 
-                // + 10 and larger miter limit cause performing an outward offset after an inward offset can disregard sharp corners
-                //
-                // conical support can make
-                //  layer above    layer below
-                //    v              v
-                //  |               : |
-                //  |        ==>    : |__
-                //  |____           :....
-                // 
-                // a miter limit would result in
-                //  | :             : |
-                //  | :..    <==    : |__
-                //  .\___           :....
-                //
-                
-            }
-            
             touching_buildplate = supportLayer.intersection(touching_buildplate); // from bottom to top, support areas can only decrease!
             
             supportAreas[layer_idx] = touching_buildplate;
@@ -293,39 +267,6 @@ void AreaSupport::generateSupportAreas(SliceDataStorage& storage, unsigned int m
     }
 }
 
-
-/*            layer 2
- * layer 1 ______________|
- * _______|         ^^^^^ basic overhang
- * 
- * ^^^^^^^ supporter
- * ^^^^^^^^^^^^^^^^^ supported
- * ^^^^^^^^^^^^^^^^^^^^^^ supportee
- *         ^^^^^^^^^^^^^^^^^^^^^^^^ overhang extended
- *         ^^^^^^^^^      overhang extensions
- *         ^^^^^^^^^^^^^^ overhang
- */
-std::pair<Polygons, Polygons> AreaSupport::computeBasicAndFullOverhang(const SliceDataStorage& storage, const SliceMeshStorage& mesh, const unsigned int layer_idx, const int64_t max_dist_from_lower_layer)
-{
-    Polygons supportLayer_supportee = mesh.layers[layer_idx].getOutlines();
-    Polygons supportLayer_supporter = storage.getLayerOutlines(layer_idx-1, false);
-
-    Polygons supportLayer_supported =  supportLayer_supporter.offset(max_dist_from_lower_layer);
-    Polygons basic_overhang = supportLayer_supportee.difference(supportLayer_supported);
-
-//     Polygons support_extension = basic_overhang.offset(max_dist_from_lower_layer);
-//     support_extension = support_extension.intersection(supportLayer_supported);
-//     support_extension = support_extension.intersection(supportLayer_supportee);
-//     
-//     Polygons overhang =  basic_overhang.unionPolygons(support_extension);
-//         presumably the computation above is slower than the one below
-
-    Polygons overhang_extented = basic_overhang.offset(max_dist_from_lower_layer + 100); // +100 for easier joining with support from layer above
-    Polygons full_overhang = overhang_extented.intersection(supportLayer_supported.unionPolygons(supportLayer_supportee));
-    return std::make_pair(basic_overhang, full_overhang);
-}
-
-
 void AreaSupport::detectOverhangPoints(
     SliceDataStorage& storage,
     SliceMeshStorage& mesh, 
@@ -465,7 +406,7 @@ void AreaSupport::handleWallStruts(
 }
 
 
-void AreaSupport::generateSupportRoofs(SliceDataStorage& storage, std::vector<Polygons>& supportAreas,  unsigned int layer_count, int layerThickness, int support_roof_height)
+void AreaSupport::generateSupportRoofs(SliceDataStorage& storage, std::vector<Polygons>& supportAreas,  unsigned int layer_count, int layerThickness, int support_roof_height, CommandSocket* commandSocket)
 {
     int roof_layer_count = support_roof_height / layerThickness;
     

src/support.h

@@ -15,8 +15,9 @@ public:
      * Generate the support areas and support roof areas for all models.
      * \param storage data storage containing the input layer outline data and containing the output support storage per layer
      * \param layer_count total number of layers
+     * \param commandSocket Socket over which to report the progress
      */
-    static void generateSupportAreas(SliceDataStorage& storage, unsigned int layer_count);
+    static void generateSupportAreas(SliceDataStorage& storage, unsigned int layer_count, CommandSocket* commandSocket);
         
 private:
     /*!
@@ -25,10 +26,11 @@ private:
      * This function also handles small overhang areas (creates towers with larger diameter than just the overhang area) and single walls which could otherwise fall over.
      * 
      * \param storage data storage containing the input layer outline data
-     * \param mesh_idx The index of the object for which to generate support areas
+     * \param object The object for which to generate support areas
      * \param layer_count total number of layers
+     * \param commandSocket Socket over which to report the progress
      */
-    static void generateSupportAreas(SliceDataStorage& storage, unsigned int mesh_idx, unsigned int layer_count, std::vector<Polygons>& supportAreas);
+    static void generateSupportAreas(SliceDataStorage& storage, SliceMeshStorage* object, unsigned int layer_count, std::vector<Polygons>& supportAreas, CommandSocket* commandSocket);
 
 
 
@@ -37,10 +39,11 @@ private:
      * 
      * \param storage Output storage: support area + support roof area output
      * \param supportAreas The basic support areas for the current mesh
+     * \param commandSocket Socket over which to report the progress
      * \param layerThickness The layer height
      * \param support_roof_height The thickness of the hammock in z directiontt
      */
-    static void generateSupportRoofs(SliceDataStorage& storage, std::vector<Polygons>& supportAreas,  unsigned int layer_count, int layerThickness, int support_roof_height);
+    static void generateSupportRoofs(SliceDataStorage& storage, std::vector<Polygons>& supportAreas,  unsigned int layer_count, int layerThickness, int support_roof_height, CommandSocket* commandSocket);
 
     /*!
      * Join current support layer with the support of the layer above, (make support conical) and perform smoothing etc operations.
@@ -75,24 +78,6 @@ private:
         int extrusionWidth
     );
     
-    /*!
-     * Compute the basic overhang and full overhang of a layer. 
-     * The basic overhang consists of the parts of this layer which are too far away from the layer below to be supported.
-     * The full overhang consists of the basic overhang extended toward the border of the layer below.
-     * 
-     *             layer 2
-     * layer 1 ______________|
-     * _______|         ^^^^^ basic overhang
-     *         ^^^^^^^^^^^^^^ full overhang
-     * 
-     * \param storage The slice data storage
-     * \param mesh The mesh for which to compute the basic overhangs
-     * \param layer_idx The layer for which to compute the overhang
-     * \param max_dist_from_lower_layer The outward distance from the layer below which can be supported by it
-     * \return a pair of basic overhang and full overhang
-     */
-    static std::pair<Polygons, Polygons> computeBasicAndFullOverhang(const SliceDataStorage& storage, const SliceMeshStorage& mesh, const unsigned int layer_idx, const int64_t max_dist_from_lower_layer);
-    
     /*!
      * Adds tower pieces to the current support layer.
      * From below the roof, the towers are added to the normal support layer and handled as normal support area.

src/timeEstimate.cpp

@@ -24,15 +24,8 @@ void TimeEstimateCalculator::setPosition(Position newPos)
     currentPosition = newPos;
 }
 
-void TimeEstimateCalculator::addTime(double time)
-{
-    extra_time += time;
-}
-
-
 void TimeEstimateCalculator::reset()
 {
-    extra_time = 0.0;
     blocks.clear();
 }
 
@@ -197,7 +190,7 @@ double TimeEstimateCalculator::calculate()
     forward_pass();
     recalculate_trapezoids();
     
-    double totalTime = extra_time;
+    double totalTime = 0;
     for(unsigned int n=0; n<blocks.size(); n++)
     {
         Block& block = blocks[n];
@@ -294,7 +287,7 @@ void TimeEstimateCalculator::recalculate_trapezoids()
     Block *current;
     Block *next = nullptr;
 
-    for(unsigned int n=0; n<blocks.size(); n++)
+    for(unsigned int n=0; n<blocks.size(); n--)
     {
         current = next;
         next = &blocks[n];