Patch statSyncNoException to handle non-string args

Non-string values were being coerced to strings which can cause
unexpected results.

Refs atom/atom-shell#843
Closes #4247

src/browser/main.coffee

@@ -13,6 +13,16 @@ process.on 'uncaughtException', (error={}) ->
   nslog(error.message) if error.message?
   nslog(error.stack) if error.stack?
 
+# Patch fs.statSyncNoException/fs.lstatSyncNoException to fail for non-strings
+# https://github.com/atom/atom-shell/issues/843
+{lstatSyncNoException, statSyncNoException} = fs
+fs.statSyncNoException = (pathToStat) ->
+  return false unless pathToStat and typeof pathToStat is 'string'
+  statSyncNoException(pathToStat)
+fs.lstatSyncNoException = (pathToStat) ->
+  return false unless pathToStat and typeof pathToStat is 'string'
+  lstatSyncNoException(pathToStat)
+
 start = ->
   if process.platform is 'win32'
     SquirrelUpdate = require './squirrel-update'

static/index.js

@@ -2,8 +2,26 @@ window.onload = function() {
   try {
     var startTime = Date.now();
 
+    var fs = require('fs');
     var path = require('path');
 
+    // Patch fs.statSyncNoException/fs.lstatSyncNoException to fail for non-strings
+    // https://github.com/atom/atom-shell/issues/843
+    var statSyncNoException = fs.statSyncNoException;
+    var lstatSyncNoException = fs.lstatSyncNoException;
+    fs.statSyncNoException = function(pathToStat) {
+      if (pathToStat && typeof pathToStat === 'string')
+        return statSyncNoException(pathToStat);
+      else
+        return false;
+    };
+    fs.lstatSyncNoException = function(pathToStat) {
+      if (pathToStat && typeof pathToStat === 'string')
+        return lstatSyncNoException(pathToStat);
+      else
+        return false;
+    };
+
     // Skip "?loadSettings=".
     var loadSettings = JSON.parse(decodeURIComponent(location.search.substr(14)));