Remove release notes from event payload

The release notes are provided by Squirrel on Mac but not by Squirrel for
Windows and the release notes package pulls them down manually anyway
so this field is no longer needed.

Checking for the presence of the release notes previously was preventing the
event from firing on Windows which would cause old release notes to show in
the package.

Closes #3757
Esse commit está contido em:
Kevin Sawicki
2015-02-03 14:52:59 -08:00
commit a4976c32ae
3 arquivos alterados com 6 adições e 7 exclusões
+1 -2
Ver Arquivo
@@ -47,9 +47,8 @@ describe "the `atom` global", ->
updateAvailableHandler.callCount > 0 updateAvailableHandler.callCount > 0
runs -> runs ->
{releaseVersion, releaseNotes} = updateAvailableHandler.mostRecentCall.args[0] {releaseVersion} = updateAvailableHandler.mostRecentCall.args[0]
expect(releaseVersion).toBe 'version' expect(releaseVersion).toBe 'version'
expect(releaseNotes).toBe 'notes'
describe "loading default config", -> describe "loading default config", ->
it 'loads the default core config', -> it 'loads the default core config', ->
+3 -3
Ver Arquivo
@@ -47,7 +47,7 @@ class AutoUpdateManager
@setState(ErrorState) @setState(ErrorState)
console.error "Error Downloading Update: #{message}" console.error "Error Downloading Update: #{message}"
autoUpdater.on 'update-downloaded', (event, @releaseNotes, @releaseVersion) => autoUpdater.on 'update-downloaded', (event, releaseNotes, @releaseVersion) =>
@setState(UpdateAvailableState) @setState(UpdateAvailableState)
@emitUpdateAvailableEvent(@getWindows()...) @emitUpdateAvailableEvent(@getWindows()...)
@@ -61,9 +61,9 @@ class AutoUpdateManager
@setState(UnsupportedState) @setState(UnsupportedState)
emitUpdateAvailableEvent: (windows...) -> emitUpdateAvailableEvent: (windows...) ->
return unless @releaseVersion? and @releaseNotes return unless @releaseVersion?
for atomWindow in windows for atomWindow in windows
atomWindow.sendMessage('update-available', {@releaseVersion, @releaseNotes}) atomWindow.sendMessage('update-available', {@releaseVersion})
setState: (state) -> setState: (state) ->
return if @state is state return if @state is state
+2 -2
Ver Arquivo
@@ -31,8 +31,8 @@ class WindowEventHandler
atom.updateAvailable(detail) atom.updateAvailable(detail)
# FIXME: Remove this when deprecations are removed # FIXME: Remove this when deprecations are removed
{releaseVersion, releaseNotes} = detail {releaseVersion} = detail
detail = [releaseVersion, releaseNotes] detail = [releaseVersion]
if workspaceElement = atom.views.getView(atom.workspace) if workspaceElement = atom.views.getView(atom.workspace)
atom.commands.dispatch workspaceElement, "window:update-available", detail atom.commands.dispatch workspaceElement, "window:update-available", detail