1f4359d429
Treat debugger statements as lint errors
2014-09-30 13:25:55 -07:00
f205fe81ce
Actually update first-mate. Previous ( 51475fe231) updated atom-keymap.
...
Both were needed to introduce disposables, but I mixed up the commit
message in the previous commit.
2014-09-30 13:58:01 -06:00
c74b1b971d
Use isPlainObject()
2014-09-30 12:44:44 -07:00
54af7eced1
Handle empty config files + reset settings before applying user config
...
Closes #3664
2014-09-30 12:39:07 -07:00
10f7a671c8
Merge pull request #3667 from atom/ns-deserializer-manager-disposables
...
Return disposables from DeserializerManager::add
2014-09-30 13:10:35 -06:00
51475fe231
Upgrade first-mate to return Disposable from GrammarRegistry::addGrammar
2014-09-30 13:09:40 -06:00
33a5ca30dc
Use DeserializerManager::add disposable instead of ::remove in specs
2014-09-30 12:58:10 -06:00
df1ae64f62
Deprecate DeserializerManager::remove
2014-09-30 12:58:10 -06:00
83710ed254
📝 Rename classes param to deserializers and update docs
2014-09-30 12:58:10 -06:00
8cb8f09803
Return a Disposable instance from DeserializerManager::add
2014-09-30 12:58:10 -06:00
ff0a7be48a
Upgrade to settings-view@0.148
2014-09-30 11:18:50 -07:00
5e6e3c8d72
Merge pull request #3655 from atom/ns-menu-disposables
...
Return disposables from MenuManager::add and add specs
2014-09-30 12:05:11 -06:00
dfc502b9a0
Merge pull request #3663 from atom/bo-subscribe-editor-commands
...
Subscribe to commands in TextEditorComponent so they are unsubscribed!
2014-09-30 10:56:05 -06:00
a8d93f9cf4
Spec for unsubscribing from commands
2014-09-30 09:45:55 -07:00
50cf5f3e95
Subscribe to editor commands
...
We need to unsubscribe when the editor is removed!
Closes #3651
2014-09-30 09:33:50 -07:00
5a9b34b31a
! -> ~
2014-09-30 09:32:03 -07:00
3efaeff669
🍎 Install via move instead of copy
...
This fixes the issue with the icon not showing up on OS X Mavericks
when building.
It seems that copying it to /Application file by file causes the icon to not
show up while moving it atomically there does.
2014-09-30 09:15:55 -07:00
443df29236
Upgrade find and replace to have cmd-d undo and skip
2014-09-29 17:26:51 -07:00
05b3f16eb2
Merge pull request #3613 from atom/bo-config-types
...
Support JSON Schema in Config
2014-09-29 17:23:54 -07:00
b54deccfae
String type must be strict.
...
It makes sense to coerce from more general -> more specific data types.
eg. string -> int, etc. But coercing the other way is problematic
in the case of chaining because the more general type will swallow the
specific type. eg. Setting `false` on type: [‘string’, ‘boolean’] will
coerce the boolean to a string, and will never allow the value to be
a boolean.
2014-09-29 16:09:49 -07:00
9808264b7f
Fix onDidChange usage
2014-09-29 16:09:49 -07:00
f3ed3dc357
Fix doc to match implementation
2014-09-29 16:09:49 -07:00
33b25c7312
Use new config callback arguments
2014-09-29 16:09:49 -07:00
454f9c4c65
Rename config-defaults -> config-schema
2014-09-29 16:09:49 -07:00
1b506673bb
📝 update
2014-09-29 16:09:49 -07:00
5651ebbb48
always set, only emit when values differ
2014-09-29 16:09:49 -07:00
a7185a894f
Fix specs
2014-09-29 16:09:49 -07:00
16c7fd3d70
Add spec for update event on load
2014-09-29 16:09:49 -07:00
98290b31ab
Rework defaults and user loading to notify per path
2014-09-29 16:09:48 -07:00
08b138997d
Change the onDidChange / observe arguments
...
Support passing no keypath
2014-09-29 16:09:48 -07:00
1f7aee00ac
function names to the imperative mood
...
http://en.wikipedia.org/wiki/Imperative_mood
2014-09-29 16:09:48 -07:00
3977596084
Validators -> enforcers
2014-09-29 16:09:48 -07:00
804d0d9911
Doc 💄
2014-09-29 16:09:48 -07:00
04d045227a
rename to config-defaults
2014-09-29 16:09:48 -07:00
4e1d13ceea
is plain object
2014-09-29 16:09:48 -07:00
ef19e925e9
Strings accept numbers too
2014-09-29 16:09:48 -07:00
2c1fa19e27
Update spec strings
2014-09-29 16:09:48 -07:00
11fad1bd12
Moar 📝
2014-09-29 16:09:48 -07:00
1408d69641
Fix up message strings
2014-09-29 16:09:48 -07:00
38d2303857
Clean up docs in creating a package
2014-09-29 16:09:48 -07:00
96207ffbdb
Update error messages to read good
2014-09-29 16:09:47 -07:00
fcf2143e70
isPlainObject
2014-09-29 16:09:47 -07:00
3a8f842de3
Remove uses of toggle
2014-09-29 16:09:47 -07:00
452e34db90
Remove deprecations for push / remove / unshift at keypath
2014-09-29 16:09:47 -07:00
8b39ce77b1
We’ll always have validators for a type. No check
2014-09-29 16:09:47 -07:00
604158647a
line height can be a string or a number
2014-09-29 16:09:47 -07:00
22fb5adda9
Remove deprecated calls for config.observe .. callNow: false in core
2014-09-29 16:09:47 -07:00
e607d45f0d
Remove instances of getPositiveInt()
2014-09-29 16:09:47 -07:00
94d470002b
Update doc strings
2014-09-29 16:09:47 -07:00
33d4ace8e9
📝 more docs for Config
2014-09-29 16:09:47 -07:00
Kevin Sawicki