Warn empty app dir

The task can be inside an asar archive, which is not allowed to be cwd.

build/Gruntfile.coffee

@@ -224,7 +224,7 @@ module.exports = (grunt) ->
 
   ciTasks = ['output-disk-space', 'download-atom-shell', 'build']
   ciTasks.push('dump-symbols') if process.platform isnt 'win32'
-  ciTasks.push('set-version', 'check-licenses', 'lint')
+  ciTasks.push('set-version', 'check-licenses', 'lint', 'generate-asar')
   ciTasks.push('mkdeb') if process.platform is 'linux'
   ciTasks.push('create-windows-installer') if process.platform is 'win32'
   ciTasks.push('test') if process.platform is 'darwin'
@@ -232,6 +232,6 @@ module.exports = (grunt) ->
   ciTasks.push('publish-build')
   grunt.registerTask('ci', ciTasks)
 
-  defaultTasks = ['download-atom-shell', 'build', 'set-version']
+  defaultTasks = ['download-atom-shell', 'build', 'set-version', 'generate-asar']
   defaultTasks.push 'install' unless process.platform is 'linux'
   grunt.registerTask('default', defaultTasks)

build/package.json

@@ -6,6 +6,7 @@
     "url": "https://github.com/atom/atom.git"
   },
   "dependencies": {
+    "asar": "^0.2.2",
     "async": "~0.2.9",
     "donna": "1.0.7",
     "formidable": "~1.0.14",

build/tasks/generate-asar-task.coffee

@@ -0,0 +1,19 @@
+asar = require 'asar'
+fs = require 'fs'
+path = require 'path'
+
+module.exports = (grunt) ->
+  {rm} = require('./task-helpers')(grunt)
+
+  grunt.registerTask 'generate-asar', 'Generate asar archive for the app', ->
+    done = @async()
+
+    appDir = grunt.config.get('atom.appDir')
+    unless fs.existsSync(appDir)
+      grunt.log.error 'The app has to be built before generating asar archive.'
+      return done(false)
+
+    asar.createPackage appDir, path.resolve(appDir, '..', 'app.asar'), (err) ->
+      return done(err) if err?
+      rm appDir
+      done()

package.json

@@ -17,7 +17,7 @@
       "url": "http://github.com/atom/atom/raw/master/LICENSE.md"
     }
   ],
-  "atomShellVersion": "0.21.0",
+  "atomShellVersion": "0.21.2",
   "dependencies": {
     "6to5-core": "^3.0.14",
     "async": "0.2.6",

spec/config-spec.coffee

@@ -666,23 +666,6 @@ describe "Config", ->
               foo:
                 bar: 'coffee'
 
-      describe "when an error is thrown writing the file to disk", ->
-        addErrorHandler = null
-        beforeEach ->
-          atom.notifications.onDidAddNotification addErrorHandler = jasmine.createSpy()
-
-        it "creates a notification", ->
-          jasmine.unspy CSON, 'writeFileSync'
-          spyOn(CSON, 'writeFileSync').andCallFake ->
-            error = new Error()
-            error.code = 'EPERM'
-            error.path = atom.config.getUserConfigPath()
-            throw error
-
-          save = -> atom.config.save()
-          expect(save).not.toThrow()
-          expect(addErrorHandler.callCount).toBe 1
-
     describe ".loadUserConfig()", ->
       beforeEach ->
         expect(fs.existsSync(atom.config.configDirPath)).toBeFalsy()

spec/pane-spec.coffee

@@ -383,25 +383,6 @@ describe "Pane", ->
           pane.saveActiveItem()
           expect(atom.showSaveDialogSync).not.toHaveBeenCalled()
 
-    describe "when the item's saveAs method throws a well-known IO error", ->
-      notificationSpy = null
-      beforeEach ->
-        atom.notifications.onDidAddNotification notificationSpy = jasmine.createSpy()
-
-      it "creates a notification", ->
-        pane.getActiveItem().saveAs = ->
-          error = new Error("EACCES, permission denied '/foo'")
-          error.path = '/foo'
-          error.code = 'EACCES'
-          throw error
-
-        pane.saveActiveItem()
-        expect(notificationSpy).toHaveBeenCalled()
-        notification = notificationSpy.mostRecentCall.args[0]
-        expect(notification.getType()).toBe 'warning'
-        expect(notification.getMessage()).toContain 'Permission denied'
-        expect(notification.getMessage()).toContain '/foo'
-
   describe "::saveActiveItemAs()", ->
     pane = null
 
@@ -423,25 +404,6 @@ describe "Pane", ->
         pane.saveActiveItemAs()
         expect(atom.showSaveDialogSync).not.toHaveBeenCalled()
 
-    describe "when the item's saveAs method throws a well-known IO error", ->
-      notificationSpy = null
-      beforeEach ->
-        atom.notifications.onDidAddNotification notificationSpy = jasmine.createSpy()
-
-      it "creates a notification", ->
-        pane.getActiveItem().saveAs = ->
-          error = new Error("EACCES, permission denied '/foo'")
-          error.path = '/foo'
-          error.code = 'EACCES'
-          throw error
-
-        pane.saveActiveItemAs()
-        expect(notificationSpy).toHaveBeenCalled()
-        notification = notificationSpy.mostRecentCall.args[0]
-        expect(notification.getType()).toBe 'warning'
-        expect(notification.getMessage()).toContain 'Permission denied'
-        expect(notification.getMessage()).toContain '/foo'
-
   describe "::itemForURI(uri)", ->
     it "returns the item for which a call to .getURI() returns the given uri", ->
       pane = new Pane(items: [new Item("A"), new Item("B"), new Item("C"), new Item("D")])

spec/workspace-spec.coffee

@@ -955,14 +955,9 @@ describe "Workspace", ->
           expect(editor.isModified()).toBeTruthy()
 
   describe "::saveActivePaneItem()", ->
-    editor = null
-    beforeEach ->
-      waitsForPromise ->
-        atom.workspace.open('sample.js').then (o) -> editor = o
-
     describe "when there is an error", ->
       it "emits a warning notification when the file cannot be saved", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           throw new Error("'/some/file' is a directory")
 
         atom.notifications.onDidAddNotification addedSpy = jasmine.createSpy()
@@ -971,7 +966,7 @@ describe "Workspace", ->
         expect(addedSpy.mostRecentCall.args[0].getType()).toBe 'warning'
 
       it "emits a warning notification when the directory cannot be written to", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           throw new Error("ENOTDIR, not a directory '/Some/dir/and-a-file.js'")
 
         atom.notifications.onDidAddNotification addedSpy = jasmine.createSpy()
@@ -980,7 +975,7 @@ describe "Workspace", ->
         expect(addedSpy.mostRecentCall.args[0].getType()).toBe 'warning'
 
       it "emits a warning notification when the user does not have permission", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           error = new Error("EACCES, permission denied '/Some/dir/and-a-file.js'")
           error.code = 'EACCES'
           error.path = '/Some/dir/and-a-file.js'
@@ -992,14 +987,14 @@ describe "Workspace", ->
         expect(addedSpy.mostRecentCall.args[0].getType()).toBe 'warning'
 
       it "emits a warning notification when the operation is not permitted", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           error = new Error("EPERM, operation not permitted '/Some/dir/and-a-file.js'")
           error.code = 'EPERM'
           error.path = '/Some/dir/and-a-file.js'
           throw error
 
       it "emits a warning notification when the file is already open by another app", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           error = new Error("EBUSY, resource busy or locked '/Some/dir/and-a-file.js'")
           error.code = 'EBUSY'
           error.path = '/Some/dir/and-a-file.js'
@@ -1014,7 +1009,7 @@ describe "Workspace", ->
         expect(notificaiton.getMessage()).toContain 'Unable to save'
 
       it "emits a warning notification when the file system is read-only", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           error = new Error("EROFS, read-only file system '/Some/dir/and-a-file.js'")
           error.code = 'EROFS'
           error.path = '/Some/dir/and-a-file.js'
@@ -1029,7 +1024,7 @@ describe "Workspace", ->
         expect(notification.getMessage()).toContain 'Unable to save'
 
       it "emits a warning notification when the file cannot be saved", ->
-        spyOn(editor, 'save').andCallFake ->
+        spyOn(Pane::, 'saveActiveItem').andCallFake ->
           throw new Error("no one knows")
 
         save = -> atom.workspace.saveActivePaneItem()

src/config.coffee

@@ -868,12 +868,7 @@ class Config
   save: ->
     allSettings = {'*': @settings}
     allSettings = _.extend allSettings, @scopedSettingsStore.propertiesForSource(@getUserConfigPath())
-    try
-      CSON.writeFileSync(@configFilePath, allSettings)
-    catch error
-      message = "Failed to save `#{path.basename(@configFilePath)}`"
-      detail = error.message
-      @notifyFailure(message, detail)
+    CSON.writeFileSync(@configFilePath, allSettings)
 
   ###
   Section: Private methods managing global settings

src/pane.coffee

@@ -481,10 +481,7 @@ class Pane extends Model
       itemURI = item.getUri()
 
     if itemURI?
-      try
-        item.save?()
-      catch error
-        @handleSaveError(error)
+      item.save?()
       nextAction?()
     else
       @saveItemAs(item, nextAction)
@@ -501,10 +498,7 @@ class Pane extends Model
     itemPath = item.getPath?()
     newItemPath = atom.showSaveDialogSync(itemPath)
     if newItemPath
-      try
-        item.saveAs(newItemPath)
-      catch error
-        @handleSaveError(error)
+      item.saveAs(newItemPath)
       nextAction?()
 
   # Public: Save all items.
@@ -673,18 +667,3 @@ class Pane extends Model
     for item in @getItems()
       return false unless @promptToSaveItem(item)
     true
-
-  handleSaveError: (error) ->
-    if error.message.endsWith('is a directory')
-      atom.notifications.addWarning("Unable to save file: #{error.message}")
-    else if error.code is 'EACCES' and error.path?
-      atom.notifications.addWarning("Unable to save file: Permission denied '#{error.path}'")
-    else if error.code in ['EPERM', 'EBUSY', 'UNKNOWN'] and error.path?
-      atom.notifications.addWarning("Unable to save file '#{error.path}'", detail: error.message)
-    else if error.code is 'EROFS' and error.path?
-      atom.notifications.addWarning("Unable to save file: Read-only file system '#{error.path}'")
-    else if errorMatch = /ENOTDIR, not a directory '([^']+)'/.exec(error.message)
-      fileName = errorMatch[1]
-      atom.notifications.addWarning("Unable to save file: A directory in the path '#{fileName}' could not be written to")
-    else
-      throw error

src/task.coffee

@@ -79,7 +79,7 @@ class Task
     taskPath = taskPath.replace(/\\/g, "\\\\")
 
     env = _.extend({}, process.env, {taskPath, userAgent: navigator.userAgent})
-    @childProcess = fork '--eval', [bootstrap], {env, cwd: __dirname}
+    @childProcess = fork '--eval', [bootstrap], {env, silent: true}
 
     @on "task:log", -> console.log(arguments...)
     @on "task:warn", -> console.warn(arguments...)
@@ -93,6 +93,11 @@ class Task
     @childProcess.removeAllListeners()
     @childProcess.on 'message', ({event, args}) =>
       @emit(event, args...) if @childProcess?
+    # Catch the errors that happened before task-bootstrap.
+    @childProcess.stdout.on 'data', (data) ->
+      console.log data.toString()
+    @childProcess.stderr.on 'data', (data) ->
+      console.error data.toString()
 
   # Public: Starts the task.
   #

src/workspace.coffee

@@ -609,7 +609,7 @@ class Workspace extends Model
   # {::saveActivePaneItemAs} # will be called instead. This method does nothing
   # if the active item does not implement a `.save` method.
   saveActivePaneItem: ->
-    @getActivePane().saveActiveItem()
+    @saveActivePaneItemAndReportErrors('saveActiveItem')
 
   # Prompt the user for a path and save the active pane item to it.
   #
@@ -617,7 +617,27 @@ class Workspace extends Model
   # `.saveAs` on the item with the selected path. This method does nothing if
   # the active item does not implement a `.saveAs` method.
   saveActivePaneItemAs: ->
-    @getActivePane().saveActiveItemAs()
+    @saveActivePaneItemAndReportErrors('saveActiveItemAs')
+
+  saveActivePaneItemAndReportErrors: (method) ->
+    try
+      @getActivePane()[method]()
+    catch error
+      if error.message.endsWith('is a directory')
+        atom.notifications.addWarning("Unable to save file: #{error.message}")
+      else if error.code is 'EACCES' and error.path?
+        atom.notifications.addWarning("Unable to save file: Permission denied '#{error.path}'")
+      else if error.code is 'EPERM' and error.path?
+        atom.notifications.addWarning("Unable to save file '#{error.path}'", detail: error.message)
+      else if error.code is 'EBUSY' and error.path?
+        atom.notifications.addWarning("Unable to save file '#{error.path}'", detail: error.message)
+      else if error.code is 'EROFS' and error.path?
+        atom.notifications.addWarning("Unable to save file: Read-only file system '#{error.path}'")
+      else if errorMatch = /ENOTDIR, not a directory '([^']+)'/.exec(error.message)
+        fileName = errorMatch[1]
+        atom.notifications.addWarning("Unable to save file: A directory in the path '#{fileName}' could not be written to")
+      else
+        throw error
 
   # Destroy (close) the active pane item.
   #