Upgrade to settings-view@0.94.0

Don't show error messages for version and help cli options

CONTRIBUTING.md

@@ -10,7 +10,7 @@ to propose changes to this document in a pull request.
     that behavior such as Emacs, vi, Xcode, etc.
   * Check the Console app for stack traces to include if reporting a crash.
   * Check the Dev tools (`alt-cmd-i`) for errors and stack traces to include.
-  
+
 ### Package Repositories
 
 This is the repository for the core Atom editor only. Atom comes bundled with

atom.sh

@@ -1,11 +1,15 @@
 #!/bin/sh
-ATOM_PATH=${ATOM_PATH-/Applications/Atom.app}
-ATOM_BINARY=$ATOM_PATH/Contents/MacOS/Atom
+ATOM_PATH=${ATOM_PATH:-/Applications} # Set ATOM_PATH unless it is already set
+ATOM_APP_NAME=Atom.app
 
-if [ ! -d $ATOM_PATH ]; then sleep 5; fi # Wait for Atom to reappear, Sparkle may be replacing it.
+# If ATOM_PATH isn't a executable file, use spotlight to search for Atom
+if [ ! -x "$ATOM_PATH/$ATOM_APP_NAME" ]; then
+  ATOM_PATH=$(mdfind "kMDItemCFBundleIdentifier == 'com.github.atom'" | head -1 | xargs dirname)
+fi
 
-if [ ! -d $ATOM_PATH ]; then
-  echo "Atom application not found at '$ATOM_PATH'" >&2
+# Exit if Atom can't be found
+if [ -z "$ATOM_PATH" ]; then
+  echo "Cannot locate Atom.app, it is usually located in /Applications. Set the ATOM_PATH environment variable to the directory containing Atom.app."
   exit 1
 fi
 
@@ -16,7 +20,11 @@ while getopts ":wtfvhs-:" opt; do
         wait)
           WAIT=1
           ;;
-        help|version|foreground|test)
+        help|version)
+          REDIRECT_STDERR=1
+          EXPECT_OUTPUT=1
+          ;;
+        foreground|test)
           EXPECT_OUTPUT=1
           ;;
       esac
@@ -24,25 +32,34 @@ while getopts ":wtfvhs-:" opt; do
     w)
       WAIT=1
       ;;
-    h|v|f|t)
+    h|v)
+      REDIRECT_STDERR=1
+      EXPECT_OUTPUT=1
+      ;;
+    f|t)
       EXPECT_OUTPUT=1
       ;;
   esac
 done
 
-if [ $EXPECT_OUTPUT ]; then
-  $ATOM_BINARY --executed-from="$(pwd)" --pid=$$ $@
-  exit $?
-else
-  open -a $ATOM_PATH -n --args --executed-from="$(pwd)" --pid=$$ $@
+if [ $REDIRECT_STDERR ]; then
+  exec 2> /dev/null
 fi
 
-# Used to exit process when atom is used as $EDITOR
+if [ $EXPECT_OUTPUT ]; then
+  "$ATOM_PATH/$ATOM_APP_NAME/Contents/MacOS/Atom" --executed-from="$(pwd)" --pid=$$ "$@"
+  exit $?
+else
+  open -a "$ATOM_PATH/$ATOM_APP_NAME" -n --args --executed-from="$(pwd)" --pid=$$ "$@"
+fi
+
+# Exits this process when Atom is used as $EDITOR
 on_die() {
   exit 0
 }
 trap 'on_die' SIGQUIT SIGTERM
 
+# If the wait flag is set, don't exit this process until Atom tells it to.
 if [ $WAIT ]; then
   while true; do
     sleep 1

build/package.json

@@ -17,7 +17,7 @@
     "grunt-contrib-csslint": "~0.1.2",
     "grunt-contrib-coffee": "~0.9.0",
     "grunt-contrib-less": "~0.8.0",
-    "grunt-cson": "0.6.0",
+    "grunt-cson": "0.8.0",
     "grunt-download-atom-shell": "git+https://atom-bot:467bac80a0017b96fb5be5cfc686f5e0cc607b10@github.com/atom/grunt-download-atom-shell#v0.6.0",
     "grunt-lesslint": "0.13.0",
     "grunt-markdown": "~0.4.0",

docs/creating-a-package.md

@@ -130,7 +130,7 @@ Ideally, you won't need much in the way of styling. We've provided a standard
 set of components which define both the colors and UI elements for any package
 that fits into Atom seamlessly. You can view all of Atom's UI components by opening
 the styleguide: open the command palette (`cmd-shift-P`) and search for _styleguide_,
-or just type `cmd-ctrl-G`.
+or just type `cmd-ctrl-shift-G`.
 
 If you _do_ need special styling, try to keep only structural styles in the package
 stylesheets. If you _must_ specify colors and sizing, these should be taken from

keymaps/darwin.cson

@@ -96,6 +96,7 @@
 '.editor':
   # Apple Specific
   'cmd-backspace': 'editor:backspace-to-beginning-of-line'
+  'cmd-shift-backspace': 'editor:backspace-to-beginning-of-line'
   'cmd-delete': 'editor:backspace-to-beginning-of-line'
   'ctrl-A': 'editor:select-to-first-character-of-line'
   'ctrl-E': 'editor:select-to-end-of-line'

menus/darwin.cson

@@ -38,7 +38,7 @@
       { label: 'Save All', command: 'window:save-all' }
       { type: 'separator' }
       { label: 'Close Buffer', command: 'core:close' }
-      { label: 'Close All Buffers', command: 'pane:close' }
+      { label: 'Close Pane', command: 'pane:close' }
       { label: 'Close Window', command: 'window:close' }
     ]
   }

package.json

@@ -1,7 +1,7 @@
 {
   "name": "atom",
   "productName": "Atom",
-  "version": "0.70.0",
+  "version": "0.73.0",
   "main": "./src/browser/main.js",
   "repository": {
     "type": "git",
@@ -11,7 +11,7 @@
     "url": "https://github.com/atom/atom/issues"
   },
   "license": "All Rights Reserved",
-  "atomShellVersion": "0.10.6",
+  "atomShellVersion": "0.10.7",
   "dependencies": {
     "async": "0.2.6",
     "bootstrap": "git://github.com/atom/bootstrap.git#6af81906189f1747fd6c93479e3d998ebe041372",
@@ -20,8 +20,8 @@
     "coffeestack": "0.7.0",
     "delegato": "1.x",
     "emissary": "1.x",
-    "first-mate": ">=1.4 <2.0",
-    "fs-plus": "2.x",
+    "first-mate": ">=1.4.2 <2.0",
+    "fs-plus": ">=2.0.4 < 3.0",
     "fstream": "0.1.24",
     "fuzzaldrin": "~1.1",
     "git-utils": "1.x",
@@ -33,12 +33,12 @@
     "loophole": "^0.3.0",
     "mixto": "1.x",
     "nslog": "0.5.0",
-    "oniguruma": "1.x",
+    "oniguruma": ">=1.0.3 <2.0",
     "optimist": "0.4.0",
-    "pathwatcher": "0.17.0",
+    "pathwatcher": "0.19.0",
     "pegjs": "0.8.0",
     "property-accessors": "1.x",
-    "q": "1.0.x",
+    "q": "^1.0.1",
     "random-words": "0.0.1",
     "runas": "0.5.x",
     "scandal": "0.15.0",
@@ -48,58 +48,58 @@
     "serializable": "1.x",
     "space-pen": "3.1.1",
     "temp": "0.5.0",
-    "text-buffer": "^1.4.2",
+    "text-buffer": "^1.4.4",
     "theorist": "1.x",
-    "underscore-plus": ">=1.0.2 <2.0",
+    "underscore-plus": ">=1.0.5 <2.0",
     "vm-compatibility-layer": "0.1.0"
   },
   "packageDependencies": {
     "atom-dark-syntax": "0.15.0",
-    "atom-dark-ui": "0.23.0",
-    "atom-light-syntax": "0.15.0",
-    "atom-light-ui": "0.22.0",
+    "atom-dark-ui": "0.25.0",
+    "atom-light-syntax": "0.16.0",
+    "atom-light-ui": "0.23.0",
     "base16-tomorrow-dark-theme": "0.13.0",
-    "solarized-dark-syntax": "0.12.0",
+    "solarized-dark-syntax": "0.14.0",
     "solarized-light-syntax": "0.7.0",
-    "archive-view": "0.26.0",
+    "archive-view": "0.29.0",
     "autocomplete": "0.27.0",
     "autoflow": "0.15.0",
-    "autosave": "0.12.0",
+    "autosave": "0.13.0",
     "background-tips": "0.9.0",
     "bookmarks": "0.21.0",
     "bracket-matcher": "0.25.0",
     "command-palette": "0.19.0",
-    "dev-live-reload": "0.28.0",
+    "dev-live-reload": "0.29.0",
     "exception-reporting": "0.17.0",
     "feedback": "0.28.0",
-    "find-and-replace": "0.89.1",
-    "fuzzy-finder": "0.39.0",
+    "find-and-replace": "0.92.0",
+    "fuzzy-finder": "0.41.0",
     "git-diff": "0.25.0",
     "go-to-line": "0.18.0",
     "grammar-selector": "0.23.0",
-    "image-view": "0.29.0",
+    "image-view": "0.30.0",
     "keybinding-resolver": "0.11.0",
     "link": "0.20.0",
-    "markdown-preview": "0.47.0",
-    "metrics": "0.30.0",
+    "markdown-preview": "0.49.0",
+    "metrics": "0.32.0",
     "open-on-github": "0.23.0",
     "package-generator": "0.30.0",
     "release-notes": "0.26.0",
-    "settings-view": "0.90.0",
-    "snippets": "0.36.0",
+    "settings-view": "0.94.0",
+    "snippets": "0.37.0",
     "spell-check": "0.28.0",
     "status-bar": "0.36.0",
     "styleguide": "0.26.0",
-    "symbols-view": "0.41.0",
-    "tabs": "0.29.0",
+    "symbols-view": "0.44.0",
+    "tabs": "0.31.0",
     "timecop": "0.17.0",
-    "tree-view": "0.76.0",
+    "tree-view": "0.80.0",
     "update-package-dependencies": "0.6.0",
     "welcome": "0.11.0",
-    "whitespace": "0.18.0",
-    "wrap-guide": "0.17.0",
+    "whitespace": "0.20.0",
+    "wrap-guide": "0.18.0",
     "language-c": "0.13.0",
-    "language-coffee-script": "0.15.0",
+    "language-coffee-script": "0.16.0",
     "language-css": "0.13.0",
     "language-gfm": "0.19.0",
     "language-git": "0.9.0",
@@ -107,23 +107,23 @@
     "language-html": "0.11.0",
     "language-hyperlink": "0.8.0",
     "language-java": "0.9.0",
-    "language-javascript": "0.17.0",
+    "language-javascript": "0.20.0",
     "language-json": "0.8.0",
     "language-less": "0.6.0",
     "language-make": "0.9.0",
     "language-objective-c": "0.10.0",
     "language-perl": "0.8.0",
-    "language-php": "0.10.0",
+    "language-php": "0.11.0",
     "language-property-list": "0.7.0",
     "language-python": "0.12.0",
-    "language-ruby": "0.15.0",
+    "language-ruby": "0.16.0",
     "language-ruby-on-rails": "0.10.0",
     "language-sass": "0.8.0",
     "language-shellscript": "0.8.0",
     "language-source": "0.7.0",
     "language-sql": "0.7.0",
     "language-text": "0.6.0",
-    "language-todo": "0.6.0",
+    "language-todo": "0.7.0",
     "language-toml": "0.11.0",
     "language-xml": "0.8.0",
     "language-yaml": "0.6.0"

spec/atom-spec.coffee

@@ -126,6 +126,16 @@ describe "the `atom` global", ->
               expect(eventHandler.callCount).toBe 2
               expect(mainModule.activate.callCount).toBe 1
 
+            it "activates the package immediately when the events are empty", ->
+              mainModule = require './fixtures/packages/package-with-empty-activation-events/index'
+              spyOn(mainModule, 'activate').andCallThrough()
+
+              waitsForPromise ->
+                atom.packages.activatePackage('package-with-empty-activation-events')
+
+              runs ->
+                expect(mainModule.activate.callCount).toBe 1
+
         describe "when the package has no main module", ->
           it "does not throw an exception", ->
             spyOn(console, "error")

spec/editor-spec.coffee

@@ -2552,7 +2552,7 @@ describe "Editor", ->
               expect(editor.lineForBufferRow(13)).toBe "}; # too many closing brackets!"
 
         describe "when inserted text does not match a decrease indent pattern", ->
-          it "does not the indentation", ->
+          it "does not decrease the indentation", ->
             editor.setCursorBufferPosition([12, 0])
             editor.insertText('  ')
             expect(editor.lineForBufferRow(12)).toBe '  };'
@@ -2786,10 +2786,18 @@ describe "Editor", ->
     describe "when the editor uses soft tabs but the row has hard tabs", ->
       it "only replaces whitespace charachters", ->
         editor.setSoftWrap(true)
-        editor.setText("	1\n	2")
+        editor.setText("\t1\n\t2")
         editor.setCursorBufferPosition([0, 0])
         editor.setIndentationForBufferRow(0, 2)
-        expect(editor.getText()).toBe("    1\n	2")
+        expect(editor.getText()).toBe("    1\n\t2")
+
+    describe "when the indentation level is a non-integer", ->
+      it "does not throw an exception", ->
+        editor.setSoftWrap(true)
+        editor.setText("\t1\n\t2")
+        editor.setCursorBufferPosition([0, 0])
+        editor.setIndentationForBufferRow(0, 2.1)
+        expect(editor.getText()).toBe("    1\n\t2")
 
   describe ".reloadGrammar()", ->
     beforeEach ->
@@ -2866,3 +2874,19 @@ describe "Editor", ->
             {tokens} = editor.lineForScreenRow(0)
             expect(tokens[2].value).toBe "SELECT"
             expect(tokens[2].scopes).toEqual ["source.js", "comment.line.double-slash.js", "keyword.other.DML.sql"]
+
+  describe ".normalizeTabsInBufferRange()", ->
+    it "normalizes tabs depending on the editor's soft tab/tab length settings", ->
+      editor.setTabLength(1)
+      editor.setSoftTabs(true)
+      editor.setText('\t\t\t')
+      editor.normalizeTabsInBufferRange([[0, 0], [0, 1]])
+      expect(editor.getText()).toBe ' \t\t'
+
+      editor.setTabLength(2)
+      editor.normalizeTabsInBufferRange([[0, 0], [Infinity, Infinity]])
+      expect(editor.getText()).toBe '     '
+
+      editor.setSoftTabs(false)
+      editor.normalizeTabsInBufferRange([[0, 0], [Infinity, Infinity]])
+      expect(editor.getText()).toBe '     '

spec/editor-view-spec.coffee

@@ -587,7 +587,7 @@ describe "EditorView", ->
         editorView.renderedLines.trigger mousedownEvent(editorView: editorView, point: [4, 10])
 
         # moving changes selection
-        $(document).trigger mousemoveEvent(editorView: editorView, point: [5, 27])
+        $(document).trigger mousemoveEvent(editorView: editorView, point: [5, 27], which: 1)
 
         range = editor.getSelection().getScreenRange()
         expect(range.start).toEqual({row: 4, column: 10})
@@ -617,12 +617,12 @@ describe "EditorView", ->
         originalScrollTop = editorView.scrollTop()
 
         # moving changes selection
-        $(document).trigger mousemoveEvent(editorView: editorView, pageX: 0, pageY: -1)
+        $(document).trigger mousemoveEvent(editorView: editorView, pageX: 0, pageY: -1, which: 1)
         expect(editorView.scrollTop()).toBe originalScrollTop - editorView.lineHeight
 
         # every mouse move selects more text
         for x in [0..10]
-          $(document).trigger mousemoveEvent(editorView: editorView, pageX: 0, pageY: -1)
+          $(document).trigger mousemoveEvent(editorView: editorView, pageX: 0, pageY: -1, which: 1)
 
         expect(editorView.scrollTop()).toBe 0
 
@@ -633,7 +633,7 @@ describe "EditorView", ->
         event = mousedownEvent(editorView: editorView, point: [4, 10])
         event.originalEvent.which = 2
         editorView.renderedLines.trigger(event)
-        $(document).trigger mousemoveEvent(editorView: editorView, point: [5, 27])
+        $(document).trigger mousemoveEvent(editorView: editorView, point: [5, 27], which: 1)
         $(document).trigger 'mouseup'
 
         range = editor.getSelection().getScreenRange()
@@ -654,6 +654,25 @@ describe "EditorView", ->
         expect(range.start).toEqual({row: 4, column: 10})
         expect(range.end).toEqual({row: 4, column: 10})
 
+      describe "when the editor is hidden", ->
+        it "stops scrolling the editor", ->
+          editorView.vScrollMargin = 0
+          editorView.attachToDom(heightInLines: 5)
+          editorView.scrollToBottom()
+
+          spyOn(window, 'setInterval').andCallFake ->
+
+          editorView.renderedLines.trigger mousedownEvent(editorView: editorView, point: [12, 0])
+          originalScrollTop = editorView.scrollTop()
+
+          $(document).trigger mousemoveEvent(editorView: editorView, pageX: 0, pageY: -1, which: 1)
+          expect(editorView.scrollTop()).toBe originalScrollTop - editorView.lineHeight
+
+          editorView.hide()
+
+          $(document).trigger mousemoveEvent(editorView: editorView, pageX: 100000, pageY: -1, which: 1)
+          expect(editorView.scrollTop()).toBe originalScrollTop - editorView.lineHeight
+
     describe "double-click and drag", ->
       it "selects the word under the cursor, then continues to select by word in either direction as the mouse is dragged", ->
         expect(editor.getCursorScreenPosition()).toEqual(row: 0, column: 0)
@@ -662,11 +681,11 @@ describe "EditorView", ->
         editorView.renderedLines.trigger mousedownEvent(editorView: editorView, point: [0, 8], originalEvent: {detail: 2})
         expect(editor.getSelectedText()).toBe "quicksort"
 
-        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [1, 8])
+        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [1, 8], which: 1)
         expect(editor.getSelectedBufferRange()).toEqual [[0, 4], [1, 10]]
         expect(editor.getCursorBufferPosition()).toEqual [1, 10]
 
-        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [0, 1])
+        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [0, 1], which: 1)
         expect(editor.getSelectedBufferRange()).toEqual [[0, 0], [0, 13]]
         expect(editor.getCursorBufferPosition()).toEqual [0, 0]
 
@@ -691,12 +710,12 @@ describe "EditorView", ->
         expect(editor.getSelectedBufferRange()).toEqual [[4, 0], [5, 0]]
 
         # moving changes selection linewise
-        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [5, 27])
+        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [5, 27], which: 1)
         expect(editor.getSelectedBufferRange()).toEqual [[4, 0], [6, 0]]
         expect(editor.getCursorBufferPosition()).toEqual [6, 0]
 
         # moving changes selection linewise
-        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [2, 27])
+        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [2, 27], which: 1)
         expect(editor.getSelectedBufferRange()).toEqual [[2, 0], [5, 0]]
         expect(editor.getCursorBufferPosition()).toEqual [2, 0]
 
@@ -706,11 +725,11 @@ describe "EditorView", ->
     describe "meta-click and drag", ->
       it "adds an additional selection", ->
         editorView.renderedLines.trigger mousedownEvent(editorView: editorView, point: [4, 10])
-        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [5, 27])
+        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [5, 27], which: 1)
         editorView.renderedLines.trigger 'mouseup'
 
         editorView.renderedLines.trigger mousedownEvent(editorView: editorView, point: [6, 10], metaKey: true)
-        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [8, 27], metaKey: true)
+        editorView.renderedLines.trigger mousemoveEvent(editorView: editorView, point: [8, 27], metaKey: true, which: 1)
         editorView.renderedLines.trigger 'mouseup'
 
         selections = editor.getSelections()

spec/fixtures/packages/package-with-empty-activation-events/index.coffee

@@ -0,0 +1 @@
+module.exports = activate: ->

spec/fixtures/packages/package-with-empty-activation-events/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "no events",
+  "version": "0.1.0",
+  "activationEvents": []
+}

spec/pane-spec.coffee

@@ -292,7 +292,7 @@ describe "Pane", ->
         pane.activeItem.path = __filename
         pane.activeItem.saveAs = jasmine.createSpy("saveAs")
         pane.saveActiveItemAs()
-        expect(atom.showSaveDialogSync).toHaveBeenCalledWith(__dirname)
+        expect(atom.showSaveDialogSync).toHaveBeenCalledWith(__filename)
         expect(pane.activeItem.saveAs).toHaveBeenCalledWith('/selected/path')
 
     describe "when the current item does not have a saveAs method", ->

spec/select-list-view-spec.coffee

@@ -43,6 +43,15 @@ describe "SelectListView", ->
       expect(list.find('li:eq(0)')).toHaveClass 'A'
       expect(selectList.getSelectedItem()).toBe items[0]
 
+    it "allows raw HTML to be returned", ->
+      selectList.viewForItem = (item) ->
+        "<li>#{item}</li>"
+
+      selectList.setItems(['Bermuda', 'Bahama'])
+
+      expect(list.find('li:eq(0)')).toHaveText 'Bermuda'
+      expect(selectList.getSelectedItem()).toBe 'Bermuda'
+
   describe "when the text of the mini editor changes", ->
     beforeEach ->
       selectList.attachToDom()

spec/spec-suite.coffee

@@ -5,7 +5,7 @@ path = require 'path'
 require './spec-helper'
 
 requireSpecs = (specDirectory, specType) ->
-  for specFilePath in fs.listTreeSync(specDirectory) when /-spec\.coffee$/.test specFilePath
+  for specFilePath in fs.listTreeSync(specDirectory) when /-spec\.(coffee|js)$/.test specFilePath
     require specFilePath
 
     # Set spec directory on spec for setting up the project in spec-helper

spec/tokenized-buffer-spec.coffee

@@ -452,3 +452,14 @@ describe "TokenizedBuffer", ->
       expect(tokenizedBuffer.tokenForPosition([0,0]).value).toBe '  '
       atom.config.set('editor.tabLength', 6)
       expect(tokenizedBuffer.tokenForPosition([0,0]).value).toBe '      '
+
+    it "does not allow the tab length to be less than 1", ->
+      buffer = atom.project.bufferForPathSync('sample.js')
+      buffer.setText('\ttest')
+      tokenizedBuffer = new TokenizedBuffer({buffer})
+      fullyTokenize(tokenizedBuffer)
+      expect(tokenizedBuffer.tokenForPosition([0,0]).value).toBe '  '
+      atom.config.set('editor.tabLength', 1)
+      expect(tokenizedBuffer.tokenForPosition([0,0]).value).toBe ' '
+      atom.config.set('editor.tabLength', 0)
+      expect(tokenizedBuffer.tokenForPosition([0,0]).value).toBe '  '

src/atom.coffee

@@ -11,10 +11,6 @@ _ = require 'underscore-plus'
 {Model} = require 'theorist'
 fs = require 'fs-plus'
 
-# this prevents CSP-related warnings for q's feature detection
-{allowUnsafeNewFunction} = require 'loophole'
-allowUnsafeNewFunction -> require 'q'
-
 {$} = require './space-pen-extensions'
 WindowEventHandler = require './window-event-handler'
 

src/browser/atom-application.coffee

@@ -198,8 +198,13 @@ class AtomApplication
     app.on 'window-all-closed', ->
       app.quit() if process.platform is 'win32'
 
-    app.on 'will-quit', => @deleteSocketFile()
-    app.on 'will-exit', => @deleteSocketFile()
+    app.on 'will-quit', =>
+      @killAllProcesses()
+      @deleteSocketFile()
+
+    app.on 'will-exit', =>
+      @killAllProcesses()
+      @deleteSocketFile()
 
     app.on 'open-file', (event, pathToOpen) =>
       event.preventDefault()
@@ -246,7 +251,26 @@ class AtomApplication
   #   The optional arguments to pass along.
   sendCommand: (command, args...) ->
     unless @emit(command, args...)
-      @focusedWindow()?.sendCommand(command, args...)
+      focusedWindow = @focusedWindow()
+      if focusedWindow?
+        focusedWindow.sendCommand(command, args...)
+      else
+        @sendCommandToFirstResponder(command)
+
+  # Translates the command into OS X action and sends it to application's first
+  # responder.
+  sendCommandToFirstResponder: (command) ->
+    return false unless process.platform is 'darwin'
+
+    switch command
+      when 'core:undo' then Menu.sendActionToFirstResponder('undo:')
+      when 'core:redo' then Menu.sendActionToFirstResponder('redo:')
+      when 'core:copy' then Menu.sendActionToFirstResponder('copy:')
+      when 'core:cut' then Menu.sendActionToFirstResponder('cut:')
+      when 'core:paste' then Menu.sendActionToFirstResponder('paste:')
+      when 'core:select-all' then Menu.sendActionToFirstResponder('selectAll:')
+      else return false
+    true
 
   # Public: Open the given path in the focused window when the event is
   # triggered.
@@ -335,13 +359,25 @@ class AtomApplication
       @pidsToOpenWindows[pidToKillWhenClosed] = openedWindow
 
     openedWindow.browserWindow.on 'destroyed', =>
-      for pid, trackedWindow of @pidsToOpenWindows when trackedWindow is openedWindow
-        try
-          process.kill(pid)
-        catch error
-          if error.code isnt 'ESRCH'
-            console.log("Killing process #{pid} failed: #{error.code}")
-        delete @pidsToOpenWindows[pid]
+      @killProcessForWindow(openedWindow)
+
+  # Kill all processes associated with opened windows.
+  killAllProcesses: ->
+    @killProcess(pid) for pid of @pidsToOpenWindows
+
+  # Kill process associated with the given opened window.
+  killProcessForWindow: (openedWindow) ->
+    for pid, trackedWindow of @pidsToOpenWindows
+      @killProcess(pid) if trackedWindow is openedWindow
+
+  # Kill the process with the given pid.
+  killProcess: (pid) ->
+    try
+      process.kill(pid)
+    catch error
+      if error.code isnt 'ESRCH'
+        console.log("Killing process #{pid} failed: #{error.code}")
+    delete @pidsToOpenWindows[pid]
 
   # Open an atom:// url.
   #

src/browser/atom-window.coffee

@@ -1,5 +1,4 @@
 BrowserWindow = require 'browser-window'
-Menu = require 'menu'
 ContextMenu = require './context-menu'
 app = require 'app'
 dialog = require 'dialog'
@@ -126,7 +125,7 @@ class AtomWindow
 
   sendCommand: (command, args...) ->
     if @isSpecWindow()
-      unless @sendCommandToFirstResponder(command)
+      unless global.atomApplication.sendCommandToFirstResponder(command)
         switch command
           when 'window:reload' then @reload()
           when 'window:toggle-dev-tools' then @toggleDevTools()
@@ -134,24 +133,13 @@ class AtomWindow
     else if @isWebViewFocused()
       @sendCommandToBrowserWindow(command, args...)
     else
-      unless @sendCommandToFirstResponder(command)
+      unless global.atomApplication.sendCommandToFirstResponder(command)
         @sendCommandToBrowserWindow(command, args...)
 
   sendCommandToBrowserWindow: (command, args...) ->
     action = if args[0]?.contextCommand then 'context-command' else 'command'
     ipc.sendChannel @browserWindow.getProcessId(), @browserWindow.getRoutingId(), action, command, args...
 
-  sendCommandToFirstResponder: (command) ->
-    switch command
-      when 'core:undo' then Menu.sendActionToFirstResponder('undo:')
-      when 'core:redo' then Menu.sendActionToFirstResponder('redo:')
-      when 'core:copy' then Menu.sendActionToFirstResponder('copy:')
-      when 'core:cut' then Menu.sendActionToFirstResponder('cut:')
-      when 'core:paste' then Menu.sendActionToFirstResponder('paste:')
-      when 'core:select-all' then Menu.sendActionToFirstResponder('selectAll:')
-      else return false
-    true
-
   close: -> @browserWindow.close()
 
   focus: -> @browserWindow.focus()

src/browser/main.coffee

@@ -77,7 +77,7 @@ parseCommandLine = ->
   options.alias('h', 'help').boolean('h').describe('h', 'Print this usage message.')
   options.alias('l', 'log-file').string('l').describe('l', 'Log all output to file.')
   options.alias('n', 'new-window').boolean('n').describe('n', 'Open a new window.')
-  options.alias('s', 'spec-directory').string('s').describe('s', 'Set the directory from which specs are loaded (default: Atom\'s spec directory).')
+  options.alias('s', 'spec-directory').string('s').describe('s', 'Set the spec directory (default: Atom\'s spec directory).')
   options.alias('t', 'test').boolean('t').describe('t', 'Run the specified specs and exit with error code on failures.')
   options.alias('v', 'version').boolean('v').describe('v', 'Print the version.')
   options.alias('w', 'wait').boolean('w').describe('w', 'Wait for window to be closed before returning.')

src/editor-view.coffee

@@ -20,7 +20,23 @@ LongLineLength = 1000
 # ## Requiring in packages
 #
 # ```coffee
-#   {EditorView} = require 'atom'
+# {EditorView} = require 'atom'
+#
+# miniEditorView = new EditorView(mini: true)
+# ```
+#
+# ## Iterating over the open editor views
+#
+# ```coffee
+# for editorView in atom.workspace.getEditorViews()
+#   console.log(editorView.getEditor().getPath())
+# ```
+#
+# ## Subscribing to every current and future editor
+#
+# ```coffee
+# atom.workspace.eachEditorView (editorView) ->
+#   console.log(editorView.getEditor().getPath())
 # ```
 module.exports =
 class EditorView extends View
@@ -445,21 +461,29 @@ class EditorView extends View
 
   selectOnMousemoveUntilMouseup: ->
     lastMoveEvent = null
-    moveHandler = (event = lastMoveEvent) =>
-      if event
-        @editor.selectToScreenPosition(@screenPositionFromMouseEvent(event))
-        lastMoveEvent = event
 
-    $(document).on "mousemove.editor-#{@id}", moveHandler
-    interval = setInterval(moveHandler, 20)
-
-    $(document).one "mouseup.editor-#{@id}", =>
+    finalizeSelections = =>
       clearInterval(interval)
       $(document).off 'mousemove', moveHandler
+      $(document).off 'mouseup', finalizeSelections
+
       @editor.mergeIntersectingSelections(isReversed: @editor.getLastSelection().isReversed())
       @editor.finalizeSelections()
       @syncCursorAnimations()
 
+    moveHandler = (event = lastMoveEvent) =>
+      return unless event?
+
+      if event.which is 1 and @[0].style.display isnt 'none'
+        @editor.selectToScreenPosition(@screenPositionFromMouseEvent(event))
+        lastMoveEvent = event
+      else
+        finalizeSelections()
+
+    $(document).on "mousemove.editor-#{@id}", moveHandler
+    interval = setInterval(moveHandler, 20)
+    $(document).one "mouseup.editor-#{@id}", finalizeSelections
+
   afterAttach: (onDom) ->
     return unless onDom
 
@@ -964,8 +988,7 @@ class EditorView extends View
       (startRow <= @firstRenderedScreenRow and endRow >= @lastRenderedScreenRow) # selection surrounds the rendered items
 
   syncCursorAnimations: ->
-    for cursorView in @getCursorViews()
-      do (cursorView) -> cursorView.resetBlinking()
+    cursorView.resetBlinking() for cursorView in @getCursorViews()
 
   autoscroll: (options={}) ->
     for cursorView in @getCursorViews()

src/editor.coffee

@@ -400,17 +400,23 @@ class Editor extends Model
   # Constructs the string used for tabs.
   buildIndentString: (number) ->
     if @getSoftTabs()
-      _.multiplyString(" ", number * @getTabLength())
+      _.multiplyString(" ", Math.floor(number * @getTabLength()))
     else
       _.multiplyString("\t", Math.floor(number))
 
-  # {Delegates to: TextBuffer.save}
+  # Public: Saves the editor's text buffer.
+  #
+  # See {TextBuffer::save} for more details.
   save: -> @buffer.save()
 
-  # {Delegates to: TextBuffer.saveAs}
-  saveAs: (path) -> @buffer.saveAs(path)
+  # Public: Saves the editor's text buffer as the given path.
+  #
+  # See {TextBuffer::saveAs} for more details.
+  #
+  # filePath - A {String} path.
+  saveAs: (filePath) -> @buffer.saveAs(filePath)
 
-  # {Delegates to: TextBuffer.getPath}
+  # Public: Returns the {String} path of this editor's text buffer.
   getPath: -> @buffer.getPath()
 
   # Public: Returns a {String} representing the entire contents of the editor.
@@ -679,7 +685,7 @@ class Editor extends Model
   # {Range}.
   normalizeTabsInBufferRange: (bufferRange) ->
     return unless @getSoftTabs()
-    @scanInBufferRange /\t/, bufferRange, ({replace}) => replace(@getTabText())
+    @scanInBufferRange /\t/g, bufferRange, ({replace}) => replace(@getTabText())
 
   # Public: For each selection, if the selection is empty, cut all characters
   # of the containing line following the cursor. Otherwise cut the selected

src/package.coffee

@@ -69,7 +69,7 @@ class Package
         @loadStylesheets()
         @grammarsPromise = @loadGrammars()
         @scopedPropertiesPromise = @loadScopedProperties()
-        @requireMainModule() unless @metadata.activationEvents?
+        @requireMainModule() unless @hasActivationEvents()
 
       catch error
         console.warn "Failed to load package named '#{@name}'", error.stack ? error
@@ -87,7 +87,7 @@ class Package
       @activationDeferred = Q.defer()
       @measure 'activateTime', =>
         @activateResources()
-        if @metadata.activationEvents?
+        if @hasActivationEvents()
           @subscribeToActivationEvents()
         else
           @activateNow()
@@ -262,6 +262,18 @@ class Package
         path.join(@path, 'index')
     @mainModulePath = fs.resolveExtension(mainModulePath, ["", _.keys(require.extensions)...])
 
+  hasActivationEvents: ->
+    if _.isArray(@metadata.activationEvents)
+      return @metadata.activationEvents.some (activationEvent) ->
+        activationEvent?.length > 0
+    else if _.isString(@metadata.activationEvents)
+      return @metadata.activationEvents.length > 0
+    else if _.isObject(@metadata.activationEvents)
+      for event, selector of @metadata.activationEvents
+        return true if event.length > 0 and selector.length > 0
+
+    false
+
   subscribeToActivationEvents: ->
     return unless @metadata.activationEvents?
     if _.isArray(@metadata.activationEvents)

src/pane-view.coffee

@@ -75,7 +75,9 @@ class PaneView extends View
     @command 'pane:split-right', => @splitRight(@copyActiveItem())
     @command 'pane:split-up', => @splitUp(@copyActiveItem())
     @command 'pane:split-down', => @splitDown(@copyActiveItem())
-    @command 'pane:close', => @model.destroy()
+    @command 'pane:close', =>
+      @model.destroyItems()
+      @model.destroy()
     @command 'pane:close-other-items', => @destroyInactiveItems()
 
   # Deprecated: Use ::destroyItem

src/pane.coffee

@@ -1,5 +1,4 @@
 {find, compact, extend, last} = require 'underscore-plus'
-{dirname} = require 'path'
 {Model, Sequence} = require 'theorist'
 Serializable = require 'serializable'
 PaneAxis = require './pane-axis'
@@ -265,10 +264,9 @@ class Pane extends Model
     return unless item?.saveAs?
 
     itemPath = item.getPath?()
-    itemPath = dirname(itemPath) if itemPath
-    path = atom.showSaveDialogSync(itemPath)
-    if path
-      item.saveAs(path)
+    newItemPath = atom.showSaveDialogSync(itemPath)
+    if newItemPath
+      item.saveAs(newItemPath)
       nextAction?()
 
   # Public: Saves all items.

src/select-list-view.coffee

@@ -153,8 +153,8 @@ class SelectListView extends View
 
       for i in [0...Math.min(filteredItems.length, @maxItems)]
         item = filteredItems[i]
-        itemView = @viewForItem(item)
-        $(itemView).data('select-list-item', item)
+        itemView = $(@viewForItem(item))
+        itemView.data('select-list-item', item)
         @list.append(itemView)
 
       @selectItemView(@list.find('li:first'))

src/selection.coffee

@@ -1,4 +1,4 @@
-{Range} = require 'text-buffer'
+{Point, Range} = require 'text-buffer'
 {Emitter} = require 'emissary'
 {pick} = require 'underscore-plus'
 
@@ -141,6 +141,8 @@ class Selection
   #
   # position - An instance of {Point}, with a given `row` and `column`.
   selectToScreenPosition: (position) ->
+    position = Point.fromObject(position)
+
     @modifySelection =>
       if @initialScreenRange
         if position.isLessThan(@initialScreenRange.start)

src/tokenized-buffer.coffee

@@ -20,7 +20,7 @@ class TokenizedBuffer extends Model
   visible: false
 
   constructor: ({@buffer, @tabLength}) ->
-    @tabLength ?= atom.config.get('editor.tabLength') ? 2
+    @tabLength ?= atom.config.getPositiveInt('editor.tabLength', 2)
 
     @subscribe atom.syntax, 'grammar-added grammar-updated', (grammar) =>
       if grammar.injectionSelector?
@@ -40,7 +40,7 @@ class TokenizedBuffer extends Model
       @emit "changed", { start: 0, end: lastRow, delta: 0 }
 
     @subscribe atom.config.observe 'editor.tabLength', callNow: false, =>
-      @setTabLength(atom.config.getPositiveInt('editor.tabLength'))
+      @setTabLength(atom.config.getPositiveInt('editor.tabLength', 2))
 
     @reloadGrammar()