Check for undefined volume object

Played a video and tried to change volume before the video finished loading and the app crashed.. Error: "TypeError: Cannot read property 'level' of undefined". Also added the change to mute callback, just in case.
Esse commit está contido em:
Oriah Ulrich
2015-04-19 14:44:19 -07:00
commit 59051a9a6c
+5 -3
Ver Arquivo
@@ -187,7 +187,9 @@ var ctrl = function(err, p, ctx) {
// toggle between mute / unmute
m: function() {
if (volume.muted) {
if(!volume) {
return;
} else if (volume.muted) {
p.unmute(function(err, status) {
if (err) return;
volume = status;
@@ -202,7 +204,7 @@ var ctrl = function(err, p, ctx) {
// volume up
up: function() {
if (volume.level >= 1) return;
if (!volume || volume.level >= 1) return;
p.setVolume(Math.min(volume.level + 0.05, 1), function(err, status) {
if (err) return;
volume = status;
@@ -211,7 +213,7 @@ var ctrl = function(err, p, ctx) {
// volume down
down: function() {
if (volume.level <= 0) return;
if (!volume || volume.level <= 0) return;
p.setVolume(Math.max(volume.level - 0.05, 0), function(err, status) {
if (err) return;
volume = status;