Fix leaks in ExtensionUpdater unit tests

BUG=http://crbug.com/16444
TEST=none

Review URL: http://codereview.chromium.org/149479

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20430 0039d316-1c4b-4281-b951-d872f2087c98
Esse commit está contido em:
asargent@chromium.org
2009-07-10 22:42:10 +00:00
commit 9247a78494
2 arquivos alterados com 8 adições e 6 exclusões
+2 -1
Ver Arquivo
@@ -466,7 +466,8 @@ bool ExtensionUpdater::Parse(const std::string& manifest_xml,
return false;
}
}
tmp_results.release(results);
results->insert(results->end(), tmp_results.begin(), tmp_results.end());
tmp_results.get().clear();
return true;
}
@@ -269,6 +269,7 @@ class ExtensionUpdaterTest : public testing::Test {
EXPECT_EQ(1u, updateable.size());
EXPECT_EQ(0, updateable[0]);
STLDeleteElements(&updates);
STLDeleteElements(&tmp);
}
static void TestMultipleManifestDownloading() {
@@ -414,23 +415,23 @@ class ExtensionUpdaterTest : public testing::Test {
// actual test code to live in ExtenionUpdaterTest methods instead of TEST_F
// subclasses where friendship with ExtenionUpdater is not inherited.
TEST(ExtensionUpdaterTest, DISABLED_TestXmlParsing) {
TEST(ExtensionUpdaterTest, TestXmlParsing) {
ExtensionUpdaterTest::TestXmlParsing();
}
TEST(ExtensionUpdaterTest, DISABLED_TestDetermineUpdates) {
TEST(ExtensionUpdaterTest, TestDetermineUpdates) {
ExtensionUpdaterTest::TestDetermineUpdates();
}
TEST(ExtensionUpdaterTest, DISABLED_TestMultipleManifestDownloading) {
TEST(ExtensionUpdaterTest, TestMultipleManifestDownloading) {
ExtensionUpdaterTest::TestMultipleManifestDownloading();
}
TEST(ExtensionUpdaterTest, DISABLED_TestSingleExtensionDownloading) {
TEST(ExtensionUpdaterTest, TestSingleExtensionDownloading) {
ExtensionUpdaterTest::TestSingleExtensionDownloading();
}
TEST(ExtensionUpdaterTest, DISABLED_TestMultipleExtensionDownloading) {
TEST(ExtensionUpdaterTest, TestMultipleExtensionDownloading) {
ExtensionUpdaterTest::TestMultipleExtensionDownloading();
}