Restore -Wall to Linux build and set up for -Werror.

* Add -Wall to build/common.gypi (and -Werror, commented out for now).
* Have build/external_code.gypi remove -Wall (and -Werror).
* Remove chromium_code definition from build/all.gyp.
* Remove chromium_code definitions from third_party/ *.gyp files.
* Remove scons-specific -Werror removal in webkit.gyp.
* Remove unused variables from:
  base/clipboard_linux.cc
  chrome/browser/gtk/download_shelf_gtk.cc
  chrome/browser/gtk/bookmark_bar_gtk.cc
Review URL: http://codereview.chromium.org/66001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98

base/clipboard_linux.cc

@@ -178,7 +178,6 @@ void Clipboard::WriteWebSmartPaste() {
 void Clipboard::WriteBitmap(const char* pixel_data, const char* size_data) {
   const gfx::Size* size = reinterpret_cast<const gfx::Size*>(size_data);
 
-  int length = size->width() * size->height() * 4;
   guchar* data = gfx::BGRAToRGBA(reinterpret_cast<const uint8_t*>(pixel_data),
                                  size->width(), size->height(), 0);
 

build/all.gyp

@@ -4,7 +4,6 @@
 
 {
   'variables': {
-    'chromium_code': 1,
     'conditions': [
       ['OS!="win"', {
         'all_gyps%': 1,

build/common.gypi

@@ -169,6 +169,9 @@
           '-fno-exceptions',
           '-msse2',
           '-mfpmath=sse',
+          '-Wall',
+          # TODO(sgk): when chromium_code targets are clean of warnings.
+          #'-Werror',
         ],
         'ldflags': [
           '-m32',

build/external_code.gypi

@@ -4,6 +4,14 @@
 
 {
   'conditions': [
+    [ 'OS=="linux"', {
+      'target_defaults': {
+        'cflags!': [
+          '-Wall',
+          '-Werror',
+        ],
+      },
+    }],
     [ 'OS=="win"', {
       'target_defaults': {
         'defines': [

chrome/browser/gtk/bookmark_bar_gtk.cc

@@ -326,7 +326,6 @@ gboolean BookmarkBarGtk::OnToolbarExpose(GtkWidget* widget,
   // A GtkToolbar's expose handler first draws a box. We don't want that so we
   // need to propagate the expose event to all the container's children.
   GList* children = gtk_container_get_children(GTK_CONTAINER(widget));
-  GList* start = children;
   while (children) {
     GList *next = children->next;
     gtk_container_propagate_expose(GTK_CONTAINER(widget),

chrome/browser/gtk/download_shelf_gtk.cc

@@ -130,15 +130,13 @@ DownloadShelfGtk::DownloadShelfGtk(TabContents* tab_contents)
   gtk_box_pack_start(GTK_BOX(shelf_), padding_bg, FALSE, FALSE, 0);
 
   // Create and pack the close button.
-  GtkWidget* centering_vbox_;
   close_button_.reset(CustomDrawButton::AddBarCloseButton(hbox_));
   g_signal_connect(G_OBJECT(close_button_->widget()), "clicked",
                    G_CALLBACK(OnButtonClick), this);
 
   // Create and pack the "Show all downloads..." link.
   // TODO(estade): there are some pixels above and below the link that
-  // can be clicked. I tried to fix this with a vbox (akin to |centering_vbox|
-  // above), but no dice.
+  // can be clicked. I tried to fix this with a vbox, but no dice.
   GtkWidget* link_box;
   GtkWidget* link_button;
   std::string link_text =

third_party/ffmpeg/ffmpeg.gyp

@@ -3,9 +3,6 @@
 # found in the LICENSE file.
 
 {
-  'variables': {
-    'chromium_code': 1,
-  },
   'includes': [
     '../../build/common.gypi',
   ],

third_party/harfbuzz/harfbuzz.gyp

@@ -3,9 +3,6 @@
 # found in the LICENSE file.
 
 {
-  'variables': {
-    'chromium_code': 1,
-  },
   'includes': [
     '../../build/common.gypi',
   ],

third_party/libevent/libevent.gyp

@@ -3,9 +3,6 @@
 # found in the LICENSE file.
 
 {
-  'variables': {
-    'chromium_code': 1,
-  },
   'includes': [
     '../../build/common.gypi',
   ],

webkit/webkit.gyp

@@ -3988,10 +3988,6 @@
             #   .../WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp
             '-Wno-multichar',
           ],
-          # TODO(sgk):  unnecessary once common.gypi gets Linux settings
-          # necessary to avoid build failure due to warnings generated by:
-          #   ../third_party/WebKit/WebCore/dom/Document.cpp
-          'scons_remove' : {'CXXFLAGS' : ['-Werror']},
         }],
         ['OS=="mac"', {
           'actions': [