I found more tests...

So, I was being dumb and thought that that only tests zend had were in the folder called Zend/tests. On happenstance I typed a bad find command and found tons more tests all over the directory structure. I sort of figured out their directory structure and changed the importer to do all of it. Now we have an order of magnitude more tests. I didn't want a very deep directory structure so I replaced their ##/## with ##-##, but I'm open to other ideas.

The import script simulation of sscanf got crazyier since it now sees all sorts of nutty things like ##'%\0'##. I left the exception handing for errors incase zend adds more things that we need to parse.

Some of these tests are really really bad. They spew files all over your directory tree. Some with names that have nulls in them and other wonderful things. I'll start monkey-patching them. Only 1 test in the good directory does that, so I'll do that first.

Our coverage is MUCH worse now, but there are lot of unimplemented extensions and non .phpt file dependancies (@sgolemon not everything is encapsulated as tightly in one file). I'm sure I'll have some fun going through these.

We are at 2836 good and 9176 bad.

I've debated to use the actual php ##run_tests.php## but it seems very specialized. @sgolemon do you think it can't be wrangled into our tests? Or maybe output a compatible format?

I'm splitting the diffs up so we have a hope of hudson running them. I added the ##-o## option to help in that. This first diff basically moves all the tests into another dir but shouldn't change any. I'll send many other diffs for all the others tests.

hphp/test/zend/bad/bug48228.php.exp

@@ -1,6 +0,0 @@
-HipHop Fatal error: Uncaught exception 'Exception' in %s
-Stack trace:
-#0 %s(%d): do_throw()
-#1 %s(%d): aa->dosome()
-#2 {main}
-  thrown in %s

hphp/test/zend/bad/bug48408.php.exp

@@ -1,5 +0,0 @@
-HipHop Fatal error: Uncaught exception 'Exception' in %s
-Stack trace:
-#0 %s(%d): C->generate(0)
-#1 {main}
-  thrown in %s

hphp/test/zend/bad/bug55554d.php.exp

@@ -1,2 +0,0 @@
-HipHop Fatal error: ReportCollision has colliding constructor definitions coming from traits in hphp/test/zend/bad/bug55554d.php on line %d
-

hphp/test/zend/bad/cli.hdf

@@ -1,44 +0,0 @@
-Server {
-  InjectedStacktrace = true
-}
-
-Eval {
-  EnableXHP = true
-  IncludePaths {
-    * = .
-    * = /usr/local/lib/php
-    * = /usr/local/php/lib/php
-  }
-}
-
-Sandbox {
-  MySQLReadTimeout = 5000
-}
-
-MySQL {
-  ReadTimeout = 5000
-}
-
-EnvVariables {
-  HPHP_INTERPRETER = 1
-}
-
-ServerVariables {
-  ALPHA_CONSOLE = 1
-  TFBENV = 16777216
-}
-
-ErrorHandling {
-  NoticeFrequency = 1
-  WarningFrequency = 1
-}
-
-ResourceLimit {
-  SerializationSizeLimit=134217728
-}
-
-LintExcludePatterns {
-  * = Server.InjectedStacktrace
-  * = Eval.IncludePaths*
-  * = Sandbox.MySQLReadTimeout
-}

hphp/test/zend/bad/exception_003.php.exp

@@ -1,4 +0,0 @@
-HipHop Fatal error: Uncaught exception 'Exception' with message '1' in %s:%d
-Stack trace:
-#0 {main}
-  thrown in hphp/test/zend/bad/exception_003.php on line %d

hphp/test/zend/bad/ns_068.php.exp

@@ -1 +0,0 @@
-HipHop Fatal error: Namespace declaration statement has to be the very first statement in the script in %sns_068.php on line %d

hphp/test/zend/bad/zend-multibyte/multibyte_encoding_006.php.exp

@@ -1 +1,2 @@
+
 HipHop Fatal error: Could not convert the script from the detected encoding "UTF-32LE" to a compatible encoding in Unknown on line 0

hphp/test/zend/bad/zend-traits-bugs/missing-trait.php.exp

@@ -0,0 +1 @@
+HipHop Fatal error: Trait 'THello' not found in hphp/test/zend/bad/missing-trait.php on line %d

hphp/test/zend/bad/zend-traits/bug55554a.php

@@ -24,4 +24,4 @@ echo "New constructor: ";
 $o = new NewConstructor;
 
 echo "Legacy constructor: ";
-$o = new LegacyConstructor;
+$o = new LegacyConstructor;

hphp/test/zend/bad/zend-traits/bug55554b.php

@@ -42,4 +42,5 @@ class ReportCollision {
 
 
 echo "ReportCollision: ";
-$o = new ReportCollision;
+$o = new ReportCollision;
+

hphp/test/zend/bad/zend-traits/bug55554e.php

@@ -20,4 +20,5 @@ class ReportCollision {
 
 
 echo "ReportCollision: ";
-$o = new ReportCollision;
+$o = new ReportCollision;
+

hphp/test/zend/bad/zend-traits/bug55554f.php

@@ -19,4 +19,5 @@ class ReportCollision {
 
 
 echo "ReportCollision: ";
-$o = new ReportCollision;
+$o = new ReportCollision;
+

hphp/test/zend/bad/zend-traits/bug55554g.php

@@ -19,4 +19,5 @@ class ReportCollision {
 
 
 echo "ReportCollision: ";
-$o = new ReportCollision;
+$o = new ReportCollision;
+

hphp/test/zend/bad/zend-traits/bug60153.php

@@ -10,4 +10,4 @@ trait TFoo {
 
 class C implements IFoo {
   use TFoo;
-}
+}

hphp/test/zend/bad/zend-traits/bug60165a.php

@@ -8,4 +8,4 @@ class MyClass {
     use A {
         nonExistent as barA;
     }
-}
+}

hphp/test/zend/bad/zend-traits/bug60165b.php

@@ -8,4 +8,4 @@ class MyClass {
     use A {
         A::nonExistent as barA;
     }
-}
+}

hphp/test/zend/bad/zend-traits/bug60165c.php

@@ -13,4 +13,4 @@ class MyClass {
         foo as fooB;
         baz as foobar;
     }
-}
+}

hphp/test/zend/bad/zend-traits/bug60165d.php

@@ -12,4 +12,4 @@ class MyClass {
     use A, B {
         A::bar insteadof B;
     }
-}
+}

hphp/test/zend/bad/zend-traits/bug60173.php

@@ -3,4 +3,4 @@
 trait foo { }
 
 $rc = new ReflectionClass('foo');
-$rc->newInstance();
+$rc->newInstance();

hphp/test/zend/bad/zend-traits/bug60173.php.exp

@@ -1 +1 @@
-HipHop Fatal error: Cannot instantiate trait foo in hphp/test/zend/good/bug60173.php on line 6
+HipHop Fatal error: Cannot instantiate trait foo in hphp/test/zend/bad/bug60173.php on line %d

hphp/test/zend/bad/zend-traits/bug60217b.php

@@ -17,4 +17,4 @@ class CBroken {
 }
 
 $o = new CBroken;
-$o->foo(1);
+$o->foo(1);

hphp/test/zend/bad/zend-traits/bug60217c.php

@@ -17,4 +17,4 @@ class CBroken {
 }
 
 $o = new CBroken;
-$o->foo(1);
+$o->foo(1);

hphp/test/zend/bad/zend-traits/error_002.php.exp

@@ -0,0 +1 @@
+HipHop Fatal error: Trait 'abc' not found in hphp/test/zend/bad/error_002.php on line %d

hphp/test/zend/bad/zend-traits/error_003.php.exp

@@ -1 +1 @@
-HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/good/error_003.php on line 6
+HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/bad/error_003.php on line %d

hphp/test/zend/bad/zend-traits/error_004.php.exp

@@ -1 +1 @@
-HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/good/error_004.php on line 6
+HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/bad/error_004.php on line %d

hphp/test/zend/bad/zend-traits/error_005.php.exp

@@ -1 +1 @@
-HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/good/error_005.php on line 6
+HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/bad/error_005.php on line %d

hphp/test/zend/bad/zend-traits/error_006.php.exp

@@ -1 +1 @@
-HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/good/error_006.php on line 6
+HipHop Fatal error: A cannot use abc - it is not a trait in hphp/test/zend/bad/error_006.php on line %d

hphp/test/zend/bad/zend-traits/error_007.php.exp

@@ -1 +1 @@
-HipHop Fatal error: Cannot instantiate trait abc in hphp/test/zend/good/error_007.php on line 6
+HipHop Fatal error: Cannot instantiate trait abc in hphp/test/zend/bad/error_007.php on line %d

hphp/test/zend/bad/zend-traits/error_008.php.exp

@@ -1 +1 @@
-HipHop Fatal error: foo cannot implement abc - it is not an interface in hphp/test/zend/good/error_008.php on line 5
+HipHop Fatal error: foo cannot implement abc - it is not an interface in hphp/test/zend/bad/error_008.php on line %d