drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes
ERROR: trailing statements should be on next line #23: FILE: drivers/net/tulip/de4x5.c:5477: + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT; total: 1 errors, 0 warnings, 8 lines checked ./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com> Cc: Grant Grundler <grundler@parisc-linux.org> Cc: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Esse commit está contido em:
@@ -5474,7 +5474,8 @@ de4x5_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
|
||||
tmp.lval[6] = inl(DE4X5_STRR); j+=4;
|
||||
tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
|
||||
ioc->len = j;
|
||||
if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
|
||||
if (copy_to_user(ioc->data, tmp.lval, ioc->len))
|
||||
return -EFAULT;
|
||||
break;
|
||||
|
||||
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
|
||||
|
||||
Referência em uma Nova Issue
Bloquear um usuário