Tim Kuipers
5a48d86bd7
refactor: handle layer plans outside of buffer (CURA-3339)
...
allocation is handled outside buffer
writing gcode is handled outside buffer
buffer processing is handled separately from adding to the buffer
2017-02-17 11:44:53 +01:00
Tim Kuipers
79cb7850e9
refactor: simplified processLayer calls (CURA-3339)
2017-02-17 11:44:53 +01:00
Tim Kuipers
9e4a786f3d
refactor: clean up GCodePathConfig (CURA-3339)
...
have one constructor rather than a constructor, init, setLayerHeight and smoothSpeed
2017-02-17 11:44:53 +01:00
Tim Kuipers
fe49157ca8
refactor: PathConfigs ==> PathConfigStorage (CURA-3339)
...
because the structure follows the structure of SliceDataStorage.
2017-02-17 11:44:53 +01:00
Tim Kuipers
889c2e4b13
fix: GCodePathConfig extrusion_per_mm was calculated too early (CURA-3339)
...
this resulted in all extrusion lines being replaced by travel paths.
This problem was introduced a couple of commits ago.
The underlying problem, that there needs to be a definite order between init and setLayerHeight, will be solved in a commit soon to come.
2017-02-17 11:44:53 +01:00
Tim Kuipers
ca3848f79a
fix: const correctness (except some const_cast instances!) (CURA-3339)
2017-02-17 11:44:53 +01:00
Tim Kuipers
77f1aebef9
fix: bundle state from gcodePlanner into class (CURA-3339)
...
this helps in making GCodePlanner multithreaded
The state of the gcodePlanner which is carried over to the next layer is bundled in a nice package, which is to be dealt with soon in a coming commit
2017-02-17 11:44:53 +01:00
Tim Kuipers
046c34b31b
lil gitignore
2017-02-17 11:44:53 +01:00
Tim Kuipers
066a0d7318
fix: move writeGcode configs out of sliceDataStorage (CURA-3339)
...
This contributes to making sliceDataStorage const after FffPolygonGenerator has been called
2017-02-17 11:44:53 +01:00
Tim Kuipers
989317a293
fix: const correctness in combing (CURA-3339)
2017-02-17 11:43:45 +01:00
Tim Kuipers
cf3d18eb75
fix: const correctness in prime tower (CURA-3339)
2017-02-17 11:43:45 +01:00
Tim Kuipers
c9096424c1
fix: lil const correctnes MergeInfillLines (CURA-3339)
2017-02-17 11:43:45 +01:00
Tim Kuipers
d489143fcb
fix: const correctness in polygon (CURA-3339)
2017-02-17 11:43:45 +01:00
Tim Kuipers
8ac3b49549
refactor: introduced ConstPolygonRef (CURA-3339)
...
Adapted from 9712301aa8
From @Johan3DV 'Improve const correctness and remove const_cast'
2017-02-17 11:43:45 +01:00
Tim Kuipers
bdb788e3c4
don't generate towers when support_use_towers is disabled (CURA-3288)
2017-02-15 12:48:46 +01:00
Tim Kuipers
5b00c21a5f
Merge branch 'feature_omp_settings'
2017-02-15 12:19:21 +01:00
Tim Kuipers
b546f66bbe
Merge branch 'feature_omp_skin_infill'
2017-02-15 12:16:37 +01:00
Tim Kuipers
2af8320cc9
Merge branch 'feature_omp_slicing'
2017-02-15 12:16:11 +01:00
Tim Kuipers
5fa5c89935
fix: const correctness of getSetting functions (CURA-3372)
2017-02-15 12:05:14 +01:00
Tim Kuipers
5c40f74c68
feat: small optimization in setting value retrieval (CURA-3372)
2017-02-15 12:03:11 +01:00
Tim Kuipers
60cebc86eb
fix: error on unknown unset setting, rather than warn (CURA-3372)
...
this als oremoves a const_cast :)
2017-02-15 12:02:36 +01:00
Tim Kuipers
1bb4e03b36
fix: remove superfluous const_cast (CURA-3372)
2017-02-15 11:46:01 +01:00
Tim Kuipers
677857a186
fix: lil (CURA-3331)
2017-02-09 21:13:26 +01:00
Tim Kuipers
156674e452
fix: bs include (CURA-3331)
2017-02-09 17:44:23 +01:00
Tim Kuipers
903b31d381
Merge branch 'feature_omp_skin_infill' of github.com:Ultimaker/CuraEngine into feature_omp_skin_infill
2017-02-09 17:41:49 +01:00
Tim Kuipers
734978230f
lil (CURA-3330)
2017-02-09 17:41:45 +01:00
Tim Kuipers
fa02006a5d
fix: logging of OpenMP threads in main (CURA-3330)
2017-02-09 15:30:45 +01:00
Ghostkeeper
6861020c6b
Remove irrelevant documentation of different function
...
This documentation of processInsets reports on one of the generateInsets functions. Probably a copy-paste mistake.
Contributes to issue CURA-3330.
2017-02-08 16:43:13 +01:00
Ghostkeeper
2d9a3c83ef
Code style: Space after for keyword
...
Contributes to issue CURA-3330.
2017-02-08 16:29:02 +01:00
Ghostkeeper
ab7e035f6e
Don't continue with compiling when function has error
...
This would give an exception which breaks the script and makes a very unclear chained error message.
Contributes to issue CURA-2572.
2017-02-03 17:05:28 +01:00
Ghostkeeper
d0a149cf26
Fix error handling when setting has a parse error
...
The code was an integer. It needs to be converted to a string in order to be added to other strings.
Contributes to issue CURA-2572.
2017-02-03 17:05:28 +01:00
Tim Kuipers
4d35735aa8
Merge pull request #451 from smartavionics/mb-spiralize-bug
...
Fix spiralize args bug - untested but this just looked wrong to me.
2017-02-02 13:12:49 +01:00
Mark Burton
5e831f99e9
Fix spiralize args bug - untested but this just looked wrong to me.
2017-02-02 08:08:50 +00:00
Tim Kuipers
04766f663b
Add OpenMP parallel execution createLayerParts (CURA-3331)
2017-02-01 13:26:51 +01:00
Tim Kuipers
42684e6368
feat: Add OpenMP parallel execution of slice make polygons (CURA-3331)
2017-01-31 11:41:34 +01:00
Ghostkeeper
aa14682087
Remove 'l' formatting character and simplify+speed-up int2mm formatting
...
The 'l' formatting character in combination with 'd' was not allowed with MinGW on Windows. Simply formatting with 'd' is sufficient since our coordinates are allowed to be cast to integers at this stage: We won't need to square them any more or anything.
Contributes to issue CURA-3274.
2017-01-31 10:35:28 +01:00
Tim Kuipers
4c5a959c4e
fix: handle multithreaded progress messages (CURA-781)
2017-01-30 17:41:33 +01:00
Johan Kristensen
21746022c4
Add OpenMP parallel execution of processInsets
...
CURA-541
2017-01-30 17:36:12 +01:00
Johan Kristensen
d6bf9be54e
Add OpenMP parallel execution of processSkinsAndInfill
...
CURA-541
2017-01-30 17:35:59 +01:00
Johan K
fff1164042
Add cmake option to enable OpenMP
...
CURA-541
2017-01-30 17:30:44 +01:00
Ghostkeeper
c7e621eeb5
Merge branch '2.4'
2017-01-25 17:46:07 +01:00
Ghostkeeper
9c3170b277
Print debug message upon sending layer data
...
This should help a bit with debugging the slice loop. I hope.
Contributes to issue CURA-3274.
2017-01-25 17:45:34 +01:00
Ghostkeeper
e2f89778e2
Remove p1 after inserting point next to it
...
Because this insertion requires dereferencing p1. If it has been removed from the list, dereferencing it would remove it from memory so that would be an invalid pointer reference.
Contributes to debugging issue CURA-3274.
2017-01-25 14:40:11 +01:00
Ghostkeeper
8f74952aca
Replace last long in gcodeExport with int64_t
...
Previously we had a crash only on windows because the long was not long enough. Perhaps this fixes something with the slicing loop.
Contributes to issue CURA-3274.
2017-01-25 13:36:14 +01:00
Ghostkeeper
5b6f1db59d
Merge branch 'mb-min-infill-area' of https://github.com/smartavionics/CuraEngine into smartavionics-mb-min-infill-area
2017-01-24 11:40:03 +01:00
Tim Kuipers
17463e1139
quick fix: accidental const (CURA-3309)
2017-01-23 17:37:17 +01:00
Tim Kuipers
8df26ae916
fix: equalize flow still equalizes after halving the line width for perimeter gaps (CURA-3309)
2017-01-23 17:36:24 +01:00
Tim Kuipers
9ac9d1dd59
Merge branch '2.4'
2017-01-23 14:54:16 +01:00
Tim Kuipers
c2aa1d59bc
fix: add perimeter_gaps config with line width of half the inner wall line width (CURA-3309)
...
also the perimeter gaps of the skin walls now have to be generated separately
2017-01-23 14:53:57 +01:00
Tim Kuipers
3d476f114b
Merge branch '2.4'
2017-01-23 10:22:54 +01:00
Tim Kuipers
152f6e89a8
fix: more safety against empty layers (CURA-3290)
2017-01-20 16:56:01 +01:00
Tim Kuipers
113202cd34
fix: types in CubicSubdiv were wrong (CURA-3196)
...
the sphere_slice_radius2 was a long rather than a coord_t (long long)
2017-01-20 15:23:34 +01:00
Tim Kuipers
4bc706d618
fix: perimeter gaps were introduced for the overlap between infill and skin (CURA-3179)
...
this caused extra overextrusion where infill and skin meet
2017-01-20 15:01:51 +01:00
Tim Kuipers
5766e2db11
fix: don't fill gaps for outer wall when spiralize is enabled (CURA-3152)
2017-01-20 14:21:14 +01:00
Tim Kuipers
671ebccdbb
fix: indentation only (CURA-3271)
2017-01-20 14:08:56 +01:00
Tim Kuipers
2516165c86
fix: there were no support bottoms on top of the first model in support of the second model (CURA-3271)
...
All support areas are now generated before generating the interface. They are stored in supportLayer.supportAreas right after generation of the areas.
generateSupportInterface then operates on the merged supportAreas.
Note that this has a performace impact: while evaluating support interface, the support of all models is considered, rather than only the support it introduced itself.
2017-01-20 14:08:29 +01:00
Tim Kuipers
0315aaf404
fix: support top distance was one layer too high (CURA-3269)
2017-01-20 13:26:39 +01:00
Mark Burton
b43e4df3aa
Remove areas of infill smaller than min_infill_area.
...
When you have a small feature above an outer layer (e.g. raised text), the
area under the feature will be infill rather than skin and so the skin is
composed of multiple segments around the feature. Better surface quality is
obtained if the area under the raised feature is treated as skin thus allowing
more of the outer layer to be printed as a single segment. This setting
specifies the minimum area (in mm^2) of a filled region. Areas smaller than
this will be filled with skin rather than infill.
2017-01-19 11:44:22 +00:00
Ghostkeeper
405c49133b
Merge branch 'first-layer-skin-pattern' of https://github.com/14bitVoid/CuraEngine into 14bitVoid-first-layer-skin-pattern
2017-01-03 10:42:31 +01:00
Tim Kuipers
49f09ed204
fix: (anti) support meshes could f*ck up the printZ of each layer (CURA-3198)
...
those meshes didn't call createLayerParts and so their printZ was never set.
To determine the print height of a layer an arbitrary mesh was used to see the printZ.
2017-01-02 23:03:40 +01:00
14bitVoid
e717404055
Use different skin pattern on first layer
2017-01-02 22:30:41 +01:00
Ghostkeeper
3e7d623c86
Make total bounding box use head coordinates
...
Instead of nozzle coordinates.
2016-12-20 15:49:37 +01:00
Ghostkeeper
d694bff227
Remove superfluous comment
...
A bit witty, perhaps, but unnecessary.
Contributes to issue CURA-3137.
2016-12-15 12:03:28 +01:00
Ghostkeeper
05be030c45
Document range check for pre-computed cubes
...
Contributes to issue CURA-3137.
2016-12-14 15:15:20 +01:00
Ghostkeeper
3c5e745f83
Reintroduce assert for coordinates exceeding maximum int
...
Because we might still test with models of 2km size.
Contributes to issue CURA-3137.
2016-12-14 14:09:16 +01:00
Ghostkeeper
2e6cd36f20
Make unused parameters unnamed
...
This way they cannot be used any more.
Shuts the compiler up for issue CURA-3137.
2016-12-14 12:02:00 +01:00
Ghostkeeper
9fc4a427cd
Removed checks of unsigned ints being >= 0
...
Because that's always true. Even the compiler says that.
Contributes sorta to issue CURA-3137.
2016-12-14 12:00:39 +01:00
Ghostkeeper
5729908023
Remove unused path parameter
...
According to the compiler, the path parameter of handleChildren was not unused, but that was only because it went recursively to subcalls to handleChildren, so it was actually also unused.
Contributes to issue CURA-3137.
2016-12-14 11:55:40 +01:00
Ghostkeeper
c5b90b0ad9
Put check for empty extruder trains before size check
...
Could save a miniscule amount of time.
Contributes to issue CURA-3137.
2016-12-14 11:50:45 +01:00
Ghostkeeper
382343e558
Make recursion depth unsigned
...
It can't be negative anyway. And it helps with the signed-unsigned comparison checks.
Contributes to issue CURA-3137.
2016-12-14 11:48:46 +01:00
Ghostkeeper
68b293b880
Make subdivided cubic infill robust to 0% infill
...
Otherwise it would crash or loop forever.
Contributes to issue CURA-3137.
2016-12-14 11:44:34 +01:00
Ghostkeeper
f867c0f53a
Prevent crashing when given no extruder trains
...
Instead we return -1. A bit more robust.
Contributes to issue CURA-3137.
2016-12-14 11:05:05 +01:00
Ghostkeeper
ee7e83d138
Merge branch 'mb-layer-height-comment' of https://github.com/smartavionics/CuraEngine into smartavionics-mb-layer-height-comment
2016-12-14 09:29:53 +01:00
Ghostkeeper
50df40c6c6
Revert "Re-use extruder train variable"
...
This reverts commit c9217d4738 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
4d924fd33d
Revert "Add park distance information to retraction config"
...
This reverts commit 23ef513cce .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
c953a726cb
Revert "Add function to move filament to park position"
...
This reverts commit ae00cbe497 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
7c8c0b2417
Revert "Correct speed of retraction"
...
This reverts commit 6925f39426 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
a834754d64
Revert "Remove some annoying compile warnings"
...
This reverts commit d75882a707 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
9957a0c733
Revert "Fix updating current E value"
...
This reverts commit 80f8760f68 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
f6ce0b4141
Revert "Put filament in parking position when we never use it any more"
...
This reverts commit 3cb3e5de45 .
Contributes to issue CURA-2795.
2016-12-13 15:35:47 +01:00
Ghostkeeper
120a9c440c
Revert "Park filament even if printer doesn't support retraction"
...
This reverts commit 837f992f69 .
Contributes to issue CURA-2795.
2016-12-13 15:35:46 +01:00
Ghostkeeper
59f72bdd98
Revert "Expand documentation of writePark"
...
This reverts commit 4f3b4f429d .
Contributes to issue CURA-2795.
2016-12-13 15:35:46 +01:00
Ghostkeeper
abc43302ac
Revert "Correct retraction speed"
...
This reverts commit 36eb3471df .
Contributes to issue CURA-2795.
2016-12-13 15:35:46 +01:00
Mark Burton
c2725bdf83
Move layer_height out of the GCodeExport class - it doesn't need to be a member.
2016-12-13 13:47:39 +00:00
Tim Kuipers
fb761dfd9d
fix: don't generate perimeter_gaps between inner wall and infill/skin when there is no infill (CURA-3108)
2016-12-13 13:53:05 +01:00
Mark Burton
90727a0578
Merge branch 'master' into mb-layer-height-comment
2016-12-13 08:05:31 +00:00
Mark Burton
fd7d1a4bd4
Add comment that reports layer height in RepRap flavour gcode.
2016-12-12 16:54:13 +00:00
Ghostkeeper
2b1266c647
Move implementation to CPP file
...
Contributes to issue CURA-3006.
2016-12-12 14:04:32 +01:00
Ghostkeeper
901bf47610
Move implementation to CPP file
...
Contributes to issue CURA-3006.
2016-12-12 13:55:47 +01:00
Ghostkeeper
80a6115537
Move implementation to CPP file
...
Contributes to issue CURA-3006.
2016-12-12 13:44:23 +01:00
Ghostkeeper
f94ca645bd
Make writeRetraction accept const ref instead of const pointer
...
This change was already made for CURA-2795, and upon this change was built by other commits for other issues. I had to revert CURA-2795, so that would undo the changes that the other commits depend on. Instead though, I un-reverted the change because it's nice and doesn't have anything inherently to do with CURA-2795.
Contributes to issue CURA-2795.
2016-12-12 13:11:03 +01:00
Ghostkeeper
2067644d30
Revert "Update prime speed corresponding to park retraction"
...
This reverts commit 6c986e6cfe .
Contributes to issue CURA-2795.
2016-12-12 12:57:15 +01:00
Ghostkeeper
0285e2f025
Revert "Add additional safety check for extruder switching off in later layers"
...
This reverts commit bc82fd98c9 .
Contributes to issue CURA-2795.
2016-12-12 12:57:15 +01:00
Ghostkeeper
38a1ee4270
Revert "Allow going to stand-by temperature if nozzle is later used"
...
This reverts commit 3c0d3f1b2d .
Contributes to issue CURA-2795.
2016-12-12 12:57:15 +01:00
Ghostkeeper
63459d5cd4
Revert "Correct documentation on why the temperature is switched off later"
...
This reverts commit 6972101d7e .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
138691436e
Revert "Correct technicality in documentation"
...
This reverts commit ab2c2eed4b .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
b9c5b4593b
Revert "Remove unused parameter"
...
This reverts commit b7e9f72023 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
a0a3a24dc1
Revert "Restore park distance exception for BFB g-code"
...
This reverts commit b6355b69e7 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
5959b41132
Revert "Use filament park distance setting instead of direct heat & cool zones"
...
This reverts commit b0487fa4c7 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
3d7229c9f2
Revert "Turn extruder temperature off only if it parked the filament"
...
This reverts commit 84d3381be6 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
e1cfc3d93b
Revert "Break retraction in two"
...
This reverts commit a0625aa735 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
5834540bec
Revert "Rename writeRetractionMove to writeMoveFilament"
...
This reverts commit 7c39b6b26a .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
f191d23e17
Revert "Pass retraction configs by reference instead of pointer"
...
This reverts commit 7a8be50b8f .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
5114ab4218
Revert "Use writeMoveFilament to retract to parking distance"
...
This reverts commit cb7b7bf22a .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
9f5645ecac
Revert "Protect writeMoveFilament"
...
This reverts commit 52220ccab8 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
66befe5827
Revert "Correct documentation of extruder_switch parameter"
...
This reverts commit 4263801d16 .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
c9de64f946
Revert "Use optional to denote uninitiated previous extruder temperature"
...
This reverts commit 460c52ea6c .
Contributes to issue CURA-2795.
2016-12-12 12:57:14 +01:00
Ghostkeeper
dbfa3a0f4b
Revert "Move park distance data to ExtruderTrainAttributes"
...
This reverts commit 7777668b86 .
Contributes to issue CURA-2795.
2016-12-12 12:54:56 +01:00
Ghostkeeper
02268eb7e8
Revert "Park via E-moves instead of via a retraction"
...
This reverts commit 6350f47cd6 .
Contributes to issue CURA-2795.
2016-12-12 12:54:56 +01:00
Tim Kuipers
d2b8c8bf17
Merge pull request #417 from smartavionics/mb-fix-total-filament-report
...
Reinstate filament used comment for RepRap flavour gcode.
2016-12-12 11:32:58 +01:00
Tim Kuipers
d00f5efa77
lil fix: assert used unset extruder_count
2016-12-11 23:12:20 +01:00
Tim Kuipers
b8d7162daf
lil cast warning fix
2016-12-11 11:56:51 +01:00
Tim Kuipers
b0293e2d6a
refactor: processSkin ==> processSkinAndPerimeterGaps (CURA-3108)
2016-12-11 11:50:07 +01:00
Tim Kuipers
e998eb8899
fix: perform perimeter gaps rounding safety offset only from one side (CURA-3108)
...
saves computation time
2016-12-11 11:24:01 +01:00
Tim Kuipers
731a69ff86
fix: perimeter gaps offset wasn't used (CURA-3108)
2016-12-11 11:04:49 +01:00
Tim Kuipers
d2d34f89d5
lil doc pf planPrime (CURA-3006)
2016-12-10 14:40:58 +01:00
Tim Kuipers
0ad7bd747c
fix: extruder was switched without pre-switch code (CURA-3006)
2016-12-10 14:36:13 +01:00
Tim Kuipers
3ad4dbd62e
fix: plan a prime at a specified location (CURA-3006)
2016-12-10 14:26:30 +01:00
Tim Kuipers
b5c8f95713
safety: assert in Meshgroup::getExtruderTrain (URA-3006)
2016-12-10 13:57:51 +01:00
Tim Kuipers
1590c18041
refactor: make explicit why only GRIFFIN needs to have priming on the initial layer (CURA-3006)
2016-12-10 13:54:25 +01:00
Tim Kuipers
405e8bdd0e
fix: properly determine the starting extruder everywhere (CURA-3006)
2016-12-10 13:14:51 +01:00
Tim Kuipers
06c74c3151
lil refactor: initialize FffGcodeWriter members in initializer list (CURA-3006)
2016-12-10 12:40:24 +01:00
Tim Kuipers
28304d1aa9
refactor: compute starting extruder outside of processStartingCode (CURA-3006)
2016-12-10 12:28:27 +01:00
Tim Kuipers
a18d61ccb3
refactor: reduced code duplication in Preheat (CURA-3006)
2016-12-10 12:12:51 +01:00
Ghostkeeper
6350f47cd6
Park via E-moves instead of via a retraction
...
While parking the filament is essentially a retraction, it should not be called this way and therefore we should make an exception for park moves that they do not allow the printer to decide for itself how far to retract the filament.
Contributes to issue CURA-2795.
2016-12-09 16:04:01 +01:00
Ghostkeeper
e25a0d1305
Rename near to nearby
...
Because 'near' is a built-in keyword in the MSVC compiler. You can't use that as a variable name.
Contributes to issue CURA-1112.
2016-12-09 14:06:37 +01:00
Ghostkeeper
31179cab5c
Revert "Use std::next instead of incrementing .begin()"
...
This reverts commit c85146457e .
Contributes to issue CURA-1112.
2016-12-09 14:03:19 +01:00
Ghostkeeper
c85146457e
Use std::next instead of incrementing .begin()
...
Hopefully that is allowed by MSVC. Let's see.
Contributes to issue CURA-1112.
2016-12-09 13:41:27 +01:00
Tim Kuipers
f1442ba7a5
fix: also add perimeter gaps between the innermost wall and infill/skin (CURA-3108)
2016-12-08 20:24:33 +01:00
Tim Kuipers
33e50f7b05
fix: also do preheating for layers with unretracted moves only (CURA-3006)
2016-12-08 19:35:59 +01:00
Tim Kuipers
865aacbfb1
fix: always prime nozzles on the first layer (CURA-3006)
2016-12-08 19:35:14 +01:00
Tim Kuipers
2bc7ee5df0
feat: prime all nozzles at the end of the first layer (CURA-3006)
2016-12-08 19:34:50 +01:00
Ghostkeeper
7777668b86
Move park distance data to ExtruderTrainAttributes
...
It was deemed to be more logical there.
Contributes to issue CURA-2795.
2016-12-08 15:35:00 +01:00
Tim Kuipers
96e8c7a73d
lil fix: forward declaration of ExtruderPlan for TimeMaterialEstimates (CURA-3006)
2016-12-08 15:30:19 +01:00
Tim Kuipers
89446b8e32
refactor: factor out GCodePath into its own header file (CURA-3006)
2016-12-08 15:27:07 +01:00
Tim Kuipers
b2fa8d3be1
refactor: factor out TimeMaterialEstimates into its own .h and .cpp files (CURA-3006)
2016-12-08 15:21:59 +01:00
Tim Kuipers
d8e0e84fcc
refactor: factor out NozzleTempInsert into its own header file (CURA-3006)
2016-12-08 15:15:30 +01:00
Tim Kuipers
443c630997
Merge branch 'feature_mesh_order'
2016-12-08 15:06:54 +01:00
Tim Kuipers
9831ef3580
lil fix: allow negative bed temperatures (CURA-2781)
2016-12-08 15:05:07 +01:00
Ghostkeeper
460c52ea6c
Use optional to denote uninitiated previous extruder temperature
...
NaN is also a very common pattern, but std::optional is more explicit.
Contributes to issue CURA-2795.
2016-12-08 14:55:15 +01:00
Tim Kuipers
3d1e79c670
lil comment (CURA-2907)
2016-12-08 11:56:21 +01:00
Ghostkeeper
879b86cab9
Also enforce z-distance from the top
...
This entails a bit slower slicing. How much slower will be determined by a performance test.
Contributes to issue CURA-2907.
2016-12-08 10:17:37 +01:00
Mark Burton
941b1ff1ac
Reinstate filament used comment for RepRap flavour gcode.
2016-12-07 14:55:54 +00:00
Ghostkeeper
4263801d16
Correct documentation of extruder_switch parameter
...
This parameter is only used for firmware-retracting printers.
Contributes to issue CURA-2795.
2016-12-07 15:44:11 +01:00
Ghostkeeper
52220ccab8
Protect writeMoveFilament
...
It should be used as a helper function only.
Contributes to issue CURA-2795.
2016-12-07 15:41:53 +01:00
Ghostkeeper
cb7b7bf22a
Use writeMoveFilament to retract to parking distance
...
This re-uses a bit of code.
Contributes to issue CURA-2795.
2016-12-07 15:40:03 +01:00
Ghostkeeper
7a8be50b8f
Pass retraction configs by reference instead of pointer
...
This makes things a bit safer. It's a const reference, so it should be very easy.
Contributes to issue CURA-2795.
2016-12-07 15:36:52 +01:00
Ghostkeeper
7c39b6b26a
Rename writeRetractionMove to writeMoveFilament
...
I think that is more indicative of what it can do, since it doesn't only concern retractions.
Contributes to issue CURA-2795.
2016-12-07 15:31:40 +01:00
Ghostkeeper
a0625aa735
Break retraction in two
...
One starting point for normal retractions and one to directly move the filament to a certain position.
Contributes to issue CURA-2795.
2016-12-07 15:29:28 +01:00
Ghostkeeper
84d3381be6
Turn extruder temperature off only if it parked the filament
...
The two had slightly different conditions if the stand-by temperature was zero.
Contributes to issue CURA-2795.
2016-12-07 12:50:49 +01:00
Ghostkeeper
8b01098dd1
Cache prime tower outside polygon
...
Saves a few polygon unions, since this is the same for each layer anyway.
Contributes to issue CURA-2684.
2016-12-07 11:54:12 +01:00
Ghostkeeper
1bfe4e74d2
Correct height of prime tower to subtract from support
...
The prime tower has one additional layer on top of the last extruder switch.
Contributes to issue CURA-2684.
2016-12-07 11:49:11 +01:00
Tim Kuipers
bcde7f50ee
Revert "fix: don't output print temperature in starting code if set to zero (CURA-3101)"
...
This reverts commit 5db20ee68d .
2016-12-06 16:39:33 +01:00
Tim Kuipers
c7cadc132b
Revert "fix: don't output print temperature in starting code if set to zero (CURA-3101)"
...
This reverts commit abfb41006b .
2016-12-06 16:39:12 +01:00
Tim Kuipers
abfb41006b
fix: don't output print temperature in starting code if set to zero (CURA-3101)
2016-12-06 16:37:35 +01:00
Tim Kuipers
5db20ee68d
fix: don't output print temperature in starting code if set to zero (CURA-3101)
2016-12-06 16:36:32 +01:00
Ghostkeeper
b0487fa4c7
Use filament park distance setting instead of direct heat & cool zones
...
The sum of the heat and cool zone lengths is now computed via inheritance in the front-end.
Contributes to issue CURA-2795.
2016-12-06 15:57:39 +01:00
Ghostkeeper
b6355b69e7
Restore park distance exception for BFB g-code
...
Turns out that BFB flavour doesn't have an e-axis, but it still doesn't count as a firmware retract.
Contributes to issue CURA-2795.
2016-12-06 14:58:26 +01:00
Tim Kuipers
9597ee5645
fix: concentric infill always acted as if alternate_extra_perimeter was enabled (CURA-2772)
2016-12-06 14:09:28 +01:00
Tim Kuipers
5ba1cb674e
fix: first walls of concentrid 3D infill didn't get added
2016-12-06 13:55:37 +01:00
Tim Kuipers
f336d5ffc0
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-12-06 13:03:19 +01:00
Tim Kuipers
1d0ac8528b
fix: only ensure unprimed extruders are primed (CURA-3006)
2016-12-06 13:02:35 +01:00
Tim Kuipers
5c06c48c87
small fix: only perform anti-overhang when there is anti-overhang (CURA-3006, CURA-2077)
2016-12-06 13:01:26 +01:00
Tim Kuipers
837d4e7fba
feat: tracking of extruder_prime_is_planned (CURA-3006)
2016-12-06 12:59:50 +01:00
Ghostkeeper
7ded01a110
Remove unused prev_extruder parameter
...
It doesn't need to know which extruder it came from. Just with which extruder to draw the lines. The new_extruder parameter was renamed because there is no need to disambiguate any more.
Contributes to issue CURA-2684.
2016-12-06 11:20:51 +01:00
Ghostkeeper
3f3b526ebd
Remove unused storage parameter
...
It doesn't need to know any settings and the documentation was outdated.
Contributes to issue CURA-2684.
2016-12-06 11:17:28 +01:00
Ghostkeeper
b29607b8a9
Remove unused gcode parameter
...
The results are stored in the gcodeLayer parameter. Has been this way for a while. This was generating compiler warnings. The documentation was already updated, it seems.
Contributes to issue CURA-2684.
2016-12-06 11:15:30 +01:00
Ghostkeeper
e641a25aab
Subtract prime tower from support after determining prime tower height
...
There is a circular dependency between prime tower height and support areas. Prime tower height is determined by the highest extruder switch. The highest extruder switch is dependent on the height of support if support is printed with a different exturder. The height of support is dependent on the support areas and the support areas are dependent on the prime tower height. Previously we resolved this by printing no support in the prime tower area and no prime tower, possibly violating the support horizontal expansion in an edge case. Now it is resolved by printing a prime tower there even if there are no extruder switches.
Contributes to issue CURA-2684.
2016-12-06 11:07:10 +01:00
Ghostkeeper
b7e9f72023
Remove unused parameter
...
One of the many. Seems to me that the documentation is outdated if an essential parameter like this one is unused.
Contributes to issue CURA-2795.
2016-12-06 09:44:18 +01:00
Ghostkeeper
ab2c2eed4b
Correct technicality in documentation
...
Contributes to issue CURA-2795.
2016-12-06 09:41:40 +01:00
Ghostkeeper
6972101d7e
Correct documentation on why the temperature is switched off later
...
This old code needs to be after the switch, but it was not clear to me why. I tried to make it clear and failed.
Contributes to issue CURA-2795.
2016-12-06 09:40:02 +01:00
Ghostkeeper
3c0d3f1b2d
Allow going to stand-by temperature if nozzle is later used
...
Contributes to issue CURA-2795.
2016-12-06 09:38:08 +01:00
Ghostkeeper
bc82fd98c9
Add additional safety check for extruder switching off in later layers
...
This is never used, but it can't hurt.
Contributes to issue CURA-2795.
2016-12-06 09:32:34 +01:00
Ghostkeeper
6c986e6cfe
Update prime speed corresponding to park retraction
...
We have some double data here, which could lead to asynchronicity. As is evident in my mistake.
Contributes to issue CURA-2795.
2016-12-06 09:30:57 +01:00
Ghostkeeper
36eb3471df
Correct retraction speed
...
Contributes to issue CURA-2795.
2016-12-06 09:24:33 +01:00
Ghostkeeper
4f3b4f429d
Expand documentation of writePark
...
It wasn't clear what retraction limit this function was not adhering to. It is not adhering to the only limit on retraction we currently have: The number of retractions.
Contributes to issue CURA-2795.
2016-12-06 09:10:34 +01:00
Ghostkeeper
837f992f69
Park filament even if printer doesn't support retraction
...
Let's hope they do support non-increasing E values.
Contributes to issue CURA-2795.
2016-12-06 09:04:07 +01:00
Tim Kuipers
ad76736d26
fix: specify starting extruder when adhesion_type==none (CURA-3006, CURA-759)
2016-12-05 17:01:21 +01:00
Tim Kuipers
3fe5a000f2
fix: set extruder back after priming in the first raft layer (CURA-3006)
2016-12-05 17:00:25 +01:00
Ghostkeeper
d5a7e2f62e
Add documentation of why this union is necessary
...
Contributes to issue CURA-3017.
2016-12-05 14:23:41 +01:00
Ghostkeeper
6e5315f754
Revert "Also union layer polygons before combing"
...
This reverts commit 4aff5a1488 .
2016-12-05 14:17:22 +01:00
Ghostkeeper
3cb3e5de45
Put filament in parking position when we never use it any more
...
It should retract before the nozzle switch, of course, so it can't be retracting at the same time as when it's setting the extruder temperature to 0.
Contributes to issue CURA-2795.
2016-12-05 12:04:12 +01:00
Ghostkeeper
80f8760f68
Fix updating current E value
...
It should be updated before we use it to write the retraction. Also we should subtract the retraction because it is the amount to retract, not the amount to prime.
Contributes to issue CURA-2795.
2016-12-05 12:02:33 +01:00
Ghostkeeper
d75882a707
Remove some annoying compile warnings
...
They are by far not all, but these remove some of the 'unused variable' warnings.
Contributes to issue CURA-2795.
2016-12-05 11:54:51 +01:00
Ghostkeeper
6925f39426
Correct speed of retraction
...
It should be in millimetres per minute, not millimetres per second. Also, always use the retraction speed.
Contributes to issue CURA-2795.
2016-12-05 11:34:59 +01:00
Tim Kuipers
d6cdfefb58
fix: use start_layers_at_same_position to see with which mesh to start a layer (CURA-1112)
2016-12-03 12:43:43 +01:00
Tim Kuipers
dfa23feb31
lil optimization vector.reserve (CURA-1112)
2016-12-03 12:26:12 +01:00
Tim Kuipers
b0888e4424
refactor: compute mesh order globally (CURA-1112)
2016-12-03 12:25:53 +01:00
Tim Kuipers
fd06e10646
fix: calculateMeshOrder now uses a smart path (CURA-1112)
...
but doesn't yet use the Z seam setting and starts at an arbitrary point in the smart cycle
2016-12-03 12:14:55 +01:00
Tim Kuipers
6e051e0bdc
refactor: let OrderOptimizer contain objects of arbitrary type rather than always pointers (CURA-1112)
2016-12-03 12:11:19 +01:00
Ghostkeeper
ae00cbe497
Add function to move filament to park position
...
If the g-code has no control over the retraction distances via G1, it performs a normal retraction instead.
Contributes to issue CURA-2795.
2016-12-02 16:58:13 +01:00
Ghostkeeper
23ef513cce
Add park distance information to retraction config
...
This is the location of the filament when the extruder is parked.
Contributes to issue CURA-2795.
2016-12-02 16:34:19 +01:00
Tim Kuipers
3aa29d898f
feat: orderOptimizer (CURA-1112)
2016-12-02 15:22:31 +01:00
Ghostkeeper
c9217d4738
Re-use extruder train variable
...
I moved the definition of the 'train' variable a bit earlier so it can be re-used a bit more often.
Contributes to issue CURA-2795.
2016-12-02 15:05:51 +01:00
Ghostkeeper
16d4ab923f
Make support attach directly to prime tower
...
No X/Y offset is happening. This makes both support and prime tower sturdier, and prevents having to do an offset of the prime tower so it would make the support a bit faster in theory (but the difference is not noticable).
Contributes to issue CURA-2684.
2016-12-02 12:39:05 +01:00
Ghostkeeper
60d4a3108d
Don't print support inside hollow prime towers
...
It only takes the outside of the prime tower ground polygon.
Contributes to issue CURA-2684.
2016-12-02 12:34:59 +01:00
Tim Kuipers
7ad5eee176
indent change only (CURA-1112)
2016-12-02 11:58:38 +01:00
Tim Kuipers
209e9fa50f
refactor: separate out FffGcodeWriter::addMeshPartToGCode (CURA-1112)
2016-12-02 11:58:11 +01:00
Ghostkeeper
4aff5a1488
Also union layer polygons before combing
...
If two polygons overlap, clipperlib can interpret them as one being the inside polygon with the even odd rule. If they overlap exactly, it produces no output. However if you union the polygons it will properly avoid all objects regardless of whether they overlap with other objects.
Contributes to issue CURA-3017.
2016-12-02 11:21:16 +01:00
Ghostkeeper
4f786d5533
Subtract prime tower area from support
...
At this point we don't know for certain if there will be a prime tower, but that is impossible since there is a circular dependency between prime tower and support then.
Contributes to issue CURA-2684.
2016-12-01 13:10:49 +01:00
Ghostkeeper
b4fd72f92f
Re-use layer outlines variable
...
We already had it stored in a variable and the polygons don't change in between, so we can safely re-use this.
Contributes to issue CURA-2684.
2016-12-01 13:10:49 +01:00
Ghostkeeper
df892030c5
Only include prime tower if it is enabled
...
We always generate a ground polygon now, so we can't rely on the ground polygon being empty if it is disabled due to there being no layer switches.
Contributes to issue CURA-2684.
2016-12-01 13:10:49 +01:00
Tim Kuipers
e31a516205
fix: ooze/draft shield now processed again (CURA-3077)
2016-12-01 11:57:13 +01:00
Ghostkeeper
c77afe06e2
Generate prime tower polygon at construction
...
This way we can always request the prime tower ground polygon throughout the entire process. The polygon will be empty if prime tower is disabled.
Contributes to issue CURA-2684.
2016-11-30 17:41:41 +01:00
Ghostkeeper
921ffbe659
Merge branch 'feature_z_seam_location'
2016-11-30 16:34:31 +01:00
Ghostkeeper
96ac0758b9
Don't use sqrt in a constexpr
...
sqrt doesn't return a constexpr. GCC allows it, but Clang doesn't. Instead we just use a preprocessor definition.
Contributes to issue CURA-2602.
2016-11-30 10:44:19 +01:00
Ghostkeeper
dd8639b1f5
Use std::abs instead of abs
...
The clang compiler doesn't define abs outside of the std library.
2016-11-30 10:27:30 +01:00
Ghostkeeper
2572349938
Remove debug prints
...
These should never have been committed.
Contributes to issue CURA-3017.
2016-11-30 10:09:09 +01:00
Tim Kuipers
ac9a053f5b
Revert "lil fix: don't compute overhang on first layer"
...
This reverts commit bec51eb0bd .
2016-11-29 17:19:15 +01:00
Tim Kuipers
bec51eb0bd
lil fix: don't compute overhang on first layer
2016-11-29 17:17:35 +01:00
Jaime van Kessel
12ccb3512f
Merge branch 'feature_recursive_infill_code_review' of github.com:Ultimaker/CuraEngine
2016-11-29 15:42:02 +01:00
Tim Kuipers
87a3a30bc5
fix: open polylines bug
...
turned back a mistake which was made in a refactor: fa203bd976
2016-11-29 14:32:01 +01:00
Tim Kuipers
6ae41a5e86
fix: max feedrate is in mm/s in both frontend and firmware (CURA-2955)
...
I've verified that M203 Sxx is interpreted as mm/s in Marlin, Sprinter and Repetier-Firmware.
Other firmware types we support, like MakerBot, BFB and MACH weren't checked.
2016-11-29 13:15:22 +01:00
Ghostkeeper
8ce016064f
Fix typo in documentation
...
The variable name is _dest_point, it seems.
Contributes to issue CURA-2229.
2016-11-28 17:05:51 +01:00
Ghostkeeper
4e16b4313f
Fix typo in assert message
...
Contributes to issue CURA-3008.
2016-11-28 16:55:24 +01:00
Ghostkeeper
5b493c17dc
Union first layer polygons for brim too
...
For skirt it does this union by taking the convex hull. For brim it did no such thing, so when polygons overlapped it would get complex polygons which didn't work out well.
Contributes to issue CURA-3017.
2016-11-28 16:37:28 +01:00
Tim Kuipers
4b45726ada
Revert "feat: PolygonPointer as distinct from PolygonRef (CURA-2602)"
...
This reverts commit a2a8604c72 .
2016-11-28 14:42:18 +01:00
Tim Kuipers
6653f5a557
Merge branch 'master' into feature_recursive_infill_code_review
2016-11-28 14:39:53 +01:00
Tim Kuipers
4da8c6d8e7
fix: no more aabb hit check fails (CURA-2992)
2016-11-28 14:35:13 +01:00
Tim Kuipers
c5ce425924
fix: no more use of deleted memory by optional (CURA-3008)
2016-11-28 14:34:45 +01:00
Tim Kuipers
c74d4f7550
Revert "feat: PolygonPointer as distinct from PolygonRef (CURA-3008)"
...
This reverts commit 20cd4275fc .
2016-11-28 13:43:03 +01:00
Tim Kuipers
19f093e0cc
safety: assert on optional::instance (CURA-3008)
2016-11-28 13:42:36 +01:00
Tim Kuipers
2a4cca0402
fix: use ClosestPolygonPoint::isValid where neccesary (CURA-3008)
2016-11-28 13:40:54 +01:00
Tim Kuipers
32804c102c
fix: use optional<PolygonRef> instead of PolygonPointer (CURA-3008)
2016-11-28 13:40:02 +01:00
Tim Kuipers
776f56fc37
lil fix: no more un/signed int comaprison
2016-11-28 12:18:13 +01:00
Tim Kuipers
866e911739
fix: make z_seam_pos settable per mesh (CURA-1461)
2016-11-25 16:43:31 +01:00
Tim Kuipers
a92cd23e62
safety: extra assert for too many nozzle switches in a layer
2016-11-25 16:10:10 +01:00
Tim Kuipers
4725001564
fix: remove printing_temperature_command if precooling goes further back (CURA-1932)
...
If the precooling command will precede the printing temeprature command to heat to the temp of the next layer, then don't use that temp;
we should already be cooling down, rather than heating toward the temp of the next layer.
2016-11-25 14:00:26 +01:00
Tim Kuipers
a18595877f
safety: extra assert on temp in NozzleTempInsert (CURA-1932)
2016-11-25 14:00:26 +01:00
Tim Kuipers
40e7c450d5
fix: getCoolDownPointAfterWarmUp outer_temp was switched (CURA-1932)
...
This caused the timing of the precool command to be off
2016-11-25 14:00:26 +01:00
Tim Kuipers
13a0b11d68
fix: don't use material_print_temperature_layer_0 if it's zero (CURA-1932)
2016-11-25 14:00:26 +01:00
Ghostkeeper
4fc69f608a
Fix max extruder height if only using bed adhesion
...
If an extruder only prints bed adhesion, the maximum extruder height for that extruder is now correct.
Contributes to issue CURA-2993.
2016-11-25 11:21:59 +01:00
Ghostkeeper
deb577d559
Make extruder numbers const and unsigned
...
This is in line with the first one, and more correct.
Contributes to issue CURA-2993.
2016-11-25 11:17:45 +01:00
Ghostkeeper
c8161da3eb
Remove spaces within brackets
...
As per our code style.
Contributes to issue CURA-2993.
2016-11-25 11:16:30 +01:00
Ghostkeeper
87733834d1
Expand documentation for computePrintHeightStatistics
...
Should make it more overseeable.
Contributes to issue CURA-2993.
2016-11-25 11:08:29 +01:00
Ghostkeeper
b9aeea425f
Correct documentation of computePrintHeightStatistics
...
It's initialised, not uninitialised (or unitialised).
Contributes to issue CURA-2993.
2016-11-25 11:01:51 +01:00
Tim Kuipers
44b3039db6
optimization: use already computed ClosestPolygonPoint for ensureInsideOrOutside during combing crossing calculation (CURA-2229)
2016-11-24 15:09:41 +01:00
Tim Kuipers
6476270cf6
fix: combing start crossing inside location was sometimes on the destination part, rather than the starting part (CURA-2229)
2016-11-24 13:56:57 +01:00
Ghostkeeper
e532f3ddda
Merge branch 'feature_anti_support'
2016-11-22 16:36:52 +01:00
Tim Kuipers
7aaab151e7
fix: better handling of edge cases for Preheat::getCoolDownPointAfterWarmUp and getWarmUpPointAfterCoolDown (CURA-3006)
2016-11-22 14:54:59 +01:00
Tim Kuipers
0353433919
fix: also ensure prime after first layer of raft (CURA-3006)
2016-11-22 14:52:21 +01:00
Tim Kuipers
40a6c495c7
refactor: move code from FffGcodeWriter::processLayer into new FffGcodeWriter::ensureAllExtrudersArePrimed (CURA-3006)
2016-11-22 14:51:48 +01:00
Ghostkeeper
cfa6758911
Merge branch 'fix_support_order'
...
Conflicts:
src/FffGcodeWriter.cpp
src/PrimeTower.cpp
2016-11-22 13:03:38 +01:00
Tim Kuipers
f6b29b1d8a
Merge branch 'feature_anti_support' of github.com:Ultimaker/CuraEngine into feature_anti_support
2016-11-22 10:21:44 +01:00
Ghostkeeper
bd79a8468e
Merge branch 'feature_hollow_prime_tower'
2016-11-22 09:19:16 +01:00
Tim Kuipers
83a1a09772
fix: merge fix for PathOrderOptimizer in FffGcodeWriter::processSkin (CURA-1461)
2016-11-21 18:48:10 +01:00
Tim Kuipers
2c425421ec
Merge branch 'master' into feature_z_seam_location
2016-11-21 18:45:10 +01:00
Ghostkeeper
35dcc6906f
Merge branch 'feature_precool'
2016-11-21 17:35:40 +01:00
Tim Kuipers
db7bc279ee
fix: removeEmptyFirstLayers can still remove even when support was generated (but removed by anti support meshes (CURA-2077)
2016-11-21 16:50:26 +01:00
Tim Kuipers
a7ea623266
fix: removeEmptyFirstLayers can still remove even when support was generated (but removed by anti support meshes (CURA-2077)
2016-11-21 16:34:55 +01:00
Tim Kuipers
724589c13a
fix: support towers went all the way to the bed (CURA-2077)
2016-11-21 16:31:52 +01:00
Tim Kuipers
db1fa098ad
Merge branch 'master' into feature_anti_support
2016-11-21 16:12:57 +01:00
Tim Kuipers
be99db30c0
fix: combing referenced element zero of a polygons (CURA-3008)
2016-11-21 15:54:07 +01:00
Tim Kuipers
9456592dd7
fix: use PolygonPointer in ClosestPolygonPoint (CURA-3008)
...
sometimes functions cannot return a ClosestPolygonPoint, or we start with an empty one untill we find any point
cherry-picked from 4634338c7d
2016-11-21 15:45:27 +01:00
Tim Kuipers
20cd4275fc
feat: PolygonPointer as distinct from PolygonRef (CURA-3008)
...
It was a bad idea to change PolygonRef into PolygonPointer, because then we'd have to check whether it is a nullptr all over the engine...
cherry-picked from a2a8604c72
2016-11-21 15:38:12 +01:00
Tim Kuipers
67697d5258
fix: handle modulo operations for negative layer numbers (CURA-2789)
2016-11-21 14:18:39 +01:00
Tim Kuipers
7d8e4de7ba
fix: prime tower didn't get added in filler layers (CURA-2789)
...
PrimeTower always received layer_nr=0 for those layers, so i had to propagate the negative layer numbers to addSupportToGcode and to PrimeTower
2016-11-21 14:17:32 +01:00
Tim Kuipers
2486120a38
fix: don't send polygons over command socket during planning phase (CURA-2789)
...
The polygons of the prime tower were also sent on the wrong layer / height, causing it to be visualized within raft layers
2016-11-21 14:13:56 +01:00
Tim Kuipers
43c8f2a913
fix: print prime tower directly after platform adhesion on layer 0 (CURA-2789)
2016-11-21 13:19:25 +01:00
Tim Kuipers
baf6410a1e
fix: PolygonUtils::findClosest failed when only the first polygon was empty (CURA-2602)
2016-11-18 16:33:28 +01:00
Tim Kuipers
4634338c7d
fix: use PolygonPointer in ClosestPolygonPoint (CURA-2602)
...
sometimes functions cannot return a ClosestPolygonPoint, or we start with an empty one untill we find any point
2016-11-18 16:32:56 +01:00
Tim Kuipers
a2a8604c72
feat: PolygonPointer as distinct from PolygonRef (CURA-2602)
...
It was a bad idea to change PolygonRef into PolygonPointer, because then we'd have to check whether it is a nullptr all over the engine...
2016-11-18 16:30:34 +01:00
Ghostkeeper
dd8b57b666
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-11-18 15:51:10 +01:00
Jaime van Kessel
72ed492a61
Merge branch 'feature_alternate_carving' of github.com:Ultimaker/CuraEngine
2016-11-18 15:14:12 +01:00
Ghostkeeper
c02482590f
Merge branch 'feature_fill_small_gaps'
2016-11-18 15:05:58 +01:00
Tim Kuipers
f32e2d9554
Merge branch 'master' into feature_anti_support
2016-11-18 14:07:29 +01:00
Tim Kuipers
40a6075022
Merge branch 'master' into feature_recursive_infill_code_review
2016-11-18 13:55:06 +01:00
Jaime van Kessel
bf61814849
Merge branch 'feature_fan_speed_0' of github.com:Ultimaker/CuraEngine
2016-11-18 10:43:56 +01:00
Jaime van Kessel
5741e79ade
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-11-18 10:42:17 +01:00
Jaime van Kessel
09419fd6be
Merge branch 'feature_bed_adhesion_none' of github.com:Ultimaker/CuraEngine
2016-11-18 10:35:29 +01:00
Tim Kuipers
a002f4b3b2
feat: alternate_carve_order (CURA-2992)
2016-11-17 19:58:31 +01:00
Tim Kuipers
25c7ccb0d3
fix: outside combing put starting and ending points of basic comb path on the wrong side (CURA-2988)
...
basic comb paths started on the wrong side, then followed the polygon on the right side and ended on the wrong side again
2016-11-17 17:22:53 +01:00
Tim Kuipers
58a99a403b
fix: createLocToLineGrid didn't create any cells and copied the hashmap (CURA-2988)
...
std::bind doesn't allow for binding by reference
2016-11-17 17:01:57 +01:00
Tim Kuipers
dd8594b200
fix: inside combing put starting and ending points of basic comb path on the wrong side (CURA-2988)
...
basic comb paths started on the wrong side, then followed the polygon on the right side and ended on the wrong side again
2016-11-17 17:00:23 +01:00
Ghostkeeper
6df5368cb9
Update variable names in documentation
...
The variable names were changed but changed incorrectly here.
Contributes to issue CURA-1932.
2016-11-17 14:49:29 +01:00
Ghostkeeper
3a038a2cd2
Put correct bounding box in g-code header
...
This is according to the Griffin header specification.
Contributes to issue CURA-2625.
2016-11-17 13:35:59 +01:00
Tim Kuipers
9613e186a3
docs: fixed docs location and included precool diagram in LayerPlanBuffer (CURA-1932)
2016-11-16 17:54:11 +01:00
Tim Kuipers
82b2362b2d
lil compiler warning removal (CURA-1932)
2016-11-16 16:52:54 +01:00
Tim Kuipers
a6ee34602c
refactor: rename rediculous timeBeforeEndToInsertPreheatCommand_coolDownWarmUp ==> sensible getWarmUpPointAfterCoolDown and vice versa (CURA-1932)
2016-11-16 16:50:05 +01:00
Tim Kuipers
05d29eabcd
refactor: timeBeforeEndToInsertPreheatCommand arguments better names (CURA-1932)
2016-11-16 16:41:18 +01:00
Tim Kuipers
f7e3534a79
fix: update outdated function signature (add const and better naming) (CURA-1932)
2016-11-16 16:30:56 +01:00
Tim Kuipers
bd4972e466
refactor: rename function argument to better match the intent (CURA-1932)
2016-11-16 16:27:44 +01:00
Tim Kuipers
0acf3beec2
fix: insertFinalPrintTempCommand: compute weighted average_print_temp by taking time into account (CURA-1932)
...
note that the print temp statistic doesn't really matter that much
2016-11-16 16:20:51 +01:00
Tim Kuipers
081055be46
fix: better documentation for LayerPlanBuffer::insertFinalPrintTempCommand (CURA-1932)
2016-11-16 16:17:42 +01:00
Tim Kuipers
c57ab7d090
fix: getSettingInMicrons should return coord_t, rather than int! (CURA-2602)
2016-11-16 15:25:12 +01:00
Tim Kuipers
bd5a82dd86
refactor: split up SubDivCube::generateSubdivisionLines into two functions (CURA-2602)
...
one public base class function, one private recursive function.
Instead of using a heap-allocated array of pointers to Polygons, just use a stack-allocated array of Polygons
2016-11-16 15:14:16 +01:00
Tim Kuipers
942d409d72
lil refactor: moved constant expression inside function where it's used (CURA-2602)
2016-11-16 14:56:48 +01:00
Tim Kuipers
a17d3017b5
lil simplification and reduction of rounding errors (CURA-2602)
2016-11-16 14:35:35 +01:00
Tim Kuipers
b79f605ce2
fix: made Polygons::remove be O(1) (CURA-2602)
...
The order of polygons is never important, except in PolygonsPart where the first polygon is the outer one, but there it should be impossible to remove the first element anyway.
2016-11-16 14:22:45 +01:00
Tim Kuipers
ea1c9b80e9
refactor: make private function of SubDivCube::addLineAndCombine (CURA-2602)
2016-11-16 14:21:10 +01:00
Tim Kuipers
1d86f54a8b
lil refactor
2016-11-16 13:59:14 +01:00
Tim Kuipers
fc909ff3ad
fix: subdivcube: max_side_length based on machine dimensions (CURA-2602)
2016-11-16 13:56:41 +01:00
Tim Kuipers
7f54037246
refactor: merged cube properties into one vector of ew struct (CURA-2602)
2016-11-16 13:36:08 +01:00
Tim Kuipers
ec7164004e
refactor: factored addLine into Polygons class (CURA-2602)
2016-11-16 13:22:28 +01:00
Tim Kuipers
a6314a9f80
lil improvements (CURA-2602)
2016-11-16 12:57:09 +01:00
Ghostkeeper
560d23d3f2
Simplify skipping current extruder in calculateExtruderOrder
...
These are equivalent, but the code is now simpler.
Contributes to issue CURA-2789.
2016-11-16 12:51:50 +01:00
Tim Kuipers
1207291950
rename: src/infill/subDivCube.cpp ==> src/infill/SubDivCube.cpp (CURA-2602)
2016-11-16 12:47:47 +01:00
Tim Kuipers
44e7b0e0be
fix: apply outer wall line width offset for interperimeter gaps (CURA-2306)
2016-11-16 10:18:40 +01:00
Tim Kuipers
8c48d1ce82
fix: material_extrusion_cool_down_speed handled correctly (CURA-1932)
...
it was handled as if the inverse (in s/*c) was the modifier rather than the original (in *C/s)
2016-11-15 17:53:38 +01:00
Tim Kuipers
8432e9ed9f
fix: first start of extruder, require print temp rather than initial print temp (CURA-1932)
2016-11-15 17:52:07 +01:00
Tim Kuipers
1b014199c9
refactor: store initial_printing_temperature in ExtruderPlan (CURA-1932)
2016-11-15 17:46:47 +01:00
Tim Kuipers
7e0c5c6323
refactor: replaced timeBeforeEndToInsertPreheatCommand_warmUp by getTimeToGoFromTempToTemp (CURA-1932)
...
both functions actually tried to do the same thing
2016-11-15 17:42:37 +01:00
Tim Kuipers
9ada0901a6
refactor: insertPreheatCommands ==> insertTempCommands (CURA-1932)
2016-11-15 17:38:26 +01:00
Tim Kuipers
d60d32a5d8
fix: exposed less internal functions of LayerPlanBuffer (CURA-1932)
2016-11-15 14:38:15 +01:00
Tim Kuipers
667c00aa5a
lil assert (CURA-1932)
2016-11-15 14:37:32 +01:00
Tim Kuipers
cf0ca05843
fix: insert initial/final print temp commands for groups of extruder plans rather than each (CURA-1932)
...
before this we would get precool and preheat during a layer change even when the last extruder of the previous layer is the first extruder of the next...
2016-11-15 14:37:07 +01:00
Tim Kuipers
3bcabacef4
fix: wrong check whether initial print temp was unused (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
b5801ea847
fix: warmUpCoolDown computed cool_down_time as if it was warm_up_time (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
1bb90a2f03
fix: use more accurate coolDownWarmUp time estimations (CURA-1932)
...
with the initial and final printing temperature the old assumption didn't hold any more:
'Assumes from_temp is approximately the same as @p temp'
It uses the same logic as timeBeforeEndToInsertPreheatCommand_warmUpCoolDown(.)
2016-11-14 17:50:08 +01:00
Tim Kuipers
cf55aef52b
fix: for warmUpCoolDown compute max temp accurately (CURA-1932)
...
Didn't take extra heating time into account
2016-11-14 17:50:08 +01:00
Tim Kuipers
c0f7538fdb
fix: take care of during_printing for heatup/cooldown timings (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
395ab9b7cd
fix: warmup and cooldown times were incorrect (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
80ecabb618
refactor: move Preheat functions to cpp file (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
ff291cc4d1
fix: insert temp commands for preheat and precool (CURA-1932)
...
insert heat command from initial_print_temp to print_temp at the first extrusion in a layer plan
insert cool command from print_temp to final_print_temp during the last extrusion moves in a layer plan
2016-11-14 17:50:08 +01:00
Tim Kuipers
4183835d2b
fix: use initial_print_temp where print_temp used to be used (CURA-1932)
...
heating up is now done toward initial_print_temp
and the required temp at the start of a layer is initial_print_temp
2016-11-14 17:50:08 +01:00
Tim Kuipers
0e24d8db47
cleanup: no more boolean trappiness (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
f7bde54869
feat: some handy Preheat functions (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
bf8f027a97
setting: material_initial_print_temperature, material_final_print_temperature (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
60625ea4bf
refactor: ExtruderPlan::required_temp ==> printing_temperature (CURA-1932)
2016-11-14 17:50:08 +01:00
Tim Kuipers
a9f6ae1943
refactor: rewrote logic in FffGcodeWriter::calculateExtruderOrder (CURA-2789)
2016-11-14 17:49:16 +01:00
Tim Kuipers
cd01d7051b
refactor: support_skin ==> support_interface (CURA-2789)
2016-11-14 17:49:16 +01:00
Ghostkeeper
bd126bb841
Fix typo in assert message
...
Contributes to issue CURA-2789.
2016-11-14 17:49:16 +01:00
Tim Kuipers
f1b3fb3cd6
refactor/fix: plan extruders independently of meshes and plan support per extruder plan (CURA-2789)
...
When printing dual color models with dual support (different support infill extruder than support skin extruder)
all support would either be printed before all models or after, leading to two extruder switches in one layer.
Now the extruder_order is calculated independently of the mesh_order and the support is added per extruder plan.
The support is always added first, so that:
- in single extrusion we never print in order support-support-model-model which would lead to model being printed on top of model which hasn't cooled enough
- in dual color, dual support we always print E1-support-model-support-model-E2-support-model-support-model so that oozle is automatically wiped on support
2016-11-14 17:49:16 +01:00
Tim Kuipers
d48f06db0e
refactor/fix: return whether support was added to extruder plan and only switch extruder if plans were added (CURA-2789)
2016-11-14 17:49:16 +01:00
Tim Kuipers
5567b06ed4
cleanup: remove unused parameter to FffGcodeWriter::addSupportToGCode (CURA-2789)
2016-11-14 17:49:16 +01:00
Tim Kuipers
e87b11179f
fix: getExtrudersUsed only include platform adhesion for first layer(s) (CURA-2789)
2016-11-14 17:49:16 +01:00
Tim Kuipers
a17fef9d4b
refactor: separate handleSupportBeforeModels out of FffGcodeWriter::addSupportToGCode (CURA-2789)
2016-11-14 17:49:16 +01:00
Tim Kuipers
4c49bf7894
cleanup: const-correctness for SliceDataStorage::getExtrudersUsed (CURA-2789)
2016-11-14 17:49:16 +01:00
Tim Kuipers
bcb0ded784
fix: print support consecutive instead of always at end of layer (CURA-2789)
...
also support_interface_extruder_nr mattered even if the interface was turned off
2016-11-14 17:49:16 +01:00
jack
54ba25e7f5
Merge pull request #411 from Ultimaker/bugfix_prime_tower_too_high
...
CURA-2633 fix: limit prime tower height when support is touching buildplate onl…
2016-11-14 14:57:13 +01:00
Tim Kuipers
84a7f401a2
lil indent fix only (CURA-759)
2016-11-14 12:41:58 +01:00
Tim Kuipers
6afdf19ce4
feat: adhesion_type none (CURA-759)
2016-11-14 12:41:29 +01:00
Tim Kuipers
4aa1cc47f4
fix: don't start output decimal numbers with the decimal dot
2016-11-11 17:23:53 +01:00
Tim Kuipers
166473596a
fix: compute perimeter_gaps for zigzag skin infill (CURA-2306)
2016-11-11 16:00:35 +01:00
Tim Kuipers
feb21b67d1
fix: turn off gap filling if fill_perimeter_gaps is set to nowhere (CURA-2306)
2016-11-11 14:58:59 +01:00
Tim Kuipers
dae7ec184f
removal: remove skin option from fill_perimeter_gaps mode (CURA-2306)
2016-11-11 14:44:48 +01:00
Tim Kuipers
cd170cae99
Revert "cleanup: removed fill_perimeter_gaps setting (CURA-996)"
...
This reverts commit 9c47644e55 .
This reintroduces the fill_perimeter_gaps setting (CURA-2306)
2016-11-11 14:41:33 +01:00
Tim Kuipers
d47d0a2e46
fix: handle perimeter_gaps for concentric skin infill (CURA-2306)
2016-11-11 14:37:51 +01:00
Tim Kuipers
f0d59db203
refactor: optionally pass down perimeter_gaps to Infill constructor (CURA-2306)
2016-11-11 14:37:14 +01:00
Tim Kuipers
f34a4e566b
feat: handle perimeter_gaps between skin walls (CURA-2306)
2016-11-11 14:35:43 +01:00
Tim Kuipers
9c1ef177d1
feat: perimeter gaps for normal walls (CURA-2306)
2016-11-11 14:33:45 +01:00
Tim Kuipers
e1c7e86b66
fix: optimize skin part order (CURA-2306)
2016-11-11 14:29:32 +01:00
Tim Kuipers
384071aaeb
feat: z seam position (CURA-1461)
2016-11-11 12:02:46 +01:00
Tim Kuipers
79d1074d47
feat: cool_fan_speed_0 (CURA-2182)
2016-11-10 16:41:42 +01:00
Tim Kuipers
348ca93dcb
fix: add more special casing to ignore (anti)support meshes (CURA-2077)
2016-11-09 17:27:59 +01:00
Tim Kuipers
e70b3c099f
Merge branch 'fix_support_order' of github.com:Ultimaker/CuraEngine into fix_support_order
2016-11-09 16:40:50 +01:00
Tim Kuipers
8c9858a14c
refactor: rewrote logic in FffGcodeWriter::calculateExtruderOrder (CURA-2789)
2016-11-09 16:38:14 +01:00
Tim Kuipers
6e56cb3416
refactor: support_skin ==> support_interface (CURA-2789)
2016-11-09 16:31:43 +01:00
Ghostkeeper
8761ae1e53
Merge branch 'feature_retract_at_layer_change'
2016-11-09 13:37:48 +01:00
Ghostkeeper
d32be27b50
Fix typo in assert message
...
Contributes to issue CURA-2789.
2016-11-09 11:58:48 +01:00
Tim Kuipers
11b33215a2
fix: set extruder count (CURA-2325)
2016-11-09 10:24:31 +01:00
Tim Kuipers
e8a31f1380
fix: remove GCodePlanner::makeLastPathZhopped (CURA-2325)
2016-11-09 10:24:31 +01:00
Ghostkeeper
7cbfb22f1f
)
...
'I have to sort my books' she cried,
With self-indulgent glee;
With senseless, narcissistic pride:
'I'm just so OCD.'
'How random guys,' I smiled and said,
Then left without a peep -
And washed my hands until they bled,
And cried myself to sleep.
2016-11-09 10:24:24 +01:00
Tim Kuipers
40e6aac22b
fix: only wipe in the middle of the prime tower if it's hollow (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
33cc601a1b
fix: only wipe on inside of prime tower if z hops are already being performed (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
d50b0c9c2f
fix: go down on middle of hollow wipe tower (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
77f415be61
fix: made hollow prime tower robust against zero wall thickness (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
1aa784e521
doc update prime tower (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
ef8258da2f
fix: make move to prime location z-hopped (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
79692200b0
fix: make move toward hollow prime tower always z hopped (CURA-2325)
2016-11-09 10:24:24 +01:00
Tim Kuipers
966912ccc5
fix: more prime positions cause inside of hollow prime tower is quite big (CURA-2325)
2016-11-09 10:19:15 +01:00
Tim Kuipers
1513dcad5c
fix: add brim on inside of hollow prime tower (CURA-2325)
...
even when we have selected to generate brim only for outside polygons
2016-11-09 10:19:15 +01:00
Tim Kuipers
41050ac835
fix: wipe on middle of prime tower (CURA-2325)
2016-11-09 10:19:15 +01:00
Tim Kuipers
fb8625756f
fix: return *this for operator= (CURA-2325)
2016-11-09 10:19:15 +01:00
Tim Kuipers
886bab29f7
refactor: cache prime tower walls as well as infill (CURA-2325)
2016-11-09 10:19:15 +01:00
Tim Kuipers
5bdf538d35
lil cleanup prime tower (CURA-2325)
2016-11-09 10:19:14 +01:00
Tim Kuipers
7d5040e283
feat: hollow prime tower (CURA-2325)
2016-11-09 10:19:14 +01:00
Tim Kuipers
a49ed9a90e
cleanup: removed unused var in PrimeTower (CURA-2325)
2016-11-09 10:19:14 +01:00
Tim Kuipers
7a4e732f3b
refactor: pass along new_extruder to wipe tower generator functions (CURA-2325)
2016-11-09 10:19:14 +01:00
Tim Kuipers
653ce82255
fix: make wipe settings settable per extruder (CURA-2325)
2016-11-09 10:19:14 +01:00
Tim Kuipers
0b1df81945
feat: separate setting for pre-wipe (CURA-2325)
2016-11-09 10:19:14 +01:00
Tim Kuipers
f65993c5b6
fix: put prime_tower_wipe_enabled back to old functionality (CURA-2325)
2016-11-09 10:19:14 +01:00
Ghostkeeper
df91b3d8aa
Merge branch 'feature_extruder_temp_layer_0'
2016-11-08 14:46:45 +01:00
Tim Kuipers
4b58ab0ad9
refactor/fix: plan extruders independently of meshes and plan support per extruder plan (CURA-2789)
...
When printing dual color models with dual support (different support infill extruder than support skin extruder)
all support would either be printed before all models or after, leading to two extruder switches in one layer.
Now the extruder_order is calculated independently of the mesh_order and the support is added per extruder plan.
The support is always added first, so that:
- in single extrusion we never print in order support-support-model-model which would lead to model being printed on top of model which hasn't cooled enough
- in dual color, dual support we always print E1-support-model-support-model-E2-support-model-support-model so that oozle is automatically wiped on support
2016-11-08 11:36:28 +01:00
Tim Kuipers
9cbdfd2152
refactor/fix: return whether support was added to extruder plan and only switch extruder if plans were added (CURA-2789)
2016-11-08 11:30:16 +01:00
Tim Kuipers
4a0a0088fe
cleanup: remove unused parameter to FffGcodeWriter::addSupportToGCode (CURA-2789)
2016-11-07 17:49:35 +01:00
Ghostkeeper
dc37384ffd
Merge branch 'bugfix_support_retractions'
2016-11-07 15:40:08 +01:00
Tim Kuipers
2a21e6c348
fix: don't write temperature gcode commands for the UM2 family (CURA-2781, CURA-2736)
...
they are fixed by the firmware
2016-11-07 15:16:43 +01:00
Tim Kuipers
30011a5285
fix: insert preheat commands even in single extruder mode (CURA-2736)
2016-11-07 13:56:22 +01:00
Tim Kuipers
965b28e009
fix: compiler warnings for unsigned layer_nr and extruder_nr (CURA-2736)
2016-11-07 13:55:22 +01:00
Tim Kuipers
1b37007003
feat: initial layer extruder temp (CURA-2736)
2016-11-07 13:48:48 +01:00
Tim Kuipers
5cf0bcd399
feat: add is_initial_layer to layerplan and extruderplan (CURA-2736)
2016-11-07 13:48:48 +01:00
Tim Kuipers
0930d61dad
feat: material_bed_temperature_layer_0 (CURA-2781)
...
set bed temeprature to normal at first layer
set bed temp to initial layer bed temp the first layer of each next meshgroup (one-at-a-time mode)
wait for initial bed temp to be reached
don't wait for second layer bed temp
2016-11-07 13:48:48 +01:00
Tim Kuipers
a181977ce9
refactor: moved command line settings to fdmprinter.def.json (CURA-566)
...
also fixed some problems:
- type of one setting was string rather than str
- there were some old unused settings in there (prime_tower_outward_dir, machine_prinbt_temp_wait)
2016-11-07 11:59:13 +01:00
Ghostkeeper
3ab19f2f29
Merge branch 'feature_wall_wipe'
2016-11-07 11:37:18 +01:00
mboerwinkle
4b6f672e56
Merge pull request #2 from Ultimaker/feature_recursive_infill_BagelOrb
...
Some small optimizations and cleanup
2016-11-06 18:23:13 -06:00
Ghostkeeper
c4a3830838
Merge branch 'bugfix_support_brim_round'
2016-11-04 15:23:47 +01:00
Jaime van Kessel
d546c27462
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-11-04 14:59:57 +01:00
Jaime van Kessel
7664e81aa2
Merge branch 'feature_concentric_3d_infill' of github.com:Ultimaker/CuraEngine
2016-11-04 14:54:07 +01:00
Tim Kuipers
aa2ce7c770
refactor: retrieve print_layer_count from SliceDataStore rather than passing it to all functions (CURA-2077)
2016-11-04 14:23:27 +01:00
Tim Kuipers
f63fc1ed74
fix: compute layer_count once and for all (CURA-2077)
2016-11-04 14:18:47 +01:00
Tim Kuipers
ac183f4e4b
refactor: don't pass down total_layers, but use mesh.layers.size instead (CURA-2077)
2016-11-04 13:15:03 +01:00
Tim Kuipers
4f3c337cc7
fix: resize layers vector in all meshes beforehand (CURA-2077)
...
A lot of (outdated) code depends on there being the same amount of layers in each mesh.
This was not the case for anti-overhang meshes and support meshes
Now each mesh starts out with the same amount of empty layers
2016-11-04 13:14:23 +01:00
Ghostkeeper
1e24769061
Merge branch 'feature_start_layer_far_away'
2016-11-04 11:36:48 +01:00
Tim Kuipers
02134eb822
fix: don't retract while performing the outer wall wipe (CURA-1698)
2016-11-03 20:18:45 +01:00
Tim Kuipers
b436da841a
fix2: don't access protected member from within lambda function (CURA-2704)
2016-11-03 14:45:58 +01:00
Tim Kuipers
fa95e56b76
fix: don't access protected member from within lambda function (CURA-2704)
2016-11-03 14:13:52 +01:00
Ghostkeeper
6bed19c295
Merge branch 'feature_infill_support'
2016-11-03 13:37:07 +01:00
Tim Kuipers
2a20853b92
fix: getExtrudersUsed only include platform adhesion for first layer(s) (CURA-2789)
2016-11-02 17:50:30 +01:00
Tim Kuipers
09ad6301e7
refactor: separate handleSupportBeforeModels out of FffGcodeWriter::addSupportToGCode (CURA-2789)
2016-11-02 16:55:34 +01:00
Tim Kuipers
d8fa29e979
cleanup: const-correctness for SliceDataStorage::getExtrudersUsed (CURA-2789)
2016-11-02 16:54:50 +01:00
Tim Kuipers
ab91cc2def
lil refactor: p0 ==> b_from_transformed (CURA-2704)
...
to conform to the other parameters such as a_from_transformed
2016-11-02 16:39:31 +01:00
Tim Kuipers
cd4e2e29a3
lil refactor: transformed_startPoint ==> transformed_from (CURA-2704)
2016-11-02 16:37:12 +01:00
Tim Kuipers
0f454e897b
refactor: polygonCollidesWithlineSegment ==> polygonCollidesWithLineSegment (l==>L) (CURA-2704)
2016-11-02 16:35:33 +01:00
Tim Kuipers
c1d53811f3
lil (no unneccesary type cast (CURA-2077)
2016-11-02 16:05:36 +01:00
Tim Kuipers
dbe6269262
Revert "refactor: support_mesh ==> overhang_mesh (CURA-2077)"
...
This reverts commit 00041da2df .
2016-11-02 16:01:08 +01:00
Tim Kuipers
0c395c5bfa
fix: wall wipe didn't update last point (CURA-1698)
2016-11-02 15:35:34 +01:00
Tim Kuipers
f312f15813
Merge branch 'master' into feature_infill_support
2016-11-01 11:04:13 +01:00
Ghostkeeper
406ea7155c
Merge pull request #408 from thopiekar/master-gcc6-fix
...
Adding <numeric> for GCC 6.x
2016-11-01 10:21:16 +01:00
Thomas Karl Pietrowski
f0f23ed732
Adding <numeric> for GCC 6.x
...
Otherwise you will get something like:
In file included from /<<PKGBUILDDIR>>/src/FffPolygonGenerator.cpp:7:0:
/<<PKGBUILDDIR>>/src/utils/algorithm.h: In function ‘std::vector<long unsigned int> cura::order(const std::vector<_Tp>&)’:
/<<PKGBUILDDIR>>/src/utils/algorithm.h:30:5: error: ‘iota’ is not a member of ‘std’
std::iota(order.begin(), order.end(), 0); // fill vector with 1, 2, 3,.. etc
^~~
2016-11-01 09:48:46 +01:00
Tim Kuipers
6760f38663
fix: properly clean up SubDivCube
2016-10-31 18:51:24 +01:00
Tim Kuipers
b1cc8e5abf
small optimization: squared distance rather than absolute distance
2016-10-31 18:31:35 +01:00
Tim Kuipers
89d274dfc0
--amend
2016-10-31 18:18:36 +01:00
Tim Kuipers
dde776bde7
removed code duplication in SubDivCube constructor
2016-10-31 16:24:12 +01:00
Tim Kuipers
edd2c796e1
introduced 3d matrix for 3d rotation
2016-10-31 16:23:19 +01:00
Tim Kuipers
07c64b9361
simplified some math
2016-10-31 16:22:36 +01:00
Ghostkeeper
0a59a059f4
Merge branch 'feature_nozzle_off_after_use'
2016-10-31 13:31:37 +01:00
Tim Kuipers
48b479b675
fix of merge conflict
2016-10-27 23:19:33 +02:00
Tim Kuipers
d39a82d13f
Merge remote-tracking branch 'mboerwinkle/master' into feature_recursive_infill_BagelOrb
2016-10-27 23:18:39 +02:00
Tim Kuipers
08844ff8d3
Merge branch 'feature_recursive_infill' into feature_recursive_infill_BagelOrb
2016-10-27 23:16:47 +02:00
Tim Kuipers
5f0a844df3
refactor: better naming
2016-10-27 23:14:08 +02:00
Tim Kuipers
2ea58fe795
cleanup: code conventions etc; no more extern SubDivCube
2016-10-27 23:13:12 +02:00
Tim Kuipers
e902fb3fc9
lil (CURA-2704)
...
makes for better debugging of the scenario of doom (isinside =/= inside)
2016-10-27 22:55:20 +02:00
Tim Kuipers
c7be93e850
test: isinside error I couldn't reproduce (CURA-2704)
2016-10-27 22:53:51 +02:00
Tim Kuipers
fe8207fb1b
fix: user clipper functions for Polygons::inside (CURA-2704)
2016-10-27 22:53:15 +02:00
Tim Kuipers
d1fbe96d6f
feat: use LocToLineGrid for moveInside-like functions (CURA-2704)
2016-10-27 17:17:07 +02:00
Tim Kuipers
ccc89e6263
refactor: typedef SparseLineGrid<PolygonsPointIndex, PolygonsPointIndexSegmentLocator> LocToLineGrid (CURA-2704)
2016-10-27 16:28:41 +02:00
Tim Kuipers
d235de6ca2
fix: early stopping for SparseGrid for_each-like functions (CURA-2704)
2016-10-27 15:06:54 +02:00
Tim Kuipers
4d98e07eb4
fix: safety for polygon operator[] (CURA-2704)
2016-10-27 12:22:50 +02:00
Tim Kuipers
7c3f69a5bf
bugfixes: combing edge cases (CURA-2704)
2016-10-27 12:22:13 +02:00
Tim Kuipers
846bb1109a
fix: combing: create inside_loc_to_line grid after partsView (CURA-2704)
2016-10-27 12:02:48 +02:00
Tim Kuipers
8c5ba49068
fix: more lenient assertions due to rounding errors (CURA-2704)
2016-10-26 18:33:14 +02:00
Tim Kuipers
8e18139ae9
fix: use loc_to_line_grid for optimized combpath optimization (CURA-2704)
2016-10-26 18:32:05 +02:00
Tim Kuipers
410d42ccb3
fix: use inside_loc_to_line grid for checking whether a small move crosses the boundary (CURA-2704)
2016-10-26 18:02:10 +02:00
Tim Kuipers
2c35ba595c
refactor: use LazyInitialization for Comb::outside_loc_to_line (CURA-2704)
2016-10-26 17:53:34 +02:00
Tim Kuipers
8f04afbff9
refactor/fix: LazyInitialization: from bind to lambdas (CURA-2704)
...
also fixes the problem of temporary rvalues being used by the constructor function
2016-10-26 17:51:57 +02:00
Tim Kuipers
1fd5355290
fix: combing: compute whether a small move is cross-boundary (CURA-2704)
...
That is: whether the move is (party) over the in_between area
2016-10-26 15:43:59 +02:00
Tim Kuipers
65b6c48391
refactor: use LazyInitialization for Comb::boundary_outside (CURA-2704)
2016-10-26 15:41:16 +02:00
Tim Kuipers
34c0960cc2
fix: LazyInitialization constructor with function object (CURA-2704)
2016-10-26 15:39:41 +02:00
Tim Kuipers
d6175e8269
feat: LazyInitialization (CURA-2704)
2016-10-26 15:38:42 +02:00
Thomas Karl Pietrowski
47984afb5f
Fixing formatting in README.md
2016-10-25 20:08:49 +02:00
Tim Kuipers
c86823033d
feat: PolygonUtils::polygonCollidesWithlineSegment(.) for a loc_to_line_grid (CURA-2704)
2016-10-25 17:59:19 +02:00
Tim Kuipers
6c157b4e1f
fix: made function parameters const in SparseGrid (CURA-2704)
2016-10-25 17:52:32 +02:00
Tim Kuipers
97b8d63547
fix: LinearAlg2D::lineSegmentsCollide now properly handles colinear cases (CURA-2704)
2016-10-25 16:58:28 +02:00
Tim Kuipers
f0536be401
refactor: move part of LinearAlg2D::lineSegmentsCollide to LinearAlg2D (CURA-2704)
2016-10-25 16:56:57 +02:00
Tim Kuipers
2c983ce39c
feat: SparseGrid::processLine (CURA-2704)
2016-10-25 16:04:38 +02:00
Tim Kuipers
a3eb8ebb2d
refactor: made SparseGrid function templates into std::function (CURA-2704)
2016-10-25 16:04:01 +02:00
Tim Kuipers
bb98cb983e
refactor: abstract SparseLineGrid::insert to SparseGrid::processLine (CURA-2704)
2016-10-25 11:56:17 +02:00
mboerwinkle
ed5a0c03c8
Merge pull request #1 from Ultimaker/feature_recursive_infill_BagelOrb
...
My proposed changes to your PR
2016-10-24 13:48:54 -05:00
Tim Kuipers
a67f7465c1
fix: print support consecutive instead of always at end of layer (CURA-2789)
...
also support_interface_extruder_nr mattered even if the interface was turned off
2016-10-22 16:34:02 +02:00
Tim Kuipers
9b8ef3981a
feat: retract_at_layer_change (CURA-2780)
2016-10-22 16:21:20 +02:00
Tim Kuipers
24a22eec82
feat: start_layers_at_same_position (CURA-1112)
2016-10-21 17:45:44 +02:00
Ghostkeeper
4d34cbc66b
Merge branch 'bugfix_double_to_stream'
2016-10-21 17:28:58 +02:00
Tim Kuipers
405a2b2a5f
fix: allow outer wall wipe to wrap around as many times as requested (CURA-1698)
2016-10-21 17:08:09 +02:00
Tim Kuipers
17260b0272
feat: wall_0_wipe (CURA-1698)
2016-10-21 17:01:40 +02:00
Tim Kuipers
2785baf7be
refactor: allow wall_0_wipe distance as parameter to GCodePlanner::addPolygon (CURA-1698)
2016-10-21 17:01:25 +02:00
Tim Kuipers
c4bc6b8d19
cleanup: codestyle in GCodePlanner::addPolygon (CURA-1698)
2016-10-21 17:00:24 +02:00
Tim Kuipers
a29af7f791
Revert "Revert "feat: setting for carveMultipleVolumes (CURA-2712)""
...
This reverts commit d50f67e583 .
Reapplies b2d837efde
2016-10-21 16:22:45 +02:00
Tim Kuipers
f304c09db4
Merge branch '2.3'
2016-10-21 16:22:30 +02:00
Tim Kuipers
d50f67e583
Revert "feat: setting for carveMultipleVolumes (CURA-2712)"
...
This reverts commit b2d837efde .
2016-10-21 16:22:16 +02:00
Tim Kuipers
b2d837efde
feat: setting for carveMultipleVolumes (CURA-2712)
2016-10-21 16:05:15 +02:00
Ghostkeeper
5c680b312b
Indent broken-up lines
...
So that you can see that the line is broken up into multiple lines.
Contributes to issue CURA-1103.
2016-10-21 15:52:22 +02:00
Ghostkeeper
0a683ff05e
Transform order algorithm to our code style
...
Lukasz needs to obey the rulesz!
Contributes to issue CURA-1103.
2016-10-21 15:39:19 +02:00
Tim Kuipers
a954d88d77
feat: cubic subdivision settings
2016-10-21 14:12:57 +02:00
Tim Kuipers
d301a8f535
fix: no more memory leak for base_subdiv_cube
...
destroy it when instantiated and mesh slice data is deleted
2016-10-21 13:56:54 +02:00
Tim Kuipers
8ac14dc725
fix: no more memory leak for base_subdiv_cube
...
destroy it when instantiated and mesh slice data is deleted
2016-10-21 13:24:50 +02:00
Tim Kuipers
7d4ac28bd2
fix: generate SubDivCube per mesh
...
There used to be one global SubDivCube which would get reset for each mesh on the build plate.
Also resetting without deleting the object leads to memory loss.
2016-10-21 13:19:17 +02:00
Tim Kuipers
f8ea0150fc
Merge branch 'master' of https://github.com/mboerwinkle/CuraEngine into feature_recursive_infill
2016-10-21 12:41:33 +02:00
Tim Kuipers
0dc6dcbb34
fix: concentric infill doesn't start right next to the inner wall any more (CURA-2772)
2016-10-20 23:22:07 +02:00
Tim Kuipers
dbb48c82bf
fix: concentric infill doesn't oscilate because of alternate extra wall (CURA-2772)
...
because the innermost wall was different every layer, the concentric infill was also shifted every layer
2016-10-20 23:13:57 +02:00
Tim Kuipers
2a1e4da930
feat: concentric 3d infill (CURA-2772)
2016-10-20 22:57:31 +02:00
Tim Kuipers
dd481bcc2e
fix: tetrahedral infill line distance is now the average line distance (CURA-2772)
...
Because the lines of tetrahedral infill sway toward and away from each other, we need to speak of an average line distance.
However, the line distance when you skip one line is constant; I call that the period.
2016-10-20 22:56:51 +02:00
Tim Kuipers
f68d1a4e2d
fix: concentric infill copied instead of pass by reference (CURA-2772)
2016-10-20 22:52:51 +02:00
Tim Kuipers
9d56baba41
fix: keep SliceMeshStorage aligned with Mesh (CURA-2077)
2016-10-20 09:38:25 +02:00
Tim Kuipers
4e96d9cbe6
feat: infill_hollow (CURA-2748)
2016-10-19 18:13:38 +02:00
Tim Kuipers
00041da2df
refactor: support_mesh ==> overhang_mesh (CURA-2077)
2016-10-19 16:42:50 +02:00
Tim Kuipers
478bd31d02
Merge branch 'bugfix_double_to_stream' of github.com:Ultimaker/CuraEngine into bugfix_double_to_stream
2016-10-18 11:02:37 +02:00
Tim Kuipers
faab907bab
fix: int64_t and double formatting (CURA-2627)
2016-10-17 17:51:38 +02:00
Tim Kuipers
dff554863c
fix: nozzle was never turned off (CURA-1103)
2016-10-17 17:25:18 +02:00
Tim Kuipers
f2222f97fd
fix: PrimeTower::extruder_count wasn't set (CUTA-1103)
2016-10-17 17:20:25 +02:00
Tim Kuipers
aa18e7bd08
feat: turn nozzle off after last layer switch (CUTA-1103)
2016-10-17 17:12:15 +02:00
Tim Kuipers
07dc53765a
fix: removeEmptyFirstLayers invalidated mesh.layer_nr_max_filled_layer (CURA-1103)
2016-10-17 17:11:37 +02:00
Tim Kuipers
559deb8914
refactor: moved max_print_height_second_to_last_extruder to FffPolygonGenerator (CURA-1103)
2016-10-17 17:10:57 +02:00
Tim Kuipers
421ff6d818
feat: prime tower max print height calculation more generic (CURA-1103)
...
Also fix for platform adhesion in registering the max height an extruder is used.
2016-10-17 15:32:26 +02:00
Tim Kuipers
e85a1004cd
feat: algorithm::order function (CURA-1103)
2016-10-17 14:46:07 +02:00
Tim Kuipers
627848bc41
refactor: max_object_height_second_to_last_extruder ==> max_print_height_second_to_last_extruder (CURA-1103)
2016-10-17 11:30:53 +02:00
Ghostkeeper
eccc62cf1d
Add whitespace around binary operators
...
As per our code style.
Contributes to issue CURA-2627.
2016-10-17 11:06:22 +02:00
Tim Kuipers
1d251fef70
fix: limit prime tower height when support is touching buildplate only (CURA-2633)
2016-10-15 16:15:18 +02:00
Tim Kuipers
16a0cf0fd5
fix: make first layer brim under support round (CURA-2686)
2016-10-15 15:59:48 +02:00
mboerwinkle
06c3729d51
cleaned up a few more things
2016-10-14 14:48:06 +00:00
Tim Kuipers
3c7c352bfc
fix: add support during generation, causing all support settings to be applied to support meshes (CURA-2077)
...
This has the disadvantage that support meshes are re-evaluated for each normal mesh.
However, otherwise support meshes could overlap with each other mesh..
2016-10-14 16:44:50 +02:00
Tim Kuipers
66e6375942
fix: lil typo in AreaSupport::generateSupportAreas for support meshes (CURA-2077)
2016-10-14 16:43:26 +02:00
Tim Kuipers
8d3f66c2cb
fix: don't switch extruder if support interface is too small to be printed (CURA-2077)
2016-10-14 16:41:15 +02:00
Tim Kuipers
1fd540c231
fix: also print support of support meshes above normal support (CURA-2077)
2016-10-14 16:00:45 +02:00
Tim Kuipers
ac799dd00e
fix: don't do multi volumes functions on support meshes (CURA-2077)
2016-10-14 16:00:22 +02:00
Tim Kuipers
699406b044
refactor: anti_support_mesh ==> anti_overhang_mesh (CURA-2077)
2016-10-14 15:31:53 +02:00
Tim Kuipers
2f3333e87c
feat: anti support meshes (CURA-2077)
2016-10-14 15:30:19 +02:00
mboerwinkle
6af4faef1f
fixed my editing of CPackConfig.cmake
2016-10-14 04:16:01 +00:00
mboerwinkle
593f3ae353
Merge branch 'master' of git://github.com/Ultimaker/CuraEngine
2016-10-14 04:05:03 +00:00
mboerwinkle
3e0811fdb7
Cleaned up everything best I could!
2016-10-14 03:51:05 +00:00
mboerwinkle
7f31e39ee3
cleaned up the code
2016-10-14 03:37:00 +00:00
mboerwinkle
ed5ed001b9
utils/polygon.h looks good. infill.h and .cpp look good. infill/subDivCube.h looks good. Only infill/subDivCube.cpp left to fix.
2016-10-14 02:00:44 +00:00
mboerwinkle
f8f14f3968
did some work on bringing my code style up to standards
2016-10-14 01:18:52 +00:00
Tim Kuipers
58e2e1a4e1
fix: better buffer for double to stream and more tests (CURA-2627)
2016-10-13 17:39:59 +02:00
Tim Kuipers
4ebbceb3e3
Merge branch '2.3'
2016-10-11 16:43:05 +02:00
Tim Kuipers
c0495edf48
fix: turn off fans if fans are disabled (CURA-2603)
2016-10-11 16:42:56 +02:00
Tim Kuipers
ace0045109
Merge branch '2.3'
2016-10-11 16:14:44 +02:00
Tim Kuipers
1574292945
fix: forgot to write retractions with given precision (CURA-2619)
2016-10-11 16:14:01 +02:00
Tim Kuipers
ed3f9f107c
fix: only wipe on prime tower when enabled (CURA-2605)
2016-10-11 15:55:05 +02:00
Tim Kuipers
7a4a7fe46a
Merge branch '2.3'
2016-10-11 15:01:03 +02:00
Tim Kuipers
18bf08a1b5
fix: retrieve adhesion_type globally (CURA-2605)
2016-10-11 15:00:51 +02:00
Tim Kuipers
dc41117078
Merge branch 'master' into feature_recursive_infill
2016-10-11 13:30:24 +02:00
Tim Kuipers
977d02a9a2
Updated link to code conventions
2016-10-11 09:22:02 +02:00
mboerwinkle
c339dbc8ae
added subdivcube infill
2016-10-10 17:13:29 +00:00
Tim Kuipers
f30c309249
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-10-10 16:08:31 +02:00
Tim Kuipers
af3536b307
Merge remote-tracking branch 'remotes/origin/feature_remove_trailing_zeros'
2016-10-10 16:08:22 +02:00
Tim Kuipers
8aed4c9139
Merge pull request #399 from Renha/master
...
Extra dollars removed from readme.
2016-10-10 15:48:30 +02:00
Renha
03fa1c2d37
Extra dollars removed from readme.
...
There are no need to write $s twice.
2016-10-10 16:40:49 +03:00
Tim Kuipers
7582100fba
fix: force prime tower wipe as extrusion move so that it's not z hopped (CURA-2522)
2016-10-06 13:42:02 +02:00
Tim Kuipers
edd1d5c8dd
fix: possible infinite loop in support interface generation (CURA-2545)
2016-10-05 17:35:16 +02:00
Tim Kuipers
5971604805
cleanup: less boolean trappy (CURA-2525)
2016-10-05 17:20:48 +02:00
Tim Kuipers
a8ea6511bd
fix: Polygon::smooth_outward can now remove whole hole polygons (CURA-2526)
2016-10-05 14:28:39 +02:00
Tim Kuipers
5c1083db0b
fix: dont remove support for brim inside empty holes (CURA-2525)
2016-10-04 15:43:04 +02:00
Tim Kuipers
f9b917f9d1
feat: Polygons::getEmptyHoles (CURA-2525)
2016-10-04 15:42:40 +02:00
Tim Kuipers
eb065c1a07
fix: avoid obstacles and retract when moving to prime tower (CURA-2522)
2016-10-04 14:16:06 +02:00
Jack Ha
29978b8654
Fix testsuite by adding mock resolveOrValue
2016-10-04 13:23:21 +02:00
Tim Kuipers
9563aeb1c0
fix: prime tower back to LINEs because of CURA-2511 (CURA-2510)
2016-10-03 17:10:46 +02:00
Ghostkeeper
fb7cd6a572
Fix indenting
...
Contributes to issue CURA-1962.
2016-09-30 16:26:39 +02:00
Tim Kuipers
3f02cf1f33
Merge branch 'feature_rotation_matrix' of github.com:Ultimaker/CuraEngine into feature_rotation_matrix
2016-09-30 16:21:14 +02:00
Tim Kuipers
7bdd5690f7
fix: mesh_rotation renamed to mesh_rotation_matrix and warning emitted if matrix is incorrect (CURA-2416)
2016-09-30 16:20:45 +02:00
Tim Kuipers
1de4107ea6
refactor: also use my own << operator for writing integers to stream (CURA-1962)
2016-09-30 15:30:59 +02:00
Tim Kuipers
6306321007
lil fixes (CURA-1962)
2016-09-30 15:26:55 +02:00
Tim Kuipers
7281e2187e
feat: faster double to stream without trailing zeros (CURA-1962)
2016-09-30 15:26:14 +02:00
Ghostkeeper
5f99281478
Fix setting name mesh_rotation_matrix
...
This was not congruent with the setting name in command_line_settings.def.json
Contributes to issue CURA-2416.
2016-09-30 14:00:17 +02:00
Tim Kuipers
3d3c12a9d2
feat: get transformation matrix from settings (CURA-2416)
2016-09-30 12:29:08 +02:00
Ghostkeeper
739aedf8ad
Merge branch 'feature_wipe_on_prime_tower'
2016-09-29 20:46:00 +02:00
Tim Kuipers
1bb79f850a
fix: no more wipe after last printed prime tower; no z hop for wipe; wipe slower (CURA-2420)
2016-09-29 18:30:25 +02:00
Tim Kuipers
3d77a426dd
fix: only wipe on single closest line of prime tower (CURA-2420)
...
otherwise the move from the switch location to the wipe tower already wiped the nozzle on the prime tower, because it moved through the prime tower toward the wipe location
2016-09-29 15:03:41 +02:00
Arjen Hiemstra
3aa3e4ef92
Merge branch 'feature_export_speedup'
...
* feature_export_speedup:
lil writeInt2mm improvements (CURA-2472)
fix: output integers directly to stream rather than converting to double first (CURA-2472)
2016-09-29 13:32:34 +02:00
Tim Kuipers
eb5231e7a8
lil fix: forgotten return statement in hopefully unreachable code (CURA-2420)
2016-09-29 12:16:53 +02:00
Tim Kuipers
17a9764181
fix: retrieve support_enable per mesh (CURA-2492)
2016-09-29 11:57:09 +02:00
Tim Kuipers
86e7dbf2b1
lil writeInt2mm improvements (CURA-2472)
2016-09-29 10:00:36 +02:00
Tim Kuipers
ccaf8538d8
fix: multVolumes: merge overlap better with model (CURA-2427)
...
when models where directly adjacent, the overlap area wouldn't be merged with the model at all places because of rounding errors
2016-09-29 09:46:44 +02:00
Tim Kuipers
a248662077
lil doc (CURA-2420)
2016-09-28 18:53:56 +02:00
Tim Kuipers
fc28698479
fix: tests for PolygonUtils::spreadDots (CURA-2420)
2016-09-28 18:41:59 +02:00
Tim Kuipers
263bb3099b
bugfixes PolygonUtils::spreadDots, segmentLength and PolygonsPointIndex (CURA-2420)
2016-09-28 18:41:30 +02:00
Tim Kuipers
25b83c9dda
factored out PolygonUtils::spreadDots from PrimeTower::generateWipeLocations (CURA-2420)
2016-09-28 17:54:54 +02:00
Tim Kuipers
7025e5cea4
indent only (CURA-2420)
2016-09-28 17:24:57 +02:00
Tim Kuipers
183fc38ca9
refactor PrimeTower::generateWipeLocations (CURA-2420)
2016-09-28 17:24:38 +02:00
Tim Kuipers
f4461ca41a
feat: simple fuctions to find the nearest vert in polygons (CURA-2420)
2016-09-28 17:20:12 +02:00
Tim Kuipers
5ba9026632
factored PolygonsPointIndex out of PolygonUtils (CURA-2420)
2016-09-28 17:19:29 +02:00
Tim Kuipers
01ec0b847f
lil (CURA-2420)
2016-09-28 16:40:04 +02:00
Tim Kuipers
9fe8796844
fix: generateMultipleVolumesOverlap wasn't applied (CURA-2427)
2016-09-28 15:47:11 +02:00
Tim Kuipers
c554ec4178
fix: register horizontal expansion in the AABB of a mesh (CURA-2427)
2016-09-28 15:16:05 +02:00
Tim Kuipers
dce8a4629f
fix: output integers directly to stream rather than converting to double first (CURA-2472)
2016-09-28 11:32:25 +02:00
Tim Kuipers
10af83137b
prime tower: changed from lines to zigzag infill (CURA-2420)
2016-09-27 12:05:14 +02:00
Tim Kuipers
d45d00b441
fix: wipe tower overlapped with brim (CURA-2420)
2016-09-27 11:56:31 +02:00
Tim Kuipers
b2abcbd7b4
refactor: move last_prime_tower_poly_printed inside PrimeTower class (CURA-2420)
2016-09-27 11:29:50 +02:00
Tim Kuipers
9c15d18cfb
unfeat: remove setting prime_tower_dir_outward (CURA-2420)
2016-09-27 11:22:59 +02:00
Tim Kuipers
7122335a55
prime tower: cleanup, const correctness and documentation (CURA-2420)
2016-09-27 11:21:01 +02:00
Tim Kuipers
b5b05c1894
lil cleanup (CURA-1062)
2016-09-22 20:51:16 +02:00
Tim Kuipers
8d6dd5ae8b
fix: dont draw skirt through ooze/draft shield (CURA-1062)
2016-09-22 20:08:18 +02:00
Tim Kuipers
433c90617e
fix: always wipe nozzle diagonally on wipe tower (CURA-2420)
2016-09-22 16:50:24 +02:00
Tim Kuipers
2980b20346
cleanup & documentation of primetower (CURA-2420)
2016-09-22 16:06:53 +02:00
Tim Kuipers
5993b5f606
oops committed debug code (CURA-2420)
2016-09-22 15:45:50 +02:00
Tim Kuipers
f7940498f0
feat: wipe nozzle before starting prime tower (CURA-2420)
...
wipe at different locations each layer, so that there won't be a buildup of material on one place, which might get the tower knocked over
2016-09-22 15:42:58 +02:00
Tim Kuipers
03acc7629c
made some polygon functions const as they should be (CURA-2420)
2016-09-22 15:41:46 +02:00
Ghostkeeper
f903d438f2
Merge branch 'bugfixes_adhesion'
2016-09-22 13:53:47 +02:00
Tim Kuipers
04dc8ac68b
lil auxiliary functions (CURA-2420)
2016-09-22 13:34:53 +02:00
Tim Kuipers
1a2ba63c74
lil cleanup (CURA-2420)
2016-09-21 18:03:11 +02:00
Tim Kuipers
d28d86c208
doc: better documentation of limit_to_extruder property in the proto file (CURA-2308)
2016-09-21 17:59:55 +02:00
Tim Kuipers
afd91bfd2e
cleanup: remove old concentric and spiral prime tower (CURA-2420)
...
I think these prime towers only printed half of the space, assuming the other extruder would print the other half
2016-09-21 17:18:21 +02:00
Tim Kuipers
4cd55f0907
refactor: move wipePoint inside wipeTower (CURA-2420)
2016-09-21 16:55:56 +02:00
Tim Kuipers
f20320031f
fix: precision was inconsistent (CURA-1955)
2016-09-21 16:07:38 +02:00
Tim Kuipers
44f7b92958
some cleanup and const correctness (CURA-1062)
2016-09-21 10:45:11 +02:00
Tim Kuipers
0b4eda9592
fix: brim was slow for high poly dual extrusion models (CURA-1062, CURA-2422)
2016-09-20 18:12:01 +02:00
Tim Kuipers
c674a84f38
Merge branch 'master' into bugfixes_adhesion
2016-09-20 17:31:55 +02:00
Tim Kuipers
2660bd1bc1
Merge branch 'totalretribution-reverse_inset_order'
2016-09-20 13:43:31 +02:00
Tim Kuipers
618660c16f
Merge branch 'reverse_inset_order' of https://github.com/totalretribution/CuraEngine into totalretribution-reverse_inset_order
2016-09-20 13:35:25 +02:00
Tim Kuipers
252a797f36
fix: shield-brim got odd number of brim lines, causing gaps (CURA-1062)
2016-09-20 11:37:26 +02:00
Tim Kuipers
2db70b4b5c
fix: put helper parts of initial layer in separate layer so as to not apply the layer_0_z_overlap (CURA-1062)
2016-09-20 11:13:09 +02:00
Tim Kuipers
379a3d54f1
fix: brim for ooze/draft shield (CURA-1062)
2016-09-20 09:57:46 +02:00
Tim Kuipers
92fca17411
fix: always even number of brim lines between support and model (CURA-1062)
2016-09-20 09:57:23 +02:00
Ghostkeeper
87637c9ef7
Fix comparison between long and int64_t
...
On some machines, long isn't 64-bit.
Contributes to issue CURA-2296.
2016-09-20 09:18:44 +02:00
Tim Kuipers
d2bbe41ff1
refactor: generateSkirtBrim ==> SkirtBrim::generate CURA-1062)
2016-09-19 18:34:24 +02:00
Tim Kuipers
a70fdfb917
feat: introduce layers with helper objects in the airgap (CURA-1062)
2016-09-19 18:01:35 +02:00
Tim Kuipers
ceff626d87
raft auciliary functions (CURA-1062)
2016-09-19 17:46:33 +02:00
Tim Kuipers
53c4552de7
removed unused CommandSocket::sendLayerInfo (CURA-1062)
2016-09-19 17:39:08 +02:00
Ghostkeeper
a576dd8929
Fix literal long on 32-bit
...
On some machines, this literal is only 32 bits wide.
I've now made it always 64 bits wide.
Contributes to issue CURA-2296.
2016-09-19 17:11:24 +02:00
Tim Kuipers
dcec2d2584
refactor: generateRaft ==> Raft::generate (CURA-1062)
2016-09-19 16:31:58 +02:00
Tim Kuipers
6c2d7b72cb
cleanup: removed unused param (CURA-1062)
2016-09-19 16:03:35 +02:00
Tim Kuipers
228b13c96c
fix: raft base came half the line width too far (CURA-1062)
2016-09-19 15:54:40 +02:00
Tim Kuipers
4607d0a8ad
fix: raft goes inward from draft/ooze shield and starts half a line width outward (CURA-1062)
2016-09-19 15:50:09 +02:00
Tim Kuipers
cec7d2bef4
fix: make ooze shield offset round (CURA-1062)
...
so that the ooze shield can never fall outside of the build plate
2016-09-19 14:49:57 +02:00
Tim Kuipers
1eee21a16c
fix: removeSmallAreas works on floats (CURA-1062)
2016-09-19 14:48:49 +02:00
Ghostkeeper
e52beb8239
Fix warning of unused variable
...
It was used only in an assert, so if you're skipping asserts, the variable was unused. I've now cast it into the void to make it 'used'.
2016-09-19 14:40:37 +02:00
Ghostkeeper
72f09d3fa0
Merge bugfix_jagged_support
...
Conflicts:
src/gcodeExport.cpp
src/support.cpp
src/utils/LinearAlg2D.cpp
src/utils/linearAlg2D.h
src/utils/polygon.cpp
2016-09-19 14:34:17 +02:00
Tim Kuipers
9ba3e301d6
fix: don't place ooze shield through thin areas; don't diagonalize oozze shield for too hgih angle; remove small areas afterwards (CURA-1062)
2016-09-19 14:25:34 +02:00
Ghostkeeper
4bea7d8ba2
Use unsigned long string interpreter
...
Sadly, stoui doesn't exist in C++11. We do have stoul though, which comes closer to what we intend and is still more powerful than we need.
Contributes to issue CURA-2314.
2016-09-16 17:03:08 +02:00
Ghostkeeper
b03a7bd9ee
Interpret cool_fan_full_layer as a layer number
...
Because it is.
Contributes to issue CURA-2314.
2016-09-16 16:43:06 +02:00
Ghostkeeper
1f5071c739
Add setting interpretation as layer number
...
Layer numbers are one-based and not negative. This translates it to zero-based.
Contributes to issue CURA-2314.
2016-09-16 16:41:44 +02:00
TotalRetribution
a165265c0a
Simplified outer_inset_first based on BagelOrb suggestion.
2016-09-16 10:34:53 +01:00
Ghostkeeper
7ba5b5c0c8
Merge branch 'bugfix_jagged_support' of github.com:Ultimaker/CuraEngine into bugfix_jagged_support
2016-09-15 16:12:22 +02:00
Tim Kuipers
adcd061f00
fix: smooth_outward fixes (CURA-2296)
2016-09-15 15:39:13 +02:00
Tim Kuipers
f6df79a134
sanity checks (CURA-2296)
2016-09-15 15:19:27 +02:00
Tim Kuipers
955399765c
fix: smooth_outward: continue if a step in both directions doesn't violate the shortcut_length constraint (CURA-2296)
2016-09-15 15:07:30 +02:00
Tim Kuipers
b79043f772
fix: smooth_outward: no more asserts which are violated by rounding errors (CURA-2296)
2016-09-15 14:42:27 +02:00
Tim Kuipers
1380d76075
Merge branch 'bugfix_jagged_support' of github.com:Ultimaker/CuraEngine into bugfix_jagged_support
2016-09-15 13:43:23 +02:00
Tim Kuipers
a2c5a73f09
fix: support: prefer more smoothing rather than less (CURA-2296)
2016-09-15 13:10:41 +02:00
Tim Kuipers
1bdf07ae88
fix: support smoothing based on whether the current mesh has an interface (CURA-2296)
...
before it looked at all meshes
2016-09-15 13:06:51 +02:00
TotalRetribution
ca1d6082e6
In processInsets moved code in for loops to processInsetLoop function to reduce duplication caused by outer_inset_first.
2016-09-15 12:06:02 +01:00
Tim Kuipers
33eabda16f
refactor: support: limited support_line_width to somputation for smoothing_distance (CURA-2296)
2016-09-15 13:02:39 +02:00
TotalRetribution
da659759cf
Merge remote-tracking branch 'origin/master' into reverse_inset_order
2016-09-15 12:00:53 +01:00
Tim Kuipers
5b99143761
lil doc (CURA-2296)
2016-09-15 12:59:05 +02:00
Tim Kuipers
dc92c1376c
lil refactor (CURA-2296)
2016-09-15 12:32:01 +02:00
Tim Kuipers
beaf71dfe8
lil optimization: pass down the square of shortcut_length in smooth_outward (CURA-2296)
2016-09-15 12:30:33 +02:00
Tim Kuipers
3062c07763
fix: smooth_outward used outdated v02 var (CURA-2296)
2016-09-15 12:23:53 +02:00
Tim Kuipers
134b37da2e
refactor: factored out complex case out of smooth_outward (CURA-2296)
2016-09-15 12:15:12 +02:00
Tim Kuipers
af10ef571d
refactor: factor out the simple case from smooth_outward (CURA-2296)
2016-09-15 11:54:47 +02:00
Tim Kuipers
92af4b76b7
doc: more comments for smooth_outward (CURA-2296)
2016-09-15 10:25:58 +02:00
Tim Kuipers
d97cfa4152
refactor: factor out inner part of loop in smoot_outward (CURA-2296)
2016-09-15 09:50:53 +02:00
Tim Kuipers
9988c67397
fix: invalid assert removed (CURA-2296)
...
assertion didn't hold for lines with a very shallow angle
2016-09-15 09:32:24 +02:00
Tim Kuipers
b7f77e9dca
lil improvement (CURA-2296)
2016-09-15 09:11:31 +02:00
Tim Kuipers
ca25ce076c
lil comment (CURA-2317)
2016-09-14 18:12:30 +02:00
TotalRetribution
71bfafbc0f
Fixed Indentation in FffGcodeWriter.cpp FffGcodeWriter::processInsets.
2016-09-14 14:53:52 +01:00
Ghostkeeper
ec44e711fb
Fix long literals
...
Turns out the 1 wasn't an 1 but a lowercase L. This is why people tend to use uppercase L for long.
Contributes to issue CURA-2296.
2016-09-14 13:48:02 +02:00
Ghostkeeper
8fd5c6d404
Fix wording of angle parameter documentation
...
Maximal is a local maximum. Maximum is the actual maximum, where there is nothing higher. The second is correct here.
Contributes to issue CURA-2296.
2016-09-14 13:39:42 +02:00
Ghostkeeper
9da278795f
Fixed numerical literal typo
...
Contributes to issue CURA-2296.
2016-09-14 13:33:39 +02:00
Ghostkeeper
2050e71dda
Fixed numerical literal typo
...
Contributes to issue CURA-2296.
2016-09-14 13:30:48 +02:00
Tim Kuipers
df003d7649
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-09-14 10:47:17 +02:00
Tim Kuipers
281e647b82
refactor: global_inherits_stack ==> limit_to_extruder (CURA-2308)
2016-09-14 10:47:08 +02:00
Ghostkeeper
0771eafc60
Fix warning of comparison unsigned to signed
...
This now allows for higher amounts of draft shield layers, in theory, with the same memory and processing cost.
2016-09-13 17:20:14 +02:00
Ghostkeeper
0743994375
Add spaces after comma
...
As per the code style.
Contributes to issue CURA-2296.
2016-09-13 16:53:42 +02:00
Tim Kuipers
7b9e571474
fix: don't retrieve the machine name from the json document, but from the settings (CURA-2360)
2016-09-13 16:44:07 +02:00
Ghostkeeper
73506345ac
Fix line direction mix-up in documentation
...
The point is before ab, or after ba.
Contributes to issue CURA-2296.
2016-09-13 16:39:52 +02:00
Tim Kuipers
ff57c578db
fix: copy first extruder if there's no definition for a latter one (CURA-2016)
2016-09-13 15:00:53 +02:00
TotalRetribution
0436916f4a
Merge remote-tracking branch 'origin/master' into reverse_inset_order
...
Conflicts:
src/FffGcodeWriter.cpp
Fixed Conflict with src/FffGcodeWriter.cpp
2016-09-13 10:55:31 +01:00
Tim Kuipers
4a392d1e79
fix: interface wasn't generated near the top of the print (CURA-2308)
2016-09-13 11:42:53 +02:00
Tim Kuipers
eb277a1181
lil type fix (CURA-2016)
2016-09-13 11:38:09 +02:00
Tim Kuipers
7b972305b5
fix: exit when file couldn't load (CURA-2016)
2016-09-13 11:35:41 +02:00
Tim Kuipers
103b2ef7a8
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-09-13 11:18:23 +02:00
Tim Kuipers
a4bb8ed287
fix: exit when json couldn't load (CURA-2016)
2016-09-13 11:15:54 +02:00
Tim Kuipers
8edce9d470
log errors when json files couldn't load (CURA-2016)
2016-09-13 11:08:46 +02:00
Tim Kuipers
54152aded7
lil cleanup (CURA-2016)
2016-09-13 10:35:58 +02:00
Tim Kuipers
771e840d07
lil cleanup (CURA-2016)
2016-09-13 10:26:55 +02:00
Tim Kuipers
1057b1e277
fix: load extruder json when and only when extruder is created (CURA-2016)
2016-09-13 10:25:54 +02:00
Tim Kuipers
26b78d68f4
fix: don't overload extruder settings over user supplied (CURA-2016)
2016-09-12 18:30:39 +02:00
Tim Kuipers
2583c2e594
Revert "fix: command line slicing overwrote child settings with parent settings"
...
This reverts commit 9c2fb686e6 .
2016-09-12 18:29:35 +02:00
Tim Kuipers
9c2fb686e6
fix: command line slicing overwrote child settings with parent settings
2016-09-12 18:08:08 +02:00
Tim Kuipers
7396deb65b
fix: jerk gcode for repetier firmware
2016-09-12 11:07:53 +02:00
Tim Kuipers
32f234eb87
Merge branch '2.3'
2016-09-12 10:49:15 +02:00
Tim Kuipers
adbf0354e6
refactor: getDraftShieldHeight==>getDraftShieldLayerCount (CURA-2098)
2016-09-12 10:49:00 +02:00
Tim Kuipers
5e7acc8b62
fix: draft shield is computed over all layers used now (CURA-2098)
2016-09-12 10:47:13 +02:00
Tim Kuipers
b1044cbe24
lil innocent assert change
2016-09-09 17:19:16 +02:00
Tim Kuipers
91a5589413
Merge branch '2.3'
2016-09-09 17:04:50 +02:00
Tim Kuipers
dc97b5f312
fix: add brim around support and around model (CURA-2317)
2016-09-09 12:30:04 +02:00
Tim Kuipers
b494b7b86d
fix: made secondary skirt generate even when the primary is empty; retrieved minimal_length per extruder (CURA-2308)
2016-09-09 12:10:38 +02:00
Tim Kuipers
970789fb4b
lil renames (CURA-2308)
2016-09-09 11:45:18 +02:00
Tim Kuipers
f4e19dd217
lil rename
2016-09-08 19:47:56 +02:00
Tim Kuipers
700ce8ef3b
fix: retrieve interface_enable per mesh (CURA-2296)
2016-09-08 19:47:26 +02:00
Tim Kuipers
df3426e8bb
Merge branch '2.3'
2016-09-08 17:31:02 +02:00
Tim Kuipers
fd73470580
fix: carveMultipleVolumes again! (CURA-1917)
2016-09-08 17:30:35 +02:00
Tim Kuipers
959664c080
Merge branch '2.3'
2016-09-08 17:17:53 +02:00
Tim Kuipers
3e9b42a2a2
fix: only print ooze shield up to the layer where the last extruder switch will happen (CURA-2139)
2016-09-08 17:17:44 +02:00
Tim Kuipers
eb74c5ce88
Merge branch '2.3'
2016-09-08 16:24:47 +02:00
Tim Kuipers
51b840caee
cleanup: made some stuff const in support.cpp (CURA-2052)
2016-09-08 16:24:34 +02:00
Tim Kuipers
d695344f1b
cleanup: removed debugging code (CURA-2296)
...
and removed acciodental bracket, which f*cks things up when you try to build previous commits
2016-09-08 15:44:52 +02:00
Tim Kuipers
0e9a7154ca
removal: made support_area_smoothing hardcoded (CURA-2296)
2016-09-08 15:39:20 +02:00
Tim Kuipers
72e4bf8069
cleanup: some doc, parameter name changes, lil bugfix (CURA-2296)
2016-09-08 15:35:18 +02:00
Tim Kuipers
acf26ba2f8
fix: made LinearAlg2D::getDist2FromLine more robust against rounding errors (CURA-2296)
2016-09-08 15:15:28 +02:00
Tim Kuipers
347f5c6238
fix: made LinearAlg2D::getPointOnLineWithDist more robust against rounding errors (CURA-2296)
2016-09-08 14:55:27 +02:00
Tim Kuipers
aebe1ef46c
fix: smooth_outward half blocked case was too naive (CURA-2296)
...
In the case which loks like \/ the sides may be longer than the shortcut on top, while there might be a shortcut halfway through which is long enough
2016-09-08 13:48:06 +02:00
Tim Kuipers
4f073ab23f
fix: smooth_outward takes care of degenerate verts (CURA-2296)
2016-09-08 11:51:12 +02:00
Tim Kuipers
62dd1c1575
fix: smooth_outward now handles separately when v02 dist is about the required dist (CURA-2296)
...
This is to avoid rounding errors which conclude that no shortcut is possible
Now also in the general case
2016-09-08 11:18:50 +02:00
Tim Kuipers
04df283704
indent only (CURA-2296)
2016-09-08 10:46:47 +02:00
Tim Kuipers
695e5dd982
fix: smooth_outward now handles separately when v02 dist is about the required dist (CURA-2296)
...
This is to avoid rounding errors which conclude that no shortcut is possible
2016-09-08 10:45:18 +02:00
Tim Kuipers
26757ef802
fix: smooth_outward used degrees instead of radians (CURA-2296)
2016-09-07 19:40:01 +02:00
Tim Kuipers
baf8f49360
feat: Polygon::smooth_outward (CURA-2296)
2016-09-07 19:23:27 +02:00
Tim Kuipers
4b20528a34
feat: LinearAlg2D::getPointOnLineWithDist(.) (CURA-2296)
2016-09-07 15:41:05 +02:00
Ghostkeeper
487b990f46
Merge branch '2.3'
2016-09-07 15:31:01 +02:00
Ghostkeeper
27d940191e
Merge branch 'bugfix_polygon_oversimplification' into 2.3
...
Conflicts:
src/utils/ListPolyIt.cpp
src/utils/ListPolyIt.h
2016-09-07 15:29:05 +02:00
Ghostkeeper
7c48706e80
Fix compiler warning with multiline comment
...
Because the line ended in a backslash, it would take the next line as a comment too. The next line was already a comment, so it didn't matter, but this period is now at the end to prevent the compiler warning.
Contributes to issue CURA-1966.
2016-09-07 14:51:53 +02:00
Tim Kuipers
09a3ec4790
feat: LinearAlg2D::pointIsLeftOfLine(.) (CURA-2296)
2016-09-07 13:34:52 +02:00
Tim Kuipers
b1e602f9f2
lil refactor: argument reorder in PolygonRef::smooth(.) (CURA-1966)
2016-09-07 09:21:11 +02:00
Tim Kuipers
f98836c279
cleanup/optimization: PolygonRef::smooth has no more code duplication and values aren't recomputed any more (CURA-1966)
2016-09-07 09:17:43 +02:00
Tim Kuipers
b54a0d3b91
fix: revamped Polygon smooth(.) (CURA-1966)
2016-09-06 17:43:27 +02:00
Jack Ha
a3f2d08f13
Merge branch '2.3'
2016-09-06 16:53:22 +02:00
Ghostkeeper
2b6c70d19c
Remove unnecessary brackets
...
Contributes to issue CURA-2052.
2016-09-06 15:14:51 +02:00
Tim Kuipers
b79f362196
refactor: moves smooth(.) from Polygon.h to Polygon.cpp (CURA-1966)
2016-09-06 14:25:52 +02:00
Tim Kuipers
535bb8cf66
Merge branch '2.3'
2016-09-06 11:14:53 +02:00
Tim Kuipers
eb2d4d3ad1
fix: test SparseLineGrid through origin and visualize correct
2016-09-06 11:12:35 +02:00
Tim Kuipers
a8152bb727
Merge branch '2.3' into markwal-negativesparselinegrid
2016-09-06 10:55:11 +02:00
Tim Kuipers
3e0a2ca48a
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-09-06 10:54:25 +02:00
Tim Kuipers
2dc4411702
fix: help didn't get outputted
2016-09-06 10:54:18 +02:00
Mark Walker
0d38105a1a
Simplify since we don't need the locals outside of
...
inner block any more
2016-09-05 11:30:40 -07:00
Mark Walker
c179d16a9e
sign to nonzero_sign and remove corner crossing fix
2016-09-05 11:14:03 -07:00
Mark Walker
76ac083eb3
Add some variable comments
2016-09-05 10:37:10 -07:00
Mark Walker
da998384f0
SparseGridLine for negative coordinates
...
and also the TODO for precisely crossing cell corners
2016-09-05 10:37:10 -07:00
Tim Kuipers
13f7e0d7e4
fix: give support interface a different color (CURA-2049)
2016-09-05 18:01:21 +02:00
Tim Kuipers
1f721a2513
fix: expand support interface so that it's never too thin to be printed (CURA-2052)
2016-09-05 17:50:37 +02:00
Tim Kuipers
4df0a27cb2
fix: support interface skip layer flaw (CURA-2052)
...
we should divide up the remaining layers after we have checked the top or bottom most
2016-09-05 17:49:34 +02:00
Tim Kuipers
0c6aca19aa
fix: interface also checks in-between layers for model (CURA-2052)
2016-09-05 17:05:17 +02:00
Aldo Hoeben
bd8c501dc3
Update Cura.proto
...
Add polygon type for Support Interface
CURA-2049
2016-09-05 16:33:45 +02:00
Tim Kuipers
b36acb07c5
fix: don't put skirt under support (CURA-2264)
2016-09-05 16:14:38 +02:00
Tim Kuipers
492bf72ffd
fix: wire printing: processStartingCode copied from FffGcodeWriter and replaced setting retrieval to naive approach (CURA-1555)
2016-09-05 15:38:18 +02:00
Tim Kuipers
f7ef517f01
fix: div by zero in LinePolygonsCrossings::lineSegmentCollidesWithBoundary() (CURA-2237)
2016-09-05 13:50:06 +02:00
Tim Kuipers
7a015ea146
fix: combing could cross exactly between two consectuive line segments of the boundary (CURA-2237)
2016-09-01 19:15:35 +02:00
Tim Kuipers
48aaebc20d
fix: only set support.generates when it actually generated support (CURA-1571)
2016-09-01 18:03:02 +02:00
Tim Kuipers
209f770cf4
fix: don't drop on buildplate when there's support under the model (CURA-1571)
2016-09-01 18:02:01 +02:00
Tim Kuipers
ec6c1216f2
fix: wireprint skirt extrusion was 10x too big (CURA-1555)
2016-09-01 15:04:29 +02:00
Tim Kuipers
c638ca822b
fix: wireprint flow now calculated as mm3 instead of E steps (CURA-1555)
2016-09-01 15:03:59 +02:00
Tim Kuipers
9007e3ff50
refactor: extrusion_per_mm ==> extrusion_mm3_per_mm (CURA-1555)
2016-09-01 15:01:25 +02:00
Tim Kuipers
32ce5e5a44
fix: wireprint don't print skirt at z0 (CURA-1555)
2016-09-01 14:57:29 +02:00
Tim Kuipers
825882100f
fix: wire printing pointer bug (CURA-1555)
2016-09-01 13:47:32 +02:00
Tim Kuipers
a47aa1e4fd
cleanup: changed some logError to log or logWarning and cleaned up the messages
2016-09-01 13:06:01 +02:00
Tim Kuipers
f5f1886175
feat: outputing correct gcode header after command line slicing
2016-09-01 12:02:27 +02:00
Tim Kuipers
26d05dc5e6
Merge pull request #385 from markwal/fixconstexprwarning
...
Fix constexpr function warning for C++14
2016-08-31 17:16:22 +02:00
Mark Walker
2715599791
Fix constexpr function warning for C++14
...
See https://akrzemi1.wordpress.com/2013/06/20/constexpr-function-is-not-const/
2016-08-28 20:51:36 -07:00
Jaime van Kessel
3c6b153e60
Removed double indication as this caused mac build to fail
2016-08-19 14:58:43 +02:00
Ghostkeeper
9bfdeb4ccd
Move per-path offset to use it only on skirt
...
This is the only place where an outside offset is done and the inside polygons don't matter, so it is the only place where the union can safely be performed, since the union treats holes as normal polygons.
Contributes to issue CURA-2088.
2016-08-19 11:11:10 +02:00
Ghostkeeper
3aaddb08ba
Move approxConvexHull implementation to CPP file
...
Where it damn well belongs, the little runt.
Contributes to issue CURA-2088.
2016-08-19 11:01:20 +02:00
Ghostkeeper
752985c9b2
Remove debug include
...
Because this include is at the top of the file, I didn't see it was still there. Sorry.
Contributes to issue CURA-2088.
2016-08-18 14:22:22 +02:00
Ghostkeeper
dcb8a03a73
Offset polygons one path at a time
...
This prevents an infinite loop in the offset code in Clipper if the polygons overlap.
Contributes to issue CURA-2088.
2016-08-18 14:16:57 +02:00
Ghostkeeper
028c408be3
Move Polygons::Offset to CPP file
...
We should really do this with all of these functions. In this case, I required this in order to be able to import SVG for a bit of debugging.
Contributes to issue CURA-2088.
2016-08-18 13:21:27 +02:00
Ghostkeeper
822a2d55f2
Rebase bugfix_overlap_compensation onto master
...
Contributes to issue CURA-1911.
2016-08-17 17:09:21 +02:00
Ghostkeeper
3e283a375e
Revert "lil feat: LinearAlg2D::projectPointOnLine(.) (CURA-1911)"
...
This reverts commit 7f08d37408eb9d010a24095f3f9b6facbe862c2e.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
635ef25030
Optimize if-statement structure
...
Also more readable, in my opinion. It's just a bunch of cases and a base case, with lazy evaluation in between.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
9a9855c0a5
Swap ifs so that we use else-if instead of recompute
...
Saves some computation time.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
83e52f6e53
Make projections constant
...
These variables aren't changed. This might allow for better optimisations by the compiler.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
9d59dde760
Improve overlap estimation for stair-case
...
In the case of stairs, there is no overlap either. The approximation now takes that into account at hardly any additional computational cost.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
9b40d6053c
Switch from and to back
...
Since these parameters are now renamed, this is clearer.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
ba05f42c91
Remove intermediary variable
...
The intermediary variable was supposed to make the variable name more clear. Instead, I just renamed the input parameter, removing the weird construct.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
5684a0cbb4
Remove commented code
...
As per our code style.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
0647fa21fe
Switch to and from other parameters
...
For consistency.
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
cb5467d2b3
Fix typo in documentation
...
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Ghostkeeper
24ec8bb254
Fix spelling in documentation
...
Contributes to issue CURA-1911.
2016-08-17 16:43:09 +02:00
Tim Kuipers
8069aba0b5
fix: proximity: don't disregard potential linking between a point and a consecutive line segment (CURA-1911)
...
short line segments might need linking from front to end when the previous and next line segment are parallel
2016-08-17 16:43:09 +02:00
Tim Kuipers
591cd105b5
lil TODO idea (CURA-1911)
2016-08-17 16:43:09 +02:00
Tim Kuipers
13e5e786bc
fix: proximity: don't disregard potential linking between consecutive line segments (CURA-1911)
...
the end point of the new line segment might still need to be projected onto the other line segment
short line segments might need linking from front to end when the previous and next line segment are parallel
2016-08-17 16:43:09 +02:00
Tim Kuipers
6f0ef96c5e
fix: small fixes for overlap compensation (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
ed636f9a44
lil assert change
2016-08-17 16:43:08 +02:00
Tim Kuipers
8f50db989c
fix: remove degenerate verts which result in multiple verts sharing the same location (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
f4e22ae7a0
lil feat: LinearAlg2D::projectPointOnLine(.) (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
cbc6e6f270
fix: PolygonProximityLinker::addProximityEnding don't add to the same set we are looping over (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
07b8165d47
fix: getApproxOverlapArea had arguments ordered wrong (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
e2409148cc
fix: compute less overlap when line segments are not opposite each other (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
a3129bf1f6
feat: LinearAlg2D::pointIsProjectedBeyondLine (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
f191497234
fix: overlap compensation: move direction info down to getApproxOverlapArea (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
ef9c477ee2
lil cleanup & doc (CURA-1911)
2016-08-17 16:43:08 +02:00
Tim Kuipers
bdcaa6c9ac
lil refactor (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
046310efcb
more doc of PolygonProximityLinker::addNewPolyPoint (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
74133ae7d7
rename PolygonProximityLinker::findProximatePoints a_from ==> a_point (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
20dff1fe8b
Revert "lil doc fix (CURA-1911)"
...
This reverts commit 1651e04f2cd1cfd69c8c92d397abfba53cb5dcc9.
2016-08-17 16:43:07 +02:00
Tim Kuipers
c7be6e147b
fix: was taking std::max of double and float (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
574739e193
lil doc fix (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
b3c0f0d2da
lil rewrite (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
33be01596c
lil doc of wall overlap (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
2cbd6d1c8a
lil rename in wall overlap (CURA-1911)
2016-08-17 16:43:07 +02:00
Tim Kuipers
510c328127
lil refactor: user unordered_map/set.find(.) rather than .count(.) (CURA-1911)
2016-08-17 16:43:06 +02:00
Ghostkeeper
9413aceaf2
Add space after comma
...
Thus haveth the code style spoken.
Contributes to issue CURA-1911.
2016-08-17 16:43:06 +02:00
Ghostkeeper
aee1887b57
Add spaces around assignment operators
...
As the code style declares.
Contributes to issue CURA-1911.
2016-08-17 16:43:06 +02:00
Ghostkeeper
b72917305c
Add missing brackets
...
To comply to the code style.
Contributes to issue CURA-1911.
2016-08-17 16:43:06 +02:00
Ghostkeeper
7d61f00b3a
Fix documentation grammar
...
It was hard to read due to the point A vs. the indefinite article a.
Contributes to issue CURA-1911.
2016-08-17 16:43:06 +02:00
Tim Kuipers
247f5d3cde
fix: removed debugging member from WallOverlapComputation (CURA-1911)
2016-08-17 16:43:06 +02:00
Tim Kuipers
21202c2e8c
fix: don't compensate for overlap if the two lines are going in the same direction (CURA-1911)
2016-08-17 16:43:06 +02:00
Tim Kuipers
6973e99cd1
cleanup: removed old slow overlap computation (CURA-1911)
2016-08-17 16:43:06 +02:00
Tim Kuipers
8cf1f1646b
safety: check for duplicate points in input polygon (CURA-1911)
2016-08-17 16:43:06 +02:00
Tim Kuipers
2a1fc8245a
safety: check for duplicate points in input polygon (CURA-1911)
2016-08-17 16:43:06 +02:00
Tim Kuipers
a1a3931f68
feat: improved slicing speed by letting overlap compensation use SparseLineGrid (CURA-1911)
...
also iterate over the newly introduced points again, because they might need links which don't get introduced when we already passed that point in the poly
also prevert newly introduced points to again introduce new points, cause otherwise we might introduce a lot of new points in a corner (visual explanation in code)
2016-08-17 16:43:05 +02:00
Tim Kuipers
e3dd8f0bdf
forgotten import (CURA-1911)
2016-08-17 16:43:05 +02:00
Tim Kuipers
3a06f49fba
fix: fixes for SparseLineGrid line to pixel algorithm (CURA-1911)
...
sometimes a line wouldn't be added to the grid at all
2016-08-17 16:43:05 +02:00
Tim Kuipers
65e90d5de0
feat: ListPolyIt operator!= and hash function object (CURA-1911)
2016-08-17 16:43:05 +02:00
Tim Kuipers
e33c441f6d
feat: Polygons::pointCount (CURA-1911)
2016-08-17 16:43:05 +02:00
Tim Kuipers
418de5d822
refactor: use actual SparseLineGrid rather than the hacked locToLineGrid (CURA-1911)
2016-08-17 16:43:05 +02:00
Tim Kuipers
a6b45b683e
fix: no more overlap areas are skipped because neighboring overlap areas were already processed (CURA-1911)
2016-08-17 16:43:05 +02:00
Tim Kuipers
eda2c987ff
feat: symmetric pair utility class (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
a71c18a146
safety: debug check for line grids (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
424e3edb4d
fix: SparseLineGrid computes cells based on print coords rather than grid coords (CURA-1911)
...
also a fix for horizontal lines, which caused division by zero.
2016-08-17 16:43:04 +02:00
Tim Kuipers
ad1c442c9a
feat: SparseLineGrid (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
65ced4a4bb
feat: SparseGrid now exposes more functions for grid to print space coords to inheriting classes (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
242e8118e3
refactor: split off SparseGrid from SparsePointGrid (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
f720cc1f0b
refactor: SparseGridInvasive ==> SparsePointGrid (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
721d7d799f
refactor: SparseGrid ==> SparsePointGridInclusive (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
26c3a35150
fix: moved SparseGridElem to SparseGrid.h (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
c1d097f7fe
lil rename (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
fedcfe582e
safety: asserts in PolygonProximityLinker (CURA-1911)
2016-08-17 16:43:04 +02:00
Tim Kuipers
1ffafd4b17
debug fix: don't visualize SVG upside down (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
45c4e2e0a1
fix: proximitylinker: don't add points twice (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
6ae7fdac5c
fix: proximitylinker: don't add points on the same location as other points (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
bf2123b82c
feat/refactor: PolygonProximityLinker::addCornerLink (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
81881a876d
fix: link points ifthey are proximate even though the line segments are connected (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
34859670ef
refactor: bit of renaming (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
4038d39e85
fix: process sharp corners before normal proximite points (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
999a131ecf
fix: ListPolyIt assignment overwrite referred polygon (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
2bcffaa0ab
fix: overlap comensation is now also activated for sharp corners (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
7f584c2e4f
refactor: merge proximity_point_links_endings into proximity_point_links (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
ba045e803b
indent change only (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
1fd2c66ec7
fix: don't create ending link when other side continues to overlap with the same point (CURA-1911)
...
also inverted some logic; indent change follows
2016-08-17 16:43:03 +02:00
Tim Kuipers
be7ea53325
fix: account for overlap areas ending in a pointy end (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
8045fb49ff
refactor: let PolygonProximityLinker::findProximatePoints use ListPolyIt instead of separate iterators and references (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
1504e38c8c
fix: proximity was only recorded between points and line segments further on in the polygon (CURA-1911)
2016-08-17 16:43:03 +02:00
Tim Kuipers
b646e94880
refactor: renaming in PolygonProximityLinker::findProximatePoints (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
929719ebdd
refactor: findProximatePoints actual linking functionality moved to its own function (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
905d788c3c
fix: findProximatePoints used wrong first segment (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
0dba144c37
doc: PolygonProximityLinker overlap ==> proximity (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
f7ba6979da
refactor: moved SparseGridInvasive to its own file (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
ae832cba68
fix: overlap links got introduced twice sometimes (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
6bdc8dae51
refactor: factored out ProximityPointLink into ints own class file (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
9a23163564
copyright
2016-08-17 16:43:02 +02:00
Tim Kuipers
fcc207ad0d
fix: store whether an overlap link is passed once outside of the link (CURA-1911)
...
The link was stored at multiple places (copies), so the information was not shared between all copies.
2016-08-17 16:43:02 +02:00
Tim Kuipers
44df11bc2c
fix: PolygonProximityLinker::getLink now returns pointer instead of optionally a copy (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
2458a9a580
lil optimization for wall overlap compensation (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
ba92bf9693
cleanup: PolygonProximityLinker::isLinked(.) makes wallOverlap more simple (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
8c1ecf1200
cleanup: simplified WallOverlapComputation::handlePotentialOverlap (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
4fdcf4ed29
cleanup: removed code duplication and add more documentation (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
cde315109a
fix: overlap compensation now also compensates segments overlapping with points (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
50ca8d7473
fix: let overlap compensation account for segments overlapping with multiple other segments (CURA-1911)
...
Make PolygONProximityLinker::Point2Link be a multimap, mapping points to multiple links
Change getLink(.) to getLinks(.)
Expose Point2Link so that outside classes can reason about which link is which
wallOverlap
Compute the actual overlapping area, since the ratio cannot easily be computed when multiple overlaps are involved
Compute the overlap area for segments for which both ends are linked to the same point
2016-08-17 16:43:02 +02:00
Tim Kuipers
9b8b3d150c
cleanup: the list_polygons are used after the contructor of PolygonProximityLinker (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
f4fd6ab0f4
cleanup: lil doc and trailing whitespace (CURA-1911)
2016-08-17 16:43:02 +02:00
Tim Kuipers
b593331c17
cleanup: removed outcommented debug code (CURA-1640)
2016-08-17 16:43:02 +02:00
Tim Kuipers
afb6237cbf
dox fix: updated doc of WallOverlap (CURA-1640)
2016-08-17 16:43:02 +02:00
Tim Kuipers
a716b88621
dox fix: updated doc of PolygonProximityLinker (CURA-1640)
2016-08-17 16:43:02 +02:00
Tim Kuipers
0bc384c807
cleanup: removed unused commented code (CURA-1640)
2016-08-17 16:43:02 +02:00
Tim Kuipers
a2e4f2a1cb
fix: accidentally removed line (CURA-654)
2016-08-17 16:43:01 +02:00
Tim Kuipers
d3c62049eb
refactor: made WallOverlap use PolygonProximityLinker (CURA-654)
2016-08-17 16:43:00 +02:00
Tim Kuipers
e773029266
refactor+fix: moved ProximityLinkAttributes into (mutable) ProximityLink + fixed iterator invalidation issues (CURA-654)
...
the [passed] attribute needs to be mutable: it doesn't change the hash of the object and needs to be changed after it's been in the set
fixed iterator invalidation issues by simply copying items from the set into the map, rather than referring to them
2016-08-17 16:39:35 +02:00
Tim Kuipers
c42b3322cd
removed debug function
2016-08-17 16:39:35 +02:00
Tim Kuipers
b652db33c1
refactor: rename WallOverlap ==> Proximity (CURA-654)
2016-08-17 16:39:35 +02:00
Tim Kuipers
596082dc7c
cleanup PolygonProximityLinker and use ListPolyIt (CURA-654)
2016-08-17 16:39:35 +02:00
Tim Kuipers
411300e0e1
refactor: factor out ListPolyIt class (CURA-654)
2016-08-17 16:39:35 +02:00
Tim Kuipers
b44116c4e5
feat: PolygonProximityLinker class (CURA-654)
2016-08-17 16:39:35 +02:00
Ghostkeeper
bf0cd02928
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-08-11 16:37:53 +02:00
Ghostkeeper
3b4c54839d
Merge feature_brim_under_support
...
Conflicts:
src/SkirtBrim.cpp
src/gcodeExport.cpp
2016-08-11 16:35:27 +02:00
Tim Kuipers
b6cb7cd271
fix: don't limit speeds to 1 mm/s when retrieving a setting (CURA-1049)
2016-08-11 16:29:25 +02:00
Tim Kuipers
ee447a9191
merge conflict fix (CUYRA-1956)
2016-08-11 16:22:31 +02:00
Ghostkeeper
9d755211cd
Update reference to support skin
...
This new code was introduced by the brim-only-outside feature and gave no merge conflict, but was not up-to-date with the support roof rename to support skin.
Contributes to issue CURA-1413.
2016-08-11 15:58:46 +02:00
Tim Kuipers
db83fcd57e
fix: also generate brim for parts which flly lie inside other parts (CURA-1413)
2016-08-11 15:38:17 +02:00
Tim Kuipers
2ccaef10b9
feat: Polygons::removeEmptyHoles() (CURA-1413)
2016-08-11 15:38:17 +02:00
Tim Kuipers
d004c77106
feat: brim only for outside polygons (CURA-1413)
2016-08-11 15:38:17 +02:00
Tim Kuipers
2bddfcd42a
feat: Polygons::getOutsidePolygons() (CURA-1413)
2016-08-11 15:38:17 +02:00
Tim Kuipers
4cd1b5066c
fix: only generate skirt polygons for used extruders (CURA-1647)
...
also cleaned up generateSkirtBrim a bit
also applied code conventions
inadvertently also causes support not to be removed by unprinted skirt
removed skirts_or_brims which didn't need to be a vector (only last elem was used)
2016-08-11 15:38:17 +02:00
Tim Kuipers
e0959e4aa0
feat: ExtruderTrain::is_used (CURA-1647)
2016-08-11 15:38:17 +02:00
Tim Kuipers
a29dcb33da
fix: brim removed support rather than going around it (CURA-1647)
2016-08-11 15:24:20 +02:00
Tim Kuipers
152cf5835f
Merge branch 'master' into feature_brim_under_support
2016-08-11 15:19:20 +02:00
Tim Kuipers
eb065aa415
lil
2016-08-11 14:53:28 +02:00
Tim Kuipers
9430432af7
fix: support simplifies based on line width (CURA-1966)
2016-08-10 14:17:48 +02:00
Tim Kuipers
252c2cae28
assert fix: default jedi profile has speeds up to 200
2016-08-10 13:12:27 +02:00
Aldo Hoeben
9ee30bba12
Merge pull request #379 from Ultimaker/master-CURA-1724
...
CURA-1724: Updating README.md
2016-08-10 12:45:03 +02:00
Tim Kuipers
3afef5d29f
fix: PolygonRef::simplify early catch for duplicate points in polygons (CURA-1966)
2016-08-10 12:01:48 +02:00
Tim Kuipers
056240d55c
fix: PolygonRef::simplify prev wasn't recorded correctly (CURA-1966)
2016-08-10 11:59:28 +02:00
Tim Kuipers
10b43fc9f8
lil: AABB for single polygon (CURA-1966)
2016-08-10 11:37:44 +02:00
Tim Kuipers
f83fbfe143
fix: PolygonRef::simplify only removes verts if BOTH line segments are too small now (CURA-1966)
2016-08-09 17:46:10 +02:00
Thomas Karl Pietrowski
bcfe400c18
Correcting formatting
2016-08-09 17:38:37 +02:00
Tim Kuipers
b67b51ce76
fix: overhauled PolygonRef::simplify (CURA-1966)
...
polygons would be simplified such that previously removed points violated the allowed error constraint further on in the algorithm
2016-08-09 17:37:10 +02:00
Tim Kuipers
83aeb36bcf
feat: ListPolyIt convert functions for single (list)polygon (CURA-1966)
2016-08-09 17:34:00 +02:00
Thomas Karl Pietrowski
e75cdf3f7c
Removing hack for skipping build of protobuf using gtest
...
Can't find anything except of gmock in https://github.com/google/protobuf/blob/e8ae137c96444ea313485ed1118c5e43b2099cf1/autogen.sh that mentions gtest.
For about a year gmock has been moved to gtest, but 3.0.0 is still using gmock from it's old repository.
Additionally as the lines mentioned don't fit to the content of automake.sh, I just removed this part.
2016-08-09 17:21:21 +02:00
Thomas Karl Pietrowski
ecd11212f4
Referencing to download page
2016-08-09 17:14:07 +02:00
Thomas Karl Pietrowski
5763b1704f
Update README.md
2016-08-09 17:01:51 +02:00
Jack Ha
f14d67934d
Added some mock locals functions in runtests. CURA-1828.
2016-08-09 15:28:57 +02:00
Tim Kuipers
9ef35e2b14
copied ListPolyIt from bugfix_overlap_compensation branch (CURA-1966)
2016-08-09 14:18:34 +02:00
Tim Kuipers
fadfaa5a80
removed debug code (CURA-1956)
2016-08-09 11:42:17 +02:00
Tim Kuipers
fc962709b0
fix: clipper offset bug testing (CURA-1956)
2016-08-09 11:16:48 +02:00
Tim Kuipers
a848b8c71d
fix: UPDATE CLIPPER (CURA-1956)
...
this was loooooooong overdue
2016-08-09 11:15:35 +02:00
Tim Kuipers
dc05c2749a
feat: write max z feedrate when overriden by user value (CURA-1049)
2016-08-08 17:01:48 +02:00
Tim Kuipers
cea312a23a
rename: zPos ==> current_layer_z (CURA-1049)
2016-08-08 14:52:14 +02:00
Tim Kuipers
deee23d1f8
fix: generate support interface correctly also inside a model (CURA-2074)
2016-08-08 13:48:54 +02:00
Tim Kuipers
d097cfa78f
rename: generateSupportRoofs ==> generateSupportInterface (CURA-2074)
2016-08-08 13:38:45 +02:00
Tim Kuipers
09c1df7ea6
Merge branch 'markwal-mergeinfillchanges'
2016-08-08 09:53:39 +02:00
Mark Walker
7f9e034dbb
Propagate rename pressure->flow all the way down
2016-08-04 11:14:56 -07:00
Mark Walker
05b5a0b45c
Rename pressure to flow and make it per extruder
2016-08-04 10:46:25 -07:00
Mark Walker
ca1a076db3
nozzle_size doesn't change in the loop
2016-08-04 10:31:59 -07:00
Mark Walker
36c2bd81d0
Add setting to control autospeed for mergeinfill
...
Also:
- use travel speed for travel moves and extrusion speeds for
extrusion moves
- get the nozzle size from settings
2016-08-04 10:31:59 -07:00
Tim Kuipers
d44c8eb067
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-08-04 12:02:44 +02:00
Tim Kuipers
2b81ce1dd5
fix: don't switch to adhesion extruder for skirt when printing raft (CURA-2013)
2016-08-04 12:02:29 +02:00
Tim Kuipers
73df32881a
fix: support bottoms now don't check below zero any more (CURA-1013)
...
taking the max of unsigned int zero and another has no use!
The other value probably wrapped around to unsigned int max_value already
2016-08-02 12:45:05 +02:00
Tim Kuipers
01357eacc4
Merge branch 'master' into feature_support_bottoms
2016-08-02 12:40:05 +02:00
Ghostkeeper
fc7c55768a
Don't apply first layer speeds on raft layers
...
This only applied to travel speeds, since raft print speeds are determined by other settings, support is not on the raft layers, and meshes are not on the raft layers.
Contributes to issue CURA-1507.
2016-08-01 13:41:36 +02:00
Ghostkeeper
fea300cfc3
Remove unnecessary static cast from int to int
...
It's already an int.
Contributes to issue CURA-1507.
2016-08-01 13:30:46 +02:00
Arjen Hiemstra
4f4a5dd1e7
Merge branch 'feature_support_settings_from_support_extruder'
...
* feature_support_settings_from_support_extruder:
Remove debug statement
Set settingInheritBase on every mesh in the meshgroup
Be more robust against wrong input from Arcus
Distribute global_inherits_stack across meshgroups
Register SettingExtruder message type
Sync from frontend: global_inherits_stack message
feat: setting retrieval inheritance overrides (CURA-1953)
2016-08-01 13:01:18 +02:00
Ghostkeeper
02fe987035
Remove debug statement
...
Oops. Sorry.
Contributes to issue CURA-2011.
2016-08-01 12:08:46 +02:00
Ghostkeeper
9e7b6212b0
Set settingInheritBase on every mesh in the meshgroup
...
Also changed the nesting of the for loops around to make it a bit more efficient.
Contributes to issue CURA-2011.
2016-08-01 11:41:44 +02:00
Ghostkeeper
94a3a6b642
Abort thread after it has completed
...
Otherwise it stays sleeping for 60s. This produced too many threads on OSX.
Contributes to issue CURA-1828.
2016-08-01 11:10:27 +02:00
Tim Kuipers
d7eef238ce
cleanup: removed dead code (CURA-1647)
2016-07-31 22:12:01 +02:00
Tim Kuipers
3cbfe3b037
fix: retract after each meshgroup (CURA-1829)
...
also fixes (CURA-1379)
2016-07-31 19:07:55 +02:00
Ghostkeeper
9b8917e763
Be more robust against wrong input from Arcus
...
A simple range check against the extruder list.
Contributes to issues CURA-2011 and CURA-1953.
2016-07-29 17:38:00 +02:00
Ghostkeeper
a5b7b474a6
Distribute global_inherits_stack across meshgroups
...
Every meshgroup gets the same global_inherits_stack values.
Contributes to issues CURA-2011 and CURA-1953.
2016-07-29 17:18:47 +02:00
Ghostkeeper
839fc30c91
Register SettingExtruder message type
...
So that we can read it.
Contributes to issue CURA-2011.
2016-07-29 16:29:15 +02:00
Ghostkeeper
b8a6888d94
Sync from frontend: global_inherits_stack message
...
The front-end added the global_inherits_stack SettingExtruder message. We should add it too to be able to read the message. This is a copy from the same file in Cura's front-end.
Contributes to issue CURA-2011.
2016-07-29 16:25:59 +02:00
Jaime van Kessel
14cb8eeabd
Removed anciend debug output
...
This statement of a time before time slowed down the frontend.
2016-07-29 16:17:06 +02:00
Tim Kuipers
f9f79fa0e8
fix: only generate skirt polygons for used extruders (CURA-1647)
...
also cleaned up generateSkirtBrim a bit
also applied code conventions
inadvertently also causes support not to be removed by unprinted skirt
removed skirts_or_brims which didn't need to be a vector (only last elem was used)
2016-07-28 23:20:34 +02:00
Tim Kuipers
691efb3b6e
feat: ExtruderTrain::is_used (CURA-1647)
2016-07-28 22:58:45 +02:00
Tim Kuipers
93be9431b7
fix: brim removed support rather than going around it (CURA-1647)
2016-07-28 21:29:46 +02:00
Ghostkeeper
6c757f3fcf
Rename draft_shield_height to draft_shield_layers
...
This was considered better.
Contributes to issue CURA-1295.
2016-07-28 20:06:35 +02:00
Tim Kuipers
ae66df7b0a
Merge branch 'master' into feature_first_layer_travel_speed
2016-07-28 16:48:48 +02:00
Tim Kuipers
d447d9d711
fix: process brim for each meshgroup again (CURA-1721)
2016-07-28 14:22:57 +02:00
Tim Kuipers
b30f1c1a2e
secret fix: change gcode type comment back to SKIRT
2016-07-28 14:16:08 +02:00
Tim Kuipers
2ff1c876b3
secret fix: change gcode type comment back to SKIRT
2016-07-28 14:14:02 +02:00
Tim Kuipers
6db1097faa
API change: support_roof_... ==> support_interface... (CURA-1013)
2016-07-28 14:05:28 +02:00
Tim Kuipers
86cbe1797b
Merge branch 'master' into feature_support_bottoms
2016-07-28 13:53:47 +02:00
Tim Kuipers
65f0ba9673
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-28 13:52:25 +02:00
Tim Kuipers
7d6df9746e
fix: always generate skin when layer number is almost at top (CURA-1837)
...
dont try to compare with non-existent layer number which is too high
2016-07-28 13:52:18 +02:00
Ghostkeeper
2d2196648f
Make draft shield limit work with small models
...
Problem was that the draft shield height limit was measured in number of layers, but it was compared with the height of the first layer to determine if we should skip adding draft shield layers, and the first layer height was measured in microns.
Contributes to issue CURA-1295.
2016-07-28 13:45:18 +02:00
Ghostkeeper
6992bb6e03
Code style: Indentation and brackets
...
Contributes to issue CURA-1509.
2016-07-28 11:44:49 +02:00
Tim Kuipers
dee2f82d87
Merge pull request #374 from Ultimaker/bugfix_slicer_initializer
...
Properly initialize member variables of classes in slicer.h
2016-07-28 10:54:15 +02:00
Tim Kuipers
bec685e004
fix: initialize slicer members to invalid values
2016-07-28 10:51:19 +02:00
Tim Kuipers
d38ccb7691
fix: changed round_divide to work with unsigned ints (CURA-1013)
...
the math was wrong for negative numbers
2016-07-27 18:31:22 +02:00
Tim Kuipers
e5036763fe
fix: round support z distance up (CURA-1013)
2016-07-27 18:26:04 +02:00
Ghostkeeper
865f97c5d7
Repair draft shield height limitation part 2
...
Renamed DraftShieldLimitation to DraftShieldHeightLimitation. Also applied the limit to FffGcodeWriter and made the draft shield function more logical and make it only check for the limit if the draft shield height is limited.
Contributes to issue CURA-1295.
2016-07-27 17:48:53 +02:00
Ghostkeeper
0b4b04f31a
Don't generate skirt if draft shield is full
...
If draft shield limitation is set to full but the height is set to 0, don't generate a skirt.
Contributes to issue CURA-1295.
2016-07-27 17:48:53 +02:00
Ghostkeeper
39fea42b92
Fix draft shield limitation setting
...
The engine now listens to the draft shield limitation. If it's set to full, we use the full height of the print to limit the draft shield rather than the height limit setting.
Contributes to issue CURA-1295.
2016-07-27 17:48:53 +02:00
Ghostkeeper
f810356bdb
Add draft shield height limitation enum
...
This enum will be needed to determine what height we should use for the draft shield.
Contributes to issue CURA-1278.
2016-07-27 17:48:53 +02:00
Ghostkeeper
4c41acd946
Re-enable skirt if draft shield disabled but height is not 0
...
It used to only look at the height.
Contributes to issue CURA-1295.
2016-07-27 17:48:52 +02:00
Ghostkeeper
af135fff49
Take draft shield height of 0 if draft shield is disabled
...
This fixes the boolean setting again.
Contributes to issue CURA-1295.
2016-07-27 17:48:52 +02:00
Tim Kuipers
ed4457a3f4
Merge branch 'master' into feature_support_bottoms
2016-07-27 17:40:11 +02:00
Tim Kuipers
7ea9b14a33
fix: retrieve globalish support settings from support extruder (CURA-2003)
2016-07-27 17:10:07 +02:00
Tim Kuipers
957c56c6b2
feat: setting retrieval inheritance overrides (CURA-1953)
2016-07-27 16:28:11 +02:00
Arjen Hiemstra
0a689a0da8
Properly initialize member variables of classes in slicer.h
...
I get crashes because SlicerSegment::endVertex is used uninitialized.
2016-07-27 15:36:58 +02:00
Ghostkeeper
39efcf5680
Add more asserts for isOutsideTest
...
This also tests other cases where the point happens to be on other edge cases for other sides of the triangle.
Contributes to issue CURA-1981.
2016-07-27 15:25:37 +02:00
Ghostkeeper
0bc373e935
Remove whitespace at end of line
...
As per our code style rules.
Contributes to issue CURA-1981.
2016-07-27 15:19:31 +02:00
Ghostkeeper
0c82c00e15
Improve documentation for generateSkirtBrim
...
Contributes to issue CURA-1678.
2016-07-27 11:56:56 +02:00
Tim Kuipers
1859de69d4
fix: round support_z_distance to nearest layer_height multiple, rather than always rounding up (CURA-1013)
...
this caused the number of roof/bottom layers to be incorrect (CURA-647)
2016-07-27 11:37:46 +02:00
Tim Kuipers
e2fc79889b
fix rename: .._support_skin options back to .._support_roof (CURA-1013)
...
We shouldn't change the interface so easily. This makes the json as it was a couple of ocmmits ago
2016-07-27 11:22:42 +02:00
Ghostkeeper
b31646f10d
Improve documentation of completeConfigs
...
Contributes to issue CURA-1507.
2016-07-27 11:18:39 +02:00
Tim Kuipers
10a8265674
Merge branch 'master' into feature_support_bottoms
2016-07-27 11:15:15 +02:00
Tim Kuipers
1445472530
fix: use round_divide where neccesary (CURA-1013)
2016-07-27 11:11:22 +02:00
Tim Kuipers
37f7e18269
fix: inline function definition in header (CURA-1013)
...
inline functions must always be defined in the header
2016-07-27 11:10:42 +02:00
Simon Edwards
a854dc692d
Added a lot more logging which kicks in when the -vv flag is given.
...
Contributes to CURA-1509 Cura in slicing loop, Arcus Error (8)
2016-07-27 11:00:28 +02:00
Tim Kuipers
9cbecf5782
fix: z_distance_top/bottom was computed in micron rather than in layers (CURA-1013)
2016-07-27 10:56:26 +02:00
Tim Kuipers
b5575093d0
replace square function by math::square (CURA-1013)
2016-07-27 10:52:51 +02:00
Tim Kuipers
368747b213
feat: math file (CURA-1013)
...
for simple mathematical constructs
2016-07-27 10:52:05 +02:00
Tim Kuipers
64d3ee9728
rename: support_skin_.. options back to support_roof_... (CURA-1013)
...
We shouldn't change the interface so easily. This makes the json as it was a couple of ocmmits ago
2016-07-27 10:17:29 +02:00
Tim Kuipers
0ba0188bcd
rename: support roof ==> support skin (CURA-1013)
...
the areas now include both roofs and skins
2016-07-26 18:44:40 +02:00
Tim Kuipers
b8691c776e
fix: (un)signed int syntax mistake (CUTA-1013)
2016-07-26 18:31:41 +02:00
Tim Kuipers
afde126052
refactor: roofs ==> interface (CURA-1013)
...
the support interface contains areas which are roof and/or bottom
2016-07-26 18:31:14 +02:00
Tim Kuipers
5c22649d7b
feat: support bottoms; bugfix: support roof height (CURA-647, CURA-1013)
2016-07-26 18:24:18 +02:00
Tim Kuipers
1e0f2ec7c1
lil refactor: switched two lines (CURA-1972)
2016-07-26 17:20:52 +02:00
Tim Kuipers
c0d59627eb
removed debug.h
...
I didn't really know how to write c++ at the time and it only gave difficult to solve problems up till now
(CURA-1792)
2016-07-26 15:58:25 +02:00
Tim Kuipers
836686b90c
Merge branch 'slicer-speedup-clean' of https://github.com/scottlenser/CuraEngine
2016-07-26 12:48:21 +02:00
Tim Kuipers
4d7dd3adce
fix: reflection graph improvements
2016-07-26 12:45:07 +02:00
Tim Kuipers
14013e657a
removed dead code
...
code was probably used in the past to send layer data in a premature stage
2016-07-26 12:44:48 +02:00
Tim Kuipers
2a1cb236c8
reflection feat: visualize global-only mode
2016-07-26 11:47:07 +02:00
Tim Kuipers
0d17a056a2
lil reflection script fix
2016-07-26 11:22:34 +02:00
Tim Kuipers
722456ba64
lil fix: try-catch for debug code to find clipper bug
2016-07-26 10:29:35 +02:00
Scott Lenser
ce1fe33b2e
Slicer: Added better documentation on SlicerLayer::Terminus::Index.
2016-07-25 21:40:42 -04:00
Tim Kuipers
df3c77d0ce
code conventions for commandSocket (CURA-1272)
2016-07-25 17:43:03 +02:00
Tim Kuipers
39e1c5ffd9
fix: set command socket current location when starting printing a meshgroup (CURA-1272)
2016-07-25 17:34:06 +02:00
Tim Kuipers
af31f141d8
Merge branch 'layerview_dev' of https://github.com/Johan3DV/CuraEngine into Johan3DV-layerview_dev
2016-07-25 15:53:33 +02:00
Tim Kuipers
5d7687228c
test: isinside (CURA-1981)
2016-07-25 11:41:50 +02:00
Tim Kuipers
ffb4cdaacd
refactor: split off PolygonTest from PolygonUtilsTest (CURA-1981)
2016-07-25 11:35:29 +02:00
Scott Lenser
ce10cdecc7
Moved some reference symbols in Slicer to match convention.
2016-07-22 17:53:03 -04:00
Scott Lenser
d7806994be
Slicer: renamed StitchGridValPointAccess to StitchGridValLocator.
2016-07-22 17:49:32 -04:00
Scott Lenser
6d5762bc59
Slicer: Fixed bug where polylines stitching wouldn't consider joining at start points.
2016-07-22 17:48:12 -04:00
Scott Lenser
f96f189d0a
Slicer: Improved case when joining polylines via start points.
2016-07-22 17:34:03 -04:00
Scott Lenser
d9605a4a53
Slicer: Moved code out of if/else that was common to both cases.
2016-07-22 17:31:46 -04:00
Scott Lenser
0238d1822c
Slicer: Comment and formatting improvements.
2016-07-22 17:30:42 -04:00
Scott Lenser
d1f38c2be0
Slicer: Documented newer private functions in SlicerLayer.
2016-07-22 16:45:47 -04:00
Scott Lenser
0df427bc7a
Slicer: Moved terminus tracking logic into a class.
2016-07-22 15:42:41 -04:00
Scott Lenser
6328aa7210
Slicer: Moved more of connectOpenPolylinesImpl into private functions.
2016-07-22 14:53:54 -04:00
Scott Lenser
2d761096b8
Spacing changes in slicer.
2016-07-22 14:37:12 -04:00
Scott Lenser
1a8b4c6655
Slicer: split off part of connectPolylinesImpl into new function.
...
Split off the finding possible stitches part into a new private function.
2016-07-22 14:33:55 -04:00
Scott Lenser
cdb451b679
Slicer: Moved Terminus and PossibleStitch classes into SlicerLayer.
...
This moves them from the SlicerLayer::connectPolylinesImpl() function
to the SlicerLayer class. This results in the declaration movign to
the header file.
2016-07-22 14:24:33 -04:00
Scott Lenser
7aa157c955
Slicer: Made terminus into a class.
...
This hides the implementation of a polyline index and a flag as an
unsigned int. This also makes some of the uses more clear because
of the accessor function names.
2016-07-22 14:18:15 -04:00
Scott Lenser
52f71823f4
Removed trailing whitespace in slicer.
2016-07-22 13:31:46 -04:00
Scott Lenser
7522ca3ddc
SparseGrid: changed name of PointAccess to Locator.
2016-07-22 13:27:26 -04:00
Scott Lenser
b502a74a28
Slicer: switched storage for segments ending in vertex.
...
This switches the storage for segments ending in a vertex to a vertex *
instead of copying the connected faces of the vertex into a copy
of the vector.
2016-07-22 13:19:43 -04:00
Scott Lenser
3f131e40b9
Added spaces (especially around binary operators) in SparseGrid.
2016-07-22 13:10:09 -04:00
Scott Lenser
9b1a8fab73
Expanded doxygen function comment for SlicerLayer::connectOpenPolylinesImpl.
2016-07-22 12:44:04 -04:00
Scott Lenser
7e5538b65e
Improved variable name in slicer.
2016-07-22 12:35:08 -04:00
Scott Lenser
1f60e35bd2
Slicer: Fixed usage of INVALID_TERMINUS value not going through constant.
2016-07-22 12:30:48 -04:00
Scott Lenser
70b3da26b9
Simplified SparseGrid usage in pathOrderOptimizer.
...
Now using the getNearbyVals() API call which is what the function
really wanted.
2016-07-22 12:26:42 -04:00
Scott Lenser
ecdfbd89ed
Merge remote-tracking branch 'origin/master' into slicer-speedup-clean
2016-07-22 12:22:15 -04:00
Ghostkeeper
134e52b15f
Rename setting skirt_minimal_length to skirt_brim_minimal_length
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 17:03:21 +02:00
Ghostkeeper
5722a3e086
Rename setting skirt_line_width to skirt_brim_line_width
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:55:27 +02:00
Ghostkeeper
e6adbd2f1d
Rename jerk_skirt to jerk_skirt_brim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:52:24 +02:00
Ghostkeeper
533d00cc3a
Rename setting acceleration_skirt to acceleration_skirt_brim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:47:47 +02:00
Ghostkeeper
586e0031d5
Rename skirt_speed to skirt_brim_speed
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:46:44 +02:00
Ghostkeeper
3ab6beb239
Update documentation
...
Contributes to issue CURA-1678.
2016-07-22 16:35:17 +02:00
Ghostkeeper
1da383d0d0
Make count unsigned
...
It can't be negative anyway.
Contributes to issue CURA-1678.
2016-07-22 16:33:52 +02:00
Ghostkeeper
479742cea3
Rename skirt_primary_extruder to skirt_brim_primary_extruder in generateSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:32:42 +02:00
Ghostkeeper
e2c206e8ee
Rename skirtNr to skirt_brim_number in generateSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:30:40 +02:00
Ghostkeeper
f58c506c6a
Rename skirt_sent to skirt_brim_sent in processPlatformAdhesion
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:27:58 +02:00
Ghostkeeper
da2a329db4
Rename skirts to skirts_or_brims in generateSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:26:25 +02:00
Ghostkeeper
ecb7ba8904
Rename skirt_polygons to skirt_brim_polygons in generateSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:21:33 +02:00
Ghostkeeper
a84bb21d10
Rename skirt_polygons to skirt_brim_polygons in generateSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:20:43 +02:00
Ghostkeeper
d41c2c6ac2
Rename primary_extruder_skirt_line_width to primary_extruder_skirt_brim_line_width
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 16:18:57 +02:00
Ghostkeeper
73f9b09951
Change feature type comment in g-code SKIRT to SKIRTBRIM
...
Because it is used not only for skirt but also for brim. This essentially means an API break, though Cura doesn't rely on this. Printers should not rely on this as per the g-code spec. The only things that rely on this are the postprocessing scripts, but it should be a trivial change for them.
Contributes to issue CURA-1678.
2016-07-22 16:16:51 +02:00
Ghostkeeper
ac0b15eb93
Rename PrintFeature::Skirt to SkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:48:32 +02:00
Ghostkeeper
27ab0658df
Rename skirt.cpp/h to SkirtBrim.cpp/h
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:44:36 +02:00
Ghostkeeper
759eb0ab90
Rename generateSkirt to generateSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:40:35 +02:00
Ghostkeeper
2099302a3b
Update skirt/brim documentation
...
Contributes to issue CURA-1678.
2016-07-22 15:35:50 +02:00
Ghostkeeper
8365cb070d
Rename skirt_is_processed to skirt_brim_is_processed
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:32:02 +02:00
Ghostkeeper
4121b3da1e
Rename processSkirt to proceesSkirtBrim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:28:36 +02:00
Ghostkeeper
931df895c6
Rename skirt to skirt_brim in processSkirt
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:25:14 +02:00
Ghostkeeper
5b20d02c11
Rename SliceDataStorage::skirt to skirt_brim
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:18:47 +02:00
Ghostkeeper
a702fa711d
Rename initializeSkirtConfigs to initializeSkirtBrimConfigs
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:06:30 +02:00
Ghostkeeper
eeb741bfb6
Rename SliceDataStorage::skirt_config to skirt_brim_config
...
Because it concerns not only the skirt, but also the brim.
Contributes to issue CURA-1678.
2016-07-22 15:01:21 +02:00
Ghostkeeper
5942bb3d4c
Only generate support roof below mesh
...
Support roof takes quite a lot of time to print, so only generate it below the actual mesh, not where the support area is X/Y expanded or where multiple pieces of support are joined and such.
Contributes to issue CURA-647.
2016-07-22 14:40:20 +02:00
Ghostkeeper
dd3007a61e
Load support roof height and layer height from mesh
...
Don't have to pass it through via parameters.
Contributes to issue CURA-647.
2016-07-22 14:23:37 +02:00
Ghostkeeper
0e0119a3e6
Make parameters const and unsigned
...
Negative is not possible anyway. And these are not changed.
Contributes to issue CURA-647.
2016-07-22 13:49:43 +02:00
Ghostkeeper
ef38ed3688
Rename variables according to code style
...
We use lowercase with underscores.
Contributes to issue CURA-647.
2016-07-22 13:47:17 +02:00
Ghostkeeper
142464ebeb
Round support Z-distance up instead of down
...
The z-distance is rounded to the next layer. This guarantees that there is at least the specified Z-distance.
Contributes to issue CURA-1283.
2016-07-22 13:31:26 +02:00
Ghostkeeper
1d54240c32
Make retraction config take extruder of current plan
...
Rather than taking the extruder of the current g-code, which is for an entire layer, take the retraction settings of the current extruder plan. This allows for different retraction settings on the same layer rather than just taking the retraction settings that layer begins with.
Contributes to issue CURA-1972.
2016-07-22 11:52:07 +02:00
Johan K
25384faeed
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine into layerview_dev
2016-07-22 10:36:34 +02:00
Johan K
610685e13b
Removing layer_nr argument from CommandSocket::send* functions.
2016-07-22 03:08:59 +02:00
Johan K
ae59b2b8d8
Clean up the interface functions for sending data to the layer view in GUI.
...
Functions are now static and internally check in the command socket is instansiated to make the using code cleaner.
The sendLine function has been renamed to sendLineTo and only take the destination point to match how data is used and written to gcode.
CURA-1272
2016-07-22 02:29:42 +02:00
Ghostkeeper
fe184f9177
Always make tests select from arrays
...
In some cases it was selecting characters from a string and passed those as a string. That's wrong!
Contributes to issue CURA-1758.
2016-07-21 18:27:49 +02:00
Ghostkeeper
bce51f4807
Add setting types polygon and polygons
...
It just evaluates the default. It doesn't try to edit these.
Contributes to issue CURA-1758.
2016-07-21 18:27:49 +02:00
Ghostkeeper
e371c43395
Don't evaluate default_value as fallback
...
Just take the value itself without evaluating it. Otherwise enum values accidentally get evaluated as a variable.
Contributes to issue CURA-1758.
2016-07-21 18:27:49 +02:00
Ghostkeeper
b3f80cec83
Repair evaluation functions
...
The names of these properties have changed a bit. Also, we're now getting the normal value first and defaulting back to default_value if there is no inheritance functions.
Contributes to issue CURA-1758.
2016-07-21 18:27:49 +02:00
Ghostkeeper
e34f2ffc67
Remove commented code
...
Contributes to issue CURA-1758.
2016-07-21 18:27:49 +02:00
Ghostkeeper
0f0bd3c32c
Remove redundant parentheses
...
As per the code style.
Contributes to issue CURA-1758.
2016-07-21 18:27:49 +02:00
Tim Kuipers
71beb1cc98
fix: no support for infill meshes (CURA-833)
2016-07-21 15:45:07 +02:00
Tim Kuipers
bc56e73e36
Merge branch 'feature_remove_extruder_width'
2016-07-21 15:32:40 +02:00
Ghostkeeper
ea364c4cd8
Obtain combined infill line width per layer
...
If the line width is different per combined layer this would get the correct one, and it is also more robust if there are 0 layers in the vector.
Contributes to issue CURA-736.
2016-07-21 13:54:01 +02:00
Ghostkeeper
d581957308
Rename primary_skirt_line_width to primary_extruder_skirt_line_width
...
This was deemed better by the reviewer.
Contributes to issue CURA-736.
2016-07-21 13:36:25 +02:00
Ghostkeeper
11c611c9e4
Restore support for negative conical support angles
...
Negative conical support angles are also allowed. Only when the support angle is exactly zero, it is nonsensical to generate conical support.
Contributes to issue CURA-736.
2016-07-21 13:32:23 +02:00
Tim Kuipers
5ab937ba03
indent fix only (CURA-833)
...
only indentation and a lot of bs diff
2016-07-21 11:27:06 +02:00
Tim Kuipers
aa5c9d37fd
fix: command line slicing was broken (CURA-833)
2016-07-21 11:26:19 +02:00
Tim Kuipers
9de3edee39
debug fix: better debug output of clipper bug
2016-07-21 11:10:43 +02:00
Ghostkeeper
21fa313feb
Move support line width into detect overhang points
...
It's the only place where it's used. This makes the stack trace slimmer, potentially making the program faster. Also, it moves the dependency on the setting closer to where the setting is used.
Contributes to issue CURA-736.
2016-07-21 09:31:00 +02:00
Ghostkeeper
6fb61a3c79
Make a few settings const
...
While we're at it...
Contributes to issue CURA-736.
2016-07-21 09:24:57 +02:00
Ghostkeeper
bc2efcfc39
Rename extrusionWidth to line_width
...
This line width is the width of the lines in the wireframe mode.
Contributes to issue CURA-736.
2016-07-21 09:19:59 +02:00
Ghostkeeper
cb40a72eda
Rename extrusionWidth to line_width
...
This is the width of all wireframe lines.
Contributes to issue CURA-736.
2016-07-20 17:14:26 +02:00
Ghostkeeper
096e8f7675
Remove old code
...
This prime tower is long unused. The queue import also seems to be unused, since compiling gives no error and a CTRL+F has no results either.
Contributes to issue CURA-736.
2016-07-20 17:10:17 +02:00
Ghostkeeper
87e02722e7
Rename primary_extrusion_width to primary_skirt_line_width
...
Sometimes it is the brim line width. But this convention is held elsewhere throughout the code too.
Contributes to issue CURA-736.
2016-07-20 17:07:24 +02:00
Ghostkeeper
d15387905b
Rename innermost_wall_extrusion_width to innermost_wall_line_width
...
Neighbouring variables are also renamed, such as extrusionWidth that was actually the wall line width.
Contributes to issue CURA-736.
2016-07-20 16:58:50 +02:00
Ghostkeeper
5280c9df10
Correct skin-wall to skin overlap
...
The skin-wall now has the line width of the inner walls.
Contributes to issue CURA-736.
2016-07-20 16:28:13 +02:00
Ghostkeeper
021c7ac0bf
Use inner wall config to extrude skin border lines
...
This makes the line width with which we're extruding equal to the line width with which we did the insets for these lines.
Contributes to issue CURA-736.
2016-07-20 16:25:00 +02:00
Ghostkeeper
3825e200a6
Make skin insets use inner wall line width
...
We deemed that the inner wall line width is more akin to the line width you're seeking for the border line of skins, which attaches slin lines that end on the border with infill. More akin than skin line width anyway.
Contributes to issue CURA-736.
2016-07-20 15:39:22 +02:00
Ghostkeeper
6022e44dee
Rename extrusion_width to support_line_width
...
Also made it const.
Contributes to issue CURA-736.
2016-07-20 15:11:51 +02:00
Ghostkeeper
b0054e1b39
Move getting skin line width into skin generator
...
This makes the stack lighter, because the context switch to the functions doesn't need to copy the value over to the stack. Also removes the reference to old terminology: extrusion_width, and makes the variable const.
Contributes to issue CURA-736.
2016-07-20 15:09:51 +02:00
Ghostkeeper
7a1ee0429e
Move getting infill line width into infill functions
...
This makes the stack lighter, because the context switch to the functions doesn't need to copy the value over to the stack. The local variable can be an order of magnitude faster even though it needs to look-up the value from the mesh one additional time. Also removes the reference to old terminology: extrusion_width, and makes the variable const.
Contributes to issue CURA-736.
2016-07-20 15:03:05 +02:00
Johan K
fddaa58d67
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine into layerview_dev
2016-07-20 14:49:24 +02:00
Ghostkeeper
0ff87b785f
Split speed_layer_0 into two settings
...
There are now distinct settings for speed_print_layer_0 (the extrusion moves) and speed_travel_layer_0 (the non-extrusion moves).
Contributes to issue CURA-1507.
2016-07-20 10:54:55 +02:00
Ghostkeeper
71df0e2586
Initial layer travel speed uses initial layer config
...
It uses the same gradient as the rest of the speeds. This is per extruder though.
Contributes to issue CURA-1507.
2016-07-19 14:49:00 +02:00
Ghostkeeper
53c8cc5e78
Document initialLayersSetup()
...
Better structured, really.
Contributes to issue CURA-1507.
2016-07-19 14:41:00 +02:00
Tim Kuipers
aa87a720c0
refactor: code conventions (CURA-1856)
2016-07-19 13:42:25 +02:00
Tim Kuipers
6e171f795c
Merge branch 'scottlenser-add-convex-hull'
2016-07-19 13:32:22 +02:00
Tim Kuipers
e76cda3ea8
Merge branch 'add-convex-hull' of https://github.com/scottlenser/CuraEngine into scottlenser-add-convex-hull
2016-07-19 13:23:58 +02:00
Ghostkeeper
8794688c48
Merge branch 'feature_tetrahedral_infill'
2016-07-19 09:28:25 +02:00
Tim Kuipers
957c82715d
fix: use print_layer_count everywhere after infill meshes have been generated/confined (CURA-833)
2016-07-18 18:06:37 +02:00
Tim Kuipers
c0813b2c77
fix: send layer info after processing infill meshes (CURA-833)
2016-07-18 18:04:28 +02:00
Tim Kuipers
3042483f73
update mesh.layer_nr_max_filled_layer during processing infill meshes (CURA-833)
2016-07-18 18:00:52 +02:00
Tim Kuipers
3abc718240
fix: reserve enough layers in the vector (speedup) (CURA-833)
2016-07-18 18:00:09 +02:00
Tim Kuipers
a52208b15e
refactor: rename layer_count ==> slice_layer_count because infill meshes may be sliced at layers which aren't printed (CURA-833)
2016-07-18 17:58:53 +02:00
Ghostkeeper
edd44de9e3
Spelling fixes
...
Contributes to issue CURA-1925.
2016-07-18 17:17:59 +02:00
Tim Kuipers
d4b1c70790
fix: limit infill meshes to the own infill area of other meshes rather than their basic infill area (CURA-833)
...
second order infill mehses could overlap with first order infill meshes before
2016-07-18 15:54:40 +02:00
Tim Kuipers
534e265fd2
refactor: factored out a new function getOwnInfillArea whic returns the infill_area_own or the infill_area (CURA-833)
2016-07-18 15:53:27 +02:00
Tim Kuipers
120de96bb5
fix: optional assignment used wrong constructor (CURA-833)
2016-07-18 14:47:13 +02:00
Tim Kuipers
a611739ff7
Merge branch 'master' into feature_gradual_infill
2016-07-18 12:20:16 +02:00
Tim Kuipers
791e436222
fix: only first infill mesh part got removed from infill of normal mesh (for gradual infill branch) (CURA-833)
2016-07-18 12:17:10 +02:00
Tim Kuipers
d16f52e776
fix: only first infill mehs part got removed from infill of normal mesh (CURA-833)
2016-07-18 12:14:45 +02:00
Tim Kuipers
a99020e995
Merge branch 'master' into feature_gradual_infill
2016-07-18 11:57:50 +02:00
Tim Kuipers
5237b1bb01
fix: made raft top layers into zigzag (CURA-1637)
...
previous commit was actually for the middle layers instead of the top layers
2016-07-15 15:34:25 +02:00
Tim Kuipers
7e0d44cfcb
fix: combing thought it was never inside when printing the raft (CURA-1637)
2016-07-15 15:31:11 +02:00
Tim Kuipers
453b3ebbc5
fix: made raft top layers into zigzag (CURA-1637)
2016-07-15 15:10:07 +02:00
Tim Kuipers
473b925814
feat/fix: changed mat GUID to string and retrieve it from settings (CURA-1836)
2016-07-15 14:27:57 +02:00
Tim Kuipers
4199fcf8ac
feat/fix: changed mat GUID to string and retrieve it from settings (CURA-1836)
2016-07-15 14:27:24 +02:00
Tim Kuipers
203f04571c
fix: delete instance when de-assigning an optional value (CURA-836)
2016-07-15 13:45:45 +02:00
Tim Kuipers
186472c26e
feat: tetrahedral infill (CURA-1925)
2016-07-15 12:35:48 +02:00
Tim Kuipers
dc2b505274
fix: combination of gradual infill and infill mehses didn't work (CURA-836)
...
The part.infill_area should remain the whole initial infill area for combing
During the generation of the part.infill_area_per_combine_per_density it refered to part.infill_area, rather than the infill-mesh-limited infill
I had to introduce an intermediate result - part.infill_area_own - which records the area where that mesh should print its infill pattern
In case there are no infill meshes the part.infill_area_own remains a nullptr, so that we don't waste resources.
After it's used and incorporated into infill_area_per_combine_per_density, its destroyed.
2016-07-14 17:57:16 +02:00
Tim Kuipers
9adc0a128c
fix: optional::operator=(nullptr) didn't work (CURA-836)
2016-07-14 17:51:12 +02:00
Tim Kuipers
e6a5eccf03
Merge branch 'master' into feature_gradual_infill
2016-07-14 16:29:28 +02:00
Johan K
71ea91b61b
Implement adding extruder number to path compiler
2016-07-14 12:13:14 +02:00
Tim Kuipers
00d6a55836
lil: less whitespace at end of lines
2016-07-14 12:12:25 +02:00
Tim Kuipers
4308c74451
fix: multiVolumesOverlap failed when two meshes are directly adjacent in the X direction (CURA-833)
...
when there was no X which covered both models
2016-07-14 12:05:17 +02:00
Tim Kuipers
757df8c7c8
fix: let combing not see infill meshes (CURA-833)
2016-07-14 11:39:38 +02:00
Tim Kuipers
ff5cc9399d
refactor: lil rename (CURA-833)
2016-07-14 11:35:46 +02:00
Johan K
ddf7bbe06e
Changed the data type of the layer visualization data from int64 to float.
...
Also added extruder number and point dimensionality to the message.
2016-07-14 11:00:39 +02:00
Tim Kuipers
e34608442a
doc: processInfillMesh (CURA-833)
2016-07-14 10:50:37 +02:00
Tim Kuipers
c0446f81e0
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-13 17:30:13 +02:00
Ghostkeeper
27ac98caa5
Code style: Whitespace around binary operators
...
Contributes to issue CURA-833.
2016-07-13 15:47:37 +02:00
Ghostkeeper
ebcfad8200
Codestyle: Whitespace around binary operators
...
Contributes to issue CURA-833.
2016-07-13 15:45:52 +02:00
Ghostkeeper
69665a0d4a
Codestyle: Space after comma and no whitespace at end of line
...
Contributes to issue CURA-833.
2016-07-13 15:13:21 +02:00
Johan K
a50d6fe5a9
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine into layerview_dev
2016-07-13 14:52:11 +02:00
Ghostkeeper
bed556a5e6
Codestyle: Brackets after if-statements
...
Instead of making new brackets after every if-statement, I opted for making it into or-clauses.
Contributes to issue CURA-833.
2016-07-13 14:48:53 +02:00
Tim Kuipers
a86c5b1105
doc: documented ExtruderPlan
2016-07-13 14:34:05 +02:00
Tim Kuipers
3db1c2580f
Merge branch 'feature_gradual_infill' of github.com:Ultimaker/CuraEngine into feature_gradual_infill
2016-07-13 14:19:22 +02:00
Tim Kuipers
2925af497c
lil doc
2016-07-13 14:17:07 +02:00
Johan K
0bd5ae9e01
Added documentaion
...
More documentation for PathCompiler and SliceDataStruct.
2016-07-13 14:03:46 +02:00
Tim Kuipers
eff7f0e326
fix: always retract after priming (CURA-1816)
2016-07-13 11:09:12 +02:00
Scott Lenser
a6ad786443
Cleaned up size handling in convexHull.
2016-07-12 10:08:35 -04:00
Scott Lenser
ce85280971
Merge remote-tracking branch 'origin/master' into slicer-speedup-clean
2016-07-12 09:13:41 -04:00
Tim Kuipers
a7bc153db5
Merge branch 'feature_overhang_dropdown'
2016-07-12 11:25:20 +02:00
Tim Kuipers
3d98bb7e74
Merge branch 'feature_firmware_travel_settings'
2016-07-12 11:06:56 +02:00
Tim Kuipers
cc632cd201
Merge branch 'master' of github.com:Ultimaker/CuraEngine into feature_fan_control_per_extruder
2016-07-12 11:02:31 +02:00
Tim Kuipers
b0ee1ca57d
Merge branch 'scottlenser-slenser-cleanup-pr-A'
2016-07-12 10:35:10 +02:00
Tim Kuipers
e7992fc17a
fix: USE_CPU_TIME iff in debug mode (CURA-1856)
2016-07-12 10:28:02 +02:00
Tim Kuipers
3f2162d76c
doc: better documentation and function naming (CURA-1856)
2016-07-12 10:23:48 +02:00
Johan K
019116cd33
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine into layerview_dev
2016-07-12 01:03:19 +02:00
Johan K
b0f725c1e5
Added extruder nr to PathSegment definition in Cura.proto
2016-07-12 01:02:24 +02:00
Tim Kuipers
17c125d395
fixed header guard of WallsComputation
2016-07-11 22:29:17 +02:00
Tim Kuipers
d0d0532cb8
Merge branch 'slenser-cleanup-pr-A' of https://github.com/scottlenser/CuraEngine into scottlenser-slenser-cleanup-pr-A
2016-07-11 18:35:31 +02:00
Tim Kuipers
563be4980d
doc: visual explanation of gradual infill shift and line dist (CURA-836)
2016-07-11 18:10:29 +02:00
Tim Kuipers
4a91663bb4
fix: gradual infill steps are skipped through regularly now (CURA-836)
...
whenb computing gradual infill, we skip layersto compute which regions count as top. These skips are now such that
you end exactly one gradual infill step above.
2016-07-11 17:44:30 +02:00
Tim Kuipers
f486d6be6f
bugfix: sqrt doesn't return a constexpr (CURA-833)
2016-07-11 16:34:21 +02:00
Tim Kuipers
945711f10a
bugfix: sqrt doesn't return a constexpr (CURA-833)
2016-07-11 16:27:36 +02:00
Tim Kuipers
0ae670ce0c
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-11 16:16:07 +02:00
Tim Kuipers
2db4730f00
lil: removed done TODO CURA-833
2016-07-11 16:04:25 +02:00
Jaime van Kessel
09b36ecdd8
Merge branch 'feature_cubic_isometric_infill' of github.com:Ultimaker/CuraEngine
2016-07-11 14:41:08 +02:00
Tim Kuipers
5e83d4252d
fix: handle inactive temp of second nozzle on first layer (CURA-1508)
2016-07-11 13:37:08 +02:00
Tim Kuipers
a69270e212
fix/refactor: factored writePrimeTrain out of startExtruder so that we can enforce printing temperature before priming (CURA-1508)
2016-07-11 13:14:48 +02:00
Ghostkeeper
d197c7f3d7
Fix spelling in documentation
...
Contributes to issue CURA-836 and a few others probably.
2016-07-11 10:26:35 +02:00
Tim Kuipers
c82a8c5a47
fix: warning msg bug: was string instead of Cstring (CURA-1568)
2016-07-11 10:22:42 +02:00
Scott Lenser
288f053abd
Updated mentions of BucketGrid in comments to SparseGrid.
...
Some of the comments had mentions of BucketGrid were the code had
already been updated to change BucketGrid2D uses to SparseGrid.
I didn't notice them before because of the different spelling.
2016-07-09 12:48:13 -04:00
Scott Lenser
f73586190e
Fixed warning message about unused variable.
2016-07-08 19:53:03 -04:00
Scott Lenser
0fd0dd6869
Removed BucketGrid2D which has been replaced by SparseGrid.
2016-07-08 19:24:14 -04:00
Scott Lenser
dee0ae12d6
Converted polygonUtils to SparseGrid from BucketGrid2D.
...
This also converts Comb which relies on polygonUtils (Comb just stores
the type from polygonUtils).
2016-07-08 19:21:44 -04:00
Scott Lenser
c2571d41af
Converted pathOrderOptimizer to SparseGrid from BucketGrid2D.
2016-07-08 18:39:45 -04:00
Scott Lenser
c8fd58376b
Converted BucketGrid2D test to SparseGrid test.
2016-07-08 17:53:44 -04:00
Scott Lenser
bce0a8a3a8
Added parameters to SparseGrid constructor to allow more control of map.
...
This adds functionality that was present in BucketGrid2D's constructors.
2016-07-08 16:59:26 -04:00
Scott Lenser
25c2f7086d
Moved SparseGrid::processNearby into public interface.
2016-07-08 16:44:49 -04:00
Scott Lenser
941f4e3a66
Added getNearest() function to SparseGrid.
...
Refactored so that getNearest and getNearby can share a lot of the
implementation.
2016-07-08 16:42:15 -04:00
Scott Lenser
6d8d453df9
Added missing doxygen comment for SparseGrid.
2016-07-08 15:35:33 -04:00
Scott Lenser
90c212b52e
Split SparseGrid into an invasive and non-invasive version.
...
The invansive version requires that the stored type being able to
provide a Point location on demand. This is a general version in
case the type being stored already has a location in it. The
non-invasive version is more convenient if the type to be stored
does not already contain a Point location.
2016-07-08 15:32:32 -04:00
Scott Lenser
db79eb7ece
Added convexHull function for Polygons.
...
This renames the previous version which is an approximate convex hull
to approxConvexHull.
2016-07-08 13:29:50 -04:00
Scott Lenser
9afcbddf29
Added rounding to coordinates from slicing of mesh.
2016-07-08 13:26:21 -04:00
Scott Lenser
c4c221145e
More const correctness.
2016-07-08 13:24:56 -04:00
Scott Lenser
1956fc00d3
Added error message if inherited JSON file can't be found.
2016-07-08 13:16:56 -04:00
Scott Lenser
8ac6c3b597
Changed signature of Mesh::getFaceIdxWithPoints to avoid redundant calculation.
2016-07-08 13:16:00 -04:00
Scott Lenser
76b3c8757d
Fixed bug which sent multiple finished slice messages.
...
The slicing finished message is already sent in CommandSocket::connect().
This confused the GUI since it is only expecting 1 finished slice message.
2016-07-08 13:11:52 -04:00
Scott Lenser
c6b6688170
Added code to use cpu time instead of wall clock time for timings.
...
This is controlled by a #define on which timings to use.
2016-07-08 13:10:18 -04:00
Scott Lenser
d2c80127ef
Fixed bug in print out about number of layers.
2016-07-08 13:09:19 -04:00
Scott Lenser
3ada6f266c
Switched command_line_settings to version 2 from version 1.
2016-07-08 13:03:08 -04:00
Scott Lenser
4b5553019e
Fixed bug in bridge generation.
...
It was calculating the angle to use for infill but then not using it.
This makes it use the calculated angle. This makes the bridge
generation go from basically completely non-functional to just mostly
non-functional.
2016-07-08 12:59:41 -04:00
Scott Lenser
4fd499f7a1
Correctness improvements to SlicerLayer::makeBasicPolygonLoop.
...
From the slicing, we know which edge generated the end point of the
segment. We then know that the face that shares this edge is the only
candidate to have generated the next segment. This avoids checking
the other 2 segments.
Improved logic used in SlicerLayer::getNextSegmentIdx(). The previous
version only considered candidate faces for extending the current
polygon loop by looking at faces that shared an edge. This works for
many models, but if the slice height exactly intersects vertices of
the mesh, then the segment that would extend the loop is not typically
found. We know whether we hit a vertex with the slice from the
slicing calculation. There is a slight cost to checking for equality
to see if we hit a vertex. This can very slightly slow down normal
models but substantially increase speed on bad case models. This
extends the logic to use the faces connected to the vertex that the
segment ended on to try to extend the polygon loop. Theoretically,
this adds a slight performance penalty to makeBasicPolygonLoops when
vertices were hit by the slice. However, in very limited testing,
this extra time is not measurable. Adding this improved correctness
makes a big difference in the number of polygon loops successfully
constructed. In a bad case model, the number of polygons found
increased from 0 to 19 and the number of open polylines for the next
stage of processing went from 6357 to 0. This made the
connectOpenPolylines() go from taking .048 seconds to 0. The overall
effect on this model was to reduce the slicing time from 0.084 to 0.04
seconds (this is a small model for testing so total times are low).
2016-07-08 12:50:03 -04:00
Scott Lenser
28aedf57c5
Sped up SlicerLayer::connectOpenPolylines and SlicerLayer::stitch.
...
Added use of spatial data structure in SlicerLayer::stitch(). Added
SparseGrid spatial data structure. This is similar to BucketGrid2D
but a bit more general and without the possibility of duplication in
returned points. SparseGrid does not offer a findNearestObject
function like BucketGrid2D does, although one could be added if
desired.
Sped up SlicerLayer::stit() further by only finding nearby points
once. The possible stitch points are calculated once and remembered.
They are put into a priority queue. A bidirectional map (via vectors)
is used to keep track of the transforms that happen to the polygons to
map from the original polyline ends to the new polyline ends.
Combined stitch and connectOpenPolylines implementations.
connectOpenPolylines basically does the same thing as stitch except
has a smaller search radius and doesn't allow for inverting edges. I
expressed these as parameters to the stitch implementation and then
reused the implementation. It is now much faster.
connectOpenPolylines has gone from O(n^2) to O(n) and stitch has gone
from O(n^3) to O(n). connectOpenPolylines has also gotten more
correct. With the original version,if polys 0 -> 10 -> 5 formed a
chain, then 0 -> 10 would be merged into 0 but the 10 -> 5 would never
be used. 0 -> 10 would be merged into 0, but this new 0 would not be
considered for merging with 5 since 10 > 5. It also wouldn't be
considered for merging 10 with 5 because 10 has already been cleared
out.
2016-07-08 12:34:47 -04:00
Scott Lenser
28e6a54961
Added timer for time to load mesh.
2016-07-08 12:06:06 -04:00
Scott Lenser
b1b49f16e0
Added timers in slicer.
...
This gives the breakdown between intersecting planes with the model
and the conversion of the resulting segments into polygons.
2016-07-08 12:02:17 -04:00
Scott Lenser
6b72d52c65
Added new spatial data structure SparseGrid.
...
This class is intended to be used for speeding up fixed radius
nearby neighbor searches.
2016-07-08 11:48:41 -04:00
Scott Lenser
07d416691a
Add move version of adding Polygon to Polygons.
2016-07-08 11:43:15 -04:00
Scott Lenser
960c56a9fa
Added a convenience typedef for the type of a coordinate in a Point.
2016-07-08 11:33:44 -04:00
Scott Lenser
a18b05f347
Fix to make bridging work much better.
2016-07-08 14:22:45 +02:00
Tim Kuipers
4d46fbea8f
fix: conical overhang wouldn't do anything for an angle of zero (CURA-1412)
...
It should then drop any overhang down: \ becomes L
2016-07-08 00:00:48 +02:00
Tim Kuipers
5620abfd95
fix: make infill mesh AABB collision detection take into account horizontal expansion (CURA-833)
2016-07-07 22:17:41 +02:00
Tim Kuipers
3d307112de
fix: infill meshes couldn't handle zero infill meshes (CURA-833)
...
zero infill meshes didn't generate any infill areas, while infill mehses assumed there to be infill areas_per_combine
2016-07-07 22:07:39 +02:00
Tim Kuipers
2c5639097e
fix: got a warning about an uninitializes unused variable
2016-07-07 20:47:44 +02:00
Tim Kuipers
cbf5d962b7
fix: catch temp flow graph reading input errors (CURA-1792)
2016-07-07 20:42:18 +02:00
Tim Kuipers
744264481a
ignore callgrind files
2016-07-07 20:09:52 +02:00
Tim Kuipers
2cd22bdfd5
Merge branch 'master' into feature_fan_control_per_extruder
2016-07-07 17:33:35 +02:00
Tim Kuipers
c259d90def
fix: extruder switched to old extruder instead of new one (CURA-1816 and CURA-1508)
2016-07-07 17:33:21 +02:00
Tim Kuipers
a7b3d53872
Merge branch 'master' into feature_fan_control_per_extruder
2016-07-07 16:50:21 +02:00
Tim Kuipers
57219beb98
fix: nozzle switch was never written (CURA-1508 CURA-1816)
2016-07-07 16:49:31 +02:00
Tim Kuipers
8f0c3c9a49
Merge branch 'feature_fan_control_per_extruder' of github.com:Ultimaker/CuraEngine into feature_fan_control_per_extruder
2016-07-07 16:47:57 +02:00
Tim Kuipers
6adfdd7ad4
Merge branch 'master' into feature_fan_control_per_extruder
2016-07-07 16:42:44 +02:00
Tim Kuipers
59b516702e
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-07 15:19:08 +02:00
Tim Kuipers
78c155b1ab
fix: only perform prime gcode for griffin (CURA-1816 CURA-1508)
2016-07-07 15:18:25 +02:00
Tim Kuipers
f39a3e62e7
fix: only prime the initial extruder at the start of a print (CURA-1508)
2016-07-07 15:14:24 +02:00
Tim Kuipers
00bcbe7192
fix: get prime location from settings and use travel speed to get there when switching to a yet unused extruder (CURA-1816 and CURA-1508)
2016-07-07 15:13:37 +02:00
Tim Kuipers
ab850577b5
fix: initial planned extruder was always set to zero (CURA-1816)
2016-07-07 15:10:45 +02:00
Tim Kuipers
307551b1db
fix: skirt assumed extruder 0 for primary adhesion extruder rather than adhesion_extruder_nr (CURA-1816)
2016-07-07 13:33:25 +02:00
Tim Kuipers
9a09cdc18a
feat/refactor: factored out startExtruder from GCodeExport::switchExtruder (CURA-1816)
2016-07-07 13:25:28 +02:00
Tim Kuipers
dfcc993034
refactor: replaced old SliceDataStorage::getExtrudersUsed(.) with GcodeExport::getExtruderIsUsed (CURA-1816)
2016-07-07 13:24:10 +02:00
Ghostkeeper
65df6439fa
Codestyle: Spaces around operators
...
Contributes to issue CURA-1792.
2016-07-07 11:43:22 +02:00
Jaime van Kessel
43a51f5757
Changed extruder_nr to int (instead of uint)
...
CURA-1687
2016-07-06 15:31:38 +02:00
Tim Kuipers
96a2ac56c5
fix: don't give warnings for known parent settings (secretly on CURA-1792)
...
the frontend sends all known settings (and categories) via the command socket even though it should know which settings will be used by the engine.
This is because the json file is the interface ofthe engine and so the frontend sends everything in the interface.
2016-07-06 15:15:26 +02:00
Ghostkeeper
63cd06ca02
Fix typo
...
Contributes to issue CURA-1568.
2016-07-06 14:59:00 +02:00
Tim Kuipers
39da22630f
bugfix: PolygonUtils::findClose(... BucketGrid2D) return pointer to heap resulting in mem leaks (CURA-1792)
...
now solved with optional
2016-07-06 14:47:19 +02:00
Ghostkeeper
3528b9eca7
Remove TODO
...
We don't need to do this. Discussed with Tim and Paul.
Contributes to issue CURA-1568.
2016-07-06 14:42:33 +02:00
Tim Kuipers
8d7827aa87
fix: parsing of temp flow graph was buggy ==> rewrite (CURA-1792)
2016-07-06 14:35:38 +02:00
Tim Kuipers
c73084bbd1
fix: instantiate command socket after loading the json file (CURA-1792)|
2016-07-06 14:31:24 +02:00
Tim Kuipers
bf372cb3aa
fix: merge conflic resolution for fan speeds per extruder (CURA-1568)
...
The ExtruderPlan needed access to the retraction_config for that extruder
2016-07-05 17:44:04 +02:00
Tim Kuipers
0b8c30616a
Merge branch 'master' into feature_overhang_dropdown
2016-07-05 15:22:22 +02:00
Tim Kuipers
a7720bcfbf
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-04 17:20:14 +02:00
Tim Kuipers
bf19300def
fix: raft outline now uses rounded offset (CURA-1835)
2016-07-04 17:19:59 +02:00
Jaime van Kessel
9a34e09806
Only send material estimates for extruders a machine has.
...
CURA-1687
2016-07-04 16:51:43 +02:00
Jaime van Kessel
62a90f86c6
Merge branch 'master' of github.com:Ultimaker/CuraEngine into SendMaterialEstimatesOfBothExtrudersToFrontend
2016-07-04 16:17:47 +02:00
Tim Kuipers
f3b6042243
fix: fixing output stream precision when outputting to standard out
2016-07-04 13:54:48 +02:00
Tim Kuipers
795d68d142
fix runtest.py: new setting attributes after settings rework (CURA-1828)
2016-07-04 12:26:10 +02:00
Tim Kuipers
c8e9091764
Merge branch 'feature_retraction_settings_per_extruder'
2016-07-04 12:02:26 +02:00
Tim Kuipers
4b43c96cbc
Merge branch 'feature_zhop_over_other_material'
2016-07-04 11:59:55 +02:00
Tim Kuipers
4ba0ae104e
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-04 11:55:55 +02:00
Tim Kuipers
f99c8b86cc
fix runtest.py: new setting attributes after settings rework (CURA-1828)
2016-07-04 11:55:32 +02:00
Tim Kuipers
5c7862287f
fix runtest.py: setting category structure after settings rework (CURA-1828)
2016-07-04 11:55:02 +02:00
Tim Kuipers
a2c8311c68
fix/feat: gradual infill: pass settings through from frontend and choose better hardcoded values (CURA-836)
2016-07-01 22:27:25 +02:00
Tim Kuipers
018f952a67
fix: linear based infill scaline algorithm was broken (CURA-836)
2016-07-01 21:39:01 +02:00
Tim Kuipers
b05928fb52
bugfix: infill shifting could result in sigaborts (CURA-836, CURA-1723)
2016-07-01 21:38:53 +02:00
Tim Kuipers
8b5f2f8ff8
fix/feat: gradual infill now also working for infil thickness aka infill combine (CURA-836)
2016-07-01 21:36:40 +02:00
Tim Kuipers
50d92ff91e
fix: linear based infill scaline algorithm was broken (CURA-836)
2016-07-01 17:41:01 +02:00
Jaime van Kessel
e3c0439575
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2016-07-01 17:22:48 +02:00
Jaime van Kessel
a0f624992d
Merge branch 'feature_time_estimates_per_layer' of github.com:Ultimaker/CuraEngine
2016-07-01 17:09:42 +02:00
Tim Kuipers
a41a0285f0
lil: removed unused var (CURA-836)
2016-07-01 16:51:55 +02:00
Tim Kuipers
dbeab1ec05
fix: gradual infill logic was the wrong way around (CURA-836)
2016-07-01 16:51:25 +02:00
Tim Kuipers
b81b956965
bugfix: infill shifting could result in sigaborts (CURA-836, CURA-1723)
2016-07-01 14:54:06 +02:00
Tim Kuipers
db2462882c
feat: Infill no accepts extra parameter for etra_infill_shift (CURA-836)
2016-07-01 14:09:34 +02:00
Tim Kuipers
cc0f0918d3
feat/fix: generate infill lines for gradual infill (CURA-836)
2016-07-01 13:59:43 +02:00
Tim Kuipers
3d93407b61
feat/fix: SkinInfillAreaComputation::generateGradualInfill (CURA-836)
2016-07-01 13:37:02 +02:00
Tim Kuipers
ead062757a
refactor: part.infill_area_per_combine ==> part.infill_area_per_combine_per_density (CURA-836)
...
from vector of polygons to vector of vectors of polygons
2016-07-01 11:47:17 +02:00
Tim Kuipers
35b1a42cf3
fix: moved cubic shift computation into a static double (CURA-1723)
2016-07-01 01:37:04 +02:00
Tim Kuipers
420508099a
feat: cubic isometric infill computation (CURA-1723)
2016-07-01 00:36:43 +02:00
Tim Kuipers
7d1586ec4c
refactor: pass down z height into Infill computation (CURA-1723)
2016-07-01 00:33:09 +02:00
Tim Kuipers
cc40088b3e
feat: shift linear based infill types (CURA-1723)
2016-06-30 23:47:11 +02:00
Tim Kuipers
e28f64d36d
fix: removed unused safe_outline_offset (remove overlapping wall parts) (CURA-1723)
2016-06-30 23:10:51 +02:00
Tim Kuipers
0357102399
feat: dont heat up unused extruder (CURA-1508)
2016-06-30 18:01:10 +02:00
Tim Kuipers
bdd1a5c4ed
bugfix: bs init of extruder_attr.is_used (CURA-1508)
2016-06-30 17:38:44 +02:00
Tim Kuipers
d9b47a8c96
refactor: lil rename n ==> extruder_nr (CURA-1508)
2016-06-30 17:27:45 +02:00
Tim Kuipers
507aa1c9d9
fix: initialize gcodeExport::extr_attr::is_used (CURA-1508)
2016-06-30 17:26:44 +02:00
Tim Kuipers
c2a0dd952c
feat: gcodeExport::extr_attr::is_used (CURA-1508)
2016-06-30 17:26:24 +02:00
Tim Kuipers
edc4e3e57b
refactor: introduce cpp file for ExtruderTrain (CURA-1508)
2016-06-30 17:07:52 +02:00
Tim Kuipers
cbf7960e08
lil codestyle fix
2016-06-30 10:55:36 +02:00
Javier Lechuga
74e52455fa
SendMaterialEstimatesOfBothExtrudersToFrontend. Including sendPrintTimeMaterialEstimates in protobuf scheme. CURA-1687
2016-06-30 09:49:46 +02:00
Javier Lechuga
fc7a60b34a
SendMaterialEstimatesOfBothExtrudersToFrontend. First commit not ready yet. CURA-1687
2016-06-30 09:49:45 +02:00
Tim Kuipers
6fa82e044b
fix: skin areas were always wrong (CURA-1773)
2016-06-29 17:59:05 +02:00
Tim Kuipers
8dbfb70c67
fix: retrieve machine_min_cool_heat_time_window per extruder (CURA-1783)
2016-06-29 14:58:37 +02:00
Tim Kuipers
513d1347ca
feat: retrieve minimal cooling+heating time window from settings (CURA-1783)
2016-06-29 14:44:43 +02:00
Tim Kuipers
97d895b0a3
feat: don't allow unused extruder to cool down when time window is too small (CURA-1783)
2016-06-29 14:34:41 +02:00
Ghostkeeper
ac1087dda3
Merge branch 'materials_test'
...
Conflicts:
src/gcodePlanner.cpp
2016-06-29 14:26:15 +02:00
Tim Kuipers
f23a91f0aa
refactor: rename time_to_start_warmup_earlier_to_be_extra_sure_we_dont_have_to_wait ==> extra_preheat_time (CURA-1731)
2016-06-29 12:50:28 +02:00
Tim Kuipers
dd7fb1941f
fix: time within path where preheat commands were inserted was inverted (CURA-1731)
2016-06-29 10:22:32 +02:00
Tim Kuipers
54f7a45f65
small codestyle fixes (CURA-1506)
2016-06-28 18:48:22 +02:00
Tim Kuipers
7d7ca8ae4a
refactor: inversed logic of and calls to LayerPlanBuffer::insertPreheatCommand (CURA-1731)
2016-06-28 18:41:50 +02:00
Tim Kuipers
9ab0839b4a
indent only (CURA-1731)
2016-06-28 18:33:24 +02:00
Tim Kuipers
844bfd34ab
refactor+bugfix: simplified LayerPlanBuffer by passing around a vector of extruder plans rather than layers AND fixed a bug in handleStandbyTemp (CURA-1731)
...
handleStandbyTemp set the standby temp of the wrong extruder plan...
2016-06-28 18:32:59 +02:00
Tim Kuipers
7a87848562
refactor: layer plan buffer: bubble up special case for very first extruder plan of a meshgroup (CURA-1731)
2016-06-28 18:28:28 +02:00
Tim Kuipers
69a62a74ca
fix: removed superfluous if case (CURA-1731)
2016-06-28 17:59:30 +02:00
Tim Kuipers
162f39e3fb
fix: the standby temperatures were reset for all previous extruder plans with the same extruder in the buffer (CURA-1731)
2016-06-28 17:45:29 +02:00
Tim Kuipers
7fa436de51
fix: adjust lowest temperature when there's no time to heat to the required temperature (CURA-1731)
2016-06-28 17:44:55 +02:00
Tim Kuipers
1ef7ae46b2
lil: includes fixed for optional (CURA-1731)
2016-06-28 16:40:55 +02:00
Tim Kuipers
8b9695b913
doc: optional documentation (CURA-1731)
2016-06-28 16:39:34 +02:00
Tim Kuipers
5879a3cdaa
fix: set extruder temps at ExtruderPlan start fixed instead of via TempInsert (CURA-1731)
2016-06-28 16:33:54 +02:00
Tim Kuipers
2236b3afeb
feat: crude implementation of c++17::std::optional (CURA-1731)
2016-06-28 16:14:35 +02:00
Tim Kuipers
ed283a978b
feat: let Preheat compute from_temperature along with heating_time and bubble the result up (CURA-1731)
2016-06-28 14:03:48 +02:00
Tim Kuipers
9f44d8362a
fix: start cooldown in new extruder plan instead of old to combat snowballing effect (CURA-1731)
...
snowballing: when we start cooling T0 before we require the temp of T1 to be reached, due to small discrepancy between the computed and actual heatup times, the time it takes to actually reach the required temp of T1 - while computed to be zero - causes T0 to drop in temperature in that time. This in turn will mean it will also take longer to heat up again, creating the same problem in the next extruder switch from T1 to T0, thereby snowballing into layer switches taking longer and longer.
2016-06-28 13:59:29 +02:00
Ghostkeeper
7e12817974
Codestyle: Spaces after comma
...
Contributes to issue CURA-1506.
2016-06-28 13:05:34 +02:00
Tim Kuipers
93bf338ff2
fix: start heating one second earlier (CURA-1731)
2016-06-28 12:14:42 +02:00
Jaime van Kessel
48c6b2a058
Merge branch 'feature_zhop_over_other_material' of github.com:Ultimaker/CuraEngine
2016-06-28 11:35:22 +02:00
Tim Kuipers
e132db6142
codestyle: brackets (CURA-1506)
2016-06-27 18:09:51 +02:00
Tim Kuipers
a0536af848
fixup: more consts in PolygonUtils::moveInside2 (CURA-1506)
2016-06-27 18:05:31 +02:00
Tim Kuipers
8e8c7fcfc9
doc: more documentation in combing (CURA-1506)
2016-06-27 18:01:45 +02:00
Tim Kuipers
6d672cc840
refactor: over_unavoidable_obstacles_makes_combing_fail ==> fail_on_unavoidable_obstacles (CURA-1506)
2016-06-27 17:49:01 +02:00
Tim Kuipers
9bf8dbbc96
fix: pass down penalty_function through PolygonUtils::ensureInside and moveInside2 (CURA-1506)
2016-06-27 17:42:25 +02:00
Tim Kuipers
c1d4ba89d2
lil: removed unused code in unit test (CURA-1506)
2016-06-27 17:19:39 +02:00
Tim Kuipers
58269b363c
Merge branch 'feature_zhop_over_other_material' of https://github.com/Ultimaker/CuraEngine into feature_zhop_over_other_material
2016-06-27 17:13:36 +02:00
Ghostkeeper
a2f6e62795
Codestyle: Brackets around indented blocks
...
Contributes to issue CURA-1506.
2016-06-27 16:42:48 +02:00
Tim Kuipers
1e1a7e4f95
refactor/fix: removed retraction_config from GCodePathConfig and removed all last_retraction_config logic to revert to just using the retraction config of the extruder (CURA-303)
2016-06-27 15:02:05 +02:00
Ghostkeeper
b035b47526
Spelling fix in documentation
...
Contributes to issue CURA-1506.
2016-06-27 14:47:14 +02:00
Ghostkeeper
53eda52041
Remove trailing whitespace
...
Contributes to issue CURA-1506.
2016-06-27 14:37:40 +02:00
Tim Kuipers
52331d0c83
fix: skin areas were missing when alternate extra perimeter was enabled (CURA-1773)
2016-06-27 10:43:55 +02:00
Tim Kuipers
5cc85d3bf6
fix: no more configurable switch_extruder_retraction_hop (CURA-1506 CURA-1061)
...
making the height configurable is quite difficult with how retraction currently works and there is not a lot of added value
2016-06-24 15:25:00 +02:00
Tim Kuipers
7cf21e9926
fix unit test: GCodePlannerTest::computeNaiveTimeEstimatesRetractionTest() (CURA-1061)
2016-06-24 15:04:10 +02:00
Tim Kuipers
26d506a0f4
refactor/fix: move extruder switch retraction config to sliceDataStorage so that extruder switch z hop can be applied (CURA-1061)
2016-06-24 15:03:43 +02:00
Tim Kuipers
607c21ee46
fix: extruder switch zhop not performed on layer start anymore (CURA-1061)
...
only when the layer starts with a different extruder as the previous ended with
2016-06-24 14:18:55 +02:00
Tim Kuipers
402ede10d4
fix: perform zhops on very first travel of extruder plan. (CURA-1061)
...
still buggy: Now it does a zhop also on the start of a layer
2016-06-24 14:04:36 +02:00
Tim Kuipers
bdd86ab9aa
fix: made max_crossing_dist2 smaller cause other material was being crossed (CURA-1506)
2016-06-23 23:48:01 +02:00
Tim Kuipers
ab3b1c2320
removed assert which doesn't seem to be true given the updated description of PolygonUtils::ensureInsideOrOutside(.) (CURA-1506)
2016-06-23 23:27:53 +02:00
Tim Kuipers
85e2ecc87e
doc: warning for polygonUtils::ensureInsideOrOutside(.) that it may give false positives (CURA-1506)
2016-06-23 23:26:14 +02:00
Tim Kuipers
82846c0cc2
debug: PolygonUtils::ensureInsideOrOutside(.) does a polygon offset which sometimes seems to fail (CURA-1506)
...
sometimes it results in too small polygons which clipper itself and we cannot handle.
sometimes very small polygons are offsetted to polygons which lie outise the original polygon.
2016-06-23 23:25:20 +02:00
Tim Kuipers
09015e188a
lil SVG const correctness
2016-06-23 23:06:23 +02:00
Tim Kuipers
36dbcfc667
check: assert to see whether ensureInsideOrOutside really moved inside (CURA-1506)
2016-06-23 22:56:34 +02:00
Tim Kuipers
5db83799d2
fix: PolygonUtils::ensureInsideOrOutside(.) checks is_inside to see if polygon offset failed (CURA-1506)
2016-06-23 22:55:54 +02:00
Tim Kuipers
9cb04d9e7a
SVG fix for font size
2016-06-23 22:46:47 +02:00
Tim Kuipers
1c966cb6a5
deleted ancient test.cpp
2016-06-23 22:45:05 +02:00
Tim Kuipers
f4d7695700
fix: replaced PolygonRef::inside(.) by Clipper function (CURA-1506)
2016-06-23 22:44:18 +02:00
Tim Kuipers
2288d2da49
fix: combing fails instead of crashes when combing fails due to too thin parts (CURA-1506)
2016-06-23 17:14:57 +02:00
Tim Kuipers
5d5a02739c
fix: moveInside failed when distance was more than max_dist, but it was already inside anyway (CURA-1506)
2016-06-23 17:11:06 +02:00
Tim Kuipers
9248c17ace
fix: combing findCrossingInOrMid can fail when part is too small (now doesn't crash anymore) (CURA-1506)
2016-06-23 16:46:35 +02:00
Tim Kuipers
7417e7d674
fix: Comb::moveInside forgot to set the inside_poly output parameter (CURA-1506)
2016-06-23 16:45:09 +02:00
Tim Kuipers
58228ff9a6
fix: PolygonUtils::findClose etc functions are now safe wrt ClosePolygonPoints which are not found (CURA-1506)
2016-06-23 16:18:44 +02:00
Tim Kuipers
329199af15
feat/fix: combing: findCrossingInOrMid now ensures to be inside (CURA-1506)
2016-06-23 16:17:39 +02:00
Tim Kuipers
2aa67efa20
refactor: changes ClosestPolygonPoint::point_idx and poly_idx to _unsigned_ int (CURA-1506)
...
NO_INDEX is an unsigned int and we don't need to waste all negative numbers which are invalid anyway
2016-06-23 15:47:37 +02:00
Tim Kuipers
7b79debf9a
feat/fix: combing: moveInside now ensures to be inside, or changes startInside / endInside (CURA-1506)
2016-06-23 15:46:24 +02:00
Tim Kuipers
1314f00713
test: unit tests for PolygonUtils::ensureInside and for moveInside2 (CURA-1506)
2016-06-23 15:36:57 +02:00
Tim Kuipers
a407ea6b61
fix: PolygonUtils::ensureInsideOrOutside passed output parameter by value (CURA-1506)|
2016-06-23 15:13:01 +02:00
Tim Kuipers
02e22b9442
small fixes in PolygonUtils (CURA-1506)
2016-06-23 14:47:17 +02:00
Tim Kuipers
5062a985fe
feat: PolygonUtils::ensureInsideOrOutside more rigorous than a simple moveInside (CURA-1506)
2016-06-23 14:46:41 +02:00
Tim Kuipers
5294ea508c
refactor: const correctness in PolygonUtils (CURA-1506)
2016-06-23 14:45:27 +02:00
Tim Kuipers
286a6edaa4
feat: PolygonUtils::moveInside2 a more simple version of moveInside and also for single polygons (CURA-1506)
2016-06-23 14:43:49 +02:00
Tim Kuipers
6af8a8eb85
feat: polygon::offset(.) (CURA-1506)
2016-06-23 14:36:21 +02:00
Tim Kuipers
ee38f51af8
refactor: ClosestPolygonPoint::pos ==> point_idx (CURA-1506)
2016-06-23 12:09:22 +02:00
Tim Kuipers
7428a47344
unit test: polygon offset on holes works the same as offset on outer boundary (CURA-1506)
2016-06-23 12:07:17 +02:00
Tim Kuipers
b859327bbd
refactor/feat: ClosestPolygonPoint now also includes the poly index of the polygon which it refers to (CURA-1506)
2016-06-23 12:06:21 +02:00
Tim Kuipers
0a02a140fb
fix: combing: better findInOrMid for tiny segments (CURA-1506)
2016-06-22 18:01:15 +02:00
Tim Kuipers
5d2d1fe6f3
lil fix: combing: made a small crossing more important than a large detour, cause otherwise sometimes combing fails because of it (CURA-1506)
2016-06-22 17:41:12 +02:00
Tim Kuipers
ed2cdfa67a
lil debug svg constness
2016-06-22 17:17:43 +02:00
Tim Kuipers
6d22cceac5
fix: Polygonutils::findClose only checked vertices of from-poly, now also checks points on line segments (CURA-1506)
2016-06-22 17:17:12 +02:00
Tim Kuipers
8a9f7dbf2b
fix: use last_retraction_config for retractions (CURA-1506)
2016-06-22 17:16:32 +02:00
Ghostkeeper
aa5bc6385b
Merge branch 'materials_test'
2016-06-22 15:32:22 +02:00
Ghostkeeper
764d9868c7
Take max of double+double, not int+double
...
Not properly overloaded by max, I think.
Contributes to issue CURA-1717.
2016-06-22 15:32:07 +02:00
Ghostkeeper
5153022d28
Merge branch 'materials_test'
2016-06-22 15:28:42 +02:00
Ghostkeeper
7d87d2baea
Improve time estimate when accelerating wrong way
...
When accelerating the wrong way, the discriminant of this parabolic is negative. Instead of returning a time estimate of 0, return the extremum of the parabola.
Contributes to issue CURA-1717.
2016-06-22 15:24:58 +02:00
Tim Kuipers
14518007a4
refactor: GCodePlanner::last_retraction_config ==> last_planned_retraction_config (CURA-1506 CURA-958)
2016-06-22 14:38:05 +02:00
Tim Kuipers
64f69d7629
fix: writeRetraction refered to last *planned* retraction config AND removed functionality to make a retraction into the extruder switch retraction (CURA-1506 CURA-958)
...
The only function using the last_retraction_config was the function which owuld convert a normal retraction into a nozzle switch retraction, instead of first performing the normal retraction and then the nozzle switch retraction. That functionality had to be removed anyway, because performing the nozzle switch retraction on the print can leave more scarring.
2016-06-22 14:34:42 +02:00
Tim Kuipers
c93facc43c
fix combing: moveInside always returned false even if we found a point inside (CURA-1506)
2016-06-21 18:09:49 +02:00
Tim Kuipers
c2144cfe1c
fix: PolygonUtils::moveInside tackled the corner case wrong when the point was exactly on the last point of a polygon (CURA-1506)
2016-06-21 17:32:55 +02:00
Tim Kuipers
ca2b4af6f7
fix combing: move inside from previous move inside try so we can get out of the tip of a narrow angled piece (CURA-1506)
...
also I fixed that moveInside always made inside true, when it was false before.
2016-06-21 17:31:58 +02:00
Tim Kuipers
4d429eb719
fix: combing: better move inside strategy (CURA-1506)
2016-06-21 16:53:41 +02:00
Tim Kuipers
e76109697e
refactor: move combings moveInside into its own function (CURA-1506)
2016-06-21 16:01:17 +02:00
Tim Kuipers
213b67528a
lil debug fix to SVG
2016-06-21 14:13:59 +02:00
Tim Kuipers
162d9aa0f7
fix: combing used offset_outside instead of distance between inside and outside at some places (CURA-1506)
2016-06-21 14:13:33 +02:00
Tim Kuipers
1c8f859885
fix: max_crossing_dist only accounted for the outside_boundary offset, not the inside_boundary_offset (CURA-1506)
2016-06-20 18:02:41 +02:00
Tim Kuipers
db4c9b63f8
fix: combing: find better crossing when crossing diagonally between vertices (CURA-1506)
2016-06-20 18:02:02 +02:00
Javier Lechuga
cc349cd046
bugfix_SegfaultDeletedCString
2016-06-20 17:34:57 +02:00
Tim Kuipers
6a925b73d6
lil doc
2016-06-20 17:25:23 +02:00
Tim Kuipers
2290a0927d
refactor: moved Comb::findBestCrossing into Crossing (CURA-1506)
...
also used the same close_to for finding the crossing with the least detour, which is technically a change, but practically does the same thing.
2016-06-20 17:14:25 +02:00
Tim Kuipers
297a22280d
refactor: combing crossings calculated factored out to new class Crossing (CURA-1506)
2016-06-20 17:11:25 +02:00
Javier Lechuga
cd98c620af
Merge branch 'bugfix_wallcount0'
2016-06-20 16:22:49 +02:00
Tim Kuipers
e9647413f8
lil fix: polygon::PartsView::asseblePart is now const (CURA-1506)
2016-06-20 15:41:51 +02:00
Javier Lechuga
998ed5a76c
bugfix: wall line count 0. CURA-1467
2016-06-20 14:39:23 +02:00
Tim Kuipers
2d62e67a24
refactor: moved combing classes into separate files (CURA-1506)
2016-06-20 13:18:46 +02:00
Tim Kuipers
69d2ab837f
refactor: moved Comb into dir pathPlanning (CURa-1506)
2016-06-20 12:23:48 +02:00
Ghostkeeper
ab8f84aa2d
Merge branch 'materials_test'
2016-06-17 17:57:04 +02:00
Ghostkeeper
72c0a8391b
Fix time estimates with accelerations
...
This was giving NaN values in the time estimates for the edge case where the discriminant of this quadratic was actually 0.0, but due to floating point rounding errors ended up below 0.
Contributes to issue CURA-1717.
2016-06-17 17:56:30 +02:00
Tim Kuipers
4b9a79df4d
fix: combing: scanline crossings edge case for line segments ending exactly on the scanline (CURA-1506)
2016-06-17 17:51:01 +02:00
Tim Kuipers
f7decf86a2
fix: combing can now fail if moving too far over in_between (CURA-1506)
2016-06-17 15:25:39 +02:00
Tim Kuipers
61b735ce89
fix: combing used pointer to local variable (CURA-1506)
2016-06-17 15:21:44 +02:00
Tim Kuipers
c4b78fdfd1
fix: perform z hop always when not combing (CURA-1506)
...
whether to perform a z hop only when the comb move would collide only influences when the combing calculation decides to fail
2016-06-17 14:38:39 +02:00
Tim Kuipers
96769cb90c
fix: combing: early calculation stopping for z-hops (CURA-1506)
2016-06-17 14:32:42 +02:00
Tim Kuipers
0ee60d2d3a
fix: return whether the combing crosses an inavoidable boundary, aka being locked in/out (CURA-1506)
2016-06-17 14:01:05 +02:00
Tim Kuipers
9cbbdad56f
lil: made clear where endInside and startInside are finally computed (CURA-1506)
2016-06-17 13:58:18 +02:00
Tim Kuipers
4a18f5d03d
fix: combing: optimized and fixed going via hole polygon when endpoint is inside of the part containing the start point (CURA-1506)
2016-06-17 13:56:57 +02:00
Tim Kuipers
9b76a2e820
fix: combing/avoid always went to outside of part even when the endpoint was inside of a hole in the start part (CURA-1506)
2016-06-17 12:36:19 +02:00
Tim Kuipers
5a1897d631
feat: SVG::writePolygons and better border handling
2016-06-17 12:31:54 +02:00
Tim Kuipers
9d83fe08d8
doc: more documentation on combing and scanline crossings (CURA-1506)
2016-06-17 12:30:44 +02:00
Tim Kuipers
428198b4f9
feat: combing: find crossing from in to out closer to end point (CURA-1506)
2016-06-16 16:44:53 +02:00
Tim Kuipers
e92bf03293
feat: combing: prefer crossings closer to start/end point a bit more (CURA-1506)
2016-06-16 16:33:13 +02:00
Tim Kuipers
9fe77a5761
test: PolygonUtils::findClose with penalty_function (CURA-1506)
2016-06-16 16:19:21 +02:00
Tim Kuipers
fa07addba2
feat: PolygonUtils::findClose now support a penalty_function (CURA-1506)
2016-06-16 16:19:00 +02:00
Tim Kuipers
ba4e4cc38f
fix: PolygonUtils::findClose would return nothing when first arbitrary point was best (CURA-1506)
2016-06-16 16:17:45 +02:00
Tim Kuipers
e2a47e1619
fix: pass by value bug and doc (CURA-1506)
2016-06-16 15:53:24 +02:00
Tim Kuipers
e107626026
unit test: Polygonutils::findClosest with penalty function (CURA-1506)
2016-06-16 15:36:35 +02:00
Tim Kuipers
527b1f9b13
feat: added optional penalty function to PolygonUtils::findClosest (CURA-1506)
2016-06-16 15:27:10 +02:00
Tim Kuipers
6abc896bab
feat: perform z-hop only when combing fails (CURA-1506)
2016-06-16 15:00:20 +02:00
Tim Kuipers
f2de0fd5df
refactor/feat: introduced getLastPlannedExtruderTrainSettings and replaced code with that function and with getExtruder() (CURA-1506)
2016-06-16 14:59:45 +02:00
Johan K
c202d1b47a
Changed the message used to send the final slice result to the front-end to LayerOptimized
...
Corrected the name of the data from polygon to path segment and left the old message for future visualization of the earlier stages.
2016-06-16 00:10:43 +02:00
Tim Kuipers
d4349818b7
fix: reset acceleration and jerk back to default firmware values afterwards (CURA-1443)
2016-06-16 00:02:17 +02:00
Tim Kuipers
ce80ceb165
lil doc typo
2016-06-15 23:21:27 +02:00
Tim Kuipers
d19310ee27
refactor: removed superfluous/old writeTypeComment(string ..) (CURA-1350)
2016-06-15 23:20:30 +02:00
Tim Kuipers
63e6a249e3
feat: write time estimates in comments every layer (CURA-1350)
2016-06-15 23:17:50 +02:00
Johan K
0b05457fac
Adding polygon packing feature and change the structure of the layer data sent to the front-end to speed up the layer view
2016-06-14 18:20:01 +02:00
Tim Kuipers
63356dca41
feat: set firmware values from configuration (CURA-1646)
2016-06-14 17:05:14 +02:00
awhiemstra
4bce36550f
Merge pull request #353 from Johan3DV/master_polyutil_ref
...
Adding some references
2016-06-14 10:35:40 +02:00
Johan K
3ca1e6673f
Adding some missing references
2016-06-13 22:07:31 +02:00
Ghostkeeper
b2a4ee1647
Merge pull request #350 from thopiekar/master-windows-work
...
Ignore generated Makefile and archives of code
2016-06-13 00:35:31 +02:00
Thomas Karl Pietrowski
81ef194164
Merge remote-tracking branch 'refs/remotes/Ultimaker/master' into master-windows-work
2016-06-11 12:40:24 +02:00
Thomas Karl Pietrowski
2c698c8ba0
Ignore generated Makefile and archives of code
2016-06-11 12:40:20 +02:00
Jaime van Kessel
54e63de3a8
Merge branch 'feature_accelerations_and_jerk_per_feature_settigns_rework' of github.com:Ultimaker/CuraEngine
2016-06-10 15:36:52 +02:00
Tim Kuipers
0186d35372
fix: retrieved extruder_count instead of machine_extruder_count (CURA-1560)
2016-06-10 15:21:14 +02:00
Tim Kuipers
c018a44c38
fix: retrieved extruder_count instead of machine_extruder_count (CURA-1560)
2016-06-10 13:13:13 +02:00
Tim Kuipers
0c62d1ab65
Merge branch 'master' into feature_accelerations_and_jerk_per_feature_settigns_rework
2016-06-10 12:19:41 +02:00
Tim Kuipers
ff1fca976e
bugfix: global settigns were never loaded (CURA-1682)
2016-06-09 19:03:52 +02:00
Tim Kuipers
a7ad42eb1f
fix: bugfix in comandSocket Extruder.settings (CURA-1682)
2016-06-09 13:10:30 +02:00
Tim Kuipers
fb526ffc6d
lil doc (CURA-1682)
2016-06-09 12:13:08 +02:00
Tim Kuipers
d806c23d59
feat: handle extruder train settings (CURA-1682)
2016-06-09 12:07:24 +02:00
Tim Kuipers
28b8b41475
Added extruder to proto message
...
CURA-1681
CURA-1682
2016-06-09 12:00:35 +02:00
Tim Kuipers
457e609091
refactor/bugfix: inline handleSettingList (CURA-1682)
...
Two commits above introduced a bug where I passed thw wrong objects to handleSettingList
2016-06-09 11:40:50 +02:00
Tim Kuipers
ffcd076f3e
doc: commented proto file (CURA-1682 CURA-1681)
2016-06-09 11:39:11 +02:00
Tim Kuipers
01951ac513
feat: global settings are now passed via the same message as the objects (CURA-1682)
2016-06-09 11:08:36 +02:00
Tim Kuipers
a8debfde40
refactor: comandSocket::handleSettingList now takes a settings base (CURA-1682)
2016-06-09 11:06:51 +02:00
Tim Kuipers
3194e30772
Updated proto file
...
Objects & global settings are now sent in one message.
Also added support for extruder settings
CURA-1681
CURA-1682
2016-06-09 10:50:46 +02:00
Tim Kuipers
223313c5ef
Merge pull request #349 from thopiekar/master-windows-work
...
Adding generated CMake files to .gitignore
2016-06-08 15:18:17 +02:00
Thomas Karl Pietrowski
5a8f580edd
Adding generated CMake files to ignore
...
These files are generated by CMake on Windows 10 64bit with Visual
Studio installed. They are not tracked by the project, so they can be
savely removed by git clean.
2016-06-08 13:50:59 +02:00
Tim Kuipers
394fbda0ff
lil codestyle
2016-06-08 12:12:42 +02:00
Tim Kuipers
e778cc6bf0
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-06-08 10:38:09 +02:00
Tim Kuipers
af6b581167
lil doc
2016-06-08 10:36:34 +02:00
Tim Kuipers
2f026d006c
fix: mergeInfillLines had a boolean mistake due to 497c969 (CURA-1560)
2016-06-08 10:33:15 +02:00
Tim Kuipers
86daf598e5
fix: minimal avoid distance is zero (CURA-1560)
2016-06-08 10:30:42 +02:00
Tim Kuipers
e77ddee5de
fix: put back the *2 I accidentally removed in ee087f23 (CURA-1560)
2016-06-08 09:58:09 +02:00
Tim Kuipers
162fac057d
fix: support_type was retrieved per mesh instead of globally (CURA-1560)
2016-06-08 09:55:25 +02:00
Thomas Karl Pietrowski
5c3c038c43
Merge remote-tracking branch 'refs/remotes/Ultimaker/master'
2016-06-08 09:41:58 +02:00
Tim Kuipers
78432b49fe
Update README.md
2016-06-07 16:06:18 +02:00
Tim Kuipers
4395f9a465
fix: only force minimal layer time on the last extruder plan (CURA-1568)
2016-06-06 17:37:37 +02:00
fieldOfView
0288f08cc3
Fixes for codestyle and find/replace accident
...
CURA-967
2016-06-05 15:28:45 +02:00
Tim Kuipers
beb14b3e15
fix: machine_extruder_end_pos_abs was retrieved globally (CURA-1568)
2016-06-03 17:30:38 +02:00
Tim Kuipers
c436a108ec
fix: dynamic char array size instead of static (CURA-1574)
...
A static char array length is open to buffer overflow problems/attacks
2016-06-03 17:04:51 +02:00
Tim Kuipers
5f9bfb6ac5
fix: cool_lift_head is now retrieved per meshgroup (CURA-1568)
2016-06-03 17:00:16 +02:00
Tim Kuipers
43a69544fb
fix: handleAllRemainingInserts at the very end of an extruder plan (CURA-1568)
2016-06-03 16:37:40 +02:00
Tim Kuipers
a53141089c
indent fix (CURA-1568)
2016-06-03 16:36:55 +02:00
Tim Kuipers
57a58afc7a
fix: don't lift head if we are at the switching bay (CUTA-1568)
2016-06-03 16:36:31 +02:00
Tim Kuipers
2e9f712eae
indent: fixed indentation (CURA-1568)
2016-06-03 16:13:29 +02:00
Tim Kuipers
075b3e6581
refactor/feat: move fanSpeedLayerTime computation inside the ExtruderPlan class (CURA-1568)
2016-06-03 16:12:26 +02:00
Tim Kuipers
8c4c2bae67
refactor: fan_speed_layer_time_settings_per_extruder.emplace_back (BUGGY STATE) (CURA-1568)
2016-06-03 16:10:55 +02:00
Tim Kuipers
8318f290fa
fix: better GCodePlannerTest (CURA-1560)
2016-06-03 13:13:28 +02:00
Tim Kuipers
191f699309
fix: testcase GCodePlannerTest restored (CURA-1560)
2016-06-03 13:09:32 +02:00
Tim Kuipers
2dac16b44f
refactor: remove unnecessary argument parent_file from SettingRegistry::getDefinitionFile (CURA-1574)
2016-06-03 12:47:32 +02:00
Tim Kuipers
9db735e2e5
fix: record search paths for extruder train defs (CURA-1574)
2016-06-03 12:44:18 +02:00
Tim Kuipers
ee087f23de
fix: wall_line_width/count not retrieved per extruder anymore (CURA-1560)
2016-06-03 00:02:50 +02:00
Tim Kuipers
5878916b03
fix: retrieve travel_avoid_distance per extruder and use the highest value (CURA-1560)
2016-06-02 23:24:24 +02:00
Tim Kuipers
7e7dbf34be
refactor: rename some vars from storage ==> mesh (CURA-1560)
2016-06-02 23:02:14 +02:00
Tim Kuipers
c3d535d88f
fix: adhesion_type was retrieved per mesh (CURA-1560)
2016-06-02 22:59:49 +02:00
Tim Kuipers
2b987a9a73
DEBUG: commented a whole testcase (CURA-1560)
2016-06-02 22:53:18 +02:00
Tim Kuipers
315f01daef
refactor: removed global retrieval of travel config (CURA-1560)
2016-06-02 22:50:26 +02:00
Tim Kuipers
fdc756a22b
refactor: moved sliceDataStorage initialization to header file (CURA-1560)
2016-06-02 22:28:46 +02:00
Tim Kuipers
497c969048
refactor: removed global travel config (CURA-1560)
2016-06-02 22:23:07 +02:00
Tim Kuipers
e22d4d30e7
refactor: removed global retraction config (CURA-1560)
2016-06-02 21:40:22 +02:00
Tim Kuipers
432761690b
fix: removed (globally retrieved) travel speed dependancy from finalize (CURA-1560)
2016-06-02 18:25:23 +02:00
Tim Kuipers
39422e6dbc
fix: platform adhesion options now all retrieved from extruder train (CURA-1560)
2016-06-02 18:22:23 +02:00
Tim Kuipers
0f9c14e42a
fix: temps set multiple times and temps retrieved per mesh (CURA-1560)
2016-06-02 17:29:22 +02:00
Tim Kuipers
d9374270cf
fix: magic_spiralize was retrieved globally (CURA-1560)
2016-06-02 17:10:28 +02:00
Tim Kuipers
9f8cdf69f0
fix: layer_height was retrieved per mesh (CURA-1560)
2016-06-02 17:04:15 +02:00
Tim Kuipers
492e4f7b29
fix: machine_name was never actually loaded in the settings (CURA-1574)
2016-06-01 17:19:59 +02:00
Tim Kuipers
b50bc938df
lil refactor
2016-06-01 15:58:40 +02:00
Tim Kuipers
aa36ad175e
fix: overlaps were compensated twice when layer would start within an overlap zone (CURA-1635)
2016-06-01 15:56:58 +02:00
Tim Kuipers
0d50fe50b4
fix: heuristic solution to circumvent iterator invalidation (CURA-1635)
...
complex models with almost everywhere pieces smaller than twice the nozzle width could break the heuristic, when there are a lot of 3-way intersections of thin walls
2016-06-01 15:54:52 +02:00
Tim Kuipers
8bf31f771c
refactor: moved WallOverlapComputation constructor to cpp file (CURA-1635)
2016-06-01 13:47:25 +02:00
Tim Kuipers
634fddd908
lil doc
2016-06-01 13:32:24 +02:00
Tim Kuipers
7f64494dec
lil refactor (CURA-1635)
2016-06-01 13:27:10 +02:00
Tim Kuipers
dffb1ef459
doc: lil doc for walloverlap comp (CURA-1635)
2016-06-01 13:22:43 +02:00
Tim Kuipers
9b74c6c0a2
better debugging for wallOverlapComp
2016-06-01 13:21:44 +02:00
Tim Kuipers
b23ede94f3
lil debug fix for WallOverlapComputation
2016-06-01 11:53:27 +02:00
Tim Kuipers
1837d658dd
fix: infill_area_per_combine wasn't always filled (CURA-1255)
2016-05-31 15:27:30 +02:00
Tim Kuipers
7086762216
refactor: early out for polygon settings (which are unsupported) (CURA-1574)
2016-05-31 12:43:04 +02:00
Tim Kuipers
bc78163d70
fix: settings default values got deleted when overriden by json object which didn't define a default_value (CURA-1574)
2016-05-31 12:41:56 +02:00
Tim Kuipers
81c2091ddb
lil fix in help (CURA-1574)
2016-05-30 17:05:07 +02:00
Tim Kuipers
6e3d71e39b
fix: load machine_extruder_trains ids from machine definition after the recursion, so that the parent json file doesn't overload the current (CURA-1574)
2016-05-30 17:02:27 +02:00
Tim Kuipers
35112600bc
fix: dont warn for duplicated for non-base files and for extruder trains (CURA-1574)
...
extruder train base definition file gets loaded for each extruder, and we don't want to get duplicate errors every time we load the second extruder
2016-05-30 17:00:29 +02:00
Tim Kuipers
0e58fb960f
feat: load extruder train defaults (and definitions) on creation of new extruder train (CURA-1574)
2016-05-30 16:44:42 +02:00
Tim Kuipers
a36c90d076
clenaup: removed unused function in settingsRegistry (CURA-1574)
2016-05-30 16:36:10 +02:00
Tim Kuipers
b72625b28f
feat: settingsRewgistry::loadExtruderJSONsettings (CURA-1574)
2016-05-30 16:35:44 +02:00
Tim Kuipers
8ead13d2be
cleanup: removed old extruder_trains unused default saving mechanism (CURA-1574)
2016-05-30 16:27:31 +02:00
Tim Kuipers
d30d2af4f0
feat: remember extruder train ids from json (CURA-1574)
2016-05-30 16:20:46 +02:00
Tim Kuipers
6808e25cd8
Merge branch 'feature_accelerations_and_jerk_per_feature_settigns_rework' of https://github.com/Ultimaker/CuraEngine into feature_accelerations_and_jerk_per_feature_settigns_rework
2016-05-30 15:18:22 +02:00
Tim Kuipers
cdc2d17455
fix: spiralzie got reintroduced by merge with code which moved GCodePathConfig (CURA-1443)
2016-05-30 15:17:18 +02:00
Tim Kuipers
31dbc4ef24
Merge branch 'feature_accelerations_and_jerk_per_feature' into feature_accelerations_and_jerk_per_feature_settigns_rework
2016-05-30 15:16:11 +02:00
Tim Kuipers
01c78d555c
Merge branch 'feature_accelerations_and_jerk_per_feature' into feature_accelerations_and_jerk_per_feature_settigns_rework
2016-05-30 15:12:31 +02:00
Tim Kuipers
2f46c0e473
fix: make path delimiter depend on OS (CURA-1574)
2016-05-30 11:27:54 +02:00
Tim Kuipers
34f60e6616
lil codestyle
2016-05-30 11:08:41 +02:00
Tim Kuipers
303246b39c
fix: generateMultipleVolumesOverlap was broken (CURA-833)
2016-05-27 13:45:10 +02:00
Tim Kuipers
3b80ac93ea
lil prime tower fix
2016-05-27 13:30:16 +02:00
Tim Kuipers
6b7b5a7ea9
refactor: load setting defaults into settings at the moment they get loaded (CURA-1574)
2016-05-27 13:27:48 +02:00
Tim Kuipers
231eee1e46
lil prime tower fix
2016-05-27 13:26:25 +02:00
Tim Kuipers
81424528f3
refactor: no more overload_defaults_only (CURA-1574)
2016-05-27 13:00:17 +02:00
Tim Kuipers
c78808b69d
lil
2016-05-27 12:59:37 +02:00
Tim Kuipers
1c347be3be
fix: don't overload defaults only when loading extruder json files (CURA-1574)
2016-05-27 12:53:38 +02:00
Tim Kuipers
c79c503621
fix: setting loading always segfaulted (CURA-1574)
2016-05-26 21:01:49 +02:00
Tim Kuipers
e6fb617f3f
refactor: simplified SettingRegistry::handleSetting (CURA-1574)
2016-05-26 08:46:37 +02:00
Tim Kuipers
ca1799efc6
remove unneeded function (CURA-1574)
2016-05-26 08:46:13 +02:00
Tim Kuipers
749e85b15b
doc: setting registry stuff (CURA-1574)
2016-05-26 08:45:50 +02:00
Tim Kuipers
82c7bfaf7a
fix: don't retrieve settings from registry (CURA-1574)
...
The settings are set during the loading of the json file, not during retrieval of settings
2016-05-25 17:08:54 +02:00
Tim Kuipers
d5df34b3cf
fix: don't set extruder train defaults anymore via some special casing for extruder trains (CURA-1574)
2016-05-25 17:07:35 +02:00
Tim Kuipers
59774e7f14
lil: less warnings when handling json (CURA-1574)
...
warnings were given twice and were given for overriding frontend settings
2016-05-25 17:05:36 +02:00
Tim Kuipers
bf8e73a4ae
feat: load json setting default directly into a given settings base (CURA-1574)
...
Instead of keeping the defaults in the global settings registry, load the defaults immediately into a settings base, so that we can override the extruder train defaults.
2016-05-25 16:58:41 +02:00
Tim Kuipers
8b778b82be
fix: support_extruder_nr used instead of support_infill_extruder_nr
2016-05-25 15:28:25 +02:00
Tim Kuipers
d42b0ac9eb
fix: SettingsToGv for new setting json files (CURA 1574)
2016-05-25 15:27:11 +02:00
Tim Kuipers
cda656d43d
lil: made etDefinitionFile static (CURA-1574)
2016-05-25 15:02:55 +02:00
Tim Kuipers
8c18b2ca89
fix doc: help and README show new way of handling settings and the CURA_ENGINE_SEARCH_PATH env var (CURA-1574)
2016-05-25 15:01:56 +02:00
Tim Kuipers
eeb69776de
feat: load json settings recursively and check in paths provided in CURA_ENGINE_SEARCH_PATH (CURA-1574)
2016-05-25 14:46:08 +02:00
Tim Kuipers
cee01abe16
refactor: pass down warn_duplicates via setting calls (CURA-1574)
...
Extruder train definition .def.json files shouldn't warn for duplicates; only the base file should.
2016-05-25 12:30:49 +02:00
Tim Kuipers
8df1562d7b
cleanup imports (CURA-1574)
2016-05-25 12:23:18 +02:00
Tim Kuipers
3bbc4a1d72
refactor: split settingRegistry into separate class and header files (CURA-1574)
2016-05-25 12:19:23 +02:00
Tim Kuipers
5a9eaa29ea
refactor: move settings related files into separate folder (CURA-1574)
2016-05-25 12:07:59 +02:00
Tim Kuipers
6faeaf8c0b
fix: accidental __cxx11:: in type (CURA-1574)
2016-05-20 14:04:46 +02:00
Tim Kuipers
f9b15a2f47
refactor: settingsResistry.settings ==> setting_key_to_config (CURA-1574)
2016-05-20 12:58:02 +02:00
Tim Kuipers
c1eb1fdd85
fix: forgotten newline in SettingContainer debug out (CURA-1574)
2016-05-20 12:57:27 +02:00
Tim Kuipers
324f424e69
refactor: simplified machine name loading (CURA-1574)
2016-05-20 12:51:04 +02:00
Tim Kuipers
3dfb35d73e
fix: a settings container is now used only for the global settings base and for the separate extruder train settings default bases (CURA-1574)
2016-05-20 12:50:38 +02:00
Tim Kuipers
e72789e3cb
fix: read new setting .def.json files (CURA-1574)
...
Simplified the recursion of reading settings
Made the settings registry into a flat list, rather than a tree
Made each setting record a path instead (to keep the same information as the tree)
Moved extruder trains into a separate object, rather than it being a normal category
warn_duplicates strategy simplified: always after the first file
(rather than when applying overrides)
temporarily removed reading of machine_extruder_trains
made label attribute obligatory
Always add a setting to the global setting config (cause reading machine_extruder_trains is currently not implemented)
2016-05-20 12:42:14 +02:00
Tim Kuipers
d6ac9e69c1
lil
2016-05-19 17:08:02 +02:00
Tim Kuipers
358d2e26c2
lil
2016-05-19 17:07:04 +02:00
Tim Kuipers
e9fb973a05
fix: machine_settings became just another category, so doesnt need special handling (CURA-1574)
2016-05-19 14:29:55 +02:00
Tim Kuipers
22b86f81b7
fix: don't load inheriting json document (CURA-1574)
...
The inherit property now refers to an id instead of a filename, so I cannot simply know which file I have to load from a given json file
2016-05-19 14:28:59 +02:00
Tim Kuipers
cf05c65061
lil: don't wait after priming second nozzle
2016-05-18 17:25:45 +02:00
Tim Kuipers
5f8f0110cf
fix: switch infill direction every X layers (CURA-1569 CURA-943)
...
infill combine always prints infill of any thickness on infill of the first fully combined layer below
2016-05-18 16:35:10 +02:00
Tim Kuipers
d3715e8e76
refactor: moved getSettingBoolean(cool_lift_head) inside gcodePlanner::writeGCode(.) (CURA-1568)
2016-05-18 13:36:05 +02:00
Tim Kuipers
31e2996104
refactor: removed superfluous layerThickness parameter to gcodePlanner::writeGCode(.) (CURA-1568)
2016-05-18 13:32:13 +02:00
Tim Kuipers
3ff329033a
lil doc
2016-05-18 10:24:42 +02:00
Tim Kuipers
f7d72623d2
fix: better naming for infill/skin overlap for support (CURA-967)
2016-05-13 13:22:34 +02:00
Tim Kuipers
fee8867855
feat: skin_overlap separated from infill_overlap (CURA-967)
2016-05-13 13:22:04 +02:00
Tim Kuipers
62a4db8632
fix: initial layer thickness stays the same even when having a raft
2016-05-12 23:42:06 +02:00
Tim Kuipers
efb20afc76
fix: only process if there's any non-infill meshes (CURA-833)
2016-05-12 20:49:46 +02:00
Tim Kuipers
683c887e53
fix: made generateMultipleVolumesOverlap ignore infill meshes and made overlap changable per object (CURA-883)
2016-05-12 20:11:00 +02:00
Tim Kuipers
4d9daccb5b
fix: don't generateMultipleVolumesOverlap for infill meshes (CURA-833)
2016-05-12 20:06:25 +02:00
Tim Kuipers
c0611904bb
refactor: compute generateMultipleVolumesOverlap differently (CURA-833)
...
instead of for each layer computing overlap for all volumes, go through all volumes computing overlap for each layer
2016-05-12 20:04:03 +02:00
Tim Kuipers
cecac0fe90
lil: code conventions (CURA-833)
2016-05-12 19:56:00 +02:00
Tim Kuipers
f48c858ec4
fix: syntax fix of last merge
2016-05-12 19:55:34 +02:00
Tim Kuipers
fc4d24fb01
optimization: carveMultipleVolumes uses aabb of meshes and discards infill meshes (CURA-1551 CURA-833)
2016-05-12 19:49:42 +02:00
Tim Kuipers
529301f950
Merge branch '2.1'
2016-05-12 19:25:10 +02:00
Tim Kuipers
33d2594b20
fix: M204 confirmed to too new Marlin standard (CURA-1443)
2016-05-12 16:54:22 +02:00
Tim Kuipers
9c47644e55
cleanup: removed fill_perimeter_gaps setting (CURA-996)
2016-05-12 16:30:11 +02:00
Tim Kuipers
2949f89b29
cleanup: removed perimeterGaps and functionality of fill_perimeter_gaps (CURA-996)
2016-05-12 16:28:39 +02:00
Tim Kuipers
1793961094
cleanup: removed avoidOverlappingPerimeters as parameters to functions and as member variables (CURA-996)
2016-05-12 16:22:34 +02:00
Tim Kuipers
590795921e
cleanup: removed avoidOverlappingPerimeters and in_between from Infill factory (CURA-996)
2016-05-12 16:17:43 +02:00
Tim Kuipers
b79c404dc3
remove: removed offsetSafe functions used for 'remove overlapping wall parts' (CURA-996)
2016-05-12 16:05:37 +02:00
Tim Kuipers
0065532d6d
lil doc (CURA-996)
2016-05-12 14:00:09 +02:00
Tim Kuipers
b89c8fd1fa
fix: infill meshes didn't update bounding boxes (CURA-833)
2016-05-11 23:25:56 +02:00
Tim Kuipers
d409c4d245
feat: infill_mesh_order to determine the order of infill meshes in eachother (CURA-833)
2016-05-11 23:25:28 +02:00
Tim Kuipers
fd64b5ce60
fix: infill meshes updated infill_area, but not infill_are_per_combine (CURA-833)
2016-05-11 22:35:06 +02:00
Tim Kuipers
5bc3b86dc4
fix: infill meshes relied on old infill_area implementation (CURA-833)
2016-05-11 21:47:41 +02:00
Tim Kuipers
9ec92fa33f
Merge branch 'feature_infill_mesh_correct_progress'
2016-05-11 21:43:58 +02:00
Tim Kuipers
03b654af3e
feat: layer_0_z_overlap (CURA-1549)
2016-05-11 17:15:28 +02:00
Tim Kuipers
e3c03e6c04
feat: switch_extruder_retraction_hop (CURA-1061)
2016-05-11 16:41:08 +02:00
Tim Kuipers
33c40f3398
Merge branch '2.1'
2016-05-11 13:27:16 +02:00
Tim Kuipers
c79a7f1819
fix: spiralize would leave the z at the next layer for the next polygon on the same layer (CURA-1541)
2016-05-11 12:57:47 +02:00
Tim Kuipers
7843a68d7c
lil: doc
2016-05-11 12:13:18 +02:00
Tim Kuipers
8f912835cf
lil: doc indent
2016-05-11 12:11:37 +02:00
Tim Kuipers
36de33b735
fix: some small fixes of second last refactor (CURA-1367)
2016-05-11 12:07:24 +02:00
Tim Kuipers
01884663c3
refactor: rename files insets ==> WallsComputation (CURA-1367)
2016-05-11 12:04:11 +02:00
Tim Kuipers
4c46dd37a7
refactor: put generateInsets functions into a class (CURA-1367)
2016-05-11 12:01:16 +02:00
Tim Kuipers
9245a4fa41
fix: only compute print_outline when the mesh uses support (CURA-1367)
2016-05-11 11:50:31 +02:00
Tim Kuipers
4b240e8057
fix: let getLayerOutlines use an outline approximation based on the outer wall (CURA-1367)
...
Thin walls may be unprintable, so getLayerOutlines returns pieces of polygons which aren't actually printed.
This caused an edge overhang to remove support due to the XY distance of unprinted parts of the edge overhang.
When two parts are connected via an unprintably thin wall, also combing would be affected, but not anymore.
2016-05-11 11:36:38 +02:00
Tim Kuipers
fff8195d51
Merge branch '2.1'
2016-05-11 08:52:55 +02:00
Tim Kuipers
e01f18c7d4
lil: doc
2016-05-11 08:52:06 +02:00
Tim Kuipers
42891874f4
fix: multiple polygons & spiralize resulted in extrusions where travels should have been (CURA-1513)
2016-05-10 17:37:16 +02:00
Tim Kuipers
257d6a6635
fix: spiralize each polygon of a spiralized mesh even though that might cause a print head crash (CURA-1443)
2016-05-10 15:58:34 +02:00
Tim Kuipers
bec8bef455
fix: consecutive spiralize paths are handled as one (CURA-1443 CURA-1541)
2016-05-10 15:32:09 +02:00
Tim Kuipers
4efeaa7083
fix: let bool spiralize bubble down from FffGcodeWriter into GCodePath instead of going via the GCodePathConfig (CURA-1443)
...
Because of the LayerPlanBuffer the GCodePathConfig changed a couple of layers too early, resulting in spiralization in the first layers which include the bottom skin.
2016-05-10 15:14:50 +02:00
Tim Kuipers
95fd9d6685
lil: doc
2016-05-10 13:25:11 +02:00
Tim Kuipers
f6cf3356f8
feat: change time estimates based on jerk and acceleration (CURA-1443)
2016-05-10 09:38:06 +02:00
Tim Kuipers
c041ca5ea1
fix: acceleration used wrong gcode (CURA-1443)
2016-05-10 09:33:42 +02:00
Tim Kuipers
92cb2f82ab
refactor: moved firmware values inside TimeEstimateCalculator (CURA-1443)
2016-05-10 09:16:11 +02:00
Tim Kuipers
fa7ff61bf5
feat: apply acceleration and jerk (CURA-1443)
2016-05-09 18:30:02 +02:00
Tim Kuipers
255c62782e
feat: initial layer speedup also applied to acceleration and jerk (CURA-1443)
2016-05-09 17:14:58 +02:00
Tim Kuipers
9cbf760c80
feat: acceleration and jerk for GCodePathConfig (CURA-1443)
2016-05-09 15:27:47 +02:00
Tim Kuipers
506560e9e0
refactor: move path config parameters which change over layers into a separate struct (CURA-1443)
...
now the iconic settings and current settings are well separated, making it easier to introduce more settings which change over layers
2016-05-09 13:39:52 +02:00
Tim Kuipers
d634e310fd
refactor: moved GCodePathConfig implementation to new cpp file (CURA-1443)
2016-05-09 12:38:59 +02:00
Tim Kuipers
255dd4ffcd
refactor: moved GCodePathConfig and RetractionConfig to their own header files (CURA-1443)
2016-05-09 12:34:47 +02:00
Tim Kuipers
6d54a31bcd
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-05-06 15:31:04 +02:00
Tim Kuipers
18df36ca06
refactor: moved AABB3D out of AABB (CURA-1436)
2016-05-06 15:30:22 +02:00
Tim Kuipers
55f47523b2
refactor: moved AABB implementation out of header file (CURA-1436)
2016-05-06 15:24:46 +02:00
Tim Kuipers
4130af0ad6
feat: boundingbox.expand (CURA-1436)
2016-05-06 15:06:19 +02:00
Tim Kuipers
c08a0221c8
fix: combing basic comb path had wrong offsets to beginning and end of poly (CURA-1436)
2016-05-06 15:05:19 +02:00
Tim Kuipers
31f8459a0f
Merge pull request #335 from sean041/patch-2
...
Compare in PolygonRef::shorterThan is strange.
2016-05-05 11:11:51 +02:00
Peng Liu
4642076fdc
Compare in PolygonRef::shorterThan is strange.
...
PolygonRef::shorterThan will always return false?
2016-05-05 15:27:46 +08:00
Tim Kuipers
5fd3277919
doc&refactor: moved ConicalOverhang to cpp file (CURA-1412)
2016-05-04 15:34:06 +02:00
Tim Kuipers
13b3c715bf
feat: compensate overlapping inner wlal parts (CURA-995)
2016-05-04 15:09:33 +02:00
Tim Kuipers
3583d71dcd
lil: indent (CURA-1479)
2016-05-04 11:40:38 +02:00
Tim Kuipers
c5ab004ece
feat: option to apply different xy distance at overhang places (CURA-1479)
2016-05-04 11:40:15 +02:00
Tim Kuipers
b8fe70ee74
feat: SupportDistPriority setting enum (CURA-1479)
2016-05-04 11:38:30 +02:00
Tim Kuipers
6db88290c2
lil debug
2016-05-03 15:57:55 +02:00
Tim Kuipers
be6fd8cc7c
fix: skirt was processed sometimes twice for the first extruder sometimes not at all for the second extruder (CURA-1446)
2016-05-03 15:57:40 +02:00
Tim Kuipers
baeb736705
fix: if all layers got removed slicing didn't quit (CURA-1465)
2016-05-03 14:15:57 +02:00
Tim Kuipers
05fa05bb5a
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-05-03 13:51:33 +02:00
Tim Kuipers
5a7c2e5ef1
fix codestyle (tabs)
2016-05-03 13:50:33 +02:00
Tim Kuipers
c9de58ceba
fix: material used was logged on the wrong extruder (CURA-520)
2016-05-03 13:15:53 +02:00
Ghostkeeper
1d60079220
Merge branch 'feature_slicer_refactor_rebased'
2016-05-03 11:06:09 +02:00
Tim Kuipers
77d40fb0e9
fix: griffin header micron ==> mm (CURA-520)
2016-05-03 09:34:03 +02:00
Tim Kuipers
72e9906bb8
Merge branch '2.1'
2016-05-02 18:29:30 +02:00
Tim Kuipers
2db37c6018
fix: erase with impossible iterator when trying to simplify an empty polygon (CURA-1430)
2016-05-02 18:28:00 +02:00
Tim Kuipers
41b0966d26
fix: constructor prime tower called incorrectly
2016-05-02 17:33:00 +02:00
Ghostkeeper
d5bff03a1c
Codestyle: Space around binary operators
...
Contributes to issue CURA-520.
2016-04-29 16:18:59 +02:00
Tim Kuipers
0d5cc686c9
fix: exclude enum values from setting reflection
2016-04-29 14:32:07 +02:00
Tim Kuipers
3103acb7b0
fix: curaEngine analyse
2016-04-29 14:28:04 +02:00
Tim Kuipers
bcce1bd8a4
feat:setting inheritance diagram
2016-04-29 14:27:50 +02:00
Tim Kuipers
cda16c4429
Merge branch 'reflection_setting_inheritance_visualization'
2016-04-29 14:19:54 +02:00
Tim Kuipers
21a8afb895
fix: extruder train initialization M227 ==> G280 (CURA-520)
2016-04-28 17:05:32 +02:00
Tim Kuipers
0d7074ee8b
doc: documented stuff in gcodePlanner.h (CURA-537)
2016-04-28 17:01:48 +02:00
Tim Kuipers
8bb91cecb9
fix: dont switch extruder if there is no priontable support (CURA-1437)
2016-04-28 15:49:30 +02:00
Tim Kuipers
7aaf3b9bae
fix: dont switch extruder if there is no priontable model (CURA-1437)
2016-04-28 15:48:57 +02:00
Tim Kuipers
a806a27836
fix: sometimes the first layer could be totally empty / no walls (CURA-1465)
2016-04-26 18:28:05 +02:00
Tim Kuipers
d556999aed
fix: jedi header: save json machine name as if it is a setting and retrieve it for the header (CURA-520)
2016-04-25 17:57:45 +02:00
Tim Kuipers
9da99b67fc
fix: jedi header: PRINT.SIZE obtained from machine dimensions (CURA-520)
2016-04-25 17:15:55 +02:00
Tim Kuipers
4b02912ab6
fix: jedi header: BED ==> BUILD_PLATE (CURA-520)
2016-04-25 17:00:25 +02:00
Tim Kuipers
58234e4125
doc: Date documentation (CURA-520)
2016-04-25 16:45:21 +02:00
Tim Kuipers
e825637f14
feat: jedi header includes date stamp (CURA-520)
2016-04-25 16:41:31 +02:00
Tim Kuipers
242384bd28
Merge branch 'feature_jedi_cura_starting_state'
2016-04-25 13:21:46 +02:00
Tim Kuipers
b0cb94aeca
Merge branch 'feature_slicer_refactor_rebased' of https://github.com/Ultimaker/CuraEngine into feature_slicer_refactor_rebased
2016-04-22 17:21:58 +02:00
Tim Kuipers
95fc4695d2
fix: polylines got copied, const correctness and documentation in slicer.cpp (CURA-738)
2016-04-22 17:19:51 +02:00
Tim Kuipers
1f6f847b51
lil: inlined one line of code
2016-04-22 16:19:03 +02:00
Tim Kuipers
3e1b5128bb
lil: made polygon.shorterThan const (CURA-738)
2016-04-22 16:17:43 +02:00
Tim Kuipers
b88ee700fc
refactor: moved implementation to cpp file for polygon.shorterThan (CURA-738)
2016-04-22 16:16:15 +02:00
Tim Kuipers
b43b98da25
bugfix: polygon.shorterThan didn't take last line segment into account (CURA-738)
2016-04-22 16:07:43 +02:00
Ghostkeeper
ecdb4f7879
Codestyle: Space after control statement
...
Contributes to issue CURA-738.
2016-04-22 15:24:21 +02:00
Ghostkeeper
20ef9ce1c0
Codestyle: Space after control statement, always use brackets
...
Contributes to issue CURA-738.
2016-04-22 14:33:32 +02:00
Ghostkeeper
aec58f7e00
Codestyle: Space around operators and after control statement
...
Contributes to issue CURA-738.
2016-04-22 14:06:01 +02:00
Tim Kuipers
7dca18fe6a
removed debugging code
2016-04-21 14:35:39 +02:00
Tim Kuipers
dc761c2f57
lil: removed commented code
2016-04-21 13:47:18 +02:00
Tim Kuipers
059c97b2cd
refactor: moved implementation in Meshgroup.h to cpp file (CURA-520)
2016-04-21 13:46:01 +02:00
Tim Kuipers
d14e05f318
refactor: jedi ==> griffin (CURA-520)
2016-04-21 13:31:39 +02:00
Tim Kuipers
a533559918
fix: combing always went to closest point to origin, instead of crossing_1_in_or_mid (CURA-579)
2016-04-21 10:42:47 +02:00
Tim Kuipers
78ca299380
quickfix: set temperature during priming (CURA-520)
2016-04-20 17:13:26 +02:00
Tim Kuipers
1d581c0fec
fix: only reset E-value after toolswitch (CURA-520)
...
Given that having an G92 E0 at the start of the first use of a toolhead is no problem in any printer, we can just reset the E-value every start of a toolhead
2016-04-20 14:53:06 +02:00
Tim Kuipers
d0c58acfcf
rebase fixes
2016-04-20 13:13:57 +02:00
Tim Kuipers
7b90354033
refactor: renaming local vars and rewrite of Remove all the tiny polygons
2016-04-20 13:10:30 +02:00
Tim Kuipers
5c4fdfdd0b
refactor: renamed clipper polygon to path
2016-04-20 13:10:30 +02:00
Tim Kuipers
c8051f5b37
refactor: renaming local vars
2016-04-20 13:10:30 +02:00
Tim Kuipers
fa203bd976
refactor: some functions moved and extensive stitching moved to its own function
2016-04-20 13:10:30 +02:00
Tim Kuipers
4d2e544be0
refactor: renamed clipper polygon to path
2016-04-20 13:10:30 +02:00
Tim Kuipers
bd27011107
bugfix: lil)
2016-04-20 13:08:04 +02:00
Tim Kuipers
fb3c99ebe0
changed stitching poly decision
2016-04-20 13:08:03 +02:00
Tim Kuipers
2a8a86aac4
refactor: moved first stitching out of slicer
2016-04-20 13:08:03 +02:00
Tim Kuipers
4fa497ee8c
bugfix: slicer didn't connect anything
2016-04-20 13:08:03 +02:00
Tim Kuipers
76eaeeb196
refactored first part of slicer: connect segments
2016-04-20 13:08:03 +02:00
Tim Kuipers
9cebeb770a
Merge branch 'feature_combing_refactor'
2016-04-20 10:35:35 +02:00
Tim Kuipers
a0200f1548
Merge branch 'feature_combing_refactor'
2016-04-20 10:32:46 +02:00
Tim Kuipers
83164fe1e7
fix: don't recalculate line distance in the engine (CURA-1317)
2016-04-19 17:30:43 +02:00
Tim Kuipers
f9f162383b
removed old test stls and gcode files
2016-04-19 16:41:59 +02:00
Tim Kuipers
403f7515b8
fix: forgot ProgressStageEstimator.h (CURA-873)
2016-04-18 17:38:38 +02:00
Tim Kuipers
a0aa69f8b0
fix: forgot ConicalOverhang.h (CURA-1412)
2016-04-18 17:34:57 +02:00
Tim Kuipers
969ed87600
refactor: moved ProgressStageEstimator implementation to cpp file (CURA-873)
2016-04-18 17:30:22 +02:00
Tim Kuipers
a2dccb118c
Merge branch 'feature_progress_refactor_folder_refactor'
2016-04-18 17:23:38 +02:00
Tim Kuipers
64e5c5b8bf
Merge branch 'feature_progress_refactor'
2016-04-18 17:22:46 +02:00
Tim Kuipers
8bb2a6ba7f
refactor: moved progress files into separate folder (CURA-873)
2016-04-18 17:21:53 +02:00
Tim Kuipers
da38e958ac
Merge branch 'feature_rework_fffPolygonProcessor_per_mesh'
2016-04-18 17:02:49 +02:00
Tim Kuipers
081a46118c
refactor: merged writeRetraction and writeRetraction_extruderSwitch (CURA-1431)
2016-04-18 15:45:00 +02:00
Tim Kuipers
bd006e676b
feat: zHop during extruder switch (CURA-1431)
2016-04-18 15:28:26 +02:00
Tim Kuipers
afc40e1c70
refactor: moved extruder switch member values into normal RetractionConfig (CURA-1431)
2016-04-18 15:27:26 +02:00
Tim Kuipers
cc6583b214
fix: writeRetraction did early exit sometimes when going from normal retracted to extruder switch retracted (CURA-1431)
2016-04-18 15:25:26 +02:00
Tim Kuipers
55fbd2ba54
refactor: extruder_attr[current_extruder] ==> extr_attr (CURA-1431)
2016-04-18 14:55:02 +02:00
Tim Kuipers
916d26417f
fix: unretraction speeds were wrong when going from exdtruder switch retraction state to normal retraction state (CURA-1431)
2016-04-18 14:54:11 +02:00
Tim Kuipers
258a7e6f37
fix: let LayerplanBuffer decide the starting temperature (CURA-520)
...
That way flow dependent temperature decides on the starting temperature when using the command sucket
2016-04-18 13:39:43 +02:00
Tim Kuipers
d5f13616c2
refactor: moved meshgroup_number to FffProcessor (CURA-520)
2016-04-18 11:44:57 +02:00
Tim Kuipers
54c7f942c4
fix: no more temp commands at start for Jedi gcode (CURA-520)
2016-04-18 11:07:57 +02:00
Tim Kuipers
f63d78357b
feat: conical ocerhang (CURA-1412)
2016-04-15 20:05:27 +02:00
Tim Kuipers
bd565ab000
fix: don't zero extruder value after toolchange (CURA-959)
2016-04-14 18:09:29 +02:00
Tim Kuipers
fc24ce974d
feat: jedi prime gcode commands (CURA-520)
...
priming is now perfored by moving to a location, perform the prime gcode, retract, switch extruder, same for other extruder
2016-04-14 15:50:23 +02:00
Tim Kuipers
7a7c824b0d
refactor: moved preSetup implementation to cpp file (CURA-520)|
2016-04-14 14:24:14 +02:00
Tim Kuipers
a4227db5b1
fix: also set initial temps when doing wireprinting (CURA-520)
2016-04-14 14:21:58 +02:00
Tim Kuipers
7fdc77c74c
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-04-14 14:10:09 +02:00
Tim Kuipers
508b1b2933
machine extruder trains now can't be an array anymore (CURA-494)
2016-04-14 14:09:58 +02:00
Tim Kuipers
387ef30ca1
machine extruder trains now can't be an array anymore (CURA-494)
2016-04-14 13:21:00 +02:00
Tim Kuipers
1b6df75591
fix: jedi header (CURA-520)
2016-04-14 11:26:02 +02:00
Tim Kuipers
53ccadbf91
feat: const preserving getExtruderTrain function (CURA-520)
2016-04-14 11:23:05 +02:00
Tim Kuipers
612f6cac3d
fix: extruder trains didn't get properly initialized when one-at-a-time printing with command line slicing
2016-04-14 11:16:45 +02:00
Tim Kuipers
166601492b
fix: always prepend bogus header to fool firmware into accepting the print (CURA-520)
...
this was done so that Jedi gcode also always includes a header
it also means that UMO gcode always gets a header, which is ok, as it is ignored by that firmware
2016-04-13 16:13:43 +02:00
Ghostkeeper
e0de929c5b
Codestyle: Spaces around operators
...
Contributes to issue CURA-494.
2016-04-13 14:54:07 +02:00
Tim Kuipers
7ac4738435
feat: JEDI gcode flavor (CURA-520)
2016-04-13 13:07:11 +02:00
Tim Kuipers
4c547b9a66
fix const problem in BucketGrid2D (CURA-893)
2016-04-12 17:09:06 +02:00
Tim Kuipers
7ca184fb78
fix merge conflicts (CURA-893)
2016-04-12 16:53:00 +02:00
Tim Kuipers
080663a653
moved polygonUtilsTest (CURA-893)
2016-04-12 16:51:55 +02:00
Tim Kuipers
cc54c8be08
Merge branch 'feature_skin_and_dual_combing' into feature_skin_and_dual_combing_merge
2016-04-12 16:49:38 +02:00
Tim Kuipers
c19f35ce13
fix: writeRetraction didn't unretract if already retracted more (CURA-959)
2016-04-12 15:25:06 +02:00
Tim Kuipers
983720cfc0
fix: G92 E0 wasn't performed after the nozzle switch (CURA-959)
2016-04-12 15:24:16 +02:00
Tim Kuipers
cad745f0b5
fix: infill_overlap ==> infill_overlap_mm (CURA-786)
2016-04-11 19:06:55 +02:00
Tim Kuipers
2a10954df2
lil fix: __cxx11::string ==> string
2016-04-09 01:55:11 +02:00
Tim Kuipers
7eded0ba3c
Merge branch 'bugfix_support_z_xy_fight'
2016-04-08 14:39:13 +02:00
Tim Kuipers
ca963d5da0
Merge branch 'bugfix_getSetting_calls'
2016-04-08 14:12:51 +02:00
Tim Kuipers
7091650876
Merge branch '2.1'
2016-04-08 13:36:26 +02:00
Tim Kuipers
93485cd0df
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-04-06 17:09:16 +02:00
Tim Kuipers
2d3382874a
fix: polygon smoothing removed vertices which were connected to a small as well as a large line segment (CURA-1361)
2016-04-06 17:09:05 +02:00
Tim Kuipers
1e78397e18
fix: support max layer was set after each object (CURA-1360)
2016-04-06 17:05:33 +02:00
Ghostkeeper
6bcdd94f7e
Copy protocol file from front-end
...
This synchronises the whitespace and comments from the front-end. The typeids are not necessary any more.
Contributes to issue CURA-1210.
2016-04-05 17:14:09 +02:00
Ghostkeeper
accd28db64
Update documentation of sendLayerData
...
Contributes to issue CURA-1210.
2016-04-05 17:13:57 +02:00
Ghostkeeper
1c0f4c42d9
Remove superfluous set to nullptr
...
Shared pointers are already set to nullptr by default.
Contributes to issue CURA-1210.
2016-04-05 17:13:47 +02:00
Ghostkeeper
5da1632d9f
Remove sliced object lists from protocol
...
Each layer is now sent individually, instead of grouped by object and grouping those objects in a sliced object list. The list was sometimes too large to send in one message. The objects weren't used by the front-end anyway.
Contributes to issue CURA-1210.
2016-04-05 17:13:37 +02:00
Ghostkeeper
cbf1152f56
Remove object ID from layer
...
Turns out that it is not needed in the front-end either any more. If we need it in the future, we'll add it again.
Contributes to issue CURA-1210.
2016-04-05 17:13:22 +02:00
Ghostkeeper
2273c5aefe
Alter protocol to no longer group sliced objects
...
They will be sent with one message per layer from now on.
Contributes to issue CURA-1210.
2016-04-05 17:13:09 +02:00
Tim Kuipers
991adf19a1
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-04-05 11:49:07 +02:00
Tim Kuipers
9a4e1b52ed
fix: always zero E value before AND after nozzle switch (CURA-959)
2016-04-05 10:53:25 +02:00
Ghostkeeper
98d2786dd0
Merge branch '2.1'
...
Conflicts:
src/gcodeExport.h
src/gcodePlanner.cpp
src/utils/LinearAlg2D.cpp
2016-04-04 19:03:33 +02:00
Tim Kuipers
46c793e73d
fix: lil string vs c_str bug (CURA-1231)
2016-04-04 14:15:14 +02:00
Tim Kuipers
fd4969887b
refactor: replaced all gcode output \n by new_line (CURA-1231)
2016-04-04 14:13:32 +02:00
Tim Kuipers
6620a050a5
feat: new_line string used for BFB machines (CURA-1231)
2016-04-04 14:13:10 +02:00
Tim Kuipers
6325197fce
feat/refactor: moved file header generation to gcodeExport and introduced the NOZZLE_SIZE header comment (CURA-1231)
2016-04-04 14:03:38 +02:00
Tim Kuipers
f828d44365
Merge branch 'feature_better_time_estimates' into 2.1
2016-04-04 12:14:19 +02:00
Tim Kuipers
5072995a66
documentation (CURA-537)
2016-04-04 12:06:28 +02:00
Tim Kuipers
a8ab0c12aa
code style: space after keyword
2016-03-30 17:44:36 +02:00
Tim Kuipers
09c989a019
code style: spaces around operators
2016-03-30 17:17:12 +02:00
Tim Kuipers
29564a23e0
refactor: introduced mm, mm3, E value conversion functions instead of inline is_volumetric checks (CURA-1293)
2016-03-30 12:35:11 +02:00
Tim Kuipers
1fdda3319f
fix: volumetric time estimation was bugged (CURA-1293)
2016-03-30 12:24:27 +02:00
sean041
be113eceb4
Fix typo. downSkinCount -> upSkinCount (CURA-1299)
...
This typo causes flaky crash when downSkinCount < upSkinCount and ignore small z gaps is disabled.
2016-03-30 10:24:58 +02:00
Tim Kuipers
0b3b8ea33b
Merge pull request #323 from sean041/patch-1
...
Fix typo. downSkinCount -> upSkinCount (CURA-1299)
this caused a crash when Ignore small z gaps was disabled and bottom was smaller than top thickness
2016-03-30 10:22:29 +02:00
Tim Kuipers
0c42ff9bfa
fix: inner (2nd) wall was refered to even if it wasn't generated (CURA-1294)
2016-03-29 15:18:47 +02:00
sean041
a5bd599ec7
Fix typo. downSkinCount -> upSkinCount
...
This typo causes flaky crash when downSkinCount < upSkinCount.
2016-03-26 08:07:36 +08:00
Ghostkeeper
7548c41d7b
Simplify test case
...
This test case now reduces to the normal test cases since there is only one option again. We can re-use the function that was made for normal test cases then.
Contributes to issue CURA-579.
2016-03-25 16:41:08 +01:00
Tim Kuipers
cd033ef6ab
doc: autobrief for first line (CURA-537)
2016-03-24 17:50:12 +01:00
Tim Kuipers
e909af9abd
documentation for fffProcessor (CURA-537)
2016-03-24 17:34:02 +01:00
Tim Kuipers
dd5fbf14e4
document FffGcodeWriter (CURA-537)
2016-03-24 16:59:09 +01:00
Tim Kuipers
168e041c42
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-03-24 15:58:16 +01:00
Ghostkeeper
670ae6dd8c
Spaces around minus operator
...
Conforming to code style.
Contributes to issue CURA-863.
2016-03-24 15:58:11 +01:00
Tim Kuipers
20adfa751f
doc+refactor: fan speed calc more clear (CURA-863)
2016-03-24 15:57:54 +01:00
Tim Kuipers
bf8776b112
optimization: removed superluous recalculation of line direction in LineOrderOptimizer (CURA-1170)
2016-03-23 16:25:10 +01:00
Tim Kuipers
1d0f3f519a
fix syntax mistake (CURA-1170)
2016-03-23 16:25:01 +01:00
Tim Kuipers
07fef8668c
calculate incoming_perpundicular_normal in end stage of line order optimizer (CURA-1170)
2016-03-23 16:24:51 +01:00
Tim Kuipers
1c06fc49fc
refactor: factor out getAngleScore from line order optimizer (CURA-1170)
2016-03-23 16:24:39 +01:00
Tim Kuipers
beb9422d9b
refactor: clear up pathOrderOptimizer for lines (CURA-1170)
2016-03-23 16:24:27 +01:00
Tim Kuipers
a8359b9a68
refactor: small optimization of line order optimizer dot score (CURA-1170)
2016-03-23 16:24:17 +01:00
Tim Kuipers
5ccfe2d1aa
refactor: clear up pathOrderOptimizer for lines (CURA-1170)
2016-03-23 16:24:07 +01:00
Tim Kuipers
74577759b4
refactor: expand complicated code in pathOrderOptimizer (CURA-1170)
2016-03-23 16:23:54 +01:00
Tim Kuipers
45eb026777
refactor: rewrite line order optimizer dot score stuff (CURA-1170)
2016-03-23 16:23:42 +01:00
Tim Kuipers
aabb07fd81
refactor: simple renaming of incoming_perpendicular_normal (CURA-1170)
...
Conflicts:
src/pathOrderOptimizer.cpp
2016-03-23 16:23:21 +01:00
Ghostkeeper
6377ec63e1
Add edge-case tests for getAngleLeft
...
These test what happens when two or more points are equal. There is nothing about this in the function specification, so it allows any output, but at least it shouldn't give like a divide by zero error.
Contributes to issue CURA-1170.
2016-03-23 16:14:11 +01:00
Tim Kuipers
eab2d8e667
fix: improved dot-score for preferring the z-seam on inside corners (CURA-1170)
2016-03-23 16:13:58 +01:00
Tim Kuipers
8d41003c67
feat: linearAlg2D::getAngleLeft CMAKE (CURA-1170)
2016-03-23 16:13:48 +01:00
Tim Kuipers
ecfae4d75c
feat: linearAlg2D::getAngleLeft (CURA-1170)
2016-03-23 16:13:37 +01:00
Tim Kuipers
a2208f6b69
fix: pathOrderOptimizer was bugged (CURA-1170)
...
polyStart indices used wrongly
2016-03-23 16:13:26 +01:00
Tim Kuipers
bacacb01dc
refactor: more cleanup of pathOrderOptimizer (CURA-1170)
2016-03-23 16:13:15 +01:00
Tim Kuipers
94c9399f2c
refactor: intpoint::crossZ ==> turn90CCW (CURA-1170)
2016-03-23 16:13:03 +01:00
Tim Kuipers
168dc3c12b
refactor: more cleanup of pathOrderOptimizer (CURA-1170)
2016-03-23 16:12:53 +01:00
Tim Kuipers
235af65b00
refactor: code cleanup helper functions of PathOrderOptimizer (CURA-1170)
2016-03-23 16:12:43 +01:00
Tim Kuipers
f3f3be74cc
refactor: code cleanup of PathOrderOptimizer - lines (CURA-1170)
2016-03-23 16:12:32 +01:00
Tim Kuipers
dca0bc80b5
fix: PathOrderOptimizar::polyStart had wrong indexing (CURA-1170)
2016-03-23 16:12:18 +01:00
Tim Kuipers
c0e57622d0
cleanup: more clarification of pathOrderOptimizer for polygons code (CURA-1170)
2016-03-23 16:12:04 +01:00
Tim Kuipers
b7a8fbe798
cleanup: pathOrderOptimizer got cleaned up (CURA-1170)
2016-03-23 16:11:49 +01:00
Ghostkeeper
0985b97c54
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-03-23 16:08:58 +01:00
Tim Kuipers
06521eef8b
lil
2016-03-23 12:32:44 +01:00
Tim Kuipers
47a6f0dc36
fix: made it possible to include warning and error functions in the graph; changed the way you should call the tool
2016-03-23 11:50:39 +01:00
Tim Kuipers
4353980e78
refactor: made code more explicit: after smoothing speed (towards bottom layer speed) the speeds are set to their iconic speeds once and for all (CURA-1248)
2016-03-22 17:20:38 +01:00
Tim Kuipers
18ae9cf41d
bugfix: alternate extra wall had skin overlapping with inner wall (CURA-1233)
...
To see if there was infill above, we looked at the innermost wall instead of the wall with index [wall line count]
2016-03-22 13:42:32 +01:00
Tim Kuipers
04edf35331
bugfix: bottom layer speed influenced all layers (CURA-1248)
...
smoothSpeed never got called for the final speed
2016-03-22 13:21:03 +01:00
Tim Kuipers
ce4d34adb2
unit test fix: moveInside(polys, points, dist) may leave inside points as they are (CURA-579)
2016-03-21 17:51:38 +01:00
Tim Kuipers
d42be2a22c
removed old unused code
2016-03-21 17:29:22 +01:00
Tim Kuipers
dbcbcae2e3
codestyle: closestHere ==> closest_here (CURA-893)
2016-03-21 17:26:04 +01:00
Tim Kuipers
ff9cb24d99
refactor: auto ==> ClipperLib::Path (CURA-893)
2016-03-21 17:23:19 +01:00
Tim Kuipers
b8ff36651e
fix: tests failed due to changed GcodePlanner constructor (CURA-893)
...
combing changed from boolean to an enum
boolean is_inside_mesh was added
2016-03-21 17:16:24 +01:00
Tim Kuipers
98a78e1844
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-03-21 12:30:52 +01:00
Tim Kuipers
37c8ad3061
lil (CURA-1217)
2016-03-21 12:28:56 +01:00
Tim Kuipers
d2187fedbc
optimization: removed superluous recalculation of line direction in LineOrderOptimizer (CURA-1170)
2016-03-21 12:17:20 +01:00
Tim Kuipers
5b0a50456f
fix syntax mistake (CURA-1170)
2016-03-21 11:55:01 +01:00
Tim Kuipers
66f4b51a3e
calculate incoming_perpundicular_normal in end stage of line order optimizer (CURA-1170)
2016-03-21 11:53:33 +01:00
Tim Kuipers
3ac6ee1b37
refactor: factor out getAngleScore from line order optimizer (CURA-1170)
2016-03-21 11:43:12 +01:00
Tim Kuipers
4d8b22a224
refactor: clear up pathOrderOptimizer for lines (CURA-1170)
2016-03-21 11:36:08 +01:00
Tim Kuipers
3a0143ff4c
refactor: small optimization of line order optimizer dot score (CURA-1170)
2016-03-21 11:33:26 +01:00
Tim Kuipers
c6a4945469
refactor: clear up pathOrderOptimizer for lines (CURA-1170)
2016-03-21 11:21:08 +01:00
Tim Kuipers
abc6514b6d
refactor: expand complicated code in pathOrderOptimizer (CURA-1170)
2016-03-21 11:05:01 +01:00
Tim Kuipers
dc26358747
refactor: rewrite line order optimizer dot score stuff (CURA-1170)
2016-03-21 10:52:23 +01:00
Tim Kuipers
3485e5a4ad
refactor: simple renaming of incoming_perpendicular_normal (CURA-1170)
2016-03-21 10:34:55 +01:00
Tim Kuipers
bd47fd2c67
removed unused old commented code
2016-03-21 10:24:42 +01:00
Tim Kuipers
d7d957d8f7
Removed unused code
2016-03-19 16:17:02 +01:00
Ghostkeeper
bec8c235ea
Add edge-case tests for getAngleLeft
...
These test what happens when two or more points are equal. There is nothing about this in the function specification, so it allows any output, but at least it shouldn't give like a divide by zero error.
Contributes to issue CURA-1170.
2016-03-18 14:12:51 +01:00
Ghostkeeper
eb1bbd41b0
Codestyle: Spaces around binary operators
...
Contributes to issue 1170.
2016-03-18 13:07:28 +01:00
Tim Kuipers
49f2f21c08
feat: linearAlg2D::getAngleLeft (CURA-1170)
2016-03-17 17:40:53 +01:00
Tim Kuipers
9ed25b95ee
fix: improved dot-score for preferring the z-seam on inside corners (CURA-1170)
2016-03-17 17:39:38 +01:00
Tim Kuipers
c8b8abd4c6
feat: linearAlg2D::getAngleLeft CMAKE (CURA-1170)
2016-03-17 17:39:38 +01:00
Ghostkeeper
37c461fa86
Merge branch '2.1'
...
Conflicts:
src/FffGcodeWriter.cpp
src/inset.cpp
src/pathOrderOptimizer.cpp
2016-03-17 15:43:03 +01:00
Tim Kuipers
7d9c8ee1b1
fix: pathOrderOptimizer was bugged (CURA-1170)
...
polyStart indices used wrongly
2016-03-17 09:45:28 +01:00
Tim Kuipers
5df73e0e30
refactor: more cleanup of pathOrderOptimizer (CURA-1170)
2016-03-16 16:59:40 +01:00
Tim Kuipers
5d8926e3e7
refactor: intpoint::crossZ ==> turn90CCW (CURA-1170)
2016-03-16 15:43:49 +01:00
Tim Kuipers
277c478e3b
refactor: more cleanup of pathOrderOptimizer (CURA-1170)
2016-03-16 15:38:59 +01:00
Tim Kuipers
6f654241f7
refactor: code cleanup helper functions of PathOrderOptimizer (CURA-1170)
2016-03-16 15:17:17 +01:00
Tim Kuipers
62910c9d0a
refactor: code cleanup of PathOrderOptimizer - lines (CURA-1170)
2016-03-16 15:13:36 +01:00
Tim Kuipers
f92ee17577
fix: PathOrderOptimizar::polyStart had wrong indexing (CURA-1170)
2016-03-16 15:02:15 +01:00
Tim Kuipers
dc3d94e0a8
cleanup: more clarification of pathOrderOptimizer for polygons code (CURA-1170)
2016-03-16 15:01:25 +01:00
Tim Kuipers
6c9db68573
cleanup: pathOrderOptimizer got cleaned up (CURA-1170)
2016-03-16 14:53:54 +01:00
Tim Kuipers
fc046d5978
fixed visualization stuff for only doing parent-child or inheritance
2016-03-16 13:48:22 +01:00
Tim Kuipers
2bd8657050
vizualize dependence of child on parent via inheritance function as normal parent-child relation
2016-03-16 13:34:21 +01:00
Tim Kuipers
6718a8b2f3
fix: made engine not depend on support_z_distance, which is a parent setting value (CURA-1171)
2016-03-16 09:36:05 +01:00
Tim Kuipers
08c69ca589
child-parent arrow color overrides inheritance
2016-03-16 09:29:35 +01:00
Tim Kuipers
a3d17d217a
DSg
2016-03-15 18:23:11 +01:00
Tim Kuipers
e47fcea2bf
sdg
2016-03-15 18:21:11 +01:00
Tim Kuipers
ad3903037c
how to use this branch
2016-03-15 18:15:34 +01:00
Ghostkeeper
f7cdd63f1d
Codestyle: Whitespace around operators
...
Space around binary operators. No space around unary operators.
Contributes to issue CURA-1098.
2016-03-15 12:18:54 +01:00
Tim Kuipers
3400439f5d
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2016-03-15 10:18:07 +01:00
Tim Kuipers
5fbf9a8907
made outer wall offset a setting instead of being calculated from the difference between nozzle size and wall_line_width_0 (CURA-1098)
2016-03-15 10:00:01 +01:00
Ghostkeeper
df6d2fc592
Codestyle: Whitespace around binary operators
...
Contributes to issue CURA-1097.
2016-03-14 16:50:10 +01:00
Ghostkeeper
08a5ec7dee
Codestyle: Whitespace around binary operators
...
Contributes to issue CURA-1097.
2016-03-14 16:45:56 +01:00
Ghostkeeper
3de01763c1
Codestyle: Whitespace around binary operators.
...
Contributes to issue CURA-1097.
2016-03-14 16:41:34 +01:00
Tim Kuipers
7fc18c2057
made combing depend on inner wall line width instead of nozzle_size (CURA-1097)
2016-03-14 13:21:05 +01:00
Tim Kuipers
c7bf1e087a
made rafts' combing not depend on nozzle_size (CURA-1097)
2016-03-14 13:16:04 +01:00
Tim Kuipers
bc7ee74d19
made combing depend on inner wall line width instead of nozzle_size (CURA-1097)
2016-03-14 11:02:32 +01:00
Tim Kuipers
fc20a6661b
made rafts' combing not depend on nozzle_size (CURA-1097)
2016-03-14 10:37:46 +01:00
Ghostkeeper
cffd6ac860
Spaces around minus operator
...
Conforming to code style.
Contributes to issue CURA-863.
2016-03-10 12:13:26 +01:00
Tim Kuipers
81d521a58b
quickfix: remove outer wall offset based on nozzle size (CURA-1097)
2016-03-10 09:56:18 +01:00
Ghostkeeper
205c4f8cc9
Add test for new filter function
...
Contributes to issue CURA-590.
2016-03-09 14:38:23 +01:00
Ghostkeeper
c797163536
Add more tests for findNearestObject
...
Contributes to issue CURA-590.
2016-03-09 14:28:14 +01:00
Ghostkeeper
d31acdb244
Add first test for findNearestObject
...
Contributes to issue CURA-590.
2016-03-09 14:07:55 +01:00
Ghostkeeper
810f689418
Add tests for a group of points on a line
...
Contributes to issue CURA-590.
2016-03-09 13:02:41 +01:00
Ghostkeeper
7270290fe3
Improve findNearbyObjects test template
...
It now allows for some points for which the answer (near or far) is indeterminate.
Contributes to issue CURA-590.
2016-03-09 12:28:39 +01:00
Ghostkeeper
37e3114311
Add two simple tests for BucketGrid2D::findNearbyObjects
...
Contributes to issue CURA-590.
2016-03-09 12:16:16 +01:00
Ghostkeeper
c3ef64fe18
Add initial test case for BucketGrid2D::findNearbyObjects
...
This is just an initial test and the testing framework for this unit.
Contributes to issue CURA-590.
2016-03-09 12:09:03 +01:00
Ghostkeeper
5d592553a6
Add test directory for infill
...
To make it complete for future tests that might appear there.
2016-03-09 11:00:03 +01:00
Ghostkeeper
38fad10453
Move utils tests to subdirectory
...
This keeps the same directory structure in the tests directory as in the source directory, as is common.
2016-03-09 10:50:10 +01:00
Tim Kuipers
c4eb1d9f27
bugfix: uninitialised infill (CURA-1084)
...
not always did the basic infill_area get initialised, notably when there was no infill, which should be an empty polygon instead of no polygon
2016-03-08 17:52:12 +01:00
Ghostkeeper
1c16c77d56
Add test cases for moveInside
...
One of the edge cases currently fails.
Contributes to issue CURA-579.
2016-03-08 17:28:09 +01:00
Tim Kuipers
883f0c7419
current setting inheritance structure
2016-03-07 13:50:51 +01:00
Tim Kuipers
bc11121a2e
feat: ouput json inheritance structure
2016-03-07 13:50:51 +01:00
Tim Kuipers
0dbf80587b
Merge branch '2.1'
2016-03-07 09:50:02 +01:00
Tim Kuipers
32d1bb6d75
bugfix: one-at-a-time printing went to z height of last position planned on the previous object (CURA-988)
2016-03-02 13:55:46 +01:00
Tim Kuipers
afdb552f63
bugfix: retraction limitation segfaulted when retraction count == 1, cause it handled retraction count as if it was [retraction count - 1] (CURA-977)
2016-03-01 13:18:53 +01:00
Tim Kuipers
a400ba28f2
fix: supportOnByuildplateOnly didn't account for conical support (CURA-914)
2016-03-01 12:06:54 +01:00
Tim Kuipers
d18843abe3
fix: all settings now implicitly retrieved from meshgroup instead of explicitly (CURA-927)
2016-02-29 13:58:15 +01:00
Tim Kuipers
ea12d310b0
fix: all settings retrieved from meshgroup instead of globally (CURA-927)
2016-02-29 13:54:36 +01:00
Tim Kuipers
b993e4aff1
fix: support_roof_height was retrieved globally and per mesh - now only per mesh (CURA-956)
2016-02-29 13:39:35 +01:00
Tim Kuipers
e0a7818d9e
fix: infill wipe distance also on skin (CURA-964)
2016-02-29 13:03:42 +01:00
Tim Kuipers
277b5dce75
fix: get infill sparse combine per mesh (CURA-949)
2016-02-29 12:21:11 +01:00
Tim Kuipers
462a6e8c16
bugfix: skin didn't overlap with walls (CURA-941)
2016-02-29 12:16:02 +01:00
Tim Kuipers
20701117fb
fix: support line width retrieved from same settings base everywhere (globally) (CURA-956)
2016-02-29 11:29:40 +01:00
Tim Kuipers
a40d48c1be
fix: initial layer speed for support requested from extruder train (CURA-956)
2016-02-29 11:18:20 +01:00
Tim Kuipers
d7e966ad83
Merge branch 'analog10-master'
2016-02-29 10:40:58 +01:00
Tim Kuipers
593dd03987
Merge branch 'master' of https://github.com/analog10/CuraEngine into analog10-master
2016-02-29 10:37:19 +01:00
Tim Kuipers
07203c9d91
lil: removed unused const-incorrect function
2016-02-29 09:25:31 +01:00
David Bender
59e6a075e8
made a few intpoint methods const
2016-02-26 11:37:57 -05:00
David Bender
3f348ab1ba
more const correctness for MeshGroup
2016-02-26 11:34:05 -05:00
David Bender
44fedbae7a
make fpoint and fmatrix methods const
2016-02-26 11:33:29 -05:00
David Bender
77a378ba1c
const cleanups in the Mesh class
2016-02-26 11:24:57 -05:00
David Bender
4f408847fb
make members of settingRegistry.h const
2016-02-26 11:20:27 -05:00
Tim Kuipers
8d941063c1
fix: get raft settings from extruder train settingsbase; get extruder_nr settings with getSettingAsIndex instead of getSettingAsCount (CURA-956)
2016-02-25 20:04:56 +01:00
Tim Kuipers
471d20ff75
fix: print temp at startingCode based on extrudertrain settingsbase & lil bugfix '->' ==> '.' (CURA-956)
2016-02-25 19:55:59 +01:00
Tim Kuipers
b82d6f9aff
fix: retrieve machine_nozzle_size from extruder (CURA-956)
2016-02-25 18:41:24 +01:00
Tim Kuipers
277e1581d0
fix: retrieve all layer_height and layer_height_0 settings from meshgroup or global settings (CURA-956)
2016-02-25 18:32:35 +01:00
Tim Kuipers
d4b128e0f3
fix: retrieve all layer_height settings from meshgroup or global settings (CURA-956)
2016-02-25 18:30:40 +01:00
Tim Kuipers
eec65df83e
refactored SliceMeshStorage storage ==> mesh (CURA-956)
2016-02-25 18:15:08 +01:00
Tim Kuipers
78e1c3114d
refactor: introduce getSettingInMillimeters (CURA-956)
2016-02-25 18:07:39 +01:00
Tim Kuipers
5941d2252c
fix: get infill sparse combine per mesh (CURA-949)
2016-02-25 10:21:44 +01:00
Tim Kuipers
6897a87584
fix: infill direction switch every two layers when infill_sparse_thickness is 2 layers and pattern is lines (CURA-943)
2016-02-25 09:49:51 +01:00
David Bender
cc2bb36fb4
getSetting functions should be const
2016-02-24 11:01:57 -05:00
David Bender
0ea387a6f0
min/max functions should be const
2016-02-24 11:01:16 -05:00
Tim Kuipers
14a01a6253
fix: supportOnByuildplateOnly didn't account for conical support (CURA-914)
2016-02-24 16:07:32 +01:00
Tim Kuipers
c20d35e293
fix: used adress comparison on ListPolygons instead of in depth comparison (CURA-934)
2016-02-23 16:23:09 +01:00
Tim Kuipers
9e56841cd2
fix: explicitly deleted polygon comparison, cause it is inefficient, and you most likely need to compare either the memory adress or need to account for the fact that two different polygons might have a different starting point (CURA-934)
2016-02-23 16:21:30 +01:00
Tim Kuipers
c39e43c161
bugfix: combing shortcuts to end of comb move (CURA-893)
2016-02-23 15:38:33 +01:00
Tim Kuipers
421a6d4095
removed line from wrong cherry-pick (CURA-894)
2016-02-23 15:38:23 +01:00
Tim Kuipers
8497e46542
bugfix: moveInside always moved in the positive direction for the corner case (CURA-579)
2016-02-23 15:33:04 +01:00
Tim Kuipers
6510ebbd92
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-02-22 17:27:06 +01:00
Tim Kuipers
c1b4a5398b
bugfix: small zgaps no-heuristic bugfixes (CURA-921)
...
It didn't create the right amount of top and bottom layers and didn't work correctly on the topmost and bottom most layers.
2016-02-22 17:26:57 +01:00
Arjen Hiemstra
11c4b9339a
Store layer messages in a hash map to speed up lookups for layers
2016-02-22 17:23:17 +01:00
Tim Kuipers
75efbac68e
fix: cone angle sign inverted: more sensible fix (CURA-869)
2016-02-22 17:08:04 +01:00
Tim Kuipers
cd199dc43e
fix: cone angle sign inverted (CURA-869)
2016-02-22 16:50:27 +01:00
Tim Kuipers
e85eec54ec
bugfix: combing shortcuts to end of comb move (CURA-893)
2016-02-22 15:57:29 +01:00
Tim Kuipers
dcc4d956b2
feat: limit inside boundary to infill (CURA-694)
2016-02-22 15:35:12 +01:00
Tim Kuipers
91249dd012
refactor: infill_area ==> infill_area_per_combine; introduced infill_area for the whole infill area (CURA-694)
2016-02-22 15:34:39 +01:00
Tim Kuipers
4de1f1abdf
removed old unused function (CURA-694)
2016-02-22 15:32:48 +01:00
Tim Kuipers
59abad0197
feat: refactor combing from bool into enum; introduced noskin (CURA-694)
2016-02-22 15:31:54 +01:00
Tim Kuipers
0dc7e326c9
refactor: made combPath.throughAir a property of all combPaths (CURA-893)
2016-02-22 11:27:56 +01:00
Tim Kuipers
3271bde77e
lil
2016-02-19 16:13:03 +01:00
Tim Kuipers
7b71426839
refactor: const correctness loosely related to combing (CURA-893)
2016-02-19 15:30:29 +01:00
Tim Kuipers
27e3df2fbc
fix: one combing calc changed avoid_other_parts for the next (CURA-893)
2016-02-19 15:06:50 +01:00
Tim Kuipers
2e915039e6
fix: is_inside info is retained after layer switch (CURA-893)
2016-02-19 14:38:37 +01:00
Tim Kuipers
8262ff3ac6
refactor/fix: call setIsInside only in addMeshLayerToGcode (CURA-893)
2016-02-19 12:19:57 +01:00
Tim Kuipers
5cc0eb24ef
optimization: faster moveOutside - if possible (CURA-893)
2016-02-19 10:59:31 +01:00
Tim Kuipers
dad74e1cd6
fix: crossing_2_in_or_mid was based on itself instead of closest to crossing_1 (CURA-893)
2016-02-18 18:33:05 +01:00
Tim Kuipers
a878a7f091
fix: setIsInside bugs (CURA-893)
2016-02-18 18:27:48 +01:00
Tim Kuipers
53a543c548
lil
2016-02-18 17:26:15 +01:00
Tim Kuipers
0366b9df71
feat: skip crossing computation when boundary to boundary is already closer than twice the avoid distance (CURA-893)
2016-02-18 17:23:51 +01:00
Tim Kuipers
9c1f74fff1
fix: moveInside registered wrongly whether the point was already on the correct side of the boudary (CURA-893)
2016-02-18 16:49:52 +01:00
Tim Kuipers
1e0d416a5b
lil fix: wrong move outside distance for crossings for combing (CURA-893)
2016-02-18 16:46:39 +01:00
Tim Kuipers
4612c69ae3
feat: moveInside utility function; directly calls moveInside (CURA-893)
2016-02-18 15:57:17 +01:00
Tim Kuipers
916e0b221d
fix: larger admitted crossing dist for combing (CURA-893)
2016-02-18 15:51:16 +01:00
Tim Kuipers
a05d31456d
feat: also use dist from start to crossing when evaluating which crossing is the best (CURA-893)
2016-02-18 13:28:06 +01:00
Tim Kuipers
8d82b8b943
bugfix: lil mistake in combing second crossing (CURA-893)
2016-02-18 13:16:18 +01:00
Tim Kuipers
948c9b7054
refactor & fix: made findBestCrossing return ClosestPolygonPoints themselves which makes it easy to move inside/outisde with the offset_dist_to_get_from_on_the_polygon_to_outside (CURA-893)
2016-02-18 12:09:49 +01:00
Tim Kuipers
28d13b4aa1
bugfix: crossing dists were based on wrong value (CURA-893)
2016-02-18 12:07:59 +01:00
Tim Kuipers
0b0f85f9ff
bugfix: moveInside couldn't perform moving outside well (CURA-579)
2016-02-17 17:59:33 +01:00
Tim Kuipers
ef55f2ea11
bugfix: combing crossing computation refered to wrong crossing (CURA-579)
2016-02-17 17:23:56 +01:00
Tim Kuipers
692180e185
bugfix: combing crossing computation refered to wrong crossing (CURA-579)
2016-02-17 17:23:27 +01:00
Tim Kuipers
e25a681201
lil refactor (CURA-893)
2016-02-17 17:13:29 +01:00
Tim Kuipers
dca1beeba2
feat: combing: better finding of good crossing between inside and outide (CURA-893)
2016-02-17 16:45:22 +01:00
Tim Kuipers
d10fea3ee6
refactor: modified findClose(Polygon ,...) such that it returns pairs of points on the first and points on the second polygon (CURA-893)
2016-02-17 16:04:51 +01:00
Tim Kuipers
1e93ffd83b
feat: made Comb have an optional bucketGrid mapping from locations to line segments in the outside boundary (computed when needed) (CURA-893)
2016-02-17 15:56:44 +01:00
Tim Kuipers
d41b842b39
refactor: introduced some const correctness for BucketGrid (CURA-893)
2016-02-17 15:43:30 +01:00
Tim Kuipers
59c3047543
feat: introduced findClose for a whole polygon (CURA-893)
2016-02-17 15:41:15 +01:00
Tim Kuipers
b53f147b14
doc: findClosest & createLocToLineGrid (CURA-893)
2016-02-17 14:59:11 +01:00
Tim Kuipers
1768072cec
unittest: findClose (CURA-893)
2016-02-17 14:45:01 +01:00
Tim Kuipers
b2b4847b85
bugfix: findClose: end point of line segment was inserted instead of start point (CURA-893)
2016-02-17 14:43:09 +01:00
Tim Kuipers
3a832ef492
feat: findClose based on BucketGrid (CURA-893)
2016-02-17 12:33:00 +01:00
Tim Kuipers
03749e98ea
fix: BucketGrid.insert expected reference instead of an object (CURA-893)
2016-02-17 12:15:03 +01:00
Tim Kuipers
9e410e7007
lil include reorder
2016-02-17 12:01:23 +01:00
Tim Kuipers
beab605308
lil (CURA-579)
2016-02-16 17:35:46 +01:00
Tim Kuipers
9de4b7e939
fix: combing now uses correctly offsetted points from in_between (CURA-579)
2016-02-16 17:31:15 +01:00
Tim Kuipers
0d7710ecd1
refactor: made combing make use of new moveInside (CURA-579)
2016-02-16 17:21:22 +01:00
Tim Kuipers
fe7364c146
refactor: simplified moveInside code (CURA-579)
...
make use of getBoundaryPointWithOffset
2016-02-16 17:16:24 +01:00
Tim Kuipers
98b1fda1f1
lil (CURA-579)
2016-02-16 16:56:11 +01:00
Tim Kuipers
151bef23c9
tests: better moveInside tests for both moveInside functions (CURA-579)
2016-02-16 16:51:14 +01:00
Tim Kuipers
b9a411df10
bugfix: moveInside always moved in the positive direction for the corner case (CURA-579)
2016-02-16 16:43:43 +01:00
Tim Kuipers
0f53a7a231
tests of PolygonUtils::moveInside(ClosestPolygonPoint) (CURA-579)
2016-02-16 16:42:11 +01:00
Tim Kuipers
57ac6aa926
refactor: make new moveInside function work on ClosestPolygonPoint (CURA-579)
2016-02-16 14:47:00 +01:00
Tim Kuipers
2ba03ff1dc
fixes: improved moveInside function for when you already found the nearest polygon point (CURA-579)
2016-02-16 14:25:33 +01:00
Tim Kuipers
f59ca9c33e
fixes: moveInside function for when you already found the nearest polygon point (CURA-579)
2016-02-16 13:39:46 +01:00
Tim Kuipers
8fc6ee87ee
introduced moveInside function for when you already found the nearest polygon point (CURA-579)
2016-02-16 13:32:24 +01:00
Tim Kuipers
48707d95f7
refactor: some more renaming in combing (CURA-579)
2016-02-16 10:52:53 +01:00
Tim Kuipers
7a1a900d78
refactor: better naming for stuff like inside_middle_from (CURA-579)
2016-02-15 18:07:24 +01:00
Tim Kuipers
38c8941b59
Revert "fix: no move outside if it's a detour (CURA-579)"
...
This reverts commit f28cf53651 .
2016-02-15 17:18:34 +01:00
Tim Kuipers
df47cf8b2d
refactor: typo iddle ==> middle (CURA-579)
2016-02-15 17:13:51 +01:00
Tim Kuipers
f28cf53651
fix: no move outside if it's a detour (CURA-579)
2016-02-15 17:03:33 +01:00
Tim Kuipers
9d063d885c
refactor: code indentation for readability (CURA-579)
2016-02-15 16:57:07 +01:00
Tim Kuipers
3ec63017cc
refactor: getBoundaryOutside now returns ref instead of pointer, cause it ensures the return is instantiated (CURA-579)
2016-02-15 16:55:28 +01:00
Tim Kuipers
26dfd02b26
refactor: separate inside_middle_from computation from inside_middle_to comp (CURA-579)
2016-02-15 16:42:53 +01:00
Tim Kuipers
e177303c4b
Merge branch '2.1'
2016-02-15 15:20:30 +01:00
Ghostkeeper
4c1c43649d
Fix setting-crash test with function evaluation
...
The minimum value, maximum value, minimum warning value and maximum warning value of each setting is now evaluated as a function, preventing casting errors. Runtest.py runs without errors or even test failures again now.
Contributes to issue CURA-814.
2016-02-15 14:05:27 +01:00
Ghostkeeper
2372a78c9b
Fix setting-crash test with function evaluation
...
The minimum value, maximum value, minimum warning value and maximum warning value of each setting is now evaluated as a function, preventing casting errors. Runtest.py runs without errors or even test failures again now.
Contributes to issue CURA-814.
2016-02-15 12:54:44 +01:00
Tim Kuipers
d3f0a06ee0
lil TODO (CURA-833)
2016-02-12 12:09:37 +01:00
Ghostkeeper
4f524613fd
Merge pull request #304 from soyersoyer/master
...
fix build warnings
2016-02-12 09:51:34 +01:00
Tim Kuipers
f94c95dd97
bugfix: total layers got updated by infill mehses CURA-833
2016-02-11 21:21:23 +01:00
Tim Kuipers
07b7d84df2
bugfixes new progress system (CURA-873)
2016-02-11 20:56:35 +01:00
Tim Kuipers
97ee04c12b
lil fixes better progress estimator structure (CURA-873)
2016-02-11 20:13:21 +01:00
Tim Kuipers
18c7c6bdb9
fix: more secure layer indexing in infill mehses (CURA-833)
2016-02-11 20:01:38 +01:00
Tim Kuipers
e93770017f
refactor+cleanup for infill mehses (CURA-833)
2016-02-11 19:56:15 +01:00
Tim Kuipers
60e1f30c60
lil optimization: less splitIntoParts in processInfillMesh (CURA-833)
2016-02-11 19:47:56 +01:00
Tim Kuipers
d4844d08f2
lil refactor: processDerivedWallSkinInfill doesn't have argument TimeKeeper anymore (CURA-833)
2016-02-11 19:46:06 +01:00
Tim Kuipers
30df9853e4
bugfix: infill meshes had too much infill overlap (CURA-833)
2016-02-11 18:59:46 +01:00
Tim Kuipers
4ff00a8f73
first approximation infill meshes (CURA-833)
2016-02-11 18:25:45 +01:00
Tim Kuipers
f5b7cadcb5
refactor progress for better progress during skin and insets (CURA-873)
2016-02-11 17:44:24 +01:00
Tim Kuipers
17ca8fce0a
fix: progress fixed for fffPolygonProcessor refactor
...
CURA-872
there is no progress information during processing insets and skin of a single mesh
2016-02-11 16:44:48 +01:00
Tim Kuipers
dbdbec44cc
refactor: split up slices2polygons in functions which work on each mesh separately (CURA-872)
2016-02-11 16:21:50 +01:00
soyer
a9fdad71b4
SettingConfig’s parent is unused
2016-02-11 16:17:55 +01:00
soyer
9fb6a217a4
use the std::abs, it has a proper overload for the long long
2016-02-11 16:15:35 +01:00
soyer
c480c96066
this is a function declaration, and this is useless here
2016-02-11 16:13:38 +01:00
Tim Kuipers
1bcb38dcb6
Merge pull request #303 from soyersoyer/master
...
fix build in the without arcus case
2016-02-11 15:22:34 +01:00
soyer
0e7b164532
without arcus the code can’t send SlicingFinished message, so do nothing.
2016-02-11 12:11:34 +01:00
soyer
0f6bdfd36e
the static CommandSocket::instance should be set without arcus too
2016-02-11 12:08:22 +01:00
Tim Kuipers
4d79ea3e9e
doc+refactor: fan speed calc more clear (CURA-863)
2016-02-10 17:00:57 +01:00
Tim Kuipers
199fa070d6
feat: findNearestObject with extra conditions (CURA-590)
2016-02-10 11:43:46 +01:00
Tim Kuipers
ef1dece5d2
fix: BucketGrid2D: disregard bucket-collision items in findNearbyObjects (CURA-590)
2016-02-10 11:19:19 +01:00
Tim Kuipers
87e42fd9bd
fix: BucketGrid2D: enhancement of hashing protocols (CURA-590)
2016-02-10 11:12:54 +01:00
Tim Kuipers
8d0a75779d
doc; refactor: BucketGrid2D (CURA-590)
...
introduced typedef CellIdx to make clear which Point variables are used to signify a cell index
2016-02-10 11:11:47 +01:00
Tim Kuipers
e882b23d76
Merge branch '2.1'
2016-02-09 17:08:34 +01:00
Tim Kuipers
142f4d519f
Merge branch 'bugfix_coasting_prime' into 2.1
2016-02-08 16:28:50 +01:00
Arjen Hiemstra
9ea43e7fc1
Move addListener call to before message registration
...
This makes it possible to receive debug information about message registration
2016-02-07 18:56:28 +01:00
Arjen Hiemstra
9b92de9b8b
Add an Arcus::SocketListener subclass so we can log all errors and debug
2016-02-04 12:16:30 +01:00
Tim Kuipers
4361dbf8fb
better print time output
2016-02-03 18:02:34 +01:00
Tim Kuipers
81ae074b86
Merge branch '2.1'
2016-02-03 17:45:04 +01:00
Ghostkeeper
6826581497
Fix compile error
...
That needs to be a C-string.
2016-02-02 13:08:25 +01:00
Jaime van Kessel
4fead4612b
Merge branch 'new_arcus_api' of github.com:Ultimaker/CuraEngine into 2.1
2016-02-02 11:25:45 +01:00
Ghostkeeper
f763edfb05
Send FinishedSlicing message later
...
The FinishedSlicing message was being sent after the mesh group is done slicing, but it should've been sent after all slicing is done (also other mesh groups and after sending the metadata). This indicates that the slicer is really really done.
Contributes to issue CURA-427.
2016-02-01 10:21:53 +01:00
Ghostkeeper
0e662d7d67
Register SlicingFinished message type
...
The message type of this message is 8 (as documented in the proto file).
Contributes to issue CURA-427.
2016-02-01 10:21:53 +01:00
Ghostkeeper
94d8c3ff32
Document protobuf message typeid
...
Contributes to issue CURA-427.
2016-02-01 10:21:53 +01:00
Arjen Hiemstra
8e91753afc
Ignore ObjectList messages with no objects and Objects with no vertices
2016-01-28 18:17:24 +01:00
Tim Kuipers
3171bd4dcb
fix: infill overlap in mm (CURA-786)
2016-01-28 16:30:07 +01:00
Tim Kuipers
199007fa76
Merge branch '2.1'
2016-01-28 15:07:26 +01:00
Tim Kuipers
203eb05d7c
bugfix: support overlapping with model for xy_distance=0 (CURA-795)
2016-01-28 13:22:23 +01:00
Tim Kuipers
9e75f8c70c
fix: z distance used at overhang instead of xy-distance (CURA-795)
...
factored computeBasicAndFullOverhang out of generateSupportAreas
keep overhang areas in a rolling deque so that they are available for the current layer and the layer supportZDistanceTop above
implemented some polygon magic to ensure that the distance of support to overhang areas is less than from non-overhang areas
2016-01-28 13:12:24 +01:00
Tim Kuipers
93b3d2e46e
refactor: made some functions const in sliceDataStorage (CURA-795)
2016-01-28 13:03:49 +01:00
Arjen Hiemstra
21e59cc1e2
Update CommandSocket with the new Arcus API
2016-01-28 03:24:12 +01:00
Tim Kuipers
f0f14b0be3
fix: prime too slow after coasting due to unset speed (CURA-796)
2016-01-27 17:40:04 +01:00
Tim Kuipers
a82c00bead
fix: prime too much after coasting (CURA-796)
2016-01-27 17:39:37 +01:00
Tim Kuipers
14b1c5333a
fix: retraction was prevented for non-direct support to support moves which did avoid other parts (CURA-777)
...
most notably I introduced path[0] == lastPosition && path[1] == p to the condistion; rest is just restruction
2016-01-27 12:16:20 +01:00
Tim Kuipers
bbe809dabc
fix: sendPolygons in coasting had a lil bug (CURA-778)
...
sendPolygons was called for lines toward the starting point instead of the new point
also a line was sent for the coasted path, which is actually just a move path
2016-01-25 17:08:45 +01:00
Tim Kuipers
ed581a92b2
fix: reintroduced infill_overlap for the right features (CURA-765)
2016-01-25 16:38:47 +01:00
Tim Kuipers
9b68305851
refactor: matrix ==> rotation_matrix (CURA-401)
2016-01-25 12:01:09 +01:00
Tim Kuipers
940d3a86bd
refactor: moved some implementation comments and renamed 'uneven' to 'odd' (CURA-401)
2016-01-25 11:27:52 +01:00
Tim Kuipers
55047120d8
refactor: split ZigZagConnectorProcessor into separate files (CURA-401)
2016-01-25 11:05:58 +01:00
Tim Kuipers
e50b00fd73
fix: introduced new socket msg SlicingFinished (CURA-427)
2016-01-22 10:57:27 +01:00
Tim Kuipers
7377f30fd0
lil (remove unused var)
2016-01-21 10:26:24 +01:00
Tim Kuipers
c9245e0926
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-01-20 14:55:28 +01:00
Tim Kuipers
7149b7dbf1
fix: infill was overlapping with wall with incorrect amount; skin was incorrect when using a single wall and the outer wall line width differs from the inner walls (CURA-729)
2016-01-20 14:37:13 +01:00
Ghostkeeper
daa3927a99
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-01-20 14:34:13 +01:00
Ghostkeeper
074d1125e6
Fix STL header size
...
This was actually causing errors with loading STL files.
Sort of contributes to issue CURA-605.
2016-01-20 14:33:52 +01:00
Tim Kuipers
a92274678d
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-01-20 11:22:36 +01:00
Tim Kuipers
081393d7f0
fix: offset issues (CURA-401)
2016-01-20 11:22:10 +01:00
Tim Kuipers
30da3097d0
lil code convention refactor (CURA-401)
2016-01-19 17:33:46 +01:00
Tim Kuipers
d830fc515b
lil
2016-01-19 17:28:47 +01:00
Tim Kuipers
5f2d924771
refactor: let fill_angle and line_distance be retrieved from Infill members (CURA-401)
2016-01-19 17:23:01 +01:00
Tim Kuipers
b1ab1cae5a
refactor: renamed variables to lower_case (code convention) (CURA-401)
2016-01-19 17:19:49 +01:00
Tim Kuipers
1fb6b20d90
refactor: let in_outline and outlineOffset be retrieved from Infill members (CURA-401)
2016-01-19 17:14:29 +01:00
Tim Kuipers
dfb4c98e35
doc: infill documentation (CURA-401)
2016-01-19 13:40:21 +01:00
Tim Kuipers
e455d63ad2
refactor: made infill generation functions public and let them use Infill member variables; also a bugfix where a PointMatrix was requested but a double was given (CURA-401)
2016-01-19 13:07:45 +01:00
Tim Kuipers
cb024c73b1
refactor: made infill generation functions non-static (CURA-401)
2016-01-19 12:45:59 +01:00
Tim Kuipers
d2d25058cb
more comments for infill generation (CURA-401)
2016-01-19 12:29:12 +01:00
Tim Kuipers
e85362370b
more comments for (zigzag) infill generation (CURA-401)
2016-01-19 12:24:18 +01:00
Tim Kuipers
00c6f5c092
refactor: extrusionWidth ==> infill_line_width (CURA-401)
2016-01-18 17:29:14 +01:00
Tim Kuipers
818c7da951
lil comments (CURA-401)
2016-01-18 17:28:58 +01:00
Tim Kuipers
41723c8b38
removed unused registerPolyStart (CURA-401)
2016-01-18 17:22:10 +01:00
Tim Kuipers
c8d75dd913
refactor: cleaned up inheritance structure of ZigZagConnectorProcessor classes (CURA-401)
...
removed code duplication by introducing another class called ActualZigzagConnectorProcessor.
explained the inheritance structure in the base class description.
made some things protected instead of public.
2016-01-18 16:49:39 +01:00
Tim Kuipers
faa60c408f
doc: documentation cleanup and expansion (CURA-401)
2016-01-18 15:27:40 +01:00
Tim Kuipers
7e322bc57c
refactor: correction of tabs and spaces only (CURA-401)
2016-01-18 14:55:07 +01:00
Tim Kuipers
888fc54660
refactor: made all global infill functions private static (CURA-401)
2016-01-18 14:53:33 +01:00
Tim Kuipers
fd660fcc11
refactor: connect_zigzags ==> connected_zigzags (cura-401)
2016-01-18 14:18:56 +01:00
Tim Kuipers
e8080422a4
refactor: generateLineInfill_alt ==> generateLinearBasedInfill (CURA-401)
2016-01-18 14:16:33 +01:00
Tim Kuipers
5fecf2cd17
removed all old unused generateLine/ZigZagInfill code (CURA-401)
2016-01-18 14:15:26 +01:00
Tim Kuipers
b4bf17c6be
refactor: let rotation_matrix bubble down from Infill class; introduce some appropriate consts (CURA-401)
2016-01-18 14:07:38 +01:00
Ghostkeeper
fabd658b53
STL file binary vs. ASCII detection robust against whitespace
...
The ASCII file may contain whitespace at the start of the file. This causes the STL file to be flagged as binary (since it doesn't start with "solid"). This fix first skips all whitespace before trying to find "solid".
Contributes to issue CURA-605.
2016-01-17 04:42:48 +01:00
Ghostkeeper
a2050de513
Binary STL load use file size instead of face count
...
To determine the amount of memory allocated and the amount of faces to try to load, use the size of the file rather than the reported face count in the file. The reported face count may be missing or corrupt, in which case the engine would crash. If that happens now, it might miss one face. It will also give a warning if the reported face count does not match.
Contributes to issue CURA-605.
2016-01-17 04:09:14 +01:00
Tim Kuipers
9bfb5b17e9
refactor: made ZigzagConnectedEndpieces and ZigzagDisconnectgedEndpieces inherit from virtual ZigzagEndpieces; fix: several bugfixes (CURA-401)
...
notably the disconnected endpieces now disconnects all endpieces instead of half
2016-01-15 17:37:03 +01:00
Tim Kuipers
e93d39d6d5
fix: disconnected endpieces (zigzag); reordered some of the connected endpieces code (CURA-401)
2016-01-15 17:16:46 +01:00
Tim Kuipers
175a65415a
fix: support zigzag connected endpieces bugfixes (CURA-401)
...
before, only half of the endpieces were drawn
some problems had slipped into the translation, such as the resetting after each polygon
2016-01-15 16:53:39 +01:00
Tim Kuipers
74986dd95c
lil refactor: changed last_var to this_var at the moment it was set for conceptual clarity (CURA-401)
2016-01-15 16:49:55 +01:00
Tim Kuipers
55dd35ae5e
refactor: logic simplifications; fix: reintroduce skipping of scanline if poly is simple (CURA-401)
...
rewrote some for-if combinations which could be made simpler
small polygons which only cover a single scanline which are printed in total don't need the scanline...
2016-01-15 15:39:25 +01:00
Tim Kuipers
8caf810642
refactor: code conventions etc for generate(Lines/Zigzag)Infill (CURA-401)
2016-01-15 15:23:41 +01:00
Tim Kuipers
76efc41407
refactor: merge of generate(Lines/ZigZag)Infill (CURA-401)
2016-01-15 14:50:24 +01:00
Tim Kuipers
b0a0fe8f30
refactor: code conventions in generate infill paths (CURA-401)
2016-01-14 11:17:06 +01:00
Tim Kuipers
653b631ffd
lil
2016-01-14 11:16:36 +01:00
Tim Kuipers
b9a01ed031
bugfix: made MargeInfill.isConvertible not static, cause it needs the nozzle_size class member (CURA-581)
2016-01-13 12:10:37 +01:00
Tim Kuipers
de9d3bb447
lil fix: MergeInfill.nozzle_size used instead of line_width (CURA-581)
...
MergeInfillLines already had a member nozzle_size, though still it had a line defining a local variable 'int nozzle_size = line_width; // TODO'
Also some minor code convention brackets...
2016-01-13 11:50:47 +01:00
Arjen Hiemstra
8f5a46f77d
Ensure we use libc++ as stdlib on OSX
2016-01-06 16:56:04 +01:00
Tim Kuipers
d0858bbdb6
merge of 2.1
2016-01-06 15:03:29 +01:00
Tim Kuipers
c22793b5d7
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2016-01-05 18:22:52 +01:00
Tim Kuipers
1e684f23a7
refactor: removed old sendPolygons functions (CURA-379)
2016-01-05 18:22:34 +01:00
Tim Kuipers
7d0025975b
refactor: removed old sendPolygons functions (CURa-379)
2016-01-05 18:20:44 +01:00
Tim Kuipers
5c892b564b
fix: send all polygons at end of slicing process instead of during (CURA-379)
2016-01-05 18:17:03 +01:00
Tim Kuipers
d5327ec3f1
refactor: let all CommandSocket calls go throught CommandSocket.getInstance() (CURA-379)
2016-01-05 17:35:12 +01:00
Tim Kuipers
c48104bc86
refactor: made CommandSocket a kind of singleton class (CURA-379)
2016-01-05 17:09:08 +01:00
Tim Kuipers
f58f1daec3
refactor: commandSocket ==> command_socket (CURA-379)
2016-01-05 17:08:24 +01:00
Tim Kuipers
669bb523a3
bugfix: commandSocket depends on there being a NoneType (CURA-581)
2016-01-05 13:07:26 +01:00
Tim Kuipers
fa74f672ac
lil
2016-01-05 12:23:44 +01:00
Tim Kuipers
e224d9c853
MergeInfillLines early abort if space filling type is not Lines (CURA-581)
2016-01-05 12:23:10 +01:00
Tim Kuipers
338d80a7a9
lil fix in test (CURA-581)
2016-01-05 12:20:46 +01:00
Tim Kuipers
87123dac31
introduction of GCOdePath.space_fill_type (Polygon,Line or PolyLine) (CURA-581)
2016-01-05 12:20:09 +01:00
Tim Kuipers
73de288f44
lil cleanup of unused commented out code (CURA-581)
2016-01-05 11:30:43 +01:00
Tim Kuipers
9f5b5f405d
lil enhancements mergeInfillLines (CURA-581)
2016-01-05 11:27:06 +01:00
Tim Kuipers
2850b34227
fix: mergeInfillLines aborts if applied to a print feature other than infill or skin (CURA-581)
2016-01-05 11:23:51 +01:00
Tim Kuipers
072d320f1d
refactor: FeatureType ==> PrintFeatureType (CURA-581)
2016-01-05 11:11:39 +01:00
Tim Kuipers
8e4b61d2a5
merge of 4c139d6441 (CURA-581)
2016-01-05 11:10:56 +01:00
Tim Kuipers
ba4e26f801
bugfix: concentric infill overlapped with skin; extra offset for concentric infill moved inside infill.cpp (CURA-650)
2016-01-05 10:04:33 +01:00
Tim Kuipers
cea0a0a98f
bugfix: no draft shield or concentric infill sendPolygons (CURA-639)
2016-01-04 16:55:41 +01:00
Ghostkeeper
2b51a11739
Fix new command socket not propagating to LayerPlanBuffer
...
This caused the command socket in LayerPlanBuffer to remain null, thus never flushing the g-code until the very end, thus causing the front-end to interpret the entire g-code as one layer, thus causing the post processing plugin to inject g-code at the wrong places.
Contributes to issue CURA-443.
2015-12-31 11:22:37 +01:00
Tim Kuipers
cc23d73532
refactor: FeatureType ==> PrintFeatureType (CURA-606)
2015-12-18 16:32:13 +01:00
Tim Kuipers
4c139d6441
refactor: PolygonType ==> FeatureType in PrintFeature.h (CURA-606)
2015-12-18 16:32:02 +01:00
Tim Kuipers
13a18549bf
Merge branch '2.1'
2015-12-18 14:32:47 +01:00
Tim Kuipers
d32443ca9b
bugfixes: merge infill (CURA-581)
2015-12-18 14:25:07 +01:00
Tim Kuipers
792aa9e8e8
merge infill improvements (CURA-581)
2015-12-18 12:50:50 +01:00
Tim Kuipers
a63abb4e88
merge infill improvements maybe (CURA-581)
2015-12-18 10:49:12 +01:00
Tim Kuipers
9f82f58f03
bugfix: moveInside called with max_dist instead of max_dist_squared (CURA-522)
2015-12-15 16:33:51 +01:00
Tim Kuipers
bd2f66e2eb
bugfix: child settings got duplicated in extruder trains... (CURA-494)
2015-12-14 15:29:26 +01:00
Tim Kuipers
267eb7aef0
bugfix: made engine work both both extruder trains being an array as it being an object (CURA-494)
2015-12-14 14:14:08 +01:00
Tim Kuipers
df04467ab1
better doc (CURA-522)
2015-12-09 17:24:05 +01:00
Tim Kuipers
bbd9412b5f
bugfixes moveInside (CURA-522)
2015-12-09 17:23:50 +01:00
Tim Kuipers
c476acd522
bugfix: moveInside distance was BS (CURA-522)
2015-12-09 17:22:50 +01:00
Tim Kuipers
278efdeb39
merge of cherry-pick of 6115bde (CURA-522)
2015-12-09 17:22:09 +01:00
Tim Kuipers
bb8a9dacba
removed Comb.moveInside and Comb.isInside and inlined the implementation (CURA-522)
...
Since comb_boundary_inside is now a field of gcodeplanner these utility functions were at an awkward place.
Conflicts:
src/gcodePlanner.cpp
src/gcodePlanner.h
2015-12-09 17:18:55 +01:00
Tim Kuipers
42420edeed
merge of cherry-pick of 5c3727d (CURA-522)
2015-12-09 17:11:56 +01:00
Tim Kuipers
be2e96f3fd
getLayerSecondOrInnermostWalls functions (CURA-522)
2015-12-09 17:04:50 +01:00
Tim Kuipers
18adc0bbc9
merge of cherry-pick of c7ce43e (CURA-522)
2015-12-09 17:02:37 +01:00
Tim Kuipers
e7824faefe
merge of cherry-pick of c7ce43e (CURA-522)
2015-12-09 17:01:37 +01:00
Tim Kuipers
7199be1b4f
merge of cherry-pick of d9e2b39 (CURA-522)
2015-12-09 16:54:13 +01:00
Tim Kuipers
8cd48bf5a2
settingsRegistry reorganized and made more robust; more stuff will override if possible; extruder trains can now be overridden (CURA-494)
2015-12-09 16:27:31 +01:00
Tim Kuipers
a766455ec8
lil (CURA-494)
2015-12-09 16:24:47 +01:00
Tim Kuipers
af08b57799
makefile now copies command_line_settings.json to binary dir (CURA-566)
2015-12-09 09:37:29 +01:00
Tim Kuipers
dbecb29dc8
command line settings json (CURA-566)
2015-12-09 09:06:29 +01:00
Tim Kuipers
7df0a34464
lil bugfix settingsRegistry (CURA-566)
2015-12-09 09:05:39 +01:00
Tim Kuipers
925d50fc5d
removed prime_tower_distance (was already unused) (CURA-566)
2015-12-09 09:05:11 +01:00
Tim Kuipers
e3163586af
Merge of branch 2.1
2015-12-08 16:24:53 +01:00
Tim Kuipers
727c863f1a
optimization: handle socket object list after listening for messages (CURA-441)
2015-12-08 15:58:00 +01:00
Tim Kuipers
d732c49dd7
bugfix: close socket before exiting the program (CURA-441)
2015-12-08 15:57:26 +01:00
Tim Kuipers
781fc5ed7b
lil doc (CURA-524)
2015-12-08 14:48:19 +01:00
Tim Kuipers
7243cf6da4
renamed commandSocket.d to commandSocket.private_data (CURA-524)
2015-12-08 14:44:15 +01:00
Tim Kuipers
1cdcce4205
revert of 6224713998 (CURA-524)
2015-12-08 14:42:00 +01:00
Tim Kuipers
acf381c008
bugfix: no vizualization of last layers trvel moves (CURA-524)
2015-12-08 14:29:44 +01:00
Tim Kuipers
4b7df9ddc0
lil refac + doc (CURA*524)
2015-12-08 14:28:52 +01:00
Tim Kuipers
7788a4a234
refactor: sendGCodeLayer ==> flushGcode (CURA-524)
2015-12-08 14:28:20 +01:00
Tim Kuipers
6224713998
renamed commandSocket.d to commandSocket.private_data (CURA-524)
2015-12-08 13:53:22 +01:00
Tim Kuipers
db8b30d77a
refactor: Min Volume Before Coasting doesn't include Coasting Volume anymore (CURA-528)
2015-12-08 13:32:31 +01:00
Tim Kuipers
f58441a6ad
refactor: added braces for checks of command_socket (CURA-499)
2015-12-08 13:16:03 +01:00
Tim Kuipers
050b9c88f2
bugfix: coasting volume more than min volume (CURA-528)
2015-12-07 18:03:40 +01:00
Ghostkeeper
8ac63fca6e
Log a warning when trying to override nonexistent setting
...
If there's a problem in the front-end this should expose it.
Contributes to issue CURA-544.
2015-12-07 15:38:21 +01:00
Ghostkeeper
1383882bc5
Fixed segfault when provided with unknown settings
...
When an override of a setting is provided via the JSON the engine would crash. This ignores those settings.
Contributes to issue CURA-544.
2015-12-07 15:18:39 +01:00
Tim Kuipers
04b4b2c057
merge
2015-12-07 13:42:31 +01:00
Tim Kuipers
3a773d3c0f
bugfix: layer plan buffer flush did flush water, but left the turd (CURA-463)
2015-12-07 12:39:25 +01:00
Tim Kuipers
734ddce3c8
lil (CURA-463)
2015-12-07 12:38:14 +01:00
Tim Kuipers
0b19936299
main didn't allow for next meshgroup to be processed (CURA-463)
2015-12-07 12:37:02 +01:00
Tim Kuipers
691d5de591
lil doc (CURA-499)
2015-12-04 17:04:45 +01:00
Tim Kuipers
490cef1a5c
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2015-12-04 16:57:00 +01:00
Tim Kuipers
b777b55935
bugfix: output command line call (CURA-499)
2015-12-04 16:56:49 +01:00
Ghostkeeper
0f5fd8d6ca
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-12-04 16:47:16 +01:00
Ghostkeeper
645b06271d
Remove support-specific test
...
Support is already tested somewhat in the default test model. This makes the testing a bit more efficient.
Contributes to issue CURA-349.
2015-12-04 16:46:59 +01:00
Ghostkeeper
0428c08152
Fix indenting
...
The main function of runtest.py was indented with tabs instead of spaces.
2015-12-04 15:58:53 +01:00
Tim Kuipers
ef61337ef8
better doc (CURA-522)
2015-12-04 13:55:08 +01:00
Tim Kuipers
20c74dd22d
lil bugfix CURA-486 (stiekum gekoppeld)
2015-12-03 18:47:12 +01:00
Tim Kuipers
188b190d21
inlined writePathWithCoasting (CURA-486)
2015-12-03 18:05:29 +01:00
Tim Kuipers
1cd128decd
coasting collapsed: no more diff between move-coasting and retract-coasting (CURA-486)
2015-12-03 18:01:34 +01:00
Tim Kuipers
925247a54d
bugfix: don't perform the retraction *during* coasting (CURA-486)
2015-12-03 18:00:34 +01:00
Tim Kuipers
b8d5474811
merge
2015-12-03 14:57:13 +01:00
Ghostkeeper
4c60339695
Merge pull request #281 from Rhoban/master
...
Adding ENABLE_ARCUS option in CMakeLists
This allows compiling CuraEngine for command-line use only.
2015-12-03 11:01:57 +01:00
Gregwar
e1a594ad3e
ENABLE_ARCUS: Adding message(STATUS) line
2015-12-03 10:22:28 +01:00
Tim Kuipers
94d9a948ae
bugfix: a zero length line has no 'beyond' (CURA-359)
2015-12-02 16:32:43 +01:00
Tim Kuipers
176bf2c887
bugfixes getDist2FromLineSegment (CURA-359)
2015-12-02 16:31:40 +01:00
Tim Kuipers
3cf208f8ed
Merge branch '2.1' of https://github.com/Ultimaker/CuraEngine into 2.1
2015-12-02 14:54:32 +01:00
Tim Kuipers
08eec2ad1f
bugfixes moveInside (CURA-522)
2015-12-02 14:54:21 +01:00
Tim Kuipers
41e012be5f
bugfix: initialize comb_boundary_inside (CURA-522)
2015-12-02 14:53:39 +01:00
Tim Kuipers
8102f7a246
bugfix: moveInside distance was BS (CURA-522)
2015-12-02 14:32:18 +01:00
Tim Kuipers
d527358a82
lil documentation cleanup (CURA-522)
2015-12-02 14:20:35 +01:00
Tim Kuipers
6115bdec2a
bugfix: when combing was off, we didn't move inside before doing a retract (CURA-522)
2015-12-02 14:19:45 +01:00
Tim Kuipers
9f29cbd3fb
removed Comb.moveInside and Comb.isInside and inlined the implementation (CURA-522)
...
Since comb_boundary_inside is now a field of gcodeplanner these utility functions were at an awkward place.
2015-12-02 14:18:46 +01:00
Tim Kuipers
5c3727d532
refactor: moved comb_boundary_inside outside of Comb to gcodePlanner (CURA-522)
2015-12-02 14:05:48 +01:00
Tim Kuipers
73152d84c7
getLayerSecondOrInnermostWalls functions (CURA-522)
2015-12-02 14:03:18 +01:00
Ghostkeeper
2b3f22872e
Fix codestyle and superfluous commented code
...
Contributes to CURA-359.
2015-12-02 13:32:48 +01:00
Tim Kuipers
c7ce43eb6c
refactor: is_combing ==> is_inside (CURA-522)
2015-12-02 13:01:44 +01:00
Tim Kuipers
d9e2b39baf
bugfix: min travel dist was ignored (CURA-522)
2015-12-02 12:54:07 +01:00
Ghostkeeper
fa03c3823f
Merge branch '2.1'
...
Merging recent fixes to master, mostly to be able to get Jenkins to report the updated tests.
2015-12-02 12:15:39 +01:00
Ghostkeeper
34e86195e9
Correct getDist2FromLineSegmentZeroNearTest ground truth
...
20^2 is 400, not 40.
Contributes to CURA-359.
2015-12-02 12:13:24 +01:00
Ghostkeeper
bad780c54b
Add existing tests for zero-length lines to test suite
...
Think I forgot to add these two tests earlier.
Contributes to CURA-359.
2015-12-02 12:13:24 +01:00
Ghostkeeper
3ddbc1d53b
Added test for large lines to point distance
...
This should test multiplication of rounding errors more properly.
Contributes to CURA-359.
2015-12-02 12:13:24 +01:00
Tim Kuipers
51757353b4
bugfix: skin orientation separate from infill orientation (CURA-363)
2015-12-02 11:47:08 +01:00
Tim Kuipers
d931baa788
fix: reserve [extruder_count] extruder plans, so that it's quite unlikely for the vector to get resized (CURA-298)
2015-12-01 18:04:14 +01:00
Tim Kuipers
2cf0d40775
fix: reserve [extruder_count] extruder plans, so that it's quite unlikely for the vector to get resized (CURA-298)
2015-12-01 17:23:16 +01:00
Tim Kuipers
d20df39d5f
Merge branch '2.1'
2015-12-01 16:31:58 +01:00
Tim Kuipers
57bc411bc6
refactor: speed_iconic ==> speed_base, speed ==> speed_current (CURA-496)
2015-12-01 16:31:34 +01:00
Gregwar
0c30d27892
Adding ENABLE_ARCUS option in CMakeLists
2015-12-01 16:27:14 +01:00
Tim Kuipers
0c9562b273
rename: support_extruder_nr ==> support_infill_extruder_nr
2015-12-01 16:07:04 +01:00
Tim Kuipers
321a9c11e0
bugfix: dynamically sized array initialized as if constant (CURA-499)
2015-12-01 15:03:21 +01:00
Tim Kuipers
389950ed90
fix: made all huge classes non-copyable (meshgroup and weaver needed some fixing) (CURA-298)
2015-12-01 14:23:55 +01:00
Tim Kuipers
61e5187267
ducomentation stuff (CURA-414)
2015-12-01 14:04:07 +01:00
Tim Kuipers
3859d58571
indent
2015-12-01 13:41:23 +01:00
Tim Kuipers
345c599062
bugfix: retraction_count_max ignored when < 0, retractions not occuring when ==0 (CURA-414)
2015-12-01 13:39:44 +01:00
Tim Kuipers
73625b949f
bugfix: retraction_count_max was retrieved as if it was in MM instead of a count (CURA-414)
2015-12-01 13:22:59 +01:00
Tim Kuipers
bf1cf334e6
bugfix: retraction_extrusion_distance_window also in MM for wireprinting (CURA-414)
2015-12-01 13:18:33 +01:00
Tim Kuipers
13ec686608
bugfix: triangles infill (and others) rotated every layer (CURA-363)
2015-12-01 13:14:05 +01:00
Tim Kuipers
742eedda06
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-12-01 12:30:37 +01:00
Tim Kuipers
bc6a139d1f
lil optimization (CURA-480)
2015-12-01 10:59:13 +01:00
Tim Kuipers
9770e91961
bugfix: first extruder plan might be empty, so then it should be removed (CURA-480)
2015-12-01 10:57:58 +01:00
daid
9e3dfb5b12
Allow running of test with just the default settings.
2015-11-30 15:22:13 +01:00
Ghostkeeper
8b244c1738
Fix order of initialisation
...
Turns out this was important. When an actually filled mesh was given, this was giving errors.
Contributes to CURA-510.
2015-11-30 14:59:24 +01:00
Tim Kuipers
c05c3ddaed
bugfix: always use safest distance for combing when a single distance is used for inside combing (CURA-480)
2015-11-27 16:32:41 +01:00
Tim Kuipers
804c288353
storage.getExtrudersUsed (CURA-480)
2015-11-27 16:30:04 +01:00
Ghostkeeper
22c1ff4efe
Properly define travel speed in GCodePlannerTests
...
It has to make travel moves, and if the travel move has speed 0 this messes up the estimates, so make it not 0.
2015-11-27 16:12:41 +01:00
Ghostkeeper
811be991c1
Define some lenience in time material estimates test
...
They are estimates, after all. The ground truth too is estimated.
2015-11-27 16:12:41 +01:00
Ghostkeeper
684da831b2
Properly set the retraction speed and distance
...
The test currently fails due to a floating point rounding error. I'll give it some lenience, especially since both the ground truth and the supposed output are estimates.
2015-11-27 16:12:41 +01:00
Ghostkeeper
a9ff4a3826
Update naive time estimates retraction test
...
It now actually performs a retraction. The test fails at the moment. It seems the planner is not properly constructed yet.
2015-11-27 16:12:41 +01:00
Ghostkeeper
6d2ecc7811
Add "-" operator for TimeMaterialEstimates
...
This allows you to get the estimates of segments of the g-code, such as what I want to do when making unit tests.
2015-11-27 16:12:41 +01:00
Ghostkeeper
e77ae7362b
Use checked meshgroup in constructing SliceDataStorage
...
The rest of this constructor was still using the input meshgroup, which might be nullptr. Make it use the field, which was checked for being nullptr and initialised if it was nullptr.
2015-11-27 16:12:41 +01:00
Ghostkeeper
571d592136
Add a check for nullptr when creating SliceDataStorage
...
For this I moved the constructor properly to the cpp file. This prevents the constructor from having to be compiled a million times, and having to compile a million other files each time you modify this constructor, and prevents having to compile the FffProcessor header each time too. Also, since meshgroup must be defined before initializeRetractionConfigs and initializeSkirtConfigs, they are now in the body of the constructor to properly define the order.
2015-11-27 16:12:41 +01:00
Ghostkeeper
4d1ebb33e6
Add test for naive time estimates
...
It will set up a very basic g-code planner and let it estimate the time and material it needs. Currently it only tests with empty g-code, but I mean to add a test with retraction once this works. Currently the setup gives a segfault.
Contributes to issue CURA-415.
2015-11-27 16:12:41 +01:00
Tim Kuipers
995f9786a4
bugfix: no more temp commands when using single extrusion and UM2 and no auto temp (CURA-468)
2015-11-27 13:40:50 +01:00
Tim Kuipers
3467593aa2
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-11-27 11:06:09 +01:00
Tim Kuipers
ef4b8abaf5
bugfix: speed was always set to speed_layer_0 (CURA-496)
2015-11-27 11:05:59 +01:00
daid
f460eeef57
Fix the CPackConfig file for both cross compiling and local compiling of packages. Final filename of the deb file was wrong.
2015-11-27 09:40:10 +01:00
Tim Kuipers
488f82ccbc
bugfix: no prime tower sendPolygons called (CURA-326)
2015-11-26 19:42:19 +01:00
Tim Kuipers
db3e9ac5e6
bugfix: do make infill and skin between INNER walls (fix of bug introduced in last commit) (CURA-481)
2015-11-26 18:29:52 +01:00
Tim Kuipers
8529924bc4
bugfix: no more infill or skin between OUTER walls (CURA-481)
2015-11-26 13:59:14 +01:00
Tim Kuipers
03ff861904
fix: no more bs check; it is never checked when the first Z position is obtained from the initial currentPosition, which is an approximation of where the nozzle starts
2015-11-25 16:58:29 +01:00
Tim Kuipers
b3752a43b4
bugfix: gcodeExport got copiedgit diff solves temp commands missing issue (CURA-298)
2015-11-24 18:27:45 +01:00
Tim Kuipers
7e47664a51
bugfixes: uninitialized extruderMM3perMM used ==> replaced by gcodePath.isTravelPath; speed increased by extruderSpeedFactor instead of travelSpeedFactor (CURA-298)
2015-11-24 17:43:47 +01:00
Tim Kuipers
1b6b5cb843
removed commented out premature gcode writing (before planning)
2015-11-24 17:04:02 +01:00
Tim Kuipers
0d98c6eaef
bugfix: remove first extruder plan temp warm up commands (since they are handled by the start gcode already) (CURA-468)
2015-11-24 16:43:06 +01:00
Tim Kuipers
518a528596
bugfix: remove first extruder plan temp commands (since they are handled by the start gcode already) (CURA-468)
2015-11-24 16:05:28 +01:00
Tim Kuipers
c9ea663a1b
enforce single slicing by commandSocket.
2015-11-20 15:57:51 +01:00
Tim Kuipers
0a7355d25c
remainder of refactor split: getExtruderTrain => createExtruderTrain (CURA-465)
2015-11-20 11:34:22 +01:00
Tim Kuipers
fc6cad48af
CuraEngine settings conversion
2015-11-20 09:00:03 +01:00
Tim Kuipers
d4c7abf7ef
refactor: commandSocket: object_to_slice ==> mehgroup (CURA-465)
2015-11-19 13:59:18 +01:00
Tim Kuipers
c04274401a
bugfix: commandSocket: objects inherited from global settings instead of from the extruder train (CURA-465)
2015-11-19 13:57:00 +01:00
TotalRetribution
fb2dac0f96
Cleaned up White space in processInsets
2015-11-18 13:26:33 +00:00
TotalRetribution
e2e9cf8ea8
Merge remote-tracking branch 'origin/master' into reverse_inset_order
2015-11-18 11:51:18 +00:00
Tim Kuipers
ee8dd68046
revert of polygon constructor change ( 667644eee4) (CURA-349)
2015-11-18 11:37:48 +01:00
Tim Kuipers
afcacd00a7
bugfix: primeTower memory issues (officially unrelated to CURA-414)
2015-11-18 11:31:55 +01:00
Tim Kuipers
a5b31de404
early out when meshgroup is empty (CURA-349)
2015-11-18 11:20:15 +01:00
Tim Kuipers
c8f1922966
early out when meshgroup is empty (CURA-349)
2015-11-18 10:29:17 +01:00
Tim Kuipers
ac24325715
relaxed tests of LinAlg2D (CURA-359)
2015-11-17 18:03:11 +01:00
Tim Kuipers
4807e13de6
lil (CURA-359)
2015-11-17 18:02:10 +01:00
Tim Kuipers
b389b24d9b
better cmake lists
2015-11-17 18:00:21 +01:00
Tim Kuipers
121d13b57e
removed stray references to gcode instead of gcode_layer
...
and removed a stray fan command - why was it even there?! it should have been in finalize and/or processNextMeshgroupGcode
CURA-299
2015-11-17 17:08:02 +01:00
Tim Kuipers
b1dc67be71
factored out maxObjectHeight from finalize (CURA-405)
2015-11-17 16:51:26 +01:00
Tim Kuipers
2584c7b38c
removed move upward before end gcode insertion (CURA-405)
2015-11-17 16:39:26 +01:00
Tim Kuipers
ac8b0e149a
bugfix: retraction dist used as if it was volume (CURA-415)
2015-11-17 14:25:34 +01:00
Tim Kuipers
03141f505d
refactor: extruderSwitchRetraction ==> extruder_switch_retraction_distance; prime_amount ==> prime_volume (CURA-415)
2015-11-17 14:24:51 +01:00
Tim Kuipers
e18659669e
refactor: retraction_amount ==> retraction_e_amount , to reflect that its unit is either mm or mm^3 (CURA-415)
2015-11-17 13:58:12 +01:00
Tim Kuipers
903f3b11d1
lil: mm3 ==> mm^3 in comments (CURA-415)
2015-11-17 13:55:55 +01:00
Tim Kuipers
51f27fd0ca
bugfixes retraction_amount vs retraction_distance (CURA-415)
2015-11-17 13:52:08 +01:00
Tim Kuipers
b7d1e53992
lil: doc: units of several speed variables (mm/s) (CURA-415)
2015-11-17 13:45:16 +01:00
Tim Kuipers
461a90a319
refactor: retractionPrimeSpeed ==> extruder_attr[e].last_retraction_prime_speed (CURA-414)
2015-11-17 13:22:35 +01:00
Tim Kuipers
b19c6751c5
neglected prime amount in naive time estimate cause it is in a different unit
2015-11-17 13:13:06 +01:00
Tim Kuipers
e2479e12b0
reffactor: retraction.amount ==> retraction.distance
2015-11-17 13:11:38 +01:00
Tim Kuipers
c67f691237
bugfix naive time estimate (CURA-415)
2015-11-17 12:14:03 +01:00
Tim Kuipers
9c8e32f37b
PR style fixes
2015-11-17 10:52:51 +01:00
Tim Kuipers
124b116b0c
Merge pull request #266 from markwal/master
...
Omit start temp if already in starting gcode
2015-11-17 10:43:47 +01:00
Ghostkeeper
0b8fd8209c
Initialise variable to shut up compiler warning
...
This variable is always initialised by LinearAlg2D::getDist2FromLineSegment before it is used. But the compiler can't detect that it is, because it noticed that the variable is not changed in some cases (namely if the pointer is null). So this just shuts up the compiler.
2015-11-16 15:39:00 +01:00
Mark Walker
1534ff0361
Add new settings to control temperature prepend
...
material_bed_temp_prepend - if true, prepend the bed temperature gcode
material_bed_temp_wait - if true, use the set and wait variant gcode
material_print_temp_prepend - if true, prepend the extruder temperature gcode
material_print_temp_wait - if true, also prepend the wait for temperature gcode
2015-11-16 02:26:02 -08:00
Ghostkeeper
b6268d8dc9
Initialise variable to shut up compiler warning
...
This variable is always initialised by LinearAlg2D::getDist2FromLineSegment before it is used. But the compiler can't detect that it is, because it noticed that the variable is not changed in some cases (namely if the pointer is null). So this just shuts up the compiler.
2015-11-13 16:55:00 +01:00
Ghostkeeper
3413f3abaa
Initialise variable in case a polygon is empty
...
If an empty polygon was passed here in the outline, firstBoundarySegmentEndsInEven would be uninitialised. This initialises it by default to true so that the if statement after the loop exhibits predictably correct behaviour.
2015-11-13 16:50:52 +01:00
Ghostkeeper
cb5c69d064
Continue running wireframe script if zero layers to initialise fields
...
Some fields of Weaver were not properly initialised if the script was cut short. It now checks at several places where zero layers would be a problem and just continues as best as it can.
Contributes to issue CURA-349.
2015-11-13 16:45:04 +01:00
Ghostkeeper
afa7c5a0c0
Properly initialise retraction settings in wireframe
...
The retraction settings were not initialised and this caused wireframe printing to access uninitialised memory. This initialises it properly by loading them from settings. At one place the rest of the settings were still hardcoded with the todo that it should be loaded from settings, but I left that as-is for now.
Contributes to issue CURA-349.
2015-11-13 16:43:05 +01:00
Ghostkeeper
7cbfd42b8f
Initialised variable that could be uninitialised in if statement
...
This variable was possibly uninitialised by the time it is first used in an if statement. This causes undefined behaviour. This now initialises it to false, which is correct behaviour if the variable is not changed (zero outlines).
2015-11-13 13:24:42 +01:00
Ghostkeeper
515bf4592e
Set CMake debug version message to status type
...
Makes it more coherent with other messages in CMake.
2015-11-13 13:12:59 +01:00
TotalRetribution
57ec92a645
Merge remote-tracking branch 'origin/master' into reverse_inset_order
2015-11-13 11:13:26 +00:00
Ghostkeeper
667644eee4
Properly initialise Polygons
...
The polygons vector of the Polygons class was in some cases not initialised while the size of the vector was requested, causing Valgrind to report a conditional jump depending on uninitialised memory.
Contributes to issue CURA-349.
2015-11-13 12:04:06 +01:00
Ghostkeeper
17e00733a4
Make flow temp graph parsing more robust
...
It should try to get as much information from the string as possible, regardless of whether the string is correctly formatted or not. At many places it used to iterate through the characters indefinitely until the next separator was reached. Now it stops at the end of string and returns the information it gathered up to then.
Contributes to issue CURA-349.
2015-11-13 11:36:24 +01:00
Tim Kuipers
5142f8c1ba
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-11-13 11:12:41 +01:00
Tim Kuipers
432abf11d5
allround print tests (CURA-426)
2015-11-13 11:12:23 +01:00
Arjen Hiemstra
77361417a4
Merge branch '15.10'
...
* 15.10:
Add support for setting CuraEngine version from CMake
Spelling fix
2015-11-13 11:06:20 +01:00
Ghostkeeper
83da6b2072
Fix maximum object height for wireframe if wireframe empty
...
It can't request the height of the heighest layer if there are no layers. If there are no layers, the height is now 0. Fixes the wireframe printing issue.
Contributes to issue CURA-349.
2015-11-13 10:18:20 +01:00
Ghostkeeper
e567f8265a
Wireframe don't crash if meshgroup is empty
...
If the mesh group is empty, the wireframe slicing crashed since it tried to access slicerList[0], which was filled with a slicer for each meshgroup.
Contributes to issue CURA-349.
2015-11-13 10:18:20 +01:00
Tim Kuipers
c20b07fe0d
lil:indent
2015-11-13 09:56:14 +01:00
Tim Kuipers
10815b4f93
bugfix: extruder start/end position didn't account for the extruder offset (CURA-351)
2015-11-13 09:55:53 +01:00
Arjen Hiemstra
a119be9021
Add support for setting CuraEngine version from CMake
2015-11-12 14:53:59 +01:00
Tim Kuipers
002692fe18
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-11-12 13:16:22 +01:00
Tim Kuipers
99e9054f54
renaming: isRetracted==>retraction_amount_current & retraction_offset_from_zero==>retraction_amount_e_start (CURA-414)
2015-11-12 13:15:28 +01:00
Tim Kuipers
eedd4adee3
bugfixes: unset prime_amount and wrong currentExtrudedVolume computation (CURA-414)
2015-11-12 13:03:38 +01:00
Tim Kuipers
e110b864ce
introduced firmware_retract (CURA-414)
2015-11-12 12:02:04 +01:00
Tim Kuipers
1109f97ae6
refactor getCurrentExtrudedVolume to only owrk on current_extruder (CURA-414)
2015-11-12 12:01:38 +01:00
Tim Kuipers
469ab32b5c
bugfix: isRetracted was used instead of prime_amount (CURA-414)
2015-11-12 11:17:18 +01:00
Tim Kuipers
e1390582ed
bugfixes extruded_volume_at_previous_n_retractions (CURA-414)
2015-11-12 10:56:24 +01:00
Tim Kuipers
6b1b11b47b
refactored out writeMoveBFB: fixed indentation
2015-11-12 09:29:48 +01:00
Tim Kuipers
3526edd04a
refactored out writeMoveBFB
2015-11-12 09:28:39 +01:00
Tim Kuipers
a101be9d2f
bugfix: register extruded volume before extruder switch (CURA-414)
2015-11-12 09:21:05 +01:00
Tim Kuipers
52aedafc13
bugfixes extrusion_amount_at_previous_n_retractions (CURA-414)
2015-11-12 08:52:25 +01:00
Tim Kuipers
afd1e2659e
refactor: getExtrusionAmountMM3 ==> getCurrentExtrudedVolume (CURA-414)
2015-11-12 08:51:38 +01:00
Tim Kuipers
93896a6960
refactored out getFilamentArea (CURA-414)
2015-11-11 17:34:54 +01:00
Tim Kuipers
954a396d96
bugfix: retraction extrusion window was interpreted in mm instead of in micron (CURA-414)
2015-11-11 17:31:33 +01:00
Tim Kuipers
610880737f
refactor: extrusion_amount ==> current_e_value (no more implicit storing of retracted amount); last_coasted_amount_mm3 + retraction_config.primeAmount ==> extruder_attr[.].prime_amount; (CURA-414)
2015-11-11 16:49:01 +01:00
Tim Kuipers
36ed9904b5
refactor: made retraction prime amount have mm3 unit (CURA-415)
2015-11-11 16:37:32 +01:00
Tim Kuipers
996fc2cbc1
refactor: isRetracted now tracks how far it is actually retracted (CURA-414)
2015-11-11 15:20:16 +01:00
Tim Kuipers
7af12e5526
lil
2015-11-11 14:25:50 +01:00
Tim Kuipers
0323179b4a
bugfix?: long retraction 'overwrites' short retraction (CURA-414) instead of doing a long+short retraction
2015-11-11 14:25:35 +01:00
Tim Kuipers
91956ad0e6
bugfix: zhop created Z position gcode commands on every move in a z hop (If I understand correctly) (CURA-414)
2015-11-11 14:23:30 +01:00
Tim Kuipers
ff9dbf9a51
refactor: isRetracted per extruder (CURA-414)
2015-11-11 14:22:15 +01:00
Ghostkeeper
bbff888e23
Fix license header
...
I don't know how I keep getting this wrong.
2015-11-11 13:41:16 +01:00
Ghostkeeper
4460b9a1d0
Fix license header
...
I don't know how I keep getting this wrong.
2015-11-11 13:39:34 +01:00
Ghostkeeper
dd161ef770
Rename libCuraEngineLibrary to lib_CuraEngine
...
It can't be named libCuraEngine, sadly, since that produces a naming conflict with the CuraEngine executable target itself. This is a better compromise than it was initially.
2015-11-11 13:39:34 +01:00
Ghostkeeper
30050349fa
Git ignore test output file
...
This should not be committed along.
2015-11-11 13:39:34 +01:00
Ghostkeeper
bafcb804f4
Streamline building with unit tests
...
It is no longer necessary to build CuraEngine twice if building unit tests. It now simply builds all of CuraEngine (except main.cpp) as a library, then builds main.cpp as separate application and links the CuraEngine library to it. Then it does the same with the tests: Just build the test suite as application and link the already-built library to it.
2015-11-11 13:39:34 +01:00
Tim Kuipers
a7320a2d14
bugfix: nozzle switch retraction prime speed was ignored
2015-11-11 12:59:03 +01:00
Tim Kuipers
a7e72ea917
bugfix: overriding json document can now add new settings to existing category
2015-11-11 12:18:26 +01:00
Tim Kuipers
61c9cb5a07
debug out functions for settings registry
2015-11-11 12:17:54 +01:00
Tim Kuipers
d029d7294f
lil
2015-11-11 11:08:49 +01:00
Tim Kuipers
4c2aaed215
merge from 15.10
2015-11-10 13:10:14 +01:00
Ghostkeeper
68602df6ee
Spelling fix
...
This would prevent the g-code flavour from being recognised in RepRap machines.
2015-11-09 13:52:40 +01:00
Tim Kuipers
017fb03391
failsafe: extruder train defaults to global settings if it is not specified
2015-11-06 17:30:37 +01:00
Tim Kuipers
92f5311aaf
failsafe: extruder train defaults to global settings if it is not specified
2015-11-06 17:30:15 +01:00
Tim Kuipers
00abb3ab4c
lil: removed debug code
2015-11-06 17:23:09 +01:00
Tim Kuipers
4f9f55ab06
lil: removed debug code
2015-11-06 17:22:45 +01:00
Tim Kuipers
dfc91d811f
merge of bugfix for combing
2015-11-06 17:12:58 +01:00
Tim Kuipers
2bfdb2d612
bugfix: outside combing was skipped sometimes
2015-11-06 17:10:31 +01:00
Tim Kuipers
026f82540f
bugfix: outside combing was skipped sometimes
2015-11-06 16:53:33 +01:00
Tim Kuipers
835424121f
bugfix: outside combing was skipped sometimes
2015-11-06 15:46:33 +01:00
Tim Kuipers
d87072f761
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-11-06 15:44:51 +01:00
Tim Kuipers
f89a747836
bugfix: outside combing was skipped sometimes
2015-11-06 15:44:42 +01:00
Ghostkeeper
767803d2bf
Fix more indenting
...
I think this is on me. I merged this code once.
2015-11-06 11:10:55 +01:00
Ghostkeeper
a808e9e8ed
Fix indenting
...
At one place there was an accidental extra four spaces. At another place the alignment of a comment was off since it was aligned to a comment above it which had moved to the left.
2015-11-06 11:10:55 +01:00
Tim Kuipers
087efefc16
bugfix: new speed wasn't set; fixes CURA-396
2015-11-06 10:42:59 +01:00
Tim Kuipers
09afe2264a
bugfix: new speed wasn't set; fixes CURA-396
2015-11-06 10:40:49 +01:00
Tim Kuipers
6866925a05
bugfix: gcode flavor prepended for UM2 was incorrect
2015-11-05 21:00:55 +01:00
Tim Kuipers
5ede92fb1b
bugfix: gcode flavor prepended for UM2 was incorrect
2015-11-05 21:00:29 +01:00
Ghostkeeper
321ef643a4
Use static cast instead of c-style cast
...
The static cast has more predictable behaviour across compilers.
2015-11-05 17:53:17 +01:00
Ghostkeeper
c43c876cbc
Offset PolyCrossings in combing after iteration of basicpath
...
The offset could sometimes make the basicpath loop get stuck.
2015-11-05 17:53:17 +01:00
Ghostkeeper
3d596f1765
Report error if SVG file couldn't be opened for writing
...
If for some reason the opening of the file failed, an error is given that indicates where the file was opened. It still continues writing because the nature of this class requires it to fail fast rather than continue silently, but it should be easier to debug now. If silent fail behaviour is desired for this class then we could decide on that later. It involves checking for if(out) at every write function.
2015-11-05 17:53:17 +01:00
Ghostkeeper
ff747fa88f
SVG filewriter to use const points
...
This way they can be directly filled in as points into a function call without making a variable for them and passing that variable by reference.
2015-11-05 17:53:17 +01:00
Tim Kuipers
950441493c
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-11-05 17:49:01 +01:00
Tim Kuipers
0c7cca6f17
feature: always show gcode flavor
2015-11-05 17:48:45 +01:00
Tim Kuipers
41a1db1e55
feature: always show gcode flavor
2015-11-05 17:48:21 +01:00
Ghostkeeper
c058a2b12b
Separate test per assert in getDist2FromLineSegmentAssert
...
Rather than failing at the first assert, there are now only 2 asserts in these test cases. Also it allows for some leniency of 10 microns error in the distance, which was the actual reason I did this.
2015-11-05 17:34:51 +01:00
Tim Kuipers
adc8341e49
bugfix: walls were visualized when wall_line_count==0
2015-11-05 12:06:31 +01:00
Tim Kuipers
0717594a15
bugfix: walls were visualized when wall_line_count==0
2015-11-05 12:05:42 +01:00
Ghostkeeper
d6ed95ed81
Merge branch 15.10
...
Conflicts:
src/settingRegistry.cpp
src/skin.cpp
2015-11-04 14:44:12 +01:00
Ghostkeeper
c72b05463a
Combing path-polygon intersection only offset along path
...
This is slightly more efficient to compute, though it allows for combing closer to the polygon than the specified combing distance if the edge approaches parallel with the desired combing path.
Contributes to issue CURA-286.
2015-11-04 14:04:50 +01:00
Ghostkeeper
eb1acd02a2
Fixed combing offset bug
...
A point was being moved inside the polygon to obtain waypoints for combing through the inside of the polygon. Then it was being moved outside the polygon with a larger offset, but the second move used the inside point of the first move, causing the resulting offset to be a bit too small. This keeps a copy of the original waypoint before moving it inside, which it uses only for computing the outside waypoint.
Contributes to issue CURA-286.
2015-11-04 14:04:50 +01:00
Tim Kuipers
102b9f9c75
setting inheritance diagram
2015-11-04 13:25:51 +01:00
Tim Kuipers
abb0b9a763
refactor: extruder plan insert Inserts code moved to ExtruderPlan
2015-11-04 12:39:00 +01:00
Tim Kuipers
63eda27a50
no more error when no extruder trains are present
2015-11-04 11:17:25 +01:00
Tim Kuipers
5b1eeecf76
fix for support roof triangles infill
2015-11-04 11:16:50 +01:00
Tim Kuipers
41ede0727b
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-11-04 11:02:32 +01:00
Ghostkeeper
7ffec2e617
Remove unnecessary parallel line collision detection
...
Now that a collision is also triggered when the line crosses an endpoint of another line, the detection of collisions when the two lines are parallel is no longer needed.
Contributes to issue CURA-286.
2015-11-03 17:40:46 +01:00
Ghostkeeper
57ebcf0163
combineInfillLayers to stop if combining 1 or 0 layers
...
Combining 1 layer has no effect. Combining 0 layers is invalid. Therefore, if this function is made to combine 1 or 0 layers, it doesn't combine anything, and immediately returns.
2015-11-03 16:48:23 +01:00
Tim Kuipers
71ae42a949
lil: error=>warning
2015-11-03 16:45:07 +01:00
Tim Kuipers
49a1ed7f3b
fix for support roof triangles infill
2015-11-03 16:20:56 +01:00
Tim Kuipers
190b5b789b
no more error when no extruder trains are present
2015-11-03 15:17:58 +01:00
Tim Kuipers
ad29876617
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-11-03 09:17:42 +01:00
Tim Kuipers
07481a548c
bugfix: settings overrides weren't working
...
Conflicts:
src/settingRegistry.cpp
2015-11-03 09:17:32 +01:00
Ghostkeeper
a6be90d3b4
Link libraries to CuraEngineLibrary rather than tests
...
It's CuraEngineLibrary that uses these libraries, not the tests themselves. It's better to link it to CuraEngineLibrary itself rather than to the test executables.
2015-11-02 16:56:41 +01:00
Ghostkeeper
3231d75d94
Use static cast instead of c-style cast
...
The behaviour of this cast is better defined.
Contributes to issue CURA-285.
2015-11-02 16:48:53 +01:00
daid
5e4080e0bb
Add clipper and Arcus libraries to link targets in an attempt to fix the build.
2015-11-02 16:17:16 +01:00
Ghostkeeper
6432215ad9
Merge branch '15.10' of http://github.com/Ultimaker/CuraEngine
...
Conflicts:
CMakeLists.txt
src/FffGcodeWriter.cpp
src/FffPolygonGenerator.cpp
src/comb.cpp
src/gcodeExport.cpp
src/gcodeExport.h
src/gcodePlanner.cpp
src/gcodePlanner.h
src/skin.cpp
src/utils/SVG.h
2015-11-02 16:00:52 +01:00
Ghostkeeper
3a60d0cb01
Merge branch '15.10' of http://github.com/Ultimaker/CuraEngine
...
Conflicts:
CMakeLists.txt
src/FffGcodeWriter.cpp
src/FffPolygonGenerator.cpp
src/comb.cpp
src/gcodeExport.cpp
src/gcodeExport.h
src/gcodePlanner.cpp
src/gcodePlanner.h
src/skin.cpp
src/utils/SVG.h
2015-11-02 16:00:06 +01:00
Ghostkeeper
7d70768178
Tell CppUnit to output XML
...
The standard XmlOutputter seems to output JUnit-style XML.
2015-11-02 15:08:28 +01:00
Ghostkeeper
9c201e3396
Remove old try for return code
...
Directly returning the boolean didn't work.
2015-11-02 14:50:57 +01:00
Ghostkeeper
f00c091ed1
Add actual tests for getDist2FromLineSegmentTest
...
It tests various types of line segments with points in various places. The tests are currently already failing...
2015-11-02 14:37:03 +01:00
Ghostkeeper
4574e0917e
getDist2FromLineSegment pass by const reference
...
This allows for calling the function with constexpr types.
2015-11-02 14:32:57 +01:00
Ghostkeeper
4ae1f5e6bf
Succeeded CppUnit integration
...
If you add -DBUILD_TESTS=true to CMake, it will add a test target for each test file. These can be executed separately as executable file, or they can be ran all at once with 'make test'.
2015-11-02 13:17:11 +01:00
Ghostkeeper
ae02a91a5d
Fix license
...
Yeah I've done that more often... Sorry.
2015-11-02 09:26:13 +01:00
Ghostkeeper
0781a8f4ef
Initial setup of CppUnit in CMake
...
I've setup a basic test but it doesn't actually do anything.
2015-10-30 17:41:48 +01:00
Ghostkeeper
f1902d88bf
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-30 17:08:45 +01:00
Ghostkeeper
4cc5c35564
Fix string casting
...
This script couldn't run because it couldn't convert the ints to strings. It shouldn't convert the ints to strings. It should convert the strings to ints (or floats).
2015-10-30 17:08:18 +01:00
Tim Kuipers
f124a7e528
bugfix: settings overrides weren't working
2015-10-30 16:05:24 +01:00
Tim Kuipers
1cd8e1c500
refactor: moved LayerPlanBuffer implementation to cpp file
2015-10-30 15:31:24 +01:00
Tim Kuipers
6dc89bbe7f
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-30 13:37:54 +01:00
Tim Kuipers
16250c54c9
large refactor/bugfix: moved GcodePathConfig initialization to start of FffGcodeWriter.writeGcode(.) and moved setting of layer-dependent config settings inside GcodePlanner.writeGcode(.)
2015-10-30 13:32:49 +01:00
Ghostkeeper
c6e201e307
Don't combine infill layers if infill is empty
...
If the infill density is 0 and it has to combine layers, it would try to access layers below the first layer that don't exist. Instead it will now not combine at all, saving some processing power too.
Contributes to issue Cura-285.
2015-10-30 12:34:31 +01:00
Ghostkeeper
c5be07212e
Use standard namespace for isinf
...
This one is in the standard namespace. Otherwise it won't compile on stricter compilers. Contributes to #2 .
2015-10-30 11:42:04 +01:00
Tim Kuipers
7035e91ac6
refactor: split raft_config into raft_base_config, raft_interface_config, raft_surface_config
2015-10-29 15:45:14 +01:00
Tim Kuipers
4f972da7ae
moved layer_height from GcodePathconfig to GcodePlanner
2015-10-29 15:29:17 +01:00
Ghostkeeper
47718a1ba4
Merge branch 'master' of http://github.com/Ultimaker/CuraEngine
2015-10-29 15:02:31 +01:00
Ghostkeeper
87db7232a1
Added a test case that would generate support
...
It requires different kinds of support: Support to buildplate, support not to buildplate, supporting edges and supporting faces.
2015-10-29 14:58:33 +01:00
daid
b9f9c12d6c
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2015-10-29 14:40:16 +01:00
daid
046fa3ba8e
Few changes after review by Ruben. Also adds some documentation, but not everything yet.
2015-10-29 14:40:05 +01:00
Tim Kuipers
db039033ce
lil raft fan speed bug
2015-10-29 11:47:32 +01:00
Tim Kuipers
c0fa1b4a1a
lil bugfix: no more redundant raft layer comments
2015-10-29 11:41:15 +01:00
Tim Kuipers
1d073600e4
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-10-29 11:36:59 +01:00
Tim Kuipers
8f6cb82421
merge of raft bugfixes
2015-10-29 11:29:43 +01:00
Tim Kuipers
a455913165
lil
2015-10-28 17:03:19 +01:00
Tim Kuipers
9b0e4be570
bugfixes print z when raft is present
2015-10-28 17:00:25 +01:00
Ghostkeeper
1023102e3a
Log an error when layer height is not positive
...
In addition to returning false, sliceModel now also logs an error when the layer height is invalid.
2015-10-28 16:38:27 +01:00
Ghostkeeper
0ac334c849
Log an error when slicing failed
...
In the command socket, when slicing failed, it would just ignore the failure and continue. This is fine, but let's at least log an error when that happens.
2015-10-28 16:34:59 +01:00
Ghostkeeper
696e0132f4
Break when layer height is 0
...
After discussing this with several colleagues, this seems to be the desired behaviour.
2015-10-28 16:19:06 +01:00
Tim Kuipers
f9a0e39a6a
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-28 15:22:08 +01:00
Tim Kuipers
ff9e7f11ae
optimization:infill layers arent combined when combine count=1
2015-10-28 15:21:44 +01:00
Ghostkeeper
fb284397c2
Only assert for insane g-code values in debug mode
...
A preprocessor definition is added if CMAKE_BUILD_TYPE == DEBUG. So for release builds, set CMAKE_BUILD_TYPE properly to RELEASE and CuraEngine will no longer stop at the assertion.
2015-10-28 15:17:33 +01:00
daid
f5e2c5a070
Handle the new string type setting in the test script. (for which I am wondering if this was introduced with agreement in the team...)
2015-10-28 13:47:15 +01:00
Ghostkeeper
85cfd422ba
Remove infill_sparse_combine setting
...
In discussion, we deemed infill_sparse_thickness more clear to the user and infill_sparse_combine superfluous, since it is really an intermediary value used by the engine to round the thickness up. So now it is actually computed in the engine. Accompanying this commit will be a commit to Cura to remove the setting from the .json file.
2015-10-28 13:10:16 +01:00
Ghostkeeper
c5334e355e
Re-do minimum combine_infill_layers check
...
This was accidentally removed in the merge...
2015-10-28 12:49:39 +01:00
Tim Kuipers
086c38ac0b
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-28 12:45:37 +01:00
Tim Kuipers
4cb64bab67
Merge conflict resolve of feature_temp_compensation_gcodePlanner
2015-10-28 12:42:57 +01:00
daid
87eaa97f21
Return used commands on failure.
2015-10-28 10:47:22 +01:00
daid
59fc004f09
Did not report failure count from default test, causing the rest of the tests not to run.
2015-10-28 09:44:49 +01:00
daid
5dbfab6ffb
Small fix in test script timestamp generator.
2015-10-28 09:36:19 +01:00
daid
5494ce12a5
Update test script to include the base name of the model filename, not the full path. And reduce the amount of random tests when previous tests are failing.
2015-10-28 09:35:13 +01:00
Tim Kuipers
1ed1de147a
refactor: renamed heatup time settings: inverted unit: s/*C => *C/s
2015-10-27 16:15:18 +01:00
Tim Kuipers
1c0a616ec7
refactor: flow_temp_graph => material_flow_temp_graph
2015-10-27 15:36:49 +01:00
Tim Kuipers
82a4bff953
use material_flow_dependent_temperature to turn off flow based temp
2015-10-27 15:24:58 +01:00
Tim Kuipers
f7bbda7599
new temp settings
2015-10-27 14:10:56 +01:00
Tim Kuipers
273f1f46f3
LayerPLanBuffer documentation
2015-10-27 13:31:45 +01:00
Tim Kuipers
e81abe405d
lil vector.reserve optimization
2015-10-27 12:29:08 +01:00
daid
d0dd97ab04
Handle engine timeouts.
2015-10-27 12:27:39 +01:00
Tim Kuipers
d0e6f5c07e
Preheat documentation
2015-10-27 12:16:23 +01:00
Tim Kuipers
f4eb33e14e
made heatup and cool down temps depend on whether we are printing
2015-10-27 12:15:52 +01:00
daid
3d3ddc238f
Forgot to actually supply the setting to the engine.
2015-10-27 12:15:44 +01:00
daid
704edd25af
Merge branch 'master' of github.com:Ultimaker/CuraEngine
2015-10-27 12:09:53 +01:00
daid
e33560beb6
Update test script to use the json file to run tests on settings.
2015-10-27 12:09:40 +01:00
Nicanor Romero Venier
71e486d007
Accepts 'help' as a known command
2015-10-27 10:25:17 +01:00
Tim Kuipers
4ca66b6916
Merge pull request #270 from nicanor-romero/master
...
Accepts 'help' as a known command
2015-10-27 10:23:28 +01:00
Nicanor Romero Venier
7e6c4661b9
Accepts 'help' as a known command
2015-10-27 09:49:12 +01:00
daid
f96eaddf6c
Removed code convention file, is moved to Ultimaker/meta as general code convention file for all projects.
2015-10-27 09:27:27 +01:00
Ghostkeeper
eb2ae0d699
Correctly handle case of no layers
...
If there are no layers, the engine used to crash with an assertion error. Instead, it now returns an empty slice, which is correct behaviour. Fixes issue CURA-323.
2015-10-26 12:11:27 +01:00
Ghostkeeper
bcee6c7cc2
No negative initial layer thickness
...
If this setting is zero or negative, make it the minimum layer thickness: 1 micron. Also fixed a mistake in the comment of the similar check for the normal layer thickness setting.
2015-10-26 11:52:32 +01:00
Ghostkeeper
3a28f5d547
No negative layer thickness
...
If this setting is zero or negative, make it the minimum layer thickness: 1 micron.
2015-10-26 11:47:53 +01:00
Tim Kuipers
5c41425859
lil rename
2015-10-23 17:12:07 +02:00
Tim Kuipers
85959b0aa7
handle tmep inserts during MergeInfillLines
2015-10-23 16:34:02 +02:00
Tim Kuipers
6bd1d9fe8c
bugfix: MergeInfillLines copied itself
2015-10-23 15:50:34 +02:00
Tim Kuipers
3e43df9e60
forceMinimalLayerTime: lil optimization
2015-10-23 12:41:21 +02:00
Ghostkeeper
4b11b5946e
Remove infill_sparse_combine setting
...
In discussion, we deemed infill_sparse_thickness more clear to the user and infill_sparse_combine superfluous, since it is really an intermediary value used by the engine to round the thickness up. So now it is actually computed in the engine. Accompanying this commit will be a commit to Cura to remove the setting from the .json file.
2015-10-23 12:14:06 +02:00
Ghostkeeper
d558e24b43
Re-do minimum combine_infill_layers check
...
This was accidentally removed in the merge...
2015-10-23 11:43:51 +02:00
Ghostkeeper
5d6f45a71d
Merge branch 'master' of http://github.com/Ultimaker/CuraEngine
...
Changed files:
* src/skin.cpp
2015-10-23 11:41:29 +02:00
Ghostkeeper
d827cc0f92
Never combine 0 layers
...
Infill_combine_layers of 0 is an invalid value. So perform this sanity check to make sure that infill_combine_layers is always at least 1.
2015-10-23 11:25:06 +02:00
Tim Kuipers
faa580ffe6
refactored TimeMaterialEstimates.travel_time into retracted_travel_time and unretracted
2015-10-22 17:50:10 +02:00
Tim Kuipers
16679d68d0
unindent refactor
2015-10-22 16:44:27 +02:00
Tim Kuipers
9983ebac7b
bugfix: layer_plan.processFanSpeedAndMinimalLayerTime called twice on the same layer
2015-10-22 16:42:48 +02:00
Tim Kuipers
ee8ef2bfa5
variable buffer size; better idle temp handing; refactored insertPreheatCommand into single and multiExtrusion; more...
2015-10-22 16:30:15 +02:00
Tim Kuipers
7646426f9d
LayerPlanBuffer.cpp to move function bodies to
2015-10-22 16:26:45 +02:00
Ghostkeeper
263eb370e9
Handle edge case of parallel line intersection
...
If a line was parallel with an edge of the polygon, the line should be marked as intersecting that edge to properly register the scanline crossing. This handles that edge case for most cases by adding one intersection. In some cases it is plausible that two intersections should be registered. For those cases this procedure is still wrong, since it is computationally expensive to detect them.
2015-10-22 13:34:13 +02:00
Ghostkeeper
c0d22dcf7b
Move middle_from and middle_to inside as well
...
When combing needs additional waypoints (middle_from and middle_to), these waypoints weren't offset away from the edge towards the inside of the mesh. This caused all sorts of mistakes with edge cases. This prevents these edge cases.
2015-10-22 13:29:57 +02:00
Ghostkeeper
01d0a3b8d6
Add variant of writeAreas for point vector
...
Rather than having to supply a polygon, you can now supply a vector of points too. This helps if you want to visualise a custom polygon. Rather than having to clone a polygon some way, clear it and fill it with your own points, you now don't have to create a polygon container at all.
2015-10-22 11:29:59 +02:00
Ghostkeeper
1dd7313332
Fix moveInside corner cases
...
When the specified point is closest to a vertex of the polygon rather than an edge, the computed inward direction was wrong. I think this was a typo.
2015-10-22 11:15:59 +02:00
Ghostkeeper
7a7d1ebd77
Edge cases in moveInside
...
If we're moving points inside, points on the edge also have their direction of motion altered. This effectively means that the corner case happens more often.
2015-10-22 11:11:20 +02:00
Tim Kuipers
2976b1276c
refactor: Insert ==> NozzleTempInsert
2015-10-22 11:01:19 +02:00
Tim Kuipers
b84f41d9b0
bugfixes: waited for temp on wrong places; inserted preheat commands for each layer instead of jsut the last
2015-10-21 18:05:59 +02:00
Tim Kuipers
f142df9176
bugfix: use correct extruder for which to preheat; included cool down inserts
2015-10-21 17:42:23 +02:00
Tim Kuipers
94f90419dd
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-21 17:00:13 +02:00
Tim Kuipers
90547bb69c
bugfix: dual prime tower was broken (gave SEGFAULT on acces of config)
...
Conflicts:
src/FffGcodeWriter.cpp
2015-10-21 16:59:59 +02:00
Tim Kuipers
3611d53222
bugfix: dual prime tower was broken (gave SEGFAULT on acces of config)
2015-10-21 16:56:00 +02:00
Tim Kuipers
ab7ca73596
bugfixes for dual extrusion in LayerPlanBuffer
2015-10-21 16:35:18 +02:00
Tim Kuipers
c42568c059
first working preheat inserts in gcode
2015-10-21 15:55:17 +02:00
Tim Kuipers
43eb784b6c
cleanup old LayerPLanBuffer code and debug output
2015-10-21 13:35:45 +02:00
Tim Kuipers
68f1eb1fd2
better temp update starting time
2015-10-21 13:31:58 +02:00
Ghostkeeper
3dfb84b9a1
Added include(Point) for 2D bounding boxes too
...
This functionality already existed for 3D axis aligned bounding boxes. It makes it easier to construct a bounding box when no explicit polygon is available. To facilitate this, the bounding box is properly constructed with high minimum value too.
2015-10-21 12:28:03 +02:00
Ghostkeeper
80896e3f4d
Fix order of parameter initialisation
...
This caused a compiler warning.
2015-10-21 12:16:49 +02:00
Tim Kuipers
6518e14e18
lil code convention braces
2015-10-21 12:05:47 +02:00
Tim Kuipers
4c95e43048
refactor: extrudeSpeedFactor (lil) made more verbose
2015-10-21 12:03:56 +02:00
Tim Kuipers
4c66b7fd01
lil
2015-10-21 11:46:50 +02:00
daid
97ebfe8b12
Remove RPM build.
2015-10-21 10:13:33 +02:00
Tim Kuipers
0cb8b64f70
rewrote LayerPlanBuffer.insertPreheatCommands
2015-10-20 18:12:27 +02:00
Tim Kuipers
bfc2d458ae
refactor: renamed TempFlowGraph to FlowTempGraph
2015-10-20 13:51:50 +02:00
Tim Kuipers
365de0578c
refactor: renamed TempFlowGraph to FlowTempGraph
2015-10-20 13:50:09 +02:00
Tim Kuipers
d9c30de796
lil
2015-10-20 13:46:50 +02:00
Ghostkeeper
e8cb1028e4
Add check against divide by zero
...
If two consecutive points are exactly equal, a divide by zero would happen here. This check prevents the divide in that case and skips the second of the points then.
2015-10-20 13:34:32 +02:00
Tim Kuipers
bc41b415c2
LayerPlanBuffer: insert temp commands at flush
2015-10-20 13:32:32 +02:00
Ghostkeeper
d4adbb97bf
Merge master of http://github.com/Ultimaker/CuraEngine
...
Changed files:
* src/comb.cpp
* src/comb.h
2015-10-19 17:06:09 +02:00
Ghostkeeper
c8488f6d37
Add writeDashedLine
...
It draws a dashed line on the canvas. This helps if there are multiple lines on top of each other.
2015-10-19 16:45:16 +02:00
Ghostkeeper
7524df2868
Add yellow colour to SVG
...
I needed an extra colour for debugging. Why not yellow?
2015-10-19 16:43:55 +02:00
Ghostkeeper
28ac5dc2c9
Switch X to be the horizontal dimension
...
This was the wrong way around in everything except my writeLines function. X is commonly the horizontal dimension (even in the SVG language itself).
2015-10-19 13:58:25 +02:00
Ghostkeeper
f5db2ee8b4
Merge master to 15.10
...
I need the new writeLines in SVG debugging. I know it's not really a bugfix, but SVG is not used in actual releases, so it would not break anything.
2015-10-19 11:46:09 +02:00
Tim Kuipers
8e736f32aa
LayerBuffer bugfixes
2015-10-16 16:11:39 +02:00
Tim Kuipers
9b4d93e236
getSettingAsFlowTempGraph
2015-10-16 15:38:33 +02:00
Ghostkeeper
2f4316e755
Fix infill if too few layers
...
I just introduced a bug where if there were too few layers such that no infill is generated at all, the infill combining would take a practically infinite amount of time. The cause was an underflow. This fixes it.
2015-10-16 13:55:56 +02:00
Ghostkeeper
52e5b33e7e
Remove debug includes
...
These two includes were used to debug the combing, but they shouldn't have been committed.
2015-10-16 13:45:38 +02:00
Ghostkeeper
01c124774c
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-16 13:35:43 +02:00
Ghostkeeper
b4afc8bb4f
Narrow range of combining infill layers
...
Infill layers only need to be combined between <bottom_layers> and <N - 1 - top_layers>. This theoretically makes the code a bit faster. Also, the infill is now combined from 0 upwards rather than in reverse order, and renamed layer_index to layer_idx.
2015-10-16 13:30:46 +02:00
Tim Kuipers
d4e2f774db
parse array settings
2015-10-16 13:28:33 +02:00
Tim Kuipers
eb388c7d80
parse json arrays
2015-10-16 13:28:26 +02:00
Tim Kuipers
ab5b7f432e
unindeted wrongly indented function
2015-10-16 13:28:17 +02:00
Tim Kuipers
e0a09dbe7c
parse array settings
2015-10-16 13:20:32 +02:00
Tim Kuipers
d83863ce4c
parse json arrays
2015-10-16 13:20:17 +02:00
Tim Kuipers
fe8def059e
unindeted wrongly indented function
2015-10-16 12:09:20 +02:00
Ghostkeeper
b91abb4c22
Don't process nonexistent file
...
If the file you're trying to load doesn't exist, don't add an empty mesh to the mesh group, and don't try to slice that mesh.
2015-10-16 10:40:33 +02:00
Tim Kuipers
4179e46a9d
insert preheat command into extruderplan and compute temp from graph
2015-10-16 10:28:24 +02:00
Tim Kuipers
692e875256
more layerPlanBuffer refactor and computation of where to insert the preheat command
2015-10-15 18:58:50 +02:00
Tim Kuipers
9d513291ba
used iterator instead of complicated nested for loop bs
2015-10-15 18:41:21 +02:00
Tim Kuipers
5b0370864b
syntax mistake fixes
2015-10-15 18:34:21 +02:00
Tim Kuipers
4dcb8563f5
more LayerBuffer crap
2015-10-15 18:32:10 +02:00
Tim Kuipers
21b6be76fe
introduced buffer.iterator
2015-10-15 18:28:35 +02:00
Tim Kuipers
f06fa4af1a
special case for when the first extruder plan of a layer is with the same extruder as the last extruder plan of the previous layer
2015-10-15 18:05:53 +02:00
Tim Kuipers
951eac4c08
config per extruder
2015-10-15 18:05:02 +02:00
Tim Kuipers
e4e2dc172e
flow-temp graph class
2015-10-15 17:41:22 +02:00
Tim Kuipers
70b0800f2e
insertPreheatCommands first approximation
2015-10-15 17:19:32 +02:00
Tim Kuipers
aaaf2a6c92
Preheat file first approximation
2015-10-15 17:18:58 +02:00
Ghostkeeper
bde136e7ed
Fix failed merge
...
I picked the wrong one to resolve the conflict.
2015-10-15 16:53:42 +02:00
Ghostkeeper
75859623d7
Remove duplicate points from comb path
...
This sometimes produced zero-length moves at the beginning and end of combing paths.
2015-10-15 16:37:34 +02:00
Ghostkeeper
388a65ef11
Fix combing optimisation intersection bug
...
The intersections of the line and the polygons was not offset with the extra offset distance to prevent edge cases. This concerns issue #259 .
2015-10-15 16:37:34 +02:00
Ghostkeeper
1168c2b120
Document edge cases in line-polygon intersection
...
It is documented that basically all edge cases trigger a collision.
2015-10-15 16:37:34 +02:00
Ghostkeeper
dfd31844ba
Handle edge cases for line-polygon collision properly
...
If a line doesn't intersect but does touch a polygon, a collision is now triggered. This is the desired behaviour in this case, since this method is only used by the combing code.
2015-10-15 16:37:34 +02:00
Ghostkeeper
f457f2590c
Add writeLines
...
This draws a polyline on the canvas, which is a sequence of connected line segments. This helps visualising paths.
2015-10-15 16:37:33 +02:00
Ghostkeeper
fb9bcccbbe
Fix writeLine to transform the points
...
The transform scales the line to the proper scale, to match the scale of the viewport.
2015-10-15 16:37:33 +02:00
Ghostkeeper
cfe216ae44
Merge master onto a41a1e5
...
Modified files:
src/gcodeExport.cpp
2015-10-15 16:36:21 +02:00
Tim Kuipers
a41a1e556a
merge
2015-10-15 11:56:01 +02:00
Tim Kuipers
8081237298
merge
2015-10-15 11:54:33 +02:00
Tim Kuipers
1a7137a6c8
bugfix: make all varargs functions use rvalues - fixes the varargs functions making copies of the objects which are passed by reference
2015-10-15 11:52:22 +02:00
Tim Kuipers
4c967ec6a3
buggy layer buffer used
2015-10-15 09:22:55 +02:00
Tim Kuipers
b455661a75
moved processFanSpeedAndMinimalLayerTime outside of gcodePlanner.writeGcode
2015-10-14 14:17:17 +02:00
Tim Kuipers
46b7d1ccab
keep time and material info at each GCodePath and each ExtruderPlan
2015-10-14 13:54:29 +02:00
Tim Kuipers
fb95022776
assert fix
2015-10-14 11:45:44 +02:00
Tim Kuipers
62ce0b5513
changed starting position to 0,0,20mm
2015-10-14 11:35:15 +02:00
Tim Kuipers
12c25b2214
Revert "added no_point instead of (0,0)"
...
This reverts commit f49803b8a9 .
2015-10-14 11:33:33 +02:00
Tim Kuipers
61915fc322
bugfix: raft is now uses combing, instead of retracting everywhere
2015-10-14 10:57:01 +02:00
Tim Kuipers
aa1998dbd8
halfway bugfix: combing during raft
2015-10-14 10:56:36 +02:00
Hajo Nils Krabbenhöft
859a106ec2
rework getLayerSecondWalls() to make sure it doesn't completely remove isles with less than 0.8mm radius (= offset_from_outlines = 2*nozzle_size)
2015-10-14 10:54:34 +02:00
Tim Kuipers
ff38534644
bugfix: raftmargin was ignored
2015-10-14 10:45:56 +02:00
Tim Kuipers
2eb81d216f
manual merge for raft z
2015-10-14 10:45:31 +02:00
Ghostkeeper
2785659fe6
Move layer loop into combineInfillLayers
...
The combineInfillLayers function now loops over all layers and combines them. The function therefore no longer needs to be called for every layer.
2015-10-14 10:07:31 +02:00
Ghostkeeper
4bc86ad192
Compute combined infill layers only on modulo-0 layers
...
For instance, if the sparse_infill_combine setting is 3, it will only be computed for layers 0, 3, 6, etc. This prevents different parts of infill from landing on different layers, causing infill to break into multiple layers.
2015-10-14 10:07:22 +02:00
Tim Kuipers
a7b5e05505
bugfix: support roofs sendPolygons now of type SupportType
2015-10-14 10:03:49 +02:00
Tim Kuipers
0fd130cfd3
bugfix: support roof config and support roof sendPolygons(.)
2015-10-14 10:03:33 +02:00
Tim Kuipers
ccae7d611e
bugfix: timeEstimate recalculate trapezoids failed
2015-10-14 10:02:45 +02:00
Arjen Hiemstra
5dcce74efe
Increment layer count for each object that should be printed as a single object
...
This makes the ordering for one-at-a-time mode more clear
CURA-222 #Start-Review
2015-10-13 17:54:25 +02:00
Tim Kuipers
988af0f6ed
(buggy dual extr) refactor: gcodePlanner now consists of ExtruderPlan s which consist of Path s
2015-10-13 15:39:30 +02:00
Tim Kuipers
53714319b4
more work on buffer.insertPreheatCommands
2015-10-13 13:57:28 +02:00
Tim Kuipers
fe44537924
Merge branch 'master' into feature_temp_compensation_gcodePlanner
2015-10-13 13:14:31 +02:00
Tim Kuipers
a285b22804
reintroduced initial layer height when raft is present
2015-10-13 12:33:03 +02:00
Tim Kuipers
e588fe100b
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-10-13 12:01:26 +02:00
Tim Kuipers
ad81cc8a12
bugfix: raft is now uses combing, instead of retracting everywhere
2015-10-13 12:01:16 +02:00
Tim Kuipers
a3db17442c
halfway bugfix: combing during raft
2015-10-13 10:49:19 +02:00
Tim Kuipers
e0cf567bf7
bugfix: raftmargin was ignored
2015-10-13 09:55:07 +02:00
Tim Kuipers
904ad24eec
bugfix: raft z was computed as if it was a normal layer
2015-10-13 09:47:06 +02:00
Tim Kuipers
f49803b8a9
added no_point instead of (0,0)
2015-10-09 17:22:45 +02:00
Tim Kuipers
2b422ce6c0
debug output command socket transmitted data as STL
2015-10-09 15:33:56 +02:00
Ghostkeeper
b2cc46a4cb
Move layer loop into combineInfillLayers
...
The combineInfillLayers function now loops over all layers and combines them. The function therefore no longer needs to be called for every layer.
2015-10-09 13:45:39 +02:00
Ghostkeeper
98d105d73c
Compute combined infill layers only on modulo-0 layers
...
For instance, if the sparse_infill_combine setting is 3, it will only be computed for layers 0, 3, 6, etc. This prevents different parts of infill from landing on different layers, causing infill to break into multiple layers.
2015-10-09 10:45:39 +02:00
Tim Kuipers
ecd32700f5
lil bugfixes
2015-10-08 16:01:57 +02:00
Ghostkeeper
44c77d2a31
Add Netbeans project file to gitignore
...
Also categorised the ignore file. Only the "nbproject/*" is new.
2015-10-08 15:35:35 +02:00
Hajo Nils Krabbenhöft
f78c3ed4da
thicker lines for retraction moves
2015-10-08 15:30:07 +02:00
Hajo Nils Krabbenhöft
79b16e406a
GCodePlanner will initialize command socket on GCodeExport, which will then send combing and retraction paths to GUI
2015-10-08 15:30:07 +02:00
Hajo Nils Krabbenhöft
8219f32d96
also add new poly types to cpp backend
2015-10-08 15:30:07 +02:00
Hajo Nils Krabbenhöft
05cfe62927
add new types to protobuf
2015-10-08 15:30:07 +02:00
Ghostkeeper
38e832c172
Move documentation to header file
...
This documentation should be in the header, as per the code style conventions and for Doxygen.
2015-10-08 15:12:51 +02:00
Tim Kuipers
64ef6e5698
first approximation of the layer plan buffer
2015-10-08 14:49:33 +02:00
Tim Kuipers
769dc252df
coding conventions: Pointers vs. references
2015-10-08 11:22:50 +02:00
Tim Kuipers
7093231707
auto-merge fixes
2015-10-07 16:32:25 +02:00
Tim Kuipers
ad93a8adde
cleanup: no more use of gcode.startPosition; moved gcode.setZ(.) from FffGcodeWriter to gcodePlanner.writeGcode(.)
2015-10-07 16:24:39 +02:00
Tim Kuipers
1bb8bde1de
TODO warning; is this code very unsafe maybe?
2015-10-07 15:52:06 +02:00
Tim Kuipers
d6822cdaf8
bugfix: processFanSpeedAndMinmalLayerTime was commented
2015-10-07 14:59:25 +02:00
Tim Kuipers
2817528c51
undoing gcodePlanner buffer edits from the commits from the feature_temp_compensation_gcodePlanner branch
2015-10-07 14:58:33 +02:00
Tim Kuipers
a52f101c14
fully purged gcodePlanner from references to gcodeExport: moved current position and current extruder to FffGcodeWriter
2015-10-07 14:51:07 +02:00
Tim Kuipers
22b1d427ec
forgot to add a header file in last commit
2015-10-07 14:49:33 +02:00
Tim Kuipers
b89733320d
purged gcodePlanner from references to gcodeExport: moved processFanSpeedAndMinimalLayerTime and factored out lastPosition=gcode.gettPositionXY(); introduced very basic gcodePlanner buffering
2015-10-07 14:09:44 +02:00
Tim Kuipers
f662844d78
bugfix: support roofs sendPolygons now of type SupportType
2015-10-07 10:23:37 +02:00
Tim Kuipers
38a4e45771
bugfix: support roof config and support roof sendPolygons(.)
2015-10-06 15:16:43 +02:00
Tim Kuipers
dc87dda346
Merge pull request #255 from nicanor-romero/15.10
...
Explicitly write a \n when finding a new line in a comment
2015-10-06 14:17:52 +02:00
Nicanor Romero Venier
f249796f3d
Explicitly write a \n when finding a new line in a comment
...
This way the start_gcode and end_gcode that includes '\n's will not
have their commands executed since they now appear as commented out.
2015-10-06 13:05:00 +02:00
Tim Kuipers
9602616a6b
bugfix: timeEstimate recalculate trapezoids failed
2015-10-02 17:01:32 +02:00
Tim Kuipers
0823f8faf5
syntax fixes of last merge
2015-10-01 15:46:17 +02:00
Tim Kuipers
33d63e8359
Merge branch '15.10'
...
Conflicts:
src/FffGcodeWriter.cpp
src/gcodePlanner.cpp
2015-10-01 15:44:20 +02:00
Tim Kuipers
3a8a5844d4
moved file 'new settings master'
2015-10-01 15:08:55 +02:00
Tim Kuipers
7b5bb1e367
write 'end of gcode' comment at end of gcode
2015-10-01 11:18:00 +02:00
Tim Kuipers
017dc5be4c
bugfix: profile string caused bugs on UMO and when USB printing
2015-10-01 11:14:18 +02:00
Tim Kuipers
60c9e83da9
bugfix: double skin areas
2015-09-30 16:18:26 +02:00
Tim Kuipers
51927938b0
bugfix: visualization used support areas instead of lines
2015-09-30 12:31:03 +02:00
Tim Kuipers
d4b9f7c0bd
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-09-30 09:43:58 +02:00
Tim Kuipers
0b78099587
bugfix: coasting speeds were 100 times too much (%)
2015-09-30 09:43:46 +02:00
Arjen Hiemstra
a61d5385ea
Use size_t instead of "long unsigned int" for storing vector sizes
...
std::vector<>::size() returns a size_t. size_t is a long uint on 64-bit
but a normal uint on 32-bit. So compilation on 32-bit fails because
std::max cannot do template deduction correctly.
2015-09-29 17:52:02 +02:00
Tim Kuipers
24c836f87a
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-09-29 16:14:50 +02:00
Tim Kuipers
8a2ca62305
bugfix: retractions on any move smaller than the retraction_min_travel when combing was disabled
2015-09-29 16:14:40 +02:00
Arjen Hiemstra
b0ae307006
Fix check for "touching buildplate" option of support type
...
CURA-168 #done
2015-09-29 16:09:06 +02:00
Hajo Nils Krabbenhöft
29dd62345a
use int for zhop
2015-09-29 15:49:34 +02:00
Hajo Nils Krabbenhöft
b3f555c78f
store current z-hop height and keep applying that on multi-step travel
2015-09-29 15:49:25 +02:00
Tim Kuipers
0b2f64c6a7
bugfix: total_layers count
2015-09-29 14:44:50 +02:00
Tim Kuipers
d501fe67d5
refactor: totalLayers -> total_layers
2015-09-29 14:41:12 +02:00
Tim Kuipers
7180e77699
refactor: fixed enum FillPerimeterGapMode to match other enums
2015-09-29 11:04:04 +02:00
Olliver Schinagl
9c36fdf513
GCodeExport: (re-)Add layer_count tag
...
Commit 1070d36 broke the build by enabeling code that was not kept up to
date, this patch fixes it properly by adding the
writeLayerCountComment() method.
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com >
2015-09-29 11:03:35 +02:00
Tim Kuipers
bc8a167e7b
refactor: fixed enum FillPerimeterGapMode to match other enums
2015-09-29 11:03:32 +02:00
Olliver Schinagl
a2881b83f7
GCodeExport: (re-)Add layer_count tag
...
Commit 1070d36 broke the build by enabeling code that was not kept up to
date, this patch fixes it properly by adding the
writeLayerCountComment() method.
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com >
2015-09-29 10:25:35 +02:00
Olliver Schinagl
bd90dd060f
Re-nable layer count using a consistent tag name
...
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com >
2015-09-28 17:37:03 +02:00
Olliver Schinagl
1070d367e1
Re-nable layer count using a consistent tag name
...
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com >
2015-09-25 12:04:19 +02:00
Arjen Hiemstra
5ac62a96a8
Also fix another call for Fill Perimeter Gaps
...
Contributes to Ultimaker/Cura#411
2015-09-22 12:38:53 +02:00
Arjen Hiemstra
7010689448
Fix "Fill Perimeter Gaps" to properly check values
...
Since the enum values were changed to normalised values this check was
wrong. Additonally, now properly use an Enum for the values since that
is a cleaner approach.
Fixes Ultimaker/Cura#411
2015-09-22 12:37:03 +02:00
Jaime van Kessel
869975be6b
Merge pull request #247 from fxtentacle/15.10-retract-when-no-combing
...
always retract when combing is disabled
2015-09-22 09:57:23 +02:00
Hajo Nils Krabbenhöft
da3bf8da32
always retract when combing is disabled
2015-09-22 09:53:11 +02:00
Jaime van Kessel
e861fba11b
Merge pull request #246 from fxtentacle/fix-retraction-for-small-isles
...
fix retraction for isles < 0.8mm radius
2015-09-21 21:22:58 +08:00
Hajo Nils Krabbenhöft
226c974b5f
rework getLayerSecondWalls() to make sure it doesn't completely remove isles with less than 0.8mm radius (= offset_from_outlines = 2*nozzle_size)
2015-09-21 14:14:18 +02:00
Jaime van Kessel
b25c72a9e3
Merge pull request #245 from fxtentacle/fix-zhop-2
...
Keep Z-Hop active for multi-step moves
2015-09-21 18:06:25 +08:00
Hajo Nils Krabbenhöft
6caf2b2db9
instead of the hardcoded 1.5mm, use last_retraction_config->retraction_min_travel_distance as threshold
2015-09-21 12:01:57 +02:00
Hajo Nils Krabbenhöft
b6138cb951
replace hardcoded Comb::max_comb_distance_ignored = 1.5mm with function parameter, which defaults to 1.5mm
2015-09-21 12:00:37 +02:00
Jaime van Kessel
e9b0cfc939
Merge pull request #244 from fxtentacle/retract-when-no-combing2
...
always retract when combing is disabled
2015-09-21 17:34:08 +08:00
Hajo Nils Krabbenhöft
f6e44af43d
use int for zhop
2015-09-21 11:33:09 +02:00
Hajo Nils Krabbenhöft
487f35abd4
store current z-hop height and keep applying that on multi-step travel
2015-09-21 11:33:09 +02:00
Jaime van Kessel
2a163528f9
Merge pull request #242 from fxtentacle/master
...
send travel moves to GUI from GCodeExport
2015-09-21 17:32:08 +08:00
Hajo Nils Krabbenhöft
02e6c87396
always retract when combing is disabled
2015-09-21 11:31:59 +02:00
Hajo Nils Krabbenhöft
b367af6ad1
thicker lines for retraction moves
2015-09-21 00:17:02 +02:00
Hajo Nils Krabbenhöft
eef8b77405
GCodePlanner will initialize command socket on GCodeExport, which will then send combing and retraction paths to GUI
2015-09-21 00:11:07 +02:00
Hajo Nils Krabbenhöft
97a4c00022
also add new poly types to cpp backend
2015-09-20 23:23:41 +02:00
Hajo Nils Krabbenhöft
6516ae0da9
add new types to protobuf
2015-09-20 23:16:07 +02:00
Arjen Hiemstra
360e3d7e24
Fix one-at-a-time mode so it does not stop after printing 1 object
...
CURA-162:review
CURA-190:review
2015-09-18 12:09:08 +02:00
Tim Kuipers
c267492a48
bugfix: raft viz
2015-09-10 13:20:44 +02:00
Tim Kuipers
52258e2d3a
bugfix: send polygon info after fuzzy skin
2015-09-10 11:44:43 +02:00
Tim Kuipers
92c6edca86
bugfix: send polygon info after fuzzy skin
2015-09-10 11:40:26 +02:00
Tim Kuipers
9c26c820a9
bugfix: skin line distance was infill line width
2015-09-10 11:20:40 +02:00
Tim Kuipers
b7993441ff
bugfix: support progress was still wrong per object
2015-09-10 10:22:06 +02:00
Tim Kuipers
10ebc96323
bugfix: no bottom/top layers resulted in a lingle layer
2015-09-09 17:06:08 +02:00
Tim Kuipers
13af50f34d
Merge branch '15.10' of https://github.com/Ultimaker/CuraEngine into 15.10
2015-09-09 16:52:25 +02:00
Tim Kuipers
0563c6eacc
Merge branch 'bugfix_per_object_support' into 15.10
2015-09-09 15:26:54 +02:00
Tim Kuipers
ab313b8992
doc: explanations on support
2015-09-09 14:18:38 +02:00
Tim Kuipers
7779bb9604
bugfix: support roofs per object
2015-09-09 13:54:18 +02:00
Tim Kuipers
1576d1d19e
bugfix: normal support per object
2015-09-09 13:23:17 +02:00
Tim Kuipers
615ed0b384
README now has correct call method
2015-09-09 11:00:29 +02:00
Arjen Hiemstra
6f95a78f3c
Set correct RPATH for CuraEngine
2015-09-08 17:29:25 +02:00
Tim Kuipers
ae79d232f3
bugfixes for skin extrusion width; feature: toggle skin_no_small_gaps_heuristic
2015-09-08 16:25:21 +02:00
Tim Kuipers
11786ada66
lil change fuzzy mode
2015-09-08 12:35:24 +02:00
Tim Kuipers
648bc1f3f3
bugfix: fuzzy skin had too many points; redux can lead to not enough points on poly
2015-09-08 12:35:16 +02:00
Tim Kuipers
84be436eb9
feat: fuzzy skin magic mode
2015-09-08 12:35:06 +02:00
Tim Kuipers
e04965187a
bugfix: visualize skin lines instead of areas
2015-09-08 10:34:53 +02:00
Tim Kuipers
ee09c6da92
lil change fuzzy mode
2015-09-04 10:10:58 +02:00
Tim Kuipers
325345a2ce
bugfix: fuzzy skin had too many points; redux can lead to not enough points on poly
2015-09-03 19:15:40 +02:00
Tim Kuipers
29e17d8bdf
feat: fuzzy skin magic mode
2015-09-03 18:33:15 +02:00
Tim Kuipers
1f1bfadf9e
basic priliminary functionality for tracking print time per feature; safety assertions in writemove(.) which work for UM2
2015-09-03 14:22:41 +02:00
Tim Kuipers
5aca2bde45
bugfix: speeds were too high for merged infill lines
2015-09-03 14:16:38 +02:00
Tim Kuipers
ae6426cb6e
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-09-02 13:29:34 +02:00
Arjen Hiemstra
7271693169
Normalize enum value names to reflect changes in the JSON file
...
We now store options as (key => user visible string) in the json file.
The keys in the json file have been normalized. Now the engine also
reflects that change.
2015-09-01 18:20:22 +02:00
Tim Kuipers
d5bbe57571
magic_mesh_surface_mode setting refactor registered
2015-09-01 15:28:11 +02:00
Tim Kuipers
8423d3ed4a
lil
2015-08-31 17:09:20 +02:00
Tim Kuipers
b1f717ad9b
refactor: moved processOozeShield
2015-08-31 15:07:37 +02:00
Tim Kuipers
00eba89494
refactor: made all enums conformant
2015-08-31 14:48:59 +02:00
Tim Kuipers
76e5b8b94b
split magic_mesh)surface_mode into Normal, Surface, Both
2015-08-31 14:31:28 +02:00
Tim Kuipers
80e09a05ef
lil bugfix: typo in FffPolygonGenerator.cpp
2015-08-31 13:06:58 +02:00
Tim Kuipers
e96bd68324
bugfix: SliceDataStorage::getLayerOutlines used ungenerated support
2015-08-31 13:05:36 +02:00
Tim Kuipers
9ba6239219
bugfix: ooze shield was computed before support
2015-08-31 13:04:52 +02:00
Tim Kuipers
af099e6896
used SliceDataStorage::getLayerOutlines(.) for raft, skirt, oozeShield, draftShield, combing
2015-08-31 12:36:34 +02:00
Tim Kuipers
bcdcc25a51
offsetPolyline(.)
2015-08-31 12:30:54 +02:00
Tim Kuipers
6b9c98914d
SliceDataStorage::getLayerOutlines
2015-08-31 12:30:07 +02:00
Tim Kuipers
e1d508ade0
bugfix: no support for meshes without insets
2015-08-31 12:28:49 +02:00
Tim Kuipers
919c0ea16d
better visualization mesh surface mode and removeEmptyFirstLayers now takes mesh surface mode into account
2015-08-28 16:56:41 +02:00
Tim Kuipers
865b22063b
better visualization mesh surface mode
2015-08-28 16:51:46 +02:00
Tim Kuipers
4bfd48efa7
bugfixes: uninitialized support.generated; uninitialized primeTower.extruder_count; layer_nr_max_filled_layer didnt account for mesh surface mode; refactored all magic_polygon_mode to mesh_surface_mode; bugfix mesh surface mode: tried to write lines as polygons
2015-08-28 16:44:08 +02:00
Tim Kuipers
9e2b269c8b
refactor: slicer and mesh surface mode names; starting mesh surface mode debug
2015-08-28 11:42:09 +02:00
Tim Kuipers
2e78d60c13
disable comb boundary for magic mesh surface mode or spiralize
2015-08-28 10:20:38 +02:00
Tim Kuipers
caf1fd5582
disable comb boundary for magic mesh surface mode or spiralize
2015-08-28 10:20:18 +02:00
Tim Kuipers
8f99483d2c
bugfix: moveinside called for spiralize vase
2015-08-28 10:16:26 +02:00
Tim Kuipers
fc31b13a5e
infill visualized area, not lines...
2015-08-27 14:49:05 +02:00
Tim Kuipers
2ea1bc0e59
refactor: renamed all sparse infill to infill
2015-08-27 14:32:24 +02:00
Tim Kuipers
102fb24d74
bugfix: no infill visualization
2015-08-27 14:26:01 +02:00
Tim Kuipers
381bf1c3d2
bugfix: min area size for infill and skin were too large
2015-08-27 14:17:58 +02:00
Tim Kuipers
03b188aca5
bugfix: now always appending cura profile string
2015-08-27 12:32:10 +02:00
Tim Kuipers
d584b19078
refcator: moved FffProcessor.h functions to cpp
2015-08-27 12:24:47 +02:00
Tim Kuipers
df1b0372ff
refactor: rename fffProcessor to FffProcessor
2015-08-27 12:20:51 +02:00
Tim Kuipers
73de8ac75b
made fffProcessor singleton
2015-08-27 12:19:13 +02:00
Tim Kuipers
48464e9d13
feat: cura settings string to log and end of gcode (when not using commandSocket)
2015-08-27 11:15:53 +02:00
Tim Kuipers
51a9d1b44f
feat/bugfix: implemented missing -g command line option (switch to meshgroup)
2015-08-27 10:27:06 +02:00
Tim Kuipers
481142ef4a
lil cleanup
2015-08-26 16:20:34 +02:00
Tim Kuipers
2eb3d3438a
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-08-26 15:15:08 +02:00
Tim Kuipers
eedda865bc
feat: settings registry handles overrides; refactor: SettingConfig inherits from SettingsContainer (was SettingsCategory)
2015-08-26 15:14:59 +02:00
Tim Kuipers
d9195c276f
settingRegistry handles json document inheritance
2015-08-26 15:11:56 +02:00
Tim Kuipers
5accc6adf8
feat: json settings loader now uses recursion to load other json files
2015-08-26 11:34:18 +02:00
Tim Kuipers
f7fde50e73
print call when erroneous cpommand line parsing
2015-08-26 10:31:51 +02:00
Tim Kuipers
765b8be00b
bugfix: retraction at end of gcode!
2015-08-26 09:57:18 +02:00
Tim Kuipers
756af8601c
feat: infill before walls
2015-08-25 16:18:39 +02:00
TotalRetribution
6a26649fe4
Merged and fixed Conflict with outer_inset_first option in src/FffGcodeWriter.cpp
2015-08-25 15:12:28 +01:00
Tim Kuipers
21661f2f4b
lil
2015-08-25 14:36:35 +02:00
Tim Kuipers
1ffa57f740
enabled support roof configurable pattern and line distance
2015-08-25 13:29:39 +02:00
Tim Kuipers
158b944b76
bugfix: concentric dense infill never called
2015-08-25 13:29:07 +02:00
Tim Kuipers
cce2efd419
refactor: fill of any sort (skin, support, infill) moved to infill.cpp
2015-08-25 13:09:19 +02:00
Tim Kuipers
1853a41117
made polygonUtils work on const polygons
2015-08-25 13:08:39 +02:00
Tim Kuipers
69412eda52
bugfix: support tried to message polygons while support wasnt generated
2015-08-25 10:35:44 +02:00
Tim Kuipers
567c385e69
introduced generateInfill(pattern, ...)
2015-08-25 10:06:20 +02:00
Tim Kuipers
e35f21ef7b
bugfix: disable retraction (set to 0) when retraction not enabled
2015-08-24 17:19:04 +02:00
Tim Kuipers
ee8b2ed39c
bugfix: disable retraction (set to 0) when retraction not enabled
2015-08-24 17:18:33 +02:00
Tim Kuipers
7d93688b9b
removed allways_retract and moved some calls to setCombing to the right place
2015-08-24 17:14:34 +02:00
Tim Kuipers
8daa32f757
bugfix: layer height info sent before beginSendSlicedObject called
2015-08-24 16:15:19 +02:00
Tim Kuipers
cf05eadfaa
polygon settings loading skipped (temp fix)
2015-08-24 13:55:02 +02:00
Tim Kuipers
70093fdb5a
feat/bugfix: z seam placement: back,random or shortest (not yet the aligned)
2015-08-24 12:03:44 +02:00
Tim Kuipers
1a7dec654e
temp file recording the setting changes between master and 15.06
2015-08-24 10:07:55 +02:00
TotalRetribution
5334fb881e
Merge remote-tracking branch 'origin/master' into reverse_inset_order
2015-08-21 15:49:01 +01:00
Tim Kuipers
24f41fe419
refactored calculateMeshorder so that it returns indices instead of the meshes, debug code for z seam in FffGcodeWriter::processInsets
2015-08-20 17:07:31 +02:00
Tim Kuipers
97e89e1a94
bugfix: moveInside didn't want to move inside by default
2015-08-20 16:51:50 +02:00
Tim Kuipers
913f955de8
refactor: moved all polygonUtils into class PolygonUtils with all static methods
2015-08-20 14:24:23 +02:00
Tim Kuipers
a2fa27603b
simplify: decoupled error_dist from smallest_line_length
2015-08-20 14:10:11 +02:00
Tim Kuipers
9d313910f4
removed debug test main
2015-08-20 14:09:35 +02:00
Tim Kuipers
eacc87d435
bugfix: simplify would in some cases move the end point of a long line if it is followed by a lot of small segments
2015-08-20 12:46:37 +02:00
Tim Kuipers
57f276d07e
bugfix: simplify would in some cases move the end point of a long line if it is followed by a lot of small segments
2015-08-20 12:36:39 +02:00
Tim Kuipers
dd638c32e5
bugfixes: now fully removed polygonOptimizer and finished getDist2FromLineSegment
2015-08-20 12:22:39 +02:00
Tim Kuipers
e02ed7c928
removed function [Polygons simplified(args..)] and left [void simplify(args..)]
2015-08-20 12:21:09 +02:00
Tim Kuipers
c0007b156f
improved getDist2FromLineSegment: may have extra output parameter
2015-08-20 12:16:21 +02:00
Tim Kuipers
2c1f4cf50e
removed polygonOptimizer
2015-08-20 12:02:31 +02:00
Tim Kuipers
28612e060c
replaced optimizePolygons by simplify
2015-08-20 12:01:40 +02:00
Tim Kuipers
094370db73
refactor: made LinearAlg2D a class with static methods and moved getClosestOnLineSegment to it
2015-08-20 11:22:44 +02:00
Tim Kuipers
ecb6b7c914
have doxygen generate dependency graphs etc.
2015-08-20 10:50:00 +02:00
Tim Kuipers
51b2d390c5
includes cleanup main.cpp
2015-08-20 10:46:40 +02:00
Tim Kuipers
be157338ad
buggy simplify improvement; bug = circular include?
2015-08-20 10:09:29 +02:00
Tim Kuipers
2c54394cd0
removed polygondebug > moved to SVG.h
2015-08-19 14:27:10 +02:00
Tim Kuipers
141f29bc18
centralized SVG output file (debug)
2015-08-19 14:25:59 +02:00
Tim Kuipers
28b27c971e
bugfix: AABB perfomred totally unnecessary copies!
2015-08-19 12:23:41 +02:00
TotalRetribution
bc9d7aced8
Added: Option to print outer inset first.
2015-08-19 10:35:09 +01:00
TotalRetribution
5bb794dc91
Merge remote-tracking branch 'origin/master' into reverse_inset_order
...
Conflicts:
src/fffProcessor.h
src/settings.cpp
src/settings.h
2015-08-19 10:32:04 +01:00
Tim Kuipers
7efc41e218
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-08-19 11:12:33 +02:00
Tim Kuipers
7145023b6f
lil
2015-08-19 11:12:24 +02:00
Tim Kuipers
8797157351
bugfixes: combing: nor combing during raft, skirt, support, etc. ; not trying to move inside comb boundary when not combing ; skip some trying-to-comb for some travel moves by calling directly addTravel_simple instead of addTravel
2015-08-19 11:11:34 +02:00
Arjen Hiemstra
f999e1b75f
Extend per-object setting support to MeshGroup
2015-08-18 18:20:12 +02:00
Tim Kuipers
5876964d41
refactor: fill_ > infill_
2015-08-18 11:49:08 +02:00
Tim Kuipers
61ff30772c
bugfix: skin used perimeter overlap; feature: move inside after each layer part
2015-08-17 14:43:38 +02:00
Tim Kuipers
e6453082bf
bugfix: UMO bed temp error when there is no heated bed
2015-08-14 17:17:32 +02:00
Tim Kuipers
c2038f7408
coasting config per mesh
2015-08-14 16:16:17 +02:00
Tim Kuipers
ff5a1d82f8
comb offset not depending on general wall line width anymore
2015-08-14 15:11:56 +02:00
Tim Kuipers
1b13dfca97
fixed outer wall width and placement and distinguished between outer wall smaller or larger than nozzle size
2015-08-14 13:48:09 +02:00
Tim Kuipers
fed536b079
fixed outer wall width and placement
2015-08-14 12:45:22 +02:00
Tim Kuipers
3cf74b5624
initial_layer_speed per mesh
2015-08-14 12:29:58 +02:00
Tim Kuipers
52a57b1499
moved retractionMinimalDistance, retraction_extrusion_window, retraction_count_max into RetractionConfig
2015-08-14 11:55:02 +02:00
Tim Kuipers
831266db31
retraction config per mesh, retraction config per extruder
2015-08-13 17:01:20 +02:00
Tim Kuipers
5fdb56966f
get some settings per mesh instead of from general settings
2015-08-13 13:35:21 +02:00
Tim Kuipers
eae4c507a4
optimization: no mesh offset is offset is zero
2015-08-13 13:33:36 +02:00
Tim Kuipers
92b68c5745
mesh positioning retrieved per object
2015-08-13 13:33:04 +02:00
Tim Kuipers
9ade99a9c7
renamed extruder_switch_retract settings and support_extruder_nr_layer_0
2015-08-13 10:31:06 +02:00
Tim Kuipers
097c390fab
enabled print time again
2015-08-13 08:48:37 +02:00
Tim Kuipers
f982202aa4
bugfix: extruder offset enabled when should have been disabled, and vice versa! (The heat is getting to me)
2015-08-12 15:36:39 +02:00
Tim Kuipers
c3f474e229
Revert "refactor: pulled writePath out of GCodePlanner::writeGCode"
...
This commit introduced major bugs.
This reverts commit 125af2915f .
2015-08-12 15:19:23 +02:00
Tim Kuipers
125af2915f
refactor: pulled writePath out of GCodePlanner::writeGCode
2015-08-12 12:31:35 +02:00
Tim Kuipers
7b26d08d25
lil optimization: earlier travel path gcode generation
2015-08-12 12:20:44 +02:00
Tim Kuipers
a2b631b61b
bugfix: infill lines merger ignored travel path before it
2015-08-12 12:16:30 +02:00
Tim Kuipers
e3df22dab9
combing debug, bugfixes, enhancements
2015-08-12 11:27:53 +02:00
Tim Kuipers
7ad1b32ef3
feat: optimization: one less copy if inset is already computed
2015-08-11 17:21:48 +02:00
Tim Kuipers
98a7c65d66
bugfix: no return when GCodePlanner::makeRetractSwitchRetract reached end of all paths in gcode_layer
2015-08-11 16:15:38 +02:00
Tim Kuipers
b60ad09882
bugfix: combing crossed perimeters due to starting points being too close to a perimeter; they weren't moved inside the polygons
2015-08-11 13:43:38 +02:00
Tim Kuipers
0f35450440
undoing last lil refactor, was erroneous
2015-08-11 13:17:47 +02:00
Tim Kuipers
0adc1b44e7
lil refactor
2015-08-11 11:59:28 +02:00
Tim Kuipers
8d084e727a
bugfix: when skirt got doubled the second skirt line wasnt a convex hull
2015-08-11 11:25:15 +02:00
Tim Kuipers
916005b6ad
feat: better conical support; new settings: support_conical_min_width, support_conical_angle
2015-08-10 16:08:57 +02:00
Tim Kuipers
c7ecc23053
feat: disable xy-shifted gcode: machine_use_extruder_offset_to_offset_coords
2015-08-10 15:20:30 +02:00
Tim Kuipers
9d36987124
bugfix: disable wipe when printing prime tower with same nozzle (no nozzle switch)
2015-08-10 15:19:28 +02:00
Tim Kuipers
0fa3cab356
feature: support expansion offset
2015-08-10 14:09:53 +02:00
Tim Kuipers
31226c0b68
feat: no wipe when prime tower isn't after a nozzle switch
2015-08-10 12:08:40 +02:00
Tim Kuipers
ca23a77ad0
bugfix: MergeInfillLines caused infinite speed when lines were in each others extension
2015-08-10 11:52:57 +02:00
Tim Kuipers
b052cd431c
bugfix: nozzle switch retractions at wrong places and too many; bugfix: removed unnecessary swaps when seconf mesh is empty at a layer
2015-08-10 10:56:08 +02:00
Tim Kuipers
f00cb00f52
make last retraction of a nozzle a nozzle switch retraction
2015-08-07 16:59:41 +02:00
Tim Kuipers
f236969909
bugfixes: double prime tower during skirt; wrong support order; sliceDataStorage.meshes reallocation
2015-08-07 15:30:57 +02:00
Tim Kuipers
70dde36d85
bugfix: extruder train settings overrided general setting defaults; now they have their own category in the JSON file
2015-08-06 17:14:10 +02:00
Tim Kuipers
52f8a7500e
lil bugfixes: getting settings via mesh instead of general settings
2015-08-06 15:37:58 +02:00
Tim Kuipers
710138f487
different prime tower pattern
2015-08-06 15:36:32 +02:00
Tim Kuipers
f7e3682c35
multi extrusion skirt
2015-08-06 13:52:42 +02:00
Arjen Hiemstra
4fca97352d
Fix building on OSX since hash_fun.h does not exist there
...
The right header is std::hash is located in <functional>
2015-08-06 10:20:07 +02:00
Tim Kuipers
10773b688e
readme
2015-08-05 14:49:21 +02:00
Tim Kuipers
aae2aad42c
new command line arguments handling
2015-08-05 14:45:05 +02:00
Tim Kuipers
79d36d9a49
bugfix: retraction count max; feature: switch positions
2015-08-05 14:17:47 +02:00
Tim Kuipers
96d64b325a
gcodeExport: refactored all per extruder settings
2015-08-05 09:47:22 +02:00
Tim Kuipers
a316302314
refactor: wire print now retrieves settings from the meshgroup
2015-08-05 09:46:46 +02:00
Tim Kuipers
93b0aad9f0
extruder train defaults per extruder train in fdmPrinter.json
2015-08-04 16:44:46 +02:00
Tim Kuipers
1df22b3cab
bugfix: partsView declared as struct instead of class
2015-08-04 12:01:20 +02:00
Tim Kuipers
0a3da66539
bugfix: prime tower fixes maybe: insets
2015-07-31 17:41:59 +02:00
Tim Kuipers
45674d0b1c
enhancement: prime tower improvements
2015-07-31 17:37:09 +02:00
Tim Kuipers
834a778f93
refactor: moved prime tower to PrimeTower.h and .cpp
2015-07-31 17:02:24 +02:00
Tim Kuipers
160612f0dc
bugfix: setting inheritance structure is now fffProcessor>MeshGroup>ExtruderTrain>Mesh instead of fffProcessor>ExtruderTrain>MeshGroup>Mesh; feat: per object settings command line parsing, per meshgroup command line settings, per extruder train command line settings
2015-07-31 13:20:53 +02:00
Tim Kuipers
0cd463820f
SliceDataStorage is now a SettingsMessenger instead of a SettingsBase
2015-07-31 13:18:56 +02:00
Tim Kuipers
73f3995443
include all files in namespace cura and standardize spelling
2015-07-31 13:16:24 +02:00
Tim Kuipers
72762d9db5
SliceDataStorage is now a SettingsMessenger instead of a SettingsBase
2015-07-31 13:15:44 +02:00
Tim Kuipers
22cbeb7c0a
bugfix: virutal constructor of SettingsBaseVirtual
2015-07-31 13:14:50 +02:00
Tim Kuipers
819206afff
constructors of classes extending SettingsBase now get a SettingsBaseVirtual as argument for their parent
2015-07-31 13:14:08 +02:00
Tim Kuipers
9121c5440d
include all files in namespace cura and standardize spelling
2015-07-31 12:41:04 +02:00
Tim Kuipers
587121c58d
bugfix: incorrectly escaped % in printf
2015-07-31 12:40:07 +02:00
Tim Kuipers
5d5912f8c2
refactor: merged the two AABB classes and renamed one to AABB3D
2015-07-31 12:33:00 +02:00
Tim Kuipers
efd88d4c84
refactor: merged the two AABB classes and renamed one to AABB3D
2015-07-31 12:29:33 +02:00
Tim Kuipers
c994d830fa
removed empty ExtruderTrain.cpp
2015-07-31 12:26:32 +02:00
Tim Kuipers
186bdb50da
per object settings
2015-07-30 17:35:34 +02:00
Tim Kuipers
2b418030bb
split up main into slice() and connect() corresponding to CuraEngine slice [options] and CuraEngine connect [options]
2015-07-30 16:52:04 +02:00
Tim Kuipers
874465b450
more commandSocket clarity
2015-07-30 16:39:42 +02:00
Tim Kuipers
7089a2d72a
SettingsBase split up into SettingsBaseVirtual, SettingsBase and SettingsMessenger, which only passes on settings from a parent
2015-07-30 16:37:38 +02:00
Tim Kuipers
3d7309bb3d
more commandSocket clarity
2015-07-30 16:36:55 +02:00
Tim Kuipers
2f355d1263
PrimeTower.h .cpp (forgotten files), ExtruderTrain.h .cpp
2015-07-30 15:04:13 +02:00
Tim Kuipers
478c667655
different command line calls: CuraEngine slice [options] -l file OR CuraEngine connect
2015-07-30 15:03:21 +02:00
Tim Kuipers
0d07f3b9b0
temp fix: instead of sometimes reporting negative print times, always reeport a print time of 10
2015-07-30 15:01:30 +02:00
Tim Kuipers
d7d3fd47f7
refactor: PrintObject => MeshGroup
2015-07-30 11:47:53 +02:00
Tim Kuipers
244a90e4eb
refactoring: getting clarity on PrintObject vs Mesh
2015-07-30 11:41:45 +02:00
Tim Kuipers
ec5680e2ea
halfway refactoring prime tower into its own file
2015-07-30 10:44:52 +02:00
Tim Kuipers
f9e562e020
removed unnecessary swaps when usign a prime tower
2015-07-30 09:29:09 +02:00
Tim Kuipers
e7379efaf3
lil bugfix: support max height etc; note that unnecessary swaps don't occur anymore, but wipe tower is not added
2015-07-29 16:42:33 +02:00
Tim Kuipers
576d90806d
feat: prime_tower_wipe_enabled, refactored all wipe_tower to prime_tower
2015-07-29 16:14:25 +02:00
Tim Kuipers
dcedf97493
bugfix: max wipe tower height when using support roofs
2015-07-29 16:09:57 +02:00
Tim Kuipers
76af340433
bugfixes for support_roof_extruder_nr
2015-07-29 15:41:37 +02:00
Tim Kuipers
24fdcd0355
support_roof_extruder_nr
2015-07-29 14:38:58 +02:00
Tim Kuipers
3f6f35bd95
support_roof_extruder_nr
2015-07-29 14:35:15 +02:00
Tim Kuipers
b41288c63d
adhesion_extruder_nr
2015-07-29 13:13:18 +02:00
Tim Kuipers
75b13046cf
lil changes
2015-07-29 12:20:57 +02:00
Tim Kuipers
2433c8521e
logWarning
2015-07-29 12:20:14 +02:00
Tim Kuipers
613e65ecba
machine_extruder_count
2015-07-28 15:19:55 +02:00
Tim Kuipers
6a7d9a7c18
machine_extruder_count
2015-07-28 15:18:28 +02:00
Tim Kuipers
6e52f81840
combine infill lines finally bugfixed!
2015-07-28 13:29:13 +02:00
Tim Kuipers
7984932307
bugfix: skirt includes support roofs
2015-07-27 16:18:30 +02:00
Tim Kuipers
871fdc3a01
different wipe tower position, closer to far right corner for UM2
2015-07-27 16:17:52 +02:00
Tim Kuipers
807e734fa4
bugfix: wipe_tower inverse order on first layer
2015-07-27 13:04:30 +02:00
Tim Kuipers
b59ebe074d
Update README.md
2015-07-27 11:11:59 +02:00
Tim Kuipers
81a3b14999
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-24 17:17:18 +02:00
Tim Kuipers
a1a3c079bb
settings wipe_tower_dir_outward ::bool
2015-07-24 17:14:14 +02:00
Tim Kuipers
33d5c91227
reverse the print order of the wipe tower skirt to inward
2015-07-24 16:55:28 +02:00
Arjen Hiemstra
d43774c664
Merge branch '15.06'
...
* 15.06: (21 commits)
bugfix: empty arcus messages
bugfix & feature: insets support smaller outer wall line width
Statically link libstdc++ on Linux to prevent issues with newer libstc++
bugfixes for raft problems: unregistered settings, printZ computed doubly, printZ didn't account for difference in initial slice Z and print Z, initial layer height should be appleid when using raft, wrong (negative) layer comments
bugfix: extrusion per mm to extrusion mm3 per mm is_volumetric set
bugfix: speed compensation for stable feedrate also changed the extrusion per mm
bugfix: speed compensation for stable feedrate also changed the extrusion per mm
bugfix+refactor: extrusion always per mm3
bugfix: no support for too low models
bugfix: no support for too low models
Also send infill polygon data to the UI, not just oultines
Also send line width to the UI along with the polygon's points
Add support for sending layer height and thickness to the UI
Properly reset the extrusion amount between slicing tasks.
Properly initialize extrusion_volume_per_mm variable
bugfix: reset filament at new print
Add missing <string> include so we can build on MacOSX
Install the created executable
bugfix gcode.writeMove(x,y,z) where z didn't get processed. = bug for wireprinting
Fix support generation by making sure "True" is also recognised as true
...
2015-07-24 12:44:00 +02:00
Tim Kuipers
6feb5bbe8c
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-24 12:02:31 +02:00
Tim Kuipers
ed15bdcc25
bugfixes: progress
2015-07-24 12:01:37 +02:00
Jaime van Kessel
95bbf211ba
progress now takes multiple objects for once at a time into account
2015-07-24 11:50:08 +02:00
Jaime van Kessel
bb2138b060
bit of refactoring in slices2polygons
2015-07-24 10:55:40 +02:00
Jaime van Kessel
debe1c5129
Renamed namespace of protobuff from Cura to cura::proto
2015-07-24 10:06:13 +02:00
Jaime van Kessel
157f0c37f8
fixed one at a time
2015-07-24 09:25:56 +02:00
Jaime van Kessel
cac5ee612c
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-24 09:05:48 +02:00
Tim Kuipers
a931f2f964
bugfix: no more automatic mesh centering (repositioning); now an option: center_object
2015-07-23 18:06:53 +02:00
Tim Kuipers
6450379a1c
feature: conical support half implemented
2015-07-23 16:25:24 +02:00
Tim Kuipers
24ece43700
feature: support_extruder_nr_layer_0
2015-07-23 16:19:02 +02:00
Jaime van Kessel
ff59738246
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-23 10:19:42 +02:00
Jaime van Kessel
b3de3b7643
Changes to make one at a time work (WIP)
2015-07-23 10:19:23 +02:00
Tim Kuipers
1523350501
UM2 gcode now accepts start gcode (though setting default should be empty)
2015-07-23 10:13:58 +02:00
Tim Kuipers
1a5fd99d7e
better starting and ending gcode for wireframe
2015-07-23 09:15:54 +02:00
Tim Kuipers
55ee8f687b
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-22 16:17:16 +02:00
Tim Kuipers
265adb1a5d
bugfix/enhancement: better combine infill lines
2015-07-22 16:17:02 +02:00
Jaime van Kessel
235c561bb5
Renamed modelfile to correct name
2015-07-22 15:49:54 +02:00
Tim Kuipers
1753bd566e
merge
2015-07-22 15:36:09 +02:00
Jaime van Kessel
5e8c73a0a2
Moar naming
2015-07-22 15:21:44 +02:00
Jaime van Kessel
5752b358f2
More refactoring
2015-07-22 13:47:16 +02:00
Jaime van Kessel
10d4785659
refactoring
2015-07-22 13:34:24 +02:00
Jaime van Kessel
9beaee7161
Added more documentation
2015-07-22 13:31:02 +02:00
Jaime van Kessel
c79e052c17
Refactoring so code adheres to codestyle
2015-07-22 13:18:18 +02:00
Tim Kuipers
5b88fda464
bugfix: removed zigzaggifying infill lines
2015-07-22 12:11:23 +02:00
Tim Kuipers
52cd83bac3
bugfixes: combine infill lines
2015-07-22 12:06:18 +02:00
Tim Kuipers
a47adb2114
bugfix: support overlapped with model by half the line width
2015-07-22 10:08:34 +02:00
Tim Kuipers
e0001ffa5b
enhancement: less copies in polygons.removeDegenerateVerts
2015-07-22 09:31:06 +02:00
Tim Kuipers
58734899d7
enhancement: less copies in polygons.removeDegenerateVerts
2015-07-21 17:24:41 +02:00
Tim Kuipers
60b0f43838
bugfix/feature enhance: better combine infill lines into single line
2015-07-21 16:25:53 +02:00
Tim Kuipers
4bed0e3ad1
bugfix: draft shield disabled skirt; bugfix: infill config was retrieved globally instead of local to the mesh
2015-07-21 13:34:22 +02:00
Tim Kuipers
0e27cbfd4f
lil draft shield improvement: more skip_layers
2015-07-20 14:59:32 +02:00
Tim Kuipers
94c29cf0af
Merge pull request #222 from electrocbd/bugfix2
...
Infinite loop in cura::FffPolygonGenerator::processDraftShield
2015-07-20 14:58:09 +02:00
Tim Kuipers
7d1d60b422
bugfix: remove degenerate verts: verts connected to overlapping line segments
2015-07-20 14:37:21 +02:00
Christophe Baribaud
7fca86e27a
Keep compatibility with 0.2mm layer height
2015-07-20 14:34:52 +02:00
Christophe Baribaud
faeaf2816f
Infinite loop in cura::FffPolygonGenerator::processDraftShield
2015-07-20 14:15:18 +02:00
Tim Kuipers
9943279361
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-20 09:11:28 +02:00
Tim Kuipers
58b2d42596
Merge pull request #221 from electrocbd/bugfix1
...
bugfix: Polygons::splitIntoPartsView_processPolyTreeNode had reference to vector element which could change within the recursive call
2015-07-19 22:42:41 +02:00
Christophe Baribaud
c42df2e53e
Fix: Polygons::splitIntoPartsView_processPolyTreeNode used a pointer to a
...
vector which is reallocated, invalidating iterators and pointers
2015-07-19 15:21:06 +02:00
Tim Kuipers
3607a88f0a
bugfix: (again) speed and extrusion/mm for combined small moves: for moves smaller than nozzle width, speed should be higher and extrusoin/mm lower
2015-07-15 17:13:42 +02:00
Tim Kuipers
8625365cf0
changed fill_overlap dewfault down; new feature: infill_wipe_dist
2015-07-09 16:53:28 +02:00
Tim Kuipers
941354c740
feat: infill_wipe_dist
2015-07-09 16:48:28 +02:00
Tim Kuipers
13f5ebe9d7
bugfix: empty arcus messages
2015-07-09 14:08:29 +02:00
Tim Kuipers
9ba97a7cd7
reqrote some comments
2015-07-09 11:37:52 +02:00
Tim Kuipers
f9bf42f610
feature: draft protection screen
2015-07-08 17:02:30 +02:00
Tim Kuipers
ce4a375780
disabled skirt when draft shield is on
2015-07-08 15:55:32 +02:00
Tim Kuipers
f0675c88df
feature: draft protection screen
2015-07-08 15:20:20 +02:00
Tim Kuipers
db787c7cab
Merge branch '15.06' of https://github.com/Ultimaker/CuraEngine into 15.06
2015-07-08 13:15:47 +02:00
Tim Kuipers
21a04beb25
bugfix & feature: insets support smaller outer wall line width
2015-07-08 13:15:35 +02:00
Tim Kuipers
0d0dd7292a
bugfix & feature: insets support smaller outer wall line width
2015-07-08 13:00:47 +02:00
Tim Kuipers
735f50875e
bugfix overlap ocmpensation: removed debug output code
2015-07-07 16:58:28 +02:00
Tim Kuipers
f0fd1a654e
bugfix for wall overlap compensation (unknown bug origin, but seems fixed by keeping endings separate from normal overlap points). CONTAINS DEBUG output code.
2015-07-07 16:52:35 +02:00
Arjen Hiemstra
1565e979ec
Statically link libstdc++ on Linux to prevent issues with newer libstc++
...
Contributes to Ultimaker/Uranium#42
2015-07-07 12:14:24 +02:00
Tim Kuipers
82532a3ddf
fix lil
2015-07-03 14:22:39 +02:00
Tim Kuipers
7075ca34d4
bugfixes for raft problems: unregistered settings, printZ computed doubly, printZ didn't account for difference in initial slice Z and print Z, initial layer height should be appleid when using raft, wrong (negative) layer comments
2015-07-03 13:23:23 +02:00
Tim Kuipers
927395630b
bugfixes for raft problems: unregistered settings, printZ computed doubly, printZ didn't account for difference in initial slice Z and print Z, initial layer height should be appleid when using raft, wrong (negative) layer comments
2015-07-02 16:13:32 +02:00
Tim Kuipers
8c9625f578
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-07-01 17:19:26 +02:00
Tim Kuipers
7c4064aa5f
travel_compensate_overlapping_walls_enabled fixed
2015-07-01 17:19:16 +02:00
Tim Kuipers
6d82284545
Update README.md
2015-07-01 10:34:23 +02:00
Tim Kuipers
fe512222e5
bugfix: extrusion per mm to extrusion mm3 per mm is_volumetric set
2015-06-30 17:20:02 +02:00
Tim Kuipers
a18cfd9af1
halfway bugfix+refactor: extrusion per mm to extrusion mm3 per mm
2015-06-30 16:16:02 +02:00
Tim Kuipers
7469a48449
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-06-30 15:38:55 +02:00
Tim Kuipers
9c8bac7a99
halfway bugfix+refactor: extrusion per mm to extrusion mm3 per mm
2015-06-30 15:38:53 +02:00
Tim Kuipers
9baaa93159
bugfix: speed compensation for stable feedrate also changed the extrusion per mm
2015-06-30 14:47:40 +02:00
Tim Kuipers
9b92c42947
bugfix: speed compensation for stable feedrate also changed the extrusion per mm
2015-06-30 14:46:26 +02:00
Tim Kuipers
0a77aaa385
overlap compensation
2015-06-30 09:31:57 +02:00
Roy Spliet
a54e70e48f
CMake: Add packaging definition
...
Signed-off-by: Roy Spliet <r.spliet@ultimaker.com >
2015-06-26 13:57:19 +02:00
daid
d3e41f3ce2
Add missing rapidjson license.
2015-06-26 11:13:47 +02:00
Tim Kuipers
a9b4aa7640
bugfix: no more removal of last point (caused by overwriting each point by the last)
2015-06-24 17:15:26 +02:00
Tim Kuipers
95ff26940e
bugfix: disabled overlap compensation due to temporary bug
2015-06-24 16:33:54 +02:00
Tim Kuipers
e5f87bcbc7
bugfixes: hasSetting removed due to new setting system introduced months ago, mesh positioning bugfix
2015-06-24 16:22:30 +02:00
Tim Kuipers
210636e205
lil
2015-06-24 15:32:27 +02:00
Tim Kuipers
028c8c6e42
no more debug out bs
2015-06-24 15:00:25 +02:00
Tim Kuipers
73f5691651
bugfix: nozzle offset
2015-06-24 15:00:09 +02:00
Tim Kuipers
ddc2c1e574
dgf
2015-06-24 14:27:26 +02:00
Tim Kuipers
fcbcf380ae
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-06-24 13:14:25 +02:00
Tim Kuipers
eccda61b55
bugfix: machine_extruder_offset >> machine_nozzle_offset
2015-06-24 13:14:15 +02:00
Tim Kuipers
0f8b52d1a0
overlap compensation halfway
2015-06-24 13:12:17 +02:00
Tim Kuipers
35373a5b1a
overlap compensation half way : location based
2015-06-23 13:45:38 +02:00
Tim Kuipers
094d0e84a2
bugfix: no support for too low models
2015-06-23 10:11:09 +02:00
Tim Kuipers
a5beedf4f6
bugfix: no support for too low models
2015-06-23 10:07:47 +02:00
Tim Kuipers
a77f0bf728
first wall overlap compensation approximation (links a point to multiple overlaps to account for threeway overlaps)
2015-06-22 12:22:28 +02:00
Ghostkeeper
8a75b638b7
Restore documentation output directory
...
The output directory had to be changed back to docs for the automatic
generation of documentation.
2015-06-19 10:24:24 +02:00
Ghostkeeper
0815a834d8
Emptied the documentation output directory
...
This output directory needs to be empty in order to automatically
publish the documentation.
2015-06-18 16:12:19 +02:00
Tim Kuipers
93c9864f17
split remove_overlapping_perimeters into outer and other
2015-06-18 13:25:05 +02:00
Tim Kuipers
2444667a70
lil
2015-06-18 10:06:48 +02:00
Tim Kuipers
0ec956c653
enhanced support roof direction
2015-06-17 15:03:28 +02:00
Tim Kuipers
ccd1c44315
stop wipe tower after last neccesary switch (+bugfixes)
2015-06-17 14:56:00 +02:00
Tim Kuipers
bed85c7e68
stop wipe tower after last neccesary switch
2015-06-16 17:26:54 +02:00
Tim Kuipers
4e40b2bc09
support roof lil stuff
2015-06-16 14:42:27 +02:00
Tim Kuipers
6fbe9c7de8
bugfix: setting typo
2015-06-16 12:36:35 +02:00
Tim Kuipers
5b70a57700
documenting AABB
2015-06-16 12:11:33 +02:00
Tim Kuipers
1ce42b6b93
lil
2015-06-16 12:07:20 +02:00
Tim Kuipers
e5b79ea847
lil
2015-06-16 12:06:58 +02:00
Tim Kuipers
70168cde07
introduced AABB (axis aligned bounding box) and cura'd a related bug
2015-06-16 12:04:34 +02:00
Tim Kuipers
7dad3d5018
different command line execution example
2015-06-16 11:25:02 +02:00
Tim Kuipers
87fbaf51f9
different command line execution example
2015-06-16 11:23:10 +02:00
Tim Kuipers
5cf401cde7
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-06-16 11:18:31 +02:00
Tim Kuipers
136aea0c15
support roof settings
2015-06-16 11:18:18 +02:00
Tim Kuipers
8e43531e10
more lenient settings handling so that you can load multiple json files after eachother
2015-06-16 11:16:36 +02:00
Ghostkeeper
7ac77ba24b
Readme correction: There is an external dependency
...
The external dependency is libArcus. A reference to libArcus is added in
the place where it said there are no external dependencies.
2015-06-12 13:45:25 +02:00
Tim Kuipers
1406c8f2ea
magic_polygon mode => magic_mesh_surface_mode
2015-06-11 14:32:55 +02:00
Tim Kuipers
c0715fd490
first approximation support roofs
2015-06-11 13:57:23 +02:00
Tim Kuipers
267e0b1fa9
LARGE REFACTOR: all variables which eventually get values from double settings have been changed from int to double
2015-06-10 11:19:37 +02:00
Tim Kuipers
dcf56c5a8e
new feature: alternate skin rotation (45 degrees for every two pairs of layers
2015-06-09 17:24:47 +02:00
Tim Kuipers
bf23ca38ba
bugfix: support line width, Fixes daid/Cura#1274
2015-06-09 14:58:05 +02:00
Tim Kuipers
b851be6a06
progress takes care of timeKeeper
2015-06-09 14:31:46 +02:00
Tim Kuipers
84b3176ac3
progress docs and sendProgressStage
2015-06-09 13:41:33 +02:00
Tim Kuipers
b9f8325534
better progress calculation
2015-06-09 13:09:30 +02:00
Tim Kuipers
9fa902ad6d
license correction
2015-06-09 13:09:12 +02:00
Tim Kuipers
68888fc0b7
license correction
2015-06-09 13:07:41 +02:00
Tim Kuipers
136e199225
lil
2015-06-09 13:06:43 +02:00
Tim Kuipers
295e51309f
bugfix: incorrect model translation upward
2015-06-08 16:57:54 +02:00
Tim Kuipers
5f09352a24
bugfix: retract on very first move, causing the head to move to an impossible position
2015-06-08 15:24:35 +02:00
Tim Kuipers
94faff843f
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-06-08 13:33:53 +02:00
Tim Kuipers
2efce629f7
coasting finished + settings
2015-06-08 13:24:09 +02:00
Tim Kuipers
6964c7122b
removed move_inside_comb_boundary, since that is already dont by the combing
2015-06-08 10:04:42 +02:00
Tim Kuipers
6b97779ac8
Update README.md
2015-06-08 09:23:50 +02:00
Tim Kuipers
5d9c64a140
differentiate between move-coasting and retract-coasting
2015-06-05 12:41:19 +02:00
Tim Kuipers
5ca046fec2
differentiate between move-coasting and retract-coasting
2015-06-05 12:40:31 +02:00
Tim Kuipers
5657577938
moved coasting to gcodePlanner.writeGcode() and introduced coasting priming
2015-06-05 12:14:42 +02:00
Tim Kuipers
224fec0b79
first coasting code part and gcodeLayer.writeGcode refactors
2015-06-03 15:44:36 +02:00
Tim Kuipers
ae2b67ef69
lil
2015-06-03 13:05:38 +02:00
Tim Kuipers
3b8ad5e55c
added setting travel_avoid_other_parts
2015-06-03 13:04:00 +02:00
Tim Kuipers
abd2c586db
moved fdmPrinter.json to the frontend (merged)
2015-06-02 17:09:35 +02:00
Tim Kuipers
0a8b508b4c
lil
2015-06-02 11:45:30 +02:00
Tim Kuipers
df97f36315
better retraction handling
2015-06-02 11:43:10 +02:00
Tim Kuipers
cc3ce8ae6b
add setting travel_avoid_distance
2015-06-02 11:32:29 +02:00
Tim Kuipers
ba2f47aa67
Merge branch 'masterhou-master-hyt'
2015-06-01 17:10:37 +02:00
Tim Kuipers
e516682744
corrected wrong initialization in polygon.cpp
2015-06-01 16:07:25 +02:00
Tim Kuipers
f43f4285a8
Merge branch 'master-hyt' of https://github.com/masterhou/CuraEngine into masterhou-master-hyt
2015-06-01 15:59:15 +02:00
Tim Kuipers
99c756aa90
lil
2015-06-01 14:15:45 +02:00
Tim Kuipers
a8a2d69a5f
better comb inside offset, don't use comb path when zhop is used.
2015-06-01 12:32:45 +02:00
Tim Kuipers
f7ac889bb4
more retractions between support (but not always)
2015-06-01 11:26:05 +02:00
Tim Kuipers
a326e73e4a
cleaning up combing, explanations, comments
2015-06-01 11:23:49 +02:00
Thomas Hou
2796103a2b
some optimization
...
1.load stl
2.use std::unordered_map instead of std::map
3.slicer, polygon close, find face by segment idx.
4.insert <k,v> fater than [k]=v;
2015-05-29 16:39:16 +08:00
Tim Kuipers
14c4ac55f1
Merge branch 'combingOverhaul'
2015-05-28 16:02:55 +02:00
Tim Kuipers
831b9d94f8
combing cleanup etc
2015-05-28 15:59:55 +02:00
Tim Kuipers
5fa793ece7
lil
2015-05-28 14:20:55 +02:00
Tim Kuipers
4065e6f7e8
refactor combing: no more force retraction, no more boundary with extra offset
2015-05-28 14:13:05 +02:00
Tim Kuipers
7ff00dfbb0
combing seems to be working
2015-05-26 17:04:26 +02:00
Tim Kuipers
84909e2e77
Merge pull request #211 from foosel/fix/usage_summary
...
Usage summary should match actual usage
2015-05-26 15:25:28 +02:00
Gina Häußge
9d75cdf0f7
Usage summary should match actual usage
...
Removed obsolete `-m` and `-c` and added missing
`--connect`, `-j` and `-p`.
2015-05-26 15:00:06 +02:00
Tim Kuipers
c0c842649f
lil commit
2015-05-26 12:26:42 +02:00
Tim Kuipers
e8d117d62f
UltiGCode starting gcode fallback option when not using command sockets
2015-05-26 11:50:24 +02:00
Tim Kuipers
87ae0dc870
bugfix for boundary point with offset for outside combing
2015-05-26 11:44:27 +02:00
Tim Kuipers
e26ee1a113
debugging, testing
2015-05-26 11:12:08 +02:00
Tim Kuipers
9d31a525c9
UltiGCode starting gcode fallback option when not using command sockets
2015-05-26 10:56:26 +02:00
Tim Kuipers
ffb08f9f8d
more cdombing overhaul (debug state)
2015-05-26 10:46:23 +02:00
Tim Kuipers
294dec007a
Merge pull request #210 from osbornm/patch-1
...
Update README to display build steps as list
2015-05-26 10:32:01 +02:00
Matthew Osborn
93a19422e8
Update README to display build steps as list
...
This way the steps show up as a list and stand out so it's easier to see.
2015-05-25 22:37:26 -07:00
Tim Kuipers
c44adab86d
combing cleanup
2015-05-19 12:31:39 +02:00
Tim Kuipers
7bb5cbe98e
first combing overhaul commit which seems to work
2015-05-19 10:52:04 +02:00
Tim Kuipers
0b0db9f864
comb boundary = whole layer
2015-05-18 13:33:03 +02:00
Arjen Hiemstra
64ddaf2ff5
Fix support generation by making sure "True" is also recognised as true
2015-05-18 11:11:59 +02:00
Tim Kuipers
a901e88aaa
bugfix gcode.writeMove(x,y,z) where z didn't get processed. = bug for wireprinting
2015-05-18 10:32:39 +02:00
Tim Kuipers
fe03259704
more refactoring
2015-05-18 09:25:01 +02:00
Tim Kuipers
cf209a157b
first working comb
2015-05-15 13:30:43 +02:00
Tim Kuipers
0f547ae354
test cleanup
2015-05-15 13:30:19 +02:00
Tim Kuipers
2ebfbe837d
includes cleanup
2015-05-15 13:29:58 +02:00
Tim Kuipers
af87a00eaa
bugfixes splitIntoPartsView
2015-05-15 13:27:28 +02:00
Tim Kuipers
09543636c7
more combing refactor
2015-05-13 17:08:09 +02:00
Tim Kuipers
f5a56a5048
some new polygon functionality and linear algebra
2015-05-13 17:07:54 +02:00
Tim Kuipers
16185bd88c
more combing refactor
2015-05-13 09:18:36 +02:00
Tim Kuipers
47479a9fd5
further combing refactoring
2015-05-12 17:24:49 +02:00
Tim Kuipers
fce31b0c32
Merge branch 'master' into combingOverhaul
2015-05-12 15:29:03 +02:00
Tim Kuipers
d44c68a28b
further crystallized addMeshLayerToGcode
2015-05-12 15:18:21 +02:00
Tim Kuipers
5f793943f2
small refactor
2015-05-12 13:04:09 +02:00
Tim Kuipers
3d81f84c0f
totally broke apart the writeGcode function
2015-05-12 12:48:10 +02:00
Tim Kuipers
9f59447a81
fff classes extend settingbase again, instead of having a settings field
2015-05-12 11:39:12 +02:00
Tim Kuipers
67c9b3dd23
totally broke apart what was formerly known as fffProcessor::prepareModel(.)
2015-05-11 14:50:46 +02:00
Tim Kuipers
f1028b55a2
refactored and commented FffPolygonGenerator
2015-05-11 14:20:35 +02:00
Tim Kuipers
4cb11122dc
renamed FffAreagenerator to FffPolygonGenerator
2015-05-11 14:01:34 +02:00
Tim Kuipers
58438bf56e
renamed FffAreagenerator to FffPolygonGenerator
2015-05-11 13:59:44 +02:00
Tim Kuipers
e93ba3d37f
refactored some FffAreaGenerator functionality
2015-05-11 13:54:37 +02:00
Tim Kuipers
9566e60037
imports cleanup
2015-05-11 13:39:34 +02:00
Tim Kuipers
b0b06635ac
split off FffAreaGenerator from fffProcessor
2015-05-11 13:36:50 +02:00
Tim Kuipers
6dfacb7d2c
rename GcodeWriter to FffGcodeWriter
2015-05-11 13:07:29 +02:00
Tim Kuipers
f1774665df
moved writeGcode to cpp file
2015-05-11 12:27:15 +02:00
Tim Kuipers
45c8439446
cleaned up some imports
2015-05-11 12:13:53 +02:00
Tim Kuipers
1d0fded682
split fffProcessor into fffProcessor and GcodeWriter
2015-05-11 12:03:07 +02:00
Tim Kuipers
31a81c5476
forgotten polygon.cpp
2015-05-11 09:27:52 +02:00
Tim Kuipers
229d3b1a2f
halfway refactoring combing
2015-05-11 09:21:01 +02:00
Tim Kuipers
796ced3508
Merge branch 'master' of https://github.com/Ultimaker/CuraEngine
2015-05-07 11:28:36 +02:00
daid
c91137cc03
Merge branch '15.06'
2015-05-06 09:24:24 +02:00
Tim Kuipers
d061420750
improved Comb::move inside
2015-05-04 17:23:03 +02:00
Tim Kuipers
50ef87d41f
combing debug
2015-05-04 16:39:39 +02:00
Tim Kuipers
c4952dd28f
removed 'using default' msg
2015-05-04 16:39:22 +02:00
Tim Kuipers
6c5c5c2e34
removed comment
2015-05-04 16:38:24 +02:00
Tim Kuipers
1520e010e7
removed unneccesary import
2015-05-04 16:38:04 +02:00
Tim Kuipers
30bd8b5c67
support everywhere as default
2015-05-04 11:00:54 +02:00
Tim Kuipers
8cc54c60de
refactored combing: one combing path per boundary polygon, needs more cleaning up and testing
2015-05-01 16:20:18 +02:00
Tim Kuipers
a4a5e22b50
refactored combing more
2015-05-01 15:12:49 +02:00
Tim Kuipers
4529585acb
made outlines into PolygonPart
2015-05-01 11:56:14 +02:00
Tim Kuipers
d1bc5f8002
moved multiVolumeOverlap code from processSliceData to prepareModel, cause it should be done before layer parts are generated
2015-05-01 11:47:37 +02:00
Tim Kuipers
ab68ee508e
removed remove-first-empty-layers code which was old and at the wrong place
2015-05-01 11:21:36 +02:00
Tim Kuipers
db7eb35e34
introduced a new class to signify that a Polygons object is a single area: PolygonsPart
2015-05-01 10:34:32 +02:00
Tim Kuipers
216ab79521
bit more explanation findSmallestConnection
2015-05-01 09:48:48 +02:00
Tim Kuipers
2a74c39642
removed slow findSmallestConnection
2015-05-01 09:45:37 +02:00
Tim Kuipers
eeaa53c118
lil comments
2015-05-01 09:43:11 +02:00
Tim Kuipers
effff44843
commenting and refactoring comb.h &.cpp
2015-04-30 17:12:34 +02:00
Tim Kuipers
99ea16e251
refactoring and commenting and correcting grammar ((TM) grammar nazi)
2015-04-30 14:54:19 +02:00
Tim Kuipers
574a89ad93
refactoring and commenting combing
2015-04-30 12:34:40 +02:00
TotalRetribution
7d928703a5
Changed option name enableReverseInsetOrder to outerInsetFirst to better explain its function.
2015-04-07 09:59:55 +01:00
TotalRetribution
8961df4342
Add option to Reverse Inset Print Order
2015-03-27 13:36:16 +00:00