parallel makes

Add a new config param, Server.FileSocket. When
Server.FileSocket
is set it will be used inplace of a network socket for the primary
server. This uses a new parameter to ServerOptions, m_useFileSocket,
to toggle between treating the address as a socket path or a network
address.

To initialize a socket connection thrift expects the socket file to not
exist. To support this the 'something nice' retry in startServer will
unlink an existing socket only if fuser claims it is unused.
Server.EvilShutdown enables unlinking the socket regardless of current
users.

Closes #1594

Reviewed By: @ptarjan

Differential Revision: D1135876

Pulled By: @sgolemon

.gitignore

@@ -1,10 +1,5 @@
 *.[oad]
 *.hhbc
-/bin*-g
-/bin*-O
-/bin/*.so
-/bin/hphp_options
-/bin/systemlib.php
 .mkdir
 hphp.log
 
@@ -31,31 +26,33 @@ hphp.log
 /hphp/runtime/tmp/run
 /hphp/runtime/tmp/run.sh
 /hphp/runtime/tmp/libtest.so
-/hphp/runtime/vm/repo_schema.h
-
-/hphp/hphpi/gen
-/hphp/hphpi/hphpi
+/hphp/hphp-build-info.cpp
+/hphp/hphp-repo-schema.h
 
 /hphp/hhvm/gen
 /hphp/hhvm/hhvm
 
+*.ext_hhvm.cpp
+*.ext_hhvm.h
+/hphp/runtime/ext_hhvm/ext_hhvm_infotabs.cpp
+/hphp/runtime/ext_hhvm/ext_hhvm_infotabs.h
+
 /hphp/tools/shmw/shmw
 
 /hphp/ffi/java/classes
 /hphp/ffi/java/hphp_ffi_java.h
 
-# Ignore all makefiles generated for fbcode's third-party repo
-/bin/*.mk
-!/bin/run.mk
-
 CMakeFiles
 CMakeCache.txt
 cmake_install.cmake
+install_manifest.txt
 
 /output_gd/
 
 /hphp/TAGS
 
+/hphp/third_party/libzip/libzip.dylib
+
 # Generated makefiles
 /hphp/runtime/ext_hhvm/Makefile
 /hphp/test/Makefile

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "hphp/submodules/folly"]
+	path = hphp/submodules/folly
+	url = git://github.com/facebook/folly.git

.travis.yml

@@ -0,0 +1,48 @@
+language: cpp
+
+compiler:
+  - gcc
+
+before_script:
+  - time TRAVIS=1 ./configure_ubuntu_12.04.sh
+# for some tests
+  - time sudo locale-gen de_DE && sudo locale-gen zh_CN.utf8 && sudo locale-gen fr_FR
+  - time HPHP_HOME=`pwd` make -j 6
+  - cd hphp/test/zend/good/ext/curl/tests/responder && ../../../../../../../hhvm/hhvm -m server -p 8444 &
+# mysql configuration for unit-tests
+  - mysql -e 'CREATE DATABASE IF NOT EXISTS hhvm;'
+  - export PDO_MYSQL_TEST_DSN="mysql:host=127.0.0.1;dbname=hhvm"
+  - export PDO_MYSQL_TEST_USER="travis"
+  - export PDO_MYSQL_TEST_PASS=""
+
+# The larger test suites (slow, zend) take longer than 50 miuntes to run. Since
+# we have no way to change the timeout, we subdivide the jit/interp repo/normal
+# matrix and then further split the large suites using an experimental cut
+# which divides the number of tests in each sub-run roughly in two.
+env:
+  - TEST_RUN_MODE="-m jit quick"
+  - TEST_RUN_MODE="-m jit slow -I /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m jit slow -E /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m jit zend -I /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+  - TEST_RUN_MODE="-m jit zend -E /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/'
+  - TEST_RUN_MODE="-m jit -r quick"
+  - TEST_RUN_MODE="-m jit -r slow -I /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m jit -r slow -E /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m jit -r zend -I /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+  - TEST_RUN_MODE="-m jit -r zend -E /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+  - TEST_RUN_MODE="-m interp quick"
+  - TEST_RUN_MODE="-m interp slow -I /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m interp slow -E /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m interp zend -I /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+  - TEST_RUN_MODE="-m interp zend -E /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+  - TEST_RUN_MODE="-m interp -r quick"
+  - TEST_RUN_MODE="-m interp -r slow -I /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m interp -r slow -E /^hphp\/test\/slow\/[a-df-nw-x].*/"
+  - TEST_RUN_MODE="-m interp -r zend -I /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+  - TEST_RUN_MODE="-m interp -r zend -E /^hphp\/test\/zend\/good\/(ext\/[a-ru-zA-Z0-9]|[Z]).*/"
+
+script: time PHP_CURL_HTTP_REMOTE_SERVER="http://localhost:8444" hphp/hhvm/hhvm hphp/test/run $TEST_RUN_MODE
+
+notifications:
+  email: false
+  irc: "chat.freenode.net#hhvm"

CMake/ExtZendCompat.cmake

@@ -0,0 +1,61 @@
+option(ENABLE_ZEND_COMPAT "Enable Zend source compatibility (beta)" OFF)
+
+set(ZEND_COMPAT_PROJECTS)
+set(ZEND_COMPAT_BUILD_DIRS)
+set(ZEND_COMPAT_EXCLUDE_IDLS)
+set(ZEND_COMPAT_LINK_LIBRARIES)
+
+# Look for projects
+set(EZC_DIR "${HPHP_HOME}/hphp/runtime/ext_zend_compat/")
+file(GLOB ezc_projects RELATIVE ${EZC_DIR} "${EZC_DIR}/*")
+foreach(ezc_project ${ezc_projects})
+	get_filename_component(ezc_name ${ezc_project} NAME)
+	if ((NOT ${ezc_name} STREQUAL "php-src") AND (IS_DIRECTORY "${EZC_DIR}/${ezc_name}"))
+		list(APPEND ZEND_COMPAT_PROJECTS ${ezc_name})
+	endif()
+endforeach()
+
+if (ENABLE_ZEND_COMPAT)
+	foreach(ezc_project ${ZEND_COMPAT_PROJECTS})
+		if (${ezc_project} STREQUAL "yaml")
+			find_package(LibYaml)
+			if (LibYaml_INCLUDE_DIRS)
+				list(APPEND ZEND_COMPAT_BUILD_DIRS "${EZC_DIR}/yaml")
+				include_directories(${LibYaml_INCLUDE_DIRS})
+				list(APPEND ZEND_COMPAT_LINK_LIBRARIES ${LibYaml_LIBRARIES})
+			else()
+				list(APPEND ZEND_COMPAT_EXCLUDE_IDLS "yaml.idl.json")
+			endif()
+		elseif (${ezc_project} STREQUAL "mongo")
+			include_directories("${EZC_DIR}/mongo/mcon")
+			list(APPEND ZEND_COMPAT_BUILD_DIRS "${EZC_DIR}/mongo")
+		else()
+			list(APPEND ZEND_COMPAT_BUILD_DIRS "${EZC_DIR}/${ezc_project}")
+		endif()
+	endforeach()
+
+	if (ZEND_COMPAT_BUILD_DIRS)
+		list(APPEND ZEND_COMPAT_BUILD_DIRS "${EZC_DIR}/php-src")
+		include_directories("${EZC_DIR}/php-src")
+		include_directories("${EZC_DIR}/php-src/main")
+		include_directories("${EZC_DIR}/php-src/Zend")
+		include_directories("${EZC_DIR}/php-src/TSRM")
+	endif()
+else()
+	foreach(ezc_project ${ZEND_COMPAT_PROJECTS})
+		list(APPEND ZEND_COMPAT_EXCLUDE_IDLS "${ezc_project}.idl.json")
+	endforeach()
+endif()
+
+# This is really ugly, but cmake's list(FIND)
+# doesn't entirely work the way it should
+macro(ZEND_COMPAT_STRIP_IDLS IDLS)
+	foreach(idl ${${IDLS}})
+		get_filename_component(idl_name ${idl} NAME)
+		foreach(f ${ARGV})
+			if (${idl_name} STREQUAL ${f})
+				list(REMOVE_ITEM ${IDLS} ${idl})
+			endif()
+		endforeach()
+	endforeach()
+endmacro()

CMake/FindEditline.cmake

@@ -0,0 +1,13 @@
+if (EDITLINE_LIBRARIES AND EDITLINE_INCLUDE_DIRS)
+  set (Editline_FIND_QUIETLY TRUE)
+endif (EDITLINE_LIBRARIES AND EDITLINE_INCLUDE_DIRS)
+
+find_path(EDITLINE_INCLUDE_DIRS NAMES editline/readline.h)
+find_library(EDITLINE_LIBRARIES NAMES edit)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(Editline DEFAULT_MSG
+    EDITLINE_LIBRARIES
+    EDITLINE_INCLUDE_DIRS)
+
+mark_as_advanced(EDITLINE_INCLUDE_DIRS EDITLINE_LIBRARIES)

CMake/FindFreetype.cmake

@@ -0,0 +1,16 @@
+
+find_package(PkgConfig)
+pkg_check_modules(PC_FREETYPE QUIET freetype2)
+
+find_path(FREETYPE_INCLUDE_DIRS NAMES freetype/config/ftheader.h
+          HINTS ${PC_FREETYPE_INCLUDEDIR} ${PC_FREETYPE_INCLUDE_DIRS}
+          PATH_SUFFIXES freetype2)
+
+find_library(FREETYPE_LIBRARIES NAMES freetype)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(Freetype DEFAULT_MSG
+    FREETYPE_LIBRARIES
+    FREETYPE_INCLUDE_DIRS)
+
+mark_as_advanced(FREETYPE_INCLUDE_DIRS FREETYPE_LIBRARIES)

CMake/FindGD.cmake

@@ -1,121 +0,0 @@
-# - Find GD
-# Find the native GD includes and library
-# This module defines
-#  GD_INCLUDE_DIR, where to find gd.h, etc.
-#  GD_LIBRARIES, the libraries needed to use GD.
-#  GD_FOUND, If false, do not try to use GD.
-# also defined, but not for general use are
-#  GD_LIBRARY, where to find the GD library.
-#  GD_SUPPORTS_PNG, GD_SUPPORTS_JPEG, GD_SUPPORTS_GIF, test
-#  support for image formats in GD.
-
-FIND_PATH(GD_INCLUDE_DIR gd.h
-/usr/local/include
-/usr/include
-)
-
-if(WIN32 AND NOT CYGWIN)
-  SET(GD_NAMES ${GD_NAMES} bgd)
-else(WIN32)
-  SET(GD_NAMES ${GD_NAMES} gd)
-endif(WIN32 AND NOT CYGWIN)
-
-FIND_LIBRARY(GD_LIBRARY
-  NAMES ${GD_NAMES}
-  PATHS /usr/lib64 /usr/lib /usr/local/lib
-  )
-
-IF (GD_LIBRARY AND GD_INCLUDE_DIR)
-    SET(GD_LIBRARIES ${GD_LIBRARY})
-    SET(GD_FOUND "YES")
-ELSE (GD_LIBRARY AND GD_INCLUDE_DIR)
-  SET(GD_FOUND "NO")
-ENDIF (GD_LIBRARY AND GD_INCLUDE_DIR)
-
-IF (GD_FOUND)
-	IF (WIN32 AND NOT CYGWIN)
-		SET(GD_SUPPORTS_PNG ON)
-		SET(GD_SUPPORTS_JPEG ON)
-		SET(GD_SUPPORTS_GIF ON)
-		get_filename_component(GD_LIBRARY_DIR ${GD_LIBRARY} PATH)
-	ELSE (WIN32 AND NOT CYGWIN)
-		INCLUDE(CheckLibraryExists)
-		GET_FILENAME_COMPONENT(GD_LIB_PATH ${GD_LIBRARY} PATH)
-		GET_FILENAME_COMPONENT(GD_LIB ${GD_LIBRARY} NAME)
-
-		CHECK_LIBRARY_EXISTS("${GD_LIBRARY}" "gdImagePng" "${GD_LIB_PATH}" GD_SUPPORTS_PNG)
-		IF (GD_SUPPORTS_PNG)
-			find_package(PNG)
-			IF (PNG_FOUND)
-				SET(GD_LIBRARIES ${GD_LIBRARIES} ${PNG_LIBRARIES})
-			SET(GD_INCLUDE_DIR ${GD_INCLUDE_DIR} ${PNG_INCLUDE_DIR})
-			ELSE (PNG_FOUND)
-				SET(GD_SUPPORTS_PNG "NO")
-			ENDIF (PNG_FOUND)
-		ENDIF (GD_SUPPORTS_PNG)
-
-		CHECK_LIBRARY_EXISTS("${GD_LIBRARY}" "gdImageJpeg" "${GD_LIB_PATH}" GD_SUPPORTS_JPEG)
-		IF (GD_SUPPORTS_JPEG)
-			find_package(JPEG)
-			IF (JPEG_FOUND)
-				SET(GD_LIBRARIES ${GD_LIBRARIES} ${JPEG_LIBRARIES})
-				SET(GD_INCLUDE_DIR ${GD_INCLUDE_DIR} ${JPEG_INCLUDE_DIR})
-			ELSE (JPEG_FOUND)
-				SET(GD_SUPPORTS_JPEG "NO")
-			ENDIF (JPEG_FOUND)
-		ENDIF (GD_SUPPORTS_JPEG)
-
-		CHECK_LIBRARY_EXISTS("${GD_LIBRARY}" "gdImageGif" "${GD_LIB_PATH}" GD_SUPPORTS_GIF)
-
-		# Trim the list of include directories
-		SET(GDINCTRIM)
-		FOREACH(GD_DIR ${GD_INCLUDE_DIR})
-			SET(GD_TMP_FOUND OFF)
-			FOREACH(GD_TRIMMED ${GDINCTRIM})
-				IF ("${GD_DIR}" STREQUAL "${GD_TRIMMED}")
-				SET(GD_TMP_FOUND ON)
-				ENDIF ("${GD_DIR}" STREQUAL "${GD_TRIMMED}")
-			ENDFOREACH(GD_TRIMMED ${GDINCTRIM})
-			IF (NOT GD_TMP_FOUND)
-				SET(GDINCTRIM "${GDINCTRIM}" "${GD_DIR}")
-			ENDIF (NOT GD_TMP_FOUND)
-		ENDFOREACH(GD_DIR ${GD_INCLUDE_DIR})
-		SET(GD_INCLUDE_DIR ${GDINCTRIM})
-
-		SET(GD_LIBRARY_DIR)
-
-		# Generate trimmed list of library directories and list of libraries
-		FOREACH(GD_LIB ${GD_LIBRARIES})
-			GET_FILENAME_COMPONENT(GD_NEXTLIBDIR ${GD_LIB} PATH)
-			SET(GD_TMP_FOUND OFF)
-			FOREACH(GD_LIBDIR ${GD_LIBRARY_DIR})
-				IF ("${GD_NEXTLIBDIR}" STREQUAL "${GD_LIBDIR}")
-					SET(GD_TMP_FOUND ON)
-				ENDIF ("${GD_NEXTLIBDIR}" STREQUAL "${GD_LIBDIR}")
-			ENDFOREACH(GD_LIBDIR ${GD_LIBRARIES})
-			IF (NOT GD_TMP_FOUND)
-				SET(GD_LIBRARY_DIR "${GD_LIBRARY_DIR}" "${GD_NEXTLIBDIR}")
-			ENDIF (NOT GD_TMP_FOUND)
-		ENDFOREACH(GD_LIB ${GD_LIBRARIES})
-	ENDIF (WIN32 AND NOT CYGWIN)
-ENDIF (GD_FOUND)
-
-IF (GD_FOUND)
-   IF (NOT GD_FIND_QUIETLY)
-      MESSAGE(STATUS "Found GD: ${GD_LIBRARY}")
-   ENDIF (NOT GD_FIND_QUIETLY)
-ELSE (GD_FOUND)
-   IF (GD_FIND_REQUIRED)
-      MESSAGE(FATAL_ERROR "Could not find GD library")
-   ENDIF (GD_FIND_REQUIRED)
-ENDIF (GD_FOUND)
-
-MARK_AS_ADVANCED(
-  GD_LIBRARY
-  GD_LIBRARIES
-  GD_INCLUDE_DIR
-  GD_LIBRARY_DIR
-  GD_SUPPORTS_PNG
-  GD_SUPPORTS_JPEG
-  GD_SUPPORTS_GIF
-)

CMake/FindICU.cmake

@@ -56,6 +56,20 @@ if(ICU_INCLUDE_DIR AND ICU_LIBRARY)
     set(ICU_I18N_FOUND 0)
     set(ICU_I18N_LIBRARIES)
   endif (ICU_I18N_LIBRARY)
+
+  # Look for the ICU data libraries
+  find_library(
+      ICU_DATA_LIBRARY
+    NAMES icudata cygicudata cygicudata32
+    DOC "Libraries to link against for ICU data")
+  mark_as_advanced(ICU_DATA_LIBRARY)
+  if (ICU_DATA_LIBRARY)
+    set(ICU_DATA_FOUND 1)
+    set(ICU_DATA_LIBRARIES ${ICU_DATA_LIBRARY})
+  else (ICU_DATA_LIBRARY)
+    set(ICU_DATA_FOUND 0)
+    set(ICU_DATA_LIBRARIES)
+  endif (ICU_DATA_LIBRARY)
 else(ICU_INCLUDE_DIR AND ICU_LIBRARY)
   set(ICU_FOUND 0)
   set(ICU_I18N_FOUND 0)

CMake/FindLibDL.cmake

@@ -0,0 +1,27 @@
+# - Try to find libdl
+# Once done this will define
+#
+#  LIBDL_FOUND - system has libdl
+#  LIBDL_INCLUDE_DIRS - the libdl include directory
+#  LIBDL_LIBRARIES - Link these to use libdl
+#  LIBDL_NEEDS_UNDERSCORE - If extern "C" symbols are prefixed (BSD/Apple)
+#
+
+find_path (LIBDL_INCLUDE_DIRS NAMES dlfcn.h)
+find_library (LIBDL_LIBRARIES NAMES dl)
+include (FindPackageHandleStandardArgs)
+
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibDL DEFAULT_MSG
+    LIBDL_LIBRARIES
+    LIBDL_INCLUDE_DIRS)
+
+SET(CMAKE_REQUIRED_LIBRARIES dl)
+INCLUDE(CheckCSourceRuns)
+CHECK_C_SOURCE_RUNS("#include <dlfcn.h>
+void testfunc() {}
+int main() {
+  testfunc();
+  return dyslm(0, \"_testfunc\") != (void*)0;
+}" LIBDL_NEEDS_UNDERSCORE)
+
+mark_as_advanced(LIBDL_INCLUDE_DIRS LIBDL_LIBRARIES LIBDL_NEEDS_UNDERSCORE)

CMake/FindLibDwarf.cmake

@@ -18,7 +18,7 @@ endif (LIBDWARF_LIBRARIES AND LIBDWARF_INCLUDE_DIRS)
 
 find_path (DWARF_INCLUDE_DIR
     NAMES
-      dwarf.h
+      libdwarf.h dwarf.h
     PATHS
       /usr/include
       /usr/include/libdwarf
@@ -50,5 +50,13 @@ FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibDwarf DEFAULT_MSG
     LIBDWARF_LIBRARIES
     LIBDWARF_INCLUDE_DIRS)
 
+if (LIBDWARF_LIBRARIES AND LIBDWARF_INCLUDE_DIRS)
+  set(CMAKE_REQUIRED_INCLUDES ${LIBDWARF_INCLUDE_DIRS})
+  set(CMAKE_REQUIRED_LIBRARIES ${LIBDWARF_LIBRARIES})
+  include(CheckSymbolExists)
+  CHECK_SYMBOL_EXISTS(dwarf_encode_leb128 "libdwarf.h" LIBDWARF_HAVE_ENCODE_LEB128)
+endif()
+
 mark_as_advanced(LIBDW_INCLUDE_DIR DWARF_INCLUDE_DIR)
 mark_as_advanced(LIBDWARF_INCLUDE_DIRS LIBDWARF_LIBRARIES)
+mark_as_advanced(LIBDWARF_HAVE_ENCODE_LEB128)

CMake/FindLibElf.cmake

@@ -51,5 +51,14 @@ FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibElf DEFAULT_MSG
     LIBELF_LIBRARIES
     LIBELF_INCLUDE_DIRS)
 
+SET(CMAKE_REQUIRED_LIBRARIES elf)
+INCLUDE(CheckCXXSourceCompiles)
+CHECK_CXX_SOURCE_COMPILES("#include <libelf.h>
+int main() {
+  Elf *e = (Elf*)0;
+  size_t sz;
+  elf_getshdrstrndx(e, &sz);
+  return 0;
+}" ELF_GETSHDRSTRNDX)
 
-mark_as_advanced(LIBELF_INCLUDE_DIRS LIBELF_LIBRARIES)
+mark_as_advanced(LIBELF_INCLUDE_DIRS LIBELF_LIBRARIES ELF_GETSHDRSTRNDX)

CMake/FindLibJpeg.cmake

@@ -0,0 +1,14 @@
+
+if (LIBJPEG_LIBRARIES AND LIBJPEG_INCLUDE_DIRS)
+  set (LibJpeg_FIND_QUIETLY TRUE)
+endif (LIBJPEG_LIBRARIES AND LIBJPEG_INCLUDE_DIRS)
+
+find_path(LIBJPEG_INCLUDE_DIRS NAMES jpeglib.h)
+find_library(LIBJPEG_LIBRARIES NAMES jpeg)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibJpeg DEFAULT_MSG
+    LIBJPEG_LIBRARIES
+    LIBJPEG_INCLUDE_DIRS)
+
+mark_as_advanced(LIBJPEG_INCLUDE_DIRS LIBJPEG_LIBRARIES)

CMake/FindLibNuma.cmake

@@ -0,0 +1,13 @@
+if (LIBNUMA_LIBRARIES AND LIBNUMA_INCLUDE_DIRS)
+  set (LibNuma_FIND_QUIETLY TRUE)
+endif (LIBNUMA_LIBRARIES AND LIBNUMA_INCLUDE_DIRS)
+
+find_path(LIBNUMA_INCLUDE_DIRS NAMES numa.h)
+find_library(LIBNUMA_LIBRARIES NAMES numa)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibNuma DEFAULT_MSG
+    LIBNUMA_LIBRARIES
+    LIBNUMA_INCLUDE_DIRS)
+
+mark_as_advanced(LIBNUMA_INCLUDE_DIRS LIBNUMA_LIBRARIES)

CMake/FindLibPng.cmake

@@ -0,0 +1,14 @@
+
+if (LIBPNG_LIBRARIES AND LIBPNG_INCLUDE_DIRS)
+  set (LibPng_FIND_QUIETLY TRUE)
+endif (LIBPNG_LIBRARIES AND LIBPNG_INCLUDE_DIRS)
+
+find_path(LIBPNG_INCLUDE_DIRS NAMES png.h)
+find_library(LIBPNG_LIBRARIES NAMES png)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibPng DEFAULT_MSG
+    LIBPNG_LIBRARIES
+    LIBPNG_INCLUDE_DIRS)
+
+mark_as_advanced(LIBPNG_INCLUDE_DIRS LIBPNG_LIBRARIES)

CMake/FindLibUODBC.cmake

@@ -0,0 +1,12 @@
+if (LIBODBC_LIBRARIES AND LIBODBC_INCLUDE_DIRS)
+  set (LibUODBC_FIND_QUIETLY TRUE)
+endif (LIBODBC_LIBRARIES AND LIBODBC_INCLUDE_DIRS)
+
+find_path (LIBODBC_INCLUDE_DIRS NAMES sqlext.h)
+find_library (LIBODBC_LIBRARIES NAMES odbc)
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibUODBC DEFAULT_MSG
+    LIBODBC_LIBRARIES
+    LIBODBC_INCLUDE_DIRS)
+
+mark_as_advanced(LIBODBC_INCLUDE_DIRS LIBODBC_LIBRARIES)

CMake/FindLibVpx.cmake

@@ -0,0 +1,14 @@
+
+if (LIBVPX_LIBRARIES AND LIBVPX_INCLUDE_DIRS)
+  set (LibVpx_FIND_QUIETLY TRUE)
+endif (LIBVPX_LIBRARIES AND LIBVPX_INCLUDE_DIRS)
+
+find_path(LIBVPX_INCLUDE_DIRS NAMES vpx_codec.h)
+find_library(LIBVPX_LIBRARIES NAMES vpx)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibVpx DEFAULT_MSG
+    LIBVPX_LIBRARIES
+    LIBVPX_INCLUDE_DIRS)
+
+mark_as_advanced(LIBVPX_INCLUDE_DIRS LIBVPX_LIBRARIES)

CMake/FindLibYaml.cmake

@@ -0,0 +1,13 @@
+if (LibYaml_LIBRARIES AND LibYaml_INCLUDE_DIRS)
+  set (LibYaml_FIND_QUIETLY TRUE)
+endif (LibYaml_LIBRARIES AND LibYaml_INCLUDE_DIRS)
+
+find_path (LibYaml_INCLUDE_DIRS NAMES yaml.h)
+find_library (LibYaml_LIBRARIES NAMES yaml)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LibYaml DEFAULT_MSG
+    LibYaml_LIBRARIES
+    LibYaml_INCLUDE_DIRS)
+
+mark_as_advanced(LibYaml_INCLUDE_DIRS LibYaml_LIBRARIES)

CMake/FindLibunwind.cmake

@@ -1,28 +0,0 @@
-#
-# $Id$
-#
-# - Find libunwind
-# Find libunwind
-#
-#  LIBUNWIND_INCLUDE_DIR - where to find unwind.h and libunwind.h
-#  LIBUNWIND_LIBRARY     - List of libraries when using libunwind
-#  LIBUNWIND_FOUND       - True if libunwind found.
-
-
-if(LIBUNWIND_INCLUDE_DIR)
-  # Already in cache, be silent
-  SET(LIBUNWIND_FIND_QUIETLY TRUE)
-endif()
-
-FIND_PATH(LIBUNWIND_INCLUDE_DIR libunwind.h)
-if(NOT EXISTS "${LIBUNWIND_INCLUDE_DIR}/unwind.h")
-  message(FATAL_ERROR "libunwind.h found without matching unwind.h")
-  SET(LIBUNWIND_INCLUDE_DIR "")
-endif()
-
-FIND_LIBRARY(LIBUNWIND_LIBRARY unwind)
-
-INCLUDE(FindPackageHandleStandardArgs)
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(LIBUNWIND DEFAULT_MSG LIBUNWIND_LIBRARY LIBUNWIND_INCLUDE_DIR)
-
-MARK_AS_ADVANCED(LIBUNWIND_LIBRARY LIBUNWIND_INCLUDE_DIR)

CMake/FindMySQL.cmake

@@ -29,7 +29,7 @@
 
 
 #-------------- FIND MYSQL_INCLUDE_DIR ------------------
-FIND_PATH(MYSQL_INCLUDE_DIR mysql/mysql.h
+FIND_PATH(MYSQL_INCLUDE_DIR mysql.h
 		$ENV{MYSQL_INCLUDE_DIR}
 		$ENV{MYSQL_DIR}/include
 		/usr/include/mysql

CMake/FindPThread.cmake

@@ -0,0 +1,27 @@
+# - Try to find libpthread
+#
+# Once done this will define
+#
+#  LIBPTHREAD_FOUND - system has libpthread
+#  LIBPTHREAD_INCLUDE_DIRS - the libpthread include directory
+#  LIBPTHREAD_LIBRARIES - Link these to use libpthread
+#  LIBPTHREAD_DEFINITIONS - Compiler switches required for using libpthread
+#
+#  Redistribution and use is allowed according to the terms of the New
+#  BSD license.
+#  For details see the accompanying COPYING-CMAKE-SCRIPTS file.
+#
+
+
+if (LIBPTHREAD_LIBRARIES AND LIBPTHREAD_INCLUDE_DIRS)
+  set (LIBPTHREAD_FIND_QUIETLY TRUE)
+endif (LIBPTHREAD_LIBRARIES AND LIBPTHREAD_INCLUDE_DIRS)
+
+find_path (LIBPTHREAD_INCLUDE_DIRS NAMES pthread.h)
+find_library (LIBPTHREAD_LIBRARIES NAMES pthread)
+
+include (FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(LIBPTHREAD DEFAULT_MSG
+    LIBPTHREAD_LIBRARIES LIBPTHREAD_INCLUDE_DIRS)
+
+mark_as_advanced(LIBPTHREAD_INCLUDE_DIRS LIBPTHREAD_LIBRARIES LIBPTHREAD_FOUND)

CMake/FollySetup.cmake

@@ -0,0 +1,28 @@
+# folly-config.h is a generated file from autotools
+# We need to do the equivalent checks here and use
+# add_definitions as needed
+add_definitions(-DFOLLY_NO_CONFIG=1)
+
+INCLUDE(CheckCXXSourceCompiles)
+CHECK_CXX_SOURCE_COMPILES("
+extern \"C\" void (*test_ifunc(void))() { return 0; }
+void func() __attribute__((ifunc(\"test_ifunc\")));
+" FOLLY_IFUNC)
+if (FOLLY_IFUNC)
+        add_definitions("-DHAVE_IFUNC=1")
+endif()
+
+set(CMAKE_REQUIRED_LIBRARIES rt)
+include(CheckFunctionExists)
+CHECK_FUNCTION_EXISTS("clock_gettime" HAVE_CLOCK_GETTIME)
+
+if (HAVE_CLOCK_GETTIME)
+	add_definitions("-DFOLLY_HAVE_CLOCK_GETTIME=1")
+endif()
+set(CMAKE_REQUIRED_LIBRARIES)
+
+find_path(FEATURES_H_INCLUDE_DIR NAMES features.h)
+if (FEATURES_H_INCLUDE_DIR)
+	include_directories("${FEATURES_H_INCLUDE_DIR}")
+	add_definitions("-DFOLLY_HAVE_FEATURES_H=1")
+endif()

CMake/HPHPCompiler.cmake

@@ -0,0 +1,56 @@
+if(CMAKE_COMPILER_IS_GNUCC)
+	INCLUDE(CheckCSourceCompiles)
+
+	CHECK_C_SOURCE_COMPILES("#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)
+#if GCC_VERSION < 40700
+#error Not GCC 4.7.0+
+#endif
+int main() { return 0; }" HAVE_GCC_47)
+
+	if (NOT HAVE_GCC_47)
+		message(FATAL_ERROR "Need at least GCC 4.7")
+	endif()
+
+	CHECK_C_SOURCE_COMPILES("#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)
+#if GCC_VERSION < 40800
+#error Not GCC 4.8.0+
+#endif
+int main() { return 0; }" HAVE_GCC_48)
+
+endif()
+
+set(FREEBSD FALSE)
+set(LINUX FALSE)
+
+if("${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD")
+	set(FREEBSD TRUE)
+endif()
+
+if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")
+	set(LINUX TRUE)
+endif()
+
+if($ENV{CXX} MATCHES "icpc")
+	set(CMAKE_C_FLAGS "-no-ipo -fp-model precise -wd584 -wd1418 -wd1918 -wd383 -wd869 -wd981 -wd424 -wd1419 -wd444 -wd271 -wd2259 -wd1572 -wd1599 -wd82 -wd177 -wd593 -w")
+	set(CMAKE_CXX_FLAGS "-no-ipo -fp-model precise -wd584 -wd1418 -wd1918 -wd383 -wd869 -wd981 -wd424 -wd1419 -wd444 -wd271 -wd2259 -wd1572 -wd1599 -wd82 -wd177 -wd593 -fno-omit-frame-pointer -ftemplate-depth-180 -Wall -Woverloaded-virtual -Wno-deprecated -w1 -Wno-strict-aliasing -Wno-write-strings -Wno-invalid-offsetof -fno-operator-names")
+else()
+	set(GNUCC_48_OPT "")
+	if(HAVE_GCC_48)
+		set(GNUCC_48_OPT "-Wno-unused-local-typedefs -fno-canonical-system-headers -Wno-deprecated-declarations")
+	endif()
+	set(CMAKE_C_FLAGS "-w")
+	set(CMAKE_CXX_FLAGS "-fno-gcse -fno-omit-frame-pointer -ftemplate-depth-180 -Wall -Woverloaded-virtual -Wno-deprecated -Wno-strict-aliasing -Wno-write-strings -Wno-invalid-offsetof -fno-operator-names -Wno-error=array-bounds -Wno-error=switch -std=gnu++11 -Werror=format-security -Wno-unused-result -Wno-sign-compare -Wno-attributes -Wno-maybe-uninitialized -mcrc32 ${GNUCC_48_OPT}")
+endif()
+
+if(${CMAKE_CXX_COMPILER} MATCHES ".*clang.*")
+	set(CMAKE_CXX_FLAGS "-fno-gcse -fno-omit-frame-pointer -ftemplate-depth-180 -Wall -Woverloaded-virtual -Wno-deprecated -Wno-strict-aliasing -Wno-write-strings -Wno-invalid-offsetof -fno-operator-names -Wno-error=array-bounds -Wno-error=switch -std=gnu++11 -Werror=format-security -Wno-unused-result -Wno-sign-compare -Wno-attributes -Wno-maybe-uninitialized -Wno-mismatched-tags -Wno-unknown-warning-option -Wno-return-type-c-linkage -Qunused-arguments")
+endif()
+
+if(CMAKE_COMPILER_IS_GNUCC)
+	set(CMAKE_C_FLAGS_RELEASE "-O3")
+endif()
+
+if(CMAKE_COMPILER_IS_GNUCXX)
+	set(CMAKE_CXX_FLAGS_RELEASE "-O3")
+endif()
+

CMake/HPHPFindLibs.cmake

@@ -17,11 +17,25 @@
 
 include(CheckFunctionExists)
 
-# boost checks
+# libdl
+find_package(LibDL)
+if (LIBDL_INCLUDE_DIRS)
+	add_definitions("-DHAVE_LIBDL")
+	include_directories(${LIBDL_INCLUDE_DIRS})
+	if (LIBDL_NEEDS_UNDERSCORE)
+		add_definitions("-DLIBDL_NEEDS_UNDERSCORE")
+	endif()
+endif()
 
+# boost checks
 find_package(Boost 1.48.0 COMPONENTS system program_options filesystem regex REQUIRED)
 include_directories(${Boost_INCLUDE_DIRS})
 link_directories(${Boost_LIBRARY_DIRS})
+# Boost 1.49 supports a better flat_multimap, but 1.48 is good enough
+if (Boost_VERSION GREATER 104899)
+	add_definitions("-DHAVE_BOOST1_49")
+endif()
+
 
 # features.h
 FIND_PATH(FEATURES_HEADER features.h)
@@ -39,10 +53,6 @@ if (LIBINOTIFY_INCLUDE_DIR)
 	include_directories(${LIBINOTIFY_INCLUDE_DIR})
 endif()
 
-# unwind checks
-find_package(Libunwind REQUIRED)
-include_directories(${LIBUNWIND_INCLUDE_DIR})
-
 # iconv checks
 find_package(Libiconv REQUIRED)
 include_directories(${LIBICONV_INCLUDE_DIR})
@@ -80,29 +90,46 @@ include_directories(${LIBEVENT_INCLUDE_DIR})
 
 set(CMAKE_REQUIRED_LIBRARIES "${LIBEVENT_LIB}")
 CHECK_FUNCTION_EXISTS("evhttp_bind_socket_with_fd" HAVE_CUSTOM_LIBEVENT)
-if (NOT HAVE_CUSTOM_LIBEVENT)
-	unset(HAVE_CUSTOM_LIBEVENT CACHE)
-	unset(LIBEVENT_INCLUDE_DIR CACHE)
-	unset(LIBEVENT_LIB CACHE)
-	unset(LibEvent_FOUND CACHE)
-	message(FATAL_ERROR "Custom libevent is required with HipHop patches")
-endif ()
+if(HAVE_CUSTOM_LIBEVENT)
+        message("Using custom LIBEVENT")
+        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DHAVE_CUSTOM_LIBEVENT")
+endif()
 set(CMAKE_REQUIRED_LIBRARIES)
 
-# GD checks
-find_package(GD REQUIRED)
+find_package(LibUODBC)
+if (LIBUODBC_INCLUDE_DIRS)
+	include_directories(${LIBUODBC_INCLUDE_DIRS})
+	add_definitions("-DHAVE_UODBC")
+endif ()
 
-if (WANT_FB_LIBMCC)
-	add_definitions(-DHPHP_WITH_LIBMCC)
-	message(FATAL_ERROR Need to add libmcc and libch for linking)
-else ()
-	# nothing for now
+# GD checks
+add_definitions(-DPNG_SKIP_SETJMP_CHECK)
+find_package(LibVpx)
+if (LIBVPX_INCLUDE_DIRS)
+	include_directories(${LIBVPX_INCLUDE_DIRS})
+	add_definitions("-DHAVE_GD_WEBP")
+endif()
+find_package(LibJpeg)
+if (LIBJPEG_INCLUDE_DIRS)
+	include_directories(${LIBJPEG_INCLUDE_DIRS})
+	add_definitions("-DHAVE_GD_JPG")
+endif()
+find_package(LibPng)
+if (LIBPNG_INCLUDE_DIRS)
+	include_directories(${LIBPNG_INCLUDE_DIRS})
+	add_definitions("-DHAVE_GD_PNG")
+endif()
+find_package(Freetype)
+if (FREETYPE_INCLUDE_DIRS)
+	include_directories(${FREETYPE_INCLUDE_DIRS})
+	add_definitions("-DHAVE_LIBFREETYPE -DHAVE_GD_FREETYPE -DENABLE_GD_TTF")
 endif()
 
+# libXed
 find_package(LibXed)
 if (LibXed_INCLUDE_DIR AND LibXed_LIBRARY)
 	include_directories(${LibXed_INCLUDE_DIR})
-	add_definitions(-DHAVE_LIBXED)
+	add_definitions("-DHAVE_LIBXED")
 endif()
 
 # CURL checks
@@ -138,16 +165,7 @@ include_directories("${HPHP_HOME}/hphp/third_party/libmbfl/filter")
 include_directories("${HPHP_HOME}/hphp/third_party/lz4")
 include_directories("${HPHP_HOME}/hphp/third_party/double-conversion/src")
 include_directories("${HPHP_HOME}/hphp/third_party/folly")
-
-FIND_LIBRARY(XHP_LIB xhp)
-FIND_PATH(XHP_INCLUDE_DIR xhp_preprocess.hpp)
-
-if (XHP_LIB AND XHP_INCLUDE_DIR)
-	include_directories(${XHP_INCLUDE_DIR})
-	set(SKIP_BUNDLED_XHP ON)
-else()
-	include_directories("${HPHP_HOME}/hphp/third_party/xhp/xhp")
-endif()
+include_directories("${HPHP_HOME}/hphp/third_party/libzip")
 
 # ICU
 find_package(ICU REQUIRED)
@@ -161,9 +179,6 @@ if (ICU_FOUND)
 	include_directories(${ICU_INCLUDE_DIRS})
 endif (ICU_FOUND)
 
-# (google heap OR cpu profiler) AND libunwind 
-FIND_LIBRARY(UNWIND_LIB unwind)
-
 # jemalloc/tmalloc and profiler
 if (USE_GOOGLE_HEAP_PROFILER OR USE_GOOGLE_CPU_PROFILER)
 	FIND_LIBRARY(GOOGLE_PROFILER_LIB profiler)
@@ -188,17 +203,35 @@ if (USE_GOOGLE_HEAP_PROFILER AND GOOGLE_PROFILER_LIB)
 	endif()
 endif()
 
-if (USE_JEMALLOC AND NOT GOOGLE_TCMALLOC_ENABLED
-		AND NOT CMAKE_BUILD_TYPE STREQUAL Debug)
-	FIND_LIBRARY(JEMALLOC_LIB jemalloc)
-	if (JEMALLOC_LIB)
-		message(STATUS "Found jemalloc: ${JEMALLOC_LIB}")
-		set(JEMALLOC_ENABLED 1)
+if (USE_JEMALLOC AND NOT GOOGLE_TCMALLOC_ENABLED)
+	FIND_LIBRARY(JEMALLOC_LIB NAMES jemalloc)
+	FIND_PATH(JEMALLOC_INCLUDE_DIR NAMES jemalloc/jemalloc.h)
+
+	if (JEMALLOC_INCLUDE_DIR AND JEMALLOC_LIB)
+		include_directories(${JEMALLOC_INCLUDE_DIR})
+
+		set (CMAKE_REQUIRED_INCLUDES ${JEMALLOC_INCLUDE_DIR})
+		INCLUDE(CheckCXXSourceCompiles)
+		CHECK_CXX_SOURCE_COMPILES("
+#include <jemalloc/jemalloc.h>
+int main(void) {
+#if !defined(JEMALLOC_VERSION_MAJOR) || (JEMALLOC_VERSION_MAJOR < 3)
+# error \"jemalloc version >= 3.0.0 required\"
+#endif
+	return 0;
+}" JEMALLOC_VERSION_3)
+		set (CMAKE_REQUIRED_INCLUDES)
+
+		if (JEMALLOC_VERSION_3)
+			message(STATUS "Found jemalloc: ${JEMALLOC_LIB}")
+			set(JEMALLOC_ENABLED 1)
+		else()
+			message(STATUS "Found jemalloc, but it was too old")
+		endif()
 	endif()
 endif()
 
-if (USE_TCMALLOC AND NOT JEMALLOC_ENABLED AND NOT GOOGLE_TCMALLOC_ENABLED
-		AND NOT CMAKE_BUILD_TYPE STREQUAL Debug)
+if (USE_TCMALLOC AND NOT JEMALLOC_ENABLED AND NOT GOOGLE_TCMALLOC_ENABLED)
 	FIND_LIBRARY(GOOGLE_TCMALLOC_MIN_LIB tcmalloc_minimal)
 	if (GOOGLE_TCMALLOC_MIN_LIB)
 		message(STATUS "Found minimal tcmalloc: ${GOOGLE_TCMALLOC_MIN_LIB}")
@@ -265,17 +298,36 @@ include_directories(${LDAP_INCLUDE_DIR})
 find_package(Ncurses REQUIRED)
 include_directories(${NCURSES_INCLUDE_PATH})
 
-find_package(Readline REQUIRED)
-include_directories(${READLINE_INCLUDE_DIR})
+# libpthreads
+find_package(PThread REQUIRED)
+include_directories(${LIBPTHREAD_INCLUDE_DIRS})
+
+# Either Readline or Editline (for hphpd)
+find_package(Readline)
+find_package(Editline)
+if (READLINE_INCLUDE_DIR)
+	include_directories(${READLINE_INCLUDE_DIR})
+elseif (EDITLINE_INCLUDE_DIRS)
+	add_definitions("-DUSE_EDITLINE")
+	include_directories(${EDITLINE_INCLUDE_DIRS})
+else()
+	message(FATAL_ERROR "Could not find Readline or Editline")
+endif()
 
 find_package(CClient REQUIRED)
 include_directories(${CCLIENT_INCLUDE_PATH})
 
 find_package(LibDwarf REQUIRED)
 include_directories(${LIBDWARF_INCLUDE_DIRS})
+if (LIBDWARF_HAVE_ENCODE_LEB128)
+	add_definitions("-DHAVE_LIBDWARF_20130729")
+endif()
 
 find_package(LibElf REQUIRED)
 include_directories(${LIBELF_INCLUDE_DIRS})
+if (ELF_GETSHDRSTRNDX)
+        add_definitions("-DHAVE_ELF_GETSHDRSTRNDX")
+endif()
 
 CONTAINS_STRING("${CCLIENT_INCLUDE_PATH}/utf8.h" U8T_DECOMPOSE RECENT_CCLIENT)
 if (NOT RECENT_CCLIENT)
@@ -283,29 +335,35 @@ if (NOT RECENT_CCLIENT)
 	message(FATAL_ERROR "Your version of c-client is too old, you need 2007")
 endif()
 
-CONTAINS_STRING("${CCLIENT_INCLUDE_PATH}/linkage.h" auth_gss CCLIENT_NEEDS_PAM)
+
+if (EXISTS "${CCLIENT_INCLUDE_PATH}/linkage.c")
+	CONTAINS_STRING("${CCLIENT_INCLUDE_PATH}/linkage.c" auth_gss CCLIENT_HAS_GSS)
+elseif (EXISTS "${CCLIENT_INCLUDE_PATH}/linkage.h")
+    CONTAINS_STRING("${CCLIENT_INCLUDE_PATH}/linkage.h" auth_gss CCLIENT_HAS_GSS)
+endif()
+
+find_package(Libpam)
+if (PAM_INCLUDE_PATH)
+	include_directories(${PAM_INCLUDE_PATH})
+endif()
+
+if (NOT CCLIENT_HAS_GSS)
+	add_definitions(-DSKIP_IMAP_GSS=1)
+endif()
 
 if (EXISTS "${CCLIENT_INCLUDE_PATH}/linkage.c")
 	CONTAINS_STRING("${CCLIENT_INCLUDE_PATH}/linkage.c" ssl_onceonlyinit CCLIENT_HAS_SSL)
-endif()
-
-if (CCLIENT_NEEDS_PAM)
-	find_package(Libpam REQUIRED)
-	include_directories(${PAM_INCLUDE_PATH})
-else()
-	add_definitions(-DSKIP_IMAP_GSS=1)
+elseif (EXISTS "${CCLIENT_INCLUDE_PATH}/linkage.h")
+	CONTAINS_STRING("${CCLIENT_INCLUDE_PATH}/linkage.h" ssl_onceonlyinit CCLIENT_HAS_SSL)
 endif()
 
 if (NOT CCLIENT_HAS_SSL)
 	add_definitions(-DSKIP_IMAP_SSL=1)
 endif()
 
+FIND_LIBRARY(CRYPT_LIB NAMES xcrypt crypt crypto)
 if (LINUX OR FREEBSD)
-	FIND_LIBRARY (CRYPT_LIB NAMES xcrypt crypt)
 	FIND_LIBRARY (RT_LIB rt)
-elseif (APPLE)
-	FIND_LIBRARY (CRYPT_LIB crypto)
-	FIND_LIBRARY (ICONV_LIB iconv)
 endif()
 
 if (LINUX)
@@ -339,6 +397,14 @@ if (FREEBSD)
 	endif()
 endif()
 
+if (APPLE)
+	find_library(LIBINTL_LIBRARIES NAMES intl libintl)
+	if (LIBINTL_INCLUDE_DIR)
+		include_directories(${LIBINTL_INCLUDE_DIR})
+	endif()
+	find_library(KERBEROS_LIB NAMES gssapi_krb5)
+endif()
+
 #find_package(BISON REQUIRED)
 #find_package(FLEX REQUIRED)
 
@@ -350,6 +416,10 @@ include_directories(${HPHP_HOME}/hphp)
 include_directories(${HPHP_HOME}/hphp/system/gen)
 
 macro(hphp_link target)
+	if (LIBDL_LIBRARIES)
+		target_link_libraries(${target} ${LIBDL_LIBRARIES})
+	endif ()
+
 	if (GOOGLE_HEAP_PROFILER_ENABLED OR GOOGLE_CPU_PROFILER_ENABLED)
 		target_link_libraries(${target} ${GOOGLE_PROFILER_LIB})
 	endif()
@@ -365,10 +435,9 @@ macro(hphp_link target)
 	endif()
 
 	target_link_libraries(${target} ${Boost_LIBRARIES})
-	target_link_libraries(${target} ${LIBUNWIND_LIBRARY})
 	target_link_libraries(${target} ${MYSQL_CLIENT_LIBS})
 	target_link_libraries(${target} ${PCRE_LIBRARY})
-	target_link_libraries(${target} ${ICU_LIBRARIES} ${ICU_I18N_LIBRARIES})
+	target_link_libraries(${target} ${ICU_DATA_LIBRARIES} ${ICU_I18N_LIBRARIES} ${ICU_LIBRARIES})
 	target_link_libraries(${target} ${LIBEVENT_LIB})
 	target_link_libraries(${target} ${CURL_LIBRARIES})
 	target_link_libraries(${target} ${LIBGLOG_LIBRARY})
@@ -399,9 +468,16 @@ if (FREEBSD)
 	target_link_libraries(${target} ${EXECINFO_LIB})
 endif()
 
+if (APPLE)
+	target_link_libraries(${target} ${LIBINTL_LIBRARIES})
+	target_link_libraries(${target} ${KERBEROS_LIB})
+endif()
+
 	target_link_libraries(${target} ${BFD_LIB})
 	target_link_libraries(${target} ${BINUTIL_LIB})
-	target_link_libraries(${target} pthread)
+if (${LIBPTHREAD_LIBRARIES})
+	target_link_libraries(${target} ${LIBPTHREAD_LIBRARIES})
+endif()
 	target_link_libraries(${target} ${TBB_LIBRARIES})
 	target_link_libraries(${target} ${OPENSSL_LIBRARIES})
 	target_link_libraries(${target} ${ZLIB_LIBRARIES})
@@ -412,18 +488,29 @@ endif()
 	target_link_libraries(${target} ${ONIGURUMA_LIBRARIES})
 	target_link_libraries(${target} ${Mcrypt_LIB})
 	target_link_libraries(${target} ${GD_LIBRARY})
-
+if (FREETYPE_LIBRARIES)
+	target_link_libraries(${target} ${FREETYPE_LIBRARIES})
+endif()
+if (LIBJPEG_LIBRARIES)
+	target_link_libraries(${target} ${LIBJPEG_LIBRARIES})
+endif()
+if (LIBPNG_LIBRARIES)
+	target_link_libraries(${target} ${LIBPNG_LIBRARIES})
+endif()
+if (LIBVPX_LIBRARIES)
+	target_link_libraries(${target} ${LIBVPX_LIBRARIES})
+endif()
+if (LIBUODBC_LIBRARIES)
+	target_link_libraries(${target} ${LIBUODBC_LIBRARIES})
+endif()
 	target_link_libraries(${target} ${LDAP_LIBRARIES})
 	target_link_libraries(${target} ${LBER_LIBRARIES})
 
 	target_link_libraries(${target} ${LIBMEMCACHED_LIBRARY})
 
+	target_link_libraries(${target} ${CRYPT_LIB})
 	if (LINUX OR FREEBSD)
-		target_link_libraries(${target} ${CRYPT_LIB})
 		target_link_libraries(${target} ${RT_LIB})
-	elseif (APPLE)
-		target_link_libraries(${target} ${CRYPTO_LIB})
-		target_link_libraries(${target} ${ICONV_LIB})
 	endif()
 
 	target_link_libraries(${target} timelib)
@@ -431,21 +518,21 @@ endif()
 	target_link_libraries(${target} lz4)
 	target_link_libraries(${target} double-conversion)
 	target_link_libraries(${target} folly)
-
-	if (SKIP_BUNDLED_XHP)
-		target_link_libraries(${target} ${XHP_LIB})
-	else()
-		target_link_libraries(${target} xhp)
-	endif()
+	target_link_libraries(${target} zip_static)
 
 	target_link_libraries(${target} afdt)
 	target_link_libraries(${target} mbfl)
 
-	target_link_libraries(${target} ${READLINE_LIBRARY})
+	if (READLINE_LIBRARY)
+		target_link_libraries(${target} ${READLINE_LIBRARY})
+	elseif (EDITLINE_LIBRARIES)
+		target_link_libraries(${target} ${EDITLINE_LIBRARIES})
+	endif()
+
 	target_link_libraries(${target} ${NCURSES_LIBRARY})
 	target_link_libraries(${target} ${CCLIENT_LIBRARY})
 
-	if (CCLIENT_NEEDS_PAM)
+	if (PAM_LIBRARY)
 		target_link_libraries(${target} ${PAM_LIBRARY})
 	endif()
 

CMake/HPHPFunctions.cmake

@@ -38,6 +38,27 @@ function(auto_sources RETURN_VALUE PATTERN SOURCE_SUBDIRS)
 	set(${RETURN_VALUE} ${${RETURN_VALUE}} PARENT_SCOPE)
 endfunction(auto_sources)
 
+macro(HHVM_SELECT_SOURCES DIR)
+	auto_sources(files "*.cpp" "RECURSE" "${DIR}")
+	foreach(f ${files})
+		if (NOT (${f} MATCHES "(ext_hhvm|/(old-)?tests?/)"))
+			list(APPEND CXX_SOURCES ${f})
+		endif()
+	endforeach()
+	auto_sources(files "*.c" "RECURSE" "${DIR}")
+	foreach(f ${files})
+		if (NOT (${f} MATCHES "(ext_hhvm|/(old-)?tests?/)"))
+			list(APPEND C_SOURCES ${f})
+		endif()
+	endforeach()
+	auto_sources(files "*.S" "RECURSE" "${DIR}")
+	foreach(f ${files})
+		if (NOT (${f} MATCHES "(ext_hhvm|/(old-)?tests?/)"))
+			list(APPEND ASM_SOURCES ${f})
+		endif()
+	endforeach()
+endmacro(HHVM_SELECT_SOURCES)
+
 function(CONTAINS_STRING FILE SEARCH RETURN_VALUE)
 	file(STRINGS ${FILE} FILE_CONTENTS REGEX ".*${SEARCH}.*")
 	if (FILE_CONTENTS)
@@ -67,3 +88,60 @@ macro(MYSQL_SOCKET_SEARCH)
 		set(MYSQL_UNIX_SOCK_ADDR ${MYSQL_SOCK} CACHE STRING "Path to MySQL Socket")
 	endif()
 endmacro()
+
+function(embed_systemlib TARGET DEST SOURCE SECTNAME)
+	if (APPLE)
+	        target_link_libraries(${TARGET} -Wl,-sectcreate,__text,${SECTNAME},${SOURCE})
+	else()
+	        add_custom_command(TARGET ${TARGET} POST_BUILD
+	                   COMMAND "objcopy"
+	                   ARGS "--add-section" "${SECTNAME}=${SOURCE}" ${DEST}
+	                   COMMENT "Embedding ${SOURCE} in ${TARGET} as ${SECTNAME}")
+	endif()
+	# Add the systemlib file to the "LINK_DEPENDS" for the systemlib, this will cause it
+	# to be relinked and the systemlib re-embedded
+	set_property(TARGET ${TARGET} APPEND PROPERTY LINK_DEPENDS ${SOURCE})
+endfunction(embed_systemlib)
+
+function(embed_all_systemlibs TARGET DEST)
+	embed_systemlib(${TARGET} ${DEST} ${HPHP_HOME}/hphp/system/systemlib.php systemlib)
+	auto_sources(SYSTEMLIBS "ext_*.php" "RECURSE" "${HPHP_HOME}/hphp/runtime")
+	foreach(SLIB ${SYSTEMLIBS})
+		get_filename_component(SLIB_BN ${SLIB} "NAME_WE")
+		string(LENGTH ${SLIB_BN} SLIB_BN_LEN)
+		math(EXPR SLIB_BN_REL_LEN "${SLIB_BN_LEN} - 4")
+		string(SUBSTRING ${SLIB_BN} 4 ${SLIB_BN_REL_LEN} SLIB_EXTNAME)
+		string(MD5 SLIB_HASH_NAME ${SLIB_EXTNAME})
+		string(SUBSTRING ${SLIB_HASH_NAME} 0 12 SLIB_HASH_NAME_SHORT)
+		embed_systemlib(${TARGET} ${DEST} ${SLIB} "ext.${SLIB_HASH_NAME_SHORT}")
+	endforeach()
+endfunction(embed_all_systemlibs)
+
+# Custom install function that doesn't relink, instead it uses chrpath to change it, if
+# it's available, otherwise, it leaves the chrpath alone
+function(HHVM_INSTALL TARGET DEST)
+	get_target_property(LOC ${TARGET} LOCATION)
+	get_target_property(TY ${TARGET} TYPE)
+	if (FOUND_CHRPATH)
+		get_target_property(RPATH ${TARGET} INSTALL_RPATH)
+		if (NOT RPATH STREQUAL "RPATH-NOTFOUND")
+			if (RPATH STREQUAL "")
+				install(CODE "execute_process(COMMAND \"${CHRPATH}\" \"-d\" \"${LOC}\" ERROR_QUIET)")
+			else()
+				install(CODE "execute_process(COMMAND \"${CHRPATH}\" \"-r\" \"${RPATH}\" \"${LOC}\" ERROR_QUIET)")
+			endif()
+		endif()
+	endif()
+	install(CODE "FILE(INSTALL DESTINATION \"\${CMAKE_INSTALL_PREFIX}/${DEST}\" TYPE ${TY} FILES \"${LOC}\")")
+endfunction(HHVM_INSTALL)
+
+function(HHVM_EXTENSION EXTNAME)
+	list(REMOVE_AT ARGV 0)
+	add_library(${EXTNAME} SHARED ${ARGV})
+	set_target_properties(${EXTNAME} PROPERTIES PREFIX "")
+	set_target_properties(${EXTNAME} PROPERTIES SUFFIX ".so")
+endfunction()
+
+function(HHVM_SYSTEMLIB EXTNAME SOURCE_FILE)
+	embed_systemlib(${EXTNAME} "${EXTNAME}.so" ${SOURCE_FILE} systemlib)
+endfunction()

CMake/HPHPSetup.cmake

@@ -1,5 +1,37 @@
 include(Options)
 
+# Do this until cmake has a define for ARMv8
+INCLUDE(CheckCXXSourceCompiles)
+CHECK_CXX_SOURCE_COMPILES("
+#ifndef __AARCH64EL__
+#error Not ARMv8  
+#endif
+int main() { return 0; }" IS_AARCH64)
+
+if (APPLE OR IS_AARCH64)
+	set(HHVM_ANCHOR_SYMS -Wl,-u,_register_libevent_server)
+else()
+	set(ENABLE_FASTCGI 1)
+	set(HHVM_ANCHOR_SYMS -Wl,-uregister_libevent_server,-uregister_fastcgi_server)
+endif()
+
+set(HHVM_LINK_LIBRARIES
+    hphp_analysis
+    hphp_runtime_static
+    ext_hhvm_static
+    hphp_system
+    hphp_parser
+    hphp_zend
+    hphp_util
+    hphp_hhbbc
+    vixl neo
+    ${HHVM_ANCHOR_SYMS})
+
+if(ENABLE_FASTCGI)
+	LIST(APPEND HHVM_LINK_LIBRARIES hphp_thrift)
+	LIST(APPEND HHVM_LINK_LIBRARIES hphp_proxygen)
+endif()
+
 if(NOT CMAKE_BUILD_TYPE)
 	set(CMAKE_BUILD_TYPE "Release")
 endif()
@@ -8,29 +40,13 @@ IF(NOT DEFINED CMAKE_PREFIX_PATH)
   message(STATUS "CMAKE_PREFIX_PATH was missing, proceeding anyway")
 endif()
 
-if(CMAKE_COMPILER_IS_GNUCC)
-	INCLUDE(CheckCSourceCompiles)
-	CHECK_C_SOURCE_COMPILES("#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)
-#if GCC_VERSION < 40400
-#error Need GCC 4.4.0+
-#endif
-int main() { return 0; }" HAVE_GCC_44)
-
-	if(NOT HAVE_GCC_44)
-		message(FATAL_ERROR "Need at least GCC 4.4")
-	endif()
-
-endif()
-
-set(FREEBSD FALSE)
-set(LINUX FALSE)
-
-if("${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD")
-	set(FREEBSD TRUE)
-endif()
-
-if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")
-	set(LINUX TRUE)
+# Look for the chrpath tool so we can warn if it's not there
+find_program(CHRPATH chrpath)
+IF (CHRPATH STREQUAL "CHRPATH-NOTFOUND")
+    SET(FOUND_CHRPATH OFF)
+    message(WARNING "chrpath not found, rpath will not be stripped from installed binaries")
+else()
+    SET(FOUND_CHRPATH ON)
 endif()
 
 LIST(APPEND CMAKE_PREFIX_PATH "$ENV{CMAKE_PREFIX_PATH}")
@@ -42,11 +58,15 @@ if(APPLE)
 	endif()
 endif()
 
+include(HPHPCompiler)
 include(HPHPFunctions)
 include(HPHPFindLibs)
 
-add_definitions(-D_GNU_SOURCE -D_REENTRANT=1 -D_PTHREADS=1)
-add_definitions(-DHHVM_LIB_PATH_DEFAULT="${HPHP_HOME}/bin")
+add_definitions(-D_REENTRANT=1 -D_PTHREADS=1 -D__STDC_FORMAT_MACROS -DFOLLY_HAVE_WEAK_SYMBOLS=1)
+
+if (LINUX)
+	add_definitions(-D_GNU_SOURCE)
+endif()
 
 if(${CMAKE_BUILD_TYPE} MATCHES "Release")
 	add_definitions(-DRELEASE=1)
@@ -57,22 +77,6 @@ else()
 	message("Generating DEBUG build")
 endif()
 
-if(INFINITE_LOOP_DETECTION)
-	add_definitions(-DINFINITE_LOOP_DETECTION=1)
-endif()
-
-if(INFINITE_RECURSION_DETECTION)
-	add_definitions(-DINFINITE_RECURSION_DETECTION=1)
-endif()
-
-if(REQUEST_TIMEOUT_DETECTION)
-	add_definitions(-DREQUEST_TIMEOUT_DETECTION=1)
-endif()
-
-if(ENABLE_LATE_STATIC_BINDING)
-	add_definitions(-DENABLE_LATE_STATIC_BINDING=1)
-endif()
-
 if(DEBUG_MEMORY_LEAK)
 	add_definitions(-DDEBUG_MEMORY_LEAK=1)
 endif()
@@ -89,10 +93,6 @@ if(HOTPROFILER)
 	add_definitions(-DHOTPROFILER=1)
 endif()
 
-if(HOTPROFILER_NO_BUILTIN)
-	add_definitions(-DHOTPROFILER_NO_BUILTIN=1)
-endif()
-
 if(EXECUTION_PROFILER)
 	add_definitions(-DEXECUTION_PROFILER=1)
 endif()
@@ -105,31 +105,33 @@ if(APPLE OR FREEBSD)
 	add_definitions(-DSKIP_USER_CHANGE=1)
 endif()
 
+if(APPLE)
+	# We have to be a little more permissive in some cases.
+	add_definitions(-fpermissive)
+
+	# Skip deprecation warnings in OpenSSL. 
+	add_definitions(-DMAC_OS_X_VERSION_MIN_REQUIRED=MAC_OS_X_VERSION_10_6)
+
+	# Just assume we have sched.h
+	add_definitions(-DFOLLY_HAVE_SCHED_H=1)
+
+	# Enable weak linking
+	add_definitions(-DMACOSX_DEPLOYMENT_TARGET=10.6)
+endif()
+
+if(ENABLE_FASTCGI)
+	add_definitions(-DENABLE_FASTCGI=1)
+endif ()
+
+if(DISABLE_HARDWARE_COUNTERS)
+	add_definitions(-DNO_HARDWARE_COUNTERS=1)
+endif ()
+
 # enable the OSS options if we have any
 add_definitions(-DHPHP_OSS=1)
 
-execute_process(COMMAND git describe --all --long --abbrev=40 --always
-    OUTPUT_VARIABLE _COMPILER_ID OUTPUT_STRIP_TRAILING_WHITESPACE ERROR_QUIET)
-
-if (_COMPILER_ID)
-	add_definitions(-DCOMPILER_ID="${_COMPILER_ID}")
-endif()
-
-IF($ENV{CXX} MATCHES "icpc")
-	set(CMAKE_C_FLAGS "-no-ipo -fp-model precise -wd584 -wd1418 -wd1918 -wd383 -wd869 -wd981 -wd424 -wd1419 -wd444 -wd271 -wd2259 -wd1572 -wd1599 -wd82 -wd177 -wd593 -w")
-	set(CMAKE_CXX_FLAGS "-no-ipo -fp-model precise -wd584 -wd1418 -wd1918 -wd383 -wd869 -wd981 -wd424 -wd1419 -wd444 -wd271 -wd2259 -wd1572 -wd1599 -wd82 -wd177 -wd593 -fno-omit-frame-pointer -ftemplate-depth-120 -Wall -Woverloaded-virtual -Wno-deprecated -w1 -Wno-strict-aliasing -Wno-write-strings -Wno-invalid-offsetof -fno-operator-names")
-else()
-	set(CMAKE_C_FLAGS "-w")
-	set(CMAKE_CXX_FLAGS "-fno-gcse -fno-omit-frame-pointer -ftemplate-depth-120 -Wall -Woverloaded-virtual -Wno-deprecated -Wno-strict-aliasing -Wno-write-strings -Wno-invalid-offsetof -fno-operator-names -Wno-error=array-bounds -Wno-error=switch -std=gnu++0x -Werror=format-security -Wno-unused-result -Wno-sign-compare")
-endif()
-
-IF(CMAKE_COMPILER_IS_GNUCC)
-	SET (CMAKE_C_FLAGS_RELEASE "-O3")
-ENDIF()
-
-IF(CMAKE_COMPILER_IS_GNUCXX)
-	SET (CMAKE_CXX_FLAGS_RELEASE "-O3")
-ENDIF()
+# later versions of binutils don't play well without automake
+add_definitions(-DPACKAGE=hhvm -DPACKAGE_VERSION=Release)
 
 include_directories(${HPHP_HOME}/hphp)
 include_directories(${HPHP_HOME}/hphp/lib/system/gen)

CMake/Options.cmake

@@ -1,24 +1,18 @@
 #set(CMAKE_BUILD_TYPE Debug)
 
-option(ENABLE_LATE_STATIC_BINDING "Enable Late Static Binding" ON)
-
-option(INFINITE_LOOP_DETECTION "Enable Infinite Loop Detection" ON)
-option(INFINITE_RECURSION_DETECTION "Enable Infinite Recursion Detection" ON)
-option(REQUEST_TIMEOUT_DETECTION "Enable Timeout Detection" ON)
-
 option(ALWAYS_ASSERT "Enabled asserts in a release build" OFF)
 option(DEBUG_MEMORY_LEAK "Allow easier debugging of memory leaks" OFF)
 option(DEBUG_APC_LEAK "Allow easier debugging of apc leaks" OFF)
 
 option(HOTPROFILER "Enable support for the hot-profiler" OFF)
-option(HOTPROFILER_NO_BUILTIN "Don't consider builtins for the hot-profiler" OFF)
 option(EXECUTION_PROFILER "Enable the execution profiler" OFF)
 option(ENABLE_FULL_SETLINE "Enable full setline function for debugger and code-coverage" OFF)
 
-option(WANT_FB_LIBMCC "want FB Memcache" OFF)
-
 option(USE_JEMALLOC "Use jemalloc" ON)
 
 option(USE_TCMALLOC "Use tcmalloc (if jemalloc is not used)" ON)
 option(USE_GOOGLE_HEAP_PROFILER "Use Google heap profiler" OFF)
 option(USE_GOOGLE_CPU_PROFILER "Use Google cpu profiler" OFF)
+
+option(DISABLE_HARDWARE_COUNTERS "Disable hardware counters (for XenU systems)" OFF)
+

CMakeLists.txt

@@ -1,18 +1,18 @@
-CMAKE_MINIMUM_REQUIRED(VERSION 2.6.4 FATAL_ERROR)
-PROJECT(hphp C CXX)
+CMAKE_MINIMUM_REQUIRED(VERSION 2.8.7 FATAL_ERROR)
+PROJECT(hphp C CXX ASM)
 
-IF("$ENV{HPHP_HOME}" STREQUAL "")
-	message(FATAL_ERROR "You should set the HPHP_HOME environmental")
+IF(NOT CMAKE_SIZEOF_VOID_P EQUAL 8)
+	message(FATAL_ERROR "HHVM requires a 64bit OS")
 ENDIF()
 
-file(TO_CMAKE_PATH "$ENV{HPHP_HOME}" HPHP_HOME)
+set(HPHP_HOME "$ENV{HPHP_HOME}")
+if (NOT HPHP_HOME)
+	set(HPHP_HOME "${CMAKE_CURRENT_SOURCE_DIR}")
+endif()
+message("Using HPHP_HOME == ${HPHP_HOME}")
 
-IF(NOT IS_DIRECTORY ${HPHP_HOME})
-	message(FATAL_ERROR "The value of HPHP_HOME does not exist")
-ENDIF()
-
-IF(NOT EXISTS "${HPHP_HOME}/LICENSE.PHP")
-	message(FATAL_ERROR "The value of HPHP_HOME in incorrect")
+IF(NOT EXISTS "${HPHP_HOME}/CMake/HPHPSetup.cmake")
+	message(FATAL_ERROR "Invalid HPHP_HOME. Set it to the root of your hhvm tree, or run `cmake .` from there.")
 ENDIF()
 
 SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/CMake" ${CMAKE_MODULE_PATH})
@@ -20,15 +20,5 @@ SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/CMake" ${CMAKE_MODULE_PATH})
 include("${CMAKE_CURRENT_SOURCE_DIR}/CMake/HPHPFunctions.cmake")
 include(CheckFunctionExists)
 
-add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/hphp)
+add_subdirectory(hphp)
 
-IF(CMAKE_SIZEOF_VOID_P EQUAL 4)
-	message(FATAL_ERROR "32-bit support is currently unsupported, check back with a later version of HipHop")
-ENDIF()
-
-if ("$ENV{USE_HHVM}" STREQUAL "1")
-	message("Building for HHVM")
-endif()
-if ("$ENV{USE_HPHPC}" STREQUAL "1")
-	message(FATAL_ERROR "Building HPHPc is no longer supported")
-endif()

CONTRIBUTING.md

@@ -0,0 +1,18 @@
+# Contributing to HipHop
+
+We'd love to have your help in making HipHop better. If you run into problems, please open an [issue](http://github.com/facebook/hiphop-php/issues), or better yet, fork us and send a pull request.
+
+If you want to help but don't know where to start, try fixing some of the [Zend tests that don't pass](hphp/test/zend/bad). You can run them with [hphp/test/run](hphp/test/run). When they work, move them to [zend/good](hphp/test/zend/good) and send a pull request.
+
+All the open issues tagged [Zend incompatibility](https://github.com/facebook/hiphop-php/issues?labels=zend+incompatibility&page=1&state=open) are real issues reported by the community in existing PHP code and [frameworks](https://github.com/facebook/hiphop-php/wiki/OSS-PHP-Frameworks-Unit-Testing:-General) that could use some attention.
+
+## Submitting Pull Requests
+
+Before changes can be accepted a [Contributor Licensing Agreement](http://developers.facebook.com/opensource/cla) ([pdf](https://github.com/facebook/hiphop-php/raw/master/hphp/doc/FB_Individual_CLA.pdf) - print, sign, scan, link) must be signed.
+
+Please add appropriate test cases as you make changes; see [here](hphp/test) for more information. Travis-CI is integrated with this GitHub project and will provide test results automatically on all pulls.
+
+## Additional Resources
+
+ * IRC:[#hhvm on freenode](http://webchat.freenode.net/?channels=hhvm)
+ * [Issue tracker](http://github.com/facebook/hiphop-php/issues)

README.md

@@ -1,78 +1,46 @@
-# HipHop for PHP
+# HHVM [![Build Status](https://travis-ci.org/facebook/hhvm.png?branch=master)](https://travis-ci.org/facebook/hhvm)
 
-HipHop is a high performance PHP toolchain. Currently supported platforms are Linux and FreeBSD. There is no OS X support.
+HHVM (aka the HipHop Virtual Machine) is a new open-source virtual machine designed for executing programs written in PHP. HHVM uses a just-in-time compilation approach to achieve superior performance while maintaining the flexibility that PHP developers are accustomed to. To date, HHVM (and its predecessor HPHPc before it) has realized over a 9x increase in web request throughput and over a 5x reduction in memory consumption for Facebook compared with the Zend PHP 5.2 engine + APC.
 
-* [Developer Mailing List](http://groups.google.com/group/hiphop-php-dev)
-* [Wiki](http://wiki.github.com/facebook/hiphop-php)
-* [Issue Tracker](http://github.com/facebook/hiphop-php/issues)
+HHVM can be run as a standalone webserver (i.e. without the Apache webserver and the "modphp" extension). HHVM can also be used together with a FastCGI-based webserver, and work is in progress to make HHVM work smoothly with Apache.
 
-## Required Packages
+## FAQ
 
-The latest information is available on the [wiki](http://wiki.github.com/facebook/hiphop-php/building-and-installing)
+Our [FAQ](https://github.com/facebook/hhvm/wiki/FAQ) has answers to many common questions about HHVM, from [general questions](https://github.com/facebook/hhvm/wiki/FAQ#general) to questions geared towards those that want to [use](https://github.com/facebook/hhvm/wiki/FAQ#users) or [contribute](https://github.com/facebook/hhvm/wiki/FAQ#contributors) to HHVM.
 
-* cmake *2.6 is the minimum version*
-* g++/gcc *4.3 is the minimum version*
-* Boost *1.37 is the minimum version*
-* flex
-* bison
-* re2c
-* libmysql
-* libxml2
-* libmcrypt
-* libicu *4.2 is the minimum version*
-* openssl
-* binutils
-* libcap
-* gd
-* zlib
-* tbb *Intel's Thread Building Blocks*
-* [Oniguruma](http://www.geocities.jp/kosako3/oniguruma/)
-* libpcre
-* libexpat
-* libmemcached
-* google-glog (http://code.google.com/p/google-glog/)
-* libc-client2007
-* libdwarf
-* libelf
-* libunwind
+## Installing
 
-The following packages have had slight modifications added to them. Patches are provided and should be made against the current source copies.
+You can install a [prebuilt package](https://github.com/facebook/hhvm/wiki#installing-pre-built-packages-for-hhvm) or [compile from source](https://github.com/facebook/hhvm/wiki#building-hhvm).
 
-* [libcurl](http://curl.haxx.se/download.html)
-* hphp/third_party/libcurl.fb-changes.diff
-* [libevent 1.4](http://www.monkey.org/~provos/libevent/)
-* hphp/third_party/libevent-1.4.14.fb-changes.diff
+## Running
 
-## Installation
+You can run standalone programs just by passing them to hhvm: `hhvm my_script.php`.
 
-You may need to point CMake to the location of your custom libcurl and libevent, or to any other libraries which needed to be installed. The *CMAKE_PREFIX_PATH* variable is used to hint to the location.
+HHVM bundles in a webserver. So if you want to run on port 80 in the current directory:
 
-    export CMAKE_PREFIX_PATH=/home/user
+```
+sudo hhvm -m server
+```
 
-To build HipHop, use the following:
+For anything more complicated, you'll want to make a [config.hdf](https://github.com/facebook/hhvm/wiki/Runtime-options#server) and run `sudo hhvm -m server -c config.hdf`.
 
-Linux:
+## Contributing
 
-    cd /home/user/dev
-    git clone git://github.com/facebook/hiphop-php.git
-    cd hiphop-php
-    git submodule init
-    git submodule update
-    export HPHP_HOME=`pwd`
-    export HPHP_LIB=`pwd`/bin
-    cmake .
+We'd love to have your help in making HHVM better. 
 
-If you are using FreeBSD instead use export - setenv
+Before changes can be accepted a [Contributor License Agreement](http://developers.facebook.com/opensource/cla) ([pdf](https://github.com/facebook/hhvm/raw/master/hphp/doc/FB_Individual_CLA.pdf) - print, sign, scan, link) must be signed.
 
-Once this is done you can generate the build file. This will return you to the shell. Finally, to build, run `make`. If any errors occur, it may be required to remove the CMakeCache.txt directory in the checkout.
+If you run into problems, please open an [issue](http://github.com/facebook/hhvm/issues), or better yet, [fork us and send a pull request](https://github.com/facebook/hhvm/pulls). Join us on [#hhvm on freenode](http://webchat.freenode.net/?channels=hhvm).
 
-    make
+If you want to help but don't know where to start, try fixing some of the [Zend tests that don't pass](hphp/test/zend/bad). You can run them with [hphp/test/run](hphp/test/run). When they work, move them to [zend/good](hphp/test/zend/good) and send a pull request.
 
-## Contributing to HipHop
-HipHop is licensed under the PHP and Zend licenses except as otherwise noted.
+All the open issues tagged [Zend incompatibility](https://github.com/facebook/hhvm/issues?labels=zend+incompatibility&page=1&state=open) are real issues reported by the community in existing PHP code and [frameworks](https://github.com/facebook/hhvm/wiki/OSS-PHP-Frameworks-Unit-Testing:-General) that could use some attention. Please add appropriate test cases as you make changes; see [here](hphp/test) for more information. Travis-CI is integrated with this GitHub project and will provide test results automatically on all pulls.
 
-Before changes can be accepted a [Contributors Licensing Agreement](http://developers.facebook.com/opensource/cla) must be signed and returned.
 
-## Running HipHop
+## License
 
-Please see [the wiki page](http://wiki.github.com/facebook/hiphop-php/running-hiphop)
+HHVM is licensed under the PHP and Zend licenses except as otherwise noted.
+
+## Reporting Crashes
+
+See [Reporting Crashes](https://github.com/facebook/hhvm/wiki/Reporting-Crashes) for helpful tips on how to report crashes in an actionable manner.

bin/README

@@ -1 +0,0 @@
-This file just exists to keep the bin/ directory in git.

configure

@@ -3,7 +3,7 @@
 if [ "$1" = '--help' ] || [ "$1" = '-h' ]; then
 	echo 'usage: ./configure -Dvariable=argument ...\n'
 	echo 'Variables: '
-	echo '  CMAKE_BUILD_TYPE=Debug|Release        Sets build type (default Relase).'
+	echo '  CMAKE_BUILD_TYPE=Debug|Release        Sets build type (default Release).'
 
 	exit 2
 fi

configure_ubuntu_12.04.sh

@@ -0,0 +1,126 @@
+#########################################
+# 
+# Install all the dependencies for HipHop
+#
+#########################################
+
+SCRIPT_NAME='./configure_ubuntu_12.04.sh'
+if [ "$0" != "$SCRIPT_NAME" ]; then
+  echo "Run the script from the hiphop-php directory like:"
+  echo "  $SCRIPT_NAME"
+  exit 1
+fi
+
+if [ "x${TRAVIS}" != "x" ]; then
+  # Collect some stats for use in tuning build later on
+  free
+  CPUS=`cat /proc/cpuinfo | grep -E '^processor' | tail -1 | cut -d : -f 2`
+  CPUS=`expr ${CPUS} + 1`
+  echo "CPUs: ${CPUS}"
+fi
+
+export CMAKE_PREFIX_PATH=`/bin/pwd`/..
+
+# install python-software-properties before trying to add a PPA
+sudo apt-get -y update
+sudo apt-get install -y python-software-properties
+
+# install apt-fast to speed up later dependency installation
+sudo add-apt-repository -y ppa:apt-fast/stable
+sudo apt-get -y update
+sudo apt-get -y install apt-fast
+
+# install the actual dependencies
+sudo apt-fast -y update
+sudo apt-fast -y install git-core cmake g++ libboost1.48-dev libmysqlclient-dev \
+  libxml2-dev libmcrypt-dev libicu-dev openssl build-essential binutils-dev \
+  libcap-dev libgd2-xpm-dev zlib1g-dev libtbb-dev libonig-dev libpcre3-dev \
+  autoconf libtool libcurl4-openssl-dev libboost-regex1.48-dev libboost-system1.48-dev \
+  libboost-program-options1.48-dev libboost-filesystem1.48-dev libboost-thread1.48-dev \
+  wget memcached libreadline-dev libncurses-dev libmemcached-dev libbz2-dev \
+  libc-client2007e-dev php5-mcrypt php5-imagick libgoogle-perftools-dev \
+  libcloog-ppl0 libelf-dev libdwarf-dev libunwind7-dev subversion &
+
+git clone git://github.com/libevent/libevent.git --quiet &
+git clone git://github.com/bagder/curl.git --quiet &
+svn checkout http://google-glog.googlecode.com/svn/trunk/ google-glog --quiet &
+wget http://www.canonware.com/download/jemalloc/jemalloc-3.0.0.tar.bz2 --quiet &
+
+# init submodules
+git submodule update --init
+
+# wait until all background processes finished
+FAIL=0
+
+for job in `jobs -p`
+do
+    echo "waiting for background job $job"
+    wait $job || let "FAIL+=1"
+done
+
+if [ "$FAIL" == "0" ];
+then
+    echo "all downloads finished"
+else
+    echo "$FAIL errors while downloading!"
+    exit 100
+fi 
+
+# Leave this install till after the main parallel package install above
+# since it adds a non-12.04 package repo and we don't want to
+# pull EVERYTHING in, just the newer gcc compiler (and toolchain)
+GCC_VER=4.7
+if [ "x${TRAVIS}" != "x" ]; then
+  GCC_VER=4.8
+fi
+sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
+sudo apt-get -y update
+sudo apt-get -y install gcc-${GCC_VER} g++-${GCC_VER}
+sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${GCC_VER} 60 \
+                         --slave /usr/bin/g++ g++ /usr/bin/g++-${GCC_VER}
+sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.6 40 \
+                         --slave /usr/bin/g++ g++ /usr/bin/g++-4.6
+sudo update-alternatives --set gcc /usr/bin/gcc-${GCC_VER}
+
+# libevent
+cd libevent
+git checkout release-1.4.14b-stable
+cat ../hphp/third_party/libevent-1.4.14.fb-changes.diff | patch -p1
+./autogen.sh
+./configure --prefix=$CMAKE_PREFIX_PATH
+make -j $CPUS
+make install
+cd ..
+
+# curl
+cd curl
+./buildconf
+./configure --prefix=$CMAKE_PREFIX_PATH
+make -j $CPUS
+make install
+cd ..
+
+# glog
+cd google-glog
+./configure --prefix=$CMAKE_PREFIX_PATH
+make -j $CPUS
+make install
+cd ..
+
+# jemaloc
+tar xjvf jemalloc-3.0.0.tar.bz2
+cd jemalloc-3.0.0
+./configure --prefix=$CMAKE_PREFIX_PATH
+make -j $CPUS
+make install
+cd ..
+
+# cleanup
+rm -rf libevent curl google-glog jemalloc-3.0.0.tar.bz2 jemalloc-3.0.0
+
+# hphp
+cmake .
+
+echo "-------------------------------------------------------------------------"
+echo "Done. Now run:"
+echo "  CMAKE_PREFIX_PATH=\`pwd\`/.. make"

hphp/.gitignore

@@ -0,0 +1,26 @@
+# HHVM build results
+*.hhbc
+*.[oa]
+/hhvm/hhvm
+/hhvm/hphp
+
+# vim swapfiles
+.*.swp
+.*.swo
+
+# tags files
+*/tags
+*/TAGS
+
+# logs
+*.log
+
+# git patch files
+*.diff
+
+# OS X
+.DS_Store
+._.DS_Store
+
+# gdb
+.gdb_history

hphp/CMakeLists.txt

@@ -16,58 +16,12 @@
 #
 
 include(HPHPSetup)
+include(FollySetup)
+include(ExtZendCompat)
 
-# HHVM Build
-SET(USE_HHVM TRUE)
-SET(ENV{HHVM} 1)
-ADD_DEFINITIONS("-DHHVM -DHHVM_BINARY=1 -DHHVM_PATH=\\\"${HPHP_HOME}/hphp/hhvm/hhvm\\\"")
+add_definitions("-DHHVM")
 
-set(RECURSIVE_SOURCE_SUBDIRS runtime/base runtime/eval runtime/ext runtime/vm system util)
-foreach (dir ${RECURSIVE_SOURCE_SUBDIRS})
-
-	auto_sources(files "*.cpp" "RECURSE" "${CMAKE_CURRENT_SOURCE_DIR}/${dir}")
-	list(APPEND CXX_SOURCES ${files})
-
-	auto_sources(files "*.c" "RECURSE" "${CMAKE_CURRENT_SOURCE_DIR}/${dir}")
-	list(APPEND C_SOURCES ${files})
-
-endforeach(dir ${RECURSIVE_SOURCE_SUBDIRS})
-
-# Disable hardware counters off of Linux
-if(NOT LINUX)
-	add_definitions(-DNO_HARDWARE_COUNTERS)
-	list(REMOVE_ITEM CXX_SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/runtime/base/hardware_counter.cpp)
-endif()
-
-# remove ext_hhvm, util/tests, and runtime/vm/translator/test
-foreach (file ${CXX_SOURCES})
-       	if (${file} MATCHES "ext_hhvm")
-		list(REMOVE_ITEM CXX_SOURCES ${file})
-	endif()
-	if (${file} MATCHES "util/test")
-		list(REMOVE_ITEM CXX_SOURCES ${file})
-	endif()
-	if (${file} MATCHES "runtime/vm/translator/test")
-		list(REMOVE_ITEM CXX_SOURCES ${file})
-	endif()
-	if (${file} MATCHES "runtime/vm/translator/hopt/test")
-		list(REMOVE_ITEM CXX_SOURCES ${file})
-	endif()
-endforeach(file ${CXX_SOURCES})
-
-# remove ext/sep for hhvm
-foreach (file ${CXX_SOURCES})
-	if (${file} MATCHES "ext/sep")
-		list(REMOVE_ITEM CXX_SOURCES ${file})
-	endif()
-endforeach(file ${CXX_SOURCES})
-
-set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_SOURCE_DIR}/bin")
-set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_SOURCE_DIR}/bin")
-
-if (NOT SKIP_BUNDLED_XHP)
-	add_subdirectory(third_party/xhp/xhp)
-endif()
+add_subdirectory(tools/bootstrap)
 
 add_subdirectory(third_party/libafdt)
 add_subdirectory(third_party/libmbfl)
@@ -76,38 +30,29 @@ add_subdirectory(third_party/timelib)
 add_subdirectory(third_party/lz4)
 add_subdirectory(third_party/double-conversion)
 add_subdirectory(third_party/folly)
+add_subdirectory(third_party/libzip)
+if(ENABLE_FASTCGI)
+	add_subdirectory(third_party/ti)
+	add_subdirectory(third_party/thrift)
+endif()
 
-foreach (CXX_FILE ${CXX_SOURCES})
-	if(${CXX_FILE} MATCHES ".no.cpp$")
-		SET_SOURCE_FILES_PROPERTIES(
-			${CXX_FILE}
-			PROPERTIES
-			COMPILE_FLAGS -O0
-		)
-	endif()
-endforeach()
-
-add_custom_command(
-  OUTPUT runtime/vm/repo_schema.h
-  COMMAND hphp/tools/generate_repo_schema.sh
-  DEPENDS ${CXX_SOURCES} ${C_SOURCES}
-  WORKING_DIRECTORY ${HPHP_HOME}
-  COMMENT "Generating Repo Schema ID"
-  VERBATIM)
-
-ADD_LIBRARY(hphp_runtime_static STATIC runtime/vm/repo_schema.h ${CXX_SOURCES} ${C_SOURCES})
-SET_TARGET_PROPERTIES(hphp_runtime_static PROPERTIES OUTPUT_NAME "hphp_runtime")
-SET_TARGET_PROPERTIES(hphp_runtime_static PROPERTIES PREFIX "lib")
-SET_TARGET_PROPERTIES(hphp_runtime_static PROPERTIES CLEAN_DIRECT_OUTPUT 1)
-
-SET(CMAKE_CXX_ARCHIVE_APPEND "<CMAKE_AR> q <TARGET> <LINK_FLAGS> <OBJECTS>")
-
-hphp_link(hphp_runtime_static)
+add_subdirectory(vixl)
+add_subdirectory(neo)
+add_subdirectory(parser)
+add_subdirectory(zend)
+add_subdirectory(util)
 
+add_subdirectory(hhbbc)
 add_subdirectory(compiler)
+add_subdirectory(runtime)
 add_subdirectory(runtime/ext_hhvm)
+add_subdirectory(system)
+
 add_subdirectory(hhvm)
 
 if (NOT "$ENV{HPHP_NOTEST}" STREQUAL "1")
 	add_subdirectory(test)
 endif ()
+
+# Keep this last
+add_subdirectory(tools/hphpize)

hphp/NEWS

@@ -0,0 +1,226 @@
+"D<something>"
+  - Deleted legacy register allocator and removed the -vEval.HHIRXls option
+
+"Coolio" 21-Jan-2014
+  - Turn on Region JIT
+  - FastCGI fixes, perf improvements
+  - ext_zend_compat fixes
+  - Turn on XLS Register Allocator by default
+  - Fix server stats reporting
+  - 'num' scalar typehint that accepts both ints and floats
+  - fix support for typedef'd namespaces
+  - don't swallow fatals when autoloading
+  - Map collections learned the in-place retain() and retainWithKey()
+  - rename Set::difference() to Set::removeAll()
+  - Update Set to retain element insertion order
+  - remove APC stats
+  - Fixes for ARM mode
+  - FrozenMap collection
+  - Deprecated Vector|Set|Map::put() method removed
+  - == between Frozen{Vector|Set|Map} and {Vector|Set|Map} now can return true
+
+"Beastie Boys" 6-Jan-2014
+  - Support lex-time binary constants (eg. 0b10111)
+  - StreamWrappers now support rmdir, mkdir, rename and unlink
+  - Miscellaneous Zend PHP compatibility fixes
+  - Default StatCache to off
+  - Miscellaneous FastCGI fixes
+  - Miscellaneous region compiler fixes
+  - Map and StableMap collections use the same underlying implementation
+  - Trait requirements enforced
+  - hhprof performance improvements
+  - Add array to string conversion notice
+  - Add RaiseNotice IR opcode
+  - Fix VirtualHost.<name>.Pattern matching
+  - Fix various memory leaks (pdo_parse_params, Gen*WaitHandle)
+  - Import a lot more Zend tests that used to crash or hang
+  - Clean up base.h
+  - XLS register allocation cleanup
+  - Enable region compiler by default for JIT functions in ahot
+  - Fatal on eval() in RepoAuthoritative mode
+  - Enable LTO for HHVM
+  - Fix a few SPL compatibility issues
+
+"Appleseed" 23-Dec-2013
+  - Fix issues with DOCUMENT_ROOT in fastcgi
+  - Better type inference for collections and builtins in repo mode
+  - Shorter syntax for lambda expressions w/ automatic captures
+  - Parser support for trait require clauses
+  - Move FrozenVector and Set to the HH namespace
+  - Fix resource to array conversion
+  - Fix a request local memory leak in foreach of apc arrays
+  - Initial php_odbc API implementation
+  - Implement PHP's hash_copy() function
+  - Experimental tool: Memoization Opportunity Profiler
+  - Various small parity/behavior fixes (in phar, proc_open, filter_var)
+  - A Eval.DumpHhas=1 option to dump hhas for a php file
+  - Better warnings in Set::toArray
+  - Fix the behavior of foreach loops in finally blocks
+  - chmod -x runtime/vm/jit/*.{cpp,h}
+  - Changes to make hhvm build clean with clang-3.4
+  - Fix array_product to not be bug-compatible with PHP 5.2
+  - Change the Map datastructure---preserves order and does faster foreach
+  - FrozenSet collection
+  - Generate pid.map when we unmap text section, for the perf tool
+  - Implemented GlobIterator
+  - Implemented Reflection::export and Reflection::getModifierNames
+
+"Tom Yum" 9-Dec-2013
+  - support date.timezone in ini files
+  - implement fileinfo
+  - special comparisons for DateTime
+  - delete unimplemented functions
+  - support for the finally clause in try blocks
+
+"Huarache" 26-Nov-2013
+  - Linker re-ordering of hot functions
+  - Huge pages for hot functions
+  - Implement ZipArchive
+  - preg_replace /e support
+  - get_mem_usage() no longer can be negative
+  - Userland file system support
+  - Implement fileinfo extension
+  - wordwrap() fixes
+  - PDO::sqliteCreateFunction()
+  - Implement NumberFormatter
+  - Implement Locale
+  - Implement DatePeriod
+  - Many reflection fixes
+  - Stub out PharData
+  - A ton of performance fixes
+  - A ton of open source framework fixes
+  - FastCGI Server Support
+
+"Garlic Alfredo" 11-Nov-2013
+  - teach implode() about collections
+  - fix ini parsing leak
+  - Make array not an instanceof Traversable
+
+"Burrito" 28-Oct-2013
+  - Initial support for using FastCGI
+  - Initial support for php.ini configuration files
+  - Log when a nullable (e.g. ?int) is incorrect
+  - Add support for collections to array_diff, array_diff_key, array_intersect,
+    array_intersect_key
+  - tc-print improvements and fixes
+  - Several debugger fixes
+  - More improvements to the experimental PHP extension compat layer
+  - Fixed how parse errors are handled by eval()
+  - Support custom reason for status header
+  - Emit better error message when hhvm's systemlib doesn't load properly
+  - Fixes / clarifications added to the bytecode specification
+  - Lots of other bug fixes, clean up, PHP compat fixes, and JIT improvements
+
+"Sausage" 14-Oct-2013
+  - Direct invocation of callable arrays: $f = [$cls_or_obj, 'method']; $f()
+  - ASAN clean
+  - Support dynamically loadable extensions
+  - Support loading mini-systemlibs from extensions
+
+"Tabasco" 30-Sep-2013
+  - Fix issues with __toString() functions that return non-string values
+  - Don't allow mock classes to extend collection classes
+  - Smarter memory allocation and scheduling for NUMA systems
+  - Improve profiler performance in the jit
+  - Fix several Zend compatibility issues
+  - Fix several bugs uncovered by ASAN
+  - Add collection support to array_keys, array_values, and array_combine
+  - Return a set-like array from Set::toArray
+  - Add to(Vector|Map|StableMap|Set) methods to collections
+  - Collections convert to boolean false when empty
+  - get_class_vars invokes the autoloader when necessary
+  - Rework the Zend compatibility layer to be more robust
+  - Allow traits to implement interfaces
+  - Support arbitrary expressions inside empty()
+
+"Bobotie" 16-Sep-2013
+  - HNI (HipHop Native Interface) for calling C++ functions from PHP
+  - Fix PropertyAccessorMap::isset
+  - Expose more POSIX constants
+  - Fixed behavior of stream_get_contents when default args are used.
+  - Implement str_getcsv, and fix some fgetcsv related issues.
+  - [IPv6] Fix stream_socket_recvfrom & stream_socket_sendto.
+  - [IPv6] Fix socket_sentto_recvfrom_ipv6_udp Zend compatibility.
+  - Optimize closure invocation and __invoke (~3x faster to invoke)
+  - Import gettext extension
+  - string and object allocation optimizations (reduced memory usage for both)
+  - Import YAML extension
+  - Import ftp extension
+
+"Kimchi" 2-Sep-2013
+  - Fix order of custom attributes and visibility in ctor arg promotion
+  - Implement CachingIterator
+  - Implement RecursiveCachingIterator
+  - Generalized heuristic for choosing when to inline in the jit
+  - Introduced a Zend compatibility layer to compile extensions
+  - Imported calendar extension
+  - Use gcc-4.8.1 by default
+  - Improve hhvm command line parsing logic
+  - Fix register_shutdown in session_set_save_handler to match PHP 5.4
+  - Add "native" functions for use in Systemlib
+  - PHP extension source-compatitblility layer
+  - Fix ArrayIterator constructor PHP compatibility
+  - Enable building against libmemcached 1.0.8
+  - Debugger: $_ not cleared but still printed after exception
+  - Fix clone of SplPriorityQueue
+  - Debugger: Fix bugs when multiple threads hit the same breakpoint
+  - Fix several namespace bugs
+  - Several PHP compatibility fixes for ArrayObject and ArrayIterator
+  - Fix list assignment with collection literals
+  - support "tuple(...)" in initializer expressions
+  - HHVM should compile with libmemcached 1.0.9+
+  - Support "(new Vector {..})->method()" style syntax
+  - use trigger_error in PHP for Redis user errors
+  - multiple simplexml fixes
+  - fixed serialize/unserialize for SplObjectStorage
+  - Implement ReflectionParameter::IsCallable()
+
+"Achiote" 19-Aug-2013
+  - Async stack traces in the debugger via the "wa" command
+  - Fix late static binding in static closures
+  - Fix breakpoints on generators
+  - Add SplObserver and SplSubject interfaces
+  - Update Iterable interface and add toArray() method
+  - Allow __get for undefined properties
+  - Implement get_included_files()
+  - Limit use of huge pages
+
+"Churrasco" 05-Aug-2013
+  - Implement stream_is_local
+  - Implement read support for .phar
+  - Implement assert with string arguments
+  - Implement RecursiveArrayIterator
+  - Implement php_strip_whitespace()
+  - Support for timeouts in cli mode
+  - Closure allocation optimizations (~2x faster to allocate a closure)
+  - Implement Redis session handler
+  - New memory profiler, hhprof, with pprof compatible output
+  - Update isset($string[$k]) and empty($string[$k) to PHP 5.5 semantics
+  - Fixed a few parser bugs
+  - Fixed a few bugs with token_get_all()
+  - Fix (string)$obj semantics when __toString() is not defined
+
+"Tamale" 22-Jul-2013
+  - Optimize vector-shaped Arrays (arrays with keys in range 0..size-1)
+  - Enable HHBC by default in debug builds
+  - Implement SplObjectStorage::getInfo()
+  - Initial rough draft of xhpast2, a replacement for xhpast
+  - fix compilation on Ubuntu 13.04
+  - OSX changes, next round
+  - Modify PHP's ext/standard/math/tests/(pow|abs).phpt to be HHVM friendly
+  - add XHP comment syntax based on http://www.w3.org/TR/REC-xml/#sec-comments
+
+"Wasabi Peas" 08-Jul-2013
+  - always_assert when we run out of TC space
+  - Initial changes to get HHVM compiling on OSX
+  - Consolidate ObjectData and Instance
+  - Prototype heap tracing framework & Heap profiler
+  - Better JIT code generation for Mod and Div
+  - Fixes to enable compilation with clang
+  - Support for yield k => v
+  - Make HHVM's command line parsing closer to PHP
+  - Implement Redis extension
+  - Implement LimitIterator from SPL
+  - add SessionHandler from PHP 5.4
+  - Numerous Debugger fixes and new developer docs for Debugger
+  - Ported many extension tests to PHP

hphp/compiler/CMakeLists.txt

@@ -49,3 +49,4 @@ add_definitions(-DALWAYS_ASSERT=1)
 
 ADD_LIBRARY(hphp_analysis STATIC ${CXX_SOURCES} ${C_SOURCES})
 target_link_libraries(hphp_analysis ${Boost_LIBRARIES})
+add_dependencies(hphp_analysis hphp_parser)

hphp/compiler/analysis/alias_manager.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,10 +14,10 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __ALIAS_MANAGER_H__
-#define __ALIAS_MANAGER_H__
+#ifndef incl_HPHP_ALIAS_MANAGER_H_
+#define incl_HPHP_ALIAS_MANAGER_H_
 
-#include <compiler/expression/expression.h>
+#include "hphp/compiler/expression/expression.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -88,7 +88,7 @@ class AliasManager {
   enum { SameAccess, SameLValueAccess, InterfAccess,
     DisjointAccess, NotAccess };
 
-  AliasManager(int opt);
+  explicit AliasManager(int opt);
   ~AliasManager();
 
   void clear();
@@ -141,7 +141,7 @@ class AliasManager {
   enum { FallThrough, CondBranch, Branch, Converge };
   enum { NoCopyProp = 1, NoDeadStore = 2 };
   struct CondStackElem {
-    CondStackElem(size_t s = 0) : m_size(s), m_exprs() {}
+    explicit CondStackElem(size_t s = 0) : m_size(s), m_exprs() {}
     size_t              m_size;
     ExpressionPtrList   m_exprs;
   };
@@ -154,7 +154,7 @@ class AliasManager {
 
   class LoopInfo {
   public:
-    LoopInfo(StatementPtr s);
+    explicit LoopInfo(StatementPtr s);
 
     StatementPtr m_stmt;
     StatementPtrVec m_inner;
@@ -205,7 +205,7 @@ class AliasManager {
   StatementPtr canonicalizeRecur(StatementPtr e, int &ret);
 
   void invalidateChainRoots(StatementPtr s);
-  void nullSafeDisableCSE(StatementPtr parent, int kid);
+  void nullSafeDisableCSE(StatementPtr parent, ExpressionPtr kid);
   void disableCSE(StatementPtr s);
   void createCFG(MethodStatementPtr m);
   void deleteCFG();
@@ -276,4 +276,4 @@ class AliasManager {
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __ALIAS_MANAGER_H__
+#endif // incl_HPHP_ALIAS_MANAGER_H_

hphp/compiler/analysis/analysis_result.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,45 +14,48 @@
    +----------------------------------------------------------------------+
 */
 
+#include "hphp/compiler/analysis/analysis_result.h"
+
 #include <iomanip>
 #include <algorithm>
 #include <sstream>
 #include <boost/format.hpp>
 #include <boost/bind.hpp>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/alias_manager.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/depth_first_visitor.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/statement/if_branch_statement.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/loop_statement.h>
-#include <compiler/statement/class_variable.h>
-#include <compiler/statement/use_trait_statement.h>
-#include <compiler/analysis/symbol_table.h>
-#include <compiler/package.h>
-#include <compiler/parser/parser.h>
-#include <compiler/option.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/builtin_symbols.h>
-#include <compiler/analysis/constant_table.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/expression/scalar_expression.h>
-#include <compiler/expression/constant_expression.h>
-#include <compiler/expression/expression_list.h>
-#include <compiler/expression/array_pair_expression.h>
-#include <runtime/ext/ext_json.h>
-#include <runtime/base/zend/zend_printf.h>
-#include <runtime/base/program_functions.h>
-#include <util/atomic.h>
-#include <util/logger.h>
-#include <util/util.h>
-#include <util/hash.h>
-#include <util/process.h>
-#include <util/job_queue.h>
-#include <util/timer.h>
+#include "hphp/compiler/analysis/alias_manager.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/depth_first_visitor.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/statement/if_branch_statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/loop_statement.h"
+#include "hphp/compiler/statement/class_variable.h"
+#include "hphp/compiler/statement/use_trait_statement.h"
+#include "hphp/compiler/statement/trait_require_statement.h"
+#include "hphp/compiler/analysis/symbol_table.h"
+#include "hphp/compiler/package.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/builtin_symbols.h"
+#include "hphp/compiler/analysis/constant_table.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/expression/scalar_expression.h"
+#include "hphp/compiler/expression/constant_expression.h"
+#include "hphp/compiler/expression/expression_list.h"
+#include "hphp/compiler/expression/array_pair_expression.h"
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/runtime/ext/ext_json.h"
+#include "hphp/runtime/base/zend-printf.h"
+#include "hphp/runtime/base/program-functions.h"
+#include "hphp/util/atomic.h"
+#include "hphp/util/logger.h"
+#include "hphp/util/util.h"
+#include "hphp/util/hash.h"
+#include "hphp/util/process.h"
+#include "hphp/util/job-queue.h"
+#include "hphp/util/timer.h"
 
 using namespace HPHP;
 using std::map;
@@ -157,6 +160,10 @@ void AnalysisResult::parseOnDemandBy(const string &name,
   }
 }
 
+void AnalysisResult::addNSFallbackFunc(ConstructPtr c, FileScopePtr fs) {
+  m_nsFallbackFuncs.insert(std::make_pair(c, fs));
+}
+
 FileScopePtr AnalysisResult::findFileScope(const std::string &name) const {
   StringToFileScopePtrMap::const_iterator iter = m_files.find(name);
   if (iter != m_files.end()) {
@@ -169,7 +176,7 @@ FunctionScopePtr AnalysisResult::findFunction(
   const std::string &funcName) const {
   StringToFunctionScopePtrMap::const_iterator bit =
     m_functions.find(funcName);
-  if (bit != m_functions.end()) {
+  if (bit != m_functions.end() && !bit->second->allowOverride()) {
     return bit->second;
   }
   StringToFunctionScopePtrMap::const_iterator iter =
@@ -177,7 +184,7 @@ FunctionScopePtr AnalysisResult::findFunction(
   if (iter != m_functionDecs.end()) {
     return iter->second;
   }
-  return FunctionScopePtr();
+  return bit != m_functions.end() ? bit->second : FunctionScopePtr();
 }
 
 BlockScopePtr AnalysisResult::findConstantDeclarer(
@@ -235,8 +242,8 @@ ClassScopePtr AnalysisResult::findClass(const std::string &name,
   return ClassScopePtr();
 }
 
-const ClassScopePtrVec &AnalysisResult::findRedeclaredClasses
-(const std::string &name) const {
+const ClassScopePtrVec &
+AnalysisResult::findRedeclaredClasses(const std::string &name) const {
   StringToClassScopePtrVecMap::const_iterator iter = m_classDecs.find(name);
   if (iter == m_classDecs.end()) {
     static ClassScopePtrVec empty;
@@ -343,11 +350,14 @@ bool AnalysisResult::declareFunction(FunctionScopePtr funcScope) const {
 
   string fname = funcScope->getName();
   // System functions override
-  if (m_functions.find(fname) != m_functions.end()) {
-    // we need someone to hold on to a reference to it
-    // even though we're not going to do anything with it
-    this->lock()->m_ignoredScopes.push_back(funcScope);
-    return false;
+  auto it = m_functions.find(fname);
+  if (it != m_functions.end()) {
+    if (!it->second->allowOverride()) {
+      // we need someone to hold on to a reference to it
+      // even though we're not going to do anything with it
+      this->lock()->m_ignoredScopes.push_back(funcScope);
+      return false;
+    }
   }
 
   return true;
@@ -399,7 +409,9 @@ static bool by_source(const BlockScopePtr &b1, const BlockScopePtr &b2) {
 void AnalysisResult::canonicalizeSymbolOrder() {
   getConstants()->canonicalizeSymbolOrder();
   getVariables()->canonicalizeSymbolOrder();
+}
 
+void AnalysisResult::markRedeclaringClasses() {
   AnalysisResultPtr ar = shared_from_this();
   for (StringToClassScopePtrVecMap::iterator iter = m_classDecs.begin();
        iter != m_classDecs.end(); ++iter) {
@@ -411,6 +423,56 @@ void AnalysisResult::canonicalizeSymbolOrder() {
       }
     }
   }
+
+  auto markRedeclaring = [&] (const std::string& name) {
+    auto it = m_classDecs.find(name);
+    if (it != m_classDecs.end()) {
+      auto& classes = it->second;
+      for (unsigned int i = 0; i < classes.size(); ++i) {
+        classes[i]->setRedeclaring(ar, i);
+      }
+    }
+  };
+
+  /*
+   * In WholeProgram mode, during parse time we collected all
+   * class_alias calls so we can mark the targets of such calls
+   * redeclaring if necessary.
+   *
+   * Two cases here that definitely require this:
+   *
+   *  - If an alias name has the same name as another class, we need
+   *    to mark *that* class as redeclaring, since it may mean
+   *    different things in different requests now.
+   *
+   *  - If an alias name can refer to more than one class, each of
+   *    those classes must be marked redeclaring.
+   *
+   * In the simple case of a unique alias name and a unique target
+   * name, we might be able to get away with manipulating the target
+   * classes' volatility.
+   *
+   * Rather than work through the various cases here, though, we've
+   * just decided to just play it safe and mark all the names involved
+   * as redeclaring for now.
+   */
+  for (auto& kv : m_classAliases) {
+    assert(kv.first == Util::toLower(kv.first));
+    assert(kv.second == Util::toLower(kv.second));
+    markRedeclaring(kv.first);
+    markRedeclaring(kv.second);
+  }
+
+  /*
+   * Similar to class_alias, when a type alias is declared with the
+   * same name as a class in the program, we need to make sure the
+   * class is marked redeclaring.  It is possible in some requests
+   * that things like 'instanceof Foo' will not mean the same thing.
+   */
+  for (auto& name : m_typeAliasNames) {
+    assert(Util::toLower(name) == name);
+    markRedeclaring(name);
+  }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -427,8 +489,7 @@ void AnalysisResult::link(FileScopePtr user, FileScopePtr provider) {
 
 bool AnalysisResult::addClassDependency(FileScopePtr usingFile,
                                         const std::string &className) {
-  if (BuiltinSymbols::s_classes.find(className) !=
-      BuiltinSymbols::s_classes.end())
+  if (m_systemClasses.find(className) != m_systemClasses.end())
     return true;
 
   StringToClassScopePtrVecMap::const_iterator iter =
@@ -446,8 +507,7 @@ bool AnalysisResult::addClassDependency(FileScopePtr usingFile,
 
 bool AnalysisResult::addFunctionDependency(FileScopePtr usingFile,
                                            const std::string &functionName) {
-  if (BuiltinSymbols::s_functions.find(functionName) !=
-      BuiltinSymbols::s_functions.end())
+  if (m_functions.find(functionName) != m_functions.end())
     return true;
   StringToFunctionScopePtrMap::const_iterator iter =
     m_functionDecs.find(functionName);
@@ -509,17 +569,16 @@ bool AnalysisResult::isSystemConstant(const std::string &constName) const {
 ///////////////////////////////////////////////////////////////////////////////
 // Program
 
-void AnalysisResult::loadBuiltinFunctions() {
-  AnalysisResultPtr ar = shared_from_this();
-  BuiltinSymbols::LoadFunctions(ar, m_functions);
+void AnalysisResult::addSystemFunction(FunctionScopeRawPtr fs) {
+  FunctionScopePtr& entry = m_functions[fs->getName()];
+  assert(!entry);
+  entry = fs;
 }
 
-void AnalysisResult::loadBuiltins() {
-  AnalysisResultPtr ar = shared_from_this();
-  BuiltinSymbols::LoadFunctions(ar, m_functions);
-  BuiltinSymbols::LoadClasses(ar, m_systemClasses);
-  BuiltinSymbols::LoadVariables(ar, m_variables);
-  BuiltinSymbols::LoadConstants(ar, m_constants);
+void AnalysisResult::addSystemClass(ClassScopeRawPtr cs) {
+  ClassScopePtr& entry = m_systemClasses[cs->getName()];
+  assert(!entry);
+  entry = cs;
 }
 
 void AnalysisResult::checkClassDerivations() {
@@ -530,30 +589,49 @@ void AnalysisResult::checkClassDerivations() {
     BOOST_FOREACH(cls, iter->second) {
       hphp_string_iset seen;
       cls->checkDerivation(ar, seen);
-      if (Option::WholeProgram || !Option::OutputHHBC) {
-        cls->importUsedTraits(ar);
+      if (Option::WholeProgram) {
+        try {
+          cls->importUsedTraits(ar);
+        } catch (const AnalysisTimeFatalException& e) {
+          cls->setFatal(e);
+        }
       }
     }
   }
 }
 
-void AnalysisResult::collectFunctionsAndClasses(FileScopePtr fs) {
-  const StringToFunctionScopePtrMap &funcs = fs->getFunctions();
+void AnalysisResult::resolveNSFallbackFuncs() {
+  for (auto &pair : m_nsFallbackFuncs) {
+    SimpleFunctionCallPtr sfc =
+      static_pointer_cast<SimpleFunctionCall>(pair.first);
+    sfc->resolveNSFallbackFunc(
+      shared_from_this(),
+      pair.second
+    );
+  }
+}
 
-  for (StringToFunctionScopePtrMap::const_iterator iter = funcs.begin();
-       iter != funcs.end(); ++iter) {
-    FunctionScopePtr func = iter->second;
+void AnalysisResult::collectFunctionsAndClasses(FileScopePtr fs) {
+  for (const auto& iter : fs->getFunctions()) {
+    FunctionScopePtr func = iter.second;
     if (!func->inPseudoMain()) {
-      FunctionScopePtr &funcDec = m_functionDecs[iter->first];
+      FunctionScopePtr &funcDec = m_functionDecs[iter.first];
       if (funcDec) {
-        FunctionScopePtrVec &funcVec = m_functionReDecs[iter->first];
-        int sz = funcVec.size();
-        if (!sz) {
-          funcDec->setRedeclaring(sz++);
-          funcVec.push_back(funcDec);
+        if (funcDec->isSystem()) {
+          assert(funcDec->allowOverride());
+          funcDec = func;
+        } else if (func->isSystem()) {
+          assert(func->allowOverride());
+        } else {
+          FunctionScopePtrVec &funcVec = m_functionReDecs[iter.first];
+          int sz = funcVec.size();
+          if (!sz) {
+            funcDec->setRedeclaring(sz++);
+            funcVec.push_back(funcDec);
+          }
+          func->setRedeclaring(sz++);
+          funcVec.push_back(func);
         }
-        func->setRedeclaring(sz++);
-        funcVec.push_back(func);
       } else {
         funcDec = func;
       }
@@ -561,13 +639,12 @@ void AnalysisResult::collectFunctionsAndClasses(FileScopePtr fs) {
   }
 
   if (const StringToFunctionScopePtrVecMap *redec = fs->getRedecFunctions()) {
-    for (StringToFunctionScopePtrVecMap::const_iterator iter = redec->begin();
-         iter != redec->end(); ++iter) {
-      FunctionScopePtrVec::const_iterator i = iter->second.begin();
-      FunctionScopePtrVec::const_iterator e = iter->second.end();
-      FunctionScopePtr &funcDec = m_functionDecs[iter->first];
+    for (const auto &iter : *redec) {
+      FunctionScopePtrVec::const_iterator i = iter.second.begin();
+      FunctionScopePtrVec::const_iterator e = iter.second.end();
+      FunctionScopePtr &funcDec = m_functionDecs[iter.first];
       assert(funcDec); // because the first one was in funcs above
-      FunctionScopePtrVec &funcVec = m_functionReDecs[iter->first];
+      FunctionScopePtrVec &funcVec = m_functionReDecs[iter.first];
       int sz = funcVec.size();
       if (!sz) {
         funcDec->setRedeclaring(sz++);
@@ -580,12 +657,15 @@ void AnalysisResult::collectFunctionsAndClasses(FileScopePtr fs) {
     }
   }
 
-  const StringToClassScopePtrVecMap &classes = fs->getClasses();
-  for (StringToClassScopePtrVecMap::const_iterator iter = classes.begin();
-       iter != classes.end(); ++iter) {
-    ClassScopePtrVec &clsVec = m_classDecs[iter->first];
-    clsVec.insert(clsVec.end(), iter->second.begin(), iter->second.end());
+  for (const auto& iter : fs->getClasses()) {
+    ClassScopePtrVec &clsVec = m_classDecs[iter.first];
+    clsVec.insert(clsVec.end(), iter.second.begin(), iter.second.end());
   }
+
+  m_classAliases.insert(fs->getClassAliases().begin(),
+                        fs->getClassAliases().end());
+  m_typeAliasNames.insert(fs->getTypeAliasNames().begin(),
+                          fs->getTypeAliasNames().end());
 }
 
 static bool by_filename(const FileScopePtr &f1, const FileScopePtr &f2) {
@@ -611,6 +691,8 @@ void AnalysisResult::analyzeProgram(bool system /* = false */) {
   // Keep generated code identical without randomness
   canonicalizeSymbolOrder();
 
+  markRedeclaringClasses();
+
   // Analyze some special cases
   for (set<string>::const_iterator it = Option::VolatileClasses.begin();
        it != Option::VolatileClasses.end(); ++it) {
@@ -621,6 +703,7 @@ void AnalysisResult::analyzeProgram(bool system /* = false */) {
   }
 
   checkClassDerivations();
+  resolveNSFallbackFuncs();
 
   // Analyze All
   Logger::Verbose("Analyzing All");
@@ -660,7 +743,7 @@ void AnalysisResult::analyzeProgram(bool system /* = false */) {
     for (StringToFunctionScopePtrMap::const_iterator iterMethod =
            methods.begin(); iterMethod != methods.end(); ++iterMethod) {
       FunctionScopePtr func = iterMethod->second;
-      if (!func->hasImpl() && needAbstractMethodImpl) {
+      if (Option::WholeProgram && !func->hasImpl() && needAbstractMethodImpl) {
         FunctionScopePtr tmpFunc =
           cls->findFunction(ar, func->getName(), true, true);
         always_assert(!tmpFunc || !tmpFunc->hasImpl());
@@ -779,8 +862,14 @@ void AnalysisResult::analyzeProgramFinal() {
   for (uint i = 0; i < m_fileScopes.size(); i++) {
     m_fileScopes[i]->analyzeProgram(ar);
   }
+
   // Keep generated code identical without randomness
   canonicalizeSymbolOrder();
+
+  // XXX: this is only here because canonicalizeSymbolOrder used to do
+  // it---is it necessary to repeat at this phase?  (Probably not ...)
+  markRedeclaringClasses();
+
   setPhase(AnalysisResult::CodeGen);
 }
 
@@ -853,9 +942,11 @@ struct OptVisitor {
   OptVisitor(AnalysisResultPtr ar, unsigned nscope) :
       m_ar(ar), m_nscope(nscope), m_dispatcher(0) {
   }
-  OptVisitor(const Visitor &po) : m_ar(po.m_ar),
-                                  m_nscope(po.m_nscope),
-                                  m_dispatcher(po.m_dispatcher) {
+  /* implicit */ OptVisitor(const Visitor &po)
+    : m_ar(po.m_ar)
+    , m_nscope(po.m_nscope)
+    , m_dispatcher(po.m_dispatcher)
+  {
     const_cast<Visitor&>(po).m_dispatcher = 0;
   }
   ~OptVisitor() {
@@ -884,11 +975,14 @@ struct OptVisitor {
 
   AnalysisResultPtr m_ar;
   unsigned m_nscope;
-  JobQueueDispatcher<BlockScope *, OptWorker<When> > *m_dispatcher;
+  JobQueueDispatcher<OptWorker<When>> *m_dispatcher;
 };
 
 template <typename When>
-class OptWorker : public JobQueueWorker<BlockScope *, true, true> {
+class OptWorker : public JobQueueWorker<BlockScope*,
+                                        void*,
+                                        true,
+                                        true> {
 public:
   OptWorker() {}
 
@@ -900,15 +994,15 @@ public:
 
   virtual void doJob(BlockScope *scope) {
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-    atomic_inc(AnalysisResult::s_NumDoJobCalls);
+    ++AnalysisResult::s_NumDoJobCalls;
     ConcurrentBlockScopeRawPtrIntHashMap::accessor acc;
     AnalysisResult::s_DoJobUniqueScopes.insert(acc,
       BlockScopeRawPtr(scope));
     acc->second += 1;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
     try {
-      DepthFirstVisitor<When, OptVisitor > *visitor =
-        (DepthFirstVisitor<When, OptVisitor >*)m_opaque;
+      auto visitor =
+        (DepthFirstVisitor<When, OptVisitor>*) m_context;
       {
         Lock ldep(BlockScope::s_depsMutex);
         Lock lstate(BlockScope::s_jobStateMutex);
@@ -960,13 +1054,13 @@ public:
                 break;
               case BlockScope::MarkProcessing:
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-                atomic_inc(AnalysisResult::s_NumForceRerunGlobal);
+                ++AnalysisResult::s_NumForceRerunGlobal;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
                 pf->first->setForceRerun(true);
                 break;
               case BlockScope::MarkProcessed:
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-                atomic_inc(AnalysisResult::s_NumReactivateGlobal);
+                ++AnalysisResult::s_NumReactivateGlobal;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
                 if (visitor->activateScope(pf->first)) {
                   visitor->enqueue(pf->first);
@@ -1002,7 +1096,7 @@ public:
               int m = pf->first->getMark();
               if (pf->second & useKinds && m == BlockScope::MarkProcessed) {
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-                atomic_inc(AnalysisResult::s_NumReactivateUseKinds);
+                ++AnalysisResult::s_NumReactivateUseKinds;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
                 bool ready = visitor->activateScope(pf->first);
                 always_assert(!ready);
@@ -1026,7 +1120,7 @@ public:
                 // in its entirety. Thus, we must force it to run again in
                 // order to be able to observe all the updates.
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-                atomic_inc(AnalysisResult::s_NumForceRerunUseKinds);
+                ++AnalysisResult::s_NumForceRerunUseKinds;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
                 always_assert(pf->first->getNumDepsToWaitFor() == 0);
                 pf->first->setForceRerun(true);
@@ -1071,12 +1165,12 @@ typedef   OptWorker<Post>          PostOptWorker;
 
 template<>
 void OptWorker<Pre>::onThreadEnter() {
-  if (!Option::SystemGen) hphp_session_init();
+  hphp_session_init();
 }
 
 template<>
 void OptWorker<Pre>::onThreadExit() {
-  if (!Option::SystemGen) hphp_session_exit();
+  hphp_session_exit();
 }
 
 /**
@@ -1097,7 +1191,7 @@ void OptWorker<Pre>::onThreadExit() {
     } \
     if (threadCount <= 0) threadCount = 1; \
     this->m_data.m_dispatcher = \
-      new JobQueueDispatcher<BlockScope *, worker >( \
+      new JobQueueDispatcher<worker>( \
         threadCount, true, 0, false, this); \
   } while (0)
 
@@ -1142,7 +1236,7 @@ template <typename When>
 void
 AnalysisResult::preWaitCallback(bool first,
                                 const BlockScopeRawPtrQueue &scopes,
-                                void *opaque) {
+                                void *context) {
   // default is no-op
 }
 
@@ -1151,17 +1245,17 @@ bool
 AnalysisResult::postWaitCallback(bool first,
                                  bool again,
                                  const BlockScopeRawPtrQueue &scopes,
-                                 void *opaque) {
+                                 void *context) {
   // default is no-op
   return again;
 }
 
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-int AnalysisResult::s_NumDoJobCalls         = 0;
-int AnalysisResult::s_NumForceRerunGlobal   = 0;
-int AnalysisResult::s_NumReactivateGlobal   = 0;
-int AnalysisResult::s_NumForceRerunUseKinds = 0;
-int AnalysisResult::s_NumReactivateUseKinds = 0;
+std::atomic<int> AnalysisResult::s_NumDoJobCalls(0);
+std::atomic<int> AnalysisResult::s_NumForceRerunGlobal(0);
+std::atomic<int> AnalysisResult::s_NumReactivateGlobal(0);
+std::atomic<int> AnalysisResult::s_NumForceRerunUseKinds(0);
+std::atomic<int> AnalysisResult::s_NumReactivateUseKinds(0);
 
 ConcurrentBlockScopeRawPtrIntHashMap
   AnalysisResult::s_DoJobUniqueScopes;
@@ -1216,7 +1310,7 @@ struct BIPairCmp {
 template <typename When>
 void
 AnalysisResult::processScopesParallel(const char *id,
-                                      void *opaque /* = NULL */) {
+                                      void *context /* = NULL */) {
   BlockScopeRawPtrQueue scopes;
   getScopesSet(scopes);
 
@@ -1253,7 +1347,7 @@ AnalysisResult::processScopesParallel(const char *id,
 
     BlockScopeRawPtrQueue enqueued;
     again = dfv.visitParallel(scopes, first, enqueued);
-    preWaitCallback<When>(first, scopes, opaque);
+    preWaitCallback<When>(first, scopes, context);
 
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
     {
@@ -1307,7 +1401,7 @@ AnalysisResult::processScopesParallel(const char *id,
     std::cout << "Number of waiting scopes: " << numWaiting << std::endl;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
 
-    again = postWaitCallback<When>(first, again, scopes, opaque);
+    again = postWaitCallback<When>(first, again, scopes, context);
     first = false;
   } while (again);
   dfv.data().stop();
@@ -1436,7 +1530,7 @@ DepthFirstVisitor<InferTypes, OptVisitor>::visitScope(BlockScopeRawPtr scope) {
         // there are potentially AST nodes which are interested in the updated
         // return type
 #ifdef HPHP_INSTRUMENT_TYPE_INF
-        atomic_inc(RescheduleException::s_NumForceRerunSelfCaller);
+        ++RescheduleException::s_NumForceRerunSelfCaller;
 #endif /* HPHP_INSTRUMENT_TYPE_INF */
         scope->setForceRerun(true);
       }
@@ -1453,7 +1547,7 @@ DepthFirstVisitor<InferTypes, OptVisitor>::visitScope(BlockScopeRawPtr scope) {
     // potential deadlock detected- reschedule
     // this scope to run at a later time
 #ifdef HPHP_INSTRUMENT_TYPE_INF
-    atomic_inc(RescheduleException::s_NumReschedules);
+    ++RescheduleException::s_NumReschedules;
 #endif /* HPHP_INSTRUMENT_TYPE_INF */
     ret |= scope->getUpdated();
     if (m) {
@@ -1479,7 +1573,8 @@ DepthFirstVisitor<InferTypes, OptVisitor>::visitScope(BlockScopeRawPtr scope) {
 
 template<>
 bool AnalysisResult::postWaitCallback<InferTypes>(
-    bool first, bool again, const BlockScopeRawPtrQueue &scopes, void *opaque) {
+    bool first, bool again,
+    const BlockScopeRawPtrQueue &scopes, void *context) {
 
 #ifdef HPHP_INSTRUMENT_TYPE_INF
   std::cout << "Number of rescheduled: " <<
@@ -1510,9 +1605,9 @@ bool AnalysisResult::postWaitCallback<InferTypes>(
 }
 
 #ifdef HPHP_INSTRUMENT_TYPE_INF
-int RescheduleException::s_NumReschedules          = 0;
-int RescheduleException::s_NumForceRerunSelfCaller = 0;
-int RescheduleException::s_NumRetTypesChanged      = 0;
+std::atomic<int> RescheduleException::s_NumReschedules(0);
+std::atomic<int> RescheduleException::s_NumForceRerunSelfCaller(0);
+std::atomic<int> RescheduleException::s_NumRetTypesChanged(0);
 LProfileMap BaseTryLock::s_LockProfileMap;
 #endif /* HPHP_INSTRUMENT_TYPE_INF */
 
@@ -1521,12 +1616,10 @@ void AnalysisResult::inferTypes() {
   BlockScopeRawPtrQueue scopes;
   getScopesSet(scopes);
 
-  for (BlockScopeRawPtrQueue::iterator
-       it = scopes.begin(), end = scopes.end();
-       it != end; ++it) {
-    (*it)->setInTypeInference(true);
-    (*it)->clearUpdated();
-    assert((*it)->getNumDepsToWaitFor() == 0);
+  for (auto scope : scopes) {
+    scope->setInTypeInference(true);
+    scope->clearUpdated();
+    assert(scope->getNumDepsToWaitFor() == 0);
   }
 
 #ifdef HPHP_INSTRUMENT_TYPE_INF
@@ -1537,13 +1630,11 @@ void AnalysisResult::inferTypes() {
 
   processScopesParallel<InferTypes>("InferTypes");
 
-  for (BlockScopeRawPtrQueue::iterator
-       it = scopes.begin(), end = scopes.end();
-       it != end; ++it) {
-    (*it)->setInTypeInference(false);
-    (*it)->clearUpdated();
-    assert((*it)->getMark() == BlockScope::MarkProcessed);
-    assert((*it)->getNumDepsToWaitFor() == 0);
+  for (auto scope : scopes) {
+    scope->setInTypeInference(false);
+    scope->clearUpdated();
+    assert(scope->getMark() == BlockScope::MarkProcessed);
+    assert(scope->getNumDepsToWaitFor() == 0);
   }
 }
 
@@ -1585,12 +1676,12 @@ StatementPtr DepthFirstVisitor<Post, OptVisitor>::visit(StatementPtr stmt) {
   return stmt->postOptimize(this->m_data.m_ar);
 }
 
-class FinalWorker : public JobQueueWorker<MethodStatementPtr> {
+class FinalWorker : public JobQueueWorker<MethodStatementPtr, AnalysisResult*> {
 public:
   virtual void doJob(MethodStatementPtr m) {
     try {
       AliasManager am(1);
-      am.finalSetup(((AnalysisResult*)m_opaque)->shared_from_this(), m);
+      am.finalSetup(m_context->shared_from_this(), m);
     } catch (Exception &e) {
       Logger::Error("%s", e.getMessage().c_str());
     }
@@ -1599,11 +1690,11 @@ public:
 
 template<>
 void AnalysisResult::preWaitCallback<Post>(
-    bool first, const BlockScopeRawPtrQueue &scopes, void *opaque) {
-  assert(!Option::ControlFlow || opaque != nullptr);
+    bool first, const BlockScopeRawPtrQueue &scopes, void *context) {
+  assert(!Option::ControlFlow || context != nullptr);
   if (first && Option::ControlFlow) {
-    JobQueueDispatcher<FinalWorker::JobType, FinalWorker> *dispatcher
-      = (JobQueueDispatcher<FinalWorker::JobType, FinalWorker> *) opaque;
+    auto *dispatcher
+      = (JobQueueDispatcher<FinalWorker> *) context;
     for (BlockScopeRawPtrQueue::const_iterator it = scopes.begin(),
            end = scopes.end(); it != end; ++it) {
       BlockScopeRawPtr scope = *it;
@@ -1627,7 +1718,7 @@ void AnalysisResult::postOptimize() {
     }
     if (threadCount <= 0) threadCount = 1;
 
-    JobQueueDispatcher<FinalWorker::JobType, FinalWorker> dispatcher(
+    JobQueueDispatcher<FinalWorker> dispatcher(
       threadCount, true, 0, false, this);
 
     processScopesParallel<Post>("PostOptimize", &dispatcher);

hphp/compiler/analysis/analysis_result.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,19 +14,20 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __ANALYSIS_RESULT_H__
-#define __ANALYSIS_RESULT_H__
+#ifndef incl_HPHP_ANALYSIS_RESULT_H_
+#define incl_HPHP_ANALYSIS_RESULT_H_
 
-#include <compiler/code_generator.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/option.h>
-#include <compiler/analysis/block_scope.h>
-#include <compiler/analysis/symbol_table.h>
-#include <compiler/analysis/function_container.h>
-#include <compiler/package.h>
+#include "hphp/compiler/code_generator.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/analysis/block_scope.h"
+#include "hphp/compiler/analysis/symbol_table.h"
+#include "hphp/compiler/analysis/function_container.h"
+#include "hphp/compiler/package.h"
+#include "hphp/compiler/hphp.h"
 
-#include <util/string_bag.h>
-#include <util/thread_local.h>
+#include "hphp/util/string-bag.h"
+#include "hphp/util/thread-local.h"
 
 #include <boost/graph/adjacency_list.hpp>
 #include <tbb/concurrent_hash_map.h>
@@ -36,7 +37,7 @@ namespace HPHP {
 
 
 DECLARE_BOOST_TYPES(ClassScope);
-DECLARE_BOOST_TYPES(FileScope);
+DECLARE_EXTENDED_BOOST_TYPES(FileScope);
 DECLARE_BOOST_TYPES(FunctionScope);
 DECLARE_BOOST_TYPES(Location);
 DECLARE_BOOST_TYPES(AnalysisResult);
@@ -91,12 +92,12 @@ public:
 
   class Locker {
   public:
-    Locker(const AnalysisResult *ar) :
+    explicit Locker(const AnalysisResult *ar) :
         m_ar(const_cast<AnalysisResult*>(ar)),
         m_mutex(m_ar->getMutex()) {
       m_mutex.lock();
     }
-    Locker(AnalysisResultConstPtr ar) :
+    explicit Locker(AnalysisResultConstPtr ar) :
         m_ar(const_cast<AnalysisResult*>(ar.get())),
         m_mutex(m_ar->getMutex()) {
       m_mutex.lock();
@@ -148,8 +149,10 @@ public:
   void addEntryPoint(const std::string &name);
   void addEntryPoints(const std::vector<std::string> &names);
 
-  void loadBuiltinFunctions();
-  void loadBuiltins();
+  void addNSFallbackFunc(ConstructPtr c, FileScopePtr fs);
+
+  void addSystemFunction(FunctionScopeRawPtr fs);
+  void addSystemClass(ClassScopeRawPtr cs);
   void analyzeProgram(bool system = false);
   void analyzeIncludes();
   void analyzeProgramFinal();
@@ -236,12 +239,22 @@ public:
   ClassScopePtr findClass(const std::string &className) const;
   ClassScopePtr findClass(const std::string &className,
                           FindClassBy by);
+
+  /*
+   * Returns: whether the given name is the name of any type aliases
+   * in the whole program.
+   */
+  bool isTypeAliasName(const std::string& name) const {
+    return m_typeAliasNames.count(name);
+  }
+
   /**
    * Find all the redeclared classes by the name, excluding system classes.
    * Note that system classes cannot be redeclared.
    */
   const ClassScopePtrVec &findRedeclaredClasses(
     const std::string &className) const;
+
   /**
    * Find all the classes by the name, including system classes.
    */
@@ -296,10 +309,12 @@ public:
   void addNamedScalarVarArray(const std::string &s);
   StringToClassScopePtrVecMap getExtensionClasses();
   void addInteger(int64_t n);
+
 private:
   Package *m_package;
   bool m_parseOnDemand;
   std::vector<std::string> m_parseOnDemandDirs;
+  std::set<std::pair<ConstructPtr, FileScopePtr> > m_nsFallbackFuncs;
   Phase m_phase;
   StringToFileScopePtrMap m_files;
   FileScopePtrVec m_fileScopes;
@@ -315,6 +330,13 @@ private:
   StringToFileScopePtrMap m_constDecs;
   std::set<std::string> m_constRedeclared;
 
+  // Map names of class aliases to the class names they will alias.
+  // Only in WholeProgram mode.  See markRedeclaringClasses.
+  std::multimap<std::string,std::string> m_classAliases;
+
+  // Names of type aliases.
+  std::set<std::string> m_typeAliasNames;
+
   bool m_classForcedVariants[2];
 
   StatementPtrVec m_stmts;
@@ -323,12 +345,12 @@ private:
   std::string m_outputPath;
 public:
   AnalysisResultPtr shared_from_this() {
-    return boost::static_pointer_cast<AnalysisResult>
+    return static_pointer_cast<AnalysisResult>
       (BlockScope::shared_from_this());
   }
 
   AnalysisResultConstPtr shared_from_this() const {
-    return boost::static_pointer_cast<const AnalysisResult>
+    return static_pointer_cast<const AnalysisResult>
       (BlockScope::shared_from_this());
   }
 
@@ -348,6 +370,11 @@ private:
    */
   bool inParseOnDemandDirs(const std::string &filename) const;
 
+  /*
+   * Find the names of all functions and classes in the program; mark
+   * functions with duplicate names as redeclaring, but duplicate
+   * classes aren't yet marked.  See markRedeclaringClasses.
+   */
   void collectFunctionsAndClasses(FileScopePtr fs);
 
   /**
@@ -356,12 +383,21 @@ private:
    */
   void canonicalizeSymbolOrder();
 
+  /*
+   * After all the class names have been collected and symbol order is
+   * canonicalized, this passes through and marks duplicate class
+   * names as redeclaring.
+   */
+  void markRedeclaringClasses();
+
   /**
    * Checks circular class derivations that can cause stack overflows for
    * subsequent analysis. Also checks to make sure no two redundant parents.
    */
   void checkClassDerivations();
 
+  void resolveNSFallbackFuncs();
+
   int getFileSize(FileScopePtr fs);
 
 public:
@@ -370,12 +406,12 @@ public:
                               s_changedScopesMapThreadLocal);
 
 #ifdef HPHP_INSTRUMENT_PROCESS_PARALLEL
-  static int                                  s_NumDoJobCalls;
+  static std::atomic<int>                     s_NumDoJobCalls;
   static ConcurrentBlockScopeRawPtrIntHashMap s_DoJobUniqueScopes;
-  static int                                  s_NumForceRerunGlobal;
-  static int                                  s_NumReactivateGlobal;
-  static int                                  s_NumForceRerunUseKinds;
-  static int                                  s_NumReactivateUseKinds;
+  static std::atomic<int>                     s_NumForceRerunGlobal;
+  static std::atomic<int>                     s_NumReactivateGlobal;
+  static std::atomic<int>                     s_NumForceRerunUseKinds;
+  static std::atomic<int>                     s_NumReactivateUseKinds;
 #endif /* HPHP_INSTRUMENT_PROCESS_PARALLEL */
 
 private:
@@ -399,13 +435,13 @@ private:
 
 class RescheduleException : public Exception {
 public:
-  RescheduleException(BlockScopeRawPtr scope) :
+  explicit RescheduleException(BlockScopeRawPtr scope) :
     Exception(), m_scope(scope) {}
   BlockScopeRawPtr &getScope() { return m_scope; }
 #ifdef HPHP_INSTRUMENT_TYPE_INF
-  static int s_NumReschedules;
-  static int s_NumForceRerunSelfCaller;
-  static int s_NumRetTypesChanged;
+  static std::atomic<int> s_NumReschedules;
+  static std::atomic<int> s_NumForceRerunSelfCaller;
+  static std::atomic<int> s_NumRetTypesChanged;
 #endif /* HPHP_INSTRUMENT_TYPE_INF */
 private:
   BlockScopeRawPtr m_scope;
@@ -413,7 +449,7 @@ private:
 
 class SetCurrentScope {
 public:
-  SetCurrentScope(BlockScopeRawPtr scope) {
+  explicit SetCurrentScope(BlockScopeRawPtr scope) {
     assert(!((*AnalysisResult::s_currentScopeThreadLocal).get()));
     *AnalysisResult::s_currentScopeThreadLocal = scope;
     scope->setInVisitScopes(true);
@@ -499,9 +535,9 @@ private:
     }
   }
 #else
-  BaseTryLock(BlockScopeRawPtr scopeToLock,
-              bool lockCondition = true,
-              bool profile = true)
+  explicit BaseTryLock(BlockScopeRawPtr scopeToLock,
+                       bool lockCondition = true,
+                       bool profile = true)
     : m_profiler(profile),
       m_mutex(scopeToLock->getInferTypesMutex()),
       m_acquired(false) {
@@ -536,8 +572,8 @@ public:
           bool profile = true) :
     BaseTryLock(scopeToLock, fromFunction, fromLine, true, profile) {}
 #else
-  TryLock(BlockScopeRawPtr scopeToLock,
-          bool profile = true) :
+  explicit TryLock(BlockScopeRawPtr scopeToLock,
+                   bool profile = true) :
     BaseTryLock(scopeToLock, true, profile) {}
 #endif /* HPHP_INSTRUMENT_TYPE_INF */
 };
@@ -595,4 +631,4 @@ public:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __ANALYSIS_RESULT_H__
+#endif // incl_HPHP_ANALYSIS_RESULT_H_

hphp/compiler/analysis/ast_walker.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,8 +14,8 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/ast_walker.h>
-#include <compiler/statement/statement.h>
+#include "hphp/compiler/analysis/ast_walker.h"
+#include "hphp/compiler/statement/statement.h"
 
 using namespace HPHP;
 
@@ -23,17 +23,17 @@ using namespace HPHP;
 
 bool FunctionWalker::SkipRecurse(ConstructPtr cp) {
   StatementPtr s(
-    boost::dynamic_pointer_cast<Statement>(cp));
+    dynamic_pointer_cast<Statement>(cp));
   return SkipRecurse(s);
 }
 bool FunctionWalker::SkipRecurse(ConstructConstPtr cp) {
   StatementConstPtr s(
-    boost::dynamic_pointer_cast<const Statement>(cp));
+    dynamic_pointer_cast<const Statement>(cp));
   return SkipRecurse(s);
 }
 bool FunctionWalker::SkipRecurse(ConstructRawPtr cp) {
   StatementRawPtr s(
-    boost::dynamic_pointer_cast<Statement>(cp));
+    dynamic_pointer_cast<Statement>(cp));
   return SkipRecurse(s);
 }
 

hphp/compiler/analysis/ast_walker.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,11 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __AST_WALKER_H__
-#define __AST_WALKER_H__
+#ifndef incl_HPHP_AST_WALKER_H_
+#define incl_HPHP_AST_WALKER_H_
 
-#include <compiler/hphp.h>
-#include <compiler/construct.h>
+#include "hphp/compiler/hphp.h"
+#include "hphp/compiler/construct.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -26,7 +26,7 @@ namespace HPHP {
 class AstWalkerState {
 public:
   AstWalkerState() : index(0) {}
-  AstWalkerState(ConstructRawPtr c) : cp(c), index(0) {}
+  explicit AstWalkerState(ConstructRawPtr c) : cp(c), index(0) {}
 
   friend bool operator==(const AstWalkerState &s1,
                          const AstWalkerState &s2) {
@@ -40,7 +40,7 @@ public:
 class AstWalkerStateVec : public std::vector<AstWalkerState> {
   public:
   AstWalkerStateVec() {}
-  AstWalkerStateVec(ConstructRawPtr cp) {
+  explicit AstWalkerStateVec(ConstructRawPtr cp) {
     push_back(AstWalkerState(cp));
   }
 };
@@ -132,4 +132,4 @@ public:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __AST_WALKER_H__
+#endif // incl_HPHP_AST_WALKER_H_

hphp/compiler/analysis/bit_set_vec.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -15,8 +15,8 @@
 */
 
 #include <stdlib.h>
-#include <compiler/analysis/bit_set_vec.h>
-#include <compiler/analysis/data_flow.h>
+#include "hphp/compiler/analysis/bit_set_vec.h"
+#include "hphp/compiler/analysis/data_flow.h"
 
 using namespace HPHP;
 

hphp/compiler/analysis/bit_set_vec.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -19,7 +19,7 @@
 
 #include <limits.h>
 #include <stddef.h>
-#include "util/assertions.h"
+#include "hphp/util/assertions.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////

hphp/compiler/analysis/block_scope.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,16 +14,17 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/expression/expression.h>
 
-#include <compiler/analysis/block_scope.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/analysis/constant_table.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/file_scope.h>
+#include "hphp/compiler/analysis/block_scope.h"
+
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/analysis/constant_table.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/file_scope.h"
 
 using namespace HPHP;
 
@@ -89,13 +90,29 @@ AnalysisResultRawPtr BlockScope::getContainingProgram() {
   return AnalysisResultRawPtr((AnalysisResult*)bs);
 }
 
-ClassScopeRawPtr BlockScope::getContainingClass() {
+FunctionScopeRawPtr BlockScope::getContainingNonClosureFunction() {
   BlockScope *bs = this;
-  if (bs->is(BlockScope::FunctionScope)) {
+  // walk out through all the closures
+  while (bs && bs->is(BlockScope::FunctionScope)) {
+    HPHP::FunctionScope *fs = static_cast<HPHP::FunctionScope*>(bs);
+    if (!fs->isClosure()) {
+      return FunctionScopeRawPtr(fs);
+    }
     bs = bs->m_outerScope.get();
   }
-  if (bs && !bs->is(BlockScope::ClassScope)) {
-    bs = 0;
+  return FunctionScopeRawPtr();
+}
+
+ClassScopeRawPtr BlockScope::getContainingClass() {
+  BlockScope *bs = getContainingNonClosureFunction().get();
+  if (!bs) {
+    bs = this;
+  }
+  if (bs && bs->is(BlockScope::FunctionScope)) {
+    bs = bs->m_outerScope.get();
+  }
+  if (!bs || !bs->is(BlockScope::ClassScope)) {
+    return ClassScopeRawPtr();
   }
   return ClassScopeRawPtr((HPHP::ClassScope*)bs);
 }
@@ -138,9 +155,7 @@ bool BlockScope::hasUser(BlockScopeRawPtr user, int useKinds) const {
 }
 
 void BlockScope::addUse(BlockScopeRawPtr user, int useKinds) {
-  if (is(ClassScope) ? static_cast<HPHP::ClassScope*>(this)->isUserClass() :
-      is(FunctionScope) &&
-      static_cast<HPHP::FunctionScope*>(this)->isUserFunction()) {
+  if ((is(ClassScope) || is(FunctionScope)) && getStmt()) {
 
     if (user.get() == this) {
       m_selfUser |= useKinds;

hphp/compiler/analysis/block_scope.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,14 +14,14 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __BLOCK_SCOPE_H__
-#define __BLOCK_SCOPE_H__
+#ifndef incl_HPHP_BLOCK_SCOPE_H_
+#define incl_HPHP_BLOCK_SCOPE_H_
 
-#include <compiler/hphp.h>
+#include "hphp/compiler/hphp.h"
 
-#include <util/bits.h>
-#include <util/lock.h>
-#include <runtime/base/macros.h>
+#include "hphp/util/bits.h"
+#include "hphp/util/lock.h"
+#include "hphp/runtime/base/macros.h"
 
 #include <tbb/concurrent_hash_map.h>
 
@@ -66,7 +66,7 @@ typedef SimpleMutex InferTypesMutex;
  * Base class of ClassScope and FunctionScope.
  */
 class BlockScope : private boost::noncopyable,
-                   public boost::enable_shared_from_this<BlockScope> {
+                   public std::enable_shared_from_this<BlockScope> {
 public:
   enum KindOf {
     ClassScope,
@@ -178,6 +178,7 @@ public:
   VariableTablePtr getVariables() { return m_variables;}
   ConstantTablePtr getConstants() { return m_constants;}
   ClassScopeRawPtr getContainingClass();
+  FunctionScopeRawPtr getContainingNonClosureFunction();
   FunctionScopeRawPtr getContainingFunction() const {
     return FunctionScopeRawPtr(is(FunctionScope) ?
                                (HPHP::FunctionScope*)this : 0);
@@ -365,4 +366,4 @@ public:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __BLOCK_SCOPE_H__
+#endif // incl_HPHP_BLOCK_SCOPE_H_

hphp/compiler/analysis/capture_extractor.cpp

@@ -0,0 +1,391 @@
+/*
+   +----------------------------------------------------------------------+
+   | HipHop for PHP                                                       |
+   +----------------------------------------------------------------------+
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
+   +----------------------------------------------------------------------+
+   | This source file is subject to version 3.01 of the PHP license,      |
+   | that is bundled with this package in the file LICENSE, and is        |
+   | available through the world-wide-web at the following url:           |
+   | http://www.php.net/license/3_01.txt                                  |
+   | If you did not receive a copy of the PHP license and are unable to   |
+   | obtain it through the world-wide-web, please send a note to          |
+   | license@php.net so we can mail you a copy immediately.               |
+   +----------------------------------------------------------------------+
+*/
+
+#include "hphp/compiler/analysis/capture_extractor.h"
+#include "hphp/compiler/expression/join_clause.h"
+#include "hphp/compiler/expression/scalar_expression.h"
+#include "hphp/parser/hphp.tab.hpp"
+
+namespace HPHP {
+///////////////////////////////////////////////////////////////////////////////
+
+/**
+ * Rewrites the construct rooted in cp so that it is in a form
+ * that a query processor can evaluate while referencing only
+ * state that is contained in the query processor or supplied
+ * to the query processor in the form of arguments to the query.
+ * For instance, a reference to a local variable in the scope
+ * containing the query expression will be rewritten into a
+ * reference to a (synthetic) parameter of the query expression.
+ * This is similar to the way lambda expressions capture variables
+ * from their enclosing environment.
+ * Note that rewriting implies allocating new objects.
+ * The original construct is not mutated in any way.
+ * If the original construct is already in the right form, it is
+ * returned as is.
+ */
+ExpressionPtr CaptureExtractor::rewrite(ExpressionPtr ep) {
+  assert(ep != nullptr);
+  switch (ep->getKindOf()) {
+    case Expression::KindOfQueryExpression: {
+      return rewriteQuery(static_pointer_cast<QueryExpression>(ep));
+    }
+    case Expression::KindOfSelectClause: {
+      // leave select clauses alone, another visitor deals with them.
+      return ep;
+    }
+    case Expression::KindOfFromClause:
+    case Expression::KindOfLetClause:
+    case Expression::KindOfIntoClause:
+    case Expression::KindOfWhereClause: {
+      return rewriteSimpleClause(static_pointer_cast<SimpleQueryClause>(ep));
+    }
+    case Expression::KindOfGroupClause:
+    case Expression::KindOfJoinClause:
+    case Expression::KindOfOrderbyClause:
+    case Expression::KindOfOrdering: {
+      // leave these alone. they are query specific and not parameterizable.
+      return ep;
+    }
+    case Expression::KindOfObjectPropertyExpression: {
+      return rewriteObjectProperty(
+        static_pointer_cast<ObjectPropertyExpression>(ep));
+    }
+    case Expression::KindOfSimpleFunctionCall: {
+      return rewriteCall(static_pointer_cast<SimpleFunctionCall>(ep));
+    }
+    case Expression::KindOfScalarExpression: {
+      // Leave scalars alone. If the query processor can't handle them
+      // rewriting won't help.
+      return ep;
+    }
+    case Expression::KindOfUnaryOpExpression: {
+      return rewriteUnary(static_pointer_cast<UnaryOpExpression>(ep));
+    }
+    case Expression::KindOfBinaryOpExpression: {
+      return rewriteBinary(static_pointer_cast<BinaryOpExpression>(ep));
+    }
+    case Expression::KindOfSimpleVariable: {
+      return rewriteSimpleVariable(static_pointer_cast<SimpleVariable>(ep));
+    }
+    case Expression::KindOfExpressionList: {
+      return rewriteExpressionList(static_pointer_cast<ExpressionList>(ep));
+    }
+    default: {
+      // If we get here, the expression is not a candidate for evaluation
+      // by the query processor, so just turn it into a query parameter.
+      return newQueryParamRef(ep);
+    }
+  }
+}
+
+/**
+ * Appends the given expression to end of the m_capturedExpressions list
+ * and creates a new expression with the same scope and source location
+ * that represents a reference to a query parameter. Query parameters do
+ * not have a source code equivalent, but inform the query processor that
+ * this expression represents the ith argument value, where i is zero based
+ * and forms the last character of the special string @query_param_i.
+ */
+SimpleVariablePtr CaptureExtractor::newQueryParamRef(ExpressionPtr ae) {
+  assert(ae != nullptr);
+  char count = '0' + m_capturedExpressions.size();
+  std::string pname = "@query_param_";
+  pname.push_back(count);
+  SimpleVariablePtr param(
+    new SimpleVariable(ae->getScope(), ae->getLocation(), pname)
+  );
+  m_capturedExpressions.push_back(ae);
+  return param;
+}
+
+/**
+ * If one or more of the arguments of the function call depend on query only
+ * state (query local but not a query parameter reference), then rewrite
+ * all of the arguments to be query local and return the rewritten
+ * function call (the query processor has to either figure out a way to call
+ * the function or must cause a runtime error when faced with the call).
+ * Otherwise, rewrite the call as a query parameter reference.
+ */
+ExpressionPtr CaptureExtractor::rewriteCall(SimpleFunctionCallPtr sfc) {
+  assert(sfc != nullptr);
+  if (sfc->hadBackslash() ||
+    (sfc->getClass() != nullptr && !sfc->getClassName().empty())) {
+    return newQueryParamRef(sfc);
+  }
+  auto args = sfc->getParams();
+  auto pc = args == nullptr ? 0 : args->getCount();
+  bool isQueryCall = false;
+  for (int i = 0; i < pc; i++) {
+    auto arg = (*args)[i];
+    assert(arg != nullptr);
+    isQueryCall |= this->dependsOnQueryOnlyState(arg);
+  }
+  if (!isQueryCall) return newQueryParamRef(sfc);
+  ExpressionListPtr newArgs(
+    new ExpressionList(args->getScope(), args->getLocation())
+  );
+  bool noRewrites = true;
+  for (int i = 0; i < pc; i++) {
+    auto arg = (*args)[i];
+    auto newArg = rewrite(arg);
+    if (arg != newArg) noRewrites = false;
+    newArgs->addElement(newArg);
+  }
+  if (noRewrites) return sfc;
+  SimpleFunctionCallPtr result(
+    new SimpleFunctionCall(sfc->getScope(), sfc->getLocation(),
+      sfc->getName(), false, newArgs, ExpressionPtr())
+  );
+  return result;
+}
+
+/**
+ * Traverses the expression tree rooted at e and returns true if
+ * any node in the tree is a simple variable that references a
+ * name in m_boundVars.
+ */
+bool CaptureExtractor::dependsOnQueryOnlyState(ExpressionPtr e) {
+  assert(e != nullptr);
+  if (e->getKindOf() == Expression::KindOfSimpleVariable) {
+    auto sv = static_pointer_cast<SimpleVariable>(e);
+    auto varName = sv->getName();
+    for (auto &boundVar : m_boundVars) {
+      if (varName == boundVar) return true;
+    }
+    return false;
+  }
+  auto numKids = e->getKidCount();
+  for (int i = 0; i < numKids; i++) {
+    auto ei = e->getNthExpr(i);
+    if (ei == nullptr) return false; //Default param
+    if (dependsOnQueryOnlyState(ei)) return true;
+  }
+  return false;
+}
+
+/**
+ * If a simple variable refers to a name bound inside the query
+ * then leave it alone. If not, rewrite it to be reference to
+ * a query parameter.
+ */
+SimpleVariablePtr CaptureExtractor::rewriteSimpleVariable(
+  SimpleVariablePtr sv) {
+  assert(sv != nullptr);
+  auto varName = sv->getName();
+  for (auto &boundVar : m_boundVars) {
+    if (varName == boundVar) return sv;
+  }
+  return newQueryParamRef(sv);
+}
+
+/**
+* Query expressions introduce a local scope with names introduced
+* by some of the clauses of the query expression. This needs
+* special handling so that we can track variables local to the query.
+*/
+QueryExpressionPtr CaptureExtractor::rewriteQuery(QueryExpressionPtr qe) {
+  assert(qe != nullptr);
+  auto clauses = qe->getClauses();
+  auto newClauses = rewriteExpressionList(clauses);
+  if (clauses == newClauses) return qe;
+  QueryExpressionPtr result(
+    new QueryExpression(qe->getScope(), qe->getLocation(), newClauses)
+  );
+  return result;
+}
+
+/**
+ * Rewrites any expression query clauses in this list of clauses, taking care
+ * to track variables local to the query.
+ */
+ExpressionListPtr CaptureExtractor::rewriteExpressionList(ExpressionListPtr l) {
+  int np = 0;
+  int nc = l->getCount();
+  ExpressionListPtr newList(
+    new ExpressionList(l->getScope(), l->getLocation())
+  );
+  bool noRewrites = true;
+  for (int i = 0; i < nc; i++) {
+    auto e = (*l)[i];
+    assert(e != nullptr);
+    auto kind = e->getKindOf();
+    switch (kind) {
+      case Expression::KindOfIntoClause: {
+        // The into expression is in the scope of the into clause
+        SimpleQueryClausePtr qcp(static_pointer_cast<SimpleQueryClause>(e));
+        m_boundVars.push_back(qcp->getIdentifier());
+        np++;
+        break;
+      }
+      case Expression::KindOfJoinClause: {
+        JoinClausePtr jcp(static_pointer_cast<JoinClause>(e));
+        m_boundVars.push_back(jcp->getVar());
+        np++;
+        break;
+      }
+      default:
+        break;
+    }
+    auto ne = rewrite(e);
+    if (ne != e) noRewrites = false;
+    newList->addElement(ne);
+    // deal with clauses that introduce names for subsequent clauses
+    switch (kind) {
+      case Expression::KindOfFromClause:
+      case Expression::KindOfLetClause: {
+        SimpleQueryClausePtr qcp(static_pointer_cast<SimpleQueryClause>(e));
+        m_boundVars.push_back(qcp->getIdentifier());
+        np++;
+        break;
+      }
+      case Expression::KindOfJoinClause: {
+        JoinClausePtr jcp(static_pointer_cast<JoinClause>(e));
+        auto groupId = jcp->getGroup();
+        if (!groupId.empty()) {
+          m_boundVars.push_back(groupId);
+          np++;
+        }
+        break;
+      }
+      default:
+        break;
+    }
+  }
+  while (np-- > 0) m_boundVars.pop_back();
+  if (noRewrites) return l;
+  return newList;
+}
+
+/*
+ * If the expression of a simple query clause is query local, then
+ * return the clause as is. Otherwise return a clone of the clause
+ * with the expression rewritten to reference a query parameter.
+ */
+SimpleQueryClausePtr CaptureExtractor::rewriteSimpleClause(
+    SimpleQueryClausePtr sc) {
+  assert (sc != nullptr);
+  auto expr = sc->getExpression();
+  auto newExpr = rewrite(expr);
+  if (expr == newExpr) return sc;
+  auto rsc = static_pointer_cast<SimpleQueryClause>(sc->clone());
+  rsc->setExpression(newExpr);
+  return rsc;
+}
+
+/*
+ * If the object expression is query local, that is, if it is a simple variable
+ * referring to a name declared in a query clause, or itself a query local
+ * object expression, then if keep this expression as is. If not, then
+ * rewrite this expression into a query parameter reference.
+ */
+ExpressionPtr CaptureExtractor::rewriteObjectProperty(
+  ObjectPropertyExpressionPtr ope) {
+  assert(ope != nullptr);
+  auto obj = ope->getObject();
+  if (this->dependsOnQueryOnlyState(obj)) {
+    auto prop = ope->getProperty();
+    if (prop->getKindOf() == Expression::KindOfScalarExpression) {
+      auto scalar = static_pointer_cast<ScalarExpression>(prop);
+      const string &propName = scalar->getLiteralString();
+      if (!propName.empty()) {
+        return ope;
+      }
+    }
+  }
+  return newQueryParamRef(ope);
+}
+
+/**
+ * If the unary operation is not PHP specific, but something a query
+ * processor can handle (+ - ! ~), then rewrite the operand to something
+ * the query processor can evaluate (such as a query parameter reference)
+ * and rewrite the entire expression to use the rewritten operand.
+ * If the rewritten operand is the same as the original operand, just
+ * return the expression as is.
+ */
+ExpressionPtr CaptureExtractor::rewriteUnary(UnaryOpExpressionPtr ue) {
+  assert (ue != nullptr);
+  if (!ue->getFront()) return nullptr;
+  switch (ue->getOp()) {
+    case '+':
+    case '-':
+    case '!':
+    case '~':
+      break; // Could be something the query processor can handle
+    default:
+      return newQueryParamRef(ue);
+  }
+  auto expr = ue->getExpression();
+  auto newExpr = rewrite(expr);
+  if (expr == newExpr) return ue;
+  UnaryOpExpressionPtr result(
+    new UnaryOpExpression(ue->getScope(), ue->getLocation(),
+                          newExpr, ue->getOp(), true)
+  );
+  return result;
+}
+
+/**
+ * If the binary operation is not PHP specific, but something a query
+ * processor can handle (+ - * and so on), then rewrite the operands to
+ * something the query processor can evaluate (such as a query parameter
+ * references) and rewrite the entire expression to use the rewritten operands.
+ * If the rewritten operands are the same as the original operands, just
+ * return the expression as is.
+ */
+ExpressionPtr CaptureExtractor::rewriteBinary(BinaryOpExpressionPtr be) {
+  assert(be != nullptr);
+  switch (be->getOp()) {
+    case '+':
+    case '-':
+    case '*':
+    case '/':
+    case '%':
+    case '&':
+    case '|':
+    case '^':
+    case T_IS_IDENTICAL:
+    case T_IS_EQUAL:
+    case '>':
+    case '<':
+    case T_IS_GREATER_OR_EQUAL:
+    case T_IS_SMALLER_OR_EQUAL:
+    case T_IS_NOT_IDENTICAL:
+    case T_IS_NOT_EQUAL:
+    case T_BOOLEAN_OR:
+    case T_BOOLEAN_AND:
+    case T_LOGICAL_OR:
+    case T_LOGICAL_AND:
+    case '.':
+      break; // Could be something the query processor can handle
+
+    default:
+      return newQueryParamRef(be);
+  }
+  auto expr1 = be->getExp1();
+  auto expr2 = be->getExp2();
+  auto newExpr1 = rewrite(expr1);
+  auto newExpr2 = rewrite(expr2);
+  if (expr1 == newExpr1 && expr2 == newExpr2) return be;
+  BinaryOpExpressionPtr result(
+    new BinaryOpExpression(be->getScope(), be->getLocation(),
+                          newExpr1, newExpr2, be->getOp())
+  );
+  return result;
+}
+
+}

hphp/compiler/analysis/capture_extractor.h

@@ -0,0 +1,66 @@
+/*
+   +----------------------------------------------------------------------+
+   | HipHop for PHP                                                       |
+   +----------------------------------------------------------------------+
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
+   +----------------------------------------------------------------------+
+   | This source file is subject to version 3.01 of the PHP license,      |
+   | that is bundled with this package in the file LICENSE, and is        |
+   | available through the world-wide-web at the following url:           |
+   | http://www.php.net/license/3_01.txt                                  |
+   | If you did not receive a copy of the PHP license and are unable to   |
+   | obtain it through the world-wide-web, please send a note to          |
+   | license@php.net so we can mail you a copy immediately.               |
+   +----------------------------------------------------------------------+
+*/
+
+#ifndef incl_HPHP_CAPTURE_EXTRACTOR_H_
+#define incl_HPHP_CAPTURE_EXTRACTOR_H_
+
+#include "hphp/compiler/expression/binary_op_expression.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/object_property_expression.h"
+#include "hphp/compiler/expression/query_expression.h"
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/compiler/expression/simple_query_clause.h"
+#include "hphp/compiler/expression/simple_variable.h"
+#include "hphp/compiler/expression/unary_op_expression.h"
+
+namespace HPHP {
+///////////////////////////////////////////////////////////////////////////////
+
+/** A rewriter for query expressions that capture variables that lie
+ *  outside of the scope of the query expression. Subexpressions that
+ *  contain such references are turned into references to query parameter
+ *  variables. The original expressions are collected into the list
+ *  returned by getCapturedEpressions. Their runtime values are obtained
+ *  before the query is evaluated and are passed as arguments to the query
+ *  processor.
+ */
+class CaptureExtractor {
+public:
+
+  ExpressionPtr rewrite(ExpressionPtr ep);
+
+  std::vector<ExpressionPtr> getCapturedExpressions() {
+    return m_capturedExpressions;
+  }
+
+private:
+  bool dependsOnQueryOnlyState(ExpressionPtr e);
+  SimpleVariablePtr newQueryParamRef(ExpressionPtr ae);
+  ExpressionPtr rewriteBinary(BinaryOpExpressionPtr be);
+  ExpressionPtr rewriteCall(SimpleFunctionCallPtr sfc);
+  ExpressionListPtr rewriteExpressionList(ExpressionListPtr l);
+  ExpressionPtr rewriteObjectProperty(ObjectPropertyExpressionPtr ope);
+  QueryExpressionPtr rewriteQuery(QueryExpressionPtr qe);
+  SimpleQueryClausePtr rewriteSimpleClause(SimpleQueryClausePtr sc);
+  SimpleVariablePtr rewriteSimpleVariable(SimpleVariablePtr sv);
+  ExpressionPtr rewriteUnary(UnaryOpExpressionPtr ue);
+
+  std::vector<ExpressionPtr> m_capturedExpressions;
+  std::vector<std::string> m_boundVars;
+};
+
+}
+#endif // incl_HPHP_CAPTURE_EXTRACTOR_H_

hphp/compiler/analysis/class_scope.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,35 +14,39 @@
    +----------------------------------------------------------------------+
 */
 
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/constant_table.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/construct.h"
+#include "hphp/compiler/expression/class_constant_expression.h"
+#include "hphp/compiler/expression/closure_expression.h"
+#include "hphp/compiler/expression/constant_expression.h"
+#include "hphp/compiler/expression/scalar_expression.h"
+#include "hphp/compiler/expression/unary_op_expression.h"
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/compiler/statement/interface_statement.h"
+#include "hphp/compiler/statement/function_statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/runtime/base/builtin-functions.h"
+#include "hphp/runtime/base/class-info.h"
+#include "hphp/compiler/statement/class_variable.h"
+#include "hphp/compiler/statement/class_constant.h"
+#include "hphp/compiler/statement/use_trait_statement.h"
+#include "hphp/compiler/statement/trait_require_statement.h"
+#include "hphp/compiler/statement/trait_prec_statement.h"
+#include "hphp/compiler/statement/trait_alias_statement.h"
+#include "hphp/runtime/base/zend-string.h"
+#include "hphp/util/util.h"
+
 #include <boost/foreach.hpp>
 #include <boost/tuple/tuple.hpp>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/constant_table.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/construct.h>
-#include <compiler/expression/class_constant_expression.h>
-#include <compiler/expression/constant_expression.h>
-#include <compiler/expression/scalar_expression.h>
-#include <compiler/expression/unary_op_expression.h>
-#include <compiler/expression/simple_function_call.h>
-#include <compiler/option.h>
-#include <compiler/parser/parser.h>
-#include <compiler/statement/interface_statement.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/statement_list.h>
-#include <runtime/base/builtin_functions.h>
-#include <runtime/base/class_info.h>
-#include <compiler/statement/class_variable.h>
-#include <compiler/statement/class_constant.h>
-#include <compiler/statement/use_trait_statement.h>
-#include <compiler/statement/trait_prec_statement.h>
-#include <compiler/statement/trait_alias_statement.h>
-#include <runtime/base/zend/zend_string.h>
-#include <util/util.h>
 
 using namespace HPHP;
 using std::map;
@@ -59,8 +63,7 @@ ClassScope::ClassScope(KindOf kindOf, const std::string &name,
     m_kindOf(kindOf), m_derivesFromRedeclaring(FromNormal),
     m_traitStatus(NOT_FLATTENED), m_volatile(false),
     m_persistent(false), m_derivedByDynamic(false),
-    m_sep(false), m_needsCppCtor(false), m_needsInit(true), m_knownBases(0),
-    m_needsEnableDestructor(0) {
+    m_needsCppCtor(false), m_needsInit(true), m_knownBases(0) {
 
   m_dynamic = Option::IsDynamicClass(m_name);
 
@@ -90,8 +93,8 @@ ClassScope::ClassScope(AnalysisResultPtr ar,
     m_kindOf(KindOfObjectClass), m_derivesFromRedeclaring(FromNormal),
     m_traitStatus(NOT_FLATTENED), m_dynamic(false),
     m_volatile(false), m_persistent(false),
-    m_derivedByDynamic(false), m_sep(false), m_needsCppCtor(false),
-    m_needsInit(true), m_knownBases(0), m_needsEnableDestructor(0) {
+    m_derivedByDynamic(false), m_needsCppCtor(false),
+    m_needsInit(true), m_knownBases(0) {
   BOOST_FOREACH(FunctionScopePtr f, methods) {
     if (f->getName() == "__construct") setAttribute(HasConstructor);
     else if (f->getName() == "__destruct") setAttribute(HasDestructor);
@@ -354,7 +357,7 @@ void ClassScope::collectMethods(AnalysisResultPtr ar,
           setVolatile();
         }
       }
-    } else if (!Option::SystemGen) {
+    } else {
       Compiler::Error(Compiler::UnknownBaseClass, m_stmt, base);
       if (base == m_parent) {
         ar->declareUnknownClass(m_parent);
@@ -401,23 +404,12 @@ MethodStatementPtr
 ClassScope::importTraitMethod(const TraitMethod&  traitMethod,
                               AnalysisResultPtr   ar,
                               string              methName,
-                              GeneratorRenameMap& genRenameMap,
                               const std::map<string, MethodStatementPtr>&
                               importedTraitMethods) {
   MethodStatementPtr meth = traitMethod.m_method;
   string origMethName = traitMethod.m_originalName;
   ModifierExpressionPtr modifiers = traitMethod.m_modifiers;
 
-  if (meth->getOrigGeneratorFunc()) {
-    const string &name = meth->getOrigGeneratorFunc()->getName();
-    if (!importedTraitMethods.count(name)) {
-      // Dont import the generator, if the origGenerator wasnt imported
-      // this happens when a generator in the trait is hidden by a non-generator
-      // method in the importing class.
-      return MethodStatementPtr();
-    }
-  }
-
   MethodStatementPtr cloneMeth = dynamic_pointer_cast<MethodStatement>(
     dynamic_pointer_cast<ClassStatement>(m_stmt)->addClone(meth));
   cloneMeth->setName(methName);
@@ -432,31 +424,67 @@ ClassScope::importTraitMethod(const TraitMethod&  traitMethod,
   ClassScopePtr cScope = dynamic_pointer_cast<ClassScope>(shared_from_this());
   cloneMeth->fixupSelfAndParentTypehints( cScope );
 
-  // Generator methods need to be renamed, otherwise code gen produces multiple
-  // continuation classes with the same name
-  if (funcScope->isGenerator()) {
-    const string& newName = getNewGeneratorName(funcScope, genRenameMap);
-    methName = origMethName = newName;
-    cloneMeth->setName(newName);
-    cloneMeth->setOriginalName(newName);
-  }
   FunctionScopePtr cloneFuncScope
     (new HPHP::FunctionScope(funcScope, ar, methName, origMethName, cloneMeth,
-                             cloneMeth->getModifiers()));
+                             cloneMeth->getModifiers(), cScope->isUserClass()));
   cloneMeth->resetScope(cloneFuncScope, true);
   cloneFuncScope->setOuterScope(shared_from_this());
+  informClosuresAboutScopeClone(cloneMeth, cloneFuncScope, ar);
 
   cloneMeth->addTraitMethodToScope(ar,
                dynamic_pointer_cast<ClassScope>(shared_from_this()));
 
+  // Preserve original filename (as this varies per-function and not per-unit
+  // in the case of methods imported from flattened traits)
+  cloneMeth->setOriginalFilename(meth->getFileScope()->getName());
+
   return cloneMeth;
 }
 
+void ClassScope::informClosuresAboutScopeClone(
+    ConstructPtr root,
+    FunctionScopePtr outerScope,
+    AnalysisResultPtr ar) {
+
+  if (!root) {
+    return;
+  }
+
+  for (int i = 0; i < root->getKidCount(); i++) {
+    ConstructPtr cons = root->getNthKid(i);
+    ClosureExpressionPtr closure =
+      dynamic_pointer_cast<ClosureExpression>(cons);
+
+    if (!closure) {
+      informClosuresAboutScopeClone(cons, outerScope, ar);
+      continue;
+    }
+
+    FunctionStatementPtr func = closure->getClosureFunction();
+    HPHP::FunctionScopePtr funcScope = func->getFunctionScope();
+    assert(funcScope->isClosure());
+    funcScope->addClonedTraitOuterScope(outerScope);
+    // Don't need to recurse
+  }
+}
+
+
 void ClassScope::addImportTraitMethod(const TraitMethod &traitMethod,
                                       const string &methName) {
   m_importMethToTraitMap[methName].push_back(traitMethod);
 }
 
+void ClassScope::addTraitRequirement(const string &requiredName,
+                                     bool isExtends) {
+  assert(isTrait());
+
+  if (isExtends) {
+    m_traitRequiredExtends.insert(requiredName);
+  } else {
+    m_traitRequiredImplements.insert(requiredName);
+  }
+}
+
 void
 ClassScope::setImportTraitMethodModifiers(const string &methName,
                                           ClassScopePtr traitCls,
@@ -517,6 +545,7 @@ ClassScope::findTraitMethod(AnalysisResultPtr ar,
 
 void ClassScope::findTraitMethodsToImport(AnalysisResultPtr ar,
                                           ClassScopePtr trait) {
+  assert(Option::WholeProgram);
   ClassStatementPtr tStmt =
     dynamic_pointer_cast<ClassStatement>(trait->getStmt());
   StatementListPtr tStmts = tStmt->getStmts();
@@ -533,7 +562,45 @@ void ClassScope::findTraitMethodsToImport(AnalysisResultPtr ar,
   }
 }
 
+void ClassScope::importTraitRequirements(AnalysisResultPtr ar,
+                                         ClassScopePtr trait) {
+  if (isTrait()) {
+    for (auto const& req : trait->getTraitRequiredExtends()) {
+      addTraitRequirement(req, true);
+    }
+    for (auto const& req : trait->getTraitRequiredImplements()) {
+      addTraitRequirement(req, false);
+    }
+  } else {
+    for (auto const& req : trait->getTraitRequiredExtends()) {
+      if (!derivesFrom(ar, req, true, false)) {
+        getStmt()->analysisTimeFatal(
+          Compiler::InvalidDerivation,
+          Strings::TRAIT_REQ_EXTENDS,
+          m_originalName.c_str(),
+          req.c_str(),
+          trait->getOriginalName().c_str(),
+          "use"
+        );
+      }
+    }
+    for (auto const& req : trait->getTraitRequiredImplements()) {
+      if (!derivesFrom(ar, req, true, false)) {
+        getStmt()->analysisTimeFatal(
+          Compiler::InvalidDerivation,
+          Strings::TRAIT_REQ_IMPLEMENTS,
+          m_originalName.c_str(),
+          req.c_str(),
+          trait->getOriginalName().c_str(),
+          "use"
+        );
+      }
+    }
+  }
+}
+
 void ClassScope::applyTraitPrecRule(TraitPrecStatementPtr stmt) {
+  assert(Option::WholeProgram);
   const string methodName = Util::toLower(stmt->getMethodName());
   const string selectedTraitName = Util::toLower(stmt->getTraitName());
   std::set<string> otherTraitNames;
@@ -564,12 +631,20 @@ void ClassScope::applyTraitPrecRule(TraitPrecStatementPtr stmt) {
 
   // Report error if didn't find the selected trait
   if (!foundSelectedTrait) {
-    Compiler::Error(Compiler::UnknownTrait, stmt);
+    stmt->analysisTimeFatal(
+      Compiler::UnknownTrait,
+      Strings::TRAITS_UNKNOWN_TRAIT,
+      selectedTraitName.c_str()
+    );
   }
 
   // Sanity checking: otherTraitNames should be empty now
   if (otherTraitNames.size()) {
-    Compiler::Error(Compiler::UnknownTrait, stmt);
+    stmt->analysisTimeFatal(
+      Compiler::UnknownTrait,
+      Strings::TRAITS_UNKNOWN_TRAIT,
+      selectedTraitName.c_str()
+    );
   }
 }
 
@@ -580,6 +655,7 @@ bool ClassScope::hasMethod(const string &methodName) const {
 ClassScopePtr
 ClassScope::findSingleTraitWithMethod(AnalysisResultPtr ar,
                                       const string &methodName) const {
+  assert(Option::WholeProgram);
   ClassScopePtr trait = ClassScopePtr();
 
   for (unsigned i = 0; i < m_usedTraitNames.size(); i++) {
@@ -597,6 +673,7 @@ ClassScope::findSingleTraitWithMethod(AnalysisResultPtr ar,
 }
 
 void ClassScope::addTraitAlias(TraitAliasStatementPtr aliasStmt) {
+  assert(Option::WholeProgram);
   const string &traitName = aliasStmt->getTraitName();
   const string &origMethName = aliasStmt->getMethodName();
   const string &newMethName = aliasStmt->getNewMethodName();
@@ -607,6 +684,7 @@ void ClassScope::addTraitAlias(TraitAliasStatementPtr aliasStmt) {
 
 void ClassScope::applyTraitAliasRule(AnalysisResultPtr ar,
                                      TraitAliasStatementPtr stmt) {
+  assert(Option::WholeProgram);
   const string traitName = Util::toLower(stmt->getTraitName());
   const string origMethName = Util::toLower(stmt->getMethodName());
   const string newMethName = Util::toLower(stmt->getNewMethodName());
@@ -619,8 +697,11 @@ void ClassScope::applyTraitAliasRule(AnalysisResultPtr ar,
     traitCls = ar->findClass(traitName);
   }
   if (!traitCls || !(traitCls->isTrait())) {
-    Compiler::Error(Compiler::UnknownTrait, stmt);
-    return;
+    stmt->analysisTimeFatal(
+      Compiler::UnknownTrait,
+      Strings::TRAITS_UNKNOWN_TRAIT,
+      traitName.empty() ? origMethName.c_str() : traitName.c_str()
+    );
   }
 
   // Keep record of alias rule
@@ -631,8 +712,10 @@ void ClassScope::applyTraitAliasRule(AnalysisResultPtr ar,
   MethodStatementPtr methStmt = findTraitMethod(ar, traitCls, origMethName,
                                                 visitedTraits);
   if (!methStmt) {
-    Compiler::Error(Compiler::UnknownTraitMethod, stmt);
-    return;
+    stmt->analysisTimeFatal(
+      Compiler::UnknownTraitMethod,
+      Strings::TRAITS_UNKNOWN_TRAIT_METHOD, origMethName.c_str()
+    );
   }
 
   if (origMethName == newMethName) {
@@ -647,6 +730,7 @@ void ClassScope::applyTraitAliasRule(AnalysisResultPtr ar,
 }
 
 void ClassScope::applyTraitRules(AnalysisResultPtr ar) {
+  assert(Option::WholeProgram);
   ClassStatementPtr classStmt = dynamic_pointer_cast<ClassStatement>(getStmt());
   assert(classStmt);
   StatementListPtr stmts = classStmt->getStmts();
@@ -679,6 +763,7 @@ void ClassScope::applyTraitRules(AnalysisResultPtr ar) {
 //   1) implemented by other traits
 //   2) duplicate
 void ClassScope::removeSpareTraitAbstractMethods(AnalysisResultPtr ar) {
+  assert(Option::WholeProgram);
   for (MethodToTraitListMap::iterator iter = m_importMethToTraitMap.begin();
        iter != m_importMethToTraitMap.end(); iter++) {
 
@@ -715,88 +800,18 @@ void ClassScope::removeSpareTraitAbstractMethods(AnalysisResultPtr ar) {
   }
 }
 
-const string& ClassScope::getNewGeneratorName(
-  FunctionScopePtr genFuncScope, GeneratorRenameMap &genRenameMap) {
-  assert(genFuncScope->isGenerator());
-  const string& oldName = genFuncScope->getName();
-  GeneratorRenameMap::iterator mapIt = genRenameMap.find(oldName);
-  if (mapIt != genRenameMap.end()) {
-    return mapIt->second;
-  }
-  string newName = oldName + "_" +
-    lexical_cast<string>(genFuncScope->getNewID());
-  genRenameMap[oldName] = newName;
-  return genRenameMap[oldName];
-}
-
-void
-ClassScope::renameCreateContinuationCalls(AnalysisResultPtr ar,
-                                          ConstructPtr      c,
-                                          ImportedMethodMap &importedMethods) {
-  if (!c) return;
-  SimpleFunctionCallPtr funcCall = dynamic_pointer_cast<SimpleFunctionCall>(c);
-  if (funcCall && funcCall->getName() == "hphp_create_continuation") {
-
-    ExpressionListPtr params = funcCall->getParams();
-    assert(params->getCount() >= 2);
-    const string &oldClassName =
-      dynamic_pointer_cast<ScalarExpression>((*params)[0])->getString();
-    ClassScopePtr oldClassScope = ar->findClass(oldClassName);
-    if (!oldClassScope || !oldClassScope->isTrait()) return;
-
-    const string &oldGenName =
-      dynamic_pointer_cast<ScalarExpression>((*params)[1])->getString();
-
-    MethodStatementPtr origGenStmt = importedMethods[oldGenName];
-    assert(origGenStmt);
-
-    const string &newGenName = origGenStmt->getOriginalName();
-    ExpressionPtr newGenExpr = funcCall->makeScalarExpression(ar, newGenName);
-    ExpressionPtr newClsExpr = funcCall->makeScalarExpression(ar, getName());
-    (*params)[0] = newClsExpr;
-    (*params)[1] = newGenExpr;
-    funcCall->analyzeProgram(ar);
-    return;
-  }
-  for (int i=0; i < c->getKidCount(); i++) {
-    renameCreateContinuationCalls(ar, c->getNthKid(i), importedMethods);
-  }
-}
-
-void ClassScope::relinkGeneratorMethods(
-  AnalysisResultPtr ar,
-  ImportedMethodMap &importedMethods) {
-  for (ImportedMethodMap::const_iterator methIt =
-         importedMethods.begin(); methIt != importedMethods.end(); methIt++) {
-    MethodStatementPtr newMeth = methIt->second;
-
-    // Skip non-generator methods
-    if (!newMeth) continue;
-
-    if (newMeth->getOrigGeneratorFunc()) {
-      // Get corresponding original generator method in the current class
-      const string& origGenName = newMeth->getOrigGeneratorFunc()->getName();
-      MethodStatementPtr origGenStmt = importedMethods[origGenName];
-      assert(origGenStmt);
-      // It must be an orig gen func already, we're just updating to point
-      // to the corresponding method cloned from the trait
-      assert(origGenStmt->getGeneratorFunc());
-      newMeth->setOrigGeneratorFunc(origGenStmt);
-      origGenStmt->setGeneratorFunc(newMeth);
-    }
-
-    // OrigGenerator methods need to have their hphp_create_continuation calls
-    // patched to the new generator name.
-    if (newMeth->getGeneratorFunc()) {
-      renameCreateContinuationCalls(ar, newMeth, importedMethods);
-    }
-  }
-}
-
 void ClassScope::importUsedTraits(AnalysisResultPtr ar) {
+  // Trait flattening is supposed to happen only when we have awareness of
+  // the whole program.
+  assert(Option::WholeProgram);
+
   if (m_traitStatus == FLATTENED) return;
   if (m_traitStatus == BEING_FLATTENED) {
-    Compiler::Error(Compiler::CyclicDependentTraits, getStmt());
+    getStmt()->analysisTimeFatal(
+      Compiler::CyclicDependentTraits,
+      "Cyclic dependency between traits involving %s",
+      getOriginalName().c_str()
+    );
     return;
   }
   if (m_usedTraitNames.size() == 0) {
@@ -813,18 +828,53 @@ void ClassScope::importUsedTraits(AnalysisResultPtr ar) {
     }
   }
 
+  if (isTrait()) {
+    for (auto const& req : getTraitRequiredExtends()) {
+      ClassScopePtr rCls = ar->findClass(req);
+      if (!rCls || rCls->isFinal() || rCls->isInterface()) {
+        getStmt()->analysisTimeFatal(
+          Compiler::InvalidDerivation,
+          Strings::TRAIT_BAD_REQ_EXTENDS,
+          m_originalName.c_str(),
+          req.c_str(),
+          req.c_str()
+        );
+      }
+    }
+    for (auto const& req : getTraitRequiredImplements()) {
+      ClassScopePtr rCls = ar->findClass(req);
+      if (!rCls || !(rCls->isInterface())) {
+        getStmt()->analysisTimeFatal(
+          Compiler::InvalidDerivation,
+          Strings::TRAIT_BAD_REQ_IMPLEMENTS,
+          m_originalName.c_str(),
+          req.c_str(),
+          req.c_str()
+        );
+      }
+    }
+  }
+
   // Find trait methods to be imported
   for (unsigned i = 0; i < m_usedTraitNames.size(); i++) {
     ClassScopePtr tCls = ar->findClass(m_usedTraitNames[i]);
     if (!tCls || !(tCls->isTrait())) {
-      setAttribute(UsesUnknownTrait);
-      Compiler::Error(Compiler::UnknownTrait, getStmt());
-      continue;
+      setAttribute(UsesUnknownTrait); // XXX: is this useful ... for anything?
+      getStmt()->analysisTimeFatal(
+        Compiler::UnknownTrait,
+        Strings::TRAITS_UNKNOWN_TRAIT,
+        m_usedTraitNames[i].c_str()
+      );
     }
     // First, make sure the used trait is flattened
     tCls->importUsedTraits(ar);
 
     findTraitMethodsToImport(ar, tCls);
+
+    // Import any interfaces implemented
+    tCls->getInterfaces(ar, m_bases, false);
+
+    importTraitRequirements(ar, tCls);
   }
 
   // Apply rules
@@ -844,9 +894,7 @@ void ClassScope::importUsedTraits(AnalysisResultPtr ar) {
   }
 
   std::map<string, MethodStatementPtr> importedTraitMethods;
-  std::vector<std::pair<string,const TraitMethod*> > importedTraitsWithOrigName;
-
-  GeneratorRenameMap genRenameMap;
+  std::vector<std::pair<string,const TraitMethod*>> importedTraitsWithOrigName;
 
   // Actually import the methods
   for (MethodToTraitListMap::const_iterator
@@ -860,7 +908,11 @@ void ClassScope::importUsedTraits(AnalysisResultPtr ar) {
     }
     // Consistency checking: each name must only refer to one imported method
     if (iter->second.size() > 1) {
-      Compiler::Error(Compiler::MethodInMultipleTraits, getStmt());
+      getStmt()->analysisTimeFatal(
+        Compiler::MethodInMultipleTraits,
+        Strings::METHOD_IN_MULTIPLE_TRAITS,
+        iter->first.c_str()
+      );
     } else {
       TraitMethodList::const_iterator traitMethIter = iter->second.begin();
       if ((traitMethIter->m_modifiers ? traitMethIter->m_modifiers :
@@ -871,13 +923,6 @@ void ClassScope::importUsedTraits(AnalysisResultPtr ar) {
           continue;
         }
       }
-      if (traitMethIter->m_modifiers &&
-          traitMethIter->m_modifiers->isStatic()) {
-        Compiler::Error(Compiler::InvalidAccessModifier,
-                        traitMethIter->m_modifiers);
-        continue;
-      }
-
       string sourceName = traitMethIter->m_ruleStmt ?
         Util::toLower(((TraitAliasStatement*)traitMethIter->m_ruleStmt.get())->
                       getMethodName()) : iter->first;
@@ -892,15 +937,12 @@ void ClassScope::importUsedTraits(AnalysisResultPtr ar) {
     const TraitMethod *traitMethod = importedTraitsWithOrigName[i].second;
     MethodStatementPtr newMeth = importTraitMethod(
       *traitMethod, ar, Util::toLower(traitMethod->m_originalName),
-      genRenameMap, importedTraitMethods);
+      importedTraitMethods);
     if (newMeth) {
       importedTraitMethods[sourceName] = newMeth;
     }
   }
 
-  // Relink generator and origGenerator methods
-  relinkGeneratorMethods(ar, importedTraitMethods);
-
   // Import trait properties
   importTraitProperties(ar);
 
@@ -1162,10 +1204,10 @@ void ClassScope::getAllParents(AnalysisResultConstPtr ar,
                                std::vector<std::string> &names) {
   if (m_stmt) {
     if (isInterface()) {
-      boost::dynamic_pointer_cast<InterfaceStatement>
+      dynamic_pointer_cast<InterfaceStatement>
         (m_stmt)->getAllParents(ar, names);
     } else {
-      boost::dynamic_pointer_cast<ClassStatement>
+      dynamic_pointer_cast<ClassStatement>
         (m_stmt)->getAllParents(ar, names);
     }
   } else {
@@ -1201,8 +1243,7 @@ void ClassScope::getInterfaces(AnalysisResultConstPtr ar,
       if (cls && cls->isRedeclaring()) {
         cls = self->findExactClass(cls);
       }
-      if (cls) names.push_back(cls->getDocName());
-      else     names.push_back(*it);
+      names.push_back(cls ? cls->getDocName() : *it);
       if (cls && recursive) {
         cls->getInterfaces(ar, names, true);
       }
@@ -1296,7 +1337,7 @@ void ClassScope::serialize(JSON::DocTarget::OutputStream &out) const {
 
   ms.add("parent");
   if (m_parent.empty()) {
-    out << JSON::Null;
+    out << JSON::Null();
   } else {
     out << GetDocName(out.analysisResult(), self, m_parent);
   }
@@ -1400,36 +1441,6 @@ bool ClassScope::addFunction(AnalysisResultConstPtr ar,
   return true;
 }
 
-/*
- * A class without a constructor, but with a destructor may need a special
- * create method to clear the NoDestructor flag - but only if
- * there is a constructor somewhere above us, and if /that/ constructor
- * doesnt need to clear the NoDestructor flag.
- */
-bool ClassScope::needsEnableDestructor(
-  AnalysisResultConstPtr ar) const {
-  if (m_needsEnableDestructor & 2) {
-    return m_needsEnableDestructor & 1;
-  }
-  bool ret =
-    (!derivesFromRedeclaring() &&
-     !getAttribute(HasConstructor) &&
-     !getAttribute(ClassNameConstructor));
-
-  if (ret) {
-    if (!getAttribute(HasDestructor) && !m_parent.empty()) {
-      if (ClassScopePtr parent = getParentScope(ar)) {
-        if (!parent->needsEnableDestructor(ar)) {
-          ret = false;
-        }
-      }
-    }
-  }
-
-  m_needsEnableDestructor = ret ? 3 : 2;
-  return ret;
-}
-
 bool ClassScope::canSkipCreateMethod(AnalysisResultConstPtr ar) const {
   // create() is not necessary if
   // 1) not inheriting from any class

hphp/compiler/analysis/class_scope.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,19 +14,20 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __CLASS_SCOPE_H__
-#define __CLASS_SCOPE_H__
+#ifndef incl_HPHP_CLASS_SCOPE_H_
+#define incl_HPHP_CLASS_SCOPE_H_
 
-#include <compiler/analysis/block_scope.h>
-#include <compiler/analysis/function_container.h>
-#include <compiler/statement/class_statement.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/trait_prec_statement.h>
-#include <compiler/statement/trait_alias_statement.h>
-#include <compiler/expression/user_attribute.h>
-#include <util/json.h>
-#include <util/case_insensitive.h>
-#include <compiler/option.h>
+#include "hphp/compiler/analysis/block_scope.h"
+#include "hphp/compiler/analysis/function_container.h"
+#include "hphp/compiler/statement/class_statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/trait_prec_statement.h"
+#include "hphp/compiler/statement/trait_alias_statement.h"
+#include "hphp/compiler/expression/user_attribute.h"
+#include "hphp/compiler/json.h"
+#include "hphp/util/functional.h"
+#include "hphp/util/hash-map-typedefs.h"
+#include "hphp/compiler/option.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -169,14 +170,11 @@ public:
     return m_derivedByDynamic;
   }
 
-  /* Whether this class is brought in by a separable extension */
-  void setSepExtension() { m_sep = true;}
-  bool isSepExtension() const { return m_sep;}
-
   /**
    * Get/set attributes.
    */
   void setSystem();
+  bool isSystem() const { return m_attribute & System; }
   void setAttribute(Attribute attr) { m_attribute |= attr;}
   void clearAttribute(Attribute attr) { m_attribute &= ~attr;}
   bool getAttribute(Attribute attr) const {
@@ -305,17 +303,29 @@ public:
     }
   }
 
+  const boost::container::flat_set<std::string>& getTraitRequiredExtends()
+    const {
+    return m_traitRequiredExtends;
+  }
+
+  const boost::container::flat_set<std::string>& getTraitRequiredImplements()
+    const {
+    return m_traitRequiredImplements;
+  }
+
   const std::vector<std::string> &getUsedTraitNames() const {
     return m_usedTraitNames;
   }
 
-  const std::vector<std::pair<std::string, std::string> > &getTraitAliases()
+  const std::vector<std::pair<std::string, std::string>>& getTraitAliases()
     const {
     return m_traitAliases;
   }
 
   void addTraitAlias(TraitAliasStatementPtr aliasStmt);
 
+  void addTraitRequirement(const std::string &requiredName, bool isExtends);
+
   void importUsedTraits(AnalysisResultPtr ar);
 
   /**
@@ -370,10 +380,19 @@ public:
     return m_needsInit;
   }
 
-  bool needsEnableDestructor(AnalysisResultConstPtr ar) const;
   bool canSkipCreateMethod(AnalysisResultConstPtr ar) const;
   bool checkHasPropTable(AnalysisResultConstPtr ar);
 
+  const StringData* getFatalMessage() const {
+    return m_fatal_error_msg;
+  }
+
+  void setFatal(const AnalysisTimeFatalException& fatal) {
+    assert(m_fatal_error_msg == nullptr);
+    m_fatal_error_msg = makeStaticString(fatal.getMessage());
+    assert(m_fatal_error_msg != nullptr);
+  }
+
 private:
   // need to maintain declaration order for ClassInfo map
   FunctionScopePtrVec m_functionsVec;
@@ -383,6 +402,8 @@ private:
   UserAttributeMap m_userAttributes;
 
   std::vector<std::string> m_usedTraitNames;
+  boost::container::flat_set<std::string> m_traitRequiredExtends;
+  boost::container::flat_set<std::string> m_traitRequiredImplements;
   // m_traitAliases is used to support ReflectionClass::getTraitAliases
   std::vector<std::pair<std::string, std::string> > m_traitAliases;
 
@@ -408,7 +429,6 @@ private:
 
   typedef std::list<TraitMethod> TraitMethodList;
   typedef std::map<std::string, TraitMethodList> MethodToTraitListMap;
-  typedef std::map<std::string, std::string> GeneratorRenameMap;
   MethodToTraitListMap m_importMethToTraitMap;
   typedef std::map<std::string, MethodStatementPtr> ImportedMethodMap;
 
@@ -425,7 +445,6 @@ private:
   unsigned m_volatile:1; // for class_exists
   unsigned m_persistent:1;
   unsigned m_derivedByDynamic:1;
-  unsigned m_sep:1;
   unsigned m_needsCppCtor:1;
   unsigned m_needsInit:1;
   // m_knownBases has a bit for each base class saying whether
@@ -433,10 +452,15 @@ private:
   // for classes with more than 31 bases, bit 31 is set iff
   // bases 32 through n are all known.
   unsigned m_knownBases;
-  mutable unsigned m_needsEnableDestructor:2;
+
+  // holds the fact that accessing this class declaration is a fatal error
+  const StringData* m_fatal_error_msg = nullptr;
 
   void addImportTraitMethod(const TraitMethod &traitMethod,
                             const std::string &methName);
+  void informClosuresAboutScopeClone(ConstructPtr root,
+                                     FunctionScopePtr outerScope,
+                                     AnalysisResultPtr ar);
 
   void setImportTraitMethodModifiers(const std::string &methName,
                                      ClassScopePtr traitCls,
@@ -445,17 +469,15 @@ private:
   MethodStatementPtr importTraitMethod(const TraitMethod&  traitMethod,
                                        AnalysisResultPtr   ar,
                                        std::string         methName,
-                                       GeneratorRenameMap& genRenameMap,
                                        const ImportedMethodMap &
                                        importedTraitMethods);
 
   void importTraitProperties(AnalysisResultPtr ar);
 
-  void relinkGeneratorMethods(AnalysisResultPtr ar,
-                              ImportedMethodMap& importedMethods);
-
   void findTraitMethodsToImport(AnalysisResultPtr ar, ClassScopePtr trait);
 
+  void importTraitRequirements(AnalysisResultPtr ar, ClassScopePtr trait);
+
   MethodStatementPtr findTraitMethod(AnalysisResultPtr ar,
                                      ClassScopePtr trait,
                                      const std::string &methodName,
@@ -476,14 +498,8 @@ private:
 
   bool hasMethod(const std::string &methodName) const;
 
-  const std::string& getNewGeneratorName(FunctionScopePtr    genFuncScope,
-                                         GeneratorRenameMap& genRenameMap);
-
-  void renameCreateContinuationCalls(AnalysisResultPtr ar, ConstructPtr c,
-                                     ImportedMethodMap &importedMethods);
-
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __CLASS_SCOPE_H__
+#endif // incl_HPHP_CLASS_SCOPE_H_

hphp/compiler/analysis/code_error.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,13 +14,13 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/parser/parser.h>
-#include <compiler/construct.h>
-#include <compiler/option.h>
-#include <util/exception.h>
-#include <util/lock.h>
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/compiler/construct.h"
+#include "hphp/compiler/option.h"
+#include "hphp/util/exception.h"
+#include "hphp/util/lock.h"
 
 using namespace HPHP::JSON;
 
@@ -79,7 +79,7 @@ std::vector<const char *> &CodeErrors::getErrorTexts() {
   if (ErrorTexts.empty()) {
     ErrorTexts.resize(ErrorCount);
 #define CODE_ERROR_ENTRY(x) ErrorTexts[x] = #x;
-#include "compiler/analysis/core_code_error.inc"
+#include "hphp/compiler/analysis/core_code_error.inc"
 #undef CODE_ERROR_ENTRY
   }
   return ErrorTexts;

hphp/compiler/analysis/code_error.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,11 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __COMPILER_ERROR_H__
-#define __COMPILER_ERROR_H__
+#ifndef incl_HPHP_COMPILER_ERROR_H_
+#define incl_HPHP_COMPILER_ERROR_H_
 
-#include <compiler/analysis/type.h>
-#include <util/json.h>
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/json.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -31,7 +31,7 @@ namespace Compiler {
 
 enum ErrorType {
 #define CODE_ERROR_ENTRY(x) x,
-#include "compiler/analysis/core_code_error.inc"
+#include "hphp/compiler/analysis/core_code_error.inc"
 #undef CODE_ERROR_ENTRY
   ErrorCount,
   NoError
@@ -79,4 +79,4 @@ bool HasError(); // any error
 ///////////////////////////////////////////////////////////////////////////////
 }}
 
-#endif // __COMPILER_ERROR_H__
+#endif // incl_HPHP_COMPILER_ERROR_H_

hphp/compiler/analysis/constant_table.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,18 +14,18 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/constant_table.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/type.h>
-#include <compiler/code_generator.h>
-#include <compiler/expression/expression.h>
-#include <compiler/expression/scalar_expression.h>
-#include <compiler/option.h>
-#include <util/util.h>
-#include <util/hash.h>
-#include <compiler/analysis/class_scope.h>
-#include <runtime/base/complex_types.h>
+#include "hphp/compiler/analysis/constant_table.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/code_generator.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/scalar_expression.h"
+#include "hphp/compiler/option.h"
+#include "hphp/util/util.h"
+#include "hphp/util/hash.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/runtime/base/complex-types.h"
 
 using namespace HPHP;
 

hphp/compiler/analysis/constant_table.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,11 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __CONSTANT_TABLE_H__
-#define __CONSTANT_TABLE_H__
+#ifndef incl_HPHP_CONSTANT_TABLE_H_
+#define incl_HPHP_CONSTANT_TABLE_H_
 
-#include <compiler/analysis/symbol_table.h>
-#include <compiler/analysis/block_scope.h>
+#include "hphp/compiler/analysis/symbol_table.h"
+#include "hphp/compiler/analysis/block_scope.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -37,7 +37,7 @@ DECLARE_BOOST_TYPES(ClassScope);
  */
 class ConstantTable : public SymbolTable {
 public:
-  ConstantTable(BlockScope &blockScope);
+  explicit ConstantTable(BlockScope &blockScope);
 
   /**
    * Whether defining something to be non-scalar value or redeclared, or
@@ -103,4 +103,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __CONSTANT_TABLE_H__
+#endif // incl_HPHP_CONSTANT_TABLE_H_

hphp/compiler/analysis/control_flow.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -13,32 +13,32 @@
    | license@php.net so we can mail you a copy immediately.               |
    +----------------------------------------------------------------------+
 */
-
-#include "compiler/analysis/ast_walker.h"
-#include "compiler/analysis/control_flow.h"
-#include "compiler/analysis/data_flow.h"
-#include "compiler/expression/expression.h"
-#include "compiler/expression/binary_op_expression.h"
-#include "compiler/expression/unary_op_expression.h"
-#include "compiler/expression/qop_expression.h"
-#include "compiler/statement/statement.h"
-#include "compiler/statement/method_statement.h"
-#include "compiler/statement/statement_list.h"
-#include "compiler/statement/if_branch_statement.h"
-#include "compiler/statement/for_statement.h"
-#include "compiler/statement/while_statement.h"
-#include "compiler/statement/do_statement.h"
-#include "compiler/statement/foreach_statement.h"
-#include "compiler/statement/switch_statement.h"
-#include "compiler/statement/break_statement.h"
-#include "compiler/statement/try_statement.h"
-#include "compiler/statement/finally_statement.h"
-#include "compiler/statement/label_statement.h"
-#include "compiler/statement/goto_statement.h"
-#include "compiler/statement/case_statement.h"
+#include "hphp/compiler/analysis/control_flow.h"
 
 #include <boost/graph/depth_first_search.hpp>
 
+#include "hphp/compiler/analysis/ast_walker.h"
+#include "hphp/compiler/analysis/data_flow.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/binary_op_expression.h"
+#include "hphp/compiler/expression/unary_op_expression.h"
+#include "hphp/compiler/expression/qop_expression.h"
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/statement/if_branch_statement.h"
+#include "hphp/compiler/statement/for_statement.h"
+#include "hphp/compiler/statement/while_statement.h"
+#include "hphp/compiler/statement/do_statement.h"
+#include "hphp/compiler/statement/foreach_statement.h"
+#include "hphp/compiler/statement/switch_statement.h"
+#include "hphp/compiler/statement/break_statement.h"
+#include "hphp/compiler/statement/try_statement.h"
+#include "hphp/compiler/statement/finally_statement.h"
+#include "hphp/compiler/statement/label_statement.h"
+#include "hphp/compiler/statement/goto_statement.h"
+#include "hphp/compiler/statement/case_statement.h"
+
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
 
@@ -64,8 +64,8 @@ typedef hphp_hash_map<ConstructRawPtr, ControlBlock*,
 
 class ControlFlowBuilder : public FunctionWalker {
 public:
-  ControlFlowBuilder(ControlFlowGraph *g, bool isGenerator) :
-      m_graph(g), m_pass(0), m_isGenerator(isGenerator), m_cur(0), m_head(0) {}
+  explicit ControlFlowBuilder(ControlFlowGraph *g) :
+      m_graph(g), m_pass(0), m_cur(0), m_head(0) {}
 
   int before(ConstructRawPtr cp);
   int after(ConstructRawPtr cp);
@@ -161,7 +161,6 @@ private:
   ControlFlowGraph               *m_graph;
   AstWalkerStateVec              m_state;
   int                            m_pass;
-  bool                           m_isGenerator;
   ControlBlock                   *m_cur;
   ControlBlock                   *m_head;
 
@@ -182,7 +181,7 @@ public:
 
 class dfs_dump : public boost::default_dfs_visitor {
 public:
-  dfs_dump(AnalysisResultConstPtr ar) : m_ar(ar) {}
+  explicit dfs_dump(AnalysisResultConstPtr ar) : m_ar(ar) {}
 
   void discover_vertex(ControlFlowGraph::vertex_descriptor u,
                        const ControlFlowGraph &g) {
@@ -246,6 +245,7 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
         Statement::KindOf stype = s->getKindOf();
         switch (stype) {
           case Statement::KindOfUseTraitStatement:
+          case Statement::KindOfTraitRequireStatement:
           case Statement::KindOfTraitPrecStatement:
           case Statement::KindOfTraitAliasStatement:
             not_reached();
@@ -329,9 +329,10 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
           }
 
           case Statement::KindOfForStatement: {
-            ConstructRawPtr cond(s->getNthKid(ForStatement::CondExpr));
-            ConstructRawPtr body(s->getNthKid(ForStatement::BodyStmt));
-            ConstructRawPtr incr(s->getNthKid(ForStatement::IncExpr));
+            ForStatementPtr fs(static_pointer_cast<ForStatement>(s));
+            ConstructRawPtr body(fs->getBody());
+            ConstructRawPtr cond(fs->getCondExp());
+            ConstructRawPtr incr(fs->getIncExp());
             if (cond) addEdge(cond, AfterConstruct, s, AfterConstruct);
             ConstructRawPtr end = incr ? incr : body ? body : cond;
             ConstructRawPtr start = cond ? cond : body ? body : incr;
@@ -341,8 +342,9 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
           }
 
           case Statement::KindOfWhileStatement: {
-            ConstructRawPtr cond(s->getNthKid(WhileStatement::CondExpr));
-            ConstructRawPtr body(s->getNthKid(WhileStatement::BodyStmt));
+            WhileStatementPtr ws(static_pointer_cast<WhileStatement>(s));
+            ConstructRawPtr body(ws->getBody());
+            ConstructRawPtr cond(ws->getCondExp());
             addEdge(cond, AfterConstruct, s, AfterConstruct);
             addEdge(body ? body : cond, AfterConstruct, cond, BeforeConstruct);
             noFallThrough(s);
@@ -350,15 +352,16 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
           }
 
           case Statement::KindOfDoStatement: {
-            ConstructRawPtr cond(s->getNthKid(DoStatement::CondExpr));
-            addEdge(cond, AfterConstruct, s, BeforeConstruct);
+            DoStatementPtr ds(static_pointer_cast<DoStatement>(s));
+            addEdge(ds->getCondExp(), AfterConstruct, s, BeforeConstruct);
             break;
           }
 
           case Statement::KindOfForEachStatement: {
-            ConstructRawPtr body(s->getNthKid(ForEachStatement::BodyStmt));
-            ConstructRawPtr name(s->getNthKid(ForEachStatement::NameExpr));
-            ConstructRawPtr value(s->getNthKid(ForEachStatement::ValueExpr));
+            ForEachStatementPtr fs(static_pointer_cast<ForEachStatement>(s));
+            ConstructRawPtr body(fs->getBody());
+            ConstructRawPtr name(fs->getNameExp());
+            ConstructRawPtr value(fs->getValueExp());
             ConstructRawPtr begin = name ? name : value;
             ConstructRawPtr end = body ? body : value;
             addEdge(end, AfterConstruct, begin, BeforeConstruct);
@@ -414,7 +417,7 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
 
           case Statement::KindOfReturnStatement: {
             setEdge(s, AfterConstruct, root(), AfterConstruct);
-            if (!m_isGenerator) noFallThrough(s);
+            noFallThrough(s);
             /*
              * Since almost anything in php /might/ throw, we
              * approximate, and add edges from the beginning and
@@ -450,23 +453,31 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
                   } else {
                     ConstructRawPtr kid;
                     switch (l->getKindOf()) {
-                      case Statement::KindOfForEachStatement:
-                        kid = l->getNthKid(ForEachStatement::NameExpr);
+                      case Statement::KindOfForEachStatement: {
+                        ForEachStatementPtr fs(static_pointer_cast<ForEachStatement>(l));
+                        kid = fs->getNameExp();
                         if (!kid) {
-                          kid = l->getNthKid(ForEachStatement::ValueExpr);
+                          kid = fs->getValueExp();
                         }
                         break;
-                      case Statement::KindOfForStatement:
-                        kid = l->getNthKid(ForStatement::IncExpr);
-                        if (!kid) kid = l->getNthKid(ForStatement::CondExpr);
-                        if (!kid) kid = l->getNthKid(ForStatement::BodyStmt);
+                      }
+                      case Statement::KindOfForStatement: {
+                        ForStatementPtr fs(static_pointer_cast<ForStatement>(l));
+                        kid = fs->getIncExp();
+                        if (!kid) kid = fs->getCondExp();
+                        if (!kid) kid = fs->getBody();
                         break;
-                      case Statement::KindOfWhileStatement:
-                        kid = l->getNthKid(WhileStatement::CondExpr);
+                      }
+                      case Statement::KindOfWhileStatement: {
+                        WhileStatementPtr ws(static_pointer_cast<WhileStatement>(l));
+                        kid = ws->getCondExp();
                         break;
-                      case Statement::KindOfDoStatement:
-                        kid = l->getNthKid(DoStatement::CondExpr);
+                      }
+                      case Statement::KindOfDoStatement: {
+                        DoStatementPtr ds(static_pointer_cast<DoStatement>(l));
+                        kid = ds->getCondExp();
                         break;
+                      }
                       default:
                         always_assert(0);
                     }
@@ -487,6 +498,7 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
           }
 
           case Statement::KindOfEchoStatement:
+          case Statement::KindOfTypedefStatement:
             break;
 
           default:
@@ -495,36 +507,36 @@ int ControlFlowBuilder::before(ConstructRawPtr cp) {
       } else {
         ExpressionPtr e(dynamic_pointer_cast<Expression>(cp));
         switch (e->getKindOf()) {
-          case Expression::KindOfBinaryOpExpression:
-            {
-              BinaryOpExpressionPtr b(
-                  static_pointer_cast<BinaryOpExpression>(e));
-              if (b->isShortCircuitOperator()) {
-                ConstructPtr trueBranch, falseBranch;
-                ConstructLocation tLoc, fLoc;
-                getTrueFalseBranches(0, trueBranch, tLoc, falseBranch, fLoc);
-                assert(trueBranch);
-                assert(falseBranch);
-                if (b->isLogicalOrOperator()) {
-                  addEdge(e->getNthExpr(0), AfterConstruct, trueBranch, tLoc);
-                } else {
-                  addEdge(e->getNthExpr(0), AfterConstruct, falseBranch, fLoc);
-                }
+          case Expression::KindOfBinaryOpExpression: {
+            BinaryOpExpressionPtr b(static_pointer_cast<BinaryOpExpression>(e));
+            if (b->isShortCircuitOperator()) {
+              ConstructPtr trueBranch, falseBranch;
+              ConstructLocation tLoc, fLoc;
+              getTrueFalseBranches(0, trueBranch, tLoc, falseBranch, fLoc);
+              assert(trueBranch);
+              assert(falseBranch);
+              if (b->isLogicalOrOperator()) {
+                addEdge(b->getExp1(), AfterConstruct, trueBranch, tLoc);
+              } else {
+                addEdge(b->getExp1(), AfterConstruct, falseBranch, fLoc);
               }
             }
             break;
-          case Expression::KindOfQOpExpression:
-            if (ExpressionPtr e1 = e->getNthExpr(1)) {
-              addEdge(e->getNthExpr(0), AfterConstruct,
-                      e->getNthExpr(2), BeforeConstruct);
+          }
+          case Expression::KindOfQOpExpression: {
+            QOpExpressionPtr q(static_pointer_cast<QOpExpression>(e));
+            if (ExpressionPtr e1 = q->getYes()) {
+              addEdge(q->getCondition(), AfterConstruct,
+                      q->getNo(), BeforeConstruct);
               addEdge(e1, AfterConstruct,
-                      e->getNthExpr(2), AfterConstruct);
+                      q->getNo(), AfterConstruct);
               noFallThrough(e1);
             } else {
-              addEdge(e->getNthExpr(0), AfterConstruct,
-                      e->getNthExpr(2), AfterConstruct);
+              addEdge(q->getCondition(), AfterConstruct,
+                      q->getNo(), AfterConstruct);
             }
             break;
+          }
           default:
             break;
         }
@@ -586,32 +598,36 @@ void ControlFlowBuilder::getTrueFalseBranches(
 
   ConstructPtr c(top(level));
   if (StatementPtr s = dynamic_pointer_cast<Statement>(c)) {
-    int kidBodyIdx = -1;
+    StatementPtr kidBody;
     switch (s->getKindOf()) {
-    case Statement::KindOfForStatement:
+    case Statement::KindOfForStatement: {
       // examine which context we're in
-      {
-        ConstructPtr kid(top(level - 1));
-        if (kid == s->getNthKid(ForStatement::InitExpr)) {
-          ; // just do the default case
-        } else if (kid == s->getNthKid(ForStatement::CondExpr)) {
-          kidBodyIdx = ForStatement::BodyStmt;
-          goto loop_stmt;
-        } else if (kid == s->getNthKid(ForStatement::IncExpr)) {
-          ; // just do the default case
-        } else {
-          assert(false);
-        }
+      ForStatementPtr fs(static_pointer_cast<ForStatement>(s));
+      ConstructPtr kid(top(level - 1));
+      if (kid == fs->getInitExp()) {
+        ; // just do the default case
+      } else if (kid == fs->getCondExp()) {
+        kidBody = fs->getBody();
+        goto loop_stmt;
+      } else if (kid == fs->getIncExp()) {
+        ; // just do the default case
+      } else {
+        assert(false);
       }
       break;
-    case Statement::KindOfWhileStatement:
-      kidBodyIdx = WhileStatement::BodyStmt;
+    }
+    case Statement::KindOfWhileStatement: {
+      WhileStatementPtr ws(static_pointer_cast<WhileStatement>(s));
+      kidBody = ws->getBody();
       goto loop_stmt;
-    case Statement::KindOfDoStatement:
-      kidBodyIdx = DoStatement::BodyStmt;
+    }
+    case Statement::KindOfDoStatement: {
+      DoStatementPtr ds(static_pointer_cast<DoStatement>(s));
+      kidBody = ds->getBody();
+    }
     loop_stmt:
       if (!trueBranch) {
-        trueBranch = s->getNthKid(kidBodyIdx);
+        trueBranch = kidBody;
         tLoc = BeforeConstruct;
       }
       if (!falseBranch) {
@@ -852,7 +868,7 @@ ControlFlowGraph *ControlFlowGraph::buildControlFlow(MethodStatementPtr m) {
   ControlFlowGraph *graph = new ControlFlowGraph;
 
   graph->m_stmt = m;
-  ControlFlowBuilder cfb(graph, m->getOrigGeneratorFunc());
+  ControlFlowBuilder cfb(graph);
   cfb.run(m->getStmts());
   graph->m_nextDfn = 1;
   depth_first_visit(*graph, cfb.head(),

hphp/compiler/analysis/control_flow.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,17 +14,17 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __CONTROL_FLOW_H__
-#define __CONTROL_FLOW_H__
+#ifndef incl_HPHP_CONTROL_FLOW_H_
+#define incl_HPHP_CONTROL_FLOW_H_
 
 #include <boost/graph/properties.hpp>
 #include <boost/graph/adjacency_iterator.hpp>
 #include <boost/graph/adjacency_list.hpp>
 
-#include <compiler/hphp.h>
+#include "hphp/compiler/hphp.h"
 
-#include <compiler/analysis/ast_walker.h>
-#include <compiler/analysis/bit_set_vec.h>
+#include "hphp/compiler/analysis/ast_walker.h"
+#include "hphp/compiler/analysis/bit_set_vec.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -65,6 +65,8 @@ struct graph_traits<HPHP::ControlFlowGraph> {
   typedef int vertices_size_type;
   typedef int edges_size_type;
   typedef std::list<HPHP::ControlEdge*>::size_type degree_size_type;
+
+  static vertex_descriptor null_vertex() { return nullptr; }
 };
 
 template<>
@@ -309,7 +311,10 @@ inline void put(boost::vertex_color_t c,
 
 class ControlFlowGraphWalker : public FunctionWalker {
 public:
-  ControlFlowGraphWalker(ControlFlowGraph *g) : m_block(0), m_graph(*g) {}
+  explicit ControlFlowGraphWalker(ControlFlowGraph *g)
+    : m_block(0)
+    , m_graph(*g)
+  {}
   template <class T>
   void walk(T &t) {
     std::pair<ControlFlowGraph::vertex_iterator,
@@ -333,4 +338,4 @@ protected:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __CONTROL_FLOW_H__
+#endif // incl_HPHP_CONTROL_FLOW_H_

hphp/compiler/analysis/core_code_error.inc

@@ -37,10 +37,11 @@ CODE_ERROR_ENTRY(InvalidAttribute)
 CODE_ERROR_ENTRY(UnknownTrait)
 CODE_ERROR_ENTRY(MethodInMultipleTraits)
 CODE_ERROR_ENTRY(UnknownTraitMethod)
-CODE_ERROR_ENTRY(InvalidAccessModifier)
 CODE_ERROR_ENTRY(CyclicDependentTraits)
 CODE_ERROR_ENTRY(InvalidTraitStatement)
 CODE_ERROR_ENTRY(RedeclaredTrait)
 CODE_ERROR_ENTRY(InvalidInstantiation)
 CODE_ERROR_ENTRY(InvalidYield)
+CODE_ERROR_ENTRY(InvalidAwait)
 CODE_ERROR_ENTRY(BadDefaultValueType)
+CODE_ERROR_ENTRY(InvalidMethodDefinition)

hphp/compiler/analysis/data_flow.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,12 +14,12 @@
    +----------------------------------------------------------------------+
 */
 
-#include "compiler/analysis/data_flow.h"
+#include "hphp/compiler/analysis/data_flow.h"
 
-#include "compiler/expression/expression.h"
-#include "compiler/expression/simple_variable.h"
-#include "compiler/expression/binary_op_expression.h"
-#include "compiler/expression/list_assignment.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/simple_variable.h"
+#include "hphp/compiler/expression/binary_op_expression.h"
+#include "hphp/compiler/expression/list_assignment.h"
 
 using namespace HPHP;
 using std::pair;
@@ -221,16 +221,16 @@ void DataFlow::ComputePartialDying(const ControlFlowGraph &g) {
 // DataFlowWalker
 
 int DataFlowWalker::after(ConstructRawPtr cp) {
-  if (ExpressionRawPtr e = boost::dynamic_pointer_cast<Expression>(cp)) {
+  if (ExpressionRawPtr e = dynamic_pointer_cast<Expression>(cp)) {
     switch (e->getKindOf()) {
       case Expression::KindOfSimpleVariable:
-        if (!boost::static_pointer_cast<SimpleVariable>(
+        if (!static_pointer_cast<SimpleVariable>(
               e)->getAlwaysStash()) {
           return WalkContinue;
         }
         break;
       case Expression::KindOfBinaryOpExpression:
-        if (boost::static_pointer_cast<BinaryOpExpression>(
+        if (static_pointer_cast<BinaryOpExpression>(
               e)->isShortCircuitOperator()) {
           break;
         }
@@ -246,7 +246,7 @@ int DataFlowWalker::after(ConstructRawPtr cp) {
         for (int i = 0, nk = e->getKidCount(); i < nk; i++) {
           ExpressionPtr k = e->getNthExpr(i);
           if (k && k->is(Expression::KindOfSimpleVariable) &&
-              !boost::static_pointer_cast<SimpleVariable>(
+              !static_pointer_cast<SimpleVariable>(
                 k)->getAlwaysStash()) {
             process(k);
           }
@@ -260,13 +260,13 @@ int DataFlowWalker::after(ConstructRawPtr cp) {
 }
 
 int DataFlowWalker::afterEach(ConstructRawPtr cur, int i, ConstructRawPtr kid) {
-  if (ExpressionRawPtr k = boost::dynamic_pointer_cast<Expression>(kid)) {
+  if (ExpressionRawPtr k = dynamic_pointer_cast<Expression>(kid)) {
     if (k->is(Expression::KindOfSimpleVariable) &&
-        !boost::static_pointer_cast<SimpleVariable>(k)->getAlwaysStash()) {
-      if (ExpressionRawPtr e = boost::dynamic_pointer_cast<Expression>(cur)) {
+        !static_pointer_cast<SimpleVariable>(k)->getAlwaysStash()) {
+      if (ExpressionRawPtr e = dynamic_pointer_cast<Expression>(cur)) {
         switch (e->getKindOf()) {
           case Expression::KindOfBinaryOpExpression:
-            if (!boost::static_pointer_cast<BinaryOpExpression>(
+            if (!static_pointer_cast<BinaryOpExpression>(
                   e)->isShortCircuitOperator()) {
               return WalkContinue;
             }
@@ -350,12 +350,13 @@ void DataFlowWalker::process(ExpressionPtr e, bool doAccessChains) {
     case Expression::KindOfAssignmentExpression:
     case Expression::KindOfBinaryOpExpression:
     case Expression::KindOfUnaryOpExpression: {
-      ExpressionPtr var = e->getNthExpr(0);
+      ExpressionPtr var = e->getStoreVariable();
       if (var && var->getContext() & (Expression::AssignmentLHS|
                                       Expression::OprLValue)) {
         processAccessChain(var);
         processAccess(var);
       }
+      // fall through
     }
     default:
       processAccess(e);

hphp/compiler/analysis/data_flow.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,11 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __DATA_FLOW_H__
-#define __DATA_FLOW_H__
+#ifndef incl_HPHP_DATA_FLOW_H_
+#define incl_HPHP_DATA_FLOW_H_
 
-#include <compiler/analysis/bit_set_vec.h>
-#include <compiler/analysis/control_flow.h>
+#include "hphp/compiler/analysis/bit_set_vec.h"
+#include "hphp/compiler/analysis/control_flow.h"
 
 namespace HPHP {
 
@@ -91,7 +91,7 @@ private:
 
 class DataFlowWalker : public ControlFlowGraphWalker {
 public:
-  DataFlowWalker(ControlFlowGraph *g) : ControlFlowGraphWalker(g) {}
+  explicit DataFlowWalker(ControlFlowGraph *g) : ControlFlowGraphWalker(g) {}
 
   template<class T>
   void walk(T &t) { ControlFlowGraphWalker::walk(t); }
@@ -107,4 +107,4 @@ public:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __DATA_FLOW_H__
+#endif // incl_HPHP_DATA_FLOW_H_

hphp/compiler/analysis/depth_first_visitor.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,15 +14,15 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __DEPTH_FIRST_VISITOR_H__
-#define __DEPTH_FIRST_VISITOR_H__
+#ifndef incl_HPHP_DEPTH_FIRST_VISITOR_H_
+#define incl_HPHP_DEPTH_FIRST_VISITOR_H_
 
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/ast_walker.h>
-#include <compiler/analysis/block_scope.h>
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/ast_walker.h"
+#include "hphp/compiler/analysis/block_scope.h"
 
-#include <compiler/expression/expression.h>
-#include <compiler/statement/statement.h>
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/statement/statement.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -64,12 +64,12 @@ public:
   }
 
   StatementPtr visitStmtRecur(StatementPtr stmt) {
-    BlockScopeRawPtr scope = boost::dynamic_pointer_cast<LoopStatement>(stmt) ?
+    BlockScopeRawPtr scope = dynamic_pointer_cast<LoopStatement>(stmt) ?
       stmt->getScope() : BlockScopeRawPtr();
 
     for (int i = 0, n = stmt->getKidCount(); i < n; i++) {
       if (ConstructPtr kid = stmt->getNthKid(i)) {
-        if (StatementPtr s = boost::dynamic_pointer_cast<Statement>(kid)) {
+        if (StatementPtr s = dynamic_pointer_cast<Statement>(kid)) {
           if (FunctionWalker::SkipRecurse(s)) continue;
           if (scope) scope->incLoopNestedLevel();
           if (StatementPtr rep = visitStmtRecur(s)) {
@@ -78,7 +78,7 @@ public:
           }
           if (scope) scope->decLoopNestedLevel();
         } else {
-          ExpressionPtr e = boost::dynamic_pointer_cast<Expression>(kid);
+          ExpressionPtr e = dynamic_pointer_cast<Expression>(kid);
           if (ExpressionPtr rep = visitExprRecur(e)) {
             stmt->setNthKid(i, rep);
             stmt->getScope()->addUpdates(BlockScope::UseKindCaller);
@@ -230,4 +230,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __DEPTH_FIRST_VISITOR_H__
+#endif // incl_HPHP_DEPTH_FIRST_VISITOR_H_

hphp/compiler/analysis/dictionary.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,12 +14,12 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/alias_manager.h>
-#include <compiler/analysis/dictionary.h>
-#include <compiler/expression/expression.h>
-#include <compiler/statement/statement.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/statement_list.h>
+#include "hphp/compiler/analysis/alias_manager.h"
+#include "hphp/compiler/analysis/dictionary.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/statement_list.h"
 
 using namespace HPHP;
 using std::vector;
@@ -39,11 +39,11 @@ void Dictionary::build(MethodStatementPtr m) {
 void Dictionary::build(StatementPtr stmt) {
   for (int i = 0, n = stmt->getKidCount(); i < n; i++) {
     if (ConstructPtr kid = stmt->getNthKid(i)) {
-      if (StatementPtr s = boost::dynamic_pointer_cast<Statement>(kid)) {
+      if (StatementPtr s = dynamic_pointer_cast<Statement>(kid)) {
         if (FunctionWalker::SkipRecurse(s)) continue;
         build(s);
       } else {
-        ExpressionPtr e = boost::dynamic_pointer_cast<Expression>(kid);
+        ExpressionPtr e = dynamic_pointer_cast<Expression>(kid);
         build(e);
       }
     }

hphp/compiler/analysis/dictionary.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,11 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __DICTIONARY_H__
-#define __DICTIONARY_H__
+#ifndef incl_HPHP_DICTIONARY_H_
+#define incl_HPHP_DICTIONARY_H_
 
-#include <compiler/hphp.h>
-#include <compiler/analysis/data_flow.h>
+#include "hphp/compiler/hphp.h"
+#include "hphp/compiler/analysis/data_flow.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -32,7 +32,7 @@ class Dictionary {
 public:
   typedef std::vector<ExpressionPtr> IdMap;
 
-  Dictionary(AliasManager &am);
+  explicit Dictionary(AliasManager &am);
   void build(MethodStatementPtr s);
   void build(StatementPtr s);
   void build(ExpressionPtr s);
@@ -78,4 +78,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __DICTIONARY_H__
+#endif // incl_HPHP_DICTIONARY_H_

hphp/compiler/analysis/emitter.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,18 +14,23 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __COMPILER_EMITTER_H__
-#define __COMPILER_EMITTER_H__
+#ifndef incl_HPHP_COMPILER_EMITTER_H_
+#define incl_HPHP_COMPILER_EMITTER_H_
 
-#include <compiler/expression/expression.h>
-#include <compiler/statement/statement.h>
-#include <compiler/statement/use_trait_statement.h>
-#include <compiler/statement/trait_prec_statement.h>
-#include <compiler/statement/trait_alias_statement.h>
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/statement/use_trait_statement.h"
+#include "hphp/compiler/statement/trait_require_statement.h"
+#include "hphp/compiler/statement/trait_prec_statement.h"
+#include "hphp/compiler/statement/trait_alias_statement.h"
+#include "hphp/compiler/statement/typedef_statement.h"
 
-#include <runtime/vm/func.h>
-#include <runtime/vm/unit.h>
-#include <util/hash.h>
+#include "hphp/runtime/vm/func.h"
+#include "hphp/runtime/vm/unit.h"
+#include "hphp/util/hash.h"
+
+#include <deque>
+#include <utility>
 
 namespace HPHP {
 
@@ -40,20 +45,12 @@ DECLARE_BOOST_TYPES(SimpleFunctionCall);
 DECLARE_BOOST_TYPES(SwitchStatement);
 DECLARE_BOOST_TYPES(ForEachStatement);
 class StaticClassName;
+class HhbcExtFuncInfo;
+class HhbcExtClassInfo;
 
 namespace Compiler {
 ///////////////////////////////////////////////////////////////////////////////
 
-using VM::Offset;
-using VM::Func;
-using VM::Class;
-using VM::Unit;
-using VM::InvalidAbsoluteOffset;
-using VM::Opcode;
-using VM::Id;
-
-using namespace VM;
-
 // Forward declarations.
 class Label;
 class EmitterVisitor;
@@ -96,6 +93,13 @@ public:
     Id str;
     Label* dest;
   };
+
+  struct IterPair {
+    IterPair(IterKind k, Id i) : kind(k), id(i) {}
+    IterKind kind;
+    Id id;
+  };
+
 #define O(name, imm, pop, push, flags) \
   void name(imm);
 #define NA
@@ -107,18 +111,20 @@ public:
   typ1 a1, typ2 a2, typ3 a3
 #define FOUR(typ1, typ2, typ3, typ4) \
   typ1 a1, typ2 a2, typ3 a3, typ4 a4
-#define MA std::vector<uchar>
+#define MA std::vector<unsigned char>
 #define BLA std::vector<Label*>&
 #define SLA std::vector<StrOff>&
+#define ILA std::vector<IterPair>&
 #define IVA int32_t
-#define HA int32_t
+#define LA int32_t
 #define IA int32_t
 #define I64A int64_t
 #define DA double
 #define SA const StringData*
 #define AA ArrayData*
 #define BA Label&
-#define OA unsigned char
+#define OA(type) type
+#define VSA std::vector<std::string>&
   OPCODES
 #undef O
 #undef NA
@@ -129,8 +135,9 @@ public:
 #undef MA
 #undef BLA
 #undef SLA
+#undef ILA
 #undef IVA
-#undef HA
+#undef LA
 #undef IA
 #undef I64A
 #undef DA
@@ -138,6 +145,7 @@ public:
 #undef AA
 #undef BA
 #undef OA
+#undef VSA
 private:
   ConstructPtr m_node;
   UnitEmitter& m_ue;
@@ -284,7 +292,7 @@ public:
 class Label {
 public:
   Label() : m_off(InvalidAbsoluteOffset) {}
-  Label(Emitter& e) : m_off(InvalidAbsoluteOffset) {
+  explicit Label(Emitter& e) : m_off(InvalidAbsoluteOffset) {
     set(e);
   }
   Offset getAbsoluteOffset() const { return m_off; }
@@ -315,15 +323,138 @@ public:
 
 class Funclet {
 public:
-  Funclet(Thunklet* body, Label* entry) : m_body(body), m_entry(entry) {}
+  explicit Funclet(Thunklet* body)
+    : m_body(body) {
+  }
   Thunklet* m_body;
-  Label* m_entry;
+  Label m_entry;
+};
+
+DECLARE_BOOST_TYPES(ControlTarget);
+/*
+ * The structure represents a code path that potentially requires
+ * running finally blocks. A code path has an assigned state ID that
+ * is used inside switch statements emitted at the end of finally
+ * blocks. It also has an optional label (the destination to jump
+ * to after all the required finally blocks are run).
+ */
+struct ControlTarget {
+  static const int k_unsetState;
+  explicit ControlTarget(EmitterVisitor* router);
+  ~ControlTarget();
+  // Manage state ID reuse.
+  bool isRegistered();
+  EmitterVisitor* m_visitor;
+  // The target to jump to once all the necessary finally blocks are run.
+  Label m_label;
+  // The state ID that identifies this control target inside finally
+  // epilogues. This ID assigned to the "state" unnamed local variable.
+  int m_state;
+};
+
+struct ControlTargetInfo {
+  ControlTargetInfo() : used(false) {}
+  ControlTargetInfo(ControlTargetPtr t, bool b) : target(t), used(b) {}
+  ControlTargetPtr target;
+  bool used;
+};
+
+DECLARE_BOOST_TYPES(Region);
+/*
+ * Region represents a single level of the unified stack
+ * of constructs that are meaningful from the point of view of finally
+ * implementation. The levels are used to keep track of the information
+ * such as the control targets that can be taken inside a block.
+ */
+class Region {
+public:
+  enum Kind {
+    // Top-level (global) context.
+    Global,
+    // Function body / method body entry.
+    FuncBody,
+    // Entry for finally fault funclets emitted after the body of
+    // a function
+    FaultFunclet,
+    // Region by a finally clause
+    TryFinally,
+    // Finally block entry (begins after catches ends after finally)
+    Finally,
+    // Loop or switch statement.
+    LoopOrSwitch,
+  };
+
+  typedef Emitter::IterPair IterPair;
+  typedef std::vector<IterPair> IterVec;
+
+  Region(Region::Kind kind, RegionPtr parent);
+
+  // Helper for establishing the maximal depth of break / continue
+  // control targets that are allocated.
+  int getBreakContinueDepth();
+
+  // Returns the maximal break / continue depth admissable (aka the
+  // number of nested loops).
+  int getMaxBreakContinueDepth();
+
+  int getMaxState();
+
+  // The number of cases to be emitted. This is a helper used in
+  // establishing whether one of the optimized cases can be used.
+  int getCaseCount();
+
+  bool isForeach() { return m_iterId != -1; }
+  bool isTryFinally() { return m_kind == Region::Kind::TryFinally; }
+  bool isFinally() { return m_kind == Region::Kind::Finally; }
+
+  bool isBreakUsed(int i) {
+    auto it = m_breakTargets.find(i);
+    if (it == m_breakTargets.end()) return false;
+    return it->second.used;
+  }
+
+  bool isContinueUsed(int i) {
+    auto it = m_continueTargets.find(i);
+    if (it == m_continueTargets.end()) return false;
+    return it->second.used;
+  }
+
+  Region::Kind m_kind;
+  // Only used for loop / break kind of entries.
+  Id m_iterId;
+  IterKind m_iterKind;
+  // Because of a bug in code emission, functions sometimes have
+  // inconsistent return flavors. Therefore instead of a single
+  // return control target, there need to be one return control
+  // target per flavor used. Once the bug is removed, this code
+  // can be simplified.
+  std::map<char, ControlTargetInfo> m_returnTargets;
+  // Break and continue control targets identified by their depth.
+  std::map<int, ControlTargetInfo> m_breakTargets;
+  std::map<int, ControlTargetInfo> m_continueTargets;
+  // Goto control targets. Each goto control target is identified
+  // by the name of the destination label.
+  std::map<StringData*, ControlTargetInfo, string_data_lt> m_gotoTargets;
+  // A set of goto labels occurrning inside the statement represented
+  // by this entry. This value is used for establishing whether
+  // a finally block needs to be executed when performing gotos.
+  std::set<StringData*, string_data_lt> m_gotoLabels;
+  // The label denoting the beginning of a finally block inside the
+  // current try. Only used when the entry kind is a try statement.
+  Label m_finallyLabel;
+  // The parent entry.
+  RegionPtr m_parent;
 };
 
 class EmitterVisitor {
   friend class UnsetUnnamedLocalThunklet;
+  friend class FuncFinisher;
 public:
-  EmitterVisitor(UnitEmitter& ue);
+  typedef std::vector<int> IndexChain;
+  typedef Emitter::IterPair IterPair;
+  typedef std::vector<IterPair> IterVec;
+
+  explicit EmitterVisitor(UnitEmitter& ue);
   ~EmitterVisitor();
 
   bool visit(ConstructPtr c);
@@ -331,9 +462,10 @@ public:
   void visitKids(ConstructPtr c);
   void visit(FileScopePtr file);
   void assignLocalVariableIds(FunctionScopePtr fs);
+  void assignFinallyVariableIds();
   void fixReturnType(Emitter& e, FunctionCallPtr fn,
-                     bool isBuiltinCall = false);
-  typedef std::vector<int> IndexChain;
+                     Func* builtinFunc = nullptr);
+
   void visitListAssignmentLHS(Emitter& e, ExpressionPtr exp,
                               IndexChain& indexChain,
                               std::vector<IndexChain*>& chainList);
@@ -347,9 +479,10 @@ public:
   }
   bool evalStackIsUnknown() { return m_evalStackIsUnknown; }
   void popEvalStack(char symFlavor, int arg = -1, int pos = -1);
-  void popSymbolicLocal(Opcode opcode, int arg = -1, int pos = -1);
-  void popEvalStackLMany();
+  void popSymbolicLocal(Op opcode, int arg = -1, int pos = -1);
+  void popEvalStackMMany();
   void popEvalStackMany(int len, char symFlavor);
+  void popEvalStackCVMany(int len);
   void pushEvalStack(char symFlavor);
   void peekEvalStack(char symFlavor, int depthActual);
   void pokeEvalStack(char symFlavor, int depthActual);
@@ -359,40 +492,51 @@ public:
     recordJumpTarget(target, m_evalStack);
   }
   void restoreJumpTargetEvalStack();
+  void recordCall();
   bool isJumpTarget(Offset target);
-  void setPrevOpcode(Opcode op) { m_prevOpcode = op; }
-  Opcode getPrevOpcode() const { return m_prevOpcode; }
+  void setPrevOpcode(Op op) { m_prevOpcode = op; }
+  Op getPrevOpcode() const { return m_prevOpcode; }
   bool currentPositionIsReachable() {
     return (m_ue.bcPos() == m_curFunc->base()
             || isJumpTarget(m_ue.bcPos())
             || (instrFlags(getPrevOpcode()) & TF) == 0);
   }
+  FuncEmitter* getFuncEmitter() { return m_curFunc; }
+  Id getStateLocal() {
+    assert(m_stateLocal >= 0);
+    return m_stateLocal;
+  }
+  Id getRetLocal() {
+    assert(m_retLocal >= 0);
+    return m_retLocal;
+  }
 
   class IncludeTimeFatalException : public Exception {
   public:
     ConstructPtr m_node;
+    bool m_parseFatal;
     IncludeTimeFatalException(ConstructPtr node, const char* fmt, ...)
-        : Exception(), m_node(node) {
+        : Exception(), m_node(node), m_parseFatal(false) {
       va_list ap; va_start(ap, fmt); format(fmt, ap); va_end(ap);
     }
     virtual ~IncludeTimeFatalException() throw() {}
     EXCEPTION_COMMON_IMPL(IncludeTimeFatalException);
+    void setParseFatal(bool b = true) { m_parseFatal = b; }
   };
 
-  enum IterKind {
-    KindOfIter = 0,
-    KindOfMIter = 1
-  };
-
-  void pushIterScope(Id id, bool itRef = false) {
-    IterKind itKind = itRef ? KindOfMIter : KindOfIter;
-    m_pendingIters.push_back(std::pair<Id,IterKind>(id,itKind));
+  void pushIterScope(Id id, IterKind kind) {
+    m_pendingIters.emplace_back(id, kind);
   }
   void popIterScope() { m_pendingIters.pop_back(); }
+
 private:
   typedef std::pair<StringData*, bool> ClosureUseVar;  // (name, byRef)
   typedef std::vector<ClosureUseVar> ClosureUseVarVec;
   typedef std::vector<std::pair<Id,IterKind> > PendingIterVec;
+  typedef std::pair<StringData*, ExpressionPtr> NonScalarPair;
+  typedef std::vector<NonScalarPair> NonScalarVec;
+  typedef std::pair<Id, int> StrCase;
+
   class PostponedMeth {
   public:
     PostponedMeth(MethodStatementPtr m, FuncEmitter* fe, bool top,
@@ -403,6 +547,7 @@ private:
     bool m_top;
     ClosureUseVarVec* m_closureUseVars;
   };
+
   class PostponedCtor {
   public:
     PostponedCtor(InterfaceStatementPtr is, FuncEmitter* fe)
@@ -410,8 +555,7 @@ private:
     InterfaceStatementPtr m_is;
     FuncEmitter* m_fe;
   };
-  typedef std::pair<StringData*, ExpressionPtr> NonScalarPair;
-  typedef std::vector<NonScalarPair> NonScalarVec;
+
   class PostponedNonScalars {
   public:
     PostponedNonScalars(InterfaceStatementPtr is, FuncEmitter* fe,
@@ -424,6 +568,7 @@ private:
     FuncEmitter* m_fe;
     NonScalarVec* m_vec;
   };
+
   class PostponedClosureCtor {
   public:
     PostponedClosureCtor(ClosureUseVarVec& v, ClosureExpressionPtr e,
@@ -433,37 +578,12 @@ private:
     ClosureExpressionPtr m_expr;
     FuncEmitter* m_fe;
   };
-  class ControlTargets {
+
+  class CatchRegion {
   public:
-    ControlTargets(Id itId, bool itRef, Label& brkTarg, Label& cntTarg,
-                   Label& brkHand, Label& cntHand) :
-        m_itId(itId), m_itRef(itRef), m_brkTarg(brkTarg), m_cntTarg(cntTarg),
-        m_brkHand(brkHand), m_cntHand(cntHand) {}
-    Id m_itId;
-    bool m_itRef;
-    Label& m_brkTarg;  // Jump here for "break;" (after doing IterFree)
-    Label& m_cntTarg;  // Jump here for "continue;"
-    Label& m_brkHand;  // Push N and jump here for "break N;"
-    Label& m_cntHand;  // Push N and jump here for "continue N;"
-  };
-  class ControlTargetPusher {
-  public:
-    ControlTargetPusher(EmitterVisitor* e, Id itId, bool itRef, Label& brkTarg,
-        Label& cntTarg, Label& brkHand, Label& cntHand) : m_e(e) {
-      e->m_contTargets.push_front(ControlTargets(itId, itRef, brkTarg, cntTarg,
-            brkHand, cntHand));
-    }
-    ~ControlTargetPusher() {
-      m_e->m_contTargets.pop_front();
-    }
-  private:
-    EmitterVisitor* m_e;
-  };
-  class ExnHandlerRegion {
-  public:
-    ExnHandlerRegion(Offset start, Offset end) : m_start(start),
+    CatchRegion(Offset start, Offset end) : m_start(start),
       m_end(end) {}
-    ~ExnHandlerRegion() {
+    ~CatchRegion() {
       for (std::vector<std::pair<StringData*, Label*> >::const_iterator it =
              m_catchLabels.begin(); it != m_catchLabels.end(); it++) {
         delete it->second;
@@ -474,15 +594,27 @@ private:
     std::set<StringData*, string_data_lt> m_names;
     std::vector<std::pair<StringData*, Label*> > m_catchLabels;
   };
+
   class FaultRegion {
   public:
-    FaultRegion(Offset start, Offset end, Id iterId)
-     : m_start(start), m_end(end), m_iterId(iterId) {}
+    FaultRegion(Offset start,
+                Offset end,
+                Label* func,
+                Id iterId,
+                IterKind kind)
+      : m_start(start)
+      , m_end(end)
+      , m_func(func)
+      , m_iterId(iterId)
+      , m_iterKind(kind) {}
+
     Offset m_start;
     Offset m_end;
+    Label* m_func;
     Id m_iterId;
-    Label m_func;
+    IterKind m_iterKind;
   };
+
   class FPIRegion {
     public:
       FPIRegion(Offset start, Offset end, Offset fpOff)
@@ -491,7 +623,7 @@ private:
       Offset m_end;
       Offset m_fpOff;
   };
-  typedef std::pair<Id, int> StrCase;
+
   struct SwitchState : private boost::noncopyable {
     SwitchState() : nonZeroI(-1), defI(-1) {}
     std::map<int64_t, int> cases; // a map from int (or litstr id) to case index
@@ -502,12 +634,13 @@ private:
     int defI;
   };
 
+private:
   static const size_t kMinStringSwitchCases = 8;
   UnitEmitter& m_ue;
   FuncEmitter* m_curFunc;
   FileScopePtr m_file;
 
-  Opcode m_prevOpcode;
+  Op m_prevOpcode;
 
   std::deque<PostponedMeth> m_postponedMeths;
   std::deque<PostponedCtor> m_postponedCtors;
@@ -516,33 +649,44 @@ private:
   std::deque<PostponedNonScalars> m_postponedCinits;
   std::deque<PostponedClosureCtor> m_postponedClosureCtors;
   PendingIterVec m_pendingIters;
-  typedef std::map<const StringData*, Label*, string_data_lt> LabelMap;
-  LabelMap m_methLabels;
+  hphp_hash_map<std::string,FuncEmitter*> m_generatorEmitted;
+  hphp_hash_set<std::string> m_nonTopGeneratorEmitted;
+  hphp_hash_set<std::string> m_topMethodEmitted;
   SymbolicStack m_evalStack;
   bool m_evalStackIsUnknown;
   hphp_hash_map<Offset, SymbolicStack> m_jumpTargetEvalStacks;
   int m_actualStackHighWater;
   int m_fdescHighWater;
-  int m_closureCounter;  // used to uniquify closures' mangled names
-  std::deque<ControlTargets> m_contTargets;
-  std::deque<Funclet> m_funclets;
-  std::deque<ExnHandlerRegion*> m_exnHandlers;
+  typedef tbb::concurrent_hash_map<const StringData*, int,
+                                   StringDataHashCompare> EmittedClosures;
+  static EmittedClosures s_emittedClosures;
+  std::deque<Funclet*> m_funclets;
+  std::map<StatementPtr, Funclet*> m_memoizedFunclets;
+  std::deque<CatchRegion*> m_catchRegions;
   std::deque<FaultRegion*> m_faultRegions;
   std::deque<FPIRegion*> m_fpiRegions;
-  std::vector<HphpArray*> m_staticArrays;
+  std::vector<Array> m_staticArrays;
   std::set<std::string,stdltistr> m_hoistables;
   LocationPtr m_tempLoc;
-  std::map<StringData*, Label, string_data_lt> m_gotoLabels;
-  MetaInfoBuilder m_metaInfo;
-public:
-  Label& topBreakHandler() { return m_contTargets.front().m_brkHand; }
-  Label& topContHandler() { return m_contTargets.front().m_cntHand; }
+  std::vector<Label> m_yieldLabels;
 
+  // The stack of all Regions that this EmitterVisitor is currently inside
+  std::vector<RegionPtr> m_regions;
+  // The state IDs currently allocated for the "finally router" logic.
+  // See FIXME above the registerControlTarget() method.
+  std::set<int> m_states;
+  // Unnamed local variables used by the "finally router" logic
+  Id m_stateLocal;
+  Id m_retLocal;
+
+  MetaInfoBuilder m_metaInfo;
+
+public:
   bool checkIfStackEmpty(const char* forInstruction) const;
   void unexpectedStackSym(char sym, const char* where) const;
 
   int scanStackForLocation(int iLast);
-  void buildVectorImm(std::vector<uchar>& vectorImm,
+  void buildVectorImm(std::vector<unsigned char>& vectorImm,
                       int iFirst, int iLast, bool allowW,
                       Emitter& e);
   enum class PassByRefKind {
@@ -554,25 +698,20 @@ public:
   void emitAGet(Emitter& e);
   void emitCGetL2(Emitter& e);
   void emitCGetL3(Emitter& e);
+  void emitPushL(Emitter& e);
   void emitCGet(Emitter& e);
   void emitVGet(Emitter& e);
   void emitIsset(Emitter& e);
-  void emitIsNull(Emitter& e);
-  void emitIsArray(Emitter& e);
-  void emitIsObject(Emitter& e);
-  void emitIsString(Emitter& e);
-  void emitIsInt(Emitter& e);
-  void emitIsDouble(Emitter& e);
-  void emitIsBool(Emitter& e);
+  void emitIsType(Emitter& e, IsTypeOp op);
   void emitEmpty(Emitter& e);
-  void emitUnset(Emitter& e);
+  void emitUnset(Emitter& e, ExpressionPtr exp = ExpressionPtr());
+  void emitVisitAndUnset(Emitter& e, ExpressionPtr exp);
   void emitSet(Emitter& e);
   void emitSetOp(Emitter& e, int op);
   void emitBind(Emitter& e);
-  void emitIncDec(Emitter& e, unsigned char cop);
+  void emitIncDec(Emitter& e, IncDecOp cop);
   void emitPop(Emitter& e);
   void emitConvertToCell(Emitter& e);
-  void emitFreePendingIters(Emitter& e);
   void emitConvertToCellIfVar(Emitter& e);
   void emitConvertToCellOrLoc(Emitter& e);
   void emitConvertSecondToCell(Emitter& e);
@@ -582,8 +721,10 @@ public:
   template<class Expr> void emitVirtualClassBase(Emitter&, Expr* node);
   void emitResolveClsBase(Emitter& e, int pos);
   void emitClsIfSPropBase(Emitter& e);
-  Label* getContinuationGotoLabel(StatementPtr s);
-  void emitContinuationSwitch(Emitter& e, SwitchStatementPtr s);
+  Id emitVisitAndSetUnnamedL(Emitter& e, ExpressionPtr exp);
+  Id emitSetUnnamedL(Emitter& e);
+  void emitPushAndFreeUnnamedL(Emitter& e, Id tempLocal, Offset start);
+  void emitContinuationSwitch(Emitter& e, int ncase);
   DataType analyzeSwitch(SwitchStatementPtr s, SwitchState& state);
   void emitIntegerSwitch(Emitter& e, SwitchStatementPtr s,
                          std::vector<Label>& caseLabels, Label& done,
@@ -610,6 +751,32 @@ public:
   void postponeSinit(InterfaceStatementPtr m, FuncEmitter* fe, NonScalarVec* v);
   void postponeCinit(InterfaceStatementPtr m, FuncEmitter* fe, NonScalarVec* v);
   void emitPostponedMeths();
+  void bindUserAttributes(MethodStatementPtr meth,
+                          FuncEmitter *fe,
+                          bool &allowOverride);
+  void bindNativeFunc(MethodStatementPtr meth, FuncEmitter *fe);
+  void emitMethodMetadata(MethodStatementPtr meth,
+                          ClosureUseVarVec* useVars,
+                          bool top);
+  void fillFuncEmitterParams(FuncEmitter* fe,
+                             ExpressionListPtr params,
+                             bool builtin = false);
+  void emitMethodPrologue(Emitter& e, MethodStatementPtr meth);
+  void emitMethod(MethodStatementPtr meth);
+  std::pair<FuncEmitter*,bool> createFuncEmitterForGeneratorBody(
+                 MethodStatementPtr meth,
+                 FuncEmitter* fe,
+                 vector<FuncEmitter*>& top_fes);
+  void emitAsyncMethod(MethodStatementPtr meth);
+  void emitGeneratorCreate(MethodStatementPtr meth);
+  void emitGeneratorBody(MethodStatementPtr meth);
+  void emitConstMethodCallNoParams(Emitter& e, string name);
+  void emitCreateStaticWaitHandle(Emitter& e, std::string cls,
+                                  std::function<void()> emitParam);
+  void emitSetFuncGetArgs(Emitter& e);
+  void emitMethodDVInitializers(Emitter& e,
+                                MethodStatementPtr& meth,
+                                Label& topOfBody);
   void emitPostponedCtors();
   void emitPostponedPSinit(PostponedNonScalars& p, bool pinit);
   void emitPostponedPinits();
@@ -629,31 +796,94 @@ public:
   };
 
   bool emitCallUserFunc(Emitter& e, SimpleFunctionCallPtr node);
-  bool canEmitBuiltinCall(FunctionCallPtr fn, const std::string& name,
-                          int numParams);
-  void emitFuncCall(Emitter& e, FunctionCallPtr node);
+  Func* canEmitBuiltinCall(const std::string& name, int numParams);
+  void emitFuncCall(Emitter& e, FunctionCallPtr node,
+                    const char* nameOverride = nullptr,
+                    ExpressionListPtr paramsOverride = nullptr);
   void emitFuncCallArg(Emitter& e, ExpressionPtr exp, int paramId);
   void emitBuiltinCallArg(Emitter& e, ExpressionPtr exp, int paramId,
                          bool byRef);
   void emitBuiltinDefaultArg(Emitter& e, Variant& v, DataType t, int paramId);
-  PreClass::Hoistable emitClass(Emitter& e, ClassScopePtr cNode,
-                                bool topLevel);
-  void emitBreakHandler(Emitter& e, Label& brkTarg, Label& cntTarg,
-                        Label& brkHand, Label& cntHand, Id iter = -1,
-                        IterKind itKind = KindOfIter);
+  void emitClass(Emitter& e, ClassScopePtr cNode, bool topLevel);
+  void emitTypedef(Emitter& e, TypedefStatementPtr);
+  void emitForeachListAssignment(Emitter& e,
+                                 ListAssignmentPtr la,
+                                 int vLocalId);
   void emitForeach(Emitter& e, ForEachStatementPtr fe);
   void emitRestoreErrorReporting(Emitter& e, Id oldLevelLoc);
-  void emitMakeUnitFatal(Emitter& e, const std::string& message);
+  void emitMakeUnitFatal(Emitter& e,
+                         const char* msg,
+                         FatalOp k = FatalOp::Runtime);
 
-  void addFunclet(Thunklet* body, Label* entry);
+  // Emits a Jmp or IterBreak instruction to the specified target, freeing
+  // the specified iterator variables. emitJump() cannot be used to leave a
+  // try region, except if it jumps to the m_finallyLabel of the try region.
+  void emitJump(Emitter& e, IterVec& iters, Label& target);
+
+  // These methods handle the return, break, continue, and goto operations.
+  // These methods are aware of try/finally blocks and foreach blocks and
+  // will free iterators and jump to finally epilogues as appropriate.
+  void emitReturn(Emitter& e, char sym, StatementPtr s);
+  void emitBreak(Emitter& e, int depth, StatementPtr s);
+  void emitContinue(Emitter& e, int depth, StatementPtr s);
+  void emitGoto(Emitter& e, StringData* name, StatementPtr s);
+
+  // Helper methods for emitting IterFree instructions
+  void emitIterFree(Emitter& e, IterVec& iters);
+  void emitIterFreeForReturn(Emitter& e);
+
+  // A "finally epilogue" is a blob of bytecode that comes after an inline
+  // copy of a "finally" clause body. Finally epilogues are used to ensure
+  // that that the bodies of finally clauses are executed whenever a return,
+  // break, continue, or goto operation jumps out of their corresponding
+  // "try" blocks.
+  void emitFinallyEpilogue(Emitter& e, Region* entry);
+  void emitReturnTrampoline(Emitter& e, Region* entry,
+                            std::vector<Label*>& cases, char sym);
+  void emitBreakTrampoline(Emitter& e, Region* entry,
+                           std::vector<Label*>& cases, int depth);
+  void emitContinueTrampoline(Emitter& e, Region* entry,
+                              std::vector<Label*>& cases, int depth);
+  void emitGotoTrampoline(Emitter& e, Region* entry,
+                          std::vector<Label*>& cases, StringData* name);
+
+  Funclet* addFunclet(Thunklet* body);
+  Funclet* addFunclet(StatementPtr stmt,
+                      Thunklet* body);
+  Funclet* getFunclet(StatementPtr stmt);
   void emitFunclets(Emitter& e);
-  void newFaultRegion(Offset start, Offset end, Thunklet* t, Id iter = -1);
+
+  struct FaultIterInfo {
+    Id iterId;
+    IterKind kind;
+  };
+
+  void newFaultRegion(Offset start,
+                      Offset end,
+                      Label* entry,
+                      FaultIterInfo = FaultIterInfo { -1, KindOfIter });
+  void newFaultRegion(StatementPtr stmt,
+                      Offset start,
+                      Offset end,
+                      Label* entry,
+                      FaultIterInfo = FaultIterInfo { -1, KindOfIter });
+  void
+  newFaultRegionAndFunclet(Offset start,
+                           Offset end,
+                           Thunklet* t,
+                           FaultIterInfo = FaultIterInfo { -1, KindOfIter });
+  void
+  newFaultRegionAndFunclet(StatementPtr stmt,
+                           Offset start,
+                           Offset end,
+                           Thunklet* t,
+                           FaultIterInfo = FaultIterInfo { -1, KindOfIter });
+
   void newFPIRegion(Offset start, Offset end, Offset fpOff);
-  void copyOverExnHandlers(FuncEmitter* fe);
+  void copyOverCatchAndFaultRegions(FuncEmitter* fe);
   void copyOverFPIRegions(FuncEmitter* fe);
   void saveMaxStackCells(FuncEmitter* fe);
   void finishFunc(Emitter& e, FuncEmitter* fe);
-  StringData* newClosureName();
 
   void initScalar(TypedValue& tvVal, ExpressionPtr val);
   bool requiresDeepInit(ExpressionPtr initExpr) const;
@@ -662,11 +892,37 @@ public:
   void emitClassTraitAliasRule(PreClassEmitter* pce,
                                TraitAliasStatementPtr rule);
   void emitClassUseTrait(PreClassEmitter* pce, UseTraitStatementPtr useStmt);
+
+  // Helper function for creating entries.
+  RegionPtr createRegion(StatementPtr s, Region::Kind kind);
+  // Enter/leave the passed in entry. Note that entries sometimes need be
+  // to be constructed before they are entered, or need to be accessed
+  // after they are left. This especially applies to constructs such
+  // as loops and try blocks.
+  void enterRegion(RegionPtr);
+  void leaveRegion(RegionPtr);
+
+  // Functions used for handling state IDs allocation.
+  // FIXME (#3275259): This should be moved into global / func
+  // body / fault funclet entries in order to optimize state
+  // allocation. See the task description for more details.
+  void registerControlTarget(ControlTarget* t);
+  void unregisterControlTarget(ControlTarget* t);
+
+  void registerReturn(StatementPtr s, Region* entry, char sym);
+  void registerYieldAwait(ExpressionPtr e);
+  ControlTargetPtr registerBreak(StatementPtr s, Region* entry, int depth,
+                                 bool alloc);
+  ControlTargetPtr registerContinue(StatementPtr s, Region* entry, int depth,
+                                    bool alloc);
+  ControlTargetPtr registerGoto(StatementPtr s, Region* entry,
+                                StringData* name, bool alloc);
 };
 
 void emitAllHHBC(AnalysisResultPtr ar);
 
 extern "C" {
+  String hphp_compiler_serialize_code_model_for(String code, String prefix);
   Unit* hphp_compiler_parse(const char* code, int codeLen, const MD5& md5,
                             const char* filename);
   Unit* hphp_build_native_func_unit(const HhbcExtFuncInfo* builtinFuncs,
@@ -679,4 +935,4 @@ extern "C" {
 }
 }
 
-#endif // __COMPILER_EMITTER_H__
+#endif // incl_HPHP_COMPILER_EMITTER_H_

hphp/compiler/analysis/expr_dict.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,14 +14,14 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/alias_manager.h>
-#include <compiler/analysis/expr_dict.h>
+#include "hphp/compiler/analysis/expr_dict.h"
+#include "hphp/compiler/analysis/alias_manager.h"
 
-#include <compiler/expression/expression.h>
-#include <compiler/expression/assignment_expression.h>
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/assignment_expression.h"
 
-#include <compiler/statement/statement.h>
-#include <compiler/statement/method_statement.h>
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/statement/method_statement.h"
 
 using namespace HPHP;
 using std::vector;
@@ -59,7 +59,7 @@ void ExprDict::getTypes(ExpressionPtr e, TypePtrIdxPairVec &types) {
 
 class TypeFunc { public:
   bool operator()(const TypePtrIdxPair& entry) const {
-    return entry.first;
+    return entry.first != nullptr;
   }
 };
 static TypeFunc s_type_func;
@@ -313,7 +313,7 @@ void ExprDict::updateAccess(ExpressionPtr e) {
             BitOps::set_bit(aid, m_altered, true);
           }
           if (!(cls & Expression::Store) ||
-              a != e->getNthExpr(0)) {
+              a != e->getStoreVariable()) {
             a->clearAvailable();
             m_avlAccess[i] = m_avlAccess[--n];
             m_avlAccess.resize(n);

hphp/compiler/analysis/expr_dict.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,10 +14,10 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __EXPR_DICT_H__
-#define __EXPR_DICT_H__
+#ifndef incl_HPHP_EXPR_DICT_H_
+#define incl_HPHP_EXPR_DICT_H_
 
-#include <compiler/analysis/dictionary.h>
+#include "hphp/compiler/analysis/dictionary.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -27,7 +27,7 @@ typedef std::vector<TypePtrIdxPair> TypePtrIdxPairVec;
 
 class ExprDict : public Dictionary {
 public:
-  ExprDict(AliasManager &am);
+  explicit ExprDict(AliasManager &am);
   /* Building the dictionary */
   void build(MethodStatementPtr m);
   void visit(ExpressionPtr e);
@@ -43,8 +43,8 @@ public:
   TypePtr propagateType(ExpressionPtr e);
 
   void getTypes(ExpressionPtr e, TypePtrIdxPairVec &types);
-private:
 
+private:
   /**
    * types is filled with (type assertion, canon id for that type assertion)
    * tuples
@@ -94,4 +94,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __EXPR_DICT_H__
+#endif // incl_HPHP_EXPR_DICT_H_

hphp/compiler/analysis/file_scope.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -13,38 +13,40 @@
    | license@php.net so we can mail you a copy immediately.               |
    +----------------------------------------------------------------------+
 */
+#include "hphp/compiler/analysis/file_scope.h"
 
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/statement/exp_statement.h>
-#include <compiler/option.h>
-#include <compiler/analysis/constant_table.h>
-#include <compiler/analysis/function_scope.h>
 #include <sys/stat.h>
-#include <compiler/parser/parser.h>
-#include <util/logger.h>
-#include <util/util.h>
-#include <util/base.h>
-#include <compiler/expression/expression_list.h>
-#include <compiler/statement/function_statement.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/expression/simple_function_call.h>
-#include <compiler/expression/include_expression.h>
-#include <compiler/expression/user_attribute.h>
-#include <runtime/base/complex_types.h>
+#include "folly/ScopeGuard.h"
 
-using namespace HPHP;
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/lambda_names.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/statement/exp_statement.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/analysis/constant_table.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/util/logger.h"
+#include "hphp/util/util.h"
+#include "hphp/util/deprecated/base.h"
+#include "hphp/compiler/expression/expression_list.h"
+#include "hphp/compiler/statement/function_statement.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/compiler/expression/include_expression.h"
+#include "hphp/compiler/expression/user_attribute.h"
+#include "hphp/runtime/base/complex-types.h"
+
+namespace HPHP {
 
 ///////////////////////////////////////////////////////////////////////////////
 
 FileScope::FileScope(const string &fileName, int fileSize, const MD5 &md5)
   : BlockScope("", "", StatementPtr(), BlockScope::FileScope),
-    m_size(fileSize), m_md5(md5), m_module(false), m_privateInclude(false),
-    m_externInclude(false),
-    m_includeState(0), m_fileName(fileName), m_redeclaredFunctions(0) {
+    m_size(fileSize), m_md5(md5), m_includeState(0), m_system(false),
+    m_fileName(fileName), m_redeclaredFunctions(0) {
   pushAttribute(); // for global scope
 }
 
@@ -66,6 +68,11 @@ void FileScope::setFileLevel(StatementListPtr stmtList) {
   }
 }
 
+void FileScope::setSystem() {
+  m_fileName = "/:" + m_fileName;
+  m_system = true;
+}
+
 FunctionScopePtr FileScope::setTree(AnalysisResultConstPtr ar,
                                     StatementListPtr tree) {
   m_tree = tree;
@@ -73,8 +80,7 @@ FunctionScopePtr FileScope::setTree(AnalysisResultConstPtr ar,
   return createPseudoMain(ar);
 }
 
-void FileScope::cleanupForError(AnalysisResultConstPtr ar,
-                                int line, const string &msg) {
+void FileScope::cleanupForError(AnalysisResultConstPtr ar) {
   for (StringToClassScopePtrVecMap::const_iterator iter = m_classes.begin();
        iter != m_classes.end(); ++iter) {
     BOOST_FOREACH(ClassScopePtr cls, iter->second) {
@@ -90,25 +96,49 @@ void FileScope::cleanupForError(AnalysisResultConstPtr ar,
   StringToClassScopePtrVecMap().swap(m_classes);
   m_pseudoMain.reset();
   m_tree.reset();
+}
+
+template <class Meth>
+void makeFatalMeth(FileScope& file,
+                   AnalysisResultConstPtr ar,
+                   const std::string& msg,
+                   int line,
+                   Meth meth) {
   LocationPtr loc(new Location());
-  loc->file = m_fileName.c_str();
+  LabelScopePtr labelScope(new LabelScope());
+  loc->file = file.getName().c_str();
   loc->first(line, 0);
   loc->last(line, 0);
   BlockScopePtr scope;
   ExpressionListPtr args(new ExpressionList(scope, loc));
   args->addElement(Expression::MakeScalarExpression(ar, scope, loc, msg));
   SimpleFunctionCallPtr e(
-    new SimpleFunctionCall(scope, loc, "throw_fatal", args, ExpressionPtr()));
-  e->setThrowFatal();
-  ExpStatementPtr exp(new ExpStatement(scope, loc, e));
-  StatementListPtr stmts(new StatementList(scope, loc));
+    new SimpleFunctionCall(scope, loc, "throw_fatal", false, args,
+      ExpressionPtr()));
+  meth(e);
+  ExpStatementPtr exp(new ExpStatement(scope, labelScope, loc, e));
+  StatementListPtr stmts(new StatementList(scope, labelScope, loc));
   stmts->addElement(exp);
 
-  FunctionScopePtr fs = setTree(ar, stmts);
-  fs->setOuterScope(shared_from_this());
+  FunctionScopePtr fs = file.setTree(ar, stmts);
+  fs->setOuterScope(file.shared_from_this());
   fs->getStmt()->resetScope(fs);
   fs->getStmt()->setLocation(loc);
-  setOuterScope(const_cast<AnalysisResult*>(ar.get())->shared_from_this());
+  file.setOuterScope(const_cast<AnalysisResult*>(ar.get())->shared_from_this());
+}
+
+void FileScope::makeFatal(AnalysisResultConstPtr ar,
+                          const std::string& msg,
+                          int line) {
+  auto meth = [](SimpleFunctionCallPtr e) { e->setThrowFatal(); };
+  makeFatalMeth(*this, ar, msg, line, meth);
+}
+
+void FileScope::makeParseFatal(AnalysisResultConstPtr ar,
+                               const std::string& msg,
+                               int line) {
+  auto meth = [](SimpleFunctionCallPtr e) { e->setThrowParseFatal(); };
+  makeFatalMeth(*this, ar, msg, line, meth);
 }
 
 bool FileScope::addFunction(AnalysisResultConstPtr ar,
@@ -192,13 +222,6 @@ int FileScope::getGlobalAttribute() const {
   return m_attributes.back();
 }
 
-bool FileScope::needPseudoMainVariables() const {
-  VariableTablePtr variables = m_pseudoMain->getVariables();
-  return
-    variables->getAttribute(VariableTable::ContainsDynamicVariable) ||
-    variables->getSymbols().size() > 0;
-}
-
 ///////////////////////////////////////////////////////////////////////////////
 
 ExpressionPtr FileScope::getEffectiveImpl(AnalysisResultConstPtr ar) const {
@@ -239,9 +262,10 @@ void FileScope::addConstantDependency(AnalysisResultPtr ar,
 }
 
 void FileScope::analyzeProgram(AnalysisResultPtr ar) {
-  if (m_pseudoMain) {
-    m_pseudoMain->getStmt()->analyzeProgram(ar);
-  }
+  if (!m_pseudoMain) return;
+  m_pseudoMain->getStmt()->analyzeProgram(ar);
+
+  resolve_lambda_names(ar, shared_from_this());
 }
 
 ClassScopeRawPtr FileScope::resolveClass(ClassScopeRawPtr cls) {
@@ -306,80 +330,80 @@ bool FileScope::insertClassUtil(AnalysisResultPtr ar,
 
 void FileScope::analyzeIncludesHelper(AnalysisResultPtr ar) {
   m_includeState = 1;
-  if (m_pseudoMain) {
-    StatementList &stmts = *getStmt();
-    bool hoistOnly = false;
-    for (int i = 0, n = stmts.getCount(); i < n; i++) {
-      StatementPtr s = stmts[i];
-      if (!s) continue;
-      if (s->is(Statement::KindOfClassStatement) ||
-          s->is(Statement::KindOfInterfaceStatement)) {
+  SCOPE_EXIT { m_includeState = 2; };
 
-        ClassScopeRawPtr cls(
-          static_pointer_cast<InterfaceStatement>(s)->getClassScope());
-        if (hoistOnly) {
-          const string &parent = cls->getOriginalParent();
-          if (cls->getBases().size() > (parent.empty() ? 0 : 1)) {
-            continue;
-          }
-          if (!parent.empty()) {
-            ClassScopeRawPtr c = ar->findClass(parent);
-            if (!c || (c->isVolatile() &&
-                       !resolveClass(c) && !checkClass(parent))) {
-              continue;
-            }
-          }
+  if (!m_pseudoMain) return;
+
+  StatementList &stmts = *getStmt();
+  bool hoistOnly = false;
+
+  for (int i = 0, n = stmts.getCount(); i < n; i++) {
+    StatementPtr s = stmts[i];
+    if (!s) continue;
+
+    if (s->is(Statement::KindOfClassStatement) ||
+        s->is(Statement::KindOfInterfaceStatement)) {
+      ClassScopeRawPtr cls(
+        static_pointer_cast<InterfaceStatement>(s)->getClassScope());
+      if (hoistOnly) {
+        const string &parent = cls->getOriginalParent();
+        if (cls->getBases().size() > (parent.empty() ? 0 : 1)) {
+          continue;
         }
-        if (cls->isVolatile()) {
-          insertClassUtil(ar, cls, true);
-        }
-        continue;
-      }
-      if (s->is(Statement::KindOfFunctionStatement)) {
-        FunctionScopeRawPtr func(
-          static_pointer_cast<FunctionStatement>(s)->getFunctionScope());
-        if (func->isVolatile()) m_providedDefs.insert(func);
-        continue;
-      }
-      if (!hoistOnly && s->is(Statement::KindOfExpStatement)) {
-        ExpressionRawPtr exp(
-          static_pointer_cast<ExpStatement>(s)->getExpression());
-        if (exp && exp->is(Expression::KindOfIncludeExpression)) {
-          FileScopeRawPtr fs(
-            static_pointer_cast<IncludeExpression>(exp)->getIncludedFile(ar));
-          if (fs && fs->m_includeState != 1) {
-            if (!fs->m_includeState) {
-              if (m_module && fs->m_privateInclude) {
-                BOOST_FOREACH(BlockScopeRawPtr bs, m_providedDefs) {
-                  fs->m_providedDefs.insert(bs);
-                }
-              }
-              fs->analyzeIncludesHelper(ar);
-            }
-            BOOST_FOREACH(BlockScopeRawPtr bs, fs->m_providedDefs) {
-              m_providedDefs.insert(bs);
-            }
+        if (!parent.empty()) {
+          ClassScopeRawPtr c = ar->findClass(parent);
+          if (!c || (c->isVolatile() &&
+                     !resolveClass(c) && !checkClass(parent))) {
             continue;
           }
         }
       }
-      hoistOnly = true;
+      if (cls->isVolatile()) {
+        insertClassUtil(ar, cls, true);
+      }
+      continue;
     }
+
+    if (s->is(Statement::KindOfFunctionStatement)) {
+      FunctionScopeRawPtr func(
+        static_pointer_cast<FunctionStatement>(s)->getFunctionScope());
+      if (func->isVolatile()) m_providedDefs.insert(func);
+      continue;
+    }
+
+    if (!hoistOnly && s->is(Statement::KindOfExpStatement)) {
+      ExpressionRawPtr exp(
+        static_pointer_cast<ExpStatement>(s)->getExpression());
+      if (exp && exp->is(Expression::KindOfIncludeExpression)) {
+        FileScopeRawPtr fs(
+          static_pointer_cast<IncludeExpression>(exp)->getIncludedFile(ar));
+        if (fs && fs->m_includeState != 1) {
+          if (!fs->m_includeState) {
+            fs->analyzeIncludesHelper(ar);
+          }
+          BOOST_FOREACH(BlockScopeRawPtr bs, fs->m_providedDefs) {
+            m_providedDefs.insert(bs);
+          }
+          continue;
+        }
+      }
+    }
+
+    hoistOnly = true;
   }
+
   m_includeState = 2;
 }
 
 void FileScope::analyzeIncludes(AnalysisResultPtr ar) {
-  if (!m_privateInclude && !m_includeState) {
+  if (!m_includeState) {
     analyzeIncludesHelper(ar);
   }
 }
 
-
 void FileScope::visit(AnalysisResultPtr ar,
                       void (*cb)(AnalysisResultPtr, StatementPtr, void*),
-                      void *data)
-{
+                      void *data) {
   if (m_pseudoMain) {
     cb(ar, m_pseudoMain->getStmt(), data);
   }
@@ -394,11 +418,15 @@ const string &FileScope::pseudoMainName() {
 
 FunctionScopePtr FileScope::createPseudoMain(AnalysisResultConstPtr ar) {
   StatementListPtr st = m_tree;
+  LabelScopePtr labelScope(new LabelScope());
   FunctionStatementPtr f
-    (new FunctionStatement(BlockScopePtr(), LocationPtr(),
+    (new FunctionStatement(BlockScopePtr(),
+                           labelScope,
+                           LocationPtr(),
+                           ModifierExpressionPtr(),
                            false, pseudoMainName(),
-                           ExpressionListPtr(), st, 0, "",
-                           ExpressionListPtr()));
+                           ExpressionListPtr(), TypeAnnotationPtr(),
+                           st, 0, "", ExpressionListPtr()));
   f->setFileLevel();
   FunctionScopePtr pseudoMain(
     new HPHP::FunctionScope(ar, true,
@@ -430,24 +458,18 @@ string FileScope::outputFilebase() const {
 
 static void getFuncScopesSet(BlockScopeRawPtrQueue &v,
                              const StringToFunctionScopePtrMap &funcMap) {
-  for (StringToFunctionScopePtrMap::const_iterator
-         iter = funcMap.begin(), end = funcMap.end();
-       iter != end; ++iter) {
-    FunctionScopePtr f = iter->second;
-    if (f->isUserFunction()) {
+  for (const auto& iter : funcMap) {
+    FunctionScopePtr f = iter.second;
+    if (f->getStmt()) {
       v.push_back(f);
     }
   }
 }
 
 void FileScope::getScopesSet(BlockScopeRawPtrQueue &v) {
-  const StringToClassScopePtrVecMap &classes = getClasses();
-  for (StringToClassScopePtrVecMap::const_iterator iter = classes.begin(),
-         end = classes.end(); iter != end; ++iter) {
-    for (ClassScopePtrVec::const_iterator it = iter->second.begin(),
-           e = iter->second.end(); it != e; ++it) {
-      ClassScopePtr cls = *it;
-      if (cls->isUserClass()) {
+  for (const auto& clsVec : getClasses()) {
+    for (const auto cls : clsVec.second) {
+      if (cls->getStmt()) {
         v.push_back(cls);
         getFuncScopesSet(v, cls->getFunctions());
       }
@@ -455,20 +477,17 @@ void FileScope::getScopesSet(BlockScopeRawPtrQueue &v) {
   }
 
   getFuncScopesSet(v, getFunctions());
-  if (const StringToFunctionScopePtrVecMap *redec = m_redeclaredFunctions) {
-    for (StringToFunctionScopePtrVecMap::const_iterator iter = redec->begin(),
-           end = redec->end(); iter != end; ++iter) {
-      FunctionScopePtrVec::const_iterator i = iter->second.begin(),
-        e = iter->second.end();
+  if (const auto redec = m_redeclaredFunctions) {
+    for (const auto& funcVec : *redec) {
+      auto i = funcVec.second.begin(), e = funcVec.second.end();
       v.insert(v.end(), ++i, e);
     }
   }
 }
 
 void FileScope::getClassesFlattened(ClassScopePtrVec &classes) const {
-  for (StringToClassScopePtrVecMap::const_iterator it = m_classes.begin();
-       it != m_classes.end(); ++it) {
-    BOOST_FOREACH(ClassScopePtr cls, it->second) {
+  for (const auto& clsVec : m_classes) {
+    for (auto cls : clsVec.second) {
       classes.push_back(cls);
     }
   }
@@ -491,3 +510,4 @@ void FileScope::serialize(JSON::DocTarget::OutputStream &out) const {
   ms.done();
 }
 
+}

hphp/compiler/analysis/file_scope.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,16 +14,20 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __FILE_SCOPE_H__
-#define __FILE_SCOPE_H__
+#ifndef incl_HPHP_FILE_SCOPE_H_
+#define incl_HPHP_FILE_SCOPE_H_
 
-#include <compiler/analysis/block_scope.h>
-#include <compiler/analysis/function_container.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/code_generator.h>
+#include <string>
+#include <map>
+#include <boost/algorithm/string.hpp>
+
+#include "hphp/compiler/analysis/block_scope.h"
+#include "hphp/compiler/analysis/function_container.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/code_generator.h"
 #include <boost/graph/adjacency_list.hpp>
-#include <util/json.h>
-#include <runtime/base/md5.h>
+#include "hphp/compiler/json.h"
+#include "hphp/util/md5.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -59,7 +63,8 @@ public:
     MixedVariableArgument     = 0x800, // variable args, may or may not be ref'd
     IsFoldable                = 0x1000,// function can be constant folded
     NeedsActRec               = 0x2000,// builtin function needs ActRec
-    IgnoreRedefinition        = 0x4000,// ignore redefinition of builtin function
+    AllowOverride             = 0x4000,// allow override of systemlib or builtin
+    NeedsFinallyLocals        = 0x8000,
   };
 
   typedef boost::adjacency_list<boost::setS, boost::vecS> Graph;
@@ -75,6 +80,7 @@ public:
 
   const std::string &getName() const { return m_fileName;}
   const MD5& getMd5() const { return m_md5; }
+  void setMd5(const MD5& md5) { m_md5 = md5; }
   StatementListPtr getStmt() const { return m_tree;}
   const StringToClassScopePtrVecMap &getClasses() const {
     return m_classes;
@@ -105,8 +111,11 @@ public:
    * are the only functions a parser calls upon analysis results.
    */
   FunctionScopePtr setTree(AnalysisResultConstPtr ar, StatementListPtr tree);
-  void cleanupForError(AnalysisResultConstPtr ar,
-                       int line, const std::string &msg);
+  void cleanupForError(AnalysisResultConstPtr ar);
+  void makeFatal(AnalysisResultConstPtr ar,
+                 const std::string& msg, int line);
+  void makeParseFatal(AnalysisResultConstPtr ar,
+                      const std::string& msg, int line);
 
   bool addFunction(AnalysisResultConstPtr ar, FunctionScopePtr funcScope);
   bool addClass(AnalysisResultConstPtr ar, ClassScopePtr classScope);
@@ -135,6 +144,27 @@ public:
   void addConstantDependency(AnalysisResultPtr ar,
                              const std::string &decname);
 
+  void addClassAlias(const std::string& target, const std::string& alias) {
+    m_classAliasMap.insert(
+      std::make_pair(
+        boost::to_lower_copy(target),
+        boost::to_lower_copy(alias)
+      )
+    );
+  }
+
+  std::multimap<std::string,std::string> const& getClassAliases() const {
+    return m_classAliasMap;
+  }
+
+  void addTypeAliasName(const std::string& name) {
+    m_typeAliasNames.insert(boost::to_lower_copy(name));
+  }
+
+  std::set<std::string> const& getTypeAliasNames() const {
+    return m_typeAliasNames;
+  }
+
   /**
    * Called only by World
    */
@@ -143,10 +173,8 @@ public:
     m_vertex = vertex;
   }
 
-  void setModule() { m_module = true; }
-  void setPrivateInclude() { m_privateInclude = true; }
-  bool isPrivateInclude() const { return m_privateInclude && !m_externInclude; }
-  void setExternInclude() { m_externInclude = true; }
+  void setSystem();
+  bool isSystem() const { return m_system; }
 
   void analyzeProgram(AnalysisResultPtr ar);
   void analyzeIncludes(AnalysisResultPtr ar);
@@ -162,31 +190,22 @@ public:
   const std::string &pseudoMainName();
   void outputFileCPP(AnalysisResultPtr ar, CodeGenerator &cg);
   bool load();
-  bool needPseudoMainVariables() const;
   std::string outputFilebase() const;
 
-  void addPseudoMainVariable(const std::string &name) {
-    m_pseudoMainVariables.insert(name);
-  }
-  std::set<std::string> &getPseudoMainVariables() {
-    return m_pseudoMainVariables;
-  }
-
   FunctionScopeRawPtr getPseudoMain() const {
     return m_pseudoMain;
   }
 
   FileScopePtr shared_from_this() {
-    return boost::static_pointer_cast<FileScope>
+    return static_pointer_cast<FileScope>
       (BlockScope::shared_from_this());
   }
+
 private:
   int m_size;
   MD5 m_md5;
-  unsigned m_module : 1;
-  unsigned m_privateInclude : 1;
-  unsigned m_externInclude : 1;
   unsigned m_includeState : 2;
+  unsigned m_system : 1;
 
   std::vector<int> m_attributes;
   std::string m_fileName;
@@ -198,14 +217,22 @@ private:
   vertex_descriptor m_vertex;
 
   std::string m_pseudoMainName;
-  std::set<std::string> m_pseudoMainVariables;
   BlockScopeSet m_providedDefs;
   std::set<std::string> m_redecBases;
 
+  // Map from class alias names to the class they are aliased to.
+  // This is only needed in WholeProgram mode.
+  std::multimap<std::string,std::string> m_classAliasMap;
+
+  // Set of names that are on the left hand side of type alias
+  // declarations.  We need this to make sure we don't mark classes
+  // with the same name Unique.
+  std::set<std::string> m_typeAliasNames;
+
   FunctionScopePtr createPseudoMain(AnalysisResultConstPtr ar);
   void setFileLevel(StatementListPtr stmt);
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __FILE_SCOPE_H__
+#endif // incl_HPHP_FILE_SCOPE_H_

hphp/compiler/analysis/function_container.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,16 +14,16 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/function_container.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/option.h>
-#include <util/util.h>
-#include <util/hash.h>
+#include "hphp/compiler/analysis/function_container.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/option.h"
+#include "hphp/util/util.h"
+#include "hphp/util/hash.h"
 
 using namespace HPHP;
 

hphp/compiler/analysis/function_container.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,17 +14,17 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __FUNCTION_CONTAINER_H__
-#define __FUNCTION_CONTAINER_H__
+#ifndef incl_HPHP_FUNCTION_CONTAINER_H_
+#define incl_HPHP_FUNCTION_CONTAINER_H_
 
-#include <compiler/hphp.h>
+#include "hphp/compiler/hphp.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
 
 class CodeGenerator;
 DECLARE_BOOST_TYPES(AnalysisResult);
-DECLARE_BOOST_TYPES(FunctionScope);
+DECLARE_EXTENDED_BOOST_TYPES(FunctionScope);
 DECLARE_BOOST_TYPES(ClassScope);
 DECLARE_BOOST_TYPES(FunctionContainer);
 
@@ -56,4 +56,4 @@ protected:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __FUNCTION_CONTAINER_H__
+#endif // incl_HPHP_FUNCTION_CONTAINER_H_

hphp/compiler/analysis/function_scope.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,31 +14,31 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/expression/constant_expression.h>
-#include <compiler/expression/modifier_expression.h>
-#include <compiler/expression/expression_list.h>
-#include <compiler/expression/function_call.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/parser/parser.h>
-#include <util/logger.h>
-#include <compiler/option.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/exp_statement.h>
-#include <compiler/expression/parameter_expression.h>
-#include <compiler/analysis/class_scope.h>
-#include <util/atomic.h>
-#include <util/util.h>
-#include <runtime/base/class_info.h>
-#include <runtime/base/type_conversions.h>
-#include <runtime/base/builtin_functions.h>
-#include <util/parser/hphp.tab.hpp>
-#include <runtime/base/variable_serializer.h>
-#include <runtime/base/zend/zend_string.h>
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/expression/constant_expression.h"
+#include "hphp/compiler/expression/modifier_expression.h"
+#include "hphp/compiler/expression/expression_list.h"
+#include "hphp/compiler/expression/function_call.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/util/logger.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/exp_statement.h"
+#include "hphp/compiler/expression/parameter_expression.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/util/atomic.h"
+#include "hphp/util/util.h"
+#include "hphp/runtime/base/class-info.h"
+#include "hphp/runtime/base/type-conversions.h"
+#include "hphp/runtime/base/builtin-functions.h"
+#include "hphp/parser/hphp.tab.hpp"
+#include "hphp/runtime/base/variable-serializer.h"
+#include "hphp/runtime/base/zend-string.h"
 
 using namespace HPHP;
 
@@ -58,15 +58,17 @@ FunctionScope::FunctionScope(AnalysisResultConstPtr ar, bool method,
       m_method(method), m_refReturn(reference), m_virtual(false),
       m_hasOverride(false), m_perfectVirtual(false), m_overriding(false),
       m_volatile(false), m_persistent(false), m_pseudoMain(inPseudoMain),
-      m_magicMethod(false), m_system(false), m_inlineable(false), m_sep(false),
+      m_magicMethod(false), m_system(false), m_inlineable(false),
       m_containsThis(false), m_containsBareThis(0), m_nrvoFix(true),
       m_inlineAsExpr(false), m_inlineSameContext(false),
       m_contextSensitive(false),
-      m_directInvoke(false), m_needsRefTemp(false),
-      m_needsObjTemp(false), m_needsCheckMem(false),
-      m_closureGenerator(false), m_noLSB(false), m_nextLSB(false),
+      m_directInvoke(false),
+      m_generator(false),
+      m_async(false),
+      m_noLSB(false), m_nextLSB(false),
       m_hasTry(false), m_hasGoto(false), m_localRedeclaring(false),
-      m_redeclaring(-1), m_inlineIndex(0), m_optFunction(0), m_nextID(0) {
+      m_redeclaring(-1), m_inlineIndex(0), m_optFunction(0), m_nextID(0),
+      m_yieldLabelCount(0), m_yieldLabelGen(-1) {
   init(ar);
   for (unsigned i = 0; i < attrs.size(); ++i) {
     if (m_userAttributes.find(attrs[i]->getName()) != m_userAttributes.end()) {
@@ -76,6 +78,12 @@ FunctionScope::FunctionScope(AnalysisResultConstPtr ar, bool method,
     }
     m_userAttributes[attrs[i]->getName()] = attrs[i]->getExp();
   }
+
+  // Support for systemlib functions implemented in PHP
+  if (!m_method &&
+      m_userAttributes.find("__Overridable") != m_userAttributes.end()) {
+    setAllowOverride();
+  }
 }
 
 FunctionScope::FunctionScope(FunctionScopePtr orig,
@@ -83,7 +91,8 @@ FunctionScope::FunctionScope(FunctionScopePtr orig,
                              const string &name,
                              const string &originalName,
                              StatementPtr stmt,
-                             ModifierExpressionPtr modifiers)
+                             ModifierExpressionPtr modifiers,
+                             bool user)
     : BlockScope(name, orig->m_docComment, stmt,
                  BlockScope::FunctionScope),
       m_minParam(orig->m_minParam), m_maxParam(orig->m_maxParam),
@@ -95,22 +104,22 @@ FunctionScope::FunctionScope(FunctionScopePtr orig,
       m_overriding(orig->m_overriding), m_volatile(orig->m_volatile),
       m_persistent(orig->m_persistent),
       m_pseudoMain(orig->m_pseudoMain), m_magicMethod(orig->m_magicMethod),
-      m_system(orig->m_system), m_inlineable(orig->m_inlineable),
-      m_sep(orig->m_sep), m_containsThis(orig->m_containsThis),
+      m_system(!user), m_inlineable(orig->m_inlineable),
+      m_containsThis(orig->m_containsThis),
       m_containsBareThis(orig->m_containsBareThis), m_nrvoFix(orig->m_nrvoFix),
       m_inlineAsExpr(orig->m_inlineAsExpr),
       m_inlineSameContext(orig->m_inlineSameContext),
       m_contextSensitive(orig->m_contextSensitive),
       m_directInvoke(orig->m_directInvoke),
-      m_needsRefTemp(orig->m_needsRefTemp),
-      m_needsObjTemp(orig->m_needsObjTemp),
-      m_needsCheckMem(orig->m_needsCheckMem),
-      m_closureGenerator(orig->m_closureGenerator), m_noLSB(orig->m_noLSB),
+      m_generator(orig->m_generator),
+      m_async(orig->m_async),
+      m_noLSB(orig->m_noLSB),
       m_nextLSB(orig->m_nextLSB), m_hasTry(orig->m_hasTry),
       m_hasGoto(orig->m_hasGoto), m_localRedeclaring(orig->m_localRedeclaring),
       m_redeclaring(orig->m_redeclaring),
       m_inlineIndex(orig->m_inlineIndex), m_optFunction(orig->m_optFunction),
-      m_nextID(0) {
+      m_nextID(0), m_yieldLabelCount(orig->m_yieldLabelCount),
+      m_yieldLabelGen(orig->m_yieldLabelGen) {
   init(ar);
   m_originalName = originalName;
   setParamCounts(ar, m_minParam, m_maxParam);
@@ -199,12 +208,14 @@ FunctionScope::FunctionScope(bool method, const std::string &name,
       m_method(method), m_refReturn(reference), m_virtual(false),
       m_hasOverride(false), m_perfectVirtual(false), m_overriding(false),
       m_volatile(false), m_persistent(false), m_pseudoMain(false),
-      m_magicMethod(false), m_system(true), m_inlineable(false), m_sep(false),
+      m_magicMethod(false), m_system(true), m_inlineable(false),
       m_containsThis(false), m_containsBareThis(0), m_nrvoFix(true),
       m_inlineAsExpr(false), m_inlineSameContext(false),
       m_contextSensitive(false),
-      m_directInvoke(false), m_needsRefTemp(false), m_needsObjTemp(false),
-      m_closureGenerator(false), m_noLSB(false), m_nextLSB(false),
+      m_directInvoke(false),
+      m_generator(false),
+      m_async(false),
+      m_noLSB(false), m_nextLSB(false),
       m_hasTry(false), m_hasGoto(false), m_localRedeclaring(false),
       m_redeclaring(-1), m_inlineIndex(0),
       m_optFunction(0) {
@@ -276,6 +287,15 @@ void FunctionScope::setParamSpecs(AnalysisResultPtr ar) {
   }
 }
 
+bool FunctionScope::hasUserAttr(const char *attr) const {
+  return m_userAttributes.find(attr) != m_userAttributes.end();
+}
+
+bool FunctionScope::isZendParamMode() const {
+  return m_attributeClassInfo &
+    (ClassInfo::ZendParamModeNull | ClassInfo::ZendParamModeFalse);
+}
+
 bool FunctionScope::isPublic() const {
   return m_modifiers && m_modifiers->isPublic();
 }
@@ -296,6 +316,10 @@ bool FunctionScope::isAbstract() const {
   return m_modifiers && m_modifiers->isAbstract();
 }
 
+bool FunctionScope::isNative() const {
+  return hasUserAttr("__native");
+}
+
 bool FunctionScope::isFinal() const {
   return m_modifiers && m_modifiers->isFinal();
 }
@@ -305,8 +329,8 @@ bool FunctionScope::isVariableArgument() const {
   return res;
 }
 
-bool FunctionScope::ignoreRedefinition() const {
-  return m_attribute & FileScope::IgnoreRedefinition;
+bool FunctionScope::allowOverride() const {
+  return m_attribute & FileScope::AllowOverride;
 }
 
 bool FunctionScope::isReferenceVariableArgument() const {
@@ -331,39 +355,38 @@ bool FunctionScope::needsActRec() const {
   return res;
 }
 
+bool FunctionScope::needsFinallyLocals() const {
+  bool res = (m_attribute & FileScope::NeedsFinallyLocals);
+  return res;
+}
+
+bool FunctionScope::mayContainThis() {
+  return inPseudoMain() || getContainingClass() ||
+    (isClosure() && !m_modifiers->isStatic());
+}
+
 bool FunctionScope::isClosure() const {
   return ParserBase::IsClosureName(name());
 }
 
-bool FunctionScope::isGenerator() const {
-  assert(!getOrigGenStmt() ||
-         (ParserBase::IsContinuationName(name()) &&
-          m_paramNames.size() == 1 &&
-          m_paramNames[0] == CONTINUATION_OBJECT_NAME));
-  return getOrigGenStmt();
+int FunctionScope::allocYieldLabel() {
+  assert(m_yieldLabelGen >= 0);
+  return ++m_yieldLabelCount;
 }
 
-bool FunctionScope::hasGeneratorAsBody() const {
-  MethodStatementPtr stmt = dynamic_pointer_cast<MethodStatement>(getStmt());
-  return stmt ? stmt->getGeneratorFunc() : false;
+int FunctionScope::getYieldLabelCount() const {
+  assert(m_yieldLabelGen >= 0);
+  return m_yieldLabelCount;
 }
 
-bool FunctionScope::isGeneratorFromClosure() const {
-  bool res = isGenerator() && getOrigGenFS()->isClosure();
-  assert(!res || getOrigGenFS()->isClosureGenerator());
-  return res;
+int FunctionScope::getYieldLabelGeneration() const {
+  assert(m_yieldLabelGen >= 0);
+  return m_yieldLabelGen;
 }
 
-MethodStatementRawPtr FunctionScope::getOrigGenStmt() const {
-  if (!getStmt()) return MethodStatementRawPtr();
-  MethodStatementPtr m =
-    dynamic_pointer_cast<MethodStatement>(getStmt());
-  return m ? m->getOrigGeneratorFunc() : MethodStatementRawPtr();
-}
-
-FunctionScopeRawPtr FunctionScope::getOrigGenFS() const {
-  MethodStatementRawPtr origStmt = getOrigGenStmt();
-  return origStmt ? origStmt->getFunctionScope() : FunctionScopeRawPtr();
+void FunctionScope::resetYieldLabelCount() {
+  ++m_yieldLabelGen;
+  m_yieldLabelCount = 0;
 }
 
 void FunctionScope::setVariableArgument(int reference) {
@@ -376,8 +399,8 @@ void FunctionScope::setVariableArgument(int reference) {
   }
 }
 
-void FunctionScope::setIgnoreRedefinition() {
-  m_attribute |= FileScope::IgnoreRedefinition;
+void FunctionScope::setAllowOverride() {
+  m_attribute |= FileScope::AllowOverride;
 }
 
 bool FunctionScope::hasEffect() const {
@@ -410,13 +433,53 @@ bool FunctionScope::containsReference() const {
   return m_attribute & FileScope::ContainsReference;
 }
 
+void FunctionScope::setContainsThis(bool f /* = true */) {
+  m_containsThis = f;
+
+  BlockScopePtr bs(this->getOuterScope());
+  while (bs && bs->is(BlockScope::FunctionScope)) {
+    FunctionScopePtr fs = static_pointer_cast<FunctionScope>(bs);
+    if (!fs->isClosure()) {
+      break;
+    }
+    fs->setContainsThis(f);
+    bs = bs->getOuterScope();
+  }
+
+  for (auto it = m_clonedTraitOuterScope.begin(); it != m_clonedTraitOuterScope.end(); it++) {
+    (*it)->setContainsThis(f);
+  }
+}
+
+void FunctionScope::setContainsBareThis(bool f, bool ref /* = false */) {
+  if (f) {
+    m_containsBareThis |= ref ? 2 : 1;
+  } else {
+    m_containsBareThis = 0;
+  }
+
+  BlockScopePtr bs(this->getOuterScope());
+  while (bs && bs->is(BlockScope::FunctionScope)) {
+    FunctionScopePtr fs = static_pointer_cast<FunctionScope>(bs);
+    if (!fs->isClosure()) {
+      break;
+    }
+    fs->setContainsBareThis(f, ref);
+    bs = bs->getOuterScope();
+  }
+
+  for (auto it = m_clonedTraitOuterScope.begin(); it != m_clonedTraitOuterScope.end(); it++) {
+    (*it)->setContainsBareThis(f, ref);
+  }
+}
+
 bool FunctionScope::hasImpl() const {
   if (!isUserFunction()) {
     return !isAbstract();
   }
   if (m_stmt) {
     MethodStatementPtr stmt = dynamic_pointer_cast<MethodStatement>(m_stmt);
-    return stmt->getStmts();
+    return stmt->getStmts() != nullptr;
   }
   return false;
 }
@@ -482,6 +545,7 @@ bool FunctionScope::mayUseVV() const {
   return (inPseudoMain() ||
           isVariableArgument() ||
           isGenerator() ||
+          isAsync() ||
           variables->getAttribute(VariableTable::ContainsDynamicVariable) ||
           variables->getAttribute(VariableTable::ContainsExtract) ||
           variables->getAttribute(VariableTable::ContainsCompact) ||
@@ -532,18 +596,6 @@ void FunctionScope::setPerfectVirtual() {
   }
 }
 
-bool FunctionScope::needsTypeCheckWrapper() const {
-  for (int i = 0; i < m_maxParam; i++) {
-    if (isRefParam(i)) continue;
-    if (TypePtr spec = m_paramTypeSpecs[i]) {
-      if (Type::SameType(spec, m_paramTypes[i])) {
-        return true;
-      }
-    }
-  }
-  return false;
-}
-
 bool FunctionScope::needsClassParam() {
   if (!isStatic()) return false;
   ClassScopeRawPtr cls = getContainingClass();
@@ -619,7 +671,8 @@ int FunctionScope::inferParamTypes(AnalysisResultPtr ar, ConstructPtr exp,
     /**
      * Duplicate the logic of getParamType(i), w/o the mutation
      */
-    TypePtr paramType(i < m_maxParam ? m_paramTypes[i] : TypePtr());
+    TypePtr paramType(i < m_maxParam && !isZendParamMode() ?
+                      m_paramTypes[i] : TypePtr());
     if (!paramType) paramType = Type::Some;
     if (valid && !canSetParamType && i < m_maxParam &&
         (!Option::HardTypeHints || !m_paramTypeSpecs[i])) {
@@ -631,8 +684,8 @@ int FunctionScope::inferParamTypes(AnalysisResultPtr ar, ConstructPtr exp,
        * expression since it'll just get converted anyways. Doing it this way
        * allows us to generate less temporaries along the way.
        */
-      TypePtr optParamType(
-          paramType->is(Type::KindOfVariant) ? Type::Some : paramType);
+      TypePtr optParamType(paramType->is(Type::KindOfVariant) ?
+                           Type::Some : paramType);
       expType = param->inferAndCheck(ar, optParamType, false);
     } else {
       expType = param->inferAndCheck(ar, Type::Some, false);
@@ -739,16 +792,10 @@ void FunctionScope::setParamName(int index, const std::string &name) {
 void FunctionScope::setParamDefault(int index, const char* value, int64_t len,
                                     const std::string &text) {
   assert(index >= 0 && index < (int)m_paramNames.size());
-  StringData* sd = new StringData(value, len, AttachLiteral);
-  sd->setStatic();
-  m_paramDefaults[index] = String(sd);
+  m_paramDefaults[index] = std::string(value, len);
   m_paramDefaultTexts[index] = text;
 }
 
-CStrRef FunctionScope::getParamDefault(int index) {
-  return m_paramDefaults[index];
-}
-
 void FunctionScope::addModifier(int mod) {
   if (!m_modifiers) {
     m_modifiers =
@@ -801,11 +848,14 @@ bool FunctionScope::popReturnType() {
         m_prevReturn.reset();
         return false;
       }
-      if (!isFirstPass()) {
-        Logger::Verbose("Corrected function return type %s -> %s",
-                        m_prevReturn->toString().c_str(),
-                        m_returnType->toString().c_str());
-      }
+      Logger::Verbose("Corrected %s's return type %s -> %s",
+                      getFullName().c_str(),
+                      m_prevReturn->toString().c_str(),
+                      m_returnType->toString().c_str());
+    } else {
+      Logger::Verbose("Set %s's return type %s",
+                      getFullName().c_str(),
+                      m_returnType->toString().c_str());
     }
   } else if (!m_prevReturn) {
     return false;
@@ -814,7 +864,7 @@ bool FunctionScope::popReturnType() {
   m_prevReturn.reset();
   addUpdates(UseKindCallerReturn);
 #ifdef HPHP_INSTRUMENT_TYPE_INF
-  atomic_inc(RescheduleException::s_NumRetTypesChanged);
+  ++RescheduleException::s_NumRetTypesChanged;
 #endif /* HPHP_INSTRUMENT_TYPE_INF */
   return true;
 }
@@ -888,28 +938,6 @@ std::string FunctionScope::getDocFullName() const {
   return docName;
 }
 
-std::string FunctionScope::getInjectionId() const {
-  string injectionName = CodeGenerator::FormatLabel(getOriginalName());
-  MethodStatementPtr stmt =
-    dynamic_pointer_cast<MethodStatement>(getStmt());
-  assert(stmt);
-  if (stmt->getGeneratorFunc()) {
-    injectionName = isClosureGenerator() ?
-      injectionName :
-      injectionName + "{continuation}";
-  } else if (stmt->getOrigGeneratorFunc() &&
-             !getOrigGenFS()->isClosure()) {
-    injectionName = CodeGenerator::FormatLabel(
-      stmt->getOrigGeneratorFunc()->getOriginalName());
-  }
-  if (m_redeclaring < 0) {
-    return injectionName;
-  }
-  const string &redecSuffix = string(Option::IdPrefix) +
-    boost::lexical_cast<std::string>(m_redeclaring);
-  return injectionName + redecSuffix;
-}
-
 ///////////////////////////////////////////////////////////////////////////////
 
 void FunctionScope::outputPHP(CodeGenerator &cg, AnalysisResultPtr ar) {
@@ -1035,7 +1063,7 @@ bool FunctionScope::needsAnonClosureClass(ParameterExpressionPtrVec &useVars) {
   useVars.clear();
   if (!isClosure()) return false;
   ParameterExpressionPtrIdxPairVec useVars0;
-  getClosureUseVars(useVars0, !m_closureGenerator);
+  getClosureUseVars(useVars0, !m_generator && !m_async);
   useVars.resize(useVars0.size());
   // C++ seems to be unable to infer the type here on pair_first_elem
   transform(useVars0.begin(),
@@ -1049,7 +1077,7 @@ bool FunctionScope::needsAnonClosureClass(
     ParameterExpressionPtrIdxPairVec &useVars) {
   useVars.clear();
   if (!isClosure()) return false;
-  getClosureUseVars(useVars, !m_closureGenerator);
+  getClosureUseVars(useVars, !m_generator && !m_async);
   return useVars.size() > 0 || getVariables()->hasStaticLocals();
 }
 

hphp/compiler/analysis/function_scope.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,15 +14,16 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __FUNCTION_SCOPE_H__
-#define __FUNCTION_SCOPE_H__
+#ifndef incl_HPHP_FUNCTION_SCOPE_H_
+#define incl_HPHP_FUNCTION_SCOPE_H_
 
-#include <compiler/expression/user_attribute.h>
-#include <compiler/analysis/block_scope.h>
-#include <compiler/option.h>
+#include "hphp/compiler/expression/user_attribute.h"
+#include "hphp/compiler/analysis/block_scope.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/json.h"
 
-#include <util/json.h>
-#include <util/parser/parser.h>
+#include "hphp/util/hash-map-typedefs.h"
+#include "hphp/parser/parser.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -73,7 +74,7 @@ public:
 
   FunctionScope(FunctionScopePtr orig, AnalysisResultConstPtr ar,
                 const std::string &name, const std::string &originalName,
-                StatementPtr stmt, ModifierExpressionPtr modifiers);
+                StatementPtr stmt, ModifierExpressionPtr modifiers, bool user);
 
   /**
    * System functions.
@@ -84,22 +85,25 @@ public:
   void setParamName(int index, const std::string &name);
   void setParamDefault(int index, const char* value, int64_t len,
                        const std::string &text);
-  CStrRef getParamDefault(int index);
   void setRefParam(int index);
   bool hasRefParam(int max) const;
 
   void addModifier(int mod);
 
+  bool hasUserAttr(const char *attr) const;
+
   /**
    * What kind of function this is.
    */
-  bool isUserFunction() const { return !m_system;}
+  bool isUserFunction() const { return !m_system && !isNative(); }
+  bool isSystem() const { return m_system; }
   bool isDynamic() const { return m_dynamic; }
   bool isPublic() const;
   bool isProtected() const;
   bool isPrivate() const;
   bool isStatic() const;
   bool isAbstract() const;
+  bool isNative() const;
   bool isFinal() const;
   bool isMagic() const;
   bool isRefParam(int index) const;
@@ -109,23 +113,18 @@ public:
   bool hasImpl() const;
   void setDirectInvoke() { m_directInvoke = true; }
   bool hasDirectInvoke() const { return m_directInvoke; }
+  bool isZendParamMode() const;
+  bool mayContainThis();
   bool isClosure() const;
-  bool isGenerator() const;
-  bool isGeneratorFromClosure() const;
-  bool hasGeneratorAsBody() const;
-  MethodStatementRawPtr getOrigGenStmt() const;
-  FunctionScopeRawPtr getOrigGenFS() const;
-  void setNeedsRefTemp() { m_needsRefTemp = true; }
-  bool needsRefTemp() const { return m_needsRefTemp; }
-  void setNeedsObjTemp() { m_needsObjTemp = true; }
-  bool needsObjTemp() const { return m_needsObjTemp; }
-  void setNeedsCheckMem() { m_needsCheckMem = true; }
-  bool needsCheckMem() const { return m_needsCheckMem; }
-  void setClosureGenerator() { m_closureGenerator = true; }
-  bool isClosureGenerator() const {
-    assert(!m_closureGenerator || isClosure());
-    return m_closureGenerator;
-  }
+  bool isGenerator() const { return m_generator; }
+  void setGenerator(bool f) { m_generator = f; }
+  int allocYieldLabel();
+  int getYieldLabelCount() const;
+  int getYieldLabelGeneration() const;
+  void resetYieldLabelCount();
+  bool isAsync() const { return m_async; }
+  void setAsync(bool f) { m_async = f; }
+
   bool needsClassParam();
 
   void setInlineSameContext(bool f) { m_inlineSameContext = f; }
@@ -161,7 +160,6 @@ public:
   }
 
   virtual std::string getId() const;
-  std::string getInjectionId() const;
 
   int getRedeclaringId() const {
     return m_redeclaring;
@@ -176,6 +174,13 @@ public:
     m_volatile = false;
   }
 
+  /**
+   * Tell this function about another outer scope that contains it.
+   */
+  void addClonedTraitOuterScope(FunctionScopePtr scope) {
+    m_clonedTraitOuterScope.push_back(scope);
+  }
+
   /**
    * Get/set original name of the function, without case being lowered.
    */
@@ -218,10 +223,12 @@ public:
   void setNeedsActRec();
 
   /*
-   * If this is a builtin and can be redefined
+   * If this is a builtin (C++ or PHP) and can be redefined
    */
-  bool ignoreRedefinition() const;
-  void setIgnoreRedefinition();
+  bool allowOverride() const;
+  void setAllowOverride();
+
+  bool needsFinallyLocals() const;
 
   /**
    * Whether this function is a runtime helper function
@@ -237,16 +244,10 @@ public:
    * Whether this function contains a usage of $this
    */
   bool containsThis() const { return m_containsThis;}
-  void setContainsThis(bool f=true) { m_containsThis = f;}
+  void setContainsThis(bool f = true);
   bool containsBareThis() const { return m_containsBareThis; }
   bool containsRefThis() const { return m_containsBareThis & 2; }
-  void setContainsBareThis(bool f, bool ref = false) {
-    if (f) {
-      m_containsBareThis |= ref ? 2 : 1;
-    } else {
-      m_containsBareThis = 0;
-    }
-  }
+  void setContainsBareThis(bool f, bool ref = false);
   /**
    * How many parameters a caller should provide.
    */
@@ -256,6 +257,8 @@ public:
 
   /**
    * What is the inferred type of this function's return.
+   * Note that for generators and async functions, this is different
+   * from what caller actually gets when calling the function.
    */
   void pushReturnType();
   void setReturnType(AnalysisResultConstPtr ar, TypePtr type);
@@ -269,8 +272,6 @@ public:
   void clearRetExprs();
   void fixRetExprs();
 
-  bool needsTypeCheckWrapper() const;
-
   void setOptFunction(FunctionOptPtr fn) { m_optFunction = fn; }
   FunctionOptPtr getOptFunction() const { return m_optFunction; }
 
@@ -312,10 +313,6 @@ public:
   bool isInlined() const { return m_inlineable; }
   void disableInline() { m_inlineable = false; }
 
-  /* Whether this function is brought in by a separable extension */
-  void setSepExtension() { m_sep = true;}
-  bool isSepExtension() const { return m_sep;}
-
   /* Whether we need to worry about the named return value optimization
      for this function */
   void setNRVOFix(bool flag) { m_nrvoFix = flag; }
@@ -392,7 +389,7 @@ public:
 
   ReadWriteMutex &getInlineMutex() { return m_inlineMutex; }
 
-  DECLARE_BOOST_TYPES(FunctionInfo);
+  DECLARE_EXTENDED_BOOST_TYPES(FunctionInfo);
 
   static void RecordFunctionInfo(std::string fname, FunctionScopePtr func);
 
@@ -400,8 +397,11 @@ public:
 
   class FunctionInfo {
   public:
-    FunctionInfo(int rva = -1) : m_maybeStatic(false), m_maybeRefReturn(false),
-                                 m_refVarArg(rva) { }
+    explicit FunctionInfo(int rva = -1)
+      : m_maybeStatic(false)
+      , m_maybeRefReturn(false)
+      , m_refVarArg(rva)
+    {}
 
     bool isRefParam(int p) const {
       if (m_refVarArg >= 0 && p >= m_refVarArg) return true;
@@ -441,7 +441,7 @@ private:
   std::vector<std::string> m_paramNames;
   TypePtrVec m_paramTypes;
   TypePtrVec m_paramTypeSpecs;
-  std::vector<String> m_paramDefaults;
+  std::vector<std::string> m_paramDefaults;
   std::vector<std::string> m_paramDefaultTexts;
   std::vector<bool> m_refs;
   TypePtr m_returnType;
@@ -464,7 +464,6 @@ private:
   unsigned m_magicMethod : 1;
   unsigned m_system : 1;
   unsigned m_inlineable : 1;
-  unsigned m_sep : 1;
   unsigned m_containsThis : 1; // contains a usage of $this?
   unsigned m_containsBareThis : 2; // $this outside object-context,
                                    // 2 if in reference context
@@ -473,10 +472,8 @@ private:
   unsigned m_inlineSameContext : 1;
   unsigned m_contextSensitive : 1;
   unsigned m_directInvoke : 1;
-  unsigned m_needsRefTemp : 1;
-  unsigned m_needsObjTemp : 1;
-  unsigned m_needsCheckMem : 1;
-  unsigned m_closureGenerator : 1;
+  unsigned m_generator : 1;
+  unsigned m_async : 1;
   unsigned m_noLSB : 1;
   unsigned m_nextLSB : 1;
   unsigned m_hasTry : 1;
@@ -492,8 +489,11 @@ private:
   ExpressionListPtr m_closureValues;
   ReadWriteMutex m_inlineMutex;
   unsigned m_nextID; // used when cloning generators for traits
+  int m_yieldLabelCount; // number of allocated yield labels
+  int m_yieldLabelGen;   // generation counter for yield labels
+  std::list<FunctionScopeRawPtr> m_clonedTraitOuterScope;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __FUNCTION_SCOPE_H__
+#endif // incl_HPHP_FUNCTION_SCOPE_H_

hphp/compiler/analysis/label_scope.h

@@ -0,0 +1,59 @@
+/*
+   +----------------------------------------------------------------------+
+   | HipHop for PHP                                                       |
+   +----------------------------------------------------------------------+
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
+   +----------------------------------------------------------------------+
+   | This source file is subject to version 3.01 of the PHP license,      |
+   | that is bundled with this package in the file LICENSE, and is        |
+   | available through the world-wide-web at the following url:           |
+   | http://www.php.net/license/3_01.txt                                  |
+   | If you did not receive a copy of the PHP license and are unable to   |
+   | obtain it through the world-wide-web, please send a note to          |
+   | license@php.net so we can mail you a copy immediately.               |
+   +----------------------------------------------------------------------+
+*/
+
+#ifndef incl_HPHP_LABEL_SCOPE_H_
+#define incl_HPHP_LABEL_SCOPE_H_
+
+#include "hphp/compiler/hphp.h"
+#include "hphp/util/deprecated/base.h"
+
+#include <vector>
+#include <string>
+
+namespace HPHP {
+///////////////////////////////////////////////////////////////////////////////
+
+class Statement;
+
+DECLARE_BOOST_TYPES(Statement);
+
+class LabelScope {
+public:
+  class LabelInfo {
+  public:
+    LabelInfo(StatementPtr s, const std::string& name)
+      : m_stmt(s), m_name(name) {}
+
+    StatementPtr getStatement() const { return m_stmt; }
+    const std::string& getName() const { return m_name; }
+
+  private:
+    StatementPtr m_stmt;
+    std::string m_name;
+  };
+
+  const std::vector<LabelInfo>& getLabels() const { return m_labels; }
+  void addLabel(StatementPtr s, const std::string& label) {
+    m_labels.push_back(LabelInfo(s, label));
+  }
+
+private:
+  std::vector<LabelInfo> m_labels;
+};
+
+///////////////////////////////////////////////////////////////////////////////
+}
+#endif // incl_HPHP_LABEL_SCOPE_H_

hphp/compiler/analysis/lambda_names.cpp

@@ -0,0 +1,156 @@
+/*
+   +----------------------------------------------------------------------+
+   | HipHop for PHP                                                       |
+   +----------------------------------------------------------------------+
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
+   +----------------------------------------------------------------------+
+   | This source file is subject to version 3.01 of the PHP license,      |
+   | that is bundled with this package in the file LICENSE, and is        |
+   | available through the world-wide-web at the following url:           |
+   | http://www.php.net/license/3_01.txt                                  |
+   | If you did not receive a copy of the PHP license and are unable to   |
+   | obtain it through the world-wide-web, please send a note to          |
+   | license@php.net so we can mail you a copy immediately.               |
+   +----------------------------------------------------------------------+
+*/
+#include "hphp/compiler/analysis/lambda_names.h"
+
+#include <set>
+
+#include "folly/ScopeGuard.h"
+
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/function_statement.h"
+#include "hphp/compiler/expression/closure_expression.h"
+
+namespace HPHP {
+
+//////////////////////////////////////////////////////////////////////
+
+namespace {
+
+struct NameScope {
+  NameScope* const prev;
+  VariableTablePtr const vars;
+};
+
+struct Walker {
+  explicit Walker(AnalysisResultPtr ar)
+    : m_curScope{nullptr}
+    , m_ar{ar}
+  {}
+
+  void walk_functions(const FunctionContainer& funcCont) {
+    for (auto& kv : funcCont.getFunctions()) {
+      walk_function(kv.second);
+    }
+  }
+
+private:
+  void visit_closure(ClosureExpressionPtr ce) {
+    auto const cfunc = ce->getClosureFunction();
+
+    with_scope(
+      cfunc->getScope()->getVariables(),
+      [&] {
+        walk_ast(cfunc->getStmts());
+      }
+    );
+
+    if (ce->type() != ClosureType::Short) return;
+    if (ce->captureState() == ClosureExpression::CaptureState::Known) {
+      return;
+    }
+
+    auto const paramNames = ce->collectParamNames();
+    std::set<std::string> mentioned;
+    cfunc->getScope()->getVariables()->getNames(mentioned);
+
+    std::set<std::string> toCapture;
+
+    for (auto& m : mentioned) {
+      if (paramNames.count(m)) continue;
+      if (m == "this") {
+        toCapture.insert("this");
+        continue;
+      }
+      for (auto scope = m_curScope; scope; scope = scope->prev) {
+        if (scope->vars->getSymbol(m)) {
+          toCapture.insert(m);
+          break;
+        }
+      }
+    }
+
+    if (cfunc->getFunctionScope()->containsThis()) {
+      toCapture.insert("this");
+    }
+
+    ce->setCaptureList(m_ar, toCapture);
+  }
+
+  void walk_ast(ConstructPtr node) {
+    if (!node) return;
+
+    if (dynamic_pointer_cast<MethodStatement>(node)) {
+      // Don't descend into nested non-closure functions, or functions
+      // in the psuedo-main.
+      return;
+    }
+
+    if (auto ce = dynamic_pointer_cast<ClosureExpression>(node)) {
+      visit_closure(ce);
+      return;
+    }
+
+    for (int i = 0; i < node->getKidCount(); ++i) {
+      walk_ast(node->getNthKid(i));
+    }
+  }
+
+  void walk_function(const FunctionScopePtr& fscope) {
+    if (fscope->isClosure()) return;
+    auto ms = dynamic_pointer_cast<MethodStatement>(fscope->getStmt());
+
+    ConstructPtr node(ms->getStmts());
+    with_scope(
+      fscope->getVariables(),
+      [&] {
+        walk_ast(node);
+      }
+    );
+  }
+
+  template<class Func>
+  void with_scope(const VariableTablePtr& scopeVars, Func func) {
+    auto newScope = NameScope { m_curScope, scopeVars };
+    m_curScope = &newScope;
+    SCOPE_EXIT { m_curScope = m_curScope->prev; };
+    func();
+  }
+
+private:
+  NameScope* m_curScope;
+  AnalysisResultPtr m_ar;
+};
+
+}
+
+//////////////////////////////////////////////////////////////////////
+
+void resolve_lambda_names(AnalysisResultPtr ar, const FileScopePtr& fscope) {
+  Walker walker(ar);
+
+  ClassScopePtrVec classScopes;
+  fscope->getClassesFlattened(classScopes);
+  for (auto& cls : classScopes) {
+    walker.walk_functions(*cls);
+  }
+  walker.walk_functions(*fscope);
+}
+
+//////////////////////////////////////////////////////////////////////
+
+}

hphp/compiler/analysis/lambda_names.h

@@ -0,0 +1,39 @@
+/*
+   +----------------------------------------------------------------------+
+   | HipHop for PHP                                                       |
+   +----------------------------------------------------------------------+
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
+   +----------------------------------------------------------------------+
+   | This source file is subject to version 3.01 of the PHP license,      |
+   | that is bundled with this package in the file LICENSE, and is        |
+   | available through the world-wide-web at the following url:           |
+   | http://www.php.net/license/3_01.txt                                  |
+   | If you did not receive a copy of the PHP license and are unable to   |
+   | obtain it through the world-wide-web, please send a note to          |
+   | license@php.net so we can mail you a copy immediately.               |
+   +----------------------------------------------------------------------+
+*/
+
+#ifndef incl_HPHP_COMPILER_ANALYSIS_LAMBDA_NAMES_H_
+#define incl_HPHP_COMPILER_ANALYSIS_LAMBDA_NAMES_H_
+
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+
+namespace HPHP {
+
+//////////////////////////////////////////////////////////////////////
+
+/*
+ * After the first analysis pass over a file, this pass must run to
+ * resolve names for lambda expressions and determine their automatic
+ * capture lists.
+ */
+void resolve_lambda_names(AnalysisResultPtr ar, const FileScopePtr&);
+
+//////////////////////////////////////////////////////////////////////
+
+}
+
+#endif

hphp/compiler/analysis/live_dict.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,20 +14,21 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/alias_manager.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/live_dict.h>
-#include <compiler/analysis/variable_table.h>
+#include "hphp/compiler/analysis/live_dict.h"
 
-#include <compiler/expression/expression.h>
-#include <compiler/expression/assignment_expression.h>
-#include <compiler/expression/simple_variable.h>
+#include "hphp/compiler/analysis/alias_manager.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/variable_table.h"
 
-#include <compiler/statement/statement.h>
-#include <compiler/statement/block_statement.h>
-#include <compiler/statement/exp_statement.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/statement_list.h>
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/assignment_expression.h"
+#include "hphp/compiler/expression/simple_variable.h"
+
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/statement/block_statement.h"
+#include "hphp/compiler/statement/exp_statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/statement_list.h"
 
 using namespace HPHP;
 using std::vector;
@@ -326,10 +327,10 @@ void LiveDict::updateAccess(ExpressionPtr e) {
 }
 
 struct Colorizer {
-  Colorizer(int w) : toNode(w) {}
+  explicit Colorizer(int w) : toNode(w) {}
 
   struct NodeInfo {
-    NodeInfo(int index) : originalIndex(index), size(0), color(-1) {}
+    explicit NodeInfo(int index) : originalIndex(index), size(0), color(-1) {}
     int originalIndex;
     int size;
     int color;
@@ -359,7 +360,7 @@ struct Colorizer {
 
   class NodeCmp {
   public:
-    NodeCmp(const Colorizer *c) : m_c(c) {}
+    explicit NodeCmp(const Colorizer *c) : m_c(c) {}
     bool operator()(int a, int b) {
       const NodeInfo &n1 = m_c->nodes[a];
       const NodeInfo &n2 = m_c->nodes[b];
@@ -461,25 +462,10 @@ bool LiveDict::color(TypePtr type) {
       if (Type::SameType(type, e->getCPPType())) {
         SimpleVariablePtr sv(
             static_pointer_cast<SimpleVariable>(e));
-        bool isGenParam = false;
-        if (sv->getFunctionScope()->isGenerator()) {
-          // do not allow coalescing of symbols which are parameters/use vars
-          // in the generator (sym->isParameter() will be false b/c we are in
-          // the scope of the generator function)
-          FunctionScopeRawPtr origScope(sv->getFunctionScope()->getOrigGenFS());
-          assert(origScope);
-          Symbol *origSym =
-            origScope->getVariables()->getSymbol(sv->getName());
-          if (origSym &&
-              (origSym->isParameter() || origSym->isClosureVar())) {
-            isGenParam = true;
-          }
-        }
         Symbol *sym = sv->getSymbol();
         if (sym &&
             !sym->isGlobal() &&
             !sym->isParameter() &&
-            !isGenParam &&
             !sym->isClosureVar() &&
             !sym->isStatic() &&
             !e->isThis()) {
@@ -623,9 +609,8 @@ public:
       always_assert(e && e->is(Expression::KindOfSimpleVariable));
       SimpleVariablePtr sv(static_pointer_cast<SimpleVariable>(e));
       Symbol *sym = sv->getSymbol();
-      bool inGen = sv->getFunctionScope()->isGenerator();
       if (!sym || sym->isGlobal() || sym->isStatic() || sym->isParameter() ||
-          sym->isClosureVar() || sv->isThis() || inGen) {
+          sym->isClosureVar() || sv->isThis()) {
         continue;
       }
 
@@ -638,7 +623,8 @@ public:
       e->setLocation(sub->getLocation());
       e->setBlockScope(sub->getScope());
       ExpStatementPtr exp(
-          new ExpStatement(sub->getScope(), sub->getLocation(), e));
+          new ExpStatement(sub->getScope(), sub->getLabelScope(),
+                           sub->getLocation(), e));
       sl->insertElement(exp, ix);
     }
   }

hphp/compiler/analysis/live_dict.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,10 +14,10 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __LIVE_DICT_H__
-#define __LIVE_DICT_H__
+#ifndef incl_HPHP_LIVE_DICT_H_
+#define incl_HPHP_LIVE_DICT_H_
 
-#include <compiler/analysis/dictionary.h>
+#include "hphp/compiler/analysis/dictionary.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -26,7 +26,7 @@ namespace HPHP {
 
 class LiveDict : public Dictionary {
 public:
-  LiveDict(AliasManager &am) : Dictionary(am) {}
+  explicit LiveDict(AliasManager &am) : Dictionary(am) {}
   /* Building the dictionary */
   void build(MethodStatementPtr m);
   void visit(ExpressionPtr e);
@@ -53,4 +53,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __LIVE_DICT_H__
+#endif // incl_HPHP_LIVE_DICT_H_

hphp/compiler/analysis/peephole.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,19 +14,17 @@
    +----------------------------------------------------------------------+
 */
 
-#include "compiler/analysis/peephole.h"
-#include "compiler/analysis/emitter.h"
+#include "hphp/compiler/analysis/peephole.h"
+#include "hphp/compiler/analysis/emitter.h"
+#include "hphp/runtime/vm/preclass-emit.h"
 
 namespace HPHP { namespace Compiler {
 
-using VM::FuncEmitter;
-using VM::UnitEmitter;
-using VM::Offset;
 
-static void collapseJmp(Offset* offsetPtr, Opcode* instr, Opcode* start) {
+static void collapseJmp(Offset* offsetPtr, Op* instr, Op* start) {
   if (offsetPtr) {
-    Opcode* dest = instr + *offsetPtr;
-    while (*dest == OpJmp && dest != instr) {
+    Op* dest = instr + *offsetPtr;
+    while (isUnconditionalJmp(*dest) && dest != instr) {
       dest = start + instrJumpTarget(start, dest - start);
     }
     *offsetPtr = dest - instr;
@@ -45,10 +43,10 @@ Peephole::Peephole(UnitEmitter &ue, MetaInfoBuilder& metaInfo)
   buildJumpTargets();
 
   // Scan the bytecode linearly.
-  Opcode* start = ue.m_bc;
-  Opcode* prev = start;
-  Opcode* cur = prev + instrLen(prev);
-  Opcode* end = start + ue.m_bclen;
+  Op* start = (Op*)ue.m_bc;
+  Op* prev = start;
+  Op* cur = prev + instrLen(prev);
+  Op* end = start + ue.m_bclen;
 
   /*
    * TODO(1086005): we should try to minimize use of CGetL2/CGetL3.
@@ -93,10 +91,10 @@ Peephole::Peephole(UnitEmitter &ue, MetaInfoBuilder& metaInfo)
           // fallthrough
 
         incDecOp:
-          if (imm->u_OA == PostInc) {
-            imm->u_OA = PreInc;
-          } else if (imm->u_OA == PostDec) {
-            imm->u_OA = PreDec;
+          if (static_cast<IncDecOp>(imm->u_OA) == IncDecOp::PostInc) {
+            imm->u_OA = static_cast<unsigned char>(IncDecOp::PreInc);
+          } else if (static_cast<IncDecOp>(imm->u_OA) == IncDecOp::PostDec) {
+            imm->u_OA = static_cast<unsigned char>(IncDecOp::PreDec);
           }
           break;
         default:
@@ -164,14 +162,19 @@ void Peephole::buildJumpTargets() {
   }
   // all jump targets are targets
   for (Offset pos = 0; pos < (Offset)m_ue.m_bclen;
-       pos += instrLen(&m_ue.m_bc[pos])) {
-    Opcode* instr = &m_ue.m_bc[pos];
+       pos += instrLen((Op*)&m_ue.m_bc[pos])) {
+    Op* instr = (Op*)&m_ue.m_bc[pos];
     if (isSwitch(*instr)) {
       foreachSwitchTarget(instr, [&](Offset& o) {
         m_jumpTargets.insert(pos + o);
       });
+    } else if (*instr == OpIterBreak) {
+      uint32_t veclen = *(uint32_t *)(instr + 1);
+      assert(veclen > 0);
+      Offset target = *(Offset *)((uint32_t *)(instr + 1) + 2 * veclen + 1);
+      m_jumpTargets.insert(pos + target);
     } else {
-      Offset target = instrJumpTarget(m_ue.m_bc, pos);
+      Offset target = instrJumpTarget((Op*)m_ue.m_bc, pos);
       if (target != InvalidAbsoluteOffset) {
         m_jumpTargets.insert(target);
       }

hphp/compiler/analysis/peephole.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -34,8 +34,8 @@
 #ifndef incl_HPHP_COMPILER_ANALYSIS_PEEPHOLE_H_
 #define incl_HPHP_COMPILER_ANALYSIS_PEEPHOLE_H_
 
-#include "runtime/vm/unit.h"
-#include "runtime/vm/func.h"
+#include "hphp/runtime/vm/unit.h"
+#include "hphp/runtime/vm/func.h"
 
 namespace HPHP { namespace Compiler {
 
@@ -43,14 +43,14 @@ class MetaInfoBuilder;
 
 class Peephole {
 public:
-  Peephole(VM::UnitEmitter& ue, MetaInfoBuilder& metaInfo);
+  Peephole(UnitEmitter& ue, MetaInfoBuilder& metaInfo);
 
 private:
-  void buildFuncTargets(VM::FuncEmitter* fe);
+  void buildFuncTargets(FuncEmitter* fe);
   void buildJumpTargets();
 
-  VM::UnitEmitter& m_ue;
-  hphp_hash_set<VM::Offset> m_jumpTargets;
+  UnitEmitter& m_ue;
+  hphp_hash_set<Offset> m_jumpTargets;
 };
 
 }}

hphp/compiler/analysis/ref_dict.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,22 +14,22 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/alias_manager.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/ref_dict.h>
+#include "hphp/compiler/analysis/ref_dict.h"
+#include "hphp/compiler/analysis/alias_manager.h"
+#include "hphp/compiler/analysis/function_scope.h"
 
-#include <compiler/expression/expression.h>
-#include <compiler/expression/assignment_expression.h>
-#include <compiler/expression/binary_op_expression.h>
-#include <compiler/expression/simple_variable.h>
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/compiler/expression/assignment_expression.h"
+#include "hphp/compiler/expression/binary_op_expression.h"
+#include "hphp/compiler/expression/simple_variable.h"
 
-#include <compiler/statement/statement.h>
-#include <compiler/statement/block_statement.h>
-#include <compiler/statement/exp_statement.h>
-#include <compiler/statement/method_statement.h>
-#include <compiler/statement/statement_list.h>
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/statement/block_statement.h"
+#include "hphp/compiler/statement/exp_statement.h"
+#include "hphp/compiler/statement/method_statement.h"
+#include "hphp/compiler/statement/statement_list.h"
 
-#include <util/parser/hphp.tab.hpp>
+#include "hphp/parser/hphp.tab.hpp"
 
 using namespace HPHP;
 using std::vector;
@@ -74,10 +74,10 @@ void RefDict::visit(ExpressionPtr e) {
   SimpleVariablePtr ptr(static_pointer_cast<SimpleVariable>(e));
 
   if (ptr->isSuperGlobal() || ptr->isThis()) {
-    // don't both recording for super globals or this 
+    // don't both recording for super globals or this
     return;
   }
-  
+
   // Good to go
   if (m_am.insertForDict(e)) {
     record(e);
@@ -129,7 +129,7 @@ void RefDict::updateParams() {
         bool isRef;
         if (sym->isParameter()) {
           ExpressionListPtr methodParams = m_method_stmt->getParams();
-          ExpressionPtr paramExprPtr = 
+          ExpressionPtr paramExprPtr =
               (*methodParams)[sym->getParameterIndex()];
           paramType = paramExprPtr->getType();
           isRef = m_method_stmt->isRef(sym->getParameterIndex());
@@ -160,7 +160,7 @@ void RefDict::updateParams() {
 
 void RefDict::updateAccess(ExpressionPtr e) {
   always_assert(!e->getScope()->inPseudoMain());
-  
+
   int eid     = e->getCanonID();
   int context = e->getContext();
 
@@ -204,7 +204,7 @@ void RefDict::updateAccess(ExpressionPtr e) {
              context & Expression::UnsetContext) {
     BitOps::set_bit(eid, m_referenced, false);
     BitOps::set_bit(eid, m_killed, true);
-  } 
+  }
 
   if (first_pass) return;
 
@@ -215,7 +215,7 @@ void RefDict::updateAccess(ExpressionPtr e) {
     // we dealt with this node as a store expression
     return;
   }
-  
+
   int cls = e->getExprClass();
 
   bool isRhsNeeded = false;
@@ -227,7 +227,7 @@ void RefDict::updateAccess(ExpressionPtr e) {
   if (cls & Expression::Store) {
     // we care about two cases here
     switch (e->getKindOf()) {
-      case Expression::KindOfAssignmentExpression: 
+      case Expression::KindOfAssignmentExpression:
         // $x = ...
         {
           AssignmentExpressionPtr assign(
@@ -254,7 +254,7 @@ void RefDict::updateAccess(ExpressionPtr e) {
         break;
     }
   }
-  
+
   bool isLhsSimpleVar = false;
   bool isLhsDynamic   = false;
   bool isRefd         = false;
@@ -343,20 +343,20 @@ void RefDict::updateAccess(ExpressionPtr e) {
       // unset($x);
       BitOps::set_bit(eid, m_obj, false);
       BitOps::set_bit(eid, m_noobj, true);
-    } else if (isRefd || 
+    } else if (isRefd ||
         ((context & Expression::Declaration) == Expression::Declaration)) {
       // if a simple variable has isRefd, then we need to mark it
       // as potentially containing an object.
-      // also, if the simple variable is in global context 
+      // also, if the simple variable is in global context
       // then we also mark it as potentially containing an object
       BitOps::set_bit(eid, m_obj, true);
       BitOps::set_bit(eid, m_noobj, false);
-    }  
+    }
   }
 
   if (isRefd) {
-    // do a scan for every simple variable referenced value 
-    // in the dictionary and mark it as potentially 
+    // do a scan for every simple variable referenced value
+    // in the dictionary and mark it as potentially
     // containing an object (in the bit vector)
     for (int i = size(); i--; ) {
       if (ExpressionPtr e = get(i)) {
@@ -372,8 +372,8 @@ void RefDict::updateAccess(ExpressionPtr e) {
 }
 
 int RefDictWalker::after(ConstructRawPtr cp) {
-  if (SimpleVariableRawPtr s = 
-      boost::dynamic_pointer_cast<SimpleVariable>(cp)) {
+  if (SimpleVariableRawPtr s =
+      dynamic_pointer_cast<SimpleVariable>(cp)) {
     if (int id = s->getCanonID()) {
       if (first_pass) {
         if (s->isAvailable() && m_block->getBit(DataFlow::PRefIn, id)) {

hphp/compiler/analysis/ref_dict.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,17 +14,17 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __REF_DICT_H__
-#define __REF_DICT_H__
+#ifndef incl_HPHP_REF_DICT_H_
+#define incl_HPHP_REF_DICT_H_
 
-#include <compiler/analysis/dictionary.h>
+#include "hphp/compiler/analysis/dictionary.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
 
 class RefDict : public Dictionary {
 public:
-  RefDict(AliasManager &am) : Dictionary(am), first_pass(true) {}
+  explicit RefDict(AliasManager &am) : Dictionary(am), first_pass(true) {}
 
   /* Building the dictionary */
   void build(MethodStatementPtr m);
@@ -52,7 +52,7 @@ private:
 
 class RefDictWalker : public ControlFlowGraphWalker {
 public:
-  RefDictWalker(ControlFlowGraph *g) :
+  explicit RefDictWalker(ControlFlowGraph *g) :
     ControlFlowGraphWalker(g), first_pass(true) {}
   void walk() { ControlFlowGraphWalker::walk(*this); }
   int after(ConstructRawPtr cp);
@@ -63,4 +63,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __REF_DICT_H__
+#endif // incl_HPHP_REF_DICT_H_

hphp/compiler/analysis/symbol_table.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,23 +14,24 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/symbol_table.h>
-#include <compiler/analysis/type.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/function_scope.h>
+#include "hphp/compiler/analysis/symbol_table.h"
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/function_scope.h"
 
-#include <compiler/expression/constant_expression.h>
-#include <compiler/expression/expression_list.h>
-#include <compiler/expression/parameter_expression.h>
-#include <compiler/expression/simple_variable.h>
+#include "hphp/compiler/expression/assignment_expression.h"
+#include "hphp/compiler/expression/constant_expression.h"
+#include "hphp/compiler/expression/expression_list.h"
+#include "hphp/compiler/expression/parameter_expression.h"
+#include "hphp/compiler/expression/simple_variable.h"
 
-#include <runtime/base/class_info.h>
-#include <runtime/base/complex_types.h>
-#include <runtime/base/variable_serializer.h>
+#include "hphp/runtime/base/class-info.h"
+#include "hphp/runtime/base/complex-types.h"
+#include "hphp/runtime/base/variable-serializer.h"
 
-#include <util/logger.h>
+#include "hphp/util/logger.h"
 
 using namespace HPHP;
 
@@ -64,13 +65,13 @@ TypePtr Symbol::setType(AnalysisResultConstPtr ar, BlockScopeRawPtr scope,
     // at this point, you *must* have a lock (if you are user scope)
     if (scope->is(BlockScope::FunctionScope)) {
       FunctionScopeRawPtr f =
-        boost::static_pointer_cast<FunctionScope>(scope);
+        static_pointer_cast<FunctionScope>(scope);
       if (f->isUserFunction()) {
         f->getInferTypesMutex().assertOwnedBySelf();
       }
     } else if (scope->is(BlockScope::ClassScope)) {
       ClassScopeRawPtr c =
-        boost::static_pointer_cast<ClassScope>(scope);
+        static_pointer_cast<ClassScope>(scope);
       if (c->isUserClass()) {
         c->getInferTypesMutex().assertOwnedBySelf();
       }
@@ -284,9 +285,9 @@ void Symbol::serializeParam(JSON::DocTarget::OutputStream &out) const {
     assert(valueExp);
     const string &init = ExtractInitializer(out.analysisResult(), valueExp);
     if (!init.empty()) out << init;
-    else               out << JSON::Null;
+    else               out << JSON::Null();
   } else {
-    out << JSON::Null;
+    out << JSON::Null();
   }
 
   ms.done();
@@ -295,20 +296,18 @@ void Symbol::serializeParam(JSON::DocTarget::OutputStream &out) const {
 static inline std::string ExtractDocComment(ExpressionPtr e) {
   if (!e) return "";
   switch (e->getKindOf()) {
-  case Expression::KindOfAssignmentExpression:
-    return ExtractDocComment(e->getNthExpr(0));
-  case Expression::KindOfSimpleVariable:
-    {
-      SimpleVariablePtr sv(
-        static_pointer_cast<SimpleVariable>(e));
-      return sv->getDocComment();
-    }
-  case Expression::KindOfConstantExpression:
-    {
-      ConstantExpressionPtr ce(
-        static_pointer_cast<ConstantExpression>(e));
-      return ce->getDocComment();
-    }
+  case Expression::KindOfAssignmentExpression: {
+    AssignmentExpressionPtr ae(static_pointer_cast<AssignmentExpression>(e));
+    return ExtractDocComment(ae->getVariable());
+  }
+  case Expression::KindOfSimpleVariable: {
+    SimpleVariablePtr sv(static_pointer_cast<SimpleVariable>(e));
+    return sv->getDocComment();
+  }
+  case Expression::KindOfConstantExpression: {
+    ConstantExpressionPtr ce(static_pointer_cast<ConstantExpression>(e));
+    return ce->getDocComment();
+  }
   default: return "";
   }
   return "";
@@ -337,9 +336,9 @@ void Symbol::serializeClassVar(JSON::DocTarget::OutputStream &out) const {
     assert(initExp);
     const string &init = ExtractInitializer(out.analysisResult(), initExp);
     if (!init.empty()) out << init;
-    else               out << JSON::Null;
+    else               out << JSON::Null();
   } else {
-    out << JSON::Null;
+    out << JSON::Null();
   }
 
   const string &docs = ExtractDocComment(
@@ -521,17 +520,6 @@ ConstructPtr SymbolTable::getValue(const std::string &name) const {
   return ConstructPtr();
 }
 
-void SymbolTable::setSepExtension(const std::string &name) {
-  genSymbol(name, m_const)->setSep();
-}
-
-bool SymbolTable::isSepExtension(const std::string &name) const {
-  if (const Symbol *sym = getSymbol(name)) {
-    return sym->isSep();
-  }
-  return false;
-}
-
 TypePtr SymbolTable::setType(AnalysisResultConstPtr ar, const std::string &name,
                              TypePtr type, bool coerced) {
   return setType(ar, genSymbol(name, m_const), type, coerced);
@@ -596,7 +584,7 @@ void SymbolTable::countTypes(std::map<std::string, int> &counts) {
 }
 
 string SymbolTable::getEscapedText(Variant v, int &len) {
-  VariableSerializer vs(VariableSerializer::Serialize);
+  VariableSerializer vs(VariableSerializer::Type::Serialize);
   String str = vs.serialize(v, true);
   len = str.length();
   string output = Util::escapeStringForCPP(str.data(), len);

hphp/compiler/analysis/symbol_table.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,13 +14,14 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __SYMBOL_TABLE_H__
-#define __SYMBOL_TABLE_H__
+#ifndef incl_HPHP_SYMBOL_TABLE_H_
+#define incl_HPHP_SYMBOL_TABLE_H_
 
-#include <compiler/hphp.h>
-#include <util/json.h>
-#include <util/util.h>
-#include <util/lock.h>
+#include "hphp/compiler/hphp.h"
+#include "hphp/compiler/json.h"
+#include "hphp/util/util.h"
+#include "hphp/util/lock.h"
+#include "hphp/util/hash-map-typedefs.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -29,7 +30,7 @@ class BlockScope;
 class CodeGenerator;
 class Variant;
 DECLARE_BOOST_TYPES(Construct);
-DECLARE_BOOST_TYPES(Type);
+DECLARE_EXTENDED_BOOST_TYPES(Type);
 DECLARE_BOOST_TYPES(AnalysisResult);
 DECLARE_BOOST_TYPES(SymbolTable);
 DECLARE_BOOST_TYPES(FunctionScope);
@@ -74,9 +75,7 @@ public:
   void setReplaced() { m_flags.m_replaced = true; }
   bool valueSet() const { return m_flags.m_value_set; }
   bool isSystem() const { return m_flags.m_system; }
-  bool isSep() const { return m_flags.m_sep; }
   void setSystem() { m_flags.m_system = true; }
-  void setSep() { m_flags.m_sep = true; }
   bool isConstant() const { return m_flags.m_constant; }
   void setConstant() { m_flags.m_constant = true; }
 
@@ -185,7 +184,7 @@ private:
   std::string  m_name;
   unsigned int m_hash;
   union {
-    unsigned m_flags_val;
+    uint32_t m_flags_val;
     struct {
       /* internal */
       unsigned m_declaration_set : 1;
@@ -196,7 +195,6 @@ private:
 
       /* common */
       unsigned m_system : 1;
-      unsigned m_sep : 1;
 
       /* ConstantTable */
       unsigned m_dynamic : 1;
@@ -227,7 +225,13 @@ private:
       unsigned m_stashedVal : 1;
       unsigned m_reseated : 1;
     } m_flags;
+
+
   };
+  static_assert(
+    sizeof(m_flags_val) == sizeof(m_flags),
+    "m_flags_val must cover all the flags");
+
   ConstructPtr        m_declaration;
   ConstructPtr        m_value;
   TypePtr             m_coerced;
@@ -244,7 +248,7 @@ private:
 
 class SymParamWrapper : public JSON::DocTarget::ISerializable {
 public:
-  SymParamWrapper(const Symbol* sym) : m_sym(sym) {
+  explicit SymParamWrapper(const Symbol* sym) : m_sym(sym) {
     assert(sym);
   }
   virtual void serialize(JSON::DocTarget::OutputStream &out) const {
@@ -256,7 +260,7 @@ private:
 
 class SymClassVarWrapper : public JSON::DocTarget::ISerializable {
 public:
-  SymClassVarWrapper(const Symbol* sym) : m_sym(sym) {
+  explicit SymClassVarWrapper(const Symbol* sym) : m_sym(sym) {
     assert(sym);
   }
   virtual void serialize(JSON::DocTarget::OutputStream &out) const {
@@ -269,7 +273,7 @@ private:
 /**
  * Base class of VariableTable and ConstantTable.
  */
-class SymbolTable : public boost::enable_shared_from_this<SymbolTable>,
+class SymbolTable : public std::enable_shared_from_this<SymbolTable>,
                     public JSON::CodeError::ISerializable {
 public:
   static Mutex AllSymbolTablesMutex;
@@ -335,10 +339,6 @@ public:
   ConstructPtr getDeclaration(const std::string &name) const;
   ConstructPtr getValue(const std::string &name) const;
 
-  /* Whether this constant is brought in by a separable extension */
-  void setSepExtension(const std::string &name);
-  bool isSepExtension(const std::string &name) const;
-
   /**
    * How big of a hash table for generate C++ switch statements.
    */
@@ -382,4 +382,4 @@ private:
 ///////////////////////////////////////////////////////////////////////////////
 }
 
-#endif // __SYMBOL_TABLE_H__
+#endif // incl_HPHP_SYMBOL_TABLE_H_

hphp/compiler/analysis/type.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,12 +14,14 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/type.h>
-#include <compiler/code_generator.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/expression/expression.h>
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/code_generator.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/expression/expression.h"
+#include "hphp/runtime/base/builtin-functions.h"
+#include "hphp/runtime/vm/runtime.h"
 #include <boost/format.hpp>
 
 using namespace HPHP;
@@ -35,6 +37,7 @@ TypePtr Type::Double      (new Type(Type::KindOfDouble      ));
 TypePtr Type::String      (new Type(Type::KindOfString      ));
 TypePtr Type::Array       (new Type(Type::KindOfArray       ));
 TypePtr Type::Object      (new Type(Type::KindOfObject      ));
+TypePtr Type::Resource    (new Type(Type::KindOfResource    ));
 TypePtr Type::Variant     (new Type(Type::KindOfVariant     ));
 
 TypePtr Type::Numeric     (new Type(Type::KindOfNumeric     ));
@@ -49,38 +52,65 @@ TypePtr Type::Any         (new Type(Type::KindOfAny         ));
 TypePtr Type::Some        (new Type(Type::KindOfSome        ));
 
 Type::TypePtrMap Type::s_TypeHintTypes;
+Type::TypePtrMap Type::s_HHTypeHintTypes;
 
 void Type::InitTypeHintMap() {
   assert(s_TypeHintTypes.empty());
+  assert(s_HHTypeHintTypes.empty());
+
   s_TypeHintTypes["array"] = Type::Array;
-  if (Option::EnableHipHopSyntax) {
-    s_TypeHintTypes["bool"]    = Type::Boolean;
-    s_TypeHintTypes["boolean"] = Type::Boolean;
-    s_TypeHintTypes["int"]     = Type::Int64;
-    s_TypeHintTypes["integer"] = Type::Int64;
-    s_TypeHintTypes["real"]    = Type::Double;
-    s_TypeHintTypes["double"]  = Type::Double;
-    s_TypeHintTypes["float"]   = Type::Double;
-    s_TypeHintTypes["string"]  = Type::String;
-  }
+  s_TypeHintTypes["resource"] = Type::Resource;
+  s_TypeHintTypes["callable"] = Type::Variant;
+
+  s_HHTypeHintTypes["array"] = Type::Array;
+  s_HHTypeHintTypes["bool"]    = Type::Boolean;
+  s_HHTypeHintTypes["boolean"] = Type::Boolean;
+  s_HHTypeHintTypes["int"]     = Type::Int64;
+  s_HHTypeHintTypes["integer"] = Type::Int64;
+  s_HHTypeHintTypes["real"]    = Type::Double;
+  s_HHTypeHintTypes["double"]  = Type::Double;
+  s_HHTypeHintTypes["float"]   = Type::Double;
+  s_HHTypeHintTypes["string"]  = Type::String;
+  // Type::Numeric doesn't include numeric strings; this is intentional
+  s_HHTypeHintTypes["num"]      = Type::Numeric;
+  s_HHTypeHintTypes["resource"] = Type::Resource;
+  s_HHTypeHintTypes["callable"] = Type::Variant;
 }
 
-const Type::TypePtrMap &Type::GetTypeHintTypes() {
-  return s_TypeHintTypes;
+const Type::TypePtrMap &Type::GetTypeHintTypes(bool hhType) {
+  return hhType ? s_HHTypeHintTypes : s_TypeHintTypes;
 }
 
 void Type::ResetTypeHintTypes() {
   s_TypeHintTypes.clear();
+  s_HHTypeHintTypes.clear();
 }
 
-TypePtr Type::CreateObjectType(const std::string &classname) {
-  return TypePtr(new Type(KindOfObject, classname));
+TypePtr Type::CreateObjectType(const std::string &clsname) {
+  // For interfaces that support primitive types, we're pessimistic and
+  // we treat it as a Variant
+  if (interface_supports_array(clsname) ||
+      interface_supports_string(clsname) ||
+      interface_supports_int(clsname) ||
+      interface_supports_double(clsname)) {
+    return Type::Variant;
+  }
+  return TypePtr(new Type(KindOfObject, clsname));
 }
 
-TypePtr Type::GetType(KindOf kindOf,
-                      const std::string &clsname /* = "" */) {
+TypePtr Type::GetType(KindOf kindOf, const std::string &clsname /* = "" */) {
   assert(kindOf);
-  if (!clsname.empty()) return TypePtr(new Type(kindOf, clsname));
+  if (!clsname.empty()) {
+    // For interfaces that support primitive types we're pessimistic and
+    // we treat it as a Variant
+    if (interface_supports_array(clsname) ||
+        interface_supports_string(clsname) ||
+        interface_supports_int(clsname) ||
+        interface_supports_double(clsname)) {
+      return Type::Variant;
+    }
+    return TypePtr(new Type(kindOf, clsname));
+  }
 
   switch (kindOf) {
   case KindOfBoolean:     return Type::Boolean;
@@ -91,6 +121,7 @@ TypePtr Type::GetType(KindOf kindOf,
   case KindOfArray:       return Type::Array;
   case KindOfVariant:     return Type::Variant;
   case KindOfObject:      return Type::Object;
+  case KindOfResource:    return Type::Resource;
   case KindOfNumeric:     return Type::Numeric;
   case KindOfPrimitive:   return Type::Primitive;
   case KindOfPlusOperand: return Type::PlusOperand;
@@ -177,6 +208,7 @@ bool Type::IsMappedToVariant(TypePtr t) {
   case KindOfString :
   case KindOfArray  :
   case KindOfObject :
+  case KindOfResource:
     return false;
   default: break;
   }
@@ -245,7 +277,8 @@ TypePtr Type::Coerce(AnalysisResultConstPtr ar, TypePtr type1, TypePtr type2) {
   if (type1->m_kindOf == KindOfVoid &&
       (type2->m_kindOf == KindOfString ||
        type2->m_kindOf == KindOfArray ||
-       type2->m_kindOf == KindOfObject)) {
+       type2->m_kindOf == KindOfObject ||
+       type2->m_kindOf == KindOfResource)) {
     return type2;
   }
   if (type2->m_kindOf == KindOfSome ||
@@ -380,6 +413,7 @@ bool Type::HasFastCastMethod(TypePtr t) {
   case Type::KindOfString:
   case Type::KindOfArray:
   case Type::KindOfObject:
+  case Type::KindOfResource:
     return true;
   default: break;
   }
@@ -425,6 +459,9 @@ string Type::GetFastCastMethod(
   case Type::KindOfObject:
     type = "Obj";
     break;
+  case Type::KindOfResource:
+    type = "Res";
+    break;
   default:
     type = ""; // make the compiler happy
     assert(false);
@@ -520,11 +557,13 @@ bool Type::isSpecificObject() const {
 }
 
 bool Type::isNonConvertibleType() const {
-  return m_kindOf == KindOfObject || m_kindOf == KindOfArray;
+  return m_kindOf == KindOfObject || m_kindOf == KindOfResource ||
+         m_kindOf == KindOfArray;
 }
 
 bool Type::isNoObjectInvolved() const {
   if (couldBe(KindOfObject)
+   || couldBe(KindOfResource)
    || couldBe(KindOfArray))
     return false;
   else
@@ -598,6 +637,7 @@ DataType Type::getDataType() const {
     case KindOfString:      return HPHP::KindOfString;
     case KindOfArray:       return HPHP::KindOfArray;
     case KindOfObject:      return HPHP::KindOfObject;
+    case KindOfResource:    return HPHP::KindOfResource;
     case KindOfNumeric:
     case KindOfPrimitive:
     case KindOfPlusOperand:
@@ -619,6 +659,7 @@ std::string Type::getPHPName() {
   switch (m_kindOf) {
   case KindOfArray:       return "array";
   case KindOfObject:      return m_name;
+  case KindOfResource:    return "resource";
   default: break;
   }
   return "";
@@ -636,6 +677,7 @@ std::string Type::toString() const {
   case KindOfSome:        return "Some";
   case KindOfAny:         return "Any";
   case KindOfObject:      return string("Object - ") + m_name;
+  case KindOfResource:    return "Resource";
   case KindOfNumeric:     return "Numeric";
   case KindOfPrimitive:   return "Primitive";
   case KindOfPlusOperand: return "PlusOperand";
@@ -684,6 +726,7 @@ void Type::serialize(JSON::DocTarget::OutputStream &out) const {
     }
     break;
   }
+  case KindOfResource:    s = "resource"; break;
   case KindOfNumeric:     s = "numeric"; break;
   case KindOfPrimitive:   s = "primitive"; break;
   case KindOfPlusOperand: s = "any"; break;

hphp/compiler/analysis/type.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,13 +14,13 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __TYPE_H__
-#define __TYPE_H__
+#ifndef incl_HPHP_TYPE_H_
+#define incl_HPHP_TYPE_H_
 
-#include <compiler/hphp.h>
-#include <util/json.h>
-#include <util/case_insensitive.h>
-#include <runtime/base/types.h>
+#include "hphp/compiler/hphp.h"
+#include "hphp/compiler/json.h"
+#include "hphp/util/functional.h"
+#include "hphp/runtime/base/types.h"
 
 
 class TestCodeRun;
@@ -53,6 +53,7 @@ public:
   static const KindOf KindOfString     = 0x0080;
   static const KindOf KindOfArray      = 0x0100;
   static const KindOf KindOfObject     = 0x0200;   // with classname
+  static const KindOf KindOfResource   = 0x0400;
   static const KindOf KindOfVariant    = 0xFFFF;
 
   /* This bit tells coerce that if the other type
@@ -88,6 +89,7 @@ public:
   static TypePtr String;
   static TypePtr Array;
   static TypePtr Object;
+  static TypePtr Resource;
   static TypePtr Variant;
 
   static TypePtr Numeric;
@@ -102,7 +104,7 @@ public:
   static TypePtr Some;
 
   typedef hphp_string_imap<TypePtr> TypePtrMap;
-  static const TypePtrMap &GetTypeHintTypes();
+  static const TypePtrMap &GetTypeHintTypes(bool hhType);
 
   /**
    * Uncertain types: types that are ambiguous yet.
@@ -201,7 +203,7 @@ public:
   /**
    * KindOf testing.
    */
-  Type(KindOf kindOf);
+  explicit Type(KindOf kindOf);
   bool is(KindOf kindOf) const { return m_kindOf == kindOf;}
   bool isExactType() const { return IsExactType(m_kindOf); }
   bool mustBe(KindOf kindOf) const { return !(m_kindOf & ~kindOf); }
@@ -267,6 +269,7 @@ private:
   static void ResetTypeHintTypes();
 
   static TypePtrMap s_TypeHintTypes;
+  static TypePtrMap s_HHTypeHintTypes;
 
   const KindOf m_kindOf;
   const std::string m_name;
@@ -274,4 +277,4 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __TYPE_H__
+#endif // incl_HPHP_TYPE_H_

hphp/compiler/analysis/variable_table.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,24 +14,25 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/analysis/variable_table.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/type.h>
-#include <compiler/code_generator.h>
-#include <compiler/expression/modifier_expression.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/expression/simple_variable.h>
-#include <compiler/builtin_symbols.h>
-#include <compiler/option.h>
-#include <compiler/expression/simple_function_call.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/expression/static_member_expression.h>
-#include <runtime/base/class_info.h>
-#include <util/util.h>
-#include <util/parser/location.h>
-#include <util/parser/parser.h>
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/code_generator.h"
+#include "hphp/compiler/expression/modifier_expression.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/expression/simple_variable.h"
+#include "hphp/compiler/builtin_symbols.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/expression/parameter_expression.h"
+#include "hphp/compiler/expression/static_member_expression.h"
+#include "hphp/runtime/base/class-info.h"
+#include "hphp/util/util.h"
+#include "hphp/parser/location.h"
+#include "hphp/parser/parser.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -68,20 +69,31 @@ VariableTable::VariableTable(BlockScope &blockScope)
 
 void VariableTable::getLocalVariableNames(vector<string> &syms) const {
   FunctionScopeRawPtr fs = getScopePtr()->getContainingFunction();
-  bool dollarThisIsSpecial = (fs->getContainingClass() ||
-                              fs->inPseudoMain());
+  bool dollarThisIsSpecial = fs->getContainingClass() ||
+                             fs->inPseudoMain() ||
+                             // In closures, $this is "sometimes"
+                             // special (if it's a closure in a method
+                             // body), but it easiest to just always
+                             // treat it special.
+                             fs->isClosure();
 
+  bool hadThisSym = false;
   for (unsigned int i = 0; i < m_symbolVec.size(); i++) {
     const string& name = m_symbolVec[i]->getName();
     if (name == "this" && dollarThisIsSpecial) {
-      // The "this" variable in methods and pseudo-main is special and is
-      // handled separately below.
+      /*
+       * The "this" variable in methods, pseudo-main, or closures is
+       * special and is handled separately below.
+       *
+       * Closures are the specialest.
+       */
+      hadThisSym = true;
       continue;
     }
     syms.push_back(name);
   }
 
-  if (fs->needsLocalThis()) {
+  if (fs->needsLocalThis() || (hadThisSym && fs->isClosure())) {
     assert(dollarThisIsSpecial);
     // We only need a local variable named "this" if the current function
     // contains an occurrence of "$this" that is not part of a property
@@ -225,7 +237,7 @@ ConstructPtr VariableTable::getStaticInitVal(string varName) {
 bool VariableTable::setStaticInitVal(string varName,
                                      ConstructPtr value) {
   Symbol *sym = addSymbol(varName);
-  bool exists = sym->getStaticInitVal();
+  bool exists = (sym->getStaticInitVal() != nullptr);
   sym->setStaticInitVal(value);
   return exists;
 }
@@ -239,7 +251,7 @@ ConstructPtr VariableTable::getClassInitVal(string varName) {
 
 bool VariableTable::setClassInitVal(string varName, ConstructPtr value) {
   Symbol *sym = addSymbol(varName);
-  bool exists = sym->getClassInitVal();
+  bool exists = (sym->getClassInitVal() != nullptr);
   sym->setClassInitVal(value);
   return exists;
 }
@@ -290,8 +302,7 @@ void VariableTable::addStaticVariable(Symbol *sym,
   m_hasStatic = true;
 
   FunctionScopeRawPtr funcScope = getFunctionScope();
-  if (funcScope &&
-      (funcScope->isClosure() || funcScope->isGeneratorFromClosure())) {
+  if (funcScope && funcScope->isClosure()) {
     // static variables for closures/closure generators are local to the
     // function scope
     m_staticLocalsVec.push_back(sym);
@@ -415,7 +426,14 @@ TypePtr VariableTable::add(Symbol *sym, TypePtr type,
   }
 
   type = setType(ar, sym, type, true);
-  sym->setDeclaration(construct);
+  if (sym->isParameter()) {
+    auto p = dynamic_pointer_cast<ParameterExpression>(construct);
+    if (p) {
+      sym->setDeclaration(construct);
+    }
+  } else {
+    sym->setDeclaration(construct);
+  }
 
   if (!implicit && m_blockScope.isFirstPass()) {
     if (!sym->getValue()) {
@@ -738,7 +756,7 @@ static bool by_location(const VariableTable::StaticGlobalInfoPtr &p1,
                         const VariableTable::StaticGlobalInfoPtr &p2) {
   ConstructRawPtr d1 = p1->sym->getDeclaration();
   ConstructRawPtr d2 = p2->sym->getDeclaration();
-  if (!d1) return d2;
+  if (!d1) return !!d2;
   if (!d2) return false;
   return d1->getLocation()->compare(d2->getLocation().get()) < 0;
 }

hphp/compiler/analysis/variable_table.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,12 +14,13 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __VARIABLE_TABLE_H__
-#define __VARIABLE_TABLE_H__
+#ifndef incl_HPHP_VARIABLE_TABLE_H_
+#define incl_HPHP_VARIABLE_TABLE_H_
 
-#include <compiler/analysis/symbol_table.h>
-#include <compiler/statement/statement.h>
-#include <compiler/analysis/class_scope.h>
+#include "hphp/compiler/analysis/symbol_table.h"
+#include "hphp/compiler/statement/statement.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/util/hash-map-typedefs.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -100,7 +101,7 @@ public:
   }
 
 public:
-  VariableTable(BlockScope &blockScope);
+  explicit VariableTable(BlockScope &blockScope);
 
   /**
    * Get/set attributes.
@@ -296,7 +297,7 @@ public:
    * GlobalVariables class to make ThreadLocal<GlobalVaribles> work.
    * This data structure is only needed by global scope.
    */
-  DECLARE_BOOST_TYPES(StaticGlobalInfo);
+  DECLARE_EXTENDED_BOOST_TYPES(StaticGlobalInfo);
   struct StaticGlobalInfo {
     Symbol *sym;
     VariableTable *variables; // where this variable was from
@@ -353,4 +354,4 @@ private:
 ///////////////////////////////////////////////////////////////////////////////
 }
 
-#endif // __VARIABLE_TABLE_H__
+#endif // incl_HPHP_VARIABLE_TABLE_H_

hphp/compiler/builtin_symbols.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,24 +14,27 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/builtin_symbols.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/analysis/type.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/expression/modifier_expression.h>
-#include <compiler/option.h>
-#include <compiler/parser/parser.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/analysis/constant_table.h>
-#include <util/parser/hphp.tab.hpp>
-#include <runtime/base/class_info.h>
-#include <runtime/base/program_functions.h>
-#include <runtime/base/array/array_iterator.h>
-#include <util/logger.h>
-#include <util/util.h>
+#include "hphp/compiler/builtin_symbols.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/expression/modifier_expression.h"
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/analysis/constant_table.h"
+#include "hphp/parser/hphp.tab.hpp"
+#include "hphp/runtime/base/class-info.h"
+#include "hphp/runtime/base/program-functions.h"
+#include "hphp/runtime/base/array-iterator.h"
+#include "hphp/runtime/base/execution-context.h"
+#include "hphp/runtime/base/thread-init-fini.h"
+#include "hphp/util/logger.h"
+#include "hphp/util/util.h"
 #include <dlfcn.h>
 
 using namespace HPHP;
@@ -46,39 +49,8 @@ using namespace HPHP;
 ///////////////////////////////////////////////////////////////////////////////
 
 bool BuiltinSymbols::Loaded = false;
-bool BuiltinSymbols::NoSuperGlobals = false;
 StringBag BuiltinSymbols::s_strings;
-
-namespace HPHP {
-#define EXT_TYPE 4
-#include <system/ext.inc>
-#undef EXT_TYPE
-}
-
-const char *BuiltinSymbols::ExtensionFunctions[] = {
-#define S(n) (const char *)n
-#define T(t) (const char *)Type::KindOf ## t
-#define EXT_TYPE 0
-#include <system/ext.inc>
-  nullptr,
-};
-#undef EXT_TYPE
-
-const char *BuiltinSymbols::ExtensionConsts[] = {
-#define EXT_TYPE 1
-#include <system/ext.inc>
-  nullptr,
-};
-#undef EXT_TYPE
-
-const char *BuiltinSymbols::ExtensionClasses[] = {
-#define EXT_TYPE 2
-#include <system/ext.inc>
-  nullptr,
-};
-#undef EXT_TYPE
-
-StringToFunctionScopePtrMap BuiltinSymbols::s_functions;
+AnalysisResultPtr BuiltinSymbols::s_systemAr;
 
 const char *const BuiltinSymbols::GlobalNames[] = {
   "HTTP_RAW_POST_DATA",
@@ -100,6 +72,7 @@ const char *BuiltinSymbols::SystemClasses[] = {
   "exception",
   "arrayaccess",
   "iterator",
+  "collections",
   "reflection",
   "splobjectstorage",
   "directory",
@@ -112,11 +85,7 @@ const char *BuiltinSymbols::SystemClasses[] = {
   nullptr
 };
 
-StringToClassScopePtrMap BuiltinSymbols::s_classes;
-VariableTablePtr BuiltinSymbols::s_variables;
-ConstantTablePtr BuiltinSymbols::s_constants;
 StringToTypePtrMap BuiltinSymbols::s_superGlobals;
-void *BuiltinSymbols::s_handle_main = nullptr;
 
 ///////////////////////////////////////////////////////////////////////////////
 
@@ -125,462 +94,307 @@ int BuiltinSymbols::NumGlobalNames() {
     sizeof(BuiltinSymbols::GlobalNames[0]);
 }
 
-void BuiltinSymbols::ParseExtFunctions(AnalysisResultPtr ar, const char **p,
-                                       bool sep) {
-  while (*p) {
-    FunctionScopePtr f = ParseExtFunction(ar, p);
-    if (sep) {
-      f->setSepExtension();
-    }
-    assert(!s_functions[f->getName()]);
-    s_functions[f->getName()] = f;
+static TypePtr typePtrFromDataType(DataType dt, TypePtr unknown) {
+  switch (dt) {
+    case KindOfNull:    return Type::Null;
+    case KindOfBoolean: return Type::Boolean;
+    case KindOfInt64:   return Type::Int64;
+    case KindOfDouble:  return Type::Double;
+    case KindOfString:  return Type::String;
+    case KindOfArray:   return Type::Array;
+    case KindOfObject:  return Type::Object;
+    case KindOfResource: return Type::Resource;
+    case KindOfUnknown:
+    default:
+      return unknown;
   }
 }
 
-void BuiltinSymbols::ParseExtConsts(AnalysisResultPtr ar, const char **p,
-                                    bool sep) {
-  while (*p) {
-    const char *name = *p++;
-    TypePtr type = ParseType(p);
-    s_constants->add(name, type, ExpressionPtr(), ar, ConstructPtr());
-    if (sep) {
-      s_constants->setSepExtension(name);
+const StaticString
+  s_fb_call_user_func_safe("fb_call_user_func_safe"),
+  s_fb_call_user_func_safe_return("fb_call_user_func_safe_return"),
+  s_fb_call_user_func_array_safe("fb_call_user_func_array_safe"),
+  s_is_callable("is_callable"),
+  s_call_user_func_array("call_user_func_array");
+
+FunctionScopePtr BuiltinSymbols::ImportFunctionScopePtr(AnalysisResultPtr ar,
+                 ClassInfo *cls, ClassInfo::MethodInfo *method) {
+  int attrs = method->attribute;
+  bool isMethod = cls != ClassInfo::GetSystem();
+  FunctionScopePtr f(new FunctionScope(isMethod,
+                                       method->name.data(),
+                                       attrs & ClassInfo::IsReference));
+
+  int reqCount = 0, totalCount = 0;
+  for(auto it = method->parameters.begin();
+      it != method->parameters.end(); ++it) {
+    const ClassInfo::ParameterInfo *pinfo = *it;
+    if (!pinfo->value || !pinfo->value[0]) {
+      ++reqCount;
+    }
+    ++totalCount;
+  }
+  f->setParamCounts(ar, reqCount, totalCount);
+
+  int idx = 0;
+  for(auto it = method->parameters.begin();
+      it != method->parameters.end(); ++it, ++idx) {
+    const ClassInfo::ParameterInfo *pinfo = *it;
+    f->setParamName(idx, pinfo->name);
+    if (pinfo->attribute & ClassInfo::IsReference) {
+      f->setRefParam(idx);
+    }
+    f->setParamType(ar, idx, typePtrFromDataType(pinfo->argType, Type::Any));
+    if (pinfo->valueLen) {
+      f->setParamDefault(idx, pinfo->value, pinfo->valueLen,
+                         std::string(pinfo->valueText, pinfo->valueTextLen));
     }
   }
-}
 
-TypePtr BuiltinSymbols::ParseType(const char **&p) {
-  const char *clsname = nullptr;
-  Type::KindOf ktype = (Type::KindOf)(long)(*p++);
-  if (ktype == CLASS_TYPE) {
-    clsname = *p++;
-  }
-  TypePtr type;
-  if (clsname) {
-    type = Type::CreateObjectType(clsname);
-  } else if (ktype != Type::KindOfVoid) {
-    type = Type::GetType(ktype);
-  }
-  return type;
-}
-
-void BuiltinSymbols::ParseExtClasses(AnalysisResultPtr ar, const char **p,
-                                     bool sep) {
-  while (*p) {
-    // Parse name
-    const char *cname = *p++;
-    // Parse parent
-    const char *cparent = *p++;
-    if (!cparent) cparent = "";
-    // Parse list of interfaces
-    vector<string> ifaces;
-    while (*p) ifaces.push_back(*p++);
-    p++;
-    // Parse methods
-    FunctionScopePtrVec methods;
-    while (*p) {
-      FunctionScopePtr fs = ParseExtFunction(ar, p, true);
-      if (sep) {
-        fs->setSepExtension();
-      }
-      int flags = (int)(int64_t)(*p++);
-      if (flags & ClassInfo::IsAbstract) {
-        fs->addModifier(T_ABSTRACT);
-      }
-      int vismod = 0;
-      if (flags & ClassInfo::IsProtected) {
-        vismod = T_PROTECTED;
-      } else if (flags & ClassInfo::IsPrivate) {
-        vismod = T_PRIVATE;
-      }
-      fs->addModifier(vismod);
-      if (flags & ClassInfo::IsStatic) {
-        fs->addModifier(T_STATIC);
-      }
-      methods.push_back(fs);
-    }
-    if (cparent && *cparent && (ifaces.empty() || ifaces[0] != cparent)) {
-      ifaces.insert(ifaces.begin(), cparent);
-    }
-    ClassScopePtr cl(new ClassScope(ar, cname, cparent, ifaces, methods));
-    for (uint i = 0; i < methods.size(); ++i) {
-      methods[i]->setOuterScope(cl);
-    }
-    p++;
-    // Parse properties
-    while (*p) {
-      int flags = (int)(int64_t)(*p++);
-      ModifierExpressionPtr modifiers(
-        new ModifierExpression(BlockScopePtr(), LocationPtr()));
-      if (flags & ClassInfo::IsProtected) {
-        modifiers->add(T_PROTECTED);
-      } else if (flags & ClassInfo::IsPrivate) {
-        modifiers->add(T_PRIVATE);
-      }
-      if (flags & ClassInfo::IsStatic) {
-        modifiers->add(T_STATIC);
-      }
-      const char *name = *p++;
-      TypePtr type = ParseType(p);
-      cl->getVariables()->add(name, type, false, ar, ExpressionPtr(), modifiers);
-    }
-    p++;
-    // Parse consts
-    while (*p) {
-      const char *name = *p++;
-      TypePtr type = ParseType(p);
-      cl->getConstants()->add(name, type, ExpressionPtr(), ar, ConstructPtr());
-    }
-    p++;
-
-    int flags = (int)(int64_t)(*p++);
-    cl->setClassInfoAttribute(flags);
-    if (flags & ClassInfo::HasDocComment) {
-      cl->setDocComment(*p++);
-    }
-
-    cl->setSystem();
-    if (sep) {
-      cl->setSepExtension();
-    }
-    s_classes[cl->getName()] = cl;
-  }
-}
-
-FunctionScopePtr BuiltinSymbols::ParseExtFunction(AnalysisResultPtr ar,
-    const char** &p, bool method /* = false */) {
-  const char *name = *p++;
-  TypePtr retType = ParseType(p);
-  bool reference = *p++;
-
-  int minParam = -1;
-  int maxParam = 0;
-  const char **arg = p;
-  while (*arg) {
-    /* name */ arg++;
-    ParseType(arg);
-    const char *argDefault = *arg++;
-    /* const char *argDefaultLen = */ arg++;
-    /* const char *argDefaultText = */ arg++;
-    /* bool argReference = */ arg++;
-    if (argDefault && minParam < 0) {
-      minParam = maxParam;
-    }
-    maxParam++;
-  }
-  if (minParam < 0) minParam = maxParam;
-
-  FunctionScopePtr f(new FunctionScope(method, name, reference));
-  f->setParamCounts(ar, minParam, maxParam);
-  if (retType) {
-    f->setReturnType(ar, retType);
+  if (method->returnType != KindOfNull) {
+    f->setReturnType(ar, typePtrFromDataType(method->returnType,
+                                             Type::Variant));
   }
 
-  int index = 0;
-  const char *paramName = nullptr;
-  while ((paramName = *p++ /* argName */)) {
-    TypePtr argType = ParseType(p);
-    const char *argDefault = *p++;
-    const char *argDefaultLen = *p++;
-    const char *argDefaultText = *p++;
-    bool argReference = *p++;
+  f->setClassInfoAttribute(attrs);
+  f->setDocComment(method->docComment);
 
-    f->setParamName(index, paramName);
-    if (argReference) f->setRefParam(index);
-    f->setParamType(ar, index, argType);
-    if (argDefault) f->setParamDefault(index, argDefault,
-                                       (int64_t)argDefaultLen,
-                                       argDefaultText);
-
-    index++;
+  if (!isMethod && (attrs & ClassInfo::HasOptFunction)) {
+    // Legacy optimization functions
+    if (method->name.same(s_fb_call_user_func_safe) ||
+        method->name.same(s_fb_call_user_func_safe_return) ||
+        method->name.same(s_fb_call_user_func_array_safe)) {
+      f->setOptFunction(hphp_opt_fb_call_user_func);
+    } else if (method->name.same(s_is_callable)) {
+      f->setOptFunction(hphp_opt_is_callable);
+    } else if (method->name.same(s_call_user_func_array)) {
+      f->setOptFunction(hphp_opt_call_user_func);
+    }
   }
 
-  int flags = (int)(int64_t)(*p++);
-  f->setClassInfoAttribute(flags);
-  if (flags & ClassInfo::HasDocComment) {
-    f->setDocComment(*p++);
-  }
-  if (flags & ClassInfo::HasOptFunction) {
-    f->setOptFunction((FunctionOptPtr)(*p++));
+  if (isMethod) {
+    if (attrs & ClassInfo::IsProtected) {
+      f->addModifier(T_PROTECTED);
+    } else if (attrs & ClassInfo::IsPrivate) {
+      f->addModifier(T_PRIVATE);
+    }
+    if (attrs & ClassInfo::IsStatic) {
+      f->addModifier(T_STATIC);
+    }
   }
 
   // This block of code is not needed, if BlockScope directly takes flags.
-  if (flags & ClassInfo::MixedVariableArguments) {
+  if (attrs & ClassInfo::MixedVariableArguments) {
     f->setVariableArgument(-1);
-  } else if (flags & ClassInfo::RefVariableArguments) {
+  } else if (attrs & ClassInfo::RefVariableArguments) {
     f->setVariableArgument(1);
-  } else if (flags & ClassInfo::VariableArguments) {
+  } else if (attrs & ClassInfo::VariableArguments) {
     f->setVariableArgument(0);
   }
-  if (flags & ClassInfo::NoEffect) {
+  if (attrs & ClassInfo::NoEffect) {
     f->setNoEffect();
   }
-  if (flags & ClassInfo::FunctionIsFoldable) {
+  if (attrs & ClassInfo::FunctionIsFoldable) {
     f->setIsFoldable();
   }
-  if (flags & ClassInfo::ContextSensitive) {
+  if (attrs & ClassInfo::ContextSensitive) {
     f->setContextSensitive(true);
   }
-  if (flags & ClassInfo::NeedsActRec) {
+  if (attrs & ClassInfo::NeedsActRec) {
     f->setNeedsActRec();
   }
-  if ((flags & ClassInfo::IgnoreRedefinition) && !method) {
-    f->setIgnoreRedefinition();
+  if ((attrs & ClassInfo::AllowOverride) && !isMethod) {
+    f->setAllowOverride();
   }
+
+  FunctionScope::RecordFunctionInfo(f->getName(), f);
   return f;
 }
 
-FunctionScopePtr BuiltinSymbols::ParseHelperFunction(AnalysisResultPtr ar,
-                                                     const char** &p) {
-  FunctionScopePtr f = ParseExtFunction(ar, p);
-  f->setHelperFunction();
-  return f;
-}
-
-bool BuiltinSymbols::LoadSepExtensionSymbols(AnalysisResultPtr ar,
-                                             const std::string &name,
-                                             const std::string &soname) {
-  string mapname = name + "_map";
-
-  const char ***symbols = nullptr;
-
-  // If we linked with .a, the symbol is already in main program.
-  if (s_handle_main == nullptr) {
-    s_handle_main = dlopen(nullptr, RTLD_NOW | RTLD_GLOBAL);
-    if (!s_handle_main) {
-      const char *error = dlerror();
-      Logger::Error("Unable to load main program's symbols: %s",
-                    error ? error : "(unknown)");
+void BuiltinSymbols::ImportExtFunctions(AnalysisResultPtr ar,
+                                        ClassInfo *cls) {
+  const ClassInfo::MethodVec &methods = cls->getMethodsVec();
+  for (auto it = methods.begin(); it != methods.end(); ++it) {
+    if (((*it)->attribute & ClassInfo::ZendCompat) &&
+        !Option::EnableZendCompat) {
+      continue;
     }
-  }
-  if (s_handle_main) {
-    symbols = (const char ***)dlsym(s_handle_main, mapname.c_str());
-  }
 
-  // Otherwise, look for .so to load it.
-  void *handle = nullptr;
-  if (!symbols) {
-    handle = dlopen(soname.c_str(), RTLD_NOW | RTLD_GLOBAL);
-    if (!handle) {
-      const char *error = dlerror();
-      Logger::Error("Unable to load %s: %s", soname.c_str(),
-                    error ? error : "(unknown)");
-      return false;
-    }
-    symbols = (const char ***)dlsym(handle, mapname.c_str());
-    if (!symbols) {
-      Logger::Error("Unable to find %s in %s", mapname.c_str(),
-                    soname.c_str());
-      dlclose(handle);
-      return false;
-    }
-  }
-
-  ParseExtFunctions(ar, symbols[0], true);
-  ParseExtConsts   (ar, symbols[1], true);
-  ParseExtClasses  (ar, symbols[2], true);
-
-  if (handle) {
-    /*
-      Not closing for now, because it may have set an object allocator,
-      which would then fail next time its used.
-      I think the object allocators should be fixed instead - one per size,
-      rather than one per class, then this issue wouldnt occur
-    */
-    // dlclose(handle);
-  }
-  return true;
-}
-
-void BuiltinSymbols::Parse(AnalysisResultPtr ar,
-                           const std::string& phpBaseName,
-                           const std::string& phpFileName) {
-  const char *baseName = s_strings.add(phpBaseName.c_str());
-  const char *fileName = s_strings.add(phpFileName.c_str());
-  try {
-    Scanner scanner(fileName, Option::ScannerType);
-    Compiler::Parser parser(scanner, baseName, ar);
-    if (!parser.parse()) {
-      Logger::Error("Unable to parse file %s: %s", fileName,
-                    parser.getMessage().c_str());
-      assert(false);
-    }
-  } catch (FileOpenException &e) {
-    Logger::Error("%s", e.getMessage().c_str());
+    FunctionScopePtr f = ImportFunctionScopePtr(ar, cls, *it);
+    ar->addSystemFunction(f);
   }
 }
 
-bool BuiltinSymbols::Load(AnalysisResultPtr ar, bool extOnly /* = false */) {
+void BuiltinSymbols::ImportExtMethods(AnalysisResultPtr ar,
+                                      FunctionScopePtrVec &vec,
+                                      ClassInfo *cls) {
+  const ClassInfo::MethodVec &methods = cls->getMethodsVec();
+  for (auto it = methods.begin(); it != methods.end(); ++it) {
+    FunctionScopePtr f = ImportFunctionScopePtr(ar, cls, *it);
+    vec.push_back(f);
+  }
+}
+
+void BuiltinSymbols::ImportExtProperties(AnalysisResultPtr ar,
+                                         VariableTablePtr dest,
+                                         ClassInfo *cls) {
+  ClassInfo::PropertyVec src = cls->getPropertiesVec();
+  for (auto it = src.begin(); it != src.end(); ++it) {
+    ClassInfo::PropertyInfo *pinfo = *it;
+    int attrs = pinfo->attribute;
+    ModifierExpressionPtr modifiers(
+      new ModifierExpression(BlockScopePtr(), LocationPtr()));
+    if (attrs & ClassInfo::IsPrivate) {
+      modifiers->add(T_PRIVATE);
+    } else if (attrs & ClassInfo::IsProtected) {
+      modifiers->add(T_PROTECTED);
+    }
+    if (attrs & ClassInfo::IsStatic) {
+      modifiers->add(T_STATIC);
+    }
+
+    dest->add(pinfo->name.data(),
+              typePtrFromDataType(pinfo->type, Type::Variant),
+              false, ar, ExpressionPtr(), modifiers);
+  }
+}
+
+void BuiltinSymbols::ImportExtConstants(AnalysisResultPtr ar,
+                                        ConstantTablePtr dest,
+                                        ClassInfo *cls) {
+  ClassInfo::ConstantVec src = cls->getConstantsVec();
+  for (auto it = src.begin(); it != src.end(); ++it) {
+    // We make an assumption that if the constant is a callback type
+    // (e.g. STDIN, STDOUT, STDERR) then it will return an Object.
+    // And that if it's deferred (SID, PHP_SAPI, etc.) it'll be a String.
+    ClassInfo::ConstantInfo *cinfo = *it;
+    dest->add(cinfo->name.data(),
+              cinfo->isDeferred() ?
+              (cinfo->isCallback() ? Type::Object : Type::String) :
+              typePtrFromDataType(cinfo->getValue().getType(), Type::Variant),
+              ExpressionPtr(), ar, ConstructPtr());
+  }
+}
+
+ClassScopePtr BuiltinSymbols::ImportClassScopePtr(AnalysisResultPtr ar,
+                                                  ClassInfo *cls) {
+  FunctionScopePtrVec methods;
+  ImportExtMethods(ar, methods, cls);
+
+  ClassInfo::InterfaceVec ifaces = cls->getInterfacesVec();
+  String parent = cls->getParentClass();
+  std::vector<std::string> stdIfaces;
+  if (!parent.empty() && (ifaces.empty() || ifaces[0] != parent)) {
+    stdIfaces.push_back(parent.data());
+  }
+  for (auto it = ifaces.begin(); it != ifaces.end(); ++it) {
+    stdIfaces.push_back(it->data());
+  }
+
+  ClassScopePtr cl(new ClassScope(ar, cls->getName().data(), parent.data(),
+                                  stdIfaces, methods));
+  for (uint i = 0; i < methods.size(); ++i) {
+    methods[i]->setOuterScope(cl);
+  }
+
+  ImportExtProperties(ar, cl->getVariables(), cls);
+  ImportExtConstants(ar, cl->getConstants(), cls);
+  int attrs = cls->getAttribute();
+  cl->setClassInfoAttribute(attrs);
+  cl->setDocComment(cls->getDocComment());
+  cl->setSystem();
+  return cl;
+}
+
+void BuiltinSymbols::ImportExtClasses(AnalysisResultPtr ar) {
+  const ClassInfo::ClassMap &classes = ClassInfo::GetClassesMap();
+  for (auto it = classes.begin(); it != classes.end(); ++it) {
+
+    const ClassInfo *info = it->second;
+    if ((info->getAttribute() & ClassInfo::ZendCompat) &&
+        !Option::EnableZendCompat) {
+      continue;
+    }
+
+    ClassScopePtr cl = ImportClassScopePtr(ar, it->second);
+    ar->addSystemClass(cl);
+  }
+}
+
+bool BuiltinSymbols::Load(AnalysisResultPtr ar) {
   if (Loaded) return true;
   Loaded = true;
 
-  // load extension functions first, so system/classes may call them
-  ParseExtFunctions(ar, ExtensionFunctions, false);
-  AnalysisResultPtr ar2 = AnalysisResultPtr(new AnalysisResult());
-  s_variables = VariableTablePtr(new VariableTable(*ar2.get()));
-  s_constants = ConstantTablePtr(new ConstantTable(*ar2.get()));
+  if (g_context.isNull()) init_thread_locals();
+  ClassInfo::Load();
 
-  // parse all PHP files under system/classes
-  if (!extOnly) {
-    ar = AnalysisResultPtr(new AnalysisResult());
-    ar->loadBuiltinFunctions();
-    string slib = systemlib_path();
-    if (slib.empty()) {
-      for (const char **cls = SystemClasses; *cls; cls++) {
-        string phpBaseName = "/system/classes/";
-        phpBaseName += *cls;
-        phpBaseName += ".php";
-        Parse(ar, phpBaseName, Option::GetSystemRoot() + phpBaseName);
-      }
-    } else {
-      Parse(ar, slib, slib);
-    }
-    ar->analyzeProgram(true);
-    ar->inferTypes();
-    const StringToFileScopePtrMap &files = ar->getAllFiles();
-    for (StringToFileScopePtrMap::const_iterator iterFile = files.begin();
-         iterFile != files.end(); iterFile++) {
-      const StringToClassScopePtrVecMap &classes =
-        iterFile->second->getClasses();
-      for (StringToClassScopePtrVecMap::const_iterator iter = classes.begin();
-           iter != classes.end(); ++iter) {
-        assert(iter->second.size() == 1);
-        iter->second[0]->setSystem();
-        assert(!s_classes[iter->first]);
-        s_classes[iter->first] = iter->second[0];
-      }
-    }
-  } else {
-    NoSuperGlobals = true;
-  }
+  // load extension functions first, so system/php may call them
+  ImportExtFunctions(ar, ClassInfo::GetSystem());
 
+  ConstantTablePtr cns = ar->getConstants();
   // load extension constants, classes and dynamics
-  ParseExtConsts(ar, ExtensionConsts, false);
-  ParseExtClasses(ar, ExtensionClasses, false);
-  for (unsigned int i = 0; i < Option::SepExtensions.size(); i++) {
-    Option::SepExtensionOptions &options = Option::SepExtensions[i];
-    string soname = options.soname;
-    if (soname.empty()) {
-      soname = string("lib") + options.name + ".so";
-    }
-    if (!options.lib_path.empty()) {
-      soname = options.lib_path + "/" + soname;
-    }
-    if (!LoadSepExtensionSymbols(ar, options.name, soname)) {
-      return false;
-    }
+  ImportExtConstants(ar, cns, ClassInfo::GetSystem());
+  ImportExtClasses(ar);
+
+  Array constants = ClassInfo::GetSystemConstants();
+  LocationPtr loc(new Location);
+  for (ArrayIter it = constants.begin(); it; ++it) {
+    CVarRef key = it.first();
+    if (!key.isString()) continue;
+    std::string name = key.toCStrRef().data();
+    if (cns->getSymbol(name)) continue;
+    if (name == "true" || name == "false" || name == "null") continue;
+    CVarRef value = it.secondRef();
+    if (!value.isInitialized() || value.isObject()) continue;
+    ExpressionPtr e = Expression::MakeScalarExpression(ar, ar, loc, value);
+    TypePtr t =
+      value.isNull()    ? Type::Null    :
+      value.isBoolean() ? Type::Boolean :
+      value.isInteger() ? Type::Int64   :
+      value.isDouble()  ? Type::Double  :
+      value.isArray()   ? Type::Array   : Type::Variant;
+
+    cns->add(key.toCStrRef().data(), t, e, ar, e);
+  }
+  for (int i = 0, n = NumGlobalNames(); i < n; ++i) {
+    ar->getVariables()->add(GlobalNames[i], Type::Variant, false, ar,
+                            ConstructPtr(), ModifierExpressionPtr());
   }
 
-  if (!extOnly) {
-    Array constants = ClassInfo::GetSystemConstants();
-    LocationPtr loc(new Location);
-    for (ArrayIter it = constants.begin(); it; ++it) {
-      CVarRef key = it.first();
-      if (!key.isString()) continue;
-      std::string name = key.toCStrRef().data();
-      if (s_constants->getSymbol(name)) continue;
-      if (name == "true" || name == "false" || name == "null") continue;
-      CVarRef value = it.secondRef();
-      if (!value.isInitialized() || value.isObject()) continue;
-      ExpressionPtr e = Expression::MakeScalarExpression(ar2, ar2, loc, value);
-      TypePtr t =
-        value.isNull()    ? Type::Null    :
-        value.isBoolean() ? Type::Boolean :
-        value.isInteger() ? Type::Int64   :
-        value.isDouble()  ? Type::Double  :
-        value.isArray()   ? Type::Array   : Type::Variant;
+  cns->setDynamic(ar, "PHP_BINARY", true);
+  cns->setDynamic(ar, "PHP_BINDIR", true);
+  cns->setDynamic(ar, "PHP_OS", true);
+  cns->setDynamic(ar, "PHP_SAPI", true);
+  cns->setDynamic(ar, "SID", true);
 
-      s_constants->add(key.toCStrRef().data(), t, e, ar2, e);
+  // Systemlib files were all parsed by hphp_process_init
+
+  const StringToFileScopePtrMap &files = ar->getAllFiles();
+  for (const auto& file : files) {
+    file.second->setSystem();
+
+    const auto& classes = file.second->getClasses();
+    for (const auto& clsVec : classes) {
+      assert(clsVec.second.size() == 1);
+      auto cls = clsVec.second[0];
+      cls->setSystem();
+      ar->addSystemClass(cls);
+      for (const auto& func : cls->getFunctions()) {
+        FunctionScope::RecordFunctionInfo(func.first, func.second);
+      }
     }
-    s_variables = ar2->getVariables();
-    for (int i = 0, n = NumGlobalNames(); i < n; ++i) {
-      s_variables->add(GlobalNames[i], Type::Variant, false, ar,
-                       ConstructPtr(), ModifierExpressionPtr());
+
+    const auto& functions = file.second->getFunctions();
+    for (const auto& func : functions) {
+      func.second->setSystem();
+      ar->addSystemFunction(func.second);
+      FunctionScope::RecordFunctionInfo(func.first, func.second);
     }
   }
-  s_constants->setDynamic(ar, "SID", true);
 
   return true;
 }
 
-AnalysisResultPtr BuiltinSymbols::LoadGlobalSymbols(const char *fileName) {
-  AnalysisResultPtr ar(new AnalysisResult());
-  string phpBaseName = "/system/globals/";
-  phpBaseName += fileName;
-  string phpFileName = Option::GetSystemRoot() + phpBaseName;
-  const char *baseName = s_strings.add(phpBaseName.c_str());
-  fileName = s_strings.add(phpFileName.c_str());
-
-  try {
-    Scanner scanner(fileName, Option::ScannerType);
-    Compiler::Parser parser(scanner, baseName, ar);
-    if (!parser.parse()) {
-      assert(false);
-      Logger::Error("Unable to parse file %s: %s", fileName,
-                    parser.getMessage().c_str());
-    }
-  } catch (FileOpenException &e) {
-    Logger::Error("%s", e.getMessage().c_str());
-  }
-  ar->analyzeProgram(true);
-  ar->inferTypes();
-  return ar;
-}
-
-void BuiltinSymbols::LoadFunctions(AnalysisResultPtr ar,
-                                   StringToFunctionScopePtrMap &functions) {
-  assert(Loaded);
-  for (StringToFunctionScopePtrMap::const_iterator it = s_functions.begin();
-       it != s_functions.end(); ++it) {
-    if (functions.find(it->first) == functions.end()) {
-      functions[it->first] = it->second;
-      FunctionScope::RecordFunctionInfo(it->first, it->second);
-    }
-  }
-}
-
-void BuiltinSymbols::LoadClasses(AnalysisResultPtr ar,
-                                 StringToClassScopePtrMap &classes) {
-  assert(Loaded);
-  classes.insert(s_classes.begin(), s_classes.end());
-
-  // we are adding these builtin functions, so that user-defined functions
-  // will not overwrite them with their own file and line number information
-  for (StringToClassScopePtrMap::const_iterator iter =
-         s_classes.begin(); iter != s_classes.end(); ++iter) {
-    const StringToFunctionScopePtrMap &funcs = iter->second->getFunctions();
-    for (StringToFunctionScopePtrMap::const_iterator iter =
-           funcs.begin(); iter != funcs.end(); ++iter) {
-      FunctionScope::RecordFunctionInfo(iter->first, iter->second);
-    }
-  }
-}
-
-void BuiltinSymbols::LoadVariables(AnalysisResultPtr ar,
-                                   VariableTablePtr variables) {
-  assert(Loaded);
-  if (s_variables) {
-    variables->import(s_variables);
-  }
-}
-
-void BuiltinSymbols::LoadConstants(AnalysisResultPtr ar,
-                                   ConstantTablePtr constants) {
-  assert(Loaded);
-  if (s_constants) {
-    constants->import(s_constants);
-  }
-}
-
-ConstantTablePtr BuiltinSymbols::LoadSystemConstants() {
-  AnalysisResultPtr ar = LoadGlobalSymbols("constants.php");
-  const auto &fileScopes = ar->getAllFilesVector();
-  if (!fileScopes.empty()) {
-    return fileScopes[0]->getConstants();
-  }
-  throw std::runtime_error("LoadSystemConstants failed");
-}
-
 void BuiltinSymbols::LoadSuperGlobals() {
   if (s_superGlobals.empty()) {
     s_superGlobals["_SERVER"] = Type::Variant;
@@ -596,7 +410,6 @@ void BuiltinSymbols::LoadSuperGlobals() {
 }
 
 bool BuiltinSymbols::IsSuperGlobal(const std::string &name) {
-  if (NoSuperGlobals) return false;
   return s_superGlobals.find(name) != s_superGlobals.end();
 }
 

hphp/compiler/builtin_symbols.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,28 +14,29 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __BUILTIN_SYMBOLS_H__
-#define __BUILTIN_SYMBOLS_H__
+#ifndef incl_HPHP_BUILTIN_SYMBOLS_H_
+#define incl_HPHP_BUILTIN_SYMBOLS_H_
 
-#include <compiler/hphp.h>
-#include <util/string_bag.h>
+#include "hphp/compiler/hphp.h"
+#include "hphp/util/string-bag.h"
+#include "hphp/runtime/base/class-info.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
 
-DECLARE_BOOST_TYPES(Type);
+DECLARE_EXTENDED_BOOST_TYPES(Type);
 DECLARE_BOOST_TYPES(AnalysisResult);
-DECLARE_BOOST_TYPES(FunctionScope);
-DECLARE_BOOST_TYPES(ClassScope);
+DECLARE_EXTENDED_BOOST_TYPES(FunctionScope);
+DECLARE_EXTENDED_BOOST_TYPES(ClassScope);
 DECLARE_BOOST_TYPES(VariableTable);
 DECLARE_BOOST_TYPES(ConstantTable);
 
 class BuiltinSymbols {
 public:
   static bool Loaded;
-  static bool NoSuperGlobals; // for SystemCPP bootstraping only
+  static AnalysisResultPtr s_systemAr;
 
-  static bool Load(AnalysisResultPtr ar, bool extOnly = false);
+  static bool Load(AnalysisResultPtr ar);
 
   static void LoadFunctions(AnalysisResultPtr ar,
                             StringToFunctionScopePtrMap &functions);
@@ -46,11 +47,6 @@ public:
   static void LoadConstants(AnalysisResultPtr ar,
                             ConstantTablePtr constants);
 
-  /*
-   * Load system/globals/constants.php.
-   */
-  static ConstantTablePtr LoadSystemConstants();
-
   /**
    * Testing whether a variable is a PHP superglobal.
    */
@@ -60,48 +56,35 @@ public:
   static bool IsDeclaredDynamic(const std::string& name);
   static void LoadSuperGlobals();
 
-  static StringToFunctionScopePtrMap s_functions;
-  static StringToClassScopePtrMap s_classes;
-  static VariableTablePtr s_variables;
-  static ConstantTablePtr s_constants;
-
   static const char *const GlobalNames[];
   static int NumGlobalNames();
 private:
   static StringBag s_strings;
-  static const char *ExtensionFunctions[];
-  static const char *ExtensionClasses[];
-  static const char *ExtensionConsts[];
-  static const char *ExtensionDeclaredDynamic[];
   static const char *SystemClasses[];
 
-  static AnalysisResultPtr LoadGlobalSymbols(const char *fileName);
-  static void Parse(AnalysisResultPtr ar,
-                    const std::string& phpBaseName,
-                    const std::string& phpFileName);
-
   static StringToTypePtrMap s_superGlobals;
 
   static std::set<std::string> s_declaredDynamic;
 
-  static void *s_handle_main;
-  static bool LoadSepExtensionSymbols(AnalysisResultPtr ar,
-                                      const std::string &name,
-                                      const std::string &soname);
-
-  static TypePtr ParseType(const char **&p);
-  static void ParseExtFunctions(AnalysisResultPtr ar, const char **p,
-                                bool sep);
-  static void ParseExtConsts(AnalysisResultPtr ar, const char **p, bool sep);
-  static void ParseExtClasses(AnalysisResultPtr ar, const char **p, bool sep);
-  static void ParseExtDynamics(AnalysisResultPtr ar, const char **p, bool sep);
-
-  static FunctionScopePtr ParseExtFunction(AnalysisResultPtr ar,
-      const char** &p, bool method = false);
-  static FunctionScopePtr ParseHelperFunction(AnalysisResultPtr ar,
-                                              const char** &p);
+  static FunctionScopePtr ImportFunctionScopePtr(AnalysisResultPtr ar,
+                                                 ClassInfo *cls,
+                                                 ClassInfo::MethodInfo *method);
+  static void ImportExtFunctions(AnalysisResultPtr ar,
+                                 ClassInfo *cls);
+  static void ImportExtMethods(AnalysisResultPtr ar,
+                               FunctionScopePtrVec &vec,
+                               ClassInfo *cls);
+  static void ImportExtProperties(AnalysisResultPtr ar,
+                                  VariableTablePtr dest,
+                                  ClassInfo *cls);
+  static void ImportExtConstants(AnalysisResultPtr ar,
+                                 ConstantTablePtr dest,
+                                 ClassInfo *cls);
+  static ClassScopePtr ImportClassScopePtr(AnalysisResultPtr ar,
+                                           ClassInfo *cls);
+  static void ImportExtClasses(AnalysisResultPtr ar);
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __BUILTIN_SYMBOLS_H__
+#endif // incl_HPHP_BUILTIN_SYMBOLS_H_

hphp/compiler/code_generator.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,17 +14,18 @@
    +----------------------------------------------------------------------+
 */
 
-#include <stdarg.h>
-
-#include <compiler/code_generator.h>
-#include <compiler/statement/statement_list.h>
-#include <compiler/option.h>
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/variable_table.h>
-#include <util/util.h>
-#include <util/hash.h>
+#include "hphp/compiler/code_generator.h"
+#include "hphp/compiler/code_model_enums.h"
+#include "hphp/compiler/statement/statement_list.h"
+#include "hphp/compiler/expression/expression_list.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/runtime/base/zend-printf.h"
+#include "hphp/util/util.h"
+#include "hphp/util/hash.h"
 #include <boost/format.hpp>
 #include <boost/scoped_array.hpp>
 
@@ -424,3 +425,171 @@ int CodeGenerator::ClassScopeCompare::cmp(const ClassScopeRawPtr &p1,
   if (d) return d;
   return strcasecmp(p1->getName().c_str(), p2->getName().c_str());
 }
+
+void CodeGenerator::printObjectHeader(const std::string className,
+                                      int numProperties) {
+  std::string prefixedClassName;
+  prefixedClassName.append(m_astPrefix);
+  prefixedClassName.append(className);
+  m_astClassNames.push_back(prefixedClassName);
+  printf("O:%d:\"%s\":%d:{",
+    (int)prefixedClassName.length(), prefixedClassName.c_str(), numProperties);
+}
+
+void CodeGenerator::printObjectFooter() {
+  printf("}");
+  m_astClassNames.pop_back();
+}
+
+void CodeGenerator::printPropertyHeader(const std::string propertyName) {
+  auto prefixedClassName = m_astClassNames.back();
+  auto len = 2+prefixedClassName.length()+propertyName.length();
+  printf("s:%d:\"", (int)len);
+  *m_out << (char)0;
+  printf("%s", prefixedClassName.c_str());
+  *m_out << (char)0;
+  printf("%s\";", propertyName.c_str());
+}
+
+void CodeGenerator::printNull() {
+  printf("N;");
+}
+
+void CodeGenerator::printBool(bool value) {
+  printf("b:%d;", value ? 1 : 0);
+}
+
+void CodeGenerator::printValue(double v) {
+  *m_out << "d:";
+  if (std::isnan(v)) {
+    *m_out << "NAN";
+  } else if (std::isinf(v)) {
+    if (v < 0) *m_out << '-';
+    *m_out << "INF";
+  } else {
+    char *buf;
+    if (v == 0.0) v = 0.0; // so to avoid "-0" output
+    vspprintf(&buf, 0, "%.*H", 14, v);
+    m_out->write(buf, strlen(buf));
+    free(buf);
+  }
+  *m_out << ';';
+}
+
+void CodeGenerator::printValue(int32_t value) {
+  printf("i:%d;", value);
+}
+
+void CodeGenerator::printValue(int64_t value) {
+  printf("i:%" PRId64 ";", value);
+}
+
+void CodeGenerator::printValue(std::string value) {
+  printf("s:%d:\"", (int)value.length());
+  getStream()->write(value.c_str(), value.length());
+  printf("\";");
+}
+
+void CodeGenerator::printModifierVector(std::string value) {
+  printf("V:9:\"HH\\Vector\":1:{");
+  printObjectHeader("Modifier", 1);
+  printPropertyHeader("name");
+  printValue(value);
+  printObjectFooter();
+  printf("}");
+}
+
+void CodeGenerator::printTypeExpression(std::string value) {
+  printObjectHeader("TypeExpression", 1);
+  printPropertyHeader("name");
+  printValue(value);
+  printObjectFooter();
+}
+
+void CodeGenerator::printExpression(ExpressionPtr expression, bool isRef) {
+  if (isRef) {
+    printObjectHeader("UnaryOpExpression", 3);
+    printPropertyHeader("expression");
+    expression->outputCodeModel(*this);
+    printPropertyHeader("operation");
+    printValue(PHP_REFERENCE_OP);
+    printPropertyHeader("sourceLocation");
+    printLocation(expression->getLocation());
+    printObjectFooter();
+  } else {
+    expression->outputCodeModel(*this);
+  }
+}
+
+void CodeGenerator::printExpressionVector(ExpressionListPtr el) {
+  auto count = el == nullptr ? 0 : el->getCount();
+  printf("V:9:\"HH\\Vector\":%d:{", count);
+  if (count > 0) {
+    el->outputCodeModel(*this);
+  }
+  printf("}");
+}
+
+void CodeGenerator::printExpressionVector(ExpressionPtr e) {
+  if (e->is(Expression::KindOfExpressionList)) {
+    auto sl = static_pointer_cast<ExpressionList>(e);
+    printExpressionVector(sl);
+  } else {
+    printf("V:9:\"HH\\Vector\":1:{");
+    e->outputCodeModel(*this);
+    printf("}");
+  }
+}
+
+void CodeGenerator::printAsBlock(StatementPtr s) {
+  if (s != nullptr && s->is(Statement::KindOfBlockStatement)) {
+    s->outputCodeModel(*this);
+  } else {
+    auto numProps = s == nullptr ? 1 : 2;
+    printObjectHeader("BlockStatement", numProps);
+    printPropertyHeader("statements");
+    printStatementVector(s);
+    if (s != nullptr) {
+      printPropertyHeader("sourceLocation");
+      printLocation(s->getLocation());
+    }
+    printObjectFooter();
+  }
+}
+
+void CodeGenerator::printStatementVector(StatementListPtr sl) {
+  printf("V:9:\"HH\\Vector\":%d:{", sl->getCount());
+  if (sl->getCount() > 0) {
+    sl->outputCodeModel(*this);
+  }
+  printf("}");
+}
+
+void CodeGenerator::printStatementVector(StatementPtr s) {
+  if (s == nullptr) {
+    printf("V:9:\"HH\\Vector\":0:{}");
+  } else if (s->is(Statement::KindOfStatementList)) {
+    auto sl = static_pointer_cast<StatementList>(s);
+    printStatementVector(sl);
+  } else {
+    printf("V:9:\"HH\\Vector\":1:{");
+    s->outputCodeModel(*this);
+    printf("}");
+  }
+}
+
+void CodeGenerator::printLocation(LocationPtr location) {
+  if (location == nullptr) return;
+  printObjectHeader("SourceLocation", 4);
+  printPropertyHeader("startLine");
+  printValue(location->line0);
+  printPropertyHeader("endLine");
+  printValue(location->line1);
+  printPropertyHeader("startColumn");
+  printValue(location->char0);
+  printPropertyHeader("endColumn");
+  printValue(location->char1);
+  printObjectFooter();
+}
+
+

hphp/compiler/code_generator.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,22 +14,26 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __CODE_GENERATOR_H__
-#define __CODE_GENERATOR_H__
+#ifndef incl_HPHP_CODE_GENERATOR_H_
+#define incl_HPHP_CODE_GENERATOR_H_
 
-#include <compiler/hphp.h>
+#include "hphp/compiler/hphp.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
 
 DECLARE_BOOST_TYPES(AnalysisResult);
 DECLARE_BOOST_TYPES(Statement);
+DECLARE_BOOST_TYPES(StatementList);
 DECLARE_BOOST_TYPES(Construct);
 DECLARE_BOOST_TYPES(BlockScope);
-DECLARE_BOOST_TYPES(ClassScope);
+DECLARE_EXTENDED_BOOST_TYPES(ClassScope);
 DECLARE_BOOST_TYPES(FunctionScope);
 DECLARE_BOOST_TYPES(FileScope);
 DECLARE_BOOST_TYPES(LoopStatement);
+DECLARE_BOOST_TYPES(Location);
+DECLARE_BOOST_TYPES(Expression);
+DECLARE_BOOST_TYPES(ExpressionList);
 
 class CodeGenerator {
 public:
@@ -45,6 +49,7 @@ public:
     SystemCPP,  // special mode for generating builtin classes
     TextHHBC,   // HHBC dump in human-readable format
     BinaryHHBC, // serialized HHBC
+    CodeModel,  // serialized Code Model classes
   };
 
   enum Stream {
@@ -131,8 +136,8 @@ public:
 
 public:
   CodeGenerator() {} // only for creating a dummy code generator
-  CodeGenerator(std::ostream *primary, Output output = PickledPHP,
-                const std::string *filename = nullptr);
+  explicit CodeGenerator(std::ostream *primary, Output output = PickledPHP,
+                         const std::string *filename = nullptr);
 
   /**
    * ...if it was passed in from constructor.
@@ -265,12 +270,37 @@ public:
   FileScopeRawPtr getLiteralScope() const {
     return m_literalScope;
   }
+
+  /**
+   * Support for printing AST nodes in PHP serialize() format.
+   */
+  void printObjectHeader(const std::string className, int numProperties);
+  void printPropertyHeader(const std::string propertyName);
+  void printObjectFooter();
+  void printNull();
+  void printBool(bool value);
+  void printValue(double value);
+  void printValue(int32_t value);
+  void printValue(int64_t value);
+  void printValue(std::string value);
+  void printModifierVector(std::string value);
+  void printTypeExpression(std::string value);
+  void printExpression(ExpressionPtr expression, bool isRef);
+  void printExpressionVector(ExpressionListPtr el);
+  void printExpressionVector(ExpressionPtr e);
+  void printAsBlock(StatementPtr s);
+  void printStatementVector(StatementListPtr sl);
+  void printStatementVector(StatementPtr s);
+  void printLocation(LocationPtr location);
+  void setAstClassPrefix(const std::string &prefix) { m_astPrefix = prefix; }
 private:
   std::string m_filename;
   Stream m_curStream;
   std::ostream *m_streams[StreamCount];
   std::ostream *m_out;
   Output m_output;
+  std::string m_astPrefix;
+  std::vector<std::string> m_astClassNames;
   bool m_verbose;
 
   int m_indentation[StreamCount];
@@ -308,28 +338,23 @@ private:
   public: void print(const char *msg, bool indent = true);
 
  private:
-  void print(const char *fmt, va_list ap);
+  void print(const char *fmt, va_list ap) ATTRIBUTE_PRINTF(2,0);
   void printSubstring(const char *start, int length);
   void printIndent();
   std::string getFormattedName(const std::string &file);
 };
 
-#define STR(x) #x
-#define XSTR(x) STR(x)
-#define FLANN(stream,func,nl) (Option::FlAnnotate ?                           \
-               stream.printf("/* %s:" XSTR(__LINE__) "*/" nl, __func__):       \
-               void()), stream.func
-#define cg_printf FLANN(cg,printf,"")
-#define m_cg_printf FLANN(m_cg,printf,"")
-#define cg_print FLANN(cg,print,"")
-#define m_cg_print FLANN(m_cg,print,"")
-#define cg_indentBegin FLANN(cg,indentBegin,"")
-#define m_cg_indentBegin FLANN(m_cg,indentBegin,"")
-#define cg_indentEnd FLANN(cg,indentEnd,"")
-#define m_cg_indentEnd FLANN(m_cg,indentEnd,"")
-#define cg_printInclude FLANN(cg,printInclude,"\n")
-#define cg_printString FLANN(cg,printString,"")
+#define cg_printf cg.printf
+#define m_cg_printf m_cg.printf
+#define cg_print cg.print
+#define m_cg_print m_cg.print
+#define cg_indentBegin cg.indentBegin
+#define m_cg_indentBegin m_cg.indentBegin
+#define cg_indentEnd cg.indentEnd
+#define m_cg_indentEnd cg.indentEnd
+#define cg_printInclude cg.printInclude
+#define cg_printString cg.printString
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __CODE_GENERATOR_H__
+#endif // incl_HPHP_CODE_GENERATOR_H_

hphp/compiler/code_model_enums.h

@@ -0,0 +1,117 @@
+/*
+   +----------------------------------------------------------------------+
+   | HipHop for PHP                                                       |
+   +----------------------------------------------------------------------+
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
+   +----------------------------------------------------------------------+
+   | This source file is subject to version 3.01 of the PHP license,      |
+   | that is bundled with this package in the file LICENSE, and is        |
+   | available through the world-wide-web at the following url:           |
+   | http://www.php.net/license/3_01.txt                                  |
+   | If you did not receive a copy of the PHP license and are unable to   |
+   | obtain it through the world-wide-web, please send a note to          |
+   | license@php.net so we can mail you a copy immediately.               |
+   +----------------------------------------------------------------------+
+*/
+// This file is @generated by tools/code-model/GenerateEnums.sh
+
+#ifndef incl_HPHP_CODE_MODEL_ENUMS_H_
+#define incl_HPHP_CODE_MODEL_ENUMS_H_
+
+namespace HPHP {
+  /** The kinds of operations that IBinaryOpExpressions can perform. */
+  enum CodeModelBinaryOperator {
+    PHP_AND_ASSIGN = 1,
+    PHP_AND = 2,
+    PHP_ARRAY_ELEMENT = 3,
+    PHP_ARRAY_PAIR = 4,
+    PHP_ASSIGNMENT = 5,
+    PHP_BOOLEAN_AND = 6,
+    PHP_BOOLEAN_OR = 7,
+    PHP_CAST = 8,
+    PHP_CONCAT_ASSIGN = 9,
+    PHP_CONCAT = 10,
+    PHP_DIVIDE_ASSIGN = 11,
+    PHP_DIVIDE = 12,
+    PHP_INSTANCEOF = 13,
+    PHP_IS_EQUAL = 14,
+    PHP_IS_GREATER = 15,
+    PHP_IS_GREATER_OR_EQUAL = 16,
+    PHP_IS_IDENTICAL = 17,
+    PHP_IS_NOT_IDENTICAL = 18,
+    PHP_IS_NOT_EQUAL = 19,
+    PHP_IS_SMALLER = 20,
+    PHP_IS_SMALLER_OR_EQUAL = 21,
+    PHP_LOGICAL_AND = 22,
+    PHP_LOGICAL_OR = 23,
+    PHP_LOGICAL_XOR = 24,
+    PHP_MINUS_ASSIGN = 25,
+    PHP_MINUS = 26,
+    PHP_MODULUS_ASSIGN = 27,
+    PHP_MODULUS = 28,
+    PHP_MULTIPLY_ASSIGN = 29,
+    PHP_MULTIPLY = 30,
+    PHP_OR_ASSIGN = 31,
+    PHP_OR = 32,
+    PHP_PLUS_ASSIGN = 33,
+    PHP_PLUS = 34,
+    PHP_SHIFT_LEFT_ASSIGN = 35,
+    PHP_SHIFT_LEFT = 36,
+    PHP_SHIFT_RIGHT_ASSIGN = 37,
+    PHP_SHIFT_RIGHT = 38,
+    PHP_XOR_ASSIGN = 39,
+    PHP_XOR = 40,
+  };
+
+  /** The kinds of operations that IUnaryOpExpressions can perform. */
+  enum CodeModelUnaryOperator {
+    PHP_ARRAY_CAST_OP = 1,
+    PHP_ARRAY_APPEND_POINT_OP = 2,
+    PHP_AWAIT_OP = 3,
+    PHP_BOOL_CAST_OP = 4,
+    PHP_BITWISE_NOT_OP = 5,
+    PHP_CLONE_OP = 6,
+    PHP_DYNAMIC_VARIABLE_OP = 7,
+    PHP_ERROR_CONTROL_OP = 8,
+    PHP_FLOAT_CAST_OP = 9,
+    PHP_INCLUDE_OP = 10,
+    PHP_INCLUDE_ONCE_OP = 11,
+    PHP_INT_CAST_OP = 12,
+    PHP_MINUS_OP = 13,
+    PHP_NOT_OP = 14,
+    PHP_OBJECT_CAST_OP = 15,
+    PHP_PLUS_OP = 16,
+    PHP_POST_DECREMENT_OP = 17,
+    PHP_POST_INCREMENT_OP = 18,
+    PHP_PRE_DECREMENT_OP = 19,
+    PHP_PRE_INCREMENT_OP = 20,
+    PHP_PRINT_OP = 21,
+    PHP_REFERENCE_OP = 22,
+    PHP_REQUIRE_OP = 23,
+    PHP_REQUIRE_ONCE_OP = 24,
+    PHP_STRING_CAST_OP = 25,
+    PHP_UNSET_CAST_OP = 26,
+  };
+
+  /** Enumerates the kinds of trait require statements. */
+  enum CodeModelRequireKind {
+    PHP_EXTENDS = 1,
+    PHP_IMPLEMENTS = 2,
+  };
+
+  /** Enumerates the kinds of type declaration statements. */
+  enum CodeModelTypeKind {
+    PHP_CLASS = 1,
+    PHP_INTERFACE = 2,
+    PHP_TRAIT = 3,
+  };
+
+  /** The sort order to use when grouping query results */
+  enum CodeModelOrder {
+    PHP_NOT_SPECIFIED = 1,
+    PHP_ASCENDING = 2,
+    PHP_DESCENDING = 3,
+  };
+
+}
+#endif // incl_HPHP_CODE_MODEL_ENUMS_H_

hphp/compiler/compiler.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,43 +14,45 @@
    +----------------------------------------------------------------------+
 */
 
+#include "hphp/compiler/compiler.h"
+#include "hphp/compiler/package.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/alias_manager.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/emitter.h"
+#include "hphp/compiler/analysis/type.h"
+#include "hphp/compiler/analysis/symbol_table.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/compiler/builtin_symbols.h"
+#include "hphp/compiler/json.h"
+#include "hphp/util/logger.h"
+#include "hphp/util/db-conn.h"
+#include "hphp/util/exception.h"
+#include "hphp/util/process.h"
+#include "hphp/util/util.h"
+#include "hphp/util/timer.h"
+#include "hphp/util/hdf.h"
+#include "hphp/util/async-func.h"
+#include "hphp/util/current-executable.h"
+#include "hphp/runtime/base/program-functions.h"
+#include "hphp/runtime/base/externals.h"
+#include "hphp/runtime/base/thread-init-fini.h"
+#include "hphp/runtime/vm/repo.h"
+#include "hphp/system/systemlib.h"
+#include "hphp/util/repo-schema.h"
+
+#include "hphp/hhvm/process-init.h"
+
+#include <sys/types.h>
+#include <sys/wait.h>
+#include <dlfcn.h>
+
 #include <boost/program_options/options_description.hpp>
 #include <boost/program_options/positional_options.hpp>
 #include <boost/program_options/variables_map.hpp>
 #include <boost/program_options/parsers.hpp>
 
-#include <compiler/package.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/alias_manager.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/emitter.h>
-#include <compiler/analysis/type.h>
-#include <util/json.h>
-#include <util/logger.h>
-#include <compiler/analysis/symbol_table.h>
-#include <compiler/option.h>
-#include <compiler/parser/parser.h>
-#include <compiler/builtin_symbols.h>
-#include <util/db_conn.h>
-#include <util/exception.h>
-#include <util/process.h>
-#include <util/util.h>
-#include <util/timer.h>
-#include <util/hdf.h>
-#include <util/async_func.h>
-#include <runtime/base/program_functions.h>
-#include <runtime/base/memory/smart_allocator.h>
-#include <runtime/base/externals.h>
-#include <runtime/base/thread_init_fini.h>
-#include <runtime/vm/repo.h>
-#include <sys/types.h>
-#include <sys/wait.h>
-#include <dlfcn.h>
-#include <system/lib/systemlib.h>
-#include <compiler/compiler.h>
-
-#include "hhvm/process_init.h"
-
 using namespace boost::program_options;
 using std::cout;
 
@@ -61,7 +63,6 @@ struct CompilerOptions {
   string target;
   string format;
   string outputDir;
-  string outputFile;
   string syncDir;
   vector<string> config;
   string configDir;
@@ -82,8 +83,6 @@ struct CompilerOptions {
   vector<string> cfiles;
   vector<string> cmodules;
   bool parseOnDemand;
-  vector<string> parseOnDemandDirs; // parse these directories on-demand
-                                    // when parseOnDemand=false
   string program;
   string programArgs;
   string branch;
@@ -92,21 +91,15 @@ struct CompilerOptions {
   bool keepTempDir;
   string dbStats;
   bool noTypeInference;
-  bool noMinInclude;
-  bool noMetaInfo;
   int logLevel;
   bool force;
-  int clusterCount;
   int optimizeLevel;
   string filecache;
-  string javaRoot;
   bool dump;
   string docjson;
   bool coredump;
   bool nofork;
-  bool fl_annotate;
   string optimizations;
-  string ppp;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -124,7 +117,8 @@ public:
 
     struct stat sb;
     stat(m_name, &sb);
-    Logger::Info("%dMB %s saved", (int64_t)sb.st_size/(1024*1024), m_name);
+    Logger::Info("%" PRId64" MB %s saved",
+                 (int64_t)sb.st_size/(1024*1024), m_name);
   }
 
 private:
@@ -146,7 +140,6 @@ int hhbcTarget(const CompilerOptions &po, AnalysisResultPtr ar,
                AsyncFileCacheSaver &fcThread);
 int runTargetCheck(const CompilerOptions &po, AnalysisResultPtr ar,
                    AsyncFileCacheSaver &fcThread);
-int buildTarget(const CompilerOptions &po);
 int runTarget(const CompilerOptions &po);
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -157,6 +150,10 @@ int compiler_main(int argc, char **argv) {
   try {
     Hdf empty;
     RuntimeOption::Load(empty);
+    initialize_repo();
+
+    // we need to initialize pcre cache table very early
+    pcre_init();
 
     CompilerOptions po;
 #ifdef FACEBOOK
@@ -195,6 +192,10 @@ int compiler_main(int argc, char **argv) {
     return ret;
   } catch (Exception &e) {
     Logger::Error("Exception: %s\n", e.getMessage().c_str());
+  } catch (const FailedAssertion& fa) {
+    fa.print();
+    StackTraceNoHeap::AddExtraLogging("Assertion failure", fa.summary);
+    abort();
   } catch (std::exception &e) {
     Logger::Error("std::exception: %s\n", e.what());
   } catch (...) {
@@ -226,9 +227,6 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
      " <any combination of them by any separator>; \n"
      "hhbc: binary (default) | text; \n"
      "run: cluster (default) | file")
-    ("cluster-count", value<int>(&po.clusterCount)->default_value(0),
-     "Cluster by file sizes and output roughly these many number of files. "
-     "Use 0 for no clustering.")
     ("input-dir", value<string>(&po.inputDir), "input directory")
     ("program", value<string>(&po.program)->default_value("program"),
      "final program name to use")
@@ -275,7 +273,6 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
     ("branch", value<string>(&po.branch), "SVN branch")
     ("revision", value<int>(&po.revision), "SVN revision")
     ("output-dir,o", value<string>(&po.outputDir), "output directory")
-    ("output-file", value<string>(&po.outputFile), "output file")
     ("sync-dir", value<string>(&po.syncDir),
      "Files will be created in this directory first, then sync with output "
      "directory without overwriting identical files. Great for incremental "
@@ -292,13 +289,6 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
     ("no-type-inference",
      value<bool>(&po.noTypeInference)->default_value(false),
      "turn off type inference for C++ code generation")
-    ("no-min-include",
-     value<bool>(&po.noMinInclude)->default_value(false),
-     "turn off minimium include analysis when target is \"analyze\"")
-    ("no-meta-info",
-     value<bool>(&po.noMetaInfo)->default_value(false),
-     "do not generate class map, function jump table and macros "
-     "when generating code; good for demo purposes")
     ("config,c", value<vector<string> >(&po.config)->composing(),
      "config file name")
     ("config-dir", value<string>(&po.configDir),
@@ -330,22 +320,11 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
      value<bool>(&po.nofork)->default_value(false),
      "forking is needed for large compilation to release memory before g++"
      "compilation. turning off forking can help gdb debugging.")
-    ("fl-annotate",
-     value<bool>(&po.fl_annotate)->default_value(false),
-     "Annotate emitted source with compiler file-line info")
     ("opts",
      value<string>(&po.optimizations)->default_value(""),
      "Set optimizations to enable/disable")
-    ("ppp",
-     value<string>(&po.ppp)->default_value(""),
-     "Preprocessed partition configuration. To speed up distcc compilation, "
-     "bin/ppp.php can pre-compute better partition between different .cpp "
-     "files according to preprocessed file sizes, instead of original file "
-     "sizes (default). Run bin/ppp.php to generate an HDF configuration file "
-     "to specify here.")
     ("compiler-id", "display the git hash for the compiler id")
     ("repo-schema", "display the repo schema id used by this app")
-    ("taint-status", "check if the compiler was built with taint enabled")
     ;
 
   positional_options_description p;
@@ -355,7 +334,7 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
     store(command_line_parser(argc, argv).options(desc).positional(p).run(),
           vm);
     notify(vm);
-  } catch (unknown_option e) {
+  } catch (const unknown_option& e) {
     Logger::Error("Error in command line: %s\n\n", e.what());
     cout << desc << "\n";
     return -1;
@@ -365,8 +344,8 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
     return 1;
   }
   if (vm.count("version")) {
-#ifdef HPHP_VERSION
-#undef HPHP_VERSION
+#ifdef HHVM_VERSION
+#undef HHVM_VERSION
 #endif
 
 #ifdef HPHP_COMPILER_STR
@@ -379,11 +358,11 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
 #define HPHP_COMPILER_STR "HipHop Compiler v"
 #endif
 
-#define HPHP_VERSION(v) cout << HPHP_COMPILER_STR #v << "\n";
-#include "../version"
+#define HHVM_VERSION(v) cout << HPHP_COMPILER_STR #v << "\n";
+#include "../version" // nolint
 
     cout << "Compiler: " << kCompilerId << "\n";
-    cout << "Repo schema: " << VM::Repo::kSchemaId << "\n";
+    cout << "Repo schema: " << kRepoSchemaId << "\n";
     return 1;
   }
 
@@ -393,14 +372,7 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
   }
 
   if (vm.count("repo-schema")) {
-    cout << VM::Repo::kSchemaId << "\n";
-    return 1;
-  }
-
-  if (vm.count("taint-status")) {
-#ifdef TAINTED
-    cout << TAINTED << "\n";
-#endif
+    cout << kRepoSchemaId << "\n";
     return 1;
   }
 
@@ -420,8 +392,6 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
     Logger::LogLevel = Logger::LogInfo;
   }
 
-  Option::FlAnnotate = po.fl_annotate;
-
   Hdf config;
   for (vector<string>::const_iterator it = po.config.begin();
        it != po.config.end(); ++it) {
@@ -474,12 +444,10 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
   }
 
   if (po.target == "hhbc" || po.target == "run") {
-    Option::OutputHHBC = true;
     Option::AnalyzePerfectVirtuals = false;
   }
 
   Option::ProgramName = po.program;
-  Option::PreprocessedPartitionConfig = po.ppp;
 
   if (po.format.empty()) {
     if (po.target == "php") {
@@ -504,11 +472,7 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
   }
 
   if (po.optimizeLevel == -1) {
-    if (Option::OutputHHBC) {
-      po.optimizeLevel = 1;
-    } else {
-      po.optimizeLevel = 1;
-    }
+    po.optimizeLevel = 1;
   }
 
   // we always do pre/post opt no matter the opt level
@@ -517,11 +481,11 @@ int prepareOptions(CompilerOptions &po, int argc, char **argv) {
   if (po.optimizeLevel == 0) {
     // --optimize-level=0 is equivalent to --opts=none
     po.optimizations = "none";
-    if (Option::OutputHHBC) {
-      Option::ParseTimeOpts = false;
-    }
+    Option::ParseTimeOpts = false;
   }
 
+  initialize_hhbbc_options();
+
   return 0;
 }
 
@@ -563,9 +527,7 @@ int process(const CompilerOptions &po) {
   Package package(po.inputDir.c_str());
   ar = package.getAnalysisResult();
 
-  if (po.target == "hhbc" || po.target == "run") {
-    hhbcTargetInit(po, ar);
-  }
+  hhbcTargetInit(po, ar);
 
   std::string errs;
   if (!AliasManager::parseOptimizations(po.optimizations, errs)) {
@@ -580,17 +542,19 @@ int process(const CompilerOptions &po) {
 
   bool isPickledPHP = (po.target == "php" && po.format == "pickled");
   if (!isPickledPHP) {
-    if (!BuiltinSymbols::Load(ar,
-                              po.target == "hhbc" && !Option::WholeProgram)) {
-      return false;
-    }
+    bool wp = Option::WholeProgram;
+    Option::WholeProgram = false;
+    BuiltinSymbols::s_systemAr = ar;
+    hphp_process_init();
+    BuiltinSymbols::s_systemAr.reset();
+    Option::WholeProgram = wp;
     if (po.target == "hhbc" && !Option::WholeProgram) {
-      BuiltinSymbols::NoSuperGlobals = false;
+      // We're trying to produce the same bytecode as runtime parsing.
+      // There's nothing to do.
     } else {
-      ar->loadBuiltins();
-    }
-    if (!Option::SystemGen) {
-      hphp_process_init();
+      if (!BuiltinSymbols::Load(ar)) {
+        return false;
+      }
     }
   }
 
@@ -638,6 +602,7 @@ int process(const CompilerOptions &po) {
         return 1;
       }
       if (Option::WholeProgram || po.target == "analyze") {
+        Timer timer(Timer::WallTime, "analyzeProgram");
         ar->analyzeProgram();
       }
     }
@@ -691,7 +656,7 @@ int process(const CompilerOptions &po) {
         int runId = package.saveStatsToDB(server, seconds, po.branch,
                                           po.revision);
         package.commitStats(server, runId);
-      } catch (DatabaseException e) {
+      } catch (const DatabaseException& e) {
         Logger::Error("%s", e.what());
       }
     } else {
@@ -716,7 +681,7 @@ int lintTarget(const CompilerOptions &po) {
   for (unsigned int i = 0; i < po.inputs.size(); i++) {
     string filename = po.inputDir + "/" + po.inputs[i];
     try {
-      Scanner scanner(filename.c_str(), Option::ScannerType);
+      Scanner scanner(filename.c_str(), Option::GetScannerType());
       Compiler::Parser parser(scanner, filename.c_str(),
                               AnalysisResultPtr(new AnalysisResult()));
       if (!parser.parse()) {
@@ -842,11 +807,16 @@ void hhbcTargetInit(const CompilerOptions &po, AnalysisResultPtr ar) {
   if (po.format.find("exe") != string::npos) {
     RuntimeOption::RepoCentralPath += ".hhbc";
   }
+  unlink(RuntimeOption::RepoCentralPath.c_str());
   RuntimeOption::RepoLocalMode = "--";
   RuntimeOption::RepoDebugInfo = Option::RepoDebugInfo;
   RuntimeOption::RepoJournal = "memory";
   RuntimeOption::EnableHipHopSyntax = Option::EnableHipHopSyntax;
+  RuntimeOption::EnableZendCompat = Option::EnableZendCompat;
   RuntimeOption::EvalJitEnableRenameFunction = Option::JitEnableRenameFunction;
+
+  // Turn off commits, because we don't want systemlib to get included
+  RuntimeOption::RepoCommit = false;
 }
 
 int hhbcTarget(const CompilerOptions &po, AnalysisResultPtr ar,
@@ -878,7 +848,7 @@ int hhbcTarget(const CompilerOptions &po, AnalysisResultPtr ar,
   /* without this, emitClass allows classes with interfaces to be
      hoistable */
   SystemLib::s_inited = true;
-
+  RuntimeOption::RepoCommit = true;
   Option::AutoInline = -1;
 
   if (po.optimizeLevel > 0) {
@@ -905,11 +875,11 @@ int hhbcTarget(const CompilerOptions &po, AnalysisResultPtr ar,
      */
     string exe = po.outputDir + '/' + po.program;
     string repo = "repo=" + exe + ".hhbc";
-    char buf[PATH_MAX];
-    if (!realpath("/proc/self/exe", buf)) return -1;
+    string buf = current_executable_path();
+    if (buf.empty()) return -1;
 
     const char *argv[] = { "objcopy", "--add-section", repo.c_str(),
-                           buf, exe.c_str(), 0 };
+                           buf.c_str(), exe.c_str(), 0 };
     string out;
     ret = Process::Exec(argv[0], argv, nullptr, out, nullptr) ? 0 : 1;
   }
@@ -919,42 +889,6 @@ int hhbcTarget(const CompilerOptions &po, AnalysisResultPtr ar,
 
 ///////////////////////////////////////////////////////////////////////////////
 
-int buildTarget(const CompilerOptions &po) {
-  const char *HPHP_HOME = getenv("HPHP_HOME");
-  if (!HPHP_HOME || !*HPHP_HOME) {
-    throw Exception("Environment variable HPHP_HOME is not set.");
-  }
-  string cmd = string(HPHP_HOME) + "/hphp/legacy/run.sh";
-  string flags;
-  if (getenv("RELEASE"))      flags += "RELEASE=1 ";
-  if (getenv("SHOW_LINK"))    flags += "SHOW_LINK=1 ";
-  if (getenv("SHOW_COMPILE")) flags += "SHOW_COMPILE=1 ";
-  if (po.format == "lib")     flags += "HPHP_BUILD_LIBRARY=1 ";
-  const char *argv[] = {"", po.outputDir.c_str(),
-                        po.program.c_str(), flags.c_str(), nullptr};
-
-  if (getenv("SHOW_COMPILE")) {
-    Logger::Info ("Compile command: %s %s %s", po.outputDir.c_str(),
-        po.program.c_str(), flags.c_str());
-  }
-  Timer timer(Timer::WallTime, "compiling and linking CPP files");
-  string out, err;
-  bool ret = Process::Exec(cmd.c_str(), argv, nullptr, out, &err);
-  if (getenv("SHOW_COMPILE")) {
-    Logger::Info("%s", out.c_str());
-  } else {
-    Logger::Verbose("%s", out.c_str());
-  }
-  if (!err.empty()) {
-    Logger::Error("%s", err.c_str());
-  }
-  if (!ret) {
-    return 1;
-  }
-
-  return 0;
-}
-
 int runTargetCheck(const CompilerOptions &po, AnalysisResultPtr ar,
                    AsyncFileCacheSaver &fcThread) {
   // generate code
@@ -984,17 +918,20 @@ int runTarget(const CompilerOptions &po) {
   // run the executable
   string cmd;
   if (po.format.find("exe") == string::npos) {
-    char buf[PATH_MAX];
-    if (!realpath("/proc/self/exe", buf)) return -1;
+    string buf = current_executable_path();
+    if (buf.empty()) return -1;
 
     cmd += buf;
     cmd += " -vRepo.Authoritative=true";
+    if (getenv("HPHP_DUMP_BYTECODE")) cmd += " -vEval.DumpBytecode=1";
+    if (getenv("HPHP_INTERP"))        cmd += " -vEval.Jit=0";
     cmd += " -vRepo.Local.Mode=r- -vRepo.Local.Path=";
   }
   cmd += po.outputDir + '/' + po.program;
   cmd += string(" --file ") +
-    (po.inputs.size() == 1 ? po.inputs[0] : "") + po.programArgs;
-  Logger::Info("running executable %s...", cmd.c_str());
+    (po.inputs.size() == 1 ? po.inputs[0] : "") +
+    " " + po.programArgs;
+  Logger::Info("running executable: %s", cmd.c_str());
   ret = Util::ssystem(cmd.c_str());
   if (ret && ret != -1) ret = 1;
 

hphp/compiler/compiler.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |

hphp/compiler/construct.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,21 +14,21 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/construct.h>
-#include <compiler/parser/parser.h>
-#include <util/util.h>
+#include "hphp/compiler/construct.h"
+#include "hphp/compiler/parser/parser.h"
+#include "hphp/util/util.h"
 
-#include <compiler/analysis/file_scope.h>
-#include <compiler/analysis/function_scope.h>
-#include <compiler/analysis/class_scope.h>
-#include <compiler/analysis/analysis_result.h>
-#include <compiler/analysis/ast_walker.h>
+#include "hphp/compiler/analysis/file_scope.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/compiler/analysis/class_scope.h"
+#include "hphp/compiler/analysis/analysis_result.h"
+#include "hphp/compiler/analysis/ast_walker.h"
 
-#include <compiler/statement/function_statement.h>
+#include "hphp/compiler/statement/function_statement.h"
 
-#include <compiler/expression/simple_function_call.h>
-#include <compiler/expression/simple_variable.h>
-#include <compiler/expression/closure_expression.h>
+#include "hphp/compiler/expression/simple_function_call.h"
+#include "hphp/compiler/expression/simple_variable.h"
+#include "hphp/compiler/expression/closure_expression.h"
 #include <iomanip>
 
 using namespace HPHP;
@@ -44,7 +44,7 @@ void Construct::resetScope(BlockScopeRawPtr scope, bool resetOrigScope) {
   setBlockScope(scope);
   if (resetOrigScope) {
     ExpressionPtr expr =
-      boost::dynamic_pointer_cast<Expression>(shared_from_this());
+      dynamic_pointer_cast<Expression>(shared_from_this());
     if (expr) {
       expr->setOriginalScope(scope);
     }
@@ -439,7 +439,7 @@ public:
     // HACK: dump the closure function as a "child" of the
     // closure expression
     ClosureExpressionPtr c =
-      boost::dynamic_pointer_cast<ClosureExpression>(cp);
+      dynamic_pointer_cast<ClosureExpression>(cp);
     if (c) {
       c->getClosureFunction()->dump(m_spc, m_ar);
     }
@@ -454,7 +454,8 @@ private:
 
 void Construct::dump(int spc, AnalysisResultConstPtr ar) {
   ConstructDumper cd(spc, ar);
-  cd.walk(ConstructRawPtr(this), ConstructRawPtr(), ConstructRawPtr());
+  cd.walk(AstWalkerStateVec(ConstructRawPtr(this)),
+    ConstructRawPtr(), ConstructRawPtr());
 }
 
 void Construct::dump(int spc, AnalysisResultConstPtr ar, bool functionOnly,
@@ -468,9 +469,23 @@ void Construct::parseTimeFatal(Compiler::ErrorType err, const char *fmt, ...) {
   va_list ap;
   va_start(ap, fmt);
   string msg;
-  Util::string_vsnprintf(msg, fmt, ap);
+  string_vsnprintf(msg, fmt, ap);
   va_end(ap);
 
   if (err != Compiler::NoError) Compiler::Error(err, shared_from_this());
   throw ParseTimeFatalException(m_loc->file, m_loc->line0, "%s", msg.c_str());
 }
+
+void Construct::analysisTimeFatal(Compiler::ErrorType err,
+                                  const char *fmt, ...) {
+  va_list ap;
+  va_start(ap, fmt);
+  string msg;
+  string_vsnprintf(msg, fmt, ap);
+  va_end(ap);
+
+  assert(err != Compiler::NoError);
+  Compiler::Error(err, shared_from_this());
+  throw AnalysisTimeFatalException(m_loc->file, m_loc->line0,
+                                   "%s [analysis]", msg.c_str());
+}

hphp/compiler/construct.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,13 +14,13 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __CONSTRUCT_H__
-#define __CONSTRUCT_H__
+#ifndef incl_HPHP_CONSTRUCT_H_
+#define incl_HPHP_CONSTRUCT_H_
 
-#include <util/json.h>
-#include <compiler/code_generator.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/analysis/block_scope.h>
+#include "hphp/compiler/json.h"
+#include "hphp/compiler/code_generator.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/analysis/block_scope.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -67,7 +67,7 @@ public:
 /**
  * Base class of Expression and Statement.
  */
-class Construct : public boost::enable_shared_from_this<Construct>,
+class Construct : public std::enable_shared_from_this<Construct>,
                   public JSON::CodeError::ISerializable {
 protected:
   Construct(BlockScopePtr scope, LocationPtr loc);
@@ -178,7 +178,10 @@ public:
     return m_blockScope->getContainingClass();
   }
   void resetScope(BlockScopeRawPtr scope, bool resetOrigScope=false);
-  void parseTimeFatal(Compiler::ErrorType error, const char *fmt, ...);
+  void parseTimeFatal(Compiler::ErrorType error, const char *fmt, ...)
+    ATTRIBUTE_PRINTF(3,4);
+  void analysisTimeFatal(Compiler::ErrorType error, const char *fmt, ...)
+    ATTRIBUTE_PRINTF(3,4);
   virtual int getLocalEffects() const { return UnknownEffect;}
   int getChildrenEffects() const;
   int getContainedEffects() const;
@@ -186,15 +189,16 @@ public:
   virtual bool kidUnused(int i) const { return false; }
 
   template<typename T>
-  static boost::shared_ptr<T> Clone(boost::shared_ptr<T> constr) {
+  static std::shared_ptr<T> Clone(std::shared_ptr<T> constr) {
     if (constr) {
-      return boost::dynamic_pointer_cast<T>(constr->clone());
+      return dynamic_pointer_cast<T>(constr->clone());
     }
-    return boost::shared_ptr<T>();
+    return std::shared_ptr<T>();
   }
 
   template<typename T>
-  boost::shared_ptr<T> Clone(boost::shared_ptr<T> constr, BlockScopePtr scope) {
+  std::shared_ptr<T> Clone(std::shared_ptr<T> constr,
+                           BlockScopePtr scope) {
     if (constr) {
       constr = constr->clone();
       constr->resetScope(scope);
@@ -242,6 +246,11 @@ public:
                    const AstWalkerStateVec &start,
                    ConstructPtr endBefore, ConstructPtr endAfter);
 
+  /**
+   * Generates a serialized Code Model corresponding to this AST.
+   */
+  virtual void outputCodeModel(CodeGenerator &cg) = 0;
+
   /**
    * Called when generating code.
    */
@@ -314,7 +323,7 @@ public:
   int getLocalEffects() const { return m_localEffects; }
   virtual void effectsCallback() = 0;
 protected:
-  LocalEffectsContainer(Construct::Effect localEffect) :
+  explicit LocalEffectsContainer(Construct::Effect localEffect) :
     m_localEffects(localEffect) {}
   LocalEffectsContainer() :
     m_localEffects(0) {}
@@ -333,4 +342,4 @@ protected:
 
 ///////////////////////////////////////////////////////////////////////////////
 }
-#endif // __CONSTRUCT_H__
+#endif // incl_HPHP_CONSTRUCT_H_

hphp/compiler/expression/array_element_expression.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,17 +14,18 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/expression/array_element_expression.h>
-#include <compiler/expression/simple_variable.h>
-#include <compiler/expression/scalar_expression.h>
-#include <compiler/analysis/variable_table.h>
-#include <compiler/analysis/code_error.h>
-#include <compiler/option.h>
-#include <compiler/expression/static_member_expression.h>
-#include <compiler/analysis/function_scope.h>
-#include <util/parser/hphp.tab.hpp>
-#include <runtime/base/complex_types.h>
-#include <runtime/base/builtin_functions.h>
+#include "hphp/compiler/expression/array_element_expression.h"
+#include "hphp/compiler/expression/simple_variable.h"
+#include "hphp/compiler/expression/scalar_expression.h"
+#include "hphp/compiler/analysis/variable_table.h"
+#include "hphp/compiler/analysis/code_error.h"
+#include "hphp/compiler/code_model_enums.h"
+#include "hphp/compiler/option.h"
+#include "hphp/compiler/expression/static_member_expression.h"
+#include "hphp/compiler/analysis/function_scope.h"
+#include "hphp/parser/hphp.tab.hpp"
+#include "hphp/runtime/base/complex-types.h"
+#include "hphp/runtime/base/builtin-functions.h"
 
 using namespace HPHP;
 
@@ -167,16 +168,6 @@ void ArrayElementExpression::analyzeProgram(AnalysisResultPtr ar) {
   m_variable->analyzeProgram(ar);
   if (m_offset) m_offset->analyzeProgram(ar);
   if (ar->getPhase() == AnalysisResult::AnalyzeFinal) {
-    if (!m_global && (m_context & AccessContext) &&
-        !(m_context & (LValue|RefValue|DeepReference|
-                       UnsetContext|RefParameter|InvokeArgument))) {
-      TypePtr type = m_variable->getActualType();
-      if (!type ||
-          (!type->is(Type::KindOfString) && !type->is(Type::KindOfArray))) {
-        FunctionScopePtr scope = getFunctionScope();
-        if (scope && !needsCSE()) scope->setNeedsRefTemp();
-      }
-    }
     if (m_global) {
       if (getContext() & (LValue|RefValue|DeepReference)) {
         setContext(NoLValueWrapper);
@@ -191,8 +182,6 @@ void ArrayElementExpression::analyzeProgram(AnalysisResultPtr ar) {
                           shared_from_this());
         }
       }
-      FunctionScopePtr scope = getFunctionScope();
-      if (scope) scope->setNeedsCheckMem();
     } else {
       TypePtr at(m_variable->getActualType());
       TypePtr et(m_variable->getExpectedType());
@@ -229,10 +218,10 @@ int ArrayElementExpression::getKidCount() const {
 void ArrayElementExpression::setNthKid(int n, ConstructPtr cp) {
   switch (n) {
     case 0:
-      m_variable = boost::dynamic_pointer_cast<Expression>(cp);
+      m_variable = dynamic_pointer_cast<Expression>(cp);
       break;
     case 1:
-      m_offset = boost::dynamic_pointer_cast<Expression>(cp);
+      m_offset = dynamic_pointer_cast<Expression>(cp);
       break;
     default:
       assert(false);
@@ -257,6 +246,14 @@ ExpressionPtr ArrayElementExpression::preOptimize(AnalysisResultConstPtr ar) {
           return replaceValue(makeConstant(ar, "null"));
         }
         if (m_offset->isScalar() && m_offset->getScalarValue(o)) {
+          if (v.isString()) {
+            if (!o.isInteger() ||
+                o.toInt64Val() < 0 ||
+                o.toInt64Val() >= v.toCStrRef().size()) {
+              // warnings should be raised...
+              return ExpressionPtr();
+            }
+          }
           try {
             g_context->setThrowAllErrors(true);
             Variant res = v.rvalAt(
@@ -392,6 +389,42 @@ ExpressionPtr ArrayElementExpression::unneeded() {
   return Expression::unneeded();
 }
 
+///////////////////////////////////////////////////////////////////////////////
+
+void ArrayElementExpression::outputCodeModel(CodeGenerator &cg) {
+  if (Option::ConvertSuperGlobals && m_global && !m_dynamicGlobal &&
+      getScope() && (getScope()->is(BlockScope::ProgramScope) ||
+                     getScope()-> getVariables()->
+                     isConvertibleSuperGlobal(m_globalName))) {
+    cg.printObjectHeader("SimpleVariableExpression", 2);
+    cg.printPropertyHeader("name");
+    cg.printValue(m_globalName);
+    cg.printPropertyHeader("sourceLocation");
+    cg.printLocation(this->getLocation());
+    cg.printObjectFooter();
+  } else if (m_offset) {
+    cg.printObjectHeader("BinaryOpExpression", 4);
+    cg.printPropertyHeader("expression1");
+    m_variable->outputCodeModel(cg);
+    cg.printPropertyHeader("expression2");
+    cg.printExpression(m_offset, false);
+    cg.printPropertyHeader("operation");
+    cg.printValue(PHP_ARRAY_ELEMENT);
+    cg.printPropertyHeader("sourceLocation");
+    cg.printLocation(this->getLocation());
+    cg.printObjectFooter();
+  } else {
+    cg.printObjectHeader("UnaryOpExpression", 3);
+    cg.printPropertyHeader("expression");
+    m_variable->outputCodeModel(cg);
+    cg.printPropertyHeader("operation");
+    cg.printValue(PHP_ARRAY_APPEND_POINT_OP);
+    cg.printPropertyHeader("sourceLocation");
+    cg.printLocation(this->getLocation());
+    cg.printObjectFooter();
+  }
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // code generation functions
 

hphp/compiler/expression/array_element_expression.h

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,10 +14,10 @@
    +----------------------------------------------------------------------+
 */
 
-#ifndef __ARRAY_ELEMENT_EXPRESSION_H__
-#define __ARRAY_ELEMENT_EXPRESSION_H__
+#ifndef incl_HPHP_ARRAY_ELEMENT_EXPRESSION_H_
+#define incl_HPHP_ARRAY_ELEMENT_EXPRESSION_H_
 
-#include <compiler/expression/expression.h>
+#include "hphp/compiler/expression/expression.h"
 
 namespace HPHP {
 ///////////////////////////////////////////////////////////////////////////////
@@ -70,4 +70,4 @@ private:
 ///////////////////////////////////////////////////////////////////////////////
 }
 
-#endif // __ARRAY_ELEMENT_EXPRESSION_H__
+#endif // incl_HPHP_ARRAY_ELEMENT_EXPRESSION_H_

hphp/compiler/expression/array_pair_expression.cpp

@@ -2,7 +2,7 @@
    +----------------------------------------------------------------------+
    | HipHop for PHP                                                       |
    +----------------------------------------------------------------------+
-   | Copyright (c) 2010- Facebook, Inc. (http://www.facebook.com)         |
+   | Copyright (c) 2010-2013 Facebook, Inc. (http://www.facebook.com)     |
    +----------------------------------------------------------------------+
    | This source file is subject to version 3.01 of the PHP license,      |
    | that is bundled with this package in the file LICENSE, and is        |
@@ -14,10 +14,11 @@
    +----------------------------------------------------------------------+
 */
 
-#include <compiler/expression/array_pair_expression.h>
-#include <compiler/expression/scalar_expression.h>
-#include <compiler/expression/unary_op_expression.h>
-#include <util/parser/hphp.tab.hpp>
+#include "hphp/compiler/expression/array_pair_expression.h"
+#include "hphp/compiler/expression/scalar_expression.h"
+#include "hphp/compiler/expression/unary_op_expression.h"
+#include "hphp/compiler/code_model_enums.h"
+#include "hphp/parser/hphp.tab.hpp"
 
 using namespace HPHP;
 
@@ -94,10 +95,10 @@ int ArrayPairExpression::getKidCount() const {
 void ArrayPairExpression::setNthKid(int n, ConstructPtr cp) {
   switch (n) {
     case 0:
-      m_name = boost::dynamic_pointer_cast<Expression>(cp);
+      m_name = dynamic_pointer_cast<Expression>(cp);
       break;
     case 1:
-      m_value = boost::dynamic_pointer_cast<Expression>(cp);
+      m_value = dynamic_pointer_cast<Expression>(cp);
       break;
     default:
       assert(false);
@@ -122,6 +123,25 @@ bool ArrayPairExpression::canonCompare(ExpressionPtr e) const {
   return m_ref == a->m_ref;
 }
 
+///////////////////////////////////////////////////////////////////////////////
+
+void ArrayPairExpression::outputCodeModel(CodeGenerator &cg) {
+  if (m_name) {
+    cg.printObjectHeader("BinaryOpExpression", 4);
+    cg.printPropertyHeader("expression1");
+    m_name->outputCodeModel(cg);
+    cg.printPropertyHeader("expression2");
+    cg.printExpression(m_value, m_ref);
+    cg.printPropertyHeader("operation");
+    cg.printValue(PHP_ARRAY_PAIR);
+    cg.printPropertyHeader("sourceLocation");
+    cg.printLocation(this->getLocation());
+    cg.printObjectFooter();
+  } else {
+    cg.printExpression(m_value, m_ref);
+  }
+  return;
+}
 
 ///////////////////////////////////////////////////////////////////////////////
 // code generation functions